Context Navigation

← Previous Period
Next Period →

Timeline

Aug 24, 2011:

11:58 PM Changeset in webkit [93762] by morrita@google.com

14 edits
4 adds in trunk

Implement an Event constructor.
https://bugs.webkit.org/show_bug.cgi?id=66756

Patch by Kentaro Hara <haraken@google.com> on 2011-08-24
Reviewed by Adam Barth.

The spec of the Event constructor is here:
http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-event-constructor.
This patch added the Event constructor to EventConstructors.h using
JavaScript implementation-independent macros. This patch also added the V8
implementation of these macros to V8EventConstructors.cpp.

Source/WebCore:

The bug 63878 has been implementing the Event constructors for JSC.
Our plan is to first implement all the Event constructors for V8
using EventConstructors.h proposed in the JSC patch, and then merge
the JSC patch with these V8 patches. In any case, we are going to split
the patches for V8 and those for JSC in order to avoid hard regression.

Test: fast/events/event-constructors.html

WebCore.gypi: Added V8EventConstructors.cpp.
WebCore.pro: Added V8EventConstructors.cpp.
bindings/generic/EventConstructors.h: Added. The Event constructor. This is written using JavaScript implementation-independent macros. The V8 implementation of these macros is written in bindings/v8/custom/V8EventConstructors.cpp.
bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::getKeyDouble): Returns the value of a given key of type double.
(WebCore::OptionsObject::getKey): Returns true whenever the given key is found, even if the value is null or undefined.

bindings/v8/OptionsObject.h:

(WebCore::OptionsObject::getKeyValue): Returns the value of the given key. We need to overload getKeyValue() for all types required to EventConfiguration members.

bindings/v8/custom/V8EventConstructors.cpp: Added. Implemented macros used in EventConstructors.h.

(WebCore::constructV8Event): The Event constructor.

dom/Event.cpp:

(WebCore::EventConfiguration::EventConfiguration): A constructor of EventConfiguration.
(WebCore::Event::Event): A constructor of the Event class.

dom/Event.h: Added EventConfiguration, which manages attributes of the Event class.

(WebCore::Event::create): A factory method of the Event class with EventConfiguration.

dom/Event.idl: Added 'CanBeConstructed' and 'V8CustomConstructor'.

LayoutTests:

fast/events/event-constructors-expected.txt: Added.
fast/events/event-constructors.html: Added.
platform/gtk/Skipped: Skipped event-constructors.html, since Event constructors are not yet implemented in JSC.
platform/mac/Skipped: Ditto.
platform/qt/Skipped: Ditto.
platform/win/Skipped: Ditto.
platform/wk2/Skipped: Ditto.

11:06 PM Changeset in webkit [93761] by Philippe Normand

5 edits in trunk

[GTK] bump GStreamer requirement to 0.10.30
https://bugs.webkit.org/show_bug.cgi?id=66860

Reviewed by Martin Robinson.

configure.ac:

WebCore:

[GTK] bump GStreamer requirement to 0.10.30
https://bugs.webkit.org/show_bug.cgi?id=66860

Reviewed by Martin Robinson.

Use fast element linking by default.

platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::enterFullscreen):
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

11:02 PM BuildingGtk edited by Philippe Normand

(diff)

10:50 PM Changeset in webkit [93760] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Some layerTreeAsText compositing tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=66913

Patch by James Robinson <jamesr@chromium.org> on 2011-08-24
Reviewed by Simon Fraser.

Remove compositingLayerUpdatePending() and unconditionally update compositing layers when
RenderLayerCompositor::layerTreeAsText(). compositingLayerUpdatePending() was only used by test code and is
unreliable.

Covered by compositing/ layerTreeAsText tests.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):

rendering/RenderLayerCompositor.h:

10:31 PM Changeset in webkit [93759] by commit-queue@webkit.org

18 edits
2 moves
2 deletes in trunk

Implement a keypath parser strictly following the specification
https://bugs.webkit.org/show_bug.cgi?id=62288

Patch by Kentaro Hara <haraken@google.com> on 2011-08-24
Reviewed by Tony Chang.

Source/WebCore:

Implemented a keypath parser that accepts either an empty string, a JavaScript
identifier, or multiple JavaScript identifiers separated by periods.
We fixed createObjectStore() and createIndex() so that they parse and check
their |keypath| argument and return an appropriate exception if the |keypath|
is not valid. We also added unit tests for the new keypath parser in keypath-basics.html.

Tests: storage/indexeddb/keypath-fetch-key.html

storage/indexeddb/keypath-basics.html

bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromSerializedValueAndKeyPath): Replaced IDBKeyPathElement with String
(WebCore::injectIDBKeyIntoSerializedValue): Replaced IDBKeyPathElement with String

bindings/v8/IDBBindingUtilities.h:
bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::getKeyStringWithUndefinedOrNullCheck): Returns false when a given value is null or undefined
(WebCore::OptionsObject::getKey): Removed undefined check

storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore): Checks if a |keypath| argument is valid, and returns a NON_TRANSIENT_ERR if it is not valid

storage/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::createObjectStore): Removed null check of a keypath

storage/IDBKeyPath.cpp:

(WebCore::IDBKeyPathLexer::currentElement): Part of the keypath parser
(WebCore::IDBKeyPathLexer::lex): Part of the keypath parser
(WebCore::IDBKeyPathLexer::lexIdentifier): Part of the keypath parser
(WebCore::IDBIsValidKeyPath): Checks if a keypath is valid
(WebCore::IDBParseKeyPath): Part of the keypath parser

storage/IDBKeyPath.h: Replaced IDBKeyPathElement with String
storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex): Checks if a |keypath| argument is valid, and returns a NON_TRANSIENT_ERR if it is not valid

storage/IDBObjectStore.idl:

Source/WebKit/chromium:

Tests: IDBKeyPathTest.*

IDBKeyFromValueAndKeyPathTest.*
InjectIDBKeyTest.*

public/WebIDBKeyPath.h:
src/WebIDBKeyPath.cpp:

(WebKit::WebIDBKeyPath::create): Replaced IDBKeyPathElement with String
(WebKit::WebIDBKeyPath::WebIDBKeyPath): Replaced IDBKeyPathElement with String
(WebKit::WebIDBKeyPath::assign): Replaced IDBKeyPathElement with String
(WebKit::WebIDBKeyPath::operator const WTF::Vector<WTF::String, 0>&): Replaced IDBKeyPathElement with String

tests/IDBBindingUtilitiesTest.cpp:

(WebCore::checkKeyFromValueAndKeyPathInternal): Replaced IDBKeyPathElement with String
(WebCore::injectKey): Replaced IDBKeyPathElement with String
(WebCore::TEST): Rewrote tests for the new keypath parser

tests/IDBKeyPathTest.cpp:

(WebCore::checkKeyPath): Checks if a keypath is an expected keypath or not
(WebCore::TEST): Unit tests for the new keypath parser

LayoutTests:

Implemented a keypath parser that accepts either an empty string, a JavaScript
identifier, or multiple JavaScript identifiers separated by periods.
We fixed createObjectStore() and createIndex() so that they parse and check
their |keypath| argument and return an appropriate exception if the |keypath|
is not valid. We removed create-index-null-name.html since this test violates the
specification that says "a |keypath| argument of createIndex() must not be nullable".

storage/indexeddb/keypath-basics-expected.txt:
storage/indexeddb/keypath-basics.html:
storage/indexeddb/keypath-fetch-key-expected.txt: Renamed from LayoutTests/storage/indexeddb/keyPath-expected.txt.
storage/indexeddb/keypath-fetch-key.html: Renamed from LayoutTests/storage/indexeddb/keyPath.html.
storage/indexeddb/mozilla/create-index-null-name-expected.txt: Removed.
storage/indexeddb/mozilla/create-index-null-name.html: Removed.

8:35 PM Changeset in webkit [93758] by abarth@webkit.org

5 edits in trunk/Tools

The user can't close the details view in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=66911

Reviewed by Dimitri Glazkov.

In addition to adding a close button, this patch changes the test
selector to use a <select> element and refactors the test selector to
share code with the builder selector.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:

7:38 PM Changeset in webkit [93757] by jamesr@google.com

2 edits in trunk/LayoutTests

[chromium] Remove expected CRASH lines for tests that don't crash

platform/chromium/test_expectations.txt:

7:30 PM Changeset in webkit [93756] by jamesr@google.com

2 edits in trunk/LayoutTests

[chromium] Remove expected failure lines from tests that work now.

platform/chromium/test_expectations.txt:

6:25 PM Changeset in webkit [93755] by commit-queue@webkit.org

9 edits in trunk/Source/JavaScriptCore

Keep track of topCallFrame for Stack traces
https://bugs.webkit.org/show_bug.cgi?id=66571

Patch by Juan C. Montemayor <jmont@apple.com> on 2011-08-24
Reviewed by Geoffrey Garen.

This patch adds a TopCallFrame to JSC in order to have that information
when an error is thrown to create a stack trace. The TopCallFrame is
updated throughout select points in the Interpreter and the JSC.

interpreter/Interpreter.cpp:

(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::privateExecute):

interpreter/Interpreter.h:

(JSC::TopCallFrameSetter::TopCallFrameSetter):
(JSC::TopCallFrameSetter::~TopCallFrameSetter):

jit/JIT.h:
jit/JITInlineMethods.h:

(JSC::JIT::updateTopCallFrame):

jit/JITStubCall.h:

(JSC::JITStubCall::call):

jit/JITStubs.cpp:

(JSC::throwExceptionFromOpCall):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::arityCheckFor):

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

runtime/JSGlobalData.h:

6:23 PM Changeset in webkit [93754] by msaboff@apple.com

2 edits in trunk/Source/WebKit2

Improper comment in CoreIPC/ArgumentEncoder.cpp from 66464
https://bugs.webkit.org/show_bug.cgi?id=66912

Updated the comment in ArgumentEncoder::grow to reflect that system malloc
currently checks to see if a MADV_FREE_REUSABLE will fail before calling it.

Reviewed by Mark Rowe.

Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::grow):

6:05 PM Changeset in webkit [93753] by jamesr@google.com

1 edit
3 adds in trunk/LayoutTests

[chromium] Update chromium mac baselines for fast/repaint/japanese-rl-selection-repaint-in-regions.html

platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
platform/chromium/test_expectations.txt:

6:02 PM Changeset in webkit [93752] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Mark a test as flaky.

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

6:02 PM Changeset in webkit [93751] by commit-queue@webkit.org

2 edits in trunk/Tools

[chromium] Stacktrace not in test output when a test crashes
https://bugs.webkit.org/show_bug.cgi?id=66806

Patch by James Robinson <jamesr@chromium.org> on 2011-08-24
Reviewed by Dirk Pranke.

Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
trace.

Scripts/webkitpy/layout_tests/port/chromium.py:

5:59 PM Changeset in webkit [93750] by ericu@chromium.org

7 edits in trunk/Source

Reviewed by Adam Barth.

[filesystem/Chromium] Filesystem paths need proper URL escaping
https://bugs.webkit.org/show_bug.cgi?id=62811

Fix http://code.google.com/p/chromium/issues/detail?id=78860 by making
KURLChromium.cpp's escaping code actually work.

Source/WebCore:

Make encodeWithURLEscapeSequences call into googleurl to do proper
escaping. Tested in WebKit/chromium/tests/KURLTest.cpp.

platform/KURLGoogle.cpp:

(WebCore::encodeWithURLEscapeSequences):

Source/WebKit/chromium:

Here I added the needed calls to encodeWithURLEscapeSequences.

src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystemChromium::virtualPathToFileSystemURL):

src/WorkerAsyncFileSystemChromium.cpp:

(WebCore::WorkerAsyncFileSystemChromium::virtualPathToFileSystemURL):

Here I updated the test to reflect the new functionality in
encodeWithURLEscapeSequences.

tests/KURLTest.cpp:

5:35 PM Changeset in webkit [93749] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Resolve potential integer overflow in memory allocation, and ensure
that allocation succeeds.

Patch by Chris Palmer <palmer@google.com> on 2011-08-24
Reviewed by Kenneth Russell.

platform/audio/AudioArray.h:

(WebCore::AudioArray::allocate): Check for integer overflow.
(WebCore::AudioArray::at): Document the safety assertion.
(WebCore::AudioArray::zero): Document the safety assertion.
(WebCore::AudioArray::zeroRange): Document the safety assertion.
(WebCore::AudioArray::copyToRange): Document the safety assertion.

4:04 PM Changeset in webkit [93748] by pkasting@chromium.org

2 edits
2 deletes in trunk/LayoutTests

[chromium] Update expectations after r93728 and r93737.

Unreviewed, test expectations update.

platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
platform/chromium/test_expectations.txt:

4:01 PM Changeset in webkit [93747] by isherman@chromium.org

10 edits
1 delete in trunk/Source/WebKit/chromium

Remove some dead Autofill code
https://bugs.webkit.org/show_bug.cgi?id=66899
http://code.google.com/p/chromium/issues/detail?id=51644

Reviewed by James Robinson.

WebKit.gyp:
public/WebAutofillClient.h:
public/WebFrame.h:
public/WebPasswordAutocompleteListener.h: Removed.
src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::EditorClientImpl):
(WebKit::EditorClientImpl::handleKeyboardEvent):
(WebKit::EditorClientImpl::textFieldDidBeginEditing):
(WebKit::EditorClientImpl::textFieldDidEndEditing):
(WebKit::EditorClientImpl::textDidChangeInTextField):
(WebKit::EditorClientImpl::doTextFieldCommandFromEvent):

src/EditorClientImpl.h:
src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDidFinishDocumentLoad):

src/WebFrameImpl.cpp:

(WebKit::frameContentAsPlainText):
(WebKit::WebFrameImpl::scopeStringMatches):
(WebKit::WebFrameImpl::~WebFrameImpl):

src/WebFrameImpl.h:
src/WebViewImpl.cpp:

(WebKit::WebViewImpl::mouseDown):

3:55 PM WikiStart edited by mjs@apple.com

(diff)

3:44 PM Changeset in webkit [93746] by Patrick Gansterer

2 edits in trunk/Source/WebCore

[EFL] Fix build with ENABLE_GEOLOCATION.
https://bugs.webkit.org/show_bug.cgi?id=66881

Use adoptPtr() to create a new GeolocationService instance, otherwise
the build will fail when creating the PassOwnPtr object.

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-24

platform/efl/GeolocationServiceEfl.cpp:

(WebCore::GeolocationServiceEfl::create):

3:35 PM Changeset in webkit [93745] by dbates@webkit.org

1 edit
2 adds in trunk/LayoutTests

XSS filter bypass via document.write(location.href) and fragments
https://bugs.webkit.org/show_bug.cgi?id=66585

Reviewed by Darin Adler.

Add a test case for a variation of a DOM-based XSS attack using an anchor URL.

http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt: Added.
http/tests/security/xssAuditor/anchor-url-dom-write-location2.html: Added.

3:28 PM Changeset in webkit [93744] by Patrick Gansterer

2 edits in trunk/Source/WebCore

[CMake] Fix build with ENABLE_BLOB or ENABLE_FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=66880

Generate and build some additional files required by these options.

No new tests, as this is a build fix for some build options.

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-24

CMakeLists.txt:

3:09 PM Changeset in webkit [93743] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[chromium] Don't call glDeleteTexture(0) in TextureManager
https://bugs.webkit.org/show_bug.cgi?id=66862

Delete(0) is allowed in standard OpenGL, but not in Chrome.
See http://code.google.com/p/chromium/issues/detail?id=85268

Patch by Iain Merrick <husky@google.com> on 2011-08-24
Reviewed by James Robinson.

platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::deleteEvictedTextures):

3:07 PM Changeset in webkit [93742] by jamesr@google.com

2 edits in trunk/LayoutTests

[chromium] Update expectations for tests that no longer crash.

platform/chromium/test_expectations.txt:

3:05 PM Changeset in webkit [93741] by abarth@webkit.org

1 edit
1 delete in trunk/Tools

Remove empty directory.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.

2:56 PM Changeset in webkit [93740] by enne@google.com

2 edits in trunk/Source/WebCore

[chromium] Properly initialize CCTiledLayerImpl::m_skipsDraw
https://bugs.webkit.org/show_bug.cgi?id=66889

Reviewed by James Robinson.

platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::CCTiledLayerImpl):

2:35 PM Changeset in webkit [93739] by cevans@google.com

3 edits in branches/chromium/835

Merge 93732
BUG=94011
Review URL: http://codereview.chromium.org/7734002

2:33 PM Changeset in webkit [93738] by abarth@webkit.org

6 edits in trunk/Tools

Finish writing up details-view in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=66891

Reviewed by Dimitri Glazkov.

This patch mostly just copies a bunch of CSS from main.css to
summary.css. Presumably we'll delete main.css soon.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:

2:27 PM Changeset in webkit [93737] by jamesr@google.com

4 edits in trunk

Some compositing LayoutTests flakily crashing on Mac 10.6
https://bugs.webkit.org/show_bug.cgi?id=66740

Reviewed by Adam Barth.

Tools:

Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
chromium configuration.

DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_Destroy):

LayoutTests:

Remove = CRASH expectations for plugin tests that should no longer crash.

platform/chromium/test_expectations.txt:

2:25 PM Changeset in webkit [93736] by cevans@google.com

1 edit
4 copies in branches/chromium/835

Merge 93521
BUG=89219
Review URL: http://codereview.chromium.org/7727007

2:20 PM Changeset in webkit [93735] by adauria@apple.com

2 edits in trunk/Tools

No review necessary.

Adding myself to list of committers.

2:06 PM Changeset in webkit [93734] by commit-queue@webkit.org

8 edits
1 add in trunk/Source

Source/WebCore: chromium WebFrameImpl - don't load javascript URLs against chrome internal
pages. Adds a mechanism for registering sensitive schemes which should
not be subject to manipulation by javascript urls typed into a location bar
or, more importantly, their bookmarklet equivalents.
https://bugs.webkit.org/show_bug.cgi?id=66720

Patch by Tom Sepez <tsepez@chromium.org> on 2011-08-24
Reviewed by Adam Barth.

Test: Chromium WebKit API unit test in chromium specific directory.

platform/SchemeRegistry.cpp:

(WebCore::notAllowingJavascriptURLsSchemes):
(WebCore::SchemeRegistry::registerURLSchemeAsNotAllowingJavascriptURLs):
(WebCore::SchemeRegistry::shouldTreatURLSchemeAsNotAllowingJavascriptURLs):

platform/SchemeRegistry.h:

Source/WebKit/chromium: chromium WebFrameImpl - don't load javascript URLs against chrome internal pages.
https://bugs.webkit.org/show_bug.cgi?id=66720

Patch by Tom Sepez <tsepez@chromium.org> on 2011-08-24
Reviewed by Adam Barth.

public/WebSecurityPolicy.h:
src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::loadJavaScriptURL):

src/WebSecurityPolicy.cpp:

(WebKit::WebSecurityPolicy::registerURLSchemeAsNotAllowingJavascriptURLs):

tests/WebFrameTest.cpp:

(WebKit::WebFrameTest::WebFrameTest):
(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
(WebKit::WebFrameTest::serveRequests):
(WebKit::WebFrameTest::loadHttpFrame):
(WebKit::WebFrameTest::loadChromeFrame):
(WebKit::WebFrameTest::registerMockedURLLoad):
(WebKit::WebFrameTest::loadFrame):
(WebKit::TEST_F):

tests/data/history.html: Added.

1:39 PM Changeset in webkit [93733] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] More test expectation updates.

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

1:36 PM Changeset in webkit [93732] by ap@apple.com

5 edits in trunk

Plug-in tests are flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=66822

Reviewed by Anders Carlsson.

Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): Protect objects that can be removed by a script.

WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto. (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): Ditto. Also fixed some nonsense code.

1:31 PM Changeset in webkit [93731] by Lucas Forschler

5 edits in branches/safari-534.51-branch/Source

Versioning.

1:30 PM Changeset in webkit [93730] by Lucas Forschler

1 copy in tags/Safari-534.51.18

New tag.

1:27 PM Changeset in webkit [93729] by scherkus@chromium.org

2 edits in branches/chromium/835/LayoutTests/platform

Merge 93715: rebaselining media/video-currentTime-set.html

1:20 PM Changeset in webkit [93728] by commit-queue@webkit.org

5 edits
11 adds in trunk

[CSSRegions] Fix Element::getBoundingClientRect and Element::getClientRects for content flow
https://bugs.webkit.org/show_bug.cgi?id=66641

Original author of the patch is Mihnea Ovidenie <mihnea@adobe.com>.

Source/WebCore:

Redirected the mapLocalToContainer method to the appropriate RenderRegion.

Note: RenderObject::absoluteQuads method needs some refactor to support multiple regions,
will do that in a separate bug.

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-24
Reviewed by David Hyatt.

Tests: fast/regions/flowed-content-bounding-client-rect-horizontal-bt.html

fast/regions/flowed-content-bounding-client-rect-vertical-rl.html
fast/regions/flowed-content-bounding-client-rect-vertical.html
fast/regions/flowed-content-bounding-client-rect.html
fast/regions/flowed-content-transform-bounding-client-rect.html

rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer):

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::renderRegionForLine):
(WebCore::RenderFlowThread::mapFromFlowToRegion):

rendering/RenderFlowThread.h:

LayoutTests:

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-24
Reviewed by David Hyatt.

fast/regions/flowed-content-bounding-client-rect-expected.txt: Added.
fast/regions/flowed-content-bounding-client-rect-horizontal-bt-expected.txt: Added.
fast/regions/flowed-content-bounding-client-rect-horizontal-bt.html: Added.
fast/regions/flowed-content-bounding-client-rect-vertical-expected.txt: Added.
fast/regions/flowed-content-bounding-client-rect-vertical-rl-expected.txt: Added.
fast/regions/flowed-content-bounding-client-rect-vertical-rl.html: Added.
fast/regions/flowed-content-bounding-client-rect-vertical.html: Added.
fast/regions/flowed-content-bounding-client-rect.html: Added.
fast/regions/flowed-content-transform-bounding-client-rect-expected.txt: Added.
fast/regions/flowed-content-transform-bounding-client-rect.html: Added.
fast/regions/resources/helper.js: Added.

(rectToArray):
(areEqualNumbers):
(areEqualRects):
(assertEqualRects):
(testBoundingRects):

1:17 PM Changeset in webkit [93727] by alokp@chromium.org

3 edits in trunk/Source/WebCore

[chromium] Root layer is not updated when only a portion of tile is updated
https://bugs.webkit.org/show_bug.cgi?id=66506

This only happened in the accelerated path which changes stencil state.
Incorrect stencil state was used to draw the root layer.

Reviewed by James Robinson.

Test: compositing/overflow/overflow-scroll.html (existing)

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersInternal):

platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):

1:16 PM Changeset in webkit [93726] by Nate Chapin

3 edits
3 adds in trunk

2011-08-24 Nate Chapin <Nate Chapin>

Fix an intermittent crash in EventSource, when a
reconnect timer triggers after a navigation
away from the current page begins.
https://bugs.webkit.org/show_bug.cgi?id=45202

Reviewed by Alexey Proskuryakov.

Test: http/tests/eventsource/eventsource-reconnect-during-navigate-crash.html

page/EventSource.cpp: (WebCore::EventSource::connect): Don't set m_requestInFlight

to true if ThreadableLoader::create() failed.

1:08 PM Changeset in webkit [93725] by reed@google.com

2 edits in trunk/Source/WebCore

Change clip routine to promote the clipbounds up to (local) floats and then perform the intersection,
rather than rounding the srcRect down to integers.
https://bugs.webkit.org/show_bug.cgi?id=66810

Reviewed by Kenneth Russell.

No new tests. Existing tests that resize images will exercise this code path

platform/graphics/skia/SkiaUtils.cpp:

(WebCore::ClipRectToCanvas):

1:04 PM Changeset in webkit [93724] by commit-queue@webkit.org

2 edits in trunk/Tools

Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
https://bugs.webkit.org/show_bug.cgi?id=66875

Patch by Avi Drissman <avi@google.com> on 2011-08-24
Reviewed by James Robinson.

DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:

(WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):

1:02 PM Changeset in webkit [93723] by andersca@apple.com

4 edits in trunk/Source/WebKit2

Rename -[WKTextInputWindowController keyboardInputSourceChanged] to unmarkText to indicate what the method does
https://bugs.webkit.org/show_bug.cgi?id=66883

Reviewed by Beth Dakin.

UIProcess/API/mac/WKTextInputWindowController.h:
UIProcess/API/mac/WKTextInputWindowController.mm:

(-[WKTextInputPanel _unmarkText]):
(-[WKTextInputWindowController unmarkText]):

UIProcess/API/mac/WKView.mm:

(-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]):

12:56 PM Changeset in webkit [93722] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Test expectation updates.

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

12:53 PM Changeset in webkit [93721] by commit-queue@webkit.org

3 edits
3 adds in trunk

[CSSRegions] RenderRegion is not used if there's another renderer after it
https://bugs.webkit.org/show_bug.cgi?id=66844

Source/WebCore:

There was no call to attachRegion in RenderObjectChildList::insertChildNode, so
the region was not added to the RenderFlowThread.

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-24
Reviewed by David Hyatt.

Test: fast/regions/content-flowed-into-regions-dynamically-inserted.html

rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::insertChildNode):

LayoutTests:

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-24
Reviewed by David Hyatt.

fast/regions/content-flowed-into-regions-dynamically-inserted-expected.png: Added.
fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Added.
fast/regions/content-flowed-into-regions-dynamically-inserted.html: Added.

12:34 PM Changeset in webkit [93720] by oliver@apple.com

5 edits in trunk/Source/WebKit2

JSNPObject and JSNPMethod create their structure in their constructors
https://bugs.webkit.org/show_bug.cgi?id=66879

Reviewed by Anders Carlsson.

It's not safe to create the Structure for an object inside its constructor
so we hoist construction out into their ::create methods and move the methods
into the cpp file.

WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::JSNPMethod::JSNPMethod):
(WebKit::JSNPMethod::create):

WebProcess/Plugins/Netscape/JSNPMethod.h:

(WebKit::JSNPMethod::create):

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::JSNPObject):
(WebKit::JSNPObject::create):

WebProcess/Plugins/Netscape/JSNPObject.h:

(WebKit::JSNPObject::create):

12:32 PM Changeset in webkit [93719] by Lucas Forschler

4 edits in trunk/WebKitLibraries

Update SVN properties to help out the Windows EWS bots.

Reviewed by Adam Roben.

win: Modified properties svn:ignore.
win/include: Modified property svn:ignore.
win/lib: Modified property svn:ignore.

12:06 PM Changeset in webkit [93718] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Organize SLOW section of expectations.

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

11:28 AM Changeset in webkit [93717] by weinig@apple.com

2 edits in trunk/Source/WebCore

JSHTMLImageElement (and associated Node) is abandoned when image load is canceled
<rdar://problem/9925630>
https://bugs.webkit.org/show_bug.cgi?id=66864

Reviewed by Anders Carlsson.

In the JSC bindings, we use HTMLImageElement::hasPendingActivity() (which in turn calls
HTMLImageLoader::haveFiredLoadEvent()) to reason about the liveness of JSHTMLImageElements.
In the case that an image load is canceled, the haveFiredLoadEvent never true, so the
JSHTMLImageElement is kept alive forever (and since it references the global object, it
keeps the entire graph alive as well).

loader/ImageLoader.cpp:

(WebCore::ImageLoader::notifyFinished):
Set m_firedLoad to true in the case of a canceled load, to reset the state back to
its initial values.

11:27 AM Changeset in webkit [93716] by mrowe@apple.com

2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r93376.

11:23 AM Changeset in webkit [93715] by scherkus@chromium.org

3 edits in trunk/LayoutTests

2011-08-24 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, rebaselining media/video-currentTime-set.html due to
FFmpeg udpate.

platform/chromium-cg-mac/media/video-currentTime-set-expected.txt:
platform/chromium-win/media/video-currentTime-set-expected.txt:

11:15 AM TestExpectations edited by pkasting@chromium.org

(diff)

11:09 AM Changeset in webkit [93714] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit/chromium

Expose fullscreen API on WebElement/WebDocument
https://bugs.webkit.org/show_bug.cgi?id=66746

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-08-24
Reviewed by Darin Fisher.

public/WebPluginContainer.h:
src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::setFullscreen):

src/WebPluginContainerImpl.h:

11:07 AM Changeset in webkit [93713] by commit-queue@webkit.org

14 edits
1 copy
1 add in trunk

MediaStream API: add createObjectURL functionality
https://bugs.webkit.org/show_bug.cgi?id=65925

Source/WebCore:

This patch introduces the functionality for generating the url associated with a MediaStream,
which can then be assigned to the src attribute of the <video> tag for example.

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-08-24
Reviewed by Adam Barth.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::createPublicBlobURL):
(WebCore::ScriptExecutionContext::revokePublicBlobURL):

dom/ScriptExecutionContext.h:
html/DOMURL.cpp:

(WebCore::DOMURL::createObjectURL):

html/DOMURL.h:
html/DOMURL.idl:
platform/MediaStreamRegistry.cpp: Added.

(WebCore::MediaStreamRegistry::registry):
(WebCore::MediaStreamRegistry::registerMediaStreamURL):
(WebCore::MediaStreamRegistry::unregisterMediaStreamURL):
(WebCore::MediaStreamRegistry::mediaStream):

platform/MediaStreamRegistry.h: Copied from Source/WebCore/html/DOMURL.h.

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

LayoutTests:

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-08-24
Reviewed by Adam Barth.

fast/files/create-blob-url-crash-expected.txt:

11:00 AM Changeset in webkit [93712] by andersca@apple.com

4 edits in trunk/Source/WebKit2

More plug-in complex text input scaffolding
https://bugs.webkit.org/show_bug.cgi?id=66865

Reviewed by Sam Weinig.

Make -[WKView _doneWithKeyEvent:eventWasHandled:] take an NSEvent * directly. Also
add methods for handling plug-in text input key-down events.

UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::doneWithKeyEvent):

UIProcess/API/mac/WKView.mm:

(-[WKView _tryHandlePluginComplexTextInputKeyDown:]):
(-[WKView keyDown:]):
(-[WKView _tryPostProcessPluginComplexTextInputKeyDown:]):
(-[WKView _doneWithKeyEvent:eventWasHandled:]):

UIProcess/API/mac/WKViewInternal.h:

10:55 AM Changeset in webkit [93711] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[GTK] WebProcess crash on hitting assertion m_isWaitingForDidUpdate in DrawingAreaImpl
https://bugs.webkit.org/show_bug.cgi?id=66640

Patch by Amruth Raj <amruthraj@motorola.com> on 2011-08-24
Reviewed by Martin Robinson.

The crash happens when a new timer is created in an existing timer callback. Since
TimerBase has a single GSource* it gets overridden and the old timer can never get
stopped. To handle this, keep a copy of the old timer and use it for destruction.

Platform/RunLoop.h:
Platform/gtk/RunLoopGtk.cpp:

(RunLoop::TimerBase::timerFiredCallback):
Store the timerSource so that even if it is modified by the timer callback,
it can be restored for freeing it.
(RunLoop::TimerBase::start):
Remove destroyNotifyCallback. Destruction is now handled in timerFiredCallback itself.

10:44 AM Changeset in webkit [93710] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

ErrorInstance::create sometimes has two heap object constructions
in flight at once
https://bugs.webkit.org/show_bug.cgi?id=66845

Reviewed by Darin Adler.

The fix is simple since there is already a second create() method
that takes a UString.

runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::create):

10:42 AM Changeset in webkit [93709] by levin@chromium.org

17 edits in trunk

MessageEvent.ports shouldn't ever be null.
https://bugs.webkit.org/show_bug.cgi?id=66789

Reviewed by Darin Adler.

Source/WebCore:

bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::ports): Never return null.

bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::portsAccessorGetter): Ditto.

LayoutTests:

Fix all tests which verified that MessageEvents.ports was null in various cases.

fast/dom/Window/window-postmessage-args-expected.txt:
fast/events/message-port-multi-expected.txt:
fast/events/resources/message-port-multi.js:

(channel.port2.onmessage):

fast/workers/resources/worker-context-multi-port.js:

(worker.onmessage):

fast/workers/resources/worker-messageport.js:

(onmessage):

fast/workers/resources/worker-thread-multi-port.js:

(onmessage):

fast/workers/worker-context-multi-port-expected.txt:
fast/workers/worker-messageport-expected.txt:
fast/workers/worker-multi-port-expected.txt:
platform/chromium-win/fast/events/message-port-multi-expected.txt:
platform/chromium-win/fast/workers/worker-context-multi-port-expected.txt:
platform/chromium-win/fast/workers/worker-multi-port-expected.txt:
platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:

10:30 AM Changeset in webkit [93708] by commit-queue@webkit.org

5 edits
2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=66799
RenderFlowThread creates a list of child elements, so that it can search
the insertion point of a new element without searching the whole DOM.
The issue is that it used addChild/removeChild, but that wasn't taking care of
elements added in anonymous blocks created inside the RenderFlowThread.

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-24
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/flow-anonymous-children.html

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::nextRendererForNode):
(WebCore::RenderFlowThread::previousRendererForNode):
(WebCore::RenderFlowThread::addFlowChild):
(WebCore::RenderFlowThread::removeFlowChild):

rendering/RenderFlowThread.h:
rendering/RenderObjectChildList.cpp:

(WebCore::renderFlowThreadContainer):
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):

LayoutTests:

fast/regions/flow-anonymous-children-expected.txt: Added.
fast/regions/flow-anonymous-children.html: Added.

8:04 AM Changeset in webkit [93707] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

[SKIA] Allow WebKitGraphicsContext3D implementation to provide a compatible GrGLInterface
https://bugs.webkit.org/show_bug.cgi?id=66809

Patch by Brian Salomon <bsalomon@google.com> on 2011-08-24
Reviewed by Stephen White.

public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::grGLInterface):

src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::grContext):

6:35 AM Changeset in webkit [93706] by pfeldman@chromium.org

26 edits in trunk/Source/WebCore

Web Inspector: Add 9 more javascript files to the compilation.
https://bugs.webkit.org/show_bug.cgi?id=66847

Reviewed by Yury Semikhatsky.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/compile-front-end.sh:
inspector/front-end/BreakpointManager.js:
inspector/front-end/CSSStyleModel.js:
inspector/front-end/Checkbox.js:
inspector/front-end/ConsoleMessage.js: Added.

(WebInspector.ConsoleStackFrame):
(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleMessage.prototype.get stackTrace):

inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated):

inspector/front-end/CookieParser.js:
inspector/front-end/DOMAgent.js:
inspector/front-end/DOMStorage.js:
inspector/front-end/Database.js:
inspector/front-end/DebuggerModel.js:
inspector/front-end/DebuggerPresentationModel.js:
inspector/front-end/InspectorFrontendHostStub.js:

(WebInspector.isMac):

inspector/front-end/NetworkManager.js:
inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.setPropertyValue):

inspector/front-end/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.Type.Document.0.Stylesheet.1.Image.2.Font.3.Script.4.XHR.5.WebSocket.7.Other.8.isTextType):
(WebInspector.Resource.Type.toUIString):
(WebInspector.Resource.Type.toString):
(WebInspector.Resource.prototype._checkWarnings):
(WebInspector.ResourceDomainModelBinding):
(WebInspector.ResourceDomainModelBinding.prototype.canSetContent):
(WebInspector.ResourceDomainModelBinding.prototype.setContent):

inspector/front-end/ResourceCategory.js:

(WebInspector.ResourceCategory):
(WebInspector.ResourceCategory.prototype.toString):
(WebInspector.ResourceCategory.prototype.get title):

inspector/front-end/ResourceTreeModel.js:
inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.prototype._didFormatContent):
(WebInspector.FormatterMappingPayload):

inspector/front-end/TimelineManager.js:
inspector/front-end/WebKit.qrc:
inspector/front-end/externs.js:

(console.assert):
(WebInspector.linkifyURLAsNode):
(WebInspector.linkifyStringAsFragment):
(WebInspector.UIString):
(Element.prototype.scrollIntoViewIfNeeded):

inspector/front-end/inspector.html:
inspector/front-end/inspector.js:

(WebInspector.UIString):

inspector/front-end/treeoutline.js:
inspector/front-end/utilities.js:
inspector/generate-protocol-externs:

5:52 AM Changeset in webkit [93705] by pfeldman@chromium.org

6 edits
1 add in trunk/Source/WebCore

Web Inspector: extract ConsoleMessage into a separate file.
https://bugs.webkit.org/show_bug.cgi?id=66853

Reviewed by Yury Semikhatsky.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/ConsoleMessage.js: Added.

(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleMessage.prototype._formatMessage):
(WebInspector.ConsoleMessage.prototype._linkifyLocation):
(WebInspector.ConsoleMessage.prototype._linkifyCallFrame):
(WebInspector.ConsoleMessage.prototype.isErrorOrWarning):
(WebInspector.ConsoleMessage.prototype._format):
(WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.valueFormatter):
(WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.append):
(WebInspector.ConsoleMessage.prototype.clearHighlight):
(WebInspector.ConsoleMessage.prototype.highlightSearchResults):
(WebInspector.ConsoleMessage.prototype.matchesRegex):
(WebInspector.ConsoleMessage.prototype.toMessageElement):
(WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
(WebInspector.ConsoleMessage.prototype._updateRepeatCount):
(WebInspector.ConsoleMessage.prototype.toString):
(WebInspector.ConsoleMessage.prototype.isEqual):
(WebInspector.ConsoleMessage.prototype.get stackTrace):

inspector/front-end/ConsoleView.js:
inspector/front-end/WebKit.qrc:

4:40 AM Changeset in webkit [93704] by podivilov@chromium.org

4 edits in trunk/LayoutTests

2011-08-24 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, chromium rebaseline for gradient-after-transparent-border.

platform/chromium-cg-mac-leopard/fast/gradients/gradient-after-transparent-border-expected.png:
platform/chromium-cg-mac/fast/gradients/gradient-after-transparent-border-expected.png:
platform/chromium/test_expectations.txt:

3:52 AM Changeset in webkit [93703] by podivilov@chromium.org

2 edits
1 move
2 adds
2 deletes in trunk/LayoutTests

2011-08-24 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, update test expectations for svg/custom/stroke-opacity-update.

platform/chromium-linux/svg/custom/stroke-opacity-update-expected.png: Added.
platform/chromium-win/svg/custom/stroke-opacity-update-expected.png: Added.
platform/chromium/test_expectations.txt:
platform/mac/svg/custom/stroke-opacity-update-expected.txt: Removed.
platform/qt/svg/custom/stroke-opacity-update-expected.txt: Removed.
svg/custom/stroke-opacity-update-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/stroke-opacity-update-expected.txt.

3:51 AM Changeset in webkit [93702] by commit-queue@webkit.org

3 edits
3 adds in trunk

Source/WebCore: Paint SliderTrack and SliderThumb independently.
https://bugs.webkit.org/show_bug.cgi?id=50453
Also fixes https://bugs.webkit.org/show_bug.cgi?id=65456 crash.

Patch by Tatiana Meshkova <tatiana.meshkova@nokia.com> on 2011-08-24
Reviewed by Kenneth Rohde Christiansen.

RenderSlider works only with <input type=range>. Nowadays RenderTheme
supports painting of SliderTrack and SliderThumb without range input.
In order to be in sync with other platforms this patch gets rid of
upcasting in RenderThemeQt::paintSliderTrack and allows to paint
SliderTrack and SliderThumb independently.

Test: platform/qt/fast/forms/range/slider-crash.html

platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::paintSliderTrack): Draw SC_SliderGroove.
Allow paintSliderThumb() to care about SC_SliderHandle. We don't need
to setup value and position anymore, since handle is drawn separately.
Draw focus explicitly, since QStyleOptionSlider doesn't allow to focus
on CC_Slider without handle subcontrol.
(WebCore::RenderThemeQt::paintSliderThumb): Draw SC_SliderHandle.

LayoutTests: Pixel crash test for RenderThemeQt::paintSliderTrack.
https://bugs.webkit.org/show_bug.cgi?id=50453

Patch by Tatiana Meshkova <tatiana.meshkova@nokia.com> on 2011-08-24
Reviewed by Kenneth Rohde Christiansen.

Support -webkit-appearance: slider-horizontal/vertical
painting without range input.

platform/qt/fast/forms/range/slider-crash-expected.png: Added.
platform/qt/fast/forms/range/slider-crash-expected.txt: Added.
platform/qt/fast/forms/range/slider-crash.html: Added.

3:18 AM Changeset in webkit [93701] by pfeldman@chromium.org

26 edits in trunk/Source/WebCore

Web Inspector: annotate and prepare for compilation first 14 JavaScript files within 4 modules.
https://bugs.webkit.org/show_bug.cgi?id=66776

Reviewed by Yury Semikhatsky.

inspector/compile-front-end.sh:
inspector/front-end/ContextMenu.js:
inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._loadNodeAttributes):
(WebInspector.DOMAgent.prototype._childNodeRemoved):
(WebInspector.DOMAgent.prototype._inspectElementRequested):
(WebInspector.DOMDispatcher.prototype.inspectElementRequested):

inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.Location):

inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._inspectElementRequested):

inspector/front-end/InspectorFrontendHostStub.js:
inspector/front-end/KeyboardShortcut.js:
inspector/front-end/Object.js:

(WebInspector.Object.prototype.addEventListener):
(WebInspector.Object.prototype.removeEventListener):
(WebInspector.Object.prototype.hasEventListeners):

inspector/front-end/Panel.js:

(WebInspector.Panel):

inspector/front-end/Placard.js:
inspector/front-end/Popover.js:

(WebInspector.Popover.prototype.show):

inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):
(WebInspector.StorageCategoryTreeElement):

inspector/front-end/Script.js:

(WebInspector.Script.prototype.editSource):

inspector/front-end/ScriptsPanel.js:
inspector/front-end/Settings.js:

(WebInspector.Settings):
(WebInspector.Settings.prototype.createSetting):

inspector/front-end/SoftContextMenu.js:

(.WebInspector.SoftContextMenu.prototype._menuItemMouseUp):
(.WebInspector.SoftContextMenu.prototype._triggerAction):
(.WebInspector.SoftContextMenu.prototype._menuKeyDown):

inspector/front-end/TabbedPane.js:
inspector/front-end/TextPrompt.js:
inspector/front-end/UserMetrics.js:
inspector/front-end/View.js:
inspector/front-end/externs.js:

(JSON.parse):
(JSON.stringify):

inspector/front-end/inspector.js:

():

inspector/generate-protocol-externs:

3:10 AM Changeset in webkit [93700] by podivilov@chromium.org

1 edit
2 adds in trunk/LayoutTests

2011-08-24 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix chromium expectations for fast/preloader/script.html.

platform/chromium/fast/preloader/script-expected.txt: Added.

2:52 AM Changeset in webkit [93699] by andreas.kling@nokia.com

3 edits in trunk/Source/WebCore

SelectElementData: Reorder members to reduce memory usage.
https://bugs.webkit.org/show_bug.cgi?id=66787

Reviewed by Darin Adler.

Reduced the size of SelectElementData by 24 bytes on 64-bit by rearranging
its data members.

Also added missing initialization of m_userDrivenChange.

dom/SelectElement.cpp:

(WebCore::SelectElementData::SelectElementData):

dom/SelectElement.h:

2:50 AM Changeset in webkit [93698] by fpizlo@apple.com

20 edits
2 adds in trunk/Source/JavaScriptCore

There is no facility for profiling how the write barrier is used
https://bugs.webkit.org/show_bug.cgi?id=66747

Reviewed by Geoffrey Garen.

Added facilities for the JIT to specify the kind of write barrier
being executed. Added code for profiling the number of each kind
of barrier encountered.

GNUmakefile.list.am:
JavaScriptCore.exp:
JavaScriptCore.pro:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::cachedPutById):

dfg/DFGJITCodeGenerator.h:
dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::emitCount):

dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::emitCount):

dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

dfg/DFGRepatch.cpp:

(JSC::DFG::tryCachePutByID):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

heap/Heap.h:

(JSC::Heap::writeBarrier):

heap/WriteBarrierSupport.cpp: Added.

(JSC::WriteBarrierCounters::initialize):

heap/WriteBarrierSupport.h: Added.

(JSC::WriteBarrierCounters::WriteBarrierCounters):
(JSC::WriteBarrierCounters::jitCounterFor):
(JSC::WriteBarrierCounters::countWriteBarrier):

jit/JIT.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emitWriteBarrier):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emitWriteBarrier):

runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

runtime/WriteBarrier.h:

(JSC::WriteBarrierBase::setWithoutWriteBarrier):

2:48 AM Changeset in webkit [93697] by commit-queue@webkit.org

2 edits
2 adds in trunk/Source/WebKit/efl

[EFL] Add dummy IconDatabaseClientEfl.
http://bugs.webkit.org/show_bug.cgi?id=65596

Implements a dummy IconDatabaseClientEfl class.
Adds two files, IconDatabaseClientEfl.h | .cpp.

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2011-08-24
Reviewed by Kent Tamura.

CMakeListsEfl.txt:
WebCoreSupport/IconDatabaseClientEfl.cpp: Added.

(WebCore::IconDatabaseClientEfl::performImport):
(WebCore::IconDatabaseClientEfl::didRemoveAllIcons):
(WebCore::IconDatabaseClientEfl::didImportIconURLForPageURL):
(WebCore::IconDatabaseClientEfl::didImportIconDataForPageURL):
(WebCore::IconDatabaseClientEfl::didChangeIconForPageURL):
(WebCore::IconDatabaseClientEfl::didFinishURLImport):

WebCoreSupport/IconDatabaseClientEfl.h: Added.

2:07 AM Changeset in webkit [93696] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: clearPseudoState should retain Element while clearing
its state.
https://bugs.webkit.org/show_bug.cgi?id=66790

Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-24
Reviewed by Yury Semikhatsky.

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::clearPseudoState):

Aug 23, 2011:

10:24 PM Changeset in webkit [93695] by koz@chromium.org

2 edits in trunk/LayoutTests

Extra baseline for bug 66036 (canvas fill composite modes)
https://bugs.webkit.org/show_bug.cgi?id=66835

Unreviewed, new baseline for pixel tests.

Patch by Ben Wells <benwells@chromium.org> on 2011-08-23

platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.png:

10:15 PM Changeset in webkit [93694] by cevans@google.com

1 edit
2 copies in branches/chromium/835

Merge 93514
BUG=93420
Review URL: http://codereview.chromium.org/7714029

9:37 PM Changeset in webkit [93693] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/efl

[EFL] Change parameter type for some APIs in ewk_tile_matrix.
https://bugs.webkit.org/show_bug.cgi?id=66639

As type of both col and row parameter for ewk_tile_matrix's some APIs listed by this patch
are different from each other and eina_matrixsparse associated with ewk_tile_matrix is now
using unsigned long type for both col and row parameter, row parameter for ewk_tile_matrix
is also better to be specified as unsigned long type.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-23
Reviewed by Anders Carlsson.

ewk/ewk_tiled_matrix.c:

(ewk_tile_matrix_tile_exact_get):
(ewk_tile_matrix_tile_exact_exists):
(ewk_tile_matrix_tile_new):
(ewk_tile_matrix_tile_update):
(ewk_tile_matrix_tile_update_full):

ewk/ewk_tiled_matrix.h:

9:32 PM Changeset in webkit [93692] by abarth@webkit.org

3 edits
1 add in trunk/Source/WebKit/chromium

WebSearchableFormData crashes when given a detached HTMLFormElement
https://bugs.webkit.org/show_bug.cgi?id=66831

Reviewed by Dimitri Glazkov.

We need to null-check the Frame.

src/WebSearchableFormData.cpp:

(HTMLNames::GetFormEncoding):

tests/WebFrameTest.cpp:

(WebKit::TEST_F):

tests/data/form.html: Added.

9:24 PM Changeset in webkit [93691] by Dimitri Glazkov

3 edits in trunk/Tools

Make notifications appear in time order again.
https://bugs.webkit.org/show_bug.cgi?id=66815

Reviewed by Adam Barth.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.

7:14 PM Changeset in webkit [93690] by commit-queue@webkit.org

1 edit
1 add in trunk/LayoutTests

Extra baseline for bug 66442 (skia webkit-transform breaks webkit-mask)
https://bugs.webkit.org/show_bug.cgi?id=66833

Patch by Ben Wells <benwells@chromium.org> on 2011-08-23
Reviewed by Kenneth Russell.

platform/chromium-gpu-linux/compositing/masks/multiple-masks-expected.png: Added.

7:11 PM Changeset in webkit [93689] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Make WebGL context current before querying for extensions
https://bugs.webkit.org/show_bug.cgi?id=66788

We're making changes on the Chromium side for threaded compositing that
will require makeContextCurrent to be called on the appropriate thread
before any other GL calls.

In line with other GraphicsContext3D implementations, we do this
implicitly. This is the minimum change that makes WebGL compliant.

Patch by Iain Merrick <husky@google.com> on 2011-08-23
Reviewed by Kenneth Russell.

src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::initializeExtensions):

7:05 PM Changeset in webkit [93688] by commit-queue@webkit.org

10 edits in trunk/Source

Add checks to ensure allocation does not take place during initialization of GC-managed objects
https://bugs.webkit.org/show_bug.cgi?id=65288

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-23
Reviewed by Darin Adler.

Source/JavaScriptCore:

Adding the new validation functionality. In its current state, it will performs checks,
but they don't fail unless you do allocation in the arguments to the parent constructor in the
initialization list of a class. The allocateCell() method turns on the global flag disallowing any new
allocations, and the constructorBody() method in JSCell turns it off. This way, allocation is still
allowed in constructor bodies while other refactoring efforts continue.

runtime/JSCell.h:

(JSC::JSCell::JSCell::constructorBody):
(JSC::JSCell::JSCell::JSCell):
(JSC::JSCell::allocateCell):

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

runtime/JSGlobalData.h:

(JSC::JSGlobalData::isInitializingObject):
(JSC::JSGlobalData::setInitializingObject):

runtime/StringObjectThatMasqueradesAsUndefined.h:

(JSC::StringObjectThatMasqueradesAsUndefined::create):

Source/WebCore:

No new tests.

bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::operator new):

bindings/js/JSDOMWindowShell.h:

Source/WebKit/mac:

Plugins/Hosted/ProxyRuntimeObject.h:

(WebKit::ProxyRuntimeObject::create):

Plugins/Hosted/ProxyRuntimeObject.mm:

(WebKit::ProxyRuntimeObject::ProxyRuntimeObject):

7:00 PM Changeset in webkit [93687] by commit-queue@webkit.org

2 edits
2 adds in trunk/LayoutTests

Rebaselines for bug 66036 (fills with various canvas compositing modes)
https://bugs.webkit.org/show_bug.cgi?id=66824

Patch by Ben Wells <benwells@chromium.org> on 2011-08-23
Reviewed by James Robinson.

platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png: Added.
platform/chromium-gpu-win/fast/canvas/canvas-composite-transformclip-expected.png: Added.
platform/chromium/test_expectations.txt:

6:57 PM Changeset in webkit [93686] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Add more flaky snowleopard GPU tests.

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

6:55 PM Changeset in webkit [93685] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/efl

[EFL] Get the default value for `scripts_window_open' from the right method.
https://bugs.webkit.org/show_bug.cgi?id=66775

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Reviewed by Kent Tamura.

For some unknown reason, the default value for this setting was being
obtained from Settings::allowScriptsToCloseWindows() instead of
Settings::javaScriptCanOpenWindowsAutomatically(), which makes no
sense at all.

ewk/ewk_view.cpp:

(_ewk_view_priv_new):

6:39 PM Changeset in webkit [93684] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Fix erroneous test expectation.

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

6:39 PM Changeset in webkit [93683] by commit-queue@webkit.org

6 edits in trunk/Source/WebKit/efl

[EFL] Change the tiled backing store to use constant size of tile.
https://bugs.webkit.org/show_bug.cgi?id=65848

As current tiled backing store in Webkit EFL is using variable tile size according to the zoom level,
the number of tiles in viewport is not same always and the speed of panning is also not consistent
whenever zoom level is changed.
Therefore, tile size should be constant size in order to make sure the consistent panning speed.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-23
Reviewed by Anders Carlsson.

ewk/ewk_tiled_backing_store.c:

(_ewk_tiled_backing_store_model_matrix_create):
(_ewk_tiled_backing_store_smart_add):
(_ewk_tiled_backing_store_smart_calculate):
(_ewk_tiled_backing_store_zoom_set_internal):
(ewk_tiled_backing_store_zoom_weak_set):
(ewk_tiled_backing_store_flush):
(ewk_tiled_backing_store_pre_render_region):
(ewk_tiled_backing_store_pre_render_relative_radius):

ewk/ewk_tiled_backing_store.h:
ewk/ewk_tiled_matrix.c:

(_ewk_tile_matrix_cell_free):
(_ewk_tile_matrix_tile_free):
(ewk_tile_matrix_new):
(ewk_tile_matrix_tile_exact_get):
(ewk_tile_matrix_tile_exact_exists):
(ewk_tile_matrix_tile_new):
(ewk_tile_matrix_tile_update):
(ewk_tile_matrix_tile_update_full):
(_ewk_tile_matrix_slicer_setup):
(ewk_tile_matrix_update):
(ewk_tile_matrix_dbg):

ewk/ewk_tiled_matrix.h:
ewk/ewk_tiled_model.c:

(ewk_tile_new):

6:36 PM Changeset in webkit [93682] by commit-queue@webkit.org

5 edits in trunk/Source

ScrollAnimatorNone coasting implementation
https://bugs.webkit.org/show_bug.cgi?id=66258

Source/WebCore:

Increase the animation time based on the velocity of the scroll, up to a
maximum amount. Fix bugs found by additional unit testing.

Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-23
Reviewed by James Robinson.

Additional tests in ScrollAnimatorNoneTest: CurveMathQuartic, CurveMathCoast,
ScrollOnceQuartic, ScrollTwiceCubic, ScrollLotsCubic, ScrollLotsCubicSmoothed,
ScrollUpToBumperCoast, ScrollDownToBumperCoast, VaryingInputsEquivalency,
VaryingInputsEquivalencyCoast, VaryingInputsEquivalencyCoastLarge,
VaryingInputsEquivalencyCoastSteep

platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::Parameters::Parameters):
(WebCore::ScrollAnimatorNone::PerAxisData::curveAt):
(WebCore::ScrollAnimatorNone::PerAxisData::coastCurve):
(WebCore::ScrollAnimatorNone::PerAxisData::curveIntegralAt):
(WebCore::ScrollAnimatorNone::PerAxisData::attackArea):
(WebCore::ScrollAnimatorNone::PerAxisData::releaseArea):
(WebCore::ScrollAnimatorNone::PerAxisData::PerAxisData):
(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::PerAxisData::updateVisibleLength):
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::willEndLiveResize):
(WebCore::ScrollAnimatorNone::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorNone::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorNone::updateVisibleLengths):

platform/ScrollAnimatorNone.h:

Source/WebKit/chromium:

Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-23
Reviewed by James Robinson.

tests/ScrollAnimatorNoneTest.cpp:

(MockScrollableArea::visibleHeight):
(MockScrollableArea::visibleWidth):
(ScrollAnimatorNoneTest::SavePerAxisData::SavePerAxisData):
(ScrollAnimatorNoneTest::SavePerAxisData::operator==):
(ScrollAnimatorNoneTest::SetUp):
(ScrollAnimatorNoneTest::updateDataFromParameters):
(ScrollAnimatorNoneTest::animateScroll):
(ScrollAnimatorNoneTest::attackArea):
(ScrollAnimatorNoneTest::releaseArea):
(ScrollAnimatorNoneTest::coastCurve):
(ScrollAnimatorNoneTest::curveTestInner):
(TEST_F):

6:33 PM Changeset in webkit [93681] by jamesr@google.com

11 edits
3 adds in trunk

[chromium] Need a way to test lost compositor context recovery
https://bugs.webkit.org/show_bug.cgi?id=66820

Reviewed by Kenneth Russell.

Source/WebCore:

Adds support for recreating a context as if it was lost, and fixes
compositeAndReadback() to attempt context recovery.

Test: platform/chromium/compositing/lost-compositor-context.html

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::loseCompositorContext):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

Adds a testing-only API to simulate a lost compositor context.

public/WebView.h:
src/WebViewImpl.cpp:

(WebKit::WebViewImpl::loseCompositorContext):

src/WebViewImpl.h:

Tools:

Exposes a LayoutTestController interface in chromium to simulate a
lost compositor context.

DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::loseCompositorContext):

DumpRenderTree/chromium/LayoutTestController.h:

LayoutTests:

Adds a simple test for losing the compositor context in a recoverable
way on a composited page. Tests that we recover without crashing and
render the updated content on the next frame.

platform/chromium/compositing/lost-compositor-context.html: Added.

6:22 PM Changeset in webkit [93680] by nduca@chromium.org

12 edits
1 move
1 add in trunk/Source

[chromium] Implement CCThread in terms of WebThread
https://bugs.webkit.org/show_bug.cgi?id=66610

Reviewed by Darin Fisher.

Source/WebCore:

WebCore.gypi:
platform/graphics/chromium/cc/CCCompletionEvent.h:
platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::client):

platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:

(WebCore::CCLayerTreeHostImplProxy::CCLayerTreeHostImplProxy):

platform/graphics/chromium/cc/CCThread.h:

(WebCore::CCThread::~CCThread):

Source/WebKit/chromium:

WebKit.gyp:
public/WebThread.h:

(WebKit::WebThread::~WebThread):

src/CCThreadImpl.cpp: Added.

(WebKit::GetThreadIDTask::GetThreadIDTask):
(WebKit::GetThreadIDTask::~GetThreadIDTask):
(WebKit::GetThreadIDTask::run):
(WebKit::CCThreadTaskAdapter::CCThreadTaskAdapter):
(WebKit::CCThreadTaskAdapter::~CCThreadTaskAdapter):
(WebKit::CCThreadTaskAdapter::run):
(WebKit::CCThreadImpl::create):
(WebKit::CCThreadImpl::~CCThreadImpl):
(WebKit::CCThreadImpl::postTask):
(WebKit::CCThreadImpl::threadID):
(WebKit::CCThreadImpl::CCThreadImpl):

src/CCThreadImpl.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
src/WebViewImpl.cpp:

(WebKit::WebViewImpl::createCompositorThread):

src/WebViewImpl.h:
tests/CCThreadTest.cpp:

6:18 PM Changeset in webkit [93679] by commit-queue@webkit.org

7 edits in trunk/Source

[chromium] Renderer crashes when about:gpucrash is loaded
https://bugs.webkit.org/show_bug.cgi?id=66814

Source/WebCore:

WebViewImpl::didRecreateGraphicsContext() was calling
setRootLayer() on the CC layer tree, but the root layer
doesn't actually change and the code wasn't defensive
against this. This CL adds some asserts to catch tree
corruption and removes the unnecessary calls.

Patch by Iain Merrick <husky@google.com> on 2011-08-23
Reviewed by James Robinson.

platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::setParent):

platform/graphics/GraphicsLayer.h:
platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setParent):
(WebCore::LayerChromium::hasAncestor):

platform/graphics/chromium/LayerChromium.h:

Source/WebKit/chromium:

Patch by Iain Merrick <husky@google.com> on 2011-08-23
Reviewed by James Robinson.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::didRecreateGraphicsContext):

6:08 PM Changeset in webkit [93678] by mrowe@apple.com

2 edits in branches/safari-534.51-branch/Source/WebKit2

Merge r93420.

6:06 PM Changeset in webkit [93677] by mrowe@apple.com

6 edits
2 adds in branches/safari-534.51-branch

Merge r90691.

6:00 PM Changeset in webkit [93676] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r93645.
http://trac.webkit.org/changeset/93645
https://bugs.webkit.org/show_bug.cgi?id=66828

Broke webkit_unit_tests on chromium mac (Requested by jamesr
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-23

platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

5:54 PM Changeset in webkit [93675] by mrowe@apple.com

5 edits
20 adds in branches/safari-534.51-branch

Merge r93287.

5:54 PM Changeset in webkit [93674] by mrowe@apple.com

5 edits
3 adds in branches/safari-534.51-branch

Merge r92417.

5:43 PM Changeset in webkit [93673] by mrowe@apple.com

3 edits in branches/safari-534.51-branch/Source/WebKit2

Merge r93546.

5:38 PM Changeset in webkit [93672] by mrowe@apple.com

2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r92894.

5:33 PM Changeset in webkit [93671] by mrowe@apple.com

2 edits in branches/safari-534.51-branch/Source/WebCore

Frequent crashes due to null frame below ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache.
https://bugs.webkit.org/show_bug.cgi?id=62764

Patch by Jessie Berlin <jberlin@apple.com> on 2011-08-23
Reviewed by Alexey Proskuryakov.

It is still unclear in what scenario the ResourceLoader could have a non-null DocumentLoader
without a Frame, since all loads should be stopped before the DocumentLoader is detached
from its Frame.

Until a reproducible case is found, bail early to prevent crashes.

loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didFail):
Add an early return if the DocumentLoader does not have a Frame.

5:29 PM Changeset in webkit [93670] by andersca@apple.com

4 edits in trunk/Source/WebKit2

Prepare WKTextInputWindowController for the new text input model
https://bugs.webkit.org/show_bug.cgi?id=66826

Reviewed by Sam Weinig.

Add -[WKTextInputWindowController hasMarkedText] and make interpretKeyEvent take an
additional usingLegacyCocoaTextInput flag. No functionality change.

UIProcess/API/mac/WKTextInputWindowController.h:
UIProcess/API/mac/WKTextInputWindowController.mm:

(-[WKTextInputPanel _interpretKeyEvent:usingLegacyCocoaTextInput:string:]):
(-[WKTextInputPanel _hasMarkedText]):
(-[WKTextInputWindowController hasMarkedText]):
(-[WKTextInputWindowController interpretKeyEvent:usingLegacyCocoaTextInput:string:]):

UIProcess/API/mac/WKView.mm:

(-[WKView keyDown:]):

5:29 PM Changeset in webkit [93669] by Beth Dakin

9 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=66244
Cached pages don't fully update when going back after changing the display scale
factor
-and corresponding-
<rdar://problem/9955656>

Reviewed by Darin Adler.

This patch adds a generalized concept of needing a full style recalc to the
BackForwardController. So when the display scale factor is changed, the
BackForwardController can be informed that all pages will need a full style recalc
when they come out of the cache. This same mechanism is also used to fix a long-
standing bug with full-page/text zoom.

Iterate through the HistoryItems and mark all CachedPages as needing a full style
recalc.

history/BackForwardController.cpp:

(WebCore::BackForwardController::markPagesForFullStyleRecalc):

history/BackForwardController.h:

ChachedPage has a new bool -- m_needsFullStyleRecalc -- to track whether a full
style recalc is needed when the CachedPage is restored.

history/CachedPage.cpp:

(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):
(WebCore::CachedPage::clear):

history/CachedPage.h:

(WebCore::CachedPage::markForFullStyleRecalc):

HistoryItem actually takes care of calling into CachedPage.

history/HistoryItem.cpp:

(WebCore::HistoryItem::markForFullStyleRecalc):

history/HistoryItem.h:

Fix style recalc issues for full-page/text zoom by calling our new function on
PageCache.

page/Frame.cpp:

(WebCore::Frame::setPageAndTextZoomFactors):

Fix style recalc issues for display scale factor changes by calling our new
function on PageCache.

page/Page.cpp:

(WebCore::Page::setDeviceScaleFactor):

5:15 PM Changeset in webkit [93668] by mrowe@apple.com

5 edits in branches/safari-534.51-branch

Merge r93487.

5:15 PM Changeset in webkit [93667] by mrowe@apple.com

7 edits in branches/safari-534.51-branch/Source/WebCore

Merge r92788.

5:15 PM Changeset in webkit [93666] by mrowe@apple.com

7 edits in branches/safari-534.51-branch/Source/WebKit2

Merge r93555.

5:15 PM Changeset in webkit [93665] by mrowe@apple.com

3 edits
3 adds in branches/safari-534.51-branch

Merge r93298.

5:15 PM Changeset in webkit [93664] by mrowe@apple.com

2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r93264.

5:13 PM Changeset in webkit [93663] by abarth@webkit.org

1 edit
2 adds
1 delete in trunk/LayoutTests

Fix baselines for fast/block/float/fit_line_below_floats.html. I forgot Windows in my previous patch.

platform/chromium-linux/fast/block/float/fit_line_below_floats-expected.txt: Removed.
platform/chromium-win/fast/block/float/fit_line_below_floats-expected.png: Added.
platform/chromium-win/fast/block/float/fit_line_below_floats-expected.txt: Added.

4:59 PM Changeset in webkit [93662] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Remove comments formerly associated with now-rebaselined tests.

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

4:39 PM Changeset in webkit [93661] by Lucas Forschler

5 edits
2 copies in branches/safari-534.51-branch/Source/WebCore

Merge r93363.

4:37 PM Changeset in webkit [93660] by Lucas Forschler

2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r93260.

4:34 PM Changeset in webkit [93659] by Lucas Forschler

4 edits
6 copies
4 deletes in branches/safari-534.51-branch/Source/WebCore

Merge 93219.

4:33 PM Changeset in webkit [93658] by Dimitri Glazkov

6 edits in trunk/Tools

Change garden-o-matic frontend builder array to be a configuration map.
https://bugs.webkit.org/show_bug.cgi?id=66816

Reviewed by Adam Barth.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.

4:32 PM Changeset in webkit [93657] by andersca@apple.com

2 edits in trunk/Source/WebCore

Fix build.

inspector/InstrumentingAgents.cpp:

4:31 PM Changeset in webkit [93656] by commit-queue@webkit.org

8 edits in trunk

Added support for momentarily revealing last typed character in password input.
Code change was partially based on Apple's iOS code and Samuel Nevala's work.
https://bugs.webkit.org/show_bug.cgi?id=32509

Patch by Chang Shu <cshu@webkit.org> on 2011-08-23
Reviewed by Alexey Proskuryakov.

Source/WebCore:

editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::doApply):

rendering/RenderText.cpp:

(WebCore::SecureTextTimer::SecureTextTimer):
(WebCore::SecureTextTimer::restartWithNewText):
(WebCore::SecureTextTimer::invalidate):
(WebCore::SecureTextTimer::lastTypedCharacterOffset):
(WebCore::SecureTextTimer::fired):
(WebCore::RenderText::willBeDestroyed):
(WebCore::RenderText::setTextInternal):
(WebCore::RenderText::secureText):
(WebCore::RenderText::momentarilyRevealLastTypedCharacter):

rendering/RenderText.h:

(WebCore::RenderText::isSecure):

testing/Internals.cpp:

(WebCore::Internals::setPasswordEchoEnabled): Fixed some silly coding in Internals.
(WebCore::Internals::setPasswordEchoDurationInSeconds):
(WebCore::Internals::reset):

LayoutTests:

Updated failed expected files.

editing/input/password-echo-passnode-expected.txt:
editing/input/password-echo-passnode2-expected.txt:

4:24 PM Changeset in webkit [93655] by commit-queue@webkit.org

2 edits
1 move
6 adds in trunk/LayoutTests

Rebaselines for bug 66442 (skia webkit-transform breaks webkit-mask)
https://bugs.webkit.org/show_bug.cgi?id=66757

Patch by Ben Wells <benwells@chromium.org> on 2011-08-23
Reviewed by Kenneth Russell.

platform/chromium-gpu-win/compositing/masks/multiple-masks-expected.png: Added.
platform/chromium-gpu-win/compositing/masks/multiple-masks-expected.txt: Added.
platform/chromium-linux/fast/backgrounds/mask-composite-expected.png: Added.
platform/chromium-win/fast/backgrounds/mask-composite-expected.png: Added.
platform/chromium-win/fast/backgrounds/mask-composite-expected.txt: Added.
platform/chromium-win/fast/css/transformed-mask-expected.png: Added.
platform/chromium-win/fast/css/transformed-mask-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/css/transformed-mask-expected.txt.
platform/chromium/test_expectations.txt:

4:22 PM Changeset in webkit [93654] by commit-queue@webkit.org

5 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=66751
[Chromium]WebWorkerClientImpl should always invoke
InspectorIntrumentation on main thread.
The fix moves calls to InspectorInstrumentation from
WebWorkerClientImpl to unedrlying WorkerMessagingProxy.

Patch by Dmitry Lomov <Dmitry Lomov (dslomov@google.com)> on 2011-08-23
Reviewed by Pavel Feldman.

Source/WebCore:

Covered by existing tests.

inspector/InstrumentingAgents.cpp:

(WebCore::instrumentationForPage):

workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::workerContextDestroyedInternal):
(WebCore::WorkerMessagingProxy::terminateWorkerContext):

Source/WebKit/chromium:

src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::terminateWorkerContext):
(WebKit::WebWorkerClientImpl::workerContextDestroyed):

4:18 PM Changeset in webkit [93653] by caryclark@google.com

2 edits in trunk/Tools

Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=66803

This fixes the WebKit Canaries, in particular avoids a crash on tests
like css1/basic/comments.html.

Reviewed by James Robinson.

DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:

(WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
and treated it as if it were a CGContextRef.

4:12 PM Changeset in webkit [93652] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Qt] Button text is invisible when mobile theme is in use and application palette set to use light text color.
https://bugs.webkit.org/show_bug.cgi?id=66635

When mobile theme is in use and application palette is using light
color to display text button text becomes invisible. The reason for
that is that in RenderThemeQt::systemFont() we are using application
pallete while when are painting buttons lightGrayPalette is used.
Calling setPaletteFromPageClientIfExists() takes care of the issue.

Patch by Misha Tyutyunik <michael.tyutyunik@nokia.com> on 2011-08-23
Reviewed by Andreas Kling.

Covered by existing tests.

platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::systemColor):

4:10 PM Changeset in webkit [93651] by tony@chromium.org

4 edits
2 adds in trunk

Add handling of mix-width and max-width for flexitems
https://bugs.webkit.org/show_bug.cgi?id=66723

Reviewed by David Hyatt.

Source/WebCore:

If we flex past a min/max width value, we need to mark the flexitem as
a fixed width and re-start the flexing algorithm. We use a HashMap to
keep track of fixed width items.

This patch also split out the size computation from the actual layout
to avoid unnecessary layouts caused by restarting the flexing algorithm.

Test: css3/flexbox/003.html

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm):

rendering/RenderFlexibleBox.h:

LayoutTests:

css3/flexbox/003-expected.txt: Added.
css3/flexbox/003.html: Added.

4:08 PM Changeset in webkit [93650] by abarth@webkit.org

11 edits
18 adds
5 deletes in trunk/LayoutTests

Update expectations for pkasting. The rebaseline script is having
trouble on Cygwin, so I ran the script as instructed by Peter.

platform/chromium-cg-mac-leopard/fast/block/float/fit_line_below_floats-expected.png: Added.
platform/chromium-cg-mac-leopard/fast/block/float/floats-and-text-indent-expected.png: Added.
platform/chromium-cg-mac-leopard/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
platform/chromium-cg-mac-leopard/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
platform/chromium-cg-mac/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
platform/chromium-linux-x86/fast/css: Removed.
platform/chromium-linux-x86/svg/dynamic-updates: Removed.
platform/chromium-linux/fast/block/float/fit_line_below_floats-expected.png: Added.
platform/chromium-linux/fast/block/float/fit_line_below_floats-expected.txt: Added.
platform/chromium-linux/fast/block/float/floats-and-text-indent-expected.png: Added.
platform/chromium-linux/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
platform/chromium-linux/fast/block/positioning/058-expected.png:
platform/chromium-linux/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
platform/chromium-win-vista/svg/dynamic-updates: Removed.
platform/chromium-win/fast/block/float/floats-and-text-indent-expected.png: Added.
platform/chromium-win/fast/block/float/floats-and-text-indent-expected.txt: Added.
platform/chromium-win/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
platform/chromium-win/fast/block/float/floats-and-text-indent-rl-expected.txt: Added.
platform/chromium-win/fast/block/positioning/058-expected.png:
platform/chromium-win/fast/block/positioning/058-expected.txt:
platform/chromium-win/fast/css/border-radius-non-negative-expected.png: Added.
platform/chromium-win/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
platform/chromium-win/fast/multicol/span/span-as-nested-inline-block-child-expected.txt: Added.
platform/chromium-win/svg/custom/image-small-width-height-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
platform/chromium/test_expectations.txt:
platform/gtk/svg/custom/image-small-width-height-expected.txt: Removed.
platform/qt/svg/custom/image-small-width-height-expected.txt: Removed.
svg/custom/image-small-width-height-expected.txt: Added.

4:07 PM Changeset in webkit [93649] by Patrick Gansterer

2 edits in trunk/Tools

Fix mergeChangeLogs test on native windows
https://bugs.webkit.org/show_bug.cgi?id=66797

Reviewed by Adam Roben.

Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.

Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:

(writeTempFile):

4:05 PM Changeset in webkit [93648] by psolanki@apple.com

2 edits in trunk/Source/WebCore

ResourceRequest::setStorageSession should update NSURLRequest as well
https://bugs.webkit.org/show_bug.cgi?id=66811

Reviewed by Darin Adler.

platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::setStorageSession): Update the m_nsRequest field as well since we
have a new CFURLRequestRef.

4:01 PM Changeset in webkit [93647] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

[chromium] Remove obsolete child context list from LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=66743

Patch by James Robinson <jamesr@chromium.org> on 2011-08-23
Reviewed by Kenneth Russell.

Before we had proper semantics for flush() in the command buffer, we
used a scheme of latches across contexts to ensure consistent frames
were presented for WebGL and canvas. We no longer have latches and
flush is a proper synchronization primative, so the child context list
no longer does anything. Canvas2DLayerChromium and
WebGLLayerChromium's implementations of updateCompositorResources() do
flushes on the appropriate context already - canvas layers via
DrawingBuffer::publishToPlatformLayer(), and WebGL layers via the call
to prepareTexture().

No new tests since the code being removed doesn't do anything.

platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::setDrawingBuffer):

platform/graphics/chromium/Canvas2DLayerChromium.h:
platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayers):

platform/graphics/chromium/LayerRendererChromium.h:
platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::~WebGLLayerChromium):
(WebCore::WebGLLayerChromium::setContext):

platform/graphics/chromium/WebGLLayerChromium.h:

4:01 PM Changeset in webkit [93646] by Lucas Forschler

3 edits in branches/safari-534.51-branch/Source/WebCore

Merge https://bugs.webkit.org/show_bug.cgi?id=62901

3:59 PM Changeset in webkit [93645] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Chromium Mac: Use a custom pattern image for rubber banding overhang area
https://bugs.webkit.org/show_bug.cgi?id=66707

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-23
Reviewed by Dimitri Glazkov.

No new tests since its just changing the Chromium-specific overhang pattern.

platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

3:57 PM Changeset in webkit [93644] by commit-queue@webkit.org

4 edits in trunk

Source/WebCore: Prepare to paint slider thumb separately.
Provide proper size values for vertical SliderThumb.
https://bugs.webkit.org/show_bug.cgi?id=66732

Patch by Tatiana Meshkova <tatiana.meshkova@nokia.com> on 2011-08-23
Reviewed by Kenneth Rohde Christiansen.

platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::adjustSliderThumbSize):
Swap length and thickness for sliderthumb-vertical.

LayoutTests: Swap width and height for sliderthumb-vertical.
https://bugs.webkit.org/show_bug.cgi?id=66732

Patch by Tatiana Meshkova <tatiana.meshkova@nokia.com> on 2011-08-23
Reviewed by Kenneth Rohde Christiansen.

platform/qt/fast/forms/range/thumbslider-no-parent-slider-expected.txt:

3:35 PM Changeset in webkit [93643] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Typo fix.

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

3:22 PM Changeset in webkit [93642] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Revert unintentional changes to test expectations in r93638.

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

3:10 PM Changeset in webkit [93641] by Dimitri Glazkov

4 edits in trunk/Tools

garden-o-matic relative time is wrong and updates too frequently.
https://bugs.webkit.org/show_bug.cgi?id=66802

Reviewed by Adam Barth.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.

3:09 PM Changeset in webkit [93640] by enne@google.com

3 edits in trunk/Source/WebCore

[chromium] Fix potential nullptr deref in TiledLayerChromium::pushPropertiesTo
https://bugs.webkit.org/show_bug.cgi?id=66808

Reviewed by James Robinson.

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::pushPropertiesTo):

platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::draw):

3:01 PM Changeset in webkit [93639] by Lucas Forschler

5 edits in tags/Safari-534.49.2/Source

Versioning.

2:51 PM Changeset in webkit [93638] by pkasting@chromium.org

4 edits
3 deletes in trunk

Unreviewed, rolling out r93452.
http://trac.webkit.org/changeset/93452
https://bugs.webkit.org/show_bug.cgi?id=66423

Broke Leopard, Snowleopard, and Chromium bots

Source/WebCore:

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

LayoutTests:

fast/parser/innerhtml-with-prefixed-elements.xhtml: Removed.
platform/chromium/test_expectations.txt:
platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.png: Removed.
platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Removed.

2:40 PM QtWebKitRelease22 edited by Ademar Reis

(diff)

2:01 PM Changeset in webkit [93637] by demarchi@webkit.org

9 edits
2 adds in trunk/Source/WebKit

Source/WebKit: Patch by Jonas M. Gastal <jgastal@profusion.mobi> on 2011-08-23
Reviewed by Antonio Gomes.

[EFL] Exporting JavaScript objects for EFL port
https://bugs.webkit.org/show_bug.cgi?id=43446

This patch allows to export objects to JavaScript API,
just like qt does, but it uses the netscape api
to do the convertion to javascript object.

CMakeLists.txt:

Adding necessary files for the patch.

Source/WebKit/efl: [EFL] Exporting JavaScript objects for EFL port
https://bugs.webkit.org/show_bug.cgi?id=43446

Patch by Jonas M. Gastal <jgastal@profusion.mobi> on 2011-08-23
Reviewed by Antonio Gomes.

This patch allows to export objects to JavaScript API,
just like qt does, but it uses the netscape api
to do the convertion to javascript object.

CMakeLists.txt:
WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):

ewk/EWebKit.h:
ewk/ewk_js.cpp: Added.

(ewk_js_variant_to_npvariant):
(ewk_js_npvariant_to_variant):
(ewk_js_property_has):
(ewk_js_property_get):
(ewk_js_property_set):
(ewk_js_property_remove):
(ewk_js_properties_enumerate):
(ewk_js_method_has):
(ewk_js_method_invoke):
(ewk_js_class_new):
(ewk_js_class_free):
(ewk_js_object_new):
(ewk_js_object_free):
(ewk_js_object_properties_get):
(ewk_js_object_name_get):
(ewk_js_variant_free):

ewk/ewk_js.h: Added.
ewk/ewk_main.cpp:

(ewk_init):

ewk/ewk_private.h:
ewk/ewk_view.cpp:

(ewk_view_js_window_object_clear):
(ewk_view_js_object_add):

ewk/ewk_view.h:

1:48 PM Changeset in webkit [93636] by andreas.kling@nokia.com

1 edit
3 deletes in trunk/Source/WebKit2

[Qt] Unnecessary folders in WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=66583

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-08-23
Reviewed by Benjamin Poulain.

Remove empty autotest folders that were left over from QGraphicsWKView times.

UIProcess/API/qt/tests/qgraphicswkview: Removed.
UIProcess/API/qt/tests/qwkhistory: Removed.
UIProcess/API/qt/tests/qwkpage: Removed.

1:40 PM Changeset in webkit [93635] by pkasting@chromium.org

1 edit
8 moves in trunk/LayoutTests

[chromium] Move result images into correct subdirectory.
https://bugs.webkit.org/show_bug.cgi?id=66618

Unreviewed, file misplacement fix.

platform/chromium-cg-mac/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Copied from platform/chromium-cg-mac/scroll-absolute-layer-with-reflection-expected.png.
platform/chromium-cg-mac/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Copied from platform/chromium-cg-mac/scroll-fixed-layer-with-reflection-expected.png.
platform/chromium-cg-mac/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-fixed-layer-with-transformed-parent-layer-expected.png.
platform/chromium-cg-mac/fast/repaint/scroll-fixed-reflected-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-fixed-reflected-layer-expected.png.
platform/chromium-cg-mac/fast/repaint/scroll-in-clipped-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-in-clipped-layer-expected.png.
platform/chromium-cg-mac/fast/repaint/scroll-in-fixed-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-in-fixed-layer-expected.png.
platform/chromium-cg-mac/fast/repaint/scroll-in-transformed-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-in-transformed-layer-expected.png.
platform/chromium-cg-mac/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-with-transformed-parent-layer-expected.png.
platform/chromium-cg-mac/scroll-absolute-layer-with-reflection-expected.png: Removed.
platform/chromium-cg-mac/scroll-fixed-layer-with-reflection-expected.png: Removed.
platform/chromium-cg-mac/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Removed.
platform/chromium-cg-mac/scroll-fixed-reflected-layer-expected.png: Removed.
platform/chromium-cg-mac/scroll-in-clipped-layer-expected.png: Removed.
platform/chromium-cg-mac/scroll-in-fixed-layer-expected.png: Removed.
platform/chromium-cg-mac/scroll-in-transformed-layer-expected.png: Removed.
platform/chromium-cg-mac/scroll-with-transformed-parent-layer-expected.png: Removed.

1:34 PM Changeset in webkit [93634] by Lucas Forschler

3 edits in tags/Safari-534.49.2/Source/WebKit2

Merge r93546.

1:32 PM Changeset in webkit [93633] by Lucas Forschler

1 copy in tags/Safari-534.49.2

New tag.

1:19 PM Changeset in webkit [93632] by adamk@chromium.org

4 edits in trunk/Source/WebKit/chromium

[chromium] Remove a few FIXME #defines in API headers
https://bugs.webkit.org/show_bug.cgi?id=66791

Reviewed by James Robinson.

DEPS:

Roll chromium_rev to r97891.

public/WebFileSystem.h:

#define made obsolete in http://crrev.com/97520.

public/WebKitClient.h:

#define made obsolete in http://crrev.com/97524 and
http://crrev.com/97891.

1:10 PM Changeset in webkit [93631] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fixed warnings produced by gcc-4.6.0.
https://bugs.webkit.org/show_bug.cgi?id=62168

Patch by Ahmad Sharif <asharif@chromium.org> on 2011-08-23
Reviewed by Adam Barth.

dom/Element.cpp:

(WebCore::Element::recalcStyle):

platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::PerAxisData::curveAt):
(WebCore::ScrollAnimatorNone::PerAxisData::curveDerivativeAt):

thirdparty: Copied from Source/WebCore/thirdparty.

1:08 PM Changeset in webkit [93630] by Patrick Gansterer

2 edits in trunk/Tools

Add missing quotes around filenames in mergeChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=66794

Reviewed by Adam Roben.

Scripts/VCSUtils.pm:

(mergeChangeLogs):

1:00 PM BuildingQtOnLinux edited by andreas.kling@nokia.com

(diff)

12:58 PM Changeset in webkit [93629] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Attempt to make test expectations more accurate.

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

12:54 PM Changeset in webkit [93628] by commit-queue@webkit.org

6 edits
3 adds in trunk

Text overlaps with the floats
https://bugs.webkit.org/show_bug.cgi?id=66671

Source/WebCore:

The problem was that LineWidth::fitBelowFloats is not updating the m_left and m_right fields.
Next time LineWidth::shrinkAvailableWidthForNewFloatIfNeeded was called the width was recalculated
using the old values, making the line bigger.

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-23
Reviewed by David Hyatt.

Test: fast/block/float/fit_line_below_floats.html

rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::fitBelowFloats):

LayoutTests:

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-23
Reviewed by David Hyatt.

fast/block/float/fit_line_below_floats.html: Added.
platform/chromium/test_expectations.txt:
platform/gtk/Skipped:
platform/mac/fast/block/float/fit_line_below_floats-expected.png: Added.
platform/mac/fast/block/float/fit_line_below_floats-expected.txt: Added.
platform/qt/Skipped:

12:44 PM Changeset in webkit [93627] by commit-queue@webkit.org

11 edits
8 adds in trunk

[CSSRegions] RenderFlowThread layout should use the attached region sizes
https://bugs.webkit.org/show_bug.cgi?id=66143

Source/WebCore:

When RenderFlowThread is doing the layout it also sets the current RenderFlowThread on
the RenderView. RenderFlowThread cannot be nested inside a single RenderView, so there's no
need to put that on the LayoutState.

The right offset used to layout the inlines inside a RenderFlowThread
is now adjusted to fit inside the current region.

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-23
Reviewed by David Hyatt.

Tests: fast/regions/webkit-flow-floats-inside-regions-bounds.html

fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl.html
fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html
fast/regions/webkit-flow-inlines-inside-regions-bounds.html

rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
(WebCore::RenderBlock::logicalRightOffsetForLine):

rendering/RenderBlock.h:
rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::renderRegionForLine):
(WebCore::RenderFlowThread::regionLogicalWidthForLine):

rendering/RenderFlowThread.h:

(WebCore::RegionFittingDisabler::RegionFittingDisabler):
(WebCore::RegionFittingDisabler::~RegionFittingDisabler):

rendering/RenderRegion.cpp:

(WebCore::RenderRegion::layout):

rendering/RenderRegion.h:
rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

rendering/RenderView.h:

(WebCore::RenderView::hasRenderFlowThread):
(WebCore::RenderView::currentRenderFlowThread):
(WebCore::RenderView::setCurrentRenderFlowThread):
(WebCore::RenderView::pushLayoutState):

LayoutTests:

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-23
Reviewed by David Hyatt.

fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
fast/regions/webkit-flow-floats-inside-regions-bounds.html: Added.
fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl.html: Added.
fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html: Added.
fast/regions/webkit-flow-inlines-inside-regions-bounds.html: Added.

12:38 PM Changeset in webkit [93626] by commit-queue@webkit.org

8 edits
6 adds in trunk

Text-indent and floats push the text out of the container box
https://bugs.webkit.org/show_bug.cgi?id=66662

Source/WebCore:

Text indent was not propagated when a new float was pushed on the line.
It was only calculated when the logicalLeft/RightOffsetForLine was called.
Because of that RenderBlock::LineBreaker::nextLineBreak used a bigger width
than actually available and made the line render on top of the borders.

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-23
Reviewed by David Hyatt.

Tests: fast/block/float/floats-and-text-indent-rl.html

fast/block/float/floats-and-text-indent.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::textIndentOffset):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):

rendering/RenderBlock.h:
rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

LayoutTests:

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-23
Reviewed by David Hyatt.

fast/block/float/floats-and-text-indent-rl.html: Added.
fast/block/float/floats-and-text-indent.html: Added.
platform/chromium/test_expectations.txt:
platform/gtk/Skipped:
platform/mac/fast/block/float/floats-and-text-indent-expected.png: Added.
platform/mac/fast/block/float/floats-and-text-indent-expected.txt: Added.
platform/mac/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
platform/mac/fast/block/float/floats-and-text-indent-rl-expected.txt: Added.
platform/qt/Skipped:

12:30 PM Changeset in webkit [93625] by commit-queue@webkit.org

8 edits in trunk/Source

Add shareResources flag to 3D graphics context attributes
https://bugs.webkit.org/show_bug.cgi?id=66516

Patch by Al Patrick <apatrick@chromium.org> on 2011-08-23
Reviewed by James Robinson.

Source/WebCore:

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::create):

platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::Attributes::Attributes):

platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::create):

Source/WebKit/chromium:

public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::Attributes::Attributes):

src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::initialize):

src/WebViewImpl.cpp:

(std::getCompositorContextAttributes):

12:28 PM Changeset in webkit [93624] by barraclough@apple.com

10 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=55347
"name" and "message" enumerable on *Error.prototype

Reviewed by Sam Weinig.

Source/JavaScriptCore:

The default value of a NativeErrorPrototype's message
property is "", not the name of the error.

runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::NativeErrorConstructor):

runtime/NativeErrorConstructor.h:

(JSC::NativeErrorConstructor::create):
(JSC::NativeErrorConstructor::constructorBody):

runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::constructorBody):

runtime/NativeErrorPrototype.h:

(JSC::NativeErrorPrototype::create):

runtime/StringPrototype.cpp:

(JSC::StringPrototype::StringPrototype):

runtime/StringPrototype.h:

(JSC::StringPrototype::create):

LayoutTests:

fast/js/exception-properties-expected.txt:
fast/js/script-tests/exception-properties.js:
- Add tests for value of RangeError.proto.{name|message}

12:27 PM Changeset in webkit [93623] by Patrick Gansterer

2 edits in trunk/Tools

webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
https://bugs.webkit.org/show_bug.cgi?id=49080

Reviewed by Adam Roben.

Use the string form of pipe open instead (like we do at all other places).

Scripts/VCSUtils.pm:

(mergeChangeLogs):

12:21 PM Changeset in webkit [93622] by fsamuel@chromium.org

2 edits in trunk/Source/WebKit/chromium

New MainFrame views should inherit fixed layout settings from existing MainFrame view in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=66780

Fixed layout mode is set from WebViewImpl, but new main FrameViews are created on loading new pages. The new page's FrameView should get its
fixed layout settings from the current page.

Reviewed by Darin Fisher.

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):

12:07 PM Changeset in webkit [93621] by commit-queue@webkit.org

7 edits
6 deletes in trunk

Unreviewed, rolling out r93616.
http://trac.webkit.org/changeset/93616
https://bugs.webkit.org/show_bug.cgi?id=66796

"causes fast/css/absolute-child-with-percent-height-inside-
relative-parent.html to fail" (Requested by mwenge2 on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-23

Source/WebCore:

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustPositionedBlock):

rendering/RenderBlock.h:
rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::setStaticPositions):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):

LayoutTests:

fast/inline/absolute-positioned-block-in-centred-block-expected.png: Removed.
fast/inline/absolute-positioned-block-in-centred-block-expected.txt: Removed.
fast/inline/absolute-positioned-block-in-centred-block.html: Removed.
fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Removed.
fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Removed.
fast/inline/absolute-positioned-inline-in-centred-block.html: Removed.
platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:

11:46 AM Changeset in webkit [93620] by jocelyn.turcotte@nokia.com

2 edits in trunk/Source/WebKit2

[Qt][WK2] Fix an awful memory leak introduced in r92376.
https://bugs.webkit.org/show_bug.cgi?id=65528

Reviewed by Benjamin Poulain.

The non-virtual destructor would create a leak of the tile update buffer because
the NodeUpdateSetTexture's QImage member destructor wouldn't be called.

UIProcess/qt/SGAgent.h:

(WebKit::NodeUpdate::~NodeUpdate):

11:42 AM Changeset in webkit [93619] by kerz@chromium.org

2 edits in branches/chromium/835/Source/WebCore

Merge 92159 - Shard webcore_remaining for msvs official builds

https://bugs.webkit.org/show_bug.cgi?id=65475

Patch by Bradley Nelson <bradnelson@chromium.org> on 2011-08-01
Reviewed by Darin Fisher.

webcore_remaining has consistently exceeded Visual Studio 2008's
capacity to link when link time code generation is turned on (full
release builds). This has been dealt with the past by carving off
larger and larger pieces of webcore_remaining (ie webcore_html,
webcore_renderer etc).
A new option has been added to gyp to automate this sharding:
'msvs_shard': SHARD_COUNT,
Targets marked in this way will be built in several pieces
(target_0, target_1...).
Since the resulting project is less comprehensible in the IDE (and
since the linking limitation only afflicts official builds), this
option is only needed for those builds.
This patch shards webcore_remaining into 10 parts for official builds.

WebCore.gyp/WebCore.gyp:

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7715011

11:30 AM Changeset in webkit [93618] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit/chromium

[chromium] Update WebSettings to support per-script font settings
https://bugs.webkit.org/show_bug.cgi?id=66220

Patch by Matt Falkenhagen <falken@chromium.org> on 2011-08-23
Reviewed by Tony Chang.

WebKit.gyp:
public/WebSettings.h:
src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setStandardFontFamily):
(WebKit::WebSettingsImpl::setFixedFontFamily):
(WebKit::WebSettingsImpl::setSerifFontFamily):
(WebKit::WebSettingsImpl::setSansSerifFontFamily):
(WebKit::WebSettingsImpl::setCursiveFontFamily):
(WebKit::WebSettingsImpl::setFantasyFontFamily):

src/WebSettingsImpl.h:

11:27 AM Changeset in webkit [93617] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/efl

[EFL] Do not treat valid cases in ewk_frame_child_add() as failures.
https://bugs.webkit.org/show_bug.cgi?id=66692

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Rubber-stamped by Kenneth Rohde Christiansen.

Frame::page() and FrameTree::parent() returning 0 were being considered
failure cases, however it is possible for them to return 0 when some
arbitrary JavaScript is run.

The function's return type has been changed to make it easier to convey
these cases to the caller (which is only ewk_view_frame_create).

This should make tests like
fast/dom/null-page-show-modal-dialog-crash.html stop outputting
erroneous messages to stderr.

ewk/ewk_frame.cpp:

(ewk_frame_child_add):

ewk/ewk_private.h:

11:11 AM Changeset in webkit [93616] by robert@webkit.org

7 edits
6 adds in trunk

div align="center" rendering problem
https://bugs.webkit.org/show_bug.cgi?id=4860

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/inline/absolute-positioned-block-in-centred-block.html

fast/inline/absolute-positioned-inline-in-centred-block.html

When an element with absolute position was the sole or first child of a render block with
centred alignment, it wasn't obeying its parent's alignment. However it would obey the
alignment if it was preceded by some text. The problem was that the element's render object
was getting skipped as leading white space, so it was not included in a normal line block in
a bidi run. Instead, its position was getting set by RenderBlockLineLayout::setStaticPositions()
which does not pay attention to alignment. Preceding the element with some text allowed the object
to get included in a Bidi run and so get a linebox which would get properly aligned.

The fix is to get RenderBlockLineLayout::setStaticPositions() to obey the alignment specified by
the object's container. This allows WebKit to get the same result on the test as Firefox and IE.
Opera has the same bug as unpatched WebKit.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustPositionedBlock): use startAlignedOffsetForBlock

rendering/RenderBlock.h:
rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::updateLogicalWidthForAlignment):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Move the alignment check to updateLogicalWidthForAlignment.
(WebCore::setStaticPositions): use startAlignedOffsetForLine and use startAlignedOffsetForBlock
(WebCore::RenderBlock::LineBreaker::nextLineBreak): use startAlignedOffsetForLine
(WebCore::RenderBlock::startAlignedOffsetForBlock): New function, find the aligned offset using updateLogicalWidthForAlignment
(WebCore::RenderBlock::startAlignedOffsetForLine): ditto

rendering/RenderBlock.h:
rendering/RenderBlockLineLayout.cpp:

LayoutTests:

fast/inline/absolute-positioned-block-in-centred-block-expected.png: Added.
fast/inline/absolute-positioned-block-in-centred-block-expected.txt: Added.
fast/inline/absolute-positioned-block-in-centred-block.html: Added.
fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
fast/inline/absolute-positioned-inline-in-centred-block.html: Added.
platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Both of these two tests were based on the incorrect behaviour of ignoring the alignment specified by the container of an element absolute position when there was no text preceding the element. The updated results agree with Firefox and IE.

11:08 AM Changeset in webkit [93615] by enne@google.com

15 edits in trunk/Source/WebCore

[chromium] Remove LayerRendererChromium references from TiledLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=66433

Reviewed by James Robinson.

Covered by existing tests.

Updated TiledLayerChromium and the texture updater classes to not
access LayerRendererChromium or cache GraphicsContext3D. Some settings
like max texture size were moved from LayerRendererChromium to
CCLayerTreeHost in order to facilitate this refactoring.

LayerTextureUpdaterSkPicture has been #ifdef'd to only work when the
compositor is not threaded. It will need to be refactored more in
order to not own graphics resources from the main thread.

platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::createTextureUpdater):

platform/graphics/chromium/ContentLayerChromium.h:
platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::create):
(WebCore::ImageLayerTextureUpdater::updateTextureRect):
(WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater):
(WebCore::ImageLayerChromium::paintContentsIfDirty):
(WebCore::ImageLayerChromium::createTextureUpdater):

platform/graphics/chromium/ImageLayerChromium.h:
platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setLayerRenderer):
(WebCore::LayerChromium::setLayerTreeHost):

platform/graphics/chromium/LayerChromium.h:
platform/graphics/chromium/LayerRendererChromium.cpp:
platform/graphics/chromium/LayerRendererChromium.h:
platform/graphics/chromium/LayerTextureUpdater.h:

(WebCore::LayerTextureUpdater::LayerTextureUpdater):

platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterCanvas::LayerTextureUpdaterCanvas):
(WebCore::LayerTextureUpdaterBitmap::create):
(WebCore::LayerTextureUpdaterBitmap::LayerTextureUpdaterBitmap):
(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::create):
(WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):

platform/graphics/chromium/LayerTextureUpdaterCanvas.h:

(WebCore::LayerTextureUpdaterSkPicture::context):

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::prepareToUpdate):

platform/graphics/chromium/TiledLayerChromium.h:
platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::layerRenderer):
(WebCore::CCLayerTreeHost::contextSupportsMapSub):
(WebCore::CCLayerTreeHost::maxTextureSize):
(WebCore::CCLayerTreeHost::bestTextureFormat):

11:02 AM Changeset in webkit [93614] by jchaffraix@webkit.org

6 edits
40 adds in trunk

Reduce the amount of RenderLayer rectangles' update when scrolling
https://bugs.webkit.org/show_bug.cgi?id=66618

Reviewed by David Hyatt.

Source/WebCore:

This patch avoids recomputing the RenderLayers rectangles if not needed.

The current code path for scrolling would update RenderLayers' repaint rectangles
twice. However we do need to update only children of a fixed element as they are
the only type of layers that move during a scroll.

We just change a call to updateLayerPositions for a call to updateLayerPositionsAfterScroll.
updateLayerPositions being pessimist about the layer's state - because it is called after layout -
it is missing some optimization that can be done during scrolling.

Tests: fast/repaint/scroll-absolute-layer-with-reflection.html

fast/repaint/scroll-fixed-layer-with-reflection.html
fast/repaint/scroll-fixed-layer-with-transformed-parent-layer.html
fast/repaint/scroll-fixed-reflected-layer.html
fast/repaint/scroll-in-clipped-layer.html
fast/repaint/scroll-in-fixed-layer.html
fast/repaint/scroll-in-transformed-layer.html
fast/repaint/scroll-with-transformed-parent-layer.html

rendering/RenderLayer.h:
page/FrameView.cpp:

(WebCore::FrameView::repaintFixedElementsAfterScrolling):
Updated those 2 call sites after updateRepaintRectsAfterScroll renaming.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositionsAfterScroll): Beefed up the method
to take care of also updating the layer's position (that sounded like a bug in
the previous code that is covered by the tests above). Note that we don't care
if one of our ancestor has a fixed position as we are scrolling *inside* this
ancestor.

(WebCore::RenderLayer::scrollTo): Call updateLayerPositionsAfterScroll instead of
updateLayerPositions.

LayoutTests:

fast/repaint/resources/default.css:

Added more shortcuts.

fast/repaint/scroll-absolute-layer-with-reflection-expected.txt: Added.
fast/repaint/scroll-absolute-layer-with-reflection.html: Added.
fast/repaint/scroll-fixed-layer-with-reflection-expected.txt: Added.
fast/repaint/scroll-fixed-layer-with-reflection.html: Added.
fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.txt: Added.
fast/repaint/scroll-fixed-layer-with-transformed-parent-layer.html: Added.
fast/repaint/scroll-fixed-reflected-layer-expected.txt: Added.
fast/repaint/scroll-fixed-reflected-layer.html: Added.
fast/repaint/scroll-in-clipped-layer-expected.txt: Added.
fast/repaint/scroll-in-clipped-layer.html: Added.
fast/repaint/scroll-in-fixed-layer-expected.txt: Added.
fast/repaint/scroll-in-fixed-layer.html: Added.
fast/repaint/scroll-in-transformed-layer-expected.txt: Added.
fast/repaint/scroll-in-transformed-layer.html: Added.
fast/repaint/scroll-with-transformed-parent-layer-expected.txt: Added.
fast/repaint/scroll-with-transformed-parent-layer.html: Added.

Those are a variation on the same theme: scrolling inside a layers (sometimes the layer is itself scrolled)
to show that we are still doing the right thing.

platform/chromium-cg-mac/scroll-absolute-layer-with-reflection-expected.png: Added.
platform/chromium-cg-mac/scroll-fixed-layer-with-reflection-expected.png: Added.
platform/chromium-cg-mac/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
platform/chromium-cg-mac/scroll-fixed-reflected-layer-expected.png: Added.
platform/chromium-cg-mac/scroll-in-clipped-layer-expected.png: Added.
platform/chromium-cg-mac/scroll-in-fixed-layer-expected.png: Added.
platform/chromium-cg-mac/scroll-in-transformed-layer-expected.png: Added.
platform/chromium-cg-mac/scroll-with-transformed-parent-layer-expected.png: Added.
platform/chromium-win/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Added.
platform/chromium-win/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Added.
platform/chromium-win/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
platform/chromium-win/fast/repaint/scroll-fixed-reflected-layer-expected.png: Added.
platform/chromium-win/fast/repaint/scroll-in-clipped-layer-expected.png: Added.
platform/chromium-win/fast/repaint/scroll-in-fixed-layer-expected.png: Added.
platform/chromium-win/fast/repaint/scroll-in-transformed-layer-expected.png: Added.
platform/chromium-win/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Added.
platform/mac/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Added.
platform/mac/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Added.
platform/mac/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
platform/mac/fast/repaint/scroll-fixed-reflected-layer-expected.png: Added.
platform/mac/fast/repaint/scroll-in-clipped-layer-expected.png: Added.
platform/mac/fast/repaint/scroll-in-fixed-layer-expected.png: Added.
platform/mac/fast/repaint/scroll-in-transformed-layer-expected.png: Added.
platform/mac/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Added.

Baseline for Chromium and Mac.

10:47 AM Changeset in webkit [93613] by jpfau@apple.com

2 edits in trunk/Source/WebCore

New XML parser: pretty XML tree viewer
https://bugs.webkit.org/show_bug.cgi?id=66489

Reviewed by Adam Barth.

xml/parser/NewXMLDocumentParser.cpp:

(WebCore::NewXMLDocumentParser::finish):

10:41 AM Changeset in webkit [93612] by caseq@chromium.org

2 edits in trunk/LayoutTests

2011-08-23 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Disabled inspector/extensions/extensions-resources.html.
https://bugs.webkit.org/show_bug.cgi?id=66786

platform/qt/Skipped:

10:08 AM Changeset in webkit [93611] by leandro@webkit.org

2 edits in trunk/Source/WebKit/efl

Unreviewed build fix after r66685.

WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
Assert using the right variable name.

9:31 AM Changeset in webkit [93610] by caseq@chromium.org

4 edits in trunk/LayoutTests

2011-08-23 Andrey Kosyakov <caseq@chromium.org>

Unreviewed test fix following r93605.

http/tests/inspector/resources/extension-main.js: (trimURL):
inspector/extensions/extensions-resources-expected.txt:
inspector/extensions/extensions-resources.html:

9:25 AM Changeset in webkit [93609] by nduca@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewd, roll chromium reverse DEPS 97698:97834
https://bugs.webkit.org/show_bug.cgi?id=66781

DEPS:

9:20 AM Changeset in webkit [93608] by jberlin@webkit.org

2 edits in trunk/Source/WebCore

Build fix.

inspector/InspectorDOMAgent.h:

HighlightData is a struct, not a class.

9:02 AM Changeset in webkit [93607] by abarth@webkit.org

10 edits in trunk/Tools

garden-o-matic summary should be able to examine failures
https://bugs.webkit.org/show_bug.cgi?id=66748

Reviewed by Dimitri Glazkov.

This patch refactors a bunch of code from summary.js to independent
controllers in controllers.js. This patch also contains the first
iteration of binding the "examine" event to a the behavior showing the
details view for the tests. There's more work to do here to make this
work properly (and elegantly), but this patch is a start.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:

8:48 AM Changeset in webkit [93606] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/efl

[EFL] Treat the case of WebCore::History->currentItem() returning NULL.
https://bugs.webkit.org/show_bug.cgi?id=66698

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Reviewed by Kenneth Rohde Christiansen.

WebCore::History->currentItem() may return NULL, and we'd better treat
it in ewk_history_history_item_current_get itself than propagate the
issue to _ewk_history_item_new.

ewk/ewk_history.cpp:

(ewk_history_history_item_current_get):

ewk/ewk_history.h:

8:35 AM Changeset in webkit [93605] by caseq@chromium.org

10 edits
3 adds in trunk

Web Inspector: [Extensions API] provide access to page resources
https://bugs.webkit.org/show_bug.cgi?id=66767

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/extensions/extensions-resources.html

inspector/front-end/ExtensionAPI.js:

(WebInspector.injectedExtensionAPI.EventSinkImpl.prototype.addListener):
(WebInspector.injectedExtensionAPI):
(WebInspector.injectedExtensionAPI.RequestImpl.prototype.getContent):
(WebInspector.injectedExtensionAPI.InspectedWindow.resourceDispatch):
(WebInspector.injectedExtensionAPI.InspectedWindow.resourceContentDispatch):
(WebInspector.injectedExtensionAPI.InspectedWindow):
(WebInspector.injectedExtensionAPI.InspectedWindow.prototype.eval):
(WebInspector.injectedExtensionAPI.InspectedWindow.prototype.getResources):
(WebInspector.injectedExtensionAPI.InspectedWindow.prototype.getResources.callbackWrapper):
(WebInspector.injectedExtensionAPI.ResourceImpl.prototype.get url):
(WebInspector.injectedExtensionAPI.ResourceImpl.prototype.get type):
(WebInspector.injectedExtensionAPI.ResourceImpl.prototype.getContent):
(WebInspector.injectedExtensionAPI.ResourceImpl.prototype.setContent):

inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._notifyResourceAdded):
(WebInspector.ExtensionServer.prototype.notifyResourceContentCommitted):
(WebInspector.ExtensionServer.prototype._makeResource):
(WebInspector.ExtensionServer.prototype._onGetPageResources):
(WebInspector.ExtensionServer.prototype._getResourceContent):
(WebInspector.ExtensionServer.prototype._onGetRequestContent):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
(WebInspector.ExtensionServer.prototype._onSetResourceContent):
(WebInspector.ExtensionServer.prototype.initExtensions):

inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.addRevision):

LayoutTests:

http/tests/inspector/resources/extension-main.js:

(trimURL):

inspector/extensions/extensions-api-expected.txt:
inspector/extensions/extensions-network-expected.txt:
inspector/extensions/extensions-network.html:
inspector/extensions/extensions-resources-expected.txt: Added.
inspector/extensions/extensions-resources.html: Added.
inspector/extensions/resources/Ahem.ttf:
inspector/extensions/resources/test-script.js: Added.

(test_function):

8:08 AM Changeset in webkit [93604] by pfeldman@chromium.org

3 edits in trunk/Source/WebCore

2011-08-23 Pavel Feldman <pfeldman@google.com>

Not reviewed: fixing build. One line drive-by typo fix in the inspector shortcut (Esc -> Backspace).

inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::highlightFrame):
inspector/front-end/treeoutline.js: (TreeOutline.prototype._treeKeyDown):

7:38 AM Changeset in webkit [93603] by apavlov@chromium.org

13 edits in trunk/Source/WebCore

Web Inspector: differentiate element highlight colors for margin and padding
https://bugs.webkit.org/show_bug.cgi?id=37768

The highlighting WIP API is slightly changed: clients will specify colors for certain elements of the highlighted objects,
rather than a generic "highlighting mode". This allows to:

use entirely custom colors for highlighting (and vary them over time);
display any combination of fill/outline for the highlighted area;
highlight any combinations of element parts.

Reviewed by Pavel Feldman.

inspector/DOMNodeHighlighter.cpp:

(WebCore::DOMNodeHighlighter::drawHighlight):

inspector/DOMNodeHighlighter.h:
inspector/Inspector.json:
inspector/InspectorDOMAgent.cpp:

(WebCore::parseColor):
(WebCore::parseConfigColor):
(WebCore::InspectorDOMAgent::~InspectorDOMAgent):
(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::highlightedNode):
(WebCore::InspectorDOMAgent::handleMousePress):
(WebCore::InspectorDOMAgent::mouseDidMoveOverElement):
(WebCore::InspectorDOMAgent::setSearchingForNode):
(WebCore::InspectorDOMAgent::setInspectModeEnabled):
(WebCore::InspectorDOMAgent::setHighlightDataFromConfig):
(WebCore::InspectorDOMAgent::highlight):
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightFrame):
(WebCore::InspectorDOMAgent::hideHighlight):
(WebCore::InspectorDOMAgent::drawHighlight):

inspector/InspectorDOMAgent.h:
inspector/front-end/Color.js:

(WebInspector.Color.fromRGBA):
(WebInspector.Color.prototype.toProtocolRGBA):

inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.setSearchingForNode):

inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode.handleMouseOver):
(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode.handleMouseOut):
(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode):

inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameTreeElement.prototype.set hovered):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._highlightRect):

inspector/front-end/inspector.css:
inspector/front-end/inspector.js:

(WebInspector.buildHighlightConfig):
(WebInspector.highlightDOMNode):

6:37 AM Changeset in webkit [93602] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/efl

[EFL] Add auxiliary history functions for DRT
https://bugs.webkit.org/show_bug.cgi?id=66700

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Reviewed by Kent Tamura.

EFL's DumpRenderTree implementation needs some private, auxiliary
functions in ewk in order to iterate and dump the history tree when
necessary.

ewk/ewk_history.cpp:

(ewk_history_item_target_get):
(ewk_history_item_target_is):
(ewk_history_item_children_get):

ewk/ewk_private.h:

6:36 AM Changeset in webkit [93601] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r93579.
http://trac.webkit.org/changeset/93579
https://bugs.webkit.org/show_bug.cgi?id=66774

"ASSERTION FAILED: m_purgePreventCount" (Requested by tonyg-cr
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-23

platform/graphics/chromium/FontCacheLinux.cpp:

(WebCore::FontCache::getFontDataForCharacters):

6:26 AM Changeset in webkit [93600] by vestbo@webkit.org

5 edits in trunk/Source

[Qt] Fix build on Lion

https://bugs.webkit.org/show_bug.cgi?id=66770

Reviewed by Andreas Kling.

We were mistakenly picking up mac/WebCoreSystemInterface.h instead of
the Qt one, and building on Lion revealed this when a typedef for
IOSurfaceRef was wrapped in PLATFORM(MAC).

For now we fix this by including WebCoreSystemInterface using
brackets, so that we'll pick up the right file based on the
include paths. This also means exposing a few missing enums
in our own version of the file, so those were added.

Lasty, we need to link against the right system interface library
on Lion.

6:19 AM Changeset in webkit [93599] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/efl

[EFL] Add auxiliary ewk_util functions for DRT.
https://bugs.webkit.org/show_bug.cgi?id=66702

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Reviewed by Kenneth Rohde Christiansen.

Add some auxiliary functions needed by EFL's DRT implementation. They
all revolve around talking to the garbage collector and counting the
worker threads.

ewk/ewk_private.h:
ewk/ewk_util.cpp:

(ewk_util_javascript_gc_collect):
(ewk_util_javascript_gc_alternate_thread_collect):
(ewk_util_javascript_gc_object_count_get):
(ewk_util_worker_thread_count):
(ewk_util_dpi_get):

6:12 AM Changeset in webkit [93598] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Remove a non-existent test from the skipped list.

platform/qt/Skipped:

6:07 AM Changeset in webkit [93597] by steveblock@google.com

4 edits in trunk/Source

Remove last occurrences of PLATFORM(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66763

Reviewed by Tony Gentilcore.

Source/JavaScriptCore:

wtf/Platform.h:

Source/WebCore:

No new tests, removing dead code only.

bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::checkMemoryUsage):

5:45 AM Changeset in webkit [93596] by steveblock@google.com

8 edits in trunk/Source/WebCore

Remove Android-specific modifications to non-client-based Geolocation
https://bugs.webkit.org/show_bug.cgi?id=66759

Reviewed by Tony Gentilcore.

No new tests, removing dead code only.

page/Geolocation.cpp:
page/Geolocation.h:
platform/GeolocationService.h:
platform/efl/GeolocationServiceEfl.cpp:
platform/efl/GeolocationServiceEfl.h:
platform/gtk/GeolocationServiceGtk.cpp:
platform/gtk/GeolocationServiceGtk.h:

5:43 AM Changeset in webkit [93595] by podivilov@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: switch to using BreakpointManager.
https://bugs.webkit.org/show_bug.cgi?id=66225

Reviewed by Pavel Feldman.

inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
(WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationBreakpoint.prototype.loadSnippet):

inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode):

5:40 AM Changeset in webkit [93594] by steveblock@google.com

12 edits in trunk

Remove all mention of removed Android files from build scripts
https://bugs.webkit.org/show_bug.cgi?id=66755

Reviewed by Tony Gentilcore.

Source/cmake/WebKitPackaging.cmake:

Source/JavaScriptCore:

JavaScriptCore.gyp/JavaScriptCore.gyp:
JavaScriptCore.gypi:
gyp/JavaScriptCore.gyp:

Source/WebCore:

No new tests, removing dead code only.

WebCore.gyp/WebCore.gyp:
WebCore.gypi:
gyp/WebCore.gyp:

Source/WebKit2:

Scripts/generate-forwarding-headers.pl:

5:39 AM Changeset in webkit [93593] by tkent@chromium.org

12 edits
6 copies
89 moves
8 adds
1 delete in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=66651
Move <input type=range> tests to fast/forms/range/

Reviewed by Tony Chang.

fast/forms/ValidityState-stepMismatch-expected.txt: Removed 'range' part.
fast/forms/input-appearance-range-rtl-expected.html: Removed.
fast/forms/input-appearance-range-rtl.html: Removed.
fast/forms/input-appearance-range.html: Removed.
fast/forms/input-stepup-stepdown-expected.txt: Removed 'range' part.
fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Removed 'range' part.
fast/forms/input-valueasnumber-range-expected.txt: Removed.
fast/forms/input-valueasnumber-range.html: Removed.
fast/forms/range: Added.
fast/forms/range-default-value-expected.txt: Removed.
fast/forms/range-default-value.html: Removed.
fast/forms/range-drag-expected.txt: Removed.
fast/forms/range-drag.html: Removed.
fast/forms/range-input-dynamic-oninput-expected.txt: Removed.
fast/forms/range-input-dynamic-oninput.html: Removed.
fast/forms/range-keyoperation-expected.txt: Removed.
fast/forms/range-keyoperation.html: Removed.
fast/forms/range-reset-expected.txt: Removed.
fast/forms/range-reset.html: Removed.
fast/forms/range-set-attribute-expected.txt: Removed.
fast/forms/range-set-attribute.html: Removed.
fast/forms/range-thumb-height-percentage.html: Removed.
fast/forms/range/ValidityState-stepMismatch-range-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt.
fast/forms/range/ValidityState-stepMismatch-range.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
fast/forms/range/input-appearance-range-rtl-expected.html: Copied from LayoutTests/fast/forms/input-appearance-range-rtl-expected.html.
fast/forms/range/input-appearance-range-rtl.html: Copied from LayoutTests/fast/forms/input-appearance-range-rtl.html.
fast/forms/range/input-appearance-range.html: Copied from LayoutTests/fast/forms/input-appearance-range.html.
fast/forms/range/input-valueasnumber-range-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-range-expected.txt.
fast/forms/range/input-valueasnumber-range.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-range.js.
fast/forms/range/range-default-value-expected.txt: Copied from LayoutTests/fast/forms/range-default-value-expected.txt.
fast/forms/range/range-default-value.html: Copied from LayoutTests/fast/forms/range-default-value.html.
fast/forms/range/range-drag-expected.txt: Copied from LayoutTests/fast/forms/range-drag-expected.txt.
fast/forms/range/range-drag.html: Copied from LayoutTests/fast/forms/range-drag.html.
fast/forms/range/range-input-dynamic-oninput-expected.txt: Copied from LayoutTests/fast/forms/range-input-dynamic-oninput-expected.txt.
fast/forms/range/range-input-dynamic-oninput.html: Copied from LayoutTests/fast/forms/range-input-dynamic-oninput.html.
fast/forms/range/range-keyoperation-expected.txt: Copied from LayoutTests/fast/forms/range-keyoperation-expected.txt.
fast/forms/range/range-keyoperation.html: Copied from LayoutTests/fast/forms/range-keyoperation.html.
fast/forms/range/range-reset-expected.txt: Copied from LayoutTests/fast/forms/range-reset-expected.txt.
fast/forms/range/range-reset.html: Copied from LayoutTests/fast/forms/range-reset.html.
fast/forms/range/range-set-attribute-expected.txt: Copied from LayoutTests/fast/forms/range-set-attribute-expected.txt.
fast/forms/range/range-set-attribute.html: Copied from LayoutTests/fast/forms/range-set-attribute.html.
fast/forms/range/range-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt.
fast/forms/range/range-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt.
fast/forms/range/range-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
fast/forms/range/range-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
fast/forms/range/range-thumb-height-percentage.html: Copied from LayoutTests/fast/forms/range-thumb-height-percentage.html.
fast/forms/range/slider-delete-while-dragging-thumb-expected.txt: Copied from LayoutTests/fast/forms/slider-delete-while-dragging-thumb-expected.txt.
fast/forms/range/slider-delete-while-dragging-thumb.html: Copied from LayoutTests/fast/forms/slider-delete-while-dragging-thumb.html.
fast/forms/range/slider-hit-testing-expected.txt: Copied from LayoutTests/fast/forms/slider-hit-testing-expected.txt.
fast/forms/range/slider-hit-testing.html: Copied from LayoutTests/fast/forms/slider-hit-testing.html.
fast/forms/range/slider-mouse-events-expected.txt: Copied from LayoutTests/fast/forms/slider-mouse-events-expected.txt.
fast/forms/range/slider-mouse-events.html: Copied from LayoutTests/fast/forms/slider-mouse-events.html.
fast/forms/range/slider-onchange-event-expected.txt: Copied from LayoutTests/fast/forms/slider-onchange-event-expected.txt.
fast/forms/range/slider-onchange-event.html: Copied from LayoutTests/fast/forms/slider-onchange-event.html.
fast/forms/range/slider-padding.html: Copied from LayoutTests/fast/forms/slider-padding.html.
fast/forms/range/slider-thumb-shared-style.html: Copied from LayoutTests/fast/forms/slider-thumb-shared-style.html.
fast/forms/range/slider-thumb-stylability.html: Copied from LayoutTests/fast/forms/slider-thumb-stylability.html.
fast/forms/range/slider-transformed-expected.txt: Copied from LayoutTests/fast/forms/slider-transformed-expected.txt.
fast/forms/range/slider-transformed.html: Copied from LayoutTests/fast/forms/slider-transformed.html.
fast/forms/range/slider-zoomed-expected.txt: Copied from LayoutTests/fast/forms/slider-zoomed-expected.txt.
fast/forms/range/slider-zoomed.html: Copied from LayoutTests/fast/forms/slider-zoomed.html.
fast/forms/range/thumbslider-crash-expected.txt: Copied from LayoutTests/fast/forms/thumbslider-crash-expected.txt.
fast/forms/range/thumbslider-crash.html: Copied from LayoutTests/fast/forms/thumbslider-crash.html.
fast/forms/range/thumbslider-no-parent-slider.html: Copied from LayoutTests/fast/forms/thumbslider-no-parent-slider.html.
fast/forms/script-tests/ValidityState-stepMismatch.js: Removed 'range' part.
fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed 'range' part.
fast/forms/script-tests/input-stepup-stepdown.js: Removed 'range' part.
fast/forms/script-tests/input-valueasnumber-range.js: Removed.
fast/forms/slider-delete-while-dragging-thumb-expected.txt: Removed.
fast/forms/slider-delete-while-dragging-thumb.html: Removed.
fast/forms/slider-hit-testing-expected.txt: Removed.
fast/forms/slider-hit-testing.html: Removed.
fast/forms/slider-mouse-events-expected.txt: Removed.
fast/forms/slider-mouse-events.html: Removed.
fast/forms/slider-onchange-event-expected.txt: Removed.
fast/forms/slider-onchange-event.html: Removed.
fast/forms/slider-padding.html: Removed.
fast/forms/slider-thumb-shared-style.html: Removed.
fast/forms/slider-thumb-stylability.html: Removed.
fast/forms/slider-transformed-expected.txt: Removed.
fast/forms/slider-transformed.html: Removed.
fast/forms/slider-zoomed-expected.txt: Removed.
fast/forms/slider-zoomed.html: Removed.
fast/forms/thumbslider-crash-expected.txt: Removed.
fast/forms/thumbslider-crash.html: Removed.
fast/forms/thumbslider-no-parent-slider.html: Removed.
platform/chromium-cg-mac-leopard/fast/forms/input-appearance-range-expected.png: Removed.
platform/chromium-cg-mac-leopard/fast/forms/range: Added.
platform/chromium-cg-mac-leopard/fast/forms/range/input-appearance-range-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-appearance-range-expected.png.
platform/chromium-cg-mac-leopard/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/slider-padding-expected.png.
platform/chromium-cg-mac-leopard/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/slider-thumb-shared-style-expected.png.
platform/chromium-cg-mac-leopard/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/slider-thumb-stylability-expected.png.
platform/chromium-cg-mac-leopard/fast/forms/range/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/thumbslider-no-parent-slider-expected.png.
platform/chromium-cg-mac-leopard/fast/forms/slider-padding-expected.png: Removed.
platform/chromium-cg-mac-leopard/fast/forms/slider-thumb-shared-style-expected.png: Removed.
platform/chromium-cg-mac-leopard/fast/forms/slider-thumb-stylability-expected.png: Removed.
platform/chromium-cg-mac-leopard/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
platform/chromium-linux/fast/forms/input-appearance-range-expected.png: Removed.
platform/chromium-linux/fast/forms/input-appearance-range-expected.txt: Removed.
platform/chromium-linux/fast/forms/range: Added.
platform/chromium-linux/fast/forms/range-thumb-height-percentage-expected.png: Removed.
platform/chromium-linux/fast/forms/range/input-appearance-range-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-range-expected.png.
platform/chromium-linux/fast/forms/range/input-appearance-range-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-range-expected.txt.
platform/chromium-linux/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/range-thumb-height-percentage-expected.png.
platform/chromium-linux/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/slider-padding-expected.png.
platform/chromium-linux/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/slider-thumb-shared-style-expected.png.
platform/chromium-linux/fast/forms/range/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/thumbslider-no-parent-slider-expected.png.
platform/chromium-linux/fast/forms/slider-padding-expected.png: Removed.
platform/chromium-linux/fast/forms/slider-thumb-shared-style-expected.png: Removed.
platform/chromium-linux/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
platform/chromium-win/fast/forms/input-appearance-range-expected.png: Removed.
platform/chromium-win/fast/forms/input-appearance-range-expected.txt: Removed.
platform/chromium-win/fast/forms/range: Added.
platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.png: Removed.
platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.txt: Removed.
platform/chromium-win/fast/forms/range/input-appearance-range-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-range-expected.png.
platform/chromium-win/fast/forms/range/input-appearance-range-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-range-expected.txt.
platform/chromium-win/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.png.
platform/chromium-win/fast/forms/range/range-thumb-height-percentage-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.txt.
platform/chromium-win/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-padding-expected.png.
platform/chromium-win/fast/forms/range/slider-padding-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-padding-expected.txt.
platform/chromium-win/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.png.
platform/chromium-win/fast/forms/range/slider-thumb-shared-style-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.txt.
platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-thumb-stylability-expected.png.
platform/chromium-win/fast/forms/range/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.png.
platform/chromium-win/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.txt.
platform/chromium-win/fast/forms/slider-padding-expected.png: Removed.
platform/chromium-win/fast/forms/slider-padding-expected.txt: Removed.
platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.png: Removed.
platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.txt: Removed.
platform/chromium-win/fast/forms/slider-thumb-stylability-expected.png: Removed.
platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
platform/chromium/test_expectations.txt:
platform/gtk/Skipped:
platform/gtk/fast/forms/input-appearance-range-expected.txt: Removed.
platform/gtk/fast/forms/range: Added.
platform/gtk/fast/forms/range-thumb-height-percentage-expected.png: Removed.
platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt: Removed.
platform/gtk/fast/forms/range/input-appearance-range-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-range-expected.txt.
platform/gtk/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/range-thumb-height-percentage-expected.png.
platform/gtk/fast/forms/range/range-thumb-height-percentage-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt.
platform/gtk/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/slider-padding-expected.png.
platform/gtk/fast/forms/range/slider-padding-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/slider-padding-expected.txt.
platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/slider-thumb-shared-style-expected.png.
platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt.
platform/gtk/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/slider-thumb-stylability-expected.png.
platform/gtk/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/slider-thumb-stylability-expected.txt.
platform/gtk/fast/forms/range/slider-transformed-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/slider-transformed-expected.txt.
platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt.
platform/gtk/fast/forms/slider-padding-expected.png: Removed.
platform/gtk/fast/forms/slider-padding-expected.txt: Removed.
platform/gtk/fast/forms/slider-thumb-shared-style-expected.png: Removed.
platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt: Removed.
platform/gtk/fast/forms/slider-thumb-stylability-expected.png: Removed.
platform/gtk/fast/forms/slider-thumb-stylability-expected.txt: Removed.
platform/gtk/fast/forms/slider-transformed-expected.txt: Removed.
platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
platform/mac-leopard/fast/forms/range: Added.
platform/mac-leopard/fast/forms/range-thumb-height-percentage-expected.png: Removed.
platform/mac-leopard/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/range-thumb-height-percentage-expected.png.
platform/mac-leopard/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/slider-padding-expected.png.
platform/mac-leopard/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/slider-thumb-shared-style-expected.png.
platform/mac-leopard/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/slider-thumb-stylability-expected.png.
platform/mac-leopard/fast/forms/slider-padding-expected.png: Removed.
platform/mac-leopard/fast/forms/slider-thumb-shared-style-expected.png: Removed.
platform/mac-leopard/fast/forms/slider-thumb-stylability-expected.png: Removed.
platform/mac/fast/forms/input-appearance-range-expected.png: Removed.
platform/mac/fast/forms/input-appearance-range-expected.txt: Removed.
platform/mac/fast/forms/range: Added.
platform/mac/fast/forms/range-thumb-height-percentage-expected.png: Removed.
platform/mac/fast/forms/range-thumb-height-percentage-expected.txt: Removed.
platform/mac/fast/forms/range/input-appearance-range-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-range-expected.png.
platform/mac/fast/forms/range/input-appearance-range-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-range-expected.txt.
platform/mac/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/mac/fast/forms/range-thumb-height-percentage-expected.png.
platform/mac/fast/forms/range/range-thumb-height-percentage-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/range-thumb-height-percentage-expected.txt.
platform/mac/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/mac/fast/forms/slider-padding-expected.png.
platform/mac/fast/forms/range/slider-padding-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/slider-padding-expected.txt.
platform/mac/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/mac/fast/forms/slider-thumb-shared-style-expected.png.
platform/mac/fast/forms/range/slider-thumb-shared-style-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/slider-thumb-shared-style-expected.txt.
platform/mac/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/mac/fast/forms/slider-thumb-stylability-expected.png.
platform/mac/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/slider-thumb-stylability-expected.txt.
platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/mac/fast/forms/thumbslider-no-parent-slider-expected.png.
platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/thumbslider-no-parent-slider-expected.txt.
platform/mac/fast/forms/slider-padding-expected.png: Removed.
platform/mac/fast/forms/slider-padding-expected.txt: Removed.
platform/mac/fast/forms/slider-thumb-shared-style-expected.png: Removed.
platform/mac/fast/forms/slider-thumb-shared-style-expected.txt: Removed.
platform/mac/fast/forms/slider-thumb-stylability-expected.png: Removed.
platform/mac/fast/forms/slider-thumb-stylability-expected.txt: Removed.
platform/mac/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
platform/mac/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
platform/qt-mac/Skipped:
platform/qt/Skipped:
platform/qt/fast/forms/range: Added.
platform/qt/fast/forms/range-thumb-height-percentage-expected.txt: Removed.
platform/qt/fast/forms/range/range-thumb-height-percentage-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/range-thumb-height-percentage-expected.txt.
platform/qt/fast/forms/range/slider-thumb-shared-style-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/slider-thumb-shared-style-expected.txt.
platform/qt/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/slider-thumb-stylability-expected.txt.
platform/qt/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/thumbslider-no-parent-slider-expected.txt.
platform/qt/fast/forms/slider-thumb-shared-style-expected.txt: Removed.
platform/qt/fast/forms/slider-thumb-stylability-expected.txt: Removed.
platform/qt/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
platform/wk2/Skipped:

5:38 AM Changeset in webkit [93592] by benjamin.poulain@nokia.com

3 edits in trunk/Source/WebKit2

[Qt][WK2] ViewportInteractionEngine: the position of the content is not corrected when scaling the page manually
https://bugs.webkit.org/show_bug.cgi?id=66672

Reviewed by Kenneth Rohde Christiansen.

Add the method animateContentIntoBoundariesIfNeeded() to move the content back into both scale and position boundaries.
This method is now used as the entry point for animations in order to avoid bugs regarding scale or position.

The existing animation methods were renamed accordingly for clarity and consistency with the updateContent methods.

UIProcess/qt/ViewportInteractionEngine.cpp:

(WebKit::ViewportInteractionEngine::panGestureEnded):
(WebKit::ViewportInteractionEngine::pinchGestureEnded):
(WebKit::ViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):
(WebKit::ViewportInteractionEngine::animateContentPositionIntoBoundariesIfNeeded):
(WebKit::ViewportInteractionEngine::animateContentScaleIntoBoundariesIfNeeded):

UIProcess/qt/ViewportInteractionEngine.h:

5:21 AM Changeset in webkit [93591] by mnaganov@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] Fix handling of aggregate names in profiler.
https://bugs.webkit.org/show_bug.cgi?id=66753

Reviewed by Pavel Feldman.

inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._buildAggregates):

3:34 AM Changeset in webkit [93590] by abarth@webkit.org

2 edits
18 deletes in trunk/Source

Remove WebCore/editing/android and other Android-specific directories
https://bugs.webkit.org/show_bug.cgi?id=66739

Reviewed by Steve Block.

Now that Android shares more code with Chromium, we don't need these
Android-specific files.

Source/JavaScriptCore:

wtf/android: Removed.
wtf/android/AndroidThreading.h: Removed.
wtf/android/MainThreadAndroid.cpp: Removed.

Source/WebCore:

editing/android: Removed.
editing/android/EditorAndroid.cpp: Removed.
history/android: Removed.
history/android/AndroidWebHistoryBridge.h: Removed.
history/android/HistoryItemAndroid.cpp: Removed.
page/android: Removed.
page/android/DragControllerAndroid.cpp: Removed.
page/android/EventHandlerAndroid.cpp: Removed.
platform/network/android: Removed.
platform/network/android/AuthenticationChallenge.h: Removed.
platform/network/android/CookieJarAndroid.cpp: Removed.
platform/network/android/ProxyServerAndroid.cpp: Removed.
platform/network/android/ResourceError.h: Removed.
platform/network/android/ResourceHandleAndroid.cpp: Removed.
platform/network/android/ResourceLoaderAndroid.h: Removed.
platform/network/android/ResourceRequest.h: Removed.
platform/network/android/ResourceRequestAndroid.cpp: Removed.
platform/network/android/ResourceResponse.h: Removed.
platform/text/android: Removed.
platform/text/android/HyphenationAndroid.cpp: Removed.
platform/text/android/TextBreakIteratorInternalICU.cpp: Removed.

2:59 AM Changeset in webkit [93589] by abarth@webkit.org

1 edit
28 deletes in trunk/Source/WebCore

Remove WebCore/platform/android
https://bugs.webkit.org/show_bug.cgi?id=66734

Reviewed by Steve Block.

This directory is not needed now that Android shares more code with
Chromium.

platform/android: Removed.
platform/android/ClipboardAndroid.cpp: Removed.
platform/android/ClipboardAndroid.h: Removed.
platform/android/CursorAndroid.cpp: Removed.
platform/android/DragDataAndroid.cpp: Removed.
platform/android/EventLoopAndroid.cpp: Removed.
platform/android/FileSystemAndroid.cpp: Removed.
platform/android/GeolocationServiceAndroid.cpp: Removed.
platform/android/GeolocationServiceAndroid.h: Removed.
platform/android/GeolocationServiceBridge.cpp: Removed.
platform/android/GeolocationServiceBridge.h: Removed.
platform/android/KeyEventAndroid.cpp: Removed.
platform/android/LanguageAndroid.cpp: Removed.
platform/android/LocalizedStringsAndroid.cpp: Removed.
platform/android/PlatformBridge.h: Removed.
platform/android/PlatformTouchEventAndroid.cpp: Removed.
platform/android/PlatformTouchPointAndroid.cpp: Removed.
platform/android/PopupMenuAndroid.cpp: Removed.
platform/android/RenderThemeAndroid.cpp: Removed.
platform/android/RenderThemeAndroid.h: Removed.
platform/android/SSLKeyGeneratorAndroid.cpp: Removed.
platform/android/ScreenAndroid.cpp: Removed.
platform/android/ScrollViewAndroid.cpp: Removed.
platform/android/SearchPopupMenuAndroid.cpp: Removed.
platform/android/SharedTimerAndroid.cpp: Removed.
platform/android/SoundAndroid.cpp: Removed.
platform/android/SystemTimeAndroid.cpp: Removed.
platform/android/TemporaryLinkStubs.cpp: Removed.
platform/android/WidgetAndroid.cpp: Removed.

2:52 AM Changeset in webkit [93588] by abarth@webkit.org

2 edits in trunk/Tools

webkitpy/common/config/build.py shouldn't mention non-existant Android directory
https://bugs.webkit.org/show_bug.cgi?id=66737

Reviewed by Steve Block.

This directory doesn't exist anymore now that the Android port shares
more code with Chromium.

Scripts/webkitpy/common/config/build.py:

2:47 AM Changeset in webkit [93587] by pfeldman@chromium.org

1 edit
1 add in trunk/Source/WebCore

2011-08-23 Pavel Feldman <pfeldman@google.com>

Not reviewed. Adding a file that slipped from r93586.

inspector/generate-protocol-externs: Added.

2:33 AM Changeset in webkit [93586] by pfeldman@chromium.org

10 edits
2 adds in trunk

Web Inspector: generate protocol externs API for the front-end compilation.
https://bugs.webkit.org/show_bug.cgi?id=66677

Reviewed by Tony Gentilcore.

Source/WebCore:

inspector/Inspector.json:
inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setAttributesText):

inspector/InspectorDOMAgent.h:
inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):

inspector/InspectorDebuggerAgent.h:
inspector/compile-front-end.sh: Added.
inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.setAttribute):

inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.setBreakpoint):

inspector/front-end/externs.js: Added.

(console.warn):

LayoutTests:

inspector/debugger/debugger-set-breakpoint-regex.html:

2:32 AM Changeset in webkit [93585] by loislo@chromium.org

2 edits in trunk/Source/JavaScriptCore

2011-08-23 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix for compile error on Windows for r93560.

runtime/SamplingCounter.h:

2:23 AM Changeset in webkit [93584] by pfeldman@chromium.org

17 edits in trunk/Source/WebCore

Web Inspector: Prepare utilities.js for compilation.
https://bugs.webkit.org/show_bug.cgi?id=66656

Removes "this" usage in functions, does not define getters for offsets.

Reviewed by Tony Gentilcore.

inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleMessage.prototype._format):
(WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.valueFormatter):

inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.appropriateSelectorFor):
(WebInspector.DOMNode.prototype.isAncestor):
(WebInspector.DOMNode.prototype.isDescendant):
(WebInspector.DOMNode.prototype.isWhitespace):

inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._resizerDragging):
(WebInspector.DataGridNode.prototype.isEventWithinDisclosureTriangle):

inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.get savedHeight):
(WebInspector.Drawer.prototype.onResize):
(WebInspector.Drawer.prototype._startStatusBarDragging):
(WebInspector.Drawer.prototype._statusBarDragging):

inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.updateModifiedNodes):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
(WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes.crumbsAreSmallerThanContainer):

inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype.findTreeElement):
(WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
():

inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject):

inspector/front-end/ResourceTimingView.js:

(WebInspector.ResourceTimingView.createTimingTable):

inspector/front-end/ResourcesPanel.js:

(WebInspector.BaseStorageTreeElement.prototype.isEventWithinDisclosureTriangle):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._startSidebarResizeDrag):

inspector/front-end/SoftContextMenu.js:

(.WebInspector.SoftContextMenu.prototype.show):

inspector/front-end/Toolbar.js:

(WebInspector.ToolbarDropdown.prototype.show):

inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype._updateHoveredElement):

inspector/front-end/inspector.js:

(Number.secondsToString):
(Number.bytesToString):

inspector/front-end/treeoutline.js:

(TreeElement.prototype.isEventWithinDisclosureTriangle):

inspector/front-end/utilities.js:

(setupPrototypeUtilities.Element.prototype.totalOffsetLeft):
(setupPrototypeUtilities.Element.prototype.totalOffsetTop):
(setupPrototypeUtilities.Element.prototype.offsetRelativeToWindow):
(setupPrototypeUtilities):
(setupPrototypeUtilities.):
():

1:50 AM Changeset in webkit [93583] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

Unreviewed gardening. Remove Windows style new lines from the test introduced in r93521.

fast/loader/document-destruction-within-unload-expected.txt:
fast/loader/document-destruction-within-unload.html:

1:43 AM Changeset in webkit [93582] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[WK2] Unreviewed gardening.

platform/wk2/Skipped: Skip fast/frames/focus-controller-crash-change-event.html, because eventSender.keyDown is unimplemented.

1:25 AM Changeset in webkit [93581] by reni@webkit.org

2 edits in trunk/LayoutTests

[Qt] REGRESSION after r93567.
https://bugs.webkit.org/show_bug.cgi?id=66749

Three tests have assertion failed error in debug mode on x86-32 Linux Qt. They are skipped.
Unreviewed gardening.

platform/qt/Skipped:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed