⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 25, 2011:

11:48 PM Changeset in webkit [93856] by yutak@chromium.org
  • 4 edits in trunk/Source/WebCore

WebSocket: Fix indentation of WebSocket header files
​https://bugs.webkit.org/show_bug.cgi?id=67018

Reviewed by Kent Tamura.

No new tests. Style fix only.

  • websockets/WebSocket.h:

(WebCore::WebSocket::create):
(WebCore::WebSocket::toWebSocket):
(WebCore::WebSocket::refEventTarget):
(WebCore::WebSocket::derefEventTarget):

  • websockets/WebSocketChannel.h:

Removed formal parameter name of resumeTimerFired().
(WebCore::WebSocketChannel::create):
(WebCore::WebSocketChannel::refThreadableWebSocketChannel):
(WebCore::WebSocketChannel::derefThreadableWebSocketChannel):
(WebCore::WebSocketChannel::isNonControlOpCode):
(WebCore::WebSocketChannel::isControlOpCode):
(WebCore::WebSocketChannel::isReservedOpCode):

  • websockets/WebSocketHandshake.h:

Removed formal parameter name of setClientProtocol().

11:44 PM Changeset in webkit [93855] by koz@chromium.org
  • 2 edits in trunk/LayoutTests

Update expectations to remove conflict
​https://bugs.webkit.org/show_bug.cgi?id=67020

Unreviewed, expectations update.

Patch by Ben Wells <​benwells@chromium.org> on 2011-08-25

  • platform/chromium/test_expectations.txt:
11:41 PM Changeset in webkit [93854] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

Touch GtkVersioning.c so that the release bot rebuilds it. This
is necessary because of the switch to GTK+ 3.x.

  • platform/gtk/GtkVersioning.c: Touch this file.
11:23 PM Changeset in webkit [93853] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=67016

Unreviewed, test expectations update.

Patch by Jeremy Apthorp <​jeremya@google.com> on 2011-08-25

  • platform/chromium/test_expectations.txt:
10:35 PM Changeset in webkit [93852] by Martin Robinson
  • 206 edits
    1 add in trunk

Reviewed by Xan Lopez.

.:

[GTK] Switch to GTK+ 3.x by default
​https://bugs.webkit.org/show_bug.cgi?id=63047

  • configure.ac: Modify the default value of the --with-gtk option to be 3.0.

LayoutTests:

Update GTK+ result that depend on the GTK+ version.

  • platform/gtk/css2.1/t09-c5526c-display-00-e-expected.png:
  • platform/gtk/css2.1/t09-c5526c-display-00-e-expected.txt:
  • platform/gtk/editing/pasteboard/4641033-expected.png:
  • platform/gtk/editing/pasteboard/4641033-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-1-expected.png:
  • platform/gtk/editing/pasteboard/4944770-1-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-2-expected.png:
  • platform/gtk/editing/pasteboard/4944770-2-expected.txt:
  • platform/gtk/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png: Added.
  • platform/gtk/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
  • platform/gtk/editing/selection/caret-before-select-expected.png:
  • platform/gtk/editing/selection/caret-before-select-expected.txt:
  • platform/gtk/editing/selection/replaced-boundaries-3-expected.png:
  • platform/gtk/editing/selection/replaced-boundaries-3-expected.txt:
  • platform/gtk/editing/selection/select-box-expected.png:
  • platform/gtk/editing/selection/select-box-expected.txt:
  • platform/gtk/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/gtk/editing/selection/select-element-paragraph-boundary-expected.txt:
  • platform/gtk/fast/block/basic/011-expected.png:
  • platform/gtk/fast/block/basic/011-expected.txt:
  • platform/gtk/fast/block/float/float-avoidance-expected.png:
  • platform/gtk/fast/block/float/float-avoidance-expected.txt:
  • platform/gtk/fast/block/margin-collapse/103-expected.png:
  • platform/gtk/fast/block/margin-collapse/103-expected.txt:
  • platform/gtk/fast/css/non-standard-checkbox-size-expected.txt:
  • platform/gtk/fast/forms/001-expected.png:
  • platform/gtk/fast/forms/001-expected.txt:
  • platform/gtk/fast/forms/003-expected.png:
  • platform/gtk/fast/forms/003-expected.txt:
  • platform/gtk/fast/forms/004-expected.png:
  • platform/gtk/fast/forms/004-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/gtk/fast/forms/basic-inputs-expected.png:
  • platform/gtk/fast/forms/basic-inputs-expected.txt:
  • platform/gtk/fast/forms/basic-selects-expected.png:
  • platform/gtk/fast/forms/basic-selects-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.png:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/checkbox-radio-onchange-expected.png:
  • platform/gtk/fast/forms/checkbox-radio-onchange-expected.txt:
  • platform/gtk/fast/forms/control-clip-overflow-expected.png:
  • platform/gtk/fast/forms/control-clip-overflow-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.png:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.png:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
  • platform/gtk/fast/forms/file-input-disabled-expected.png:
  • platform/gtk/fast/forms/file-input-disabled-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.png:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/formmove-expected.png:
  • platform/gtk/fast/forms/formmove-expected.txt:
  • platform/gtk/fast/forms/formmove2-expected.png:
  • platform/gtk/fast/forms/formmove2-expected.txt:
  • platform/gtk/fast/forms/indeterminate-expected.png:
  • platform/gtk/fast/forms/indeterminate-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.png:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-number-rtl-expected.png:
  • platform/gtk/fast/forms/input-appearance-number-rtl-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.png:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.png:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
  • platform/gtk/fast/forms/input-value-expected.png:
  • platform/gtk/fast/forms/input-value-expected.txt:
  • platform/gtk/fast/forms/menulist-clip-expected.png:
  • platform/gtk/fast/forms/menulist-clip-expected.txt:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.png:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.png:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.png:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.png:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
  • platform/gtk/fast/forms/menulist-style-color-expected.png:
  • platform/gtk/fast/forms/menulist-style-color-expected.txt:
  • platform/gtk/fast/forms/menulist-width-change-expected.png:
  • platform/gtk/fast/forms/menulist-width-change-expected.txt:
  • platform/gtk/fast/forms/option-script-expected.png:
  • platform/gtk/fast/forms/option-script-expected.txt:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.png:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
  • platform/gtk/fast/forms/option-text-clip-expected.png:
  • platform/gtk/fast/forms/option-text-clip-expected.txt:
  • platform/gtk/fast/forms/radio-attr-order-expected.png:
  • platform/gtk/fast/forms/radio-attr-order-expected.txt:
  • platform/gtk/fast/forms/radio-nested-labels-expected.png:
  • platform/gtk/fast/forms/radio-nested-labels-expected.txt:
  • platform/gtk/fast/forms/radio_checked-expected.png:
  • platform/gtk/fast/forms/radio_checked-expected.txt:
  • platform/gtk/fast/forms/radio_checked_dynamic-expected.png:
  • platform/gtk/fast/forms/radio_checked_dynamic-expected.txt:
  • platform/gtk/fast/forms/select-align-expected.png:
  • platform/gtk/fast/forms/select-align-expected.txt:
  • platform/gtk/fast/forms/select-background-none-expected.png:
  • platform/gtk/fast/forms/select-background-none-expected.txt:
  • platform/gtk/fast/forms/select-baseline-expected.png:
  • platform/gtk/fast/forms/select-baseline-expected.txt:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.png:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.png:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.png:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
  • platform/gtk/fast/forms/select-empty-option-height-expected.png:
  • platform/gtk/fast/forms/select-empty-option-height-expected.txt:
  • platform/gtk/fast/forms/select-initial-position-expected.png:
  • platform/gtk/fast/forms/select-initial-position-expected.txt:
  • platform/gtk/fast/forms/select-selected-expected.png:
  • platform/gtk/fast/forms/select-selected-expected.txt:
  • platform/gtk/fast/forms/select-size-expected.png:
  • platform/gtk/fast/forms/select-size-expected.txt:
  • platform/gtk/fast/forms/select-style-expected.png:
  • platform/gtk/fast/forms/select-style-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.png:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.png:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/selectlist-minsize-expected.png:
  • platform/gtk/fast/forms/selectlist-minsize-expected.txt:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.png:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/gtk/fast/inline/positionedLifetime-expected.png:
  • platform/gtk/fast/inline/positionedLifetime-expected.txt:
  • platform/gtk/fast/invalid/014-expected.png:
  • platform/gtk/fast/invalid/014-expected.txt:
  • platform/gtk/fast/invalid/residual-style-expected.png:
  • platform/gtk/fast/invalid/residual-style-expected.txt:
  • platform/gtk/fast/parser/bad-xml-slash-expected.png:
  • platform/gtk/fast/parser/bad-xml-slash-expected.txt:
  • platform/gtk/fast/parser/document-write-option-expected.png:
  • platform/gtk/fast/parser/document-write-option-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-expected.png:
  • platform/gtk/fast/replaced/replaced-breaking-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/gtk/fast/replaced/table-percent-height-expected.txt:
  • platform/gtk/fast/replaced/three-selects-break-expected.png:
  • platform/gtk/fast/replaced/three-selects-break-expected.txt:
  • platform/gtk/fast/replaced/width100percent-checkbox-expected.png:
  • platform/gtk/fast/replaced/width100percent-checkbox-expected.txt:
  • platform/gtk/fast/replaced/width100percent-menulist-expected.png:
  • platform/gtk/fast/replaced/width100percent-menulist-expected.txt:
  • platform/gtk/fast/replaced/width100percent-radio-expected.png:
  • platform/gtk/fast/replaced/width100percent-radio-expected.txt:
  • platform/gtk/fast/text/international/bidi-menulist-expected.png:
  • platform/gtk/fast/text/international/bidi-menulist-expected.txt:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.png:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/gtk/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/gtk/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
  • platform/gtk/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1318-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug29326-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4527-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/gtk/tables/mozilla/core/margins-expected.png:
  • platform/gtk/tables/mozilla/core/margins-expected.txt:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.png:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/gtk/transforms/2d/zoom-menulist-expected.png:
  • platform/gtk/transforms/2d/zoom-menulist-expected.txt:
9:59 PM Changeset in webkit [93851] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Enable fullscreen API in Chromium by default.
​https://bugs.webkit.org/show_bug.cgi?id=66993

Patch by Jeremy Apthorp <​jeremya@google.com> on 2011-08-25
Reviewed by Adam Barth.

  • features.gypi:
9:27 PM Changeset in webkit [93850] by commit-queue@webkit.org
  • 6 edits in trunk

Use PATH_BASED_BORDER_RADIUS_DRAWING for skia
​https://bugs.webkit.org/show_bug.cgi?id=65583

Source/WebCore:

This change brings in the new border rendering for Skia. To support this without aliasing the skia
graphics context has been updated to support anti-aliased clipping around convex polygons and also
anti-aliased clipping outside a path.

Patch by Ben Wells <​benwells@chromium.org> on 2011-08-25
Reviewed by James Robinson.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipConvexPolygon):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::clipPathAntiAliased):

  • rendering/RenderObject.h:

LayoutTests:

Patch by Ben Wells <​benwells@chromium.org> on 2011-08-25
Reviewed by James Robinson.

Update expectations: added failures for baselines to come. removed some
failure expectations for tests that now pass and moved some expectations
into the group of tests to be rebaselined.

  • platform/chromium/test_expectations.txt:
7:54 PM Changeset in webkit [93849] by Martin Robinson
  • 2 edits in trunk/LayoutTests

Skip some tests on GTK+ that are missing DRT functionality. Also
reorganize some failures on the skipped list.

  • platform/gtk/Skipped: Update the skipped list.
6:32 PM Changeset in webkit [93848] by macpherson@chromium.org
  • 5 edits in trunk/Source/WebCore

Implement animation and transition properties in CSSStyleApplyProperty.
​https://bugs.webkit.org/show_bug.cgi?id=66126

Reviewed by Dean Jackson.

No new tests. This is essentially a refactoring of the HANDLE_ANIMATION* and HANDLE_TRANSITION* macros in CSSStyleSelector.cpp.
The only functional change is to iterate correctly over the lists instead of setting only the first element. See bug 66118 for details on that.

  • css/CSSStyleApplyProperty.cpp:

Added new class ApplyPropertyAnimation to handle animation and transition properties.
(WebCore::ApplyPropertyAnimation::ApplyPropertyAnimation):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyAnimation::setValue):
(WebCore::ApplyPropertyAnimation::value):
(WebCore::ApplyPropertyAnimation::test):
(WebCore::ApplyPropertyAnimation::clear):
(WebCore::ApplyPropertyAnimation::initial):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::accessAnimations):
(WebCore::ApplyPropertyAnimation::animations):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

Removed animation and transition macros (celebrate!)
(WebCore::CSSStyleSelector::applyProperty):
Removed old implementations of animation and transition properties.

  • platform/animation/Animation.h:

Changed return types of initial values to match the setters and getters.
(WebCore::Animation::initialAnimationDelay):
(WebCore::Animation::initialAnimationName):
(WebCore::Animation::initialAnimationTimingFunction):

6:06 PM Changeset in webkit [93847] by Dimitri Glazkov
  • 3 edits
    3 adds
    1 delete in trunk/Tools

Reorganize garden-o-matic CSS files to match JS-built views.
​https://bugs.webkit.org/show_bug.cgi?id=66998

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
6:05 PM Changeset in webkit [93846] by pkasting@chromium.org
  • 6 edits in trunk/LayoutTests

Temporarily mark some tests as crashing (assertion failure) after r93794.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:
6:02 PM Changeset in webkit [93845] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

kNPEventStartIME doesn't work correctly for NPAPI
​https://bugs.webkit.org/show_bug.cgi?id=65264
<rdar://problem/9996476>

Reviewed by Sam Weinig.

In order to remain compatible with older plug-ins, the updated input model won't
be turned on unless a plug-in explicitly asks whether we support it. The plug-in must do
this before any keyboard events have been processed.

  • PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::setComplexTextInputState):
Add the CoreIPC::DispatchMessageEvenWhenWaitingForSyncReply flag to this message since we want
the web process to handle it while it's waiting for a reply to the PluginControllerProxy::HandleMouseEvent
synchronous message.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Implement the logic for when to turn off the legacy Cocoa text input model support.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_ignoreNextKeyUpEvent to false.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add m_ignoreNextKeyUpEvent member variable.

(WebKit::NetscapePlugin::hasHandledAKeyDownEvent):
Add a getter.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Don't send keydown and keyup events when complex text input is enabled in the updated model.

5:54 PM Changeset in webkit [93844] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Correctly handle events in the updated Cocoa text input model
​https://bugs.webkit.org/show_bug.cgi?id=67005

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKTextInputWindowController.mm:

(-[WKTextInputPanel _interpretKeyEvent:usingLegacyCocoaTextInput:string:]):
When using the updated model, always return a string even for 'simple' characters.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _tryHandlePluginComplexTextInputKeyDown:]):
Only let the input method have a crack at the event in the legacy model.

5:51 PM Changeset in webkit [93843] by jeffm@apple.com
  • 3 edits in trunk/Source/WebKit2

Move Windows-specific WebPageProxy code to WebPageProxyWin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=67002

Reviewed by Brian Weinstein.

  • UIProcess/WebPageProxy.cpp: Moved Windows-only functions to WebPageProxyWin.cpp.


  • UIProcess/win/WebPageProxyWin.cpp:

(WebKit::WebPageProxy::firstRectForCharacterInSelectedRange): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::getSelectedText): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::gestureWillBegin): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::gestureDidScroll): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::gestureDidEnd): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::setGestureReachedScrollingLimit): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::startDragDrop): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::didChangeCompositionSelection): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::confirmComposition): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::setComposition): Moved from WebPageProxy.cpp.

5:41 PM Changeset in webkit [93842] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Some tests are apparently slow on Mac debug too.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
5:41 PM Changeset in webkit [93841] by jchaffraix@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Fixing broken build due to unused variables in release mode
​https://bugs.webkit.org/show_bug.cgi?id=67004

Unreviewed, release build fix.

Fixing broken build due to unused variables in ASSERTs in release build.

Patch by Mark Hahnenberg <​mhahnenberg@apple.com> on 2011-08-25

  • runtime/JSObject.h:

(JSC::JSObject::finishCreation):

  • runtime/JSString.h:

(JSC::RopeBuilder::finishCreation):

  • runtime/ScopeChain.h:

(JSC::ScopeChainNode::finishCreation):

5:36 PM Changeset in webkit [93840] by abarth@webkit.org
  • 5 edits in trunk/Tools

garden-o-matic should be able to roll out patches
​https://bugs.webkit.org/show_bug.cgi?id=66982

Reviewed by Dimitri Glazkov.

This patch just wires the rollout event through the controller to the
local server, which is already set up to perform rollouts.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
5:34 PM Changeset in webkit [93839] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Handle key-down events in the updated Cocoa text input model
​https://bugs.webkit.org/show_bug.cgi?id=67001

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKView.mm:

(-[WKView performKeyEquivalent:]):
Call _disableComplexTextInputIfNecessary so that we'll inform the plug-in that complex text
input has been disabled.

(-[WKView _disableComplexTextInputIfNecessary]):
If the plug-in is using the updated Cocoa text input model specification, disable text input
if the text input window has been dismissed for whatever reason.

(-[WKView _tryHandlePluginComplexTextInputKeyDown:]):
Call _disableComplexTextInputIfNecessary so that we'll inform the plug-in that complex text
input has been disabled.

(-[WKView _tryPostProcessPluginComplexTextInputKeyDown:]):
If the plug-in is using the updated Cocoa text input model specification, let the input methods
have a go at the keyboard event.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::setComplexTextInputEnabled):
Actually set m_isComplexTextInputEnabled to the right value.

5:06 PM Changeset in webkit [93838] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Factor code to send a key-down event to the plug-in out into a new function
​https://bugs.webkit.org/show_bug.cgi?id=66999

Reviewed by Darin Adler.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _handlePluginComplexTextInputKeyDown:]):
(-[WKView _tryHandlePluginComplexTextInputKeyDown:]):

4:39 PM Changeset in webkit [93837] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Concentrate RenderLayer repaint rects updates
​https://bugs.webkit.org/show_bug.cgi?id=64993

Reviewed by David Hyatt.

The change moves the update of the repaint rects to 2 methods
(computeRepaintRects and clearRepaintRects) to better track
those changes.

No new test, refactoring covered by the existing test cases.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions): Reverse the logic and
calculate the new bounds upfront. This should have no impact as none
of the methods rely on the internal value.

(WebCore::RenderLayer::computeRepaintRects): Added the cachedOffset parameter
to avoid breaking the performance optimization in updateLayerPositions. Added
some ASSERTS.

(WebCore::RenderLayer::clearRepaintRects): Added some ASSERTs here.
(WebCore::RenderLayer::updateRepaintRectsAfterScroll): Added a FIXME as this
method could use the cachedOffset trick too.

(WebCore::RenderLayer::setHasVisibleContent): Changed the code to use
computeRepaintRects.

  • rendering/RenderLayer.h: Updated the signature of computeRepaintRects and moved

those 2 methods into the private section of the class.

4:33 PM Changeset in webkit [93836] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Test expectation updates.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
4:30 PM Changeset in webkit [93835] by commit-queue@webkit.org
  • 16 edits in trunk/Source/JavaScriptCore

Unzip initialization lists and constructors in JSCell hierarchy (1/7)
​https://bugs.webkit.org/show_bug.cgi?id=66827

Patch by Mark Hahnenberg <​mhahnenberg@apple.com> on 2011-08-25
Reviewed by Geoffrey Garen.

Added finishCreation() methods to all immediately subclasses of JSCell with
non-empty constructors. Part of a larger refactoring to "unzip" initialization
lists and constructor bodies. Also renamed JSCell's constructorBody() method
to finishCreation().

  • runtime/Executable.h:

(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::constructorBody):

  • runtime/GetterSetter.h:

(JSC::GetterSetter::GetterSetter):

  • runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::constructorBody):
(JSC::JSAPIValueWrapper::JSAPIValueWrapper):

  • runtime/JSCell.h:

(JSC::JSCell::JSCell::JSCell):
(JSC::JSCell::JSCell::constructorBody):

  • runtime/JSObject.h:

(JSC::JSObject::constructorBody):
(JSC::JSObject::JSObject):

  • runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::constructorBody):

  • runtime/JSString.h:

(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::constructorBody):

  • runtime/RegExp.cpp:

(JSC::RegExp::RegExp):
(JSC::RegExp::constructorBody):

  • runtime/RegExp.h:
  • runtime/ScopeChain.h:

(JSC::ScopeChainNode::ScopeChainNode):
(JSC::ScopeChainNode::constructorBody):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):

  • runtime/StructureChain.cpp:

(JSC::StructureChain::StructureChain):

  • runtime/StructureChain.h:

(JSC::StructureChain::create):
(JSC::StructureChain::constructorBody):

4:19 PM Changeset in webkit [93834] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove use of magic number -1 in WebCore/editing/visible_units.cpp
​https://bugs.webkit.org/show_bug.cgi?id=66980

Patch by Van Lam <​vanlam@google.com> on 2011-08-25
Reviewed by Ryosuke Niwa.

Replaced use of magic number -1 with constant offsetNotFound.

  • editing/visible_units.cpp:

(WebCore::greatestOffsetUnder):
(WebCore::smallestOffsetAbove):

4:08 PM Changeset in webkit [93833] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Add API to allow scripts to close windows automatically via JavaScript.
​https://bugs.webkit.org/show_bug.cgi?id=66777

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-08-25
Reviewed by Antonio Gomes.

Make it possible to allow or prevent scripts from closing windows
automatically (via window.close, for example).

Besides being useful in general, this is required by DRT.

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):
(ewk_view_setting_scripts_can_close_windows_get):
(ewk_view_setting_scripts_can_close_windows_set):

  • ewk/ewk_view.h:
4:08 PM Changeset in webkit [93832] by loki@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r93755): It made 14 jsc test and ~500 layout test fail on Qt-ARM bot
​https://bugs.webkit.org/show_bug.cgi?id=66956

Rebaseline constants for patching GetByIdSlowCaseCall on ARM.

Reviewed by Oliver Hunt.

  • jit/JIT.h:
4:06 PM Changeset in webkit [93831] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
​https://bugs.webkit.org/show_bug.cgi?id=66951

Patch by Viatcheslav Ostapenko <​ostapenko.viatcheslav@nokia.com> on 2011-08-25
Reviewed by Andreas Kling.

Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
width and height one by one and setWidth cause geometryChange event in QTouchWebView.

  • MiniBrowser/qt/BrowserView.cpp:

(BrowserView::resizeEvent):

4:02 PM Changeset in webkit [93830] by Dimitri Glazkov
  • 6 edits in trunk/Tools

garden-o-matic summary view should provide information on builders still in flight.
​https://bugs.webkit.org/show_bug.cgi?id=66992

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
3:58 PM Changeset in webkit [93829] by abarth@webkit.org
  • 2 edits in trunk/Tools

webkit-patch rebaseline-expectations don't work when run outside the root
​https://bugs.webkit.org/show_bug.cgi?id=66966

Reviewed by Eric Seidel.

Turns out tool.path() used to be relative, which caused problems when
running webkit-patch outside the root directory. This patch makes it
absolute. I checked all callers, and they all appear to want this
behavior.

It was unclear to me how to test this change because we only really
have a testing strategy for webkitpy, not for the main script.

  • Scripts/webkit-patch:
3:56 PM Changeset in webkit [93828] by crogers@google.com
  • 1 edit in branches/chromium/835/Source/WebCore/platform/audio/AudioArray.h

Merge 93749 - Resolve potential integer overflow in memory allocation, and ensure
that allocation succeeds.

BUG=94025
Review URL: ​http://codereview.chromium.org/7741034

3:54 PM Changeset in webkit [93827] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

WKView should keep track of the plug-in complex text input state
​https://bugs.webkit.org/show_bug.cgi?id=66990

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKView.mm:

Add a _pluginComplexTextInputState ivar to WKViewData.

(-[WKView _setPluginComplexTextInputState:]):
Set the _pluginComplexTextInputState variable. If text input is being disabled, send back an empty string to the plug-in.

(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):
Call -[WKView _setPluginComplexTextInputState:].

3:34 PM Changeset in webkit [93826] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Apparently, expectations without WONTFIX or BUGxxx are ignored.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
3:33 PM Changeset in webkit [93825] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Move file internal methods to a class continuation in WKView
​https://bugs.webkit.org/show_bug.cgi?id=66983

Reviewed by Dan Bernstein.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _deviceScaleFactor]):
(-[WKView _setDrawingAreaSize:]):

2:20 PM Changeset in webkit [93824] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

More work on the updated Cocoa text input specification
​https://bugs.webkit.org/show_bug.cgi?id=66977

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_pluginWantsLegacyCocoaTextInput and m_hasHandledAKeyDownEvent.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add m_pluginWantsLegacyCocoaTextInput and m_hasHandledAKeyDownEvent.

(WebKit::NetscapePlugin::setPluginWantsLegacyCocoaTextInput):
Add setter. Not called yet.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Set m_hasHandledAKeyDownEvent to true if we get a KeyDown event.

(WebKit::NetscapePlugin::sendComplexTextInput):
If the plug-in is using the updated Cocoa text input spec, we can disable text input here.

(WebKit::NetscapePlugin::pluginFocusOrWindowFocusChanged):
If the plug-in is using the updated Cocoa text input spec, text input is not enabled when
the plug-in is focused.

(WebKit::NetscapePlugin::setComplexTextInputEnabled):
Set the right text input state based on whether the plug-in is using the updated spec or not.

2:09 PM Changeset in webkit [93823] by Dimitri Glazkov
  • 1 edit
    2 adds in trunk/Tools

garden-o-matic summary needs a mock view that could be used for working on styling
​https://bugs.webkit.org/show_bug.cgi?id=66971

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
2:00 PM Changeset in webkit [93822] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Test expectation updates.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
1:58 PM Changeset in webkit [93821] by gavinp@chromium.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Added myself to committers.

1:56 PM Changeset in webkit [93820] by igor.oliveira@openbossa.org
  • 6 edits
    2 deletes in trunk

2011-08-25 Igor Oliveira <​igor.oliveira@openbossa.org>

Rollout r93799: Caused bad clipping on the bottom of tall glyphs inside a button label

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:

(WebCore::RenderBox::hasControlClip):
(WebCore::RenderBox::controlClipRect):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::setupInnerStyle):

LayoutTests:

Rollout r93799: Caused bad clipping on the bottom of tall glyphs inside a button label

  • fast/css/button-overflow-ellipsis.html: Removed.
  • platform/qt/fast/css/button-overflow-ellipsis-expected.txt: Removed.
1:50 PM Changeset in webkit [93819] by crogers@google.com
  • 1 edit in branches/chromium/835/Source/WebCore/bindings/v8/custom/V8AudioNodeCustom.cpp

Merge 91802 - V8 custom bindings for AudioNode must do proper object checking and throw exception in case of error
​https://bugs.webkit.org/show_bug.cgi?id=65222

BUG=94273
Review URL: ​http://codereview.chromium.org/7740035

1:37 PM Changeset in webkit [93818] by crogers@google.com
  • 2 edits in branches/chromium/835/Source/WebCore/webaudio

Merge 92658 - Fix thread-safety of AudioNode deletion
​https://bugs.webkit.org/show_bug.cgi?id=65888

BUG=94278
Review URL: ​http://codereview.chromium.org/7749016

1:29 PM Changeset in webkit [93817] by Ademar Reis
  • 2 edits in trunk/Source/WebCore

[Qt] Enable password echo on Symbian builds
​https://bugs.webkit.org/show_bug.cgi?id=66954

Reviewed by Chang Shu.

No tests, as this is just a build change.

  • config.h:
1:28 PM Changeset in webkit [93816] by crogers@google.com
  • 1 edit in branches/chromium/835/Source/WebCore/webaudio/AudioContext.cpp

Merge 91801 - AudioContext is not correctly accounting for hardware resources
​https://bugs.webkit.org/show_bug.cgi?id=65217

BUG=94271
Review URL: ​http://codereview.chromium.org/7741029

1:27 PM Changeset in webkit [93815] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

2011-08-25 Nate Chapin <Nate Chapin>

Windows build fix after r93811.

  • loader/cf/ResourceLoaderCFNet.cpp: (WebCore::ResourceLoader::shouldCacheResponse):
1:26 PM Changeset in webkit [93814] by andersca@apple.com
  • 5 edits
    3 adds in trunk

Return the correct value for NPNVsupportsCarbonBool
​https://bugs.webkit.org/show_bug.cgi?id=66964

Source/WebKit2:

Reviewed by Adam Roben.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Remove a FIXME and set the value to true.

Tools:

Add a test.

Reviewed by Adam Roben.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.

(SupportsCarbonEventModel::SupportsCarbonEventModel):
(SupportsCarbonEventModel::testConvert):
(SupportsCarbonEventModel::runTest):
(SupportsCarbonEventModel::NPP_New):

LayoutTests:

Reviewed by Adam Roben.

Add test.

  • platform/mac/plugins/supports-carbon-event-model-expected.txt: Added.
  • platform/mac/plugins/supports-carbon-event-model.html: Added.
1:21 PM Changeset in webkit [93813] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

[EFL] Implement FrameLoaderClient::didTransferChildFrameToNewDocument
​https://bugs.webkit.org/show_bug.cgi?id=66690

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-08-25
Reviewed by Antonio Gomes.

The implementation is mostly based on the GTK+ port's, as we just need
to transfer the ownership of the frame to a new view and adjust the
smart object part accordingly.

This should help make fast/frames/iframe-reparenting-adopt-node.html
pass.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::didTransferChildFrameToNewDocument):

  • ewk/ewk_frame.cpp:

(ewk_frame_view_set):
(ewk_frame_view_create_for_view):

  • ewk/ewk_private.h:
12:57 PM Changeset in webkit [93812] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Further attempts to clean up the test expectations by being
more consistent about handling SKIPped and WONTFIXed tests.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
12:55 PM Changeset in webkit [93811] by Nate Chapin
  • 17 edits
    1 add in trunk/Source/WebCore

Split some of the variables out of ThreadableLoaderOptions
into a superclass, ResourceLoaderOptions. Use ResourceLoaderOptions
all the way down to ResourceLoader.
​https://bugs.webkit.org/show_bug.cgi?id=63301

Reviewed by David Levin.

No new tests, refractor only.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentThreadableLoader.cpp:
  • loader/MainResourceLoader.cpp:
  • loader/NetscapePlugInStreamLoader.cpp:
  • loader/ResourceLoadScheduler.cpp:
  • loader/ResourceLoadScheduler.h:
  • loader/ResourceLoader.cpp:
  • loader/ResourceLoader.h:
  • loader/ResourceLoaderOptions.h: Added.
  • loader/SubresourceLoader.cpp:
  • loader/SubresourceLoader.h:
  • loader/ThreadableLoader.h:
  • loader/cache/CachedResourceRequest.cpp:
  • loader/mac/ResourceLoaderMac.mm:
12:53 PM Changeset in webkit [93810] by crogers@google.com
  • 5 edits in branches/chromium/835/Source/WebCore

Merge 92408 - Make sure that AudioArray is 16-byte aligned
​https://bugs.webkit.org/show_bug.cgi?id=65651

Reviewed by Kenneth Russell.

No new tests - this does not change JavaScript API.

  • platform/audio/AudioArray.h:

(WebCore::AudioArray::AudioArray):
(WebCore::AudioArray::~AudioArray):
(WebCore::AudioArray::allocate):
(WebCore::AudioArray::data):
(WebCore::AudioArray::size):
(WebCore::AudioArray::at):
(WebCore::AudioArray::operator[]):
(WebCore::AudioArray::alignedAddress):

  • platform/audio/Biquad.cpp:

(WebCore::Biquad::Biquad):

  • platform/audio/ReverbConvolverStage.cpp:

(WebCore::ReverbConvolverStage::ReverbConvolverStage):

  • webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::DelayDSPKernel):

  • webaudio/RealtimeAnalyser.cpp:

(WebCore::RealtimeAnalyser::setFftSize):

TBR=​crogers@google.com
Review URL: ​http://codereview.chromium.org/7745029

12:44 PM Changeset in webkit [93809] by adamk@chromium.org
  • 3 edits in trunk/Source/WebCore

use strict in CodeGeneratorJS and CodeGeneratorV8
​https://bugs.webkit.org/show_bug.cgi?id=66915

Reviewed by Darin Adler.

Making these files "use strict" makes changing them less
time-consuming and error-prone, and helps avoid accidentally
adding dead code (added a FIXME for one such case).

No expected change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForType):
(GenerateParametersCheckExpression):
(GenerateFunctionParametersCheck):
(GenerateImplementation):
(GenerateImplementationFunctionCall):
(NativeToJSValue):
(GenerateHashValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(AddIncludesForType):
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateNormalAttrSetter):
(GetFunctionTemplateCallbackName):
(GenerateNewFunctionTemplate):
(GenerateParametersCheckExpression):
(GenerateFunctionParametersCheck):
(GenerateImplementation):
():

12:21 PM Changeset in webkit [93808] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Enable incremental linking for component build on Chromium
​https://bugs.webkit.org/show_bug.cgi?id=66950

Patch by Scott Graham <​scottmg@chromium.org> on 2011-08-25
Reviewed by Darin Fisher.

Turns on Use Library Dependency Inputs for webkit.vcproj on Windows
build, when incremental_chrome_dll gyp flag is set. This is to get
faster incremental links on Windows builds.

  • WebKit.gyp:
12:17 PM Changeset in webkit [93807] by dino@apple.com
  • 8 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=21586
Apply CSS animations and transitions to SVG properties

Reviewed by Simon Fraser.

Expose the applicable SVG properties from SVGRenderStyle to
RenderStyle and add them to the list of animatable
properties. There aren't many SVG properties that are
animatable directly. SVGPaint (used in "fill" and "stroke")
is supported only when both ends of the animation are
a Color. Also updated SVGLength to have some methods
for converting to and from user space units.

12:09 PM Changeset in webkit [93806] by Dimitri Glazkov
  • 2 edits in trunk/Tools

garden-o-matic summary view should not be broken.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:

(table.comparison): Added more specificity.

12:06 PM Changeset in webkit [93805] by abarth@webkit.org
  • 2 edits in trunk/Tools

This command has been broken for a while. This patch updates the
callsite to the new API.

  • Scripts/webkitpy/tool/commands/rebaseline.py:
12:02 PM Changeset in webkit [93804] by igor.oliveira@openbossa.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed, rebaseline for bug 53438.

  • platform/qt/fast/css/button-overflow-ellipsis-expected.txt:
11:48 AM Changeset in webkit [93803] by inferno@chromium.org
  • 1 edit
    40 adds
    1 delete in trunk/LayoutTests

Unreviewed. Chromium rebaselines for r93794.

  • platform/chromium-cg-mac-leopard/fast/table/table-after-child-in-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-before-child-in-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-cell-after-child-in-block-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-cell-after-child-in-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-cell-before-child-in-block-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-cell-before-child-in-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-row-after-child-in-block-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-row-after-child-in-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-row-before-child-in-block-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/table-row-before-child-in-table-expected.png: Added.
  • platform/chromium-linux/fast/table/table-after-child-in-table-expected.png: Added.
  • platform/chromium-linux/fast/table/table-before-child-in-table-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-after-child-in-block-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-after-child-in-table-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-before-child-in-block-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-before-child-in-table-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-after-child-in-block-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-after-child-in-table-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-before-child-in-block-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-before-child-in-table-expected.png: Added.
  • platform/chromium-win-vista/fast/table: Removed.
  • platform/chromium-win/fast/table/table-after-child-in-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-after-child-in-table-expected.txt: Added.
  • platform/chromium-win/fast/table/table-before-child-in-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-before-child-in-table-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-after-child-in-block-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-after-child-in-block-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-after-child-in-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-after-child-in-table-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-before-child-in-block-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-before-child-in-block-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-before-child-in-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-before-child-in-table-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-after-child-in-block-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-after-child-in-block-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-after-child-in-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-after-child-in-table-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-before-child-in-block-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-before-child-in-block-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-before-child-in-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-before-child-in-table-expected.txt: Added.
11:09 AM Changeset in webkit [93802] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

REGRESSION(r90971): Fix an assertion failure with textarea placeholder.
​https://bugs.webkit.org/show_bug.cgi?id=66164

Source/WebCore:

Patch by Kent Tamura <​tkent@chromium.org> on 2011-08-25
Reviewed by Dave Hyatt.

Minor patch nits addressed by ​inferno@chromium.org, on Hyatt's
review.

Test: fast/forms/textarea-placeholder-relayout-assertion.html

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::layoutSpecialExcludedChild):
Pass 'false' to the 'markParents' argument of setChildNeedsLayout().
We don't need to propagate needsLayout for ancestors because
layoutSpecialExcludedChild() is called from layout() of the
parent.

LayoutTests:

Patch by Kent Tamura <​tkent@chromium.org> on 2011-08-25
Reviewed by Dave Hyatt.

  • fast/forms/textarea-placeholder-relayout-assertion-expected.txt: Added.
  • fast/forms/textarea-placeholder-relayout-assertion.html: Added.
11:07 AM Changeset in webkit [93801] by Dimitri Glazkov
  • 5 edits
    2 adds in trunk/Tools

garden-o-matic needs a way to report where and how tests are failing in the summary view.
​https://bugs.webkit.org/show_bug.cgi?id=66955

Introduce FailureGrid, your one-stop failure-indicating destination.

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
11:05 AM Changeset in webkit [93800] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip new tests until check them.
11:04 AM Changeset in webkit [93799] by igor.oliveira@openbossa.org
  • 6 edits
    2 adds in trunk

2011-08-25 Igor Oliveira <​igor.oliveira@openbossa.org>

Text-overflow is broken for button elements
​https://bugs.webkit.org/show_bug.cgi?id=53438

Fix text-overflow for button elements. Make the element inside
the button inherit the button controlClip.

Reviewed by David Hyatt.

Test: fast/css/button-overflow-ellipsis.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::controlClipRect):

  • rendering/RenderBox.h:

(WebCore::RenderBox::hasControlClip):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::setupInnerStyle):

LayoutTests:

Text-overflow is broken for button elements
​https://bugs.webkit.org/show_bug.cgi?id=53438

Add button text-overflow test.

Reviewed by David Hyatt.

  • fast/css/button-overflow-ellipsis.html: Added.
  • platform/qt/fast/css/button-overflow-ellipsis-expected.txt: Added.
10:56 AM Changeset in webkit [93798] by ap@apple.com
  • 2 edits
    1 copy in trunk/Source/ThirdParty

Fix build when GCC 4.2 is not installed.

  • gtest/xcode/Config/CompilerVersion.xcconfig: Copied from Source/WebCore/Configurations/CompilerVersion.xcconfig.
  • gtest/xcode/Config/General.xcconfig: Use the same compiler version as other projects do.
10:33 AM QtWebKit edited by Ademar Reis
(diff)
10:32 AM QtWebKit edited by Ademar Reis
(diff)
10:27 AM Changeset in webkit [93797] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Several test expectation updates.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
10:24 AM Changeset in webkit [93796] by enne@google.com
  • 11 edits in trunk/Source/WebCore

[chromium] Update VideoLayerChromium to not access GC3D on the main thread
​https://bugs.webkit.org/show_bug.cgi?id=66434

Reviewed by James Robinson.

Covered by existing tests.

This change allows the main thread VideoLayerChromium to not depend on
compositor thread resources (GC3D, LayerRendererChromium). The texture
allocation in VideoLayerChromium was changed to use ManagedTexture so
that textures can now be evicted when there is texture memory pressure
and so that destruction can be automatically deferred until a GC3D is
available.

  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/ManagedTexture.cpp:
  • platform/graphics/chromium/ManagedTexture.h:

(WebCore::ManagedTexture::size):
(WebCore::ManagedTexture::format):

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::~VideoLayerChromium):
(WebCore::VideoLayerChromium::cleanupResources):
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::pushPropertiesTo):
(WebCore::VideoLayerChromium::setLayerTreeHost):
(WebCore::VideoLayerChromium::determineTextureFormat):
(WebCore::VideoLayerChromium::reserveTextures):
(WebCore::VideoLayerChromium::updateTexture):
(WebCore::VideoLayerChromium::releaseCurrentFrame):

  • platform/graphics/chromium/VideoLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::contentsTextureManager):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::setTexture):
(WebCore::CCVideoLayerImpl::drawYUV):
(WebCore::CCVideoLayerImpl::drawRGBA):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:
10:13 AM Changeset in webkit [93795] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-08-25 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, fix chromium devtools tests.

  • src/js/Tests.js: (.TestSuite.prototype.evaluateInConsole_):
9:58 AM Changeset in webkit [93794] by inferno@chromium.org
  • 5 edits
    30 adds in trunk

Incorrect layout of :before and :after content, with display
table, table-row and table-cell.
​https://bugs.webkit.org/show_bug.cgi?id=66699

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/table-after-child-in-table.html

fast/table/table-before-child-in-table.html
fast/table/table-cell-after-child-in-block.html
fast/table/table-cell-after-child-in-table.html
fast/table/table-cell-before-child-in-block.html
fast/table/table-cell-before-child-in-table.html
fast/table/table-row-after-child-in-block.html
fast/table/table-row-after-child-in-table.html
fast/table/table-row-before-child-in-block.html
fast/table/table-row-before-child-in-table.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
Fix the looping condition to detect :after child correctly.
isAnonymousBlock() does not apply to tables, instead
using isAnonymous().

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::addChild): Don't add the new child
in the generatedContainer with :before, :after content.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild): Don't add the new child
in the generatedContainer with :before, :after content.

LayoutTests:

  • fast/table/table-after-child-in-table.html: Added.
  • fast/table/table-before-child-in-table.html: Added.
  • fast/table/table-cell-after-child-in-block.html: Added.
  • fast/table/table-cell-after-child-in-table.html: Added.
  • fast/table/table-cell-before-child-in-block.html: Added.
  • fast/table/table-cell-before-child-in-table.html: Added.
  • fast/table/table-row-after-child-in-block.html: Added.
  • fast/table/table-row-after-child-in-table.html: Added.
  • fast/table/table-row-before-child-in-block.html: Added.
  • fast/table/table-row-before-child-in-table.html: Added.
  • platform/mac/fast/table/table-after-child-in-table-expected.png: Added.
  • platform/mac/fast/table/table-after-child-in-table-expected.txt: Added.
  • platform/mac/fast/table/table-before-child-in-table-expected.png: Added.
  • platform/mac/fast/table/table-before-child-in-table-expected.txt: Added.
  • platform/mac/fast/table/table-cell-after-child-in-block-expected.png: Added.
  • platform/mac/fast/table/table-cell-after-child-in-block-expected.txt: Added.
  • platform/mac/fast/table/table-cell-after-child-in-table-expected.png: Added.
  • platform/mac/fast/table/table-cell-after-child-in-table-expected.txt: Added.
  • platform/mac/fast/table/table-cell-before-child-in-block-expected.png: Added.
  • platform/mac/fast/table/table-cell-before-child-in-block-expected.txt: Added.
  • platform/mac/fast/table/table-cell-before-child-in-table-expected.png: Added.
  • platform/mac/fast/table/table-cell-before-child-in-table-expected.txt: Added.
  • platform/mac/fast/table/table-row-after-child-in-block-expected.png: Added.
  • platform/mac/fast/table/table-row-after-child-in-block-expected.txt: Added.
  • platform/mac/fast/table/table-row-after-child-in-table-expected.png: Added.
  • platform/mac/fast/table/table-row-after-child-in-table-expected.txt: Added.
  • platform/mac/fast/table/table-row-before-child-in-block-expected.png: Added.
  • platform/mac/fast/table/table-row-before-child-in-block-expected.txt: Added.
  • platform/mac/fast/table/table-row-before-child-in-table-expected.png: Added.
  • platform/mac/fast/table/table-row-before-child-in-table-expected.txt: Added.
9:50 AM Changeset in webkit [93793] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

JSHTMLImageElement (and associated Node) is abandoned when image load is canceled via beforeload
<rdar://problem/9925630>
​https://bugs.webkit.org/show_bug.cgi?id=66906

Reviewed by Darin Adler.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
Very similar fix to the one in r93717 except this patches the case where the image load was
canceled via beforeload.

9:42 AM Changeset in webkit [93792] by commit-queue@webkit.org
  • 16 edits in trunk/Source

[chromium] Leaking SkBitmaps for background images
​https://bugs.webkit.org/show_bug.cgi?id=66488

Patch by John Bates <​jbates@google.com> on 2011-08-25
Reviewed by Stephen White.

This patch simply changes NativeImageSkia to have a SkBitmap instead of
deriving from SkBitmap. All dependent code updated to access the member
instead of calling SkBitmap methods on NativeImageSkia objects. This
may or may not fix the memory leak, but it's definitely a bug that could
cause memory leaks.

Source/WebCore:

  • platform/chromium/DragImageChromiumSkia.cpp:

(WebCore::createDragImageFromImage):

  • platform/graphics/chromium/PlatformImage.cpp:

(WebCore::PlatformImage::updateFromImage):

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h:

(WebCore::BitmapImageSingleFrameSkia::currentFrameHasAlpha):
(WebCore::BitmapImageSingleFrameSkia::size):
(WebCore::BitmapImageSingleFrameSkia::notSolidColor):

  • platform/graphics/skia/GraphicsContext3DSkia.cpp:

(WebCore::GraphicsContext3D::getImageData):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::checkForSolidColor):

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::NativeImageSkia):
(WebCore::NativeImageSkia::decodedSize):
(WebCore::NativeImageSkia::resizedBitmap):

  • platform/graphics/skia/NativeImageSkia.h:

(WebCore::NativeImageSkia::bitmap):

  • platform/graphics/skia/PatternSkia.cpp:

(WebCore::Pattern::platformPattern):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageFrame::getAddr):

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::ImageFrame::operator=):
(WebCore::ImageFrame::clearPixelData):
(WebCore::ImageFrame::zeroFillPixelData):
(WebCore::ImageFrame::copyBitmapData):
(WebCore::ImageFrame::setSize):
(WebCore::ImageFrame::hasAlpha):
(WebCore::ImageFrame::setHasAlpha):
(WebCore::ImageFrame::width):
(WebCore::ImageFrame::height):

Source/WebKit/chromium:

  • src/PlatformBridge.cpp:

(WebCore::PlatformBridge::clipboardWriteImage):

  • src/WebImageDecoder.cpp:

(WebKit::WebImageDecoder::getFrameAtIndex):

  • src/WebImageSkia.cpp:

(WebKit::WebImage::fromData):
(WebKit::WebImage::operator=):

9:14 AM Changeset in webkit [93791] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[SKIA] Move forward decl of skia type outside namespace Webkit
​https://bugs.webkit.org/show_bug.cgi?id=66942

Patch by Brian Salomon <​bsalomon@google.com> on 2011-08-25
Reviewed by Stephen White.

  • public/WebGraphicsContext3D.h:
8:56 AM Changeset in webkit [93790] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r93774.
​http://trac.webkit.org/changeset/93774
​https://bugs.webkit.org/show_bug.cgi?id=66945

It broke 26 tests on the Qt bot (Requested by ossy on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-08-25

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::stroke):

  • platform/graphics/qt/PathQt.cpp:

(WebCore::Path::boundingRect):

8:47 AM Changeset in webkit [93789] by caseq@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: [refactoring] use PopoverHelper to implement popup in the SourceFrame
​https://bugs.webkit.org/show_bug.cgi?id=66858

Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._showStringContentPopover):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype.initializeView):
(WebInspector.NetworkLogView.prototype.willHide):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkLogView.prototype._showPopover):

  • inspector/front-end/Popover.js:

(WebInspector.Popover):
(WebInspector.Popover.prototype.show):
(WebInspector.Popover.prototype.dispose):
(WebInspector.PopoverHelper):
(WebInspector.PopoverHelper.prototype._mouseMove.doHide):
(WebInspector.PopoverHelper.prototype._mouseMove):
(WebInspector.PopoverHelper.prototype.hidePopover):
(WebInspector.PopoverHelper.prototype._hidePopover):
(WebInspector.PopoverHelper.prototype._mouseHover):
(WebInspector.PopoverHelper.prototype._killHidePopupTimer):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.willHide):
(WebInspector.SourceFrame.prototype._initializeTextViewer):
(WebInspector.SourceFrame.prototype._scroll):
(WebInspector.SourceFrame.prototype._mouseDown):
(WebInspector.SourceFrame.prototype._onHidePopover):
(WebInspector.SourceFrame.prototype._shouldShowPopover):
(WebInspector.SourceFrame.prototype._getPopoverAnchor):
(WebInspector.SourceFrame.prototype._highlightExpression):
(WebInspector.SourceFrame.prototype._onShowPopover.showObjectPopover):
(WebInspector.SourceFrame.prototype._onShowPopover):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._showPopover):
(WebInspector.TimelinePanel.prototype._closeRecordDetails):

8:46 AM Changeset in webkit [93788] by igor.oliveira@openbossa.org
  • 2 edits in trunk/Tools

Add myself to the committers list
​https://bugs.webkit.org/show_bug.cgi?id=66941

Reviewed by Andreas Kling.

  • Scripts/webkitpy/common/config/committers.py:
8:29 AM Changeset in webkit [93787] by Ademar Reis
  • 2 edits in trunk/Source/WebKit/qt

Unreviewed QtWebKit.pro fix for when building inside Qt

Patch by Simo Fält <​simo.falt@nokia.com>

The QtWebKit version was being overwritten by a global Qt version when
QtWebKit was built inside Qt. Fixed by moving the version
definition after the inclusion of qbase.pri.

8:22 AM Changeset in webkit [93786] by pfeldman@chromium.org
  • 8 edits
    2 adds in trunk

[Qt] REGRESSION(93769): inspector/console/console-tests.html fails
​https://bugs.webkit.org/show_bug.cgi?id=66930

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/console/console-repeat-count.html

  • inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleModel):
(WebInspector.ConsoleModel.prototype.addMessage):
(WebInspector.ConsoleModel.prototype.clearMessages):
(WebInspector.ConsoleModel.prototype.interruptRepeatCount):
(WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated):
(WebInspector.ConsoleDispatcher.prototype.messageRepeatCountUpdated):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._consoleMessageAdded):

  • inspector/front-end/inspector.js:

LayoutTests:

  • inspector/console/console-repeat-count-expected.txt: Added.
  • inspector/console/console-repeat-count.html: Added.
8:18 AM Changeset in webkit [93785] by Ademar Reis
  • 3 edits in trunk/Source/WebKit/qt

Unreviewed, rolling out r93783.
​http://trac.webkit.org/changeset/93783
​https://bugs.webkit.org/show_bug.cgi?id=66943

Commited wrong stuff by accident. (Requested by ademar on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-08-25

  • Api/qwebview.cpp:

(QWebView::load):
(QWebView::setHtml):
(QWebView::setContent):
(QWebView::setUrl):

8:13 AM Changeset in webkit [93784] by alexis.menard@openbossa.org
  • 12 edits
    3 deletes in trunk/Source/WebKit2

[Qt][WK2] Remove QWKContext class and make sure the WebProcessProxy life is correctly managed.
​https://bugs.webkit.org/show_bug.cgi?id=66886

Reviewed by Benjamin Poulain.

Remove QWKContext class from Qt APIs as it is too low level for the vision
of the Qt5 API. QtWebPageProxy now holds directly a WebContext which can be a custom one
or default created one. This patch also ensure that the WebProcessProxy is correctly
destroyed at application exit by removing the circular references between the WebContext,
WebProcessProxy, and WebPageProxy.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::QDesktopWebViewPrivate):

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::QTouchWebViewPrivate):

  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_setStatusText):

  • UIProcess/qt/ClientImpl.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::defaultWKContext):
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::~QtWebPageProxy):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::QDesktopWebPageProxy):

  • UIProcess/qt/qdesktopwebpageproxy.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::QTouchWebPageProxy):

  • UIProcess/qt/qtouchwebpageproxy.h:
  • UIProcess/qt/qwkcontext.cpp: Removed.
  • UIProcess/qt/qwkcontext.h: Removed.
  • UIProcess/qt/qwkcontext_p.h: Removed.
  • WebKit2.pro:
7:59 AM Changeset in webkit [93783] by Ademar Reis
  • 3 edits in trunk/Source/WebKit/qt

Unreviewed QtWebKit.pro fix for when building inside Qt

Patch by Simo Fält <​simo.falt@nokia.com>

The QtWebKit version was being overwritten by a global Qt version when
QtWebKit was built inside Qt. Fixed by moving the version
definition after the inclusion of qbase.pri.

7:37 AM Changeset in webkit [93782] by mnaganov@chromium.org
  • 8 edits in trunk/Source

Chromium: expose MemoryCache::prune and FontCache::purgeInactiveFontData.
​https://bugs.webkit.org/show_bug.cgi?id=66132

Reviewed by Tony Gentilcore.

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::prune):
(WebCore::MemoryCache::pruneToPercentage):

  • loader/cache/MemoryCache.h: Methods moved from .h to .cpp to work around compilation problem with the Win Chromium port.
  • public/WebCache.h:
  • public/WebFontCache.h:
  • src/WebCache.cpp:

(WebKit::WebCache::clear):
(WebKit::WebCache::prune):

  • src/WebFontCache.cpp:

(WebKit::WebFontCache::prune):

6:08 AM Changeset in webkit [93781] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r93771.
​http://trac.webkit.org/changeset/93771
​https://bugs.webkit.org/show_bug.cgi?id=66933

Broke css3/font-feature-settings-rendering.html on chromium
mac 10.5 (Requested by podivilov on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-08-25

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):

  • platform/graphics/mac/FontCustomPlatformData.h:

(WebCore::FontCustomPlatformData::FontCustomPlatformData):

5:52 AM Changeset in webkit [93780] by jocelyn.turcotte@nokia.com
  • 24 edits
    2 adds
    3 deletes in trunk/Source

[Qt][WK2] Drive tiling from the WebProcess and reuse TiledBackingStore.
​https://bugs.webkit.org/show_bug.cgi?id=66771

Reviewed by Tor Arne Vestbø.

We need the tiling logic to be moved to the web process to allow invalidated tile rects to be
rendered with the same layout. This also allows the web process to render tiles into
buffers readable directly by the GPU (on supported platforms). We also take the opportunity
to use the TiledBackingStore in WebCore to have only one tiling implementation.

Before this patch:

  • TiledDrawingAreaProxy manages tiles from the UI process.
  • TiledDrawingArea received rendering requests for a rect and returns the result to the proxy through shared memory.

After this patch:

  • TiledDrawingArea uses a TiledBackingStore to manage tiles from the web process.
  • TiledBackingStoreRemoteTile forwards tile creations, update and removals to the proxy.
  • TiledDrawingAreaProxy updates the scene graph directly from requests.

It also implements tile buffer swapping correctly in SGTileNode, triggered by the DidRenderFrame message.
Render throttling is implemented by waiting in TiledDrawingArea for the UI process to
notify us when the last rendered frame is ready to make it to the screen.
TiledDrawingAreaTileSets have been replaced by using two instances of TiledBackingStore instead.

Source/WebCore:

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::coverageRatio):
(WebCore::TiledBackingStore::startTileBufferUpdateTimer):

  • platform/graphics/TiledBackingStore.h:
  • platform/graphics/TiledBackingStoreClient.h:

(WebCore::TiledBackingStoreClient::tiledBackingStoreIsUpdatingAllowed):

Source/WebKit2:

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::updatePaintNode):

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::updateViewportState):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::createTile):
(WebKit::DrawingAreaProxy::updateTile):
(WebKit::DrawingAreaProxy::didRenderFrame):
(WebKit::DrawingAreaProxy::removeTile):

  • UIProcess/DrawingAreaProxy.messages.in:
  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::create):
(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
(WebKit::TiledDrawingAreaProxy::~TiledDrawingAreaProxy):
(WebKit::TiledDrawingAreaProxy::setVisibleContentRect):
(WebKit::TiledDrawingAreaProxy::setContentsScale):
(WebKit::TiledDrawingAreaProxy::renderNextFrame):
(WebKit::TiledDrawingAreaProxy::sizeDidChange):
(WebKit::TiledDrawingAreaProxy::paint):

  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/TiledDrawingAreaTile.h: Removed.
  • UIProcess/qt/SGAgent.cpp:

(WebKit::NodeUpdateCreateTile::NodeUpdateCreateTile):
(WebKit::NodeUpdateRemoveTile::NodeUpdateRemoveTile):
(WebKit::NodeUpdateSetBackBuffer::NodeUpdateSetBackBuffer):
(WebKit::NodeUpdateSwapTileBuffers::NodeUpdateSwapTileBuffers):
(WebKit::SGAgent::SGAgent):
(WebKit::SGAgent::createTileNode):
(WebKit::SGAgent::removeTileNode):
(WebKit::SGAgent::setNodeBackBuffer):
(WebKit::SGAgent::swapTileBuffers):
(WebKit::SGAgent::updatePaintNode):
(WebKit::SGAgent::getScaleNode):
Make the parenting logic more strict to allow SGAgent to handle the scale nodes itself (remove NodeUpdateCreateScale and use the scale in CreateTile).
Delete the scale node when the last of its child tiles has been removed.

  • UIProcess/qt/SGAgent.h:

(WebKit::SGAgent::isSwapPending):

  • UIProcess/qt/SGTileNode.cpp:

(WebKit::SGTileNode::SGTileNode):
(WebKit::SGTileNode::setBackBuffer):
(WebKit::SGTileNode::swapIfNeeded):
Replace setTargetRect, setSourceRect and setTexture by a single setBackBuffer method.
This allows all those values to be used only when swapIfNeeded is called later.

  • UIProcess/qt/SGTileNode.h:
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp:

(WebKit::TiledDrawingAreaProxy::createTile):
(WebKit::TiledDrawingAreaProxy::updateTile):
(WebKit::TiledDrawingAreaProxy::didRenderFrame):
(WebKit::TiledDrawingAreaProxy::removeTile):

  • UIProcess/qt/TiledDrawingAreaTileQt.cpp: Removed.
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::renderNextFrame):

  • UIProcess/qt/qtouchwebpageproxy.h:
  • WebKit2.pro:
  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setVisibleContentRect):
(WebKit::DrawingArea::setContentsScale):
(WebKit::DrawingArea::renderNextFrame):

  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp: Added.

(WebKit::TiledBackingStoreRemoteTile::TiledBackingStoreRemoteTile):
(WebKit::TiledBackingStoreRemoteTile::~TiledBackingStoreRemoteTile):
(WebKit::TiledBackingStoreRemoteTile::isDirty):
(WebKit::TiledBackingStoreRemoteTile::invalidate):
(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):
(WebKit::TiledBackingStoreRemoteTile::swapBackBufferToFront):
(WebKit::TiledBackingStoreRemoteTile::isReadyToPaint):
(WebKit::TiledBackingStoreRemoteTile::paint):
(WebKit::TiledBackingStoreRemoteTileBackend::TiledBackingStoreRemoteTileBackend):
(WebKit::TiledBackingStoreRemoteTileBackend::createTile):
(WebKit::TiledBackingStoreRemoteTileBackend::paintCheckerPattern):

  • WebProcess/WebPage/TiledBackingStoreRemoteTile.h: Added.

(WebKit::TiledBackingStoreRemoteTile::create):
(WebKit::TiledBackingStoreRemoteTile::coordinate):
(WebKit::TiledBackingStoreRemoteTile::rect):
(WebKit::TiledBackingStoreRemoteTileClient::~TiledBackingStoreRemoteTileClient):
(WebKit::TiledBackingStoreRemoteTileBackend::create):

  • WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::TiledDrawingArea):
(WebKit::TiledDrawingArea::setNeedsDisplay):
(WebKit::TiledDrawingArea::setSize):
(WebKit::TiledDrawingArea::setVisibleContentRect):
(WebKit::TiledDrawingArea::setContentsScale):
(WebKit::TiledDrawingArea::renderNextFrame):
(WebKit::TiledDrawingArea::suspendPainting):
(WebKit::TiledDrawingArea::resumePainting):
(WebKit::TiledDrawingArea::tiledBackingStorePaintBegin):
(WebKit::TiledDrawingArea::tiledBackingStorePaint):
(WebKit::TiledDrawingArea::tiledBackingStorePaintEnd):
(WebKit::TiledDrawingArea::tiledBackingStoreIsUpdatingAllowed):
(WebKit::TiledDrawingArea::tiledBackingStoreContentsRect):
(WebKit::TiledDrawingArea::tiledBackingStoreVisibleRect):
(WebKit::TiledDrawingArea::tiledBackingStoreBackgroundColor):
(WebKit::TiledDrawingArea::createTile):
(WebKit::TiledDrawingArea::updateTile):
(WebKit::TiledDrawingArea::removeTile):

  • WebProcess/WebPage/TiledDrawingArea.h:
  • WebProcess/WebPage/qt/TiledDrawingAreaQt.cpp: Removed.
5:52 AM Changeset in webkit [93779] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r93775.
​http://trac.webkit.org/changeset/93775
​https://bugs.webkit.org/show_bug.cgi?id=66932

"Patch introduced the failures was rolled out." (Requested by
kbalazs on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-08-25

  • platform/qt/Skipped:
5:49 AM Changeset in webkit [93778] by podivilov@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

2011-08-25 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, rebaseline chromium expectations.

  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
5:31 AM Changeset in webkit [93777] by jocelyn.turcotte@nokia.com
  • 5 edits
    1 copy
    1 add in trunk/Source/WebCore

TiledBackingStore: Untie the tile implementation from the platform.
​https://bugs.webkit.org/show_bug.cgi?id=66760

Reviewed by Kenneth Rohde Christiansen.

Make the Tile class polymorphic and introduce TiledBackingStoreBackend as a Tile factory.

  • platform/graphics/Tile.h:

(WebCore::Tile::~Tile):

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::paint):
(WebCore::TiledBackingStore::createTiles):

  • platform/graphics/TiledBackingStore.h:

(WebCore::TiledBackingStore::client):

  • platform/graphics/TiledBackingStoreBackend.h: Added.

(WebCore::TiledBackingStoreBackend::create):
(WebCore::TiledBackingStoreBackend::~TiledBackingStoreBackend):
(WebCore::TiledBackingStoreBackend::TiledBackingStoreBackend):

  • platform/graphics/qt/TileQt.cpp:

(WebCore::TileQt::TileQt):
(WebCore::TileQt::~TileQt):
(WebCore::TileQt::isDirty):
(WebCore::TileQt::isReadyToPaint):
(WebCore::TileQt::invalidate):
(WebCore::TileQt::updateBackBuffer):
(WebCore::TileQt::swapBackBufferToFront):
(WebCore::TileQt::paint):
(WebCore::TiledBackingStoreBackend::paintCheckerPattern):
(WebCore::TiledBackingStoreBackend::createTile):

  • platform/graphics/qt/TileQt.h: Copied from Source/WebCore/platform/graphics/Tile.h.

(WebCore::TileQt::create):
(WebCore::TileQt::coordinate):
(WebCore::TileQt::rect):

5:30 AM Changeset in webkit [93776] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r93767.
​http://trac.webkit.org/changeset/93767
​https://bugs.webkit.org/show_bug.cgi?id=66931

Broke Qt bot. (Requested by yutak on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-08-25

  • Scripts/webkitpy/thirdparty/init.py:
5:02 AM Changeset in webkit [93775] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed Qt gardening.

  • platform/qt/Skipped:

Patch by Zsolt Fehér <​h490267@stud.u-szeged.hu> on 2011-08-25

4:48 AM Changeset in webkit [93774] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] Path::boundingRect() is unnecessarily slow.
​https://bugs.webkit.org/show_bug.cgi?id=66854

Patch by Andreas Kling <​kling@webkit.org> on 2011-08-25
Reviewed by Benjamin Poulain.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::stroke): Remove Qt-specific optimization
since calling Path::boundingRect() will now do exactly the same thing.

  • platform/graphics/qt/PathQt.cpp:

(WebCore::Path::boundingRect): Return QPainterPath::controlPointRect() since
that is much faster than computing the (precise) QPainterPath::boundingRect()
and Path::boundingRect() is not expected to be 100% precise anyway.

4:31 AM Changeset in webkit [93773] by yutak@chromium.org
  • 3 edits in trunk/Source/WebCore

WebSocket: Queue messages to be sent
​https://bugs.webkit.org/show_bug.cgi?id=66298

Reviewed by Kent Tamura.

Blobs must be read asynchronously and thus cannot be sent immediately. Therefore, we need to
create a queue of messages to be sent in order to handle pending requests.

No new tests. Strictly speaking, there is a small change in behavior but it is hard to
reproduce in tests. See description of WebSocketChannel::send below.

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::send):
Now, this function always returns true if hybi-10 protocol is selected. The impact of this change
should be minimum, because the current WebSocket API defines the return type of WebSocket.send()
is void (see also bug 65850).
It's hard to make SocketStreamHandle::send() fail deliberately, therefore it's difficult to write
a test to detect this behavior change.
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::startClosingHandshake):
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::enqueueTextFrame):
(WebCore::WebSocketChannel::enqueueRawFrame):
(WebCore::WebSocketChannel::processOutgoingFrameQueue):
(WebCore::WebSocketChannel::abortOutgoingFrameQueue):

  • websockets/WebSocketChannel.h:
3:30 AM Changeset in webkit [93772] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Directional arrow on element info box looks terrible
​https://bugs.webkit.org/show_bug.cgi?id=66819

Beautify the tooltip arrow, give it a better alignment in some edge cases,
and fix the tooltip font on Macs.

Reviewed by Pavel Feldman.

  • inspector/DOMNodeHighlighter.cpp:
3:18 AM Changeset in webkit [93771] by jeremy@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove ATSFont*() functions in favor of CGFont in FontCustomPlatformData.cpp
​https://bugs.webkit.org/show_bug.cgi?id=66629

As of r72774 and dropping support for OS X 10.4, we can safely
remove the ATS APIs from FontCustomPlatformData.cpp in favor of just the
CGFont code.

This change is motivated by a bug in ATSFontDeactivite() on 10.7 which
affects the Chromium port, due to its compiling once against the 10.5
SDK for all platforms - See crbug.com/93191 or rdar://9976774 .

Reviewed by Dan Bernstein.

No new tests - covered by existing tests.

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):

  • platform/graphics/mac/FontCustomPlatformData.h:

(WebCore::FontCustomPlatformData::FontCustomPlatformData):

3:05 AM Changeset in webkit [93770] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-08-25 Pavel Feldman <​pfeldman@google.com>

Not reviewed: rollout r93768 for breaking build.

  • inspector/DOMNodeHighlighter.cpp:
3:01 AM Changeset in webkit [93769] by pfeldman@chromium.org
  • 63 edits
    1 copy
    1 add in trunk

Web Inspector: split ConsoleView into the View and the Model.
​https://bugs.webkit.org/show_bug.cgi?id=66861

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/BreakpointManager.js:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessage.prototype._format):

  • inspector/front-end/ConsoleModel.js: Added.

(WebInspector.ConsoleModel):
(WebInspector.ConsoleModel.prototype._setConsoleMessageExpiredCount):
(WebInspector.ConsoleModel.prototype.addMessage):
(WebInspector.ConsoleModel.prototype._incrementErrorWarningCount):
(WebInspector.ConsoleModel.prototype.requestClearMessages):
(WebInspector.ConsoleModel.prototype.clearMessages):
(WebInspector.ConsoleDispatcher):
(WebInspector.ConsoleDispatcher.prototype.messageAdded):
(WebInspector.ConsoleDispatcher.prototype.messageRepeatCountUpdated):

  • inspector/front-end/ConsolePanel.js:

(WebInspector.ConsolePanel):
(WebInspector.ConsolePanel.prototype.performSearch):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype._consoleMessageAdded):
(WebInspector.ConsoleView.prototype._appendConsoleCommand):
(WebInspector.ConsoleView.prototype._appendConsoleCommandResult):
(WebInspector.ConsoleView.prototype._appendConsoleMessage):
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._registerShortcuts):
(WebInspector.ConsoleView.prototype._requestClearMessages):

  • inspector/front-end/DebuggerModel.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.addSourceMappingListener):
(WebInspector.DebuggerPresentationModel.prototype.removeSourceMappingListener):

  • inspector/front-end/NetworkLog.js: Copied from Source/WebCore/inspector/front-end/externs.js.

(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype.get resources):
(WebInspector.NetworkLog.prototype._frameNavigated):
(WebInspector.NetworkLog.prototype._onResourceStarted):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
(WebInspector.NetworkDispatcher.prototype._mimeTypeIsConsistentWithType):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.set finished):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode.prototype._scriptForRawLocation):
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):

  • inspector/front-end/UISourceCode.js:

(WebInspector.ContentProvider):
(WebInspector.ContentProvider.prototype.requestContent):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype.update):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/externs.js:

(WebInspector.linkifyURLAsNode):
(WebInspector.formatLinkText):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector._createGlobalStatusBarItems):
(WebInspector._updateErrorAndWarningCounts):
(WebInspector.showConsole):

LayoutTests:

  • http/tests/inspector/change-iframe-src.html:
  • http/tests/inspector/console-cd-completions.html:
  • http/tests/inspector/console-cd.html:
  • http/tests/inspector/console-resource-errors.html:
  • http/tests/inspector/console-test.js:

(initialize_ConsoleTest.InspectorTest.dumpConsoleMessages):
(initialize_ConsoleTest.InspectorTest.dumpConsoleMessagesWithClasses):
(initialize_ConsoleTest.InspectorTest.expandConsoleMessages):
(initialize_ConsoleTest):

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest.InspectorTest.evaluateInConsole):
(initialize_InspectorTest):

  • http/tests/inspector/network/disabled-cache-crash.html:
  • http/tests/inspector/network/network-cachedresources-with-same-urls.html:
  • http/tests/inspector/network/network-clear-cache.html-disabled:
  • http/tests/inspector/network/network-clear-cookies.html-disabled:
  • http/tests/inspector/network/network-content-replacement-embed.html:
  • http/tests/inspector/network/network-content-replacement-xhr.html:
  • http/tests/inspector/network/network-disable-cache-memory.html:
  • http/tests/inspector/network/network-disable-cache-xhrs.html:
  • http/tests/inspector/network/network-embed.html:
  • http/tests/inspector/network/network-iframe-load-and-delete.html:
  • http/tests/inspector/network/network-initiator-from-console.html:
  • http/tests/inspector/network/network-initiator.html:
  • http/tests/inspector/network/network-request-revision-content.html:
  • http/tests/inspector/network/network-shared-worker.html:
  • http/tests/inspector/network/network-sidebar-width.html:
  • http/tests/inspector/network/network-size-chunked.html:
  • http/tests/inspector/network/network-size-sync.html:
  • http/tests/inspector/network/network-size.html:
  • http/tests/inspector/network/network-timing.html:
  • http/tests/inspector/network/network-worker.html:
  • http/tests/inspector/network/network-xhr-async.html:
  • http/tests/inspector/network/network-xhr-sync.html:
  • http/tests/inspector/resource-tree/resource-tree-frame-add.html:
  • http/tests/inspector/resource-tree/resource-tree-frame-navigate.html:
  • http/tests/inspector/resource-tree/resource-tree-no-xhrs.html:
  • inspector/console/console-assert.html:
  • inspector/console/console-trace-in-eval.html:
  • inspector/console/console-trace.html:
  • inspector/console/console-uncaught-exception.html:
  • inspector/debugger/debugger-autocontinue-on-syntax-error.html:
  • inspector/debugger/debugger-completions-on-call-frame.html:
  • inspector/styles/styles-iframe.html:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:
2:52 AM Changeset in webkit [93768] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Directional arrow on element info box looks terrible
​https://bugs.webkit.org/show_bug.cgi?id=66819

Beautify the tooltip arrow, give it a better alignment in some edge cases,
and fix the tooltip font on Macs.

Reviewed by Pavel Feldman.

  • inspector/DOMNodeHighlighter.cpp:
2:38 AM Changeset in webkit [93767] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
​https://bugs.webkit.org/show_bug.cgi?id=66924

Patch by Takashi Toyoshima <​toyoshim@chromium.org> on 2011-08-25
Reviewed by Kent Tamura.

  • Scripts/webkitpy/thirdparty/init.py:
2:25 AM Changeset in webkit [93766] by yutak@chromium.org
  • 8 edits in trunk

Let MessageEvent.data hold SerializedScriptValue or String selectively
​https://bugs.webkit.org/show_bug.cgi?id=66841

Reviewed by Adam Barth.

MessageEvent from WebSocket contains a String in its "data" attribute, but it does not have
to be serialized.

No new tests are added, because this is refactoring and the behavior should not change.

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data):
To call putAnonymousValue(), "this" needs to be converted to non-const using const_cast<>.
(WebCore::JSMessageEvent::initMessageEvent):
Update the cache value as well.

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):
ForceSet() is used to cache a value. This is the same as what the code generated by
CodeGeneratorV8 does.
(WebCore::V8MessageEvent::initMessageEventCallback):

  • dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):
(WebCore::MessageEvent::data):
This is only used within the Objective-C bindings (JSC and V8 have the custom functions).
Since Objective-C code generator does not support [CustomGetter] IDL attribute, there is
no good way to return a variant value for Objective-C bindings.

  • dom/MessageEvent.h:

(WebCore::MessageEvent::create):
(WebCore::MessageEvent::dataType):
(WebCore::MessageEvent::dataAsSerializedScriptValue):
(WebCore::MessageEvent::dataAsString):

  • dom/MessageEvent.idl:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveMessage):
Construct a MessageEvent without serializing the received message.

1:38 AM Changeset in webkit [93765] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-25 Pavel Podivilov <​podivilov@chromium.org>

Unreviwed, fix error in chromium test_expectations.

  • platform/chromium/test_expectations.txt:
1:13 AM Changeset in webkit [93764] by morrita@google.com
  • 14 edits
    4 deletes in trunk

Unreviewed, rolling out r93762.
​http://trac.webkit.org/changeset/93762
​https://bugs.webkit.org/show_bug.cgi?id=66756

IndexedDb tests crash

Source/WebCore:

  • WebCore.gypi:
  • WebCore.pro:
  • bindings/generic/EventConstructors.h: Removed.
  • bindings/v8/OptionsObject.cpp:
  • bindings/v8/OptionsObject.h:
  • bindings/v8/custom/V8EventConstructors.cpp: Removed.
  • dom/Event.cpp:
  • dom/Event.h:

(WebCore::Event::create):

  • dom/Event.idl:

LayoutTests:

  • fast/events/event-constructors-expected.txt: Removed.
  • fast/events/event-constructors.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wk2/Skipped:
1:04 AM Changeset in webkit [93763] by zherczeg@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Add Qt specific expected after r93713 since ENABLE_MEDIA_STREAM is disabled.

Unreviewed, test expectations update.

  • platform/qt/fast/files/create-blob-url-crash-expected.txt: Added.

Patch by Zoltan Herczeg <​zherczeg@webkit.org> on 2011-08-25

Aug 24, 2011:

11:58 PM Changeset in webkit [93762] by morrita@google.com
  • 14 edits
    4 adds in trunk

Implement an Event constructor.
​https://bugs.webkit.org/show_bug.cgi?id=66756

Patch by Kentaro Hara <​haraken@google.com> on 2011-08-24
Reviewed by Adam Barth.

The spec of the Event constructor is here:
​http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-event-constructor.
This patch added the Event constructor to EventConstructors.h using
JavaScript implementation-independent macros. This patch also added the V8
implementation of these macros to V8EventConstructors.cpp.

Source/WebCore:

The bug 63878 has been implementing the Event constructors for JSC.
Our plan is to first implement all the Event constructors for V8
using EventConstructors.h proposed in the JSC patch, and then merge
the JSC patch with these V8 patches. In any case, we are going to split
the patches for V8 and those for JSC in order to avoid hard regression.

Test: fast/events/event-constructors.html

  • WebCore.gypi: Added V8EventConstructors.cpp.
  • WebCore.pro: Added V8EventConstructors.cpp.
  • bindings/generic/EventConstructors.h: Added. The Event constructor. This is written using JavaScript implementation-independent macros. The V8 implementation of these macros is written in bindings/v8/custom/V8EventConstructors.cpp.
  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::getKeyDouble): Returns the value of a given key of type double.
(WebCore::OptionsObject::getKey): Returns true whenever the given key is found, even if the value is null or undefined.

  • bindings/v8/OptionsObject.h:

(WebCore::OptionsObject::getKeyValue): Returns the value of the given key. We need to overload getKeyValue() for all types required to EventConfiguration members.

  • bindings/v8/custom/V8EventConstructors.cpp: Added. Implemented macros used in EventConstructors.h.

(WebCore::constructV8Event): The Event constructor.

  • dom/Event.cpp:

(WebCore::EventConfiguration::EventConfiguration): A constructor of EventConfiguration.
(WebCore::Event::Event): A constructor of the Event class.

  • dom/Event.h: Added EventConfiguration, which manages attributes of the Event class.

(WebCore::Event::create): A factory method of the Event class with EventConfiguration.

  • dom/Event.idl: Added 'CanBeConstructed' and 'V8CustomConstructor'.

LayoutTests:

  • fast/events/event-constructors-expected.txt: Added.
  • fast/events/event-constructors.html: Added.
  • platform/gtk/Skipped: Skipped event-constructors.html, since Event constructors are not yet implemented in JSC.
  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
  • platform/wk2/Skipped: Ditto.
11:06 PM Changeset in webkit [93761] by Philippe Normand
  • 5 edits in trunk

[GTK] bump GStreamer requirement to 0.10.30
​https://bugs.webkit.org/show_bug.cgi?id=66860

Reviewed by Martin Robinson.

  • configure.ac:

WebCore:

[GTK] bump GStreamer requirement to 0.10.30
​https://bugs.webkit.org/show_bug.cgi?id=66860

Reviewed by Martin Robinson.

Use fast element linking by default.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::enterFullscreen):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
11:02 PM BuildingGtk edited by Philippe Normand
(diff)
10:50 PM Changeset in webkit [93760] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Some layerTreeAsText compositing tests are flaky
​https://bugs.webkit.org/show_bug.cgi?id=66913

Patch by James Robinson <​jamesr@chromium.org> on 2011-08-24
Reviewed by Simon Fraser.

Remove compositingLayerUpdatePending() and unconditionally update compositing layers when
RenderLayerCompositor::layerTreeAsText(). compositingLayerUpdatePending() was only used by test code and is
unreliable.

Covered by compositing/ layerTreeAsText tests.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):

  • rendering/RenderLayerCompositor.h:
10:31 PM Changeset in webkit [93759] by commit-queue@webkit.org
  • 18 edits
    2 moves
    2 deletes in trunk

Implement a keypath parser strictly following the specification
​https://bugs.webkit.org/show_bug.cgi?id=62288

Patch by Kentaro Hara <​haraken@google.com> on 2011-08-24
Reviewed by Tony Chang.

Source/WebCore:

Implemented a keypath parser that accepts either an empty string, a JavaScript
identifier, or multiple JavaScript identifiers separated by periods.
We fixed createObjectStore() and createIndex() so that they parse and check
their |keypath| argument and return an appropriate exception if the |keypath|
is not valid. We also added unit tests for the new keypath parser in keypath-basics.html.

Tests: storage/indexeddb/keypath-fetch-key.html

storage/indexeddb/keypath-basics.html

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromSerializedValueAndKeyPath): Replaced IDBKeyPathElement with String
(WebCore::injectIDBKeyIntoSerializedValue): Replaced IDBKeyPathElement with String

  • bindings/v8/IDBBindingUtilities.h:
  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::getKeyStringWithUndefinedOrNullCheck): Returns false when a given value is null or undefined
(WebCore::OptionsObject::getKey): Removed undefined check

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore): Checks if a |keypath| argument is valid, and returns a NON_TRANSIENT_ERR if it is not valid

  • storage/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::createObjectStore): Removed null check of a keypath

  • storage/IDBKeyPath.cpp:

(WebCore::IDBKeyPathLexer::currentElement): Part of the keypath parser
(WebCore::IDBKeyPathLexer::lex): Part of the keypath parser
(WebCore::IDBKeyPathLexer::lexIdentifier): Part of the keypath parser
(WebCore::IDBIsValidKeyPath): Checks if a keypath is valid
(WebCore::IDBParseKeyPath): Part of the keypath parser

  • storage/IDBKeyPath.h: Replaced IDBKeyPathElement with String
  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex): Checks if a |keypath| argument is valid, and returns a NON_TRANSIENT_ERR if it is not valid

  • storage/IDBObjectStore.idl:

Source/WebKit/chromium:

Implemented a keypath parser that accepts either an empty string, a JavaScript
identifier, or multiple JavaScript identifiers separated by periods.
We fixed createObjectStore() and createIndex() so that they parse and check
their |keypath| argument and return an appropriate exception if the |keypath|
is not valid. We also added unit tests for the new keypath parser in
tests/IDBKeyPathTest.cpp. We replaced IDBKeyPathElement with String here and there.

Tests: IDBKeyPathTest.*

IDBKeyFromValueAndKeyPathTest.*
InjectIDBKeyTest.*

  • public/WebIDBKeyPath.h:
  • src/WebIDBKeyPath.cpp:

(WebKit::WebIDBKeyPath::create): Replaced IDBKeyPathElement with String
(WebKit::WebIDBKeyPath::WebIDBKeyPath): Replaced IDBKeyPathElement with String
(WebKit::WebIDBKeyPath::assign): Replaced IDBKeyPathElement with String
(WebKit::WebIDBKeyPath::operator const WTF::Vector<WTF::String, 0>&): Replaced IDBKeyPathElement with String

  • tests/IDBBindingUtilitiesTest.cpp:

(WebCore::checkKeyFromValueAndKeyPathInternal): Replaced IDBKeyPathElement with String
(WebCore::injectKey): Replaced IDBKeyPathElement with String
(WebCore::TEST): Rewrote tests for the new keypath parser

  • tests/IDBKeyPathTest.cpp:

(WebCore::checkKeyPath): Checks if a keypath is an expected keypath or not
(WebCore::TEST): Unit tests for the new keypath parser

LayoutTests:

Implemented a keypath parser that accepts either an empty string, a JavaScript
identifier, or multiple JavaScript identifiers separated by periods.
We fixed createObjectStore() and createIndex() so that they parse and check
their |keypath| argument and return an appropriate exception if the |keypath|
is not valid. We removed create-index-null-name.html since this test violates the
specification that says "a |keypath| argument of createIndex() must not be nullable".

  • storage/indexeddb/keypath-basics-expected.txt:
  • storage/indexeddb/keypath-basics.html:
  • storage/indexeddb/keypath-fetch-key-expected.txt: Renamed from LayoutTests/storage/indexeddb/keyPath-expected.txt.
  • storage/indexeddb/keypath-fetch-key.html: Renamed from LayoutTests/storage/indexeddb/keyPath.html.
  • storage/indexeddb/mozilla/create-index-null-name-expected.txt: Removed.
  • storage/indexeddb/mozilla/create-index-null-name.html: Removed.
8:35 PM Changeset in webkit [93758] by abarth@webkit.org
  • 5 edits in trunk/Tools

The user can't close the details view in garden-o-matic
​https://bugs.webkit.org/show_bug.cgi?id=66911

Reviewed by Dimitri Glazkov.

In addition to adding a close button, this patch changes the test
selector to use a <select> element and refactors the test selector to
share code with the builder selector.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
7:38 PM Changeset in webkit [93757] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Remove expected CRASH lines for tests that don't crash

  • platform/chromium/test_expectations.txt:
7:30 PM Changeset in webkit [93756] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Remove expected failure lines from tests that work now.

  • platform/chromium/test_expectations.txt:
6:25 PM Changeset in webkit [93755] by commit-queue@webkit.org
  • 9 edits in trunk/Source/JavaScriptCore

Keep track of topCallFrame for Stack traces
​https://bugs.webkit.org/show_bug.cgi?id=66571

Patch by Juan C. Montemayor <​jmont@apple.com> on 2011-08-24
Reviewed by Geoffrey Garen.

This patch adds a TopCallFrame to JSC in order to have that information
when an error is thrown to create a stack trace. The TopCallFrame is
updated throughout select points in the Interpreter and the JSC.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::privateExecute):

  • interpreter/Interpreter.h:

(JSC::TopCallFrameSetter::TopCallFrameSetter):
(JSC::TopCallFrameSetter::~TopCallFrameSetter):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::updateTopCallFrame):

  • jit/JITStubCall.h:

(JSC::JITStubCall::call):

  • jit/JITStubs.cpp:

(JSC::throwExceptionFromOpCall):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::arityCheckFor):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:
6:23 PM Changeset in webkit [93754] by msaboff@apple.com
  • 2 edits in trunk/Source/WebKit2

Improper comment in CoreIPC/ArgumentEncoder.cpp from 66464
​https://bugs.webkit.org/show_bug.cgi?id=66912

Updated the comment in ArgumentEncoder::grow to reflect that system malloc
currently checks to see if a MADV_FREE_REUSABLE will fail before calling it.

Reviewed by Mark Rowe.

  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::grow):

6:05 PM Changeset in webkit [93753] by jamesr@google.com
  • 1 edit
    3 adds in trunk/LayoutTests

[chromium] Update chromium mac baselines for fast/repaint/japanese-rl-selection-repaint-in-regions.html

  • platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
6:02 PM Changeset in webkit [93752] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark a test as flaky.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
6:02 PM Changeset in webkit [93751] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[chromium] Stacktrace not in test output when a test crashes
​https://bugs.webkit.org/show_bug.cgi?id=66806

Patch by James Robinson <​jamesr@chromium.org> on 2011-08-24
Reviewed by Dirk Pranke.

Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
trace.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
5:59 PM Changeset in webkit [93750] by ericu@chromium.org
  • 7 edits in trunk/Source

Reviewed by Adam Barth.

[filesystem/Chromium] Filesystem paths need proper URL escaping
​https://bugs.webkit.org/show_bug.cgi?id=62811

Fix ​http://code.google.com/p/chromium/issues/detail?id=78860 by making
KURLChromium.cpp's escaping code actually work.

Source/WebCore:

Make encodeWithURLEscapeSequences call into googleurl to do proper
escaping. Tested in WebKit/chromium/tests/KURLTest.cpp.

  • platform/KURLGoogle.cpp:

(WebCore::encodeWithURLEscapeSequences):

Source/WebKit/chromium:

Here I added the needed calls to encodeWithURLEscapeSequences.

  • src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystemChromium::virtualPathToFileSystemURL):

  • src/WorkerAsyncFileSystemChromium.cpp:

(WebCore::WorkerAsyncFileSystemChromium::virtualPathToFileSystemURL):

Here I updated the test to reflect the new functionality in
encodeWithURLEscapeSequences.

  • tests/KURLTest.cpp:
5:35 PM Changeset in webkit [93749] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Resolve potential integer overflow in memory allocation, and ensure
that allocation succeeds.

Patch by Chris Palmer <​palmer@google.com> on 2011-08-24
Reviewed by Kenneth Russell.

  • platform/audio/AudioArray.h:

(WebCore::AudioArray::allocate): Check for integer overflow.
(WebCore::AudioArray::at): Document the safety assertion.
(WebCore::AudioArray::zero): Document the safety assertion.
(WebCore::AudioArray::zeroRange): Document the safety assertion.
(WebCore::AudioArray::copyToRange): Document the safety assertion.

4:04 PM Changeset in webkit [93748] by pkasting@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

[chromium] Update expectations after r93728 and r93737.

Unreviewed, test expectations update.

  • platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
4:01 PM Changeset in webkit [93747] by isherman@chromium.org
  • 10 edits
    1 delete in trunk/Source/WebKit/chromium

Remove some dead Autofill code
​https://bugs.webkit.org/show_bug.cgi?id=66899
​http://code.google.com/p/chromium/issues/detail?id=51644

Reviewed by James Robinson.

  • WebKit.gyp:
  • public/WebAutofillClient.h:
  • public/WebFrame.h:
  • public/WebPasswordAutocompleteListener.h: Removed.
  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::EditorClientImpl):
(WebKit::EditorClientImpl::handleKeyboardEvent):
(WebKit::EditorClientImpl::textFieldDidBeginEditing):
(WebKit::EditorClientImpl::textFieldDidEndEditing):
(WebKit::EditorClientImpl::textDidChangeInTextField):
(WebKit::EditorClientImpl::doTextFieldCommandFromEvent):

  • src/EditorClientImpl.h:
  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDidFinishDocumentLoad):

  • src/WebFrameImpl.cpp:

(WebKit::frameContentAsPlainText):
(WebKit::WebFrameImpl::scopeStringMatches):
(WebKit::WebFrameImpl::~WebFrameImpl):

  • src/WebFrameImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::mouseDown):

3:55 PM WikiStart edited by mjs@apple.com
(diff)
3:44 PM Changeset in webkit [93746] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

[EFL] Fix build with ENABLE_GEOLOCATION.
​https://bugs.webkit.org/show_bug.cgi?id=66881

Use adoptPtr() to create a new GeolocationService instance, otherwise
the build will fail when creating the PassOwnPtr object.

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-08-24

  • platform/efl/GeolocationServiceEfl.cpp:

(WebCore::GeolocationServiceEfl::create):

3:35 PM Changeset in webkit [93745] by dbates@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

XSS filter bypass via document.write(location.href) and fragments
​https://bugs.webkit.org/show_bug.cgi?id=66585

Reviewed by Darin Adler.

Add a test case for a variation of a DOM-based XSS attack using an anchor URL.

  • http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt: Added.
  • http/tests/security/xssAuditor/anchor-url-dom-write-location2.html: Added.
3:28 PM Changeset in webkit [93744] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

[CMake] Fix build with ENABLE_BLOB or ENABLE_FILE_SYSTEM.
​https://bugs.webkit.org/show_bug.cgi?id=66880

Generate and build some additional files required by these options.

No new tests, as this is a build fix for some build options.

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-08-24

  • CMakeLists.txt:
3:09 PM Changeset in webkit [93743] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Don't call glDeleteTexture(0) in TextureManager
​https://bugs.webkit.org/show_bug.cgi?id=66862

Delete(0) is allowed in standard OpenGL, but not in Chrome.
See ​http://code.google.com/p/chromium/issues/detail?id=85268

Patch by Iain Merrick <​husky@google.com> on 2011-08-24
Reviewed by James Robinson.

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::deleteEvictedTextures):

3:07 PM Changeset in webkit [93742] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Update expectations for tests that no longer crash.

  • platform/chromium/test_expectations.txt:
3:05 PM Changeset in webkit [93741] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/Tools

Remove empty directory.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
2:56 PM Changeset in webkit [93740] by enne@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Properly initialize CCTiledLayerImpl::m_skipsDraw
​https://bugs.webkit.org/show_bug.cgi?id=66889

Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::CCTiledLayerImpl):

2:35 PM Changeset in webkit [93739] by cevans@google.com
  • 3 edits in branches/chromium/835

Merge 93732
BUG=94011
Review URL: ​http://codereview.chromium.org/7734002

2:33 PM Changeset in webkit [93738] by abarth@webkit.org
  • 6 edits in trunk/Tools

Finish writing up details-view in garden-o-matic
​https://bugs.webkit.org/show_bug.cgi?id=66891

Reviewed by Dimitri Glazkov.

This patch mostly just copies a bunch of CSS from main.css to
summary.css. Presumably we'll delete main.css soon.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2:27 PM Changeset in webkit [93737] by jamesr@google.com
  • 4 edits in trunk

Some compositing LayoutTests flakily crashing on Mac 10.6
​https://bugs.webkit.org/show_bug.cgi?id=66740

Reviewed by Adam Barth.

Tools:

Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
chromium configuration.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_Destroy):

LayoutTests:

Remove = CRASH expectations for plugin tests that should no longer crash.

  • platform/chromium/test_expectations.txt:
2:25 PM Changeset in webkit [93736] by cevans@google.com
  • 1 edit
    4 copies in branches/chromium/835

Merge 93521
BUG=89219
Review URL: ​http://codereview.chromium.org/7727007

2:20 PM Changeset in webkit [93735] by adauria@apple.com
  • 2 edits in trunk/Tools

No review necessary.

Adding myself to list of committers.

2:06 PM Changeset in webkit [93734] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk/Source

Source/WebCore: chromium WebFrameImpl - don't load javascript URLs against chrome internal
pages. Adds a mechanism for registering sensitive schemes which should
not be subject to manipulation by javascript urls typed into a location bar
or, more importantly, their bookmarklet equivalents.
​https://bugs.webkit.org/show_bug.cgi?id=66720

Patch by Tom Sepez <​tsepez@chromium.org> on 2011-08-24
Reviewed by Adam Barth.

Test: Chromium WebKit API unit test in chromium specific directory.

  • platform/SchemeRegistry.cpp:

(WebCore::notAllowingJavascriptURLsSchemes):
(WebCore::SchemeRegistry::registerURLSchemeAsNotAllowingJavascriptURLs):
(WebCore::SchemeRegistry::shouldTreatURLSchemeAsNotAllowingJavascriptURLs):

  • platform/SchemeRegistry.h:

Source/WebKit/chromium: chromium WebFrameImpl - don't load javascript URLs against chrome internal pages.
​https://bugs.webkit.org/show_bug.cgi?id=66720

Patch by Tom Sepez <​tsepez@chromium.org> on 2011-08-24
Reviewed by Adam Barth.

  • public/WebSecurityPolicy.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::loadJavaScriptURL):

  • src/WebSecurityPolicy.cpp:

(WebKit::WebSecurityPolicy::registerURLSchemeAsNotAllowingJavascriptURLs):

  • tests/WebFrameTest.cpp:

(WebKit::WebFrameTest::WebFrameTest):
(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
(WebKit::WebFrameTest::serveRequests):
(WebKit::WebFrameTest::loadHttpFrame):
(WebKit::WebFrameTest::loadChromeFrame):
(WebKit::WebFrameTest::registerMockedURLLoad):
(WebKit::WebFrameTest::loadFrame):
(WebKit::TEST_F):

  • tests/data/history.html: Added.
1:39 PM Changeset in webkit [93733] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] More test expectation updates.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
1:36 PM Changeset in webkit [93732] by ap@apple.com
  • 5 edits in trunk

Plug-in tests are flaky on Mac
​https://bugs.webkit.org/show_bug.cgi?id=66822

Reviewed by Anders Carlsson.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): Protect objects that can be removed by a script.
  • WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto. (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): Ditto. Also fixed some nonsense code.
1:31 PM Changeset in webkit [93731] by Lucas Forschler
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

1:30 PM Changeset in webkit [93730] by Lucas Forschler
  • 1 copy in tags/Safari-534.51.18

New tag.

1:27 PM Changeset in webkit [93729] by scherkus@chromium.org
  • 2 edits in branches/chromium/835/LayoutTests/platform

Merge 93715: rebaselining media/video-currentTime-set.html

1:20 PM Changeset in webkit [93728] by commit-queue@webkit.org
  • 5 edits
    11 adds in trunk

[CSSRegions] Fix Element::getBoundingClientRect and Element::getClientRects for content flow
​https://bugs.webkit.org/show_bug.cgi?id=66641

Original author of the patch is Mihnea Ovidenie <​mihnea@adobe.com>.

Source/WebCore:

Redirected the mapLocalToContainer method to the appropriate RenderRegion.

Note: RenderObject::absoluteQuads method needs some refactor to support multiple regions,
will do that in a separate bug.

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-24
Reviewed by David Hyatt.

Tests: fast/regions/flowed-content-bounding-client-rect-horizontal-bt.html

fast/regions/flowed-content-bounding-client-rect-vertical-rl.html
fast/regions/flowed-content-bounding-client-rect-vertical.html
fast/regions/flowed-content-bounding-client-rect.html
fast/regions/flowed-content-transform-bounding-client-rect.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::renderRegionForLine):
(WebCore::RenderFlowThread::mapFromFlowToRegion):

  • rendering/RenderFlowThread.h:

LayoutTests:

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-24
Reviewed by David Hyatt.

  • fast/regions/flowed-content-bounding-client-rect-expected.txt: Added.
  • fast/regions/flowed-content-bounding-client-rect-horizontal-bt-expected.txt: Added.
  • fast/regions/flowed-content-bounding-client-rect-horizontal-bt.html: Added.
  • fast/regions/flowed-content-bounding-client-rect-vertical-expected.txt: Added.
  • fast/regions/flowed-content-bounding-client-rect-vertical-rl-expected.txt: Added.
  • fast/regions/flowed-content-bounding-client-rect-vertical-rl.html: Added.
  • fast/regions/flowed-content-bounding-client-rect-vertical.html: Added.
  • fast/regions/flowed-content-bounding-client-rect.html: Added.
  • fast/regions/flowed-content-transform-bounding-client-rect-expected.txt: Added.
  • fast/regions/flowed-content-transform-bounding-client-rect.html: Added.
  • fast/regions/resources/helper.js: Added.

(rectToArray):
(areEqualNumbers):
(areEqualRects):
(assertEqualRects):
(testBoundingRects):

1:17 PM Changeset in webkit [93727] by alokp@chromium.org
  • 3 edits in trunk/Source/WebCore

[chromium] Root layer is not updated when only a portion of tile is updated
​https://bugs.webkit.org/show_bug.cgi?id=66506

This only happened in the accelerated path which changes stencil state.
Incorrect stencil state was used to draw the root layer.

Reviewed by James Robinson.

Test: compositing/overflow/overflow-scroll.html (existing)

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):

1:16 PM Changeset in webkit [93726] by Nate Chapin
  • 3 edits
    3 adds in trunk

2011-08-24 Nate Chapin <Nate Chapin>

Fix an intermittent crash in EventSource, when a
reconnect timer triggers after a navigation
away from the current page begins.
​https://bugs.webkit.org/show_bug.cgi?id=45202

Reviewed by Alexey Proskuryakov.

Test: http/tests/eventsource/eventsource-reconnect-during-navigate-crash.html

  • page/EventSource.cpp: (WebCore::EventSource::connect): Don't set m_requestInFlight

to true if ThreadableLoader::create() failed.

1:08 PM Changeset in webkit [93725] by reed@google.com
  • 2 edits in trunk/Source/WebCore

Change clip routine to promote the clipbounds up to (local) floats and then perform the intersection,
rather than rounding the srcRect down to integers.
​https://bugs.webkit.org/show_bug.cgi?id=66810

Reviewed by Kenneth Russell.

No new tests. Existing tests that resize images will exercise this code path

  • platform/graphics/skia/SkiaUtils.cpp:

(WebCore::ClipRectToCanvas):

1:04 PM Changeset in webkit [93724] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
​https://bugs.webkit.org/show_bug.cgi?id=66875

Patch by Avi Drissman <​avi@google.com> on 2011-08-24
Reviewed by James Robinson.

  • DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:

(WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):

1:02 PM Changeset in webkit [93723] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Rename -[WKTextInputWindowController keyboardInputSourceChanged] to unmarkText to indicate what the method does
​https://bugs.webkit.org/show_bug.cgi?id=66883

Reviewed by Beth Dakin.

  • UIProcess/API/mac/WKTextInputWindowController.h:
  • UIProcess/API/mac/WKTextInputWindowController.mm:

(-[WKTextInputPanel _unmarkText]):
(-[WKTextInputWindowController unmarkText]):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]):

12:56 PM Changeset in webkit [93722] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Test expectation updates.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
12:53 PM Changeset in webkit [93721] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

[CSSRegions] RenderRegion is not used if there's another renderer after it
​https://bugs.webkit.org/show_bug.cgi?id=66844

Source/WebCore:

There was no call to attachRegion in RenderObjectChildList::insertChildNode, so
the region was not added to the RenderFlowThread.

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-24
Reviewed by David Hyatt.

Test: fast/regions/content-flowed-into-regions-dynamically-inserted.html

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::insertChildNode):

LayoutTests:

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-24
Reviewed by David Hyatt.

  • fast/regions/content-flowed-into-regions-dynamically-inserted-expected.png: Added.
  • fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-dynamically-inserted.html: Added.
12:34 PM Changeset in webkit [93720] by oliver@apple.com
  • 5 edits in trunk/Source/WebKit2

JSNPObject and JSNPMethod create their structure in their constructors
​https://bugs.webkit.org/show_bug.cgi?id=66879

Reviewed by Anders Carlsson.

It's not safe to create the Structure for an object inside its constructor
so we hoist construction out into their ::create methods and move the methods
into the cpp file.

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::JSNPMethod::JSNPMethod):
(WebKit::JSNPMethod::create):

  • WebProcess/Plugins/Netscape/JSNPMethod.h:

(WebKit::JSNPMethod::create):

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::JSNPObject):
(WebKit::JSNPObject::create):

  • WebProcess/Plugins/Netscape/JSNPObject.h:

(WebKit::JSNPObject::create):

12:32 PM Changeset in webkit [93719] by Lucas Forschler
  • 4 edits in trunk/WebKitLibraries

Update SVN properties to help out the Windows EWS bots.

Reviewed by Adam Roben.

  • win: Modified properties svn:ignore.
  • win/include: Modified property svn:ignore.
  • win/lib: Modified property svn:ignore.
12:06 PM Changeset in webkit [93718] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Organize SLOW section of expectations.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
11:28 AM Changeset in webkit [93717] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

JSHTMLImageElement (and associated Node) is abandoned when image load is canceled
<rdar://problem/9925630>
​https://bugs.webkit.org/show_bug.cgi?id=66864

Reviewed by Anders Carlsson.

In the JSC bindings, we use HTMLImageElement::hasPendingActivity() (which in turn calls
HTMLImageLoader::haveFiredLoadEvent()) to reason about the liveness of JSHTMLImageElements.
In the case that an image load is canceled, the haveFiredLoadEvent never true, so the
JSHTMLImageElement is kept alive forever (and since it references the global object, it
keeps the entire graph alive as well).

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::notifyFinished):
Set m_firedLoad to true in the case of a canceled load, to reset the state back to
its initial values.

11:27 AM Changeset in webkit [93716] by mrowe@apple.com
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r93376.

11:23 AM Changeset in webkit [93715] by scherkus@chromium.org
  • 3 edits in trunk/LayoutTests

2011-08-24 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, rebaselining media/video-currentTime-set.html due to
FFmpeg udpate.

  • platform/chromium-cg-mac/media/video-currentTime-set-expected.txt:
  • platform/chromium-win/media/video-currentTime-set-expected.txt:
11:15 AM TestExpectations edited by pkasting@chromium.org
(diff)
11:09 AM Changeset in webkit [93714] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

Expose fullscreen API on WebElement/WebDocument
​https://bugs.webkit.org/show_bug.cgi?id=66746

Patch by Jeremy Apthorp <​jeremya@google.com> on 2011-08-24
Reviewed by Darin Fisher.

  • public/WebPluginContainer.h:
  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::setFullscreen):

  • src/WebPluginContainerImpl.h:
11:07 AM Changeset in webkit [93713] by commit-queue@webkit.org
  • 14 edits
    1 copy
    1 add in trunk

MediaStream API: add createObjectURL functionality
​https://bugs.webkit.org/show_bug.cgi?id=65925

Source/WebCore:

This patch introduces the functionality for generating the url associated with a MediaStream,
which can then be assigned to the src attribute of the <video> tag for example.

Patch by Tommy Widenflycht <​tommyw@google.com> on 2011-08-24
Reviewed by Adam Barth.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::createPublicBlobURL):
(WebCore::ScriptExecutionContext::revokePublicBlobURL):

  • dom/ScriptExecutionContext.h:
  • html/DOMURL.cpp:

(WebCore::DOMURL::createObjectURL):

  • html/DOMURL.h:
  • html/DOMURL.idl:
  • platform/MediaStreamRegistry.cpp: Added.

(WebCore::MediaStreamRegistry::registry):
(WebCore::MediaStreamRegistry::registerMediaStreamURL):
(WebCore::MediaStreamRegistry::unregisterMediaStreamURL):
(WebCore::MediaStreamRegistry::mediaStream):

  • platform/MediaStreamRegistry.h: Copied from Source/WebCore/html/DOMURL.h.

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

LayoutTests:

Patch by Tommy Widenflycht <​tommyw@google.com> on 2011-08-24
Reviewed by Adam Barth.

  • fast/files/create-blob-url-crash-expected.txt:
11:00 AM Changeset in webkit [93712] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

More plug-in complex text input scaffolding
​https://bugs.webkit.org/show_bug.cgi?id=66865

Reviewed by Sam Weinig.

Make -[WKView _doneWithKeyEvent:eventWasHandled:] take an NSEvent * directly. Also
add methods for handling plug-in text input key-down events.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::doneWithKeyEvent):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _tryHandlePluginComplexTextInputKeyDown:]):
(-[WKView keyDown:]):
(-[WKView _tryPostProcessPluginComplexTextInputKeyDown:]):
(-[WKView _doneWithKeyEvent:eventWasHandled:]):

  • UIProcess/API/mac/WKViewInternal.h:
10:55 AM Changeset in webkit [93711] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[GTK] WebProcess crash on hitting assertion m_isWaitingForDidUpdate in DrawingAreaImpl
​https://bugs.webkit.org/show_bug.cgi?id=66640

Patch by Amruth Raj <​amruthraj@motorola.com> on 2011-08-24
Reviewed by Martin Robinson.

The crash happens when a new timer is created in an existing timer callback. Since
TimerBase has a single GSource* it gets overridden and the old timer can never get
stopped. To handle this, keep a copy of the old timer and use it for destruction.

  • Platform/RunLoop.h:
  • Platform/gtk/RunLoopGtk.cpp:

(RunLoop::TimerBase::timerFiredCallback):
Store the timerSource so that even if it is modified by the timer callback,
it can be restored for freeing it.
(RunLoop::TimerBase::start):
Remove destroyNotifyCallback. Destruction is now handled in timerFiredCallback itself.

10:44 AM Changeset in webkit [93710] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ErrorInstance::create sometimes has two heap object constructions
in flight at once
​https://bugs.webkit.org/show_bug.cgi?id=66845

Reviewed by Darin Adler.

The fix is simple since there is already a second create() method
that takes a UString.

  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::create):

10:42 AM Changeset in webkit [93709] by levin@chromium.org
  • 17 edits in trunk

MessageEvent.ports shouldn't ever be null.
​https://bugs.webkit.org/show_bug.cgi?id=66789

Reviewed by Darin Adler.

Source/WebCore:

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::ports): Never return null.

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::portsAccessorGetter): Ditto.

LayoutTests:

Fix all tests which verified that MessageEvents.ports was null in various cases.

  • fast/dom/Window/window-postmessage-args-expected.txt:
  • fast/events/message-port-multi-expected.txt:
  • fast/events/resources/message-port-multi.js:

(channel.port2.onmessage):

  • fast/workers/resources/worker-context-multi-port.js:

(worker.onmessage):

  • fast/workers/resources/worker-messageport.js:

(onmessage):

  • fast/workers/resources/worker-thread-multi-port.js:

(onmessage):

  • fast/workers/worker-context-multi-port-expected.txt:
  • fast/workers/worker-messageport-expected.txt:
  • fast/workers/worker-multi-port-expected.txt:
  • platform/chromium-win/fast/events/message-port-multi-expected.txt:
  • platform/chromium-win/fast/workers/worker-context-multi-port-expected.txt:
  • platform/chromium-win/fast/workers/worker-multi-port-expected.txt:
  • platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
10:30 AM Changeset in webkit [93708] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=66799
RenderFlowThread creates a list of child elements, so that it can search
the insertion point of a new element without searching the whole DOM.
The issue is that it used addChild/removeChild, but that wasn't taking care of
elements added in anonymous blocks created inside the RenderFlowThread.

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-24
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/flow-anonymous-children.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::nextRendererForNode):
(WebCore::RenderFlowThread::previousRendererForNode):
(WebCore::RenderFlowThread::addFlowChild):
(WebCore::RenderFlowThread::removeFlowChild):

  • rendering/RenderFlowThread.h:
  • rendering/RenderObjectChildList.cpp:

(WebCore::renderFlowThreadContainer):
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):

LayoutTests:

  • fast/regions/flow-anonymous-children-expected.txt: Added.
  • fast/regions/flow-anonymous-children.html: Added.
8:04 AM Changeset in webkit [93707] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[SKIA] Allow WebKitGraphicsContext3D implementation to provide a compatible GrGLInterface
​https://bugs.webkit.org/show_bug.cgi?id=66809

Patch by Brian Salomon <​bsalomon@google.com> on 2011-08-24
Reviewed by Stephen White.

  • public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::grGLInterface):

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::grContext):

6:35 AM Changeset in webkit [93706] by pfeldman@chromium.org
  • 26 edits in trunk/Source/WebCore

Web Inspector: Add 9 more javascript files to the compilation.
​https://bugs.webkit.org/show_bug.cgi?id=66847

Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/BreakpointManager.js:
  • inspector/front-end/CSSStyleModel.js:
  • inspector/front-end/Checkbox.js:
  • inspector/front-end/ConsoleMessage.js: Added.

(WebInspector.ConsoleStackFrame):
(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleMessage.prototype.get stackTrace):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated):

  • inspector/front-end/CookieParser.js:
  • inspector/front-end/DOMAgent.js:
  • inspector/front-end/DOMStorage.js:
  • inspector/front-end/Database.js:
  • inspector/front-end/DebuggerModel.js:
  • inspector/front-end/DebuggerPresentationModel.js:
  • inspector/front-end/InspectorFrontendHostStub.js:

(WebInspector.isMac):

  • inspector/front-end/NetworkManager.js:
  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.setPropertyValue):

  • inspector/front-end/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.Type.Document.0.Stylesheet.1.Image.2.Font.3.Script.4.XHR.5.WebSocket.7.Other.8.isTextType):
(WebInspector.Resource.Type.toUIString):
(WebInspector.Resource.Type.toString):
(WebInspector.Resource.prototype._checkWarnings):
(WebInspector.ResourceDomainModelBinding):
(WebInspector.ResourceDomainModelBinding.prototype.canSetContent):
(WebInspector.ResourceDomainModelBinding.prototype.setContent):

  • inspector/front-end/ResourceCategory.js:

(WebInspector.ResourceCategory):
(WebInspector.ResourceCategory.prototype.toString):
(WebInspector.ResourceCategory.prototype.get title):

  • inspector/front-end/ResourceTreeModel.js:
  • inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.prototype._didFormatContent):
(WebInspector.FormatterMappingPayload):

  • inspector/front-end/TimelineManager.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/externs.js:

(console.assert):
(WebInspector.linkifyURLAsNode):
(WebInspector.linkifyStringAsFragment):
(WebInspector.UIString):
(Element.prototype.scrollIntoViewIfNeeded):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector.UIString):

  • inspector/front-end/treeoutline.js:
  • inspector/front-end/utilities.js:
  • inspector/generate-protocol-externs:
5:52 AM Changeset in webkit [93705] by pfeldman@chromium.org
  • 6 edits
    1 add in trunk/Source/WebCore

Web Inspector: extract ConsoleMessage into a separate file.
​https://bugs.webkit.org/show_bug.cgi?id=66853

Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ConsoleMessage.js: Added.

(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleMessage.prototype._formatMessage):
(WebInspector.ConsoleMessage.prototype._linkifyLocation):
(WebInspector.ConsoleMessage.prototype._linkifyCallFrame):
(WebInspector.ConsoleMessage.prototype.isErrorOrWarning):
(WebInspector.ConsoleMessage.prototype._format):
(WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.valueFormatter):
(WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.append):
(WebInspector.ConsoleMessage.prototype.clearHighlight):
(WebInspector.ConsoleMessage.prototype.highlightSearchResults):
(WebInspector.ConsoleMessage.prototype.matchesRegex):
(WebInspector.ConsoleMessage.prototype.toMessageElement):
(WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
(WebInspector.ConsoleMessage.prototype._updateRepeatCount):
(WebInspector.ConsoleMessage.prototype.toString):
(WebInspector.ConsoleMessage.prototype.isEqual):
(WebInspector.ConsoleMessage.prototype.get stackTrace):

  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/WebKit.qrc:
4:40 AM Changeset in webkit [93704] by podivilov@chromium.org
  • 4 edits in trunk/LayoutTests

2011-08-24 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, chromium rebaseline for gradient-after-transparent-border.

  • platform/chromium-cg-mac-leopard/fast/gradients/gradient-after-transparent-border-expected.png:
  • platform/chromium-cg-mac/fast/gradients/gradient-after-transparent-border-expected.png:
  • platform/chromium/test_expectations.txt:
3:52 AM Changeset in webkit [93703] by podivilov@chromium.org
  • 2 edits
    1 move
    2 adds
    2 deletes in trunk/LayoutTests

2011-08-24 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, update test expectations for svg/custom/stroke-opacity-update.

  • platform/chromium-linux/svg/custom/stroke-opacity-update-expected.png: Added.
  • platform/chromium-win/svg/custom/stroke-opacity-update-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/stroke-opacity-update-expected.txt: Removed.
  • platform/qt/svg/custom/stroke-opacity-update-expected.txt: Removed.
  • svg/custom/stroke-opacity-update-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/stroke-opacity-update-expected.txt.
3:51 AM Changeset in webkit [93702] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Source/WebCore: Paint SliderTrack and SliderThumb independently.
​https://bugs.webkit.org/show_bug.cgi?id=50453
Also fixes ​https://bugs.webkit.org/show_bug.cgi?id=65456 crash.

Patch by Tatiana Meshkova <​tatiana.meshkova@nokia.com> on 2011-08-24
Reviewed by Kenneth Rohde Christiansen.

RenderSlider works only with <input type=range>. Nowadays RenderTheme
supports painting of SliderTrack and SliderThumb without range input.
In order to be in sync with other platforms this patch gets rid of
upcasting in RenderThemeQt::paintSliderTrack and allows to paint
SliderTrack and SliderThumb independently.

Test: platform/qt/fast/forms/range/slider-crash.html

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::paintSliderTrack): Draw SC_SliderGroove.
Allow paintSliderThumb() to care about SC_SliderHandle. We don't need
to setup value and position anymore, since handle is drawn separately.
Draw focus explicitly, since QStyleOptionSlider doesn't allow to focus
on CC_Slider without handle subcontrol.
(WebCore::RenderThemeQt::paintSliderThumb): Draw SC_SliderHandle.

LayoutTests: Pixel crash test for RenderThemeQt::paintSliderTrack.
​https://bugs.webkit.org/show_bug.cgi?id=50453

Patch by Tatiana Meshkova <​tatiana.meshkova@nokia.com> on 2011-08-24
Reviewed by Kenneth Rohde Christiansen.

Support -webkit-appearance: slider-horizontal/vertical
painting without range input.

  • platform/qt/fast/forms/range/slider-crash-expected.png: Added.
  • platform/qt/fast/forms/range/slider-crash-expected.txt: Added.
  • platform/qt/fast/forms/range/slider-crash.html: Added.
3:18 AM Changeset in webkit [93701] by pfeldman@chromium.org
  • 26 edits in trunk/Source/WebCore

Web Inspector: annotate and prepare for compilation first 14 JavaScript files within 4 modules.
​https://bugs.webkit.org/show_bug.cgi?id=66776

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/ContextMenu.js:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._loadNodeAttributes):
(WebInspector.DOMAgent.prototype._childNodeRemoved):
(WebInspector.DOMAgent.prototype._inspectElementRequested):
(WebInspector.DOMDispatcher.prototype.inspectElementRequested):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.Location):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._inspectElementRequested):

  • inspector/front-end/InspectorFrontendHostStub.js:
  • inspector/front-end/KeyboardShortcut.js:
  • inspector/front-end/Object.js:

(WebInspector.Object.prototype.addEventListener):
(WebInspector.Object.prototype.removeEventListener):
(WebInspector.Object.prototype.hasEventListeners):

  • inspector/front-end/Panel.js:

(WebInspector.Panel):

  • inspector/front-end/Placard.js:
  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype.show):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):
(WebInspector.StorageCategoryTreeElement):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.editSource):

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/Settings.js:

(WebInspector.Settings):
(WebInspector.Settings.prototype.createSetting):

  • inspector/front-end/SoftContextMenu.js:

(.WebInspector.SoftContextMenu.prototype._menuItemMouseUp):
(.WebInspector.SoftContextMenu.prototype._triggerAction):
(.WebInspector.SoftContextMenu.prototype._menuKeyDown):

  • inspector/front-end/TabbedPane.js:
  • inspector/front-end/TextPrompt.js:
  • inspector/front-end/UserMetrics.js:
  • inspector/front-end/View.js:
  • inspector/front-end/externs.js:

(JSON.parse):
(JSON.stringify):

  • inspector/front-end/inspector.js:

():

  • inspector/generate-protocol-externs:
3:10 AM Changeset in webkit [93700] by podivilov@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-08-24 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, fix chromium expectations for fast/preloader/script.html.

  • platform/chromium/fast/preloader/script-expected.txt: Added.
2:52 AM Changeset in webkit [93699] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

SelectElementData: Reorder members to reduce memory usage.
​https://bugs.webkit.org/show_bug.cgi?id=66787

Reviewed by Darin Adler.

Reduced the size of SelectElementData by 24 bytes on 64-bit by rearranging
its data members.

Also added missing initialization of m_userDrivenChange.

  • dom/SelectElement.cpp:

(WebCore::SelectElementData::SelectElementData):

  • dom/SelectElement.h:
2:50 AM Changeset in webkit [93698] by fpizlo@apple.com
  • 20 edits
    2 adds in trunk/Source/JavaScriptCore

There is no facility for profiling how the write barrier is used
​https://bugs.webkit.org/show_bug.cgi?id=66747

Reviewed by Geoffrey Garen.

Added facilities for the JIT to specify the kind of write barrier
being executed. Added code for profiling the number of each kind
of barrier encountered.

(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::cachedPutById):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::emitCount):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::emitCount):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCachePutByID):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • heap/Heap.h:

(JSC::Heap::writeBarrier):

  • heap/WriteBarrierSupport.cpp: Added.

(JSC::WriteBarrierCounters::initialize):

  • heap/WriteBarrierSupport.h: Added.

(JSC::WriteBarrierCounters::WriteBarrierCounters):
(JSC::WriteBarrierCounters::jitCounterFor):
(JSC::WriteBarrierCounters::countWriteBarrier):

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emitWriteBarrier):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emitWriteBarrier):

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/WriteBarrier.h:

(JSC::WriteBarrierBase::setWithoutWriteBarrier):

2:48 AM Changeset in webkit [93697] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebKit/efl

[EFL] Add dummy IconDatabaseClientEfl.
​http://bugs.webkit.org/show_bug.cgi?id=65596

Implements a dummy IconDatabaseClientEfl class.
Adds two files, IconDatabaseClientEfl.h | .cpp.

Patch by Jaehun Lim <​ljaehun.lim@samsung.com> on 2011-08-24
Reviewed by Kent Tamura.

  • CMakeListsEfl.txt:
  • WebCoreSupport/IconDatabaseClientEfl.cpp: Added.

(WebCore::IconDatabaseClientEfl::performImport):
(WebCore::IconDatabaseClientEfl::didRemoveAllIcons):
(WebCore::IconDatabaseClientEfl::didImportIconURLForPageURL):
(WebCore::IconDatabaseClientEfl::didImportIconDataForPageURL):
(WebCore::IconDatabaseClientEfl::didChangeIconForPageURL):
(WebCore::IconDatabaseClientEfl::didFinishURLImport):

  • WebCoreSupport/IconDatabaseClientEfl.h: Added.
2:07 AM Changeset in webkit [93696] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: clearPseudoState should retain Element while clearing
its state.
​https://bugs.webkit.org/show_bug.cgi?id=66790

Patch by Pavel Feldman <​pfeldman@google.com> on 2011-08-24
Reviewed by Yury Semikhatsky.

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::clearPseudoState):

Note: See TracTimeline for information about the timeline view.