⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 27, 2011:

3:01 PM Changeset in webkit [93948] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

Don't rely on hardcoded position in absolute-appended-to-inline.html

Allow test added in r93944 to pass on platforms other than Chromium-Linux.

Unreviewed, fix on r93944.

  • fast/block/positioning/absolute-appended-to-inline.html:
2:49 PM Changeset in webkit [93947] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

JSC::Executable is inconsistent about using weak handle finalizers
and destructors for releasing memory
​https://bugs.webkit.org/show_bug.cgi?id=67072

Reviewed by Darin Adler.

Moved more of the destruction of Executable state into the finalizer,
which also resulted in an opportunity to mostly combine this with
discardCode(). This also means that the finalizer is now enabled even
when the JIT is turned off. This is performance neutral on SunSpider,
V8, and Kraken.

  • runtime/Executable.cpp:

(JSC::ExecutableBase::clearCode):
(JSC::ExecutableFinalizer::finalize):
(JSC::EvalExecutable::clearCode):
(JSC::ProgramExecutable::clearCode):
(JSC::FunctionExecutable::discardCode):
(JSC::FunctionExecutable::clearCode):

  • runtime/Executable.h:

(JSC::ExecutableBase::finishCreation):

2:31 PM Changeset in webkit [93946] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add a build bot for Chromium with OS(ANDROID)
​https://bugs.webkit.org/show_bug.cgi?id=66687

Patch by Peter Beverloo <​peter@chromium.org> on 2011-08-27
Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
2:12 PM Changeset in webkit [93945] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

SQLiteStatement::getColumnText() could construct WTF::String result more efficiently.
​https://bugs.webkit.org/show_bug.cgi?id=67090

Patch by Andreas Kling <​kling@webkit.org> on 2011-08-27
Reviewed by Darin Adler.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::getColumnText): Use sqlite3_column_bytes16()
to get the length of the column text without looking for the null terminator.

2:03 PM Changeset in webkit [93944] by robert@webkit.org
  • 3 edits
    2 adds in trunk

The child div element with position:absolute will overlap with its parent div when a 'break' element is present in between
​https://bugs.webkit.org/show_bug.cgi?id=21934

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/block/positioning/absolute-appended-to-inline.html

Appending a positioned child node to an inline flow should dirty the lines in the flow, just as
inserting a positioned child node does. Treating an appended and inserted node differently meant that updating the display type
from 'none' to 'block' for the following markup would result in the div getting positioned correctly under
the line block:

<div><a onMouseOver="mopen()">Hover</a><div style="display:none; position:absolute; background:#4682b4; height:10px; width:20px"><br></div></div>

but this would not happen with the following markup (the <br> is before the child div rather than after it):

<div><a onMouseOver="mopen()">Hover</a><br><div style="display:none; position:absolute; background:#4682b4; height:10px; width:20px"></div></div>

This problem is specific to cases where an object is appended to a line block whose last child is a <br>. When the line is relaid out after appending
the positioned object the last line in the line block is always considered dirty unless it broke cleanly (ie. with a <br>, see RenderBlock::determineStartPosition),
So in the second case above, the clean break and failing to dirty any lines in the block when appending the object means that the line block doesn't get relaid out
to position the new positioned object relative to its containing line block.

So the change could special-case appending a node when the previous sibling isBR(), but it seems just as well to behave the same way as insertChildNode().

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::appendChildNode):

Call dirtyLinesFromChangedChild() if the child is positioned, just like insertChildNode().

LayoutTests:

  • fast/block/positioning/absolute-appended-to-inline-expected.txt: Added.
  • fast/block/positioning/absolute-appended-to-inline.html: Added.
1:22 PM Changeset in webkit [93943] by andersca@apple.com
  • 3 edits
    3 adds in trunk

iChat: Receiving a message containing only a single-quote (') causes bubble to fail
​https://bugs.webkit.org/show_bug.cgi?id=67076
<rdar://problem/10026089>

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/borders/border-fit-2.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::borderFitAdjust):
Make sure that the resulting rect isn't smaller than the border + padding.

(WebCore::RenderBlock::clearTruncation):
Fix blatant coding style violations.

LayoutTests:

  • fast/borders/border-fit-2.html: Added.
  • platform/mac/fast/borders/border-fit-2-expected.png: Added.
  • platform/mac/fast/borders/border-fit-2-expected.txt: Added.
12:05 PM Changeset in webkit [93942] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Update the master build bot configuration script to properly
deal with the --chromium-android switch.
​https://bugs.webkit.org/show_bug.cgi?id=66687

The --chromium-android switch is needed when running
update-webkit-chromium and build-webkit, as it'll tell the
scripts to pull in the right dependencies and cross-compile
WebKit using the Android NDK.

Patch by Peter Beverloo <​peter@chromium.org> on 2011-08-27
Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
12:02 PM Changeset in webkit [93941] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Shrink RenderLayer.
​https://bugs.webkit.org/show_bug.cgi?id=67089

Patch by Andreas Kling <​kling@webkit.org> on 2011-08-27
Reviewed by Antonio Gomes.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):

  • rendering/RenderLayer.h: Make m_inResizeMode a bitfield,

shrinking RenderLayer by 8 bytes (on 64-bit.)

11:58 AM Changeset in webkit [93940] by enne@google.com
  • 3 edits in branches/chromium/835/Source/WebCore/platform/graphics/chromium

[chromium] Possible leak of LayerRendererChromium
​https://bugs.webkit.org/show_bug.cgi?id=66981

Patch by James Robinson < ​jamesr@chromium.org> on 2011-08-26
From ​http://codereview.chromium.org/7749028/

Fix a number of reference cycle leaks that prevent
LayerRendererChromiums from being destroyed when a tab is closed.

Not possible to write a layout test where an entire WebView goes away.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::clearRenderSurfacesOnCCLayerImplRecursive):
(WebCore::LayerRendererChromium::clearRootCCLayerImpl):
(WebCore::LayerRendererChromium::setRootLayer):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:
11:57 AM Changeset in webkit [93939] by commit-queue@webkit.org
  • 7 edits in trunk

Teach the update and build scripts how to handle dependencies
and cross-compiling rules for the Chromium port on OS(ANDROID).
​https://bugs.webkit.org/show_bug.cgi?id=66687

Patch by Peter Beverloo <​peter@chromium.org> on 2011-08-27
Reviewed by Adam Barth.

Source/WebKit/chromium:

  • gyp_webkit:

Tools:

  • Scripts/build-webkit:
  • Scripts/update-webkit:
  • Scripts/update-webkit-chromium:
  • Scripts/webkitdirs.pm:

(argumentsForConfiguration):
(isChromium):
(isChromiumAndroid):
(determineIsChromiumAndroid):
(buildChromium):

11:09 AM Changeset in webkit [93938] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Patch by Young Han Lee <​joybro@company100.net> on 2011-08-27
Reviewed by Dirk Schulze.

SVG animation fill="freeze" doesn't set baseVal to current animVal if animation stops before reaching the end
​https://bugs.webkit.org/show_bug.cgi?id=63553

calculateAnimationPercentAndRepeat() is returning 1, which means 100%, whenever
elapsed >= m_intervalEnd, but this is wrong because m_intervalEnd can be in the middle
of the animation duration. (e.g. begin="0s" end="2s" dur="3s")

This change makes the function return the animations's true progress instead of 100%
when the animation ends.

Source/WebCore:

Test: svg/animations/animate-end-attribute.html

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):

LayoutTests:

  • svg/animations/animate-end-attribute-expected.txt: Added.
  • svg/animations/animate-end-attribute.html: Added.
  • svg/animations/script-tests/animate-end-attribute.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

4:06 AM Changeset in webkit [93937] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

[Qt] Need spin-button implementation
​https://bugs.webkit.org/show_bug.cgi?id=65896

Patch by Jarred Nicholls <​jarred@sencha.com> on 2011-08-27
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeQt::paintInnerSpinButton):

  • platform/qt/RenderThemeQt.h:

LayoutTests:

  • platform/qt/Skipped:
  • platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.
  • platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
  • platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Added.
12:54 AM Changeset in webkit [93936] by Csaba Osztrogonác
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Remove a non-existent test.
  • platform/qt/fast/text/complex-preferred-logical-widths-expected.png: Added.
  • platform/qt/fast/text/complex-preferred-logical-widths-expected.txt: Added.

Aug 26, 2011:

9:42 PM Changeset in webkit [93935] by xji@chromium.org
  • 7 edits
    8 adds in trunk

Regression(91788): Bad cast in WebCore::blockWithNextLineBox
​https://bugs.webkit.org/show_bug.cgi?id=66090

Reviewed by Ryosuke Niwa.

Source/WebCore:

This is more like (but not exactly) a revert of r91788.
It does not search for previous or next root inline box in different
render object, which completely eliminates the cause of this issue.
And it removes createPositionAvoidingIgnoredNode(), changed its caller
to use createLegacyEditingPosition(). createPositionAvoidingIgnoredNode
is not correct when node is a replaced element whose caretMaxOffset
could be greater than 1.

Tests: editing/selection/move-by-word-visually-crash-test-1.html

editing/selection/move-by-word-visually-crash-test-2.html
editing/selection/move-by-word-visually-crash-test-3.html
editing/selection/move-by-word-visually-crash-test-4.html

  • editing/htmlediting.cpp:
  • editing/htmlediting.h:
  • editing/visible_units.cpp:

(WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality):
(WebCore::leftmostPositionInRTLBoxInLTRBlock):
(WebCore::rightmostPositionInLTRBoxInRTLBlock):
(WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality):
(WebCore::appendPositionAtLogicalEndOfLine):
(WebCore::leftInlineBox):
(WebCore::rightInlineBox):

LayoutTests:

  • editing/selection/move-by-word-visually-crash-test-1-expected.txt: Added.
  • editing/selection/move-by-word-visually-crash-test-1.html: Added.
  • editing/selection/move-by-word-visually-crash-test-2-expected.txt: Added.
  • editing/selection/move-by-word-visually-crash-test-2.html: Added.
  • editing/selection/move-by-word-visually-crash-test-3-expected.txt: Added.
  • editing/selection/move-by-word-visually-crash-test-3.html: Added.
  • editing/selection/move-by-word-visually-crash-test-4-expected.txt: Added.
  • editing/selection/move-by-word-visually-crash-test-4.html: Added.
  • editing/selection/move-by-word-visually-multi-line-expected.txt:
  • editing/selection/resources/move-by-word-visually.js:

(runMoveLeftRight):

9:19 PM Changeset in webkit [93934] by barraclough@apple.com
  • 8 edits in trunk

DFG JIT - ArithMod may clobber operands.
​https://bugs.webkit.org/show_bug.cgi?id=67085

Reviewed by Sam Weinig.

Source/JavaScriptCore:

unboxDouble must be called on a temporary.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::fillDouble):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::boxDouble):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

LayoutTests:

Added test case.

  • fast/js/mod-crash-expected.txt:
  • fast/js/script-tests/mod-crash.js:

(nonSpeculativeModReuseInner):
(nonSpeculativeModReuse):

8:51 PM Changeset in webkit [93933] by abarth@webkit.org
  • 4 edits in trunk/Tools

garden-o-matic should let me know that I need to run the local server
​https://bugs.webkit.org/show_bug.cgi?id=66985

Reviewed by Dimitri Glazkov.

The patch triggers an alert dialog whenever the user tries to use a
feature that requires the local server.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
7:15 PM Changeset in webkit [93932] by commit-queue@webkit.org
  • 23 edits in trunk/LayoutTests

Cleanup resulting text of media/track tests.
​https://bugs.webkit.org/show_bug.cgi?id=67073

Patch by Anna Cavender <​annacc@chromium.org> on 2011-08-26
Reviewed by Eric Carlson.

  • media/track/track-webvtt-tc001-utf8-expected.txt:
  • media/track/track-webvtt-tc002-bom-expected.txt:
  • media/track/track-webvtt-tc003-newlines-expected.txt:
  • media/track/track-webvtt-tc004-magic-header-expected.txt:
  • media/track/track-webvtt-tc005-header-comment-expected.txt:
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt:
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt:
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt:
  • media/track/track-webvtt-tc009-timings-hour-expected.txt:
  • media/track/track-webvtt-tc011-blank-lines-expected.txt:
  • media/track/track-webvtt-tc013-settings-expected.txt:
  • media/track/track-webvtt-tc014-alignment-expected.txt:
  • media/track/track-webvtt-tc015-positioning-expected.txt:
  • media/track/track-webvtt-tc016-align-positioning-expected.txt:
  • media/track/track-webvtt-tc017-line-position-expected.txt:
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt:
  • media/track/track-webvtt-tc019-cue-size-expected.txt:
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt:
  • media/track/track-webvtt-tc021-valign-expected.txt:
  • media/track/track-webvtt-tc022-entities-expected.txt:
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt:
  • media/video-test.js:

(testCues):

6:05 PM Changeset in webkit [93931] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Stop using custom NSErrors for WebKit2 WebErrors
​https://bugs.webkit.org/show_bug.cgi?id=67075

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/WebErrors.h:
  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:

(WebKit::createNSError):
(WebKit::cancelledError):
(WebKit::fileDoesNotExistError):
(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptedForPolicyChangeError):
(WebKit::cannotShowMIMETypeError):
(WebKit::pluginWillHandleLoadError):
There is no reason to use custom registered NSErrors anymore, so don't.

6:05 PM Changeset in webkit [93930] by levin@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

[chromium] Update tests expectations due to r93909 and r93913.

  • platform/chromium-cg-mac/fast/text/complex-preferred-logical-widths-expected.txt: Added.
  • platform/chromium-linux/fast/text/complex-preferred-logical-widths-expected.png: Added.
  • platform/chromium-win/fast/text/complex-preferred-logical-widths-expected.png: Added.
  • platform/chromium/test_expectations.txt:
5:52 PM Changeset in webkit [93929] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
5:41 PM Changeset in webkit [93928] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebKit/chromium

[chromium] Add MockWebGraphicsContext3D, for compositor unit testing
​https://bugs.webkit.org/show_bug.cgi?id=67006

MockWebGraphicsContext3D is a no-op implementation of the pure virtual
interface WebGraphicsContext3D. I've included a test with a couple of
example usages: subclassing it manually, and using it with GMock.

Patch by Iain Merrick <​husky@google.com> on 2011-08-26
Reviewed by Kenneth Russell.

  • WebKit.gypi:
  • tests/MockWebGraphicsContext3D.h: Added.

(WebKit::MockWebGraphicsContext3D::initialize):
(WebKit::MockWebGraphicsContext3D::makeContextCurrent):
(WebKit::MockWebGraphicsContext3D::width):
(WebKit::MockWebGraphicsContext3D::height):
(WebKit::MockWebGraphicsContext3D::reshape):
(WebKit::MockWebGraphicsContext3D::isGLES2Compliant):
(WebKit::MockWebGraphicsContext3D::readBackFramebuffer):
(WebKit::MockWebGraphicsContext3D::getPlatformTextureId):
(WebKit::MockWebGraphicsContext3D::prepareTexture):
(WebKit::MockWebGraphicsContext3D::synthesizeGLError):
(WebKit::MockWebGraphicsContext3D::isContextLost):
(WebKit::MockWebGraphicsContext3D::mapBufferSubDataCHROMIUM):
(WebKit::MockWebGraphicsContext3D::unmapBufferSubDataCHROMIUM):
(WebKit::MockWebGraphicsContext3D::mapTexSubImage2DCHROMIUM):
(WebKit::MockWebGraphicsContext3D::unmapTexSubImage2DCHROMIUM):
(WebKit::MockWebGraphicsContext3D::getRequestableExtensionsCHROMIUM):
(WebKit::MockWebGraphicsContext3D::requestExtensionCHROMIUM):
(WebKit::MockWebGraphicsContext3D::blitFramebufferCHROMIUM):
(WebKit::MockWebGraphicsContext3D::renderbufferStorageMultisampleCHROMIUM):
(WebKit::MockWebGraphicsContext3D::activeTexture):
(WebKit::MockWebGraphicsContext3D::attachShader):
(WebKit::MockWebGraphicsContext3D::bindAttribLocation):
(WebKit::MockWebGraphicsContext3D::bindBuffer):
(WebKit::MockWebGraphicsContext3D::bindFramebuffer):
(WebKit::MockWebGraphicsContext3D::bindRenderbuffer):
(WebKit::MockWebGraphicsContext3D::bindTexture):
(WebKit::MockWebGraphicsContext3D::blendColor):
(WebKit::MockWebGraphicsContext3D::blendEquation):
(WebKit::MockWebGraphicsContext3D::blendEquationSeparate):
(WebKit::MockWebGraphicsContext3D::blendFunc):
(WebKit::MockWebGraphicsContext3D::blendFuncSeparate):
(WebKit::MockWebGraphicsContext3D::bufferData):
(WebKit::MockWebGraphicsContext3D::bufferSubData):
(WebKit::MockWebGraphicsContext3D::checkFramebufferStatus):
(WebKit::MockWebGraphicsContext3D::clear):
(WebKit::MockWebGraphicsContext3D::clearColor):
(WebKit::MockWebGraphicsContext3D::clearDepth):
(WebKit::MockWebGraphicsContext3D::clearStencil):
(WebKit::MockWebGraphicsContext3D::colorMask):
(WebKit::MockWebGraphicsContext3D::compileShader):
(WebKit::MockWebGraphicsContext3D::copyTexImage2D):
(WebKit::MockWebGraphicsContext3D::copyTexSubImage2D):
(WebKit::MockWebGraphicsContext3D::cullFace):
(WebKit::MockWebGraphicsContext3D::depthFunc):
(WebKit::MockWebGraphicsContext3D::depthMask):
(WebKit::MockWebGraphicsContext3D::depthRange):
(WebKit::MockWebGraphicsContext3D::detachShader):
(WebKit::MockWebGraphicsContext3D::disable):
(WebKit::MockWebGraphicsContext3D::disableVertexAttribArray):
(WebKit::MockWebGraphicsContext3D::drawArrays):
(WebKit::MockWebGraphicsContext3D::drawElements):
(WebKit::MockWebGraphicsContext3D::enable):
(WebKit::MockWebGraphicsContext3D::enableVertexAttribArray):
(WebKit::MockWebGraphicsContext3D::finish):
(WebKit::MockWebGraphicsContext3D::flush):
(WebKit::MockWebGraphicsContext3D::framebufferRenderbuffer):
(WebKit::MockWebGraphicsContext3D::framebufferTexture2D):
(WebKit::MockWebGraphicsContext3D::frontFace):
(WebKit::MockWebGraphicsContext3D::generateMipmap):
(WebKit::MockWebGraphicsContext3D::getActiveAttrib):
(WebKit::MockWebGraphicsContext3D::getActiveUniform):
(WebKit::MockWebGraphicsContext3D::getAttachedShaders):
(WebKit::MockWebGraphicsContext3D::getAttribLocation):
(WebKit::MockWebGraphicsContext3D::getBooleanv):
(WebKit::MockWebGraphicsContext3D::getBufferParameteriv):
(WebKit::MockWebGraphicsContext3D::getContextAttributes):
(WebKit::MockWebGraphicsContext3D::getError):
(WebKit::MockWebGraphicsContext3D::getFloatv):
(WebKit::MockWebGraphicsContext3D::getFramebufferAttachmentParameteriv):
(WebKit::MockWebGraphicsContext3D::getIntegerv):
(WebKit::MockWebGraphicsContext3D::getProgramiv):
(WebKit::MockWebGraphicsContext3D::getProgramInfoLog):
(WebKit::MockWebGraphicsContext3D::getRenderbufferParameteriv):
(WebKit::MockWebGraphicsContext3D::getShaderiv):
(WebKit::MockWebGraphicsContext3D::getShaderInfoLog):
(WebKit::MockWebGraphicsContext3D::getShaderSource):
(WebKit::MockWebGraphicsContext3D::getString):
(WebKit::MockWebGraphicsContext3D::getTexParameterfv):
(WebKit::MockWebGraphicsContext3D::getTexParameteriv):
(WebKit::MockWebGraphicsContext3D::getUniformfv):
(WebKit::MockWebGraphicsContext3D::getUniformiv):
(WebKit::MockWebGraphicsContext3D::getUniformLocation):
(WebKit::MockWebGraphicsContext3D::getVertexAttribfv):
(WebKit::MockWebGraphicsContext3D::getVertexAttribiv):
(WebKit::MockWebGraphicsContext3D::getVertexAttribOffset):
(WebKit::MockWebGraphicsContext3D::hint):
(WebKit::MockWebGraphicsContext3D::isBuffer):
(WebKit::MockWebGraphicsContext3D::isEnabled):
(WebKit::MockWebGraphicsContext3D::isFramebuffer):
(WebKit::MockWebGraphicsContext3D::isProgram):
(WebKit::MockWebGraphicsContext3D::isRenderbuffer):
(WebKit::MockWebGraphicsContext3D::isShader):
(WebKit::MockWebGraphicsContext3D::isTexture):
(WebKit::MockWebGraphicsContext3D::lineWidth):
(WebKit::MockWebGraphicsContext3D::linkProgram):
(WebKit::MockWebGraphicsContext3D::pixelStorei):
(WebKit::MockWebGraphicsContext3D::polygonOffset):
(WebKit::MockWebGraphicsContext3D::readPixels):
(WebKit::MockWebGraphicsContext3D::releaseShaderCompiler):
(WebKit::MockWebGraphicsContext3D::renderbufferStorage):
(WebKit::MockWebGraphicsContext3D::sampleCoverage):
(WebKit::MockWebGraphicsContext3D::scissor):
(WebKit::MockWebGraphicsContext3D::shaderSource):
(WebKit::MockWebGraphicsContext3D::stencilFunc):
(WebKit::MockWebGraphicsContext3D::stencilFuncSeparate):
(WebKit::MockWebGraphicsContext3D::stencilMask):
(WebKit::MockWebGraphicsContext3D::stencilMaskSeparate):
(WebKit::MockWebGraphicsContext3D::stencilOp):
(WebKit::MockWebGraphicsContext3D::stencilOpSeparate):
(WebKit::MockWebGraphicsContext3D::texImage2D):
(WebKit::MockWebGraphicsContext3D::texParameterf):
(WebKit::MockWebGraphicsContext3D::texParameteri):
(WebKit::MockWebGraphicsContext3D::texSubImage2D):
(WebKit::MockWebGraphicsContext3D::uniform1f):
(WebKit::MockWebGraphicsContext3D::uniform1fv):
(WebKit::MockWebGraphicsContext3D::uniform1i):
(WebKit::MockWebGraphicsContext3D::uniform1iv):
(WebKit::MockWebGraphicsContext3D::uniform2f):
(WebKit::MockWebGraphicsContext3D::uniform2fv):
(WebKit::MockWebGraphicsContext3D::uniform2i):
(WebKit::MockWebGraphicsContext3D::uniform2iv):
(WebKit::MockWebGraphicsContext3D::uniform3f):
(WebKit::MockWebGraphicsContext3D::uniform3fv):
(WebKit::MockWebGraphicsContext3D::uniform3i):
(WebKit::MockWebGraphicsContext3D::uniform3iv):
(WebKit::MockWebGraphicsContext3D::uniform4f):
(WebKit::MockWebGraphicsContext3D::uniform4fv):
(WebKit::MockWebGraphicsContext3D::uniform4i):
(WebKit::MockWebGraphicsContext3D::uniform4iv):
(WebKit::MockWebGraphicsContext3D::uniformMatrix2fv):
(WebKit::MockWebGraphicsContext3D::uniformMatrix3fv):
(WebKit::MockWebGraphicsContext3D::uniformMatrix4fv):
(WebKit::MockWebGraphicsContext3D::useProgram):
(WebKit::MockWebGraphicsContext3D::validateProgram):
(WebKit::MockWebGraphicsContext3D::vertexAttrib1f):
(WebKit::MockWebGraphicsContext3D::vertexAttrib1fv):
(WebKit::MockWebGraphicsContext3D::vertexAttrib2f):
(WebKit::MockWebGraphicsContext3D::vertexAttrib2fv):
(WebKit::MockWebGraphicsContext3D::vertexAttrib3f):
(WebKit::MockWebGraphicsContext3D::vertexAttrib3fv):
(WebKit::MockWebGraphicsContext3D::vertexAttrib4f):
(WebKit::MockWebGraphicsContext3D::vertexAttrib4fv):
(WebKit::MockWebGraphicsContext3D::vertexAttribPointer):
(WebKit::MockWebGraphicsContext3D::viewport):
(WebKit::MockWebGraphicsContext3D::createBuffer):
(WebKit::MockWebGraphicsContext3D::createFramebuffer):
(WebKit::MockWebGraphicsContext3D::createProgram):
(WebKit::MockWebGraphicsContext3D::createRenderbuffer):
(WebKit::MockWebGraphicsContext3D::createShader):
(WebKit::MockWebGraphicsContext3D::createTexture):
(WebKit::MockWebGraphicsContext3D::deleteBuffer):
(WebKit::MockWebGraphicsContext3D::deleteFramebuffer):
(WebKit::MockWebGraphicsContext3D::deleteProgram):
(WebKit::MockWebGraphicsContext3D::deleteRenderbuffer):
(WebKit::MockWebGraphicsContext3D::deleteShader):
(WebKit::MockWebGraphicsContext3D::deleteTexture):

  • tests/MockWebGraphicsContext3DTest.cpp: Added.

(TEST):
(FrameCountingContext::FrameCountingContext):
(FrameCountingContext::prepareTexture):
(FrameCountingContext::frameCount):

5:38 PM Changeset in webkit [93927] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[Chromium] Possible leak of LayerRendererChromium
​https://bugs.webkit.org/show_bug.cgi?id=66981

Patch by James Robinson <​jamesr@chromium.org> on 2011-08-26
Reviewed by Kenneth Russell.

Fix a number of reference cycle leaks that prevent LayerRendererChromiums from being destroyed when a tab is
closed.

Not possible to write a layout test where an entire WebView goes away.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::clearRenderSurfacesOnCCLayerImplRecursive):
(WebCore::LayerRendererChromium::clearRootCCLayerImpl):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setRootLayer):

5:23 PM Changeset in webkit [93926] by Dimitri Glazkov
  • 5 edits in trunk/Tools

garden-o-matic summary view should have pretty commit data information.
​https://bugs.webkit.org/show_bug.cgi?id=67069

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
4:44 PM Changeset in webkit [93925] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fold _webkit_initWithDomain into _webkit_errorWithDomain in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=67063

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:

(+[NSError _webkit_errorWithDomain:code:URL:]):

4:42 PM Changeset in webkit [93924] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Update tests expectations due to r93909.

  • platform/mac/fast/text/complex-preferred-logical-widths-expected.txt:
4:31 PM Changeset in webkit [93923] by Nate Chapin
  • 13 edits in trunk/Source/WebCore

Move allowCredentials from ThreadableLoaderOptions down
to ResourceLoaderOptions. This allows us to remove
getShouldUseCredentialStorage() from SubresourceLoaderClient
and check allowCredentials in ResourceLoader.
​https://bugs.webkit.org/show_bug.cgi?id=65330

Reviewed by Alexey Proskuryakov.

No new tests, refractor only.

  • loader/DocumentThreadableLoader.cpp:
  • loader/DocumentThreadableLoader.h:
  • loader/MainResourceLoader.cpp:
  • loader/NetscapePlugInStreamLoader.cpp:
  • loader/ResourceLoadScheduler.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::shouldUseCredentialStorage): Check

m_options.allowCredentials instead of calling a client.

  • loader/ResourceLoaderOptions.h:
  • loader/SubresourceLoader.cpp:
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h:
  • loader/ThreadableLoader.h:
  • loader/cache/CachedResourceRequest.cpp:
3:55 PM Changeset in webkit [93922] by levin@chromium.org
  • 1 edit
    1 add
    2 deletes in trunk/LayoutTests

[chromium] Update tests expectations due to r93913.

  • platform/chromium-cg-mac/fast/dom/xmlhttprequest-constructor-in-detached-document-expected.txt: Removed.
  • platform/chromium-win/fast/dom/xmlhttprequest-constructor-in-detached-document-expected.txt: Removed.
  • platform/chromium/fast/dom/xmlhttprequest-constructor-in-detached-document-expected.txt: Added.
3:40 PM Changeset in webkit [93921] by ojan@chromium.org
  • 7 edits in trunk

change the default preferred width of the flex() function to 0px per the new spec
​https://bugs.webkit.org/show_bug.cgi?id=67067

Reviewed by Tony Chang.

Source/WebCore:

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFlex):

LayoutTests:

  • css3/flexbox/001.html:
  • css3/flexbox/002.html:
  • css3/flexbox/flex-parsing-expected.txt:
  • css3/flexbox/script-tests/flex-parsing.js:
3:32 PM Changeset in webkit [93920] by commit-queue@webkit.org
  • 13 edits in trunk/Source/JavaScriptCore

Unzip initialization lists and constructors in JSCell hierarchy (2/7)
​https://bugs.webkit.org/show_bug.cgi?id=66957

Patch by Mark Hahnenberg <​mhahnenberg@apple.com> on 2011-08-26
Reviewed by Darin Adler.

Completed the second level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

  • runtime/Executable.h:

(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::create):
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):
(JSC::NativeExecutable::NativeExecutable):
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::finishCreation):

  • runtime/GetterSetter.h:

(JSC::GetterSetter::GetterSetter):
(JSC::GetterSetter::create):

  • runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::create):
(JSC::JSAPIValueWrapper::JSAPIValueWrapper):

  • runtime/JSObject.h:

(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSNonFinalObject::finishCreation):
(JSC::JSFinalObject::create):
(JSC::JSFinalObject::finishCreation):
(JSC::JSFinalObject::JSFinalObject):
(JSC::JSObject::JSObject):

  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
(JSC::JSPropertyNameIterator::create):

  • runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::create):

  • runtime/RegExp.cpp:

(JSC::RegExp::RegExp):
(JSC::RegExp::createWithoutCaching):

  • runtime/ScopeChain.h:

(JSC::ScopeChainNode::ScopeChainNode):
(JSC::ScopeChainNode::create):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):

  • runtime/Structure.h:

(JSC::Structure::create):
(JSC::Structure::finishCreation):
(JSC::Structure::createStructure):

  • runtime/StructureChain.cpp:

(JSC::StructureChain::StructureChain):

  • runtime/StructureChain.h:

(JSC::StructureChain::create):

3:26 PM Changeset in webkit [93919] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebCore

Remove offset hack from GraphicsContextCG setShadow code
​https://bugs.webkit.org/show_bug.cgi?id=67052

Reviewed by Simon Fraser.

No new tests - current tests cover it.

  • platform/graphics/cg/GraphicsContextCG.cpp:

Removing the offset hack introduced in ​http://trac.webkit.org/changeset/28714
for an issue with offsets in an old version of CoreGraphics that's long since been fixed.

3:23 PM Changeset in webkit [93918] by fpizlo@apple.com
  • 13 edits
    2 adds in trunk/Source/JavaScriptCore

The GC does not have a facility for profiling the kinds of objects
that occupy the heap
​https://bugs.webkit.org/show_bug.cgi?id=66849

Reviewed by Geoffrey Garen.

Destructor calls and object scans are now optionally counted, per
vtable. When the heap is destroyed and profiling is enabled, the
counts are dumped, with care taken to print the names of classes
(modulo C++ mangling) sorted in descending commonality.

(JSC::Heap::destroy):

  • heap/Heap.h:
  • heap/MarkStack.cpp:

(JSC::SlotVisitor::visitChildren):
(JSC::SlotVisitor::drain):

  • heap/MarkStack.h:
  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::callDestructor):

  • heap/MarkedBlock.h:
  • heap/VTableSpectrum.cpp: Added.

(JSC::VTableSpectrum::VTableSpectrum):
(JSC::VTableSpectrum::~VTableSpectrum):
(JSC::VTableSpectrum::countVPtr):
(JSC::VTableSpectrum::count):
(JSC::VTableAndCount::VTableAndCount):
(JSC::VTableAndCount::operator<):
(JSC::VTableSpectrum::dump):

  • heap/VTableSpectrum.h: Added.
  • wtf/Platform.h:
3:20 PM Changeset in webkit [93917] by Dimitri Glazkov
  • 3 edits in trunk/Tools

Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
​https://bugs.webkit.org/show_bug.cgi?id=67066

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
3:18 PM Changeset in webkit [93916] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

Rebasing media/video-layer-crash & media/video-transformed images.
​https://bugs.webkit.org/show_bug.cgi?id=67065

Patch by Aaron Colwell <​acolwell@chromium.org> on 2011-08-26
Reviewed by David Levin.

  • platform/chromium-linux/media/video-layer-crash-expected.png:
  • platform/chromium-linux/media/video-transformed-expected.png:
  • platform/chromium-win/media/video-layer-crash-expected.png:
  • platform/chromium-win/media/video-transformed-expected.png:
  • platform/chromium/test_expectations.txt:
2:46 PM Changeset in webkit [93915] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Update topCallFrame when calling host functions in the JIT
​https://bugs.webkit.org/show_bug.cgi?id=67010

Patch by Juan C. Montemayor <​jmont@apple.com> on 2011-08-26
Reviewed by Oliver Hunt.

The topCallFrame is not being updated when a host function is
called by the JIT. This causes problems when trying to create a
stack trace (​https://bugs.webkit.org/show_bug.cgi?id=66994).

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):

2:41 PM Changeset in webkit [93914] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
​https://bugs.webkit.org/show_bug.cgi?id=67041

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-08-26
Reviewed by Martin Robinson.

This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
PixelDumpSupportCairo.h, but the latter was #including cairo.h only
when the GTK+ port was being built.

  • DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2:40 PM Changeset in webkit [93913] by ap@apple.com
  • 17 edits
    2 adds in trunk

Get rid of frame life support timer
​https://bugs.webkit.org/show_bug.cgi?id=66874

Reviewed by Geoff Garen. V8 fixes courtesy of Dmitry Titov.

Test: fast/frames/detached-frame-property.html

  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::runScript): (WebCore::V8Proxy::callFunction): (WebCore::V8Proxy::newInstance):
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::pageDestroyed):
  • page/Frame.h:
  • page/Page.cpp: (WebCore::Page::~Page): Removed all code that dealt with the life support timer. Protect Frame inside runScript() and callFunction() for v8 bindings.
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent): Replaced ref/deref calls on self with a RefPtr.
2:36 PM Changeset in webkit [93912] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Implement NPN_ScheduleTimer/NPN_UnscheduleTimer
​https://bugs.webkit.org/show_bug.cgi?id=67062

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_ScheduleTimer):
Call NetscapePlugin::scheduleTimer.

(WebKit::NPN_UnscheduleTimer):
Call NetscapePlugin::unscheduleTimer.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_nextTimerID.

(WebKit::NetscapePlugin::Timer::start):
Start the timer.

(WebKit::NetscapePlugin::Timer::stop):
Stop the timer.

(WebKit::NetscapePlugin::Timer::timerFired):
Call the right callback and unschedule the timer object if it's not a repeating timer.

(WebKit::NetscapePlugin::scheduleTimer):
Create a new timer and start it.

(WebKit::NetscapePlugin::unscheduleTimer):
Get the timer from the map and destroy it.

(WebKit::NetscapePlugin::destroy):
Destroy all timers.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add Timer class.

2:36 PM Changeset in webkit [93911] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

fast/js/const.html is opening a modal print dialog, leading to a timeout on the GTK+ bots
​https://bugs.webkit.org/show_bug.cgi?id=67061

Patch by Martin Robinson <​mrobinson@igalia.com> on 2011-08-26
Reviewed by Oliver Hunt.

Update this test to remove inadvertant calls to window.print().

  • fast/js/resources/const.js:

(tryCatch1): Remove call to window.print()
(tryCatch2): Ditto.

1:47 PM Changeset in webkit [93910] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix MIPS patchOffsetGetByIdSlowCaseCall
​https://bugs.webkit.org/show_bug.cgi?id=67046

Patch by Chao-ying Fu <​fu@mips.com> on 2011-08-26
Reviewed by Gavin Barraclough.

  • jit/JIT.h:
1:43 PM Changeset in webkit [93909] by mitz@apple.com
  • 3 edits
    3 adds in trunk

RenderText::computePreferredLogicalWidths() should measure words with trailing spaces
​https://bugs.webkit.org/show_bug.cgi?id=66733

Source/WebCore:

Patch by Ned Holbrook <​nholbrook@apple.com> on 2011-08-26
Reviewed by Dan Bernstein.

Test: fast/text/complex-preferred-logical-widths.html

  • rendering/RenderText.cpp:

(WebCore::RenderText::computePreferredLogicalWidths): Apply logic from RenderBlock::LineBreaker::nextLineBreak().

LayoutTests:

  • fast/text/complex-preferred-logical-widths.html: Added.
  • platform/mac/fast/text/complex-preferred-logical-widths-expected.txt: Added.
1:42 PM Changeset in webkit [93908] by tony@chromium.org
  • 15 edits in trunk

Add CSS parsing for -webkit-flex-align
​https://bugs.webkit.org/show_bug.cgi?id=66726

Reviewed by Ojan Vafai.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexAlign):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::flexAlign):
(WebCore::InheritedFlags::setFlexAlign):
(WebCore::InheritedFlags::initialFlexAlign):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/script-tests/css-properties.js:
1:41 PM Changeset in webkit [93907] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

2011-08-26 Nate Chapin <Nate Chapin>

Fix http/tests/misc/willCacheResponse-delegate-callback.html
after r93886. We're implicitly converting an enum to a bool.

Rubber-stamped by David Levin.

  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willCacheResponse):
1:38 PM Changeset in webkit [93906] by Dimitri Glazkov
  • 11 edits in trunk/Tools

Clean up and line up layout in garden-o-matic summary view.
​https://bugs.webkit.org/show_bug.cgi?id=67057

1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
2) Rearranged DOM structure a bit to accommodate recent changes;
3) Added minimal CSS to line things up.

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
1:37 PM Changeset in webkit [93905] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix typo in Connection.cpp
​https://bugs.webkit.org/show_bug.cgi?id=67060

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::waitForSyncReply):
We want timedOut, not timeout. There is not a current way to cause this
to be an issue. This issue was caught by the Clang Static Analyzer.

1:05 PM Changeset in webkit [93904] by Martin Robinson
  • 2 edits in trunk/LayoutTests

Skip two tests on GTK+ that are failing due to known issues.

  • platform/gtk/Skipped: Update the skipped list.
12:29 PM Changeset in webkit [93903] by crogers@google.com
  • 14 edits in trunk

Add MediaPlayer::audioSourceProvider() method for audio stream access by the Web Audio API.
​https://bugs.webkit.org/show_bug.cgi?id=66398

Reviewed by Eric Carlson.

Source/WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::loadNextSourceChild):
(WebCore::HTMLMediaElement::ensureMediaPlayer):
(WebCore::HTMLMediaElement::createMediaPlayer):

MediaPlayer creation has now been put into createMediaPlayer() instead of it being created
separately in these various methods. It has been made thread-safe for use with the Web Audio API
in conjunction with an MediaElementAudioSourceNode.

(WebCore::HTMLMediaElement::setAudioSourceNode):
(WebCore::HTMLMediaElement::audioSourceProvider):

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::audioSourceNode):

The HTMLMediaElement now keeps track of an optional MediaElementAudioSourceNode if
the audio stream is being processed using the Web Audio API.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::audioSourceProvider):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::audioSourceProvider):

MediaPlayer now has an audioSourceProvider() method with a default "empty" implementation.
audioSourceProvider() returns an AudioSourceProvider object which the Web Audio API's
MediaElementAudioSourceNode uses (indirectly through an HTMLMediaElement method) to get the rendered audio stream.

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaElementSource):

  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:

AudioContext::createMediaElementSource() is now more careful to check that an HTMLMediaElement
doesn't already have a MediaElementAudioSourceNode attached to it.

  • webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
(WebCore::MediaElementAudioSourceNode::~MediaElementAudioSourceNode):
(WebCore::MediaElementAudioSourceNode::process):
(WebCore::MediaElementAudioSourceNode::lock):
(WebCore::MediaElementAudioSourceNode::unlock):

  • webaudio/MediaElementAudioSourceNode.h:

Implement thread-safe processing (replacing the old stub implementation).

LayoutTests:

  • webaudio/mediaelementaudiosourcenode-expected.txt:
  • webaudio/mediaelementaudiosourcenode.html:
12:23 PM Changeset in webkit [93902] by alice.liu@apple.com
  • 16 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=66823
Add the request info to the WebPageProxy::CreateNewPage message

Reviewed by Anders Carlsson.

Source/WebKit2:

Update function declarations with additional ResourceRequest parameter:

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::createNewPage):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::createNewPage):

  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createWindow):
Pass the ResourceRequest within the FrameLoadRequest.

Tools:

Update function declarations with additional parameter:

  • MiniBrowser/gtk/BrowserWindow.c:

(createNewPage):

  • MiniBrowser/mac/BrowserWindowController.m:

(createNewPage):

  • MiniBrowser/win/BrowserView.cpp:

(createNewPage):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):

  • WebKitTestRunner/TestController.h:
12:11 PM Changeset in webkit [93901] by senorblanco@chromium.org
  • 5 edits
    2 adds in trunk

Assertion fires if canvas is resized while save() active
​https://bugs.webkit.org/show_bug.cgi?id=66710

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/canvas/resize-while-save-active.html

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):
Call CanvasRenderingContext2D::reset() before resizing the canvas,
so that the GraphicsContext state stack can be unwound.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::unwindStateStack):
(WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
Refactor the state stack unwinding code from the destructor to
unwindStateStack() (new).
(WebCore::CanvasRenderingContext2D::reset):
Unwind the GraphicsContext state stack when the context is reset.

  • html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

  • fast/canvas/resize-while-save-active-expected.txt: Added.
  • fast/canvas/resize-while-save-active.html: Added.
11:59 AM Changeset in webkit [93900] by Darin Adler
  • 2 edits in trunk/Source/WebCore

[Mac] Use the progress cursor instead of the wristwatch for CSS "wait" cursor
​https://bugs.webkit.org/show_bug.cgi?id=67049

Reviewed by Beth Dakin.

  • platform/mac/CursorMac.mm:

(WebCore::Cursor::ensurePlatformCursor): Use BusyButClickable cursor for wait
as well as for Progress.

11:41 AM Changeset in webkit [93899] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

2011-08-26 Nate Chapin <Nate Chapin>

Fix gtk build after r93886.

  • platform/track/CueParser.cpp: (WebCore::CueParser::load):
11:31 AM Changeset in webkit [93898] by Martin Robinson
  • 2 edits
    6 adds in trunk/LayoutTests

Add some new baselines for GTK+ and unskip tests that now have them.

  • platform/gtk/Skipped: Unskip tests.
  • platform/gtk/fast/block/float/fit_line_below_floats-expected.png: Added.
  • platform/gtk/fast/block/float/fit_line_below_floats-expected.txt: Added.
  • platform/gtk/fast/block/float/floats-and-text-indent-expected.png: Added.
  • platform/gtk/fast/block/float/floats-and-text-indent-expected.txt: Added.
  • platform/gtk/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
  • platform/gtk/fast/block/float/floats-and-text-indent-rl-expected.txt: Added.
11:24 AM Changeset in webkit [93897] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2]REGRESSION(r93784): It made many tests crash
​https://bugs.webkit.org/show_bug.cgi?id=66958

Reviewed by Anders Carlsson.

Don't try to make sure the WebContext is deleted, for now the leak
is intended and when multiple processes per context will be supported
this leak should be fixed. This was the cause of DRT crashing on the bot,
the context was deleted after the first test, letting other tests with nothing
but a bad context.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::~QtWebPageProxy):

11:23 AM Changeset in webkit [93896] by Martin Robinson
  • 1 edit
    190 adds in trunk/LayoutTests

Import the last set of GTK+ CSS3 selector results.

  • platform/gtk/css3/selectors3/xml: Import the last set of results.
11:15 AM Changeset in webkit [93895] by Martin Robinson
  • 1 edit
    201 adds in trunk/LayoutTests

Continue importing GTK+ CSS3 selector test results.

  • platform/gtk/css3/selectors3/xml: Import the next set of results.
11:08 AM Changeset in webkit [93894] by Martin Robinson
  • 1 edit
    202 adds in trunk/LayoutTests

Begin importing the last directory of CSS3 selector results for GTK+.

  • platform/gtk/css3/selectors3/xml: Import the first set of files in this directory.
11:07 AM Changeset in webkit [93893] by commit-queue@webkit.org
  • 3 edits in trunk

WebViewImpl::selectionRange should return range in the right order.
​https://bugs.webkit.org/show_bug.cgi?id=66973

Patch by Varun Jain <​varunjain@google.com> on 2011-08-26
Reviewed by Darin Fisher.

  • Source/WebKit/chromium/public/WebWidget.h:
  • Source/WebKit/chromium/src/WebViewImpl.cpp:
11:04 AM Changeset in webkit [93892] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Update searchableIndexIntroduction() to match GTK+'s.
​https://bugs.webkit.org/show_bug.cgi?id=66885

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-08-26
Reviewed by Gustavo Noronha Silva.

Using this new string allows us to share the test expectations with
other ports, and thus makes
fast/replaced/table-percent-height-text-controls.html pass.

No new tests, as this is covered by an existing one.

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::searchableIndexIntroduction):

10:59 AM Changeset in webkit [93891] by vrk@chromium.org
  • 1 edit
    105 adds in trunk/LayoutTests

Unreviewed; adding files missing from r93885.

  • media/track/captions-webvtt/tc000-empty.vtt: Added.
  • media/track/captions-webvtt/tc001-iso2022jp3.vtt: Added.
  • media/track/captions-webvtt/tc001-utf8.vtt: Added.
  • media/track/captions-webvtt/tc002-bom.vtt: Added.
  • media/track/captions-webvtt/tc003-newlines.vtt: Added.
  • media/track/captions-webvtt/tc003-no-newline-at-eof.vtt: Added.
  • media/track/captions-webvtt/tc004-no-webvtt.vtt: Added.
  • media/track/captions-webvtt/tc004-webvtt-file.vtt: Added.
  • media/track/captions-webvtt/tc004-webvtt-rubbish.vtt: Added.
  • media/track/captions-webvtt/tc005-default-styles.vtt: Added.
  • media/track/captions-webvtt/tc005-metadata-area.vtt: Added.
  • media/track/captions-webvtt/tc006-cue-id-error.vtt: Added.
  • media/track/captions-webvtt/tc006-cue-id.vtt: Added.
  • media/track/captions-webvtt/tc007-cue-no-id-error.vtt: Added.
  • media/track/captions-webvtt/tc007-cue-no-id.vtt: Added.
  • media/track/captions-webvtt/tc008-timings-no-hour-errors.vtt: Added.
  • media/track/captions-webvtt/tc008-timings-no-hour.vtt: Added.
  • media/track/captions-webvtt/tc009-timings-hour-error.vtt: Added.
  • media/track/captions-webvtt/tc009-timings-hour.vtt: Added.
  • media/track/captions-webvtt/tc010-no-timings.vtt: Added.
  • media/track/captions-webvtt/tc011-cues-no-separation.vtt: Added.
  • media/track/captions-webvtt/tc011-cues.vtt: Added.
  • media/track/captions-webvtt/tc012-out-of-order.vtt: Added.
  • media/track/captions-webvtt/tc013-settings-bad-separation.vtt: Added.
  • media/track/captions-webvtt/tc013-settings.vtt: Added.
  • media/track/captions-webvtt/tc014-alignment-bad.vtt: Added.
  • media/track/captions-webvtt/tc014-alignment-ltr.vtt: Added.
  • media/track/captions-webvtt/tc014-alignment.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning-bad.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning-ltr.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning.vtt: Added.
  • media/track/captions-webvtt/tc016-align-positioning-bad.vtt: Added.
  • media/track/captions-webvtt/tc016-align-positioning.vtt: Added.
  • media/track/captions-webvtt/tc017-line-position-bad.vtt: Added.
  • media/track/captions-webvtt/tc017-line-position.vtt: Added.
  • media/track/captions-webvtt/tc018-align-text-line-position-bad.vtt: Added.
  • media/track/captions-webvtt/tc018-align-text-line-position.vtt: Added.
  • media/track/captions-webvtt/tc019-cue-size-bad.vtt: Added.
  • media/track/captions-webvtt/tc019-cue-size.vtt: Added.
  • media/track/captions-webvtt/tc020-cue-size-align-bad.vtt: Added.
  • media/track/captions-webvtt/tc020-cue-size-align.vtt: Added.
  • media/track/captions-webvtt/tc021-valign-bad.vtt: Added.
  • media/track/captions-webvtt/tc021-valign-ltr.vtt: Added.
  • media/track/captions-webvtt/tc021-valign.vtt: Added.
  • media/track/captions-webvtt/tc022-entities-wrong.vtt: Added.
  • media/track/captions-webvtt/tc022-entities.vtt: Added.
  • media/track/captions-webvtt/tc023-markup-bad.vtt: Added.
  • media/track/captions-webvtt/tc023-markup.vtt: Added.
  • media/track/captions-webvtt/tc024-timestamp-bad.vtt: Added.
  • media/track/captions-webvtt/tc024-timestamp.vtt: Added.
  • media/track/captions-webvtt/tc025-class-bad.vtt: Added.
  • media/track/captions-webvtt/tc025-class.vtt: Added.
  • media/track/captions-webvtt/tc026-voice-bad.vtt: Added.
  • media/track/captions-webvtt/tc026-voice.vtt: Added.
  • media/track/captions-webvtt/tc027-empty-cue.vtt: Added.
  • media/track/captions-webvtt/tc028-unsupported-markup.vtt: Added.
  • media/track/track-webvtt-tc004-magic-header-expected.txt: Added.
  • media/track/track-webvtt-tc004-magic-header.html: Added.
  • media/track/track-webvtt-tc005-header-comment-expected.txt: Added.
  • media/track/track-webvtt-tc005-header-comment.html: Added.
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Added.
  • media/track/track-webvtt-tc006-cue-identifiers.html: Added.
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt: Added.
  • media/track/track-webvtt-tc007-cue-no-id.html: Added.
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Added.
  • media/track/track-webvtt-tc008-timings-no-hours.html: Added.
  • media/track/track-webvtt-tc009-timings-hour-expected.txt: Added.
  • media/track/track-webvtt-tc009-timings-hour.html: Added.
  • media/track/track-webvtt-tc010-no-timings-expected.txt: Added.
  • media/track/track-webvtt-tc010-no-timings.html: Added.
  • media/track/track-webvtt-tc011-blank-lines-expected.txt: Added.
  • media/track/track-webvtt-tc011-blank-lines.html: Added.
  • media/track/track-webvtt-tc012-out-of-order-expected.txt: Added.
  • media/track/track-webvtt-tc012-out-of-order.html: Added.
  • media/track/track-webvtt-tc014-alignment-expected.txt: Added.
  • media/track/track-webvtt-tc014-alignment.html: Added.
  • media/track/track-webvtt-tc015-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc015-positioning.html: Added.
  • media/track/track-webvtt-tc016-align-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc016-align-positioning.html: Added.
  • media/track/track-webvtt-tc017-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc017-line-position.html: Added.
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc018-align-text-line-position.html: Added.
  • media/track/track-webvtt-tc019-cue-size-expected.txt: Added.
  • media/track/track-webvtt-tc019-cue-size.html: Added.
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt: Added.
  • media/track/track-webvtt-tc020-cue-size-align.html: Added.
  • media/track/track-webvtt-tc021-valign-expected.txt: Added.
  • media/track/track-webvtt-tc021-valign.html: Added.
  • media/track/track-webvtt-tc022-entities-expected.txt: Added.
  • media/track/track-webvtt-tc022-entities.html: Added.
  • media/track/track-webvtt-tc023-markup-expected.txt: Added.
  • media/track/track-webvtt-tc023-markup.html: Added.
  • media/track/track-webvtt-tc024-timestamp-expected.txt: Added.
  • media/track/track-webvtt-tc024-timestamp.html: Added.
  • media/track/track-webvtt-tc025-class-markup-expected.txt: Added.
  • media/track/track-webvtt-tc025-class-markup.html: Added.
  • media/track/track-webvtt-tc026-voice-expected.txt: Added.
  • media/track/track-webvtt-tc026-voice.html: Added.
  • media/track/track-webvtt-tc027-empty-cue-expected.txt: Added.
  • media/track/track-webvtt-tc027-empty-cue.html: Added.
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Added.
  • media/track/track-webvtt-tc028-unsupported-markup.html: Added.
10:59 AM Changeset in webkit [93890] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Do not log an error if a fallback cursor cannot be found.
​https://bugs.webkit.org/show_bug.cgi?id=67037

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-08-26
Reviewed by Gustavo Noronha Silva.

Ecore_X does not necessarily have to be used (DumpRenderTree does not
use it, for example), so showing an error message here is bogus.

No new tests, as it just removes erroneous error messages from
when running DRT with existing tests.

  • platform/efl/WidgetEfl.cpp:

(WebCore::Widget::applyFallbackCursor):

10:53 AM Changeset in webkit [93889] by Martin Robinson
  • 1 edit
    593 adds in trunk/LayoutTests

Continue importing GTK+ CSS3 selector results.

  • platform/gtk/css3/selectors3/xhtml: Import this directory.
10:48 AM Changeset in webkit [93888] by Martin Robinson
  • 1 edit
    346 adds in trunk/LayoutTests

Begin importing CSS3 selector test results for GTK+.

  • platform/gtk/css3/selectors3/html: Import this directory.
10:45 AM Changeset in webkit [93887] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Fix handling of keyup events in the new Cocoa text input model
​https://bugs.webkit.org/show_bug.cgi?id=67045

Reviewed by Sam Weinig.

Use a counter instead of a boolean for deciding when to ignore keyup events, because
if multiple keys are pressed simultaneously then we need to ignore more than one keyup event in a row.

Also if a keyboard event is an autorepeating event we won't get a keyup event so don't increment the counter
in that case.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformHandleKeyboardEvent):

10:41 AM Changeset in webkit [93886] by Nate Chapin
  • 32 edits in trunk/Source

Source/WebCore: Change a bunch of nondescript bools to
descriptive enums in ResourceLoaderOptions and
ThreadableLoaderOptions.
​https://bugs.webkit.org/show_bug.cgi?id=66984

Reviewed by David Levin.

No new tests, no functionality change intended.

  • WebCore.exp.in:
  • fileapi/FileReaderLoader.cpp:
  • html/MediaDocument.cpp:
  • html/PluginDocument.cpp:
  • loader/CrossOriginAccessControl.cpp:
  • loader/CrossOriginAccessControl.h:
  • loader/CrossOriginPreflightResultCache.cpp:
  • loader/CrossOriginPreflightResultCache.h:
  • loader/DocumentThreadableLoader.cpp:
  • loader/FrameLoader.h:
  • loader/ImageLoader.cpp:
  • loader/MainResourceLoader.cpp:
  • loader/NetscapePlugInStreamLoader.cpp:
  • loader/ResourceLoadScheduler.h:
  • loader/ResourceLoader.cpp:
  • loader/ResourceLoader.h:
  • loader/ResourceLoaderOptions.h:
  • loader/ThreadableLoader.h:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResourceRequest.cpp:
  • loader/cf/ResourceLoaderCFNet.cpp:
  • loader/mac/ResourceLoaderMac.mm:
  • page/EventSource.cpp:
  • platform/network/ResourceHandle.h:
  • workers/WorkerScriptLoader.cpp:
  • xml/XMLHttpRequest.cpp:

Source/WebKit/chromium: Use enums instead of bools for ThreadableLoaderOptions
variables.
​https://bugs.webkit.org/show_bug.cgi?id=66984

Reviewed by David Levin.

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::loadAsynchronously):

10:21 AM Changeset in webkit [93885] by vrk@chromium.org
  • 11 edits
    43 deletes in trunk/LayoutTests

Tests for validating a new WebVTT parser and tokenizer for TextTrackCue content.
​https://bugs.webkit.org/show_bug.cgi?id=65884

Patch by Anna Cavender <​annacc@chromium.org> on 2011-08-25
Reviewed by Eric Carlson.

  • media/track/captions-webvtt/tc000-empty.vtt: Renamed from media/track/captions/tc000_empty.vtt.
  • media/track/captions-webvtt/tc001-iso2022jp3.vtt: Renamed from media/track/captions/tc001_iso2022jp3.vtt.
  • media/track/captions-webvtt/tc001-utf8.vtt: Renamed from media/track/captions/tc001_utf8.vtt.
  • media/track/captions-webvtt/tc002-bom.vtt: Renamed from media/track/captions/tc002_bom.vtt.
  • media/track/captions-webvtt/tc003-newlines.vtt: Renamed from media/track/captions/tc003_newlines.vtt
  • media/track/captions-webvtt/tc003-no-newline-at-eof.vtt: Renamed from media/track/captions/tc003_nonewlineateof.vtt
  • media/track/captions-webvtt/tc004-no-webvtt.vtt: Renamed from media/track/captions/tc004_nowebvtt.vtt.
  • media/track/captions-webvtt/tc004-webvtt-file.vtt: Renamed from media/track/captions/tc004_webvttfile.vtt.
  • media/track/captions-webvtt/tc004-webvtt-rubbish.vtt: Renamed from media/track/captions/tc004_webvttrubbish.vtt.
  • media/track/captions-webvtt/tc005-default-styles.vtt: Renamed from media/track/captions/tc005_defaultstyles.vtt.
  • media/track/captions-webvtt/tc005-metadata-area.vtt: Renamed from media/track/captions/tc005_metadataarea.vtt.
  • media/track/captions-webvtt/tc006-cue-id-error.vtt: Renamed from media/track/captions/tc006_cueiderror.vtt.
  • media/track/captions-webvtt/tc006-cue-id.vtt: Renamed from media/track/captions/tc006_cueid.vtt.
  • media/track/captions-webvtt/tc007-cue-no-id-error.vtt: Renamed from media/track/captions/tc007_cuenoid.vtt.
  • media/track/captions-webvtt/tc007-cue-no-id.vtt: Renamed from media/track/captions/tc007_cuenoiderror.vtt.
  • media/track/captions-webvtt/tc008-timings-no-hour-errors.vtt: Renamed from media/track/captions/tc008_timingsnohourerrors.vtt.
  • media/track/captions-webvtt/tc008-timings-no-hour.vtt: Renamed from media/track/captions/tc008_timingsnohour.vtt.
  • media/track/captions-webvtt/tc009-timings-hour-error.vtt: Renamed from media/track/captions/tc009_timingshourerror.vtt.
  • media/track/captions-webvtt/tc009-timings-hour.vtt: Renamed from media/track/captions/tc009_timingshour.vtt.
  • media/track/captions-webvtt/tc010-no-timings.vtt: Renamed from media/track/captions/tc010_notimings.vtt.
  • media/track/captions-webvtt/tc011-cues-no-separation.vtt: Copied from media/track/captions/tc011_cuesnosep.vtt.
  • media/track/captions-webvtt/tc011-cues.vtt: Renamed from media/track/captions/tc011_cues.vtt.
  • media/track/captions-webvtt/tc012-out-of-order.vtt: Renamed from media/track/captions/tc012_outoforder.vtt.
  • media/track/captions-webvtt/tc013-settings-bad-separation.vtt: Renamed from media/track/captions/tc013_settingsbadsep.vtt.
  • media/track/captions-webvtt/tc013-settings.vtt: Renamed from media/track/captions/tc013_settings.vtt.
  • media/track/captions-webvtt/tc014-alignment-bad.vtt: Added.
  • media/track/captions-webvtt/tc014-alignment-ltr.vtt: Added.
  • media/track/captions-webvtt/tc014-alignment.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning-bad.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning-ltr.vtt: Added.
  • media/track/captions-webvtt/tc015-positioning.vtt: Added.
  • media/track/captions-webvtt/tc016-align-positioning-bad.vtt: Added.
  • media/track/captions-webvtt/tc016-align-positioning.vtt: Added.
  • media/track/captions-webvtt/tc017-line-position-bad.vtt: Added.
  • media/track/captions-webvtt/tc017-line-position.vtt: Added.
  • media/track/captions-webvtt/tc018-align-text-line-position-bad.vtt: Added.
  • media/track/captions-webvtt/tc018-align-text-line-position.vtt: Added.
  • media/track/captions-webvtt/tc019-cue-size-bad.vtt: Added.
  • media/track/captions-webvtt/tc019-cue-size.vtt: Added.
  • media/track/captions-webvtt/tc020-cue-size-align-bad.vtt: Added.
  • media/track/captions-webvtt/tc020-cue-size-align.vtt: Added.
  • media/track/captions-webvtt/tc021-valign-bad.vtt: Added.
  • media/track/captions-webvtt/tc021-valign-ltr.vtt: Added.
  • media/track/captions-webvtt/tc021-valign.vtt: Added.
  • media/track/captions-webvtt/tc022-entities-wrong.vtt: Added.
  • media/track/captions-webvtt/tc022-entities.vtt: Added.
  • media/track/captions-webvtt/tc023-markup-bad.vtt: Added.
  • media/track/captions-webvtt/tc023-markup.vtt: Added.
  • media/track/captions-webvtt/tc024-timestamp-bad.vtt: Added.
  • media/track/captions-webvtt/tc024-timestamp.vtt: Added.
  • media/track/captions-webvtt/tc025-class-bad.vtt: Added.
  • media/track/captions-webvtt/tc025-class.vtt: Added.
  • media/track/captions-webvtt/tc026-voice-bad.vtt: Added.
  • media/track/captions-webvtt/tc026-voice.vtt: Added.
  • media/track/captions-webvtt/tc027-empty-cue.vtt: Added.
  • media/track/captions-webvtt/tc028-unsupported-markup.vtt: Added.
  • media/track/track-webvtt-tc000-empty.html:
  • media/track/track-webvtt-tc001-utf8-expected.txt:
  • media/track/track-webvtt-tc001-utf8.html:
  • media/track/track-webvtt-tc002-bom-expected.txt:
  • media/track/track-webvtt-tc002-bom.html:
  • media/track/track-webvtt-tc003-newlines-expected.txt:
  • media/track/track-webvtt-tc003-newlines.html:
  • media/track/track-webvtt-tc004-magic-header-expected.txt: Renamed from media/track/track-webvtt-tc004-magicheader-expected.txt.
  • media/track/track-webvtt-tc004-magic-header.html: Renamed from media/track/track-webvtt-tc004-magicheader.html.
  • media/track/track-webvtt-tc005-header-comment-expected.txt: Renamed from media/track/track-webvtt-tc005-headercomment-expected.txt.
  • media/track/track-webvtt-tc005-header-comment.html: Renamed from media/track/track-webvtt-tc005-headercomment.html.
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Renamed from media/track/track-webvtt-tc006-cueidentifiers-expected.txt.
  • media/track/track-webvtt-tc006-cue-identifiers.html: Renamed from media/track/track-webvtt-tc006-cueidentifiers.html.
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt: Renamed from media/track/track-webvtt-tc007-cuenoid-expected.txt.
  • media/track/track-webvtt-tc007-cue-no-id.html: Renamed media/track/track-webvtt-tc007-cuenoid.html.
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Renamed from media/track/track-webvtt-tc008-timingsnohours-expected.txt.
  • media/track/track-webvtt-tc008-timings-no-hours.html: Renamed from media/track/track-webvtt-tc008-timingsnohours.html.
  • media/track/track-webvtt-tc009-timings-hour-expected.txt: Renamed from media/track/track-webvtt-tc009-timingshour-expected.txt.
  • media/track/track-webvtt-tc009-timings-hour.html: Renamed from media/track/track-webvtt-tc009-timingshour.html.
  • media/track/track-webvtt-tc010-no-timings-expected.txt: Copied from media/track/track-webvtt-tc010-notimings-expected.txt.
  • media/track/track-webvtt-tc010-no-timings.html: Renamed from media/track/track-webvtt-tc012-outoforder.html.
  • media/track/track-webvtt-tc011-blank-lines-expected.txt: Renamed from media/track/track-webvtt-tc011-blanklines-expected.txt.
  • media/track/track-webvtt-tc011-blank-lines.html: Renamed from media/track/track-webvtt-tc011-blanklines.html.
  • media/track/track-webvtt-tc012-out-of-order-expected.txt: Renamed from media/track/track-webvtt-tc012-outoforder-expected.txt.
  • media/track/track-webvtt-tc012-out-of-order.html: Copied from media/track/track-webvtt-tc000-empty.html.
  • media/track/track-webvtt-tc013-settings-expected.txt:
  • media/track/track-webvtt-tc013-settings.html:
  • media/track/track-webvtt-tc014-alignment-expected.txt: Added.
  • media/track/track-webvtt-tc014-alignment.html: Added.
  • media/track/track-webvtt-tc015-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc015-positioning.html: Added.
  • media/track/track-webvtt-tc016-align-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc016-align-positioning.html: Added.
  • media/track/track-webvtt-tc017-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc017-line-position.html: Added.
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc018-align-text-line-position.html: Added.
  • media/track/track-webvtt-tc019-cue-size-expected.txt: Added.
  • media/track/track-webvtt-tc019-cue-size.html: Added.
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt: Added.
  • media/track/track-webvtt-tc020-cue-size-align.html: Added.
  • media/track/track-webvtt-tc021-valign-expected.txt: Added.
  • media/track/track-webvtt-tc021-valign.html: Added.
  • media/track/track-webvtt-tc022-entities-expected.txt: Added.
  • media/track/track-webvtt-tc022-entities.html: Added.
  • media/track/track-webvtt-tc023-markup-expected.txt: Added.
  • media/track/track-webvtt-tc023-markup.html: Added.
  • media/track/track-webvtt-tc024-timestamp-expected.txt: Added.
  • media/track/track-webvtt-tc024-timestamp.html: Added.
  • media/track/track-webvtt-tc025-class-markup-expected.txt: Added.
  • media/track/track-webvtt-tc025-class-markup.html: Added.
  • media/track/track-webvtt-tc026-voice-expected.txt: Added.
  • media/track/track-webvtt-tc026-voice.html: Added.
  • media/track/track-webvtt-tc027-empty-cue-expected.txt: Added.
  • media/track/track-webvtt-tc027-empty-cue.html: Added.
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Added.
  • media/track/track-webvtt-tc028-unsupported-markup.html: Added.
  • media/video-test.js:

(testCues):
(allTestsEnded):

10:19 AM Changeset in webkit [93884] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

HTMLMetaElement: Don't cache "http-equiv" and "content" attributes.
​https://bugs.webkit.org/show_bug.cgi?id=67040

Reviewed by Darin Adler.

  • html/HTMLMetaElement.h: Remove m_equiv and m_content members,

shrinking HTMLMetaElement by 16 bytes (on 64-bit.)

  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::parseMappedAttribute):
(WebCore::HTMLMetaElement::process): Implemented using fastGetAttribute().

10:17 AM Changeset in webkit [93883] by cevans@google.com
  • 3 edits in branches/chromium/835/Source/WebCore/rendering

Merge 93794
BUG=93587
Review URL: ​http://codereview.chromium.org/7753041

9:57 AM Changeset in webkit [93882] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] No way to expand hovered objects while debugging.
​https://bugs.webkit.org/show_bug.cgi?id=67039

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Popover.js:

(WebInspector.Popover):
(WebInspector.Popover.prototype.show):
(WebInspector.PopoverHelper.prototype._mouseDown):
(WebInspector.PopoverHelper.prototype._hidePopover):
(WebInspector.PopoverHelper.prototype._mouseHover):
(WebInspector.PopoverHelper.prototype._killHidePopoverTimer):

9:26 AM Changeset in webkit [93881] by podivilov@chromium.org
  • 9 edits in trunk

Unreviewed, rolling out r93870.
​http://trac.webkit.org/changeset/93870
​https://bugs.webkit.org/show_bug.cgi?id=65203

Broke i18n chromium tests

Source/WebCore:

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):

  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::windowsCanHandleDrawTextShadow):
(WebCore::windowsCanHandleTextDrawing):
(WebCore::windowsCanHandleTextDrawingWithoutShadow):

  • platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
9:15 AM Changeset in webkit [93880] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit2

Gut WKPageCreateSnapshotOfVisibleContent so that it can be removed later.
​https://bugs.webkit.org/show_bug.cgi?id=66979.

Removing the function altogether would break the nightlies.
This patch removes the code behind it so that it is clear that
WKPageCreateSnapshotOfVisibleContent should not be used, and so that the code isn't just
left rotting in the tree.

Patch by Jessie Berlin <​jberlin@apple.com> on 2011-08-26
Reviewed by Brian Weinstein.

  • UIProcess/API/C/WKPage.cpp:

(WKPageCreateSnapshotOfVisibleContent):
Return 0.

  • UIProcess/API/C/WKPagePrivate.h:

Update the comment and add a link to the bug.

  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
8:29 AM Changeset in webkit [93879] by commit-queue@webkit.org
  • 3 edits in trunk/Source

Chromium Mac: Use a custom pattern image for rubber banding overhang area
​https://bugs.webkit.org/show_bug.cgi?id=66707

Also roll Chromium revision to 98101, to include dependency: ​http://codereview.chromium.org/7714036/

Patch by Alexei Svitkine <​asvitkine@chromium.org> on 2011-08-26
Reviewed by Dimitri Glazkov.

No new tests since its just changing the Chromium-specific overhang pattern.

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

8:14 AM Changeset in webkit [93878] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

<video> playlist can not advance when playing in background tab
​https://bugs.webkit.org/show_bug.cgi?id=66978

Reviewed by Darin Adler.

No new tests added because it isn't possible to simulate a background tab in DRT.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Set RequirePageConsentToLoadMedia restriction.
(WebCore::HTMLMediaElement::loadInternal): Don't consider page->canStartMedia if it has ever

allowed a file to load.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::requirePageConsentToLoadMedia): New.
(WebCore::HTMLMediaElement::removeBehaviorRestriction): New.

8:06 AM Changeset in webkit [93877] by Martin Robinson
  • 3 edits in trunk/LayoutTests

Removing some tests from the GTK+ skipped lists that have results now
or no longer exist.

  • platform/gtk/Skipped: Clean up.
  • platform/gtk/test_expectations.txt: Ditto.
7:57 AM Changeset in webkit [93876] by andreas.kling@nokia.com
  • 14 edits in trunk/LayoutTests

Rebaseline Qt (4.7) after r93873.

  • platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/qt/svg/batik/text/textOnPath-expected.txt:
  • platform/qt/svg/batik/text/textOnPath2-expected.txt:
  • platform/qt/svg/batik/text/textOnPath3-expected.txt:
  • platform/qt/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/qt/svg/text/text-path-01-b-expected.txt:
7:06 AM Changeset in webkit [93875] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-26 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, fix error in chromium test_expectations.

  • platform/chromium/test_expectations.txt:
7:02 AM Changeset in webkit [93874] by Philippe Normand
  • 1 edit
    18 adds in trunk/LayoutTests

Unreviewed, GTK baselines for new tests.

  • platform/gtk/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
  • platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
  • platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added.
  • platform/gtk/fast/table/table-before-child-in-table-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-after-child-in-block-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-after-child-in-table-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-before-child-in-block-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-before-child-in-table-expected.txt: Added.
  • platform/gtk/fast/table/table-row-after-child-in-block-expected.txt: Added.
  • platform/gtk/fast/table/table-row-after-child-in-table-expected.txt: Added.
  • platform/gtk/fast/table/table-row-before-child-in-block-expected.txt: Added.
  • platform/gtk/fast/table/table-row-before-child-in-table-expected.txt: Added.
  • platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
  • platform/gtk/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Added.
  • platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
6:35 AM Changeset in webkit [93873] by andreas.kling@nokia.com
  • 30 edits in trunk

[Qt] Path::boundingRect() is unnecessarily slow.
​https://bugs.webkit.org/show_bug.cgi?id=66854

Reviewed by Benjamin Poulain.

Source/WebCore:

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::stroke): Remove Qt-specific optimization
since calling Path::boundingRect() will now do exactly the same thing.

  • platform/graphics/qt/PathQt.cpp:

(WebCore::Path::boundingRect): Return QPainterPath::controlPointRect() since
that is much faster than computing the (precise) QPainterPath::boundingRect()
and Path::boundingRect() is not expected to be 100% precise anyway.

LayoutTests:

Rebaseline SVG tests after Path::boundingRect() change.
This brings Qt quite a bit closer to CG and Skia metrics.

  • platform/qt-4.8/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • platform/qt-4.8/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/qt-4.8/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/qt-4.8/svg/batik/text/textOnPath-expected.txt:
  • platform/qt-4.8/svg/batik/text/textOnPath2-expected.txt:
  • platform/qt-4.8/svg/batik/text/textOnPath3-expected.txt:
  • platform/qt-4.8/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/qt-4.8/svg/text/text-path-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
  • platform/qt/svg/custom/animate-path-morphing-expected.txt:
  • platform/qt/svg/custom/broken-internal-references-expected.txt:
  • platform/qt/svg/custom/control-points-for-S-and-T-expected.txt:
  • platform/qt/svg/custom/path-textPath-simulation-expected.txt:
  • platform/qt/svg/custom/second-inline-text-expected.txt:
  • platform/qt/svg/custom/use-nested-transform-expected.txt:
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.txt:
  • platform/qt/svg/hixie/perf/001-expected.txt:
  • platform/qt/svg/hixie/perf/002-expected.txt:
  • platform/qt/svg/hixie/shapes/path/001-expected.txt:
6:22 AM Changeset in webkit [93872] by Philippe Normand
  • 77 edits in trunk/LayoutTests

Unreviewed, another rebaseline after switch to GTK+3.x.

  • platform/gtk/editing/selection/caret-rtl-2-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-2-left-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-right-expected.txt:
  • platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt:
  • platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
  • platform/gtk/fast/borders/bidi-012-expected.txt:
  • platform/gtk/fast/borders/rtl-border-04-expected.txt:
  • platform/gtk/fast/css/rtl-ordering-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-strict-expected.txt:
  • platform/gtk/fast/forms/listbox-bidi-align-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-long-image-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-repeat-x-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-repeat-y-expected.txt:
  • platform/gtk/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
  • platform/gtk/fast/text/cg-fallback-bolding-expected.txt:
  • platform/gtk/fast/text/drawBidiText-expected.txt:
  • platform/gtk/fast/text/in-rendered-text-rtl-expected.txt:
  • platform/gtk/fast/text/international/bidi-L2-run-reordering-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/gtk/fast/text/international/bidi-european-terminators-expected.txt:
  • platform/gtk/fast/text/international/bidi-explicit-embedding-expected.txt:
  • platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • platform/gtk/fast/text/international/bidi-innertext-expected.txt:
  • platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-001-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-002-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-003-expected.txt:
  • platform/gtk/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/gtk/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/gtk/fast/text/international/bidi-override-expected.txt:
  • platform/gtk/fast/text/international/hebrew-vowels-expected.txt:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/gtk/fast/text/international/rtl-caret-expected.txt:
  • platform/gtk/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt:
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/gtk/fast/text/trailing-white-space-2-expected.txt:
  • platform/gtk/fast/text/trailing-white-space-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • platform/gtk/svg/text/bidi-embedded-direction-expected.txt:
  • platform/gtk/svg/text/bidi-reorder-value-lists-expected.txt:
  • platform/gtk/svg/text/bidi-text-anchor-direction-expected.txt:
  • platform/gtk/svg/text/text-tselect-02-f-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
6:15 AM Changeset in webkit [93871] by gavinp@chromium.org
  • 3 edits in trunk/Source/WebCore

add a state enumeration to track down cause of null CachedScript execution
​https://bugs.webkit.org/show_bug.cgi?id=66939

Reviewed by Alexey Proskuryakov.

Over in ​http://code.google.com/p/chromium/issues/detail?id=75604 I
have a bug I cannot reproduce. I added an earlier crash in
​https://bugs.webkit.org/show_bug.cgi?id=65563 , and we've since
gotten many good stacks, all coming in through a failed request that
eventually calls notifyFinished() on a ScriptElement with a NULL
m_cachedScript.

I'd like to know how this got NULL. This enumeration should let
me find that in stack dumps from reproductions.

No new tests, as my goal here is to get telemetry on a bug that I cannot reproduce.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::requestScript):
(WebCore::ScriptElement::stopLoadRequest):
(WebCore::ScriptElement::notifyFinished):

  • dom/ScriptElement.h:
6:12 AM Changeset in webkit [93870] by reed@google.com
  • 9 edits in trunk

[skia] never draw with GDI, so that all text can be gpu-accelerated
​https://bugs.webkit.org/show_bug.cgi?id=65203

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/PlatformContextSkia.cpp:
  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp:
  • platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
5:50 AM Changeset in webkit [93869] by podivilov@chromium.org
  • 63 edits
    17 moves
    8 deletes in trunk/LayoutTests

2011-08-26 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, rebaseline chromium fast/borders/* tests.

  • fast/borders/borderRadiusArcs01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusArcs01-expected.txt.
  • fast/borders/borderRadiusDashed02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDashed02-expected.txt.
  • fast/borders/borderRadiusDashed03-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDashed03-expected.txt.
  • fast/borders/borderRadiusDotted01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDotted01-expected.txt.
  • fast/borders/borderRadiusDouble01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDouble01-expected.txt.
  • fast/borders/borderRadiusDouble02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDouble02-expected.txt.
  • fast/borders/borderRadiusDouble03-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDouble03-expected.txt.
  • fast/borders/borderRadiusGroove01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusGroove01-expected.txt.
  • fast/borders/borderRadiusGroove02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusGroove02-expected.txt.
  • fast/borders/borderRadiusInset01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusInset01-expected.txt.
  • fast/borders/borderRadiusOutset01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusOutset01-expected.txt.
  • fast/borders/borderRadiusRidge01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusRidge01-expected.txt.
  • fast/borders/borderRadiusSolid01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusSolid01-expected.txt.
  • fast/borders/borderRadiusSolid02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusSolid02-expected.txt.
  • fast/borders/borderRadiusSolid03-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusSolid03-expected.txt.
  • fast/borders/borderRadiusSolid04-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusSolid04-expected.txt.
  • fast/borders/fieldsetBorderRadius-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/fieldsetBorderRadius-expected.txt.
  • platform/chromium-linux-x86/fast/borders/borderRadiusGroove01-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusGroove02-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/borderRadiusRidge01-expected.png: Removed.
  • platform/chromium-linux/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-inline-flow-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid04-expected.png:
  • platform/chromium-linux/fast/borders/different-color-borders-expected.png:
  • platform/chromium-linux/fast/borders/fieldsetBorderRadius-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-01-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-02-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-03-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-04-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-05-expected.png:
  • platform/chromium-win/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-win/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-win/fast/borders/border-radius-inline-flow-expected.png:
  • platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid04-expected.png:
  • platform/chromium-win/fast/borders/different-color-borders-expected.png:
  • platform/chromium-win/fast/borders/fieldsetBorderRadius-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-01-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-02-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-03-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-04-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-05-expected.png:
  • platform/chromium-win/fast/borders/table-borders-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/borders/fieldsetBorderRadius-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusDashed02-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusDashed03-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusDotted01-expected.txt: Removed.
  • platform/qt/fast/borders/fieldsetBorderRadius-expected.txt: Removed.
5:32 AM Changeset in webkit [93868] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: in some cases Popover code is failing to calculate popover box position.
​https://bugs.webkit.org/show_bug.cgi?id=67029

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype._positionElement):

5:28 AM Changeset in webkit [93867] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Minor style fix in the sample code for WebKitWebFrame.

  • webkit/webkitwebframe.cpp:
4:31 AM Changeset in webkit [93866] by Philippe Normand
  • 24 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline of some svg tests after switch to
GTK+-3.x.

  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • platform/gtk/svg/text/bidi-embedded-direction-expected.txt:
  • platform/gtk/svg/text/bidi-reorder-value-lists-expected.txt:
  • platform/gtk/svg/text/bidi-text-anchor-direction-expected.txt:
  • platform/gtk/svg/text/text-tselect-02-f-expected.txt:
4:24 AM Changeset in webkit [93865] by Philippe Normand
  • 56 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline of some fast/ tests after switch to
GTK+-3.x.

  • platform/gtk/fast/borders/bidi-012-expected.txt:
  • platform/gtk/fast/borders/rtl-border-04-expected.txt:
  • platform/gtk/fast/css/pseudo-cache-stale-expected.txt:
  • platform/gtk/fast/css/rtl-ordering-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/gtk/fast/css/text-overflow-ellipsis-strict-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-text-indent-expected.txt:
  • platform/gtk/fast/forms/isindex-placeholder-expected.txt:
  • platform/gtk/fast/forms/listbox-bidi-align-expected.txt:
  • platform/gtk/fast/forms/password-placeholder-expected.txt:
  • platform/gtk/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/gtk/fast/forms/placeholder-position-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt:
  • platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-long-image-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-repeat-x-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-repeat-y-expected.txt:
  • platform/gtk/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
  • platform/gtk/fast/text/cg-fallback-bolding-expected.txt:
  • platform/gtk/fast/text/drawBidiText-expected.txt:
  • platform/gtk/fast/text/in-rendered-text-rtl-expected.txt:
  • platform/gtk/fast/text/international/bidi-L2-run-reordering-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/gtk/fast/text/international/bidi-european-terminators-expected.txt:
  • platform/gtk/fast/text/international/bidi-explicit-embedding-expected.txt:
  • platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • platform/gtk/fast/text/international/bidi-innertext-expected.txt:
  • platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-001-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-002-expected.txt:
  • platform/gtk/fast/text/international/bidi-linebreak-003-expected.txt:
  • platform/gtk/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/gtk/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/gtk/fast/text/international/bidi-override-expected.txt:
  • platform/gtk/fast/text/international/hebrew-vowels-expected.txt:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/gtk/fast/text/international/rtl-caret-expected.txt:
  • platform/gtk/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt:
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/gtk/fast/text/trailing-white-space-2-expected.txt:
  • platform/gtk/fast/text/trailing-white-space-expected.txt:
4:19 AM Changeset in webkit [93864] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2011-08-26 Nikolas Zimmermann <​nzimmermann@rim.com>

[Qt] http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm fails intermittently
​https://bugs.webkit.org/show_bug.cgi?id=65969

Not reviewed. Unskip this test on Qt, it's fixed now.

  • platform/qt/Skipped:
4:10 AM Changeset in webkit [93863] by Philippe Normand
  • 11 edits
    1 add in trunk/LayoutTests

Unreviewed, GTK rebaseline of some editing tests after switch to
GTK+-3.x.

  • platform/gtk/editing/pasteboard/4641033-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-2-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-2-left-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-expected.txt:
  • platform/gtk/editing/selection/caret-rtl-right-expected.txt:
  • platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt: Added.
  • platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
3:02 AM Changeset in webkit [93862] by Nikolas Zimmermann
  • 3 edits in trunk/Source/WebCore

2011-08-26 Nikolas Zimmermann <​nzimmermann@rim.com>

[Qt] http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm fails intermittently
​https://bugs.webkit.org/show_bug.cgi?id=65969

Reviewed by Zoltan Herczeg.

Fix intrinsic size negotiation flakiness, most visible on the Qt port.

The http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm testcase triggered
an assertion on a Qt debug build indicating that the HashSet updateLayoutAndStyleIfNeededRecursive()
operates on is mutated while its iterated, leading to an assertion/crash. Due the new forceLayoutParentViewIfNeeded()
logic it's no longer safe to directly use the children() HashSet in that method - we have to make a copy first.

The second part of the fix is to stop entering forceLayoutParentViewIfNeeded(), if the origin of that call
is forceLayoutParentViewIfNeeded() itself. Set m_inLayoutParentView to true before calling FrameView::layout()
on our parent frame view - this is only an optimization to avoid doing layout() twice.

The third part of the fix is to call updateWidgetPositions() on the parent FrameView, _before_ calling layout()
on the parent view itself, as the SVG document needs to report the correct intrinsic size (which can depend
on the host object/embed/iframe) when we're running RenderReplaced::layout() on the host renderer.

  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::collectFrameViewChildren): (WebCore::FrameView::forceLayoutParentViewIfNeeded): (WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
  • page/FrameView.h:
2:56 AM Changeset in webkit [93861] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] Double clicking on numbers in Count & size columns doesn't toggle between values and percents in the Heap Snapshot.
​https://bugs.webkit.org/show_bug.cgi?id=66988

Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._mouseClickInContentsGrid):
(WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid):

2:06 AM Changeset in webkit [93860] by koz@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r93853.
​http://trac.webkit.org/changeset/93853
​https://bugs.webkit.org/show_bug.cgi?id=67016

Turns bots red

  • platform/chromium/test_expectations.txt:
2:05 AM Changeset in webkit [93859] by Csaba Osztrogonác
  • 2 edits
    20 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add Qt specific expected results for new tests introduced in r93794.

  • platform/qt/Skipped:
  • platform/qt/fast/table/table-after-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-after-child-in-table-expected.txt: Added.
  • platform/qt/fast/table/table-before-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-before-child-in-table-expected.txt: Added.
  • platform/qt/fast/table/table-cell-after-child-in-block-expected.png: Added.
  • platform/qt/fast/table/table-cell-after-child-in-block-expected.txt: Added.
  • platform/qt/fast/table/table-cell-after-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-cell-after-child-in-table-expected.txt: Added.
  • platform/qt/fast/table/table-cell-before-child-in-block-expected.png: Added.
  • platform/qt/fast/table/table-cell-before-child-in-block-expected.txt: Added.
  • platform/qt/fast/table/table-cell-before-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-cell-before-child-in-table-expected.txt: Added.
  • platform/qt/fast/table/table-row-after-child-in-block-expected.png: Added.
  • platform/qt/fast/table/table-row-after-child-in-block-expected.txt: Added.
  • platform/qt/fast/table/table-row-after-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-row-after-child-in-table-expected.txt: Added.
  • platform/qt/fast/table/table-row-before-child-in-block-expected.png: Added.
  • platform/qt/fast/table/table-row-before-child-in-block-expected.txt: Added.
  • platform/qt/fast/table/table-row-before-child-in-table-expected.png: Added.
  • platform/qt/fast/table/table-row-before-child-in-table-expected.txt: Added.
1:59 AM Changeset in webkit [93858] by commit-queue@webkit.org
  • 7 edits in trunk

REGRESSION(r93390): Empty or invalid maxlength of an input tag should be ignored.
​https://bugs.webkit.org/show_bug.cgi?id=67015

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-08-26
Reviewed by Kent Tamura.

Source/WebCore:

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMaxLengthAttribute):

Checks the validity of maxlength attribute when converting it to integer.

LayoutTests:

  • fast/forms/input-text-paste-maxlength-expected.txt:

Added maxlength="" and maxlength="invalid" tests.

  • fast/forms/input-text-paste-maxlength.html: ditto.
  • fast/forms/script-tests/textarea-maxlength.js: ditto.
  • fast/forms/textarea-maxlength-expected.txt: ditto.
1:52 AM Changeset in webkit [93857] by noel.gordon@gmail.com
  • 2 edits in trunk/Tools

Make show-pretty-diff work on linux
​https://bugs.webkit.org/show_bug.cgi?id=67017

Reviewed by Adam Barth.

  • Scripts/show-pretty-diff:
Note: See TracTimeline for information about the timeline view.