⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 28, 2011:

11:49 PM WebKitGtkLayoutTests edited by nayankk@motorola.com
(diff)
11:09 PM Changeset in webkit [93954] by loislo@chromium.org
  • 1 edit in branches/chromium/835/Source/WebCore/inspector/front-end/Popover.js

Merge 93868 - Web Inspector: in some cases Popover code is failing to calculate popover box position.
​https://bugs.webkit.org/show_bug.cgi?id=67029

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype._positionElement):

TBR=​loislo@chromium.org
Review URL: ​http://codereview.chromium.org/7778006

8:49 PM Changeset in webkit [93953] by keishi@webkit.org
  • 5 edits
    5 adds in trunk

Chromium Win: Setting square-button appearance reaches NOTREACHED
​https://bugs.webkit.org/show_bug.cgi?id=66918

Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/css/square-button-appearance.html

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore::supportsFocus): Add case for SquareButtonPart.
(WebCore::RenderThemeChromiumWin::supportsFocusRing): Add case for SquareButtonPart.
(WebCore::RenderThemeChromiumWin::getThemeData): Add case for SquareButtonPart.

LayoutTests:

  • fast/css/square-button-appearance-expected.txt: Added.
  • fast/css/square-button-appearance.html: Added. Test rendering of square-button appearance.
  • platform/chromium-linux/fast/css/square-button-appearance-expected.png: Added.
  • platform/chromium-win/fast/css/square-button-appearance-expected.png: Added.
  • platform/gtk/test_expectations.txt: Added this test as expected to fail.
  • platform/mac/fast/css/square-button-appearance-expected.png: Added.
  • platform/qt/test_expectations.txt: Added this test as expected to fail.
5:26 PM Changeset in webkit [93952] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix reference counting of values in CSSSelector.
​https://bugs.webkit.org/show_bug.cgi?id=66452

Reviewed by Darin Adler.

No new tests / no functionality changed.

Call deref when reassigning the value.

  • css/CSSSelector.h:

(WebCore::CSSSelector::setValue):

4:58 PM Changeset in webkit [93951] by weinig@apple.com
  • 12 edits
    5 adds in trunk

Add support for constructor syntax for Events
​https://bugs.webkit.org/show_bug.cgi?id=63878

Reviewed by Oliver Hunt.

Source/WebCore:

Add basic support for Event constructors, starting with just supporting
the constructor for the base Event class and just JSC support. This lays
the infrastructure for the other events as well.

Test: fast/events/event-constructors.html

  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:

Add files.

  • bindings/generic/EventConstructors.h: Added.

Add binding agnostic header that defines the Event initializers
using a macro based DSL.

  • bindings/js/JSEventConstructors.cpp: Added.

(WebCore::convertValue):
(WebCore::tryGetProperty):
(WebCore::constructJSEventWithInitializer):
Add JSC implementation of Event initializer DSL.

  • dom/Event.cpp:

(WebCore::EventInit::EventInit):
(WebCore::Event::Event):

  • dom/Event.h:

(WebCore::Event::create):
Add Event initializer interface for base Event.

  • dom/Event.idl:

Mark Event as having a custom constructor function.

LayoutTests:

Add basic test for Event constructors.

  • fast/events/constructors/event-constructors-expected.txt: Added.
  • fast/events/constructors/event-constructors.html: Added.
12:24 PM Changeset in webkit [93950] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix build error when compiling with MinGW-w64 by disabling JIT
on Windows 64-bit
​https://bugs.webkit.org/show_bug.cgi?id=61235

Patch by Jonathan Liu <​net147@gmail.com> on 2011-08-28
Reviewed by Gavin Barraclough.

The fixed mmap executable allocator for JIT on x86_64 requires
sys/mman.h which is not available on Windows.

  • wtf/Platform.h:
12:14 PM Changeset in webkit [93949] by kbalazs@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Unreviewed build fix.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init): Initialize the WKPageUIClient with memset
to avoid missing initializer warning. The missing initializer is the
result of using a version 0 WKPageUIClient while it has newer version (1).
We have nothing to do with the callbacks in the new version so I voted
for memset.

  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: Include ResourceError.h.

Aug 27, 2011:

3:01 PM Changeset in webkit [93948] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

Don't rely on hardcoded position in absolute-appended-to-inline.html

Allow test added in r93944 to pass on platforms other than Chromium-Linux.

Unreviewed, fix on r93944.

  • fast/block/positioning/absolute-appended-to-inline.html:
2:49 PM Changeset in webkit [93947] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

JSC::Executable is inconsistent about using weak handle finalizers
and destructors for releasing memory
​https://bugs.webkit.org/show_bug.cgi?id=67072

Reviewed by Darin Adler.

Moved more of the destruction of Executable state into the finalizer,
which also resulted in an opportunity to mostly combine this with
discardCode(). This also means that the finalizer is now enabled even
when the JIT is turned off. This is performance neutral on SunSpider,
V8, and Kraken.

  • runtime/Executable.cpp:

(JSC::ExecutableBase::clearCode):
(JSC::ExecutableFinalizer::finalize):
(JSC::EvalExecutable::clearCode):
(JSC::ProgramExecutable::clearCode):
(JSC::FunctionExecutable::discardCode):
(JSC::FunctionExecutable::clearCode):

  • runtime/Executable.h:

(JSC::ExecutableBase::finishCreation):

2:31 PM Changeset in webkit [93946] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add a build bot for Chromium with OS(ANDROID)
​https://bugs.webkit.org/show_bug.cgi?id=66687

Patch by Peter Beverloo <​peter@chromium.org> on 2011-08-27
Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
2:12 PM Changeset in webkit [93945] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

SQLiteStatement::getColumnText() could construct WTF::String result more efficiently.
​https://bugs.webkit.org/show_bug.cgi?id=67090

Patch by Andreas Kling <​kling@webkit.org> on 2011-08-27
Reviewed by Darin Adler.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::getColumnText): Use sqlite3_column_bytes16()
to get the length of the column text without looking for the null terminator.

2:03 PM Changeset in webkit [93944] by robert@webkit.org
  • 3 edits
    2 adds in trunk

The child div element with position:absolute will overlap with its parent div when a 'break' element is present in between
​https://bugs.webkit.org/show_bug.cgi?id=21934

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/block/positioning/absolute-appended-to-inline.html

Appending a positioned child node to an inline flow should dirty the lines in the flow, just as
inserting a positioned child node does. Treating an appended and inserted node differently meant that updating the display type
from 'none' to 'block' for the following markup would result in the div getting positioned correctly under
the line block:

<div><a onMouseOver="mopen()">Hover</a><div style="display:none; position:absolute; background:#4682b4; height:10px; width:20px"><br></div></div>

but this would not happen with the following markup (the <br> is before the child div rather than after it):

<div><a onMouseOver="mopen()">Hover</a><br><div style="display:none; position:absolute; background:#4682b4; height:10px; width:20px"></div></div>

This problem is specific to cases where an object is appended to a line block whose last child is a <br>. When the line is relaid out after appending
the positioned object the last line in the line block is always considered dirty unless it broke cleanly (ie. with a <br>, see RenderBlock::determineStartPosition),
So in the second case above, the clean break and failing to dirty any lines in the block when appending the object means that the line block doesn't get relaid out
to position the new positioned object relative to its containing line block.

So the change could special-case appending a node when the previous sibling isBR(), but it seems just as well to behave the same way as insertChildNode().

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::appendChildNode):

Call dirtyLinesFromChangedChild() if the child is positioned, just like insertChildNode().

LayoutTests:

  • fast/block/positioning/absolute-appended-to-inline-expected.txt: Added.
  • fast/block/positioning/absolute-appended-to-inline.html: Added.
1:22 PM Changeset in webkit [93943] by andersca@apple.com
  • 3 edits
    3 adds in trunk

iChat: Receiving a message containing only a single-quote (') causes bubble to fail
​https://bugs.webkit.org/show_bug.cgi?id=67076
<rdar://problem/10026089>

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/borders/border-fit-2.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::borderFitAdjust):
Make sure that the resulting rect isn't smaller than the border + padding.

(WebCore::RenderBlock::clearTruncation):
Fix blatant coding style violations.

LayoutTests:

  • fast/borders/border-fit-2.html: Added.
  • platform/mac/fast/borders/border-fit-2-expected.png: Added.
  • platform/mac/fast/borders/border-fit-2-expected.txt: Added.
12:05 PM Changeset in webkit [93942] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Update the master build bot configuration script to properly
deal with the --chromium-android switch.
​https://bugs.webkit.org/show_bug.cgi?id=66687

The --chromium-android switch is needed when running
update-webkit-chromium and build-webkit, as it'll tell the
scripts to pull in the right dependencies and cross-compile
WebKit using the Android NDK.

Patch by Peter Beverloo <​peter@chromium.org> on 2011-08-27
Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
12:02 PM Changeset in webkit [93941] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Shrink RenderLayer.
​https://bugs.webkit.org/show_bug.cgi?id=67089

Patch by Andreas Kling <​kling@webkit.org> on 2011-08-27
Reviewed by Antonio Gomes.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):

  • rendering/RenderLayer.h: Make m_inResizeMode a bitfield,

shrinking RenderLayer by 8 bytes (on 64-bit.)

11:58 AM Changeset in webkit [93940] by enne@google.com
  • 3 edits in branches/chromium/835/Source/WebCore/platform/graphics/chromium

[chromium] Possible leak of LayerRendererChromium
​https://bugs.webkit.org/show_bug.cgi?id=66981

Patch by James Robinson < ​jamesr@chromium.org> on 2011-08-26
From ​http://codereview.chromium.org/7749028/

Fix a number of reference cycle leaks that prevent
LayerRendererChromiums from being destroyed when a tab is closed.

Not possible to write a layout test where an entire WebView goes away.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::clearRenderSurfacesOnCCLayerImplRecursive):
(WebCore::LayerRendererChromium::clearRootCCLayerImpl):
(WebCore::LayerRendererChromium::setRootLayer):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:
11:57 AM Changeset in webkit [93939] by commit-queue@webkit.org
  • 7 edits in trunk

Teach the update and build scripts how to handle dependencies
and cross-compiling rules for the Chromium port on OS(ANDROID).
​https://bugs.webkit.org/show_bug.cgi?id=66687

Patch by Peter Beverloo <​peter@chromium.org> on 2011-08-27
Reviewed by Adam Barth.

Source/WebKit/chromium:

  • gyp_webkit:

Tools:

  • Scripts/build-webkit:
  • Scripts/update-webkit:
  • Scripts/update-webkit-chromium:
  • Scripts/webkitdirs.pm:

(argumentsForConfiguration):
(isChromium):
(isChromiumAndroid):
(determineIsChromiumAndroid):
(buildChromium):

11:09 AM Changeset in webkit [93938] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Patch by Young Han Lee <​joybro@company100.net> on 2011-08-27
Reviewed by Dirk Schulze.

SVG animation fill="freeze" doesn't set baseVal to current animVal if animation stops before reaching the end
​https://bugs.webkit.org/show_bug.cgi?id=63553

calculateAnimationPercentAndRepeat() is returning 1, which means 100%, whenever
elapsed >= m_intervalEnd, but this is wrong because m_intervalEnd can be in the middle
of the animation duration. (e.g. begin="0s" end="2s" dur="3s")

This change makes the function return the animations's true progress instead of 100%
when the animation ends.

Source/WebCore:

Test: svg/animations/animate-end-attribute.html

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):

LayoutTests:

  • svg/animations/animate-end-attribute-expected.txt: Added.
  • svg/animations/animate-end-attribute.html: Added.
  • svg/animations/script-tests/animate-end-attribute.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

4:06 AM Changeset in webkit [93937] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

[Qt] Need spin-button implementation
​https://bugs.webkit.org/show_bug.cgi?id=65896

Patch by Jarred Nicholls <​jarred@sencha.com> on 2011-08-27
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeQt::paintInnerSpinButton):

  • platform/qt/RenderThemeQt.h:

LayoutTests:

  • platform/qt/Skipped:
  • platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.
  • platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
  • platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Added.
12:54 AM Changeset in webkit [93936] by Csaba Osztrogonác
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Remove a non-existent test.
  • platform/qt/fast/text/complex-preferred-logical-widths-expected.png: Added.
  • platform/qt/fast/text/complex-preferred-logical-widths-expected.txt: Added.
Note: See TracTimeline for information about the timeline view.