Context Navigation

← Previous Period
Next Period →

Timeline

Sep 1, 2011:

11:33 PM Changeset in webkit [94387] by commit-queue@webkit.org

12 edits
6 adds in trunk

[WebSocket] Implement WebSocket::close() code and reason handling.
https://bugs.webkit.org/show_bug.cgi?id=66925

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-09-01
Reviewed by Kent Tamura.

Source/WebCore:

Tests: http/tests/websocket/tests/hybi/close.html

http/tests/websocket/tests/hybi/workers/close.html

bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::close):

bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::closeCallback):
Add custom bridge for WebSocket::close().

websockets/ThreadableWebSocketChannel.h:
websockets/WebSocket.cpp:

(WebCore::WebSocket::close):

websockets/WebSocket.h:
websockets/WebSocket.idl:
websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::close):
Add code and reason arguments handling.
(WebCore::WebSocketChannel::startClosingHandshake):
Send a close frame without code and reason on server initiated closing handshakes.
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::processFrameHixie76):

websockets/WebSocketChannel.h:
websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::close):
(WebCore::WorkerThreadableWebSocketChannel::Peer::close):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadClose):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::close):

websockets/WorkerThreadableWebSocketChannel.h:

Add code and reason arguments handling.

LayoutTests:

http/tests/websocket/tests/hybi/close-expected.txt: Added.
http/tests/websocket/tests/hybi/close.html: Added.
http/tests/websocket/tests/hybi/close_wsh.py: Added.
http/tests/websocket/tests/hybi/workers/close-expected.txt: Added.
http/tests/websocket/tests/hybi/workers/close.html: Added.
http/tests/websocket/tests/hybi/workers/resources/close.js: Added.

(postResult):
(testFailed):
(debug):
(shouldBe):
(shouldBeTrue):
(shouldBeFalse):
(handleOpen):
(handleError):
(handleClose):
(handleMessage):
(setDefaultHandlers):
(runCodeTest.else.ws.onclose):
(runCodeTest):
(runInvalidStringTest):
(runReasonTest.else.ws.onclose):
(runReasonTest):
(runCodeAndReasonTest.):
(runCodeAndReasonTest):

9:57 PM Changeset in webkit [94386] by mrowe@apple.com

7 edits in trunk

Fix the build by adding some more missing return types.

Source/WebCore:

page/mac/WebCoreViewFactory.m:

(-[WebCoreViewFactory init]):

Source/WebKit/mac:

WebView/WebDashboardRegion.h:
WebView/WebDashboardRegion.mm:

(-[WebDashboardRegion initWithRect:clip:type:]):

Tools:

DumpRenderTree/mac/ResourceLoadDelegate.mm:

(-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):

9:03 PM Changeset in webkit [94385] by dominicc@chromium.org

3 edits in trunk/LayoutTests

Unreviewed test fix.

r94362 erroneously changed the description wording generated by
the js-test-pre.

fast/js/resources/js-test-pre.js:

(description): add the word 'see'

platform/chromium/fast/dom/prototype-inheritance-expected.txt:

8:59 PM Changeset in webkit [94384] by jamesr@google.com

1 edit
2 adds in trunk/LayoutTests

[chromium] Add chromium-mac-leopard pixel baselines for new/modified tests with text

platform/chromium-cg-mac-leopard/fast/text/fallback-traits-fixup-expected.png: Added.
platform/chromium-cg-mac-leopard/svg/custom/pattern-rotate-gaps-expected.png: Added.

7:27 PM Changeset in webkit [94383] by Michael Nordman

2 edits in trunk/Source/WebCore

[Chromium] Fix a crashing bug due to raciness around SQL database shutdown.
https://bugs.webkit.org/show_bug.cgi?id=67457

The removeOpenDatabase() method can get called multiple times.
Subsequent calls to it should be harmeless instead of cause a crash.

Reviewed by David Levin.

storage/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::removeOpenDatabase):

7:12 PM Changeset in webkit [94382] by tkent@chromium.org

5 edits in trunk

The filename text color of a file upload control should be inherited.
https://bugs.webkit.org/show_bug.cgi?id=67368

Reviewed by Darin Adler.

Source/WebCore:

css/html.css:

(input[type="file"]):
Add 'color: inherit'.
The declaration for 'input' contains 'color: initial;'. So a file
upload control has had black foreground color unless it has been
specified 'color' property explicitly.
Because a file upload control uses inherited background color, the
foreground color also should be inherited.

LayoutTests:

fast/forms/file/file-style-inheritance-expected.txt:
fast/forms/file/file-style-inheritance.html: Add a testcase.

6:37 PM Changeset in webkit [94381] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Generate a Worker constructor of V8 using the IDL 'Constructor' extended attribute
https://bugs.webkit.org/show_bug.cgi?id=67447

Patch by Kentaro Hara <haraken@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

Test: fast/workers/worker-constructor.html

fast/workers/worker-event-listener.html

bindings/v8/custom/V8WorkerCustom.cpp: Removed constructorCallback().
workers/Worker.idl: Added the 'Constructor' extended attribute.

6:35 PM Changeset in webkit [94380] by gyuyoung.kim@samsung.com

6 edits in trunk/Source/WebKit/efl

[EFL] Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=67012

Reviewed by Kenneth Russell.

Set default minimum DOMTimer interval to 4ms instead of 10ms. Because, 4ms is known
to better minimum value for performance. Mac, android, chromium and window ports already
use 4ms instead of 10ms.

It is desirable to be able to change the minimum DOMTimer interval on per-page basis
in order to avoid consuming excessive CPU and battery life on mobile devices. In addition,
other ports have already used this setting by means of Bug 54312.

ewk/ewk_main.cpp:

(_ewk_init_body):

ewk/ewk_settings.cpp:

(ewk_settings_default_timer_interval_get):

ewk/ewk_settings.h:
ewk/ewk_view.cpp:

(_ewk_view_priv_new):
(ewk_view_setting_minimum_timer_interval_set):
(ewk_view_setting_minimum_timer_interval_get):

ewk/ewk_view.h:

6:33 PM Changeset in webkit [94379] by jamesr@google.com

2 edits
1 copy
1 move
2 adds in trunk/LayoutTests

[chromium] Add chromium leopard baselines

platform/chromium-cg-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.png:
platform/chromium-cg-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.txt: Copied from LayoutTests/platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt.
platform/win-wk2/fast/text/international/bidi-mirror-he-ar-expected.txt: Renamed from LayoutTests/platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt.

6:25 PM Changeset in webkit [94378] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit/efl

[EFL] Remove unused code related with priv->render.process_entire_queue in ewk_tiled_backing_store.
https://bugs.webkit.org/show_bug.cgi?id=63377

priv->render.process_entire_queue affects no logical flow of ewk_tiled_backing_store,
But, ewk_view_tiled_process_entire_queue_set is now provided as setter api for it.
So removal of this api and some codes related with it is required.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-09-01
Reviewed by Antonio Gomes.

ewk/ewk_tiled_backing_store.c:

(_ewk_tiled_backing_store_smart_add):
(ewk_tiled_backing_store_enable_render):

ewk/ewk_tiled_backing_store.h:
ewk/ewk_view.h:
ewk/ewk_view_tiled.c:

(ewk_view_tiled_unused_cache_set):

6:00 PM Changeset in webkit [94377] by jamesr@google.com

2 edits in trunk/LayoutTests

[chromium] Remove expectation lines for tests that pass

platform/chromium/test_expectations.txt:

5:51 PM Changeset in webkit [94376] by mrowe@apple.com

4 edits in trunk/Source/JavaScriptCore

Fix the build.

JavaScriptCore.JSVALUE32_64only.exp:
JavaScriptCore.JSVALUE64only.exp:
JavaScriptCore.exp:

5:49 PM Changeset in webkit [94375] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Generate a FileReader constructor of V8 using the IDL 'Constructor' extended attribute
https://bugs.webkit.org/show_bug.cgi?id=67412

Patch by Kentaro Hara <haraken@google.com> on 2011-09-01
Reviewed by Adam Barth.

Test: fast/files/blob-slice-test.html

fast/files/file-reader-abort.html

bindings/v8/custom/V8FileReaderCustom.cpp: Removed constructorCallback().
fileapi/FileReader.idl: Added the 'Constructor' extended attribute.

5:42 PM Changeset in webkit [94374] by mitz@apple.com

1 edit
1 add in trunk/LayoutTests

Added Snow Leopard expected results to the test added in r94352.

platform/mac-snowleopard/fast/text/fallback-traits-fixup-expected.txt: Added.

5:32 PM Changeset in webkit [94373] by commit-queue@webkit.org

6 edits in trunk/Source

Source/WebCore: [chromium] Code cleanup FIXME in Chromium recognizer
https://bugs.webkit.org/show_bug.cgi?id=67448

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-09-01
Reviewed by Adam Barth.

page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):
Fixed a bug noticed by a benjaminp while reviewing a different
ndonned patch where global positions were not being set correctly
on gesture-driven mouse wheel events.

platform/chromium/GestureRecognizerChromium.cpp:

Changed static per-edge functions into methods and improves
encapsulation. No new functionality is present.
(WebCore::GestureRecognizerChromium::GestureRecognizerChromium):
(WebCore::GestureRecognizerChromium::reset):
(WebCore::GestureRecognizerChromium::~GestureRecognizerChromium):
(WebCore::GestureRecognizerChromium::addEdgeFunction):
(WebCore::GestureRecognizerChromium::isInClickTimeWindow):
(WebCore::GestureRecognizerChromium::isInsideManhattanSquare):
(WebCore::GestureRecognizerChromium::appendClickGestureEvent):
(WebCore::GestureRecognizerChromium::processTouchEventForGestures):
(WebCore::GestureRecognizerChromium::appendScrollGestureBegin):
(WebCore::GestureRecognizerChromium::appendScrollGestureEnd):
(WebCore::GestureRecognizerChromium::appendScrollGestureUpdate):
(WebCore::GestureRecognizerChromium::updateValues):
(WebCore::GestureRecognizerChromium::signature):
(WebCore::GestureRecognizerChromium::touchDown):
(WebCore::GestureRecognizerChromium::scrollEnd):
(WebCore::GestureRecognizerChromium::noGesture):
(WebCore::GestureRecognizerChromium::click):
(WebCore::GestureRecognizerChromium::isClickOrScroll):
(WebCore::GestureRecognizerChromium::inScroll):

platform/chromium/GestureRecognizerChromium.h:

(WebCore::GestureRecognizerChromium::setState):

Source/WebKit/chromium: [chromium] Code cleanup FIXME in Chromium recognizer
https://bugs.webkit.org/show_bug.cgi?id=67448

Updated GestureRecognizer unit tests for more encapsulated
gesture recognizer implementation.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-09-01
Reviewed by Adam Barth.

tests/InnerGestureRecognizerTest.cpp:

(InspectableGestureRecognizerChromium::InspectableGestureRecognizerChromium):
(InspectableGestureRecognizerChromium::signature):
(InspectableGestureRecognizerChromium::edgeFunction):
(InspectableGestureRecognizerChromium::updateValues):
(InspectableGestureRecognizerChromium::addEdgeFunction):
(InspectableGestureRecognizerChromium::setStateTest):
(InspectableGestureRecognizerChromium::isInsideManhattanSquare):
(InspectableGestureRecognizerChromium::isInClickTimeWindow):
(InspectableGestureRecognizerChromium::stubEdgeFunction):
(GestureRecognizerTest::GestureRecognizerTest):
(TEST_F):

5:29 PM Changeset in webkit [94372] by jchaffraix@webkit.org

19 edits
2 adds in trunk/Source/WebCore

Move LayoutRepainter to its own class
https://bugs.webkit.org/show_bug.cgi?id=66255

Reviewed by Hajime Morita.

No new tests, code movement only.

rendering/RenderObject.h: Moved code from here ...
rendering/LayoutRepainter.cpp: Added.

(WebCore::LayoutRepainter::LayoutRepainter):
(WebCore::LayoutRepainter::repaintAfterLayout):

rendering/LayoutRepainter.h: Added.

(WebCore::LayoutRepainter::checkForRepaint):
... to those 2 files.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:

Updated our build systems.

rendering/RenderingAllInOne.cpp:

Needed for the Windows bot.

rendering/RenderBlock.cpp:
rendering/RenderDeprecatedFlexibleBox.cpp:
rendering/RenderReplaced.cpp:
rendering/RenderTable.cpp:
rendering/svg/RenderSVGContainer.cpp:
rendering/svg/RenderSVGForeignObject.cpp:
rendering/svg/RenderSVGImage.cpp:
rendering/svg/RenderSVGPath.cpp:
rendering/svg/RenderSVGRoot.cpp:
rendering/svg/RenderSVGText.cpp:

Added #include "LayoutRepainter".

5:20 PM Changeset in webkit [94371] by adachan@apple.com

4 edits in trunk/Source

Source/WebCore: Cleanup refactoring for https://bugs.webkit.org/show_bug.cgi?id=67160

Don't ifdef out the data member xslStyleSheets in MemoryCache::Statistics to cut down
the ifdefs in getWebCoreMemoryCacheStatistics() in WebKit2/WebProcess/WebProcess.cpp.

Reviewed by Darin Adler.

No new tests required. Just small code refactoring.

loader/cache/MemoryCache.h:

Source/WebKit2: Cut down the ifdefs in WebKit::getWebCoreMemoryCacheStatistics() now that
MemoryCache::Statistics always has the xslStyleSheets field.

Reviewed by Darin Adler.

WebProcess/WebProcess.cpp:

(WebKit::getWebCoreMemoryCacheStatistics):

5:20 PM Changeset in webkit [94370] by jamesr@google.com

6 edits
3 adds
1 delete in trunk/LayoutTests

[chromium] Update leopard pixel baselines for svg tests

platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
platform/chromium-cg-mac-leopard/svg/custom/non-scaling-stroke-expected.png:
platform/chromium-cg-mac-leopard/svg/custom/pattern-rotate-expected.png:
platform/chromium-cg-mac-leopard/svg/custom/pattern-skew-transformed-expected.png: Removed.
platform/chromium-cg-mac-leopard/svg/custom/pattern-with-transformation-expected.png:
platform/chromium-cg-mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
platform/chromium-cg-mac-leopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
platform/chromium-cg-mac/svg/custom/pattern-rotate-expected.png: Added.
platform/chromium-cg-mac/svg/custom/pattern-rotate-gaps-expected.png: Added.

5:18 PM Changeset in webkit [94369] by jchaffraix@webkit.org

10 edits
20 adds in trunk

REGRESSION (r84327-r84329): CSS stylesheets fail to load on www.flagstar.com login page
https://bugs.webkit.org/show_bug.cgi?id=65140

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/css/stylesheet-enable-first-alternate-link.html

fast/css/stylesheet-enable-first-alternate-on-load-link.html
fast/css/stylesheet-enable-first-alternate-on-load-sheet.html
fast/css/stylesheet-enable-second-alternate-link.html
fast/css/stylesheet-enable-second-alternate-on-load-link.html
fast/css/stylesheet-enable-second-alternate-on-load-sheet.html
http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html
http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html

This patch basically reverts 88479 and 84329 while keeping the tests
we developped during the implementation.

Following discussion, it looks like HTML5 will need to be amended.
In the meantime, we will just revert the changes so that we can come
up with a better change.

dom/Document.cpp:

(WebCore::Document::recalcStyleSelector):

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::setDisabledState):
(WebCore::HTMLLinkElement::parseMappedAttribute):
(WebCore::HTMLLinkElement::process):
Revert those method to their original content.

html/HTMLLinkElement.h:

(WebCore::HTMLLinkElement::isDisabled):
(WebCore::HTMLLinkElement::isEnabledViaScript):
(WebCore::HTMLLinkElement::isAlternate):
Re-introduced the DisabledState enum.

html/HTMLLinkElement.idl: |disabled| is Reflect'ed again.

LayoutTests:

fast/css/stylesheet-enable-first-alternate-link-expected.txt: Added.
fast/css/stylesheet-enable-first-alternate-link.html: Added.
fast/css/stylesheet-enable-first-alternate-on-load-link-expected.txt: Added.
fast/css/stylesheet-enable-first-alternate-on-load-link.html: Added.
fast/css/stylesheet-enable-first-alternate-on-load-sheet-expected.txt: Added.
fast/css/stylesheet-enable-first-alternate-on-load-sheet.html: Added.
fast/css/stylesheet-enable-second-alternate-link-expected.txt: Added.
fast/css/stylesheet-enable-second-alternate-link.html: Added.
fast/css/stylesheet-enable-second-alternate-on-load-link-expected.txt: Added.
fast/css/stylesheet-enable-second-alternate-on-load-link.html: Added.
fast/css/stylesheet-enable-second-alternate-on-load-sheet-expected.txt: Added.
fast/css/stylesheet-enable-second-alternate-on-load-sheet.html: Added.
http/tests/css/link-css-disabled-value-with-slow-loading-sheet-expected.txt: Added.
http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Added.
http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html: Added.
http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html: Added.
http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet-in-error.js: Added.

(onSheetLoaded):
(testWhenLoaded):

http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet.js: Added.

(onSheetLoaded):
(testWhenLoaded):

http/tests/css/resources/slow-loading-sheet-in-error.php: Added.
http/tests/css/resources/slow-loading-sheet.php: Added.

New tests developped for 65140. The baselines matches what FF and Opera are doing (IE does not support
link.sheet at the moment). Those failures are covered by bug 67436.

fast/css/link-disabled-attr-expected.txt:
fast/dom/HTMLLinkElement/disabled-attribute-expected.txt:

Fixed the baseline to match our behavior. The FAIL are our current deviation from the spec. Those
failures are covered by bug 67436.

fast/dom/boolean-attribute-reflection-expected.txt:
fast/dom/script-tests/boolean-attribute-reflection.js:

Re-added link.disabled as a reflected attribute.

5:16 PM Changeset in webkit [94368] by mitz@apple.com

2 edits in trunk/Source/WebCore

Fix layout test regressions from r94352.

Reviewed by Anders Carlsson.

platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::getFontDataForCharacters): In the custom font case (that is, when there is
not base NSFont) always get and use the best variation.

5:11 PM Changeset in webkit [94367] by rniwa@webkit.org

6 edits in trunk

Revert r94355 because it caused bunch of builds to break.

Source/WebCore:

page/DOMWindow.idl:

LayoutTests:

platform/mac/fast/dom/Window/window-properties-expected.txt:
platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
platform/mac/fast/js/global-constructors-expected.txt:

4:57 PM Changeset in webkit [94366] by jamesr@google.com

2 edits
4 adds in trunk/LayoutTests

[chromium] Update chromium baselines+expectations for fast/text/fallback-traits-fixup.html

platform/chromium-cg-mac/fast/text/fallback-traits-fixup-expected.png: Added.
platform/chromium-cg-mac/fast/text/fallback-traits-fixup-expected.txt: Added.
platform/chromium-linux/fast/text/fallback-traits-fixup-expected.png: Added.
platform/chromium-linux/fast/text/fallback-traits-fixup-expected.txt: Added.
platform/chromium/test_expectations.txt:

4:53 PM Changeset in webkit [94365] by mrowe@apple.com

2 edits in trunk/Source/WebCore

<rdar://problem/10063411> WebScriptObject.h declares an Objective-C method without a return type.

Rubber-stamped by Anders Carlsson.

bridge/objc/WebScriptObject.h:

4:49 PM Changeset in webkit [94364] by commit-queue@webkit.org

79 edits in trunk/Source

Unzip initialization lists and constructors in JSCell hierarchy (4/7)
https://bugs.webkit.org/show_bug.cgi?id=67174

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-01
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Completed the fourth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

API/JSCallbackConstructor.cpp:

(JSC::JSCallbackConstructor::JSCallbackConstructor):
(JSC::JSCallbackConstructor::finishCreation):

API/JSCallbackConstructor.h:
API/JSCallbackObject.h:

(JSC::JSCallbackObject::create):

API/JSCallbackObjectFunctions.h:

(JSC::::JSCallbackObject):
(JSC::::finishCreation):

JavaScriptCore.JSVALUE64only.exp:
JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::DebuggerActivation):
(JSC::DebuggerActivation::create):

debugger/DebuggerActivation.h:
runtime/Arguments.h:

(JSC::Arguments::create):
(JSC::Arguments::createNoParameters):
(JSC::Arguments::Arguments):

runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::ArrayPrototype):
(JSC::ArrayPrototype::finishCreation):

runtime/ArrayPrototype.h:
runtime/BooleanObject.cpp:

(JSC::BooleanObject::BooleanObject):
(JSC::BooleanObject::finishCreation):

runtime/BooleanObject.h:
runtime/DateInstance.cpp:

(JSC::DateInstance::DateInstance):
(JSC::DateInstance::finishCreation):

runtime/DateInstance.h:
runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::ErrorInstance):

runtime/ErrorInstance.h:

(JSC::ErrorInstance::create):

runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):
(JSC::ErrorPrototype::finishCreation):

runtime/ErrorPrototype.h:
runtime/ExceptionHelpers.cpp:

(JSC::InterruptedExecutionError::InterruptedExecutionError):
(JSC::InterruptedExecutionError::create):
(JSC::TerminatedExecutionError::TerminatedExecutionError):
(JSC::TerminatedExecutionError::create):

runtime/Executable.cpp:

(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::FunctionExecutable::FunctionExecutable):

runtime/Executable.h:

(JSC::NativeExecutable::create):
(JSC::NativeExecutable::NativeExecutable):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::create):
(JSC::FunctionExecutable::create):

runtime/InternalFunction.cpp:

(JSC::InternalFunction::InternalFunction):
(JSC::InternalFunction::finishCreation):

runtime/InternalFunction.h:
runtime/JSActivation.cpp:

(JSC::JSActivation::JSActivation):
(JSC::JSActivation::finishCreation):

runtime/JSActivation.h:
runtime/JSArray.cpp:

(JSC::JSArray::JSArray):

runtime/JSArray.h:

(JSC::JSArray::create):

runtime/JSByteArray.cpp:

(JSC::JSByteArray::JSByteArray):

runtime/JSByteArray.h:

(JSC::JSByteArray::create):

runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):
(JSC::JSFunction::finishCreation):

runtime/JSFunction.h:

(JSC::JSFunction::create):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::finishCreation):

runtime/JSNotAnObject.h:

(JSC::JSNotAnObject::JSNotAnObject):
(JSC::JSNotAnObject::create):

runtime/JSONObject.cpp:

(JSC::JSONObject::JSONObject):
(JSC::JSONObject::finishCreation):

runtime/JSONObject.h:
runtime/JSObjectWithGlobalObject.cpp:

(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):

runtime/JSObjectWithGlobalObject.h:
runtime/JSStaticScopeObject.h:

(JSC::JSStaticScopeObject::create):
(JSC::JSStaticScopeObject::finishCreation):
(JSC::JSStaticScopeObject::JSStaticScopeObject):

runtime/JSVariableObject.h:

(JSC::JSVariableObject::JSVariableObject):

runtime/JSWrapperObject.h:

(JSC::JSWrapperObject::JSWrapperObject):

runtime/MathObject.cpp:

(JSC::MathObject::MathObject):
(JSC::MathObject::finishCreation):

runtime/MathObject.h:
runtime/NumberObject.cpp:

(JSC::NumberObject::NumberObject):
(JSC::NumberObject::finishCreation):

runtime/NumberObject.h:
runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::ObjectPrototype):

runtime/ObjectPrototype.h:

(JSC::ObjectPrototype::create):

runtime/RegExpConstructor.cpp:

(JSC::RegExpMatchesArray::RegExpMatchesArray):
(JSC::RegExpMatchesArray::finishCreation):

runtime/RegExpMatchesArray.h:
runtime/RegExpObject.cpp:

(JSC::RegExpObject::RegExpObject):
(JSC::RegExpObject::finishCreation):

runtime/RegExpObject.h:
runtime/StrictEvalActivation.cpp:

(JSC::StrictEvalActivation::StrictEvalActivation):

runtime/StrictEvalActivation.h:

(JSC::StrictEvalActivation::create):

runtime/StringObject.cpp:

(JSC::StringObject::StringObject):
(JSC::StringObject::finishCreation):

runtime/StringObject.h:

Source/JavaScriptGlue:

Completed the fourth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

UserObjectImp.cpp:

(UserObjectImp::UserObjectImp):

UserObjectImp.h:

(UserObjectImp::create):

Source/WebCore:

No new tests.

Completed the fourth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::create):

bindings/js/JSDOMWindowShell.h:
bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::JSDOMWrapper):

bindings/js/ScriptController.cpp:

(WebCore::ScriptController::createWindowShell):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

bindings/scripts/test/JS/JSTestInterface.h:

(WebCore::JSTestInterfacePrototype::JSTestInterfacePrototype):

bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListenerPrototype::JSTestMediaQueryListListenerPrototype):

bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObjPrototype::JSTestObjPrototype):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):

bridge/objc/objc_runtime.h:
bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
(JSC::Bindings::ObjcFallbackObjectImp::finishCreation):

bridge/runtime_array.cpp:

(JSC::RuntimeArray::RuntimeArray):
(JSC::RuntimeArray::finishCreation):

bridge/runtime_array.h:
bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::RuntimeObject):
(JSC::Bindings::RuntimeObject::finishCreation):

bridge/runtime_object.h:

Source/WebKit2:

Completed the fourth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::JSNPObject):
(WebKit::JSNPObject::finishCreation):

WebProcess/Plugins/Netscape/JSNPObject.h:

4:45 PM Changeset in webkit [94363] by enne@google.com

4 edits in trunk/Source/WebCore

[chromium] Remove unsafe raw GraphicsContext3D pointer from ProgramBinding
https://bugs.webkit.org/show_bug.cgi?id=67003

Reviewed by James Robinson.

ProgramBinding now takes an explicit cleanup call to destroy its
resources. This will assert if it is not called and will leak no
longer potentially dereference a dead pointer.

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::borderProgram):
(WebCore::LayerRendererChromium::headsUpDisplayProgram):
(WebCore::LayerRendererChromium::renderSurfaceProgram):
(WebCore::LayerRendererChromium::renderSurfaceMaskProgram):
(WebCore::LayerRendererChromium::tilerProgram):
(WebCore::LayerRendererChromium::tilerProgramSwizzle):
(WebCore::LayerRendererChromium::tilerProgramAA):
(WebCore::LayerRendererChromium::tilerProgramSwizzleAA):
(WebCore::LayerRendererChromium::canvasLayerProgram):
(WebCore::LayerRendererChromium::pluginLayerProgram):
(WebCore::LayerRendererChromium::videoLayerRGBAProgram):
(WebCore::LayerRendererChromium::videoLayerYUVProgram):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

platform/graphics/chromium/ProgramBinding.cpp:

(WebCore::ProgramBindingBase::ProgramBindingBase):
(WebCore::ProgramBindingBase::~ProgramBindingBase):
(WebCore::ProgramBindingBase::init):
(WebCore::ProgramBindingBase::cleanup):
(WebCore::ProgramBindingBase::loadShader):
(WebCore::ProgramBindingBase::createShaderProgram):

platform/graphics/chromium/ProgramBinding.h:

(WebCore::ProgramBinding::ProgramBinding):
(WebCore::ProgramBinding::initialize):

4:41 PM Changeset in webkit [94362] by jamesr@google.com

9 edits
5 deletes in trunk/LayoutTests

fast/dom/global-constructors.html and fast/dom/prototype-inheritance.html are way too fragile
https://bugs.webkit.org/show_bug.cgi?id=67452

Reviewed by Darin Adler.

Modifies these tests to not print PASS lines for all of the expected successes, since that means they have to be
updated whenever the set of properties on the global object is changed. That is not the point of these tests
and it just causes excessive churn.

fast/dom/global-constructors-expected.txt:
fast/dom/global-constructors.html:
fast/dom/prototype-inheritance-expected.txt:
fast/dom/script-tests/prototype-inheritance.js:
fast/js/resources/js-test-pre.js:

(description):
(descriptionQuiet):
(shouldBe):
(shouldBeTrueQuiet):

platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt:
platform/chromium/fast/dom/global-constructors-expected.txt: Removed.
platform/chromium/fast/dom/prototype-inheritance-expected.txt:
platform/chromium/test_expectations.txt:
platform/gtk/fast/dom/prototype-inheritance-expected.txt: Removed.
platform/mac/fast/dom/prototype-inheritance-expected.txt: Removed.
platform/qt/fast/dom/prototype-inheritance-expected.txt: Removed.
platform/win/fast/dom/prototype-inheritance-expected.txt: Removed.

4:32 PM Changeset in webkit [94361] by mitz@apple.com

1 edit
1 add in trunk/LayoutTests

Added Windows expected results to the test added in r94352.

platform/win/fast/text/fallback-traits-fixup-expected.txt: Added.

4:29 PM Changeset in webkit [94360] by Patrick Gansterer

10 edits in trunk/Source/WebCore

Don't include unnecessary headers in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=67435

Reviewed by Darin Adler.

When an IDL attribue is Conditonal the corresponding headers
need to be surrounded with the correct #if ENABLE().

bindings/scripts/CodeGeneratorV8.pm:
bindings/scripts/test/CPP/WebDOMTestObj.cpp:
bindings/scripts/test/CPP/WebDOMTestObj.h:
bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/JS/JSTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.mm:
bindings/scripts/test/TestObj.idl:
bindings/scripts/test/V8/V8TestObj.cpp:

4:25 PM Changeset in webkit [94359] by commit-queue@webkit.org

4 edits
1 add in trunk/Source/WebKit/chromium

[Chromium, Skia] Add virtual to WebGraphicsContext3D to create a new GrGLInterface per context. Insert per-skia-GL-function callback to set correct GL context.
https://bugs.webkit.org/show_bug.cgi?id=67395

Patch by Brian Salomon <bsalomon@google.com> on 2011-09-01
Reviewed by Kenneth Russell.

WebKit.gyp:
public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::onCreateGrGLInterface):

src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::grContext):

src/WebGraphicsContext3D.cpp: Added.

(WebKit::WebGraphicsContext3D::createGrGLInterface):

4:22 PM Changeset in webkit [94358] by psolanki@apple.com

12 edits in trunk/Source/WebCore

Rename CFNETWORK_DATA_ARRAY_CALLBACK to NETWORK_CFDATA_ARRAY_CALLBACK
https://bugs.webkit.org/show_bug.cgi?id=67348

Reviewed by Alexey Proskuryakov.

loader/ResourceLoader.h:
loader/SubresourceLoader.h:
loader/cf/SubresourceLoaderCF.cpp:
loader/mac/ResourceLoaderMac.mm:
platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::clear):
(WebCore::SharedBuffer::buffer):

platform/SharedBuffer.h:
platform/cf/SharedBufferCF.cpp:
platform/network/ResourceHandle.h:
platform/network/ResourceHandleClient.h:
platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createCFURLConnection):

platform/network/mac/ResourceHandleMac.mm:

4:06 PM Changeset in webkit [94357] by commit-queue@webkit.org

15 edits
3 adds in trunk

TypeError should be thrown when a constructor is called as a normal function.
https://bugs.webkit.org/show_bug.cgi?id=67381

Patch by Kentaro Hara <haraken@google.com> on 2011-09-01
Reviewed by Darin Adler.

The spec is here: http://www.w3.org/TR/WebIDL/#es-interface-call
For example, "Image()" or "XMLHttpRequest()" should throw TypeError.

Source/WebCore:

Test: fast/dom/call-a-constructor-as-a-function.html

bindings/v8/custom/V8ArrayBufferCustom.cpp:

(WebCore::V8ArrayBuffer::constructorCallback): Throws TypeError if args.IsConstructCall() is false.

bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray): Ditto.

bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallback): Ditto.

bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCallback): Ditto.

bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:

(WebCore::v8HTMLAudioElementConstructorCallback): Ditto.

bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback): Ditto.

bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:

(WebCore::v8HTMLOptionElementConstructorCallback): Ditto.

bindings/v8/custom/V8MessageChannelConstructor.cpp:

(WebCore::V8MessageChannel::constructorCallback): Ditto.

bindings/v8/custom/V8SharedWorkerCustom.cpp:

(WebCore::V8SharedWorker::constructorCallback): Ditto.

bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp:

(WebCore::V8WebKitCSSMatrix::constructorCallback): Ditto.

bindings/v8/custom/V8WebKitPointConstructor.cpp:

(WebCore::V8WebKitPoint::constructorCallback): Ditto.

bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback): Ditto.

bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::V8Worker::constructorCallback): Ditto.

LayoutTests:

fast/dom/call-a-constructor-as-a-function-expected.txt: Added. The test result for JSC.
fast/dom/call-a-constructor-as-a-function.html: Added. Checks if TypeError is thrown.
platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt: Added. The test result for V8.

4:03 PM Changeset in webkit [94356] by enne@google.com

4 edits in trunk/Source/WebCore

[chromium] TextureManager overestimates the size of non-RGBA texture formats
https://bugs.webkit.org/show_bug.cgi?id=66917

Reviewed by James Robinson.

Use GraphicsContext3D to determine the size of a given texture format.
Also, make TextureManager use more GraphicsContext3D types.

platform/graphics/GraphicsContext3D.h:
platform/graphics/chromium/TextureManager.cpp:

(WebCore::memoryUseBytes):

platform/graphics/chromium/TextureManager.h:

3:48 PM Changeset in webkit [94355] by weinig@apple.com

7 edits in trunk

Add missing Event constructors to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=67449

Reviewed by Anders Carlsson.

Source/WebCore:

Covered by existing tests.

page/DOMWindow.idl:

LayoutTests:

platform/mac/fast/dom/Window/window-properties-expected.txt:
platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
platform/mac/fast/dom/prototype-inheritance-expected.txt:
platform/mac/fast/js/global-constructors-expected.txt:

Update results for new constructors.

3:42 PM Changeset in webkit [94354] by Patrick Gansterer

15 edits in trunk/Source/WebCore

Consider Conditional attribute in CodeGenerator for methods
https://bugs.webkit.org/show_bug.cgi?id=67409

Reviewed by Darin Adler.

This change adds appropriate #if ENABLE() lines for the preprocessor around the
generated functions depending on the Conditional attribute in the IDL file.

bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

bindings/scripts/test/CPP/WebDOMTestObj.cpp:
bindings/scripts/test/CPP/WebDOMTestObj.h:
bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
bindings/scripts/test/GObject/WebKitDOMTestObj.h:
bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/JS/JSTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.mm:
bindings/scripts/test/TestObj.idl:
bindings/scripts/test/V8/V8TestObj.cpp:

3:40 PM Changeset in webkit [94353] by nduca@chromium.org

25 edits
1 copy
2 moves
3 adds
2 deletes in trunk/Source

[chromium] Introduce CCSingleThreadProxy in order to move LayerRenderer to CCLayerTreeHostImpl
https://bugs.webkit.org/show_bug.cgi?id=66807

Reviewed by James Robinson.

Source/WebCore:

WebCore.gypi:
platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::createTextureUpdater):

platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setLayerRendererRecursive):

platform/graphics/chromium/LayerChromium.h:
platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::close):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
(WebCore::LayerRendererChromium::isContextLost):

platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::capabilities):
(WebCore::LayerRendererChromium::rootLayerImpl):
(WebCore::LayerRendererChromium::contextSupportsMapSub):
(WebCore::LayerRendererChromium::viewportSize):

platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setLayerTreeHost):

platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::reserveTextures):

platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:

(WebCore::CCCanvasLayerImpl::draw):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::animateAndLayout):
(WebCore::CCLayerTreeHost::preCommit):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::createCompositorThread):
(WebCore::CCLayerTreeHost::createLayerTreeHostContext3D):
(WebCore::CCLayerTreeHost::createLayerTreeHostImpl):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::scheduleComposite):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::finishAllRendering):
(WebCore::CCLayerTreeHost::layerRendererCapabilities):
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::skiaContext):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::loseCompositorContext):
(WebCore::CCLayerTreeHost::contentsTextureManager):
(WebCore::CCLayerTreeHost::composite):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Removed.
platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::create):
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::commitComplete):
(WebCore::CCLayerTreeHostImpl::context):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::finishAllRendering):
(WebCore::CCLayerTreeHostImpl::isContextLost):
(WebCore::CCLayerTreeHostImpl::layerRendererCapabilities):
(WebCore::CCLayerTreeHostImpl::present):
(WebCore::CCLayerTreeHostImpl::readback):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::setVisible):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
(WebCore::CCLayerTreeHostImpl::updateLayers):
(WebCore::CCLayerTreeHostImpl::setViewport):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::layerRenderer):
(WebCore::CCLayerTreeHostImpl::rootLayer):
(WebCore::CCLayerTreeHostImpl::viewportSize):

platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Removed.
platform/graphics/chromium/cc/CCMainThreadTask.h:

(WebCore::MainThreadTask4::create):
(WebCore::MainThreadTask4::MainThreadTask4):
(WebCore::MainThreadTask4::performTask):
(WebCore::MainThreadTask5::create):
(WebCore::MainThreadTask5::MainThreadTask5):
(WebCore::MainThreadTask5::performTask):
(WebCore::createMainThreadTask):

platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::draw):

platform/graphics/chromium/cc/CCProxy.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp.

(WebCore::CCProxy::isMainThread):
(WebCore::CCProxy::isImplThread):
(WebCore::CCProxy::setImplThread):

platform/graphics/chromium/cc/CCProxy.h: Added.

(WebCore::CCProxy::~CCProxy):
(WebCore::CCProxy::CCProxy):

platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: Added.

(WebCore::ScopedSetImplThread::ScopedSetImplThread):
(WebCore::ScopedSetImplThread::~ScopedSetImplThread):
(WebCore::CCSingleThreadProxy::create):
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::start):
(WebCore::CCSingleThreadProxy::~CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::context):
(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::isStarted):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::layerRendererCapabilities):
(WebCore::CCSingleThreadProxy::loseCompositorContext):
(WebCore::CCSingleThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCSingleThreadProxy::setNeedsRedraw):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::skiaContext):
(WebCore::CCSingleThreadProxy::contentsTextureManager):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::compositeIfNeeded):
(WebCore::CCSingleThreadProxy::doComposite):

platform/graphics/chromium/cc/CCSingleThreadProxy.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h.
platform/graphics/chromium/cc/CCThreadProxy.cpp: Added.

(WebCore::CCThreadProxy::create):
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::isStarted):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::layerRendererCapabilities):
(WebCore::CCThreadProxy::loseCompositorContext):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::skiaContext):
(WebCore::CCThreadProxy::contentsTextureManager):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::drawLayersOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):
(WebCore::CCThreadProxy::initializeImplOnCCThread):
(WebCore::CCThreadProxy::initializeLayerRendererOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):

platform/graphics/chromium/cc/CCThreadProxy.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h.
platform/graphics/chromium/cc/CCThreadTask.h:

(WebCore::CCThreadTask5::create):
(WebCore::CCThreadTask5::CCThreadTask5):
(WebCore::CCThreadTask5::performTask):
(WebCore::createCCThreadTask):

platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::draw):

Source/WebKit/chromium:

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::didRecreateGraphicsContext):

tests/CCThreadTaskTest.cpp:

(WebCore::TEST):

3:32 PM Changeset in webkit [94352] by mitz@apple.com

3 edits
3 adds in trunk

<rdar://problem/9528843> STIX glyphs not rendered on this stackoverflow answer
https://bugs.webkit.org/show_bug.cgi?id=67444

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/text/fallback-traits-fixup.html

After obtaining STIX Regular as a fallback font for some characters, getFontDataForCharacters()
proceeded to ask for a font from the same family having the desired traits and weight (because
wkGetFontInLanguageForRange() does not preserve traits and weight). The returned font was different
and happened to not contain the desired character.

platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::getFontDataForCharacters): Only ask for a family member with the desired
traits and weight if the substitute font does not already have them, and only use the returned
member if it actually contains the desired character.

LayoutTests:

fast/text/fallback-traits-fixup.html: Added.
platform/mac/fast/text/fallback-traits-fixup-expected.png: Added.
platform/mac/fast/text/fallback-traits-fixup-expected.txt: Added.

3:27 PM Changeset in webkit [94351] by jamesr@google.com

4 edits
2 moves
4 deletes in trunk/LayoutTests

[chromium] Update more SVG baselines

platform/chromium-cg-mac/svg/custom/non-scaling-stroke-expected.png:
platform/chromium-cg-mac/svg/custom/pattern-skew-transformed-expected.png:
platform/chromium-cg-mac/svg/custom/pattern-with-transformation-expected.png:
platform/mac/svg/custom/non-scaling-stroke-expected.txt: Removed.
platform/mac/svg/custom/pattern-skew-transformed-expected.txt: Removed.
platform/qt/svg/custom/non-scaling-stroke-expected.txt: Removed.
platform/qt/svg/custom/pattern-skew-transformed-expected.txt: Removed.
svg/custom/non-scaling-stroke-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/non-scaling-stroke-expected.txt.
svg/custom/pattern-skew-transformed-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/pattern-skew-transformed-expected.txt.

3:16 PM Changeset in webkit [94350] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Generate an XSLTProcessor constructor of V8 using the IDL 'Constructor' extended attribute
https://bugs.webkit.org/show_bug.cgi?id=67414

Patch by Kentaro Hara <haraken@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

Test: fast/dom/Window/custom-constructors.html

fast/xsl/default-html.html

bindings/v8/custom/V8XSLTProcessorCustom.cpp: Removed constructorCallback().
xml/XSLTProcessor.idl: Added the 'Constructor' extended attribute.

3:02 PM Changeset in webkit [94349] by jamesr@google.com

2 edits in trunk/LayoutTests

[chromium] Mark test that renders differently in 32 vs 64 bit mode as failing (WTF?)

platform/chromium/test_expectations.txt:

2:52 PM BuildingQtOnLinux edited by benjamin@webkit.org

Remove the section about debugging from a Qt build. This is not … (diff)

2:40 PM Changeset in webkit [94348] by jamesr@google.com

6 edits
6 adds in trunk/LayoutTests

[chromium] Update chromium baselines for 94338 for windows/mac

platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
platform/chromium-cg-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
platform/chromium-cg-mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
platform/chromium/test_expectations.txt:

2:30 PM Changeset in webkit [94347] by jonlee@apple.com

2 edits in trunk/Websites/webkit.org

Adding control rendering at various sizes.

projects/forms/survey.html:

2:30 PM Changeset in webkit [94346] by jamesr@google.com

4 edits
1 move
1 delete in trunk/LayoutTests

[chromium] Update chromium baselines for 94338

platform/chromium-linux/svg/custom/pattern-rotate-expected.png:
platform/chromium-win/svg/custom/pattern-rotate-expected.png:
platform/chromium/test_expectations.txt:
platform/qt/svg/custom/pattern-rotate-expected.txt: Removed.
svg/custom/pattern-rotate-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/pattern-rotate-expected.txt.

2:29 PM Changeset in webkit [94345] by eric@webkit.org

5 edits in trunk/Tools

REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
https://bugs.webkit.org/show_bug.cgi?id=66228

Reviewed by Dirk Pranke.

ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
The LeaksViewer tool globs for all *-leaks.txt files.
This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.

In order to test this I had to fix a limitation in our MockFileSystem.glob
method. However, doing so uncovered a typo and bug in the integration tests.
I've disabled the offending integration tests.

Scripts/webkitpy/common/system/filesystem_mock.py:
Scripts/webkitpy/layout_tests/port/leakdetector.py:
Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:

2:22 PM Changeset in webkit [94344] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

HTMLMediaElement should use fastHasAttribute instead of hasAttribute
https://bugs.webkit.org/show_bug.cgi?id=67421

Reviewed by Simon Fraser.

Use fastHasAttribute instead of hasAttribute because it is faster, and HTMLMediaElement
doesn't ever need to check style or SVG animated attributes.

No new tests required, this is just an optimization.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::selectMediaResource): hasAttribute -> fastHasAttribute.
(WebCore::HTMLMediaElement::loadResource): Ditto.
(WebCore::HTMLMediaElement::autoplay): Ditto.
(WebCore::HTMLMediaElement::loop): Ditto.
(WebCore::HTMLMediaElement::controls): Ditto.
(WebCore::HTMLMediaElement::selectNextSourceChild): Ditto.
(WebCore::HTMLMediaElement::sourceWasAdded): Ditto.

2:14 PM Changeset in webkit [94343] by commit-queue@webkit.org

21 edits
2 adds in trunk

Source/WebCore: Add API functions to enable starting and stopping speech input,
and checking the current speech input state.
https://bugs.webkit.org/show_bug.cgi?id=60170

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

Test: fast/speech/input-text-speechstart.html

html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::startSpeechInput):
(WebCore::InputFieldSpeechButtonElement::stopSpeechInput):

html/shadow/TextControlInnerElements.h:
rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::speechButtonElement):

rendering/RenderTextControlSingleLine.h:

Source/WebKit/chromium: Add API functions to enable starting and stopping speech input,
and checking the current speech input state.
https://bugs.webkit.org/show_bug.cgi?id=60170

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

public/WebInputElement.h:
src/AssertMatchingEnums.cpp:
src/WebInputElement.cpp:

(WebKit::WebInputElement::isSpeechInputEnabled):
(WebKit::WebInputElement::getSpeechInputState):
(WebKit::WebInputElement::startSpeechInput):
(WebKit::WebInputElement::stopSpeechInput):

Tools: Adds a LayoutTestController method to make it possible to test
starting speech input via an API call.
https://bugs.webkit.org/show_bug.cgi?id=60170

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

DumpRenderTree/LayoutTestController.h:
DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::startSpeechInput):

DumpRenderTree/chromium/LayoutTestController.h:
DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::startSpeechInput):

DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::startSpeechInput):

DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::startSpeechInput):

DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::startSpeechInput):

DumpRenderTree/qt/LayoutTestControllerQt.h:
DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::startSpeechInput):

DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::startSpeechInput):

LayoutTests: Adds a new test that checks triggering speech input via an API call.
https://bugs.webkit.org/show_bug.cgi?id=60170

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

fast/speech/input-text-speechtrigger-expected.txt: Added.
fast/speech/input-text-speechtrigger.html: Added.

2:06 PM Changeset in webkit [94342] by dbates@webkit.org

2 edits in trunk/Source/JavaScriptCore

QNX GCC distribution doesn't support vasprintf()
https://bugs.webkit.org/show_bug.cgi?id=67423

Reviewed by Antonio Gomes.

wtf/Platform.h: Don't enable HAVE_VASPRINTF when building with GCC on QNX.

1:46 PM Changeset in webkit [94341] by caryclark@google.com

39 edits
203 adds
1154 deletes in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac, next chunk of files)
Some images incorrectly created with LCD text replaced with gray-scale.
Updated newer tests with reference images.
Deleted images with correct fallbacks.

platform/chromium-mac/http/tests/navigation/error404-basic-expected.png: Removed.

(remaining files omitted for brevity)

1:39 PM Changeset in webkit [94340] by adachan@apple.com

5 edits in trunk/Source/WebKit2

Gather memory cache statistics in WebProcess::getWebCoreStatistics().
https://bugs.webkit.org/show_bug.cgi?id=67160

Reviewed by Darin Adler.

Encode and decode webCoreCacheStatistics data member in StatisticsData.

Shared/StatisticsData.cpp:

(WebKit::StatisticsData::encode):
(WebKit::StatisticsData::decode):

Shared/StatisticsData.h:

Convert the cache statistics data into an ImmutableArray and return it in WebContext::didGetWebCoreStatistics().

UIProcess/WebContext.cpp:

(WebKit::WebContext::didGetWebCoreStatistics):

Store memory cache statistics into the StatisticsData object.

WebProcess/WebProcess.cpp:

(WebKit::getWebCoreMemoryCacheStatistics):
(WebKit::WebProcess::getWebCoreStatistics):

1:38 PM Changeset in webkit [94339] by jamesr@google.com

1 edit
5 adds in trunk/LayoutTests

[chromium] Land chromium baselines for fast/css/focus-ring-multiline-writingmode-vertical.html

platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
platform/chromium-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
platform/chromium-win/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
platform/chromium-win/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.

1:27 PM Changeset in webkit [94338] by timothy_horton@apple.com

10 edits
3 adds in trunk

REGRESSION: Rendering artifacts on a rotated, pattern filled SVG shape
https://bugs.webkit.org/show_bug.cgi?id=53055
<rdar://problem/8910917>

Reviewed by Simon Fraser.

Make use of wkCGPatternCreateWithImageAndTransform
when tiling patterns in both directions. This helps to avoid
pixel-cracking along pattern tiling boundaries.

Ignore 2D rotation when computing the size of a pattern's tile image,
as it artificially inflates the size of the tile, which can cause
pixel-cracking.

Test: svg/custom/pattern-rotate-gaps.svg

platform/graphics/cg/PatternCG.cpp:

(WebCore::Pattern::createPlatformPattern):

rendering/svg/RenderSVGResourcePattern.cpp:
rendering/svg/SVGImageBufferTools.cpp:

(WebCore::SVGImageBufferTools::roundedImageBufferSize):

rendering/svg/SVGImageBufferTools.h:

Add a test that makes pixel cracking in transformed SVG patterns quite blatant,
and rebaseline some other tests affected by the change.

platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
platform/mac/svg/custom/pattern-rotate-expected.png:
platform/mac/svg/custom/pattern-rotate-gaps-expected.png: Added.
platform/mac/svg/custom/pattern-rotate-gaps-expected.txt: Added.
platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
svg/custom/pattern-rotate-gaps.svg: Added.

1:09 PM Changeset in webkit [94337] by jamesr@google.com

2 edits
3 deletes in trunk/LayoutTests

[chromium] Update expectations and baselines

platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Removed.
platform/chromium/test_expectations.txt:

1:04 PM Changeset in webkit [94336] by msaboff@apple.com

11 edits in trunk/Source/JavaScriptCore

Remove simple usage of UString::characters() from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=67340

In preparation to allowing StringImpl to be backed by 8 bit
characters when appropriate, we need to eliminate or change the
usage of StringImpl::characters(). Most of the changes below
change s->characters()[0] to s[0].

Reviewed by Geoffrey Garen.

bytecompiler/BytecodeGenerator.cpp:

(JSC::keyForCharacterSwitch):

bytecompiler/NodesCodegen.cpp:

(JSC::processClauseList):

interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

runtime/Identifier.cpp:

(JSC::Identifier::addSlowCase):

runtime/JSGlobalObjectFunctions.cpp:

(JSC::jsToNumber):
(JSC::parseFloat):

runtime/JSString.cpp:

(JSC::JSString::substringFromRope):

runtime/JSString.h:

(JSC::jsSingleCharacterSubstring):
(JSC::jsString):
(JSC::jsSubstring):
(JSC::jsOwnedString):

runtime/RegExp.cpp:

(JSC::regExpFlags):

wtf/text/StringBuilder.h:

(WTF::StringBuilder::operator[]):

12:56 PM Changeset in webkit [94335] by timothy_horton@apple.com

2 edits in trunk/Tools

Fix TestWebKitAPI build on clang-2.0

TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:

12:51 PM Changeset in webkit [94334] by Patrick Gansterer

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r94284.
http://trac.webkit.org/changeset/94284
https://bugs.webkit.org/show_bug.cgi?id=65050

Broke building without SVG enabled on Chromium.

page/DOMWindow.idl:

12:50 PM Changeset in webkit [94333] by ap@apple.com

3 edits in trunk/Source/WebCore

REGRESSION (r93247): 2 http/tests/misc tests failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=67374

Reviewed by Simon Fraser.

platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::applyBasicAuthorizationHeader):

platform/network/mac/ResourceHandleMac.mm:

(WebCore::applyBasicAuthorizationHeader):
Some versions of CFNetwork carry along an Authorization header, some don't. We shouldn't
repeat its value twice, this is not one of those headers that allow comma separated lists
of values.

12:40 PM Changeset in webkit [94332] by noel.gordon@gmail.com

2 edits in trunk/Source/WebCore

[chromium] Move ImageBuffer::platformLayer()
https://bugs.webkit.org/show_bug.cgi?id=67372

Reviewed by Kenneth Russell.

No new tests: refactoring only, covered by existting tests.

platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::platformLayer): Move it away from the toDataURL code.

12:38 PM Changeset in webkit [94331] by commit-queue@webkit.org

3 edits
5 adds in trunk

Focus ring is rendered incorrectly for a block with -webkit-writing-mode
https://bugs.webkit.org/show_bug.cgi?id=62915

Patch by Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org> on 2011-09-01
Reviewed by Simon Fraser.

Source/WebCore:

RenderBlock::addFocusRingRects() should consider physical box position and
dimension instead of logical values for focus ring rects calculation.

Test: fast/css/focus-ring-multiline-writingmode-vertical.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addFocusRingRects):

LayoutTests:

fast/css/focus-ring-multiline-writingmode-vertical.html: Added.
platform/qt-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
platform/qt-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.

12:33 PM Changeset in webkit [94330] by Philippe Normand

2 edits in trunk/Source/WebCore

Unreviewed, GTK build fix after r94299.

GNUmakefile.list.am:

12:28 PM Changeset in webkit [94329] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

[Chromium/Skia] Use GraphicsContext3D::grContext() to create GrContext for accelerated drawing
https://bugs.webkit.org/show_bug.cgi?id=67419

Patch by Brian Salomon <bsalomon@google.com> on 2011-09-01
Reviewed by James Robinson.

Accelerated drawing is not enabled in layout tests. However, once it is this change will be tested by every test.

platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::contextSupportsAcceleratedPainting):
(WebCore::LayerRendererChromium::initialize):

platform/graphics/chromium/LayerRendererChromium.h:
platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterSkPicture::create):
(WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):

platform/graphics/chromium/LayerTextureUpdaterCanvas.h:

12:27 PM Changeset in webkit [94328] by commit-queue@webkit.org

1 edit
1 move in trunk/Source/WebCore

Rename GraphicsContext3DInternal to GraphicsContext3DPrivate and add a dummy version of this class for Mac
https://bugs.webkit.org/show_bug.cgi?id=67172

Build fix, completing rename for GTK file.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2011-09-01
Reviewed by Chris Marrin.

platform/graphics/gtk/GraphicsContext3DPrivate.cpp: Renamed from Source/WebCore/platform/graphics/gtk/GraphicsContext3DInternal.cpp.

(sharedDisplay):
(WebCore::activeGraphicsContexts):
(WebCore::GraphicsContext3DPrivate::addActiveGraphicsContext):
(WebCore::GraphicsContext3DPrivate::removeActiveGraphicsContext):
(WebCore::GraphicsContext3DPrivate::cleanupActiveContextsAtExit):
(WebCore::GraphicsContext3DPrivate::create):
(WebCore::GraphicsContext3DPrivate::createPbufferContext):
(WebCore::GraphicsContext3DPrivate::createPixmapContext):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::makeContextCurrent):

12:12 PM Changeset in webkit [94327] by Simon Fraser

1 edit
4 moves in trunk/LayoutTests

r93794 results in ruby tests causing assertion failure in RenderBlock.cpp
https://bugs.webkit.org/show_bug.cgi?id=67007

Reviewed by Beth Dakin.

Disable these asserting ruby tests until the underlying issue can be fixed.

fast/ruby/after-block-doesnt-crash.html-disabled: Renamed from LayoutTests/fast/ruby/after-block-doesnt-crash.html.
fast/ruby/after-table-doesnt-crash.html-disabled: Renamed from LayoutTests/fast/ruby/after-table-doesnt-crash.html.
fast/ruby/generated-after-counter-doesnt-crash.html-disabled: Renamed from LayoutTests/fast/ruby/generated-after-counter-doesnt-crash.html.
fast/ruby/generated-before-and-after-counter-doesnt-crash.html-disabled: Renamed from LayoutTests/fast/ruby/generated-before-and-after-counter-doesnt-crash.html.

12:01 PM Changeset in webkit [94326] by jamesr@google.com

1 edit
2 adds in trunk/LayoutTests

[chromium] Update baselines for vertical-text-glyph-test.html

platform/chromium-cg-mac/fast/text/international/vertical-text-glyph-test-expected.png: Added.
platform/chromium-cg-mac/fast/text/international/vertical-text-glyph-test-expected.txt: Added.

11:57 AM Changeset in webkit [94325] by jamesr@google.com

4 edits in trunk/Tools

Remove unused "extension" parameter from rebaseline gardeningserver handler
https://bugs.webkit.org/show_bug.cgi?id=67384

Patch by Adam Barth <abarth@webkit.org> on 2011-09-01
Reviewed by James Robinson.

This parameter hasn't done anything in a while.

Scripts/webkitpy/tool/commands/rebaseline.py:
Scripts/webkitpy/tool/servers/gardeningserver.py:
Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

11:44 AM Changeset in webkit [94324] by Simon Fraser

2 edits in trunk/Source/WebCore

REGRESSION (r94259): Two tests doing hit testing were broken by this change.
https://bugs.webkit.org/show_bug.cgi?id=67353

Reviewed by Chris Marrin.

Fix a regression from r94259; that change missed a fix in RenderView,
which affects coordinate transforms in position:fixed elements.

This fixes these tests:

fast/events/document-elementFromPoint.html
fast/events/offsetX-offsetY.html
plugins/mouse-events-fixedpos.html

rendering/RenderView.cpp:

(WebCore::RenderView::mapAbsoluteToLocalPoint):

11:41 AM Changeset in webkit [94323] by tonyg@chromium.org

3 edits in trunk/Source

[chromium] Fonts returned by FontCache::getFontDataForCharacters() are never released
https://bugs.webkit.org/show_bug.cgi?id=66673

Reviewed by James Robinson.

This was fixed for other ports in http://trac.webkit.org/changeset/88260.
However, it was missed in FontCacheLinux likely due to similar param in the nested call to getCachedFontPlatformData().

No new tests because no directly observable change in behavior.

platform/graphics/chromium/FontCacheLinux.cpp:

(WebCore::FontCache::getFontDataForCharacters):

11:39 AM Changeset in webkit [94322] by mnaganov@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] Perform a more effective JS GC
https://bugs.webkit.org/show_bug.cgi?id=67304

Reviewed by Pavel Feldman.

bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::collectGarbage):

11:39 AM Changeset in webkit [94321] by caio.oliveira@openbossa.org

5 edits
2 adds in trunk/Source/WebKit/qt

[Qt] Transform QtFallbackWebPopupCombo into QtWebComboBox
https://bugs.webkit.org/show_bug.cgi?id=67344

Reviewed by Andreas Kling.

Renamed QtFallbackWebPopup to QtWebComboBox and decoupled it from
QtFallbackWebPopup. The new class is a QComboBox with the features that
we need for QtWebKit: tracking when the popup is hidden (via the didHide()
signal) and a convenience method to show its popup in the cursor position.

An important change was made to the combobox: instead of hooking our actions in
showPopup() and hidePopup(), as well as watching for popup visibility events, we
now just watch for the visibility events. This allowed us to get rid of
m_popupVisible and tracking the Show event.

This commit also removed a workaround for input focus added in r40970 after
reviewers request. See bug report for details.

QtWebKit.pro:
WebCoreSupport/QtFallbackWebPopup.cpp:

(WebCore::QtFallbackWebPopup::QtFallbackWebPopup):
(WebCore::QtFallbackWebPopup::~QtFallbackWebPopup):
(WebCore::QtFallbackWebPopup::show):
(WebCore::QtFallbackWebPopup::deleteComboBox):

WebCoreSupport/QtFallbackWebPopup.h:
WebCoreSupport/QtWebComboBox.cpp: Added.

(WebCore::QtWebComboBox::QtWebComboBox):
(WebCore::QtWebComboBox::showPopupAtCursorPosition):
(WebCore::QtWebComboBox::eventFilter):

WebCoreSupport/QtWebComboBox.h: Added.

tests/qwebframe/tst_qwebframe.cpp:

(tst_QWebFrame::popupFocus):
Change the test to use QObject::findChild(). The old method couldn't find our
new class because we defined a new metaclass for it.

11:37 AM Changeset in webkit [94320] by Nate Chapin

3 edits in trunk/LayoutTests

http/tests/loading/empty-urls.html shouldn't
fail if the load event fires before we finish.
https://bugs.webkit.org/show_bug.cgi?id=67359

Reviewed by Adam Barth.

http/tests/loading/empty-urls-expected.txt:
http/tests/loading/empty-urls.html:

11:20 AM Changeset in webkit [94319] by weinig@apple.com

10 edits
2 adds in trunk

WebGLContextEvent should have its own JS wrapper
https://bugs.webkit.org/show_bug.cgi?id=67352

Reviewed by Anders Carlsson.

Source/WebCore:

The WebGLContextEvent was missing a proper JS wrapper, and thus
anyone using one in an EventListener was actually just getting
a plain old Event. Rectify this by generating the wrapper and
wrapping it on creating.

Test: fast/canvas/webgl/WebGLContextEvent.html

CodeGenerators.pri:

Add WebGLContextEvent.idl

DerivedSources.make:

Add WebGLContextEvent and sort.

WebCore.xcodeproj/project.pbxproj:

Add generated JSWebGLContextEvent.h/cpp.

bindings/js/JSEventCustom.cpp:

(WebCore::toJS):
Wrap WebGLContextEvents as JSWebGLContextEvents.

dom/Event.cpp:

(WebCore::Event::isWebGLContextEvent):

dom/Event.h:
html/canvas/WebGLContextEvent.cpp:

(WebCore::WebGLContextEvent::isWebGLContextEvent):

html/canvas/WebGLContextEvent.h:

Add predicate for WebGLContextEvent.

LayoutTests:

fast/canvas/webgl/WebGLContextEvent-expected.txt: Added.
fast/canvas/webgl/WebGLContextEvent.html: Added.

Add a test that shows that WebGLContextEvents are not just base Events.

11:10 AM Changeset in webkit [94318] by eric.carlson@apple.com

6 edits
2 adds in trunk

Add 'muted' content attribute to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=58369

Source/WebCore:

Reviewed by Darin Adler.

Test: media/video-defaultmuted.html

html/HTMLAttributeNames.in: Add muted.
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadResource): Deal with the 'muted' attribute.

html/HTMLMediaElement.idl: Add defaultMuted.

LayoutTests:

Reviewed by Darin Adler.

media/video-defaultmuted-expected.txt: Added.
media/video-defaultmuted.html: Added.

11:03 AM Changeset in webkit [94317] by timothy_horton@apple.com

15 edits in trunk

REGRESSION: Rendering artifacts on a rotated, pattern filled shape
https://bugs.webkit.org/show_bug.cgi?id=53055
<rdar://problem/8910917>

Reviewed by Simon Fraser.

Introduce wkCGPatternCreateWithImageAndTransform.

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebCore.exp.in:
platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:

WebKitSystemInterface.h:
libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceLion.a:
libWebKitSystemInterfaceSnowLeopard.a:
win/include/WebKitSystemInterface/WebKitSystemInterface.h:
win/lib/WebKitSystemInterface.lib:

11:01 AM Changeset in webkit [94316] by eric@webkit.org

2 edits in trunk/Tools

Unreviewed.

Fix a typo in unittests. Unfortunately fixing it
caused several assertions. Just disabling the test
instead, since it was providing no value before due to the typo.

Scripts/webkitpy/layout_tests/port/test.py:

10:58 AM Changeset in webkit [94315] by enne@google.com

3 edits
5 adds in trunk

[chromium] Fix scissor rects on clipped nested iframes
https://bugs.webkit.org/show_bug.cgi?id=67221

Reviewed by James Robinson.

Source/WebCore:

Layers that mask to bounds (like iframes) weren't being properly
clipped if their parent scissor rect was empty. This case happens
when a parent iframe is clipped. Fixed by propagating the empty
scissor rect to child layers rather than ignoring it.

Test: compositing/iframes/nested-composited-iframe.html

platform/graphics/chromium/LayerRendererChromium.cpp:

LayoutTests:

compositing/iframes/nested-composited-iframe-expected.png: Added.
compositing/iframes/nested-composited-iframe-expected.txt: Added.
compositing/iframes/nested-composited-iframe.html: Added.
compositing/iframes/resources/composited-red.html: Added.
compositing/iframes/resources/has-composited-iframe-child.html: Added.

10:57 AM Changeset in webkit [94314] by abarth@webkit.org

12 edits in trunk/Tools

Add a "rebaseline" button to the garden-o-matic summary page
https://bugs.webkit.org/show_bug.cgi?id=67382

Reviewed by Dimitri Glazkov.

As much as we might wish folks to not rebaseline entire test groups at
once, the truth is that doing so is a common operation. Adding a
button for this operation is likely to make folks happy.

This patch also cleans up a bunch of plumbing surrounding failureInfo
objects.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:

10:56 AM Changeset in webkit [94313] by commit-queue@webkit.org

3 edits
3 adds in trunk/Source/WebKit2

[Qt] TouchWebView crashes with segmentation fault
https://bugs.webkit.org/show_bug.cgi?id=67308

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-01
Reviewed by Benjamin Poulain.

If you instantiate TouchWebView element with height and width in a qml file and
load a url it crashes.
The functions setWidth() and setHeight() are called sequentially therefore it can happen
that computeViewportAttributes was called with a size like (width, 0) breaking the
assumption of the function that the size is valid. The patch makes sure we compute the
viewport when both height and width are valid.

UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::updateViewportConstraints):

UIProcess/API/qt/tests/qmltests/TouchWebView/tst_load.qml: Added.
UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadNegativeSizeView.qml: Added.
UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadZeroSizeView.qml: Added.
UIProcess/API/qt/tests/qmltests/qmltests.pro:

10:54 AM Changeset in webkit [94312] by abarth@webkit.org

6 edits in trunk/Tools

garden-o-matic should let the gardener assign blame for a group of test failures
https://bugs.webkit.org/show_bug.cgi?id=67379

Reviewed by Dimitri Glazkov.

If a group of test failures has a large revision range, the gardener
might wish to blame a specific revision for the failure. Currently,
this only effect of assigning blame in this way is to hide the other
suspect commits.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:

10:53 AM Changeset in webkit [94311] by abarth@webkit.org

4 edits in trunk/Tools

Hide garden-o-matic failure table until hover
https://bugs.webkit.org/show_bug.cgi?id=67376

Reviewed by Dimitri Glazkov.

This patch removes the failure table for build failures (because it
does not make sense) and hides the failure table for test groups until
the user hovers over the test failure block, reducing visual noise.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:

10:51 AM Changeset in webkit [94310] by abarth@webkit.org

4 edits in trunk/Tools

Switch garden-o-matic from commitData.title to commitData.summary
https://bugs.webkit.org/show_bug.cgi?id=67375

Reviewed by Dimitri Glazkov.

commitData.title is a string provided by Trac, which isn't great in all
cases. commitData.summary is my attempt to find the most important
one-line summary of the commit. This patch switches garden-o-matic
over to summary.

Also, this patch tweaks a bunch of CSS to tighten up the summary page
and reduce visual noise.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:

10:48 AM Changeset in webkit [94309] by abarth@webkit.org

6 edits in trunk/Tools

Group failing tests in garden-o-matic if there are more than three in a folder
https://bugs.webkit.org/show_bug.cgi?id=67373

Reviewed by Dimitri Glazkov.

Sometimes a failure will cause many tests in a given directory to fail.
When that happens, it's better to list the directory as a single item
(with a count) rather than spamming all the test names.

(This patch also updates a bunch of unit test expected results after my last commit.)

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:

10:47 AM Changeset in webkit [94308] by abarth@webkit.org

3 edits
1 add in trunk/Tools

Lower the visual noise from the failing builders display
https://bugs.webkit.org/show_bug.cgi?id=67369

Reviewed by Dimitri Glazkov.

This patch ensures that the "Building" row in the failing builders
display is always last and dims it by 50% to reduce visual noise. This
lets the gardener focus on the actual failures.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.

10:39 AM Changeset in webkit [94307] by yurys@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: close dedicated worker inspectors when page inspector is closing
https://bugs.webkit.org/show_bug.cgi?id=67366

Close all dedicated worker inspector windows when page inspector is closing.

Reviewed by Pavel Feldman.

inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.prototype._openInspectorWindow):
(WebInspector.WorkerManager.prototype._pageInspectorClosing):
(WebInspector.WorkerManager.prototype._workerInspectorClosing):

inspector/front-end/inspector.js:

(WebInspector.close):

10:36 AM Changeset in webkit [94306] by yurys@chromium.org

6 edits in trunk/Source/WebCore

[Chromium] Web Inspector: dedicated worker inspection is broken
https://bugs.webkit.org/show_bug.cgi?id=67279

Provide transport for inspector messages between Page and DedicatedWorker inspectors
in case of in-process workers.

Reviewed by Pavel Feldman.

inspector/CodeGeneratorInspector.pm: sendMessageObjectToBackend should accept message

object which is ready for sending to backend. This method is overriden in WorkerManager
for dedicated workers and we don't want to replicate request id assignment there.

workers/WorkerMessagingProxy.cpp:

(WebCore::PostMessageToPageInspectorTask::create):
(WebCore::PostMessageToPageInspectorTask::PostMessageToPageInspectorTask):
(WebCore::PostMessageToPageInspectorTask::performTask):
(WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
(WebCore::connectToWorkerContextInspectorTask):
(WebCore::WorkerMessagingProxy::connectToInspector):
(WebCore::disconnectFromWorkerContextInspectorTask):
(WebCore::WorkerMessagingProxy::disconnectFromInspector):
(WebCore::dispatchOnInspectorBackendTask):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):

workers/WorkerMessagingProxy.h:

10:25 AM Changeset in webkit [94305] by apavlov@chromium.org

4 edits
3 copies
3 adds in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline tests after r94299.

platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt.
platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
platform/chromium-win/fast/borders/border-image-slices-expected.png: Added.
platform/chromium-win/fast/borders/border-image-slices-expected.txt: Added.
platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:

10:22 AM Changeset in webkit [94304] by Csaba Osztrogonác

2 edits in trunk/Source/WebCore

[CSS3 Backgrounds and Borders] Implement border-image-slice
https://bugs.webkit.org/show_bug.cgi?id=67321

WebCore.pro: Unreviewed buildfix after Dave "scattered" Hyatt (r94299).

10:20 AM Changeset in webkit [94303] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Typesetting features need not force complex for single-character runs
https://bugs.webkit.org/show_bug.cgi?id=66498

Typesetting features have no effect on a solitary character, so they shouldn't enable complex layout
unless multiple characters are present.

Patch by Ned Holbrook <nholbrook@apple.com> on 2011-09-01
Reviewed by Dan Bernstein.

No new tests, this is merely a performance optimization.

platform/graphics/Font.cpp:

(WebCore::Font::codePath): typesettingFeatures() only forces Complex for multiple-character runs.

10:15 AM Changeset in webkit [94302] by jeffm@apple.com

3 edits in trunk/Source/WebCore

Defer creating AVPlayer and AVPlayerItem in MediaPlayerPrivateAVFoundation::setPreload()
https://bugs.webkit.org/show_bug.cgi?id=66253

Reviewed by Jon Honeycutt.

No new tests, should be covered by existing media tests.

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::setPreload): Use the same code on Mac and Windows to only create the AVPlayer and AVPlayerItem when needed.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Assign any existing AVPlayerItem to the new AVPlayer.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Allow creation of the AVPlayerItem before the AVPlayer.

9:15 AM WebKitGtkLayoutTests edited by Philippe Normand

(diff)

9:10 AM Changeset in webkit [94301] by commit-queue@webkit.org

6 edits in trunk/LayoutTests

New baselines needed after changes in r94185
https://bugs.webkit.org/show_bug.cgi?id=67350

Patch by Anna Cavender <annacc@chromium.org> on 2011-09-01
Reviewed by Eric Carlson.

platform/chromium-linux/media/audio-repaint-expected.png:
platform/chromium-linux/media/video-zoom-controls-expected.png:
platform/chromium-win/media/audio-repaint-expected.png:
platform/chromium-win/media/video-zoom-controls-expected.png:
platform/chromium/test_expectations.txt:

9:03 AM Changeset in webkit [94300] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Unreviewed, rolling out r94194.
http://trac.webkit.org/changeset/94194
https://bugs.webkit.org/show_bug.cgi?id=67410

Broke a test on the GTK+ bots. (Requested by mrobinson on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-01

platform/gtk/Skipped:

9:01 AM Changeset in webkit [94299] by hyatt@apple.com

27 edits
5 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=67321

Implement border-image-slice. This will eventually be a component of the new border-image shorthand
property. It holds the cuts that you make into the border image along with a new optional "fill"
keyword that indicates whether or not the center should be filled with the middle slice of the image.

By default -webkit-border-image has always filled, but this does not match the specification. To preserve
backwards compatibility, -webkit-border-image will continue to fill by default, but this does slightly affect
computed style results, since the "fill" keyword will now be included in property dumps.

Reviewed by Beth Dakin.

Added fast/borders/border-image-slices.html.

CMakeLists.txt:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSBorderImageSliceValue.cpp: Added.

(WebCore::CSSBorderImageSliceValue::CSSBorderImageSliceValue):
(WebCore::CSSBorderImageSliceValue::~CSSBorderImageSliceValue):
(WebCore::CSSBorderImageSliceValue::cssText):

css/CSSBorderImageSliceValue.h: Added.

(WebCore::CSSBorderImageSliceValue::create):
(WebCore::CSSBorderImageSliceValue::isBorderImageSliceValue):
Add a new CSSBorderImageSliceValue that holds both the four slices (as a CSS rect) and the
fill keyword (as a boolean). Note that the cssText() dumping of the slices has been refined
to be smarter, and it will no longer dump repeating values.

css/CSSBorderImageValue.cpp:

(WebCore::CSSBorderImageValue::CSSBorderImageValue):
(WebCore::CSSBorderImageValue::cssText):

css/CSSBorderImageValue.h:

(WebCore::CSSBorderImageValue::create):
CSSBorderImageValue now owns a CSSBorderImageSliceValue instead of just a CSS rect.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForNinePieceImageSlice):
(WebCore::valueForNinePieceImage):
Add a new method, valueForNinePieceImageSlice, for getting the slices plus the fill value
from the NinePieceImage and putting it into a CSSBorderImageSliceValue. This method is now used by
valueForNinePieceImage to get the CSSBorderImageSliceValue that is part of the overall
CSSBorderImageValue.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Adding support for the new properties: border-image-slice and -webkit-mask-box-image-slice.

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::allowBreak):
(WebCore::BorderImageParseContext::commitImage):
(WebCore::BorderImageParseContext::commitSlice):
(WebCore::BorderImageParseContext::commitSlash):
(WebCore::BorderImageParseContext::commitBorderImage):
(WebCore::CSSParser::parseBorderImage):
Modify parseBorderImage to no longer parse the slices itself. Instead it farms out the parsing
to parseBorderImageSlice.

(WebCore::BorderImageSliceParseContext::BorderImageSliceParseContext):
(WebCore::BorderImageSliceParseContext::allowNumber):
(WebCore::BorderImageSliceParseContext::allowFill):
(WebCore::BorderImageSliceParseContext::allowFinalCommit):
(WebCore::BorderImageSliceParseContext::top):
(WebCore::BorderImageSliceParseContext::commitNumber):
(WebCore::BorderImageSliceParseContext::commitFill):
(WebCore::BorderImageSliceParseContext::setAllowFinalCommit):
(WebCore::BorderImageSliceParseContext::setTop):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::CSSParser::parseBorderImageSlice):
Slice parsing has now been broken out so that it can be parsed as a single property. In addition
support for the "fill" keyword has been added to control image filling.

css/CSSParser.h:

Modified to add the new parseBorderImageSlice method.

css/CSSPropertyNames.in:

Add the new properties: border-image-slice and -webkit-mask-box-image-slice.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapNinePieceImage):
Rework mapNinePieceImage to call mapNinePieceImageSlice so that the mapping can be done just for
the slices.

(WebCore::CSSStyleSelector::mapNinePieceImageSlice):
A new method that handles mapping just the slices into the front-end NinePieceImage.

(WebCore::CSSStyleSelector::loadPendingImages):
Modified to ensure the fill value is preserved when box-reflect makes a new NinePieceImage.

css/CSSStyleSelector.h:

Added the new mapNinePieceImageSlice method.

css/CSSValue.h:

(WebCore::CSSValue::isBorderImageSliceValue):
Virtual function for identifying border image slice values.

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintNinePieceImage):
The painting of the nine piece image has been modified to match the specification. The "fill"
keyword controls whether or not the middle is painted.

rendering/style/NinePieceImage.cpp:

(WebCore::NinePieceImage::operator==):
The fill keyword has to be checked now for equality.

rendering/style/NinePieceImage.h:

(WebCore::NinePieceImage::NinePieceImage):
(WebCore::NinePieceImage::fill):
(WebCore::NinePieceImage::setFill):
Added the fill keyword to the front end NinePieceImage.

(WebCore::NinePieceImage::copySlicesFrom):
Added a helper to copy only the slices over from another NinePieceImage. Used when inheriting
the border-image-slice property from a parent style.

LayoutTests: Implement border-image-slice. This will eventually be a component of the new border-image shorthand
property. It holds the cuts that you make into the border image along with a new optional "fill"
keyword that indicates whether or not the center should be filled with the middle slice of the image.

By default -webkit-border-image has always filled, but this does not match the specification. To preserve
backwards compatibility, -webkit-border-image will continue to fill by default, but this does slightly affect
computed style results, since the "fill" keyword will now be included in property dumps.

Reviewed by Beth Dakin.

Added fast/borders/border-image-slices.html.

fast/borders/border-image-slices.html: Added.
fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-with-zoom-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt:
fast/css/uri-token-parsing-expected.txt:
fast/css/uri-token-parsing.html:
platform/mac/fast/borders/border-image-slices-expected.png: Added.
platform/mac/fast/borders/border-image-slices-expected.txt: Added.
svg/css/getComputedStyle-basic-expected.txt:

8:09 AM Changeset in webkit [94298] by adachan@apple.com

7 edits in trunk/Source

Source/JavaScriptCore: Export fastMallocStatistics and Heap::objectTypeCounts for https://bugs.webkit.org/show_bug.cgi?id=67160.

Reviewed by Darin Adler.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Source/WebKit2: Gather JavaScript, FastMalloc, icon, font, and glyph page statistics in WebProcess::getWebCoreStatistics().
https://bugs.webkit.org/show_bug.cgi?id=67160

Reviewed by Darin Adler.

Encode and decode the data members in StatisticsData.

Shared/StatisticsData.cpp:

(WebKit::StatisticsData::encode):
(WebKit::StatisticsData::decode):
(WebKit::StatisticsData::StatisticsData):

Add three data members to StatisticsData:

statisticsNumbers: Map containing statistics values that are numbers, mapped by their names, such as

JavaScriptObjectsCount, CachedFontDataCount, etc.

javaScriptProtectedObjectTypeCounts
javaScriptObjectTypeCounts
Shared/StatisticsData.h:

Create a WK::Dictionary containing statistics values mapped by their names and return that dictionary
in WebContext::didGetWebCoreStatistics().

UIProcess/WebContext.cpp:

(WebKit::createDictionaryFromHashMap):
(WebKit::WebContext::didGetWebCoreStatistics):

Package JavaScript, FastMalloc, icon, font, and glyph page statistics into a StatisticsData object
and send it to the UIProcess.

WebProcess/WebProcess.cpp:

(WebKit::fromCountedSetToHashMap):
(WebKit::WebProcess::getWebCoreStatistics):

7:41 AM Changeset in webkit [94297] by loki@webkit.org

2 edits in trunk/LayoutTests

Unreviewed Qt gardening.
https://bugs.webkit.org/show_bug.cgi?id=67392

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-01

platform/qt-wk2/Skipped:

7:22 AM Changeset in webkit [94296] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Decode query/form parameters names as well as values.
https://bugs.webkit.org/show_bug.cgi?id=67393

Reviewed by Yury Semikhatsky.

inspector/front-end/ResourceHeadersView.js:

(WebInspector.ResourceHeadersView.prototype._decodeURIComponent):
(WebInspector.ResourceHeadersView.prototype._refreshParms):

7:22 AM Changeset in webkit [94295] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, skip 2 GTK a11y failing tests.

platform/gtk/Skipped:

7:20 AM Changeset in webkit [94294] by podivilov@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: remove PresentationBreakpoint class.
https://bugs.webkit.org/show_bug.cgi?id=67275

Reviewed by Yury Semikhatsky.

inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint.didRequestContent):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint):

inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):

7:09 AM Changeset in webkit [94293] by Philippe Normand

1 edit
18 adds in trunk/LayoutTests

Unreviewed, GTK baselines for new tests.

platform/gtk/fast/borders/border-fit-2-expected.png: Added.
platform/gtk/fast/borders/border-fit-2-expected.txt: Added.
platform/gtk/fast/borders/border-image-source-expected.png: Added.
platform/gtk/fast/borders/border-image-source-expected.txt: Added.
platform/gtk/fast/multicol/overflow-across-columns-expected.png: Added.
platform/gtk/fast/multicol/overflow-across-columns-expected.txt: Added.
platform/gtk/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
platform/gtk/fast/multicol/overflow-across-columns-percent-height-expected.txt: Added.
platform/gtk/fast/multicol/overflow-unsplittable-expected.png: Added.
platform/gtk/fast/multicol/overflow-unsplittable-expected.txt: Added.
platform/gtk/fast/multicol/positive-leading-expected.png: Added.
platform/gtk/fast/multicol/positive-leading-expected.txt: Added.
platform/gtk/fast/table/table-after-child-in-table-expected.png: Added.
platform/gtk/fast/table/table-after-child-in-table-expected.txt: Added.
platform/gtk/fast/text/complex-preferred-logical-widths-expected.png: Added.
platform/gtk/fast/text/complex-preferred-logical-widths-expected.txt: Added.
platform/gtk/fast/text/midword-break-before-surrogate-pair-2-expected.png: Added.
platform/gtk/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Added.

6:06 AM Changeset in webkit [94292] by loki@webkit.org

1 edit
4 adds in trunk/LayoutTests

Unreviewed, rebaseline Qt-specific tests.

platform/qt/fast/borders/border-image-source-expected.png: Added.
platform/qt/fast/borders/border-image-source-expected.txt: Added.
platform/qt/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
platform/qt/fast/multicol/overflow-across-columns-percent-height-expected.txt: Added.

5:46 AM Changeset in webkit [94291] by caryclark@google.com

1 edit
611 adds in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac, next chunk of 800 files)
tables/mozilla/bugs/bug8361 through transitions/svg-text-shadow-transition

platform/chromium-mac/transforms: Added.

(remaining files omitted for brevity)

5:37 AM Changeset in webkit [94290] by steveblock@google.com

7 edits in trunk/Source/WebCore

Clean up all mentions of Android in comments
https://bugs.webkit.org/show_bug.cgi?id=67303

Also removes some superfluous guards and methods added for Android.

Reviewed by Darin Adler.

No new tests, removing dead code only.

WebCorePrefix.h: Chromium uses this file only on Mac, so these Android guards are no longer required.
bindings/v8/NPV8Object.cpp:
bindings/v8/NPV8Object.h: Including npruntime.h for non-Chromium ports was added in http://trac.webkit.org/changeset/53634 for Android. However, this file is included in WebCore.pro, so leaving the guard in place.
bindings/v8/ScriptCachedFrameData.h: This code was added for Android in http://trac.webkit.org/changeset/56716 but is now also used by QT. The comment should have been removed in http://trac.webkit.org/changeset/93573.
dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::isLayoutTimerActive):
(WebCore::Document::minimumLayoutDelay):

dom/Document.h: This method was added for Android in http://trac.webkit.org/changeset/52919 and modified in http://trac.webkit.org/changeset/79775. It is no longer needed.

5:36 AM Changeset in webkit [94289] by loki@webkit.org

2 edits in trunk/LayoutTests

Unreviewed Qt gardening.

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-01

platform/qt-wk2/Skipped:

5:24 AM Changeset in webkit [94288] by Csaba Osztrogonác

4 edits in trunk

[Qt] Build dependency problems
https://bugs.webkit.org/show_bug.cgi?id=38054

Make clean build after the defines are changed.

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-01
Reviewed by Csaba Osztrogonác.

Source/WebCore:

features.pri:

Tools:

Scripts/webkitdirs.pm:

(buildQMakeProject):

5:16 AM Changeset in webkit [94287] by vsevik@chromium.org

7 edits in trunk

Web Inspector: Network error messages in console should link to the respective request in network panel if there is one.
https://bugs.webkit.org/show_bug.cgi?id=65550

Reviewed by Yury Semikhatsky.

Source/WebCore:

inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessage.prototype._formatMessage):

inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkLogView.prototype.searchCanceled):
(WebInspector.NetworkLogView.prototype.revealAndHighlightResource):
(WebInspector.NetworkLogView.prototype._removeAllNodeHighlights):
(WebInspector.NetworkLogView.prototype._highlightNode):
(WebInspector.NetworkPanel.prototype._resourceByAnchor):
(WebInspector.NetworkPanel.prototype.canShowAnchorLocation):
(WebInspector.NetworkPanel.prototype.showAnchorLocation):

inspector/front-end/networkLogView.css:

(.network-log-grid tr.highlighted-row):
(from):
(to):

LayoutTests:

http/tests/inspector/console-resource-errors-expected.txt:
http/tests/inspector/console-xhr-logging-expected.txt:

5:06 AM Changeset in webkit [94286] by caryclark@google.com

1 edit
812 adds in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac, next chunk of 800 files)
svg/svg/text/scaled-font through tables/mozilla/bugs/bug82946-1

platform/chromium-mac/svg/zoom: Added.

(remaining files omitted for brevity)

4:18 AM Changeset in webkit [94285] by xan@webkit.org

2 edits in trunk/Source/WebKit2

2011-09-01 Xan Lopez <xlopez@igalia.com>

[GTK] Add XRender lib dependencies explicitly

Reviewed by Philippe Normand.

This is needed when using the GNU/Gold linker, since we use
XRender directly.

GNUmakefile.am:

3:24 AM Changeset in webkit [94284] by Patrick Gansterer

2 edits in trunk/Source/WebCore

Replace preprocessor statements in DOMWindow.idl with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=65050

Reviewed by Brent Fulgham.

Many attributes use the [Conditional=XXX] syntax already.
Unify the declaration of conditional attributes of DOMWindow
with the corresponding Conditional attribute.
This reduces the need of the preprocessor which is the
the source of much pain on native windows.

page/DOMWindow.idl:

3:22 AM Changeset in webkit [94283] by zherczeg@webkit.org

3 edits in trunk/LayoutTests

Unreviewed, skipping failing tests after r94259.

r94259 fails on Qt and Gtk
https://bugs.webkit.org/show_bug.cgi?id=67383

platform/gtk/Skipped:
platform/qt/Skipped:

2:58 AM Changeset in webkit [94282] by yutak@chromium.org

6 edits in trunk

WebSocket: Fix bufferedAmount after WebSocket is closed
https://bugs.webkit.org/show_bug.cgi?id=67363

Reviewed by Kent Tamura.

Source/WebCore:

Test: http/tests/websocket/tests/hybi/bufferedAmount-after-close.html (updated)

websockets/WebSocket.cpp:

(WebCore::WebSocket::send):
(WebCore::WebSocket::getFramingOverhead):

websockets/WebSocket.h:

LayoutTests:

http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:

Try to send messages having various lengths to make sure we correctly calculate
the framing overhead.

2:40 AM Changeset in webkit [94281] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Define PTHREAD_KEYS_MAX to fix Android port build.
https://bugs.webkit.org/show_bug.cgi?id=67362

Patch by Hao Zheng <zhenghao@chromium.org> on 2011-09-01
Reviewed by Adam Barth.

PTHREAD_KEYS_MAX is not defined in bionic, so explicitly define it.

wtf/ThreadIdentifierDataPthreads.cpp:

1:44 AM Changeset in webkit [94280] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Temporarily skip a test that started failing after r94274.
The failure is tracked by the bug 67377.

platform/mac/Skipped:

12:40 AM Changeset in webkit [94279] by keishi@webkit.org

6 edits in trunk/Source/WebCore

Rename colorSelected to didChooseColor
https://bugs.webkit.org/show_bug.cgi?id=67271

Reviewed by Kent Tamura.

WebCore.exp.in:
html/ColorInputType.cpp:

(WebCore::ColorInputType::didChooseColor): Renamed colorSelected to didChooseColor so it follows common naming practice.

html/ColorInputType.h:
platform/ColorChooser.cpp:

(WebCore::ColorChooser::didChooseColor): Renamed.

platform/ColorChooser.h:

12:27 AM Changeset in webkit [94278] by abarth@webkit.org

2 edits in trunk/Source/WebCore

Attempt to fix Windows build.

platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:

12:00 AM Changeset in webkit [94277] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/chromium

Add pass-throughs for NPObject/v8::Value marshalling to WebBindings
https://bugs.webkit.org/show_bug.cgi?id=67302

Patch by Greg Billock <gbillock@google.com> on 2011-08-31
Reviewed by Darin Fisher.

public/WebBindings.h:
src/WebBindings.cpp:

(WebKit::WebBindings::toNPVariant):
(WebKit::WebBindings::toV8Value):

src/WebSerializedScriptValue.cpp:

(WebKit::WebSerializedScriptValue::serialize):

Aug 31, 2011:

11:29 PM Changeset in webkit [94276] by levin@chromium.org

1 edit
2 adds in trunk/LayoutTests

[chromium] Add baseline due to r94258.

platform/chromium-linux/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt: Added.

11:23 PM Changeset in webkit [94275] by abarth@webkit.org

62 edits
3 moves
1 add
1 delete in trunk/Source

[Chromium] Rename PlatformBridge to PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=67349

Reviewed by Darin Fisher.

This matches the WebKitPlatformSupport embedder API.

Source/WebCore:

WebCore.gypi:
WebCore.pro:
bindings/v8/NPV8Object.cpp:

(_NPN_Evaluate):

bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::createScriptInstanceForWidget):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::reportFatalErrorInV8):

bindings/v8/V8GCController.cpp:
bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::handleOutOfMemory):
(WebCore::V8Proxy::evaluate):

bindings/v8/V8Proxy.h:
bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::histogramEnumeration):

page/PageGroup.cpp:

(WebCore::PageGroup::isLinkVisited):

platform/audio/chromium/AudioBusChromium.cpp:

(WebCore::AudioBus::loadPlatformResource):
(WebCore::createBusFromInMemoryAudioFile):

platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::getSequenceNumber):
(WebCore::ChromiumDataObject::containsFilenames):

platform/chromium/DataTransferItemChromium.cpp:

(WebCore::DataTransferItemChromium::getAsString):
(WebCore::DataTransferItemChromium::getAsFile):

platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::asURL):

platform/chromium/FileSystemChromium.cpp:

(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::revealFolderInOS):
(WebCore::directoryName):
(WebCore::pathByAppendingComponent):
(WebCore::makeAllDirectories):
(WebCore::fileExists):
(WebCore::openFile):
(WebCore::closeFile):
(WebCore::seekFile):
(WebCore::truncateFile):
(WebCore::readFromFile):
(WebCore::writeToFile):

platform/chromium/LanguageChromium.cpp:

(WebCore::platformDefaultLanguage):

platform/chromium/LinkHashChromium.cpp:

(WebCore::visitedLinkHash):

platform/chromium/MIMETypeRegistryChromium.cpp:

(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
(WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
(WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):

platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::writeURL):
(WebCore::Pasteboard::writeImage):
(WebCore::Pasteboard::canSmartReplace):
(WebCore::Pasteboard::plainText):
(WebCore::Pasteboard::documentFragment):

platform/chromium/PlatformBridge.h: Removed.
platform/chromium/PlatformScreenChromium.cpp:

(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):

platform/chromium/PlatformSupport.h: Copied from Source/WebCore/platform/chromium/PlatformBridge.h.
platform/chromium/SSLKeyGeneratorChromium.cpp:

(WebCore::signedPublicKeyAndChallengeString):

platform/chromium/ScrollbarThemeChromium.cpp:
platform/chromium/ScrollbarThemeChromiumLinux.cpp:

(WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumLinux::paintButton):
(WebCore::ScrollbarThemeChromiumLinux::paintThumb):
(WebCore::ScrollbarThemeChromiumLinux::buttonSize):
(WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):

platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paint):

platform/chromium/ScrollbarThemeChromiumWin.cpp:

(WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumWin::paintButton):
(WebCore::ScrollbarThemeChromiumWin::paintThumb):
(WebCore::ScrollbarThemeChromiumWin::buttonSize):

platform/chromium/SharedTimerChromium.cpp:

(WebCore::setSharedTimerFiredFunction):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):

platform/chromium/SuddenTerminationChromium.cpp:

(WebCore::disableSuddenTermination):
(WebCore::enableSuddenTermination):

platform/chromium/TraceEvent.h:

(WebCore::internal::ScopeTracer::ScopeTracer):
(WebCore::internal::ScopeTracer::~ScopeTracer):

platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerPainter::paint):

platform/graphics/chromium/CrossProcessFontLoading.mm:
platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::fontContainsCharacter):
(WebCore::FillLogFont):

platform/graphics/chromium/FontCacheLinux.cpp:

(WebCore::FontCache::getFontDataForCharacters):

platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::drawGlyphsWin):

platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:

(WebCore::FontPlatformData::scriptFontProperties):

platform/graphics/chromium/FontPlatformDataLinux.cpp:

(WebCore::FontPlatformData::querySystemForRenderStyle):

platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:

(WebCore::fillBMPGlyphs):

platform/graphics/chromium/ImageChromium.cpp:

(WebCore::Image::loadPlatformResource):

platform/graphics/chromium/ImageChromiumMac.mm:

(WebCore::Image::loadPlatformResource):

platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformWidthForGlyph):

platform/graphics/chromium/UniscribeHelperTextRun.cpp:

(WebCore::UniscribeHelperTextRun::tryToPreloadFont):

platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

platform/network/chromium/CookieJarChromium.cpp:

(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):

platform/network/chromium/DNSChromium.cpp:

(WebCore::prefetchDNS):

platform/qt/PlatformBridge.h: Removed.
platform/qt/PlatformBridgeQt.cpp: Removed.
platform/qt/PlatformSupport.h: Copied from Source/WebCore/platform/qt/PlatformBridge.h.
platform/qt/PlatformSupportQt.cpp: Copied from Source/WebCore/platform/qt/PlatformBridgeQt.cpp.

(WebCore::PlatformSupport::popupsAllowed):
(WebCore::PlatformSupport::pluginScriptableObject):

platform/sql/chromium/SQLiteFileSystemChromium.cpp:

(WebCore::SQLiteFileSystem::deleteDatabaseFile):
(WebCore::SQLiteFileSystem::getDatabaseFileSize):

platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
plugins/chromium/PluginDataChromium.cpp:

(WebCore::PluginCache::plugins):

rendering/RenderThemeChromiumLinux.cpp:

(WebCore::getWebThemeState):
(WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
(WebCore::RenderThemeChromiumLinux::paintCheckbox):
(WebCore::RenderThemeChromiumLinux::setCheckboxSize):
(WebCore::RenderThemeChromiumLinux::paintRadio):
(WebCore::RenderThemeChromiumLinux::setRadioSize):
(WebCore::RenderThemeChromiumLinux::paintButton):
(WebCore::RenderThemeChromiumLinux::paintTextField):
(WebCore::RenderThemeChromiumLinux::paintMenuList):
(WebCore::RenderThemeChromiumLinux::paintSliderTrack):
(WebCore::RenderThemeChromiumLinux::paintSliderThumb):
(WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumLinux::paintInnerSpinButton):
(WebCore::RenderThemeChromiumLinux::paintProgressBar):

rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):

rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::caretBlinkInterval):

rendering/RenderThemeChromiumWin.cpp:

(WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeChromiumWin::systemColor):
(WebCore::RenderThemeChromiumWin::paintButton):
(WebCore::RenderThemeChromiumWin::paintSliderTrack):
(WebCore::menuListButtonWidth):
(WebCore::RenderThemeChromiumWin::paintMenuList):
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
(WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
(WebCore::RenderThemeChromiumWin::paintProgressBar):

storage/chromium/IDBFactoryBackendInterface.cpp:

(WebCore::IDBFactoryBackendInterface::create):

storage/chromium/IDBKeyPathBackendImpl.cpp:

(WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
(WebCore::IDBKeyPathBackendImpl::injectIDBKeyIntoSerializedValue):

storage/chromium/QuotaTracker.cpp:

(WebCore::QuotaTracker::getDatabaseSizeAndSpaceAvailableToOrigin):

Source/WebKit/chromium:

WebKit.gyp:
src/AssertMatchingEnums.cpp:
src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::shouldRunModalDialogDuringPageDismissal):

src/PlatformBridge.cpp: Removed.
src/ResourceHandle.cpp:

(WebCore::ResourceHandle::cacheMetadata):

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::WebFrameImpl):
(WebKit::WebFrameImpl::~WebFrameImpl):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::paint):
(WebKit::WebViewImplContentPainter::paint):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

11:11 PM Changeset in webkit [94274] by rniwa@webkit.org

10 edits
4 adds in trunk

Crash when inserting text with a trailing newline into a textarea via JS
https://bugs.webkit.org/show_bug.cgi?id=66241

Reviewed by Darin Adler and Kent Tamura.

Source/WebCore:

The crash was caused by updateFromElement biting on the editing code.

When there is a style rule that applies on text nodes inside the shadow DOM, DOM modifications made
by the editing code may trigger style recalculation on input or textarea elements in the midst of editing
commands. In response to this style recalculation, HTMLInputElement::updateFromElement and
HTMLTextAreaElement::updateFromElement call setInnerTextValue to re-create the text nodes in the
shadow DOM. The editing code blows up because setInnerTextValue detaches old text nodes referenced by
Positions and VisiblePositions held by the editing commands in progress.

Fixed the crash by stop calling setInnerTextValue in updateFromElement. Instead, WebKit now creates
the text nodes when attributes, descendent nodes, etc... of input or textarea element changes.

Tests: fast/forms/update-from-element-during-editing-crash-1.html

fast/forms/update-from-element-during-editing-crash-2.html

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType): Force calling setInnerTextValue when input type changes.
(WebCore::HTMLInputElement::updateInnerTextValue): Extracted from RenderTextControlSingleLine's
updateElement.
(WebCore::HTMLInputElement::parseMappedAttribute): Calls updateInnerTextValue; force calling
setInnerTextValue when -webkit-speech attribute changes. In the theory, we should be able to call it less
frequently but there are too many cases to consider at the moment.
(WebCore::HTMLInputElement::setValue): Calls updateInnerTextValue when the value actually changed.
Note we need to call it before we set or restore selection.

html/HTMLInputElement.h:
html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::childrenChanged): Calls updateInnerTextValue when textarea's descendants
nodes are changed by parser or scripts.
(WebCore::HTMLTextAreaElement::setValueCommon): Calls updateInnerTextValue when the value changes.

html/HTMLTextFormControlElement.h:
html/NumberInputType.cpp:

(WebCore::NumberInputType::willBlur): Calls updateInnerTextValue because input[type=number] forces
the value to be valid on blur.

rendering/RenderTextControlMultiLine.cpp: Removed RenderTextControlMultiLine::updateFromElement.
rendering/RenderTextControlMultiLine.h: Ditto.
rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::updateFromElement):

LayoutTests:

Add regressions tests to ensure WebKit doesn't crash even when style recalc happens
in the midst of editing commands.

fast/forms/update-from-element-during-editing-crash-1-expected.txt: Added.
fast/forms/update-from-element-during-editing-crash-1.html: Added.
fast/forms/update-from-element-during-editing-crash-2-expected.txt: Added.
fast/forms/update-from-element-during-editing-crash-2.html: Added.

11:07 PM Changeset in webkit [94273] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix snow-leopard regression caused by r93982
https://bugs.webkit.org/show_bug.cgi?id=67301

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-31
Reviewed by Kenneth Russell.

Test: canvas/philip/tests/2d.path.stroke.prune.arc.html

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::arc):

10:56 PM Changeset in webkit [94272] by levin@chromium.org

2 edits
3 adds in trunk/LayoutTests

[chromium] Add baselines due to r94253 and r94258.

platform/chromium-cg-mac-leopard/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
platform/chromium-win/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt: Added.
platform/chromium/test_expectations.txt:

10:47 PM Changeset in webkit [94271] by tkent@chromium.org

1 edit in branches/chromium/835/Source/WebCore/css/html.css

Merge 94268 - REGRESSION(r88115): "Choose File" button doesn't respect font-size property for the <input>
https://bugs.webkit.org/show_bug.cgi?id=67181

Reviewed by Dimitri Glazkov.

Source/WebCore:

r88115 removed the code to make inherited style of the owner input
element, and html.css contains "font: -webkit-small-control" for
input element. So -webkit-file-upload-button always had
-webkit-small-control font.

Test: fast/forms/file/file-style-inheritance.html

css/html.css:

(input[type="file"]::-webkit-file-upload-button):
Specify font-size:inherit explicitly.

LayoutTests:

fast/forms/file/file-style-inheritance-expected.txt: Added.
fast/forms/file/file-style-inheritance.html: Added.

TBR=tkent@chromium.org
BUG=94602
Review URL: http://codereview.chromium.org/7828001

10:33 PM Changeset in webkit [94270] by keishi@webkit.org

7 edits in trunk/Source/WebCore

Rename closeColorChooser to cleanupColorChooser
https://bugs.webkit.org/show_bug.cgi?id=67270

Reviewed by Kent Tamura.

html/ColorInputType.cpp:

(WebCore::ColorInputType::~ColorInputType):
(WebCore::ColorInputType::detach):
(WebCore::ColorInputType::cleanupColorChooserIfCurrentClient): NSColorPanel shouldn't be closed but the color
chooser listeners need to be taken care of. Therefore closeColorChooser will be renamed to cleanupColorChooser.
This will close the color chooser on platforms where appropriate.

html/ColorInputType.h:
loader/EmptyClients.h:

(WebCore::EmptyChromeClient::cleanupColorChooser): Rename.

page/Chrome.cpp:

(WebCore::Chrome::cleanupColorChooser): Rename.

page/Chrome.h:
page/ChromeClient.h:

8:23 PM Changeset in webkit [94269] by levin@chromium.org

1 edit
4 adds in trunk/LayoutTests

[chromium] Add baselines for test added by r94253.

platform/chromium-cg-mac/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
platform/chromium-linux/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
platform/chromium-win/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
platform/chromium-win/fast/multicol/overflow-across-columns-percent-height-expected.txt: Added.

7:40 PM Changeset in webkit [94268] by tkent@chromium.org

3 edits
2 adds in trunk

REGRESSION(r88115): "Choose File" button doesn't respect font-size property for the <input>
https://bugs.webkit.org/show_bug.cgi?id=67181

Reviewed by Dimitri Glazkov.

Source/WebCore:

Test: fast/forms/file/file-style-inheritance.html

css/html.css:

(input[type="file"]::-webkit-file-upload-button):
Specify font-size:inherit explicitly.

LayoutTests:

fast/forms/file/file-style-inheritance-expected.txt: Added.
fast/forms/file/file-style-inheritance.html: Added.

7:28 PM Changeset in webkit [94267] by crogers@google.com

1 edit in branches/chromium/835/Source/WebCore/webaudio/AudioNode.cpp

Merge 94262 - Add defensive bounds checking for AudioNode methods
https://bugs.webkit.org/show_bug.cgi?id=67346

BUG=95012
Review URL: http://codereview.chromium.org/7821023

7:24 PM Changeset in webkit [94266] by crogers@google.com

1 edit in branches/chromium/835/Source/WebCore/webaudio/AudioBufferSourceNode.cpp

Merge 94265 - Do more rigorous bounds checking in AudioBufferSourceNode::renderFromBuffer()
https://bugs.webkit.org/show_bug.cgi?id=67351

TBR=crogers@google.com
Review URL: http://codereview.chromium.org/7756026

7:08 PM Changeset in webkit [94265] by crogers@google.com

2 edits in trunk/Source/WebCore

Do more rigorous bounds checking in AudioBufferSourceNode::renderFromBuffer()
https://bugs.webkit.org/show_bug.cgi?id=67351

Reviewed by Dirk Pranke.

No new tests since this does not change JavaScript API.

webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::renderFromBuffer):

6:56 PM Changeset in webkit [94264] by keishi@webkit.org

4 edits in trunk/Source/WebCore

Remove closeColorChooser call from FrameLoader::transitionToCommitted
https://bugs.webkit.org/show_bug.cgi?id=67267

Reviewed by Darin Adler.

html/ColorInputType.cpp:

(WebCore::ColorInputType::closeColorChooserIfCurrentClient): Moved order to match header.

html/ColorInputType.h:
loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted): Remove ColorInputType::closeColorChooserIfCurrentClient call.
It wasn't the right place to directly manipulate the UI.

6:46 PM Changeset in webkit [94263] by abarth@webkit.org

3 edits in trunk/Tools

Move DumpRenderTree to WebKitPlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=67331

Reviewed by Darin Fisher.

This patch update DumpRenderTree to account for the WebKitClient =>
WebKitPlatformSupport rename.

DumpRenderTree/chromium/NotificationPresenter.cpp:

(NotificationPresenter::show):

DumpRenderTree/chromium/Task.cpp:

(postTask):

6:43 PM Changeset in webkit [94262] by crogers@google.com

2 edits in trunk/Source/WebCore

Add defensive bounds checking for AudioNode methods
https://bugs.webkit.org/show_bug.cgi?id=67346

Reviewed by Anders Carlsson.

No new tests since this does not change JavaScript API.

webaudio/AudioNode.cpp:

(WebCore::AudioNode::input):
(WebCore::AudioNode::output):

6:31 PM Changeset in webkit [94261] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/chromium

Chromium Mac: PDF: Scrollsbars should be visible when scrolling using the two finger gesture on Lion
https://bugs.webkit.org/show_bug.cgi?id=66599

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-31
Reviewed by Darin Fisher.

Overlay scrollbars over a pdf wouldn't stay visible if a gesture was in progress. Normally we use a beginScrollGesture and endScrollGesture to keep the scrollbars visible. Unfortunately PDFs didn't handle gesture events so we didn't get the begin/end gesture events.

This change pipes gesture events to WebPluginContainerImpl if possible. This fixes this bug.

src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::handleGestureEvent):

src/WebPluginContainerImpl.h:
src/WebViewImpl.cpp:

(WebKit::WebViewImpl::gestureEvent):

6:22 PM Changeset in webkit [94260] by arv@chromium.org

3 edits in trunk/LayoutTests

shouldBeEqualToString should encode special characters
https://bugs.webkit.org/show_bug.cgi?id=67223

Reviewed by Darin Adler.

fast/js/resources/standalone-pre.js:

(shouldBeEqualToString): Encode \, ", \n, \r

http/tests/cookies/resources/cookies-test-pre.js:

(shouldBeEqualToString): Encode \, ", \n, \r

6:20 PM Changeset in webkit [94259] by Simon Fraser

5 edits in trunk/Source/WebCore

TransformState.move() should be negated in the unapply code path
https://bugs.webkit.org/show_bug.cgi?id=66246

Reviewed by Chris Marrin.

Code using TransformState was confused about when to negate the arguments
to move() in the "UnapplyInverseTransform" direction (used by mapAbsoluteToLocal).

Made the move() path equivalent to the applyTransform() path by not requiring
the caller to negate, and instead negating inside move().

Fixed the erroneous negation in TransformState::move() when accumulating;
that negation will happen later via matrix inversion.

No behavior change.

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::recursiveCommitChanges):

platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::move):

rendering/RenderBox.cpp:

(WebCore::RenderBox::mapAbsoluteToLocalPoint):

rendering/RenderInline.cpp:

(WebCore::RenderInline::mapAbsoluteToLocalPoint):

6:11 PM Changeset in webkit [94258] by inferno@chromium.org

1 edit
2 copies
3 moves
1 add in trunk/LayoutTests

Add test for testing non-existent eventsource and
fix typo in previous test.
https://bugs.webkit.org/show_bug.cgi?id=49448

Reviewed by Alexey Proskuryakov.

http/tests/eventsource/eventsource-status-error-iframe-crash-expected.txt: Removed.
http/tests/eventsource/eventsource-status-error-iframe-crash.html: Removed.
http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt: Copied from LayoutTests/http/tests/eventsource/eventsource-status-error-iframe-crash-expected.txt.
http/tests/eventsource/existent-eventsource-status-error-iframe-crash.html: Copied from LayoutTests/http/tests/eventsource/eventsource-status-error-iframe-crash.html.
http/tests/eventsource/non-existent-eventsource-status-error-iframe-crash-expected.txt: Added.
http/tests/eventsource/non-existent-eventsource-status-error-iframe-crash.html: Added.
http/tests/eventsource/resources/request-existent-eventsource-error.html: Copied from LayoutTests/http/tests/eventsource/resources/request-status-error.htm.
http/tests/eventsource/resources/request-non-existent-eventsource-error.html: Added.
http/tests/eventsource/resources/request-status-error.htm: Removed.

5:36 PM Changeset in webkit [94257] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Jagged text shown in find-in-page highlight
https://bugs.webkit.org/show_bug.cgi?id=67347
<rdar://problem/9870444>

Reviewed by Dan Bernstein.

When painting each text line in the find indicator, make sure to clip it against
the text rect and not paint the entire rect over and over.

UIProcess/FindIndicator.cpp:

(WebKit::FindIndicator::draw):

5:28 PM Changeset in webkit [94256] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix build.

5:26 PM Changeset in webkit [94255] by psolanki@apple.com

3 edits in trunk/Source/WebCore

Fix compile issues when enabling HAVE(CFNETWORK_DATA_ARRAY_CALLBACK)
https://bugs.webkit.org/show_bug.cgi?id=67332

Reviewed by Darin Adler.

loader/mac/ResourceLoaderMac.mm:

(WebCore::ResourceLoader::didReceiveDataArray):

platform/network/cf/ResourceHandleCFNet.cpp:

5:21 PM Changeset in webkit [94254] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

fast/regex/overflow.html asserts in debug builds
https://bugs.webkit.org/show_bug.cgi?id=67326

Reviewed by Gavin Barraclough.

The deliberate overflows in these expressions don't interact nicely
with Checked<32bit-type> so we just bump up to Checked<int64_t> for the
intermediate calculations.

yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):

5:14 PM Changeset in webkit [94253] by mitz@apple.com

3 edits
3 adds in trunk

Source/WebCore: Refined the heuristic introduced to fix <rdar://problem/10002140> Text gets clipped in
multi-column layouts when overflow:auto is used.
https://bugs.webkit.org/show_bug.cgi?id=67212

Reviewed by Dave Hyatt.

Test: fast/multicol/overflow-across-columns-percent-height.html

rendering/RenderBox.cpp:

(WebCore::percentageLogicalHeightIsResolvable): Added. This follows logic similar to the one
in computePercentageLogicalHeight() to determine whether percentage values for height properties
are resolved or treated as "auto".
(WebCore::RenderBox::hasUnsplittableScrollingOverflow): If min-height or max-height are specified
as a percentage but actually resolve to "auto", don’t let that prevent splitting.

LayoutTests: Additional test for <rdar://problem/10002140> Text gets clipped in
multi-column layouts when overflow:auto is used.
https://bugs.webkit.org/show_bug.cgi?id=67212

Reviewed by Dave Hyatt.

fast/multicol/overflow-across-columns-percent-height.html: Added.
platform/mac/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
platform/mac/fast/multicol/overflow-across-columns-percent-height-expected.txt: Added.

5:00 PM Changeset in webkit [94252] by rniwa@webkit.org

13 edits in trunk/Source

Move text() and textWithHardLineBreaks() from RenderTextControl to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=67320

Reviewed by Darin Adler.

Source/WebCore:

Moved and renamed RenderText::text and RenderText::textWithHardLineBreaks to
HTMLTextFormControlElement::innerTextValue and HTMLTextFormControlElement::valueWithHardLineBreaks.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::text):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::subtreeHasChanged):

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::appendFormData): Calls valueWithHardLineBreaks. It doesn't have to check
the existence of renderer anymore because valueWithHardLineBreaks returns value() when renderer do not
exist unlike RenderText::textWithHardLineBreaks returned emptyString() in such cases. This is the only place
valueWithHardLineBreaks is ever called; but we can't move valueWithHardLineBreaks because it calls
finishText.
(WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
(WebCore::HTMLTextAreaElement::updateValue):

html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::selectedText):
(WebCore::HTMLTextFormControlElement::setInnerTextValue):
(WebCore::finishText): Moved from RenderText.cpp
(WebCore::HTMLTextFormControlElement::innerTextValue): Ditto.
(WebCore::getNextSoftBreak): Ditto.
(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks): Ditto; this function returns value()
when there are no renderers or root inline boxes instead of emptyString().

html/HTMLTextFormControlElement.h:
html/NumberInputType.cpp:

(WebCore::NumberInputType::hasUnacceptableValue):

html/SearchInputType.cpp:

(WebCore::SearchInputType::startSearchEventTimer):

html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):

rendering/RenderTextControl.cpp:
rendering/RenderTextControl.h:

Source/WebKit/qt:

Call HTMLTextFormControlElement::value() instead of RenderText::text()

Api/qwebpage.cpp:

(QWebPage::inputMethodQuery):

4:55 PM Changeset in webkit [94251] by jeffm@apple.com

4 edits in trunk/Source

Source/JavaScriptCore: REGRESSION(92210): AVFoundation media engine is disabled on OS X
https://bugs.webkit.org/show_bug.cgi?id=67316

Move the definition of WTF_USE_AVFOUNDATION on the Mac back to JavaScriptCore/wtf/Platform.h,
since WebKit2 doesn't have access to WebCore/config.h on this platform. This reverts the
changes that were made in r92210.

Reviewed by Darin Adler.

wtf/Platform.h: Added definition of WTF_USE_AVFOUNDATION on the Mac.

Source/WebCore: REGRESSION(92210): AVFoundation media engine is disabled on OS X
https://bugs.webkit.org/show_bug.cgi?id=67316

Move the definition of WTF_USE_AVFOUNDATION on the Mac back to JavaScriptCore/wtf/Platform.h,
since WebKit2 doesn't have access to WebCore/config.h on this platform. This reverts the
changes that were made in r92210.

Reviewed by Darin Adler.

No new tests, covered by existing media tests.

config.h: Removed definition of WTF_USE_AVFOUNDATION on the Mac, add a comment about fixing this on Windows in the future.

4:54 PM Changeset in webkit [94250] by ojan@chromium.org

2 edits in trunk/LayoutTests

fix bug in flexbox test with offsetWidth/offsetLeft of 0
https://bugs.webkit.org/show_bug.cgi?id=67330

Reviewed by Tony Chang.

css3/flexbox/resources/flexbox.js:

4:54 PM Changeset in webkit [94249] by Lucas Forschler

5 edits in branches/safari-534.51-branch/Source

Versioning.

4:52 PM Changeset in webkit [94248] by Lucas Forschler

1 copy in tags/Safari-534.51.19

New tag.

4:32 PM Changeset in webkit [94247] by Beth Dakin

10 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=67322
Re-name overrideBackingScaleFactor

Reviewed by John Sullivan.

Source/WebKit/mac:

_setOverrideBackingScaleFactor is now _setCustomBackingScaleFactor

WebView/WebView.mm:

(-[WebView _setCustomBackingScaleFactor:]):
(-[WebView _deviceScaleFactor]):

WebView/WebViewData.h:
WebView/WebViewPrivate.h:

Source/WebKit2:

API is now WKPageSetCustomBackingScaleFactor() and WKPageGetBackingScaleFactor()
which returns the custom scale factor if one was set, and the intrinsic scale
factor otherwise.

UIProcess/API/C/WKPage.cpp:

(WKPageGetBackingScaleFactor):
(WKPageSetCustomBackingScaleFactor):

UIProcess/API/C/WKPage.h:

Re-named _deviceScaleFactor to _intrinsicDeviceScaleFactor since it only ever
refers to the intrinsic value.

UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidChangeResolution:]):
(-[WKView _intrinsicDeviceScaleFactor]):

WebPageProxy stores both the customDeviceScaleFactor and the
intrinsicDeviceScaleFactor. deviceScaleFactor() returns the appropriate value that
should be the one used.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setIntrinsicDeviceScaleFactor):
(WebKit::WebPageProxy::deviceScaleFactor):
(WebKit::WebPageProxy::setCustomDeviceScaleFactor):
(WebKit::WebPageProxy::creationParameters):

UIProcess/WebPageProxy.h:

4:16 PM Changeset in webkit [94246] by andersca@apple.com

3 edits in trunk/Source/WebKit2

REGRESSION(r93902): Can't open external links on gmail
https://bugs.webkit.org/show_bug.cgi?id=67234
<rdar://problem/10053636>

Reviewed by Alexey Proskuryakov.

Shared/cf/ArgumentCodersCF.cpp:

(CoreIPC::decode):
If we encounter an empty URL string, create an empty url by using NSURL, just
like we do in WebCore when converting an empty KURL to an NSURL.

WebKit2.xcodeproj/project.pbxproj:

Compile ArgumentCodersCF.cpp as Objective-C++ for now.

4:14 PM Changeset in webkit [94245] by imasaki@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Update a bug number in test expectation file and skip
media-document-audio-repaint.html for GPU due to an unimplented
feature.
https://bugs.webkit.org/show_bug.cgi?id=67328

Reviewed by Adam Barth.

platform/chromium/test_expectations.txt:

4:12 PM Changeset in webkit [94244] by levin@chromium.org

1 edit
14 moves
42 adds in trunk/LayoutTests

[chromium] Test expectation updates due to r94211.

platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-001-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-002-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-003-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-004-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-005-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-006-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-007-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-008-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-009-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-010-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-012-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-013-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-014-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/margin-applies-to-015-expected.png: Added.
platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-001-expected.png: Added.
platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-002-expected.png: Added.
platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-003-expected.png: Added.
platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-004-expected.png: Added.
platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-005-expected.png: Added.
platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-006-expected.png: Added.
platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-007-expected.png: Added.
platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-008-expected.png: Added.
platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-009-expected.png: Added.
platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-010-expected.png: Added.
platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-012-expected.png: Added.
platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-013-expected.png: Added.
platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-014-expected.png: Added.
platform/chromium-cg-mac/css2.1/20110323/margin-applies-to-015-expected.png: Added.
platform/chromium-win/css2.1/20110323/margin-applies-to-001-expected.png: Added.
platform/chromium-win/css2.1/20110323/margin-applies-to-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-001-expected.txt.
platform/chromium-win/css2.1/20110323/margin-applies-to-002-expected.png: Added.
platform/chromium-win/css2.1/20110323/margin-applies-to-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-002-expected.txt.
platform/chromium-win/css2.1/20110323/margin-applies-to-003-expected.png: Added.
platform/chromium-win/css2.1/20110323/margin-applies-to-003-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-003-expected.txt.
platform/chromium-win/css2.1/20110323/margin-applies-to-004-expected.png: Added.
platform/chromium-win/css2.1/20110323/margin-applies-to-004-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-004-expected.txt.
platform/chromium-win/css2.1/20110323/margin-applies-to-005-expected.png: Added.
platform/chromium-win/css2.1/20110323/margin-applies-to-005-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-005-expected.txt.
platform/chromium-win/css2.1/20110323/margin-applies-to-006-expected.png: Added.
platform/chromium-win/css2.1/20110323/margin-applies-to-006-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-006-expected.txt.
platform/chromium-win/css2.1/20110323/margin-applies-to-007-expected.png: Added.
platform/chromium-win/css2.1/20110323/margin-applies-to-007-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-007-expected.txt.
platform/chromium-win/css2.1/20110323/margin-applies-to-008-expected.png: Added.
platform/chromium-win/css2.1/20110323/margin-applies-to-008-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-008-expected.txt.
platform/chromium-win/css2.1/20110323/margin-applies-to-009-expected.png: Added.
platform/chromium-win/css2.1/20110323/margin-applies-to-009-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-009-expected.txt.
platform/chromium-win/css2.1/20110323/margin-applies-to-010-expected.png: Added.
platform/chromium-win/css2.1/20110323/margin-applies-to-010-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-010-expected.txt.
platform/chromium-win/css2.1/20110323/margin-applies-to-012-expected.png: Added.
platform/chromium-win/css2.1/20110323/margin-applies-to-012-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-012-expected.txt.
platform/chromium-win/css2.1/20110323/margin-applies-to-013-expected.png: Added.
platform/chromium-win/css2.1/20110323/margin-applies-to-013-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-013-expected.txt.
platform/chromium-win/css2.1/20110323/margin-applies-to-014-expected.png: Added.
platform/chromium-win/css2.1/20110323/margin-applies-to-014-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-014-expected.txt.
platform/chromium-win/css2.1/20110323/margin-applies-to-015-expected.png: Added.
platform/chromium-win/css2.1/20110323/margin-applies-to-015-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/margin-applies-to-015-expected.txt.

4:06 PM Changeset in webkit [94243] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Chromium] Switching between overlay and opaque scrollbars causes glitches
https://bugs.webkit.org/show_bug.cgi?id=62686

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-31
Reviewed by Beth Dakin.

When switching from opaque scrollbars to overlay scrollbars the page content size wouldn't change leaving a empty region under the overlay scrollbar.

The problem was that we were relying on ScrollView::updateScrollbars() to kick off a layout. Unfortunately this doesn't happen because updateScrollbars doesn't distinguish between overlay and opaque scrollbars.

To fix this I'm explicitly invalidating the layout when ScrollView::scrollbarStyleChanged() is called.

No tests because there are no Mac 10.7 chromium bots yet. Bug 66504 will track the work to add these tests once the bots are in place.

platform/ScrollView.cpp:

(WebCore::ScrollView::scrollbarStyleChanged):

4:01 PM Changeset in webkit [94242] by ap@apple.com

6 edits in trunk

http/tests/eventsource/workers/eventsource-simple.html is a flaky crash because of
eventsource-status-error-iframe-crash.html
https://bugs.webkit.org/show_bug.cgi?id=61523

Reviewed by Nate Chapin.

Source/WebCore:

The problem here was that canceling EventSource during frame removal erroneously resulted
in event dispatch, and event handler re-entered frame destruction code.

page/EventSource.h: Renamed endRequest() to networkRequestEnded(), because this method

doesn't end request. It implements "reestablish the connection" or "fail the connection"
algotithms from the spec, depending on current state.
Removed m_failSilently, since we can make this decision with existing data, and want to
fail silently by default (e.g. when detaching a frame cancels all loads).

page/EventSource.cpp:

(WebCore::EventSource::EventSource): Don't initialize m_failSilently.
(WebCore::EventSource::~EventSource): Assert taht we are in a correct state.
(WebCore::EventSource::connect): Ditto.
(WebCore::EventSource::networkRequestEnded): Moved errorevent dispatch elsewhere.
(WebCore::EventSource::scheduleReconnect): Error event should always be queued when
reconnecting; firing it synchronously after starting m_reconnectTimer implements that.
(WebCore::EventSource::reconnectTimerFired): Assert that state is correct (the timer is
stopped if EventSource is stopped while waiting on the timer).
(WebCore::EventSource::close): Don't set m_state before calling cancel() - it will indirectly
call didFail(), which asserts that EventSource is not stopped yet.
(WebCore::EventSource::didReceiveResponse): Explicitly dispatch an error event, since it
is no longer dispatched when canceling, and canceling is the only way to stop a ThreadableLoader.
Removed a special case for 2xx responses, since it's no longer in the spec.
(WebCore::EventSource::didReceiveData): Assert that state is correct.
(WebCore::EventSource::didFinishLoading): Don't set state to CONNECTING after parsing remaining
response bytes - that may well result in dispatching an event whose handler calls close().
(WebCore::EventSource::didFail): It's simple now - we always reconnect unless the request
got canceled.
(WebCore::EventSource::didFailRedirectCheck): Dispatch error event explicitly, as we are
not going to attempt reconnecting.

LayoutTests:

http/tests/eventsource/eventsource-status-code-states-expected.txt:
http/tests/eventsource/eventsource-status-code-states.html:

2xx responses are no longer different from any other failures.

3:44 PM Changeset in webkit [94241] by cevans@google.com

1 edit in branches/chromium/835/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp

Merge 94237
BUG=91197
Review URL: http://codereview.chromium.org/7822005

3:40 PM Changeset in webkit [94240] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit/chromium

Chromium Mac: Add fallback for drawing PDF overhang area
https://bugs.webkit.org/show_bug.cgi?id=66614

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-31
Reviewed by Darin Fisher.

This change adds a fallback for overhang drawing for PDF content. This fallback is needed until the PDF plugin uses the linen pattern to draw its own overhang.

src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::paintCustomOverhangArea):

src/ChromeClientImpl.h:
src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::paintCustomOverhangArea):

src/WebPluginContainerImpl.h:

3:26 PM Changeset in webkit [94239] by levin@chromium.org

1 edit
1 delete in trunk/LayoutTests

[chromium] Fix expectations due to r94213.

platform/chromium-cg-mac/fast/tokenizer/script_extra_close-expected.txt: Removed.

3:20 PM Changeset in webkit [94238] by levin@chromium.org

3 edits in trunk/LayoutTests

empty-urls.html is non-deterministic.
https://bugs.webkit.org/show_bug.cgi?id=67327

Reviewed by Adam Barth.

http/tests/loading/empty-urls-expected.txt:
http/tests/loading/empty-urls.html: Ensure the ordering of the pass messages and remove the loader events which also seem to produce non-deterministic results.

2:51 PM Changeset in webkit [94237] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Have the FrameLoaderClient release any plugin widget
reference is holding when the FrameLoader detaches it, to ensure that
the plugin won't out-live the containing page.
https://bugs.webkit.org/show_bug.cgi?id=66517

Patch by James Weatherall <wez@chromium.org> on 2011-08-31
Reviewed by Darin Fisher.

src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::detachedFromParent3):

2:51 PM Changeset in webkit [94236] by commit-queue@webkit.org

4 edits
2 deletes in trunk

Unreviewed, rolling out r94116.
http://trac.webkit.org/changeset/94116
https://bugs.webkit.org/show_bug.cgi?id=67323

caused a lot of tests failures (Requested by thorton on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-31

Source/WebCore:

platform/graphics/cg/PathCG.cpp:

(WebCore::Path::boundingRect):

LayoutTests:

platform/chromium/test_expectations.txt:
svg/custom/getBBox-path-expected.txt: Removed.
svg/custom/getBBox-path.svg: Removed.

2:48 PM Changeset in webkit [94235] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

Add Android's platform specification and the right atomic functions.
https://bugs.webkit.org/show_bug.cgi?id=66687

Patch by Peter Beverloo <peter@chromium.org> on 2011-08-31
Reviewed by Adam Barth.

wtf/Atomics.h:

(WTF::atomicIncrement):
(WTF::atomicDecrement):

wtf/Platform.h:

2:24 PM Changeset in webkit [94234] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Chromium Mac: Tweak rubber banding overhang shadows. Add a drop shadow from the browser's toolbar.
https://bugs.webkit.org/show_bug.cgi?id=67289

Chromium bug: http://crbug.com/93228

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-31
Reviewed by Dimitri Glazkov.

No new tests, since this merely tweaks Chromium overhang area appearance.

platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::paintGivenTickmarks):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

2:19 PM Changeset in webkit [94233] by caryclark@google.com

1 edit
828 adds in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac, next chunk of 800 files)
svg/batik/text/textLayout through svg/text/multichar-glyph

platform/chromium-mac/svg/batik/text/textLayout-expected.png: Added.

(remaining files omitted for brevity)

2:12 PM Changeset in webkit [94232] by tony@chromium.org

2 edits in trunk/Source/WebCore

Remove webcore_bindings (including DerivedSources##.cpp) from the critical path
https://bugs.webkit.org/show_bug.cgi?id=67168

Reviewed by Adam Barth.

webcore_bindings_sources, debugger_script_source, injected_script_source, and
inspector_protocol_sources generates various files (e.g., CSSPropertyNames,
DerivedSources, HTMLNames, etc). webcore_bindings depends on *_sources and compiles
these files. Previously, the other webcore libs (webcore_svg, webcore_html,
webcore_remaining, etc) depended on webcore_bindings. This moves the *_sources
dependencies from webcore_bindings to the other webcore libs so the build can
parallelize the compile of webcore_bindings and the other webcore_* libs.

Also copy over the include dirs that we used to get from webcore_bindings'
direct_dependent_settings.

No new tests, just changing the build dependencies.

WebCore.gyp/WebCore.gyp:

2:10 PM Changeset in webkit [94231] by abarth@webkit.org

32 edits
1 copy
1 add in trunk/Source/WebKit/chromium

[Chromium] Rename WebKitClient to WebKitPlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=67309

Reviewed by Darin Fisher.

WebKitClient doesn't actually represent the WebKit Client. Instead, it
represents supporting code for the WebKit Platform. This patch renames
WebKitClient to WebKitPlatformSupport to make it easier for folks to
understand the difference between the Client and the Platform.

This patch includes shims so as not to break the Chromium build. Once
the Chromium side is updated, I'll remove the shims.

WebKit.gyp:
public/WebFrameClient.h:
public/WebKit.h:

(WebKit::webKitClient):

public/WebKitClient.h: Removed.
public/WebKitPlatformSupport.h: Copied from Source/WebKit/chromium/public/WebKitClient.h.

(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):

src/ApplicationCacheHostInternal.h:
src/AssociatedURLLoader.cpp:
src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium):

src/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestination::hardwareSampleRate):

src/BlobRegistryProxy.cpp:

(WebCore::BlobRegistryProxy::BlobRegistryProxy):

src/CCThreadImpl.cpp:

(WebKit::CCThreadImpl::CCThreadImpl):

src/ChromiumCurrentTime.cpp:

(WTF::currentTime):
(WTF::monotonicallyIncreasingTime):

src/ChromiumOSRandomSource.cpp:

(WTF::cryptographicallyRandomValuesFromOS):

src/ChromiumThreading.cpp:

(WTF::ChromiumThreading::callOnMainThread):

src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::canShowMIMEType):
(WebKit::FrameLoaderClientImpl::userAgent):

src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3D::create):

src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

src/LocalizedStrings.cpp:

(WebCore::query):

src/PlatformBridge.cpp:

(WebCore::getCookieJar):
(WebCore::PlatformBridge::cacheMetadata):
(WebCore::PlatformBridge::clipboardIsFormatAvailable):
(WebCore::PlatformBridge::clipboardReadPlainText):
(WebCore::PlatformBridge::clipboardReadHTML):
(WebCore::PlatformBridge::clipboardReadImage):
(WebCore::PlatformBridge::clipboardGetSequenceNumber):
(WebCore::PlatformBridge::clipboardWriteSelection):
(WebCore::PlatformBridge::clipboardWritePlainText):
(WebCore::PlatformBridge::clipboardWriteURL):
(WebCore::PlatformBridge::clipboardWriteImage):
(WebCore::PlatformBridge::clipboardWriteData):
(WebCore::PlatformBridge::clipboardReadAvailableTypes):
(WebCore::PlatformBridge::clipboardReadData):
(WebCore::PlatformBridge::clipboardReadFilenames):
(WebCore::PlatformBridge::prefetchDNS):
(WebCore::PlatformBridge::fileExists):
(WebCore::PlatformBridge::deleteFile):
(WebCore::PlatformBridge::deleteEmptyDirectory):
(WebCore::PlatformBridge::getFileSize):
(WebCore::PlatformBridge::revealFolderInOS):
(WebCore::PlatformBridge::getFileModificationTime):
(WebCore::PlatformBridge::directoryName):
(WebCore::PlatformBridge::pathByAppendingComponent):
(WebCore::PlatformBridge::makeAllDirectories):
(WebCore::PlatformBridge::getAbsolutePath):
(WebCore::PlatformBridge::isDirectory):
(WebCore::PlatformBridge::filePathToURL):
(WebCore::PlatformBridge::openFile):
(WebCore::PlatformBridge::closeFile):
(WebCore::PlatformBridge::seekFile):
(WebCore::PlatformBridge::truncateFile):
(WebCore::PlatformBridge::readFromFile):
(WebCore::PlatformBridge::writeToFile):
(WebCore::PlatformBridge::ensureFontLoaded):
(WebCore::PlatformBridge::loadFont):
(WebCore::PlatformBridge::getFontFamilyForCharacters):
(WebCore::PlatformBridge::getRenderStyleForStrike):
(WebCore::PlatformBridge::databaseOpenFile):
(WebCore::PlatformBridge::databaseDeleteFile):
(WebCore::PlatformBridge::databaseGetFileAttributes):
(WebCore::PlatformBridge::databaseGetFileSize):
(WebCore::PlatformBridge::databaseGetSpaceAvailableForOrigin):
(WebCore::PlatformBridge::createIDBKeysFromSerializedValuesAndKeyPath):
(WebCore::PlatformBridge::injectIDBKeyIntoSerializedValue):
(WebCore::PlatformBridge::signedPublicKeyAndChallengeString):
(WebCore::PlatformBridge::computedDefaultLanguage):
(WebCore::PlatformBridge::isSupportedImageMIMEType):
(WebCore::PlatformBridge::isSupportedJavaScriptMIMEType):
(WebCore::PlatformBridge::isSupportedNonImageMIMEType):
(WebCore::PlatformBridge::mimeTypeForExtension):
(WebCore::PlatformBridge::wellKnownMimeTypeForExtension):
(WebCore::PlatformBridge::mimeTypeFromFile):
(WebCore::PlatformBridge::preferredExtensionForMIMEType):
(WebCore::PlatformBridge::plugins):
(WebCore::PlatformBridge::loadPlatformImageResource):
(WebCore::PlatformBridge::loadPlatformAudioResource):
(WebCore::PlatformBridge::decodeAudioFileData):
(WebCore::PlatformBridge::sandboxEnabled):
(WebCore::PlatformBridge::setSharedTimerFiredFunction):
(WebCore::PlatformBridge::setSharedTimerFireInterval):
(WebCore::PlatformBridge::stopSharedTimer):
(WebCore::PlatformBridge::decrementStatsCounter):
(WebCore::PlatformBridge::incrementStatsCounter):
(WebCore::PlatformBridge::histogramCustomCounts):
(WebCore::PlatformBridge::histogramEnumeration):
(WebCore::PlatformBridge::suddenTerminationChanged):
(WebCore::PlatformBridge::paintButton):
(WebCore::PlatformBridge::paintMenuList):
(WebCore::PlatformBridge::paintScrollbarArrow):
(WebCore::PlatformBridge::paintScrollbarThumb):
(WebCore::PlatformBridge::paintScrollbarTrack):
(WebCore::PlatformBridge::paintSpinButton):
(WebCore::PlatformBridge::paintTextField):
(WebCore::PlatformBridge::paintTrackbar):
(WebCore::PlatformBridge::paintProgressBar):
(WebCore::PlatformBridge::getThemePartSize):
(WebCore::PlatformBridge::paintThemePart):
(WebCore::PlatformBridge::traceEventBegin):
(WebCore::PlatformBridge::traceEventEnd):
(WebCore::PlatformBridge::visitedLinkHash):
(WebCore::PlatformBridge::isLinkVisited):
(WebCore::PlatformBridge::memoryUsageMB):
(WebCore::PlatformBridge::actualMemoryUsageMB):

src/PlatformMessagePortChannel.cpp:

(WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):

src/ResourceHandle.cpp:

(WebCore::ResourceHandleInternal::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

src/SharedWorkerRepository.cpp:

(WebCore::SharedWorkerRepository::isAvailable):
(WebCore::SharedWorkerRepository::connect):
(WebCore::SharedWorkerRepository::documentDetached):
(WebCore::SharedWorkerRepository::hasSharedWorkers):

src/SocketStreamHandle.cpp:

(WebCore::SocketStreamHandleInternal::connect):

src/StorageEventDispatcherChromium.cpp:

(WebCore::StorageEventDispatcher::dispatch):

src/StorageNamespaceProxy.cpp:

(WebCore::StorageNamespace::localStorageNamespace):

src/WebKit.cpp:

(WebKit::generateEntropy):
(WebKit::initialize):
(WebKit::shutdown):
(WebKit::webKitPlatformSupport):

src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::supportsType):

src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::copy):

src/WebViewImpl.cpp:
src/WebWorkerClientImpl.cpp:
src/WorkerAsyncFileSystemChromium.cpp:

(WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):

src/WorkerFileWriterCallbacksBridge.cpp:

(WebKit::WorkerFileWriterCallbacksBridge::initOnMainThread):

tests/RunAllTests.cpp:

2:07 PM Changeset in webkit [94230] by abarth@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-31

DEPS:

2:03 PM Changeset in webkit [94229] by tonyg@chromium.org

3 edits in trunk/Source/WebCore

Minor cleanup: remove inScriptExecution()
https://bugs.webkit.org/show_bug.cgi?id=67276

Reviewed by Adam Barth.

At one point inScriptExecution() existed as a non-virtual duplicate of isExecutingScript()
to avoid virtual method calls from a tight loop. Now we aren't calling it anywhere perf
sensitive, so remove the duplication.

No new tests because no change in functionality.

html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::isExecutingScript):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
(WebCore::HTMLDocumentParser::notifyFinished):

html/parser/HTMLDocumentParser.h:

(WebCore::HTMLDocumentParser::shouldDelayEnd):

1:58 PM Changeset in webkit [94228] by eric@webkit.org

5 edits
2 adds in trunk/Tools

Add queues.webkit.org/active-bots page to make it easy to see which bots are down
https://bugs.webkit.org/show_bug.cgi?id=67314

Reviewed by Adam Barth.

Very simple page. Just lists all the bots, what queue they belong to and what we last heard from them.
If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
This makes it very easy for me to see which of my cr-jail bots might be down at any one time.

I also moved a bunch of code into dashboard.css which belonged there.

QueueStatusServer/handlers/activebots.py: Added.
QueueStatusServer/main.py:
QueueStatusServer/stylesheets/dashboard.css:

(.queue_bubble):
(.queue_name):
(.last_heard_from):
(.status_text):
(.alive):
(.behind):
(.dead):

QueueStatusServer/templates/activebots.html: Added.
QueueStatusServer/templates/dashboard.html:
QueueStatusServer/templates/recentstatus.html:

1:56 PM Changeset in webkit [94227] by robert@webkit.org

1 edit
42 adds in trunk/LayoutTests

Add new platform-specific results from r94211

Unreviewed.

platform/gtk/css2.1/20110323/margin-applies-to-001-expected.txt: Added.
platform/gtk/css2.1/20110323/margin-applies-to-002-expected.txt: Added.
platform/gtk/css2.1/20110323/margin-applies-to-003-expected.txt: Added.
platform/gtk/css2.1/20110323/margin-applies-to-004-expected.txt: Added.
platform/gtk/css2.1/20110323/margin-applies-to-005-expected.txt: Added.
platform/gtk/css2.1/20110323/margin-applies-to-006-expected.txt: Added.
platform/gtk/css2.1/20110323/margin-applies-to-007-expected.txt: Added.
platform/gtk/css2.1/20110323/margin-applies-to-008-expected.txt: Added.
platform/gtk/css2.1/20110323/margin-applies-to-009-expected.txt: Added.
platform/gtk/css2.1/20110323/margin-applies-to-010-expected.txt: Added.
platform/gtk/css2.1/20110323/margin-applies-to-012-expected.txt: Added.
platform/gtk/css2.1/20110323/margin-applies-to-013-expected.txt: Added.
platform/gtk/css2.1/20110323/margin-applies-to-014-expected.txt: Added.
platform/gtk/css2.1/20110323/margin-applies-to-015-expected.txt: Added.
platform/mac/css2.1/20110323/margin-applies-to-001-expected.txt: Added.
platform/mac/css2.1/20110323/margin-applies-to-002-expected.txt: Added.
platform/mac/css2.1/20110323/margin-applies-to-003-expected.txt: Added.
platform/mac/css2.1/20110323/margin-applies-to-004-expected.txt: Added.
platform/mac/css2.1/20110323/margin-applies-to-005-expected.txt: Added.
platform/mac/css2.1/20110323/margin-applies-to-006-expected.txt: Added.
platform/mac/css2.1/20110323/margin-applies-to-007-expected.txt: Added.
platform/mac/css2.1/20110323/margin-applies-to-008-expected.txt: Added.
platform/mac/css2.1/20110323/margin-applies-to-009-expected.txt: Added.
platform/mac/css2.1/20110323/margin-applies-to-010-expected.txt: Added.
platform/mac/css2.1/20110323/margin-applies-to-012-expected.txt: Added.
platform/mac/css2.1/20110323/margin-applies-to-013-expected.txt: Added.
platform/mac/css2.1/20110323/margin-applies-to-014-expected.txt: Added.
platform/mac/css2.1/20110323/margin-applies-to-015-expected.txt: Added.
platform/qt/css2.1/20110323/margin-applies-to-001-expected.txt: Added.
platform/qt/css2.1/20110323/margin-applies-to-002-expected.txt: Added.
platform/qt/css2.1/20110323/margin-applies-to-003-expected.txt: Added.
platform/qt/css2.1/20110323/margin-applies-to-004-expected.txt: Added.
platform/qt/css2.1/20110323/margin-applies-to-005-expected.txt: Added.
platform/qt/css2.1/20110323/margin-applies-to-006-expected.txt: Added.
platform/qt/css2.1/20110323/margin-applies-to-007-expected.txt: Added.
platform/qt/css2.1/20110323/margin-applies-to-008-expected.txt: Added.
platform/qt/css2.1/20110323/margin-applies-to-009-expected.txt: Added.
platform/qt/css2.1/20110323/margin-applies-to-010-expected.txt: Added.
platform/qt/css2.1/20110323/margin-applies-to-012-expected.txt: Added.
platform/qt/css2.1/20110323/margin-applies-to-013-expected.txt: Added.
platform/qt/css2.1/20110323/margin-applies-to-014-expected.txt: Added.
platform/qt/css2.1/20110323/margin-applies-to-015-expected.txt: Added.

1:53 PM Changeset in webkit [94226] by levin@chromium.org

6 edits
2 adds in trunk/LayoutTests

[chromium] Update test expectation due to r94206 and r94211.

platform/chromium-win/fast/borders/border-image-source-expected.png: Added.
platform/chromium-win/fast/borders/border-image-source-expected.txt: Added.
platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
platform/chromium-win/tables/mozilla_expected_failures/core/captions1-expected.png:
platform/chromium-win/tables/mozilla_expected_failures/core/captions2-expected.png:

1:52 PM Changeset in webkit [94225] by commit-queue@webkit.org

4 edits
1 add in trunk

Fix XSS filter bypass by multiply decoding both the URL and the body
snippet until they are in the most minimal form before comparison.
https://bugs.webkit.org/show_bug.cgi?id=66585

Patch by Tom Sepez <tsepez@chromium.org> on 2011-08-31
Reviewed by Adam Barth.

Source/WebCore:

html/parser/XSSAuditor.cpp:

(WebCore::fullyDecodeString):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
(WebCore::XSSAuditor::isContainedInRequest):

LayoutTests:

http/tests/security/xssAuditor/anchor-url-dom-write-location2.html:
http/tests/security/xssAuditor/resources/echo-dom-write-unescaped-location.html: Added.

1:46 PM Changeset in webkit [94224] by caryclark@google.com

1 edit
846 adds in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac, next chunk of 800 files)
fast/overflow through svg/batik/text

platform/chromium-mac/fast/overflow/overflow-with-local-background-attachment-expected.png: Added.

(remaining files omitted for brevity)

1:32 PM Changeset in webkit [94223] by caryclark@google.com

1 edit
850 adds in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac, next chunk of 800 files)
Most files were inadvertantly excluded from earlier checkins.

platform/chromium-mac/fast/overflow: Added.

(remaining files omitted for brevity)

1:16 PM Changeset in webkit [94222] by robert@webkit.org

16 edits in trunk/LayoutTests

Update platform-specific results after r94211

Unreviewed, update platform-specifc results.

platform/gtk/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
platform/gtk/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.txt:
platform/gtk/tables/mozilla_expected_failures/core/captions3-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:
platform/mac/tables/mozilla_expected_failures/core/captions3-expected.txt:
platform/qt/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
platform/qt/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
platform/qt/tables/mozilla_expected_failures/core/captions1-expected.txt:
platform/qt/tables/mozilla_expected_failures/core/captions2-expected.txt:
platform/qt/tables/mozilla_expected_failures/core/captions3-expected.txt:

1:14 PM Changeset in webkit [94221] by oliver@apple.com

2 edits
1 move in trunk/Tools

Move CheckedArithmeticOperations.cpp to the intended location

1:12 PM Changeset in webkit [94220] by Lucas Forschler

19 edits
2 copies in branches/safari-534.51-branch

Merged r92982.

1:09 PM Changeset in webkit [94219] by commit-queue@webkit.org

2 edits in trunk/Tools

add unittest to validate the complete set of Chromium configurations
https://bugs.webkit.org/show_bug.cgi?id=67211

Patch by Elliot Poger <epoger@google.com> on 2011-08-31
Reviewed by Adam Barth.

Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

12:42 PM Changeset in webkit [94218] by Lucas Forschler

3 edits in branches/safari-534.51-branch/Source/WebCore

Merge r93459.

12:29 PM Changeset in webkit [94217] by vangelis@chromium.org

2 edits in branches/chromium/835/Source/WebKit/chromium/src

Direct commit into chromium 835 branch:

Fix handling of lost context recovery for windows XP. The existing code didn't always
succeed creating a GC3D right after recovering from a lost device and ended up in an inconsistent
state of doing s/w rendering but without having properly cleared the composited layers.
The new code attempts to create a GC3D a few times before giving up and switching to s/w rendering.
Upon repeated failure we now switch to s/w rendering and force a style recalc on the document
to make sure that composited layers are properly disposed.

This code is checked in to the 835 branch directly as handling of the lost context events on the trunk has significantly diverged. A similar change must be made to the trunk as well.

CHROME BUG=http://code.google.com/p/chromium/issues/detail?id=94183
TEST=Open pages using the compositor like the poster circle on windows XP and trigger repeated lost device events
by locking the screen. Verify that upon return the page renders correctly.

12:21 PM Changeset in webkit [94216] by vsevik@chromium.org

1 edit in branches/chromium/835/Source/WebCore/inspector/InspectorResourceAgent.cpp

Merge 94078 - Web Inspector: Inspected page sometimes crashes in InspectorResourceAgent::didFailLoading
https://bugs.webkit.org/show_bug.cgi?id=67193

Reviewed by Pavel Feldman.

inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didFailLoading):

TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/7819001

12:12 PM Changeset in webkit [94215] by Simon Fraser

3 edits
2 adds in trunk

Crash with -webkit-radial-gradient(top) gradient
https://bugs.webkit.org/show_bug.cgi?id=66686

Source/WebCore:

Reviewed by Darin Adler.

Null-check the current value after calling parseFillPosition(),
since it may be null for gradients with degenerate arguments.

Test: fast/gradients/css3-radial-gradient-crash.html

css/CSSParser.cpp:

(WebCore::CSSParser::parseRadialGradient):

LayoutTests:

Reviewed by Darin Adler.

Test case with degenerate arguments in a radial gradient.

fast/gradients/css3-radial-gradient-crash-expected.txt: Added.
fast/gradients/css3-radial-gradient-crash.html: Added.

12:08 PM Changeset in webkit [94214] by thakis@chromium.org

6 edits in trunk

Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
https://bugs.webkit.org/show_bug.cgi?id=67297

Reviewed by Tony Chang.

Source/WebCore:

I need this to disable smooth scrolling in chromium tests. I'm making
the change to ScrollAnimatorMac to make unforking the file easier. I
changed scrollAnimatorEnabled() to default to true so that this change
is a no-op for Safari; in chromium the flag is set explicitly to true
or false anyway.

page/Settings.cpp:

(WebCore::Settings::Settings):

platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::scroll):

platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::scroll):

Tools:

Explicitly disable smooth scrolling in chromium's DRT.

DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::applyTo):

12:01 PM Changeset in webkit [94213] by Nate Chapin

10 edits
5 adds
32 deletes in trunk

Source/WebCore: Don't load resources with empty urls, since this
will resolve to the current document.
https://bugs.webkit.org/show_bug.cgi?id=30303

Reviewed by Darin Adler.

Test: http/tests/loading/empty-urls.html

dom/ScriptElement.cpp:

(WebCore::ScriptElement::requestScript): If src="", fail through

to the error event case.

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::parseMappedAttribute): Ensure the url

stays empty if we try to resolve an empty href.

loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement): Throw an error instead of

loading if the src is empty in all cases, not just local files.

LayoutTests: Test updates for https://bugs.webkit.org/show_bug.cgi?id=30303.

Reviewed by Darin Adler.

fast/images/load-img-with-empty-src-expected.txt:
fast/images/load-img-with-empty-src.html: Expect the same behavior whether or not an empty src

is in a local file document.

fast/tokenizer/002-expected.txt: Added.
fast/tokenizer/002.html: Make dumpAsText().
fast/tokenizer/external-script-document-write_2-expected.txt: Added.
fast/tokenizer/external-script-document-write_2.html:: Make dumpAsText().
fast/tokenizer/script_extra_close-expected.txt: Added.
fast/tokenizer/script_extra_close.html:: Make dumpAsText().
http/tests/loading/empty-urls-expected.txt: Added.
http/tests/loading/empty-urls.html: Added. Test empty urls with a bunch of subresource types

and ensure their error event behavior matches the spec.

platform/chromium-cg-mac/fast/tokenizer/002-expected.txt: Removed.
platform/chromium-cg-mac/fast/tokenizer/external-script-document-write_2-expected.txt: Removed.
platform/chromium-linux/fast/tokenizer/002-expected.png: Removed.
platform/chromium-linux/fast/tokenizer/external-script-document-write_2-expected.png: Removed.
platform/chromium-linux/fast/tokenizer/script_extra_close-expected.png: Removed.
platform/chromium-win/fast/tokenizer/002-expected.png: Removed.
platform/chromium-win/fast/tokenizer/002-expected.txt: Removed.
platform/chromium-win/fast/tokenizer/external-script-document-write_2-expected.png: Removed.
platform/chromium-win/fast/tokenizer/external-script-document-write_2-expected.txt: Removed.
platform/chromium-win/fast/tokenizer/script_extra_close-expected.png: Removed.
platform/chromium-win/fast/tokenizer/script_extra_close-expected.txt: Removed.
platform/gtk/fast/tokenizer/002-expected.png: Removed.
platform/gtk/fast/tokenizer/002-expected.txt: Removed.
platform/gtk/fast/tokenizer/external-script-document-write_2-expected.png: Removed.
platform/gtk/fast/tokenizer/external-script-document-write_2-expected.txt: Removed.
platform/gtk/fast/tokenizer/script_extra_close-expected.png: Removed.
platform/gtk/fast/tokenizer/script_extra_close-expected.txt: Removed.
platform/mac-leopard/fast/tokenizer/002-expected.png: Removed.
platform/mac-leopard/fast/tokenizer/external-script-document-write_2-expected.png: Removed.
platform/mac-leopard/fast/tokenizer/script_extra_close-expected.png: Removed.
platform/mac/fast/tokenizer/002-expected.png: Removed.
platform/mac/fast/tokenizer/002-expected.txt: Removed.
platform/mac/fast/tokenizer/external-script-document-write_2-expected.png: Removed.
platform/mac/fast/tokenizer/external-script-document-write_2-expected.txt: Removed.
platform/mac/fast/tokenizer/script_extra_close-expected.png: Removed.
platform/mac/fast/tokenizer/script_extra_close-expected.txt: Removed.
platform/qt/fast/tokenizer/002-expected.png: Removed.
platform/qt/fast/tokenizer/002-expected.txt: Removed.
platform/qt/fast/tokenizer/external-script-document-write_2-expected.png: Removed.
platform/qt/fast/tokenizer/external-script-document-write_2-expected.txt: Removed.
platform/qt/fast/tokenizer/script_extra_close-expected.png: Removed.
platform/qt/fast/tokenizer/script_extra_close-expected.txt: Removed.

11:57 AM Changeset in webkit [94212] by Simon Fraser

2 edits in trunk/LayoutTests

Improve appearance and performance of layout test results.html
https://bugs.webkit.org/show_bug.cgi?id=67252

Reviewed by Adam Barth, Ojan Vafai.

Improve the appearance of the pixel result comparison overlay.

Change the overlay from painting pixels into a canvas one by one
to using images enlarged with 'image-rendering: -webkit-optimize-contrast",
which is very much faster.

fast/harness/results.html:

11:48 AM Changeset in webkit [94211] by robert@webkit.org

10 edits
42 adds in trunk

CSS 2.1 failure: margin-applies-to-015 fails, WebKit does not respect top margin for table captions
https://bugs.webkit.org/show_bug.cgi?id=34763

Reviewed by Simon Fraser.

Source/WebCore:

rendering/RenderTable.cpp:

(WebCore::RenderTable::adjustLogicalHeightForCaption): Added the caption's margin to the position calculation.

LayoutTests:

css2.1/20110323/margin-applies-to-001.htm: Added.
css2.1/20110323/margin-applies-to-002.htm: Added.
css2.1/20110323/margin-applies-to-003.htm: Added.
css2.1/20110323/margin-applies-to-004.htm: Added.
css2.1/20110323/margin-applies-to-005.htm: Added.
css2.1/20110323/margin-applies-to-006.htm: Added.
css2.1/20110323/margin-applies-to-007.htm: Added.
css2.1/20110323/margin-applies-to-008.htm: Added.
css2.1/20110323/margin-applies-to-009.htm: Added.
css2.1/20110323/margin-applies-to-010.htm: Added.
css2.1/20110323/margin-applies-to-012.htm: Added.
css2.1/20110323/margin-applies-to-013.htm: Added.
css2.1/20110323/margin-applies-to-014.htm: Added.
css2.1/20110323/margin-applies-to-015.htm: Added.
- Added from http://test.csswg.org/suites/css2.1/20110323/html4/chapter-8.html
platform/chromium-linux/css2.1/20110323/margin-applies-to-001-expected.png: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-001-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-002-expected.png: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-002-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-003-expected.png: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-003-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-004-expected.png: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-004-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-005-expected.png: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-005-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-006-expected.png: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-006-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-007-expected.png: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-007-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-008-expected.png: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-008-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-009-expected.png: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-009-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-010-expected.png: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-010-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-012-expected.png: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-012-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-013-expected.png: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-013-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-014-expected.png: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-014-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-015-expected.png: Added.
platform/chromium-linux/css2.1/20110323/margin-applies-to-015-expected.txt: Added.
- Chromium-Linux results for http://test.csswg.org/suites/css2.1/20110323/html4/chapter-8.html
platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
platform/chromium-win/tables/mozilla_expected_failures/core/captions1-expected.txt:
platform/chromium-win/tables/mozilla_expected_failures/core/captions2-expected.txt:
platform/chromium-win/tables/mozilla_expected_failures/core/captions3-expected.txt:
- Updated to reflect position of table caption taking account of margin, matching Firefox where appropriate. Still some unrelated failures that prevent matching Firefox exactly.

11:48 AM Changeset in webkit [94210] by Lucas Forschler

2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r93900.

11:46 AM Changeset in webkit [94209] by Lucas Forschler

3 edits in branches/safari-534.51-branch/Source/WebCore

Merge r93878.

11:37 AM Changeset in webkit [94208] by oliver@apple.com

2 edits in trunk/Tools

2011-08-31 Oliver Hunt <oliver@apple.com>

Add Checked<> tests to windows build

TestWebKitAPI/win/TestWebKitAPI.vcproj:

11:16 AM Changeset in webkit [94207] by oliver@apple.com

13 edits
3 adds in trunk

Add support for checked arithmetic
https://bugs.webkit.org/show_bug.cgi?id=67095

Reviewed by Sam Weinig.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Add a checked arithmetic class Checked<T> that provides overflow-safe
arithmetic over all integral types. Checked<T> supports addition, subtraction
and multiplication, along with "bool" conversions and equality operators.

Checked<> can be used in either CRASH() on overflow or delayed failure modes,
although the default is to CRASH().

To ensure the code is actually in use (rather than checking in dead code) I've
made a couple of properties in YARR use Checked<int> and Checked<unsigned>
instead of raw value arithmetic. This has resulted in a moderate set of changes,
to YARR - mostly adding .get() calls, but a couple of casts from unsigned long
to unsigned for some uses of sizeof, as Checked<> currently does not support
mixed signed-ness of types wider that 32 bits.

Happily the increased type safety of Checked<> means that it's not possible to
accidentally assign away precision, nor accidentally call integer overload of
a function instead of the bool version.

No measurable regression in performance, and SunSpider claims this patch to be
a progression of 0.3%.

GNUmakefile.list.am:
JavaScriptCore.gypi:
JavaScriptCore.vcproj/WTF/WTF.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
wtf/CheckedArithmetic.h: Added.

(WTF::CrashOnOverflow::overflowed):
(WTF::CrashOnOverflow::clearOverflow):
(WTF::CrashOnOverflow::hasOverflowed):
(WTF::RecordOverflow::RecordOverflow):
(WTF::RecordOverflow::overflowed):
(WTF::RecordOverflow::clearOverflow):
(WTF::RecordOverflow::hasOverflowed):
(WTF::isInBounds):
(WTF::safeAdd):
(WTF::safeSub):
(WTF::safeMultiply):
(WTF::safeEquals):
(WTF::workAroundClangBug):
(WTF::Checked::Checked):
(WTF::Checked::operator=):
(WTF::Checked::operator++):
(WTF::Checked::operator--):
(WTF::Checked::operator!):
(WTF::Checked::operator UnspecifiedBoolType*):
(WTF::Checked::get):
(WTF::Checked::operator+=):
(WTF::Checked::operator-=):
(WTF::Checked::operator*=):
(WTF::Checked::operator==):
(WTF::Checked::operator!=):
(WTF::operator+):
(WTF::operator-):
(WTF::operator*):

yarr/YarrInterpreter.cpp:

(JSC::Yarr::ByteCompiler::atomPatternCharacter):
(JSC::Yarr::ByteCompiler::atomCharacterClass):
(JSC::Yarr::ByteCompiler::atomBackReference):
(JSC::Yarr::ByteCompiler::atomParentheticalAssertionEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesOnceEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesTerminalEnd):

yarr/YarrInterpreter.h:

(JSC::Yarr::ByteTerm::ByteTerm):
(JSC::Yarr::ByteTerm::CheckInput):
(JSC::Yarr::ByteTerm::UncheckInput):

yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generateAssertionEOL):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassOnce):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassNonGreedy):

yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::setupAlternativeOffsets):

yarr/YarrPattern.h:

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Add a forwarding header for CheckedArithmetic.h

ForwardingHeaders/wtf/CheckedArithmetic.h: Added.

../../../../Volumes/Data/git/WebKit/OpenSource/Tools:

Add test cases for Checked<>

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.

11:11 AM Changeset in webkit [94206] by hyatt@apple.com

11 edits
3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=67300

Add the new border-image-source property (and its corresponding analogue for masks, mask-box-image-source).
Change the border-image parsing code to no longer consider "none" to represent the entire border-image
expression, but instead to just mean "none" for the image component of the expression.

Change the pending image code for border-image and mask-box-image to use the new *-source properties when
loading the image so that they're considered the same.

This is the first step towards eliminating the border-image parsing code in favor of just parsing it as
a shorthand instead, but for now I'm implementing each property one by one, and once they're all there,
we can cut over to border-image as a true shorthand.

Reviewed by Beth Dakin.

Added fast/borders/border-image-source.html.

Source/WebCore:

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseBorderImage):

css/CSSPropertyNames.in:
css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapNinePieceImage):
(WebCore::CSSStyleSelector::loadPendingImages):

rendering/style/NinePieceImage.h:

(WebCore::NinePieceImage::setImage):

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::borderImageSource):
(WebCore::InheritedFlags::maskBoxImageSource):
(WebCore::InheritedFlags::setBorderImageSource):
(WebCore::InheritedFlags::setMaskBoxImageSource):
(WebCore::InheritedFlags::initialBorderImageSource):
(WebCore::InheritedFlags::initialMaskBoxImageSource):

LayoutTests:

fast/borders/border-image-source.html: Added.
fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
svg/css/getComputedStyle-basic-expected.txt:

10:54 AM Changeset in webkit [94205] by caryclark@google.com

1 edit
677 adds in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac, remainder of fast directory)

platform/chromium-mac/fast/blockflow: Added.

(remaining files omitted for brevity)

10:53 AM Changeset in webkit [94204] by abarth@webkit.org

1 edit
2 moves in trunk/Tools

Move summary.html to garden-o-matic.html.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.

10:44 AM Changeset in webkit [94203] by noel.gordon@gmail.com

4 edits in trunk

[chromium] DRT linux should pass nativeKeyCode to plugins
https://bugs.webkit.org/show_bug.cgi?id=66679

Reviewed by Tony Chang.

Tools:

DumpRenderTree/chromium/EventSender.cpp:

(EventSender::keyDown): Call a Chromium Linux GTK helper routine that returns the
(simulated) nativeKeyCode for the given input keyboard code.

LayoutTests:

platform/chromium-linux/plugins/keyboard-events-expected.txt:

10:41 AM Changeset in webkit [94202] by senorblanco@chromium.org

2 edits in trunk/Source/WebCore

[chromium] Set the GrContext before SkGpuDevice is destroyed.
https://bugs.webkit.org/show_bug.cgi?id=67296

When SkGpuDevice is destroyed, it frees the FBO used for accelerated
rendering. If the wrong context is set (e.g., compositor context),
a crash may result.

Reviewed by Kenneth Russell.

No new tests. (Unfortunately, wrong-context bugs are difficult to
express in a layout test).

platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::~ImageBuffer):

10:32 AM Changeset in webkit [94201] by abarth@webkit.org

3 edits
1 add in trunk/Tools

Tighen up UI for garden-o-matic tab strip
https://bugs.webkit.org/show_bug.cgi?id=67266

Reviewed by Dimitri Glazkov.

This patch add CSS to move the tab strip to the edges of the page and
to remove some gratuitous border-radius.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:

10:30 AM Changeset in webkit [94200] by abarth@webkit.org

4 edits in trunk/Tools

garden-o-matic results view shouldn't be horrifically ugly
https://bugs.webkit.org/show_bug.cgi?id=67264

Reviewed by Dimitri Glazkov.

Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:

10:20 AM Changeset in webkit [94199] by nduca@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Unreviewed, fix inconsistent WebKit.gypi after r94106
https://bugs.webkit.org/show_bug.cgi?id=67288

WebKit.gypi:

9:37 AM Changeset in webkit [94198] by abarth@webkit.org

6 edits in trunk/Tools

garden-o-matic needs a tabstrip
https://bugs.webkit.org/show_bug.cgi?id=67263

Reviewed by Dimitri Glazkov.

This patch adds a basic tabstrip to garden-o-matic. The results
details view now opens in the "Results" tab, and the user can flip back
and forth between the Summary and the Results tab quickly. There's
also a stub for a "Commits" tab, which is disabled.

This patch isn't the most beautiful in the world, but it gets the ball
rolling on a multi-modal UI.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:

9:34 AM Changeset in webkit [94197] by kbalazs@webkit.org

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.
Unskip fast/files/create-blob-url.html after r94187

platform/qt/Skipped:

9:31 AM Changeset in webkit [94196] by eric.carlson@apple.com

4 edits in trunk/Source/WebCore

Clean up HTMLMediaElement behavior restrictions
https://bugs.webkit.org/show_bug.cgi?id=67231

Reviewed by Darin Adler.

No new tests, cleanup only.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Deal with enum and function renaming.
(WebCore::HTMLMediaElement::load): Call userGestureRequiredForLoad() instead of testing bits

directly.

(WebCore::HTMLMediaElement::loadInternal): Deal with enum and function renaming.
(WebCore::HTMLMediaElement::play): Call userGestureRequiredForRateChange() instead of testing bits

directly.

(WebCore::HTMLMediaElement::pause): Ditto.

html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::userGestureRequiredForLoad): Renamed.
(WebCore::HTMLMediaElement::userGestureRequiredForRateChange):
(WebCore::HTMLMediaElement::userGestureRequiredForFullscreen):
(WebCore::HTMLMediaElement::pageConsentRequiredForLoad):
(WebCore::HTMLMediaElement::addBehaviorRestriction):
(WebCore::HTMLMediaElement::removeBehaviorRestriction):

html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::webkitEnterFullscreen): requireUserGestureForFullScreen renamed to

userGestureRequiredForFullscreen.

9:20 AM Changeset in webkit [94195] by caryclark@google.com

1 edit
946 adds in trunk/LayoutTests

unreviewed; new baselines (Skia on Mac, css3, edit, partial fast directories)

platform/chromium-mac/css3: Added.
platform/chromium-mac/edit: Added.
platform/chromium-mac/fast/backgrounds: Added.

(remaining files omitted for brevity)

9:09 AM Changeset in webkit [94194] by Martin Robinson

2 edits in trunk/LayoutTests

Unskip a test which now seems to be passing on GTK+.

platform/gtk/Skipped: Unskip a test.

8:25 AM Changeset in webkit [94193] by kbalazs@webkit.org

2 edits in trunk/LayoutTests

[Qt] Incorrect results for new fast/multicol tests added in r94084
https://bugs.webkit.org/show_bug.cgi?id=67293

Unreviwed gardening.

platform/qt/Skipped:

8:25 AM Changeset in webkit [94192] by andreip@google.com

2 edits in trunk/Source/JavaScriptCore

2011-08-31 Andrei Popescu <andreip@google.com>

Investigate current uses of OS(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66761

Unreviewed, build fix for ARM platforms.

wtf/Platform.h:

8:10 AM Changeset in webkit [94191] by andreip@google.com

6 edits in trunk/Source

Investigate current uses of OS(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66761

Reviewed by Darin Adler.

Remove the last legacy Android code.

No new tests needed as the code wasn't tested in the first place.

Source/JavaScriptCore:

wtf/Atomics.h:
wtf/Platform.h:
wtf/ThreadingPthreads.cpp:

(WTF::createThreadInternal):

Source/WebCore:

bridge/jni/JNIUtility.cpp:

(JSC::Bindings::getJNIEnv):

8:02 AM Changeset in webkit [94190] by caryclark@google.com

1 edit
683 adds in trunk/LayoutTests

unreviewed; new baselines (Skia on Mac, css2.1 directory only)

platform/chromium-mac/css2.1: Added.
platform/chromium-mac/css2.1/20110323: Added.
platform/chromium-mac/css2.1/20110323/absolute-non-replaced-height-001-expected.png: Added.

(remaining files omitted for brevity)

7:52 AM Changeset in webkit [94189] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r94082.
http://trac.webkit.org/changeset/94082
https://bugs.webkit.org/show_bug.cgi?id=67291

Breaks trunk (not canary) Chromium Mac builders upon WebKit
roll (Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-31

WebCore.gyp/WebCore.gyp:

7:50 AM Changeset in webkit [94188] by noam.rosenthal@nokia.com

3 edits in trunk/Source/WebCore

[Qt] Add a convenience function to cast a QTransform to TransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=67246

Reviewed by Andreas Kling.

No new functionality so no new tests.

platform/graphics/qt/TransformationMatrixQt.cpp:

(WebCore::TransformationMatrix::TransformationMatrix):

platform/graphics/transforms/TransformationMatrix.h:

7:43 AM Changeset in webkit [94187] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, revert part of r94168, the test didn't need result
update. Proper fix is worked on in bug 66045.

fast/files/create-blob-url-crash-expected.txt:

7:37 AM Changeset in webkit [94186] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r94176.
http://trac.webkit.org/changeset/94176
https://bugs.webkit.org/show_bug.cgi?id=67290

This does not fix the build failure on Macs (Requested by
apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-31

WebCore.gyp/WebCore.gyp:

7:03 AM Changeset in webkit [94185] by reed@google.com

4 edits in trunk

[skia] antialias images if we're rotated
https://bugs.webkit.org/show_bug.cgi?id=67207

Reviewed by Stephen White.

Source/WebCore:

platform/graphics/skia/ImageSkia.cpp:

(WebCore::hasNon90rotation):
(WebCore::paintSkBitmap):

LayoutTests:

platform/chromium/test_expectations.txt:

6:37 AM Changeset in webkit [94184] by kbalazs@webkit.org

2 edits in trunk/LayoutTests

[Qt] Unreviewedly skip new failures.

It covers the following bugs:

Ping-pong with fast/files/create-blob-url-crash-expected.txt https://bugs.webkit.org/show_bug.cgi?id=67282
[Qt] css2.1/t090204-display-change-01-b-ao.html fails after r94084 https://bugs.webkit.org/show_bug.cgi?id=67286

platform/qt/Skipped:

6:24 AM Changeset in webkit [94183] by Philippe Normand

3 edits in trunk/LayoutTests

Unreviewed, rebaseline GTK-specific font tests.

platform/gtk/fonts/complex-text-shadows-expected.txt:
platform/gtk/fonts/font-face-with-complex-text-expected.txt:

6:11 AM Changeset in webkit [94182] by caio.oliveira@openbossa.org

2 edits in trunk/Source/WebKit/qt

[Qt] Unskip API test for load signals order
https://bugs.webkit.org/show_bug.cgi?id=67285

Reviewed by Andreas Kling.

tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::loadSignalsOrder):

5:53 AM Changeset in webkit [94181] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Having the "Metrics" pane open affects the node highlight display
https://bugs.webkit.org/show_bug.cgi?id=67278

Reviewed by Yury Semikhatsky.

inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane.prototype._updateMetrics):

5:50 AM Changeset in webkit [94180] by podivilov@chromium.org

2 edits in trunk/LayoutTests

2011-08-31 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, build fix after r94167.

inspector/debugger/script-formatter.html:

5:49 AM Changeset in webkit [94179] by kbalazs@webkit.org

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.
Skipped the wrong test in a previous gardening.

platform/qt/Skipped:

5:13 AM Changeset in webkit [94178] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: console view does a style recalculation per each addMessage call.
https://bugs.webkit.org/show_bug.cgi?id=67198

It is bad from the performance point of view.

Reviewed by Yury Semikhatsky.

inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._isScrollIntoViewScheduled):
(WebInspector.ConsoleView.prototype._appendConsoleMessage):

5:07 AM Changeset in webkit [94177] by kbalazs@webkit.org

2 edits in trunk/LayoutTests

[Qt] Incorrect results for svg/custom/getBBox-js.svg
Unreviewed gardening.

platform/qt/Skipped:

4:09 AM Changeset in webkit [94176] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

[Chromium] Unreviewed build fix. Restore debugger_script_source target dependency
broken in http://trac.webkit.org/changeset/94082.

WebCore.gyp/WebCore.gyp:

4:02 AM Changeset in webkit [94175] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, unskip fast/css/square-button-appearance.html which
got baselines in r93953.

platform/gtk/test_expectations.txt:

3:55 AM Changeset in webkit [94174] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] 3 test started crashing somewhere between r93878-r93935
https://bugs.webkit.org/show_bug.cgi?id=67197

platform/qt/Skipped: Unskip tests, because bug was fixed by r94088.

3:53 AM Changeset in webkit [94173] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, skip failing fast/loader/location-port.html test on
GTK.

platform/gtk/Skipped:

3:52 AM Changeset in webkit [94172] by Csaba Osztrogonác

5 edits
3 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

Add Qt specific expected files after r94111, update Qt specific expected files after r94109.

Based on digging of Gabor Rapcsanyi.

platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.png:
platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.png:
platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
platform/qt/fast/preloader/document-write-noscript-expected.png: Added.
platform/qt/fast/preloader/document-write-noscript-expected.txt: Added.

3:42 AM Changeset in webkit [94171] by Csaba Osztrogonác

7 edits
4 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add and update platform specific expected files after r94109.

Based on digging of Gabor Rapcsanyi.

platform/qt/fast/table/table-after-child-in-table-expected.txt:
platform/qt/fast/table/table-before-child-in-table-expected.txt:
platform/qt/fast/table/table-before-child-style-update-expected.png: Added.
platform/qt/fast/table/table-before-child-style-update-expected.txt: Added.
platform/qt/fast/table/table-row-after-child-in-block-expected.txt:
platform/qt/fast/table/table-row-after-child-in-table-expected.txt:
platform/qt/fast/table/table-row-before-child-in-block-expected.txt:
platform/qt/fast/table/table-row-before-child-in-table-expected.txt:
platform/qt/fast/table/table-row-before-child-style-update-expected.png: Added.
platform/qt/fast/table/table-row-before-child-style-update-expected.txt: Added.

3:37 AM Changeset in webkit [94170] by Csaba Osztrogonác

5 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Update platform specific expected files after r94147.

Based on digging of Gabor Rapcsanyi.

platform/qt/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
platform/qt/fast/dom/prototype-inheritance-expected.txt:
platform/qt/fast/js/global-constructors-expected.txt:

3:20 AM Changeset in webkit [94169] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Early return in CSSPrimitiveValue::getDoubleValueInternal() omits additional invalid enums
https://bugs.webkit.org/show_bug.cgi?id=67139

Reviewed by Darin Adler.

css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion): Check if a given unit type can be converted to a double.
(WebCore::CSSPrimitiveValue::getDoubleValueInternal): Make use of the new method that explicitly lists all unit types.

3:11 AM Changeset in webkit [94168] by Philippe Normand

4 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r93713 and r93909.

fast/files/create-blob-url-crash-expected.txt:
platform/gtk/css2.1/t0602-c13-inheritance-00-e-expected.txt:
platform/gtk/css2.1/t090204-display-change-01-b-ao-expected.txt:

3:02 AM Changeset in webkit [94167] by podivilov@chromium.org

10 edits in trunk

Web Inspector: rename sourceFile to uiSourceCode and get rid of sourceFileId where possible.
https://bugs.webkit.org/show_bug.cgi?id=67136

Reviewed by Yury Semikhatsky.

Source/WebCore:

inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.breakpointsForUISourceCode):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):
(WebInspector.BreakpointManager.prototype._addBreakpointToUI):
(WebInspector.BreakpointManager.prototype._deleteBreakpointFromUI):
(WebInspector.BreakpointManager.prototype.set reset):
(WebInspector.BreakpointManager.prototype.debuggerReset):

inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.removeBreakpoint):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.highlightBreakpoint):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._createBreakpointItemId):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointClicked):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._contextMenu):

inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype.update.didGetSourceLine):
(WebInspector.CallStackSidebarPane.prototype.update):

inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor.didGetLocation):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeReplaced):
(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage.didGetUILocation):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForUISourceCode):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
(WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.PresentationBreakpoint):
(WebInspector.PresentationBreakpoint.prototype.get url):
(WebInspector.PresentationBreakpoint.prototype.loadSnippet):
(WebInspector.PresenationCallFrame):
(WebInspector.PresenationCallFrame.prototype.get url):
(WebInspector.PresenationCallFrame.prototype.select):
(WebInspector.PresenationCallFrame.prototype.sourceLine):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.get statusBarItems):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded.get if):
(WebInspector.ScriptsPanel.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.prototype.setScriptSourceIsBeingEdited):
(WebInspector.ScriptsPanel.prototype._consoleMessagesCleared):
(WebInspector.ScriptsPanel.prototype._consoleMessageAdded):
(WebInspector.ScriptsPanel.prototype._breakpointAdded):
(WebInspector.ScriptsPanel.prototype._breakpointRemoved):
(WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.ScriptsPanel.prototype._resetFilesSelect):
(WebInspector.ScriptsPanel.prototype.showAnchorLocation):
(WebInspector.ScriptsPanel.prototype._showSourceLine):
(WebInspector.ScriptsPanel.prototype._showSourceFrameAndAddToHistory):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype._removeSourceFrame):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
(WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.ScriptsPanel.prototype._filesSelectChanged):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
(WebInspector.SourceFrameDelegateForScriptsPanel):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.updateBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.removeBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.findBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.continueToLine):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.canEditScriptSource):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSource):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSourceIsBeingEdited):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):

LayoutTests:

inspector/debugger/breakpoint-manager.html:
inspector/debugger/scripts-panel.html:

2:20 AM Changeset in webkit [94166] by apavlov@chromium.org

1 edit
1 add in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline another multicol test expectation.

platform/chromium-cg-mac-leopard/fast/multicol/overflow-across-columns-expected.png: Added.

2:12 AM Changeset in webkit [94165] by apavlov@chromium.org

1 edit
2 adds in trunk/LayoutTests

[Chromium] Unreviewed, update Mac-Leopard expectations for multicol tests.

platform/chromium-cg-mac-leopard/fast/multicol/overflow-unsplittable-expected.png: Added.
platform/chromium-cg-mac-leopard/fast/multicol/positive-leading-expected.png: Added.

2:06 AM Changeset in webkit [94164] by commit-queue@webkit.org

20 edits in trunk/LayoutTests

[WebSocket] Prevent unnecessary pywebsocket warnings on layout tests.
https://bugs.webkit.org/show_bug.cgi?id=67182

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-31
Reviewed by Kent Tamura.

Some layout tests for WebSocket raised Exception to prevent unnecessary
pywebsocket warning. But it doesn't work any more on pywebsocket 0.6b4.
Now pywebsocket support AbortedByUserException to prevent warning.
This change make raise AbortedByUserException instead of Exception.

handshake-fail-by-prepended-null_wsh.py didn't use Exception, but
expected abnormal closure on sending response could raise unexpected
Exception by chance. This change also takes care of it.

http/tests/websocket/tests/hixie76/bad-handshake-crash_wsh.py:
http/tests/websocket/tests/hixie76/frame-length-longer-than-buffer_wsh.py:
http/tests/websocket/tests/hixie76/frame-length-overflow_wsh.py:
http/tests/websocket/tests/hixie76/handshake-fail-by-maxlength_wsh.py:
http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header_wsh.py:
http/tests/websocket/tests/hixie76/handshake-fail-by-no-cr_wsh.py:
http/tests/websocket/tests/hixie76/handshake-fail-by-no-upgrade-header_wsh.py:
http/tests/websocket/tests/hixie76/handshake-fail-by-prepended-null_wsh.py:
http/tests/websocket/tests/hixie76/long-invalid-header_wsh.py:
http/tests/websocket/tests/hybi/bad-handshake-crash_wsh.py:
http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header_wsh.py:
http/tests/websocket/tests/hybi/handshake-fail-by-maxlength_wsh.py:
http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header_wsh.py:
http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header_wsh.py:
http/tests/websocket/tests/hybi/handshake-fail-by-no-cr_wsh.py:
http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header_wsh.py:
http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header_wsh.py:
http/tests/websocket/tests/hybi/long-invalid-header_wsh.py:
http/tests/websocket/tests/hybi/masked-frames_wsh.py:

Use AbortedByUserException instead of Exception.

1:45 AM Changeset in webkit [94163] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/efl

[EFL] Fonts API refactoring.
https://bugs.webkit.org/show_bug.cgi?id=66654

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-31
Reviewed by Hajime Morita.

There are too many similar API regarding to fonts.
Add one consistent API to set/get the font name for the font family.
Remove the previous font API.

ewk/ewk_view.cpp:

(ewk_view_font_family_name_get):
(ewk_view_font_family_name_set):

ewk/ewk_view.h:

1:35 AM Changeset in webkit [94162] by yutak@chromium.org

3 edits in trunk/Source/WebCore

WebSocket: Load Blob in WebSocketChannel
https://bugs.webkit.org/show_bug.cgi?id=67013

Reviewed by Kent Tamura.

Add WebSocketChannel::enqueueBlobFrame(). It makes WebSocketChannel start loading a Blob
and send a WebSocket frame after the Blob is loaded.

While a Blob is being loaded, subsequent send() requests cannot be processed and are blocked.
Pending requests are stored in m_outgoingFrameQueue. When we have finished loading a Blob,
requests in the queue are allowed to get processed.

No new tests are added, because nobody uses enqueueBlobFrame() yet. New tests will be added
when WebSocket.send(Blob) is implemented, and they will cover this code change.

websockets/WebSocketChannel.cpp:

ref() is called when m_blobLoader is allocated, and deref() is called in didFinishLoading()
or didFail(). This is necessary because WebSocketChannel must be able to receive callbacks
from FileReaderLoader even if the channel is referred from no other objects.
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::didStartLoading):
(WebCore::WebSocketChannel::didReceiveData):
(WebCore::WebSocketChannel::didFinishLoading):
(WebCore::WebSocketChannel::didFail):
When we have failed to load a Blob, fail() is called, and eventually didCloseSocketStream()
will be called. It will clean up the pending requests in the queue.
(WebCore::WebSocketChannel::enqueueBlobFrame):
(WebCore::WebSocketChannel::processOutgoingFrameQueue):
(WebCore::WebSocketChannel::abortOutgoingFrameQueue):
Cancel the Blob loader when the outgoing request queue is about to be aborted. The loader
will not invoke didFail() callback once it is canceled, thus we need to call didFail()
manually so that we can free up the loader and decrement the reference count.

1:33 AM Changeset in webkit [94161] by yutak@chromium.org

9 edits
2 copies
3 adds in trunk

WebSocket: Receive binary message as ArrayBuffer
https://bugs.webkit.org/show_bug.cgi?id=67180

Reviewed by Kent Tamura.

Source/WebCore:

Tests: http/tests/websocket/tests/hybi/receive-arraybuffer.html

http/tests/websocket/tests/hybi/workers/receive-arraybuffer.html

bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data): Convert ArrayBuffer to JSValue.

bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter): Convert ArrayBuffer to v8::Value.

dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent):

dom/MessageEvent.h:

Added DataTypeArrayBuffer and ArrayBuffer-related functions.
(WebCore::MessageEvent::create):
(WebCore::MessageEvent::dataAsArrayBuffer):

websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveBinaryData):
Construct an ArrayBuffer from binaryData and raise MessageEvent.

LayoutTests:

http/tests/websocket/tests/hybi/receive-arraybuffer-expected.txt: Added.
http/tests/websocket/tests/hybi/receive-arraybuffer.html:

Added. Connect to binary-frames_wsh.py (which is also used from receive-blob.html) and
check the content of MessageEvent's data attribute.

http/tests/websocket/tests/hybi/receive-blob.html:

Update function names to match ones in receive-arraybuffer.html.

http/tests/websocket/tests/hybi/workers/receive-arraybuffer-expected.txt: Added.
http/tests/websocket/tests/hybi/workers/receive-arraybuffer.html: Added.
http/tests/websocket/tests/hybi/workers/resources/receive-arraybuffer.js: Added.
http/tests/websocket/tests/hybi/workers/resources/receive-blob.js:

Same as receive-blob.html above.

1:18 AM Changeset in webkit [94160] by commit-queue@webkit.org

1 edit
4 adds in trunk/Tools

Extract reference links from reftest test file.
https://bugs.webkit.org/show_bug.cgi?id=66838

Patch by Ai Makabi <makabi@google.com> on 2011-08-31
Reviewed by Shinichiro Hamaji.

Scripts/webkitpy/layout_tests/reftests/init.py: Added.
Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.

1:11 AM Changeset in webkit [94159] by Philippe Normand

11 edits
4 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline after r94109 and r93909.

platform/gtk/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
platform/gtk/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
platform/gtk/fast/multicol/inherit-column-values-expected.txt: Added.
platform/gtk/fast/multicol/initial-column-values-expected.txt: Added.
platform/gtk/fast/multicol/single-line-expected.txt:
platform/gtk/fast/multicol/table-vertical-align-expected.txt:
platform/gtk/fast/repaint/multicol-repaint-expected.txt:
platform/gtk/fast/table/table-before-child-in-table-expected.txt:
platform/gtk/fast/table/table-before-child-style-update-expected.txt: Added.
platform/gtk/fast/table/table-row-after-child-in-block-expected.txt:
platform/gtk/fast/table/table-row-after-child-in-table-expected.txt:
platform/gtk/fast/table/table-row-before-child-in-block-expected.txt:
platform/gtk/fast/table/table-row-before-child-in-table-expected.txt:
platform/gtk/fast/table/table-row-before-child-style-update-expected.txt: Added.

1:08 AM Changeset in webkit [94158] by keishi@webkit.org

9 edits
2 adds in trunk

input color: onchange event is not fired when changing color from color chooser
https://bugs.webkit.org/show_bug.cgi?id=66848

Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/color/input-color-onchange-event.html

WebCore.exp.in: Added calls used in Internals.cpp.
html/ColorInputType.cpp:

(WebCore::ColorInputType::colorSelected): Dispatch change event.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::connectToColorChooser): Added. Called from Internals::connectColorChooserClient.

html/HTMLInputElement.h:
testing/Internals.cpp:

(WebCore::Internals::connectColorChooserClient): Added. Connects element as client to color chooser.
(WebCore::Internals::selectColorInColorChooser): Added. Simulate color selection in color chooser.

testing/Internals.h:
testing/Internals.idl:

LayoutTests:

fast/forms/color/input-color-onchange-event-expected.txt: Added.
fast/forms/color/input-color-onchange-event.html: Added. Tests if change event is fired when user selects color from color chooser.

12:38 AM Changeset in webkit [94157] by Philippe Normand

5 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r94147.

platform/gtk/fast/dom/Window/window-properties-expected.txt:
platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
platform/gtk/fast/dom/prototype-inheritance-expected.txt:
platform/gtk/fast/js/global-constructors-expected.txt:

12:35 AM Changeset in webkit [94156] by commit-queue@webkit.org

10 edits in trunk/Source/WebCore

Implement Web IDL Constructor extended attribute in IDLParser.pm and CodeGeneratorV8.pm.
https://bugs.webkit.org/show_bug.cgi?id=66536

Patch by Kentaro Hara <haraken@google.com> on 2011-08-31
Reviewed by Adam Barth.

The spec is here: http://www.w3.org/TR/WebIDL/#Constructor

[1] Introduced Web IDL 'Constructor' extended attribute.

[2] Added 'ConstructorWith=ScriptExecutionContext' extended attribute.

The constructor passes ScriptExecutionContext to a XXX::create() method,

like XXX::create(..., context, ...).

[3] Added 'V8ConstructorSetsActiveDOMWrapper' extended attribute.

The constructor calls V8DOMWrapper::setJSWrapperForActiveDOMObject()

instead of V8DOMWrapper::setJSWrapperForDOMObject().

[4] Added 'ConstructorRaisesException' extended attribute.

A placeholder for ExceptionCode is passed to a XXX::create() method,

like XXX::create(..., ec).

We can use 'ConstructorRaisesException' and 'ConstructorWith=ScriptExecutionContext' together.

Note:

Constructor overloading is not yet implemented.
We cannot yet specify [Optional] without CallWithDefaultValue.

Test: Source/WebCore/bindings/scripts/test/TestInterface.idl

Source/WebCore/bindings/scripts/test/TestObj.idl

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader): Generates constructorCallback() header, if 'Constructor' is specified.
(GenerateFunctionCallback): Uses GenerateArgumentsCountCheck() and GenerateParametersCheck().
(GenerateArgumentsCountCheck): Splits out of GenerateFunctionCallback() for reuse.
(GenerateParametersCheck): Ditto.
(GenerateConstructorCallback): Generates constructorCallback() definition.
(GenerateImplementation):

bindings/scripts/IDLParser.pm:

(parseExtendedAttributes): Previously, only a string in the "A=B, C, D, E=F" format can be parsed. This patch enables to parse a string in the "A=B, C, D, E=F, G(in DOMString s, in [H, I, J] DOMString t)" format.
(parseParameters): Splits out of ParseInterface() for reuse.
(ParseInterface): Uses parseParameters().

bindings/scripts/IDLStructure.pm: Added domClass{constructor}. Changed the regular expression to extract the list of extended attributes.
bindings/scripts/test/TestInterface.idl: Added all the extended attributes that this patch is going to introduce.
bindings/scripts/test/TestObj.idl: Added 'Constructor'.
bindings/scripts/test/V8/V8TestInterface.cpp: Updated the test result.

(WebCore::V8TestInterface::constructorCallback):
(WebCore::ConfigureV8TestInterfaceTemplate):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: Ditto.
bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

(WebCore::V8TestObj::constructorCallback):

bindings/scripts/test/V8/V8TestObj.h: Ditto.

12:02 AM Changeset in webkit [94155] by Philippe Normand

15 edits in trunk/Source/WebCore

[GTK] gstreamer/ files directly related to the MediaPlayer need VIDEO guards
https://bugs.webkit.org/show_bug.cgi?id=67196

Reviewed by Martin Robinson.

Guard those files with ENABLE(VIDEO) so other features using
GStreamer can be built even with VIDEO disabled.

platform/graphics/gstreamer/GStreamerGWorld.cpp:
platform/graphics/gstreamer/GStreamerGWorld.h:
platform/graphics/gstreamer/ImageGStreamer.h:
platform/graphics/gstreamer/ImageGStreamerCG.mm:
platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
platform/graphics/gstreamer/ImageGStreamerQt.cpp:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
platform/graphics/gstreamer/PlatformVideoWindow.h:
platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp:
platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
platform/graphics/gstreamer/VideoSinkGStreamer.h:
platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
platform/graphics/gstreamer/WebKitWebSourceGStreamer.h:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed