⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 3, 2011:

10:43 PM Changeset in webkit [94500] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ThunkGenerators does not convert positive double zero into integer zero
​https://bugs.webkit.org/show_bug.cgi?id=67553

Reviewed by Gavin Barraclough.

This is an 0.5% speed-up on V8 and neutral elsewhere.

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::returnDouble):

7:58 PM Changeset in webkit [94499] by Laszlo Gombos
  • 8 edits in trunk/Source

REGRESSION (r86268): Fix for qt_networkAccessAllowed()
​https://bugs.webkit.org/show_bug.cgi?id=67570

Reviewed by Noam Rosenthal.

Source/WebCore:

No new tests as this change only removes dead code.
Support for Qt 4.6 has been removed a while back.

  • WebCore.pri:
  • WebCore.pro:
  • features.pri:
  • platform/network/NetworkStateNotifier.h:
  • platform/network/qt/NetworkStateNotifierQt.cpp:

Source/WebKit/qt:

Replace the ENABLE(QT_BEARER) guard with
!defined(QT_NO_BEARERMANAGEMENT) which is true by
default in Qt 4.7 or later versions.

  • Api/qwebsettings.cpp:

(qt_networkAccessAllowed):

4:31 PM Changeset in webkit [94498] by rniwa@webkit.org
  • 1 edit in trunk/LayoutTests/platform/mac/Skipped

Remove the corresponding entry from the skipped list.

4:30 PM Changeset in webkit [94497] by rniwa@webkit.org
  • 3 edits
    2 copies in trunk

REGRESSION(r94274): selection-change-closes-typing.html fails
​https://bugs.webkit.org/show_bug.cgi?id=67377

Reviewed by Kent Tamura.

Source/WebCore:

The problem was that when the shadow DOM is updated by setInnerTextValue, WebKit layer detects the selection
change and calls confirmCompositionWithoutDisturbingSelection, which in turn modifies the shadow DOM by
inserting text.

Fixed the bug by not inserting text in confirmCompositionWithoutDisturbingSelection. It turned out that this
function is only used to cancel composition but never to confirming composition and restoring selection.

Test: platform/mac/editing/input/selection-change-closes-typing-2.html

  • editing/Editor.cpp:

(WebCore::Editor::confirmCompositionWithoutDisturbingSelection):
(WebCore::Editor::confirmComposition):

LayoutTests:

Add a regression test to ensure the same bug doesn't exist in textarea element.

  • platform/mac/editing/input/selection-change-closes-typing-2-expected.txt: Copied from

LayoutTests/platform/mac/editing/input/selection-change-closes-typing-expected.txt.

  • platform/mac/editing/input/selection-change-closes-typing-2.html: Copied from

LayoutTests/platform/mac/editing/input/selection-change-closes-typing.html.

3:43 PM Changeset in webkit [94496] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Test that document.all.tags() matches IE behavior with too few arguments
​https://bugs.webkit.org/show_bug.cgi?id=66535

Patch by Mark Pilgrim <​pilgrim@chromium.org> on 2011-09-03
Reviewed by Darin Adler.

  • fast/dom/document-all-tags-expected.txt: Added.
  • fast/dom/document-all-tags.html: Added.
2:00 PM Changeset in webkit [94495] by robert@webkit.org
  • 4 edits
    4 adds in trunk/LayoutTests

Add platform-specific results for r94492

Unreviewed.

  • platform/chromium-win/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/gtk/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
  • platform/gtk/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Added.
  • platform/gtk/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/gtk/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
  • platform/mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
1:08 PM Changeset in webkit [94494] by kevino@webkit.org
  • 4 edits in trunk

[wx] Unreviewed build fix. Add wtf/dtoa directory to build.

12:26 PM Changeset in webkit [94493] by weinig@apple.com
  • 8 edits in trunk

Add missing Event constructors to DOMWindow.idl
​https://bugs.webkit.org/show_bug.cgi?id=67449

Reviewed by Anders Carlsson.

Source/WebCore:

Covered by existing tests.

  • page/DOMWindow.idl:

LayoutTests:

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-expected.txt:
  • platform/mac/fast/js/global-constructors-expected.txt:

Update results for new constructors.

11:28 AM Changeset in webkit [94492] by robert@webkit.org
  • 8 edits
    12 adds in trunk

div align="center" rendering problem
​https://bugs.webkit.org/show_bug.cgi?id=4860

Reviewed by David Hyatt.

Source/WebCore:

When an inline element with absolute position was the sole or first child of a render block with
centred alignment, it wasn't obeying its parent's alignment. However it would obey the
alignment if it was preceded by some text. The problem was that the element's render object
was getting skipped as leading white space, so it was not included in a normal line block in
a bidi run. Instead, its position was getting set by RenderBlockLineLayout::setStaticPositions()
which does not pay attention to alignment. Preceding the element with some text allowed the object
to get included in a Bidi run and so get a linebox which would get properly aligned.

The fix is to get RenderBlockLineLayout::setStaticPositions() to obey the alignment specified by
the object's container. This allows WebKit to get the same result on the test as Firefox and IE.
Opera has the same bug as unpatched WebKit.

Tests: fast/css/bug4860-absolute-block-child-does-not-inherit-alignment.html

  • Ensure positioned block elements inherit alignment. fast/css/bug4860-absolute-inline-child-inherits-alignment.html
  • Ensure positioned inline elements inherit alignment. fast/inline/absolute-positioned-inline-in-centred-block.html
  • Ensure positioned inline element that's the sole or first child of a rendered block obeys parents alignment. fast/inline/absolute-positioned-block-in-centred-block.html
  • As above, but a positioned block should not inherit alignment.
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::updateLogicalWidthForAlignment):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Move the alignment check to updateLogicalWidthForAlignment.
(WebCore::setStaticPositions): use startAlignedOffsetForLine and use startAlignedOffsetForBlock
(WebCore::RenderBlock::startAlignedOffsetForLine): New function, find the aligned offset using updateLogicalWidthForAlignment

LayoutTests:

  • fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.png: Added.
  • fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Added.
  • fast/css/bug4860-absolute-block-child-does-not-inherit-alignment.html: Added.
  • fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.png: Added.
  • fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Added.
  • fast/css/bug4860-absolute-inline-child-inherits-alignment.html: Added.
  • fast/inline/absolute-positioned-block-in-centred-block-expected.png: Added.
  • fast/inline/absolute-positioned-block-in-centred-block-expected.txt: Added.
  • fast/inline/absolute-positioned-block-in-centred-block.html: Added.
  • fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
  • fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • fast/inline/absolute-positioned-inline-in-centred-block.html: Added.
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Both of these two tests were based on the incorrect behaviour of ignoring the alignment specified by the container of an element absolute position when there was no text preceding the element. The updated results agree with Firefox and IE.
  • fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt:
  • platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: This test expected the wrong alignment of the red block - it should be centred, not aligned to the left.
11:18 AM Changeset in webkit [94491] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

Remove two unused functions from Element.
​https://bugs.webkit.org/show_bug.cgi?id=67492

Reviewed by Benjamin Poulain.

Removed openTagStartToString() and setCStringAttribute() as they are
not called from anywhere.

  • dom/Element.cpp:
  • dom/Element.h:
10:13 AM Changeset in webkit [94490] by mitz@apple.com
  • 2 edits in trunk/Tools

32-bit build fix.

  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::toSTD):

9:13 AM Changeset in webkit [94489] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Enable support for WebGL OES_standard_derivatives for Qt
​https://bugs.webkit.org/show_bug.cgi?id=67430

Patch by Andrew Wason <​rectalogic@rectalogic.com> on 2011-09-03
Reviewed by Noam Rosenthal.

Tested using ​https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/extensions/oes-standard-derivatives.html

Enable existing support for OES_standard_derivatives for Qt.

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::ensureEnabled):
(WebCore::Extensions3DOpenGL::isEnabled):

8:57 AM Changeset in webkit [94488] by mitz@apple.com
  • 5 edits
    1 add in trunk/Tools

Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
​https://bugs.webkit.org/show_bug.cgi?id=67559

Reviewed by Darin Adler.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
the call to it.

  • TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
  • TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.

(TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.

  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::toSTD): Added.

1:29 AM Changeset in webkit [94487] by abarth@webkit.org
  • 6 edits in trunk/Tools

garden-o-matic results view should have a better results selector
​https://bugs.webkit.org/show_bug.cgi?id=67542

Reviewed by Dimitri Glazkov.

This patch adds a basic grid-based results selector to the results
view. Currently, this grid just shows how the tests fail on the
various bots. A future patch will let you select which failure to view
and to mark the failures for rebaselining.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
    • Add some more basic functions for manipulating dictionaries.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1:27 AM Changeset in webkit [94486] by abarth@webkit.org
  • 5 edits in trunk/Tools

garden-o-matic results view should show Actual and Expected results for text failures
​https://bugs.webkit.org/show_bug.cgi?id=67536

Reviewed by Eric Seidel.

In the past, we didn't show actual and expected text results (we just
showed the diff) because we didn't have the awesome six-by-two results
grid. Now that we do, we can move show these results.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
    • Fixed some typos that were preventing these unit tests from running.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:

(.):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
    • Report -actual.txt and -expected.txt as possible results URLs.
1:25 AM Changeset in webkit [94485] by abarth@webkit.org
  • 4 edits in trunk/Tools

garden-o-matic shows "ghost" failures that are already fixed
​https://bugs.webkit.org/show_bug.cgi?id=67535

Reviewed by Eric Seidel.

About 10% of writes fail to stick on test-results.appspot.com. This
patch causes us to fetch the full_results.json blob directly from
build.chromium.org rather than relying upon AppEngine.

Unforuntately, we still need to get historical information from
AppEngine. That will take several patches to fix becuase I need to
change the bots to write the full_results.json file to the
build-specific directory in addition to the zip file.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
12:49 AM Changeset in webkit [94484] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG variable predictions only work for local variables, not temporaries
​https://bugs.webkit.org/show_bug.cgi?id=67554

Reviewed by Gavin Barraclough.

This appears to be a slight speed-up in Kraken (0.3% but significant)
and neutral elsewhere.

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):

12:45 AM Changeset in webkit [94483] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r94458.
​http://trac.webkit.org/changeset/94458
​https://bugs.webkit.org/show_bug.cgi?id=67558

Caused appcache test to fail on various bots (Requested by
rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-03

  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
12:45 AM Changeset in webkit [94482] by yutak@chromium.org
  • 18 edits
    1 copy
    2 moves
    4 adds in trunk

WebSocket: Send ArrayBuffer as WebSocket binary message
​https://bugs.webkit.org/show_bug.cgi?id=67477

Reviewed by Kent Tamura.

Source/WebCore:

Tests: http/tests/websocket/tests/hybi/send-arraybuffer.html

http/tests/websocket/tests/hybi/workers/send-arraybuffer.html
http/tests/websocket/tests/hybi/bufferedAmount-after-close.html (updated)

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::send):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::sendCallback):

  • websockets/ThreadableWebSocketChannel.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::sendRequestResult):
(WebCore::ThreadableWebSocketChannelClientWrapper::setSendRequestResult):

  • websockets/ThreadableWebSocketChannelClientWrapper.h:

Rename "sent" to "sendRequestResult" to clarify the meaning. Messages from the script may not
be sent immediately, thus the return value of WebSocketChannel::send() indicates whether the
message has been queued successfully, rather than whether the message has been sent or not.

  • websockets/WebSocket.cpp:

(WebCore::WebSocket::send):
Case of sending "[object ArrayBuffer]" is covered by an existing test
http/tests/websocket/tests/{hybi,hixie76}/send-object.html.

  • websockets/WebSocket.h:
  • websockets/WebSocket.idl:
  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):

  • websockets/WebSocketChannel.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::workerContextDidSend):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendArrayBuffer):
Construct an ArrayBuffer from the data on Vector<char>.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
Copy the content into temporary buffer of Vector<char>, and send it to the main thread.

  • websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:

Add tests to send ArrayBuffers.

  • http/tests/websocket/tests/hybi/check-binary-messages_wsh.py:

Renamed from LayoutTests/http/tests/websocket/tests/hybi/send-blob_wsh.py, because this handler
is used from send-blob.html and send-arraybuffer.html.

  • http/tests/websocket/tests/hybi/send-arraybuffer-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-arraybuffer.html:

Added. Send three small binary messages as ArrayBuffers.

  • http/tests/websocket/tests/hybi/send-blob.html:
  • http/tests/websocket/tests/hybi/workers/resources/check-binary-messages_wsh.py:

Renamed from LayoutTests/http/tests/websocket/tests/hybi/workers/resources/send-blob_wsh.py.

  • http/tests/websocket/tests/hybi/workers/resources/send-arraybuffer.js:

Added. Same as send-arraybuffer.html, except that this test is run on the worker.

  • http/tests/websocket/tests/hybi/workers/resources/send-blob.js:

Removed the definition of unnecessary function startsWith().

  • http/tests/websocket/tests/hybi/workers/send-arraybuffer-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/send-arraybuffer.html: Added
12:29 AM Changeset in webkit [94481] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r94453.
​http://trac.webkit.org/changeset/94453
​https://bugs.webkit.org/show_bug.cgi?id=67557

Caused appcache test to fail on various bots (Requested by
rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-03

  • Scripts/webkitpy/layout_tests/port/webkit.py:

Sep 2, 2011:

11:04 PM Changeset in webkit [94480] by commit-queue@webkit.org
  • 6 edits in trunk

Implement a CustomEvent constructor for V8
​https://bugs.webkit.org/show_bug.cgi?id=67527

Patch by Kentaro Hara <​haraken@google.com> on 2011-09-02
Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/events/constructors/custom-event-constructor.html

  • bindings/v8/OptionsObject.h:

(WebCore::OptionsObject::getKeyValue): Returns ScriptValue corresponding to a given key.

  • bindings/v8/custom/V8EventConstructors.cpp: Added the CustomEvent constructor.
  • dom/CustomEvent.idl: Added a 'V8CustomConstructor' attribute.

LayoutTests:

  • platform/chromium/fast/events/constructors/custom-event-constructor-expected.txt: Updated the result.
10:45 PM Changeset in webkit [94479] by abarth@webkit.org
  • 4 edits
    1 delete in trunk/Source/WebKit/chromium

Remove WebKitClient.h
​https://bugs.webkit.org/show_bug.cgi?id=67539

Reviewed by Sam Weinig.

This API no longer has any callers.

  • WebKit.gyp:
  • public/WebKit.h:
  • public/WebKitClient.h: Removed.
  • src/WebKit.cpp:
10:23 PM Changeset in webkit [94478] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG JIT speculation failure does recovery of additions in reverse and
doesn't rebox
​https://bugs.webkit.org/show_bug.cgi?id=67551

Reviewed by Sam Weinig.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):

10:14 PM Changeset in webkit [94477] by fpizlo@apple.com
  • 10 edits
    1 add in trunk/Source/JavaScriptCore

ValueProfile does not make it safe to introspect cell values
after garbage collection
​https://bugs.webkit.org/show_bug.cgi?id=67354

Reviewed by Gavin Barraclough.

ValueProfile buckets are now weak references, implemented using a
light-weight weak reference mechanism that this patch also adds (the
WeakReferenceHarvester). If a cell stored in a ValueProfile bucket
is not marked, then the bucket is transformed into a Structure
pointer. If the Structure is not marked either, then it is turned
into a ClassInfo pointer.

(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::visitWeakReferences):

  • bytecode/CodeBlock.h:
  • bytecode/ValueProfile.h:

(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfile::classInfo):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfCells):
(JSC::ValueProfile::numberOfArrays):
(JSC::ValueProfile::probabilityOfArray):
(JSC::ValueProfile::WeakBucket::WeakBucket):
(JSC::ValueProfile::WeakBucket::operator!):
(JSC::ValueProfile::WeakBucket::isEmpty):
(JSC::ValueProfile::WeakBucket::isClassInfo):
(JSC::ValueProfile::WeakBucket::isStructure):
(JSC::ValueProfile::WeakBucket::asStructure):
(JSC::ValueProfile::WeakBucket::asClassInfo):
(JSC::ValueProfile::WeakBucket::getClassInfo):

  • heap/Heap.cpp:

(JSC::Heap::harvestWeakReferences):
(JSC::Heap::markRoots):

  • heap/Heap.h:
  • heap/MarkStack.cpp:

(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::harvestWeakReferences):

  • heap/MarkStack.h:

(JSC::MarkStack::addWeakReferenceHarvester):
(JSC::MarkStack::MarkStack):
(JSC::MarkStack::appendUnbarrieredPointer):

  • heap/SlotVisitor.h:
  • heap/WeakReferenceHarvester.h: Added.

(JSC::WeakReferenceHarvester::WeakReferenceHarvester):
(JSC::WeakReferenceHarvester::~WeakReferenceHarvester):

6:20 PM Changeset in webkit [94476] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit2

Unreviewed, rolling out r94473.
​http://trac.webkit.org/changeset/94473
​https://bugs.webkit.org/show_bug.cgi?id=67547

Putting ​http://trac.webkit.org/changeset/94454 back in as
​http://trac.webkit.org/changeset/94472 fixed the problem
(Requested by msaboff on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-02

  • UIProcess/API/C/WKContext.cpp:

(WKContextGarbageCollectJavaScriptObjects):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::garbageCollectJavaScriptObjects):

  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::garbageCollectJavaScriptObjects):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
6:08 PM Changeset in webkit [94475] by msaboff@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Replace local implementation of string equals() methods with UString versions
​https://bugs.webkit.org/show_bug.cgi?id=67342

In preparation to allowing StringImpl to be backed by 8 bit
characters when appropriate, we need to eliminate or change the
usage of StringImpl::characters(). Change the uses of characters()
that are used to implement redundant equals() methods.

Reviewed by Gavin Barraclough.

  • runtime/Identifier.cpp:

(JSC::Identifier::equal):

  • runtime/Identifier.h:

(JSC::Identifier::equal):

  • wtf/text/AtomicString.cpp:

(WTF::CStringTranslator::equal): Moved an optimized method to here.
(WTF::operator==):

  • wtf/text/StringImpl.cpp:

(WTF::equal):

  • wtf/text/StringImpl.h:
6:06 PM Changeset in webkit [94474] by enne@google.com
  • 13 edits
    2 adds in trunk/Source/WebCore

[chromium] Move updateLayers from LayerRendererChromium to CCLayerTreeHost
​https://bugs.webkit.org/show_bug.cgi?id=67438

Reviewed by James Robinson.

Covered by existing tests.

Move functionality used by both CCLayerTreeHost and
LayerRendererChromium into CCLayerTreeHostCommon. Move update, paint,
and updateCompositorResource functions into CClayerTreeHost.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::sortLayers):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::textureMemoryReclaimLimit):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::sortLayers):

  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp: Added.

(WebCore::CCLayerTreeHostCommon::isScaleOrTranslation):
(WebCore::CCLayerTreeHostCommon::calculateVisibleRect):
(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h: Added.

(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::commitIfNeeded):

6:02 PM Changeset in webkit [94473] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit2

Unreviewed, rolling out r94454.
​http://trac.webkit.org/changeset/94454
​https://bugs.webkit.org/show_bug.cgi?id=67546

"Broke Windows and SnowLeopard, also no reply on the bug."
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-02

  • UIProcess/API/C/WKContext.cpp:
  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:
  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp:
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
6:01 PM Changeset in webkit [94472] by msaboff@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-09-02 Michael Saboff <​msaboff@apple.com>

Fixed release build by removing #ifndef NDEBUG to
allow definition of gcController().

Rubber-stamp by Sam Weinig.

  • WebProcess/WebProcess.cpp:
5:42 PM Changeset in webkit [94471] by cmarrin@apple.com
  • 3 edits
    2 adds in trunk

2011-09-02 Chris Marrin <​cmarrin@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=67510
Crash can occur when doing a PlatformCAAnimation::copy() with no valueFunction

Reviewed by Simon Fraser.


Do a null check in two places to avoid sending nulls to CACF ValueFunction API.

Test: animations/pause-crash.html

  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp: (PlatformCAAnimation::valueFunction): (PlatformCAAnimation::setValueFunction):
5:41 PM Changeset in webkit [94470] by msaboff@apple.com
  • 4 edits
    4 adds in trunk

Add JSC:RegExp functional tests
​https://bugs.webkit.org/show_bug.cgi?id=67339

Source/JavaScriptCore:

Added new test driver program (testRegExp) and corresponding data file
along with build scripts changes.

Reviewed by Gavin Barraclough.

(Options::Options):
(StopWatch::start):
(StopWatch::stop):
(StopWatch::getElapsedMS):
(RegExpTest::RegExpTest):
(GlobalObject::create):
(GlobalObject::className):
(GlobalObject::GlobalObject):
(main):
(cleanupGlobalData):
(testOneRegExp):
(scanString):
(parseRegExpLine):
(parseTestLine):
(runFromFiles):
(printUsageStatement):
(parseArguments):
(realMain):

  • tests/regexp: Added.
  • tests/regexp/RegExpTest.data: Added.

Tools:

New perl script to build JavaScriptCore and run the RegExp tests.

Reviewed by Gavin Barraclough.

  • Scripts/run-regexp-tests: Added.
5:31 PM Changeset in webkit [94469] by jamesr@google.com
  • 2 edits
    3 deletes in trunk/LayoutTests

[chromium] Update baselines and expectations.

  • platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
5:20 PM Changeset in webkit [94468] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add JSC:RegExp functional test data generator
​https://bugs.webkit.org/show_bug.cgi?id=67519

Add a data generator for regular expressions. To enable, change the
#undef REGEXP_FUNC_TEST_DATA_GEN to #define. Then compile and use
regular expressions. The resulting data will be in /tmp/RegExpTestsData.

Reviewed by Gavin Barraclough.

  • runtime/RegExp.cpp:

(JSC::regExpFlags):
(JSC::RegExpFunctionalTestCollector::clearRegExp):
(JSC::RegExpFunctionalTestCollector::get):
(JSC::RegExpFunctionalTestCollector::outputOneTest):
(JSC::RegExpFunctionalTestCollector::RegExpFunctionalTestCollector):
(JSC::RegExpFunctionalTestCollector::~RegExpFunctionalTestCollector):
(JSC::RegExpFunctionalTestCollector::outputEscapedUString):
(JSC::RegExp::~RegExp):
(JSC::RegExp::compile):
(JSC::RegExp::match):
(JSC::RegExp::matchCompareWithInterpreter):

5:20 PM Changeset in webkit [94467] by enne@google.com
  • 1 edit in branches/chromium/835/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp

[chromium] Fix crash when compositing is disabled during painting
​https://bugs.webkit.org/show_bug.cgi?id=66981

Reviewed by James Robinson.

This fixes a use-after-free and a null pointer deref introduced by r93940.
See also: ​http://codereview.chromium.org/7739008/

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::clearRootCCLayerImpl):
(WebCore::LayerRendererChromium::updateLayers):

5:17 PM Changeset in webkit [94466] by commit-queue@webkit.org
  • 13 edits
    3 copies
    1 add in trunk/Source

Source/WebCore: Add a 'didDownloadData' method to ResourceLoader, SubresourceLoader,
SubresourceLoaderClient, DocumentThreadableLoader, ResourceHandleClient,
and ThreadableLoaderClient for the Chromium port only, so we can pass
these notifications from our ResourceHandle implementation through the
WebCore loader framework.
​https://bugs.webkit.org/show_bug.cgi?id=67229

Patch by Bill Budge <​bbudge@chromium.org> on 2011-09-02
Reviewed by Darin Fisher.

No new tests. Exposes no new functionality.

  • WebCore.gypi:
  • loader/DocumentThreadableLoader.h:
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h:

(WebCore::SubresourceLoaderClient::didDownloadData):

  • loader/ThreadableLoaderClient.h:

(WebCore::ThreadableLoaderClient::didDownloadData):

  • loader/ThreadableLoaderClientWrapper.h:

(WebCore::ThreadableLoaderClientWrapper::didDownloadData):

  • loader/chromium: Added.
  • loader/chromium/DocumentThreadableLoaderChromium.cpp: Added.

(WebCore::DocumentThreadableLoader::didDownloadData):

  • loader/chromium/ResourceLoaderChromium.cpp: Added.

(WebCore::ResourceLoader::didDownloadData):

  • loader/chromium/SubresourceLoaderChromium.cpp: Added.

(WebCore::SubresourceLoader::didDownloadData):

  • platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::didDownloadData):

Source/WebKit/chromium: Add a 'didDownloadData' method to ResourceHandleInternal and pass these
notifications to WebURLLoaderClients.
​https://bugs.webkit.org/show_bug.cgi?id=67229

Patch by Bill Budge <​bbudge@chromium.org> on 2011-09-02
Reviewed by Darin Fisher.

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter):
(WebKit::AssociatedURLLoader::ClientAdapter::didDownloadData):
(WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
(WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading):

  • src/ResourceHandle.cpp:

(WebCore::ResourceHandleInternal::didDownloadData):

  • src/ResourceHandleInternal.h:
5:16 PM Changeset in webkit [94465] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Assert that PlatformCALayerWinInternal::displayCallback() is only called on the main thread
​https://bugs.webkit.org/show_bug.cgi?id=67541

Reviewed by Simon Fraser.

No new tests, covered by existing media tests.

  • platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::displayCallback): Assert that is function is only called on the main thread.

5:07 PM Changeset in webkit [94464] by jchaffraix@webkit.org
  • 6 edits
    2 adds in trunk

Enable RenderLayer::updateLayerPosition's cachedOffset optimization for more cases
​https://bugs.webkit.org/show_bug.cgi?id=66901

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/layers/assert-RenderLayer-update-positions.html

Also covered by existing tests under the new ASSERT.

This change extends the range of callers making use of the cachedOffset optimization.

Most callers did not make use of cachedOffset as it did not work when called on a subtree.
This limitation is now gone thus we can enable it more widely.

The semantics of the optimization are changed a bit as we now return if it is enabled whereas
the old code would check if it was *disabled*. Also there were some renames done to match more
closely what was going on (s/cachedOffset/offsetFromRoot/ and s/cachedOffsetDisabled/hasLayerOffset/).

Note that this is an optimistic optimization: if cachedOffset is not used, then we have
done at least an extra traversal up to the root. I have found it to be a wash on file
cycler (alexa) but to be a nice improvement (~20%) on some table benchmarks (modifying
a cell, scrolling).

  • page/FrameView.cpp:

(WebCore::FrameView::layout): Extended the use of cachedOffset to subtree layouts.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleDidChange): Forbid the use cachedOffset in this
case as we have only a single layer to update.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::computeOffsetFromRoot): Added this function to get the offset from the root
layer at a certain point in the RenderLayer's tree. It gets the root layer's checking if no layer
in between would prevent convertToLayerCoords to work and return the position relative to
this layer.

(WebCore::RenderLayer::updateLayerPositions): Added a new ASSERT to make sure our cachedOffset
is always fine. Also added a comment about calling convertToLayerCoords.

(WebCore::RenderLayer::removeOnlyThisLayer): Added cachedOffset here too as we may have to
update several layers. We save the offset prior to being removed from the hierarchy for
correctness.

(WebCore::RenderLayer::paintChildLayerIntoColumns): Added a comment here about calling convertToLayerCoords.

  • rendering/RenderLayer.h: Swapped the argument in updateLayerPositions to make

cachedOffset a mandatory field. Patched all the callers.

(WebCore::RenderLayer::canUseConvertToLayerCoords): Added this helper method to know when a
renderer prevents convertToLayerCoords from working. Added some FIXME around suspicious use
of convertToLayerCoords.

LayoutTests:

  • fast/layers/crash-RenderLayer-update-positions-expected.txt: Added.
  • fast/layers/crash-RenderLayer-update-positions.html: Added.

Test that some changes in the layers does not cause an ASSERT failure.

4:58 PM Changeset in webkit [94463] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Fix the broken build due to dtoa patch
​https://bugs.webkit.org/show_bug.cgi?id=67534

Patch by Mark Hahnenberg <​mhahnenberg@apple.com> on 2011-09-02
Reviewed by Oliver Hunt.

Fixing the build.

  • GNUmakefile.list.am:
  • wtf/dtoa/bignum.cc:
  • wtf/dtoa/fast-dtoa.cc:
  • wtf/dtoa/utils.h:
4:39 PM Changeset in webkit [94462] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt][Symbian] REGRESSION(93235) Missing .def update
​https://bugs.webkit.org/show_bug.cgi?id=67307

Patch by Jade Han <​jade.han@nokia.com> on 2011-09-02
Reviewed by Laszlo Gombos.

  • symbian/eabi/QtWebKitu.def:
4:33 PM Changeset in webkit [94461] by oliver@apple.com
  • 9 edits
    2 deletes in trunk/Source/JavaScriptCore

Remove OldSpace classes
​https://bugs.webkit.org/show_bug.cgi?id=67533

Reviewed by Gavin Barraclough.

Remove the unused OldSpace classes

(JSC::Heap::writeBarrierSlowCase):

  • heap/MarkedBlock.h:
  • heap/OldSpace.cpp: Removed.
  • heap/OldSpace.h: Removed.
4:25 PM Changeset in webkit [94460] by jamesr@google.com
  • 2 edits in trunk/Source/JavaScriptCore

Compile fix for mac build.

  • wtf/CheckedArithmetic.h:

(WTF::operator+):
(WTF::operator-):
(WTF::operator*):

4:07 PM Changeset in webkit [94459] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

Need API for getting surrounding text from webkit in chromium
​https://bugs.webkit.org/show_bug.cgi?id=66681

Patch by Peng Huang <​penghuang@chromium.org> on 2011-09-02
Reviewed by Ryosuke Niwa.

Add getSelectionOffsetsAndTextInEditableContent() to Chromium's
WebViewImpl. This function is for supporting some input methods which
need input context around the edit caret.

  • public/WebWidget.h:

(WebKit::WebWidget::getSelectionOffsetsAndTextInEditableContent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::getSelectionOffsetsAndTextInEditableContent):

  • src/WebViewImpl.h:
3:33 PM Changeset in webkit [94458] by eric@webkit.org
  • 3 edits in trunk/Tools

Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
​https://bugs.webkit.org/show_bug.cgi?id=67530

Unreviewed. Fixing typo from previous commit.

Turns out there was *no* unittesting of WebKitDriver. Added a basic test of _read_block
which exercises the code I previously made a typo in.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3:32 PM Changeset in webkit [94457] by mdelaney@apple.com
  • 12 edits
    2 adds in trunk

Read out of bounds in sUnpremultiplyData_RGBA8888 / ImageBufferData::getData
​https://bugs.webkit.org/show_bug.cgi?id=65352

Reviewed by Simon Fraser.

New test: fast/canvas/canvas-getImageData-large-crash.html

Source/JavaScriptCore:

This patch prevents overflows from happening in getImageData, createImageData, and canvas creation
calls that specify widths and heights that end up overflowing the ints that we store those values in
as well as derived values such as area and maxX / maxY of the bounding rects involved. Overflow of integer
arithmetic is detected via the use of the new Checked type that was introduced in r94207. The change to JSC
is just to add a new helper method described below.

  • wtf/MathExtras.h:

(isWithinIntRange): Reports if a float's value is within the range expressible by an int.

Source/WebCore:

This patch prevents overflows from happening in getImageData, createImageData, and canvas creation
calls that specify widths and heights that end up overflowing the ints that we store those values in
as well as derived values such as area and maxX / maxY of the bounding rects involved. Overflow of integer
arithmetic is detected via the use of the new Checked type that was introduced in r94207.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::convertLogicalToDevice): Removed dependency on ints, using FloatRects/Sizes instead.
(WebCore::HTMLCanvasElement::createImageBuffer): Moved the check for max canvas area and dimensions here.

Added in check that prevents us from having canvases of sizes that will cause overflows.

(WebCore::HTMLCanvasElement::baseTransform): Updated use of convertLogicalToDevice.

  • html/HTMLCanvasElement.h: Updated method signatures.
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::createEmptyImageData): Added in check to prevent creating ImageData objects that will cause overflow when computing their size.
(WebCore::CanvasRenderingContext2D::createImageData): Avoid creating ImageData objects of size that will overflow later.
(WebCore::CanvasRenderingContext2D::getImageData): Added in check to prevent trying to get ImageData objects that will cause overflow when computing their size.

  • platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::isExpressibleAsIntRect): New method that tests whether a FloatRect can become an IntRect without overflow or having to be clamped.

  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.cpp:

(WebCore::FloatSize::isExpressibleAsIntSize): Same as FloatRect, but for FloatSize->IntSize.

  • platform/graphics/FloatSize.h:
  • platform/graphics/cg/ImageBufferCG.cpp: Added check for overflow.

(WebCore::ImageBuffer::ImageBuffer):

3:22 PM Changeset in webkit [94456] by andersca@apple.com
  • 14 edits
    1 add in trunk/Source/WebKit2

NPN_SetException doesn't work with OOP plug-ins
​https://bugs.webkit.org/show_bug.cgi?id=67524

Reviewed by Sam Weinig.

  • DerivedSources.make:

Add PluginProcessConnection.messages.in.

  • GNUmakefile.am:

Add generated files.

  • Platform/CoreIPC/MessageID.h:

Add MessageClassPluginProcessConnection.

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::initialize):
Set the set exception function.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::ConnectionStack::current):
(WebKit::ConnectionStack::CurrentConnectionPusher::CurrentConnectionPusher):
(WebKit::ConnectionStack::CurrentConnectionPusher::~CurrentConnectionPusher):
Add a helper class for managing a stack of CoreIPC connections, along with a RAII
object to push/pop connections onto it.

(WebKit::connectionStack):
Add getter.

(WebKit::WebProcessConnection::setGlobalException):
Get the current connection and send a PluginProcessConnection::SetException message to it.

(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::didReceiveSyncMessage):
Create connection pushers.

  • PluginProcess/WebProcessConnection.h:

Add setGlobalException.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::setSetExceptionFunction):
New function for setting the 'setException' function.

(WebKit::NetscapePlugin::setException):
Call the 'setException' function.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::didReceiveSyncMessage):
Call the message receiver function.

(WebKit::PluginProcessConnection::setException):
Call the NPRuntimeObjectMap.

  • WebProcess/Plugins/PluginProcessConnection.messages.in:

Add new messages file.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
When not using the plug-in process, make sure to call NetscapePlugin::setSetExceptionFunction.

3:22 PM Changeset in webkit [94455] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/9755843> anonymous RenderMathMLOperator sets itself as the renderer of its parent mfenced node

Reviewed by Darin Adler.

Source/WebCore:

Test: mathml/operator-hijacks-fenced-node.xhtml

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::updateFromElement): Rather than unconditionally setting the
node’s renderer to this, just restore it to whatever it was before calling destroyLeftoverChildren().

LayoutTests:

  • mathml/operator-hijacks-fenced-node-expected.txt: Added.
  • mathml/operator-hijacks-fenced-node.xhtml: Added.
3:21 PM Changeset in webkit [94454] by adachan@apple.com
  • 8 edits in trunk/Source/WebKit2

Add WKContextGarbageCollectJavaScriptObjects() which does a garbage collection in the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=67526

Reviewed by Darin Adler.

  • UIProcess/API/C/WKContext.cpp:

(WKContextGarbageCollectJavaScriptObjects):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::garbageCollectJavaScriptObjects): Send a message to WebProcess to garbage collect JS objects.

  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::garbageCollectJavaScriptObjects): Call GCController::garbageCollectNow().

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in: Add GarbageCollectJavaScriptObjects message.
3:19 PM Changeset in webkit [94453] by eric@webkit.org
  • 2 edits in trunk/Tools

Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
​https://bugs.webkit.org/show_bug.cgi?id=67530

Reviewed by Adam Barth.

No functional change, just reshuffling code.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
3:09 PM Changeset in webkit [94452] by commit-queue@webkit.org
  • 23 edits
    24 adds in trunk/Source

Incorporate newer, faster dtoa library
​https://bugs.webkit.org/show_bug.cgi?id=66346

Patch by Mark Hahnenberg <​mhahnenberg@apple.com> on 2011-09-02
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Added new dtoa library at ​http://code.google.com/p/double-conversion/.
Replaced old call to dtoa. The new library is much faster than the old one.
We still use the old dtoa for some stuff in WebCore as well as the old strtod,
but we can phase these out eventually as well.

(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):

  • runtime/UString.cpp:

(JSC::UString::number):

  • wtf/CMakeLists.txt:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):

  • wtf/ThreadingWin.cpp:

(WTF::initializeThreading):

  • wtf/dtoa.cpp:

(WTF::dtoa):

  • wtf/dtoa.h:
  • wtf/dtoa/COPYING: Added.
  • wtf/dtoa/LICENSE: Added.
  • wtf/dtoa/README: Added.
  • wtf/dtoa/bignum-dtoa.cc: Added.
  • wtf/dtoa/bignum-dtoa.h: Added.
  • wtf/dtoa/bignum.cc: Added.
  • wtf/dtoa/bignum.h: Added.

(WTF::double_conversion::Bignum::Times10):
(WTF::double_conversion::Bignum::Equal):
(WTF::double_conversion::Bignum::LessEqual):
(WTF::double_conversion::Bignum::Less):
(WTF::double_conversion::Bignum::PlusEqual):
(WTF::double_conversion::Bignum::PlusLessEqual):
(WTF::double_conversion::Bignum::PlusLess):
(WTF::double_conversion::Bignum::EnsureCapacity):
(WTF::double_conversion::Bignum::BigitLength):

  • wtf/dtoa/cached-powers.cc: Added.
  • wtf/dtoa/cached-powers.h: Added.
  • wtf/dtoa/diy-fp.cc: Added.
  • wtf/dtoa/diy-fp.h: Added.

(WTF::double_conversion::DiyFp::DiyFp):
(WTF::double_conversion::DiyFp::Subtract):
(WTF::double_conversion::DiyFp::Minus):
(WTF::double_conversion::DiyFp::Times):
(WTF::double_conversion::DiyFp::Normalize):
(WTF::double_conversion::DiyFp::f):
(WTF::double_conversion::DiyFp::e):
(WTF::double_conversion::DiyFp::set_f):
(WTF::double_conversion::DiyFp::set_e):

  • wtf/dtoa/double-conversion.cc: Added.
  • wtf/dtoa/double-conversion.h: Added.

(WTF::double_conversion::DoubleToStringConverter::DoubleToStringConverter):
(WTF::double_conversion::StringToDoubleConverter::StringToDoubleConverter):

  • wtf/dtoa/double.h: Added.

(WTF::double_conversion::double_to_uint64):
(WTF::double_conversion::uint64_to_double):
(WTF::double_conversion::Double::Double):
(WTF::double_conversion::Double::AsDiyFp):
(WTF::double_conversion::Double::AsNormalizedDiyFp):
(WTF::double_conversion::Double::AsUint64):
(WTF::double_conversion::Double::NextDouble):
(WTF::double_conversion::Double::Exponent):
(WTF::double_conversion::Double::Significand):
(WTF::double_conversion::Double::IsDenormal):
(WTF::double_conversion::Double::IsSpecial):
(WTF::double_conversion::Double::IsNan):
(WTF::double_conversion::Double::IsInfinite):
(WTF::double_conversion::Double::Sign):
(WTF::double_conversion::Double::UpperBoundary):
(WTF::double_conversion::Double::NormalizedBoundaries):
(WTF::double_conversion::Double::value):
(WTF::double_conversion::Double::SignificandSizeForOrderOfMagnitude):
(WTF::double_conversion::Double::Infinity):
(WTF::double_conversion::Double::NaN):
(WTF::double_conversion::Double::DiyFpToUint64):

  • wtf/dtoa/fast-dtoa.cc: Added.
  • wtf/dtoa/fast-dtoa.h: Added.
  • wtf/dtoa/fixed-dtoa.cc: Added.
  • wtf/dtoa/fixed-dtoa.h: Added.
  • wtf/dtoa/strtod.cc: Added.
  • wtf/dtoa/strtod.h: Added.
  • wtf/dtoa/utils.h: Added.

(WTF::double_conversion::Max):
(WTF::double_conversion::Min):
(WTF::double_conversion::StrLength):
(WTF::double_conversion::Vector::Vector):
(WTF::double_conversion::Vector::SubVector):
(WTF::double_conversion::Vector::length):
(WTF::double_conversion::Vector::is_empty):
(WTF::double_conversion::Vector::start):
(WTF::double_conversion::Vector::operator[]):
(WTF::double_conversion::Vector::first):
(WTF::double_conversion::Vector::last):
(WTF::double_conversion::StringBuilder::StringBuilder):
(WTF::double_conversion::StringBuilder::~StringBuilder):
(WTF::double_conversion::StringBuilder::size):
(WTF::double_conversion::StringBuilder::position):
(WTF::double_conversion::StringBuilder::Reset):
(WTF::double_conversion::StringBuilder::AddCharacter):
(WTF::double_conversion::StringBuilder::AddString):
(WTF::double_conversion::StringBuilder::AddSubstring):
(WTF::double_conversion::StringBuilder::AddPadding):
(WTF::double_conversion::StringBuilder::Finalize):
(WTF::double_conversion::StringBuilder::is_finalized):
(WTF::double_conversion::BitCast):

  • wtf/wtf.pri:

Source/WebCore:

No new tests.

Added new dtoa library at ​http://code.google.com/p/double-conversion/.
Replaced old call to dtoa. The new library is much faster than the old one.
We still use the old dtoa for some stuff in WebCore as well as the old strtod,
but we can phase these out eventually as well.

  • ForwardingHeaders/wtf/dtoa/double-conversion.h: Added.
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • css/CSSPrimitiveValue.cpp:

(WebCore::formatNumber):

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::serializeForNumberType):

  • inspector/InspectorValues.cpp:

(WebCore::InspectorBasicValue::writeJSON):

  • platform/graphics/Color.cpp:

(WebCore::Color::serialized):

2:57 PM Changeset in webkit [94451] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Add LayoutTest for the case where long strings are processed by the XSSAuditor.
​https://bugs.webkit.org/show_bug.cgi?id=66580

Patch by Tom Sepez <​tsepez@chromium.org> on 2011-09-02
Reviewed by Adam Barth.

  • http/tests/security/xssAuditor/resources/xss-filter-bypass-long-string-reply.html: Added.
  • http/tests/security/xssAuditor/xss-filter-bypass-long-string-expected.txt: Added.
  • http/tests/security/xssAuditor/xss-filter-bypass-long-string.html: Added.
2:35 PM Changeset in webkit [94450] by nduca@chromium.org
  • 13 edits
    2 copies
    4 adds in trunk

[chromium] Check for null context when reinitializing compositor
​https://bugs.webkit.org/show_bug.cgi?id=67507

Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):

2:16 PM Changeset in webkit [94449] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG graph has no way of distinguishing or reconciling between static
and dynamic predictions
​https://bugs.webkit.org/show_bug.cgi?id=67343

Reviewed by Gavin Barraclough.

PredictedType now stores the source of the prediction. Merging predictions,
which was previously done with a bitwise or, is now done via the
mergePredictions (equivalent to |) and mergePrediction (equivalent to |=)
functions, which correctly handle combinations of static and dynamic.

This is performance-neutral, since all predictions are currently static and
so the code has no visible effects.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::staticallyPredictArray):
(JSC::DFG::ByteCodeParser::staticallyPredictInt32):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::predictGlobalVar):

  • dfg/DFGNode.h:

(JSC::DFG::isArrayPrediction):
(JSC::DFG::isInt32Prediction):
(JSC::DFG::isDoublePrediction):
(JSC::DFG::isDynamicPrediction):
(JSC::DFG::mergePredictions):
(JSC::DFG::mergePrediction):
(JSC::DFG::makePrediction):
(JSC::DFG::Node::predict):

2:08 PM Changeset in webkit [94448] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix 32bit build.

1:49 PM Changeset in webkit [94447] by Lucas Forschler
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

1:48 PM Changeset in webkit [94446] by jer.noble@apple.com
  • 7 edits in trunk/LayoutTests

Some media layout tests fail because of ambiguous ordering of canplaythough event.
​https://bugs.webkit.org/show_bug.cgi?id=67520

Reviewed by Eric Carlson.

The "canplaythrough" event can occur either before or after the "playing" event, causing layout tests
to fail for certain media engines (AVFoundation). The "canplaythrough" event check isn't adding anything
of value which isn't covered in other layout tests, so remove this event check.

  • media/audio-play-event-expected.txt:
  • media/audio-play-event.html:
  • media/video-play-empty-events-expected.txt:
  • media/video-play-empty-events.html:
  • media/video-timeupdate-during-playback-expected.txt:
  • media/video-timeupdate-during-playback.html:
1:41 PM Changeset in webkit [94445] by oliver@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Use bump allocator for initial property storage
​https://bugs.webkit.org/show_bug.cgi?id=67494

Reviewed by Gavin Barraclough.

Switch to a bump allocator for the initial out of line
property storage. This gives us slightly faster allocation
for short lived objects that need out of line storage at
the cost of an additional memcpy when the object survives
a GC pass.

No performance impact.

(JSC::Heap::collect):

  • heap/Heap.h:

(JSC::Heap::allocatePropertyStorage):
(JSC::Heap::inPropertyStorageNursary):

  • heap/NewSpace.cpp:

(JSC::NewSpace::NewSpace):

  • heap/NewSpace.h:

(JSC::NewSpace::resetPropertyStorageNursary):
(JSC::NewSpace::allocatePropertyStorage):
(JSC::NewSpace::inPropertyStorageNursary):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSObject.cpp:

(JSC::JSObject::allocatePropertyStorage):

  • runtime/JSObject.h:

(JSC::JSObject::~JSObject):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::putDirectFunctionWithoutTransition):
(JSC::JSObject::transitionTo):
(JSC::JSObject::visitChildrenDirect):

1:33 PM Changeset in webkit [94444] by Darin Adler
  • 4 edits in trunk/Tools

Added Subversion ignore for .pyc generated files.

  • Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
  • Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
  • Scripts/webkitpy/tool/servers: Added property svn:ignore.
1:25 PM Changeset in webkit [94443] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Update expectations for tests with animations and reflections

  • platform/chromium/test_expectations.txt:
12:55 PM Changeset in webkit [94442] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-02

  • DEPS:
12:48 PM Changeset in webkit [94441] by abarth@webkit.org
  • 2 edits in trunk/Tools

Enable testing on mac-ews
​https://bugs.webkit.org/show_bug.cgi?id=67505

Reviewed by Eric Seidel.

This patch enables testing on the Mac EWS, which should help
contributors not turn the Mac bots red.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
12:40 PM Changeset in webkit [94440] by jamesr@google.com
  • 4 edits
    2 adds in trunk/LayoutTests

[chromium] Update some chromium gpu baselines

  • platform/chromium-gpu-cg-mac/compositing/images/content-image-change-expected.png: Added.
  • platform/chromium-gpu-cg-mac/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-gpu-win/compositing/images/content-image-change-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium/test_expectations.txt:
12:27 PM Changeset in webkit [94439] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove plug-in paths from web process sandbox
​https://bugs.webkit.org/show_bug.cgi?id=67518

Reviewed by Adam Roben.

Plug-ins are never accessed from the web process, so remove plug-in paths from the sandbox profile.

  • WebProcess/com.apple.WebProcess.sb:
12:19 PM Changeset in webkit [94438] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Assertion/crash when running netscape-plugin-property-access-exception.html test
​https://bugs.webkit.org/show_bug.cgi?id=67517

Reviewed by Adam Roben.

Make sure to initialize the NPVariant in case the plug-in returns true from NP_GetProperty,
but doesn't set the result NPVariant to anything.

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::getProperty):

11:55 AM Changeset in webkit [94437] by Beth Dakin
  • 4 edits
    1 add in trunk/Tools

​https://bugs.webkit.org/show_bug.cgi?id=67451
Add a test for going back to a cached page after changing the device scale factor

Reviewed by Adam Roben.

New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.

(TestWebKitAPI::DeviceScaleFactorOnBack::url):
(TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
(TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
(TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
(TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
(TestWebKitAPI::TEST_F):

Added new function to WebKitAgnosticTest to goBack. Separated
waitForLoadToFinish() into its own function (instead of being a part of
loadAndWaitUntilFinished()) so that it can be called from goBack as
well. Also added initializeView() so we can set the cache model.

  • TestWebKitAPI/mac/WebKitAgnosticTest.h:

(TestWebKitAPI::WebKitAgnosticTest::initializeView):

  • TestWebKitAPI/mac/WebKitAgnosticTest.mm:

(TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
(TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
(TestWebKitAPI::WebKitAgnosticTest::loadURL):
(TestWebKitAPI::WebKitAgnosticTest::goBack):
(TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):

11:35 AM Changeset in webkit [94436] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Flaky Test: http/tests/appcache/origin-usage.html
​https://bugs.webkit.org/show_bug.cgi?id=60928

Reviewed by Joseph Pecoraro.

Not sure if it was actually flaky anywhere, but it's failing for me on Lion consistently.

  • http/tests/appcache/origin-usage-expected.txt:
  • http/tests/appcache/origin-usage.html: Increase the range for success. It's OK because data is added in larger chunks anyway.
11:17 AM Changeset in webkit [94435] by andersca@apple.com
  • 4 edits in trunk

The private browsing state isn't saved when it changes
​https://bugs.webkit.org/show_bug.cgi?id=67508

Reviewed by Sam Weinig.

Source/WebKit2:

Store the new private browsing state so subsequent queries for it
will return the right value.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::privateBrowsingStateChanged):

LayoutTests:

Unskip private browsing plug-in tests, since WebKitTestRunner
now has layoutTestController.setPopupBlockingEnabled.

  • platform/wk2/Skipped:
11:02 AM Changeset in webkit [94434] by caryclark@google.com
  • 10 edits
    189 adds
    16 deletes in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac, next chunk of files)
Updated newer tests with reference images.
Deleted images with correct fallbacks.

  • platform/chromium-mac/media/controls-after-reload-expected.txt: Added.

(remaining files omitted for brevity)

10:42 AM Changeset in webkit [94433] by weinig@apple.com
  • 15 edits
    3 deletes in trunk/Source/WebCore

Remove BeforeProcessEvent, it was never meant to be
​https://bugs.webkit.org/show_bug.cgi?id=67493

Reviewed by Anders Carlsson.

BeforeProcessEvent was added, never hooked up, and never removed.
Now it is being removed.

  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/BeforeProcessEvent.cpp: Removed.
  • dom/BeforeProcessEvent.h: Removed.
  • dom/BeforeProcessEvent.idl: Removed.
  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp:

(WebCore::Document::addListenerTypeIfNeeded):

  • dom/Document.h:
  • dom/EventNames.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::parseMappedAttribute):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::parseMappedAttribute):

10:41 AM Changeset in webkit [94432] by andersca@apple.com
  • 2 edits in trunk/Tools

Build fix.

  • DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:

(PrivateBrowsing::ScriptableObject::pluginTest):

10:36 AM Changeset in webkit [94431] by enne@google.com
  • 18 edits in trunk/Source

[chromium] Remove LayerRendererChromium references from the LayerChromium tree
​https://bugs.webkit.org/show_bug.cgi?id=66430

Reviewed by James Robinson.

Source/WebCore:

Covered by existing tests.

Replace references to LayerRendererChromium in the LayerChromium tree
with references to LayerTreeHost. The LayerRendererChromium property
is no longer synced and instead is set recursively on the CCLayerImpl
tree during commit.

WebGLLayerChromium's paintRenderedResultsToCanvas function is
temporarily turned off for threaded compositing because it needs
access to the compositor context.

Previously, changing the layer renderer on a layer called cleanup
resources on that layer. Now, call that explicitly clean up all
resources explicitly from the proxy when the layer renderer gets
created. This cleans up all of the ManagedTexture objects which may be
hanging onto stale GraphicsContext3D pointers.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::cleanupResourcesRecursive):
(WebCore::LayerChromium::setLayerTreeHost):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::layerTreeHost):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::paintLayerContents):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::textureManager):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::cleanupResources):
(WebCore::VideoLayerChromium::setLayerTreeHost):
(WebCore::VideoLayerChromium::reserveTextures):

  • platform/graphics/chromium/VideoLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):
(WebCore::WebGLLayerChromium::setTextureUpdated):
(WebCore::WebGLLayerChromium::layerRendererContext):

  • platform/graphics/chromium/WebGLLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::setLayerRendererRecursive):

  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

Source/WebKit/chromium:

Change references to LayerRendererChromium to CCLayerTreeHost.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):

10:33 AM Changeset in webkit [94430] by andersca@apple.com
  • 14 edits
    1 add in trunk

Move private browsing test to a PluginTest subclass
​https://bugs.webkit.org/show_bug.cgi?id=67498

Reviewed by Darin Adler.

Tools:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:

(pluginGetProperty):

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::NPP_SetValue):

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  • DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.

(PrivateBrowsing::PrivateBrowsing):
(PrivateBrowsing::privateBrowsingEnabled):
(PrivateBrowsing::cachedPrivateBrowsingEnabled):
(PrivateBrowsing::ScriptableObject::hasProperty):
(PrivateBrowsing::ScriptableObject::getProperty):
(PrivateBrowsing::ScriptableObject::pluginTest):
(PrivateBrowsing::NPP_New):
(PrivateBrowsing::NPP_GetValue):
(PrivateBrowsing::NPP_SetValue):

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_New):
(NPP_SetValue):

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am:

LayoutTests:

Set the 'test' attribute to 'private-browsing'.

  • plugins/private-browsing-mode-2.html:
  • plugins/private-browsing-mode.html:
10:24 AM Changeset in webkit [94429] by apavlov@chromium.org
  • 4 edits
    3 copies
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed, update expectations after r94420.

  • platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt.
  • platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
  • platform/chromium-win/fast/borders/border-image-repeat-expected.png: Added.
  • platform/chromium-win/fast/borders/border-image-repeat-expected.txt: Added.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
10:09 AM Changeset in webkit [94428] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • platform/network/mac/CookieStorageMac.mm: (WebCore::setCookieStoragePrivateBrowsingEnabled): Can't use BUILDING_ON_SNOW_LEOPARD without defined() when not on Snow Leopard.
10:07 AM Changeset in webkit [94427] by commit-queue@webkit.org
  • 72 edits in trunk/Source/WebCore

Unreviewed, rolling out r94421.
​http://trac.webkit.org/changeset/94421
​https://bugs.webkit.org/show_bug.cgi?id=67496

Broke a number of tests on Chromium builders (including the
"cr-linux" EWS bot) (Requested by apavlov on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-02

  • accessibility/AXObjectCache.cpp:

(WebCore::nodeHasRole):

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(webkit_accessible_get_name):

  • dom/Document.cpp:

(WebCore::Document::buildAccessKeyMap):
(WebCore::Document::recalcStyleSelector):

  • dom/Element.cpp:

(WebCore::Element::baseURI):
(WebCore::Element::formatForDebugger):
(WebCore::Element::spellcheckAttributeState):

  • dom/NameNodeList.cpp:

(WebCore::NameNodeList::nodeMatches):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):

  • editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::doUnapply):

  • editing/markup.cpp:

(WebCore::shouldIncludeWrapperForFullySelectedRoot):
(WebCore::createMarkup):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::draggable):
(WebCore::HTMLAnchorElement::href):
(WebCore::HTMLAnchorElement::name):
(WebCore::HTMLAnchorElement::target):
(WebCore::HTMLAnchorElement::sendPings):
(WebCore::HTMLAnchorElement::handleClick):

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::createRenderer):

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::target):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::aLink):
(WebCore::HTMLBodyElement::bgColor):
(WebCore::HTMLBodyElement::link):
(WebCore::HTMLBodyElement::text):
(WebCore::HTMLBodyElement::vLink):
(WebCore::HTMLBodyElement::addSubresourceAttributeURLs):

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::value):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::checkForNameMatch):
(WebCore::HTMLCollection::updateNameCache):

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::dir):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::draggable):
(WebCore::HTMLElement::title):
(WebCore::setHasDirAutoFlagRecursively):
(WebCore::HTMLElement::directionalityIfhasDirAutoAttribute):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildAttributeChanged):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget):
(WebCore::HTMLEmbedElement::insertedIntoDocument):
(WebCore::HTMLEmbedElement::addSubresourceAttributeURLs):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::getNamedFormItem):
(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::autofocus):
(WebCore::HTMLFormControlElement::updateVisibleValidationMessage):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::name):
(WebCore::HTMLFormElement::action):
(WebCore::HTMLFormElement::method):
(WebCore::HTMLFormElement::target):

  • html/HTMLFrameElement.cpp:

(WebCore::HTMLFrameElement::noResize):

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
(WebCore::HTMLFrameElementBase::location):
(WebCore::HTMLFrameElementBase::allowFullScreen):

  • html/HTMLHtmlElement.cpp:

(WebCore::HTMLHtmlElement::insertedByParser):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::altText):
(WebCore::HTMLImageElement::width):
(WebCore::HTMLImageElement::height):
(WebCore::HTMLImageElement::alt):
(WebCore::HTMLImageElement::draggable):
(WebCore::HTMLImageElement::src):
(WebCore::HTMLImageElement::addSubresourceAttributeURLs):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::finishParsingChildren):
(WebCore::HTMLInputElement::altText):
(WebCore::HTMLInputElement::reset):
(WebCore::HTMLInputElement::searchEventsShouldBeDispatched):
(WebCore::HTMLInputElement::isSpeechEnabled):

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::control):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::href):
(WebCore::HTMLLinkElement::rel):
(WebCore::HTMLLinkElement::target):
(WebCore::HTMLLinkElement::type):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::attributeChanged):
(WebCore::HTMLMediaElement::insertedIntoDocument):

  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::content):
(WebCore::HTMLMetaElement::httpEquiv):
(WebCore::HTMLMetaElement::name):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::min):
(WebCore::HTMLMeterElement::max):
(WebCore::HTMLMeterElement::value):
(WebCore::HTMLMeterElement::low):
(WebCore::HTMLMeterElement::high):
(WebCore::HTMLMeterElement::optimum):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget):
(WebCore::HTMLObjectElement::containsJavaApplet):
(WebCore::HTMLObjectElement::addSubresourceAttributeURLs):

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::groupLabelText):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::max):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::sourceAttributeValue):
(WebCore::HTMLScriptElement::charsetAttributeValue):
(WebCore::HTMLScriptElement::typeAttributeValue):
(WebCore::HTMLScriptElement::languageAttributeValue):
(WebCore::HTMLScriptElement::forAttributeValue):
(WebCore::HTMLScriptElement::eventAttributeValue):

  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::media):
(WebCore::HTMLSourceElement::type):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::media):
(WebCore::HTMLStyleElement::type):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::abbr):
(WebCore::HTMLTableCellElement::axis):
(WebCore::HTMLTableCellElement::headers):
(WebCore::HTMLTableCellElement::scope):
(WebCore::HTMLTableCellElement::addSubresourceAttributeURLs):

  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::width):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::rules):
(WebCore::HTMLTableElement::summary):
(WebCore::HTMLTableElement::addSubresourceAttributeURLs):

  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::align):
(WebCore::HTMLTableSectionElement::ch):
(WebCore::HTMLTableSectionElement::chOff):
(WebCore::HTMLTableSectionElement::vAlign):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::maxLength):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::strippedPlaceholder):
(WebCore::HTMLTextFormControlElement::isPlaceholderEmpty):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::src):
(WebCore::HTMLTrackElement::kind):
(WebCore::HTMLTrackElement::srclang):
(WebCore::HTMLTrackElement::label):
(WebCore::HTMLTrackElement::isDefault):
(WebCore::HTMLTrackElement::load):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::width):
(WebCore::HTMLVideoElement::height):

  • html/StepRange.cpp:

(WebCore::StepRange::StepRange):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrame):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

  • page/Frame.cpp:

(WebCore::Frame::matchLabelsAgainstElement):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

  • page/mac/FrameMac.mm:

(WebCore::Frame::matchLabelsAgainstElement):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::writeImageToDataObject):

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeImage):

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::getURLForImageNode):

  • platform/mac/HTMLConverter.mm:

(fileWrapperForElement):

  • platform/win/ClipboardWin.cpp:

(WebCore::writeImageToDataObject):
(WebCore::ClipboardWin::declareAndWriteDragImage):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::absoluteLinkURL):

  • rendering/RenderDetails.cpp:

(WebCore::RenderDetails::isOpen):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::itemAccessibilityText):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addPDFURLRect):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computePreferredLogicalWidths):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::autosaveName):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::calculateIntrinsicSize):

  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::updateFromElement):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::updateFromElement):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::updateFromElement):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

10:02 AM Changeset in webkit [94426] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r94093): Private browsing doesn't start with a clean state on Snow Leopard
​https://bugs.webkit.org/show_bug.cgi?id=67356

Reviewed by Darin Adler.

  • platform/network/mac/CookieStorageMac.mm: (WebCore::setCookieStoragePrivateBrowsingEnabled): Don't enable old-style private browsing when using sessions - it would take precedence over session cookie storage on Snow Leopard.
10:01 AM Changeset in webkit [94425] by commit-queue@webkit.org
  • 12 edits in trunk

BORDER attribute percent with the input image tag not working.
​https://bugs.webkit.org/show_bug.cgi?id=66467

Patch by Mihnea Ovidenie <​mihnea@adobe.com> on 2011-09-02
Reviewed by Simon Fraser.

Source/WebCore:

This patch fixes 2 issues regarding the border attribute of an input image element.

  1. The border attribute, if specified, is now taken into account and the border of the input image element is displayed.
  2. If the border attribute contains percent, the border is displayed.

The value of the border attribute for input image element is now parsed according to the rules for parsing non-negative integers.
This implies that when percent is specified in the border attribute, parsing takes place and the percent is ignored.
If after parsing, the value of the border is greater than zero, the border of the input image element is displayed.

  • html/HTMLElement.cpp:

(WebCore::parseBorderWidthAttribute):
(WebCore::HTMLElement::applyBorderAttribute):

  • html/HTMLElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseMappedAttribute):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMappedAttribute):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute):

LayoutTests:

Test border-width-percent was modified with tests for input image element.
Expected results for input-image-alt-test were regenerated since an image input element
takes border attribute into account.
Also, mark the test as failure for chromium.

  • fast/borders/border-width-percent-expected.txt:
  • fast/borders/border-width-percent.html:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
9:59 AM Changeset in webkit [94424] by rolandsteiner@chromium.org
  • 8 edits
    1 add in trunk

Implement the Event constructor for V8.
​https://bugs.webkit.org/show_bug.cgi?id=66756

Patch by Kentaro Hara <​haraken@google.com> on 2011-09-02
Reviewed by Adam Barth.

Source/WebCore:

The spec of the Event constructor is here:
​http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-event-constructor
This patch implements the Event constructor for V8 in V8EventConstructors.cpp,
similar to the implementation for JSC in JSEventConstructors.cpp.

  • WebCore.gypi: Added V8EventConstructors.cpp.
  • WebCore.pro: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::getKeyDouble): Returns a value of type double corresponding to a given key.

  • bindings/v8/OptionsObject.h:

(WebCore::OptionsObject::getKeyValue): Returns a value corresponding to a given key.

  • bindings/v8/custom/V8EventConstructors.cpp: Added.

(WebCore::constructV8Event): AllowAllocation::current() means that a DOM object created by WebCore is going to be just wrapped into a V8 object. In this case, we skip the code of constructorCallback().

  • dom/Event.idl: Added |V8CustomConstructor|.

LayoutTests:

  • platform/chromium/test_expectations.txt: Unskip fast/events/constructors/event-constructors.html.
9:50 AM Changeset in webkit [94423] by antonm@chromium.org
  • 2 edits in trunk/Source/WebCore

[v8] Use size_t instead of unsigned when iterating over Vector in V8DOMStringMap
​https://bugs.webkit.org/show_bug.cgi?id=67484

Reviewed by Yury Semikhatsky.

No new tests, minor cleanup.

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyEnumerator):

9:38 AM Changeset in webkit [94422] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r94404.
​http://trac.webkit.org/changeset/94404
​https://bugs.webkit.org/show_bug.cgi?id=67490

"Patch is wrong, new API needs two reviewers, we are already
working on how to add notifications elsewhere" (Requested by
xan_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-02

  • bindings/gobject/GNUmakefile.am:
9:13 AM Changeset in webkit [94421] by andreas.kling@nokia.com
  • 72 edits in trunk/Source/WebCore

Use fastGetAttribute() and fastHasAttribute() where appropriate.
​https://bugs.webkit.org/show_bug.cgi?id=67394

Reviewed by Darin Adler.

Change call sites that don't check the "style" or SVG animatable
attributes to use fastGetAttribute()/fastHasAttribute() instead
of getAttribute()/hasAttribute().

No new tests, this is a minor performance optimization.

  • accessibility/AXObjectCache.cpp:

(WebCore::nodeHasRole):

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(webkit_accessible_get_name):

  • dom/Document.cpp:

(WebCore::Document::buildAccessKeyMap):
(WebCore::Document::recalcStyleSelector):

  • dom/Element.cpp:

(WebCore::Element::baseURI):
(WebCore::Element::formatForDebugger):
(WebCore::Element::spellcheckAttributeState):

  • dom/NameNodeList.cpp:

(WebCore::NameNodeList::nodeMatches):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):

  • editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::doUnapply):

  • editing/markup.cpp:

(WebCore::shouldIncludeWrapperForFullySelectedRoot):
(WebCore::createMarkup):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::draggable):
(WebCore::HTMLAnchorElement::href):
(WebCore::HTMLAnchorElement::name):
(WebCore::HTMLAnchorElement::target):
(WebCore::HTMLAnchorElement::sendPings):
(WebCore::HTMLAnchorElement::handleClick):

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::createRenderer):

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::target):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::aLink):
(WebCore::HTMLBodyElement::bgColor):
(WebCore::HTMLBodyElement::link):
(WebCore::HTMLBodyElement::text):
(WebCore::HTMLBodyElement::vLink):
(WebCore::HTMLBodyElement::addSubresourceAttributeURLs):

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::value):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::checkForNameMatch):
(WebCore::HTMLCollection::updateNameCache):

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::dir):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::draggable):
(WebCore::HTMLElement::title):
(WebCore::setHasDirAutoFlagRecursively):
(WebCore::HTMLElement::directionalityIfhasDirAutoAttribute):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildAttributeChanged):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget):
(WebCore::HTMLEmbedElement::insertedIntoDocument):
(WebCore::HTMLEmbedElement::addSubresourceAttributeURLs):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::getNamedFormItem):
(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::autofocus):
(WebCore::HTMLFormControlElement::updateVisibleValidationMessage):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::name):
(WebCore::HTMLFormElement::action):
(WebCore::HTMLFormElement::method):
(WebCore::HTMLFormElement::target):

  • html/HTMLFrameElement.cpp:

(WebCore::HTMLFrameElement::noResize):

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
(WebCore::HTMLFrameElementBase::location):
(WebCore::HTMLFrameElementBase::allowFullScreen):

  • html/HTMLHtmlElement.cpp:

(WebCore::HTMLHtmlElement::insertedByParser):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::altText):
(WebCore::HTMLImageElement::width):
(WebCore::HTMLImageElement::height):
(WebCore::HTMLImageElement::alt):
(WebCore::HTMLImageElement::draggable):
(WebCore::HTMLImageElement::src):
(WebCore::HTMLImageElement::addSubresourceAttributeURLs):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::finishParsingChildren):
(WebCore::HTMLInputElement::altText):
(WebCore::HTMLInputElement::reset):
(WebCore::HTMLInputElement::searchEventsShouldBeDispatched):
(WebCore::HTMLInputElement::isSpeechEnabled):

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::control):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::href):
(WebCore::HTMLLinkElement::rel):
(WebCore::HTMLLinkElement::target):
(WebCore::HTMLLinkElement::type):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::attributeChanged):
(WebCore::HTMLMediaElement::insertedIntoDocument):

  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::content):
(WebCore::HTMLMetaElement::httpEquiv):
(WebCore::HTMLMetaElement::name):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::min):
(WebCore::HTMLMeterElement::max):
(WebCore::HTMLMeterElement::value):
(WebCore::HTMLMeterElement::low):
(WebCore::HTMLMeterElement::high):
(WebCore::HTMLMeterElement::optimum):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget):
(WebCore::HTMLObjectElement::containsJavaApplet):
(WebCore::HTMLObjectElement::addSubresourceAttributeURLs):

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::groupLabelText):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::max):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::sourceAttributeValue):
(WebCore::HTMLScriptElement::charsetAttributeValue):
(WebCore::HTMLScriptElement::typeAttributeValue):
(WebCore::HTMLScriptElement::languageAttributeValue):
(WebCore::HTMLScriptElement::forAttributeValue):
(WebCore::HTMLScriptElement::eventAttributeValue):

  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::media):
(WebCore::HTMLSourceElement::type):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::media):
(WebCore::HTMLStyleElement::type):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::abbr):
(WebCore::HTMLTableCellElement::axis):
(WebCore::HTMLTableCellElement::headers):
(WebCore::HTMLTableCellElement::scope):
(WebCore::HTMLTableCellElement::addSubresourceAttributeURLs):

  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::width):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::rules):
(WebCore::HTMLTableElement::summary):
(WebCore::HTMLTableElement::addSubresourceAttributeURLs):

  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::align):
(WebCore::HTMLTableSectionElement::ch):
(WebCore::HTMLTableSectionElement::chOff):
(WebCore::HTMLTableSectionElement::vAlign):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::maxLength):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::strippedPlaceholder):
(WebCore::HTMLTextFormControlElement::isPlaceholderEmpty):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::src):
(WebCore::HTMLTrackElement::kind):
(WebCore::HTMLTrackElement::srclang):
(WebCore::HTMLTrackElement::label):
(WebCore::HTMLTrackElement::isDefault):
(WebCore::HTMLTrackElement::load):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::width):
(WebCore::HTMLVideoElement::height):

  • html/StepRange.cpp:

(WebCore::StepRange::StepRange):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrame):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

  • page/Frame.cpp:

(WebCore::Frame::matchLabelsAgainstElement):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

  • page/mac/FrameMac.mm:

(WebCore::Frame::matchLabelsAgainstElement):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::writeImageToDataObject):

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeImage):

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::getURLForImageNode):

  • platform/mac/HTMLConverter.mm:

(fileWrapperForElement):

  • platform/win/ClipboardWin.cpp:

(WebCore::writeImageToDataObject):
(WebCore::ClipboardWin::declareAndWriteDragImage):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::absoluteLinkURL):

  • rendering/RenderDetails.cpp:

(WebCore::RenderDetails::isOpen):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::itemAccessibilityText):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addPDFURLRect):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computePreferredLogicalWidths):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::autosaveName):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::calculateIntrinsicSize):

  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::updateFromElement):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::updateFromElement):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::updateFromElement):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

9:00 AM Changeset in webkit [94420] by hyatt@apple.com
  • 16 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=67431

Implement border-image-repeat. Similar to how border-image-slice was implemented, the parsing of the two
repeat values has been moved into separate functions. The value is represented as a Pair (similar to how we
handle border radius).

Reviewed by Beth Dakin.

Added fast/borders/border-image-repeat.html.

Source/WebCore:

  • css/CSSBorderImageValue.cpp:

(WebCore::CSSBorderImageValue::CSSBorderImageValue):
(WebCore::CSSBorderImageValue::cssText):

  • css/CSSBorderImageValue.h:

(WebCore::CSSBorderImageValue::create):
Modified the CSSBorderImageValue (you're living on borrowed time, my friend!) to have a CSSValue that
contains a Pair.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForRepeatRule):
(WebCore::valueForNinePieceImageRepeat):
(WebCore::valueForNinePieceImage):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Add support for the new properties. Break out the value retrieval for the image repeat rules into its
own function, valueForNinePieceImageRepeat.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::allowRepeat):
(WebCore::BorderImageParseContext::commitSlice):
(WebCore::BorderImageParseContext::commitSlash):
(WebCore::BorderImageParseContext::commitWidth):
(WebCore::BorderImageParseContext::commitRepeat):
(WebCore::BorderImageParseContext::commitBorderImage):
(WebCore::CSSParser::parseBorderImage):
Modified the parsing of border image to call into parseBorderImageRepeat for the repeat values.

(WebCore::isBorderImageRepeatKeyword):
(WebCore::CSSParser::parseBorderImageRepeat):
The new parsing code for border-image-repeat is here. It will build up a CSSValue containing a Pair and
return the result.

  • css/CSSParser.h:
  • css/CSSPropertyNames.in:

Add the new properties.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapNinePieceImage):
(WebCore::CSSStyleSelector::mapNinePieceImageRepeat):

  • css/CSSStyleSelector.h:

The mapping into the front end is done the same way as border-image-slice. Factor out the image repeat rules
portion into mapNinePieceImageRepeat.

  • platform/graphics/Image.cpp:

(WebCore::Image::drawTiled):

  • platform/graphics/Image.h:

Add the new 'space' value as a valid image tiling rule. It's not yet supported and, like the 'round' value,
is just mapped to 'repeat' for now.

  • rendering/style/NinePieceImage.h:

(WebCore::NinePieceImage::copyRepeatFrom):
Helper for copying only the repeat rules from another NinePieceImage.

LayoutTests:

  • fast/borders/border-image-repeat.html: Added.
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/borders/border-image-repeat-expected.png: Added.
  • platform/mac/fast/borders/border-image-repeat-expected.txt: Added.
  • svg/css/getComputedStyle-basic-expected.txt:
8:57 AM Changeset in webkit [94419] by commit-queue@webkit.org
  • 4 edits in trunk

Source/WebCore: [Qt] number input not rendering spin buttons properly in RTL direction
​https://bugs.webkit.org/show_bug.cgi?id=67445

Properly render Qt's number input with RTL direction, and fix Plastique styling.

Patch by Jarred Nicholls <​jarred@sencha.com> on 2011-09-02
Reviewed by Andreas Kling.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::paintInnerSpinButton):

LayoutTests: [Qt] number input not rendering spin buttons properly in RTL direction
​https://bugs.webkit.org/show_bug.cgi?id=67445

New baseline for Qt number input with RTL direction.

Patch by Jarred Nicholls <​jarred@sencha.com> on 2011-09-02
Reviewed by Andreas Kling.

  • platform/qt/fast/forms/input-appearance-number-rtl-expected.png:
8:35 AM Changeset in webkit [94418] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Source/WebCore: Resetting media controls when the src is changed from a valid url to an
invalid url.
​https://bugs.webkit.org/show_bug.cgi?id=64880

Patch by Arko Saha <​nghq36@motorola.com> on 2011-09-02
Reviewed by Eric Carlson.

Test: media/media-controls-invalid-url.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaLoadingFailed):

LayoutTests: Controls not reset when media element url changed from a valid url to an invalid url.
​https://bugs.webkit.org/show_bug.cgi?id=64880

Patch by Arko Saha <​nghq36@motorola.com> on 2011-09-02
Reviewed by Eric Carlson.

  • media/media-controls-invalid-url-expected.txt: Added.
  • media/media-controls-invalid-url.html: Added.
7:09 AM Changeset in webkit [94417] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Anchor elements doesn't get focus on TAB key press.
​https://bugs.webkit.org/show_bug.cgi?id=66949

Patch by Ravi Phaneendra Kasibhatla <​ravi.kasibhatla@motorola.com> on 2011-09-02
Reviewed by Adam Roben.

Setting the default property value of TabsToLinks to true
only for GTK platform since Win & Mac platforms doesn't want
it to be set to true by default.

  • Shared/WebPreferencesStore.h:

Set the default value of key TabsToLinks to true for GTK platform only.

7:05 AM Changeset in webkit [94416] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] 4 tests are failing, skip them
​https://bugs.webkit.org/show_bug.cgi?id=67485

Patch by Kristóf Kosztyó <​kkristof@inf.u-szeged.hu> on 2011-09-02

  • platform/qt-wk2/Skipped:
7:02 AM Changeset in webkit [94415] by dominicc@chromium.org
  • 5 edits in trunk/LayoutTests

Unreviewed test fix.

Sadly window-property-descriptors enumerates functions in the test
harness. r94362 added a couple of functions, so these results need
to be updated.

  • fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
6:22 AM Changeset in webkit [94414] by leandro@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

Unreviewed build fix after r67110.

  • ewk/ewk_view.cpp:

(ewk_view_need_touch_events_get): Make the function signature match
its declaration.

6:09 AM Changeset in webkit [94413] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Two tests are passing after r94324. They are unskipped:
fast/events/document-elementFromPoint.html
plugins/mouse-events-fixedpos.html

Unreviewed gardening.

  • platform/qt/Skipped:
5:46 AM Changeset in webkit [94412] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update test expectations.

  • platform/chromium/test_expectations.txt:
5:35 AM Changeset in webkit [94411] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Cannot gathering glyph page statistics
​https://bugs.webkit.org/show_bug.cgi?id=67475

Rubber stamped by Csaba Osztrogonác.

Fix Qt WK2 build without having QRAWFONT.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::getWebCoreStatistics):

4:49 AM Changeset in webkit [94410] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Make it more clear when requests are loaded from cache on network panel.
​https://bugs.webkit.org/show_bug.cgi?id=67396

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):

  • inspector/front-end/ResourceHeadersView.js:

(WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):

  • inspector/front-end/networkPanel.css:

(.resource-headers-view .outline-disclosure li .status-from-cache):

4:41 AM Changeset in webkit [94409] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Should remove resource highlight on sort/filter in network panel.
​https://bugs.webkit.org/show_bug.cgi?id=67411

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._sortItems):
(WebInspector.NetworkLogView.prototype._sortByTimeline):
(WebInspector.NetworkLogView.prototype._updateFilter):

4:39 AM Changeset in webkit [94408] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Network: jump to initiator's record in case of redirect
​https://bugs.webkit.org/show_bug.cgi?id=67367

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype._appendRedirect):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.get redirectSource):
(WebInspector.Resource.prototype.set redirectSource):

4:36 AM Changeset in webkit [94407] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Build dependency problems
​https://bugs.webkit.org/show_bug.cgi?id=38054

Trivial fix after r94288.

Rubber-stamped by Andras Becsi.

  • Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.

(buildQMakeProject):

4:19 AM Changeset in webkit [94406] by Antti Koivisto
  • 25 edits in trunk/Source/WebCore

De-virtualize recalcStyle()
​https://bugs.webkit.org/show_bug.cgi?id=67378

Reviewed by Dimitri Glazkov.

Element::recalcStyle() does not need to be virtual, there are very few legit overrides. This will
also make it possible to de-recursify it later.

Added willRecalcStyle()/didRecalcStyle() virtual function for subclasses that need custom style recalc.
These are only invoked if hasCustomWillOrDidRecalcStyle() bit is set.

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::recalcStyle):

  • dom/Element.h:

(WebCore::Element::willRecalcStyle):
(WebCore::Element::didRecalcStyle):

  • dom/Node.h:

(WebCore::Node::hasCustomWillOrDidRecalcStyle):
(WebCore::Node::setHasCustomWillOrDidRecalcStyle):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::recalcShadowTreeStyle):

  • dom/ShadowRoot.h:
  • dom/Text.cpp:

(WebCore::Text::recalcTextStyle):

  • dom/Text.h:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::didRecalcStyle):

  • html/HTMLFormControlElement.h:
  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
(WebCore::HTMLFrameSetElement::willRecalcStyle):

  • html/HTMLFrameSetElement.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::didRecalcStyle):

  • html/HTMLMediaElement.h:
  • html/HTMLNoScriptElement.cpp:

(WebCore::HTMLNoScriptElement::HTMLNoScriptElement):
(WebCore::HTMLNoScriptElement::willRecalcStyle):

  • html/HTMLNoScriptElement.h:
  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::willRecalcStyle):

  • html/HTMLPlugInImageElement.h:
  • html/HTMLSelectElement.cpp:
  • html/HTMLSelectElement.h:
  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::SVGTRefElement):
(WebCore::SVGShadowText::willRecalcStyle):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::willRecalcStyle):
(WebCore::SVGUseElement::didRecalcStyle):

  • svg/SVGUseElement.h:
4:16 AM Changeset in webkit [94405] by yutak@chromium.org
  • 18 edits
    18 adds in trunk

WebSocket: Send Blob as WebSocket binary message
​https://bugs.webkit.org/show_bug.cgi?id=67465

Reviewed by Kent Tamura.

Re-lands r94399 with a fix for Leopard builds.

Source/WebCore:

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::send):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::sendCallback):

  • websockets/ThreadableWebSocketChannel.h:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::send):

  • websockets/WebSocket.h:
  • websockets/WebSocket.idl:
  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):

  • websockets/WebSocketChannel.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendBlob):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):

  • websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

  • http/tests/websocket/tests/hixie76/send-empty-expected.txt: Added.
  • http/tests/websocket/tests/hixie76/send-empty.html: Added.
  • http/tests/websocket/tests/hixie76/send-object-expected.txt: Added.
  • http/tests/websocket/tests/hixie76/send-object.html: Added.
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
  • http/tests/websocket/tests/hybi/send-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-blob.html: Added.
  • http/tests/websocket/tests/hybi/send-blob_wsh.py: Added.
  • http/tests/websocket/tests/hybi/send-empty-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-empty.html: Added.
  • http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-file-blob-fail.html: Added.
  • http/tests/websocket/tests/hybi/send-file-blob.html: Added.
  • http/tests/websocket/tests/hybi/send-file-blob_wsh.py: Added.
  • http/tests/websocket/tests/hybi/workers/resources/send-blob.js: Added.
  • http/tests/websocket/tests/hybi/workers/resources/send-blob_wsh.py: Added.
  • http/tests/websocket/tests/hybi/workers/send-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/send-blob.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
4:10 AM Changeset in webkit [94404] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

[GTK] Generate gobject bindings for Notification and NotificationCenter
​https://bugs.webkit.org/show_bug.cgi?id=67380

Reviewed by Philippe Normand.

  • bindings/gobject/GNUmakefile.am:
3:54 AM Changeset in webkit [94403] by bashi@chromium.org
  • 4 edits in trunk

[chromium] editing/selection/regional-indicators.html timing out on Linux
​https://bugs.webkit.org/show_bug.cgi?id=66510

Reviewed by Kent Tamura.

Source/WebCore:

Uses SurrogatePairAwareTextIerator in ComplexTextControllerLinux to handle surrogate pairs correctly.

No new tests. editing/selection/regional-indicators.html should pass with this patch.

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp:

(WebCore::ComplexTextController::nextScriptRun): Used SurrogatePairAwareTextIterator to split run.
(WebCore::surrogatePairAwareFirstCharacter): Added.
(WebCore::ComplexTextController::setupFontForScriptRun): Used surrogatePairAwareFirstCharacter() to get appropriate FontData.

LayoutTests:

ComplexTextControllerLinux is now surrogate pairs aware, therefore;

  • editing/selection/regional-indicators.html should pass.
  • editing/deleting/regional-indicators.html should not timeout.
  • fast/text/regional-indicator-symbols.html should pass.
  • platform/chromium/test_expectations.txt:
3:51 AM Changeset in webkit [94402] by commit-queue@webkit.org
  • 18 edits
    18 deletes in trunk

Unreviewed, rolling out r94399.
​http://trac.webkit.org/changeset/94399
​https://bugs.webkit.org/show_bug.cgi?id=67471

Broke Leopard build (Requested by yutak on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-02

Source/WebCore:

  • bindings/js/JSWebSocketCustom.cpp:
  • bindings/v8/custom/V8WebSocketCustom.cpp:
  • websockets/ThreadableWebSocketChannel.h:
  • websockets/WebSocket.cpp:
  • websockets/WebSocket.h:
  • websockets/WebSocket.idl:
  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):

  • websockets/WebSocketChannel.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp:
  • websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

  • http/tests/websocket/tests/hixie76/send-empty-expected.txt: Removed.
  • http/tests/websocket/tests/hixie76/send-empty.html: Removed.
  • http/tests/websocket/tests/hixie76/send-object-expected.txt: Removed.
  • http/tests/websocket/tests/hixie76/send-object.html: Removed.
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
  • http/tests/websocket/tests/hybi/send-blob-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/send-blob.html: Removed.
  • http/tests/websocket/tests/hybi/send-blob_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/send-empty-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/send-empty.html: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob-fail.html: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob.html: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/workers/resources/send-blob.js: Removed.
  • http/tests/websocket/tests/hybi/workers/resources/send-blob_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/workers/send-blob-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/workers/send-blob.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
3:40 AM Changeset in webkit [94401] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r94393.
​http://trac.webkit.org/changeset/94393
​https://bugs.webkit.org/show_bug.cgi?id=67470

It broke Qt-SL build (Requested by ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-02

  • WebCore.pro:
3:38 AM Changeset in webkit [94400] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Webfonts display bold in Windows
​https://bugs.webkit.org/show_bug.cgi?id=67387

Uses font's default weight for webfonts by setting FW_DONTCARE.

Reviewed by Kent Tamura.

No new tests. We don't have fonts to test this change.

  • platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData): Sets FW_DONTCARE to use default font weight.

3:36 AM Changeset in webkit [94399] by yutak@chromium.org
  • 18 edits
    18 adds in trunk

WebSocket: Send Blob as WebSocket binary message
​https://bugs.webkit.org/show_bug.cgi?id=67465

Reviewed by Kent Tamura.

Source/WebCore:

Tests: http/tests/websocket/tests/hixie76/send-empty.html

http/tests/websocket/tests/hixie76/send-object.html
http/tests/websocket/tests/hybi/send-blob.html
http/tests/websocket/tests/hybi/send-empty.html
http/tests/websocket/tests/hybi/send-file-blob-fail.html
http/tests/websocket/tests/hybi/send-file-blob.html
http/tests/websocket/tests/hybi/workers/send-blob.html
http/tests/websocket/tests/hybi/bufferedAmount-after-close.html (updated)

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::send):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::sendCallback):

  • websockets/ThreadableWebSocketChannel.h:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::send):

  • websockets/WebSocket.h:
  • websockets/WebSocket.idl:

Fixing code generator did not sound easy, because there are some classes depending on
broken behavior of current code generator (one such example is CanvasRenderingContext2D).
As a temporary workaround, new custom handlers for send() are added.

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):

  • websockets/WebSocketChannel.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendBlob):
A Blob can be deserialized from url, type and size.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
KURL, String and long long (corresponding to url, type and size, respectively) can be passed
safely across threads.

  • websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

  • http/tests/websocket/tests/hixie76/send-empty-expected.txt: Added.
  • http/tests/websocket/tests/hixie76/send-empty.html: Added.
  • http/tests/websocket/tests/hixie76/send-object-expected.txt: Added.
  • http/tests/websocket/tests/hixie76/send-object.html: Added.
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:

Updated. Added tests to send Blobs.

  • http/tests/websocket/tests/hybi/send-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-blob.html:

Added. Send three Blobs each of which contains a small binary message.

  • http/tests/websocket/tests/hybi/send-blob_wsh.py:

Added. receive_message() returns a unicode value if the received message was text, or
a str value if the message was binary.

  • http/tests/websocket/tests/hybi/send-empty-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-empty.html: Added.
  • http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-file-blob-fail.html:

Added. If we delete a file before reading it, FileReaderLoader reliably fails.

  • http/tests/websocket/tests/hybi/send-file-blob.html:

Added. Create a File and try to send it as a Blob.

  • http/tests/websocket/tests/hybi/send-file-blob_wsh.py: Added.
  • http/tests/websocket/tests/hybi/workers/resources/send-blob.js:

Added. Same as send-blob.html above.

  • http/tests/websocket/tests/hybi/workers/resources/send-blob_wsh.py:

Added. Same as send-blob_wsh.py above.

  • http/tests/websocket/tests/hybi/workers/send-blob-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/send-blob.html: Added.
  • platform/gtk/Skipped:

send-file-blob.html and send-file-blob-fail.html depend on availability of File API.

  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
3:21 AM Changeset in webkit [94398] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

<​http://webkit.org/b/67467> WebProcessProxy::secItemCopyMatching / WebProcessProxy::secItemAdd
leak the results of the APIs they wrap.

Reviewed by Dan Bernstein.

  • UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::secItemCopyMatching): Adopt the result of SecItemCopyMatching in to a
RetainPtr to ensure it gets released at the appropriate time.
(WebKit::WebProcessProxy::secItemAdd): Ditto for SecItemAdd.

2:58 AM Changeset in webkit [94397] by Philippe Normand
  • 7 edits in trunk/Source/WebCore

[WebAudio] Undeclared dependency to VIDEO
​https://bugs.webkit.org/show_bug.cgi?id=66893

Reviewed by Kenneth Russell.

Build MediaAudioSourceNode only if VIDEO is enabled

  • webaudio/AudioContext.cpp:
  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
  • webaudio/MediaElementAudioSourceNode.cpp:
  • webaudio/MediaElementAudioSourceNode.h:
  • webaudio/MediaElementAudioSourceNode.idl:
2:53 AM Changeset in webkit [94396] by abecsi@webkit.org
  • 2 edits in trunk/Tools

Remove my old e-mail address and add my new one.

Rubber-stamped by Tor Arne Vestbø.

  • Scripts/webkitpy/common/config/committers.py:
2:33 AM WebKit Team edited by abecsi@webkit.org
(diff)
2:09 AM Changeset in webkit [94395] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r94304.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
1:49 AM Changeset in webkit [94394] by reni@webkit.org
  • 5 edits in trunk/LayoutTests

[Qt] Update Qt specific expected files after r94304.

Unreviewed gardening.

  • platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.png:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
1:26 AM Changeset in webkit [94393] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt][WK2] Unreviewed speculative buildfix.

  • WebCore.pro: Add platform/graphics/GlyphPageTreeNode.cpp to SOURCES.
1:25 AM Changeset in webkit [94392] by reni@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

[Qt] Add Qt expecteds for new tests.

Unreviewed gardening.

  • platform/qt/fast/borders/border-image-slices-expected.png: Added.
  • platform/qt/fast/borders/border-image-slices-expected.txt: Added.
  • platform/qt/fast/text/fallback-traits-fixup-expected.txt: Added.
  • platform/qt/svg/custom/pattern-rotate-gaps-expected.png: Added.
  • platform/qt/svg/custom/pattern-rotate-gaps-expected.txt: Added.
12:58 AM Changeset in webkit [94391] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r94389.
​http://trac.webkit.org/changeset/94389
​https://bugs.webkit.org/show_bug.cgi?id=67468

breaks mac build (Requested by philn-tp on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-02

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaElementSource):

  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
  • webaudio/MediaElementAudioSourceNode.cpp:
  • webaudio/MediaElementAudioSourceNode.h:
  • webaudio/MediaElementAudioSourceNode.idl:
12:41 AM Changeset in webkit [94390] by commit-queue@webkit.org
  • 4 edits
    1 delete in trunk/Source/WebCore

Generate an EventSource constructor of V8 using the IDL 'Constructor' extended attribute
​https://bugs.webkit.org/show_bug.cgi?id=67459

Patch by Kentaro Hara <​haraken@google.com> on 2011-09-02
Reviewed by Adam Barth.

Tests: fast/eventsource/eventsource-constructor.html

fast/eventsource/eventsource-attribute-listeners.html

  • WebCore.gypi: Removed V8EventSourceConstructor.cpp.
  • WebCore.pro: Removed V8EventSourceConstructor.cpp.
  • bindings/v8/custom/V8EventSourceConstructor.cpp: Removed.
  • page/EventSource.idl: Added the 'Constructor' extended attribute.
12:35 AM Changeset in webkit [94389] by Philippe Normand
  • 7 edits in trunk/Source/WebCore

[WebAudio] Undeclared dependency to VIDEO
​https://bugs.webkit.org/show_bug.cgi?id=66893

Reviewed by Kenneth Russell.

Build MediaAudioSourceNode only if VIDEO is enabled

  • webaudio/AudioContext.cpp:
  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
  • webaudio/MediaElementAudioSourceNode.cpp:
  • webaudio/MediaElementAudioSourceNode.h:
  • webaudio/MediaElementAudioSourceNode.idl:
12:32 AM Changeset in webkit [94388] by Philippe Normand
  • 2 edits in trunk/Tools

[GTK] run-gtk-tests leaves a zombie Xvfb process
​https://bugs.webkit.org/show_bug.cgi?id=67389

Reviewed by Martin Robinson.

  • Scripts/run-gtk-tests: Properly close STDIN and STDERR on the child process instead of doing shell redirection.
Note: See TracTimeline for information about the timeline view.