Context Navigation

This test failed when the bug was originally filed, but was
fixed in: https://bugs.webkit.org/show_bug.cgi?id=61805
so no code changes are accompanying this new layout test.

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-12
Reviewed by Chris Fleizach.

accessibility/duplicate-child-nodes-expected.txt: Added.
accessibility/duplicate-child-nodes.html: Added.

10:57 PM Changeset in webkit [95017] by commit-queue@webkit.org

3 edits
2 adds in trunk

Crashes in WebCore::InsertListCommand::unlistifyParagraph.
https://bugs.webkit.org/show_bug.cgi?id=67918

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-09-12
Reviewed by Ryosuke Niwa.

Source/WebCore:

execCommand("InsertUnorderedList") was crashing if the parent node of the target is
a kind of list element and it is not contenteditable.
This patch checks the parent node is contenteditable.

Test: editing/execCommand/insert-list-in-noneditable-list-parent.html

editing/htmlediting.cpp:

(WebCore::enclosingListChild): Checks the parent node is contenteditable.

LayoutTests:

Added tests.

editing/execCommand/insert-list-in-noneditable-list-parent-expected.txt: Added.
editing/execCommand/insert-list-in-noneditable-list-parent.html: Added.

10:35 PM Changeset in webkit [95016] by fpizlo@apple.com

23 edits
4 adds
1 delete in trunk/Source/JavaScriptCore

JavaScriptCore does not have baseline->speculative OSR
https://bugs.webkit.org/show_bug.cgi?id=67920

Reviewed by Oliver Hunt.

This adds the ability to on-stack-replace (OSR) from code that is
running hot in the old JIT to code compiled by the new JIT. This
ensures that long-running loops benefit from DFG optimization.
It also ensures that if code experiences a speculation failure
in DFG code, it has an opportunity to reenter the DFG once every
1,000 loop iterations or so.

This results in a 2.88x speed-up on Kraken/imaging-desaturate,
and is a pure win on the main three benchmark suites (SunSpider,
V8, Kraken), when tiered compilation is enabled.

JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::ProgramCodeBlock::compileOptimized):
(JSC::EvalCodeBlock::compileOptimized):
(JSC::FunctionCodeBlock::compileOptimized):

bytecode/CodeBlock.h:
bytecode/Opcode.h:
bytecode/PredictedType.h: Added.

(JSC::isCellPrediction):
(JSC::isArrayPrediction):
(JSC::isInt32Prediction):
(JSC::isDoublePrediction):
(JSC::isNumberPrediction):
(JSC::isBooleanPrediction):
(JSC::isStrongPrediction):
(JSC::predictionToString):
(JSC::mergePredictions):
(JSC::mergePrediction):
(JSC::makePrediction):

bytecode/PredictionTracker.h: Added.

(JSC::operandIsArgument):
(JSC::PredictionSlot::PredictionSlot):
(JSC::PredictionTracker::PredictionTracker):
(JSC::PredictionTracker::initializeSimilarTo):
(JSC::PredictionTracker::copyLocalsFrom):
(JSC::PredictionTracker::numberOfArguments):
(JSC::PredictionTracker::numberOfVariables):
(JSC::PredictionTracker::argumentIndexForOperand):
(JSC::PredictionTracker::predictArgument):
(JSC::PredictionTracker::predict):
(JSC::PredictionTracker::predictGlobalVar):
(JSC::PredictionTracker::getArgumentPrediction):
(JSC::PredictionTracker::getPrediction):
(JSC::PredictionTracker::getGlobalVarPrediction):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitLoopHint):

bytecompiler/BytecodeGenerator.h:
bytecompiler/NodesCodegen.cpp:

(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

dfg/DFGDriver.cpp:

(JSC::DFG::compile):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

dfg/DFGGraph.h:

(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):

dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::noticeOSREntry):

dfg/DFGNode.h:
dfg/DFGOSREntry.cpp: Added.

(JSC::DFG::predictionIsValid):
(JSC::DFG::prepareOSREntry):

dfg/DFGOSREntry.h: Added.

(JSC::DFG::prepareOSREntry):

dfg/DFGPredictionTracker.h: Removed.
dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::mergeUse):
(JSC::DFG::Propagator::mergePrediction):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

jit/CompactJITCodeMap.h:

(JSC::CompactJITCodeMap::numberOfEntries):
(JSC::CompactJITCodeMap::decode):
(JSC::CompactJITCodeMap::Decoder::Decoder):
(JSC::CompactJITCodeMap::Decoder::numberOfEntriesRemaining):
(JSC::CompactJITCodeMap::Decoder::read):

jit/JIT.cpp:

(JSC::JIT::emitOptimizationCheck):
(JSC::JIT::emitTimeoutCheck):
(JSC::JIT::privateCompileMainPass):

jit/JIT.h:

(JSC::JIT::emit_op_loop_hint):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

9:50 PM Changeset in webkit [95015] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-12

DEPS:

9:44 PM Changeset in webkit [95014] by commit-queue@webkit.org

38 edits
3 deletes in trunk

Unreviewed, rolling out r94975.
http://trac.webkit.org/changeset/94975
https://bugs.webkit.org/show_bug.cgi?id=67984

crash in PrerenderBrowserTest.PrerenderHTML5VideoJs (Requested
by ukai on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-12

Source/WebCore:

platform/graphics/chromium/CanvasLayerChromium.h:

(WebCore::CanvasLayerChromium::layerTypeAsString):

platform/graphics/chromium/ContentLayerChromium.h:

(WebCore::ContentLayerChromium::layerTypeAsString):

platform/graphics/chromium/ImageLayerChromium.h:

(WebCore::ImageLayerChromium::layerTypeAsString):

platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::layerTreeAsText):
(WebCore::writeIndent):
(WebCore::LayerChromium::dumpLayer):
(WebCore::LayerChromium::dumpLayerProperties):

platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::layerTypeAsString):

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::textureMemoryReclaimLimit):
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::close):
(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
(WebCore::LayerRendererChromium::layerTreeAsText):
(WebCore::LayerRendererChromium::dumpRenderSurfaces):

platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::owner):
(WebCore::LayerRendererChromium::rootLayer):
(WebCore::LayerRendererChromium::rootLayerImpl):
(WebCore::LayerRendererChromium::viewportSize):
(WebCore::LayerRendererChromium::contentsTextureManager):

platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):

platform/graphics/chromium/PluginLayerChromium.h:

(WebCore::PluginLayerChromium::layerTypeAsString):

platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::name):
(WebCore::writeIndent):
(WebCore::RenderSurfaceChromium::dumpSurface):

platform/graphics/chromium/RenderSurfaceChromium.h:
platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::deleteEvictedTextures):
(WebCore::TextureManager::removeTexture):
(WebCore::TextureManager::allocateTexture):
(WebCore::TextureManager::requestTexture):

platform/graphics/chromium/TextureManager.h:

(WebCore::TextureManager::setAssociatedContextDebugOnly):
(WebCore::TextureManager::associatedContextDebugOnly):

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::writeIndent):
(WebCore::TiledLayerChromium::dumpLayerProperties):

platform/graphics/chromium/TiledLayerChromium.h:
platform/graphics/chromium/VideoLayerChromium.h:

(WebCore::VideoLayerChromium::layerTypeAsString):

platform/graphics/chromium/WebGLLayerChromium.h:

(WebCore::WebGLLayerChromium::layerTypeAsString):

platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
platform/graphics/chromium/cc/CCLayerImpl.cpp:
platform/graphics/chromium/cc/CCLayerImpl.h:
platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::contentsTextureManager):

platform/graphics/chromium/cc/CCLayerTreeHost.h:
platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::setVisible):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
platform/graphics/chromium/cc/CCPluginLayerImpl.h:
platform/graphics/chromium/cc/CCProxy.h:
platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::contentsTextureManager):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):

platform/graphics/chromium/cc/CCSingleThreadProxy.h:
platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::contentsTextureManager):
(WebCore::CCThreadProxy::initializeLayerRendererOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):

platform/graphics/chromium/cc/CCThreadProxy.h:
platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::dumpLayerProperties):

platform/graphics/chromium/cc/CCTiledLayerImpl.h:
platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
platform/graphics/chromium/cc/CCVideoLayerImpl.h:

LayoutTests:

platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.png: Removed.
platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.txt: Removed.
platform/chromium/compositing/lost-compositor-context-with-rendersurface.html: Removed.

9:41 PM Changeset in webkit [95013] by Joseph Pecoraro

2 edits in trunk/Source/WebCore

Possible ASSERT(!storageTracker) in Lazily Initialized StorageTracker
https://bugs.webkit.org/show_bug.cgi?id=67957

Reviewed by Darin Adler.

The storageTracker singleton may already have been created
through StorageTracker::tracker before initializeTracker
gets called. Update the ASSERT in this case to check that
there is no client for the tracker.

No test, this depends on how the port initializes the tracker.

storage/StorageTracker.cpp:

(WebCore::StorageTracker::initializeTracker):

9:15 PM Changeset in webkit [95012] by levin@chromium.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Remove AllowCrossThreadAccess for WorkerFileWriterCallbacksBridge.
https://bugs.webkit.org/show_bug.cgi?id=67943

Reviewed by Adam Barth.

src/WorkerFileWriterCallbacksBridge.cpp: Removed AllowCrossThreadAccess

allowing the automatic ref counting to work. This was previous needed when
the ref counting wasn't working but that was fixed in r94986. Note that the
design was to have ref counting since the methods take PassRefPtr and the
class is ThreadSafeRefCounted. (Ideally we have noticed this flaw when
adding in AllowCrossThreadAccess.)
(WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::didWrite):
(WebKit::WorkerFileWriterCallbacksBridge::didFail):
(WebKit::WorkerFileWriterCallbacksBridge::didTruncate):
(WebKit::WorkerFileWriterCallbacksBridge::postInitToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToWorkerThread):

9:01 PM Changeset in webkit [95011] by weinig@apple.com

5 edits in trunk

Don't allow setting proto to be a getter or setter
https://bugs.webkit.org/show_bug.cgi?id=67982

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

runtime/JSObject.cpp:

(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):
Disallow setting a getter or setter on proto.

LayoutTests:

fast/js/prototypes-expected.txt:
fast/js/script-tests/prototypes.js:

Add test that we disallow setting a getter or setter on proto.

8:55 PM Changeset in webkit [95010] by adamk@chromium.org

2 edits in trunk/Source/WebCore

Fix out-of-bounds access in Gradient::sortStopsIfNecessary
https://bugs.webkit.org/show_bug.cgi?id=67958

Reviewed by Darin Adler.

Reported by Valgrind in http://crbug.com/77049.

The errant code was added as an optimization in r67804.
This patch reverts that one, as all parties agree that the optimization
doesn't seem worthwhile, and there clearly aren't any tests covering
the special case.

No new tests, as existing tests should cover the remaining call to
|std::stable_sort|.

platform/graphics/Gradient.cpp:

(WebCore::Gradient::sortStopsIfNecessary):

8:50 PM Changeset in webkit [95009] by commit-queue@webkit.org

3 edits
2 adds in trunk

Setting document.title doesn't affect contents of title tag of XHTML documents
https://bugs.webkit.org/show_bug.cgi?id=57537

Patch by Jacky Jiang <zhajiang@rim.com> on 2011-09-12
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Update the contents of the <title> tag of XHTML documents when setting
document.title.

Test: fast/dom/title-content-set-innerText-get.xhtml

dom/Document.cpp:

(WebCore::Document::setTitle):

LayoutTests:

fast/dom/title-content-set-innerText-get-expected.txt: Added.
fast/dom/title-content-set-innerText-get.xhtml: Added.

8:44 PM Changeset in webkit [95008] by commit-queue@webkit.org

1 edit
4 adds in trunk/LayoutTests

Add GTK & Win expectations for two recently added
accessibility layout tests.
https://bugs.webkit.org/show_bug.cgi?id=67948

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-12
Reviewed by Chris Fleizach.

platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Added.
platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt: Added.
platform/win/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Added.
platform/win/accessibility/div-within-anchors-causes-crash-expected.txt: Added.

8:38 PM Changeset in webkit [95007] by commit-queue@webkit.org

2 edits
1 add in trunk/Tools

[EFL] DRT: Add DumpRenderTreeEfl.h
https://bugs.webkit.org/show_bug.cgi?id=63993

Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-09-12
Reviewed by Eric Seidel.

This header contains some global variables used by EFL's
DumpRenderTree implementation.

DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when

appropriate.

DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.

8:34 PM Changeset in webkit [95006] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] Send the right key names for PageUp and PageDown.
https://bugs.webkit.org/show_bug.cgi?id=67044

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-12
Reviewed by Kenneth Rohde Christiansen.

PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
PageDown (which is close to the defines in WindowsKeyboardCodes.h).
However, EventSender was sending "Page_Up" and "Page_Down", so tests
such as editing/input/page-up-down-scrolls.html were timing out due to
the right key down events not being sent.

DumpRenderTree/efl/EventSender.cpp:

(keyPadNameFromJSValue):
(keyNameFromJSValue):

8:30 PM Changeset in webkit [95005] by ryuan.choi@samsung.com

3 edits in trunk/Source/WebKit2

Reviewed by Eric Seidel.

[CMAKE][WK2] include cmakeconfig.h in WebKit2/config.h
https://bugs.webkit.org/show_bug.cgi?id=62692

CMakeLists.txt: define WTF_USE_JSC=1.
config.h: add cmakeconfig.h and define necessary macros for CMake build.

8:24 PM Changeset in webkit [95004] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[EFL] Initialize m_unmodifiedText in PlatformKeyboardEventEfl.
https://bugs.webkit.org/show_bug.cgi?id=67038

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-12
Reviewed by Kenneth Rohde Christiansen.

Since most of the time it will return the same thing as text(), we
initialize it the same way we initialize m_text. The other case (what
would have been generated if no modifiers were pressed) should be
covered by this as well.

As this method is used when handling access keys, tests such as
fast/events/access-key-self-destruct.html should now pass.

No new tests, as this fixes a problem uncovered by the existing ones.

platform/efl/PlatformKeyboardEventEfl.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

8:13 PM Changeset in webkit [95003] by commit-queue@webkit.org

1 edit
1 copy
2 moves
1 add
11 deletes in trunk/LayoutTests

Patch by Wyatt Carss <wcarss@chromium.org> on 2011-09-12
Reviewed by Eric Seidel.

convert editing/deleting/5390681-2.html to dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=63293

Renamed editing/deleting/5390681* to editing/deleting/smart-delete-across-editable-boundaries,
Added doctype/html/body to both tests, and converted smart-delete-across-editable-boundaries-2
to dump-as-markup test in the same style as the first. Also updated results.

editing/deleting/5390681.html: Removed.
editing/deleting/5390681-expected.txt: Removed.
editing/deleting/5390681-2.html: Removed.
editing/deleting/smart-delete-across-editable-boundaries.html: Added.
editing/deleting/smart-delete-across-editable-boundaries-expected.txt: Added.
editing/deleting/smart-delete-across-editable-boundaries-2.html: Added.
editing/deleting/smart-delete-across-editable-boundaries-2-expected.txt: Added.
platform/chromium-linux/editing/deleting/5390681-2-expected.png: Removed.
platform/chromium-win/editing/deleting/5390681-2-expected.png: Removed.
platform/chromium-win/editing/deleting/5390681-2-expected.txt: Removed.
platform/gtk/editing/deleting/5390681-2-expected.txt: Removed.
platform/mac-leopard/editing/deleting/5390681-2-expected.png: Removed.
platform/mac/editing/deleting/5390681-2-expected.png: Removed.
platform/mac/editing/deleting/5390681-2-expected.txt: Removed.
platform/qt/editing/deleting/5390681-2-expected.png: Removed.
platform/qt/editing/deleting/5390681-2-expected.txt: Removed.
platform/qt/editing/deleting/5390681-expected.png: Removed.

8:12 PM Changeset in webkit [95002] by commit-queue@webkit.org

1 edit
1 add in trunk/Source/WebCore

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2011-09-12
Reviewed by Eric Seidel.

[EFL] Add GraphicsContext3DEfl for WebGL and accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=62709

Add GraphicsContext3D implementation for EFL port.
GraphicsContext3D delegates to GraphicsContext3DInternal.

platform/graphics/efl/GraphicsContext3DEfl.cpp: Added.

(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3D::activeTexture):
(WebCore::GraphicsContext3D::attachShader):
(WebCore::GraphicsContext3D::bindAttribLocation):
(WebCore::GraphicsContext3D::bindBuffer):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::bindRenderbuffer):
(WebCore::GraphicsContext3D::bindTexture):
(WebCore::GraphicsContext3D::blendColor):
(WebCore::GraphicsContext3D::blendEquation):
(WebCore::GraphicsContext3D::blendEquationSeparate):
(WebCore::GraphicsContext3D::blendFunc):
(WebCore::GraphicsContext3D::blendFuncSeparate):
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::bufferSubData):
(WebCore::GraphicsContext3D::checkFramebufferStatus):
(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::clearColor):
(WebCore::GraphicsContext3D::clearDepth):
(WebCore::GraphicsContext3D::clearStencil):
(WebCore::GraphicsContext3D::colorMask):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::cullFace):
(WebCore::GraphicsContext3D::depthFunc):
(WebCore::GraphicsContext3D::depthMask):
(WebCore::GraphicsContext3D::depthRange):
(WebCore::GraphicsContext3D::detachShader):
(WebCore::GraphicsContext3D::disable):
(WebCore::GraphicsContext3D::disableVertexAttribArray):
(WebCore::GraphicsContext3D::drawArrays):
(WebCore::GraphicsContext3D::drawElements):
(WebCore::GraphicsContext3D::enable):
(WebCore::GraphicsContext3D::enableVertexAttribArray):
(WebCore::GraphicsContext3D::finish):
(WebCore::GraphicsContext3D::flush):
(WebCore::GraphicsContext3D::framebufferRenderbuffer):
(WebCore::GraphicsContext3D::framebufferTexture2D):
(WebCore::GraphicsContext3D::frontFace):
(WebCore::GraphicsContext3D::generateMipmap):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getAttachedShaders):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getBooleanv):
(WebCore::GraphicsContext3D::getBufferParameteriv):
(WebCore::GraphicsContext3D::getContextAttributes):
(WebCore::GraphicsContext3D::getError):
(WebCore::GraphicsContext3D::getFloatv):
(WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContext3D::getIntegerv):
(WebCore::GraphicsContext3D::getProgramiv):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getRenderbufferParameteriv):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::getTexParameterfv):
(WebCore::GraphicsContext3D::getTexParameteriv):
(WebCore::GraphicsContext3D::getUniformfv):
(WebCore::GraphicsContext3D::getUniformiv):
(WebCore::GraphicsContext3D::getUniformLocation):
(WebCore::GraphicsContext3D::getVertexAttribfv):
(WebCore::GraphicsContext3D::getVertexAttribiv):
(WebCore::GraphicsContext3D::getVertexAttribOffset):
(WebCore::GraphicsContext3D::hint):
(WebCore::GraphicsContext3D::isBuffer):
(WebCore::GraphicsContext3D::isEnabled):
(WebCore::GraphicsContext3D::isFramebuffer):
(WebCore::GraphicsContext3D::isProgram):
(WebCore::GraphicsContext3D::isRenderbuffer):
(WebCore::GraphicsContext3D::isShader):
(WebCore::GraphicsContext3D::isTexture):
(WebCore::GraphicsContext3D::lineWidth):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::pixelStorei):
(WebCore::GraphicsContext3D::polygonOffset):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::sampleCoverage):
(WebCore::GraphicsContext3D::scissor):
(WebCore::GraphicsContext3D::shaderSource):
(WebCore::GraphicsContext3D::stencilFunc):
(WebCore::GraphicsContext3D::stencilFuncSeparate):
(WebCore::GraphicsContext3D::stencilMask):
(WebCore::GraphicsContext3D::stencilMaskSeparate):
(WebCore::GraphicsContext3D::stencilOp):
(WebCore::GraphicsContext3D::stencilOpSeparate):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::texParameterf):
(WebCore::GraphicsContext3D::texParameteri):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::uniform1f):
(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform1i):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2f):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform2i):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3f):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform3i):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4f):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform4i):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
(WebCore::GraphicsContext3D::useProgram):
(WebCore::GraphicsContext3D::validateProgram):
(WebCore::GraphicsContext3D::vertexAttrib1f):
(WebCore::GraphicsContext3D::vertexAttrib1fv):
(WebCore::GraphicsContext3D::vertexAttrib2f):
(WebCore::GraphicsContext3D::vertexAttrib2fv):
(WebCore::GraphicsContext3D::vertexAttrib3f):
(WebCore::GraphicsContext3D::vertexAttrib3fv):
(WebCore::GraphicsContext3D::vertexAttrib4f):
(WebCore::GraphicsContext3D::vertexAttrib4fv):
(WebCore::GraphicsContext3D::vertexAttribPointer):
(WebCore::GraphicsContext3D::viewport):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::markContextChanged):
(WebCore::GraphicsContext3D::markLayerComposited):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3D::createBuffer):
(WebCore::GraphicsContext3D::createFramebuffer):
(WebCore::GraphicsContext3D::createProgram):
(WebCore::GraphicsContext3D::createRenderbuffer):
(WebCore::GraphicsContext3D::createShader):
(WebCore::GraphicsContext3D::createTexture):
(WebCore::GraphicsContext3D::deleteBuffer):
(WebCore::GraphicsContext3D::deleteFramebuffer):
(WebCore::GraphicsContext3D::deleteProgram):
(WebCore::GraphicsContext3D::deleteRenderbuffer):
(WebCore::GraphicsContext3D::deleteShader):
(WebCore::GraphicsContext3D::deleteTexture):
(WebCore::GraphicsContext3D::synthesizeGLError):
(WebCore::GraphicsContext3D::getExtensions):
(WebCore::GraphicsContext3D::getInternalFramebufferSize):
(WebCore::GraphicsContext3D::setContextLostCallback):
(WebCore::GraphicsContext3D::getImageData):

8:02 PM Changeset in webkit [95001] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2011-09-12
Reviewed by Eric Seidel.

[CMAKE] Remove platform/graphics/opengl/*OpenGL.cpp files in CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=62707

No change in fuctionality so no new tests.

Bug 62376 makes all ports use GraphicsContext3DOpenGL and
Extensions3DOpenGL when enabling WebGL.
However, some ports already have their own GC3D implementation.
In QT and chromium, for example, GC3D delegates to GC3DInternal.
So, it would be better to allow each port to decide whether or not
to include files in platform/graphics/opengl.

CMakeLists.txt:

7:59 PM Changeset in webkit [95000] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

platform/chromium/test_expectations.txt: fast/borders/border-image-omit-right-slice.html crash on debug

7:43 PM Changeset in webkit [94999] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewred, update chromium test expectations.

platform/chromium/test_expectations.txt: fast/events/constructors/progress-event-constructor.html on mac

7:25 PM Changeset in webkit [94998] by jamesr@google.com

2 edits in trunk/LayoutTests

[chromium] Remove bad expectation that was causing us to run a compositing/ test on Leopard. Tsk tsk, Mike
Reed!

platform/chromium/test_expectations.txt:

6:57 PM Changeset in webkit [94997] by jamesr@google.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for chromium.

Guard access to UString::latin1() with USE(JSC) since it is defined in JavaScriptCore/runtime/UString.cpp, which
is currently only compiled in by ports that use JavaScriptCore. This code is currently unreachable in builds so
no change in functionality.

yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::CharAccess::CharAccess):

6:33 PM Changeset in webkit [94996] by fpizlo@apple.com

20 edits
1 add in trunk/Source/JavaScriptCore

JavaScriptCore does not have speculative->baseline OSR
https://bugs.webkit.org/show_bug.cgi?id=67826

Reviewed by Oliver Hunt.

This adds the ability to bail out of DFG speculative JIT execution by
performing an on-stack replacement (OSR) that results in the control
flow going to the equivalent code generated by the old JIT.

This required a number of new features, as well as taking advantage of
some features that happened to already be present:

We already had a policy of storing the bytecode index for which a DFG
node was generated inside the DFG::Node class. This was previously
called exceptionInfo. It's now renamed to codeOrigin to reflect that
it's used for more than just excpetions. OSR uses this to figure out
which bytecode index to use to look up the machine code location in
the code generated by the old JIT that we should be jumping to.

CodeBlock now stores a mapping between bytecode indices and machine
code offsets for code generated by the old JIT. This is implemented
by CompactJITCodeMap, which tries to compress this data a bit. The
OSR compiler decodes this and uses it to find the machine code
locations it should be jumping to.

We already had a mechanism that emitted SetLocal nodes in the DFG graph
that told us the time at which the old JIT would have stored something
into its register file, and the DFG::Node that corresponds to the value
that it would have stored. These SetLocal's were mostly dead-code-
eliminated, but our DCE leaves the nodes intact except for making them
have 0 as the ref count. This allows the OSR compiler to construct a
mapping between the state as it would have been seen by the old JIT
and the state as the DFG JIT sees it. The OSR compiler uses this to
generate code that reshapes the call frame so that it is like what the
old JIT would expect.

Finally, when DFG_OSR is enabled (the default for TIERED_COMPILATION)
we no longer emit the non-speculative path.

JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/CodeBlock.h:
dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::addToGraph):

dfg/DFGGPRInfo.h:
dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::alive):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::appendCallWithExceptionCheck):

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

dfg/DFGJITCompiler.h:

(JSC::DFG::CallRecord::CallRecord):
(JSC::DFG::JITCompiler::notifyCall):
(JSC::DFG::JITCompiler::appendCallWithExceptionCheck):
(JSC::DFG::JITCompiler::appendCallWithFastExceptionCheck):
(JSC::DFG::JITCompiler::addJSCall):
(JSC::DFG::JITCompiler::JSCallRecord::JSCallRecord):

dfg/DFGNode.h:

(JSC::DFG::CodeOrigin::CodeOrigin):
(JSC::DFG::CodeOrigin::isSet):
(JSC::DFG::CodeOrigin::bytecodeIndex):
(JSC::DFG::Node::Node):
(JSC::DFG::Node::child1Unchecked):

dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::ValueSource::ValueSource):
(JSC::DFG::ValueSource::isSet):
(JSC::DFG::ValueSource::nodeIndex):
(JSC::DFG::ValueRecovery::ValueRecovery):
(JSC::DFG::ValueRecovery::alreadyInRegisterFile):
(JSC::DFG::ValueRecovery::inGPR):
(JSC::DFG::ValueRecovery::inFPR):
(JSC::DFG::ValueRecovery::displacedInRegisterFile):
(JSC::DFG::ValueRecovery::constant):
(JSC::DFG::ValueRecovery::technique):
(JSC::DFG::ValueRecovery::gpr):
(JSC::DFG::ValueRecovery::fpr):
(JSC::DFG::ValueRecovery::virtualRegister):
(JSC::DFG::OSRExit::numberOfRecoveries):
(JSC::DFG::OSRExit::valueRecovery):
(JSC::DFG::OSRExit::isArgument):
(JSC::DFG::OSRExit::argumentForIndex):
(JSC::DFG::OSRExit::variableForIndex):
(JSC::DFG::OSRExit::operandForIndex):
(JSC::DFG::SpeculativeJIT::osrExits):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::valueSourceForOperand):
(JSC::DFG::SpeculativeJIT::setNodeIndexForOperand):
(JSC::DFG::SpeculativeJIT::valueSourceReferenceForOperand):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculationCheckIndexIterator::SpeculationCheckIndexIterator):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):

jit/CompactJITCodeMap.h: Added.

(JSC::BytecodeAndMachineOffset::BytecodeAndMachineOffset):
(JSC::BytecodeAndMachineOffset::getBytecodeIndex):
(JSC::BytecodeAndMachineOffset::getMachineCodeOffset):
(JSC::CompactJITCodeMap::~CompactJITCodeMap):
(JSC::CompactJITCodeMap::decode):
(JSC::CompactJITCodeMap::CompactJITCodeMap):
(JSC::CompactJITCodeMap::at):
(JSC::CompactJITCodeMap::decodeNumber):
(JSC::CompactJITCodeMap::Encoder::Encoder):
(JSC::CompactJITCodeMap::Encoder::~Encoder):
(JSC::CompactJITCodeMap::Encoder::append):
(JSC::CompactJITCodeMap::Encoder::finish):
(JSC::CompactJITCodeMap::Encoder::appendByte):
(JSC::CompactJITCodeMap::Encoder::encodeNumber):
(JSC::CompactJITCodeMap::Encoder::ensureCapacityFor):

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompile):

jit/JIT.h:
runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

runtime/JSGlobalData.h:

(JSC::JSGlobalData::osrScratchBufferForSize):

runtime/JSValue.cpp:

(JSC::JSValue::description):

6:26 PM Changeset in webkit [94995] by kov@webkit.org

1 edit
1 move in trunk/Source/WebKit/gtk/po

Unreviewed. Rename Greek translation file, the correct code is el
(http://www.science.co.il/language/Locale-Codes.asp?s=decimal).

Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2011-09-12

el.po: Renamed from Source/WebKit/gtk/po/gr.po.

5:26 PM Changeset in webkit [94994] by rniwa@webkit.org

1 edit
2 copies in branches/chromium/874

Merge 94988 - REGRESSION: Moving up doesn't work in some cases
https://bugs.webkit.org/show_bug.cgi?id=67522

Reviewed by Eric Seidel.

Source/WebCore:

The bug was caused by previousLinePosition's attempting to obtain the last root line box using
a position at minCaretOffset (which is, in practice, located at the beginning of wrapped lines).

Fix the bug by calling maxCaretOffset instead. Because isCandidate returns false at (br, 1),
use the positionBeforeNode for br elements.

Test: editing/selection/move-up-into-wrapped-line.html

editing/visible_units.cpp:

(WebCore::previousLinePosition):

LayoutTests:

Add a test to move caret upwards from an empty line below wrapped lines.

WebKit used to skip wrapped lines and placed caret at the beginning of the first of those wrapped lines
instead of before the last.

editing/selection/move-up-into-wrapped-line-expected.txt: Added.
editing/selection/move-up-into-wrapped-line.html: Added.

Review URL: http://codereview.chromium.org/7878009

5:07 PM Changeset in webkit [94993] by eric@webkit.org

5 edits in trunk/Tools

sheriffbot whois is case sensitive
https://bugs.webkit.org/show_bug.cgi?id=67972

Reviewed by Adam Barth.

I also fixed a typo in the "More than 5 contributors" message
from my previous commit.

Scripts/webkitpy/common/config/committers.py:
Scripts/webkitpy/common/config/committers_unittest.py:
Scripts/webkitpy/tool/bot/irc_command.py:
Scripts/webkitpy/tool/bot/irc_command_unittest.py:

5:06 PM Changeset in webkit [94992] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

Re-enabled ENABLE(LAZY_BLOCK_FREEING).

Reviewed by Stephanie Lewis.

I accidentally disabled this in r94890, causing a big performance regression.

wtf/Platform.h:

5:02 PM Changeset in webkit [94991] by mitz@apple.com

4 edits
3 adds in trunk

<rdar://problem/10054615> Floats in ruby text intrude into the base

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/ruby/float-overhang-from-ruby-text.html

rendering/RenderRubyText.cpp:

(WebCore::RenderRubyText::avoidsFloats): Added. Returns true. This ensures that
RenderBlock::clearFloats() will not consider ruby text as having intruding floats.

rendering/RenderRubyText.h:

LayoutTests:

fast/ruby/float-overhang-from-ruby-text-expected.png: Added.
fast/ruby/float-overhang-from-ruby-text-expected.txt: Added.
fast/ruby/float-overhang-from-ruby-text.html: Added.

4:43 PM Changeset in webkit [94990] by eric@webkit.org

4 edits in trunk/Tools

sheriffbot whois should be smarter
https://bugs.webkit.org/show_bug.cgi?id=67971

Reviewed by Adam Barth.

This makes sheriffbot whois basically grep the committers list
making it much easier to find a contributor by name.

Unfortunately the current unittests depend on the real committers.py
file, so as we add more eric's to the project, this unittest result will
change. I think that's OK for now. We'll fix it when it breaks.

Scripts/webkitpy/common/config/committers.py:
Scripts/webkitpy/tool/bot/irc_command.py:
Scripts/webkitpy/tool/bot/irc_command_unittest.py:

4:38 PM Changeset in webkit [94989] by hyatt@apple.com

4 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=67970

Add unprefixed border-image property.

Reviewed by Beth Dakin.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

css/CSSPropertyNames.in:

4:32 PM Changeset in webkit [94988] by rniwa@webkit.org

3 edits
2 adds in trunk

REGRESSION: Moving up doesn't work in some cases
https://bugs.webkit.org/show_bug.cgi?id=67522

Reviewed by Eric Seidel.

Source/WebCore:

The bug was caused by previousLinePosition's attempting to obtain the last root line box using
a position at minCaretOffset (which is, in practice, located at the beginning of wrapped lines).

Fix the bug by calling maxCaretOffset instead. Because isCandidate returns false at (br, 1),
use the positionBeforeNode for br elements.

Test: editing/selection/move-up-into-wrapped-line.html

editing/visible_units.cpp:

(WebCore::previousLinePosition):

LayoutTests:

Add a test to move caret upwards from an empty line below wrapped lines.

WebKit used to skip wrapped lines and placed caret at the beginning of the first of those wrapped lines
instead of before the last.

editing/selection/move-up-into-wrapped-line-expected.txt: Added.
editing/selection/move-up-into-wrapped-line.html: Added.

4:14 PM Changeset in webkit [94987] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

Broken Build for ARM - lshift32() needs TrustedImm32 arg
https://bugs.webkit.org/show_bug.cgi?id=67965

Change lshift32(16, ARMRegisters::S1); to lshift32(TrustedImm32(16), ARMRegisters::S1);

Reviewed by Anders Carlsson.

assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::branch16):

3:48 PM Changeset in webkit [94986] by levin@chromium.org

3 edits in trunk/Source/WebCore

Make the ThreadSafeRefCounted support in CrossThreadCopier work for T*.
https://bugs.webkit.org/show_bug.cgi?id=67947

Reviewed by Adam Barth.

The changes are tested by compiling and added compile asserts to do some verification as well.

platform/CrossThreadCopier.cpp:

Added some compile asserts to verify various match and non-matches for CrossThreadCopier.

platform/CrossThreadCopier.h:

Added a typedef to convert T* to T, just like the typedef's to remove RefPtr and PassRefPtr.
Added a compile assert to verify that only one of the typedefs did anything.
(CrossThreadCopierBase<false, true, T>::copy): Remove "get" as it is unnecessary.
It shouldn't have been here (PassRefPtr and RefPtr easily and sometimes more efficiently
convert to PassRefPtr without get). Also, a raw pointer doesn't have a get() method.

3:43 PM Changeset in webkit [94985] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

Broken ARM build - missing semicolon in JavaScriptCore/assembler/MacroAssemblerARM.h
https://bugs.webkit.org/show_bug.cgi?id=67961

Added missing semicolon.

Reviewed by Ryosuke Niwa.

assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::branch16):

3:43 PM Changeset in webkit [94984] by crogers@google.com

2 edits in trunk/Source/WebCore

Address lifetime issues in OfflineAudioDestinationNode
https://bugs.webkit.org/show_bug.cgi?id=67949

Reviewed by Kenneth Russell.

No new tests. This does not change JavaScript API.

webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::~OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::render):
(WebCore::OfflineAudioDestinationNode::notifyCompleteDispatch):

3:21 PM Changeset in webkit [94983] by commit-queue@webkit.org

2 edits in trunk/Tools

Unreviewed, rolling out r94976.
http://trac.webkit.org/changeset/94976
https://bugs.webkit.org/show_bug.cgi?id=67953

Broke a bunch of security/load& tests (Requested by rniwa on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-12

DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::pathToLocalResource):

3:19 PM Changeset in webkit [94982] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[chromium] Prevent a crash when tearing down an ImageBuffer that was not successfully initialized.
https://bugs.webkit.org/show_bug.cgi?id=67944

Patch by Jeff Timanus <twiz@chromium.org> on 2011-09-12
Reviewed by Stephen White.

platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::~ImageBuffer):

3:17 PM Changeset in webkit [94981] by msaboff@apple.com

24 edits in trunk/Source

Update RegExp and related classes to use 8 bit strings when available
https://bugs.webkit.org/show_bug.cgi?id=67337

Source/JavaScriptCore:

Modified both the Yarr interpreter and JIT to handle 8 bit subject strings.
The code paths are triggered by the UString::is8bit() method which currently
returns false. Implemented JIT changes for all current architectures.
Tested X86_64 and ARM v7.

This includes some code that will likely change as we complete the
8 bit string changes. This includes the way the raw buffer pointers
are accessed as well as replacing the CharAccess class with a
string interator returned from UString.

Fixed build breakage in testRegExp.cpp due to globalObject construction
changes.

Reviewed by Gavin Barraclough.

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
testRegExp.cpp:

(GlobalObject::finishCreation):
(GlobalObject::GlobalObject):

assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::baseIndexTransfer32):

assembler/ARMAssembler.h:
assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::ubfx):
(JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp12Reg40Imm3Reg4Imm20Imm5):

assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::load8):
(JSC::MacroAssemblerARM::branch8):
(JSC::MacroAssemblerARM::branch16):

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::load8):
(JSC::MacroAssemblerARMv7::branch16):
(JSC::MacroAssemblerARMv7::branch8):

assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::load8):
(JSC::MacroAssemblerMIPS::branch8):
(JSC::MacroAssemblerMIPS::branch16):

assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::load8):
(JSC::MacroAssemblerSH4::branch8):
(JSC::MacroAssemblerSH4::branch16):

assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::load8):
(JSC::MacroAssemblerX86Common::branch16):
(JSC::MacroAssemblerX86Common::branch8):

assembler/SH4Assembler.h:

(JSC::SH4Assembler::extub):
(JSC::SH4Assembler::printInstr):

assembler/X86Assembler.h:

(JSC::X86Assembler::cmpw_ir):
(JSC::X86Assembler::movzbl_mr):

runtime/RegExp.cpp:

(JSC::RegExp::compile):
(JSC::RegExp::compileIfNecessary):
(JSC::RegExp::match):
(JSC::RegExp::matchCompareWithInterpreter):

runtime/RegExp.h:
runtime/UString.h:

(JSC::UString::is8Bit):

yarr/Yarr.h:
yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::CharAccess::CharAccess):
(JSC::Yarr::Interpreter::CharAccess::~CharAccess):
(JSC::Yarr::Interpreter::CharAccess::operator[]):
(JSC::Yarr::Interpreter::InputStream::InputStream):
(JSC::Yarr::Interpreter::Interpreter):
(JSC::Yarr::interpret):

yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::jumpIfCharNotEquals):
(JSC::Yarr::YarrGenerator::readCharacter):
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
(JSC::Yarr::YarrGenerator::generateDotStarEnclosure):
(JSC::Yarr::YarrGenerator::YarrGenerator):
(JSC::Yarr::YarrGenerator::compile):
(JSC::Yarr::jitCompile):
(JSC::Yarr::execute):

yarr/YarrJIT.h:

(JSC::Yarr::YarrCodeBlock::has8BitCode):
(JSC::Yarr::YarrCodeBlock::has16BitCode):
(JSC::Yarr::YarrCodeBlock::set8BitCode):
(JSC::Yarr::YarrCodeBlock::set16BitCode):
(JSC::Yarr::YarrCodeBlock::execute):

yarr/YarrParser.h:

(JSC::Yarr::Parser::Parser):

Source/WebCore:

Updated call to match to use UString& instead of UChar*.

Reviewed by Gavin Barraclough.

No new tests, Covered by existing tests.

platform/text/RegularExpression.cpp:

(WebCore::RegularExpression::match):

2:52 PM Changeset in webkit [94980] by Beth Dakin

6 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=67898
REGRESSION(r94900): fast/images/support-broken-image-delegate.html fails on Mac

Reviewed by Simon Fraser.

Source/WebCore:

New function willPaintBrokenImage() returns true when there has been an error
loading the image and the broken image icon will be used in its place. This is
necessary since it is possible to have an error loading an image and to NOT use
the broken image icon.

loader/cache/CachedImage.cpp:

(WebCore::CachedImage::willPaintBrokenImage):

loader/cache/CachedImage.h:
rendering/RenderImage.cpp:

(WebCore::RenderImage::imageSizeForError):

LayoutTests:

platform/mac/Skipped:

2:41 PM Changeset in webkit [94979] by igor.oliveira@openbossa.org

9 edits in trunk/Source/WebKit2

2011-09-12 Igor Oliveira <igor.oliveira@openbossa.org>

[Qt] [WK2] implement support to upload files in Qt WebKit2
https://bugs.webkit.org/show_bug.cgi?id=67228

This patch implements support to upload files in the Desktop Qt WebKit2 implementation.

Reviewed by Andreas Kling.

Shared/WebOpenPanelParameters.h: (WebKit::WebOpenPanelParameters::selectedFileNames):
UIProcess/API/qt/qdesktopwebview.cpp: (QDesktopWebViewPrivate::chooseFiles): (QDesktopWebViewPrivate::onOpenPanelFilesSelected): (QDesktopWebViewPrivate::onOpenPanelFinished):
UIProcess/API/qt/qdesktopwebview_p.h:
UIProcess/qt/ClientImpl.cpp:

qt_wk_runOpenPanel supports single and multiple files selection.

(qt_wk_runOpenPanel):

UIProcess/qt/ClientImpl.h:
UIProcess/qt/QtWebPageProxy.cpp: (QtWebPageProxy::init):
UIProcess/qt/TouchViewInterface.h: (WebKit::TouchViewInterface::chooseFiles):
UIProcess/qt/ViewInterface.h:

2:11 PM Changeset in webkit [94978] by eric@webkit.org

10 edits
1 delete in trunk/Tools

Rubber-stamped by Adam Barth.

Remove the "the tree is burning!" warning previously shown
when landing patches. It was a dream. But it's just noise now.

Some bots will require a restart to notice the removal of the option
so I've left the --ignore-builders option in for now.

Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
Scripts/webkitpy/tool/bot/patchanalysistask.py:
Scripts/webkitpy/tool/commands/download.py:
Scripts/webkitpy/tool/commands/download_unittest.py:
Scripts/webkitpy/tool/commands/queues_unittest.py:
Scripts/webkitpy/tool/steps/init.py:
Scripts/webkitpy/tool/steps/commit.py:
Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
Scripts/webkitpy/tool/steps/postdiffforrevert.py:

2:05 PM Changeset in webkit [94977] by rniwa@webkit.org

3 edits in trunk/LayoutTests

Fix a test added by r94966 to work on Mac.

fast/events/selectstart-by-arrow-keys.html:
platform/chromium/test_expectations.txt:

1:54 PM Changeset in webkit [94976] by eric@webkit.org

2 edits in trunk/Tools

[NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
https://bugs.webkit.org/show_bug.cgi?id=65781

Reviewed by Ryosuke Niwa.

Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
to resolve the passed in url relative to the absolute url for the test.

I believe this is a better approach than the on used in the Qt and Chromium DRT's
(which resolves the path relative to the built location of the DRT executable)
and we should move this new code into a shared location in a follow-up patch.

DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::pathToLocalResource):

1:30 PM Changeset in webkit [94975] by jamesr@google.com

37 edits
3 adds in trunk

[chromium] Move contents texture manager from LayerRendererChromium to CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=67440

Reviewed by Kenneth Russell.

This moves the contents TextureManager over to the CCLayerTreeHost, where it belongs, and adds in a commit path
to make sure that textures are deleted even if the page is not visible. This move also removed the need for
LayerRendererChromium's CCLayerTreeHost pointer, so I removed that as well. That meant moving the
layerTreeAsText() logic over to the CCLayerImpl side, which is where it really belonged anyway.

Covered by existing compositing/ tests and
platform/chromium/compositor/lost-compositor-context-with-rendersurface.html

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::setContentsTextureMemoryUseBytes):

platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::highLimitBytes):
(WebCore::TextureManager::reclaimLimitBytes):
(WebCore::TextureManager::lowLimitBytes):

platform/graphics/chromium/TextureManager.h:
platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::deleteContentsTextures):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::contentsTextureManager):

platform/graphics/chromium/cc/CCLayerTreeHost.h:
platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setVisible):

platform/graphics/chromium/cc/CCProxy.h:
platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::stop):

platform/graphics/chromium/cc/CCSingleThreadProxy.h:
platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):

platform/graphics/chromium/cc/CCThreadProxy.h:

1:15 PM Changeset in webkit [94974] by Nate Chapin

2 edits in trunk/LayoutTests

2011-09-12 Nate Chapin <Nate Chapin>

Fix up duplicate expectations and add expected failure
for selectstart-by-arrow-keys.html for chromium mac.

platform/chromium/test_expectations.txt:

1:06 PM Changeset in webkit [94973] by eric@webkit.org

3 edits in trunk/Tools

Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
https://bugs.webkit.org/show_bug.cgi?id=67530

Reviewed by Adam Barth.

I believe I've fixed the bug in the original patch which prompted the rollout.
The previous patch was using the wrong deadline for the initial read,
subtracting time.time() twice from the deadline value.

Scripts/webkitpy/layout_tests/port/webkit.py:
Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

1:05 PM Changeset in webkit [94972] by commit-queue@webkit.org

20 edits
1 delete in trunk/LayoutTests

Rebaseline for r94703.
https://bugs.webkit.org/show_bug.cgi?id=67945

Patch by David Reveman <reveman@chromium.org> on 2011-09-12
Reviewed by James Robinson.

platform/chromium-gpu-cg-mac/compositing/color-matching/image-color-matching-expected.png:
platform/chromium-gpu-cg-mac/compositing/flat-with-transformed-child-expected.png:
platform/chromium-gpu-cg-mac/compositing/masks/masked-ancestor-expected.png:
platform/chromium-gpu-cg-mac/compositing/reflections/nested-reflection-transformed-expected.png:
platform/chromium-gpu-cg-mac/compositing/reflections/nested-reflection-transformed2-expected.png:
platform/chromium-gpu-cg-mac/compositing/reflections/reflection-in-composited-expected.png:
platform/chromium-gpu-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png:
platform/chromium-gpu-cg-mac/media/video-layer-crash-expected.png:
platform/chromium-gpu-cg-mac/media/video-transformed-expected.png:
platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.png:
platform/chromium-gpu-win/compositing/flat-with-transformed-child-expected.png:
platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.png:
platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.png:
platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.png:
platform/chromium-gpu-win/compositing/reflections/reflection-in-composited-expected.png:
platform/chromium-gpu-win/compositing/scaling/tiled-layer-recursion-expected.png:
platform/chromium-gpu-win/media/video-layer-crash-expected.png:
platform/chromium-gpu-win/media/video-transformed-expected.png:
platform/chromium/test_expectations.txt:
platform/mac-snowleopard/media/video-layer-crash-expected.txt: Removed.

1:05 PM Porting Macros plan edited by abarth@webkit.org

(diff)

12:53 PM Changeset in webkit [94971] by nduca@chromium.org

7 edits in trunk/Source/WebKit/chromium

[chromium] Add GraphicsContext3DPrivate:createGraphicsContextForAnotherThread
https://bugs.webkit.org/show_bug.cgi?id=67832

The compositor thread needs to create a GraphicsContext3D without
actually making it current. In previous attempts at doing this, we
modified all graphics3D creation to not make the contexts current, but
this prove to be shockingly fragile. Since this is a very
Chromium-specific behavior, this patch makes creationForAnotherThread a
method on the private GraphicsContext3D interface.
GraphicsContext3D::create behaves as usual.

Reviewed by Kenneth Russell.

src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextForAnotherThread):
(WebCore::GraphicsContext3D::create):

src/GraphicsContext3DPrivate.h:
src/WebViewImpl.cpp:

(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::graphicsContext3D):

tests/MockGraphicsContext3DTest.cpp:

(TEST):

12:50 PM Changeset in webkit [94970] by eric@webkit.org

2 edits in trunk/LayoutTests

Implement a HashChangeEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=67924

Unreviewed. Updating results which were forgotten.

fast/dom/constructed-objects-prototypes-expected.txt:

12:35 PM WebKit Team edited by adauria@apple.com

Adding myself to list of committers. (diff)

11:55 AM Changeset in webkit [94969] by crogers@google.com

3 edits
2 adds in trunk

DelayNode delay buffer is not correctly wrapping around
https://bugs.webkit.org/show_bug.cgi?id=67872

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/delaynode.html

webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::process):

LayoutTests:

webaudio/delaynode-expected.txt: Added.
webaudio/delaynode.html: Added.

11:12 AM Changeset in webkit [94968] by Csaba Osztrogonác

4 edits in trunk/Source/WebKit/qt

[Qt] Fix "Unmatched parentheses are deprecated." warnings
https://bugs.webkit.org/show_bug.cgi?id=67775

Reviewed by Zoltan Herczeg.

Modify function declarations to single line to make qmake happier.

Api/qwebframe.h:
Api/qwebpluginfactory.h:
Api/qwebview.h:

11:00 AM Changeset in webkit [94967] by jamesr@google.com

6 edits in branches/chromium/874/Source/WebCore

Merge 94964 - [chromium] REGRESSION(94353): Compositor textures and resources leaked when tab closed that is not last tab in the process
https://bugs.webkit.org/show_bug.cgi?id=67816

Reviewed by Kenneth Russell.

We lack infrastructure to construct an automated test for this today. To test manually, open up a composited
page (like the poster circle), duplicate the tab many times, close all the duplicates, and verify that the
memory use returns to the single tab level.

platform/graphics/chromium/LayerChromium.h:
platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setLayerTreeHost):

platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::setLayerTreeHost):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::clearRenderSurfacesRecursive):
(WebCore::CCLayerTreeHost::setRootLayer):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

TBR=jamesr@google.com
BUG=96288
Review URL: http://codereview.chromium.org/7873004

10:55 AM Changeset in webkit [94966] by commit-queue@webkit.org

4 edits
4 adds in trunk

Selectstart is not fired when selection was created by arrow keys.
https://bugs.webkit.org/show_bug.cgi?id=60430

Patch by Arko Saha <arko@motorola.com> on 2011-09-12
Reviewed by Ryosuke Niwa.

Source/WebCore:

Fire selectstart when a user starts extending the selection using arrow key.
Fixed by Arko Saha <arko@motorola.com> and Kaustubh Atrawalkar <Kaustubh Atrawalkar>

Tests: fast/events/selectstart-by-arrow-keys-prevent-default.html

fast/events/selectstart-by-arrow-keys.html

editing/FrameSelection.cpp:

(WebCore::FrameSelection::modify):
(WebCore::FrameSelection::shouldChangeSelection):
(WebCore::FrameSelection::dispatchSelectStart):

editing/FrameSelection.h:

LayoutTests:

fast/events/selectstart-by-arrow-keys-expected.txt: Added.
fast/events/selectstart-by-arrow-keys-prevent-default-expected.txt: Added.
fast/events/selectstart-by-arrow-keys-prevent-default.html: Added.
fast/events/selectstart-by-arrow-keys.html: Added.

10:54 AM Changeset in webkit [94965] by commit-queue@webkit.org

5 edits
4 adds in trunk/Source/WebKit/efl

Patch by Flavio Ceolin <flavio.ceolin@profusion.mobi> on 2011-09-12
Reviewed by Martin Robinson.

[EFL] Add custom network resource handler
https://bugs.webkit.org/show_bug.cgi?id=44759

This patch adds support for handling user-specific protocols.
It allows browsers to intercept and handle non-standard url schemes (such as preferences://)
allowing to load some resource from non-http/file storage, like a tar/zip/eet.

CMakeListsEfl.txt:
ewk/ewk_protocol_handler.cpp: Added.
ewk/ewk_protocol_handler.h: Added.
ewk/ewk_protocol_handler_soup.cpp: Added.
ewk/ewk_protocol_handler_soup.h: Added.
ewk/ewk_private.h:
ewk/ewk_view.cpp:

(ewk_view_protocol_handler_set):
(ewk_view_protocol_handler_unset):
(ewk_view_protocol_handler_resource_get):

ewk/ewk_view.h:

10:52 AM Changeset in webkit [94964] by jamesr@google.com

6 edits in trunk/Source/WebCore

[chromium] REGRESSION(94353): Compositor textures and resources leaked when tab closed that is not last tab in the process
https://bugs.webkit.org/show_bug.cgi?id=67816

Reviewed by Kenneth Russell.

platform/graphics/chromium/LayerChromium.h:
platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setLayerTreeHost):

platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::setLayerTreeHost):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::clearRenderSurfacesRecursive):
(WebCore::CCLayerTreeHost::setRootLayer):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

10:45 AM Changeset in webkit [94963] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Chromium shadow-buffer-partial test change.
https://bugs.webkit.org/show_bug.cgi?id=67849

Patch by Ben Wagner <bungeman@chromium.org> on 2011-09-12
Reviewed by Kenneth Russell.

platform/chromium/test_expectations.txt:

10:44 AM Rebaseline edited by jamesr@google.com

(diff)

10:40 AM Changeset in webkit [94962] by commit-queue@webkit.org

7 edits
2 adds in trunk

Implement a HashChangeEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=67924

Patch by Kentaro Hara <haraken@google.com> on 2011-09-12
Reviewed by Sam Weinig.

Source/WebCore:

The spec for the HashChangeEvent constructor is here:
http://www.whatwg.org/specs/web-apps/current-work/#hashchangeevent

Test: fast/events/constructors/hash-change-event-constructor.html

bindings/generic/EventConstructors.h: Added a definition for the HashChangeEvent constructor.
bindings/js/JSEventConstructors.cpp: Added #includes for HashChangeEvent.
dom/HashChangeEvent.h: Added a definition for HashChangeEventInit.

(WebCore::HashChangeEventInit::HashChangeEventInit):
(WebCore::HashChangeEvent::create):
(WebCore::HashChangeEvent::HashChangeEvent):

dom/HashChangeEvent.idl: Makes HashChangeEvent constructible.

LayoutTests:

hash-change-event-constructor.html checks the behavior of the HashChangeEvent constructor.

fast/events/constructors/hash-change-event-constructor-expected.txt: Added.
fast/events/constructors/hash-change-event-constructor.html: Added.
platform/chromium/test_expectations.txt: Skipped hash-change-event-constructor.html, since V8 does not yet have the HashChangeEvent constructor.

10:31 AM Changeset in webkit [94961] by reed@google.com

2 edits in trunk/Source/WebCore

[skia] remove dead code, no functionality change
https://bugs.webkit.org/show_bug.cgi?id=67844

Reviewed by Kenneth Russell.

No new tests. just removing dead-code, existing tests apply

platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::drawGlyphs):

10:02 AM Changeset in webkit [94960] by alexis.menard@openbossa.org

2 edits in trunk/Source/WebKit2

[Qt]Style error fix.

Reviewed by Andreas Kling.

UIProcess/qt/QtWebPageProxy.cpp:

9:46 AM Changeset in webkit [94959] by Nate Chapin

2 edits in trunk/LayoutTests

2011-09-12 Nate Chapin <Nate Chapin>

Add video-zoom-controls.html to chromium expectations
for leopard gpu.

platform/chromium/test_expectations.txt:

8:24 AM Changeset in webkit [94958] by pfeldman@chromium.org

5 edits in trunk

Web Inspector: Runtime.callFunctionOn does not accept arguments that evaluate to false.
https://bugs.webkit.org/show_bug.cgi?id=67934

Reviewed by Tony Gentilcore.

Source/WebCore:

inspector/InjectedScriptSource.js:

LayoutTests:

inspector/runtime/runtime-setPropertyValue.html:

8:22 AM Changeset in webkit [94957] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: event dividers do not update timeline boundaries.
https://bugs.webkit.org/show_bug.cgi?id=67932

inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._onLoadEventFired):
(WebInspector.NetworkLogView.prototype._domContentLoadedEventFired):
(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkTimeCalculator.prototype.updateBoundariesForEventTime):

7:54 AM Changeset in webkit [94956] by kbalazs@webkit.org

1 edit in trunk/Tools/ChangeLog

Oops. Missed the reviewer in my the previous commit.

7:20 AM Changeset in webkit [94955] by kbalazs@webkit.org

2 edits in trunk/Tools

[Qt][WK2] WebKitTestRunner does not produce crash logs
https://bugs.webkit.org/show_bug.cgi?id=67714

Added a simple way of generating backtrace on crash
to the web process. The implementation is similar what
we have in DRT. It depends on GNU libc functionality
so it is only enabled where we are running in such an environment.

WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:

(WTR::printBacktrace):
(WTR::crashHandler):
(WTR::InjectedBundle::platformInitialize):

6:33 AM Changeset in webkit [94954] by abecsi@webkit.org

2 edits in trunk/Source/JavaScriptCore

[Qt] Build fails after r94920 with strict compiler
https://bugs.webkit.org/show_bug.cgi?id=67928

Reviewed by Csaba Osztrogonác.

wtf/RedBlackTree.h:

(WTF::RedBlackTree::insert): Remove dead variables updateStart and newSubTreeRoot.

4:09 AM Changeset in webkit [94953] by commit-queue@webkit.org

5 edits in trunk

Implement a WebKitAnimationEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=67922

Patch by Kentaro Hara <haraken@google.com> on 2011-09-12
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/constructors/webkit-animation-event-constructor.html

bindings/v8/custom/V8EventConstructors.cpp: Added the WebKitAnimationEvent constructor.
dom/WebKitAnimationEvent.idl: Added a 'V8CustomConstructor' attribute.

LayoutTests:

Enabled webkit-animation-event-constructor.html, since now V8 has a WebKitAnimationEvent constructor.

platform/chromium/test_expectations.txt:

4:03 AM Changeset in webkit [94952] by Patrick Gansterer

4 edits in trunk/Source/JavaScriptCore

Unreviewed build fix after r94871.

runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

wtf/FastMalloc.cpp:
wtf/RefCountedLeakCounter.h:

2:48 AM Changeset in webkit [94951] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Shrink CanvasGradient for builds without ENABLE(DASHBOARD_SUPPORT).
https://bugs.webkit.org/show_bug.cgi?id=67916

Patch by Andreas Kling <kling@webkit.org> on 2011-09-12
Reviewed by Kenneth Rohde Christiansen.

html/canvas/CanvasGradient.cpp:

(WebCore::CanvasGradient::CanvasGradient):
(WebCore::CanvasGradient::addColorStop):

html/canvas/CanvasGradient.h:

1:45 AM Changeset in webkit [94950] by zoltan@webkit.org

2 edits in trunk/LayoutTests

[Qt][ARMv5] fast/events/constructors/progress-event-constructor.html is failing
https://bugs.webkit.org/show_bug.cgi?id=67927

Skip it.

platform/qt-arm/Skipped:

1:09 AM Changeset in webkit [94949] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

platform/chromium/test_expectations.txt: add fast/events/constructors/progress-event-constructor.html

12:21 AM Changeset in webkit [94948] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

platform/chromium/test_expectations.txt: perf/show-hide-table-rows.html slow to timeout

12:14 AM Changeset in webkit [94947] by commit-queue@webkit.org

3 edits
2 adds in trunk

Characters beyond U+10000 should be deleted by one pressing delete key.
https://bugs.webkit.org/show_bug.cgi?id=40351

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-09-12
Reviewed by Kent Tamura.

Source/WebCore:

If a character is the trail part of unicode surrogate pair, the lead part of it
should also be deleted. Also, If in MacOSX, the deletion should honor Mac's behavior.

Test: editing/deleting/delete-surrogatepair.html

rendering/RenderText.cpp:

(WebCore::RenderText::previousOffsetForBackwardDeletion):

Added if-macro to support chromium on mac, and added trail part check for unicode character.

LayoutTests:

Added deletion tests.

editing/deleting/delete-surrogatepair-expected.txt: Added.
editing/deleting/delete-surrogatepair.html: Added.

Sep 11, 2011:

10:46 PM Changeset in webkit [94946] by hayato@chromium.org

8 edits in trunk

Implement a ProgressEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=67800

Patch by Kentaro Hara <haraken@google.com> on 2011-09-11
Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/events/constructors/progress-event-constructor.html

bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue): Replaced UnsignedLongLongMax with std::numeric_limits<unsigned long long>::max().

bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::getKeyValue): Returns an unsigned long long value corresponding to a given key. Spec: http://www.w3.org/TR/WebIDL/#es-unsigned-long-long

bindings/v8/OptionsObject.h:
bindings/v8/custom/V8EventConstructors.cpp: Added the ProgressEvent constructor.
dom/ProgressEvent.idl: Added a 'V8CustomConstructor' attribute.

LayoutTests:

Enabled fast/events/constructors/progress-event-constructor.html

platform/chromium/test_expectations.txt:

10:26 PM Changeset in webkit [94945] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

platform/chromium/test_expectations.txt: slow perf/show-hide-table-rows.html

9:20 PM Changeset in webkit [94944] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

platform/chromium/test_expectations.txt: slow perf/document-contains.html

9:00 PM Changeset in webkit [94943] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

platform/chromium/test_expectations.txt: add svg/custom/simple-text-double-shadow.svg

8:42 PM Changeset in webkit [94942] by fpizlo@apple.com

16 edits in trunk/Source/JavaScriptCore

DFGNode.h has macros that indicate the enabling of a feature, but
they do not use the ENABLE() idiom.
https://bugs.webkit.org/show_bug.cgi?id=67907

Reviewed by Oliver Hunt.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::stronglyPredict):
(JSC::DFG::ByteCodeParser::parse):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::predictArgumentTypes):

dfg/DFGJITCodeGenerator.cpp:
dfg/DFGJITCodeGenerator.h:
dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

dfg/DFGJITCompiler.h:
dfg/DFGNode.h:
dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::propagateForward):
(JSC::DFG::Propagator::propagateBackward):
(JSC::DFG::propagate):

dfg/DFGScoreBoard.h:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):

jit/JIT.cpp:

(JSC::JIT::privateCompile):

8:34 PM Changeset in webkit [94941] by koz@chromium.org

6 edits
14 moves
34 adds
28 deletes in trunk/LayoutTests

Rebaseline for bug 65583 (path based border radius drawing on skia) part 3
https://bugs.webkit.org/show_bug.cgi?id=67830

Patch by Ben Wells <benwells@chromium.org> on 2011-09-11
Reviewed by Kenneth Russell.

fast/borders/: 13 changes
fast/frames/iframe-scaling-with-scroll-expected.txt: Renamed from LayoutTests/platform/gtk/fast/frames/iframe-scaling-with-scroll-expected.txt.
platform/chromium-linux/fast/: 18 changes
platform/chromium-win/fast/: 21 changes
platform/chromium/test_expectations.txt:
platform/mac/fast/: 13 removals
platform/qt/fast/: 14 removals

8:34 PM Changeset in webkit [94940] by mrowe@apple.com

3 edits in trunk/Source/WebKit2

<rdar://problem/9878268> Pressing caps lock after closing a showModalDialog window results in WebProcess exiting

It's incorrect to try and use -[NSApplication run] to run nested runloops as it is not possible to
interrupt a nested invocation of -run without also causing outer invocations to exit after processing
their next event. We can avoid this issue by using -[NSApplication run] for the outermost invocation
of the main runloop, while using CFRunLoopRun for any nested invocations.

Reviewed by Anders Carlsson.

Platform/RunLoop.h:
Platform/mac/RunLoopMac.mm:

(RunLoop::RunLoop): Initialize the nesting level to 0.
(RunLoop::run): Bump the nesting level, and only use -[NSApplication run] for the outermost invocation of the
runloop. We also switch from -[NSRunloop run] to CFRunLoopRun as the former will only exit when it has no sources
left to process, while CFRunLoopRun will return immediately after CFRunLoopStop is called on it.
(RunLoop::stop): Only go down the NSApp path for the outermost invocation of the runloop.

8:31 PM Changeset in webkit [94939] by ukai@chromium.org

2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for chromium/mac & clang.

Fix the macro redefinition error by r94927, because chromium set
ENABLE_JSC_MULTIPLE_THREADS=0 in WebKit/chromium/features.gypi and
it is not PLATFORM(QT).

../../JavaScriptCore/wtf/Platform.h:512:9: error: 'ENABLE_JSC_MULTIPLE_THREADS' macro redefined [-Werror]
#define ENABLE_JSC_MULTIPLE_THREADS 1
<command line>:43:9: note: previous definition is here
#define ENABLE_JSC_MULTIPLE_THREADS 0
1 error generated.

wtf/Platform.h:

8:25 PM Changeset in webkit [94938] by Dimitri Glazkov

4 edits
2 adds in trunk

REGRESSION (r87351): toggling display of lots (thousands) of elements with display:none is very slow
https://bugs.webkit.org/show_bug.cgi?id=67581

Reviewed by Darin Adler.

Source/WebCore:

Test: perf/show-hide-table-rows.html

dom/NodeRenderingContext.cpp:

(WebCore::NodeRendererFactory::createRendererAndStyle): Moved style-creating code into createRendererIfNeeded, renamed

to createRenderer.

(WebCore::NodeRendererFactory::createRendererIfNeeded): Re-arrange code to avoid unnecessary creation of renderers.

LayoutTests:

perf/show-hide-table-rows-expected.txt: Added.
perf/show-hide-table-rows.html: Added.

8:21 PM Changeset in webkit [94937] by kbalazs@webkit.org

2 edits in trunk/Source/WebKit2

[Qt][WK2] Qt layer should be hardened against C API versioning in the sense of build failures
https://bugs.webkit.org/show_bug.cgi?id=67094

Reviewed by Andreas Kling.

UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init):

8:14 PM Changeset in webkit [94936] by jeremy@chromium.org

7 edits in trunk/Source

[Chromium] Change OOP Font loading code to use CGFont*() APIs.
https://bugs.webkit.org/show_bug.cgi?id=66935

This change is necessary due a bug in ATSFontDeactivate() on 10.7.
See crbug.com/93191 for details.

Reviewed by Eric Seidel.

Source/WebCore:

No new tests - covered by existing tests.

platform/chromium/PlatformBridge.h:
platform/graphics/chromium/CrossProcessFontLoading.h:
platform/graphics/chromium/CrossProcessFontLoading.mm:

(WebCore::MemoryActivatedFont::create):
(WebCore::MemoryActivatedFont::MemoryActivatedFont):
(WebCore::MemoryActivatedFont::~MemoryActivatedFont):

Source/WebKit/chromium:

public/mac/WebSandboxSupport.h:
src/PlatformBridge.cpp:

(WebCore::PlatformBridge::loadFont):

7:22 PM Changeset in webkit [94935] by abarth@webkit.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Add more key codes to WebInputEvent for Android
https://bugs.webkit.org/show_bug.cgi?id=67887

Reviewed by Darin Fisher.

src/WebInputEvent.cpp:

(WebKit::staticKeyIdentifiers):

7:19 PM Changeset in webkit [94934] by ukai@chromium.org

2 edits
1 delete in trunk/LayoutTests

Unreviewed, one more rebaseline for r94912

platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:

6:52 PM Changeset in webkit [94933] by ukai@chromium.org

4 edits
2 deletes in trunk/LayoutTests

Unreviewed, update chromium test expectations and rebaselines for r94912

platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
platform/chromium-cg-mac/svg/css/getComputedStyle-basic-expected.txt: Removed.
platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
platform/chromium/test_expectations.txt:

3:41 PM Changeset in webkit [94932] by weinig@apple.com

3 edits in trunk/Source/JavaScriptCore

Remove JSCell::isPropertyNameIterator(), it is unused
https://bugs.webkit.org/show_bug.cgi?id=67911

Reviewed by Oliver Hunt.

runtime/JSCell.h:
runtime/JSPropertyNameIterator.h:

3:29 PM Changeset in webkit [94931] by weinig@apple.com

5 edits in trunk/Source/JavaScriptCore

De-virtualize JSCell::isAPIValueWrapper
https://bugs.webkit.org/show_bug.cgi?id=67909

Reviewed by Oliver Hunt.

runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::createStructure):
Set the correct type on structure creation.

runtime/JSCell.h:

Remove virtual keyword and default implementation.

runtime/JSType.h:

Add type for APIValueWrapper. It must come after CompoundType since
the APIValueWrapper has children in need of marking.

runtime/Structure.h:

(JSC::JSCell::isAPIValueWrapper):
Implement predicate using type info.

2:45 PM Changeset in webkit [94930] by weinig@apple.com

8 edits in trunk/Source/JavaScriptCore

De-virtualize JSCell::isGetterSetter, type information is available for it
https://bugs.webkit.org/show_bug.cgi?id=67902

Reviewed by Dan Bernstein.

runtime/GetterSetter.cpp:
runtime/GetterSetter.h:

Remove override of isGetterSetter.

runtime/JSCell.cpp:
runtime/JSCell.h:

De-virtualize and remove silly base implementation.

runtime/Structure.h:

(JSC::JSCell::isGetterSetter):
Use type info to determine getter-setter-hood.

2:11 PM Changeset in webkit [94929] by oliver@apple.com

110 edits in trunk/Source

Remove support for anonymous storage from jsobjects
https://bugs.webkit.org/show_bug.cgi?id=67881

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Remove all use of anonymous slots, essentially a mechanical change
in JavaScriptCore

API/JSCallbackConstructor.h:

(JSC::JSCallbackConstructor::createStructure):

API/JSCallbackFunction.h:

(JSC::JSCallbackFunction::createStructure):

API/JSCallbackObject.h:

(JSC::JSCallbackObject::createStructure):

JavaScriptCore.exp:
debugger/DebuggerActivation.h:

(JSC::DebuggerActivation::createStructure):

heap/MarkStack.cpp:

(JSC::MarkStack::validateValue):

heap/MarkStack.h:
runtime/Arguments.h:

(JSC::Arguments::createStructure):

runtime/ArrayConstructor.h:

(JSC::ArrayConstructor::createStructure):

runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::finishCreation):

runtime/ArrayPrototype.h:

(JSC::ArrayPrototype::createStructure):

runtime/BooleanObject.h:

(JSC::BooleanObject::createStructure):

runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::BooleanPrototype):

runtime/BooleanPrototype.h:

(JSC::BooleanPrototype::createStructure):

runtime/DateConstructor.h:

(JSC::DateConstructor::createStructure):

runtime/DateInstance.h:

(JSC::DateInstance::createStructure):

runtime/DatePrototype.cpp:

(JSC::DatePrototype::DatePrototype):

runtime/DatePrototype.h:

(JSC::DatePrototype::createStructure):

runtime/ErrorInstance.h:

(JSC::ErrorInstance::createStructure):

runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::finishCreation):

runtime/ErrorPrototype.h:

(JSC::ErrorPrototype::createStructure):

runtime/ExceptionHelpers.h:

(JSC::InterruptedExecutionError::createStructure):
(JSC::TerminatedExecutionError::createStructure):

runtime/Executable.h:

(JSC::ExecutableBase::createStructure):
(JSC::NativeExecutable::createStructure):
(JSC::EvalExecutable::createStructure):
(JSC::ProgramExecutable::createStructure):
(JSC::FunctionExecutable::createStructure):

runtime/FunctionPrototype.h:

(JSC::FunctionPrototype::createStructure):

runtime/GetterSetter.h:

(JSC::GetterSetter::createStructure):

runtime/InternalFunction.h:

(JSC::InternalFunction::createStructure):

runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::createStructure):

runtime/JSActivation.h:

(JSC::JSActivation::createStructure):

runtime/JSArray.h:

(JSC::JSArray::createStructure):

runtime/JSByteArray.cpp:

(JSC::JSByteArray::createStructure):

runtime/JSCell.h:
runtime/JSFunction.h:

(JSC::JSFunction::createStructure):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::finishCreation):
(JSC::JSGlobalObject::createStructure):

runtime/JSNotAnObject.h:

(JSC::JSNotAnObject::createStructure):

runtime/JSONObject.h:

(JSC::JSONObject::createStructure):

runtime/JSObject.h:

(JSC::JSObject::createStructure):
(JSC::JSNonFinalObject::createStructure):
(JSC::JSFinalObject::createStructure):

runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::create):

runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::createStructure):

runtime/JSStaticScopeObject.h:

(JSC::JSStaticScopeObject::createStructure):

runtime/JSString.h:

(JSC::RopeBuilder::createStructure):

runtime/JSVariableObject.h:

(JSC::JSVariableObject::createStructure):

runtime/JSWrapperObject.h:

(JSC::JSWrapperObject::createStructure):

runtime/MathObject.h:

(JSC::MathObject::createStructure):

runtime/NativeErrorConstructor.h:

(JSC::NativeErrorConstructor::createStructure):

runtime/NumberConstructor.h:

(JSC::NumberConstructor::createStructure):

runtime/NumberObject.h:

(JSC::NumberObject::createStructure):

runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::NumberPrototype):

runtime/NumberPrototype.h:

(JSC::NumberPrototype::createStructure):

runtime/ObjectConstructor.h:

(JSC::ObjectConstructor::createStructure):

runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::finishCreation):

runtime/ObjectPrototype.h:

(JSC::ObjectPrototype::createStructure):

runtime/RegExp.h:

(JSC::RegExp::createStructure):

runtime/RegExpConstructor.h:

(JSC::RegExpConstructor::createStructure):

runtime/RegExpObject.h:

(JSC::RegExpObject::createStructure):

runtime/RegExpPrototype.h:

(JSC::RegExpPrototype::createStructure):

runtime/ScopeChain.h:

(JSC::ScopeChainNode::createStructure):

runtime/StrictEvalActivation.h:

(JSC::StrictEvalActivation::createStructure):

runtime/StringConstructor.h:

(JSC::StringConstructor::createStructure):

runtime/StringObject.h:

(JSC::StringObject::createStructure):

runtime/StringObjectThatMasqueradesAsUndefined.h:

(JSC::StringObjectThatMasqueradesAsUndefined::createStructure):

runtime/StringPrototype.cpp:

(JSC::StringPrototype::StringPrototype):

runtime/StringPrototype.h:

(JSC::StringPrototype::createStructure):

runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::getterSetterTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::get):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):
(JSC::Structure::checkConsistency):

runtime/Structure.h:

(JSC::Structure::create):
(JSC::Structure::propertyStorageSize):
(JSC::Structure::get):

runtime/StructureChain.h:

(JSC::StructureChain::createStructure):

Source/JavaScriptGlue:

Don't need an anonymous slot count anymore

UserObjectImp.h:

(UserObjectImp::createStructure):

Source/WebCore:

Remove all use of anonymous slots, this required modifying
bindings generation to add member variables for cached attributes,
and override visitChildren with the necessary logic to mark those
new members.

I added bindings generation tests for these values.

bindings/js/JSAudioConstructor.h:

(WebCore::JSAudioConstructor::createStructure):

bindings/js/JSDOMBinding.h:

(WebCore::DOMConstructorObject::createStructure):

bindings/js/JSDOMGlobalObject.h:

(WebCore::JSDOMGlobalObject::createStructure):

bindings/js/JSDOMWindowBase.h:

(WebCore::JSDOMWindowBase::createStructure):

bindings/js/JSDOMWindowShell.h:

(WebCore::JSDOMWindowShell::createStructure):

bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::createStructure):

bindings/js/JSImageConstructor.h:

(WebCore::JSImageConstructor::createStructure):

bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data):
(WebCore::JSMessageEvent::initMessageEvent):

bindings/js/JSOptionConstructor.h:

(WebCore::JSOptionConstructor::createStructure):

bindings/js/JSWorkerContextBase.h:

(WebCore::JSWorkerContextBase::createStructure):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::createStructure):

bindings/scripts/test/JS/JSTestInterface.h:

(WebCore::JSTestInterface::createStructure):
(WebCore::JSTestInterfacePrototype::createStructure):

bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::createStructure):

bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::createStructure):
(WebCore::JSTestMediaQueryListListenerPrototype::createStructure):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::createStructure):
(WebCore::jsTestObjCachedAttribute1):
(WebCore::jsTestObjCachedAttribute2):
(WebCore::JSTestObj::visitChildren):

bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::createStructure):
(WebCore::JSTestObjPrototype::createStructure):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::createStructure):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::createStructure):

bindings/scripts/test/TestObj.idl:
bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::cachedAttribute1AttrGetter):
(WebCore::TestObjInternal::cachedAttribute2AttrGetter):

bridge/c/CRuntimeObject.h:

(JSC::Bindings::CRuntimeObject::createStructure):

bridge/c/c_instance.cpp:

(JSC::Bindings::CRuntimeMethod::createStructure):

bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaRuntimeMethod::createStructure):

bridge/jni/jsc/JavaRuntimeObject.h:

(JSC::Bindings::JavaRuntimeObject::createStructure):

bridge/objc/ObjCRuntimeObject.h:

(JSC::Bindings::ObjCRuntimeObject::createStructure):

bridge/objc/objc_instance.mm:

(ObjCRuntimeMethod::createStructure):

bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::createStructure):

bridge/runtime_array.h:

(JSC::RuntimeArray::createStructure):

bridge/runtime_method.h:

(JSC::RuntimeMethod::createStructure):

bridge/runtime_object.h:

(JSC::Bindings::RuntimeObject::createStructure):

Source/WebKit/mac:

Remove the use of AnonymousSlotCount

Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyRuntimeMethod::createStructure):

Plugins/Hosted/ProxyRuntimeObject.h:

(WebKit::ProxyRuntimeObject::createStructure):

Source/WebKit2:

Remove the use of AnonymousSlotCount.

WebProcess/Plugins/Netscape/JSNPMethod.h:

(WebKit::JSNPMethod::createStructure):

WebProcess/Plugins/Netscape/JSNPObject.h:

(WebKit::JSNPObject::createStructure):

1:49 PM Changeset in webkit [94928] by mitz@apple.com

4 edits in trunk/Source/WebCore/svg

Removed the svn:executable property from some source files

11:34 AM Changeset in webkit [94927] by Csaba Osztrogonác

2 edits in trunk/Source/JavaScriptCore

[Qt] Win32 build broken due to MachineStackMarker.cpp/.o failing to link against pthreads library
https://bugs.webkit.org/show_bug.cgi?id=67864

Qt Win32 is not pthread compatible and cannot participate in multithreaded JSC or it fails to build.

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-11
Reviewed by Csaba Osztrogonác.

wtf/Platform.h:

10:21 AM Changeset in webkit [94926] by Martin Robinson

3 edits
2 deletes in trunk/LayoutTests

Remove two platform-specific results for GTK+ that no longer apply and
rebaseline one more test.

platform/gtk/fast/multicol/inherit-column-values-expected.txt: Removed.
platform/gtk/fast/multicol/initial-column-values-expected.txt: Removed.
svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Rebaselined.
svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Ditto.

9:56 AM Changeset in webkit [94925] by Martin Robinson

2 edits in trunk/LayoutTests

Unskip two tests that should be passing now that 67383 is resolved.

platform/gtk/Skipped: Unskip passing tests.

12:27 AM Changeset in webkit [94924] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed gardening. Paint the Qt-Mac bot green.

platform/qt-mac/Skipped: Skip new failing tests.

12:13 AM Changeset in webkit [94923] by fpizlo@apple.com

2 edits in trunk/Tools

Added my IRC nick to the committers file.

Scripts/webkitpy/common/config/committers.py:

12:08 AM Changeset in webkit [94922] by Csaba Osztrogonác

5 edits in trunk/Source/JavaScriptCore

ARM and MIPS assemblers still refer to executable pools.
https://bugs.webkit.org/show_bug.cgi?id=67903

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-09-11
Reviewed by Csaba Osztrogonác.

assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::executableCopy):

assembler/ARMAssembler.h:
assembler/AssemblerBufferWithConstantPool.h:
assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::executableCopy):

12:06 AM Changeset in webkit [94921] by Csaba Osztrogonác

1 edit
16 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add Qt specific expected results for new passing tests.

platform/qt/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
platform/qt/fast/borders/block-mask-overlay-image-outset-expected.txt: Added.
platform/qt/fast/borders/border-image-outset-expected.png: Added.
platform/qt/fast/borders/border-image-outset-expected.txt: Added.
platform/qt/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
platform/qt/fast/borders/border-image-outset-in-shorthand-expected.txt: Added.
platform/qt/fast/borders/border-image-outset-split-inline-expected.png: Added.
platform/qt/fast/borders/border-image-outset-split-inline-expected.txt: Added.
platform/qt/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
platform/qt/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Added.
platform/qt/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
platform/qt/fast/borders/inline-mask-overlay-image-outset-expected.txt: Added.
platform/qt/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
platform/qt/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt: Added.
platform/qt/fast/reflections/reflection-masks-outset-expected.png: Added.
platform/qt/fast/reflections/reflection-masks-outset-expected.txt: Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed