Timeline
Sep 17, 2011:
- 8:47 PM Changeset in webkit [95389] by
-
- 8 edits1 delete in trunk/Source/JavaScriptCore
DFG JIT does not have full block-local CSE
https://bugs.webkit.org/show_bug.cgi?id=68316
Reviewed by Oliver Hunt.
This adds block-local CSE to the DFG. CSE runs in the propagator just after
type propagation. It is part of the propagator itself because it needs to
use the propagator's internal data structures to determine which operations
may have side effects. Because it changes the live-ranges of nodes, the
virtual register allocator had to be moved into the propagator so that it
runs after CSE. To ensure that the back-end knows to keep the inputs to
any eliminated node alive for OSR, a new node type, Phantom, was introduced.
It is a no-op but prolonges the live-range of its inputs.
This is an 80% speed-up on imaging-gaussian-blur, and a 10% speed-up on
Kraken.
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAliasTracker.h: Removed.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::MethodCheckData::operator==):
(JSC::DFG::MethodCheckData::operator!=):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasVirtualRegister):
(JSC::DFG::Node::setRefCount):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::canonicalize):
(JSC::DFG::Propagator::computeStartIndex):
(JSC::DFG::Propagator::startIndex):
(JSC::DFG::Propagator::pureCSE):
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::performSubstitution):
(JSC::DFG::Propagator::setReplacement):
(JSC::DFG::Propagator::performNodeCSE):
(JSC::DFG::Propagator::performBlockCSE):
(JSC::DFG::Propagator::localCSE):
(JSC::DFG::Propagator::allocateVirtualRegisters):
(JSC::DFG::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 4:33 PM Changeset in webkit [95388] by
-
- 5 edits in trunk/Source/JavaScriptCore
method_check should repatch itself if it finds that the new structure(s)
are the result of transitions from the old structure(s)
https://bugs.webkit.org/show_bug.cgi?id=68294
Reviewed by Gavin Barraclough.
Previously a patched method_check would slow-path to get_by_id. Now it
slow-paths to method_check_update, which attempts to correct the
method_check due to structure transitions before bailing to get_by_id.
This is a 1-2% speed-up on some benchmarks and is not a slow-down
anywhere, leading to a 0.6% speed-up on the Kraken geomean.
- jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
- runtime/Structure.h:
(JSC::Structure::transitivelyTransitionedFrom):
- 4:31 PM Changeset in webkit [95387] by
-
- 35 edits in trunk/Source
FrameLoaderClient BackForwardList-related methods are unsued
https://bugs.webkit.org/show_bug.cgi?id=68293
Reviewed by Darin Adler.
Source/WebCore:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- history/BackForwardListImpl.cpp:
(WebCore::BackForwardListImpl::addItem):
(WebCore::BackForwardListImpl::goBack):
(WebCore::BackForwardListImpl::goForward):
(WebCore::BackForwardListImpl::goToItem):
(WebCore::BackForwardListImpl::setCapacity):
- loader/EmptyClients.h:
- loader/FrameLoaderClient.h:
Source/WebKit/chromium:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- src/FrameLoaderClientImpl.cpp:
- src/FrameLoaderClientImpl.h:
Source/WebKit/efl:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
- WebCoreSupport/FrameLoaderClientEfl.h:
Source/WebKit/gtk:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
- WebCoreSupport/FrameLoaderClientGtk.h:
Source/WebKit/haiku:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- WebCoreSupport/FrameLoaderClientHaiku.cpp:
- WebCoreSupport/FrameLoaderClientHaiku.h:
Source/WebKit/mac:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebKit.order:
Source/WebKit/qt:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- WebCoreSupport/FrameLoaderClientQt.cpp:
- WebCoreSupport/FrameLoaderClientQt.h:
Source/WebKit/win:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- WebCoreSupport/WebFrameLoaderClient.cpp:
- WebCoreSupport/WebFrameLoaderClient.h:
Source/WebKit/wince:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- WebCoreSupport/FrameLoaderClientWinCE.cpp:
- WebCoreSupport/FrameLoaderClientWinCE.h:
Source/WebKit/wx:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- WebKitSupport/FrameLoaderClientWx.cpp:
- WebKitSupport/FrameLoaderClientWx.h:
Source/WebKit2:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- 4:12 PM Changeset in webkit [95386] by
-
- 3 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=68307
Crash in border image cssText. Make sure to null check all the components, since they're all
optional now.
Reviewed by Sam Weinig.
Source/WebCore:
Added fast/borders/border-image-slice-omission.html
- css/CSSBorderImageValue.cpp:
(WebCore::CSSBorderImageValue::cssText):
LayoutTests:
- fast/borders/border-image-slice-omission.html: Added.
- 3:47 PM Changeset in webkit [95385] by
-
- 11 edits2 adds in trunk/Source
Rework script context creation/release notifications
https://bugs.webkit.org/show_bug.cgi?id=67828
Reviewed by Adam Barth.
Source/WebCore:
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::disposeContextHandles):
(WebCore::V8DOMWindowShell::initContextIfNeeded):
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):
- bindings/v8/V8IsolatedContext.h:
- loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::didCreateScriptContext):
(WebCore::EmptyFrameLoaderClient::willReleaseScriptContext):
- loader/FrameLoaderClient.h:
Source/WebKit/chromium:
- public/WebFrameClient.h:
(WebKit::WebFrameClient::didCreateScriptContext):
(WebKit::WebFrameClient::didDestroyScriptContext):
(WebKit::WebFrameClient::willReleaseScriptContext):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
(WebKit::FrameLoaderClientImpl::willReleaseScriptContext):
- src/FrameLoaderClientImpl.h:
- 1:10 PM Changeset in webkit [95384] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] fast/events/media-element-focus-tab.html fails
https://bugs.webkit.org/show_bug.cgi?id=68315
- platform/qt-wk2/Skipped: Skip fast/events/media-element-focus-tab.html until fix.
- 10:43 AM Changeset in webkit [95383] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: file open dialog appears when user clicks on the timeline bar in timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=68312
Reviewed by Pavel Feldman.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._createFileSelector):
- 8:58 AM Changeset in webkit [95382] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r95372.
- dom/DOMAllInOne.cpp: #include "EventListenerMap.cpp"
- 3:57 AM Changeset in webkit [95381] by
-
- 6 edits4 adds in trunk
Override supportsFocus() for HTMLMediaElement.
https://bugs.webkit.org/show_bug.cgi?id=67190
Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-09-17
Reviewed by Antonio Gomes.
Source/WebCore:
Tests: fast/events/media-element-focus-tab.html
fast/spatial-navigation/snav-media-elements.html
Return true from supportsFocus() if control's attribute is present or a tabindex is specified.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::supportsFocus):
- html/HTMLMediaElement.h:
LayoutTests:
For media elements be able to receive focus without tabindex if
control attribute is present, hence changed
tabindex-focus-blur-all.js and tabindex-focus-blur-all-expected.txt.
- fast/events/media-element-focus-tab-expected.txt: Added.
- fast/events/media-element-focus-tab.html: Added.
- fast/events/resources/tabindex-focus-blur-all.js:
(test):
- fast/events/tabindex-focus-blur-all-expected.txt:
- fast/spatial-navigation/snav-media-elements-expected.txt: Added.
- fast/spatial-navigation/snav-media-elements.html: Added.
- 2:49 AM Changeset in webkit [95380] by
-
- 3 edits2 adds in trunk/Source/WebKit/chromium
[chromium]The focus of an input field inside an Iframe doesn't get cleared even though clearFocusedNode is called.
https://bugs.webkit.org/show_bug.cgi?id=68162
Add a unit-test to check whether the focus of node is get cleared when clearFocusNode called.
This test check for focus of input node inside a frame after clear focus get called.
Patch by chandra shekar vallala <chandra.vallala@motorola.com> on 2011-09-17
Reviewed by Adam Barth.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::clearFocusedNode):
- tests/WebFrameTest.cpp:
(WebKit::TEST_F): Added a unit test to make sure that focus of the node is get cleared.
- tests/data/autofocus_input_field_iframe.html: Added.
- tests/data/iframe_clear_focused_node_test.html: Added.
- 2:28 AM Changeset in webkit [95379] by
-
- 3 edits in trunk
[EFL] Bump minimum requirement for cairo to 1.10.
https://bugs.webkit.org/show_bug.cgi?id=68226
Reviewed by Adam Barth.
- Source/cmake/FindCairo.cmake: Check required version.
- Source/cmake/OptionsEfl.cmake:
- 2:08 AM Changeset in webkit [95378] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-4.8/editing/deleting/merge-whitespace-pre-expected.txt: Update after r95335.
- 1:59 AM Changeset in webkit [95377] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed gardening after r95337.
- platform/qt-wk2/Skipped: Skip one more test.
- 1:06 AM Changeset in webkit [95376] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] fast/forms/submit-to-blank-multiple-times.html fails
https://bugs.webkit.org/show_bug.cgi?id=68309
- platform/qt-wk2/Skipped: Skip fast/forms/submit-to-blank-multiple-times.html.
- 12:57 AM Changeset in webkit [95375] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed gardening after r95335.
- platform/qt-wk2/Skipped: Skip new failing tests.
- 12:49 AM Changeset in webkit [95374] by
-
- 6 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/Skipped: Skip plugins/fullscreen-plugins-dont-reload.html, because ENABLE(FULLSCREEN_API) is disabled on Qt.
- platform/qt/fast/dom/Window/window-properties-expected.png: Updated after r95362.
- platform/qt/fast/dom/Window/window-properties-expected.txt: Updated after r95362.
- platform/qt/fast/dom/Window/window-property-descriptors-expected.png: Updated after r95362.
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated after r95362.
Sep 16, 2011:
- 11:52 PM Changeset in webkit [95373] by
-
- 20 edits in trunk/Source
Rename ENABLE(LEVELDB) to USE(LEVELDB)
https://bugs.webkit.org/show_bug.cgi?id=68290
Reviewed by Darin Adler.
Source/WebCore:
LEVELDB is a library that can be used to implemented INDEXED_DATABASE,
which means it should be a USE not an ENABLE.
- CMakeLists.txt:
- WebCore.gyp/WebCore.gyp:
- platform/leveldb/LevelDBComparator.h:
- platform/leveldb/LevelDBDatabase.cpp:
- platform/leveldb/LevelDBDatabase.h:
- platform/leveldb/LevelDBIterator.h:
- platform/leveldb/LevelDBSlice.h:
- platform/leveldb/LevelDBTransaction.cpp:
- platform/leveldb/LevelDBTransaction.h:
- platform/leveldb/LevelDBWriteBatch.cpp:
- platform/leveldb/LevelDBWriteBatch.h:
- storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open):
(WebCore::IDBFactoryBackendImpl::migrateFromSQLiteToLevelDB):
- storage/IDBLevelDBBackingStore.cpp:
- storage/IDBLevelDBBackingStore.h:
- storage/IDBLevelDBCoding.cpp:
- storage/IDBLevelDBCoding.h:
Source/WebKit/chromium:
- features.gypi:
- tests/IDBLevelDBCodingTest.cpp:
- 11:34 PM Changeset in webkit [95372] by
-
- 13 edits2 adds in trunk/Source/WebCore
Reduce EventTarget memory usage by deferring hash map allocation
until there are listeners for more than 1 event type.
Patch by Andreas Kling <kling@webkit.org> on 2011-09-16
Reviewed by Darin Adler.
Introduce an EventListenerMap class which manages a map of event types that have
one or more listeners connected.
When there is only one event type, it's stored directly on the EventListenerMap
internally, and when more are added it moves to a hash map. It only goes back
from the hash map if all the listeners are removed at once (i.e clear() is called.)
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Adding files.
- WebCore.exp.in:
Export EventListenerMap::contains() for WebKit/mac.
- dom/EventListenerMap.cpp: Added.
(WebCore::EventListenerMap::EventListenerMap):
(WebCore::EventListenerMap::~EventListenerMap):
(WebCore::EventListenerMap::isEmpty):
(WebCore::EventListenerMap::contains):
(WebCore::EventListenerMap::clear):
(WebCore::EventListenerMap::eventTypes):
(WebCore::addListenerToVector):
(WebCore::EventListenerMap::add):
(WebCore::removeListenerFromVector):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::removeFirstListenerCreatedFromMarkup):
(WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup):
(WebCore::copyListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::EventListenerIterator):
(WebCore::EventListenerIterator::nextListener):
- dom/EventListenerMap.h: Added.
- dom/EventTarget.cpp:
(WebCore::EventTargetData::~EventTargetData):
(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::fireEventListeners):
(WebCore::EventTarget::getEventListeners):
(WebCore::EventTarget::removeAllEventListeners):
- dom/EventTarget.h:
(WebCore::EventTarget::visitJSEventListeners):
Use EventListenerIterator to visit listeners. (JSC specific.)
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getEventListenersForNode):
Call EventListenerMap::eventTypes() go get the list of event types
currently listened for.
- dom/Node.cpp:
(WebCore::Node::removeEventListener):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::transferEventListenersToShadowTree):
Move implementations of SVG-specific hacks into EventListenerMap and
call them from here.
- 11:07 PM Changeset in webkit [95371] by
-
- 6 edits2 adds in trunk
Don't detach elements from the render tree when entering fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=66531
Source/WebCore:
This prevents plugin instances from being destroyed and reinstantiated
when entering fullscreen mode.
Reviewed by James Robinson.
Test: plugins/fullscreen-plugins-dont-reload.html
- dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRendererFactory::createRendererIfNeeded):
- rendering/RenderFullScreen.cpp:
(createFullScreenStyle):
(RenderFullScreen::wrapRenderer):
(RenderFullScreen::unwrapRenderer):
- rendering/RenderFullScreen.h:
LayoutTests:
Test that the plugin is not reloaded when entering fullscreen.
Reviewed by James Robinson.
- plugins/fullscreen-plugins-dont-reload-expected.txt: Added.
- plugins/fullscreen-plugins-dont-reload.html: Added.
- 10:53 PM Changeset in webkit [95370] by
-
- 4 edits in trunk/Tools
add non-CG Webkit-Mac builds to flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=68265
Patch by Elliot Poger <epoger@google.com> on 2011-09-16
Reviewed by Adam Barth.
As Chromium-on-Mac approaches the switchover from Core Graphics to
Skia, we need to add the Skia version to the flakiness dashboard.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- TestResultServer/static-dashboards/builders.js:
- TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
- 10:52 PM Changeset in webkit [95369] by
-
- 17 edits7 adds in trunk
Source/WebCore: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
https://bugs.webkit.org/show_bug.cgi?id=68071
This will allow embedders to block images based on where the image is loaded from, instead of just blocking all images in a given frame.
Reviewed by Adam Barth.
- html/ImageDocument.cpp:
(WebCore::ImageDocumentParser::appendBytes):
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::allowImage):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestImage):
Source/WebKit/chromium: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
https://bugs.webkit.org/show_bug.cgi?id=68071
Reviewed by Adam Barth.
- public/WebPermissionClient.h:
(WebKit::WebPermissionClient::allowImage):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::allowImage):
- src/FrameLoaderClientImpl.h:
Tools: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
https://bugs.webkit.org/show_bug.cgi?id=68071
Reviewed by Adam Barth.
- DumpRenderTree/chromium/WebPermissions.cpp:
(WebPermissions::allowImage):
- DumpRenderTree/chromium/WebPermissions.h:
LayoutTests: Add tests for FrameLoaderClient::allowImage.
https://bugs.webkit.org/show_bug.cgi?id=68071
Reviewed by Adam Barth.
- http/tests/permissionclient/resources/bostin.gif:
- http/tests/permissionclient/resources/redir.php:
- platform/chromium/permissionclient/image-permissions-expected.txt:
- platform/chromium/permissionclient/image-permissions.html:
- platform/http/tests/permissionclient/image-permissions-expected.txt:
- platform/http/tests/permissionclient/image-permissions.html:
- 10:30 PM Changeset in webkit [95368] by
-
- 3 edits in trunk/Source/WebKit/chromium
https://bugs.webkit.org/show_bug.cgi?id=67733
[Chromium] Separate WebKit initialization and V8 initialization in chromium port.
Reviewed by Darin Fisher.
- public/WebKit.h:
- src/WebKit.cpp:
(WebKit::initialize):
(WebKit::initializeWithoutV8):
- 10:24 PM Changeset in webkit [95367] by
-
- 2 edits1 add in trunk/Source/WebKit2
[Qt] QTouchWebView missing loadProgress tests
https://bugs.webkit.org/show_bug.cgi?id=68183
Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-16
Reviewed by Chang Shu.
Added test case to check load progress for QTouchWebView
- UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml: Added.
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
- 10:16 PM Changeset in webkit [95366] by
-
- 4 edits2 adds in trunk
Make XSSAuditor truncate inline snippets at a reasonable length before comparison
respecting boundaries of multiply urlencoded sequences.
https://bugs.webkit.org/show_bug.cgi?id=68092
Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-16
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/security/xssAuditor/property-escape-long.html
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterTokenAfterScriptStartTag):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
(WebCore::XSSAuditor::eraseAttributeIfInjected):
(WebCore::XSSAuditor::decodedSnippetForAttribute):
(WebCore::XSSAuditor::isContainedInRequest):
- html/parser/XSSAuditor.h:
LayoutTests:
- http/tests/security/xssAuditor/property-escape-long-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape-long.html: Added.
- 9:39 PM Changeset in webkit [95365] by
-
- 8 edits in trunk/Source/WebCore
Remove m_contentsDirty from LayerChromium because it
is redundant with m_dirtyRect.
https://bugs.webkit.org/show_bug.cgi?id=68213
Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.
Code cleanup towards unit testing.
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setNeedsDisplay):
(WebCore::LayerChromium::resetNeedsDisplay):
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::updateCompositorResources):
- platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateCompositorResources):
- 9:28 PM Changeset in webkit [95364] by
-
- 2 edits in trunk/Source/JavaScriptCore
Touch Platform.h in the hope to fix SnowLeopard Intel Release (WebKit2 Tests).
- wtf/Platform.h:
- 9:15 PM Changeset in webkit [95363] by
-
- 2 edits in trunk/Tools
update-webkit-chromium should retry the gclient call if it fails once
https://bugs.webkit.org/show_bug.cgi?id=68252
Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-09-16
Reviewed by Adam Barth.
- Scripts/update-webkit-chromium:
- 9:01 PM Changeset in webkit [95362] by
-
- 26 edits in trunk
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=66714
Add webkitPostMessage to allow for adding transferable support.
This adds webkitPostMessage, currently identical to postMessage, which
would later be a vehicle for adding transferable support for messaging.
Based on patch by Luke Zarko.
Reviewed by David Levin.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::webkitPostMessage):
- bindings/js/JSDedicatedWorkerContextCustom.cpp:
(WebCore::JSDedicatedWorkerContext::webkitPostMessage):
- bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::webkitInitMessageEvent):
- bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::webkitPostMessage):
- bindings/js/JSWorkerCustom.cpp:
(WebCore::JSWorker::postMessage):
(WebCore::JSWorker::webkitPostMessage):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback):
(WebCore::V8DOMWindow::postMessageCallback):
(WebCore::V8DOMWindow::webkitPostMessageCallback):
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::handlePostMessageCallback):
(WebCore::V8DedicatedWorkerContext::postMessageCallback):
(WebCore::V8DedicatedWorkerContext::webkitPostMessageCallback):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::initMessageEventCallback):
(WebCore::V8MessageEvent::webkitInitMessageEventCallback):
- bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::handlePostMessageCallback):
(WebCore::V8MessagePort::postMessageCallback):
(WebCore::V8MessagePort::webkitPostMessageCallback):
- bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::handlePostMessageCallback):
(WebCore::V8Worker::postMessageCallback):
(WebCore::V8Worker::webkitPostMessageCallback):
- dom/MessageEvent.idl:
- dom/MessagePort.idl:
- page/DOMWindow.idl:
- workers/DedicatedWorkerContext.idl:
- workers/Worker.idl:
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=66714
Add webkitPostMessage to allow for adding transferable support.
This adds webkitPostMessage, currently identical to postMessage, which
would later be a vehicle for adding transferable support for messaging.
The tests ensure that webkitPostMessage and postMessage behave identically.
Based on patch by Luke Zarko.
Reviewed by David Levin.
- fast/dom/Window/window-postmessage-args-expected.txt:
- fast/dom/Window/window-postmessage-args.html:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/events/message-port-expected.txt:
- fast/events/message-port.html:
- fast/workers/resources/worker-call.js:
- fast/workers/worker-call-expected.txt:
- platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
- 8:47 PM Changeset in webkit [95361] by
-
- 3 edits3 adds in trunk
Chromium: Fix repaint of rubber-band overhang area under composited path
https://bugs.webkit.org/show_bug.cgi?id=68246
I accidently removed these two lines from the last patch on: https://bugs.webkit.org/show_bug.cgi?id=66969
Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-09-16
Reviewed by James Robinson.
Test: platform/chromium-gpu/compositing/rubberbanding/transform-overhang-size-change.html
Source/WebCore:
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
LayoutTests:
- platform/chromium-gpu/compositing/rubberbanding/transform-overhang-size-change-expected.png: Added.
- platform/chromium-gpu/compositing/rubberbanding/transform-overhang-size-change-expected.txt: Added.
- platform/chromium-gpu/compositing/rubberbanding/transform-overhang-size-change.html: Added.
- 8:36 PM Changeset in webkit [95360] by
-
- 11 edits in trunk/Source/WebKit2
Removed unwanted NotImplemented.h inclusion in WebKit2 GTK port & platform independent files
https://bugs.webkit.org/show_bug.cgi?id=68249
Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-09-16
Reviewed by Martin Robinson.
- Shared/Plugins/NPIdentifierData.cpp: Removed NotImplemented.h inclusion.
- Shared/Plugins/NPRemoteObjectMap.cpp: Removed NotImplemented.h inclusion.
- Shared/Plugins/NPVariantData.cpp: Removed NotImplemented.h inclusion.
- UIProcess/gtk/WebContextGtk.cpp: Removed NotImplemented.h inclusion.
- WebProcess/Cookies/WebCookieManager.cpp: Removed NotImplemented.h inclusion.
- WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp: Removed NotImplemented.h inclusion.
- WebProcess/Plugins/Netscape/JSNPMethod.cpp: Removed NotImplemented.h inclusion.
- WebProcess/Plugins/Netscape/NPJSObject.cpp: Removed NotImplemented.h inclusion.
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp: Removed NotImplemented.h inclusion.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp: Removed NotImplemented.h inclusion.
- 8:23 PM Changeset in webkit [95359] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Add movementX/Y members to WebMouseEvent
https://bugs.webkit.org/show_bug.cgi?id=68174
Reviewed by Dimitri Glazkov.
- public/WebInputEvent.h:
(WebKit::WebMouseEvent::WebMouseEvent):
- 7:57 PM Changeset in webkit [95358] by
-
- 4 edits in trunk/Source/JavaScriptCore
Rename APIValueWrapper type to APIValueWrapperType for consistency
https://bugs.webkit.org/show_bug.cgi?id=68306
Reviewed by Anders Carlsson.
- runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
Update name.
- runtime/JSType.h:
Update name and un-indent.
- runtime/Structure.h:
(JSC::JSCell::isAPIValueWrapper):
Update name.
- 7:47 PM Changeset in webkit [95357] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove unused isStrictModeFunction function
https://bugs.webkit.org/show_bug.cgi?id=68305
Reviewed by Anders Carlsson.
- runtime/JSObject.h:
(JSC::JSObject::isStrictModeFunction):
- 7:42 PM Changeset in webkit [95356] by
-
- 3 edits in trunk/Source/WebCore
Depend on harfbuzz for OS=Android as well
https://bugs.webkit.org/show_bug.cgi?id=68239
Like GTK, Android depends on harfbuzz as well, so reflect that in
the project file. Furthermore, fix a compile error in PopupListBox.cpp
by explicitly including ctype.h, as isspace otherwise won't be declared.
Patch by Peter Beverloo <peter@chromium.org> on 2011-09-16
Reviewed by Steve Block.
- WebCore.gyp/WebCore.gyp:
- platform/chromium/PopupListBox.cpp:
- 7:40 PM Changeset in webkit [95355] by
-
- 8 edits in trunk
Rename flex-align values to match the spec
https://bugs.webkit.org/show_bug.cgi?id=67741
Reviewed by Ojan Vafai.
Source/WebCore:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexAlign):
- css/CSSValueKeywords.in:
- rendering/style/RenderStyleConstants.h:
LayoutTests:
- css3/flexbox/css-properties-expected.txt:
- css3/flexbox/script-tests/css-properties.js:
- 7:31 PM Changeset in webkit [95354] by
-
- 7 edits2 deletes in trunk
[V8] REGRESSION(94783): calling the binding script during V8 context creation slows down page loads
https://bugs.webkit.org/show_bug.cgi?id=68237
Patch by Ulan Degenbaev <ulan@chromium.org> on 2011-09-16
Reviewed by Kenneth Russell.
Call the binding script lazily on the first run of the set() method of
a typed array.
- ../../Source/WebCore/WebCore.gypi:
- ../../Source/WebCore/bindings/v8/V8BindingScripts.cpp: Removed.
- ../../Source/WebCore/bindings/v8/V8BindingScripts.h: Removed.
- ../../Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:
- ../../Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp:
- ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
- ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:
- ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustomScript.js:
- 7:24 PM Changeset in webkit [95353] by
-
- 5 edits1 add1 delete in trunk/LayoutTests
Chromium pixel test rebaseline for r95335.
- platform/chromium-cg-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png: Added.
- platform/chromium-linux/editing/deleting/merge-whitespace-pre-expected.png:
- platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
- platform/chromium-win-vista/editing: Removed.
- platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.png:
- platform/chromium/test_expectations.txt:
- 7:01 PM Changeset in webkit [95352] by
-
- 9 edits2 adds in trunk
Implement an ErrorEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=68148
Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-16
Reviewed by Sam Weinig.
Source/WebCore:
The spec for the ErrorEvent constructor is here:
http://dev.w3.org/html5/workers/#errorevent
Test: fast/events/constructors/error-event-constructor.html
- bindings/generic/EventConstructors.h: Added a definition for the ErrorEvent constructor.
- bindings/js/JSEventConstructors.cpp: Added #includes for ErrorEvent.
- dom/ErrorEvent.cpp:
(WebCore::ErrorEventInit::ErrorEventInit):
(WebCore::ErrorEvent::ErrorEvent):
(WebCore::ErrorEvent::initErrorEvent):
(WebCore::ErrorEvent::isErrorEvent):
- dom/ErrorEvent.h: Added a definition for ErrorEventInit.
(WebCore::ErrorEvent::create):
(WebCore::ErrorEvent::message):
(WebCore::ErrorEvent::filename):
(WebCore::ErrorEvent::lineno):
- dom/ErrorEvent.idl: Makes ErrorEvent constructible.
LayoutTests:
error-event-constructor.html checks the behavior of the ErrorEvent constructor.
- fast/dom/constructed-objects-prototypes-expected.txt: Now window has ErrorEvent.
- fast/events/constructors/error-event-constructor-expected.txt: Added.
- fast/events/constructors/error-event-constructor.html: Added.
- platform/chromium/test_expectations.txt: Skipped error-event-constructor.html, since V8 does not yet have the ErrorEvent constructor.
- 6:47 PM Changeset in webkit [95351] by
-
- 1 edit3 adds in trunk/LayoutTests
CORS images viewed from different domains fail security checks
https://bugs.webkit.org/show_bug.cgi?id=68011
Reviewed by Darin Adler.
I am unable to reproduce the bug, but the test I wrote in the process
might be worth having anyway.
- http/tests/security/canvas-cors-with-two-hosts-expected.txt: Added.
- http/tests/security/canvas-cors-with-two-hosts.html: Added.
- http/tests/security/resources/canvas-cors-subtest.html: Added.
- 6:36 PM Changeset in webkit [95350] by
-
- 4 edits12 adds2 deletes in trunk
Overhangs a ruby by no more than half the width of the neighboring text.
https://bugs.webkit.org/show_bug.cgi?id=62684
Reviewed by Dan Bernstein.
Assume two rubies between which a narrow text exists, like
"<ruby>x<rt>xxxxxx</rt></ruby>l<ruby>y<rt>yyyyyy</rt></ruby>".
In order to avoid the two rubies overlapping with each other,
this patch overhangs the ruby by no more than half the ruby font
size and no more than half the width of the neighboring text.
Source/WebCore:
Tests: fast/ruby/overhang-horizontal-no-overlap1.html
fast/ruby/overhang-horizontal-no-overlap2.html
fast/ruby/overhang-vertical-no-overlap1.html
fast/ruby/overhang-vertical-no-overlap2.html
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::getOverhang): Calculates the width of ruby overhanging.
LayoutTests:
- fast/ruby/overhang-horizontal-no-overlap1-expected.png: Added.
- fast/ruby/overhang-horizontal-no-overlap1-expected.txt: Added.
- fast/ruby/overhang-horizontal-no-overlap1.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
- fast/ruby/overhang-horizontal-no-overlap2-expected.png: Added.
- fast/ruby/overhang-horizontal-no-overlap2-expected.txt: Added.
- fast/ruby/overhang-horizontal-no-overlap2.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
- fast/ruby/overhang-vertical-no-overlap1-expected.png: Added.
- fast/ruby/overhang-vertical-no-overlap1-expected.txt: Added.
- fast/ruby/overhang-vertical-no-overlap1.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
- fast/ruby/overhang-vertical-no-overlap2-expected.png: Added.
- fast/ruby/overhang-vertical-no-overlap2-expected.txt: Added.
- fast/ruby/overhang-vertical-no-overlap2.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
- platform/chromium-linux/fast/ruby/overhang-vertical-expected.png: Removed.
- platform/chromium-win/fast/ruby/overhang-horizontal-expected.png: Removed.
- platform/chromium/test_expectations.txt: Skips overhang-horizontal.html. We will update the result image as a rebase line.
- 6:32 PM Changeset in webkit [95349] by
-
- 17 edits in trunk/Source/WebCore
Unreviewed, rolling out r95304.
http://trac.webkit.org/changeset/95304
https://bugs.webkit.org/show_bug.cgi?id=68299
Broke GTK+ builds. It pulls derived headers into main.c
(Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16
- bindings/scripts/CodeGeneratorGObject.pm:
():
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
- bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_conditional_method1):
(webkit_dom_test_obj_conditional_method2):
(webkit_dom_test_obj_conditional_method3):
(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:
- 6:14 PM Changeset in webkit [95348] by
-
- 8 edits in trunk/Source/WebCore
Re-named isRootLayer to isNonCompositedContent because
that is what the flag actually means.
https://bugs.webkit.org/show_bug.cgi?id=68214
Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.
Code cleanup towards unit testing.
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setIsNonCompositedContent):
(WebCore::LayerChromium::isNonCompositedContent):
- platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::NonCompositedContentHost):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setLayerTreeHost):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::setIsNonCompositedContent):
(WebCore::CCLayerImpl::isNonCompositedContent):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::draw):
- 6:12 PM Changeset in webkit [95347] by
-
- 13 edits in trunk/Source
Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
https://bugs.webkit.org/show_bug.cgi?id=68134
Source/WebCore:
Reviewed by Sam Weinig.
Add a new setting to control whether the mock scrollbar theme is used.
This is a global setting, so that it can be set without having to
access a specific Settings object.
- page/Settings.h:
(WebCore::Settings::setMockScrollbarsEnabled):
(WebCore::Settings::mockScrollbarsEnabled):
Source/WebKit/mac:
Reviewed by Sam Weinig.
Hook up a private preference that enables the mock scrollbar theme.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(-[WebPreferences mockScrollbarsEnabled]):
(-[WebPreferences setMockScrollbarsEnabled:]):
- WebView/WebPreferencesPrivate.h:
Source/WebKit2:
Reviewed by Sam Weinig.
Hook up a private preference that enables the mock scrollbar theme.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetMockScrollbarsEnabled):
(WKPreferencesGetMockScrollbarsEnabled):
- UIProcess/API/C/WKPreferencesPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 6:02 PM Changeset in webkit [95346] by
-
- 3 edits2 adds in trunk
Large canvas fills should not crash or create unnecessarily large image buffers
https://bugs.webkit.org/show_bug.cgi?id=67988
Source/WebCore:
When using source-in, destination-in, source-out, or destination-atop a temporary
buffer is created. This buffer only needs to be big enough to cover the intersection
of the path and the canvas. If the area of intersection between the fill and the
canvas is empty the canvas is completely cleared and a temporary buffer is not used.
This change also adds some null checks for failures to create contexts or buffers.
Patch by Ben Wells <benwells@chromium.org> on 2011-09-16
Reviewed by Darin Adler.
Test: fast/canvas/canvas-large-fills.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::clearCanvas):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):
LayoutTests:
Patch by Ben Wells <benwells@chromium.org> on 2011-09-16
Reviewed by Darin Adler.
- fast/canvas/canvas-large-fills-expected.txt: Added.
- fast/canvas/canvas-large-fills.html: Added.
- 5:55 PM Changeset in webkit [95345] by
-
- 8 edits2 copies in branches/chromium/835
Merge 94508 - <rdar://problem/10071256> Retain retired custom fonts until the next style recalc
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/css/font-face-used-after-retired.html
During style recalc, existing renderers may reference their old style, including font data.
Allow them to do so safely by keeping retired custom font data around until after style recalc.
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::retireCustomFont): Added. Calls through to CSSFontSelector, if the font
face is still part of any segmented font face. Otherwise, deletes the custom font data.
- css/CSSFontFace.h:
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::pruneTable): Changed to call retireCustomFont() instead of deleting
retired font data.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::retireCustomFont): Added. Calls through to the Document, if this is
still the active font selector for a document. Otherwise, deletes the custom font data.
- css/CSSFontSelector.h:
- css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::pruneTable): Changed to call retireCustomFont() instead of
deleting retired font data.
- dom/Document.cpp:
(WebCore::Document::~Document): Added a call to deleteRetiredCustomFonts(), in case the Document
is destroyed before getting a chance to recalc style after custom fonts have been retired.
(WebCore::Document::recalcStyle): Added a call to deleteRetiredCustomFonts() after style recalc.
(WebCore::Document::deleteRetiredCustomFonts): Added. Deletes all previously-retired custom font
data.
- dom/Document.h:
(WebCore::Document::retireCustomFont): Added.
LayoutTests:
- fast/css/font-face-used-after-retired-expected.txt: Added.
- fast/css/font-face-used-after-retired.html: Added.
TBR=mitz@apple.com
Review URL: http://codereview.chromium.org/7932007
- 5:50 PM Changeset in webkit [95344] by
-
- 2 edits in trunk/Source/WebCore
Remove default NULL argument in LayerChromium::create().
https://bugs.webkit.org/show_bug.cgi?id=68211
Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.
Code cleanup related to creating unit testing.
- platform/graphics/chromium/LayerChromium.h:
- 5:45 PM Changeset in webkit [95343] by
-
- 2 edits2 adds in trunk/LayoutTests
[chromium] Rebaseline fix up due to r95239.
Add back in a baseline that was removed in my last change.
- platform/chromium-cg-mac-leopard/fast/clip/overflow-border-radius-combinations-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/clip/overflow-border-radius-transformed-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 5:44 PM Changeset in webkit [95342] by
-
- 5 edits in trunk/LayoutTests
Fix the rebaseline in r95325 and also rebaseline for r95335.
- inspector/styles/styles-update-from-js-expected.txt:
- platform/chromium/test_expectations.txt
- platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.txt:
- platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
- 5:33 PM Changeset in webkit [95341] by
-
- 12 edits in trunk/Source/WebCore
[chromium] Move quad drawing code from LayerChromium to LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=68272
Reviewed by James Robinson.
All the OpenGL code is in LayerRendererChromium and the CCLayerImpl
tree, so move the static drawTexturedQuad/toGLMatrix functions to
LayerRendererChromium, where they really belong.
Just moving code around. Tested by existing compositor tests.
- platform/graphics/chromium/LayerChromium.cpp:
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::toGLMatrix):
(WebCore::LayerRendererChromium::drawTexturedQuad):
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::draw):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::drawDebugBorder):
- platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::draw):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::drawSurface):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::drawTiles):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::drawYUV):
(WebCore::CCVideoLayerImpl::drawRGBA):
- 5:22 PM Changeset in webkit [95340] by
-
- 6 edits in trunk/Source/JavaScriptCore
Cleanup JSTypeInfo a bit
https://bugs.webkit.org/show_bug.cgi?id=68289
Reviewed by Anders Carlsson.
- dfg/DFGOperations.cpp:
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
Replace direct access to flags() with predicate.
- runtime/JSObject.h:
(JSC::JSFinalObject::createStructure):
Pass FinalObjectType instead of using special IsJSFinalObject.
- runtime/JSTypeInfo.h:
(JSC::TypeInfo::TypeInfo):
Add additional assert that you should no object should OverridesHasInstance but not have ImplementsHasInstance set.
(JSC::TypeInfo::isFinalObject):
Added.
(JSC::TypeInfo::masqueradesAsUndefined):
(JSC::TypeInfo::implementsHasInstance):
(JSC::TypeInfo::isEnvironmentRecord):
(JSC::TypeInfo::overridesHasInstance):
(JSC::TypeInfo::implementsDefaultHasInstance):
(JSC::TypeInfo::overridesGetOwnPropertySlot):
(JSC::TypeInfo::overridesVisitChildren):
(JSC::TypeInfo::overridesGetPropertyNames):
(JSC::TypeInfo::prohibitsPropertyCaching):
(JSC::TypeInfo::isSetOnFlags1):
(JSC::TypeInfo::isSetOnFlags2):
Replace direct bit twiddling with helper functions.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
Use new isFinalObject() predicate.
- 5:22 PM Changeset in webkit [95339] by
-
- 2 edits in trunk/Source/WebKit2
Stop installing source and header files in to WebKit2.framework after r95303.
- WebKit2.xcodeproj/project.pbxproj:
- 5:20 PM Changeset in webkit [95338] by
-
- 5 edits in trunk
Unsigned bit shift fails under certain conditions in 32 bit builds
https://bugs.webkit.org/show_bug.cgi?id=68166
Reviewed by Geoff Garen.
Source/JavaScriptCore:
The major bug here is that the slow case (which handles shifts of
doubles) doesn't check for negative results from an unsigned shift
(which should be unsigned, and as such can't be represented by a
signed integer immediate). The implementation is also flawed for
shifts by negative shift amounts (treats as shift by zero).
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitRightShift):
(JSC::JIT::emitRightShiftSlowCase):
LayoutTests:
Added layout test.
- fast/js/floating-point-truncate-rshift-expected.txt:
- fast/js/floating-point-truncate-rshift.html:
- 5:08 PM Changeset in webkit [95337] by
-
- 2 edits2 adds in trunk/LayoutTests
Add the forgotten test, also suppress a test in Chromium as it needs a rebaseline.
- platform/chromium/test_expectations.txt:
- editing/deleting/merge-paragraph-into-blockquote-expected.txt: Added.
- editing/deleting/merge-paragraph-into-blockquote.html: Added.
- 5:07 PM Changeset in webkit [95336] by
-
- 2 edits in trunk/Source/WebCore
Fixed const correctness on accessors in LayerChromium
https://bugs.webkit.org/show_bug.cgi?id=68210
Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.
Code cleanup related to creating unit testing.
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::preserves3D):
(WebCore::LayerChromium::replicaLayer):
- 5:00 PM Changeset in webkit [95335] by
-
- 7 edits15 adds in trunk
Deleting line break before h1 converts h1 to span
https://bugs.webkit.org/show_bug.cgi?id=45784
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Fixed the bug by treating h1 and other elements that retain structure like Mail blockquote.
We already had a logic to overriding styles of merged paragraphs by Mail blockquote so
just extend this logic for h1-h6, pre, etc...
Tests: editing/deleting/merge-paragraph-from-address.html
editing/deleting/merge-paragraph-from-h6-with-style.html
editing/deleting/merge-paragraph-from-h6.html
editing/deleting/merge-paragraph-from-listing.html
editing/deleting/merge-paragraph-into-h1-with-style.html
editing/deleting/merge-paragraph-into-h1.html
editing/deleting/merge-paragraph-into-pre.html
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
- editing/markup.cpp:
(WebCore::isBlockNodeToRetainAppearance): Extracted from ancestorToRetainStructureAndAppearance.
(WebCore::StyledMarkupAccumulator::serializeNodes):
(WebCore::ancestorToRetainStructureAndAppearance):
- editing/markup.h:
LayoutTests:
Added a bunch of tests to ensure WebKit does not keep block elements' style when merging paragraphs.
When removing line breaks between <h1>hello</h1>world and hello<pre>world</pre> for example,
we should not be overriding and preserving styles from h1 in the merge paragraph respectively.
- editing/deleting/merge-paragraph-from-address-expected.txt: Added.
- editing/deleting/merge-paragraph-from-address.html: Added.
- editing/deleting/merge-paragraph-from-h6-expected.txt: Added.
- editing/deleting/merge-paragraph-from-h6-with-style-expected.txt: Added.
- editing/deleting/merge-paragraph-from-h6-with-style.html: Added.
- editing/deleting/merge-paragraph-from-h6.html: Added.
- editing/deleting/merge-paragraph-from-listing-expected.txt: Added.
- editing/deleting/merge-paragraph-from-listing.html: Added.
- editing/deleting/merge-paragraph-into-h1-expected.txt: Added.
- editing/deleting/merge-paragraph-into-h1-style-expected.txt: Added.
- editing/deleting/merge-paragraph-into-h1-with-style-expected.txt: Added.
- editing/deleting/merge-paragraph-into-h1-with-style.html: Added.
- editing/deleting/merge-paragraph-into-h1.html: Added.
- editing/deleting/merge-paragraph-into-pre-expected.txt: Added.
- editing/deleting/merge-paragraph-into-pre.html: Added.
- platform/mac/editing/deleting/merge-whitespace-pre-expected.png:
- platform/mac/editing/deleting/merge-whitespace-pre-expected.txt:
- 4:33 PM Changeset in webkit [95334] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Create WebGL layer for graphics contexts on demand
https://bugs.webkit.org/show_bug.cgi?id=68288
Reviewed by James Robinson.
- src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::platformLayer):
- src/GraphicsContext3DPrivate.h:
- 4:24 PM Changeset in webkit [95333] by
-
- 3 edits in trunk/Source/WebCore
Set but not used variables cleanup (gcc 4.6)
https://bugs.webkit.org/show_bug.cgi?id=68157
Patch by Max Perepelitsyn <pph34r@gmail.com> on 2011-09-16
Reviewed by Darin Adler.
- platform/audio/ReverbConvolverStage.cpp:
(WebCore::ReverbConvolverStage::process):
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaButton):
- 4:07 PM Changeset in webkit [95332] by
-
- 6 edits16 adds in trunk/LayoutTests
[chromium] Rebaseline fix up due to r95239.
Expectation removal due to r95322 and r95325.
- platform/chromium-cg-mac-leopard/fast/clip/overflow-border-radius-composited-expected.png: Added.
- platform/chromium-cg-mac/fast/clip/overflow-border-radius-combinations-expected.png: Added.
- platform/chromium-cg-mac/fast/clip/overflow-border-radius-composited-expected.png: Added.
- platform/chromium-cg-mac/fast/clip/overflow-border-radius-transformed-expected.png: Added.
- platform/chromium-cg-mac/fast/css/nested-rounded-corners-expected.png:
- platform/chromium-linux/fast/clip/overflow-border-radius-combinations-expected.png: Added.
- platform/chromium-linux/fast/clip/overflow-border-radius-composited-expected.png: Added.
- platform/chromium-linux/fast/clip/overflow-border-radius-transformed-expected.png: Added.
- platform/chromium-linux/fast/css/nested-rounded-corners-expected.png:
- platform/chromium-mac/fast/clip/overflow-border-radius-combinations-expected.png: Added.
- platform/chromium-mac/fast/clip/overflow-border-radius-composited-expected.png: Added.
- platform/chromium-mac/fast/clip/overflow-border-radius-transformed-expected.png: Added.
- platform/chromium-mac/fast/css/nested-rounded-corners-expected.png:
- platform/chromium-win/fast/clip/overflow-border-radius-combinations-expected.png: Added.
- platform/chromium-win/fast/clip/overflow-border-radius-combinations-expected.txt: Added.
- platform/chromium-win/fast/clip/overflow-border-radius-composited-expected.png: Added.
- platform/chromium-win/fast/clip/overflow-border-radius-composited-expected.txt: Added.
- platform/chromium-win/fast/clip/overflow-border-radius-transformed-expected.png: Added.
- platform/chromium-win/fast/clip/overflow-border-radius-transformed-expected.txt: Added.
- platform/chromium-win/fast/css/nested-rounded-corners-expected.png:
- platform/chromium/test_expectations.txt:
- 4:02 PM Changeset in webkit [95331] by
-
- 10 edits4 deletes in trunk
Removed undetectable style.filter.
Reviewed by Sam Weinig.
This feature was added in http://trac.webkit.org/changeset/15557 to
support housingmaps.com. But housingmaps.com no longer needs this hack,
we don't know of other websites that need it, and we don't know of
any other browsers that have implemented this feature.
Source/JavaScriptCore:
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/JSTypeInfo.h:
- runtime/StringObjectThatMasqueradesAsUndefined.h: Removed.
Source/WebCore:
- ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h: Removed.
- WebCore.order:
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::nameGetter):
LayoutTests:
- fast/dom/undetectable-style-filter-expected.txt: Removed.
- fast/dom/undetectable-style-filter.html: Removed.
- 3:50 PM Changeset in webkit [95330] by
-
- 2 edits in trunk/Tools
2011-09-16 Rob Buis <rbuis@rim.com>
Add Eli's rim address and change the nick.
- Scripts/webkitpy/common/config/committers.py:
- 3:29 PM Changeset in webkit [95329] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r95317.
http://trac.webkit.org/changeset/95317
https://bugs.webkit.org/show_bug.cgi?id=68282
Remove newly added overlapping test expectations. (Requested
by dave_levin on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16
- platform/chromium/test_expectations.txt:
- 3:27 PM Changeset in webkit [95328] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] compilation failed in target 'webkit_unit_tests'.
https://bugs.webkit.org/show_bug.cgi?id=68078
Patch by chandra shekar v <chandra.vallala@motorola.com> on 2011-09-16
Reviewed by Adam Barth.
- tests/WebFrameTest.cpp:
(WebKit::TestReloadDoesntRedirectWebFrameClient::decidePolicyForNavigation):
- 3:02 PM Changeset in webkit [95327] by
-
- 5 edits in trunk/Source/WebCore
Update JSC results to account for intrinsics change.
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- 2:34 PM Changeset in webkit [95326] by
-
- 11 edits in trunk/Source/JavaScriptCore
Prepare JSTypes for more Object subtypes
https://bugs.webkit.org/show_bug.cgi?id=68200
Reviewed by Gavin Barraclough.
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::branchIfNotObject):
- jit/JITInlineMethods.h:
(JSC::JIT::emitJumpIfNotObject):
- runtime/JSGlobalObject.h:
(JSC::Structure::prototypeForLookup):
- runtime/JSObject.h:
(JSC::JSObject::finishCreation):
- runtime/JSType.h:
- runtime/JSTypeInfo.h:
(JSC::TypeInfo::type):
(JSC::TypeInfo::isObject):
(JSC::TypeInfo::isFinal):
(JSC::TypeInfo::prohibitsPropertyCaching):
- runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::finishCreation):
- runtime/Operations.cpp:
(JSC::jsIsObjectType):
- runtime/Structure.cpp:
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
- runtime/Structure.h:
(JSC::Structure::isObject):
(JSC::JSCell::isObject):
- 2:12 PM Changeset in webkit [95325] by
-
- 2 edits in trunk/LayoutTests
Rebaseline from r95242.
- 2:05 PM Changeset in webkit [95324] by
-
- 4 edits in trunk/Source/JavaScriptCore
Rolled back in r95201 with test failure fixed.
I missed two cases of jumpSlowToHot in rshift -- these cases need to be
sure to initialize regT1 to the int tag, since it will otherwise hold
the top 32 bits of a double.
- jit/JIT.h:
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emitRightShiftSlowCase):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):
- jit/JITInlineMethods.h:
(JSC::JIT::emitStoreAndMapInt32):
- 1:59 PM Changeset in webkit [95323] by
-
- 2 edits in trunk/LayoutTests
Replace use of access to nodeList using call, with array style notation.
- editing/pasteboard/paste-noscript.html:
- 1:43 PM Changeset in webkit [95322] by
-
- 5 edits in trunk/LayoutTests
http/tests/history/back-with-fragment-change.php fails on non-Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=68242
Skip test on ports on which it fails. Move comment to be inside
<?php> block so that HTTP headers can be set on all platforms (there
must not be any whitespace before the <?php> block).
- http/tests/history/back-with-fragment-change.php:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- 1:42 PM Changeset in webkit [95321] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed Windows build fix after 95318.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 1:33 PM Changeset in webkit [95320] by
-
- 8 edits in trunk/Source
Unreviewed, rolling out r95312.
http://trac.webkit.org/changeset/95312
https://bugs.webkit.org/show_bug.cgi?id=68277
It's innocent, innocent I tell you! (Requested by jamesr_ on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16
Source/WebCore:
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(WTF::TestHooks::beginCommitOnCCThread):
(WTF::TestHooks::commitCompleteOnCCThread):
(WTF::TestHooks::drawLayersOnCCThread):
(WTF::MockLayerTreeHostImpl::create):
(WTF::MockLayerTreeHostImpl::beginCommit):
(WTF::MockLayerTreeHostImpl::commitComplete):
(WTF::MockLayerTreeHostImpl::drawLayers):
(WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(WTF::MockLayerTreeHost::create):
(WTF::MockLayerTreeHost::createLayerTreeHostImpl):
(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF::CompositorMockWebGraphicsContext3D::create):
(WTF::CompositorMockWebGraphicsContext3D::makeContextCurrent):
(WTF::CompositorMockWebGraphicsContext3D::createProgram):
(WTF::CompositorMockWebGraphicsContext3D::createShader):
(WTF::CompositorMockWebGraphicsContext3D::getShaderiv):
(WTF::CompositorMockWebGraphicsContext3D::getProgramiv):
(WTF::CompositorMockWebGraphicsContext3D::CompositorMockWebGraphicsContext3D):
(WTF::MockLayerTreeHostClient::create):
(WTF::MockLayerTreeHostClient::animateAndLayout):
(WTF::MockLayerTreeHostClient::createCompositorThread):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::MockLayerTreeHostClient::createRootLayerPainter):
(WTF::MockLayerTreeHostClient::didRecreateGraphicsContext):
(WTF::MockLayerTreeHostClient::MockLayerTreeHostClient):
(WTF::CCLayerTreeHostTest::postSetNeedsCommitToMainThread):
(WTF::CCLayerTreeHostTest::postSetNeedsRedrawToMainThread):
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::onBeginTest):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsCommit):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::testTimeout):
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::CCLayerTreeHostTestShortlived2::beginTest):
(WTF::CCLayerTreeHostTestShortlived3::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):
- 1:33 PM Changeset in webkit [95319] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix after r95310
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Added include\private\JavaScriptCore to the
include path so DFGIntrinsic.h can be found.
- 1:32 PM Changeset in webkit [95318] by
-
- 9 edits in trunk/Source/JavaScriptCore
Rationalize JSObject::putDirect* methods
https://bugs.webkit.org/show_bug.cgi?id=68274
Reviewed by Sam Weinig.
Delete the *Function variants. These are overall inefficient,
in the way they get the name back from the function rather
than just passing it in.
- JavaScriptCore.exp:
- jsc.cpp:
(GlobalObject::finishCreation):
(GlobalObject::addFunction):
- runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::addFunctionProperties):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
- runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::putWithAttributes):
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):
- runtime/JSObject.h:
(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectWithoutTransition):
- runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
- runtime/Lookup.h:
(JSC::lookupPut):
- 1:22 PM Changeset in webkit [95317] by
-
- 2 edits in trunk/LayoutTests
Unreviewed; new expectations (Skia on Mac)
This separates test failures that are specific to CG Mac from failures
for Skia on Mac (Leopard only).
- LayoutTests/platform/chromium/test_expectations.txt:
- 1:18 PM Changeset in webkit [95316] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix for Windows.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 1:12 PM Changeset in webkit [95315] by
-
- 8 edits in trunk
Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
https://bugs.webkit.org/show_bug.cgi?id=68269
Reviewed by Geoffrey Garen.
Source/WebKit2:
Add back WKPageMouseDidMoveOverElementCallback last and deprecate the current callback.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::mouseDidMoveOverElement):
Tools:
Update client function signatures.
- MiniBrowser/gtk/BrowserWindow.c:
(browserWindowUIClientInit):
- MiniBrowser/mac/BrowserWindowController.m:
(mouseDidMoveOverElement):
(-[BrowserWindowController awakeFromNib]):
- MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
- 1:06 PM Changeset in webkit [95314] by
-
- 4 edits1 copy in trunk/Source/WebKit2
Give local builds of WebProcess different icon to distinguish them from built-in Safariâs WebProcess
https://bugs.webkit.org/show_bug.cgi?id=68268
Reviewed by Darin Adler.
- Configurations/WebProcess.xcconfig: Add an icon in Debug and Release builds. The empty value for production resulted in WebKit not adding the key to plist at all, which is what we want (but I don't know if it's a supported feature). Also, don't copy the icon file to built framework in production builds.
- WebKit2.xcodeproj/project.pbxproj: Added WebKit.icns.
- WebProcess/Info.plist: Added a key for the icon.
- WebProcess/mac/WebKit.icns: Copied from Websites/webkit.org/images/surfin-safari.icns.
- 1:05 PM Changeset in webkit [95313] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix for non-DFG builds.
- runtime/Executable.h:
(JSC::NativeExecutable::finishCreation):
- 1:05 PM Changeset in webkit [95312] by
-
- 8 edits in trunk/Source
Unreviewed, rolling out r95309.
http://trac.webkit.org/changeset/95309
https://bugs.webkit.org/show_bug.cgi?id=68271
Broke many chromium gpu tests. (Requested by dave_levin on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16
Source/WebCore:
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::animateAndLayout):
(WTF::CCLayerTreeHostTest::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTest::beginCommitOnMainThread):
(WTF::CCLayerTreeHostTest::commitOnCCThread):
(WTF::CCLayerTreeHostTest::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTest::commitCompleteOnMainThread):
(WTF::CCLayerTreeHostTest::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTest::updateLayers):
(WTF::CCLayerTreeHostTest::onBeginTest):
(WTF::CCLayerTreeHostTest::doEndTest):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::testTimeout):
(WTF::MockLayerTreeHostClient::MockLayerTreeHostClient):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::MockLayerTreeHostClient::animateAndLayout):
(WTF::MockLayerTreeHostClient::updateLayers):
(WTF::MockLayerTreeHostCommitter::create):
(WTF::MockLayerTreeHostCommitter::commit):
(WTF::MockLayerTreeHostCommitter::MockLayerTreeHostCommitter):
(WTF::MockLayerTreeHostImpl::create):
(WTF::MockLayerTreeHostImpl::beginCommit):
(WTF::MockLayerTreeHostImpl::commitComplete):
(WTF::MockLayerTreeHostImpl::drawLayersAndPresent):
(WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(WTF::MockLayerTreeHostImplProxy::create):
(WTF::MockLayerTreeHostImplProxy::createLayerTreeHostImpl):
(WTF::MockLayerTreeHostImplProxy::MockLayerTreeHostImplProxy):
(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF::MockLayerTreeHost::createLayerTreeHostImplProxy):
(WTF::MockLayerTreeHost::updateLayers):
(WTF::MockLayerTreeHost::createLayerTreeHostCommitter):
(WTF::MockLayerTreeHost::beginCommit):
(WTF::MockLayerTreeHost::commitComplete):
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::CCLayerTreeHostTestShortlived2::beginTest):
(WTF::CCLayerTreeHostTestShortlived3::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::commitOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::commitOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::commitOnCCThread):
- 12:29 PM Changeset in webkit [95311] by
-
- 5 edits in trunk
Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
https://bugs.webkit.org/show_bug.cgi?id=68266
Reviewed by John Sullivan.
Source/WebKit2:
- UIProcess/API/C/WKPage.h:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::mouseDidMoveOverElement):
Tools:
- MiniBrowser/mac/BrowserWindowController.m:
(mouseDidMoveOverElement):
- 11:50 AM Changeset in webkit [95310] by
-
- 26 edits1 add in trunk/Source
DFG JIT should inline Math.abs
https://bugs.webkit.org/show_bug.cgi?id=68227
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
This adds the ability to track intrinsic functions throughout the
host function infrastructure, so that the DFG can easily query
whether or not a call's target is intrinsic, and if so, which
intrinsic it is.
On top of this, it adds Math.abs intrinsics to DFG. Call(Math.abs)
is transformed into ValueToNumber<-ArithAbs nodes. These nodes
then get optimized using the usual tricks.
Also had to make a completely unrelated change to
DateInstanceCache.h in order to fix a preexisting alphabetical
sorting problem in JSGlobalData.h
This results in a big win in imaging-gaussian-blur: 61% faster
than before. The net win on Kraken is around 13%.
- JavaScriptCore.xcodeproj/project.pbxproj:
- create_hash_table:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::isFunctionConstant):
(JSC::DFG::Graph::valueOfFunctionConstant):
- dfg/DFGIntrinsic.h: Added.
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::isFunctionConstant):
(JSC::DFG::JITCodeGenerator::valueOfFunctionConstant):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::isFunctionConstant):
(JSC::DFG::JITCompiler::valueOfFunctionConstant):
- dfg/DFGNode.h:
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNode):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
- jit/JITStubs.h:
- runtime/DateInstanceCache.h:
- runtime/Executable.cpp:
(JSC::ExecutableBase::intrinsic):
(JSC::NativeExecutable::intrinsic):
- runtime/Executable.h:
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::getHostFunction):
- runtime/JSGlobalData.h:
- runtime/Lookup.cpp:
(JSC::HashTable::createTable):
(JSC::setUpStaticFunctionSlot):
- runtime/Lookup.h:
(JSC::HashEntry::initialize):
(JSC::HashEntry::intrinsic):
Source/WebCore:
Reviewed by Oliver Hunt.
Added JavaScriptCore/dfg to include path path. Changed the bindings
scripts to handle the presence of intrinsics.
- CMakeLists.txt:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHashTable):
Source/WebKit:
Reviewed by Oliver Hunt.
Added JavaScriptCore/dfg to include path path.
- CMakeLists.txt:
Source/WebKit2:
Reviewed by Oliver Hunt.
Added JavaScriptCore/dfg to include path path.
- CMakeLists.txt:
- 11:43 AM Changeset in webkit [95309] by
-
- 8 edits in trunk/Source
[chromium] Fix CCLayerTreeHostTest
https://bugs.webkit.org/show_bug.cgi?id=67418
Source/WebCore:
This is a minimal set of changes to get CCLayerTreeHostTest
compiling, running and passing with USE_THREADED_COMPOSITING
enabled.
Patch by Iain Merrick <husky@google.com> on 2011-09-16
Reviewed by James Robinson.
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::createLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):
Source/WebKit/chromium:
Fixes needed to compile and link with USE_THREADED_COMPOSITING
enabled, and to pass the basic unit test.
Patch by Iain Merrick <husky@google.com> on 2011-09-16
Reviewed by James Robinson.
- src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::platformLayer):
- src/GraphicsContext3DPrivate.h:
- tests/CCLayerTreeHostTest.cpp:
(TestHooks::beginCommitOnCCThread):
(TestHooks::commitCompleteOnCCThread):
(TestHooks::drawLayersOnCCThread):
(MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(MockLayerTreeHostImpl::beginCommit):
(MockLayerTreeHostImpl::commitComplete):
(MockLayerTreeHostImpl::drawLayers):
(MockLayerTreeHost::MockLayerTreeHost):
(MockLayerTreeHost::createLayerTreeHostImpl):
(CompositorMockWebGraphicsContext3D::makeContextCurrent):
(CompositorMockWebGraphicsContext3D::createProgram):
(CompositorMockWebGraphicsContext3D::createShader):
(CompositorMockWebGraphicsContext3D::getShaderiv):
(CompositorMockWebGraphicsContext3D::getProgramiv):
(MockLayerTreeHostClient::MockLayerTreeHostClient):
(MockLayerTreeHostClient::animateAndLayout):
(MockLayerTreeHostClient::createCompositorThread):
(MockLayerTreeHostClient::createLayerTreeHostContext3D):
(MockLayerTreeHostClient::createRootLayerPainter):
(MockLayerTreeHostClient::didRecreateGraphicsContext):
(CCLayerTreeHostTest::postSetNeedsCommitToMainThread):
(CCLayerTreeHostTest::postSetNeedsRedrawToMainThread):
(CCLayerTreeHostTest::onEndTest):
(CCLayerTreeHostTest::dispatchSetNeedsCommit):
(CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(CCLayerTreeHostTest::runTest):
(CCLayerTreeHostTest::doBeginTest):
(CCLayerTreeHostTestShortlived2::beginTest):
(CCLayerTreeHostTestShortlived3::beginTest):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(CCLayerTreeHostTestSetNeedsCommit1::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit1::commitCompleteOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(CCLayerTreeHostTestSetNeedsCommit2::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit2::commitCompleteOnCCThread):
(CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(CCLayerTreeHostTestSetNeedsRedraw::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):
- 11:43 AM Changeset in webkit [95308] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION: Reproducible crash below SlotVisitor::harvestWeakReferences
using Domino's online ordering
https://bugs.webkit.org/show_bug.cgi?id=68220
Reviewed by Oliver Hunt.
Weak handle processing can result in new objects being marked, which
results in new WeakReferencesHarvesters being added. But weak
reference harvesters are only processed before weak handle processing,
so there's the risk that a weak reference harvester will persist
until the next collection, by which time it may have been deleted.
- heap/Heap.cpp:
(JSC::Heap::markRoots):
- 11:32 AM Changeset in webkit [95307] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r95227.
http://trac.webkit.org/changeset/95227
https://bugs.webkit.org/show_bug.cgi?id=68262
Broke a bunch of SVG tests (Requested by andersca on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16
- platform/ScrollView.cpp:
(WebCore::ScrollView::contentsSize):
(WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h:
- platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformContentsSize):
- platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::platformContentsSize):
- 11:26 AM Changeset in webkit [95306] by
-
- 4 edits in trunk
2011-09-16 James Simonsen <simonjam@chromium.org>
Fix HTML5 parser's adoption agency algorithm to reparent correctly
https://bugs.webkit.org/show_bug.cgi?id=68147
Reviewed by Eric Seidel.
- html5lib/resources/webkit02.dat:
2011-09-16 James Simonsen <simonjam@chromium.org>
Fix HTML5 parser's adoption agency algorithm to reparent correctly
https://bugs.webkit.org/show_bug.cgi?id=68147
Reviewed by Eric Seidel.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
- 11:22 AM Changeset in webkit [95305] by
-
- 2 edits in trunk/Tools/MiniBrowser
Unreviewed commit. Fix Windows and MacOSX compilation after r95303.
- 11:06 AM Changeset in webkit [95304] by
-
- 17 edits in trunk/Source/WebCore
CodeGeneratorGObject should use C++ style comments for ENABLE guards
https://bugs.webkit.org/show_bug.cgi?id=68256
Reviewed by Darin Adler.
This patch should have not behavioral effect. It just cleans up the
GObject code generator to use C++-style comments for ENABLE guards and
to use the usual comment style for license blocks.
- bindings/scripts/CodeGeneratorGObject.pm:
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
- bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_conditional_method1):
(webkit_dom_test_obj_conditional_method2):
(webkit_dom_test_obj_conditional_method3):
(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:
- 10:31 AM Changeset in webkit [95303] by
-
- 16 edits2 adds in trunk/Source/WebKit2
2011-09-16 Igor Oliveira <igor.oliveira@openbossa.org>
[WK2] mouseDidMoveOverElement needs to send more information about hovered element to UiProcess.
https://bugs.webkit.org/show_bug.cgi?id=68125
This patch implements support for the UiProcess to know what is the link url of a hovered element.
Reviewed by Anders Carlsson.
- CMakeLists.txt:
- GNUmakefile.am:
- Shared/API/c/WKBase.h:
- Shared/APIObject.h:
- Shared/WebHitTestResult.cpp: Added.
WebHitTestResult has hovered element information.
(WebKit::WebHitTestResult::create):
(WebKit::WebHitTestResult::Data::encode):
(WebKit::WebHitTestResult::Data::decode):
- Shared/WebHitTestResult.h: Added. (WebKit::WebHitTestResult::absoluteImageURL): (WebKit::WebHitTestResult::absoluteLinkURL): (WebKit::WebHitTestResult::absoluteMediaURL): (WebKit::WebHitTestResult::linkLabel): (WebKit::WebHitTestResult::linkTitle): (WebKit::WebHitTestResult::WebHitTestResult): (WebKit::WebHitTestResult::type):
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::mouseDidMoveOverElement):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::mouseDidMoveOverElement):
- UIProcess/WebUIClient.h:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::mouseDidMoveOverElement):
- win/WebKit2.vcproj:
- 10:28 AM Changeset in webkit [95302] by
-
- 19 edits3 deletes in trunk
[Qt] REGRESSION(r95091) It made many tests flakey
https://bugs.webkit.org/show_bug.cgi?id=68232
Unreviewed rolling out r95091 and followup patches.
Source/WebCore:
- English.lproj/localizedStrings.js:
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::callFunction):
- bindings/v8/V8Proxy.h:
- bindings/v8/custom/V8CustomVoidCallback.cpp:
(WebCore::invokeCallback):
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::registerCallback):
(WebCore::ScriptedAnimationController::cancelCallback):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
- inspector/InspectorInstrumentation.cpp:
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willCallFunction):
- inspector/InspectorTimelineAgent.cpp:
- inspector/InspectorTimelineAgent.h:
- inspector/TimelineRecordFactory.cpp:
- inspector/TimelineRecordFactory.h:
- inspector/front-end/TimelineAgent.js:
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
LayoutTests:
- inspector/timeline/timeline-animation-frame-expected.txt: Removed.
- inspector/timeline/timeline-animation-frame.html: Removed.
- inspector/timeline/timeline-enum-stability-expected.txt:
- inspector/timeline/timeline-test.js:
- platform/chromium/inspector/timeline/timeline-animation-frame-expected.txt: Removed.
- platform/qt/Skipped:
- platform/qt/test_expectations.txt:
- 10:23 AM Changeset in webkit [95301] by
-
- 4 edits2 adds in trunk
cachedFont not getting updated for inline SVG text.
https://bugs.webkit.org/show_bug.cgi?id=68060
Reviewed by Nikolas Zimmermann.
Source/WebCore:
The cached scaledFont needs to be updated on every style set call. It
is not similar to m_style which can get derived from parent's style and
hence will get automatically updated on ancestor's style change. This is
required, otherwise we will maintain stale font list in cached scaledFont
when custom fonts are retired on Document::recalcStyle.
Test: svg/text/text-style-recalc-crash.html
- rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::styleDidChange):
(WebCore::RenderSVGInlineText::setStyle):
- rendering/svg/RenderSVGInlineText.h:
LayoutTests:
- svg/text/text-style-recalc-crash-expected.txt: Added.
- svg/text/text-style-recalc-crash.html: Added.
- 9:58 AM Changeset in webkit [95300] by
-
- 4 edits in trunk/Source/WebKit2
Add support for attributes on message parameters
Parameter attributes are specified as a space-separated list inside square brackets before
the parameter's type. WebKit2 doesn't use this, but other projects that use these scripts
would like to.
Fixes <http://webkit.org/b/68219> Would like a way to specify attributes on message
parameters
Reviewed by Sam Weinig.
- Scripts/webkit2/messages_unittest.py: Added tests for parameter attributes.
- Scripts/webkit2/model.py:
(Parameter.init): Added a new attributes parameter, which is stored in the self.attributes
property.
(Parameter.has_attribute): Added. Returns true if this parameter has the given attribute.
- Scripts/webkit2/parser.py:
(parse): Moved attributes-parsing code from here...
(parse_attributes_string): ...to here.
(parse_parameters_string): Renamed from parse_parameter_string. Now also parses parameter
attributes.
- 9:58 AM Changeset in webkit [95299] by
-
- 4 edits in trunk/Source/WebKit2
Make WebKit2's message-generation model and parser scripts accessible to other projects
We copy them into the build products directory so other projects can find them.
Fixes <http://webkit.org/b/68169> Would like to be able to use WebKit2's message-generation
scripts in other projects
Reviewed by Darin Adler.
- WebKit2.xcodeproj/project.pbxproj: Copy the scripts to PrivateHeaders.
- win/WebKit2.make: Copy the scripts from obj/WebKit2/scripts to
tools/scripts, like WebCore does.
- win/WebKit2Generated.make: Copy the scripts to obj/WebKit2/scripts, which is similar to what
WebCore does for its bindings scripts.
- 9:57 AM Changeset in webkit [95298] by
-
- 9 edits2 adds in trunk/Source/WebKit2
Split some of the message-generation code into separate modules
This is in preparation for making these modules scripts usable by other projects.
Fixes <http://webkit.org/b/68217> Model and parsing functionality for WebKit2's
message-generation scripts is trapped inside a much larger module
Reviewed by Darin Adler.
- DerivedSources.make:
- DerivedSources.pro:
- GNUmakefile.am:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- win/WebKit2Generated.vcproj:
Added new files.
- Scripts/webkit2/messages.py: Moved some code from here...
- Scripts/webkit2/model.py: Added.
- Scripts/webkit2/parser.py: Added.
...to here. MessageReceiver.parse was split out into a function in the new parser module.
- Scripts/webkit2/messages_unittest.py: Updated for renames.
- 9:36 AM Changeset in webkit [95297] by
-
- 6 edits in trunk
Source/JavaScriptCore: REGRESSION(r95201): It made two tests fail
https://bugs.webkit.org/show_bug.cgi?id=68230
Unreviewed rolling out r95201.
- jit/JIT.h:
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):
- jit/JITInlineMethods.h:
LayoutTests: Unreviewed rolling out r95277.
- platform/qt/Skipped:
- 9:26 AM Changeset in webkit [95296] by
-
- 1 edit5 adds in trunk/LayoutTests
Web Inspector: UI performance tests are required.
https://bugs.webkit.org/show_bug.cgi?id=68234
The idea is to create a set of tests which cover frequently used UI actions
and print the average time of these actions.
There are two pilot tests. The common part was extracted into performance-test helper.
Reviewed by Pavel Feldman.
- inspector/performance/resources/network-append-30-requests.html: Added.
- inspector/performance/resources/performance-test.js: Added.
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.start):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.finish):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._runTest):
- inspector/performance/resources/show-panel-network.html: Added.
- 9:25 AM Changeset in webkit [95295] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r95052): SelectorChecker identifier filter not working
https://bugs.webkit.org/show_bug.cgi?id=68244
Reviewed by Dan Bernstein.
Missing &.
- css/SelectorChecker.cpp:
(WebCore::collectDescendantSelectorIdentifierHashes):
- 9:08 AM Changeset in webkit [95294] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed typo fix after r95271.
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
- 8:58 AM Changeset in webkit [95293] by
-
- 2 edits in trunk/Tools
Add Vincent Scheib to the committers list.
- Scripts/webkitpy/common/config/committers.py:
- 8:50 AM Changeset in webkit [95292] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip a flakey test.
- platform/qt/Skipped:
- 8:42 AM Changeset in webkit [95291] by
-
- 1 edit6 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Add Qt specific expexted results for new tests introduced in r95239.
- platform/qt/fast/clip/overflow-border-radius-combinations-expected.png: Added.
- platform/qt/fast/clip/overflow-border-radius-combinations-expected.txt: Added.
- platform/qt/fast/clip/overflow-border-radius-composited-expected.png: Added.
- platform/qt/fast/clip/overflow-border-radius-composited-expected.txt: Added.
- platform/qt/fast/clip/overflow-border-radius-transformed-expected.png: Added.
- platform/qt/fast/clip/overflow-border-radius-transformed-expected.txt: Added.
- 8:24 AM Changeset in webkit [95290] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r95285.
http://trac.webkit.org/changeset/95285
https://bugs.webkit.org/show_bug.cgi?id=68247
It broke a webkitpy test (Requested by ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16
- Scripts/webkitpy/layout_tests/controllers/manager.py:
- 6:30 AM Changeset in webkit [95289] by
-
- 10 edits1 add1 delete in trunk/Source
2011-09-16 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: [Extensions API] support extensions for remote inspector front-end
https://bugs.webkit.org/show_bug.cgi?id=67840
Reviewed by Pavel Feldman.
- Merge ExtensionCommon.js into ExtensionAPI.js
- refactor building of extension API for better reuse
- expose interface for extension registration
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/ExtensionAPI.js: (defineCommonExtensionSymbols): (buildExtensionAPIInjectedScript):
- inspector/front-end/ExtensionCommon.js:
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionServer.prototype._addExtension): (WebInspector.ExtensionServer.prototype._buildExtensionAPIScript): (WebInspector.ExtensionServer.prototype._onWindowMessage): (WebInspector.ExtensionServer.prototype._registerExtension): (WebInspector.ExtensionServer.prototype._expandResourcePath):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
2011-09-16 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: [Extensions API] support extensions for remote inspector front-end
https://bugs.webkit.org/show_bug.cgi?id=67840
Reviewed by Pavel Feldman.
- expose extension API as a single, standalone file for easy reuse in remote extension scripts.
- WebKit.gyp:
- scripts/generate_devtools_extension_api.py: Added.
- scripts/generate_devtools_zip.py:
- 6:19 AM Changeset in webkit [95288] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test fix for r95287.
- inspector/debugger/debugger-expand-scope.html:
- 5:55 AM Changeset in webkit [95287] by
-
- 15 edits in trunk
Web Inspector: change WebInspector.currentPanel getter/setter to functions.
https://bugs.webkit.org/show_bug.cgi?id=68242
This is necessary for the panel switching performance tests.
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
(WebInspector.Drawer.prototype._animateDrawerHeight):
(WebInspector.Drawer.prototype._statusBarDragging):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.switchToAndFocus):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.showAnchorLocation):
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype.updateSearchMatchesCount):
(WebInspector.SearchController.prototype.updateCurrentMatchIndex):
(WebInspector.SearchController.prototype.updateSearchLabel):
(WebInspector.SearchController.prototype.handleShortcut):
(WebInspector.SearchController.prototype._performSearch):
- inspector/front-end/Toolbar.js:
(WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked):
(WebInspector.Toolbar.createPanelToolbarItem):
- inspector/front-end/inspector.js:
(WebInspector.currentPanel):
(WebInspector._updateFocusedNode):
(WebInspector.windowResize):
(WebInspector.documentKeyDown):
(WebInspector.documentCanCopy):
(WebInspector.documentCopy):
(WebInspector.showPanel):
(WebInspector.startUserInitiatedDebugging):
(WebInspector.inspect):
(WebInspector._showAnchorLocationInPanel):
(WebInspector._toolbarItemClicked):
(WebInspector.PanelHistory.prototype.goBack):
(WebInspector.PanelHistory.prototype.goForward):
Source/WebKit/chromium:
- src/js/Tests.js:
(.TestSuite.prototype.showPanel):
LayoutTests:
- http/tests/inspector/resource-tree/resource-tree-test.js:
(initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):
- inspector/debugger/debugger-expand-scope.html:
- inspector/debugger/debugger-proto-property.html:
- inspector/storage-panel-dom-storage.html:
- 5:42 AM Changeset in webkit [95286] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] bot lucks mobility
https://bugs.webkit.org/show_bug.cgi?id=68243
Unreviwed test skipping.
- platform/qt-wk2/Skipped:
- 5:04 AM Changeset in webkit [95285] by
-
- 2 edits in trunk/Tools
Buildbot marks a nrwt bot red when tests are missing results
https://bugs.webkit.org/show_bug.cgi?id=64812
Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-16
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
- 5:00 AM Changeset in webkit [95284] by
-
- 1 edit in trunk/Source/WebCore/rendering/LayoutState.cpp
Unreviewed. Fix release compilation after r95264
- 4:43 AM Changeset in webkit [95283] by
-
- 6 edits in trunk
[GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
https://bugs.webkit.org/show_bug.cgi?id=68178
Patch by Martin Robinson <mrobinson@igalia.com> on 2011-09-16
Reviewed by Xan Lopez.
.:
- configure.ac: Do not build WebKit2 by default. Re-add pkgconfig support
for WebKit2.
Source/WebKit2:
- GNUmakefile.am: Do not build WebKit2 by default. Re-add pkgconfig support
for WebKit2.
Tools:
Add a work-around to enable WebKit2 when using build-webkit.
- Scripts/webkitdirs.pm:
(buildAutotoolsProject):
- 2:29 AM Changeset in webkit [95282] by
-
- 9 edits in trunk
Web Inspector: rename Console.clearConsoleMessages to Console.clearMessages, brush up console domain doc.
https://bugs.webkit.org/show_bug.cgi?id=68165
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::clearConsoleMessages):
- inspector/Inspector.json:
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::clearMessages):
- inspector/InspectorConsoleAgent.h:
- inspector/front-end/ConsoleModel.js:
(WebInspector.ConsoleModel.prototype.requestClearMessages):
LayoutTests:
- inspector/protocol/console-agent-expected.txt:
- inspector/protocol/console-agent.html:
- 2:13 AM Changeset in webkit [95281] by
-
- 3 edits1 add in trunk/LayoutTests
[chromium] Rebaselines due to r95203 and r95207.
- platform/chromium-cg-mac-leopard/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
- platform/chromium/test_expectations.txt:
- 1:39 AM Changeset in webkit [95280] by
-
- 2 edits in trunk/Source/WebCore
2011-09-16 Alejandro G. Castro <alex@igalia.com>
Fix build after r95245.
- GNUmakefile.list.am:
- 1:35 AM Changeset in webkit [95279] by
-
- 5 edits in trunk/LayoutTests
[Qt] Update expecteds of failing tests after r95260 and r95242.
Unreviewed gardening.
- 1:26 AM Changeset in webkit [95278] by
-
- 2 edits in trunk/LayoutTests
[Qt] One test failed after r95203
https://bugs.webkit.org/show_bug.cgi?id=68233
Unreviewed gardening.
- platform/qt/Skipped: failed test is skipped.
- 1:21 AM Changeset in webkit [95277] by
-
- 2 edits in trunk/LayoutTests
[Qt] One test runs out of time after r95091
https://bugs.webkit.org/show_bug.cgi?id=68232
Unreviewed gardening.
- platform/qt/Skipped:
- 1:16 AM Changeset in webkit [95276] by
-
- 2 edits in trunk/LayoutTests
[Qt] Two tests fail after r95201
https://bugs.webkit.org/show_bug.cgi?id=68230
Unreviewed gardening.
- platform/qt/Skipped:
- 12:15 AM Changeset in webkit [95275] by
-
- 3 edits2 adds in trunk
[Qt] Crash when dragging google maps.
https://bugs.webkit.org/show_bug.cgi?id=68223
Source/WebCore:
The custom image for a cursor might not be ready when WebKit trying
to use it to construct the cursor in Qt porting. This patch is using
arrow image to substitute the unready custom image.
Reviewed by Adam Barth.
Test: fast/css/crash-on-custom-cursor-when-loading.html
- platform/qt/CursorQt.cpp:
(WebCore::createCustomCursor):
(WebCore::Cursor::ensurePlatformCursor):
LayoutTests:
Test case to use an unready custom cursor.
Reviewed by Adam Barth.
- fast/css/crash-on-custom-cursor-when-loading-expected.txt: Added.
- fast/css/crash-on-custom-cursor-when-loading.html: Added.
