Context Navigation

← Previous Period
Next Period →

Timeline

Sep 18, 2011:

11:50 PM Changeset in webkit [95402] by koz@chromium.org

1 edit
1 add in trunk/LayoutTests

Rebaseline navigator test for chromium-win-vista.
https://bugs.webkit.org/show_bug.cgi?id=68334

Unreviewed. Rebaseline for navigator-detached-no-crash.

platform/chromium-win-vista/fast/dom/navigator-detached-no-crash-expected.txt: Added.

10:34 PM Changeset in webkit [95401] by loislo@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: chromium-win: "Save timeline data" does nothing.
https://bugs.webkit.org/show_bug.cgi?id=68313

windows shell API function GetSaveFileName doesn't accept file names with ':' symbol.

Reviewed by Pavel Feldman.

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelineModel.prototype._saveToFile):

6:29 PM Changeset in webkit [95400] by mitz@apple.com

5 edits
2 deletes in trunk/Source/JavaScriptCore

Removed ProfilerServer.

Reviewed by Mark Rowe.

JavaScriptCore.gypi:
JavaScriptCore.xcodeproj/project.pbxproj:
profiler/ProfilerServer.h: Removed.
profiler/ProfilerServer.mm: Removed.
runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

wscript:

3:29 PM Changeset in webkit [95399] by fpizlo@apple.com

9 edits in trunk/Source/JavaScriptCore

DFG JIT should inline Math.min, Math.max, and Math.sqrt
https://bugs.webkit.org/show_bug.cgi?id=68318

Reviewed by Gavin Barraclough.

Adds Math.min, Math.max, and Math.sqrt intrinsics. Adds support for
a function to have an intrinsic but not a thunk generator. This is
a 7% speed-up on access-nbody, and neutral elsewhere, mainly because
we're still not DFG compiling the bulk of the hot code in Kraken audio
benchmarks.

create_hash_table:
dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):

dfg/DFGIntrinsic.h:
dfg/DFGNode.h:
dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::fixupNode):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

jit/JITStubs.cpp:

(JSC::JITThunks::hostFunctionStub):

runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

2:35 PM Changeset in webkit [95398] by thakis@chromium.org

2 edits in trunk/Source/JavaScriptCore

Remove two files from JavaScriptCore.gypi that were removed in r95240
https://bugs.webkit.org/show_bug.cgi?id=68327

Unreviewed, build warning fix.

JavaScriptCore.gypi:

11:38 AM Changeset in webkit [95397] by oliver@apple.com

5 edits in trunk/Source/JavaScriptCore

Remove special case handling of inline storage from the JIT
https://bugs.webkit.org/show_bug.cgi?id=68319

Reviewed by Gavin Barraclough.

Simplify logic used for reading and writing to property storage
by removing the special cases for inline storage. This has no
perf impact.

dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryBuildGetByIDList):

jit/JIT.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdSelfList):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdSelfList):

11:18 AM Changeset in webkit [95396] by mitz@apple.com

2 edits in trunk/Source/WebCore

Try to fix the Chromium Mac build after r95391.

WebCore.gyp/WebCore.gyp:

11:05 AM Changeset in webkit [95395] by mitz@apple.com

2 edits in trunk/Source/WebCore

Try to fix the Chromium Mac build after r95391.

WebCore.gyp/WebCore.gyp:

10:27 AM Changeset in webkit [95394] by mitz@apple.com

5 edits
1 move in trunk/Source/WebCore

Try to fix the Chromium Mac build after r95391.

WebCore.gypi: Updated for the renaming of ComplexTextController.cpp.
WebCore.xcodeproj/project.pbxproj: Ditto.
platform/graphics/Font.h: Changed #if directives to include the Chromium Mac port.
platform/graphics/SimpleFontData.h: Ditto.
platform/graphics/mac/ComplexTextControllerCoreText.cpp: Changed the filename extension of this

Objective-C++ file to .mm.

platform/graphics/mac/ComplexTextControllerCoreText.mm: Copied from Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.cpp.

10:16 AM Changeset in webkit [95393] by mitz@apple.com

2 edits in trunk/Source/WebCore

Snow Leopard build fix after r95391.

platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

10:02 AM Changeset in webkit [95392] by mitz@apple.com

2 edits in trunk/Source/WebCore

Leopard build fix after r95391.

platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):

9:52 AM Changeset in webkit [95391] by mitz@apple.com

11 edits
3 adds in trunk

Source/WebCore: Allow Core Text to choose the fallback font for rendering a combining character sequence

Fixes <rdar://problem/7860281> Decomposed text is displayed incorrectly when Verdana is specified
https://bugs.webkit.org/show_bug.cgi?id=68287

Reviewed by Dave Hyatt.

Test: platform/mac/fast/text/combining-character-sequence-fallback.html

WebCore.xcodeproj/project.pbxproj: Compile ComplexTextControllerCoreText.cpp as Objective-C++.

I am going to rename this file in a followup patch.

platform/graphics/Font.h: Declared fontDataForCombiningCharacterSequence().

platform/graphics/SimpleFontData.h: Declared canRenderCombiningCharacterSequence() and added

a member variable to cache the results of calling this function.

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::offsetForPosition): Fixed a typo in a comment.
(WebCore::advanceByCombiningCharacterSequence): Added this helper function, which iterates over
characters until the end of a sequence of combining characters, zero-width joiners and zero-width
non-joiners. A single base characater followed by such a (possibly-empty) sequence is known as
a combining character sequence. This stretches the definition a little because the base character
may be a combining character as well. Returns false if an invalid UTF-16 sequence is encountered,
true otherwise.
(WebCore::ComplexTextController::collectComplexTextRuns): - Replaced the glyphData and nextGlyphData
variables each with a pair of variables, a SimpleFontData* and a boolean indicating whether a
character mapped to the missing glyph. This clarifies that this function does not use glyph IDs.

Renamed the local variable newC to uppercaseCharacter.
Changed to use advanceByCombiningCharacterSequence().
Changed to use Font::fontDataForCombiningCharacterSequence() instead of Font::glyphDataForCharacter(). If there are combining marks and none of the fonts in the fallback list can render the sequence alone, use the systemFallbackFontData() constant to indicate to collectComplexTextRunsForCharactersCoreText() to allow Core Text to perform its own fallback.
Stopped checking isSmallCaps against nextIsSmallCaps. It was redundant, since the small caps FontData differs from the normal variant.

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Moved the common logic to
handle the 0 fontData case from the ATSUI and Core Text continuations of this function into this function.

platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::systemFallbackFontData): Added. This constant is used to indicate to
collectComplexTextRunsForCharactersCoreText() that it should allow Core Text to perform its own font
fallback.

platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI): Handle systemFallbackFontData()
by using the primary font data.

platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(-[CascadeList initWithFont:WebCore::character:]): Added.
(-[CascadeList count]): Added.
(-[CascadeList objectAtIndex:]): Added. Returns an entry from a cascade list of CTFontDescriptorRef
objects based on the font’s fallback list for the character. The list is initialized lazily.
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Handle systemFallbackFontData()
by allowing Core Text to perform font fallback, starting with a cascade list based on the font’s fallback
list and possibly continuing with system fallback.

platform/graphics/mac/FontMac.mm:

(WebCore::Font::fontDataForCombiningCharacterSequence): Added. If the sequence is only a base character,
calls through to glyphDataForCharacter(). Otherwise, iterates over the font’s fallback list for the
base character (and the system fallback font for that character), returning the first font that can
render the sequence, or 0 if there is none.

platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::provideStringAndAttributes): Added this Core Text callback.
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence): Added. Checks if Core Text can render
the sequence using only this font. Caches the result.

LayoutTests: <rdar://problem/7860281> Decomposed text is displayed incorrectly when Verdana is specified
https://bugs.webkit.org/show_bug.cgi?id=68287

Reviewed by Dave Hyatt.

platform/mac/fast/text/combining-character-sequence-fallback.html: Added.
platform/mac/platform/mac/fast/text/combining-character-sequence-fallback-expected.png: Added.
platform/mac/platform/mac/fast/text/combining-character-sequence-fallback-expected.txt: Added.

9:21 AM Changeset in webkit [95390] by mitz@apple.com

3 edits in trunk/LayoutTests

Updated expected results for two tests after r95362.

platform/mac/fast/dom/Window/window-properties-expected.txt:
platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:

Sep 17, 2011:

8:47 PM Changeset in webkit [95389] by fpizlo@apple.com

8 edits
1 delete in trunk/Source/JavaScriptCore

DFG JIT does not have full block-local CSE
https://bugs.webkit.org/show_bug.cgi?id=68316

Reviewed by Oliver Hunt.

This adds block-local CSE to the DFG. CSE runs in the propagator just after
type propagation. It is part of the propagator itself because it needs to
use the propagator's internal data structures to determine which operations
may have side effects. Because it changes the live-ranges of nodes, the
virtual register allocator had to be moved into the propagator so that it
runs after CSE. To ensure that the back-end knows to keep the inputs to
any eliminated node alive for OSR, a new node type, Phantom, was introduced.
It is a no-op but prolonges the live-range of its inputs.

This is an 80% speed-up on imaging-gaussian-blur, and a 10% speed-up on
Kraken.

JavaScriptCore.xcodeproj/project.pbxproj:
dfg/DFGAliasTracker.h: Removed.
dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

dfg/DFGGraph.h:

(JSC::DFG::MethodCheckData::operator==):
(JSC::DFG::MethodCheckData::operator!=):

dfg/DFGNode.h:

(JSC::DFG::Node::hasVirtualRegister):
(JSC::DFG::Node::setRefCount):

dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::canonicalize):
(JSC::DFG::Propagator::computeStartIndex):
(JSC::DFG::Propagator::startIndex):
(JSC::DFG::Propagator::pureCSE):
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::performSubstitution):
(JSC::DFG::Propagator::setReplacement):
(JSC::DFG::Propagator::performNodeCSE):
(JSC::DFG::Propagator::performBlockCSE):
(JSC::DFG::Propagator::localCSE):
(JSC::DFG::Propagator::allocateVirtualRegisters):
(JSC::DFG::propagate):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:33 PM Changeset in webkit [95388] by fpizlo@apple.com

5 edits in trunk/Source/JavaScriptCore

method_check should repatch itself if it finds that the new structure(s)
are the result of transitions from the old structure(s)
https://bugs.webkit.org/show_bug.cgi?id=68294

Reviewed by Gavin Barraclough.

Previously a patched method_check would slow-path to get_by_id. Now it
slow-paths to method_check_update, which attempts to correct the
method_check due to structure transitions before bailing to get_by_id.

This is a 1-2% speed-up on some benchmarks and is not a slow-down
anywhere, leading to a 0.6% speed-up on the Kraken geomean.

jit/JITPropertyAccess.cpp:

(JSC::JIT::patchMethodCallProto):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

jit/JITStubs.h:
runtime/Structure.h:

(JSC::Structure::transitivelyTransitionedFrom):

4:31 PM Changeset in webkit [95387] by mihaip@chromium.org

35 edits in trunk/Source

FrameLoaderClient BackForwardList-related methods are unsued
https://bugs.webkit.org/show_bug.cgi?id=68293

Reviewed by Darin Adler.

Source/WebCore: