Context Navigation

← Previous Period
Next Period →

Timeline

Sep 19, 2011:

11:33 PM Changeset in webkit [95517] by mrowe@apple.com

3 edits in trunk/Source/WebCore

Attempt to fix the Leopard build.

platform/mac/DisplaySleepDisabler.cpp:

(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):

platform/mac/DisplaySleepDisabler.h:

9:33 PM Changeset in webkit [95516] by mhahnenberg@apple.com

8 edits in trunk/Source/JavaScriptCore

Remove toPrimitive from JSCell
https://bugs.webkit.org/show_bug.cgi?id=67875

Reviewed by Darin Adler.

Part of the refactoring process to un-virtualize JSCell. We move
all of the implicit functionality provided by the virtual toPrimitive method
in JSCell to be explicit in JSValue::toPrimitive and JSCell:toPrimitive while
also de-virtualizing JSCell::toPrimitive.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
runtime/JSCell.cpp:

(JSC::JSCell::toPrimitive):

runtime/JSCell.h:

We replace JSNotAnObject::toPrimitive with defaultValue, which it overrides from
JSObject. This pushes the virtual method further down, enabling us to get rid
of the virtual call in JSCell. Eventually we'll probably have to deal with this
again, but we'll cross that bridge when we come to it.

runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::defaultValue):

runtime/JSNotAnObject.h:
runtime/JSObject.h:
runtime/JSString.h:

9:30 PM Changeset in webkit [95515] by ggaren@apple.com

1 edit in trunk/Source/cmake/OptionsWinCE.cmake

Removing one last case of DENABLE_JSC_MULTIPLE_THREADS -- the cmake folder doesn't seem to have a ChangeLog

9:24 PM Changeset in webkit [95514] by ggaren@apple.com

2 edits in trunk/Source/WebKit/chromium

Removed ENABLE_JSC_MULTIPLE_THREADS and related #ifdefs.
https://bugs.webkit.org/show_bug.cgi?id=68422

Missed this one case before.

features.gypi:

9:14 PM Changeset in webkit [95513] by mrowe@apple.com

11 edits
2 copies in trunk/Source

<http://webkit.org/b/68421> Stop calling UpdateSystemActivity in places where we hold power assertions that achieve the same effect

On SnowLeopard and newer it's not necessary to call UpdateSystemActivity to prevent the screensaver from kicking
in as the NoDisplaySleep assertion now has that effect. It's also not necessary to hold both a NoDisplaySleep and
a NoIdleSleep assertion as the latter is implied by the former.

Source/WebCore:

Since there were multiple copies of the same code to disable display sleep spread across WebCore, WebKit and WebKit2
this patch takes the approach of moving this functionality to a new DisplaySleepDisabler class that lives in WebCore.
A class is used as it makes it easier to reason about the lifetime of the assertions and to ensure that the assertions will
always be released when their owning objects go away.

Reviewed by Dan Bernstein.

WebCore.exp.in:
WebCore.xcodeproj/project.pbxproj:
platform/mac/DisplaySleepDisabler.cpp:

(WebCore::DisplaySleepDisabler::DisplaySleepDisabler): Register for the NoDisplaySleep assertion, and start our
system activity timer when on Leopard.
(WebCore::DisplaySleepDisabler::~DisplaySleepDisabler): Unregister for the assertion.
(WebCore::DisplaySleepDisabler::systemActivityTimerFired): Call UpdateSystemActivity to prevent the screensaver from
triggering on Leopard.

platform/mac/DisplaySleepDisabler.h:

(WebCore::DisplaySleepDisabler::create):

platform/mac/WebVideoFullscreenController.h:
platform/mac/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController dealloc]):
(-[WebVideoFullscreenController setupVideoOverlay:]): Remove the now-unnecessary explicit use of the WebCore namespace.
(-[WebVideoFullscreenController mediaElement]): Ditto.
(-[WebVideoFullscreenController setMediaElement:]): Ditto.
(-[WebVideoFullscreenController windowDidExitFullscreen]): Ditto.
(-[WebVideoFullscreenController updatePowerAssertions]): Create a DisplaySleepDisabler instance when transitioning from permitting
display sleep to disabling display sleep. Clear out our reference when sleep should be permitted, destroying any
disabler that we own.

Source/WebKit/mac:

Adopt the DisplaySleepDisabler class that was added to WebCore and remove all of duplicated logic from WebFullScreenController.

Reviewed by Dan Bernstein.

WebView/WebFullScreenController.h:
WebView/WebFullScreenController.mm:

(-[WebFullScreenController dealloc]):
(-[WebFullScreenController _updatePowerAssertions]): Create a DisplaySleepDisabler instance when transitioning from permitting
display sleep to disabling display sleep. Clear out our reference when sleep should be permitted, destroying any
disabler that we own.

Source/WebKit2:

Adopt the DisplaySleepDisabler class that was added to WebCore and remove all of duplicated logic from WKFullScreenWindowController.

Reviewed by Dan Bernstein.

UIProcess/mac/WKFullScreenWindowController.h:
UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController _updatePowerAssertions]): Create a DisplaySleepDisabler instance when transitioning from permitting
display sleep to disabling display sleep. Clear out our reference when sleep should be permitted, destroying any
disabler that we own. Also adds a FIXME about an error that was noticed while working in this code.

9:05 PM Changeset in webkit [95512] by ggaren@apple.com

4 edits in trunk/Source/JavaScriptCore

Removed ENABLE_LAZY_BLOCK_FREEING and related #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=68424

As discussed on webkit-dev. All ports build with threads enabled in JSC now.

This may break WinCE and other ports that have not built and tested with
this configuration. I've filed bugs for port maintainers. It's time for
WebKit to move forward.

Reviewed by Mark Rowe.

heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::destroy):
(JSC::Heap::blockFreeingThreadMain):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::releaseFreeBlocks):

heap/Heap.h:
wtf/Platform.h:

8:55 PM Changeset in webkit [95511] by ggaren@apple.com

11 edits in trunk/Source/JavaScriptCore

Removed ENABLE_WTF_MULTIPLE_THREADS and related #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=68423

As discussed on webkit-dev. All ports build with threads enabled in WTF now.

This may break WinCE and other ports that have not built and tested with
this configuration. I've filed bugs for port maintainers. It's time for
WebKit to move forward.

Reviewed by Mark Rowe.

wtf/CryptographicallyRandomNumber.cpp:

(WTF::ARC4Stream::ARC4RandomNumberGenerator::randomNumber):
(WTF::ARC4Stream::ARC4RandomNumberGenerator::randomValues):

wtf/FastMalloc.cpp:
wtf/Platform.h:
wtf/RandomNumber.cpp:

(WTF::randomNumber):

wtf/RefCountedLeakCounter.cpp:

(WTF::RefCountedLeakCounter::increment):
(WTF::RefCountedLeakCounter::decrement):

wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):

wtf/ThreadingWin.cpp:

(WTF::initializeThreading):

wtf/dtoa.cpp:

(WTF::pow5mult):

wtf/gtk/ThreadingGtk.cpp:

(WTF::initializeThreading):

wtf/qt/ThreadingQt.cpp:

(WTF::initializeThreading):

8:35 PM Changeset in webkit [95510] by ggaren@apple.com

11 edits in trunk/Source/JavaScriptCore

Removed ENABLE_JSC_MULTIPLE_THREADS and related #ifdefs.
https://bugs.webkit.org/show_bug.cgi?id=68422

As discussed on webkit-dev. All ports build with threads enabled in JSC now.

This may break WinCE and other ports that have not built and tested with
this configuration. I've filed bugs for port maintainers. It's time for
WebKit to move forward.

Reviewed by Sam Weinig.

API/APIShims.h:

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):

API/JSContextRef.cpp:
heap/MachineStackMarker.cpp:

(JSC::MachineThreads::MachineThreads):
(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::gatherConservativeRoots):

heap/MachineStackMarker.h:
runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):
(JSC::initializeThreading):

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::sharedInstance):

runtime/JSGlobalData.h:

(JSC::JSGlobalData::makeUsableFromMultipleThreads):

runtime/JSLock.cpp:
runtime/Structure.cpp:
wtf/Platform.h:

7:48 PM Changeset in webkit [95509] by rniwa@webkit.org

3 edits
4 adds in trunk

Hit testing on margins of body and head elements doesn't recur
https://bugs.webkit.org/show_bug.cgi?id=40753

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by positionForPointRespectingEditingBoundaries's comparing the editability
of head/body and html elements when hit testing was done inside margins of head and body elements.

Fixed the bug by special-casing html element (any immediate child of render view with a render layer)
since margins of head and body elements are special.

Tests: editing/selection/click-on-body-margin.html

editing/selection/click-on-head-margin.html

rendering/RenderBlock.cpp:

(WebCore::positionForPointRespectingEditingBoundaries):

LayoutTests:

Add tests to click on margins of head and body elements. WebKit should not
(attempt to) place the caret after or before head and body elements.

editing/selection/click-on-body-margin-expected.txt: Added.
editing/selection/click-on-body-margin.html: Added.
editing/selection/click-on-head-margin-expected.txt: Added.
editing/selection/click-on-head-margin.html: Added.

7:07 PM Changeset in webkit [95508] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/chromium

Ask for audio hardware buffer size instead of using hardwired constants.
https://bugs.webkit.org/show_bug.cgi?id=67952

Patch by Raymond Toy <Raymond Toy> on 2011-09-19
Reviewed by Kenneth Russell.

public/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::audioHardwareBufferSize): Declare
new member function audioHardwareBufferSize.

src/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):
Call audioHardwareBufferSize() to get buffer size; update
m_callbackBuffersize and m_renderCountPerCallback appropriately.
Remove global variables callbackBufferSize and
renderCountPerCallback. Add constant for maximum
allowed buffer size and verify we don't exceed it.
(WebCore::AudioDestinationChromium::render): Use new member
variables instead of globals.

src/AudioDestinationChromium.h:

Define new member variables m_callbackBufferSize and
m_renderCountPerCallback

6:53 PM Changeset in webkit [95507] by commit-queue@webkit.org

15 edits
3 deletes in trunk/Source

Unreviewed, rolling out r95493 and r95496.
http://trac.webkit.org/changeset/95493
http://trac.webkit.org/changeset/95496
https://bugs.webkit.org/show_bug.cgi?id=68418

Broke Windows build (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

Source/JavaScriptCore:

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.exp:
JavaScriptCore.gypi:
JavaScriptCore.pro:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
debugger/Debugger.cpp:

(JSC::Debugger::recompileAllJSFunctions):

heap/AllocationSpace.cpp: Removed.
heap/AllocationSpace.h: Removed.
heap/Heap.cpp:

(JSC::CountFunctor::TakeIfEmpty::TakeIfEmpty):
(JSC::CountFunctor::TakeIfEmpty::operator()):
(JSC::CountFunctor::TakeIfEmpty::returnValue):
(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::tryAllocate):
(JSC::Heap::allocateSlowCase):
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::clearMarks):
(JSC::Heap::sweep):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrink):

heap/Heap.h:

(JSC::Heap::markedSpace):
(JSC::Heap::forEachCell):
(JSC::Heap::forEachBlock):
(JSC::Heap::sizeClassFor):
(JSC::Heap::allocate):

jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::recompileAllJSFunctions):
(JSC::JSGlobalData::releaseExecutableMemory):

Source/WebCore:

ForwardingHeaders/heap/AllocationSpace.h: Removed.

6:49 PM Changeset in webkit [95506] by commit-queue@webkit.org

8 edits in trunk/Source/WebCore

[chromium] ContentLayer's texture updater deleted during paint when compositing turns off in the middle of paint
https://bugs.webkit.org/show_bug.cgi?id=68405

Patch by James Robinson <jamesr@chromium.org> on 2011-09-19
Reviewed by Kenneth Russell.

Make TiledLayerChromium's textureUpdater refcounted and hold an explicit reference during paint in case
compositing is turned off halfway through a paint.

platform/graphics/chromium/ContentLayerChromium.h:
platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::create):

platform/graphics/chromium/ImageLayerChromium.h:
platform/graphics/chromium/LayerTextureUpdater.h:
platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterBitmap::create):
(WebCore::LayerTextureUpdaterSkPicture::create):

platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdate):

6:44 PM Changeset in webkit [95505] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

Errrk, missed stylebot comments in last commit.

runtime/StringPrototype.cpp:

(JSC::stringProtoFuncSplit):

6:41 PM Changeset in webkit [95504] by barraclough@apple.com

9 edits
3 adds in trunk

String#split is buggy
https://bugs.webkit.org/show_bug.cgi?id=68348

Reviewed by Sam Weinig.

Source/JavaScriptCore:

runtime/StringPrototype.cpp:

(JSC::jsStringWithReuse):

added helper function to reuse original JSString value.

(JSC::stringProtoFuncSplit):

Rewritten from the spec.

tests/mozilla/ecma/String/15.5.4.8-2.js:

(getTestCases):

This test is not ES5 compliant.

LayoutTests:

fast/js/script-tests/string-split-conformance.js: Added.
fast/js/string-split-conformance-expected.txt: Added.
fast/js/string-split-conformance.html: Added.
- Added new Layout test based on:

http://stevenlevithan.com/demo/split.cfm

sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T6-expected.txt:
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T7-expected.txt:
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T8-expected.txt:
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T9-expected.txt:
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A2_T7-expected.txt:
- Check in failing results for these 5 tests; they are all wrong (see https://bugs.ecmascript.org/show_bug.cgi?id=61).

6:21 PM Changeset in webkit [95503] by ggaren@apple.com

5 edits in trunk/Source/JavaScriptCore

Removed lots of friend declarations from JSCell, so we can more
effectively make use of private and protected.

Reviewed by Sam Weinig.

runtime/JSCell.h: Removed MSVCBugWorkaround because it was a lot of

confusion for not much safety.
(JSC::JSCell::operator new): Made this public because it is used by a
few clients, and not really dangerous.

runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):
(JSC::JSObject::getPropertySpecificValue):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::seal):
(JSC::JSObject::freeze):
(JSC::JSObject::preventExtensions):
(JSC::JSObject::removeDirect):
(JSC::JSObject::createInheritorID):
(JSC::JSObject::allocatePropertyStorage):
(JSC::JSObject::getOwnPropertyDescriptor):

runtime/JSObject.h:

(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectLocation):
(JSC::JSObject::hasCustomProperties):
(JSC::JSObject::hasGetterSetterProperties):
(JSC::JSObject::isSealed):
(JSC::JSObject::isFrozen):
(JSC::JSObject::isExtensible):
(JSC::JSObject::flattenDictionaryObject):
(JSC::JSObject::finishCreation):
(JSC::JSObject::prototype):
(JSC::JSObject::setPrototype):
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSCell::fastGetOwnProperty):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::transitionTo):
(JSC::JSObject::visitChildrenDirect): Changed all use of m_structure to
structure() / setStructure(), so we don't have to be a friend of JSCell.

runtime/Structure.h:

(JSC::JSCell::setStructure): Added, to avoid direct access by JSObject
to JSCell::m_structure.

6:20 PM Changeset in webkit [95502] by macpherson@chromium.org

17 edits in trunk/Source/WebCore

Eliminate Length::undefinedLength = -1 and replace with Undefined LengthType.
https://bugs.webkit.org/show_bug.cgi?id=68057

Reviewed by Darin Adler.

There appear to be many cases where -1 is actually a valid Length.
Encoding the validity of Length separately to the value is a natural solution.

No new tests / no behavioral changes.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):

platform/Length.h:

(WebCore::Length::Length):
(WebCore::Length::value):
(WebCore::Length::calcValue):
(WebCore::Length::calcMinValue):
(WebCore::Length::calcFloatValue):
(WebCore::Length::isUndefined):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):

rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):

rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):

rendering/RenderImage.cpp:

(WebCore::RenderImage::isLogicalWidthSpecified):
(WebCore::RenderImage::isLogicalHeightSpecified):

rendering/RenderListBox.cpp:

(WebCore::RenderListBox::computePreferredLogicalWidths):

rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::computePreferredLogicalWidths):

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computePreferredLogicalWidths):

rendering/RenderSlider.cpp:

(WebCore::RenderSlider::computePreferredLogicalWidths):

rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computePreferredLogicalWidths):

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::initialMaxSize):

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computePreferredLogicalWidths):

6:04 PM Changeset in webkit [95501] by abarth@webkit.org

33 edits in trunk

Always enable ENABLE(EVENTSOURCE)
https://bugs.webkit.org/show_bug.cgi?id=68414

Reviewed by Eric Seidel.

Source/cmake/OptionsEfl.cmake:
Source/cmake/OptionsWinCE.cmake:
Source/cmakeconfig.h.cmake:
configure.ac:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

EventSource seems to be here to stay. This patch makes WebKit more
hackable by removing this ENABLE macro, as discussed on webkit-dev.

Configurations/FeatureDefines.xcconfig:
GNUmakefile.am:
bindings/cpp/WebDOMEventTarget.cpp:

(toWebKit):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::eventSource):

bindings/js/JSEventSourceCustom.cpp:
bindings/js/JSEventTarget.cpp:

(WebCore::toJS):
(WebCore::toEventTarget):

bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::eventSource):

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

features.pri:
page/DOMWindow.idl:
page/EventSource.cpp:
page/EventSource.h:
page/EventSource.idl:
workers/WorkerContext.idl:

Source/WebKit/chromium:

features.gypi:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Tools:

Scripts/build-webkit:

WebKitLibraries:

win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

5:56 PM Changeset in webkit [95500] by levin@chromium.org

4 edits in trunk/Tools

Sheriffbot rollout should be more intuitive.
https://bugs.webkit.org/show_bug.cgi?id=68415

Reviewed by Adam Barth.

Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args and a few others cases.
Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.

5:38 PM Changeset in webkit [95499] by levin@chromium.org

3 edits in trunk/Tools

check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
https://bugs.webkit.org/show_bug.cgi?id=68391

Reviewed by Darin Adler.

Scripts/webkitpy/style/checkers/cpp.py: Skip asm lines when doing style checks on a line.
Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.

5:35 PM Changeset in webkit [95498] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

Enable JSC_MULTIPLE_THREADS for OS(QNX).
https://bugs.webkit.org/show_bug.cgi?id=68047

Patch by Eli Fidler <efidler@rim.com> on 2011-09-19
Reviewed by Daniel Bates.

SA_RESTART was required for SIGUSR2-based debugging, but is not
present on QNX. This debugging doesn't seem critical to
JSC_MULTIPLE_THREADS, so allow it to proceed.

heap/MachineStackMarker.cpp:

(JSC::MachineThreads::Thread::Thread):
(JSC::getPlatformThreadRegisters):
(JSC::otherThreadStackPointer):
(JSC::freePlatformThreadRegisters):

wtf/Platform.h: enable PTHREADS for OS(QNX)

5:19 PM Changeset in webkit [95497] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix a use-after-free: clear the fullscreen change event target queue at
detach time, rather than at destruction time. If this isn't done, it's
possible for the event target queue to be the only thing that
references the document. Then when the document is popped off the queue
and dereferenced in Document::fullScreenChangeDelayTimerFired, the
document is destroyed and the subsequent access to
m_fullScreenChangeEventTargetQueue.isEmpty() accesses free'd memory.
https://bugs.webkit.org/show_bug.cgi?id=67960

Patch by Jeremy Apthorp <jeremya@chromium.org> on 2011-09-19
Reviewed by Adam Barth.

dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::detach):

4:50 PM Changeset in webkit [95496] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Windows build fix.

4:49 PM Changeset in webkit [95495] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Suppress flakey test on windows in Chromium gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=68408

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-09-19
Reviewed by Adam Barth.

tests/InnerGestureRecognizerTest.cpp:

(TEST_F):

4:48 PM Changeset in webkit [95494] by commit-queue@webkit.org

5 edits in trunk

Unreviewed, rolling out r95482.
http://trac.webkit.org/changeset/95482
https://bugs.webkit.org/show_bug.cgi?id=68410

Broke chromium webkit-tests (Requested by dslomov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

Source/WebCore:

platform/image-encoders/skia/JPEGImageEncoder.cpp:

(WebCore::RGBAtoRGB):

LayoutTests:

fast/canvas/webgl/premultiplyalpha-test-expected.txt:
fast/canvas/webgl/premultiplyalpha-test.html:

4:15 PM Changeset in webkit [95493] by oliver@apple.com

14 edits
3 adds in trunk/Source

Refactor Heap allocation logic into separate AllocationSpace class
https://bugs.webkit.org/show_bug.cgi?id=68409

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

This patch hoists direct manipulation of the MarkedSpace and related
data out of Heap and into a separate class. This will allow us to
have multiple allocation spaces in future, so easing the way towards
having GC'd backing stores for objects.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.exp:
JavaScriptCore.gypi:
JavaScriptCore.pro:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
debugger/Debugger.cpp:

(JSC::Debugger::recompileAllJSFunctions):

heap/AllocationSpace.cpp: Added.

(JSC::AllocationSpace::tryAllocate):
(JSC::AllocationSpace::allocateSlowCase):
(JSC::AllocationSpace::allocateBlock):
(JSC::AllocationSpace::freeBlocks):
(JSC::TakeIfEmpty::TakeIfEmpty):
(JSC::TakeIfEmpty::operator()):
(JSC::TakeIfEmpty::returnValue):
(JSC::AllocationSpace::shrink):

heap/AllocationSpace.h: Added.

(JSC::AllocationSpace::AllocationSpace):
(JSC::AllocationSpace::blocks):
(JSC::AllocationSpace::sizeClassFor):
(JSC::AllocationSpace::setHighWaterMark):
(JSC::AllocationSpace::highWaterMark):
(JSC::AllocationSpace::canonicalizeBlocks):
(JSC::AllocationSpace::resetAllocator):
(JSC::AllocationSpace::forEachCell):
(JSC::AllocationSpace::forEachBlock):
(JSC::AllocationSpace::allocate):

heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::clearMarks):
(JSC::Heap::sweep):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrink):

heap/Heap.h:

(JSC::Heap::objectSpace):
(JSC::Heap::sizeClassForObject):
(JSC::Heap::allocate):

jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::recompileAllJSFunctions):
(JSC::JSGlobalData::releaseExecutableMemory):

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Adding a forwarding header.

ForwardingHeaders/heap/AllocationSpace.h: Added.

4:13 PM Changeset in webkit [95492] by alexis.menard@openbossa.org

4 edits in trunk/Source/WebKit2

[Qt] Unreviewed coding style fix.

UIProcess/API/qt/qdesktopwebview.h:
UIProcess/API/qt/qtouchwebpage.h:
UIProcess/API/qt/qweberror.h:

4:04 PM Changeset in webkit [95491] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit/chromium

Expose AXObjectCache methods so that WebAccessibilityCache
can be deleted.
https://bugs.webkit.org/show_bug.cgi?id=68225

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-19
Reviewed by Dimitri Glazkov.

This patch exposes the functionality needed from AXObjectCache
with new methods in WebAccessibilityObject and WebDocument.
Next, Chromium will be updated to use only these methods and
not WebAccessibilityCache. Then, WebAccessibilityCache can be
deleted from WebKit.

public/WebAccessibilityObject.h:
public/WebDocument.h:
src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::enableAccessibility):
(WebKit::WebAccessibilityObject::accessibilityEnabled):
(WebKit::WebAccessibilityObject::axID):

src/WebDocument.cpp:

(WebKit::WebDocument::accessibilityObject):
(WebKit::WebDocument::accessibilityObjectFromID):

4:02 PM Changeset in webkit [95490] by bbudge@chromium.org

4 edits in trunk/Source/WebKit/chromium

Perform HTTP method and header validation in AssociatedURLLoader for
requests coming from untrusted code (eg. Native Client in Chrome). Use
the same code as XMLHttpRequest to reduce code duplication and have
behavior identical to XHR in Javascript. Add an 'untrustedHTTP' option
to WebURLLoaderOptions, which AssociatedURLLoader can use to determine
if it should check the request method and headers.
https://bugs.webkit.org/show_bug.cgi?id=67655

Reviewed by Darin Fisher.

public/WebURLLoaderOptions.h:

(WebKit::WebURLLoaderOptions::WebURLLoaderOptions):

src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::ClientAdapter::setDelayedError):
(WebKit::AssociatedURLLoader::loadAsynchronously):

tests/AssociatedURLLoaderTest.cpp:

(WebKit::AssociatedURLLoaderTest::CheckMethodFails):
(WebKit::AssociatedURLLoaderTest::CheckHeaderFails):
(WebKit::AssociatedURLLoaderTest::CheckFails):
(WebKit::TEST_F):

3:57 PM Changeset in webkit [95489] by abarth@webkit.org

8 edits
2 adds in trunk

[V8] document.all gets confused about its prototype chain
https://bugs.webkit.org/show_bug.cgi?id=68393

Reviewed by Eric Seidel.

Source/WebCore:

GetRealNamedPropertyInPrototypeChain doesn't call interceptors, so it's
not a good idea to use its return value. It turns out that all the
callers of the API only cared about whether it returns a null handle.

Test: http/tests/security/document-all.html

bindings/v8/V8Collection.h:

(WebCore::collectionNamedPropertyGetter):

bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyDeleter):
(WebCore::V8DOMStringMap::namedPropertySetter):

bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore::V8HTMLAllCollection::namedPropertyGetter):

bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::V8HTMLCollection::namedPropertyGetter):

bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::V8NamedNodeMap::namedPropertyGetter):

bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::storageSetter):

LayoutTests:

Test how document.all behaves when you change its prototype chain.

http/tests/security/document-all-expected.txt: Added.
http/tests/security/document-all.html: Added.

3:56 PM Changeset in webkit [95488] by abarth@webkit.org

3 edits
3 adds in trunk

Named property confusion with proto
https://bugs.webkit.org/show_bug.cgi?id=68221

Reviewed by Eric Seidel.

Source/WebCore:

The proto property is super magical because it's not a real named
property and it has higher precedence than even interceptors. This
confuses this check, which is meant to detech which names will get
handled by our interceptor.

Test: http/tests/security/window-named-proto.html

bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedSecurityCheck):

LayoutTests:

http/tests/security/resources/innocent-victim-with-iframe.html: Added.
http/tests/security/window-named-proto-expected.txt: Added.
http/tests/security/window-named-proto.html: Added.

3:54 PM Changeset in webkit [95487] by abarth@webkit.org

9 edits in trunk/Source

Rename ENABLE(OPENTYPE_SANITIZER) to USE(OPENTYPE_SANITIZER)
https://bugs.webkit.org/show_bug.cgi?id=68292

Reviewed by Eric Seidel.

Source/WebCore:

OpenType Sanitizer is a library for sanitizing type and not a feature.
Therefore this macro should say that we USE the library.

platform/graphics/WOFFFileFormat.cpp:
platform/graphics/WOFFFileFormat.h:
platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

platform/graphics/opentype/OpenTypeSanitizer.cpp:
platform/graphics/opentype/OpenTypeSanitizer.h:
platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):
(WebCore::FontCustomPlatformData::supportsFormat):

Source/WebKit/chromium:

features.gypi:

3:53 PM Changeset in webkit [95486] by abarth@webkit.org

8 edits
1 delete in trunk/Source/WebCore

Remove APPLICATION_CACHE_DYNAMIC_ENTRIES and associated code
https://bugs.webkit.org/show_bug.cgi?id=68407

Reviewed by Eric Seidel.

As discussed on webkit-dev, no one appears to be using this code.

GNUmakefile.list.am:
UseJSC.cmake:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSBindingsAllInOne.cpp:
bindings/js/JSDOMApplicationCacheCustom.cpp: Removed.

3:32 PM Changeset in webkit [95485] by Adam Roben

2 edits in trunk/Source/JavaScriptCore

Windows build fix after r95310

JavaScriptCore.vcproj/testRegExp/testRegExpCommon.vsprops: Added

include\private\JavaScriptCore to the include path so DFGIntrinsic.h can be found.

3:27 PM Changeset in webkit [95484] by fpizlo@apple.com

14 edits in trunk/Source/JavaScriptCore

DFG speculation failures should act as additional value profiles
https://bugs.webkit.org/show_bug.cgi?id=68335

Reviewed by Oliver Hunt.

This adds slow-case counters to the old JIT. It also ensures that
negative zero in multiply is handled carefully. The old JIT
previously took slow path if the result of a multiply was zero,
which, without any changes, would cause the DFG to think that
every such multiply produced a double result.

This also fixes a bug in the old JIT's handling of decrements. It
would take the slow path if the result was zero, but not if it
underflowed.

By itself, this would be a 1% slow-down on V8 and Kraken. But then
I wrote optimizations in the DFG that take advantage of this new
information. It's no longer the case that every multiply needs to
do a check for negative zero; it only happens if the negative
zero is ignored.

This results in a 12% speed-up on v8-crypto, for a 1.4% geomean
speed-up in V8. It's mostly neutral on Kraken. I can see an
0.5% slow-down and it appears to be significant.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::resetRareCaseProfiles):
(JSC::CodeBlock::dumpValueProfiles):

bytecode/CodeBlock.h:
bytecode/ValueProfile.h:

(JSC::RareCaseProfile::RareCaseProfile):
(JSC::getRareCaseProfileBytecodeOffset):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::GPRTemporary::GPRTemporary):

dfg/DFGJITCodeGenerator.h:
dfg/DFGNode.h:
dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::performNodeCSE):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):

jit/JIT.h:

(JSC::JIT::linkDummySlowCase):

jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_dec):
(JSC::JIT::compileBinaryArithOp):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):

jit/JITInlineMethods.h:

(JSC::JIT::addSlowCase):

3:26 PM Changeset in webkit [95483] by commit-queue@webkit.org

11 edits
2 deletes in trunk/Source

Unreviewed, rolling out r95385 and r95457.
http://trac.webkit.org/changeset/95385
http://trac.webkit.org/changeset/95457
https://bugs.webkit.org/show_bug.cgi?id=68395

Broke chromium browser_tests (Requested by dslomov on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

Source/WebCore:

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::disposeContextHandles):
(WebCore::V8DOMWindowShell::initContextIfNeeded):

bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):

bindings/v8/V8IsolatedContext.h:
loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::didCreateScriptContextForFrame):
(WebCore::EmptyFrameLoaderClient::didDestroyScriptContextForFrame):
(WebCore::EmptyFrameLoaderClient::didCreateIsolatedScriptContext):

loader/FrameLoaderClient.h:

Source/WebKit/chromium:

public/WebFrameClient.h:

(WebKit::WebFrameClient::didCreateIsolatedScriptContext):

src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateScriptContextForFrame):
(WebKit::FrameLoaderClientImpl::didDestroyScriptContextForFrame):
(WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext):

src/FrameLoaderClientImpl.h:
tests/WebFrameTest.cpp:

(WebKit::TEST_F):

tests/data/context_notifications_test.html: Removed.
tests/data/context_notifications_test_frame.html: Removed.

3:23 PM Changeset in webkit [95482] by commit-queue@webkit.org

5 edits in trunk

Fix nonpremultiplied webgl toDataURL to jpeg
https://bugs.webkit.org/show_bug.cgi?id=68366

Source/WebCore:

The canvas spec says that toDataURL to formats without an alpha must
be "composited onto a solid black background using the source-over
operator." Do that.

Patch by John Bauman <jbauman@chromium.org> on 2011-09-19
Reviewed by Kenneth Russell.

platform/image-encoders/skia/JPEGImageEncoder.cpp:

(WebCore::RGBAtoRGB):

LayoutTests:

Update the premultiplyalpha-test from the WebGL conformance tests.

Patch by John Bauman <jbauman@chromium.org> on 2011-09-19
Reviewed by Kenneth Russell.

fast/canvas/webgl/premultiplyalpha-test-expected.txt:
fast/canvas/webgl/premultiplyalpha-test.html:

3:20 PM Changeset in webkit [95481] by Adam Roben

2 edits in trunk/Source/ThirdParty/ANGLE

Let Xcode 4 do its thang with ANGLE.xcodeproj

ANGLE.xcodeproj/project.pbxproj:

3:20 PM Changeset in webkit [95480] by Adam Roben

2 edits in trunk/Source/JavaScriptCore

Windows build fix after r94575

JavaScriptCore.vcproj/JavaScriptCore.sln: Relinearized project dependencies. testRegExp

now builds just before FindSafari.

2:56 PM Changeset in webkit [95479] by cmarrin@apple.com

4 edits
1 add in trunk/Source/WebCore

2011-09-19 Chris Marrin <cmarrin@apple.com>

Crash can occur when doing a PlatformCAAnimation::copy() with no valueFunction
https://bugs.webkit.org/show_bug.cgi?id=67510

Reviewed by Adam Roben.

Another fix to take care of one last crash when running pause-crash.html.
CACF can't deal with null valueFunctions, so avoid setting it when it doesn't
exist.

This also adds logic to the Windows Hook in LayerChangesFlusher to prevent it
from catching the null pointer exception generated by the pause-crash.html test
before this bug was fixed. Windows was ignoring the exception, so the testcase
would appear to succeed, even though it should have crashed.

This is a resubmission of http://trac.webkit.org/changeset/95243 with a build fix.

WebCore.vcproj/WebCore.vcproj:
platform/graphics/ca/win/LayerChangesFlusher.cpp: (WebCore::LayerChangesFlusher::hookCallback):
platform/graphics/ca/win/PlatformCAAnimationWin.cpp: (PlatformCAAnimation::copy):
platform/win/StructuredExceptionHandlerSupressor.h: Added. (WebCore::StructuredExceptionHandlerSupressor::StructuredExceptionHandlerSupressor): (WebCore::StructuredExceptionHandlerSupressor::~StructuredExceptionHandlerSupressor):

2:51 PM Changeset in webkit [95478] by rniwa@webkit.org

3 edits
2 adds in trunk

Incorrect selection with absolutely positioned div
https://bugs.webkit.org/show_bug.cgi?id=39503

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

The bug was caused by a false assumption in RenderBlock::positionForPoint. Because the last child box
can be positioned, floated, invisible, etc..., we can't always trust last child's logicalTop to tell us
whether a given point is inside or below the last child box.

Fixed the bug by using the last hit-test candidate instead.

Test: editing/selection/block-with-positioned-lastchild.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionForPoint):

LayoutTests:

Added a regression test for placing the caret inside a block with multiple logical lines
with an absolutely positioned last child. WebKit should place the caret on the left of the first line
(instead of after the last line) when the user clicks on the left of the first line.

editing/selection/block-with-positioned-lastchild-expected.txt: Added.
editing/selection/block-with-positioned-lastchild.html: Added.

2:48 PM Changeset in webkit [95477] by inferno@chromium.org

1 edit
15 adds in trunk/LayoutTests

Unreviewed. Chromium Rebaselines for r95461.

platform/chromium-linux/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
platform/chromium-linux/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
platform/chromium-linux/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
platform/chromium-linux/fast/table/table-row-before-after-content-around-block-expected.png: Added.
platform/chromium-linux/fast/table/table-row-before-after-content-around-table-expected.png: Added.
platform/chromium-mac/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
platform/chromium-mac/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
platform/chromium-mac/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
platform/chromium-mac/fast/table/table-row-before-after-content-around-block-expected.png: Added.
platform/chromium-mac/fast/table/table-row-before-after-content-around-table-expected.png: Added.
platform/chromium-win/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
platform/chromium-win/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
platform/chromium-win/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
platform/chromium-win/fast/table/table-row-before-after-content-around-block-expected.png: Added.
platform/chromium-win/fast/table/table-row-before-after-content-around-table-expected.png: Added.

2:47 PM Changeset in webkit [95476] by andersca@apple.com

3 edits in trunk/Source/WebKit/mac

Fix crashes when running WebKit1 tests.

-[WebView _mustDrawUnionedRect:singleRects:count:] was removed, so just put back the
equivalent code directly into -[WebHTMLView drawRect:].

WebView/WebHTMLView.mm:

(-[WebHTMLView drawRect:]):

WebView/WebViewInternal.h:

2:28 PM Changeset in webkit [95475] by commit-queue@webkit.org

8 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r95466.
http://trac.webkit.org/changeset/95466
https://bugs.webkit.org/show_bug.cgi?id=68389

Incorrect version of the patch. (Requested by mhahnenberg on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
runtime/JSCell.cpp:

(JSC::JSCell::toPrimitive):

runtime/JSCell.h:

(JSC::JSCell::JSValue::toPrimitive):

runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::toPrimitive):

runtime/JSNotAnObject.h:
runtime/JSObject.h:
runtime/JSString.h:

2:25 PM Changeset in webkit [95474] by andersca@apple.com

5 edits in trunk/Source/WebKit/mac

Remove the last remains of viewless WebKit1
https://bugs.webkit.org/show_bug.cgi?id=68388

Reviewed by Darin Adler.

WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::forceLayoutForNonHTML):
Remove null check.

WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
Remove usesDocumentViews parameter and checks.

(-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]):
Add an assertion that usesDocumentViews is always true.

(-[WebView _isUsingAcceleratedCompositing]):
Remove usesDocumentViews check.

(-[WebView _isSoftwareRenderable]):
Remove usesDocumentViews check.

(-[WebView initWithFrame:frameName:groupName:]):
Remove usesDocumentViews parameter and always pass YES to the _initWithFrame method.

(-[WebView initWithCoder:]):
Remove usesDocumentViews parameter.

(-[WebView _frameViewAtWindowPoint:]):
Remove usesDocumentViews check.

WebView/WebViewData.h:

Remove usesDocumentViews ivar.

WebView/WebViewPrivate.h:

Remove usesDocumentViews parameters.

2:10 PM Changeset in webkit [95473] by inferno@chromium.org

2 edits in branches/chromium/874/Source/WebCore/loader

Merge 95259 - Fragment navigations should interrupt a provisional load of a different document
BUG=86758
Review URL: http://codereview.chromium.org/7945015

2:09 PM Changeset in webkit [95472] by alexis.menard@openbossa.org

12 edits in trunk/Source/WebKit2

[Qt][WK2] Make loading errors API easier to use.
https://bugs.webkit.org/show_bug.cgi?id=68357

Reviewed by Tor Arne Vestbø.

Make the API to get loading errors easier to use. 95197 introduced
a QJSValue API that is a bit opaque for the client code. Rather than
using a dedicated object, we can just pass the needed information as
parameters of the slot.

UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::loadDidFail):

UIProcess/API/qt/qdesktopwebview.h:
UIProcess/API/qt/qdesktopwebview_p.h:
UIProcess/API/qt/qtouchwebpage.h:
UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:

(tst_CommonViewTests::loadNonexistentFileUrl):

UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::WebViewAbstraction):
(WebViewAbstraction::touchViewLoadFailed):
(WebViewAbstraction::desktopViewLoadFailed):

UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::loadDidFail):

UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::loadDidFail):

UIProcess/qt/TouchViewInterface.h:
UIProcess/qt/ViewInterface.h:

2:05 PM Changeset in webkit [95471] by dimich@chromium.org

5 edits
4 adds in trunk

[Chromium] Crash after magic iframe transfer for Pepper/NaCl plugins.
https://bugs.webkit.org/show_bug.cgi?id=68267
Make adoptNode() to not enable live iframe transfer when the iframe's subtree contains plugins.

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/frames/iframe-reparenting-embed-elements.html

dom/Document.cpp:

(WebCore::Document::adoptNode):

html/HTMLFrameElementBase.cpp:

(WebCore::hasPluginElements):
(WebCore::HTMLFrameElementBase::canRemainAliveOnRemovalFromTree):

html/HTMLFrameElementBase.h:

LayoutTests:

fast/frames/iframe-reparenting-embed-elements-expected.txt: Added.
fast/frames/iframe-reparenting-embed-elements.html: Added.
fast/frames/resources/iframe-reparenting-embed-frame1.html: Added.
fast/frames/resources/iframe-reparenting-embed-iframe.html: Added.

1:55 PM Changeset in webkit [95470] by andersca@apple.com

6 edits
1 delete in trunk/Source/WebKit

Remove WebViewEventHandling.mm
https://bugs.webkit.org/show_bug.cgi?id=68387

Reviewed by Adam Roben.

../..:

Remove WebViewEventHandling.mm from the Xcode project.

WebKit.xcodeproj/project.pbxproj:

../../mac:

WebViewEventHandling.mm was all about event handling in viewless WebKit, so rip it out since
we're getting rid of viewless WebKit1.

WebView/WebView.mm:

(-[WebView _close]):

WebView/WebViewData.h:
WebView/WebViewEventHandling.mm: Removed.
WebView/WebViewInternal.h:

1:52 PM Changeset in webkit [95469] by inferno@chromium.org

6 edits in branches/chromium/874/Source/WebCore/rendering

Merge 95461 - Child not placed correctly when beforeChild (table part)
has both :before, :after content.
BUG=95520
Review URL: http://codereview.chromium.org/7946014

1:48 PM Changeset in webkit [95468] by inferno@chromium.org

3 edits in branches/chromium/874/Source/WebCore/rendering

Merge 95462 - Source/WebCore: Issues with merging ruby bases.
BUG=94809
Review URL: http://codereview.chromium.org/7941019

1:39 PM Changeset in webkit [95467] by andersca@apple.com

6 edits in trunk/Source/WebKit/mac

Remove -[WebView _selectionChanged] and -[WebView _setTooltip:]
https://bugs.webkit.org/show_bug.cgi?id=68385

Reviewed by Adam Roben.

Move these functions back into the respective clients and remove usesDocumentViews checks.

WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::setToolTip):

WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::respondToChangedSelection):

WebView/WebView.mm:
WebView/WebViewEventHandling.mm:
WebView/WebViewInternal.h:

1:32 PM Changeset in webkit [95466] by mhahnenberg@apple.com

8 edits in trunk/Source/JavaScriptCore

Remove toPrimitive from JSCell
https://bugs.webkit.org/show_bug.cgi?id=67875

Reviewed by Geoffrey Garen.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
runtime/JSCell.cpp:

(JSC::JSCell::toPrimitive):

runtime/JSCell.h:

runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::defaultValue):

runtime/JSNotAnObject.h:
runtime/JSObject.h:
runtime/JSString.h:

(JSC::JSValue::toPrimitive):

1:27 PM Changeset in webkit [95465] by andersca@apple.com

2 edits in trunk/Source/WebKit/mac

Begin removing -[WebView _usesDocumentCalls] from WebView.mm
https://bugs.webkit.org/show_bug.cgi?id=68383

Reviewed by Adam Roben.

Remove checks and begin assuming that -[WebView _usesDocumentViews] always
returns true, since viewless WebKit1 has been abandoned.

WebView/WebView.mm:

(-[WebView selectedFrame]):
(-[WebView setHostWindow:]):
(-[WebView acceptsFirstResponder]):
(-[WebView becomeFirstResponder]):
(-[WebView _webcore_effectiveFirstResponder]):
(-[WebView setNextKeyView:]):
(-[WebView setHoverFeedbackSuspended:]):

1:22 PM Changeset in webkit [95464] by levin@chromium.org

1 edit in branches/chromium/874/Source/WebKit/chromium/src/WorkerFileWriterCallbacksBridge.cpp

Merge 95012 - [chromium] Remove AllowCrossThreadAccess for WorkerFileWriterCallbacksBridge.
https://bugs.webkit.org/show_bug.cgi?id=67943

Reviewed by Adam Barth.

src/WorkerFileWriterCallbacksBridge.cpp: Removed AllowCrossThreadAccess

allowing the automatic ref counting to work. This was previous needed when
the ref counting wasn't working but that was fixed in r94986. Note that the
design was to have ref counting since the methods take PassRefPtr and the
class is ThreadSafeRefCounted. (Ideally we have noticed this flaw when
adding in AllowCrossThreadAccess.)
(WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::didWrite):
(WebKit::WorkerFileWriterCallbacksBridge::didFail):
(WebKit::WorkerFileWriterCallbacksBridge::didTruncate):
(WebKit::WorkerFileWriterCallbacksBridge::postInitToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToWorkerThread):

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/7942006

1:20 PM Changeset in webkit [95463] by levin@chromium.org

2 edits in branches/chromium/874/Source/WebCore/platform

Merge 94986 - Make the ThreadSafeRefCounted support in CrossThreadCopier work for T*.
https://bugs.webkit.org/show_bug.cgi?id=67947

Reviewed by Adam Barth.

The changes are tested by compiling and added compile asserts to do some verification as well.

platform/CrossThreadCopier.cpp:

Added some compile asserts to verify various match and non-matches for CrossThreadCopier.

platform/CrossThreadCopier.h:

Added a typedef to convert T* to T, just like the typedef's to remove RefPtr and PassRefPtr.
Added a compile assert to verify that only one of the typedefs did anything.
(CrossThreadCopierBase<false, true, T>::copy): Remove "get" as it is unnecessary.
It shouldn't have been here (PassRefPtr and RefPtr easily and sometimes more efficiently
convert to PassRefPtr without get). Also, a raw pointer doesn't have a get() method.

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/7946013

1:20 PM Changeset in webkit [95462] by inferno@chromium.org

5 edits
2 adds in trunk

Source/WebCore: Issues with merging ruby bases.
https://bugs.webkit.org/show_bug.cgi?id=67240

Reviewed by James Robinson.

1) Change fromBeforeChild to beforeChild to match
webkit rendering naming conventions.
2) Add assert to verify ruby base is indeed emptied
after collecting all children in a single base.
3) Fix condition in mergeBlockChildren to bail out only
when we have no children and there is no work to merge
children to toBase.

Test: fast/ruby/ruby-overhang-crash.html

rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::moveChildren):
(WebCore::RenderRubyBase::moveInlineChildren):
(WebCore::RenderRubyBase::moveBlockChildren):
(WebCore::RenderRubyBase::mergeBlockChildren):

rendering/RenderRubyBase.h:
rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::removeChild):

LayoutTests: Issues with merging ruby bases.
https://bugs.webkit.org/show_bug.cgi?id=67240

Reviewed by James Robinson.

ASSERTION FAILED: !needsLayout() in RenderRubyRun::getOverhang.

fast/ruby/ruby-overhang-crash-expected.txt: Added.
fast/ruby/ruby-overhang-crash.html: Added.

1:17 PM Changeset in webkit [95461] by inferno@chromium.org

8 edits
15 adds in trunk

Child not placed correctly when beforeChild (table part)
has both :before, :after content.
https://bugs.webkit.org/show_bug.cgi?id=67656

Reviewed by James Robinson.

Source/WebCore:

Tests: fast/table/table-cell-before-after-content-around-table-block.html

fast/table/table-cell-before-after-content-around-table-row.html
fast/table/table-cell-before-after-content-around-table.html
fast/table/table-row-before-after-content-around-block.html
fast/table/table-row-before-after-content-around-table.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):

Use the new helper functions findAfterContentRenderer, anonymousContainer.
Rename anonymousChild to better name - beforeChildAnonymousContainer.

rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild):
When adding a new child, if beforeChild is a table part(
Table/TableSection/TableRow), we need to check if both
:before, :after content are shoved in one of the anonymous child.
If yes, we need to split the :before, :after content before adding
newChild. Easiest approach is to destroy the :before content, then add
the newChild and then call updateBeforeAfterContent to recreate the
:before content.

rendering/RenderObject.h:

(WebCore::RenderObject::findBeforeContentRenderer): same as
beforePseudoElementRenderer, but ignores text childs since they are
sequentially added.
(WebCore::RenderObject::findAfterContentRenderer): same.
(WebCore::RenderObject::anonymousContainer):
(WebCore::objectIsRelayoutBoundary):

rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild): use the new helpers and functionally
correct functions - findAfterContentRenderer, anonymousContainer. previous
implementation was wrong since it would not go inside, if :after content
is embedded deeper than one level.

rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::addChild): same.

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild): same.

LayoutTests:

fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
fast/table/table-cell-before-after-content-around-table-block-expected.txt: Added.
fast/table/table-cell-before-after-content-around-table-block.html: Added.
fast/table/table-cell-before-after-content-around-table-expected.png: Added.
fast/table/table-cell-before-after-content-around-table-expected.txt: Added.
fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
fast/table/table-cell-before-after-content-around-table-row-expected.txt: Added.
fast/table/table-cell-before-after-content-around-table-row.html: Added.
fast/table/table-cell-before-after-content-around-table.html: Added.
fast/table/table-row-before-after-content-around-block-expected.png: Added.
fast/table/table-row-before-after-content-around-block-expected.txt: Added.
fast/table/table-row-before-after-content-around-block.html: Added.
fast/table/table-row-before-after-content-around-table-expected.png: Added.
fast/table/table-row-before-after-content-around-table-expected.txt: Added.
fast/table/table-row-before-after-content-around-table.html: Added.

1:09 PM Changeset in webkit [95460] by abarth@webkit.org

1 edit in branches/chromium/874/Source/WebCore/loader/FrameLoader.cpp

Manual merge of 94902 to 874 branch.

1:07 PM Changeset in webkit [95459] by andersca@apple.com

3 edits in trunk/Source/WebKit/mac

Remove calls to -[WebView _usesDocumentViews] from WebFrameLoaderClient.mm
https://bugs.webkit.org/show_bug.cgi?id=68379

Reviewed by Adam Roben.

Remove checks and begin assuming that -[WebView _usesDocumentViews] always
returns true, since viewless WebKit1 has been abandoned.

WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::hasHTMLView):
(WebFrameLoaderClient::dispatchDidCommitLoad):
(WebFrameLoaderClient::transitionToCommittedForNewPage):
(WebFrameLoaderClient::createFrame):

WebView/WebFrame.mm:

(-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
(-[WebFrame _hasSelection]):
(-[WebFrame _clearSelection]):
(-[WebFrame _shouldFlattenCompositingLayers:]):
(-[WebFrame _dragSourceEndedAt:operation:]):
(-[WebFrame frameView]):

12:46 PM Changeset in webkit [95458] by andersca@apple.com

3 edits in trunk/Source/WebKit/mac

Remove calls to -[WebView _usesDocumentViews]
https://bugs.webkit.org/show_bug.cgi?id=68377

Reviewed by Adam Roben.

Remove checks and begin assuming that -[WebView _usesDocumentViews] always
returns true, since viewless WebKit1 has been abandoned.

WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::windowResizerRect):
(WebChromeClient::invalidateContentsAndWindow):
(WebChromeClient::screenToWindow):
(WebChromeClient::windowToScreen):
(WebChromeClient::platformPageClient):
(WebChromeClient::scrollRectIntoView):
(WebChromeClient::print):

WebView/WebDataSource.mm:

(-[WebDataSource _receivedData:]):

12:44 PM Changeset in webkit [95457] by aa@chromium.org

2 edits in trunk/Source/WebKit/chromium

r95385 broke Chromium. Fix it.
https://bugs.webkit.org/show_bug.cgi?id=68378

Unreviewed, build fix.

src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
(WebKit::FrameLoaderClientImpl::willReleaseScriptContext):

12:38 PM Changeset in webkit [95456] by jochen@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed, build fix

It's not enough to disable clang plugins.

gyp_webkit:

12:33 PM Changeset in webkit [95455] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Build fix.

12:19 PM Changeset in webkit [95454] by jochen@chromium.org

3 edits in trunk/Source/WebKit/chromium

[chromium] Disable clang when building chromium in WebKit
https://bugs.webkit.org/show_bug.cgi?id=68343

Reviewed by Adam Barth.

DEPS:
gyp_webkit:

12:14 PM Changeset in webkit [95453] by oliver@apple.com

9 edits
1 move
1 add
1 delete in trunk/Source/JavaScriptCore

Rename NewSpace.{h,cpp} to MarkedSpace.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=68376

Reviewed by Gavin Barraclough.

Renamed the the MarkedSpace files to match new name, and
updated the relevant references.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.gypi:
JavaScriptCore.pro:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
heap/Heap.h:
heap/MarkedSpace.cpp: Renamed from Source/JavaScriptCore/heap/NewSpace.cpp.

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::addBlock):
(JSC::MarkedSpace::removeBlock):
(JSC::MarkedSpace::resetAllocator):
(JSC::MarkedSpace::canonicalizeBlocks):

heap/MarkedSpace.h: Renamed from Source/JavaScriptCore/heap/NewSpace.h.

(JSC::MarkedSpace::waterMark):
(JSC::MarkedSpace::highWaterMark):
(JSC::MarkedSpace::setHighWaterMark):
(JSC::MarkedSpace::sizeClassFor):
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::forEachBlock):
(JSC::MarkedSpace::SizeClass::SizeClass):
(JSC::MarkedSpace::SizeClass::resetAllocator):
(JSC::MarkedSpace::SizeClass::canonicalizeBlock):

runtime/JSCell.h:

12:13 PM Changeset in webkit [95452] by commit-queue@webkit.org

5 edits in trunk/Source

[chromium] Gesture recognizer fires taptype only every other touch
down/up sequence https://bugs.webkit.org/show_bug.cgi?id=68368

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-09-19
Reviewed by Adam Barth.

Source/WebCore:

The addition of doubletap detection to the gesture recognizer missed some of the
outgoing edges in the recognizer state machine. This change simplifies the logic
and handles all outgoing edges.

platform/chromium/GestureRecognizerChromium.cpp:

(WebCore::GestureRecognizerChromium::GestureRecognizerChromium):
(WebCore::GestureRecognizerChromium::isInSecondClickTimeWindow):
(WebCore::GestureRecognizerChromium::updateValues):
(WebCore::GestureRecognizerChromium::touchDown):
(WebCore::GestureRecognizerChromium::click):

platform/chromium/GestureRecognizerChromium.h:

Source/WebKit/chromium:

The addition of doubletap detection to the gesture recognizer missed some of the
outgoing edges in the recognizer state machine. Thsi change simplifies the logic
and handles all outgoing edges.

tests/InnerGestureRecognizerTest.cpp:

Additional tests added to ensure that all edges in the state
machine are accounted for.
(BuildablePlatformTouchEvent::BuildablePlatformTouchEvent):
(SimulateAndTestFirstClick):
(TEST_F):

11:59 AM Changeset in webkit [95451] by commit-queue@webkit.org

5 edits
2 adds in trunk

Fix xssauditor bypass with unterminated closing tag by making the HTMLSourceTracker
and the HTMLParser interact more closely with each other. HTMLParser should be
setting the end range for the token itself to account for buffering that the
HTMLSourceTracker can't know about, but there are a lot of paths that would need
updating. First step is to cover this one path.
https://bugs.webkit.org/show_bug.cgi?id=68281

Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-19
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag.html

html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::end):

html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::nextToken):

LayoutTests:

http/tests/security/xssAuditor/resources/echo-intertag.pl:
http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag.html: Added.

11:54 AM Changeset in webkit [95450] by oliver@apple.com

8 edits in trunk/Source/JavaScriptCore

Rename NewSpace to MarkedSpace
https://bugs.webkit.org/show_bug.cgi?id=68375

Reviewed by Gavin Barraclough.

Rename NewSpace to a more accurate name, and update all uses.
This patch doesn't rename the files themselves as that will
just make the patch appear bigger than it is.

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
heap/Heap.cpp:

(JSC::CountFunctor::TakeIfEmpty::TakeIfEmpty):
(JSC::CountFunctor::TakeIfEmpty::operator()):
(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::tryAllocate):
(JSC::Heap::allocateSlowCase):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
(JSC::Heap::isValidAllocation):
(JSC::Heap::shrink):

heap/Heap.h:

(JSC::Heap::markedSpace):
(JSC::Heap::sizeClassFor):
(JSC::Heap::allocate):

heap/NewSpace.cpp:

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::addBlock):
(JSC::MarkedSpace::removeBlock):
(JSC::MarkedSpace::resetAllocator):
(JSC::MarkedSpace::canonicalizeBlocks):

heap/NewSpace.h:

jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

11:45 AM Changeset in webkit [95449] by commit-queue@webkit.org

51 edits in trunk/Source

TextPosition refactoring: Merge ZeroBasedNumber and OneBasedNumber classes
https://bugs.webkit.org/show_bug.cgi?id=63541

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-09-19
Reviewed by Adam Barth.

Source/JavaScriptCore:

parser/SourceProvider.h:

(JSC::SourceProvider::startPosition):

wtf/text/TextPosition.h:

(WTF::OrdinalNumber::fromZeroBasedInt):
(WTF::OrdinalNumber::fromOneBasedInt):
(WTF::OrdinalNumber::OrdinalNumber):
(WTF::OrdinalNumber::zeroBasedInt):
(WTF::OrdinalNumber::oneBasedInt):
(WTF::OrdinalNumber::operator==):
(WTF::OrdinalNumber::operator!=):
(WTF::OrdinalNumber::first):
(WTF::OrdinalNumber::beforeFirst):
(WTF::TextPosition::TextPosition):
(WTF::TextPosition::minimumPosition):
(WTF::TextPosition::belowRangePosition):

Source/WebCore:

No new tests because this patch is not changing behavior.

bindings/js/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::JavaScriptCallFrame):

bindings/js/JavaScriptCallFrame.h:

(WebCore::JavaScriptCallFrame::create):
(WebCore::JavaScriptCallFrame::position):
(WebCore::JavaScriptCallFrame::update):

bindings/js/ScriptController.cpp:

(WebCore::ScriptController::eventHandlerLineNumber):

bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):

bindings/js/ScriptDebugServer.h:
bindings/js/ScriptSourceCode.h:

(WebCore::ScriptSourceCode::ScriptSourceCode):

bindings/js/StringSourceProvider.h:

(WebCore::StringSourceProvider::create):
(WebCore::StringSourceProvider::startPosition):
(WebCore::StringSourceProvider::StringSourceProvider):

bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::ScheduledAction):

bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::eventHandlerPosition):

bindings/v8/ScriptController.h:
bindings/v8/ScriptEventListener.cpp:

(WebCore::createAttributeEventListener):

bindings/v8/ScriptSourceCode.h:

(WebCore::ScriptSourceCode::ScriptSourceCode):
(WebCore::ScriptSourceCode::startPosition):

bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::V8LazyEventListener):

bindings/v8/V8LazyEventListener.h:

(WebCore::V8LazyEventListener::create):

bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::compileScript):
(WebCore::V8Proxy::evaluate):
(WebCore::V8Proxy::runScript):

bindings/v8/V8Proxy.h:
bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::evaluate):
(WebCore::WorkerContextExecutionProxy::runScript):

bindings/v8/WorkerContextExecutionProxy.h:
bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

dom/PendingScript.cpp:

(WebCore::PendingScript::releaseElementAndClear):

dom/PendingScript.h:

(WebCore::PendingScript::PendingScript):
(WebCore::PendingScript::startingPosition):
(WebCore::PendingScript::setStartingPosition):

dom/ScriptElement.cpp:

(WebCore::ScriptElement::prepareScript):

dom/ScriptElement.h:
dom/ScriptableDocumentParser.h:
dom/ViewportArguments.cpp:

(WebCore::parserLineNumber):

html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::lineNumber):
(WebCore::HTMLDocumentParser::textPosition):

html/parser/HTMLDocumentParser.h:
html/parser/HTMLInputStream.h:
html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::execute):
(WebCore::HTMLScriptRunner::runScript):

html/parser/HTMLScriptRunner.h:
html/parser/HTMLTreeBuilder.cpp:

(WebCore::uninitializedPositionValue1):
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::takeScriptToProcess):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):

html/parser/HTMLTreeBuilder.h:
inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::buildInitiatorObject):

platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::currentLine):
(WebCore::SegmentedString::currentColumn):
(WebCore::SegmentedString::setCurrentPosition):

platform/text/SegmentedString.h:
svg/SVGDocumentExtensions.cpp:

(WebCore::parserLineNumber):

xml/XMLErrors.cpp:

(WebCore::XMLErrors::XMLErrors):
(WebCore::XMLErrors::handleError):
(WebCore::XMLErrors::appendErrorMessage):

xml/XMLErrors.h:
xml/parser/MarkupTokenizerBase.h:

(WebCore::MarkupTokenizerBase::lineNumber):

xml/parser/NewXMLDocumentParser.cpp:

(WebCore::NewXMLDocumentParser::processScript):
(WebCore::NewXMLDocumentParser::textPosition):
(WebCore::NewXMLDocumentParser::lineNumber):

xml/parser/NewXMLDocumentParser.h:
xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::pushCurrentNode):
(WebCore::XMLDocumentParser::handleError):

xml/parser/XMLDocumentParser.h:
xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::PendingCallbacks::appendErrorCallback):
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::error):
(WebCore::XMLDocumentParser::lineNumber):
(WebCore::XMLDocumentParser::columnNumber):
(WebCore::XMLDocumentParser::textPosition):

xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::doEnd):
(WebCore::XMLDocumentParser::lineNumber):
(WebCore::XMLDocumentParser::columnNumber):
(WebCore::XMLDocumentParser::textPosition):
(WebCore::XMLDocumentParser::parse):
(WebCore::XMLDocumentParser::parseStartElement):

Source/WebKit/chromium:

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::executeScript):
(WebKit::WebFrameImpl::executeScriptInIsolatedWorld):
(WebKit::WebFrameImpl::executeScriptAndReturnValue):

11:36 AM Changeset in webkit [95448] by mitz@apple.com

28 edits
6 moves
1 add
2 deletes in trunk/Source

Source/JavaScriptCore: JavaScriptCore part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Renamed WTFMainThreadCaller to JSWTFMainThreadCaller.

wtf/mac/MainThreadMac.mm:

(WTF::initializeMainThreadPlatform):
(WTF::initializeMainThreadToProcessMainThreadPlatform):

Source/WebCore: WebCore part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Renamed AccessibilityObjectWrapper to WebAccessibilityObjectWrapper.
Renamed CascadeList to WebCascadeList.
Renamed CookieStorageObjCAdapter to WebCookieStorageObjCAdapter.
Renamed LanguageChangeObserver to WebLanguageChangeObserver.
Renamed ScrollAnimationHelperDelegate to WebScrollAnimationHelperDelegate.
Renamed ScrollbarPainterControllerDelegate to WebScrollbarPainterControllerDelegate.
Renamed ScrollbarPainterDelegate to WebScrollbarPainterDelegate.
Renamed ScrollbarPartAnimation to WebScrollbarPartAnimation.
Renamed ScrollbarPrefsObserver to WebScrollbarPrefsObserver.

WebCore.gyp/WebCore.gyp: Updated for the renaming of CascadeList to WebCascadeList.
WebCore.xcodeproj/project.pbxproj:
accessibility/AccessibilityObject.h:
accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::attachWrapper):

accessibility/mac/AccessibilityObjectMac.mm:
accessibility/mac/AccessibilityObjectWrapper.h: Removed.
accessibility/mac/AccessibilityObjectWrapper.mm: Removed.
accessibility/mac/WebAccessibilityObjectWrapper.h: Copied from Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.h.
accessibility/mac/WebAccessibilityObjectWrapper.mm: Copied from Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm.

(convertToNSArray):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapper accessibilityIndexOfChild:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):

platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

platform/mac/Language.mm:

(WebCore::platformDefaultLanguage):

platform/mac/ScrollAnimatorMac.h:
platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):

platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::ScrollbarThemeMac):

platform/network/mac/CookieStorageMac.mm:

(WebCore::startObservingCookieChanges):

Source/WebKit: WebKit part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Updated for the renaming of NonBlockingPanel to WebNonBlockingPanel.

English.lproj/WebJavaScriptTextInputPanel.nib/classes.nib: Removed.
English.lproj/WebJavaScriptTextInputPanel.nib/designable.nib: Added.
English.lproj/WebJavaScriptTextInputPanel.nib/info.nib: Removed.
English.lproj/WebJavaScriptTextInputPanel.nib/keyedobjects.nib:

Source/WebKit/mac: WebKit part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Renamed NonBlockingPanel to WebNonBlockingPanel.
Renamed ThreadEnabler to WebCocoaThreadingEnabler.
Renamed PDFPrefUpdatingProxy to WebPDFPrefUpdatingProxy.

Misc/WebIconDatabase.mm:

(+[WebCocoaThreadingEnabler enableThreading]):
(importToWebCoreFormat):

Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
Panels/WebAuthenticationPanel.h:
Panels/WebAuthenticationPanel.m: Renamed NonBlockingPanel to

WebNonBlockingPanel. Because Safari 5.1 uses NonBlockingPanel, this will
cause nightly builds to log an error message when showing the Safari
HTTP authentication sheet and disable the Quit command while the sheet
is disaplyed.

WebView/WebPDFView.mm:

(-[WebPDFView initWithFrame:]):
(-[WebPDFView _updatePreferencesSoon]):

Source/WebKit2: WebKit2 part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Renamed FullKeyboardAccessWatcher to WKFullKeyboardAccessWatcher.
Renamed AccessibilityWebPageObject to WKAccessibilityWebPageObject.

WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/mac/AccessibilityWebPageObject.h: Removed.
WebProcess/WebPage/mac/AccessibilityWebPageObject.mm: Removed.
WebProcess/WebPage/mac/WKAccessibilityWebPageObject.h: Copied from Source/WebKit2/WebProcess/WebPage/mac/AccessibilityWebPageObject.h.
WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm: Copied from Source/WebKit2/WebProcess/WebPage/mac/AccessibilityWebPageObject.mm.
WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::accessibilityRemoteObject):

WebProcess/mac/FullKeyboardAccessWatcher.h: Removed.
WebProcess/mac/FullKeyboardAccessWatcher.mm: Removed.
WebProcess/mac/WKFullKeyboardAccessWatcher.h: Copied from Source/WebKit2/WebProcess/mac/FullKeyboardAccessWatcher.h.
WebProcess/mac/WKFullKeyboardAccessWatcher.mm: Copied from Source/WebKit2/WebProcess/mac/FullKeyboardAccessWatcher.mm.

(+[WKFullKeyboardAccessWatcher fullKeyboardAccessEnabled]):

WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::fullKeyboardAccessEnabled):

11:30 AM Changeset in webkit [95447] by oliver@apple.com

5 edits in trunk/Source/JavaScriptCore

Remove direct property slot pointers from the instruction stream
https://bugs.webkit.org/show_bug.cgi?id=68373

Reviewed by Gavin Barraclough.

Use an indirect load to access prototype properties rather than directly
storing the property address in the instruction stream. This should allow
further optimisations in future, and also provides a 0.5% win to sunspider.

dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):

jit/JITPropertyAccess.cpp:

(JSC::JIT::compileGetDirectOffset):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::compileGetDirectOffset):

runtime/JSObject.h:

(JSC::JSObject::addressOfPropertyStorage):

11:29 AM Changeset in webkit [95446] by alexis.menard@openbossa.org

3 edits in trunk/Tools

Style checker should not check public Qt WK2 API for parameter_name.
https://bugs.webkit.org/show_bug.cgi?id=68359

Reviewed by Andreas Kling.

The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
Add an exception in the style checker to disable the check. Also added the test for it.

Scripts/webkitpy/style/checker.py:
Scripts/webkitpy/style/checker_unittest.py:

11:27 AM Changeset in webkit [95445] by caryclark@google.com

3 edits in trunk/Source/WebCore

Move fontDataForCombiningCharacterSequence to fix Skia on Mac build
https://bugs.webkit.org/show_bug.cgi?id=68358

Reviewed by Dan Bernstein.

No new tests.

platform/graphics/mac/FontMac.mm:
platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::fontDataForCombiningCharacterSequence):
This moves the implementation from FontMac.mm to
FontComplexTextMac.cpp, so it is visible to the Skia on Mac
platform as well.

11:18 AM Changeset in webkit [95444] by commit-queue@webkit.org

5 edits in trunk

GTK DRT leaks memory while comparing history items
https://bugs.webkit.org/show_bug.cgi?id=68086

Source/WebKit/gtk:

Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-09-19
Reviewed by Martin Robinson.

webkit_web_history_item_get_target() function returns a g_strdup()'d
string, so it should return "gchar*" instead of "const gchar*".

webkit/webkitwebhistoryitem.cpp:

(webkit_web_history_item_get_target): Change return type to "gchar*".

webkit/webkitwebhistoryitemprivate.h: Ditto.

Tools:

Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-09-19
Reviewed by Martin Robinson.

webkit_web_history_item_get_target() returns a g_strdup()'d string,
so memory must be freed before compareHistoryItems() returns.

DumpRenderTree/gtk/DumpRenderTree.cpp:

(compareHistoryItems): Use GOwnPtr to manage memory automatically.

11:16 AM Changeset in webkit [95443] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/gtk/po

Fix paths used by update-po, and avoid changing directory
unnecessarily.

[GTK] make update-po is b0rked
https://bugs.webkit.org/show_bug.cgi?id=68352

Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2011-09-19
Reviewed by Martin Robinson.

GNUmakefile.am:

11:12 AM Changeset in webkit [95442] by dslomov@google.com

2 edits in trunk/LayoutTests

[Chromium] Rebaseline expectations and file WK68372.

platform/chromium/test_expectations.txt:

11:03 AM Changeset in webkit [95441] by commit-queue@webkit.org

3 edits in trunk/Tools

Buildbot marks a nrwt bot red when tests are missing results
https://bugs.webkit.org/show_bug.cgi?id=64812

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-19
Reviewed by Ryosuke Niwa.

Scripts/webkitpy/layout_tests/controllers/manager.py:
Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

11:00 AM Changeset in webkit [95440] by jberlin@webkit.org

6 edits
2 adds in trunk

Sites that use history pushState or replaceState are recorded in history in Private Browsing
mode.
https://bugs.webkit.org/show_bug.cgi?id=68208

Reviewed by Brady Eidson.

Source/WebCore:

Test: TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.

Add the privateBrowsingEnabled check that is used in other places in HistoryController
before calling addVisitedLink and FrameLoaderClient::updateGlobalHistory.

loader/HistoryController.cpp:

(WebCore::HistoryController::pushState):
(WebCore::HistoryController::replaceState):

Tools:

Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.

TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.

(TestWebKitAPI::didNavigateWithNavigationData):
This is a context history client callback, so it should not be called when in Private
Browsing. Add a call to FAIL().
(TestWebKitAPI::didSameDocumentNavigationForFrame):
This is a page load client callback that happens after the didNavigateWithNavigationData
callback. End the test.
(TestWebKitAPI::TEST):
Enable Private Browsing and load a page that uses history.pushState.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.

TestWebKitAPI/Tests/WebKit2/push-state.html: Added.

Ditto.

TestWebKitAPI/win/TestWebKitAPI.vcproj:

Ditto.

TestWebKitAPI/win/copy-resources.cmd:

Ditto.

10:41 AM Changeset in webkit [95439] by oliver@apple.com

8 edits in trunk/Source/JavaScriptCore

Remove bump allocator
https://bugs.webkit.org/show_bug.cgi?id=68370

Reviewed by Sam Weinig.

Can't do anything with this allocator currently, and it's
increasing the complexity of the GC code. Slight progression
on SunSpider, slight regression (undoing the original progression)
in V8.

heap/Heap.cpp:

(JSC::Heap::collect):

heap/Heap.h:
heap/NewSpace.cpp:

(JSC::NewSpace::NewSpace):

heap/NewSpace.h:

(JSC::NewSpace::allocate):

runtime/JSObject.cpp:

(JSC::JSObject::allocatePropertyStorage):

runtime/JSObject.h:

(JSC::JSObject::~JSObject):
(JSC::JSObject::visitChildrenDirect):

runtime/StorageBarrier.h:

(JSC::StorageBarrier::set):

10:34 AM Changeset in webkit [95438] by dslomov@google.com

1 edit
1 delete in trunk/LayoutTests

[Chromium] Rebaseline expectations due to r95402.

platform/chromium-win-vista/fast/dom/navigator-detached-no-crash-expected.txt: Removed.

10:18 AM Changeset in webkit [95437] by leandro@webkit.org

3 edits in trunk/Source/WebCore

Unreviewed: ScrollbarThemeMock.cpp is already referenced in the
global CMakeLists.txt.

CMakeListsEfl.txt: Remove reference to platform/mock/ScrollbarThemeMock.cpp.
CMakeListsWinCE.txt: Ditto.

10:14 AM Changeset in webkit [95436] by caio.oliveira@openbossa.org

5 edits
2 adds in trunk/Source/WebKit2

[Qt] [WK2] Implement popup menus in QDesktopWebView using QComboBox
https://bugs.webkit.org/show_bug.cgi?id=67938

Reviewed by Andreas Kling.

Implement a WebPopupMenuProxy that uses QtWebComboBox (a QComboBox subclass we
have for WK1). Then use this WebPopupMenuProxy in QDesktopWebView. The implementation
explicitly avoids running a nested mainloop.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showPopupMenu):
Since we don't run a nested mainloop, we need to keep the client pointer to call
valueChangedForPopupMenu().

UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp: Added.

(WebKit::WebPopupMenuProxyQtDesktop::WebPopupMenuProxyQtDesktop):
(WebKit::WebPopupMenuProxyQtDesktop::~WebPopupMenuProxyQtDesktop):
(WebKit::WebPopupMenuProxyQtDesktop::showPopupMenu):
(WebKit::WebPopupMenuProxyQtDesktop::hidePopupMenu):
(WebKit::WebPopupMenuProxyQtDesktop::setSelectedIndex):
(WebKit::WebPopupMenuProxyQtDesktop::onPopupMenuHidden):
(WebKit::WebPopupMenuProxyQtDesktop::populate):

UIProcess/qt/WebPopupMenuProxyQtDesktop.h: Added.

(WebKit::WebPopupMenuProxyQtDesktop::create):

UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::createPopupMenuProxy):

UIProcess/qt/qdesktopwebpageproxy.h:
WebKit2.pro:

10:13 AM Changeset in webkit [95435] by inferno@chromium.org

1 edit in branches/chromium/874/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp

Merge 95124
BUG=96150
Review URL: http://codereview.chromium.org/7945008

10:12 AM Changeset in webkit [95434] by inferno@chromium.org

1 edit in branches/chromium/874/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp

Merge 94984
BUG=96150
Review URL: http://codereview.chromium.org/7944005

10:09 AM Changeset in webkit [95433] by inferno@chromium.org

1 edit in branches/chromium/874/Source/WebCore/css/CSSPrimitiveValue.cpp

Merge 95071 - Fix cssText property of counter-valued CSSPrimitiveValue and avoid uninitialized read
BUG=60653
Review URL: http://codereview.chromium.org/7941005

10:07 AM Changeset in webkit [95432] by inferno@chromium.org

2 edits in branches/chromium/874/Source/WebCore/accessibility

Merge 94716
BUG=84160
Review URL: http://codereview.chromium.org/7944004

10:05 AM Changeset in webkit [95431] by inferno@chromium.org

1 edit in branches/chromium/874/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

Merge 94864
BUG=84885
Review URL: http://codereview.chromium.org/7948002

10:02 AM Changeset in webkit [95430] by inferno@chromium.org

2 edits in branches/chromium/874/Source/WebCore/rendering

Merge 95054
BUG=92226

9:58 AM Changeset in webkit [95429] by inferno@chromium.org

6 edits in branches/chromium/874/Source/WebCore

Merge 94905
BUG=1092
Review URL: http://codereview.chromium.org/7942002

9:54 AM Changeset in webkit [95428] by inferno@chromium.org

2 edits in branches/chromium/874/Source/WebCore/rendering

Merge 94991
BUG=94810
Review URL: http://codereview.chromium.org/7943004

9:52 AM Changeset in webkit [95427] by inferno@chromium.org

2 edits
2 copies in branches/chromium/874

Merge 95301
BUG=95072
Review URL: http://codereview.chromium.org/7947002

9:49 AM Changeset in webkit [95426] by inferno@chromium.org

1 edit in branches/chromium/874/Source/WebCore/rendering/RenderObjectChildList.cpp

Merge 94857
BUG=95672
Review URL: http://codereview.chromium.org/7946005

9:47 AM Changeset in webkit [95425] by inferno@chromium.org

2 edits
2 copies in branches/chromium/874

Merge 95204
BUG=95761
Review URL: http://codereview.chromium.org/7950001

9:43 AM Changeset in webkit [95424] by inferno@chromium.org

5 edits in branches/chromium/874/Source/WebCore

Merge 95093
BUG=96170
Review URL: http://codereview.chromium.org/7945005

9:42 AM Changeset in webkit [95423] by inferno@chromium.org

1 edit
2 copies in branches/chromium/874

Merge 95074
BUG=96444
Review URL: http://codereview.chromium.org/7945004

9:40 AM Changeset in webkit [95422] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r95416.
http://trac.webkit.org/changeset/95416
https://bugs.webkit.org/show_bug.cgi?id=68367

Broke chromium-mac (Requested by beverloo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

DEPS:

9:38 AM Changeset in webkit [95421] by inferno@chromium.org

2 edits in branches/chromium/874

Merge 95306
BUG=96665
Review URL: http://codereview.chromium.org/7948001

9:35 AM Changeset in webkit [95420] by inferno@chromium.org

1 edit in branches/chromium/874/Source/WebCore/bindings/ScriptControllerBase.cpp

Merge 94820 - REGRESSION (r66874): Missing RefPtr in ScriptController
BUG=95669
Review URL: http://codereview.chromium.org/7946004

9:33 AM Changeset in webkit [95419] by inferno@chromium.org

3 edits in branches/chromium/874/Source/WebCore

Merge 94608 - MediaElementAudioSourceNode destruction triggers ASSERTS
https://bugs.webkit.org/show_bug.cgi?id=67665
BUG=94186
Review URL: http://codereview.chromium.org/7947001

9:26 AM Changeset in webkit [95418] by loislo@chromium.org

2 edits in trunk/LayoutTests

Unreviewed skip inspector/timeline/timeline-animation-frame.html on win platform.

platform/win/Skipped:

9:22 AM Changeset in webkit [95417] by commit-queue@webkit.org

5 edits in trunk/Source

[GTK] Fix distcheck build
https://bugs.webkit.org/show_bug.cgi?id=68346

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2011-09-19
Reviewed by Philippe Normand.

Source/JavaScriptCore:

GNUmakefile.list.am:

Source/WebKit/gtk:

tests/testmimehandling.c: Remove ogg tests, since the behavious

has changed in libsoup (https://bugzilla.gnome.org/show_bug.cgi?id=648846#c8)
(server_callback):
(mime_type_policy_decision_requested_cb):
(main):

webkit/webkitwebplugin.cpp: Fix introspection annotation.

9:07 AM Changeset in webkit [95416] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

DEPS:

8:15 AM Changeset in webkit [95415] by loislo@chromium.org

6 edits in trunk/LayoutTests

Unreviewed fix for flaky tests.

inspector/timeline/timeline-dom-content-loaded-event-expected.txt:
inspector/timeline/timeline-dom-content-loaded-event.html:
inspector/timeline/timeline-load-event-expected.txt:
inspector/timeline/timeline-load-event.html:
platform/qt/Skipped:

7:45 AM Changeset in webkit [95414] by kbalazs@webkit.org

2 edits in trunk/LayoutTests

Unreviewed Qt gardening.
https://bugs.webkit.org/show_bug.cgi?id=68360

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-19

platform/qt/Skipped:

7:23 AM Changeset in webkit [95413] by Ademar Reis

2 edits in trunk/Source/WebCore

Unreviewed: dos2unix on bindings/js/JSExceptionBase.h

Visual Studio is choking on this file when generating packages for
Qt-4.8 on Windows:

"""
Source\WebCore\Bindings\js\JSExceptionBase.h:
error C4335: Mac file format detected: please convert the source file
to either DOS or UNIX format
"""

Since from all .cpp or .h files shared by all ports this is the only
one with CRLF line terminations, I'm assuming this was a mistake.

bindings/js/JSExceptionBase.h:

7:09 AM Changeset in webkit [95412] by kbalazs@webkit.org

1 edit
240 adds in trunk/LayoutTests

[Qt][WK2] Add some pixel baselines.

Unreviewed expectation update.

These baselines was produced in the same environment where the
Szeged WK2 bot runs. The validity of the results had been checked manually.

platform/qt-wk2/css1/box_properties/float_on_text_elements-expected.png: Added.
platform/qt-wk2/css2.1/t051202-c24-first-lttr-00-b-expected.png: Added.
platform/qt-wk2/css2.1/t051202-c26-psudo-nest-00-c-expected.png: Added.
platform/qt-wk2/css2.1/t060401-c32-cascading-00-b-expected.png: Added.
platform/qt-wk2/css2.1/t080301-c411-vt-mrgn-00-b-expected.png: Added.
platform/qt-wk2/css2.1/t0805-c5512-brdr-rw-00-b-expected.png: Added.
platform/qt-wk2/css2.1/t0805-c5514-brdr-lw-00-b-expected.png: Added.
platform/qt-wk2/css2.1/t0805-c5515-brdr-w-00-a-expected.png: Added.
platform/qt-wk2/css2.1/t0805-c5516-brdr-c-00-a-expected.png: Added.
platform/qt-wk2/css2.1/t0805-c5516-ibrdr-c-00-a-expected.png: Added.
platform/qt-wk2/css2.1/t0805-c5517-brdr-s-00-c-expected.png: Added.
platform/qt-wk2/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Added.
platform/qt-wk2/css2.1/t0805-c5518-ibrdr-t-00-a-expected.png: Added.
platform/qt-wk2/css2.1/t0805-c5519-brdr-r-00-a-expected.png: Added.
platform/qt-wk2/css2.1/t0805-c5519-brdr-r-02-e-expected.png: Added.
platform/qt-wk2/css2.1/t0805-c5519-ibrdr-r-00-a-expected.png: Added.
platform/qt-wk2/css2.1/t0805-c5520-brdr-b-01-e-expected.png: Added.
platform/qt-wk2/css2.1/t0805-c5520-ibrdr-b-00-a-expected.png: Added.
platform/qt-wk2/css2.1/t0805-c5521-brdr-l-00-a-expected.png: Added.
platform/qt-wk2/css2.1/t0805-c5521-brdr-l-02-e-expected.png: Added.
platform/qt-wk2/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png: Added.
platform/qt-wk2/css2.1/t0805-c5522-brdr-00-b-expected.png: Added.
platform/qt-wk2/css2.1/t0805-c5522-ibrdr-00-a-expected.png: Added.
platform/qt-wk2/css2.1/t090402-c42-ibx-pad-00-d-ag-expected.png: Added.
platform/qt-wk2/css2.1/t0905-c5525-fltmult-00-d-g-expected.png: Added.
platform/qt-wk2/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
platform/qt-wk2/css2.1/t0905-c5525-fltwrap-00-b-expected.png: Added.
platform/qt-wk2/css2.1/t090501-c414-flt-00-d-expected.png: Added.
platform/qt-wk2/css2.1/t090501-c414-flt-01-b-expected.png: Added.
platform/qt-wk2/css2.1/t090501-c414-flt-ln-00-d-expected.png: Added.
platform/qt-wk2/css2.1/t090501-c414-flt-ln-01-d-g-expected.png: Added.
platform/qt-wk2/css2.1/t090501-c414-flt-ln-02-d-expected.png: Added.
platform/qt-wk2/css2.1/t090501-c414-flt-ln-03-d-expected.png: Added.
platform/qt-wk2/css2.1/t090501-c5525-flt-l-00-b-g-expected.png: Added.
platform/qt-wk2/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Added.
platform/qt-wk2/css2.1/t1002-c5523-width-02-b-g-expected.png: Added.
platform/qt-wk2/css2.1/t100801-c544-valgn-00-a-ag-expected.png: Added.
platform/qt-wk2/css2.1/t100801-c544-valgn-02-d-agi-expected.png: Added.
platform/qt-wk2/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
platform/qt-wk2/css2.1/t100801-c544-valgn-04-d-agi-expected.png: Added.
platform/qt-wk2/css2.1/t1202-counter-08-b-expected.png: Added.
platform/qt-wk2/css2.1/t1202-counters-08-b-expected.png: Added.
platform/qt-wk2/css2.1/t1601-c547-indent-01-d-expected.png: Added.
platform/qt-wk2/css2.1/t1602-c546-txt-align-00-b-expected.png: Added.
platform/qt-wk2/css3/css3-modsel-33-expected.png: Added.
platform/qt-wk2/css3/css3-modsel-35-expected.png: Added.
platform/qt-wk2/fast/backgrounds/size/backgroundSize15-expected.png: Added.
platform/qt-wk2/fast/backgrounds/size/backgroundSize16-expected.png: Added.
platform/qt-wk2/fast/block/basic/014-expected.png: Added.
platform/qt-wk2/fast/block/basic/016-expected.png: Added.
platform/qt-wk2/fast/block/basic/white-space-pre-wraps-expected.png: Added.
platform/qt-wk2/fast/block/float/003-expected.png: Added.
platform/qt-wk2/fast/block/float/020-expected.png: Added.
platform/qt-wk2/fast/block/float/021-expected.png: Added.
platform/qt-wk2/fast/block/float/avoidance-percent-width-strict-expected.png: Added.
platform/qt-wk2/fast/block/float/nopaint-after-layer-destruction2-expected.png: Added.
platform/qt-wk2/fast/block/float/width-update-after-clear-expected.png: Added.
platform/qt-wk2/fast/block/margin-collapse/empty-clear-blocks-expected.png: Added.
platform/qt-wk2/fast/block/positioning/auto-height-with-top-and-bottom-expected.png: Added.
platform/qt-wk2/fast/block/positioning/auto/005-expected.png: Added.
platform/qt-wk2/fast/borders/block-mask-overlay-image-expected.png: Added.
platform/qt-wk2/fast/borders/border-fit-expected.png: Added.
platform/qt-wk2/fast/borders/border-image-scale-transform-expected.png: Added.
platform/qt-wk2/fast/borders/border-radius-inline-flow-expected.png: Added.
platform/qt-wk2/fast/borders/rtl-border-01-expected.png: Added.
platform/qt-wk2/fast/borders/rtl-border-02-expected.png: Added.
platform/qt-wk2/fast/borders/rtl-border-03-expected.png: Added.
platform/qt-wk2/fast/box-shadow/basic-shadows-expected.png: Added.
platform/qt-wk2/fast/canvas/arc360-expected.png: Added.
platform/qt-wk2/fast/canvas/canvas-before-css-expected.png: Added.
platform/qt-wk2/fast/canvas/canvas-text-alignment-expected.png: Added.
platform/qt-wk2/fast/canvas/canvas-zoom-expected.png: Added.
platform/qt-wk2/fast/canvas/canvasDrawingIntoSelf-expected.png: Added.
platform/qt-wk2/fast/canvas/drawImage-expected.png: Added.
platform/qt-wk2/fast/canvas/drawImage-with-globalAlpha-expected.png: Added.
platform/qt-wk2/fast/canvas/fillrect-gradient-zero-stops-expected.png: Added.
platform/qt-wk2/fast/canvas/fillrect_gradient-expected.png: Added.
platform/qt-wk2/fast/canvas/image-object-in-canvas-expected.png: Added.
platform/qt-wk2/fast/canvas/patternfill-repeat-expected.png: Added.
platform/qt-wk2/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
platform/qt-wk2/fast/canvas/shadow-offset-1-expected.png: Added.
platform/qt-wk2/fast/canvas/shadow-offset-2-expected.png: Added.
platform/qt-wk2/fast/canvas/shadow-offset-3-expected.png: Added.
platform/qt-wk2/fast/canvas/shadow-offset-4-expected.png: Added.
platform/qt-wk2/fast/canvas/shadow-offset-5-expected.png: Added.
platform/qt-wk2/fast/canvas/shadow-offset-6-expected.png: Added.
platform/qt-wk2/fast/canvas/shadow-offset-7-expected.png: Added.
platform/qt-wk2/fast/css-generated-content/012-expected.png: Added.
platform/qt-wk2/fast/css-generated-content/013-expected.png: Added.
platform/qt-wk2/fast/css-generated-content/after-duplicated-after-split-expected.png: Added.
platform/qt-wk2/fast/css-generated-content/after-order-expected.png: Added.
platform/qt-wk2/fast/css-generated-content/hover-style-change-expected.png: Added.
platform/qt-wk2/fast/css/004-expected.png: Added.
platform/qt-wk2/fast/css/005-expected.png: Added.
platform/qt-wk2/fast/css/MarqueeLayoutTest-expected.png: Added.
platform/qt-wk2/fast/css/ZeroOpacityLayers-expected.png: Added.
platform/qt-wk2/fast/css/ZeroOpacityLayers2-expected.png: Added.
platform/qt-wk2/fast/css/absolute-poition-in-rtl-parent-expected.png: Added.
platform/qt-wk2/fast/css/begin-end-contain-selector-empty-value-expected.png: Added.
platform/qt-wk2/fast/css/css1_forward_compatible_parsing-expected.png: Added.
platform/qt-wk2/fast/css/css3-modsel-22-expected.png: Added.
platform/qt-wk2/fast/css/css3-nth-child-expected.png: Added.
platform/qt-wk2/fast/css/first-letter-detach-expected.png: Added.
platform/qt-wk2/fast/css/first-letter-hover-expected.png: Added.
platform/qt-wk2/fast/css/font-face-implicit-local-font-expected.png: Added.
platform/qt-wk2/fast/css/hsl-color-expected.png: Added.
platform/qt-wk2/fast/css/inline-properties-important-expected.png: Added.
platform/qt-wk2/fast/css/invalidation-errors-2-expected.png: Added.
platform/qt-wk2/fast/css/invalidation-errors-expected.png: Added.
platform/qt-wk2/fast/css/non-standard-checkbox-size-expected.png: Added.
platform/qt-wk2/fast/css/outline-auto-location-expected.png: Added.
platform/qt-wk2/fast/css/selector-set-attribute-expected.png: Added.
platform/qt-wk2/fast/css/text-align-expected.png: Added.
platform/qt-wk2/fast/css/textCapitalizeEdgeCases-expected.png: Added.
platform/qt-wk2/fast/css/zoom-font-size-expected.png: Added.
platform/qt-wk2/fast/dom/HTMLHeadElement/head-link-style-href-check-expected.png: Added.
platform/qt-wk2/fast/dom/HTMLTableElement/colSpan-expected.png: Added.
platform/qt-wk2/fast/dom/HTMLTableElement/createCaption-expected.png: Added.
platform/qt-wk2/fast/dom/children-nodes-expected.png: Added.
platform/qt-wk2/fast/dom/clone-node-dynamic-style-expected.png: Added.
platform/qt-wk2/fast/dom/css-rule-functions-expected.png: Added.
platform/qt-wk2/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Added.
platform/qt-wk2/fast/dynamic/selection-highlight-adjust-expected.png: Added.
platform/qt-wk2/fast/dynamic/staticY-marking-parents-regression-expected.png: Added.
platform/qt-wk2/fast/forms/basic-selects-expected.png: Added.
platform/qt-wk2/fast/forms/basic-textareas-quirks-expected.png: Added.
platform/qt-wk2/fast/forms/input-placeholder-text-indent-expected.png: Added.
platform/qt-wk2/fast/forms/minWidthPercent-expected.png: Added.
platform/qt-wk2/fast/frames/frame-scrolling-attribute-expected.png: Added.
platform/qt-wk2/fast/gradients/radial-centered-expected.png: Added.
platform/qt-wk2/fast/html/details-writing-mode-expected.png: Added.
platform/qt-wk2/fast/inline/continuation-outlines-expected.png: Added.
platform/qt-wk2/fast/inline/continuation-outlines-with-layers-expected.png: Added.
platform/qt-wk2/fast/lists/001-vertical-expected.png: Added.
platform/qt-wk2/fast/lists/007-vertical-expected.png: Added.
platform/qt-wk2/fast/lists/008-vertical-expected.png: Added.
platform/qt-wk2/fast/media/mq-relative-constraints-08-expected.png: Added.
platform/qt-wk2/fast/multicol/client-rects-expected.png: Added.
platform/qt-wk2/fast/multicol/column-break-with-balancing-expected.png: Added.
platform/qt-wk2/fast/multicol/float-multicol-expected.png: Added.
platform/qt-wk2/fast/multicol/float-paginate-complex-expected.png: Added.
platform/qt-wk2/fast/multicol/float-paginate-expected.png: Added.
platform/qt-wk2/fast/multicol/layers-split-across-columns-expected.png: Added.
platform/qt-wk2/fast/multicol/margin-collapse-expected.png: Added.
platform/qt-wk2/fast/multicol/max-height-columns-block-expected.png: Added.
platform/qt-wk2/fast/multicol/nested-columns-expected.png: Added.
platform/qt-wk2/fast/multicol/paginate-block-replaced-expected.png: Added.
platform/qt-wk2/fast/multicol/positioned-with-constrained-height-expected.png: Added.
platform/qt-wk2/fast/multicol/scrolling-overflow-expected.png: Added.
platform/qt-wk2/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
platform/qt-wk2/fast/multicol/span/anonymous-style-inheritance-expected.png: Added.
platform/qt-wk2/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Added.
platform/qt-wk2/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Added.
platform/qt-wk2/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Added.
platform/qt-wk2/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Added.
platform/qt-wk2/fast/multicol/span/span-as-immediate-columns-child-expected.png: Added.
platform/qt-wk2/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Added.
platform/qt-wk2/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
platform/qt-wk2/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
platform/qt-wk2/fast/multicol/span/span-margin-collapsing-expected.png: Added.
platform/qt-wk2/fast/multicol/table-margin-collapse-expected.png: Added.
platform/qt-wk2/fast/multicol/table-vertical-align-expected.png: Added.
platform/qt-wk2/fast/multicol/unsplittable-inline-block-expected.png: Added.
platform/qt-wk2/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
platform/qt-wk2/fast/multicol/vertical-lr/column-rules-expected.png: Added.
platform/qt-wk2/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
platform/qt-wk2/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
platform/qt-wk2/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
platform/qt-wk2/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
platform/qt-wk2/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
platform/qt-wk2/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
platform/qt-wk2/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
platform/qt-wk2/fast/multicol/vertical-rl/column-rules-expected.png: Added.
platform/qt-wk2/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
platform/qt-wk2/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
platform/qt-wk2/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
platform/qt-wk2/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
platform/qt-wk2/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
platform/qt-wk2/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
platform/qt-wk2/fast/overflow/line-clamp-expected.png: Added.
platform/qt-wk2/fast/overflow/overflow-rtl-vertical-expected.png: Added.
platform/qt-wk2/fast/overflow/table-overflow-float-expected.png: Added.
platform/qt-wk2/fast/reflections/opacity-reflection-transform-expected.png: Added.
platform/qt-wk2/fast/repaint/bugzilla-6278-expected.png: Added.
platform/qt-wk2/fast/repaint/line-flow-with-floats-1-expected.png: Added.
platform/qt-wk2/fast/repaint/line-flow-with-floats-10-expected.png: Added.
platform/qt-wk2/fast/repaint/line-flow-with-floats-2-expected.png: Added.
platform/qt-wk2/fast/repaint/line-flow-with-floats-3-expected.png: Added.
platform/qt-wk2/fast/repaint/line-flow-with-floats-4-expected.png: Added.
platform/qt-wk2/fast/repaint/line-flow-with-floats-5-expected.png: Added.
platform/qt-wk2/fast/repaint/line-flow-with-floats-6-expected.png: Added.
platform/qt-wk2/fast/repaint/line-flow-with-floats-7-expected.png: Added.
platform/qt-wk2/fast/repaint/line-flow-with-floats-8-expected.png: Added.
platform/qt-wk2/fast/repaint/line-flow-with-floats-9-expected.png: Added.
platform/qt-wk2/fast/repaint/multicol-repaint-expected.png: Added.
platform/qt-wk2/fast/repaint/outline-repaint-glitch-expected.png: Added.
platform/qt-wk2/fast/repaint/selected-replaced-expected.png: Added.
platform/qt-wk2/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Added.
platform/qt-wk2/fast/repaint/stacked-diacritics-expected.png: Added.
platform/qt-wk2/fast/repaint/text-append-dirty-lines-expected.png: Added.
platform/qt-wk2/fast/replaced/001-expected.png: Added.
platform/qt-wk2/fast/replaced/002-expected.png: Added.
platform/qt-wk2/fast/replaced/003-expected.png: Added.
platform/qt-wk2/fast/replaced/005-expected.png: Added.
platform/qt-wk2/fast/replaced/absolute-image-sizing-expected.png: Added.

6:33 AM Changeset in webkit [95411] by loislo@chromium.org

1 edit
1 add in trunk/LayoutTests

Web Inspector: extend UI perf tests coverage. Elements Panel.
https://bugs.webkit.org/show_bug.cgi?id=68263

Reviewed by Pavel Feldman.

inspector/performance/resources/show-panel-elements.html: Added.

6:32 AM Changeset in webkit [95410] by loislo@chromium.org

5 edits
4 adds in trunk

Web Inspector: didMarkDOMContentEvent() should send event of MarkDOMContent type.
https://bugs.webkit.org/show_bug.cgi?id=67528

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: inspector/timeline/timeline-dom-content-loaded-event.html

inspector/timeline/timeline-load-event.html

inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):

LayoutTests:

inspector/timeline/timeline-animation-frame.html:
inspector/timeline/timeline-dom-content-loaded-event-expected.txt: Added.
inspector/timeline/timeline-dom-content-loaded-event.html: Added.
inspector/timeline/timeline-load-event-expected.txt: Added.
inspector/timeline/timeline-load-event.html: Added.
inspector/timeline/timeline-test.js:

(initialize_Timeline.InspectorTest.waitForRecordType.addRecord):
(initialize_Timeline.InspectorTest.waitForRecordType):

6:04 AM Changeset in webkit [95409] by kov@webkit.org

2 edits in trunk/Source/WebKit/gtk/po

Ukrainian translation for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=66543

Patch by Yuri Chornoivan <yurchor@ukr.net> on 2011-08-31
Reviewed by Gustavo Noronha.

uk.po: updated.

6:04 AM Changeset in webkit [95408] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt: Updated.
platform/qt-mac/Skipped: Skip new failing tests to paint the bot green.

5:48 AM Changeset in webkit [95407] by rgabor@webkit.org

2 edits in trunk/LayoutTests

[Qt] [ARMv5] fast/events/media-element-focus-tab.html fast/spatial-navigation/snav-media-elements.html fail
https://bugs.webkit.org/show_bug.cgi?id=68341

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-19

platform/qt-arm/Skipped: Skip the failing tests

2:19 AM Changeset in webkit [95406] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Re-name LayerChromium border functions to reflect that
they are only for debug use.
https://bugs.webkit.org/show_bug.cgi?id=68212

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-19
Reviewed by James Robinson.

Code cleanup towards unit testing.

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::setupContentsLayer):

platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setDebugBorderColor):
(WebCore::LayerChromium::setDebugBorderWidth):

platform/graphics/chromium/LayerChromium.h:

1:17 AM Changeset in webkit [95405] by loislo@chromium.org

2 edits in trunk/Source/WebKit/chromium

Web Inspector: extend timeline coverage.
https://bugs.webkit.org/show_bug.cgi?id=68260

Another place with js function call from native.

Reviewed by Pavel Feldman.

src/WebDevToolsFrontendImpl.cpp:

(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):

12:36 AM Changeset in webkit [95404] by loislo@chromium.org

18 edits
3 adds in trunk

2011-09-18 Ilya Tikhonovsky <loislo@chromium.org>

Web Inspector: requestAnimationFrame callbacks don't show up in the timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=67986

Reviewed by Pavel Feldman.

Test: inspector/timeline/timeline-animation-frame.html

WebCore:

English.lproj/localizedStrings.js:
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunction): (WebCore::V8Proxy::callFunctionWithoutFrame): (WebCore::V8Proxy::instrumentedCallFunction):
bindings/v8/V8Proxy.h:
bindings/v8/custom/V8CustomVoidCallback.cpp: (WebCore::invokeCallback):
dom/ScriptedAnimationController.cpp: (WebCore::ScriptedAnimationController::registerCallback): (WebCore::ScriptedAnimationController::cancelCallback): (WebCore::ScriptedAnimationController::serviceScriptedAnimations):
inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallbackImpl): (WebCore::InspectorInstrumentation::didCancelAnimationFrameCallbackImpl): (WebCore::InspectorInstrumentation::willFireAnimationFrameEventImpl): (WebCore::InspectorInstrumentation::didFireAnimationFrameEventImpl):
inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willCallFunction): (WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallback): (WebCore::InspectorInstrumentation::didCancelAnimationFrameCallback): (WebCore::InspectorInstrumentation::willFireAnimationFrameEvent): (WebCore::InspectorInstrumentation::didFireAnimationFrameEvent):
inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didRegisterAnimationFrameCallback): (WebCore::InspectorTimelineAgent::didCancelAnimationFrameCallback): (WebCore::InspectorTimelineAgent::willFireAnimationFrameEvent): (WebCore::InspectorTimelineAgent::didFireAnimationFrameEvent):
inspector/InspectorTimelineAgent.h:
inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createAnimationFrameCallbackData):
inspector/TimelineRecordFactory.h:
inspector/front-end/TimelineAgent.js:
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get _recordStyles): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._clearPanel): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

LayoutTests:

inspector/timeline/timeline-animation-frame-expected.txt: Added.
inspector/timeline/timeline-animation-frame.html: Added.
inspector/timeline/timeline-enum-stability-expected.txt:
platform/chromium/inspector/timeline/timeline-enum-stability-expected.txt:
platform/qt/Skipped: inspector/timeline/timeline-animation-frame.html was added to the skip list.
inspector/timeline/timeline-test.js:

12:31 AM Changeset in webkit [95403] by Carlos Garcia Campos

6 edits in trunk/Source

[GTK] Fix distcheck build
https://bugs.webkit.org/show_bug.cgi?id=68241

Reviewed by Martin Robinson.

Source/JavaScriptCore:

GNUmakefile.list.am:

Source/WebCore:

GNUmakefile.list.am:

Source/WebKit2:

GNUmakefile.am:

Sep 18, 2011:

11:50 PM Changeset in webkit [95402] by koz@chromium.org

1 edit
1 add in trunk/LayoutTests

Rebaseline navigator test for chromium-win-vista.
https://bugs.webkit.org/show_bug.cgi?id=68334

Unreviewed. Rebaseline for navigator-detached-no-crash.

platform/chromium-win-vista/fast/dom/navigator-detached-no-crash-expected.txt: Added.

10:34 PM Changeset in webkit [95401] by loislo@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: chromium-win: "Save timeline data" does nothing.
https://bugs.webkit.org/show_bug.cgi?id=68313

windows shell API function GetSaveFileName doesn't accept file names with ':' symbol.

Reviewed by Pavel Feldman.

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelineModel.prototype._saveToFile):

6:29 PM Changeset in webkit [95400] by mitz@apple.com

5 edits
2 deletes in trunk/Source/JavaScriptCore

Removed ProfilerServer.

Reviewed by Mark Rowe.

JavaScriptCore.gypi:
JavaScriptCore.xcodeproj/project.pbxproj:
profiler/ProfilerServer.h: Removed.
profiler/ProfilerServer.mm: Removed.
runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

wscript:

3:29 PM Changeset in webkit [95399] by fpizlo@apple.com

9 edits in trunk/Source/JavaScriptCore

DFG JIT should inline Math.min, Math.max, and Math.sqrt
https://bugs.webkit.org/show_bug.cgi?id=68318

Reviewed by Gavin Barraclough.

Adds Math.min, Math.max, and Math.sqrt intrinsics. Adds support for
a function to have an intrinsic but not a thunk generator. This is
a 7% speed-up on access-nbody, and neutral elsewhere, mainly because
we're still not DFG compiling the bulk of the hot code in Kraken audio
benchmarks.

create_hash_table:
dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):

dfg/DFGIntrinsic.h:
dfg/DFGNode.h:
dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::fixupNode):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

jit/JITStubs.cpp:

(JSC::JITThunks::hostFunctionStub):

runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

2:35 PM Changeset in webkit [95398] by thakis@chromium.org

2 edits in trunk/Source/JavaScriptCore

Remove two files from JavaScriptCore.gypi that were removed in r95240
https://bugs.webkit.org/show_bug.cgi?id=68327

Unreviewed, build warning fix.

JavaScriptCore.gypi:

11:38 AM Changeset in webkit [95397] by oliver@apple.com

5 edits in trunk/Source/JavaScriptCore

Remove special case handling of inline storage from the JIT
https://bugs.webkit.org/show_bug.cgi?id=68319

Reviewed by Gavin Barraclough.

Simplify logic used for reading and writing to property storage
by removing the special cases for inline storage. This has no
perf impact.

dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryBuildGetByIDList):

jit/JIT.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdSelfList):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdSelfList):

11:18 AM Changeset in webkit [95396] by mitz@apple.com

2 edits in trunk/Source/WebCore

Try to fix the Chromium Mac build after r95391.

WebCore.gyp/WebCore.gyp:

11:05 AM Changeset in webkit [95395] by mitz@apple.com

2 edits in trunk/Source/WebCore

Try to fix the Chromium Mac build after r95391.

WebCore.gyp/WebCore.gyp:

10:27 AM Changeset in webkit [95394] by mitz@apple.com

5 edits
1 move in trunk/Source/WebCore

Try to fix the Chromium Mac build after r95391.

WebCore.gypi: Updated for the renaming of ComplexTextController.cpp.
WebCore.xcodeproj/project.pbxproj: Ditto.
platform/graphics/Font.h: Changed #if directives to include the Chromium Mac port.
platform/graphics/SimpleFontData.h: Ditto.
platform/graphics/mac/ComplexTextControllerCoreText.cpp: Changed the filename extension of this

Objective-C++ file to .mm.

platform/graphics/mac/ComplexTextControllerCoreText.mm: Copied from Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.cpp.

10:16 AM Changeset in webkit [95393] by mitz@apple.com

2 edits in trunk/Source/WebCore

Snow Leopard build fix after r95391.

platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

10:02 AM Changeset in webkit [95392] by mitz@apple.com

2 edits in trunk/Source/WebCore

Leopard build fix after r95391.

platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):

9:52 AM Changeset in webkit [95391] by mitz@apple.com

11 edits
3 adds in trunk

Source/WebCore: Allow Core Text to choose the fallback font for rendering a combining character sequence

Fixes <rdar://problem/7860281> Decomposed text is displayed incorrectly when Verdana is specified
https://bugs.webkit.org/show_bug.cgi?id=68287

Reviewed by Dave Hyatt.

Test: platform/mac/fast/text/combining-character-sequence-fallback.html

WebCore.xcodeproj/project.pbxproj: Compile ComplexTextControllerCoreText.cpp as Objective-C++.

I am going to rename this file in a followup patch.

platform/graphics/Font.h: Declared fontDataForCombiningCharacterSequence().

platform/graphics/SimpleFontData.h: Declared canRenderCombiningCharacterSequence() and added

a member variable to cache the results of calling this function.

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::offsetForPosition): Fixed a typo in a comment.
(WebCore::advanceByCombiningCharacterSequence): Added this helper function, which iterates over
characters until the end of a sequence of combining characters, zero-width joiners and zero-width
non-joiners. A single base characater followed by such a (possibly-empty) sequence is known as
a combining character sequence. This stretches the definition a little because the base character
may be a combining character as well. Returns false if an invalid UTF-16 sequence is encountered,
true otherwise.
(WebCore::ComplexTextController::collectComplexTextRuns): - Replaced the glyphData and nextGlyphData
variables each with a pair of variables, a SimpleFontData* and a boolean indicating whether a
character mapped to the missing glyph. This clarifies that this function does not use glyph IDs.

Renamed the local variable newC to uppercaseCharacter.
Changed to use advanceByCombiningCharacterSequence().
Changed to use Font::fontDataForCombiningCharacterSequence() instead of Font::glyphDataForCharacter(). If there are combining marks and none of the fonts in the fallback list can render the sequence alone, use the systemFallbackFontData() constant to indicate to collectComplexTextRunsForCharactersCoreText() to allow Core Text to perform its own fallback.
Stopped checking isSmallCaps against nextIsSmallCaps. It was redundant, since the small caps FontData differs from the normal variant.

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Moved the common logic to
handle the 0 fontData case from the ATSUI and Core Text continuations of this function into this function.

platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::systemFallbackFontData): Added. This constant is used to indicate to
collectComplexTextRunsForCharactersCoreText() that it should allow Core Text to perform its own font
fallback.

platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI): Handle systemFallbackFontData()
by using the primary font data.

platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(-[CascadeList initWithFont:WebCore::character:]): Added.
(-[CascadeList count]): Added.
(-[CascadeList objectAtIndex:]): Added. Returns an entry from a cascade list of CTFontDescriptorRef
objects based on the font’s fallback list for the character. The list is initialized lazily.
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Handle systemFallbackFontData()
by allowing Core Text to perform font fallback, starting with a cascade list based on the font’s fallback
list and possibly continuing with system fallback.

platform/graphics/mac/FontMac.mm:

(WebCore::Font::fontDataForCombiningCharacterSequence): Added. If the sequence is only a base character,
calls through to glyphDataForCharacter(). Otherwise, iterates over the font’s fallback list for the
base character (and the system fallback font for that character), returning the first font that can
render the sequence, or 0 if there is none.

platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::provideStringAndAttributes): Added this Core Text callback.
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence): Added. Checks if Core Text can render
the sequence using only this font. Caches the result.

LayoutTests: <rdar://problem/7860281> Decomposed text is displayed incorrectly when Verdana is specified
https://bugs.webkit.org/show_bug.cgi?id=68287

Reviewed by Dave Hyatt.

platform/mac/fast/text/combining-character-sequence-fallback.html: Added.
platform/mac/platform/mac/fast/text/combining-character-sequence-fallback-expected.png: Added.
platform/mac/platform/mac/fast/text/combining-character-sequence-fallback-expected.txt: Added.

9:21 AM Changeset in webkit [95390] by mitz@apple.com

3 edits in trunk/LayoutTests

Updated expected results for two tests after r95362.

platform/mac/fast/dom/Window/window-properties-expected.txt:
platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed