Context Navigation

← Previous Period
Next Period →

Timeline

Sep 24, 2011:

11:04 PM Changeset in webkit [95919] by abarth@webkit.org

126 edits in trunk

Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
https://bugs.webkit.org/show_bug.cgi?id=68767

Reviewed by Eric Seidel.

Source/cmake/OptionsEfl.cmake:
Source/cmake/OptionsWinCE.cmake:
Source/cmakeconfig.h.cmake:
configure.ac:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

As discussed on webkit-dev, almost everyone has this enable turned on
and this feature is unlikely to be removed from the web platform given
its popularity.

CMakeLists.txt:
Configurations/FeatureDefines.xcconfig:
GNUmakefile.am:
GNUmakefile.list.am:
WebCore.exp.in:
WebCore.pro:
bindings/cpp/WebDOMEventTarget.cpp:

(toWebKit):

bindings/js/JSEventTarget.cpp:

(WebCore::toJS):
(WebCore::toEventTarget):

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

dom/EventTarget.cpp:

(WebCore::EventTarget::toDOMApplicationCache):

dom/EventTarget.h:
features.pri:
history/PageCache.cpp:

(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):

html/HTMLHtmlElement.cpp:

(WebCore::HTMLHtmlElement::insertedByParser):

html/HTMLHtmlElement.h:
html/HTMLMediaElement.cpp:

(WebCore::createFileURLForApplicationCacheResource):
(WebCore::HTMLMediaElement::loadResource):

html/ImageDocument.cpp:

(WebCore::ImageDocument::createDocumentStructure):

html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):

inspector/InspectorApplicationCacheAgent.cpp:
inspector/InspectorApplicationCacheAgent.h:
inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):

inspector/InspectorController.h:
inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):

inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::networkStateChanged):
(WebCore::InspectorInstrumentation::updateApplicationCacheStatus):

inspector/InstrumentingAgents.h:

(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):

inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::connectFrontend):

inspector/generate-inspector-idl:
loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::mainReceivedError):
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::detachFromFrame):
(WebCore::DocumentLoader::handledOnloadEvents):

loader/DocumentLoader.h:

(WebCore::DocumentLoader::applicationCacheHost):

loader/EmptyClients.h:

(WebCore::EmptyChromeClient::reachedApplicationCacheOriginQuota):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadResourceSynchronously):

loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::willSendRequest):
(WebCore::MainResourceLoader::didReceiveResponse):
(WebCore::MainResourceLoader::didReceiveData):
(WebCore::MainResourceLoader::didFinishLoading):
(WebCore::MainResourceLoader::didFail):
(WebCore::MainResourceLoader::load):

loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::start):
(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didSendData):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::wasBlocked):
(WebCore::ResourceLoader::cannotShowURL):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::willCacheResponse):

loader/ResourceLoader.h:
loader/appcache/ApplicationCache.cpp:
loader/appcache/ApplicationCache.h:
loader/appcache/ApplicationCacheGroup.cpp:
loader/appcache/ApplicationCacheGroup.h:
loader/appcache/ApplicationCacheHost.cpp:
loader/appcache/ApplicationCacheHost.h:
loader/appcache/ApplicationCacheResource.cpp:
loader/appcache/ApplicationCacheResource.h:
loader/appcache/ApplicationCacheStorage.cpp:
loader/appcache/ApplicationCacheStorage.h:
loader/appcache/DOMApplicationCache.cpp:
loader/appcache/DOMApplicationCache.h:
loader/appcache/DOMApplicationCache.idl:
loader/appcache/ManifestParser.cpp:

(WebCore::parseManifest):

loader/appcache/ManifestParser.h:
loader/chromium/ResourceLoaderChromium.cpp:

(WebCore::ResourceLoader::didDownloadData):

page/ChromeClient.h:
page/DOMWindow.cpp:

(WebCore::DOMWindow::clear):
(WebCore::DOMWindow::applicationCache):

page/DOMWindow.h:

(WebCore::DOMWindow::optionalApplicationCache):

page/DOMWindow.idl:
xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):

xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::parseStartElement):

Source/WebKit/chromium:

features.gypi:
src/ApplicationCacheHost.cpp:
src/ApplicationCacheHostInternal.h:
src/AssertMatchingEnums.cpp:
src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::reachedApplicationCacheOriginQuota):

src/ChromeClientImpl.h:
src/WebDataSourceImpl.cpp:

(WebKit::WebDataSourceImpl::applicationCacheHost):

src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableApplicationCache):
(WebKit::WebRuntimeFeatures::isApplicationCacheEnabled):

Source/WebKit/efl:

WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::reachedApplicationCacheOriginQuota):

WebCoreSupport/ChromeClientEfl.h:
ewk/ewk_main.cpp:

(_ewk_init_body):

ewk/ewk_settings.cpp:

(ewk_settings_cache_directory_path_set):
(ewk_settings_cache_directory_path_get):

Source/WebKit/gtk:

WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::reachedApplicationCacheOriginQuota):

WebCoreSupport/ChromeClientGtk.h:
webkit/webkitapplicationcache.cpp:

(webkit_application_cache_get_maximum_size):
(webkit_application_cache_set_maximum_size):
(webkit_application_cache_get_database_directory_path):

webkit/webkitglobals.cpp:

(webkitInit):

Source/WebKit/haiku:

WebCoreSupport/ChromeClientHaiku.cpp:

(WebCore::ChromeClientWx::reachedApplicationCacheOriginQuota):

WebCoreSupport/ChromeClientHaiku.h:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:
Misc/WebCache.mm:

(+[WebCache empty]):

WebCoreSupport/WebApplicationCache.mm:
WebCoreSupport/WebApplicationCacheQuotaManager.mm:

(-[WebApplicationCacheQuotaManager usage]):
(-[WebApplicationCacheQuotaManager quota]):
(-[WebApplicationCacheQuotaManager setQuota:]):

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm:
WebView/WebDataSource.mm:

(-[WebDataSource _transferApplicationCache:]):

WebView/WebFrame.mm:

(-[WebFrame _cacheabilityDictionary]):

WebView/WebView.mm:

(WebKitInitializeApplicationCachePathIfNecessary):

Source/WebKit/qt:

Api/qwebsecurityorigin.cpp:

(QWebSecurityOrigin::setApplicationCacheQuota):

Api/qwebsettings.cpp:

(QWebSettings::setOfflineWebApplicationCachePath):
(QWebSettings::offlineWebApplicationCachePath):
(QWebSettings::setOfflineWebApplicationCacheQuota):
(QWebSettings::offlineWebApplicationCacheQuota):

WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::reachedApplicationCacheOriginQuota):

WebCoreSupport/ChromeClientQt.h:
WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::clearAllApplicationCaches):

Source/WebKit/win:

WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::reachedApplicationCacheOriginQuota):

WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::reachedApplicationCacheOriginQuota):

WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

WebKitSupport/ChromeClientWx.cpp:

(WebCore::ChromeClientWx::reachedApplicationCacheOriginQuota):

WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:
UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::applicationCacheDirectory):

WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:

(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManager::deleteAllEntries):

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::reachedApplicationCacheOriginQuota):

WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::clearApplicationCache):

WebProcess/WebProcess.h:

Tools:

Scripts/build-webkit:

WebKitLibraries:

win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

7:20 PM Changeset in webkit [95918] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

JIT implementation of put_by_val increments m_length instead of setting
it to index+1
https://bugs.webkit.org/show_bug.cgi?id=68766

Reviewed by Geoffrey Garen.

jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_by_val):

3:53 PM Changeset in webkit [95917] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

More build fixage.

heap/ConservativeRoots.cpp: Our system of #includes, it is chaos.

3:39 PM Changeset in webkit [95916] by fpizlo@apple.com

8 edits in trunk/Source/JavaScriptCore

The DFG should not attempt to guess types in the absence of value
profiles
https://bugs.webkit.org/show_bug.cgi?id=68677

Reviewed by Oliver Hunt.

This adds the ForceOSRExit node, which is ignored by the propagator
and virtual register allocator (and hence ensuring that liveness analysis
works correctly), but forces terminateSpeculativeExecution() in the
back-end. This appears to be a slight speed-up on benchmark averages,
with ~5% swings on individual benchmarks, in both directions. But it's
never a regression on any average, and appears to be a ~1% progression
in the SunSpider average.

This also adds a bit better debugging support in the old JIT and in DFG,
as this was necessary to debug the much more frequent OSR transitions
that occur with this change.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getStrongPrediction):
(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

dfg/DFGNode.h:
dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

jit/JIT.h:

3:38 PM Changeset in webkit [95915] by mihaip@chromium.org

2 edits in trunk/LayoutTests

Remove Chromium failing expectations for WCSS tests now that they're
been removed with r95911.

platform/chromium/test_expectations.txt:

3:36 PM Changeset in webkit [95914] by ggaren@apple.com

4 edits in trunk/Source/JavaScriptCore

Some Windows build fixage.

heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweep):

heap/MarkedBlock.h:

(JSC::MarkedBlock::isLive): Show the compiler that all control paths
return a value. There, there, compiler. Everything's going to be OK.

runtime/JSCell.h:

(JSC::JSCell::setVPtr): Oops! Unrename this function.

3:35 PM Changeset in webkit [95913] by mihaip@chromium.org

2 edits
1 delete in trunk/LayoutTests

Mark an svg/ test as slow, and remove incorrect baselines for another.

platform/chromium-cg-mac-leopard/fast/ruby/ruby-text-before-after-content-expected.txt: Removed.
platform/chromium/test_expectations.txt:

3:15 PM Changeset in webkit [95912] by ggaren@apple.com

15 edits in trunk

Allocate new objects unmarked
https://bugs.webkit.org/show_bug.cgi?id=68764

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This is a pre-requisite to using the mark bit to determine object age.

~2% v8 speedup, mostly due to a 12% v8-splay speedup.

heap/MarkedBlock.h:

(JSC::MarkedBlock::isLive):
(JSC::MarkedBlock::isLiveCell): These two functions are the reason for
this patch. They can now determine object liveness without relying on
newly allocated objects having their mark bits set. Each MarkedBlock
now has a state variable that tells us how to determine whether its
cells are live. (This new state variable supercedes the old one about
destructor state. The rest of this patch is just refactoring to support
the invariants of this new state variable without introducing a
performance regression.)

(JSC::MarkedBlock::didConsumeFreeList): New function for updating interal
state when a block becomes fully allocated.

(JSC::MarkedBlock::clearMarks): Folded a state change to 'Marked' into
this function because, logically, clearing all mark bits is the first
step in saying "mark bits now exactly reflect object liveness".

(JSC::MarkedBlock::markCountIsZero): Renamed from isEmpty() to clarify
that this function only tells you about the mark bits, so it's only
meaningful if you've put the mark bits into a meaningful state before
calling it.

(JSC::MarkedBlock::forEachCell): Changed to use isLive() helper function
instead of testing mark bits, since mark bits are not always the right
way to find out if an object is live anymore. (New objects are live, but
not marked.)

heap/MarkedBlock.cpp:

(JSC::MarkedBlock::recycle):
(JSC::MarkedBlock::MarkedBlock): Folded all initialization -- even
initialization when recycling an old block -- into the MarkedBlock
constructor, for simplicity.

(JSC::MarkedBlock::callDestructor): Inlined for speed. Always check for
a zapped cell before running a destructor, and always zap after
running a destructor. This does not seem to be expensive, and the
alternative just creates a too-confusing matrix of possible cell states
((zombie undestructed cell + zombie destructed cell + zapped destructed
cell) * 5! permutations for progressing through block states = "Oh my!").

(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep): Maintained and expanded a pre-existing
optimization to use template specialization to constant fold lots of
branches and elide certain operations entirely during a sweep. Merged
four or five functions that were logically about sweeping into this one
function pair, so there's only one way to do things now, it's
automatically correct, and it's always fast.

(JSC::MarkedBlock::zapFreeList): Renamed this function to be more explicit
about exactly what it does, and to honor the new block state system.

heap/AllocationSpace.cpp:

(JSC::AllocationSpace::allocateBlock): Updated for rename.

(JSC::AllocationSpace::freeBlocks): Updated for changed interface.

(JSC::TakeIfUnmarked::TakeIfUnmarked):
(JSC::TakeIfUnmarked::operator()):
(JSC::TakeIfUnmarked::returnValue): Just like isEmpty() above, renamed
to clarify that this functor only tests the mark bits, so it's only
valid if you've put the mark bits into a meaningful state before
calling it.

(JSC::AllocationSpace::shrink): Updated for rename.

heap/AllocationSpace.h:

(JSC::AllocationSpace::canonicalizeCellLivenessData): Renamed to be a
little more specific about what we're making canonical.

(JSC::AllocationSpace::forEachCell): Updated for rename.

(JSC::AllocationSpace::forEachBlock): No need to canonicalize cell
liveness data before iterating blocks -- clients that want iterated
blocks to have valid cell lieveness data should make this call for
themselves. (And not all clients want it.)

heap/ConservativeRoots.cpp:

(JSC::ConservativeRoots::genericAddPointer): Updated for rename. Removed
obsolete comment.

heap/Heap.cpp:

(JSC::CountFunctor::ClearMarks::operator()): Removed call to notify...()
because clearMarks() now does that implicitly.

(JSC::Heap::destroy): Make sure to canonicalize before tear-down, since
tear-down tests cell liveness when running destructors.

(JSC::Heap::markRoots):
(JSC::Heap::collect): Moved weak reference harvesting out of markRoots()
and into collect, since it strictly depends on root marking, and does
not contribute to root marking.

(JSC::Heap::canonicalizeCellLivenessData): Renamed to be a little more
specific about what we're making canonical.

heap/Heap.h:

(JSC::Heap::forEachProtectedCell): No need to canonicalize cell liveness
data before iterating protected cells, since we know they're all live,
and don't need to test for it.

heap/Local.h:

(JSC::::set): Can't make the same ASSERT we used to because we just don't
have the mark bits for it anymore. Perhaps we can bring this ASSERT back
in a weaker form in the future.

heap/MarkedSpace.cpp:

(JSC::MarkedSpace::addBlock):
(JSC::MarkedSpace::removeBlock): Updated for interface change.
(JSC::MarkedSpace::canonicalizeCellLivenessData): Renamed to be a little more
specific about what we're making canonical.

heap/MarkedSpace.h:

(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::SizeClass::SizeClass):
(JSC::MarkedSpace::SizeClass::resetAllocator):
(JSC::MarkedSpace::SizeClass::zapFreeList): Simplified this allocator
functionality a bit. We now track only one block -- "currentBlock" --
and rely on its internal state to know whether it has more cells to
allocate.

heap/Weak.h:

(JSC::Weak::set): Can't make the same ASSERT we used to because we just don't
have the mark bits for it anymore. Perhaps we can bring this ASSERT back
in a weaker form in the future.

runtime/JSCell.h:

(JSC::JSCell::vptr):
(JSC::JSCell::zap):
(JSC::JSCell::isZapped):
(JSC::isZapped): Made zapping a property of JSCell, for a little abstraction.
In the future, exactly how a JSCell zaps itself will change, as the
internal representation of JSCell changes.

LayoutTests:

Reviewed by Oliver Hunt.

Made this flaky test less flaky. (Just enough to make my patch not fail.)

fast/dom/gc-10.html: Count objects immediately after GC to get an

exact count. Call 'reload' a few times to improve test coverage. Preload
properties in case they're lazily instantiated, which would change
object count numbers. Also, use the 'var' keyword like a good little
JavaScripter.

3:03 PM Changeset in webkit [95911] by abarth@webkit.org

24 edits
6 deletes in trunk

Remove ENABLE(WCSS) and associated code
https://bugs.webkit.org/show_bug.cgi?id=68759

Reviewed by Darin Adler.

configure.ac:

Source/WebCore:

As discussed on webkit-dev, we are removing this feature from trunk to
reduce the number of different configurations.

CodeGenerators.pri:
GNUmakefile.am:
WebCore.pro:
css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

css/CSSParser.h:
css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

css/WCSSPropertyNames.in: Removed.
css/WCSSValueKeywords.in: Removed.
features.pri:
html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):

html/HTMLInputElement.h:
html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::sanitizeValue):
(WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):

rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::start):

rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

rendering/style/RenderStyleConstants.h:

Tools:

Scripts/build-webkit:
Scripts/old-run-webkit-tests:
Scripts/webkitperl/features.pm:

(hasFeature):

Scripts/webkitpy/layout_tests/port/webkit.py:
Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

LayoutTests:

fast/wcss: Removed.
fast/wcss/wap-input-format-expected.txt: Removed.
fast/wcss/wap-input-format.xhtml: Removed.
fast/wcss/wap-input-required-expected.txt: Removed.
fast/wcss/wap-input-required.xhtml: Removed.

2:23 PM Changeset in webkit [95910] by fpizlo@apple.com

4 edits in trunk/Source/JavaScriptCore

DFG JIT should not eagerly initialize integer tags in the register file
https://bugs.webkit.org/show_bug.cgi?id=68763

Reviewed by Oliver Hunt.

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::ValueRecovery::alreadyInRegisterFileAsUnboxedInt32):
(JSC::DFG::OSRExit::operandForArgument):
(JSC::DFG::OSRExit::operandForIndex):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

12:13 PM Changeset in webkit [95909] by mitz@apple.com

1 edit
1 add in trunk/LayoutTests

Added Snow Leopard-specific expected results.

platform/mac-snowleopard/platform/mac/fast/text/combining-character-sequence-fallback-expected.txt: Added.

2:58 AM Changeset in webkit [95908] by alex

2 edits in trunk/Tools

2011-09-24 Alejandro G. Castro <alex@igalia.com>

Fixed GTK compilation after r95878, the operator== was defined
twice when USE_WEBPROCESS_EVENT_SIMULATION is defined.

WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

1:17 AM Changeset in webkit [95907] by commit-queue@webkit.org

4 edits
3 adds in trunk

SVGAnimation does not support 'values' for from-to animations
https://bugs.webkit.org/show_bug.cgi?id=64859

Patch by Young Han Lee <joybro@company100.net> on 2011-09-24
Reviewed by Dirk Schulze.

If from-to animation have discrete calc-mode and have a 'keyTimes' list, values of
the keyTimes indicate the begin and the end of the animation respectively.[1][2]

When keyTimes is given, calculate the progress percentage of the animation with it
even for from-to animation.

[1] http://www.w3.org/TR/SVG/animate.html#ValueAttributes
[2] http://www.w3.org/TR/2001/REC-smil-animation-20010904/#AnimFuncValues

Source/WebCore:

Test: svg/animations/animate-from-to-keyTimes.html

svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::calculatePercentForFromTo):
(WebCore::SVGAnimationElement::updateAnimation):

svg/SVGAnimationElement.h:

LayoutTests:

svg/animations/animate-from-to-keyTimes-expected.txt: Added.
svg/animations/animate-from-to-keyTimes.html: Added.
svg/animations/script-tests/animate-from-to-keyTimes.js: Added.

(sample1):
(sample2):
(executeTest):

12:00 AM Changeset in webkit [95906] by Chris Fleizach

5 edits in trunk

WebKit does not expose AXPlaceholder value on password fields
https://bugs.webkit.org/show_bug.cgi?id=68745

Reviewed by Oliver Hunt.

Source/WebCore:

accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

accessibility/placeholder-expected.txt:
accessibility/placeholder.html:

Sep 23, 2011:

10:42 PM Changeset in webkit [95905] by barraclough@apple.com

3 edits in trunk

Add JSVALUE32_64 support to DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=67460

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-23
Reviewed by Gavin Barraclough.

Add cmake options to enable DFG JIT compilation for EFL port

Source/cmake/OptionsEfl.cmake:
Source/cmakeconfig.h.cmake:

10:30 PM Changeset in webkit [95904] by commit-queue@webkit.org

2 edits in trunk/Tools

[DRT] Include the right config file for EFL's DRT.
https://bugs.webkit.org/show_bug.cgi?id=67042

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-23
Reviewed by Martin Robinson.

Ports which use CMake as their buildsystem (such as the EFL one) also
have config.h files, but they are named differently, so include the
right one depending on the buildsystem being used.

DumpRenderTree/config.h:

10:11 PM Changeset in webkit [95903] by mrowe@apple.com

2 edits in trunk/Source/WebCore

Fix the build.

loader/CrossOriginAccessControl.cpp:

(WebCore::passesAccessControlCheck): Get rid of the exit-time destructor.

10:04 PM Changeset in webkit [95902] by barraclough@apple.com

21 edits
4 adds in trunk/Source/JavaScriptCore

Add JSVALUE32_64 support to DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=67460

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-23
Reviewed by Gavin Barraclough.

This is the initial attempt to add JSVALUE32_64 support to DFG JIT.
It's tested on IA32 Linux EFL port currently. It still cannot run
all the test cases and benchmarks so should be turned off now.

The major work includes:
1) dealing with JSVALUE32_64 data format in DFG JIT;
2) bindings between 64-bit JS Value and 32-bit registers;
3) handling of function calls. Currently for DFG operation function
calls we follow the X86 cdecl calling convention on Linux, and the
implementation is in a naive way by pushing the arguments into stack
one by one.

The known issues include:
1) some code duplicates unnecessarily, especially in Speculative JIT
code generation, where most of the operations on SpeculataInteger /
SpeculateDouble should be identical to the JSVALUE64 code. Refactoring
is needed in the future;
2) lack of op_call and op_construct support, comparing to current
JSVALUE64 DFG;
3) currently integer speculations assume to be StrictInt32;
4) lack of JSBoolean speculations;
5) boxing and unboxing doubles could be improved;
6) DFG X86 register description is different with the baseline JIT,
the timeoutCheckRegister is used for general purpose usage;
7) calls to runtime functions with primitive double parameters (e.g.
fmod) don't work. Support needs to be added to the assembler to
implement the mechanism of passing double parameters for X86 cdecl
convention.

And there should be many other hidden bugs which should be exposed and
resolved in later debugging process.

CMakeListsEfl.txt:
assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::loadDouble):
(JSC::MacroAssemblerX86::storeDouble):

assembler/X86Assembler.h:

(JSC::X86Assembler::movsd_rm):

bytecode/StructureStubInfo.h:
dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

dfg/DFGFPRInfo.h:

(JSC::DFG::FPRInfo::debugName):

dfg/DFGGPRInfo.h:

(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):

dfg/DFGGenerationInfo.h:

(JSC::DFG::needDataFormatConversion):
(JSC::DFG::GenerationInfo::initJSValue):
(JSC::DFG::GenerationInfo::initDouble):
(JSC::DFG::GenerationInfo::gpr):
(JSC::DFG::GenerationInfo::tagGPR):
(JSC::DFG::GenerationInfo::payloadGPR):
(JSC::DFG::GenerationInfo::fpr):
(JSC::DFG::GenerationInfo::fillJSValue):
(JSC::DFG::GenerationInfo::fillCell):
(JSC::DFG::GenerationInfo::fillDouble):

dfg/DFGJITCodeGenerator.cpp:
dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::allocate):
(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::registersMatched):
(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
(JSC::DFG::JITCodeGenerator::silentFillAllRegisters):
(JSC::DFG::JITCodeGenerator::boxDouble):
(JSC::DFG::JITCodeGenerator::unboxDouble):
(JSC::DFG::JITCodeGenerator::spill):
(JSC::DFG::addressOfDoubleConstant):
(JSC::DFG::integerResult):
(JSC::DFG::jsValueResult):
(JSC::DFG::setupResults):
(JSC::DFG::callOperation):
(JSC::JSValueOperand::JSValueOperand):
(JSC::JSValueOperand::~JSValueOperand):
(JSC::JSValueOperand::isDouble):
(JSC::JSValueOperand::fill):
(JSC::JSValueOperand::tagGPR):
(JSC::JSValueOperand::payloadGPR):
(JSC::JSValueOperand::fpr):
(JSC::GPRTemporary::~GPRTemporary):
(JSC::GPRTemporary::gpr):
(JSC::GPRResult2::GPRResult2):

dfg/DFGJITCodeGenerator32_64.cpp: Added.

(JSC::DFG::JITCodeGenerator::clearGenerationInfo):
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::fillStorage):
(JSC::DFG::JITCodeGenerator::useChildren):
(JSC::DFG::JITCodeGenerator::isStrictInt32):
(JSC::DFG::JITCodeGenerator::isKnownInteger):
(JSC::DFG::JITCodeGenerator::isKnownNumeric):
(JSC::DFG::JITCodeGenerator::isKnownCell):
(JSC::DFG::JITCodeGenerator::isKnownNotInteger):
(JSC::DFG::JITCodeGenerator::isKnownNotNumber):
(JSC::DFG::JITCodeGenerator::isKnownBoolean):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativeUInt32ToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeArithMod):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCheckHasInstance):
(JSC::DFG::JITCodeGenerator::nonSpeculativeInstanceOf):
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::cachedPutById):
(JSC::DFG::JITCodeGenerator::cachedGetMethod):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeStrictEq):
(JSC::DFG::JITCodeGenerator::emitBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeLogicalNot):
(JSC::DFG::JITCodeGenerator::emitCall):
(JSC::DFG::JITCodeGenerator::speculationCheck):
(JSC::DFG::dataFormatString):
(JSC::DFG::JITCodeGenerator::dump):
(JSC::DFG::JITCodeGenerator::checkConsistency):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::FPRTemporary::FPRTemporary):

dfg/DFGJITCompiler.cpp:
dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::tagForGlobalVar):
(JSC::DFG::JITCompiler::payloadForGlobalVar):
(JSC::DFG::JITCompiler::appendCallWithExceptionCheck):
(JSC::DFG::JITCompiler::addressOfDoubleConstant):
(JSC::DFG::JITCompiler::boxDouble):
(JSC::DFG::JITCompiler::unboxDouble):
(JSC::DFG::JITCompiler::addPropertyAccess):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):

dfg/DFGJITCompiler32_64.cpp: Added.

(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::fillToJS):
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::jitAssertIsInt32):
(JSC::DFG::JITCompiler::jitAssertIsJSInt32):
(JSC::DFG::JITCompiler::jitAssertIsJSNumber):
(JSC::DFG::JITCompiler::jitAssertIsJSDouble):
(JSC::DFG::JITCompiler::jitAssertIsCell):
(JSC::DFG::JITCompiler::emitCount):
(JSC::DFG::JITCompiler::setSamplingFlag):
(JSC::DFG::JITCompiler::clearSamplingFlag):

dfg/DFGJITCompilerInlineMethods.h: Added.

(JSC::DFG::JITCompiler::emitLoadTag):
(JSC::DFG::JITCompiler::emitLoadPayload):
(JSC::DFG::JITCompiler::emitLoad):
(JSC::DFG::JITCompiler::emitLoad2):
(JSC::DFG::JITCompiler::emitLoadDouble):
(JSC::DFG::JITCompiler::emitLoadInt32ToDouble):
(JSC::DFG::JITCompiler::emitStore):
(JSC::DFG::JITCompiler::emitStoreInt32):
(JSC::DFG::JITCompiler::emitStoreCell):
(JSC::DFG::JITCompiler::emitStoreBool):
(JSC::DFG::JITCompiler::emitStoreDouble):

dfg/DFGNode.h:
dfg/DFGOperations.cpp:
dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryCachePutByID):

dfg/DFGSpeculativeJIT.cpp:
dfg/DFGSpeculativeJIT.h:

(JSC::DFG::ValueRecovery::inGPR):
(JSC::DFG::ValueRecovery::inPair):
(JSC::DFG::ValueRecovery::tagGPR):
(JSC::DFG::ValueRecovery::payloadGPR):

dfg/DFGSpeculativeJIT32_64.cpp: Added.

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::dump):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntStrict):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::convertToDouble):
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::initializeVariableTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

runtime/JSValue.h:

9:23 PM Changeset in webkit [95901] by Darin Adler

6034 edits in trunk/Source

Set eol-style to native on many source files where it was unset.

8:51 PM Changeset in webkit [95900] by abarth@webkit.org

3 edits in trunk/Source/WebCore

Canvas security checks show up on HTML5GamingTest benchmark
https://bugs.webkit.org/show_bug.cgi?id=68743

Reviewed by Oliver Hunt.

Prior to this patch, the canvas security checks took as much as 4% of
the time on the HTML5GamingTest benchmark:

http://craftymind.com/factory/guimark2/HTML5GamingTest.html

This patch uses a couple of AtomicStrings and shuffles around the order
of the security check to take this down to around 0.1% (which is near
the noise floor of what I can measure with my profiler).

html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::wouldTaintOrigin):

loader/CrossOriginAccessControl.cpp:

(WebCore::passesAccessControlCheck):

8:24 PM Changeset in webkit [95899] by commit-queue@webkit.org

7 edits in trunk

Source/WebCore: Unwarranted DOM Exception when canvas2D drawImage is called with src
rect out of bounds
https://bugs.webkit.org/show_bug.cgi?id=65709

Patch by Justin Novosad <junov@chromium.org> on 2011-09-23
Reviewed by Oliver Hunt.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):
Return early without throwing an exception if source rectangle is out of
bounds to match the spec.

LayoutTests: Unwarranted DOM Exception when canvas2D drawImage is called with src
rect is out of bounds
https://bugs.webkit.org/show_bug.cgi?id=65709

Patch by Justin Novosad <junov@chromium.org> on 2011-09-23
Reviewed by Oliver Hunt.

fast/canvas/drawImage-with-invalid-args-expected.txt:
fast/canvas/drawImage-with-invalid-args.html:

This test covers (among other things) cases where the source rectangle is
_completely_ outside the bounds of the source image. It was modified to no
longer expect DOM exceptions

platform/chromium/test_expectations.txt:

Out-dated test canvas/philip/tests/2d.drawImage.outsidesource.html
is now expected to fail

platform/mac/Skipped:

Skipping canvas/philip/tests/2d.drawImage.outsidesource.html

8:20 PM Changeset in webkit [95898] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Printing of notImplemented() when logging enabled.
https://bugs.webkit.org/show_bug.cgi?id=64590

Printing of notImplemented() method was enabled on Debug builds only.
Now it is enabled when logging is enabled.

Patch by Lukasz Slachciak <l.slachciak@samsung.com> on 2011-09-23
Reviewed by Oliver Hunt.

No new tests because there is no new functionality.

platform/NotImplemented.h: Non-debug mode replaced with non-logging mode.

8:12 PM Changeset in webkit [95897] by mihaip@chromium.org

3 edits
2 adds in trunk

[Chromium] REGRESSION (r95725): Resizing a window doesn't resize the contents
https://bugs.webkit.org/show_bug.cgi?id=68730

Reviewed by James Robinson.

Source/WebCore:

Adds a missing contentsResized() call in ScrollView::setFrameRect.

Test: fast/dom/Window/window-resize-contents.html

platform/ScrollView.cpp:

(WebCore::ScrollView::setFrameRect):

LayoutTests:

Test for resizing of the window triggering resizing of contents.

fast/dom/Window/window-resize-contents-expected.txt: Added.
fast/dom/Window/window-resize-contents.html: Added.

8:12 PM Changeset in webkit [95896] by commit-queue@webkit.org

2 edits in trunk

[CMake] Detect amd64 as a valid 64-bit architecture.
https://bugs.webkit.org/show_bug.cgi?id=67481

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-23
Reviewed by Oliver Hunt.

Some operating systems (generally the BSDs) use amd64 instead of x86_64
to report they're running on 64 bits, so consider it a valid value.

Source/CMakeLists.txt:

7:07 PM Changeset in webkit [95895] by fpizlo@apple.com

7 edits
1 add in trunk/Source/JavaScriptCore

wtf/BitVector.h has a variety of bugs which manifest when the
vector grows beyond 63 bits
https://bugs.webkit.org/show_bug.cgi?id=68746

Reviewed by Oliver Hunt.

Out-of-lined slow path code in BitVector so that not every user
of CodeBlock ends up having to compile it. Fixed a variety of
index computation and size computation bugs.

I have not seen these issues manifest themselves, but they are
blocking a patch that uses BitVector more aggressively.

GNUmakefile.list.am:
JavaScriptCore.vcproj/WTF/WTF.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
wtf/BitVector.cpp: Added.

(BitVector::BitVector):
(BitVector::operator=):
(BitVector::resize):
(BitVector::clearAll):
(BitVector::OutOfLineBits::create):
(BitVector::OutOfLineBits::destroy):
(BitVector::resizeOutOfLine):

wtf/BitVector.h:

(WTF::BitVector::ensureSize):
(WTF::BitVector::get):
(WTF::BitVector::set):
(WTF::BitVector::clear):
(WTF::BitVector::byteCount):
(WTF::BitVector::OutOfLineBits::numWords):
(WTF::BitVector::OutOfLineBits::bits):
(WTF::BitVector::outOfLineBits):

wtf/CMakeLists.txt:
wtf/wtf.pri:

6:25 PM Changeset in webkit [95894] by adamk@chromium.org

18 edits in trunk

Add ENABLE_MUTATION_OBSERVERS feature flag
https://bugs.webkit.org/show_bug.cgi?id=68732

Reviewed by Ojan Vafai.

This flag will guard an implementation of the "Mutation Observers" proposed in
http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html

configure.ac:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:
GNUmakefile.am:

Source/WebKit/chromium:

features.gypi:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Tools:

Scripts/build-webkit:

WebKitLibraries:

win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

6:19 PM Changeset in webkit [95893] by mhahnenberg@apple.com

11 edits in trunk/Source/JavaScriptCore

De-virtualize JSCell::getJSNumber
https://bugs.webkit.org/show_bug.cgi?id=68651

Reviewed by Oliver Hunt.

Added a new JSType to check whether or not something is a
NumberObject (which includes NumberPrototype) in TypeInfo::isNumberObject because there's not
currently a better way to determine whether something is indeed a NumberObject.
Also de-virtualized JSCell::getJSNumber, having it check the TypeInfo
for whether the object is a NumberObject or not. This patch is part of
the larger process of de-virtualizing JSCell.

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
runtime/JSCell.cpp:

(JSC::JSCell::getJSNumber):

runtime/JSCell.h:

(JSC::JSValue::getJSNumber):

runtime/JSType.h:
runtime/JSTypeInfo.h:

(JSC::TypeInfo::isNumberObject):

runtime/JSValue.h:
runtime/NumberObject.cpp:

(JSC::NumberObject::getJSNumber):

runtime/NumberObject.h:

(JSC::NumberObject::createStructure):

runtime/NumberPrototype.h:

(JSC::NumberPrototype::createStructure):

6:12 PM Changeset in webkit [95892] by mihaip@chromium.org

2 edits
3 adds in trunk/LayoutTests

Rebaseline fast/ruby/ruby-text-before-after-content.html for Chromium Mac.

Mark media/controls-right-click-on-timebar.html as flaky.

platform/chromium-cg-mac-leopard/fast/ruby/ruby-text-before-after-content-expected.png: Added.
platform/chromium-cg-mac-leopard/fast/ruby/ruby-text-before-after-content-expected.txt: Added.
platform/chromium-mac/fast/ruby/ruby-text-before-after-content-expected.png: Added.
platform/chromium/test_expectations.txt:

5:44 PM Changeset in webkit [95891] by jcivelli@chromium.org

2 edits in trunk/Source/WebKit/chromium

Making some WebBlob methods exportable.
This is needed by the shared lib chromium build.
https://bugs.webkit.org/show_bug.cgi?id=68709

Reviewed by Darin Fisher.

public/WebBlob.h:

5:23 PM Changeset in webkit [95890] by commit-queue@webkit.org

16 edits
4 adds in trunk

.: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
https://bugs.webkit.org/show_bug.cgi?id=68198

Patch by Varun Jain <varunjain@google.com> on 2011-09-23
Reviewed by Dimitri Glazkov.

Source/autotools/symbols.filter:

Source/WebCore: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
https://bugs.webkit.org/show_bug.cgi?id=68198

Patch by Varun Jain <varunjain@google.com> on 2011-09-23
Reviewed by Dimitri Glazkov.

Tests: fast/dom/scroll-element-to-rect-centered.html

fast/dom/scroll-element-to-rect.html

WebCore.exp.in:
page/FrameView.cpp:

(WebCore::FrameView::scrollElementToRect):

page/FrameView.h:
testing/Internals.cpp:

(WebCore::Internals::scrollElementToRect):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit/chromium: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
https://bugs.webkit.org/show_bug.cgi?id=68198

Patch by Varun Jain <varunjain@google.com> on 2011-09-23
Reviewed by Dimitri Glazkov.

public/WebView.h:

(WebKit::WebView::scrollFocusedNodeIntoRect):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::scrollFocusedNodeIntoRect):

Source/WebKit2: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
https://bugs.webkit.org/show_bug.cgi?id=68198

Patch by Varun Jain <varunjain@google.com> on 2011-09-23
Reviewed by Dimitri Glazkov.

win/WebKit2.def:
win/WebKit2CFLite.def:

LayoutTests: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
https://bugs.webkit.org/show_bug.cgi?id=68198

Patch by Varun Jain <varunjain@google.com> on 2011-09-23
Reviewed by Dimitri Glazkov.

fast/dom/scroll-element-to-rect-centered-expected.txt: Added.
fast/dom/scroll-element-to-rect-centered.html: Added.
fast/dom/scroll-element-to-rect-expected.txt: Added.
fast/dom/scroll-element-to-rect.html: Added.

5:07 PM Changeset in webkit [95889] by mihaip@chromium.org

7 edits in trunk/Source

Unreviewed, rolling out r95860.
http://trac.webkit.org/changeset/95860
https://bugs.webkit.org/show_bug.cgi?id=68648

Breaks overhang rendering on Chromium Mac

Source/WebCore:

platform/chromium/ScrollbarThemeChromium.cpp:
platform/chromium/ScrollbarThemeChromium.h:
platform/chromium/ScrollbarThemeChromiumMac.h:
platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

Source/WebKit/chromium:

features.gypi:

4:43 PM Changeset in webkit [95888] by dino@apple.com

10 edits
6 adds in trunk

Add -webkit-filter to CSSPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=68675

Reviewed by Simon Fraser.

Add property and rudimentary parsing for -webkit-filter. The
property value isn't preserved anywhere yet. Add
stub definition for computed style.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFilter):

css/CSSParser.h:
css/CSSPropertyNames.in:
css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

New test for rudimentary parsing of -webkit-filter.
Since currently only the Apple port enables the
feature, add this new test to the platform skip lists
for GTK, QT and Chromium.

css3/filters/filter-property-expected.txt: Added.
css3/filters/filter-property.html: Added.
css3/filters/script-tests/TEMPLATE.html: Added.
css3/filters/script-tests/filter-property.js: Added.
platform/chromium/test_expectations.txt:
platform/gtk/Skipped:
platform/qt/Skipped:

4:28 PM Changeset in webkit [95887] by fpizlo@apple.com

8 edits in trunk/Source/JavaScriptCore

Resolve opcodes should have value profiling.
https://bugs.webkit.org/show_bug.cgi?id=68723

Reviewed by Oliver Hunt.

This adds value profiling to all forms of op_resolve in the
old JIT, and patches that information into the DFG along with
performing the appropriate type propagation.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):

dfg/DFGNode.h:

(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::resolveGlobalDataIndex):
(JSC::DFG::Node::hasPrediction):

dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
(JSC::JIT::emitSlow_op_resolve_global_dynamic):

jit/JITStubCall.h:

(JSC::JITStubCall::callWithValueProfiling):

4:25 PM Changeset in webkit [95886] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Remove preserves3D() from CCLayerDelegate, replacing it by setting the
value explicitly after creating a layer, or setting its delegate.
https://bugs.webkit.org/show_bug.cgi?id=68295

Patch by Antoine Labour <piman@chromium.org> on 2011-09-23
Reviewed by James Robinson.

Covered by compositing/ layeout tests.

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::setupContentsLayer):

platform/graphics/chromium/GraphicsLayerChromium.h:
platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):

platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setPreserves3D):
(WebCore::LayerChromium::preserves3D):

4:24 PM Changeset in webkit [95885] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

chrome.dll!WebCore::ApplyStyleCommand::applyBlockStyle ReadAV@NULL (64db547804532a84be2e53721e499e9e)
https://bugs.webkit.org/show_bug.cgi?id=51639

Patch by Jay Soffian <jaysoffian@gmail.com> on 2011-09-23
Reviewed by Tony Chang.

Add repro for a crash inside WebCore::ApplyStyleCommand::applyBlockStyle. Fixed by r94840.

editing/style/justify-without-enclosing-block-expected.txt: Added.
editing/style/justify-without-enclosing-block.xhtml: Added.

4:19 PM Changeset in webkit [95884] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix windows build.

4:17 PM Changeset in webkit [95883] by abarth@webkit.org

2 edits in trunk/LayoutTests

Note flaky test.

platform/chromium/test_expectations.txt:

4:16 PM Changeset in webkit [95882] by mrowe@apple.com

5 edits in trunk/Source

Versioning.

4:14 PM Changeset in webkit [95881] by mrowe@apple.com

1 copy in tags/Safari-535.4

New tag.

4:12 PM Changeset in webkit [95880] by commit-queue@webkit.org

1 edit
4 adds in trunk/LayoutTests

Add a few more possiblities to the test cases for xss denial.
https://bugs.webkit.org/show_bug.cgi?id=47120

Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-23
Reviewed by Adam Barth.

http/tests/security/xss-DENIED-document-baseURI-javascript-with-spaces-expected.txt: Added.
http/tests/security/xss-DENIED-document-baseURI-javascript-with-spaces.html: Added.
http/tests/security/xss-DENIED-window-open-javascript-url-with-spaces-expected.txt: Added.
http/tests/security/xss-DENIED-window-open-javascript-url-with-spaces.html: Added.

4:11 PM Changeset in webkit [95879] by jchaffraix@webkit.org

2 edits in trunk/Source/WebCore

Implicit conversion double to float in ShadowBlur::adjustBlurRadius
https://bugs.webkit.org/show_bug.cgi?id=68722

Reviewed by Simon Fraser.

platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::adjustBlurRadius): Added 2 explicit
conversions.

4:02 PM Changeset in webkit [95878] by commit-queue@webkit.org

13 edits in trunk

[WK2] [Qt] Implement MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
https://bugs.webkit.org/show_bug.cgi?id=68556

Implement the MouseDown/MouseUp/MouseMoveTo functions on Qt platform.

Source/WebKit2:

Patch by Chang Shu <cshu@webkit.org> on 2011-09-23
Reviewed by Darin Adler.

Shared/API/c/WKGeometry.h:

(operator==):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mouseEventSyncForTesting): initialize "handled"

Tools:

Patch by Chang Shu <cshu@webkit.org> on 2011-09-23
Reviewed by Darin Adler.

WebKitTestRunner/EventSenderProxy.h:
WebKitTestRunner/InjectedBundle/EventSendingController.h:
WebKitTestRunner/PlatformWebView.h:
WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::leapForward):

WebKitTestRunner/qt/EventSenderProxyQt.cpp:

(WTR::EventSenderProxy::EventSenderProxy):
(WTR::getMouseButton):
(WTR::getModifiers):
(WTR::EventSenderProxy::updateClickCountForButton):
(WTR::EventSenderProxy::createGraphicsSceneMouseEvent):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::leapForward):
(WTR::EventSenderProxy::sendOrQueueEvent):
(WTR::EventSenderProxy::replaySavedEvents):

WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::postEvent):

WebKitTestRunner/qt/WebKitTestRunner.pro:

LayoutTests:

Unskip passed tests.

Patch by Chang Shu <cshu@webkit.org> on 2011-09-23
Reviewed by Darin Adler.

platform/qt-wk2/Skipped:

3:59 PM Changeset in webkit [95877] by barraclough@apple.com

4 edits
3 adds in trunk

Source/JavaScriptCore: Strict mode does not work in non-trivial nested functions.
https://bugs.webkit.org/show_bug.cgi?id=68740

Reviewed by Oliver Hunt.

Function-info caching does not preserve all state that it should.

parser/JSParser.cpp:

(JSC::JSParser::Scope::saveFunctionInfo):
(JSC::JSParser::Scope::restoreFunctionInfo):
(JSC::JSParser::parseFunctionInfo):

parser/SourceProviderCacheItem.h:

LayoutTests: gh@apple.com>

Strict mode does not work in non-trivial nested functions.
https://bugs.webkit.org/show_bug.cgi?id=68740

Reviewed by Oliver Hunt.

Function-info caching does not preserve all state that it should.

fast/js/nested-functions-expected.txt: Added.
fast/js/nested-functions.html: Added.
fast/js/script-tests/nested-functions.js: Added.

(runTests.test1):
(runTests.test2):
(runTests.test3):
(runTests):

3:58 PM Changeset in webkit [95876] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

ValueToDouble handling in prediction propagation should be ASSERT_NOT_REACHED
https://bugs.webkit.org/show_bug.cgi?id=68724

Reviewed by Oliver Hunt.

dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

3:47 PM Changeset in webkit [95875] by commit-queue@webkit.org

2 edits in trunk/Tools

[chromium] Make the layout test script's kill timeout proportional to --time-out-ms
https://bugs.webkit.org/show_bug.cgi?id=68026

Patch by Lei Zhang <thestig@chromium.org> on 2011-09-23
Reviewed by Dirk Pranke.

Scripts/webkitpy/layout_tests/port/chromium.py:

3:45 PM Changeset in webkit [95874] by mitz@apple.com

3 edits
2 adds in trunk

<rdar://problem/10178576> REGRESSION (r95391): Crash in -[WebCascadeList objectAtIndex:] when a font-family list contains missing fonts
https://bugs.webkit.org/show_bug.cgi?id=68737

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/text/combining-character-sequence-fallback-crash.html

platform/graphics/mac/ComplexTextControllerCoreText.mm:

(-[WebCascadeList initWithFont:WebCore::character:]): Changed to intialize _count to the exact
number of FontData instances in the fallback list rather than the number of font families in the
font description.

LayoutTests:

fast/text/combining-character-sequence-fallback-crash-expected.txt: Added.
fast/text/combining-character-sequence-fallback-crash.html: Added.

3:44 PM Changeset in webkit [95873] by adamk@chromium.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Remove WEBWIDGET_HAS_ANIMATE_CHANGES #define
https://bugs.webkit.org/show_bug.cgi?id=68720

Reviewed by James Robinson.

References to this macro were removed in http://crrev.com/102314.

public/WebWidget.h:

3:41 PM Changeset in webkit [95872] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Build fix.

3:34 PM Changeset in webkit [95871] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Crash in WebCore::DatabaseObserver
https://bugs.webkit.org/show_bug.cgi?id=67805

Patch by Stephen Chenney <schenney@chromium.org> on 2011-09-23
Reviewed by David Levin.

src/DatabaseObserver.cpp:

(WebCore::DatabaseObserver::canEstablishDatabase): Added a check for a
null frame or page, and return false if null. Investigated
changing the fall-through return value to false but decided against
it given the way the code is used and existing default values for
related code. Reproduction and testing depends on having a document
with no frame or no page, which sometimes happens in practice but is
hard to construct explicitly.

3:28 PM Changeset in webkit [95870] by commit-queue@webkit.org

10 edits
4 adds
1 delete in trunk

[Chromium] Fix CSS 3D corner anti-aliasing.
https://bugs.webkit.org/show_bug.cgi?id=68087

Patch by David Reveman <reveman@chromium.org> on 2011-09-23
Reviewed by James Robinson.

Source/WebCore:

Render sharp corners more correctly by adding bounding box
edges to anti-aliasing shaders.

Test: platform/chromium/compositing/3d-corners.html

platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::FragmentShaderRGBATexAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexClampAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexClampSwizzleAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::getShaderString):

platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::drawLayer):
(WebCore::CCRenderSurface::drawSurface):

platform/graphics/chromium/cc/CCRenderSurface.h:
platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::draw):
(WebCore::CCTiledLayerImpl::drawTiles):

platform/graphics/chromium/cc/CCTiledLayerImpl.h:

LayoutTests:

Add a test to check sharp corner rendering of CSS 3D transformed
elements.

platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.checksum: Removed.
platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Added.
platform/chromium-gpu-linux/platform/chromium/compositing/3d-corners-expected.png: Added.
platform/chromium-gpu-linux/platform/chromium/compositing/backface-visibility-transformed-expected.png:
platform/chromium-gpu-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
platform/chromium/compositing/3d-corners-expected.txt: Added.
platform/chromium/compositing/3d-corners.html: Added.
platform/chromium/test_expectations.txt:

3:22 PM Changeset in webkit [95869] by mihaip@chromium.org

2 edits in trunk/LayoutTests

Add failing expectations for tests added by r95852.

platform/chromium/test_expectations.txt:

3:13 PM Changeset in webkit [95868] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG implementation of PutScopedVar corrupts register allocation
https://bugs.webkit.org/show_bug.cgi?id=68735

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-09-23
Reviewed by Oliver Hunt.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

3:10 PM Changeset in webkit [95867] by barraclough@apple.com

3 edits in trunk/LayoutTests

Updating now-passing Layout test.

Rubber stamped by geoff garen

fast/js/Object-getOwnPropertyNames-expected.txt:
fast/js/script-tests/Object-getOwnPropertyNames.js:

3:08 PM Changeset in webkit [95866] by inferno@chromium.org

2 edits in branches/chromium/874/Source/WebCore/rendering

Merge 95857 - Source/WebCore: Style not updated for :before, :after content
in ruby text.
BUG=97546
Review URL: http://codereview.chromium.org/8037003

3:05 PM Changeset in webkit [95865] by oliver@apple.com

17 edits
2 adds in trunk/Source

Make write barriers actually do something when enabled
https://bugs.webkit.org/show_bug.cgi?id=68717

Reviewed by Geoffrey Garen.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Add a basic card marking style write barrier to JSC (currently
turned off). This requires two scratch registers in the JIT
so there was some register re-arranging to satisfy that requirement.
Happily this produced a minor perf bump in sunspider (~0.5%).

Turning the barriers on causes an overall regression of around 1.5%

JavaScriptCore.exp:
JavaScriptCore.xcodeproj/project.pbxproj:
assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::store8):

assembler/X86Assembler.h:

(JSC::X86Assembler::movb_i8m):

dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::isKnownNotCell):
(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::markCellCard):
(JSC::DFG::JITCodeGenerator::cachedPutById):

dfg/DFGJITCodeGenerator.h:
dfg/DFGRepatch.cpp:

(JSC::DFG::tryCachePutByID):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

heap/CardSet.h: Added.

(JSC::CardSet::CardSet):
(JSC::::cardForAtom):
(JSC::::cardMarkedForAtom):
(JSC::::markCardForAtom):

heap/Heap.cpp:
heap/Heap.h:

(JSC::Heap::addressOfCardFor):
(JSC::Heap::writeBarrierFastCase):

heap/MarkedBlock.h:

(JSC::MarkedBlock::setDirtyObject):
(JSC::MarkedBlock::addressOfCardFor):
(JSC::MarkedBlock::offsetOfCards):

jit/JIT.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emitWriteBarrier):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var):

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Add a forwarding header, and fix an evaluation ordering
issue that shows up if you try to use write barriers.

ForwardingHeaders/heap/CardSet.h: Added.
bindings/js/JSEventListener.h:

(WebCore::JSEventListener::jsFunction):

2:59 PM Changeset in webkit [95864] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=68077
SH4 assemblers doesn't refer to executable memory handle.

Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2011-09-23
Reviewed by Gavin Barraclough.

assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branch8):

assembler/SH4Assembler.h:

(JSC::SH4Assembler::executableCopy):

2:51 PM Changeset in webkit [95863] by jamesr@google.com

4 edits in trunk/Source/WebCore

Avoid updating compositing state during paint
https://bugs.webkit.org/show_bug.cgi?id=68727

Reviewed by Simon Fraser.

We shouldn't update our compositing state in the middle of a paint. The call to
updateCompositingAndLayerListsIfNeeded() was added to RenderLayer::paintLayer in r45715, which was intended to
fix this exact issue. Based off the ChangeLog entries, I think that this was just a typo.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers):

rendering/RenderLayerCompositor.h:

2:51 PM Changeset in webkit [95862] by inferno@chromium.org

1 edit
3 adds in trunk/LayoutTests

Unreviewed. Chromium rebaselines for r95857.

platform/chromium-linux/fast/ruby/ruby-text-before-after-content-expected.png: Added.
platform/chromium-win/fast/ruby/ruby-text-before-after-content-expected.png: Added.
platform/chromium-win/fast/ruby/ruby-text-before-after-content-expected.txt: Added.

2:48 PM Changeset in webkit [95861] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

occasional crash in Chromium in dispatching keyEvent
https://bugs.webkit.org/show_bug.cgi?id=67941

Patch by Scott Graham <scottmg@chromium.org> on 2011-09-23
Reviewed by Darin Fisher.

Use focusedWebCoreNode() to handle null document for frame when
retrieving focused node in handling keyEvent.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::keyEvent):

2:39 PM Changeset in webkit [95860] by fsamuel@chromium.org

7 edits in trunk/Source

Refactor paintOverhangAreas to allow non-Mac Chromium platforms to reuse code
https://bugs.webkit.org/show_bug.cgi?id=68648

Reviewed by Dimitri Glazkov.

Source/WebCore:

No new tests because there's no change in functionality (yet).

platform/chromium/ScrollbarThemeChromium.cpp:

(WebCore::ScrollbarThemeChromium::ScrollbarThemeChromium):
(WebCore::ScrollbarThemeChromium::~ScrollbarThemeChromium):
(WebCore::ScrollbarThemeChromium::paintOverhangAreas):

platform/chromium/ScrollbarThemeChromium.h:
platform/chromium/ScrollbarThemeChromiumMac.h:
platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):

Source/WebKit/chromium:

features.gypi:

2:35 PM Changeset in webkit [95859] by ojan@chromium.org

8 edits in trunk

remove physical flex-flow values to match the updated spec
https://bugs.webkit.org/show_bug.cgi?id=68728

Reviewed by Tony Chang.

Source/WebCore:

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexFlow):

css/CSSValueKeywords.in:
rendering/style/RenderStyleConstants.h:

LayoutTests:

css3/flexbox/css-properties-expected.txt:
css3/flexbox/script-tests/css-properties.js:

2:31 PM Changeset in webkit [95858] by Adam Roben

1 copy in tags/Safari-535.3.1-Win

New tag

2:01 PM Changeset in webkit [95857] by inferno@chromium.org

4 edits
3 adds in trunk

Source/WebCore: Style not updated for :before, :after content
in ruby text.
https://bugs.webkit.org/show_bug.cgi?id=68625

Reviewed by Dave Hyatt.

Test: fast/ruby/ruby-text-before-after-content.html

rendering/RenderRubyText.cpp:

(WebCore::RenderRubyText::updateBeforeAfterContent):

rendering/RenderRubyText.h:

LayoutTests: Style not updated for :before, :after content
in ruby text.
https://bugs.webkit.org/show_bug.cgi?id=68625

Reviewed by Dave Hyatt.

fast/ruby/ruby-text-before-after-content-expected.png: Added.
fast/ruby/ruby-text-before-after-content-expected.txt: Added.
fast/ruby/ruby-text-before-after-content.html: Added.

1:32 PM Changeset in webkit [95856] by ojan@chromium.org

5 edits in trunk/Source/WebCore

refactor RenderFlexibleBox to use flex-flow aware methods
https://bugs.webkit.org/show_bug.cgi?id=68665

Reviewed by Tony Chang.

This is just a refactor. Just move the all the code that needs to
be flow aware into helper functions. Actually making them flow-aware
can be done in a followup patch.

rendering/RenderBlock.cpp:
rendering/RenderBlock.h:

Moved setLogicalLocationForChild into RenderFlexibleBox since that was the only caller.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::hasOrthogonalFlow):
(WebCore::RenderFlexibleBox::isHorizontalFlow):
(WebCore::RenderFlexibleBox::isLeftToRightFlow):
(WebCore::RenderFlexibleBox::setFlowAwareLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareLogicalHeightForChild):
(WebCore::RenderFlexibleBox::flowAwareLogicalWidthForChild):
(WebCore::RenderFlexibleBox::flowAwareLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareContentLogicalWidth):
(WebCore::RenderFlexibleBox::flowAwareAvailableLogicalWidth):
(WebCore::RenderFlexibleBox::flowAwareBorderStart):
(WebCore::RenderFlexibleBox::flowAwareBorderBefore):
(WebCore::RenderFlexibleBox::flowAwareBorderAfter):
(WebCore::RenderFlexibleBox::flowAwarePaddingStart):
(WebCore::RenderFlexibleBox::flowAwarePaddingBefore):
(WebCore::RenderFlexibleBox::flowAwarePaddingAfter):
(WebCore::RenderFlexibleBox::flowAwareMarginStartForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginBeforeForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginAfterForChild):
(WebCore::RenderFlexibleBox::setFlowAwareMarginStartForChild):
(WebCore::RenderFlexibleBox::setFlowAwareMarginEndForChild):
(WebCore::RenderFlexibleBox::setFlowAwareLogicalLocationForChild):
(WebCore::RenderFlexibleBox::logicalBorderAndPaddingWidthForChild):
(WebCore::RenderFlexibleBox::logicalScrollbarHeightForChild):
(WebCore::RenderFlexibleBox::marginStartStyleForChild):
(WebCore::RenderFlexibleBox::marginEndStyleForChild):
(WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
(WebCore::RenderFlexibleBox::layoutInlineDirection):
(WebCore::RenderFlexibleBox::logicalPositiveFlexForChild):
(WebCore::RenderFlexibleBox::logicalNegativeFlexForChild):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::setLogicalOverrideSize):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):

rendering/RenderFlexibleBox.h:

1:25 PM Changeset in webkit [95855] by hyatt@apple.com

7 edits
6 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=68719

Push through multiple regions when an object doesn't fit in any of them. Unlike with pages and
columns, when regions have a non-uniform height, we may need to push through multiple regions
in order to find one that fits.

Added an optimization for quickly noticing if regions do have a uniform height so that we can
treat them like columns and pages if so.

Also fixed the end line matchup to properly null out endLine when no next line box exists. The new
layout tests I wrote to cover this feature exposed this crasher, so fixing it in order to land
the new tests.

Reviewed by Anders Carlsson.

Source/WebCore:

Added new tests in fast/regions.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::pushToNextPageWithMinimumLogicalHeight):
(WebCore::RenderBlock::adjustLinePositionForPagination):

rendering/RenderBlock.h:
rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::matchedEndLine):

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):

rendering/RenderFlowThread.h:

LayoutTests:

fast/regions/webkit-flow-float-pushed-to-last-region.html: Added.
fast/regions/webkit-flow-float-unable-to-push.html: Added.
platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Added.
platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.png: Added.
platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.

1:21 PM Changeset in webkit [95854] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

PutScopedVar nodes should report that it has a var number
https://bugs.webkit.org/show_bug.cgi?id=68721

Reviewed by Anders Carlsson.

Another assertion fix.

dfg/DFGNode.h:

(JSC::DFG::Node::hasVarNumber):

1:11 PM Changeset in webkit [95853] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Move WebHitTestResult files to Shared/ in the Xcode project
https://bugs.webkit.org/show_bug.cgi?id=68718

Reviewed by Sam Weinig.

WebKit2.xcodeproj/project.pbxproj:

12:56 PM Changeset in webkit [95852] by jchaffraix@webkit.org

10 edits
47 adds in trunk

Redrawing dirty parts of a large table is very slow
https://bugs.webkit.org/show_bug.cgi?id=64546

Patch by Konstantin Scheglov <scheglov@google.com> on 2011-09-23
Reviewed by David Hyatt.

Source/WebCore:

Move CollapsedBorderValues into RenderTable.h.
Calculate collapsed borders only once and re-use during paintObject().
Invalidate cache when cell, row, row group, col, col group or table border is changed.

Tests: fast/table/border-collapsing/cached-cell-append.html

fast/table/border-collapsing/cached-cell-remove.html
fast/table/border-collapsing/cached-change-cell-border-color.html
fast/table/border-collapsing/cached-change-cell-border-width.html
fast/table/border-collapsing/cached-change-col-border-color.html
fast/table/border-collapsing/cached-change-col-border-width.html
fast/table/border-collapsing/cached-change-colgroup-border-color.html
fast/table/border-collapsing/cached-change-colgroup-border-width.html
fast/table/border-collapsing/cached-change-row-border-color.html
fast/table/border-collapsing/cached-change-row-border-width.html
fast/table/border-collapsing/cached-change-table-border-color.html
fast/table/border-collapsing/cached-change-table-border-width.html
fast/table/border-collapsing/cached-change-tbody-border-color.html
fast/table/border-collapsing/cached-change-tbody-border-width.html

rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::styleDidChange): Invalidate cache on border change.
(WebCore::RenderTable::layout): Invalidate cache if layout changed.
(WebCore::RenderTable::recalcCollapsedBorders): Ensures that cache is valid.
(WebCore::RenderTable::paintObject): Use cached collapsed borders.

rendering/RenderTable.h:

(WebCore::RenderTable::invalidateCollapsedBorders): Accessor to mark cache invalid.
(WebCore::RenderTable::currentBorderValue): Rename to use word "value".

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleDidChange): If border changed, invalidate cache.

Rename to use word "value".
(WebCore::addBorderStyle):
(WebCore::RenderTableCell::collectBorderValues):
(WebCore::compareBorderValuesForQSort):
(WebCore::RenderTableCell::sortBorderValues):
(WebCore::RenderTableCell::paintCollapsedBorder):

rendering/RenderTableCell.h:

If border changed, invalidate cache.

rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::styleDidChange):

rendering/RenderTableCol.h:
rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleDidChange):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::styleDidChange):

LayoutTests:

Tests for invalidating collapsed borders cache.

fast/table/border-collapsing/cached-cell-append-expected.png: Added.
fast/table/border-collapsing/cached-cell-append-expected.txt: Added.
fast/table/border-collapsing/cached-cell-append.html: Added.
fast/table/border-collapsing/cached-cell-remove-expected.png: Added.
fast/table/border-collapsing/cached-cell-remove-expected.txt: Added.
fast/table/border-collapsing/cached-cell-remove.html: Added.
fast/table/border-collapsing/cached-change-cell-border-color-expected.png: Added.
fast/table/border-collapsing/cached-change-cell-border-color-expected.txt: Added.
fast/table/border-collapsing/cached-change-cell-border-color.html: Added.
fast/table/border-collapsing/cached-change-cell-border-width-expected.png: Added.
fast/table/border-collapsing/cached-change-cell-border-width-expected.txt: Added.
fast/table/border-collapsing/cached-change-cell-border-width.html: Added.
fast/table/border-collapsing/cached-change-col-border-color-expected.png: Added.
fast/table/border-collapsing/cached-change-col-border-color-expected.txt: Added.
fast/table/border-collapsing/cached-change-col-border-color.html: Added.
fast/table/border-collapsing/cached-change-col-border-width-expected.png: Added.
fast/table/border-collapsing/cached-change-col-border-width-expected.txt: Added.
fast/table/border-collapsing/cached-change-col-border-width.html: Added.
fast/table/border-collapsing/cached-change-colgroup-border-color-expected.png: Added.
fast/table/border-collapsing/cached-change-colgroup-border-color-expected.txt: Added.
fast/table/border-collapsing/cached-change-colgroup-border-color.html: Added.
fast/table/border-collapsing/cached-change-colgroup-border-width-expected.png: Added.
fast/table/border-collapsing/cached-change-colgroup-border-width-expected.txt: Added.
fast/table/border-collapsing/cached-change-colgroup-border-width.html: Added.
fast/table/border-collapsing/cached-change-row-border-color-expected.png: Added.
fast/table/border-collapsing/cached-change-row-border-color-expected.txt: Added.
fast/table/border-collapsing/cached-change-row-border-color.html: Added.
fast/table/border-collapsing/cached-change-row-border-width-expected.png: Added.
fast/table/border-collapsing/cached-change-row-border-width-expected.txt: Added.
fast/table/border-collapsing/cached-change-row-border-width.html: Added.
fast/table/border-collapsing/cached-change-table-border-color-expected.png: Added.
fast/table/border-collapsing/cached-change-table-border-color-expected.txt: Added.
fast/table/border-collapsing/cached-change-table-border-color.html: Added.
fast/table/border-collapsing/cached-change-table-border-width-expected.png: Added.
fast/table/border-collapsing/cached-change-table-border-width-expected.txt: Added.
fast/table/border-collapsing/cached-change-table-border-width.html: Added.
fast/table/border-collapsing/cached-change-tbody-border-color-expected.png: Added.
fast/table/border-collapsing/cached-change-tbody-border-color-expected.txt: Added.
fast/table/border-collapsing/cached-change-tbody-border-color.html: Added.
fast/table/border-collapsing/cached-change-tbody-border-width-expected.png: Added.
fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt: Added.
fast/table/border-collapsing/cached-change-tbody-border-width.html: Added.

12:48 PM Changeset in webkit [95851] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Add a bunch of unhandled node types to the propagator
https://bugs.webkit.org/show_bug.cgi?id=68716

Reviewed by Darin Adler.

Remove the ASSERT_NOT_REACHED() default for debug builds in the
prediction propagator, this way unhandled nodes will just cause
compile time failures rather than failing at some point in the
future.

dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

12:46 PM Changeset in webkit [95850] by mihaip@chromium.org

5 edits in trunk

update layout_tests to account for new default of use_skia=1
https://bugs.webkit.org/show_bug.cgi?id=68698

Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
from http://src.chromium.org/viewvc/chrome?view=rev&revision=102532
(Chromium-on-Mac now uses the Skia graphics library instead of
Core Graphics).

Also updates layout_test code to work with that change.

Patch by Elliot Poger <epoger@google.com> on 2011-09-23
Reviewed by Mihai Parparita.

Source/WebKit/chromium:

DEPS:

Tools:

Scripts/webkitpy/layout_tests/port/chromium_mac.py:
Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

12:40 PM Changeset in webkit [95849] by mhahnenberg@apple.com

81 edits in trunk

Add static version of JSCell::visitChildren
https://bugs.webkit.org/show_bug.cgi?id=68404

Reviewed by Darin Adler.

In this patch we just extract the bodies of the virtual visitChildren methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of visitChildren into our own custom vtable stored in
ClassInfo. We need to convert the methods to static methods in order to be
able to more easily store and refer to them in our custom vtable since normal
member methods store some implicit information in their types, making it
impossible to store them generically in ClassInfo.

Source/autotools/symbols.filter:

Source/JavaScriptCore:

API/JSCallbackObject.h:

(JSC::JSCallbackObject::visitChildrenVirtual):
(JSC::JSCallbackObject::visitChildren):

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::visitChildrenVirtual):
(JSC::DebuggerActivation::visitChildren):

debugger/DebuggerActivation.h:
heap/MarkStack.cpp:

(JSC::SlotVisitor::visitChildren):
(JSC::SlotVisitor::drain):

runtime/Arguments.cpp:

(JSC::Arguments::visitChildrenVirtual):
(JSC::Arguments::visitChildren):

runtime/Arguments.h:
runtime/Executable.cpp:

(JSC::EvalExecutable::visitChildrenVirtual):
(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildrenVirtual):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildrenVirtual):
(JSC::FunctionExecutable::visitChildren):

runtime/Executable.h:
runtime/GetterSetter.cpp:

(JSC::GetterSetter::visitChildrenVirtual):
(JSC::GetterSetter::visitChildren):

runtime/GetterSetter.h:
runtime/JSActivation.cpp:

(JSC::JSActivation::visitChildrenVirtual):
(JSC::JSActivation::visitChildren):

runtime/JSActivation.h:
runtime/JSArray.cpp:

(JSC::JSArray::visitChildrenVirtual):
(JSC::JSArray::visitChildren):

runtime/JSArray.h:
runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::visitChildrenVirtual):
(JSC::JSBoundFunction::visitChildren):

runtime/JSBoundFunction.h:
runtime/JSCell.h:

(JSC::JSCell::visitChildrenVirtual):
(JSC::JSCell::visitChildren):

runtime/JSFunction.cpp:

(JSC::JSFunction::visitChildrenVirtual):
(JSC::JSFunction::visitChildren):

runtime/JSFunction.h:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::visitChildrenVirtual):
(JSC::JSGlobalObject::visitChildren):

runtime/JSGlobalObject.h:
runtime/JSObject.cpp:

(JSC::JSObject::visitChildrenVirtual):
(JSC::JSObject::visitChildren):

runtime/JSObject.h:

(JSC::JSObject::visitChildrenDirect):

runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::visitChildrenVirtual):
(JSC::JSPropertyNameIterator::visitChildren):

runtime/JSPropertyNameIterator.h:
runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::visitChildrenVirtual):
(JSC::JSStaticScopeObject::visitChildren):

runtime/JSStaticScopeObject.h:
runtime/JSWrapperObject.cpp:

(JSC::JSWrapperObject::visitChildrenVirtual):
(JSC::JSWrapperObject::visitChildren):

runtime/JSWrapperObject.h:
runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::visitChildrenVirtual):
(JSC::NativeErrorConstructor::visitChildren):

runtime/NativeErrorConstructor.h:
runtime/RegExpObject.cpp:

(JSC::RegExpObject::visitChildrenVirtual):
(JSC::RegExpObject::visitChildren):

runtime/RegExpObject.h:
runtime/ScopeChain.cpp:

(JSC::ScopeChainNode::visitChildrenVirtual):
(JSC::ScopeChainNode::visitChildren):

runtime/ScopeChain.h:
runtime/Structure.cpp:

(JSC::Structure::visitChildrenVirtual):
(JSC::Structure::visitChildren):

runtime/Structure.h:
runtime/StructureChain.cpp:

(JSC::StructureChain::visitChildrenVirtual):
(JSC::StructureChain::visitChildren):

runtime/StructureChain.h:

Source/JavaScriptGlue:

UserObjectImp.cpp:

(UserObjectImp::visitChildrenVirtual):
(UserObjectImp::visitChildren):

UserObjectImp.h:

Source/WebCore:

No new tests.

WebCore.exp.in:
bindings/js/JSAttrCustom.cpp:

(WebCore::JSAttr::visitChildrenVirtual):
(WebCore::JSAttr::visitChildren):

bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContext::visitChildrenVirtual):
(WebCore::JSAudioContext::visitChildren):

bindings/js/JSCSSRuleCustom.cpp:

(WebCore::JSCSSRule::visitChildrenVirtual):
(WebCore::JSCSSRule::visitChildren):

bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::visitChildrenVirtual):
(WebCore::JSCSSStyleDeclaration::visitChildren):

bindings/js/JSCanvasRenderingContextCustom.cpp:

(WebCore::JSCanvasRenderingContext::visitChildrenVirtual):
(WebCore::JSCanvasRenderingContext::visitChildren):

bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::visitChildrenVirtual):
(WebCore::JSDOMGlobalObject::visitChildren):

bindings/js/JSDOMGlobalObject.h:
bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::visitChildrenVirtual):
(WebCore::JSDOMWindow::visitChildren):

bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::visitChildrenVirtual):
(WebCore::JSDOMWindowShell::visitChildren):

bindings/js/JSDOMWindowShell.h:
bindings/js/JSJavaScriptAudioNodeCustom.cpp:

(WebCore::JSJavaScriptAudioNode::visitChildrenVirtual):
(WebCore::JSJavaScriptAudioNode::visitChildren):

bindings/js/JSMessageChannelCustom.cpp:

(WebCore::JSMessageChannel::visitChildrenVirtual):
(WebCore::JSMessageChannel::visitChildren):

bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::visitChildrenVirtual):
(WebCore::JSMessagePort::visitChildren):

bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::visitChildrenVirtual):
(WebCore::JSNamedNodeMap::visitChildren):

bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::visitChildrenVirtual):
(WebCore::JSNode::visitChildren):

bindings/js/JSNodeFilterCustom.cpp:

(WebCore::JSNodeFilter::visitChildrenVirtual):
(WebCore::JSNodeFilter::visitChildren):

bindings/js/JSNodeIteratorCustom.cpp:

(WebCore::JSNodeIterator::visitChildrenVirtual):
(WebCore::JSNodeIterator::visitChildren):

bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::visitChildrenVirtual):
(WebCore::JSSVGElementInstance::visitChildren):

bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorker::visitChildrenVirtual):
(WebCore::JSSharedWorker::visitChildren):

bindings/js/JSStyleSheetCustom.cpp:

(WebCore::JSStyleSheet::visitChildrenVirtual):
(WebCore::JSStyleSheet::visitChildren):

bindings/js/JSTreeWalkerCustom.cpp:

(WebCore::JSTreeWalker::visitChildrenVirtual):
(WebCore::JSTreeWalker::visitChildren):

bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::JSWebGLRenderingContext::visitChildrenVirtual):
(WebCore::JSWebGLRenderingContext::visitChildren):

bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::visitChildrenVirtual):
(WebCore::JSWorkerContext::visitChildren):

bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::visitChildrenVirtual):
(WebCore::JSXMLHttpRequest::visitChildren):

bindings/js/JSXPathResultCustom.cpp:

(WebCore::JSXPathResult::visitChildrenVirtual):
(WebCore::JSXPathResult::visitChildren):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::visitChildrenVirtual):
(WebCore::JSTestObj::visitChildren):

bindings/scripts/test/JS/JSTestObj.h:
bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObject::visitChildrenVirtual):
(JSC::Bindings::QtRuntimeObject::visitChildren):

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::visitChildrenVirtual):
(JSC::Bindings::QtRuntimeMetaMethod::visitChildren):

bridge/qt/qt_runtime.h:
workers/WorkerContext.h:

12:31 PM Changeset in webkit [95848] by andersca@apple.com

3 edits
1 delete in trunk/Source/WebKit

Axe WebImageRendererFactory
https://bugs.webkit.org/show_bug.cgi?id=68715

Reviewed by Darin Adler.

../..:

Remove WebImageRendererFactory.m from the Xcode project.

WebKit.xcodeproj/project.pbxproj:

../../mac:

Remove WebImageRendererFactory, it was used by Safari 3, many a moon ago.

WebCoreSupport/WebImageRendererFactory.m: Removed.

12:24 PM Changeset in webkit [95847] by andersca@apple.com

15 edits in trunk/Source/WebKit

Add OVERRIDE to a bunch of virtual member functions on clients
https://bugs.webkit.org/show_bug.cgi?id=68712

Reviewed by Sam Weinig.

../..:

WebKit.xcodeproj/project.pbxproj:

../../mac:

Configurations/Base.xcconfig:
WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebContextMenuClient.h:
WebCoreSupport/WebDeviceOrientationClient.h:
WebCoreSupport/WebDragClient.h:
WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameNetworkingContext.h:
WebCoreSupport/WebGeolocationClient.h:
WebCoreSupport/WebIconDatabaseClient.h:
WebCoreSupport/WebInspectorClient.h:
WebCoreSupport/WebPlatformStrategies.h:

12:19 PM Changeset in webkit [95846] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Node propagation doesn't handle PutScopedVar
https://bugs.webkit.org/show_bug.cgi?id=68713

Reviewed by Sam Weinig.

This was causing assertion failures.

dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

12:19 PM Changeset in webkit [95845] by jochen@chromium.org

17 edits
4 copies in trunk/LayoutTests

Clarify wording in cross origin XSL tests and enable on all platforms
https://bugs.webkit.org/show_bug.cgi?id=68683

The condition for passing the test should be more clear now. Also, since the redirect case works on all platforms, the regular case should also work on all platforms.

Reviewed by Alexey Proskuryakov.

http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
http/tests/security/cross-origin-xsl-BLOCKED.html:
http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
http/tests/security/cross-origin-xsl-redirect-BLOCKED.html:
platform/chromium-cg-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
platform/chromium-cg-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
platform/chromium-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
platform/chromium-win/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
platform/gtk/Skipped:
platform/gtk/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
platform/mac-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
platform/mac-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
platform/qt-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
platform/qt-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
platform/win-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
platform/win-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
platform/wk2/Skipped:

12:17 PM Changeset in webkit [95844] by andersca@apple.com

2 edits in trunk/Source/JavaScriptCore

Make sure to define OVERRIDE and FINAL for older builds of clang.

wtf/Compiler.h:

12:07 PM Changeset in webkit [95843] by mihaip@chromium.org

2 edits in trunk/LayoutTests

Mark two more tests as flaky.

platform/chromium/test_expectations.txt:

12:07 PM Changeset in webkit [95842] by loislo@chromium.org

2 edits
4 copies in branches/chromium/874

Merge 95410 - Web Inspector: didMarkDOMContentEvent() should send event of MarkDOMContent type.
https://bugs.webkit.org/show_bug.cgi?id=67528

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: inspector/timeline/timeline-dom-content-loaded-event.html

inspector/timeline/timeline-load-event.html

inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):

LayoutTests:

inspector/timeline/timeline-animation-frame.html:
inspector/timeline/timeline-dom-content-loaded-event-expected.txt: Added.
inspector/timeline/timeline-dom-content-loaded-event.html: Added.
inspector/timeline/timeline-load-event-expected.txt: Added.
inspector/timeline/timeline-load-event.html: Added.
inspector/timeline/timeline-test.js:

(initialize_Timeline.InspectorTest.waitForRecordType.addRecord):
(initialize_Timeline.InspectorTest.waitForRecordType):

TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/8021012

11:57 AM Changeset in webkit [95841] by loislo@chromium.org

2 edits in branches/chromium/874/Source/WebCore/inspector/front-end

Merge 95401 - Web Inspector: chromium-win: "Save timeline data" does nothing.
https://bugs.webkit.org/show_bug.cgi?id=68313

windows shell API function GetSaveFileName doesn't accept file names with ':' symbol.

Reviewed by Pavel Feldman.

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelineModel.prototype._saveToFile):

TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/8018012

11:52 AM Changeset in webkit [95840] by barraclough@apple.com

6 edits in trunk/Source/JavaScriptCore

Implement op_resolve_global in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=68704

Reviewed by Oliver Hunt.

This is performance neutral, but increases coverage.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGNode.h:

(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::resolveInfoIndex):

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

11:51 AM Changeset in webkit [95839] by mario@webkit.org

2 edits in trunk/Source/WebCore

[GTK] Remove extra space at the beginning of the last line.
https://bugs.webkit.org/show_bug.cgi?id=68710

Reviewed by Gustavo Noronha Silva.

platform/network/soup/SocketStreamHandleSoup.cpp:

11:41 AM Changeset in webkit [95838] by mihaip@chromium.org

2 edits in trunk/LayoutTests

Mark a test as flaky.

platform/chromium/test_expectations.txt:

11:24 AM Changeset in webkit [95837] by mario@webkit.org

2 edits in trunk/Source/WebCore

2011-09-23 Mario Sanchez Prada <msanchez@igalia.com>

[GTK] Fix coding style issues in ResourceRequestSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=68707

Reviewed by Xan Lopez.

This patch fixes some issues as reported by check-webkit-style.

platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateFromSoupMessage):

11:18 AM Changeset in webkit [95836] by Martin Robinson

1370 edits
476 copies
30 deletes in releases/WebKitGTK/webkit-1.6

Updating WebKitGTK+ branch to to the state of the 1.5.90 release

11:15 AM Changeset in webkit [95835] by mihaip@chromium.org

1 edit in branches/chromium/874/LayoutTests/http/tests/history/back-with-fragment-change.php

Merge 95322 - http/tests/history/back-with-fragment-change.php fails on non-Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=68242

Skip test on ports on which it fails. Move comment to be inside
<?php> block so that HTTP headers can be set on all platforms (there
must not be any whitespace before the <?php> block).

http/tests/history/back-with-fragment-change.php:
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:

TBR=mihaip@chromium.org
Review URL: http://codereview.chromium.org/8018010

11:07 AM Changeset in webkit [95834] by andersca@apple.com

18 edits in trunk/Source/WebKit2

Add OVERRIDE to overrides of virtual member functions in client classes
https://bugs.webkit.org/show_bug.cgi?id=68702

Reviewed by Darin Adler.

Disable the warning in Xcode and VS2005 for using override and final when compiling as C++98,
and remove WebEditorClient::isEditable, WebChromeClient::formDidFocus,
WebChromeClient::formDidBlur and WebFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest since
they have been removed from their respective base classes.

Configurations/Base.xcconfig:
WebProcess/WebCoreSupport/WebChromeClient.cpp:
WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/WebCoreSupport/WebContextMenuClient.h:
WebProcess/WebCoreSupport/WebDatabaseManager.h:
WebProcess/WebCoreSupport/WebDragClient.h:
WebProcess/WebCoreSupport/WebEditorClient.cpp:
WebProcess/WebCoreSupport/WebEditorClient.h:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
WebProcess/WebCoreSupport/WebGeolocationClient.h:
WebProcess/WebCoreSupport/WebInspectorClient.h:
WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
WebProcess/WebCoreSupport/WebPlatformStrategies.h:
WebProcess/WebCoreSupport/WebPopupMenu.h:
WebProcess/WebCoreSupport/WebSearchPopupMenu.h:
win/WebKit2Common.vsprops:

10:46 AM Changeset in webkit [95833] by mrowe@apple.com

2 edits in trunk/Source/JavaScriptCore

Define BUILDING_ON_LION / TARGETING_LION when appropriate in Platform.h.

wtf/Platform.h:

10:46 AM Changeset in webkit [95832] by mrowe@apple.com

2 edits in trunk/Tools

Fix the build.

TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Define operator<<(std::ostream&, const WTF::String&) inside

the WTF namespace.

10:38 AM Changeset in webkit [95831] by Ademar Reis

2 edits in trunk/Source/WebCore

Unreviewed: [Qt] Workaround MSVC2010 problems when linking QtWebKit

Include MSVC2010 in the list of compilers where incremental
build is disabled (INCREMENTAL:NO).

Change suggested by Simo Falt <simo.falt@nokia.com>, already present
in the Qt-4.8 repository where the problem was identified.

WebCore.pri:

10:11 AM Changeset in webkit [95830] by jamesr@google.com

2 edits in branches/chromium/874/Source/WebCore

Merge 95668 - [chromium] SharedGraphicsContext3D's context should not be destroyed during atexit
https://bugs.webkit.org/show_bug.cgi?id=68558

Reviewed by Stephen White.

The SharedGraphicsContext3D's internal context is lazily created and then leaked intentionally, but since the
last ref is in a function-static RefPtr<> it ends up being destroyed at process exit time. This is bad, since
by the time we get this far in process shutdown we can't actually cleanly run the destruction logic and we
crash. Since we are explicitly leaking this for the lifetime of the process there's no point in keeping it in a
RefPtr<>

platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::get):

TBR=jamesr@google.com
Review URL: http://codereview.chromium.org/8020006

10:04 AM Changeset in webkit [95829] by inferno@chromium.org

11 edits in branches/chromium/874

Merge 94582 - Style not propagated to anonymous boxes and anonymous
inline-blocks.
BUG=95520
Review URL: http://codereview.chromium.org/8017007

10:03 AM Changeset in webkit [95828] by loislo@chromium.org

3 edits in trunk/LayoutTests

Unreviewed. Normalize test names.

inspector/performance/resources/first-open-elements.html:
inspector/performance/resources/first-open-resources.html:

10:01 AM Changeset in webkit [95827] by inferno@chromium.org

5 edits
4 copies in branches/chromium/874/LayoutTests/platform

Merge 95696 - Unreviewed. Chromium rebaselines for r95671.
BUG=95520
Review URL: http://codereview.chromium.org/8018006

9:59 AM Changeset in webkit [95826] by Darin Adler

2 edits in trunk/Source/WebCore

Try to fix warning seen in some 32-bit builds.

rendering/RenderBoxModelObject.cpp:

(WebCore::backgroundRectAdjustedForBleedAvoidance):
Use an explicit cast for the conversion from a double to a LayoutUnit.

9:59 AM Changeset in webkit [95825] by inferno@chromium.org

15 copies in branches/chromium/874/LayoutTests/platform

Merge 95477 - Unreviewed. Chromium Rebaselines for r95461.
BUG=95520
Review URL: http://codereview.chromium.org/8015011

9:57 AM Changeset in webkit [95824] by inferno@chromium.org

14 edits
3 copies in branches/chromium/874

Merge 95671 - Source/WebCore: Not use anonymousContainer on beforeChild calculation
and let later code handle it. Fix style update on block-level
anonymous objects.
BUG=95520
Review URL: http://codereview.chromium.org/8016006

9:49 AM Changeset in webkit [95823] by andersca@apple.com

2 edits in trunk/Source/JavaScriptCore

We should add support for OVERRIDE and FINAL annotations
https://bugs.webkit.org/show_bug.cgi?id=68654

Reviewed by David Hyatt.

Add OVERRIDE and FINAL macros for compilers that support them.

wtf/Compiler.h:

9:47 AM Changeset in webkit [95822] by yael.aharon@nokia.com

1 edit
1 move in trunk/LayoutTests

Fix typo in file name from http://trac.webkit.org/changeset/95813.

Unreviewed.

platform/gtk/media/video-playing-and-pause-actual.txt: Removed.
platform/gtk/media/video-playing-and-pause-expected.txt: Copied from LayoutTests/platform/gtk/media/video-playing-and-pause-actual.txt.

9:45 AM Changeset in webkit [95821] by inferno@chromium.org

3 edits in branches/chromium/874/Source/WebCore/dom

Merge 95600 - Style changes on forwarded shadow children should trigger shadow renderer reconstruction.
BUG=93788
Review URL: http://codereview.chromium.org/8002029

9:43 AM Changeset in webkit [95820] by inferno@chromium.org

1 edit in branches/chromium/874/Source/WebCore/dom/Document.cpp

Merge 95497
BUG=95639
Review URL: http://codereview.chromium.org/8016005

9:41 AM Changeset in webkit [95819] by inferno@chromium.org

1 edit
2 copies in branches/chromium/874

Merge 95059 - Source/WebCore: Fix crash when an iframe element is removed during a transition to
fullscreen.
BUG=95639
Review URL: http://codereview.chromium.org/8018005

9:39 AM Changeset in webkit [95818] by yael.aharon@nokia.com

1 edit
2 adds in trunk/LayoutTests

Rebaseline after http://trac.webkit.org/changeset/95799

Unreviewed.

platform/mac-wk2/media/video-playing-and-pause-expected.txt: Added.
platform/mac/media/video-playing-and-pause-expected.txt: Added.

9:38 AM Changeset in webkit [95817] by inferno@chromium.org

15 copies in branches/chromium/874/LayoutTests/fast/table

Merge 95461 - Child not placed correctly when beforeChild (table part)
BUG=95520
Review URL: http://codereview.chromium.org/8008019

9:31 AM Changeset in webkit [95816] by inferno@chromium.org

2 edits
2 copies in branches/chromium/874

Merge 95791 - use after free in WebCore::SVGTRefElement::updateReferencedText
BUG=95359
Review URL: http://codereview.chromium.org/8015009

9:26 AM Changeset in webkit [95815] by inferno@chromium.org

1 edit
3 copies in branches/chromium/874

Merge 95488 - Named property confusion with proto
BUG=95671
Review URL: http://codereview.chromium.org/8020005

9:20 AM Changeset in webkit [95814] by inferno@chromium.org

6 edits
2 copies in branches/chromium/874

Merge 95489 - [V8] document.all gets confused about its prototype chain
BUG=96885
Review URL: http://codereview.chromium.org/8015008

9:19 AM Changeset in webkit [95813] by yael.aharon@nokia.com

1 edit
1 add in trunk/LayoutTests

Rebaseline after http://trac.webkit.org/changeset/95799

Unreviewed.

platform/gtk/media/video-playing-and-pause-actual.txt: Added.

9:17 AM Changeset in webkit [95812] by inferno@chromium.org

2 edits
3 copies in branches/chromium/874

Merge 95580 - Invoke CachedResourceLoader::canRequest for all URLs in a redirect chain
BUG=97278
Review URL: http://codereview.chromium.org/8002026

9:14 AM Changeset in webkit [95811] by inferno@chromium.org

1 edit
2 copies in branches/chromium/874

Merge 95667 - [Chromium] Protect the Frame in V8HTMLDocument::openCallback
BUG=97451
Review URL: http://codereview.chromium.org/8015007

9:13 AM Changeset in webkit [95810] by inferno@chromium.org

1 edit
2 copies in branches/chromium/874

Merge 95689 - [Chromium] Protect message ports from being deleted in V8MessageEvent::portsAccessorGetter
BUG=97520
Review URL: http://codereview.chromium.org/8016003

9:10 AM Changeset in webkit [95809] by xan@webkit.org

2 edits in trunk/LayoutTests

2011-09-23 Xan Lopez <xlopez@igalia.com>

[GTK] Skip crashing test fast/workers/storage/interrupt-database.html
https://bugs.webkit.org/show_bug.cgi?id=68700

Unreviewed.

platform/gtk/Skipped:

9:09 AM Changeset in webkit [95808] by inferno@chromium.org

4 edits
2 copies in branches/chromium/874

Merge 95728 - Ref protect shaders in V8WebGLRenderingContext::getAttachedShadersCallback
BUG=97615
Review URL: http://codereview.chromium.org/8015006

8:57 AM Changeset in webkit [95807] by vsevik@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: Clicking on error doesn't point on the correct line if user searched something
https://bugs.webkit.org/show_bug.cgi?id=68627

Reviewed by Yury Semikhatsky.

inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype.disableSearchUntilExplicitAction):

inspector/front-end/inspector.js:

(WebInspector._showAnchorLocationInPanel):

8:48 AM QtWebKitReleases edited by Ademar Reis

(diff)

8:22 AM Changeset in webkit [95806] by vsevik@chromium.org

4 edits
6 adds in trunk

Web Inspector: InspectorStyleSheet should use stylesheet's original url, not final one.
https://bugs.webkit.org/show_bug.cgi?id=68631

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: http/tests/inspector/styles/styles-redirected-css.html

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::resourceStyleSheetText):

LayoutTests:

http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.getElementStylePropertyTreeItem):
(initialize_ElementTest.InspectorTest.getMatchedStylePropertyTreeItem):
(initialize_ElementTest.InspectorTest.getFirstPropertyTreeItemForSection):

http/tests/inspector/styles/resources/styles-redirected-css.css: Added.

(div):

http/tests/inspector/styles/resources/styles-redirected-css.php: Added.
http/tests/inspector/styles/styles-redirected-css-expected.txt: Added.
http/tests/inspector/styles/styles-redirected-css.html: Added.

8:08 AM Changeset in webkit [95805] by vsevik@chromium.org

3 edits
2 adds in trunk

Web Inspector: XHRs requests with the same url as main resource should have correct category.
https://bugs.webkit.org/show_bug.cgi?id=68646

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: http/tests/inspector/network/network-xhr-same-url-as-main-resource.html

inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didReceiveResponse):

LayoutTests:

http/tests/inspector/network/network-xhr-same-url-as-main-resource-expected.txt: Added.
http/tests/inspector/network/network-xhr-same-url-as-main-resource.html: Added.

8:06 AM Changeset in webkit [95804] by jesus@webkit.org

4 edits in trunk/Source/WebKit2

[Qt][WK2] QtFileDownloader ctor shouldn't call QtFileDownloader::onReadyRead()
https://bugs.webkit.org/show_bug.cgi?id=68696

Reviewed by Andreas Kling.

Instead of connecting signals and calling QtFileDownloader::onReadyRead()
on its constructor, QtFileDownloader will now handle this in start().

WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::start):

WebProcess/Downloads/qt/QtFileDownloader.cpp:

(WebKit::QtFileDownloader::QtFileDownloader):
(WebKit::QtFileDownloader::start):

WebProcess/Downloads/qt/QtFileDownloader.h:

7:59 AM Changeset in webkit [95803] by pfeldman@chromium.org

2 edits
3 copies in branches/chromium/874

Merge 95083 - Web Inspector: [v8] building call frame info for location-less internal script function crashes.
https://bugs.webkit.org/show_bug.cgi?id=67991

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/debugger-pause-in-internal.html

bindings/v8/DebuggerScript.js:
bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::currentCallFrame):

LayoutTests:

inspector/debugger/debugger-pause-in-internal-expected.txt: Added.
inspector/debugger/debugger-pause-in-internal.html: Added.
inspector/debugger/debugger-pause-on-exception-crash-expected.txt: Added.
platform/chromium/inspector/debugger/debugger-pause-in-internal-expected.txt: Added.

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/8017006

7:58 AM Changeset in webkit [95802] by bulach@chromium.org

2 edits in trunk/LayoutTests

[chromium] Update expectation for pservers-grad-14-b.svg on snowleopard
https://bugs.webkit.org/show_bug.cgi?id=68697

Unreviewed rebaseline.

platform/chromium/test_expectations.txt:

7:35 AM Changeset in webkit [95801] by vsevik@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: Add context menu action to navigate from resources panel resource to network panel.
https://bugs.webkit.org/show_bug.cgi?id=68657

Reviewed by Yury Semikhatsky.

English.lproj/localizedStrings.js:
inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkPanel.prototype.showAnchorLocation):
(WebInspector.NetworkPanel.prototype.revealAndHighlightResource):

inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
(WebInspector.FrameResourceTreeElement.prototype._appendOpenInNetworkPanelAction):

inspector/front-end/inspector.js:

(WebInspector.openInNetworkPanelLabel):
(WebInspector.openRequestInNetworkPanel):

7:14 AM Changeset in webkit [95800] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[Gtk] Title attribute is not respected on option elements.
https://bugs.webkit.org/show_bug.cgi?id=68615

Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-09-23
Reviewed by Martin Robinson.

Set tooltip on PopupMenuGtk items created from GtkActions.

platform/gtk/GtkPopupMenu.cpp:

(WebCore::GtkPopupMenu::appendItem): Added a call to gtk_widget_set_tooltip_text()

to set the tooltip on menuitem. Tooltip text is retrieved from GtkAction.

platform/gtk/PopupMenuGtk.cpp:

(WebCore::PopupMenuGtk::createGtkActionForMenuItem): Pass the tooltip text

from client when creating a GtkAction.

7:03 AM Changeset in webkit [95799] by yael.aharon@nokia.com

4 edits
3 adds in trunk

[Qt][Gtk] Wrong state when pausing a video in the "playing" event handler
https://bugs.webkit.org/show_bug.cgi?id=68589

Reviewed by Philippe Normand.

Source/WebCore:

Test: media/video-playing-and-pause.html

As suggested by Alexis Menard on IRC, query gstreamer's state instead of using a cached value
in MediaPlayerGstreamerPrivate::paused().

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::paused):

LayoutTests:

media/video-playing-and-pause.html: Added.
media/video-paint-test.js:
platform/qt/media/video-playing-and-pause-expected.txt: Added.
platform/qt/media/video-playing-and-pause-expected.png: Added.

6:48 AM Changeset in webkit [95798] by bulach@chromium.org

1 edit
2 moves
4 adds
2 deletes in trunk/LayoutTests

[chromium, gtk, qt] Rebaseline following r95726
https://bugs.webkit.org/show_bug.cgi?id=68694

Unreviewed rebaseline.

css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt.
css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt.
platform/chromium/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
platform/chromium/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Removed.
platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Removed.

6:17 AM Changeset in webkit [95797] by podivilov@chromium.org

5 edits in trunk

Web Inspector: skip overlapping scripts when displaying concatenated content.
https://bugs.webkit.org/show_bug.cgi?id=68144

Source/WebCore:

Dynamically appended script tags have wrong offsets and cause troubles building concatenated content.

Reviewed by Pavel Feldman.

inspector/front-end/SourceFile.js:

(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):

LayoutTests:

Reviewed by Pavel Feldman.

inspector/debugger/content-providers-expected.txt:
inspector/debugger/content-providers.html:

6:04 AM Changeset in webkit [95796] by xan@webkit.org

2 edits in trunk/LayoutTests

2011-09-23 Xan Lopez <xlopez@igalia.com>

[GTK] Rebaseline following r95745, r95725

Unreviewed rebaseline.

platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt:

5:43 AM Changeset in webkit [95795] by bulach@chromium.org

7 edits in trunk/LayoutTests

[chromium] Rebaseline following r95745, r95725
https://bugs.webkit.org/show_bug.cgi?id=68685

Unreviewed rebaseline.

platform/chromium-cg-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png:
platform/chromium-linux/editing/deleting/merge-whitespace-pre-expected.png:
platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.png:
platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.txt:
platform/chromium/test_expectations.txt:

5:06 AM Changeset in webkit [95794] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: file open dialog appears when user clicks on the timeline bar in timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=68312

Reviewed by Yury Semikhatsky.

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._createFileSelector):

4:43 AM Changeset in webkit [95793] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r95383.
http://trac.webkit.org/changeset/95383
https://bugs.webkit.org/show_bug.cgi?id=68690

It broke WebInspector.Timeline.LoadFromFile feature.
(Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-23

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._createFileSelector):

3:59 AM Changeset in webkit [95792] by loislo@chromium.org

1 edit
1 add in trunk/LayoutTests

Web Inspector: UI performance test for Scripts panel first open experience.
https://bugs.webkit.org/show_bug.cgi?id=68541

The test's body has dummy scripts section copied from inspector-test.jss

Reviewed by Yury Semikhatsky.

inspector/performance/resources/first-open-scripts.html:

3:56 AM Changeset in webkit [95791] by commit-queue@webkit.org

4 edits
2 adds in trunk

use after free in WebCore::SVGTRefElement::updateReferencedText
https://bugs.webkit.org/show_bug.cgi?id=67555

Patch by Rob Buis <rbuis@rim.com> on 2011-09-23
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Event listeners can outlive the tref element that created them when
the tref is cloned and then garbage collected, causing a dangling pointer to the
tref. To fix this do not install event listener until the tref is inserted into the document.

Test: svg/custom/tref-clone-crash.html

svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::svgAttributeChanged):
(WebCore::SVGTRefElement::insertedIntoDocument):

svg/SVGTRefElement.h:

LayoutTests:

Test that cloned tref does not cause a crash.

svg/custom/tref-clone-crash-expected.txt: Added.
svg/custom/tref-clone-crash.html: Added.

3:46 AM Changeset in webkit [95790] by vsevik@chromium.org

5 edits in trunk/Source/WebCore

ASSERTION FAILED: documentLoader in WebKit/Source/WebCore/inspector/InspectorInstrumentation.cpp(597)
https://bugs.webkit.org/show_bug.cgi?id=68291

Reviewed by Tony Chang.

dom/Document.cpp:

(WebCore::Document::finishedParsing):

inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
(WebCore::InspectorInstrumentation::loadEventFiredImpl):

inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::domContentLoadedEventFired):
(WebCore::InspectorInstrumentation::loadEventFired):

page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchLoadEvent):

3:35 AM Changeset in webkit [95789] by xan@webkit.org

2 edits in trunk/LayoutTests

2011-09-23 Xan Lopez <xlopez@igalia.com>

Crash on editing/pasteboard/drag-drop-input-in-svg.svg
https://bugs.webkit.org/show_bug.cgi?id=68686

Unreviewed, skip crashing test.

platform/gtk/Skipped:

2:19 AM Changeset in webkit [95788] by kbalazs@webkit.org

3 edits in trunk/LayoutTests

plugins/mouse-click-iframe-to-plugin.html should not use flash plugin
https://bugs.webkit.org/show_bug.cgi?id=68601

Use the test plugin that we always have.

platform/qt-wk2/Skipped: Unskip the test.
plugins/mouse-click-iframe-to-plugin.html:

12:18 AM Changeset in webkit [95787] by barraclough@apple.com

6 edits
3 adds in trunk

Source/JavaScriptCore: GetScopedVar should have value profiling
https://bugs.webkit.org/show_bug.cgi?id=68676

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-09-22
Reviewed by Oliver Hunt.

Added GetScopedVar value profiling and predictin propagation.
Added GetScopeChain to CSE.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):

dfg/DFGNode.h:

(JSC::DFG::Node::hasPrediction):

dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::getScopeChainLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_scoped_var):

LayoutTests: [Qt] Unreviewed gardening, update expected file after r95745.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2011-09-22

platform/qt/editing/deleting/merge-whitespace-pre-expected.png:
platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed