Context Navigation

← Previous Period
Next Period →

Timeline

Oct 2, 2011:

11:59 PM Changeset in webkit [96484] by tkent@chromium.org

14 edits
4 adds in trunk

method/enctype/formMethod/formEnctype properties should be limited to known values.
https://bugs.webkit.org/show_bug.cgi?id=68887

Reviewed by Hajime Morita.

Source/WebCore:

According to the standard and other browser behaviors, the
following IDL properties should be reflected to the corresponding
HTML attributes on setting, but should return normalized values on
getting.

HTMLFormElement::method
HTMLFormElement::enctype
HTMLInputElement::formMethod
HTMLInputElement::formEnctype
HTMLButtonElement::formMethod
HTMLButtonElement::formEnctype

Tests: fast/forms/enctype-attribute.html

fast/forms/method-attribute.html

html/HTMLButtonElement.idl:

Replace 'Reflect' with 'ConvertNullToNullString' in order to use a
getter function.

html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::formEnctype):
Normalizes the value by parseEncodingType().
(WebCore::HTMLFormControlElement::setFormEnctype):
Simply calls setAttribute()
(WebCore::HTMLFormControlElement::formMethod):
Normalizes the value by parseMethodType().
(WebCore::HTMLFormControlElement::setFormMethod):
Simply calls setAttribute()

html/HTMLFormControlElement.h:
html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::parseMappedAttribute):
Follow the Attributes function renaming.
(WebCore::HTMLFormElement::method):
Normalizes the value by parseMethodType().

html/HTMLFormElement.idl:

Replace 'Reflect' with 'ConvertNullToNullString' in order to use a
getter function.

html/HTMLInputElement.idl: ditto.
loader/FormSubmission.cpp:

(WebCore::FormSubmission::Attributes::parseEncodingType):
New function made from a part of old parseEncodingType().
(WebCore::FormSubmission::Attributes::updateEncodingType):
Renamed from parseEncodingType().
(WebCore::FormSubmission::Attributes::parseMethodType):
New function made from a part of old parseMethodType().
(WebCore::FormSubmission::Attributes::updateMethodType):
Renamed from parseMethodType().
(WebCore::FormSubmission::create):
Follow the Attributes function renaming.

loader/FormSubmission.h:

(WebCore::FormSubmission::Attributes::methodString):
A helper function to provide normalized strings for FormSubmission::Method.

LayoutTests:

fast/dom/element-attribute-js-null-expected.txt:
fast/dom/element-attribute-js-null.html: Correct an expectation for HTMLFormElement::method.
fast/forms/enctype-attribute-expected.txt: Added.
fast/forms/enctype-attribute.html: Added.
fast/forms/method-attribute-expected.txt: Added.
fast/forms/method-attribute.html: Added.
fast/forms/script-tests/submit-form-attributes.js: Correct expectations.
fast/forms/submit-form-attributes-expected.txt: ditto.

11:49 PM Changeset in webkit [96483] by zherczeg@webkit.org

2 edits in trunk/Source/JavaScriptCore

[Qt]REGRESSION(r95912): It made sputnik tests flakey
https://bugs.webkit.org/show_bug.cgi?id=68990

Reviewed by Geoffrey Garen.

Changing signed char to int in r96354 solved the
problem. However transitionCount still returns
with a signed char and should be changed to int.

runtime/Structure.h:

(JSC::Structure::transitionCount):

7:13 PM Changeset in webkit [96482] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG misses some obvious opportunities for common subexpression elimination
https://bugs.webkit.org/show_bug.cgi?id=69233

Reviewed by Oliver Hunt.

0.7% speed-up on SunSpider.

dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

6:11 PM Changeset in webkit [96481] by commit-queue@webkit.org

9 edits
1 copy in trunk/Source/WebKit/chromium

[chromium] Add WebWidget API for accessing the current WebCompositor
https://bugs.webkit.org/show_bug.cgi?id=69181

Patch by James Robinson <jamesr@chromium.org> on 2011-10-02
Reviewed by Darin Fisher.

Add new WebWidgetClient::did(Activate|Deactivate)Compositor calls intended to replace
didActivateAccleratedCompositing(bool) so that the enable call can be parameterized.

Add a WebCompositor identifier parameter to didEnableAcceleratedCompositing that can be used on the compositor
thread to get access to a WebCompositor pointer.

public/WebWidget.h:

(WebKit::WebWidget::compositor):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::compositor):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

src/WebViewImpl.h:

5:40 PM Changeset in webkit [96480] by weinig@apple.com

6 edits in trunk/Source

Strength reduce Mac only Frame::searchForLabelsBeforeElement and Frame::matchLabelsAgainstElement into callers
https://bugs.webkit.org/show_bug.cgi?id=69230

Reviewed by Anders Carlsson.

../WebCore:

WebCore.exp.in:
page/Frame.h:
page/mac/FrameMac.mm:

../WebKit/mac:

WebView/WebHTMLRepresentation.mm:

(regExpForLabels):
(searchForLabelsBeforeElement):
(matchLabelsAgainstString):
(matchLabelsAgainstElement):
(-[WebHTMLRepresentation searchForLabels:beforeElement:resultDistance:resultIsInCellAbove:]):
(-[WebHTMLRepresentation matchLabels:againstElement:]):

5:22 PM Changeset in webkit [96479] by barraclough@apple.com

5 edits in trunk

Bug 67455 - Different regular expression result

Reviewed by Darin Adler.

Fix a regression introduced in r72140. A return was added to the backtracking loop for
backtrackParentheses with QuantifierNonGreedy, so it always returns after one iteration.
This is incorrect. The additional return should only trigger to force an early return if
an error has occured.

Source/JavaScriptCore:

yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::matchParentheses):

Simplify some nested if else logic.

(JSC::Yarr::Interpreter::backtrackParentheses):

Simplify some nested if else logic.
Only return early from backtrackParentheses on success/error, not on failure.

LayoutTests:

fast/regex/parentheses-expected.txt:
fast/regex/script-tests/parentheses.js:
- Added test cases from bug.

1:02 PM Changeset in webkit [96478] by ap@apple.com

2 edits in trunk/Source/WebKit/mac

REGRESSION (r95474): Unable to type anywhere in nightly builds in WebKit1 mode
https://bugs.webkit.org/show_bug.cgi?id=68542

Reviewed by Mark Rowe.

WebView/WebView.mm: (-[WebView _usesDocumentViews]): Re-add this method for now.

12:54 PM Changeset in webkit [96477] by commit-queue@webkit.org

5 edits in trunk/Source

[Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch.
https://bugs.webkit.org/show_bug.cgi?id=69223

Source/WebCore:

Add a missing import (NSWindow.h) in WebVideoFullscreenHUDWindowController.
Add a missing include path and a missing objective source file to WebCore.pro.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-02
Reviewed by Noam Rosenthal.

No new tests, build fix.

WebCore.pro:
platform/mac/WebVideoFullscreenHUDWindowController.h:

Source/WebKit2:

After the merge of the Qt5 refactor branch, networking stuff has been
extracted into a separate library. The qmlplugin needs to link to that
library to get QNetworkReply defined.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-02
Reviewed by Noam Rosenthal.

UIProcess/API/qt/qmlplugin/qmlplugin.pro:

12:41 PM Changeset in webkit [96476] by jchaffraix@webkit.org

2 edits in trunk/Source/WebCore

Remove an unused member in RenderTable::ColumnStruct
https://bugs.webkit.org/show_bug.cgi?id=69119

Reviewed by Darin Adler.

No test as there should be no change in behavior.

The member was added several years ago and its users were removed or changed. The code would
need a refactoring but this would be tricky to get right. This change just removes the member
to reap the short-term benefits.

rendering/RenderTable.h:

(WebCore::RenderTable::ColumnStruct::ColumnStruct): Remove anything associated with m_width.

10:38 AM Changeset in webkit [96475] by abarth@webkit.org

1 edit
2 adds
15 deletes in trunk/LayoutTests

Remove temporary baselines after http://trac.webkit.org/changeset/96470.

platform/chromium-cg-mac-leopard/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
platform/chromium-cg-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
platform/chromium-cg-mac/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
platform/chromium-linux-x86/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
platform/chromium-linux-x86/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
platform/chromium-win-vista/svg/css: Removed.
platform/chromium-win-vista/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
platform/chromium-win-xp/svg/css: Removed.
platform/chromium-win-xp/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
platform/chromium-win/svg/filters/filter-clip-expected.txt: Removed.
platform/chromium/svg/filters: Removed.
platform/chromium/svg/filters/filter-clip-expected.txt: Removed.
platform/gtk/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
svg/css/circle-in-mask-with-shadow-expected.txt: Added.

10:35 AM Changeset in webkit [96474] by abarth@webkit.org

3 edits in trunk/Tools

Clean up obsolete code in gardeningserver.py related to
STATIC_FILE_NAMES. Rather than serve the UI via the Python HTTP
server, we just serve it off the filesystem directly.

We had planned to serve the UI off build.webkit.org, but that server is
somewhat slow. We'll probably serve the UI of some web server, but
we'll need to work that out later.

Scripts/webkitpy/tool/commands/gardenomatic.py:
Scripts/webkitpy/tool/servers/gardeningserver.py:

10:18 AM Changeset in webkit [96473] by abarth@webkit.org

10 edits in trunk/Tools

Rip out half-backed garden-o-matic features in preparation for wider use
https://bugs.webkit.org/show_bug.cgi?id=69226

This patch rips out a bunch of half-baked features and cleans up a
bunch of small nits with the core set of features. We're going to ask
more folks to start using the tool, and having a bunch of half-baked
features around is distracting. We can add these features back under a
flag and interate on them after we've got the core functionality
nailed.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:

8:25 AM Changeset in webkit [96472] by abarth@webkit.org

14 edits
22 adds
10 deletes in trunk/LayoutTests

Update baseline and expectations after http://trac.webkit.org/changeset/96470

platform/chromium-cg-mac-leopard/svg/custom/grayscale-gradient-mask-expected.png:
platform/chromium-cg-mac-leopard/svg/custom/mask-colorspace-expected.png: Removed.
platform/chromium-cg-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Added.
platform/chromium-cg-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
platform/chromium-cg-mac/svg/custom/grayscale-gradient-mask-expected.png:
platform/chromium-cg-mac/svg/custom/grayscale-gradient-mask-expected.txt: Added.
platform/chromium-cg-mac/svg/custom/mask-colorspace-expected.png: Added.
platform/chromium-cg-mac/svg/custom/mask-with-all-units-expected.png: Added.
platform/chromium-cg-mac/svg/filters/filter-clip-expected.png: Added.
platform/chromium-linux-x86/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
platform/chromium-linux-x86/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.png:
platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
platform/chromium-linux/svg/custom/mask-colorspace-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
platform/chromium-mac/svg/custom/mask-colorspace-expected.png:
platform/chromium-mac/svg/filters/filter-clip-expected.png:
platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
platform/chromium-win-vista/svg/css: Added.
platform/chromium-win-vista/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
platform/chromium-win-xp/svg/css: Added.
platform/chromium-win-xp/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
platform/chromium-win/svg/css/circle-in-mask-with-shadow-expected.png:
platform/chromium-win/svg/custom/mask-colorspace-expected.png:
platform/chromium-win/svg/filters/filter-clip-expected.txt: Added.
platform/chromium/svg/filters: Added.
platform/chromium/svg/filters/filter-clip-expected.txt: Added.
platform/chromium/test_expectations.txt:
platform/gtk/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
platform/gtk/svg/custom/mask-with-all-units-expected.txt: Removed.
platform/gtk/svg/filters/filter-clip-expected.txt: Removed.
platform/mac/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
platform/mac/svg/custom/mask-with-all-units-expected.txt: Removed.
platform/mac/svg/filters/filter-clip-expected.txt: Removed.
platform/qt/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
platform/qt/svg/custom/mask-with-all-units-expected.txt: Removed.
platform/qt/svg/filters/filter-clip-expected.txt: Removed.
svg/custom/grayscale-gradient-mask-expected.txt: Added.
svg/custom/mask-with-all-units-expected.txt: Added.
svg/filters/filter-clip-expected.txt: Added.

1:25 AM Changeset in webkit [96471] by mitz@apple.com

3 edits
2 adds in trunk

REGRESSION (r95502): Assertion failure in CSSPrimitiveValue::computeLengthDouble() when media query specifies unit-less length
https://bugs.webkit.org/show_bug.cgi?id=68760

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/media/invalid-lengths.html

Made length-comparison media queries accept only length values. In compatibility mode, numbers
are allowed as well, and they are interpreted as pixels.

css/MediaQueryEvaluator.cpp:

(WebCore::computeLength): Added this helper function.
(WebCore::device_heightMediaFeatureEval): Changed to use computeLength().
(WebCore::device_widthMediaFeatureEval): Ditto.
(WebCore::heightMediaFeatureEval): Ditto.
(WebCore::widthMediaFeatureEval): Ditto.

LayoutTests:

fast/media/invalid-lengths-expected.txt: Added.
fast/media/invalid-lengths.html: Added.

12:15 AM Changeset in webkit [96470] by krit@webkit.org

5 edits
3 adds in trunk

SVG Mask should take 'color-interpolation' into account to determine the color space of the mask image
https://bugs.webkit.org/show_bug.cgi?id=69076

Source/WebCore:

Reviewed by Simon Fraser.

SVG Masks should take 'color-interpolation' into account to determine the color space of the mask image.
The behavior was changed in SVG 1.1 SE. The color space of the mask image gets defined by the computed value of the
'color-interpolation' property. This will switch the default color space from linearRGB to sRGB for mask images and
is a performance improvement for platforms without native support for linearRGB color space. The
color space transformation can be avoided.

Test: svg/custom/grayscale-gradient-mask-2.svg

rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):
(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):

rendering/svg/RenderSVGResourceMasker.h:

LayoutTests:

Reviewed by Simon Fraser.

Added a new test case to check the behavior of SVG Masks on different values for the 'color-interpolation' property.
Since the default color space of the mask image changes from linearRGB to sRGB, a test needed an update.

platform/mac/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
platform/mac/svg/custom/grayscale-gradient-mask-2-expected.txt: Added.
platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
platform/mac/svg/custom/grayscale-gradient-mask-expected.txt:
svg/custom/grayscale-gradient-mask-2.svg: Added.

Oct 1, 2011:

11:49 PM Changeset in webkit [96469] by abarth@webkit.org

2 edits
1 delete in trunk/LayoutTests

Tweak expectations for leopard some more.

platform/chromium-cg-mac-leopard/fast/css/last-of-type-pseudo-class-expected.txt: Removed.
platform/chromium/test_expectations.txt:

9:34 PM Changeset in webkit [96468] by bfulgham@webkit.org

2 edits in trunk/Tools

Correct post-build step for WinCairo test runs.
https://bugs.webkit.org/show_bug.cgi?id=69191

Reviewed by Brian Weinstein.

DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Add additional

shell case to handle the CFLite build.

7:21 PM Changeset in webkit [96467] by vangelis@chromium.org

3 edits in trunk/Source/WebCore

[chromium] Fixing draw matrix for composited layers. This
was a regression introduced by:
http://trac.webkit.org/changeset/96454

https://bugs.webkit.org/show_bug.cgi?id=69217

Reviewed by James Robinson.

Tests: compositor test now pass

platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::draw):

platform/graphics/chromium/cc/CCTiledLayerImpl.h:

6:13 PM Changeset in webkit [96466] by ggaren@apple.com

3 edits in trunk/Source/WebKit/mac

Leopard build fix: Updated for Strong<T> changes.

Plugins/Hosted/NetscapePluginInstanceProxy.mm:
WebView/WebScriptDebugger.mm:

5:54 PM Changeset in webkit [96465] by ggaren@apple.com

33 edits
2 adds in trunk/Source

Removed redundant helper functions for allocating Strong handles
https://bugs.webkit.org/show_bug.cgi?id=69218

Reviewed by Sam Weinig.

../JavaScriptCore:

heap/Heap.h:

(JSC::Heap::handleHeap):

runtime/JSGlobalData.h: Removed these helper functions, since they

just created indirection.

heap/StrongInlines.h: Added. Broke out a header for inline functions

to resolve circular dependencies created by inlining. I'm told this is
the future for JavaScriptCore.

GNUmakefile.list.am:
JavaScriptCore.gypi:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj: Go forth and build.

API/JSCallbackObjectFunctions.h:

(JSC::::init):

runtime/WeakGCMap.h:

(JSC::WeakGCMap::add):
(JSC::WeakGCMap::set):

runtime/StructureTransitionTable.h:

(JSC::StructureTransitionTable::setSingleTransition):

heap/Local.h:

(JSC::::Local):

heap/Strong.h:

(JSC::::Strong):
(JSC::::set):

heap/Weak.h:

(JSC::Weak::Weak):
(JSC::Weak::set): Allocate handles directly instead of going through a
chain of forwarding functions.

bytecompiler/BytecodeGenerator.cpp:
runtime/JSGlobalData.cpp:
runtime/LiteralParser.cpp:
runtime/RegExpCache.cpp: Updated for header changes.

../JavaScriptGlue:

JSRun.cpp:
JSValueWrapper.cpp:

../WebCore:

ForwardingHeaders/heap/StrongInlines.h: Added.
bindings/js/JSCallbackData.h:
bindings/js/JSDOMWindowShell.cpp:
bindings/js/ScheduledAction.h:
bindings/js/ScriptCachedFrameData.cpp:
bindings/js/ScriptController.cpp:
bindings/js/ScriptState.cpp:
bindings/js/ScriptValue.h:
bindings/js/WorkerScriptController.cpp:
bridge/runtime_root.cpp:

../WebKit2:

WebProcess/Plugins/Netscape/NPJSObject.cpp:
WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

3:08 PM Changeset in webkit [96464] by fpizlo@apple.com

2 edits in trunk/Tools

Added myself to reviewers, because I'm now a reviewer.

Scripts/webkitpy/common/config/committers.py:

3:03 PM Changeset in webkit [96463] by fpizlo@apple.com

11 edits
2 adds in trunk/Source/JavaScriptCore

All of JSC's heuristics should be in one place for easier tuning
https://bugs.webkit.org/show_bug.cgi?id=69201

Reviewed by Oliver Hunt.

This makes it possible to change tiered compilation heuristics in
one place (Heuristics.cpp) without recompiling the whole project.

It also makes it possible to enable setting heuristics using
environment variables. This is off by default. When turned on, it
makes tuning the system much easier.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.pro:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/CodeBlock.cpp:

(JSC::CodeBlock::shouldOptimizeNow):

bytecode/CodeBlock.h:
dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

jit/JIT.cpp:

(JSC::JIT::emitOptimizationCheck):

runtime/Heuristics.cpp: Added.

(JSC::Heuristics::parse):
(JSC::Heuristics::setHeuristic):
(JSC::Heuristics::initializeHeuristics):

runtime/Heuristics.h: Added.
runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

3:01 PM WebKit Team edited by fpizlo@apple.com

(diff)

2:58 PM Changeset in webkit [96462] by fpizlo@apple.com

2 edits in trunk/Tools

Bencher script makes it difficult to do automated performance testing
https://bugs.webkit.org/show_bug.cgi?id=69207

Reviewed by Sam Weinig.

This adds two new features:

The ability to disable automatic VM detection, which is flaky if any
profiling features are enabled in jsc.

The ability to compute, and report, a scaled result for all benchmark
suites. It is the geometric mean of three numbers: SunSpider's
arithmetic mean, V8's geometric mean, and Kraken's arithmetic mean.
It is also possible to turn off all other output from bencher and just
get this number with the --brief option.

Scripts/bencher:

2:46 PM Changeset in webkit [96461] by oliver@apple.com

8 edits in trunk/Source/JavaScriptCore

Support string length in the DFG
https://bugs.webkit.org/show_bug.cgi?id=69215

Reviewed by Geoff Garen.

Adds a GetStringLength node to the DFG so that we can support
string.length inline.

dfg/DFGNode.h:
dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::isKnownString):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

runtime/JSString.h:

(JSC::JSString::offsetOfLength):

1:48 PM Changeset in webkit [96460] by weinig@apple.com

2 edits in trunk/Tools

WTR is not successfully changing the NSUserDefaults
https://bugs.webkit.org/show_bug.cgi?id=69204

Reviewed by Dan Bernstein.

WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

(WTR::InjectedBundle::platformInitialize):
Use -setVolatileDomain:forName:NSArgumentDomain instead of registerDefaults to
get our overrides picked up.

12:56 PM Changeset in webkit [96459] by abarth@webkit.org

1 edit
1 delete in trunk/LayoutTests

Delete bogus text expectation.

platform/chromium-mac/http/tests/misc/acid3-expected.txt: Removed.

12:21 PM Changeset in webkit [96458] by commit-queue@webkit.org

4 edits in trunk/Source/JavaScriptCore

JSVALUE32_64 DFG JIT - unboxed integers and cells in register file must be reboxed before exiting from DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69205

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-01
Reviewed by Gavin Barraclough.

If there are unboxed integers and cells in register file (e.g. by SetLocal),
they must be reboxed before exiting from the speculative DFG JIT execution.
This patch also adds a new ValueSourceKind (CellInRegisterFile) and a new
ValueRecoveryTechnique (AlreadyInRegisterFileAsCell).

dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::ValueSource::forPrediction):
(JSC::DFG::ValueRecovery::alreadyInRegisterFileAsUnboxedCell):

10:32 AM Changeset in webkit [96457] by abarth@webkit.org

2 edits in trunk/LayoutTests

Note test as timing out.

platform/chromium/test_expectations.txt:

10:29 AM Changeset in webkit [96456] by abarth@webkit.org

3 edits
5 adds
2 deletes in trunk/LayoutTests

Update Mac baselines.

platform/chromium-cg-mac-leopard/fast/css/last-of-type-pseudo-class-expected.txt: Added.
platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt: Removed.
platform/chromium-cg-mac-leopard/svg/as-object: Added.
platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.
platform/chromium-cg-mac/http/tests/misc/acid3-expected.png:
platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt: Removed.
platform/chromium-mac/http/tests/misc/acid3-expected.png:
platform/chromium-mac/http/tests/misc/acid3-expected.txt: Added.

12:22 AM Changeset in webkit [96455] by commit-queue@webkit.org