Timeline
Oct 3, 2011:
- 11:42 PM Changeset in webkit [96573] by
-
- 21 edits in trunk/LayoutTests
Mac rebaseline after r96509.
- platform/mac/fast/forms/file-input-disabled-expected.txt:
- platform/mac/fast/invalid/017-expected.txt:
- platform/mac/fast/invalid/018-expected.txt:
- platform/mac/fast/invalid/020-expected.txt:
- platform/mac/fast/invalid/residual-style-expected.txt:
- platform/mac/fast/invalid/table-inside-stray-table-content-expected.txt:
- platform/mac/fast/table/inline-form-assert-expected.txt:
- platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug23994-expected.txt:
- platform/mac/tables/mozilla/bugs/bug56405-expected.txt:
- platform/mac/tables/mozilla/bugs/bug56563-expected.png:
- platform/mac/tables/mozilla/bugs/bug56563-expected.txt:
- platform/mac/tables/mozilla/bugs/bug9024-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/conflicts-expected.txt:
- platform/mac/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
- tables/mozilla_expected_failures/bugs/bug3517-expected.txt:
- 11:22 PM Changeset in webkit [96572] by
-
- 24 edits3 copies6 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Update Qt specific expected files after r96509.
- platform/qt/fast/invalid/017-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla_expected_failures/bugs/bug220653-expected.png.
- platform/qt/fast/invalid/017-expected.txt:
- platform/qt/fast/invalid/018-expected.png: Added.
- platform/qt/fast/invalid/018-expected.txt:
- platform/qt/fast/invalid/020-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug23994-expected.png.
- platform/qt/fast/invalid/020-expected.txt:
- platform/qt/fast/invalid/table-inside-stray-table-content-expected.png: Added.
- platform/qt/fast/invalid/table-inside-stray-table-content-expected.txt:
- platform/qt/fast/table/inline-form-assert-expected.png:
- platform/qt/fast/table/inline-form-assert-expected.txt:
- platform/qt/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
- platform/qt/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.
- platform/qt/tables/mozilla/bugs/bug113235-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug113235-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug23994-expected.png:
- platform/qt/tables/mozilla/bugs/bug23994-expected.txt:
- platform/qt/tables/mozilla/bugs/bug56405-expected.png:
- platform/qt/tables/mozilla/bugs/bug56405-expected.txt:
- platform/qt/tables/mozilla/bugs/bug56563-expected.png:
- platform/qt/tables/mozilla/bugs/bug56563-expected.txt:
- platform/qt/tables/mozilla/bugs/bug9024-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug9024-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.png: Added.
- platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug9024-expected.txt.
- platform/qt/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
- platform/qt/tables/mozilla_expected_failures/core/conflicts-expected.png:
- platform/qt/tables/mozilla_expected_failures/core/conflicts-expected.txt:
- platform/qt/tables/mozilla_expected_failures/other/empty_cells-expected.png:
- platform/qt/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
- 9:16 PM Changeset in webkit [96571] by
-
- 3 edits in trunk/Source/WebCore
Mac release build fix after r96561, and Leopard build fix after r96568.
- editing/TextCheckingHelper.h:
(WebCore::TextCheckingParagraph::textCharAt):
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::wheelEvent):
- 8:52 PM Changeset in webkit [96570] by
-
- 4 edits in trunk/Source/WebCore
Build fix after r96568.
- accessibility/AccessibilityObject.cpp:
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
- editing/Editor.cpp:
- 8:20 PM Changeset in webkit [96569] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG should inline Array.push and Array.pop
https://bugs.webkit.org/show_bug.cgi?id=69314
Reviewed by Geoff Garen.
Fix 32-bit.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 8:10 PM Changeset in webkit [96568] by
-
- 6 edits in trunk/Source/WebCore
Should call checkTextOfParagraph() indirectly to make unifying spell-checking code path easy.
https://bugs.webkit.org/show_bug.cgi?id=69241
Patch by Shinya Kawanaka <shinyak@google.com> on 2011-10-03
Reviewed by Ryosuke Niwa.
WebCore has two different code paths for spell-checking:
1) checkTextOfParagraph() for Snow Leopard or later
2) checkSpellingOfString() for checkGrammarOfString() for other platforms.
At the first step, this patch introduces an indirect wrapper to call
checkTextOfParagraph() in Snow Leopard or later. This is intended to make it easy to
introduce a function for mimicing checkTextOfParagraph() in Chromium platform or
other non-SL or non-Lion platform.
No new tests because this patch does not change a behavior.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::hasMisspelling): Calling checkTextOfParagraph() indirectly.
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(AXAttributeStringSetSpelling): ditto.
- editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): ditto.
- editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): ditto.
(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): ditto.
(WebCore::checkTextOfParagraph): Added.
- editing/TextCheckingHelper.h:
- 7:55 PM Changeset in webkit [96567] by
-
- 12 edits in trunk/Source/JavaScriptCore
DFG should inline Array.push and Array.pop
https://bugs.webkit.org/show_bug.cgi?id=69314
Reviewed by Oliver Hunt.
1% speed-up in V8 due to 6% speed-up in V8-deltablue.
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::storePtr):
- create_hash_table:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGIntrinsic.h:
- dfg/DFGNode.h:
(JSC::DFG::Node::hasHeapPrediction):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 7:26 PM Changeset in webkit [96566] by
-
- 13 edits in trunk/Source/WebCore
Change cursor to hand over missing plug-in message
https://bugs.webkit.org/show_bug.cgi?id=69312
Reviewed by Sam Weinig.
No tests because we currently don't have any test machinery for cursors.
- page/EventHandler.cpp:
(WebCore::OptionalCursor::OptionalCursor): Added. Construct an object
to represent either a cursor, or no cursor change.
(WebCore::OptionalCursor::isCursorChange): Added.
(WebCore::OptionalCursor::cursor): Added.
(WebCore::EventHandler::selectCursor): Changed return type to OptionalCursor,
moved some special cases from handleMouseMoveEvent in here. Moved the logic
for plug-ins and framesets into the specific renderer classes for those.
Added a call to the new getCursor virtual function.
(WebCore::EventHandler::handleMouseMoveEvent): Changed cursor setting code to
just be a call to selectCursor and then setCursor. Plug-in-specific code is now
in RenderWidget.
- page/EventHandler.h: Changed return type of selectCursor.
- page/MouseEventWithHitTestResults.cpp: Made some functions be inline.
- page/MouseEventWithHitTestResults.h:
(WebCore::MouseEventWithHitTestResults::localPoint): Made this inline.
(WebCore::MouseEventWithHitTestResults::scrollbar): Made this inline.
Yes, this has nothing to do with the rest of the patch, but it's good.
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry): Made const.
(WebCore::RenderEmbeddedObject::isInMissingPluginIndicator): Made const.
Overloaded so it can be called with a point rather than an event.
(WebCore::shouldMissingPluginMessageBeButton): Added. Helps streamline
the logic below.
(WebCore::RenderEmbeddedObject::handleMissingPluginIndicatorEvent):
Changed to use shouldMissingPluginMessageBeButton.
(WebCore::RenderEmbeddedObject::getCursor): Added. Sets the cursor to
a hand when over the missing plug-in message.
- rendering/RenderEmbeddedObject.h: Added getCursor override. Also updated
for other changes above.
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::getCursor): Added. Contains the logic that used
to be hardcoded in EventHandler::selectCursor about cursors when over
resizable frame borders.
- rendering/RenderFrameSet.h: Added getCursor.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::getCursor): Added. Returns SetCursorBasedOnStyle.
- rendering/RenderObject.h: Added getCursor.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::getCursor): Added. Contains the logic that used
to be hardcoded in EventHandler::handleMouseMoveEvent to prevent setting
the cursor when the pointer is over a plug-in. This new code is much better,
because it only kicks in when there is actually a plug-in present. The old
was based on the HTML tag!
- rendering/RenderWidget.h: Added getCursor.
- 7:00 PM Changeset in webkit [96565] by
-
- 5 edits in trunk/Tools
garden-o-matic should remove builders from the failure grid once they start to pass
https://bugs.webkit.org/show_bug.cgi?id=69309
Unreviewed. dglazkov is on vacation. I need to interest someone else
in reviewing these patches.
This patch follows the update/purge model from UpdateTracker. This
patch is less awesome than it could be because it causes the UI to
flash slightly. In a future patch, we'll want to use these
update/purge notifications to update the UI without flashing. However,
that's not such a big deal because this UI is hidden in the default
view.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
- 6:37 PM Changeset in webkit [96564] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSC ASSERT Opening the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=69293
Reviewed by Oliver Hunt.
If a polymorphic access structure list has a duplicated structure, then
don't crash.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- 6:16 PM Changeset in webkit [96563] by
-
- 9 edits in trunk/Source/JavaScriptCore
On X86, switch bucketCount into a register, timeoutCheck into memory
https://bugs.webkit.org/show_bug.cgi?id=69299
Reviewed by Geoff Garen.
We don't have sufficient registers to keep both in registers, and DFG JIT will trample esi;
it doesn't matter if the bucketCount gets stomped on (in fact it may add to randomness!),
but it if the timeoutCheck gets trashed we may make calls out to the timout_check stub
function too frequently (regressing performance). This patch has no perf impact on sunspider.
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::branchAdd32):
(JSC::MacroAssemblerX86::branchSub32):
- Added branchSub32 with AbsoluteAddress.
- jit/JIT.cpp:
(JSC::JIT::emitTimeoutCheck):
- Keep timeout count in memory on X86.
- jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
- remove X86 specific code, switch bucket count back into a register.
- jit/JITStubs.cpp:
- Stop initializing esi (it is no longer the timeoutCheck!)
- jit/JSInterfaceJIT.h:
- change definition of esi to be the bucketCountRegister.
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
- Add timeoutCount as a property to global data (the counter should be per-thread).
- 6:05 PM Changeset in webkit [96562] by
-
- 6 edits in trunk/Source/JavaScriptCore
DFG backends don't have access to per-node predictions from the propagator
https://bugs.webkit.org/show_bug.cgi?id=69291
Reviewed by Oliver Hunt.
Nodes now have two notion of predictions: the heap prediction, which is
what came directly from value profiling, and the propagator's predictions,
which arise out of abstract interpretation. Every node has a propagator
prediction, but not every node has a heap prediction; and there is no
guarantee that a node that has both will keep them consistent as the
propagator may have additional information available to it.
This is performance neutral.
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::getPrediction):
- dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::getHeapPrediction):
(JSC::DFG::Node::predictHeap):
(JSC::DFG::Node::prediction):
(JSC::DFG::Node::predict):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::setPrediction):
(JSC::DFG::Propagator::mergePrediction):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::isPredictedNumerical):
(JSC::DFG::Propagator::logicalNotIsPure):
(JSC::DFG::Propagator::setReplacement):
- 5:29 PM Changeset in webkit [96561] by
-
- 13 edits in trunk/Source/WebCore
Work towards making PlatformWheelEvent immutable
https://bugs.webkit.org/show_bug.cgi?id=69306
Reviewed by Sam Weinig.
Currently, PlatformWheelEvent has an m_isAccepted flag that tracks whether
the event has been handled or not. For all other event types, that state is instead
tracked by the return value of the various event handlers.
As a first step, add return values to the various handleWheelEvent functions and
add an assertion in EventHandler::wheelEvent that the return value is the same as
the state of PlatformWheelEvent::isAccepted.
- Configurations/Base.xcconfig:
Don't warn when using C++11 extensions.
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::wheelEvent):
Assert that isAccepted matches the return value.
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleWheelEvent):
Return isAccepted.
- platform/ScrollAnimator.h:
HandleWheelEvent now returns a boolean.
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
Return whether the event was handled or not.
- platform/ScrollView.h:
ScrollView::wheelEvent now returns a bool.
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::handleWheelEvent):
- platform/ScrollableArea.h:
ScrollableArea::handleWheelEvent now returns a bool.
- platform/chromium/ScrollAnimatorChromiumMac.h:
- platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
Add return values, based on either the base class calls or the state of
PlatformWheelEvent::isAccepted().
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleWheelEvent):
Ditto.
- 5:23 PM Changeset in webkit [96560] by
-
- 4 edits in trunk/Tools
webkitpy: Expose cc_emails and comments from bug.py
https://bugs.webkit.org/show_bug.cgi?id=69308
Reviewed by Adam Barth.
- Scripts/webkitpy/common/net/bugzilla/bug.py: Expose cc_emails and comments .
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Add parsing support for comments.
- Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fix the unit test due
to comments being exposed.
- 5:13 PM Changeset in webkit [96559] by
-
- 2 edits1 copy in trunk/PerformanceTests
Add a microbenchmark for a full-page render of the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=69285
Reviewed by Adam Barth.
This was designed to be a test for https://bugs.webkit.org/show_bug.cgi?id=68944
But it seems that by far our dominating cost for the HTML5 benchmark is
time spent laying out lines (which isn't actually that surprising).
I'm adding the performance test for posterity.
- Parser/html-parser.html:
- Removed use of "about:blank" which abarth says is a no-op. Made comment more accurate.
- Parser/html5-full-render.html: Copied from PerformanceTests/Parser/html-parser.html.
- 5:10 PM Changeset in webkit [96558] by
-
- 8 edits2 adds in trunk
<rdar://problem/9973489> REGRESSION (r66599): -[DOMNode boundingBox] returns the zero rect for SVG elements
https://bugs.webkit.org/show_bug.cgi?id=69305
Reviewed by Simon Fraser.
Source/WebCore:
Test: svg/custom/boundingBox.html
Rather than asserting and returning the zero rect, take the transform-aware code path for computing SVG
bounding rects.
- rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::mapLocalToContainer): Updated for change to SVGRenderSupport::mapLocalToContainer().
- rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::mapLocalToContainer): Ditto.
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::mapLocalToContainer): Ditto.
(WebCore::RenderSVGModelObject::absoluteRects): Replaced an incorrect assertion with code to approximate the bounding
box.
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::mapLocalToContainer): Updated for change to SVGRenderSupport::mapLocalToContainer().
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::mapLocalToContainer): Removed the fixed and useTransform boolean parameters.
- rendering/svg/SVGRenderSupport.h:
LayoutTests:
- svg/custom/boundingBox-expected.txt: Added.
- svg/custom/boundingBox.html: Added.
- 4:54 PM Changeset in webkit [96557] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Tweak WebCompositor API for input event handling to express three possible states
https://bugs.webkit.org/show_bug.cgi?id=69304
Reviewed by Darin Fisher.
- public/WebCompositorClient.h:
- src/WebCompositorImpl.cpp:
(WebKit::WebCompositorImpl::~WebCompositorImpl):
(WebKit::WebCompositorImpl::handleInputEvent):
- 4:22 PM Changeset in webkit [96556] by
-
- 2 edits in trunk/Tools
Add myself to the watchlist for platform/graphics/chromium
https://bugs.webkit.org/show_bug.cgi?id=69297
Patch by James Robinson <jamesr@chromium.org> on 2011-10-03
Reviewed by David Levin.
- Scripts/webkitpy/common/config/watchlist:
- 4:11 PM Changeset in webkit [96555] by
-
- 2 edits in trunk/Source/WebKit2
Content area does not return to the correct position after rubberbanding
https://bugs.webkit.org/show_bug.cgi?id=69302
<rdar://problem/10102886>
Reviewed by Sam Weinig.
Make sure to schedule a display after adding to the dirty region.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::scroll):
- 4:07 PM Changeset in webkit [96554] by
-
- 5 edits in trunk/Source/WebCore
A little more WebSQLDatabase thread safety.
https://bugs.webkit.org/show_bug.cgi?id=69277
- switch to using AtomicallyInitializedStatic where appropiate
- avoid using some Strings across threads
Reviewed by David Levin.
Existing tests apply.
- storage/AbstractDatabase.cpp:
(WebCore::guidMutex):
(WebCore::guidToVersionMap):
(WebCore::guidToDatabaseMap):
(WebCore::guidForOriginAndName):
(WebCore::AbstractDatabase::databaseInfoTableName):
(WebCore::AbstractDatabase::AbstractDatabase):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::getVersionFromDatabase):
(WebCore::AbstractDatabase::setVersionInDatabase):
- storage/AbstractDatabase.h:
- storage/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::tracker):
- storage/chromium/QuotaTracker.cpp:
(WebCore::QuotaTracker::instance):
- 4:05 PM Changeset in webkit [96553] by
-
- 6 edits in trunk/Source/WebCore
Replace m_firstNodeInserted and m_lastLeafInserted in ReplaceSelectionCommand by positions
https://bugs.webkit.org/show_bug.cgi?id=68874
Reviewed by Enrica Casucci.
Replaced m_firstNodeInserted and m_lastLeafInserted by m_startOfInsertedContent and m_endOfInsertedContent
respectively. Also removed removeNodePreservingChildren and removeNodeAndPruneAncestors in ReplaceSelectionCommand
because they were not virtual in CompositeEditCommand and implicitly overriding the functions was confusing.
Since each of these two functions is used at exactly one place, just update positions and insertedNodes explicitly.
- editing/CompositeEditCommand.cpp:
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
(WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
(WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent):
(WebCore::ReplaceSelectionCommand::handleStyleSpans):
(WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Update m_endOfInsertedContent by endingSelection().visibleEnd()
instead of m_lastLeafInserted with destination.previous() because moveParagraph could have removed leading whitespace in
the text node referenced by destination. This is tested by an existing layout test.
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace): Update positions as needed. All changes are tested
by the existing layout tests in editing/pasteboard.
(WebCore::ReplaceSelectionCommand::updateNodesInserted):
- editing/ReplaceSelectionCommand.h:
- editing/htmlediting.cpp:
(WebCore::hasARenderedDescendant): Moved from CompositeEditCommand.cpp.
(WebCore::highestNodeToRemoveInPruning): Ditto.
- editing/htmlediting.h:
- 4:02 PM Changeset in webkit [96552] by
-
- 3 edits2 adds in trunk
REGRESSION(r94274): cloned text input loses value
https://bugs.webkit.org/show_bug.cgi?id=69095
Reviewed by Darin Adler.
Source/WebCore:
The bug was caused by copyNonAttributeProperties not updating inner element text after copying
m_valueIfDirty. Fixed the bug by calling updateInnerTextValue.
Test: fast/forms/clone-input-with-dirty-value.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::copyNonAttributeProperties):
LayoutTests:
Added a regression test that clones an input element with a dirty value.
The cloned input element should have the edited value.
- fast/forms/clone-input-with-dirty-value-expected.txt: Added.
- fast/forms/clone-input-with-dirty-value.html: Added.
- 3:51 PM Changeset in webkit [96551] by
-
- 2 edits in trunk/Source/WebCore
Leopard build fix after r96530.
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::applyResource):
- 3:35 PM Changeset in webkit [96550] by
-
- 8 edits in trunk/Source/WebCore
Move ContentSecurityPolicy to the ScriptExecutionContext to prepare it for working with XHR and workers
https://bugs.webkit.org/show_bug.cgi?id=69294
Reviewed by Darin Adler.
- dom/Document.cpp:
(WebCore::Document::initSecurityContext):
Initialize the ContentSecurityPolicy by calling down to the ScriptExecutionContext.
- dom/Document.h:
Move the ContentSecurityPolicy member and getter from here to ScriptExecutionContext.h.
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::setContentSecurityPolicy):
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::contentSecurityPolicy):
Add ContentSecurityPolicy member and getter/setter.
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::didReceiveHeader):
(WebCore::ContentSecurityPolicy::reportViolation):
(WebCore::ContentSecurityPolicy::parseReportURI):
(WebCore::ContentSecurityPolicy::createCSPDirective):
- page/ContentSecurityPolicy.h:
(WebCore::ContentSecurityPolicy::create):
Replace Document with ScriptExecutionContext. Add temporary checked casts to document
where necessary.
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::WorkerContext):
Add initialization of the ContentSecurityPolicy.
- 3:31 PM Changeset in webkit [96549] by
-
- 22 edits in trunk
Remove custom scrollbar painting hooks
https://bugs.webkit.org/show_bug.cgi?id=69163
Source/WebCore:
Reviewed by Alexey Proskuryakov.
The custom scrollbar and scroll corner painting hooks aren't used by anyone
so go ahead and remove them. This removes the setter/getter and ChromeClient functions.
- page/Chrome.cpp:
- page/ChromeClient.h:
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
- platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
(WebCore::ScrollbarThemeComposite::paintScrollCorner):
Source/WebKit/chromium:
Reviewed by Alexey Proskuryakov.
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setShouldPaintCustomScrollbars):
Source/WebKit/win:
Reviewed by Alexey Proskuryakov.
Remove now unused WebPreferences and ChromeClient overrides.
- Interfaces/IWebPreferences.idl:
- WebCoreSupport/WebChromeClient.cpp:
- WebCoreSupport/WebChromeClient.h:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::unused3):
(WebPreferences::unused4):
- WebPreferences.h:
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Source/WebKit2:
Remove overridden ChromeClient member functions.
Reviewed by Alexey Proskuryakov.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.h:
Tools:
Reviewed by Alexey Proskuryakov.
- DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::applyTo):
No need to enable custom scrollbar painting.
- 3:25 PM Changeset in webkit [96548] by
-
- 4 edits7 adds3 deletes in trunk/LayoutTests
Update results again now that Leopard has finally cycled.
- platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
- platform/chromium-cg-mac-leopard/svg/custom/non-scaling-stroke-expected.png:
- platform/chromium-cg-mac-leopard/svg/custom/pattern-skew-transformed-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/custom/pattern-with-transformation-expected.png:
- platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Added.
- platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
- platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
- platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
- 3:15 PM Changeset in webkit [96547] by
-
- 22 edits in trunk/Source/WebCore
Rename many obviously-correct call sites in WebCore using releaseRef to use it by its new name leakRef
https://bugs.webkit.org/show_bug.cgi?id=68672
Reviewed by Daniel Bates.
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonJSGlobalData):
- css/CSSInitialValue.h:
(WebCore::CSSInitialValue::createExplicit):
(WebCore::CSSInitialValue::createImplicit):
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::init):
- css/CSSStyleSelector.cpp:
(WebCore::parseUASheet):
(WebCore::CSSStyleSelector::styleForElement):
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderTheme::themeForPage):
- platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderTheme::themeForPage):
- platform/haiku/RenderThemeHaiku.cpp:
(WebCore::RenderTheme::themeForPage):
- platform/network/cf/DNSCFNet.cpp:
(WebCore::DNSResolveQueue::resolve):
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::releaseConnectionForDownload):
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
- platform/text/BidiContext.cpp:
(WebCore::BidiContext::create):
- platform/wx/RenderThemeWx.cpp:
(WebCore::RenderTheme::themeForPage):
- rendering/RenderThemeChromiumLinux.cpp:
(WebCore::RenderTheme::themeForPage):
- rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderTheme::themeForPage):
- rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
- rendering/RenderThemeChromiumWin.cpp:
(WebCore::RenderTheme::themeForPage):
- rendering/RenderThemeMac.mm:
(WebCore::RenderTheme::themeForPage):
- rendering/RenderThemeSafari.cpp:
(WebCore::RenderTheme::themeForPage):
- rendering/RenderThemeWin.cpp:
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):
- rendering/RenderThemeWinCE.cpp:
(WebCore::RenderTheme::themeForPage):
- rendering/style/RenderStyle.cpp:
(WebCore::defaultStyle):
Call leakRef instead of releaseRef. I did this only in the cases where
it was obvious to me this was the right way to do it. I'll keep revisiting
sites still calling it releaseRef until they are all gone.
- 3:00 PM Changeset in webkit [96546] by
-
- 9 edits in trunk/Source/WebCore
remove dead code in flipForWritingMode
https://bugs.webkit.org/show_bug.cgi?id=68948
Reviewed by Hajime Morita.
ChildToParentFlippingAdjustment is never used, so the third argument
to flipForWritingMode always has the same value.
In addition, renamed to flipForWritingModeForChild to be more clear
that it's operating on the child and renamed flipFloatForWritingMode to match.
No new tests. This is just a code cleanup. No functional changes.
- rendering/InlineBox.cpp:
(WebCore::InlineBox::paint):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::flipFloatForWritingModeForChild):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::hitTestContents):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::flipForWritingModeForChild):
(WebCore::RenderBox::topLeftLocation):
- rendering/RenderBox.h:
- rendering/RenderTable.cpp:
(WebCore::RenderTable::paintObject):
(WebCore::RenderTable::nodeAtPoint):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::nodeAtPoint):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintCell):
(WebCore::RenderTableSection::nodeAtPoint):
- 2:57 PM Changeset in webkit [96545] by
-
- 10 edits in trunk/Source
Unreviewed, rolling out r96526.
http://trac.webkit.org/changeset/96526
https://bugs.webkit.org/show_bug.cgi?id=68587
WEB_AUDIO has numerous 64->32 bit casting warnings, causing
build breakages where -Wall is enabled.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
- wtf/Platform.h:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 2:55 PM Changeset in webkit [96544] by
-
- 2 edits2 adds in trunk/LayoutTests
Update results to account for Windows Vista.
- platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
- platform/chromium-win-vista/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
- 2:50 PM Changeset in webkit [96543] by
-
- 3 edits2 adds in trunk
<http://webkit.org/b/69152> Web Inspector: rgb() with percentages shows wrong hex/hsl values
Reviewed by Pavel Feldman.
Source/WebCore:
Previously we assumed rgb values were always in byte form,
but they could include percentage values. Ex. rgb(100%,0,0).
This patch fixes this, and in the process includes clamping
for invalid percentages, byte values, and alpha values.
Test: inspector/styles/styles-invalid-color-values.html
- inspector/front-end/Color.js:
(WebInspector.Color.prototype._clamp):
(WebInspector.Color.prototype._individualRGBValueToFloatValue):
(WebInspector.Color.prototype._individualRGBValueToHexValue):
(WebInspector.Color.prototype._rgbToHex):
(WebInspector.Color.prototype._rgbToHSL):
An individual rgb value can be either a decimal/float or a
percentage. Rewrite the conversion functions to handle either
input. Regardless of the type of input, always return a clamped
decimal/float value between 0 and 255.
(WebInspector.Color.prototype._rgbaToHSLA):
(WebInspector.Color.prototype._hslaToRGBA):
(WebInspector.Color.prototype._parse):
Clamp the alpha value between 0 and 1.
LayoutTests:
This test outputs all of the supported color format representations
for supplied CSS color values. We expect some of the CSS values
to be clamped, e.g. rgb(300,0,0) to rgb(255,0,0). This also tests
that rgb percentages, such as rgb(100%,0,0), work correctly.
- inspector/styles/styles-invalid-color-values-expected.txt: Added.
- inspector/styles/styles-invalid-color-values.html: Added.
- 2:45 PM Changeset in webkit [96542] by
-
- 2 edits6 adds in trunk/LayoutTests
Update chromium-cg-mac results after http://trac.webkit.org/changeset/96530.
- platform/chromium-cg-mac/svg/custom/pattern-skew-transformed-expected.png:
- platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Added.
- platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Added.
- platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Added.
- platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Added.
- platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Added.
- platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Added.
- 2:44 PM Changeset in webkit [96541] by
-
- 3 edits in trunk/Tools
watchlist: Make watchlist run on a bot.
https://bugs.webkit.org/show_bug.cgi?id=68974
Reviewed by Adam Barth.
- Scripts/webkitpy/tool/commands/queues.py: Add the watchlist to the style bot.
- Scripts/webkitpy/tool/commands/queues_unittest.py:
Change to log what is run so that we can see the style command
and the watchlist command being run.
- 2:44 PM Changeset in webkit [96540] by
-
- 5 edits in trunk/Tools
watchlist: Allow specified a bug to attach the watchlist info to.
https://bugs.webkit.org/show_bug.cgi?id=69288
Reviewed by Eric Seidel.
- Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Add support for bugid.
- Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
Add tests and fix an existing test because the unit tests do not go through the
normal command line processing (so the -g argument remained when we determined bug ids).
- Scripts/webkitpy/tool/commands/commandtest.py: Change the derivation to
get the assert raises regex method.
- Scripts/webkitpy/tool/commands/download.py: Fix the command help to be more unixy.
- 2:42 PM Changeset in webkit [96539] by
-
- 1 edit2 adds in trunk/LayoutTests
Update results now that the race condition is fixed. It seems like the
cross-platform results would need to be updated as well, but no bot has
told me that yet.
- platform/chromium-mac-leopard/svg/as-object: Added.
- platform/chromium-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.
- 2:37 PM Changeset in webkit [96538] by
-
- 14 edits8 adds3 deletes in trunk/LayoutTests
Update baselines after http://trac.webkit.org/changeset/96530.
- platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
- platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
- platform/chromium-cg-mac/svg/custom/non-scaling-stroke-expected.png:
- platform/chromium-cg-mac/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
- platform/chromium-cg-mac/svg/custom/pattern-size-bigger-than-target-size-expected.png: Added.
- platform/chromium-cg-mac/svg/custom/pattern-with-transformation-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
- platform/chromium-linux/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
- platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
- platform/chromium-mac/svg/custom/non-scaling-stroke-expected.png:
- platform/chromium-mac/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
- platform/chromium-mac/svg/custom/pattern-size-bigger-than-target-size-expected.png:
- platform/chromium-mac/svg/custom/pattern-with-transformation-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
- platform/chromium-win/svg/custom/non-scaling-stroke-expected.png:
- platform/chromium-win/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
- platform/chromium-win/svg/custom/pattern-size-bigger-than-target-size-expected.png:
- platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
- platform/gtk/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Removed.
- platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Removed.
- platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Removed.
- svg/custom/pattern-size-bigger-than-target-size-expected.txt: Added.
- 1:57 PM Changeset in webkit [96537] by
-
- 1 edit2 adds in trunk/Tools
[EFL] DRT: Add JSStringUtils.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=66397
Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-10-03
Reviewed by Ryosuke Niwa.
Adds helper functions to compare the equality of C-style strings and
JSStringRef objects.
- DumpRenderTree/efl/JSStringUtils.cpp: Added.
(equals):
- DumpRenderTree/efl/JSStringUtils.h: Added.
- 1:51 PM Changeset in webkit [96536] by
-
- 3 edits in trunk/Tools
garden-o-matic should work in Safari 5.1
https://bugs.webkit.org/show_bug.cgi?id=69290
Reviewed by Sam Weinig.
My old implementation of bind was too clever by half. This one seems
to work better, at least according to this test.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
- 1:43 PM Changeset in webkit [96535] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r96532.
http://trac.webkit.org/changeset/96532
https://bugs.webkit.org/show_bug.cgi?id=69289
Accidentally marked failures as expected instead of creating
new baseline. (Requested by krit on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-03
- platform/chromium/test_expectations.txt:
- 1:39 PM Changeset in webkit [96534] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed build fix for DFG JIT 32_64.
- dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 1:25 PM Changeset in webkit [96533] by
-
- 2 edits in trunk/Source/WebKit/chromium
webkit->chromium DEPS roll 103471->103694
https://bugs.webkit.org/show_bug.cgi?id=69271
This brings in a new tools/win/supalink directory from
http://src.chromium.org/viewvc/chrome?view=rev&revision=103474
Patch by Elliot Poger <epoger@google.com> on 2011-10-03
Reviewed by Adam Barth.
- DEPS:
- 1:24 PM Changeset in webkit [96532] by
-
- 2 edits in trunk/LayoutTests
Uneviewed by rebaseline after SVG Pattern patch with bug 69261.
- platform/chromium/test_expectations.txt:
- 1:09 PM Changeset in webkit [96531] by
-
- 2 edits in trunk/PerformanceTests
PerformanceTests/Parser/html-parser is only testing parsing of the head element
https://bugs.webkit.org/show_bug.cgi?id=69283
Reviewed by Adam Barth.
While investigating https://bugs.webkit.org/show_bug.cgi?id=68944
I found that the html-parser benchmark was only parsing up to the
first script tag per loop! We've fixed this by adding the sandbox
tag which will deny all external loads and allow the parser to
synchronously continue parsing the entire document to completion
(as we had expected it was doing).
This changes the profile somewhat. Line number counting is much
hotter, since we're actually accounting for the parse of the entire
document in our sample.
Total sample time only about doubles, from 1800ms to 3800ms on my machine
which is less than I would have expected.
- Parser/html-parser.html:
- 12:54 PM Changeset in webkit [96530] by
-
- 5 edits3 adds in trunk
SVG Pattern tile pixelated on patternTransform
https://bugs.webkit.org/show_bug.cgi?id=69261
Source/WebCore:
Reviewed by Rob Buis.
Scale the SVG pattern tile by the scale level of patternTransform to avoid pixelation.
Test: svg/custom/pattern-scaled-pattern-space.svg
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::applyResource):
LayoutTests:
Reviewed by Rob Buis.
Add a new test to check that SVG pattern tiles are not pixelated on
scaling with patternTransform.
Updated two more pixel tests. Both changes are progressions.
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
- platform/mac/svg/custom/non-scaling-stroke-expected.png:
- svg/custom/pattern-scaled-pattern-space-expected.png: Added.
- svg/custom/pattern-scaled-pattern-space-expected.txt: Added.
- svg/custom/pattern-scaled-pattern-space.svg: Added.
- 12:52 PM Changeset in webkit [96529] by
-
- 10 edits1 copy in trunk/Source
[chromium] Add WebWidget API for accessing the current WebCompositor
https://bugs.webkit.org/show_bug.cgi?id=69181
Reviewed by Darin Fisher.
Add new WebWidgetClient::did(Activate|Deactivate)Compositor calls intended to replace
didActivateAccleratedCompositing(bool) so that the enable call can be parameterized.
Add a WebCompositor identifier parameter to didEnableAcceleratedCompositing that can be used on the compositor
thread to get access to a WebCompositor pointer.
- public/WebWidget.h:
(WebKit::WebWidget::compositor):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::compositor):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- src/WebViewImpl.h:
- 12:44 PM Changeset in webkit [96528] by
-
- 9 edits2 adds1 delete in trunk/LayoutTests
Another round of updates after http://trac.webkit.org/changeset/96509.
- platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug56563-expected.png:
- platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug220653-expected.png: Added.
- platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png: Added.
- platform/chromium-cg-mac/tables/mozilla/bugs/bug113235-2-expected.png:
- platform/chromium-cg-mac/tables/mozilla/bugs/bug23994-expected.png:
- platform/chromium-cg-mac/tables/mozilla/bugs/bug56405-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3517-expected.png:
- platform/chromium-win/fast/invalid/017-expected.png:
- platform/chromium-win/fast/invalid/018-expected.png:
- platform/chromium-win/fast/invalid/020-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
- 12:25 PM Changeset in webkit [96527] by
-
- 15 edits1 add in trunk/Source/JavaScriptCore
DFG should speculate more aggressively on obvious cases on
polymorphic get_by_id
https://bugs.webkit.org/show_bug.cgi?id=69235
Reviewed by Oliver Hunt.
This implements trivial polymorphic get_by_id. It also fixes
problems in the CSE for CheckStructure in the put_by_id
transition case.
Doing this required knowing whether a polymorphic get_by_id stub
was doing a direct access rather than a call of some kind.
Slight speed-up on Kraken and SunSpider. 0.5% speed-up in the
scaled mean of all benchmarks.
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/Instruction.h:
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::addStructureSet):
(JSC::DFG::Graph::addStructureTransitionData):
- dfg/DFGNode.h:
(JSC::DFG::StructureTransitionData::StructureTransitionData):
(JSC::DFG::Node::hasStructureTransitionData):
(JSC::DFG::Node::structureTransitionData):
(JSC::DFG::Node::hasStructureSet):
(JSC::DFG::Node::structureSet):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
- dfg/DFGRepatch.cpp:
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryBuildGetByIDProtoList):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStructureSet.h: Added.
(JSC::DFG::StructureSet::StructureSet):
(JSC::DFG::StructureSet::add):
(JSC::DFG::StructureSet::addAll):
(JSC::DFG::StructureSet::remove):
(JSC::DFG::StructureSet::contains):
(JSC::DFG::StructureSet::isSubsetOf):
(JSC::DFG::StructureSet::isSupersetOf):
(JSC::DFG::StructureSet::size):
(JSC::DFG::StructureSet::at):
(JSC::DFG::StructureSet::operator[]):
(JSC::DFG::StructureSet::last):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC::getPolymorphicAccessStructureListSlot):
- 12:21 PM Changeset in webkit [96526] by
-
- 10 edits in trunk/Source
Enable WEB_AUDIO by default in the WebKit/mac port.
https://bugs.webkit.org/show_bug.cgi?id=68587
Reviewed by Simon Fraser.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
- wtf/Platform.h:
Source/WebCore:
No new tests; existing webaudio/ layout tests cover this.
- Configurations/FeatureDefines.xcconfig:
- WebCore.xcodeproj/project.pbxproj: Add a build step which copies audio resources to
the WebCore.framework bundle.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 12:13 PM Changeset in webkit [96525] by
-
- 24 edits2 adds in trunk
BiquadFilterNode .type attribute is not handled correctly
https://bugs.webkit.org/show_bug.cgi?id=69182
Reviewed by Kenneth Russell.
Source/WebCore:
Test: webaudio/biquadfilternode-basic.html
- platform/audio/AudioDSPKernelProcessor.cpp:
(WebCore::AudioDSPKernelProcessor::initialize):
- webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
- webaudio/AudioChannelMerger.cpp:
(WebCore::AudioChannelMerger::AudioChannelMerger):
- webaudio/AudioChannelSplitter.cpp:
(WebCore::AudioChannelSplitter::AudioChannelSplitter):
- webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::AudioDestinationNode):
- webaudio/AudioGainNode.cpp:
(WebCore::AudioGainNode::AudioGainNode):
- webaudio/AudioNode.cpp:
(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::~AudioNode):
(WebCore::AudioNode::setNodeType):
(WebCore::AudioNode::ref):
(WebCore::AudioNode::finishDeref):
- webaudio/AudioNode.h:
(WebCore::AudioNode::nodeType):
- webaudio/AudioPannerNode.cpp:
(WebCore::AudioPannerNode::AudioPannerNode):
(WebCore::AudioPannerNode::notifyAudioSourcesConnectedToNode):
- webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::BiquadFilterNode):
(WebCore::BiquadFilterNode::setType):
- webaudio/BiquadFilterNode.h:
- webaudio/BiquadFilterNode.idl:
- webaudio/BiquadProcessor.h:
(WebCore::BiquadProcessor::setType):
- webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::ConvolverNode):
- webaudio/DelayNode.cpp:
(WebCore::DelayNode::DelayNode):
- webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
- webaudio/HighPass2FilterNode.cpp:
(WebCore::HighPass2FilterNode::HighPass2FilterNode):
- webaudio/JavaScriptAudioNode.cpp:
(WebCore::JavaScriptAudioNode::JavaScriptAudioNode):
- webaudio/LowPass2FilterNode.cpp:
(WebCore::LowPass2FilterNode::LowPass2FilterNode):
- webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
- webaudio/RealtimeAnalyserNode.cpp:
(WebCore::RealtimeAnalyserNode::RealtimeAnalyserNode):
- webaudio/WaveShaperNode.cpp:
(WebCore::WaveShaperNode::WaveShaperNode):
LayoutTests:
- webaudio/biquadfilternode-basic-expected.txt: Added.
- webaudio/biquadfilternode-basic.html: Added.
- 12:01 PM Changeset in webkit [96524] by
-
- 4 edits2 adds in trunk
AX: support role mapping for HTML5 section elements
https://bugs.webkit.org/show_bug.cgi?id=69150
Source/WebCore:
We need to map these HTML5 elements to appropriate ARIA roles. That mapping is:
article -> Document article
nav -> Landmark navigation
aside -> Landmark complementary
section -> Document region
address -> Landmark content info
header -> Landmark banner (unless it's in an article or section)
footer -> Landmark content info (unless it's in an article or section)
Reviewed by Darin Adler.
Test: platform/mac/accessibility/html-section-elements.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isDescendantOfElementType):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/AccessibilityRenderObject.h:
LayoutTests:
Reviewed by Darin Adler.
- platform/mac/accessibility/html-section-elements-expected.txt: Added.
- platform/mac/accessibility/html-section-elements.html: Added.
- 11:55 AM Changeset in webkit [96523] by
-
- 2 edits in trunk/Tools
Unreviewed: change my e-mail in commiters.py
(I'm leaving the company and my @openbossa.org will be no more)
- Scripts/webkitpy/common/config/committers.py:
- 11:09 AM Changeset in webkit [96522] by
-
- 1 edit2 adds in trunk/LayoutTests
AX: click point for AXHeadings often returns point on empty space (results in wrong context menu)
https://bugs.webkit.org/show_bug.cgi?id=69262
Actually commit the files this time.
Reviewed by John Sullivan.
- platform/mac/accessibility/heading-clickpoint-expected.txt: Added.
- platform/mac/accessibility/heading-clickpoint.html: Added.
- 11:05 AM Changeset in webkit [96521] by
-
- 1 edit1 add1 delete in trunk/LayoutTests
Results from more bots for http://trac.webkit.org/changeset/96498.
- platform/chromium-cg-mac-leopard/svg/filters/feColorMatrix-saturate-expected.png: Added.
- platform/chromium-win-vista/svg/filters: Removed.
- platform/chromium-win-vista/svg/filters/feColorMatrix-values-expected.png: Removed.
- 11:04 AM Changeset in webkit [96520] by
-
- 6 edits in trunk
AX: click point for AXHeadings often returns point on empty space (results in wrong context menu)
https://bugs.webkit.org/show_bug.cgi?id=69262
Source/WebCore:
When the contextual menu is opened for a heading, often it will open on empty space because
the heading is wider than the content inside. The click point should thus use the content
inside the heading as the click point.
To accomplish this we need to query whether we have children using children() which is a non-const
method, hence the removal of const from clickPoint().
Reviewed by John Sullivan.
Test: platform/mac/accessibility/heading-clickpoint.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::clickPoint):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::clickPoint):
- accessibility/AccessibilityRenderObject.h:
LayoutTests:
Reviewed by John Sullivan.
- platform/mac/accessibility/heading-clickpoint-expected.txt: Added.
- platform/mac/accessibility/heading-clickpoint.html: Added.
- 11:00 AM Changeset in webkit [96519] by
-
- 14 edits1 delete in trunk/Source/WebCore
Unreviewed, rolling out r96500.
http://trac.webkit.org/changeset/96500
https://bugs.webkit.org/show_bug.cgi?id=69268
Breaks inspector, change landed with no test. (Requested by
pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-03
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._linkifyLocation):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._consoleCleared):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
- inspector/front-end/EventListenersSidebarPane.js:
(WebInspector.EventListenersSidebarPane.prototype.update.callback):
(WebInspector.EventListenersSidebarPane.prototype.update):
():
- inspector/front-end/Linkifier.js: Removed.
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
- inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.createCell):
- inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileView):
(WebInspector.CPUProfileView.prototype._resetClicked):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyLocation):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.PopupContentHelper):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
- 10:51 AM Changeset in webkit [96518] by
-
- 2 edits in trunk/LayoutTests
Unbork the test_expectations file.
- platform/chromium/test_expectations.txt:
- 10:40 AM Changeset in webkit [96517] by
-
- 7 edits in trunk/Source/WebCore
Add exact match attribute selectors to the fast path
https://bugs.webkit.org/show_bug.cgi?id=69159
Reviewed by Sam Weinig.
Attribute selectors are increasingly common and we have them in our default style sheet too.
[foo] and [foo="bar"] type selectors can be resolved quickly and easily in the fast path.
- Implement fast path checking for simple attribute selectors.
- Get rid of the ill-defined CSSSelector::hasAttribute(), inline CSSSelector::attribute()
This is ~20% progression in styleForElement() performance loading the full HTML5 spec (~0.8s).
- css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText):
- css/CSSSelector.h:
(WebCore::CSSSelector::hasTag):
(WebCore::CSSSelector::attribute):
(WebCore::CSSSelector::isAttributeSelector):
- css/CSSSelectorList.cpp:
(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::checkSelector):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::fastCheckRightmostSelector):
(WebCore::SelectorChecker::fastCheckSelector):
(WebCore::isFastCheckableMatch):
(WebCore::isFastCheckableRightmostSelector):
(WebCore::SelectorChecker::isFastCheckableSelector):
(WebCore::SelectorChecker::checkSelector):
(WebCore::htmlAttributeHasCaseInsensitiveValue):
(WebCore::anyAttributeMatches):
(WebCore::SelectorChecker::checkOneSelector):
- css/SelectorChecker.h:
(WebCore::SelectorChecker::attributeNameMatches):
(WebCore::SelectorChecker::checkExactAttribute):
(WebCore::SelectorChecker::fastCheckRightmostAttributeSelector):
- 10:37 AM Changeset in webkit [96516] by
-
- 10 edits32 adds5 deletes in trunk/LayoutTests
Update expectations for tables tests after http://trac.webkit.org/changeset/96509.
- platform/chromium-cg-mac/tables/mozilla/bugs/bug113235-2-expected.png: Added.
- platform/chromium-cg-mac/tables/mozilla/bugs/bug23994-expected.png: Added.
- platform/chromium-cg-mac/tables/mozilla/bugs/bug56405-expected.png: Added.
- platform/chromium-cg-mac/tables/mozilla/bugs/bug56563-expected.png:
- platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png: Added.
- platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
- platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3517-expected.png: Added.
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
- platform/chromium-win-xp/fast/forms/file-input-disabled-expected.txt: Added.
- platform/chromium-win/fast/forms/file-input-disabled-expected.txt:
- platform/chromium-win/fast/invalid/residual-style-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
- platform/chromium/fast/invalid: Added.
- platform/chromium/fast/invalid/017-expected.txt: Added.
- platform/chromium/fast/invalid/018-expected.txt: Added.
- platform/chromium/fast/invalid/020-expected.txt: Added.
- platform/chromium/fast/invalid/residual-style-expected.txt: Added.
- platform/chromium/fast/invalid/table-inside-stray-table-content-expected.txt: Added.
- platform/chromium/fast/table: Added.
- platform/chromium/fast/table/inline-form-assert-expected.txt: Added.
- platform/chromium/tables: Added.
- platform/chromium/tables/mozilla: Added.
- platform/chromium/tables/mozilla/bugs: Added.
- platform/chromium/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
- platform/chromium/tables/mozilla/bugs/bug23994-expected.txt: Added.
- platform/chromium/tables/mozilla/bugs/bug56405-expected.txt: Added.
- platform/chromium/tables/mozilla/bugs/bug56563-expected.txt: Added.
- platform/chromium/tables/mozilla_expected_failures: Added.
- platform/chromium/tables/mozilla_expected_failures/bugs: Added.
- platform/chromium/tables/mozilla_expected_failures/bugs/bug220653-expected.txt: Added.
- platform/chromium/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
- platform/chromium/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt: Added.
- platform/chromium/tables/mozilla_expected_failures/core: Added.
- platform/chromium/tables/mozilla_expected_failures/core/conflicts-expected.txt: Added.
- platform/chromium/tables/mozilla_expected_failures/other: Added.
- platform/chromium/tables/mozilla_expected_failures/other/empty_cells-expected.txt: Added.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
- platform/mac/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
- platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
- tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
- 10:20 AM Changeset in webkit [96515] by
-
- 2 edits in trunk/Source/WebCore
respect other paint flags when setting flags for the font. No need to fiddle with DC(0) in paintSkiaText.
https://bugs.webkit.org/show_bug.cgi?id=69172
Reviewed by Stephen White.
No new tests. This is a cleanup/optimization, existing tests apply
- platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::getDefaultGDITextFlags):
(WebCore::setupPaintForFont):
(WebCore::paintSkiaText):
- 9:57 AM Changeset in webkit [96514] by
-
- 2 edits in trunk/LayoutTests
[Qt] REGRESSION(r95526): It made 3 inspector tests fail
https://bugs.webkit.org/show_bug.cgi?id=69265
- platform/qt/Skipped: Skip failing tests to make buildbot happy.
- 9:56 AM Changeset in webkit [96513] by
-
- 1 edit1 delete in trunk/LayoutTests
Delete bogus expected PNG.
- platform/chromium-linux/svg/filters/feColorMatrix-values-expected.png: Removed.
- 9:50 AM Changeset in webkit [96512] by
-
- 2 edits in trunk/Source/WebCore
FontFallbackList: Glyph pages waste a lot of memory.
https://bugs.webkit.org/show_bug.cgi?id=69260
Patch by Andreas Kling <kling@webkit.org> on 2011-10-03
Reviewed by Dan Bernstein.
Use a minimum hash table size of 16 (down from 64) for FontFallbackList's
glyph pages. This reduces memory consumption by ~900 kB when loading the
full HTML5 spec.
The cost is two additional rehash()es of FontFallbackList::m_pages when
adding the 32nd and 64th pages to the hash map.
- platform/graphics/FontFallbackList.h:
- 9:36 AM Changeset in webkit [96511] by
-
- 5 edits in trunk/Source/WebKit2
[GTK] Add failing uri parameter to provisional-load-failed and load-failed signals
https://bugs.webkit.org/show_bug.cgi?id=69252
Reviewed by Martin Robinson.
- UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
(didFailProvisionalLoadWithErrorForFrame): Pass failing URL to
signal handler.
(didFailLoadWithErrorForFrame): Ditto.
(webkit_web_loader_client_class_init): Add failing URL parameter
to provisional-load-failed and load-failed signals.
- UIProcess/API/gtk/WebKitWebLoaderClient.h:
- UIProcess/API/gtk/tests/testloading.c:
(loadStatusProvisionalLoadFailed): Update to API changes.
(loadStatusLoadFailed): Ditto.
(loadErrorProvisionalLoadFailed): Ditto.
- UIProcess/API/gtk/webkit2marshal.list:
- 9:19 AM Changeset in webkit [96510] by
-
- 2 edits in trunk/LayoutTests
Fix typo causing race condition in this test.
- svg/as-object/embedded-svg-immediate-offsetWidth-query.html:
- 9:19 AM Changeset in webkit [96509] by
-
- 30 edits1 copy2 adds in trunk
Right border missing from table with colspan and collapsing border
https://bugs.webkit.org/show_bug.cgi?id=14274
Patch by Konstantin Scheglov <scheglov@google.com> on 2011-10-03
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/table/border-collapsing/bug14274.html
- rendering/RenderTable.cpp:
(WebCore::RenderTable::RenderTable):
- rendering/RenderTable.h:
(WebCore::RenderTable::colToEffCol):
LayoutTests:
- fast/table/border-collapsing/bug14274-expected.png: Copied from LayoutTests/platform/chromium-win/fast/invalid/020-expected.png.
- fast/table/border-collapsing/bug14274-expected.txt: Added.
- fast/table/border-collapsing/bug14274.html: Added.
- platform/chromium-linux/fast/forms/file-input-disabled-expected.txt:
- platform/chromium-linux/fast/invalid/residual-style-expected.txt:
- platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
- platform/chromium-win/fast/invalid/017-expected.png:
- platform/chromium-win/fast/invalid/017-expected.txt:
- platform/chromium-win/fast/invalid/018-expected.png:
- platform/chromium-win/fast/invalid/018-expected.txt:
- platform/chromium-win/fast/invalid/020-expected.png:
- platform/chromium-win/fast/invalid/020-expected.txt:
- platform/chromium-win/fast/invalid/table-inside-stray-table-content-expected.txt:
- platform/chromium-win/fast/table/inline-form-assert-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug113235-2-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug23994-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug56405-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug56563-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug9024-expected.txt:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3517-expected.txt:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
- platform/chromium-win/tables/mozilla_expected_failures/core/conflicts-expected.txt:
- platform/chromium-win/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
- platform/gtk/fast/invalid/table-residual-style-crash-expected.txt:
- platform/mac/fast/invalid/table-residual-style-crash-expected.txt:
- platform/qt/fast/invalid/table-residual-style-crash-expected.txt:
- 9:17 AM Changeset in webkit [96508] by
-
- 5 edits in trunk
[GTK] Fix memory leak when loading url
https://bugs.webkit.org/show_bug.cgi?id=69247
Reviewed by Martin Robinson.
Release URL created with WKURLCreateWithUTF8CString().
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_load_uri):
Tools:
- MiniBrowser/gtk/BrowserWindow.c:
(activateUriEntryCallback):
- MiniBrowser/gtk/main.c:
(loadURI):
- 9:16 AM Changeset in webkit [96507] by
-
- 1 edit5 adds1 delete in trunk/LayoutTests
Update baselines after http://trac.webkit.org/changeset/96498.
- platform/chromium-linux-x86/svg/filters: Removed.
- platform/chromium-linux/svg/filters/feColorMatrix-values-expected.png: Added.
- platform/chromium-mac/svg/filters/feColorMatrix-saturate-expected.png: Added.
- platform/chromium-win-vista/svg/filters: Added.
- platform/chromium-win-vista/svg/filters/feColorMatrix-values-expected.png: Added.
- platform/chromium-win/svg/filters/feColorMatrix-saturate-expected.png: Added.
- 9:14 AM Changeset in webkit [96506] by
-
- 3 edits in trunk/Source/WebKit2
[UNIX] Rename NetscapePluginModule::pluginInfo to NetscapePluginModule::getPluginInfoForLoadedPlugin()
https://bugs.webkit.org/show_bug.cgi?id=69147
Reviewed by Martin Robinson.
- Shared/Plugins/Netscape/NetscapePluginModule.h:
- Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin):
(WebKit::NetscapePluginModule::getPluginInfo):
- 9:11 AM Changeset in webkit [96505] by
-
- 5 edits in trunk/Source
[GTK] Fix make distcheck build
https://bugs.webkit.org/show_bug.cgi?id=69243
Reviewed by Martin Robinson.
Source/JavaScriptCore:
- GNUmakefile.list.am:
Source/WebCore:
- GNUmakefile.am:
- GNUmakefile.list.am:
- 9:03 AM QtWebKitBuildBots edited by
- Update Qt5 on the WK2 bot (diff)
- 9:02 AM Changeset in webkit [96504] by
-
- 2 edits in trunk/LayoutTests
feColorMatrix saturation is not limited to range 0..1 anymore
https://bugs.webkit.org/show_bug.cgi?id=69245
Unreviewed rebaseline of Win Chromium DRT results.
- platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:
- 8:58 AM Changeset in webkit [96503] by
-
- 8 edits1 add in trunk/Source
[Qt] Build fix: Qt::escape is deprecated in Qt5
https://bugs.webkit.org/show_bug.cgi?id=69162
Use QString::toHtmlEscaped in the Qt5 case.
Source/JavaScriptCore:
Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-10-03
Reviewed by Andreas Kling.
- JavaScriptCore.pri:
- wtf/qt/UtilsQt.h: Added.
(escapeHtml):
- wtf/wtf.pri:
Source/WebCore:
Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-10-03
Reviewed by Andreas Kling.
No new tests needed.
- WebCore.pro: adjust the include path accordingly
in the v8 case.
Source/WebKit/qt:
Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-10-03
Reviewed by Andreas.
- Api/qwebpage.cpp:
(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::setToolTip):
- 8:51 AM Changeset in webkit [96502] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: [chromium] clean up inspector layout test suppressions on chromium.
https://bugs.webkit.org/show_bug.cgi?id=69263
- platform/chromium/test_expectations.txt:
- 8:43 AM Changeset in webkit [96501] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed gardening after r96404.
Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-10-03
- platform/qt-4.8/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
- platform/qt-4.8/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
- 8:07 AM Changeset in webkit [96500] by
-
- 14 edits1 add in trunk/Source/WebCore
Web Inspector: debuggerPresentatioModel.linkifyLocation leaks updateAnchor closure instances.
https://bugs.webkit.org/show_bug.cgi?id=69146
In many places we use linkifyLocation function to produce a link node which updates automatically when the source file is changed on the fly.
Such changes happen when we use pretty print or another operation that changes the source code somehow.
linkifyLocation associates a new instance of updateAnchor closure with the each link node and add the closure to the SourceMappingUpdated event's list.
As the result the node<->closure pairs wouldn't be collected until reset the UI and DebuggerPresentationModel.
Reviewed by Yury Semikhatsky.
Test: inspector/performance/resources/network-append-30-requests.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessage.prototype._linkifyLocation):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._consoleCleared):
- inspector/front-end/DebuggerPresentationModel.js:
- inspector/front-end/EventListenersSidebarPane.js:
(WebInspector.EventListenersSidebarPane.prototype.update.callback):
(WebInspector.EventListenersSidebarPane.prototype.update):
():
- inspector/front-end/Linkifier.js: Added.
(WebInspector.Linkifier):
(WebInspector.Linkifier.prototype.linkifyLocation):
(WebInspector.Linkifier.prototype.reset):
(WebInspector.Linkifier.prototype._updateSourceAnchors):
(WebInspector.Linkifier.prototype._updateAnchor):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
- inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.createCell):
- inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileView):
(WebInspector.CPUProfileView.prototype._resetClicked):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._linkifyLocation):
(WebInspector.TimelinePanel.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.PopupContentHelper):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
- 7:56 AM Changeset in webkit [96499] by
-
- 18 edits in trunk
Source/WebCore: Web Inspector: more compilation fixes including making ConsoleMessage a part of console model.
https://bugs.webkit.org/show_bug.cgi?id=69253
Reviewed by Yury Semikhatsky.
- inspector/Inspector.json:
- inspector/compile-front-end.sh:
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessage.create):
(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleMessageImpl):
- inspector/front-end/ConsoleModel.js:
(WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated):
(WebInspector.ConsoleMessage.create):
(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleDispatcher.prototype.messageAdded):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleCommandResult):
(WebInspector.ConsoleCommandResult.prototype.toMessageElement):
- inspector/front-end/CookieParser.js:
(WebInspector.Cookie.prototype.get path):
(WebInspector.Cookie.prototype.get domain):
(WebInspector.Cookie.prototype.expires):
- inspector/front-end/DOMAgent.js:
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onAddConsoleMessage):
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype._createResource):
- inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.prototype.setContent):
(WebInspector.Resource.prototype.searchInContent):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._createResource):
- inspector/front-end/externs.js:
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
(WebInspector.extensionServer.notifyResourceContentCommitted):
(WebInspector.resourceForURL):
(WebInspector.debuggerPresentationModel.linkifyLocation):
(WebInspector.ObjectPropertiesSection):
(WebInspector.ElementsTreeOutline):
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector.log.logMessage):
(WebInspector.log):
- inspector/generate-protocol-externs:
Tools: Unreviewed. Add Zoltán Árvai as contributor.
Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2011-10-03
- Scripts/webkitpy/common/config/committers.py:
- 7:27 AM Changeset in webkit [96498] by
-
- 6 edits3 adds in trunk
feColorMatrix saturation is not limited to range 0..1 anymore
https://bugs.webkit.org/show_bug.cgi?id=69245
Source/WebCore:
Reviewed by Nikolas Zimmermann.
Opera doesn't limit the range of values for saturation on feColorMatrix from 0 to 1. The limitation
was also removed from the new Filter Effects 1.0 specification. Values outside this range lead to
under- or oversaturation of the filter input image.
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/publish/Filters.html#feColorMatrixElement
Test: svg/filters/feColorMatrix-saturate.svg
- svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::build):
LayoutTests:
Reviewed by Nikolas Zimmermann.
Added new test case to test under- or oversaturation of the filter input image if the value
is not in the range of 0..1.
feColorMatrix-values needed a change, since it relies to the old specification text.
- platform/mac/svg/filters/feColorMatrix-values-expected.png:
- platform/mac/svg/filters/feColorMatrix-values-expected.txt:
- svg/filters/feColorMatrix-saturate-expected.png: Added.
- svg/filters/feColorMatrix-saturate-expected.txt: Added.
- svg/filters/feColorMatrix-saturate.svg: Added.
- svg/filters/feColorMatrix-values.svg:
- 7:21 AM Changeset in webkit [96497] by
-
- 1 edit2 adds in trunk/Tools
[EFL] DRT: Add DumpHistoryItem.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=63992
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-03
Reviewed by Antonio Gomes.
This is the code responsible for dumping the back and forward history
list.
- DumpRenderTree/efl/DumpHistoryItem.cpp: Added.
(dumpHistoryItem):
(dumpBackForwardListForWebView):
(dumpBackForwardListForWebViews):
- DumpRenderTree/efl/DumpHistoryItem.h: Added.
- 7:16 AM Changeset in webkit [96496] by
-
- 3 edits in trunk/Source/WebCore
Shrink HTMLLIElement.
https://bugs.webkit.org/show_bug.cgi?id=69250
Patch by Andreas Kling <kling@webkit.org> on 2011-10-03
Reviewed by Antti Koivisto.
Don't cache the explicit "value" attribute on the HTMLLIElement,
but fetch it with fastGetAttribute when needed.
This shrinks HTMLLIElement by one CPU word.
- html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::HTMLLIElement):
(WebCore::HTMLLIElement::parseMappedAttribute):
(WebCore::HTMLLIElement::attach):
- html/HTMLLIElement.h:
- 7:13 AM Changeset in webkit [96495] by
-
- 3 edits3 moves in trunk/Source/WebKit/efl
[EFL] Rename ewk_tiled_*.c to ewk_tiled_*.cpp
https://bugs.webkit.org/show_bug.cgi?id=68599
Use a C++ compiler for these files and fix compile issues and coding style.
Reviewed by Hajime Morita.
- CMakeListsEfl.txt:
- ewk/ewk_tiled_backing_store.cpp: Renamed from Source/WebKit/efl/ewk/ewk_tiled_backing_store.c.
- ewk/ewk_tiled_backing_store.h:
- ewk/ewk_tiled_matrix.cpp: Renamed from Source/WebKit/efl/ewk/ewk_tiled_matrix.c.
- ewk/ewk_tiled_model.cpp: Renamed from Source/WebKit/efl/ewk/ewk_tiled_model.c.
- 7:04 AM Changeset in webkit [96494] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WebKit2][Mac] WebProcess should exit automatically when UIProcess dies.
https://bugs.webkit.org/show_bug.cgi?id=68439
We use a dispatch queue and a dispatch source in the WebProcess
to receive a notification when the UI Process dies.
The WebProcess then commits suicide.
Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-03
Reviewed by Andreas Kling.
- WebProcess/qt/WebProcessQt.cpp:
(WebKit::parentProcessDiedCallback):
(WebKit::WebProcess::platformInitializeWebProcess):
- 6:58 AM Changeset in webkit [96493] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening after r96257.
https://bugs.webkit.org/show_bug.cgi?id=69257
Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-10-03
- platform/qt/Skipped:
- 6:06 AM Changeset in webkit [96492] by
-
- 2 edits in trunk/Source/JavaScriptCore
libdispatch based ParallelJobs is not enough parallel
https://bugs.webkit.org/show_bug.cgi?id=66378
Reviewed by Zoltan Herczeg.
Use the appropriate libdispatch API for our use case.
Throw away the hard coded limit of parallel threads
and use dispatch_apply with the default priority normal
queue istead of using our own custom serial queue (which
was a misuse of the API). Enabling PARALLEL_JOBS is now
a 60% win (2.63x as fast) on the methanol benchmark
(https://gitorious.org/methanol) with an SVG centric test set
while the old implementation was almost identical (less than 5% win).
- wtf/ParallelJobsLibdispatch.h:
(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
- 5:56 AM Changeset in webkit [96491] by
-
- 11 edits5 adds in trunk
Web Inspector: Add support for backend search in script content.
https://bugs.webkit.org/show_bug.cgi?id=69015
Reviewed by Pavel Feldman.
Source/WebCore:
Tests: http/tests/inspector/search/search-in-concatenated-script.html
http/tests/inspector/search/search-in-script.html
- inspector/Inspector.json:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):
- inspector/InspectorDebuggerAgent.h:
- inspector/front-end/ContentProviders.js:
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ScriptContentProvider.prototype.searchInContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.maybeCallback):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.searchCallback):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent):
- inspector/front-end/Script.js:
(WebInspector.Script.prototype.requestSource):
(WebInspector.Script.prototype.searchInContent):
LayoutTests:
- http/tests/inspector/resource-tree/resource-tree-test.js:
(initialize_ResourceTreeTest):
- http/tests/inspector/resources-test.js:
(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.maybeCallback):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.addSniffer):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.resourceAddedToFrame):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.visit):
(initialize_ResourceTest):
- http/tests/inspector/search/resources/search-concatenated.html: Added.
- http/tests/inspector/search/search-in-concatenated-script-expected.txt: Added.
- http/tests/inspector/search/search-in-concatenated-script.html: Added.
- http/tests/inspector/search/search-in-resource.html:
- http/tests/inspector/search/search-in-script-expected.txt: Added.
- http/tests/inspector/search/search-in-script.html: Added.
- http/tests/inspector/search/search-test.js:
(initialize_SearchTest):
- 4:58 AM Changeset in webkit [96490] by
-
- 9 edits1 delete in trunk/Source/WebKit/chromium
Unreviewed, rolling out r96481.
http://trac.webkit.org/changeset/96481
https://bugs.webkit.org/show_bug.cgi?id=69251
Breaks webkit_unit_tests on Linux(dbg) (Requested by hwennborg
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-03
- WebKit.gypi:
- public/WebCompositor.h:
- public/WebWidgetClient.h:
- src/WebCompositorImpl.cpp:
(WebKit::WebCompositorImpl::WebCompositorImpl):
(WebKit::WebCompositorImpl::~WebCompositorImpl):
(WebKit::WebCompositorImpl::setClient):
(WebKit::WebCompositorImpl::handleInputEvent):
- src/WebCompositorImpl.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- src/WebViewImpl.h:
- tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHost::MockLayerTreeHost):
- tests/WebCompositorImplTest.cpp: Removed.
- 4:37 AM Changeset in webkit [96489] by
-
- 2 edits in trunk/Tools
[Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch.
https://bugs.webkit.org/show_bug.cgi?id=69223
WebKitTestRunner must include Qt / qnamespace header
to get a definition of Qt::MouseButtons.
Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-03
Reviewed by Andreas Kling.
- WebKitTestRunner/EventSenderProxy.h:
- 3:55 AM Changeset in webkit [96488] by
-
- 2 edits in trunk/Tools
Unreviewed. Add Zoltán Árvai as contributor.
- Scripts/webkitpy/common/config/committers.py:
- 2:54 AM Changeset in webkit [96487] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: move console message formatting from ConsoleView.js into ConsoleMessage.js
https://bugs.webkit.org/show_bug.cgi?id=69244
Reviewed by Yury Semikhatsky.
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.prototype._formatMessage.else.else.linkifier):
(WebInspector.ConsoleMessage.prototype._formatMessage):
(WebInspector.ConsoleMessage.prototype._format):
(WebInspector.ConsoleMessage.prototype._formatParameter):
(WebInspector.ConsoleMessage.prototype._formatParameterAsValue):
(WebInspector.ConsoleMessage.prototype._formatParameterAsObject):
(WebInspector.ConsoleMessage.prototype._formatParameterAsNode):
(WebInspector.ConsoleMessage.prototype._formatParameterAsArray):
(WebInspector.ConsoleMessage.prototype._formatParameterAsString):
(WebInspector.ConsoleMessage.prototype._printArray):
(WebInspector.ConsoleMessage.prototype._formatAsArrayEntry):
(WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString):
- inspector/front-end/ConsoleView.js:
- 2:30 AM Changeset in webkit [96486] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed Qt gardening after r96404
Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-10-03
- platform/qt/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
- platform/qt/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
- 2:18 AM WebKit Team edited by
- (diff)
- 2:16 AM Changeset in webkit [96485] by
-
- 11 edits in trunk/Source/WebCore
Web Inspector: restore partial front-end compilability
https://bugs.webkit.org/show_bug.cgi?id=69221
Removed unused isWhitespace; introduced missing classes in Inspector.json;
generated externs for the protocol types along with the commands.
Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-03
Reviewed by Yury Semikhatsky.
- inspector/Inspector.json:
- inspector/compile-front-end.sh:
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent):
(WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable.onDocumentAvailable):
(WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
- inspector/front-end/ElementsTreeOutline.js:
():
- inspector/front-end/Object.js:
- inspector/front-end/Popover.js:
(WebInspector.PopoverHelper.prototype._mouseMove):
- inspector/front-end/View.js:
- inspector/front-end/externs.js:
(Array.prototype.remove):
- inspector/generate-protocol-externs:
Oct 2, 2011:
- 11:59 PM Changeset in webkit [96484] by
-
- 14 edits4 adds in trunk
method/enctype/formMethod/formEnctype properties should be limited to known values.
https://bugs.webkit.org/show_bug.cgi?id=68887
Reviewed by Hajime Morita.
Source/WebCore:
According to the standard and other browser behaviors, the
following IDL properties should be reflected to the corresponding
HTML attributes on setting, but should return normalized values on
getting.
- HTMLFormElement::method
- HTMLFormElement::enctype
- HTMLInputElement::formMethod
- HTMLInputElement::formEnctype
- HTMLButtonElement::formMethod
- HTMLButtonElement::formEnctype
Tests: fast/forms/enctype-attribute.html
fast/forms/method-attribute.html
- html/HTMLButtonElement.idl:
Replace 'Reflect' with 'ConvertNullToNullString' in order to use a
getter function.
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::formEnctype):
Normalizes the value by parseEncodingType().
(WebCore::HTMLFormControlElement::setFormEnctype):
Simply calls setAttribute()
(WebCore::HTMLFormControlElement::formMethod):
Normalizes the value by parseMethodType().
(WebCore::HTMLFormControlElement::setFormMethod):
Simply calls setAttribute()
- html/HTMLFormControlElement.h:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::parseMappedAttribute):
Follow the Attributes function renaming.
(WebCore::HTMLFormElement::method):
Normalizes the value by parseMethodType().
- html/HTMLFormElement.idl:
Replace 'Reflect' with 'ConvertNullToNullString' in order to use a
getter function.
- html/HTMLInputElement.idl: ditto.
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::Attributes::parseEncodingType):
New function made from a part of old parseEncodingType().
(WebCore::FormSubmission::Attributes::updateEncodingType):
Renamed from parseEncodingType().
(WebCore::FormSubmission::Attributes::parseMethodType):
New function made from a part of old parseMethodType().
(WebCore::FormSubmission::Attributes::updateMethodType):
Renamed from parseMethodType().
(WebCore::FormSubmission::create):
Follow the Attributes function renaming.
- loader/FormSubmission.h:
(WebCore::FormSubmission::Attributes::methodString):
A helper function to provide normalized strings for FormSubmission::Method.
LayoutTests:
- fast/dom/element-attribute-js-null-expected.txt:
- fast/dom/element-attribute-js-null.html: Correct an expectation for HTMLFormElement::method.
- fast/forms/enctype-attribute-expected.txt: Added.
- fast/forms/enctype-attribute.html: Added.
- fast/forms/method-attribute-expected.txt: Added.
- fast/forms/method-attribute.html: Added.
- fast/forms/script-tests/submit-form-attributes.js: Correct expectations.
- fast/forms/submit-form-attributes-expected.txt: ditto.
- 11:49 PM Changeset in webkit [96483] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt]REGRESSION(r95912): It made sputnik tests flakey
https://bugs.webkit.org/show_bug.cgi?id=68990
Reviewed by Geoffrey Garen.
Changing signed char to int in r96354 solved the
problem. However transitionCount still returns
with a signed char and should be changed to int.
- runtime/Structure.h:
(JSC::Structure::transitionCount):
- 7:13 PM Changeset in webkit [96482] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG misses some obvious opportunities for common subexpression elimination
https://bugs.webkit.org/show_bug.cgi?id=69233
Reviewed by Oliver Hunt.
0.7% speed-up on SunSpider.
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
- 6:11 PM Changeset in webkit [96481] by
-
- 9 edits1 copy in trunk/Source/WebKit/chromium
[chromium] Add WebWidget API for accessing the current WebCompositor
https://bugs.webkit.org/show_bug.cgi?id=69181
Patch by James Robinson <jamesr@chromium.org> on 2011-10-02
Reviewed by Darin Fisher.
Add new WebWidgetClient::did(Activate|Deactivate)Compositor calls intended to replace
didActivateAccleratedCompositing(bool) so that the enable call can be parameterized.
Add a WebCompositor identifier parameter to didEnableAcceleratedCompositing that can be used on the compositor
thread to get access to a WebCompositor pointer.
- public/WebWidget.h:
(WebKit::WebWidget::compositor):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::compositor):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- src/WebViewImpl.h:
- 5:40 PM Changeset in webkit [96480] by
-
- 6 edits in trunk/Source
Strength reduce Mac only Frame::searchForLabelsBeforeElement and Frame::matchLabelsAgainstElement into callers
https://bugs.webkit.org/show_bug.cgi?id=69230
Reviewed by Anders Carlsson.
../WebCore:
- WebCore.exp.in:
- page/Frame.h:
- page/mac/FrameMac.mm:
../WebKit/mac:
- WebView/WebHTMLRepresentation.mm:
(regExpForLabels):
(searchForLabelsBeforeElement):
(matchLabelsAgainstString):
(matchLabelsAgainstElement):
(-[WebHTMLRepresentation searchForLabels:beforeElement:resultDistance:resultIsInCellAbove:]):
(-[WebHTMLRepresentation matchLabels:againstElement:]):
- 5:22 PM Changeset in webkit [96479] by
-
- 5 edits in trunk
Bug 67455 - Different regular expression result
Reviewed by Darin Adler.
Fix a regression introduced in r72140. A return was added to the backtracking loop for
backtrackParentheses with QuantifierNonGreedy, so it always returns after one iteration.
This is incorrect. The additional return should only trigger to force an early return if
an error has occured.
Source/JavaScriptCore:
- yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::matchParentheses):
- Simplify some nested if else logic.
(JSC::Yarr::Interpreter::backtrackParentheses):
- Simplify some nested if else logic.
- Only return early from backtrackParentheses on success/error, not on failure.
LayoutTests:
- fast/regex/parentheses-expected.txt:
- fast/regex/script-tests/parentheses.js:
- Added test cases from bug.
- 1:02 PM Changeset in webkit [96478] by
-
- 2 edits in trunk/Source/WebKit/mac
REGRESSION (r95474): Unable to type anywhere in nightly builds in WebKit1 mode
https://bugs.webkit.org/show_bug.cgi?id=68542
Reviewed by Mark Rowe.
- WebView/WebView.mm: (-[WebView _usesDocumentViews]): Re-add this method for now.
- 12:54 PM Changeset in webkit [96477] by
-
- 5 edits in trunk/Source
[Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch.
https://bugs.webkit.org/show_bug.cgi?id=69223
Source/WebCore:
Add a missing import (NSWindow.h) in WebVideoFullscreenHUDWindowController.
Add a missing include path and a missing objective source file to WebCore.pro.
Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-02
Reviewed by Noam Rosenthal.
No new tests, build fix.
- WebCore.pro:
- platform/mac/WebVideoFullscreenHUDWindowController.h:
Source/WebKit2:
After the merge of the Qt5 refactor branch, networking stuff has been
extracted into a separate library. The qmlplugin needs to link to that
library to get QNetworkReply defined.
Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-02
Reviewed by Noam Rosenthal.
- UIProcess/API/qt/qmlplugin/qmlplugin.pro:
- 12:41 PM Changeset in webkit [96476] by
-
- 2 edits in trunk/Source/WebCore
Remove an unused member in RenderTable::ColumnStruct
https://bugs.webkit.org/show_bug.cgi?id=69119
Reviewed by Darin Adler.
No test as there should be no change in behavior.
The member was added several years ago and its users were removed or changed. The code would
need a refactoring but this would be tricky to get right. This change just removes the member
to reap the short-term benefits.
- rendering/RenderTable.h:
(WebCore::RenderTable::ColumnStruct::ColumnStruct): Remove anything associated with m_width.
- 10:38 AM Changeset in webkit [96475] by
-
- 1 edit2 adds15 deletes in trunk/LayoutTests
Remove temporary baselines after http://trac.webkit.org/changeset/96470.
- platform/chromium-cg-mac-leopard/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
- platform/chromium-cg-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
- platform/chromium-cg-mac/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
- platform/chromium-linux-x86/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
- platform/chromium-linux-x86/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
- platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
- platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
- platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
- platform/chromium-win-vista/svg/css: Removed.
- platform/chromium-win-vista/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
- platform/chromium-win-xp/svg/css: Removed.
- platform/chromium-win-xp/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
- platform/chromium-win/svg/filters/filter-clip-expected.txt: Removed.
- platform/chromium/svg/filters: Removed.
- platform/chromium/svg/filters/filter-clip-expected.txt: Removed.
- platform/gtk/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
- platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
- svg/css/circle-in-mask-with-shadow-expected.txt: Added.
- 10:35 AM Changeset in webkit [96474] by
-
- 3 edits in trunk/Tools
Clean up obsolete code in gardeningserver.py related to
STATIC_FILE_NAMES. Rather than serve the UI via the Python HTTP
server, we just serve it off the filesystem directly.
We had planned to serve the UI off build.webkit.org, but that server is
somewhat slow. We'll probably serve the UI of some web server, but
we'll need to work that out later.
- Scripts/webkitpy/tool/commands/gardenomatic.py:
- Scripts/webkitpy/tool/servers/gardeningserver.py:
- 10:18 AM Changeset in webkit [96473] by
-
- 10 edits in trunk/Tools
Rip out half-backed garden-o-matic features in preparation for wider use
https://bugs.webkit.org/show_bug.cgi?id=69226
This patch rips out a bunch of half-baked features and cleans up a
bunch of small nits with the core set of features. We're going to ask
more folks to start using the tool, and having a bunch of half-baked
features around is distracting. We can add these features back under a
flag and interate on them after we've got the core functionality
nailed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
- 8:25 AM Changeset in webkit [96472] by
-
- 14 edits22 adds10 deletes in trunk/LayoutTests
Update baseline and expectations after http://trac.webkit.org/changeset/96470
- platform/chromium-cg-mac-leopard/svg/custom/grayscale-gradient-mask-expected.png:
- platform/chromium-cg-mac-leopard/svg/custom/mask-colorspace-expected.png: Removed.
- platform/chromium-cg-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Added.
- platform/chromium-cg-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
- platform/chromium-cg-mac/svg/custom/grayscale-gradient-mask-expected.png:
- platform/chromium-cg-mac/svg/custom/grayscale-gradient-mask-expected.txt: Added.
- platform/chromium-cg-mac/svg/custom/mask-colorspace-expected.png: Added.
- platform/chromium-cg-mac/svg/custom/mask-with-all-units-expected.png: Added.
- platform/chromium-cg-mac/svg/filters/filter-clip-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
- platform/chromium-linux-x86/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
- platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.png:
- platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
- platform/chromium-linux/svg/custom/mask-colorspace-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
- platform/chromium-mac/svg/custom/mask-colorspace-expected.png:
- platform/chromium-mac/svg/filters/filter-clip-expected.png:
- platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
- platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
- platform/chromium-win-vista/svg/css: Added.
- platform/chromium-win-vista/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
- platform/chromium-win-xp/svg/css: Added.
- platform/chromium-win-xp/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
- platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
- platform/chromium-win/svg/css/circle-in-mask-with-shadow-expected.png:
- platform/chromium-win/svg/custom/mask-colorspace-expected.png:
- platform/chromium-win/svg/filters/filter-clip-expected.txt: Added.
- platform/chromium/svg/filters: Added.
- platform/chromium/svg/filters/filter-clip-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/gtk/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
- platform/gtk/svg/custom/mask-with-all-units-expected.txt: Removed.
- platform/gtk/svg/filters/filter-clip-expected.txt: Removed.
- platform/mac/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
- platform/mac/svg/custom/mask-with-all-units-expected.txt: Removed.
- platform/mac/svg/filters/filter-clip-expected.txt: Removed.
- platform/qt/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
- platform/qt/svg/custom/mask-with-all-units-expected.txt: Removed.
- platform/qt/svg/filters/filter-clip-expected.txt: Removed.
- svg/custom/grayscale-gradient-mask-expected.txt: Added.
- svg/custom/mask-with-all-units-expected.txt: Added.
- svg/filters/filter-clip-expected.txt: Added.
- 1:25 AM Changeset in webkit [96471] by
-
- 3 edits2 adds in trunk
REGRESSION (r95502): Assertion failure in CSSPrimitiveValue::computeLengthDouble() when media query specifies unit-less length
https://bugs.webkit.org/show_bug.cgi?id=68760
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/media/invalid-lengths.html
Made length-comparison media queries accept only length values. In compatibility mode, numbers
are allowed as well, and they are interpreted as pixels.
- css/MediaQueryEvaluator.cpp:
(WebCore::computeLength): Added this helper function.
(WebCore::device_heightMediaFeatureEval): Changed to use computeLength().
(WebCore::device_widthMediaFeatureEval): Ditto.
(WebCore::heightMediaFeatureEval): Ditto.
(WebCore::widthMediaFeatureEval): Ditto.
LayoutTests:
- fast/media/invalid-lengths-expected.txt: Added.
- fast/media/invalid-lengths.html: Added.
- 12:15 AM Changeset in webkit [96470] by
-
- 5 edits3 adds in trunk
SVG Mask should take 'color-interpolation' into account to determine the color space of the mask image
https://bugs.webkit.org/show_bug.cgi?id=69076
Source/WebCore:
Reviewed by Simon Fraser.
SVG Masks should take 'color-interpolation' into account to determine the color space of the mask image.
The behavior was changed in SVG 1.1 SE. The color space of the mask image gets defined by the computed value of the
'color-interpolation' property. This will switch the default color space from linearRGB to sRGB for mask images and
is a performance improvement for platforms without native support for linearRGB color space. The
color space transformation can be avoided.
Test: svg/custom/grayscale-gradient-mask-2.svg
- rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
- rendering/svg/RenderSVGResourceMasker.h:
LayoutTests:
Reviewed by Simon Fraser.
Added a new test case to check the behavior of SVG Masks on different values for the 'color-interpolation' property.
Since the default color space of the mask image changes from linearRGB to sRGB, a test needed an update.
- platform/mac/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
- platform/mac/svg/custom/grayscale-gradient-mask-2-expected.txt: Added.
- platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
- platform/mac/svg/custom/grayscale-gradient-mask-expected.txt:
- svg/custom/grayscale-gradient-mask-2.svg: Added.
