Timeline
Oct 10, 2011:
- 10:33 PM Changeset in webkit [97126] by
-
- 3 edits in trunk/LayoutTests
[Chromium] Fix expectations from r97120. (again)
Unreviewed.
- platform/chromium-linux/editing/pasteboard/smart-paste-008-expected.png:
- platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png:
- 10:12 PM Changeset in webkit [97125] by
-
- 1 edit3 copies in branches/chromium/874
Merge 97124 - Style not updated on text fragment in :first-letter nested in :before table.
BUG=99294
Review URL: http://codereview.chromium.org/8229001
- 10:08 PM Changeset in webkit [97124] by
-
- 3 edits3 adds in trunk
Style not updated on text fragment in :first-letter
nested in :before table.
https://bugs.webkit.org/show_bug.cgi?id=69540
Reviewed by Dan Bernstein.
Source/WebCore:
Test: fast/css-generated-content/first-letter-in-nested-before-table.html
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
LayoutTests:
- fast/css-generated-content/first-letter-in-nested-before-table-expected.png: Added.
- fast/css-generated-content/first-letter-in-nested-before-table-expected.txt: Added.
- fast/css-generated-content/first-letter-in-nested-before-table.html: Added.
- 9:57 PM Changeset in webkit [97123] by
-
- 6 edits in trunk/Source/WebCore
Unreviewed, rolling out r97121.
http://trac.webkit.org/changeset/97121
https://bugs.webkit.org/show_bug.cgi?id=69815
Many layout tests failed (Requested by tkent on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-10
- dom/SelectElement.cpp:
(WebCore::SelectElementData::SelectElementData):
(WebCore::SelectElementData::checkListItems):
(WebCore::SelectElementData::listItems):
- dom/SelectElement.h:
(WebCore::SelectElementData::shouldRecalcListItems):
(WebCore::SelectElementData::setShouldRecalcListItems):
(WebCore::SelectElementData::rawListItems):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::HTMLSelectElement):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
(WebCore::HTMLSelectElement::nextSelectableListIndex):
(WebCore::HTMLSelectElement::previousSelectableListIndex):
(WebCore::HTMLSelectElement::firstSelectableListIndex):
(WebCore::HTMLSelectElement::lastSelectableListIndex):
(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::setRecalcListItems):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::setSelectedIndexInternal):
(WebCore::HTMLSelectElement::optionToListIndex):
(WebCore::HTMLSelectElement::listToOptionIndex):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
(WebCore::HTMLSelectElement::lastSelectedListIndex):
(WebCore::HTMLSelectElement::typeAheadFind):
(WebCore::HTMLSelectElement::insertedIntoTree):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
(WebCore::HTMLSelectElement::length):
- html/HTMLSelectElement.h:
(WebCore::HTMLSelectElement::listItems):
- html/HTMLSelectElementWin.cpp:
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
- 9:55 PM Changeset in webkit [97122] by
-
- 7 edits1 copy1 add1 delete in trunk/LayoutTests
[Chromium] Fix expectations from r97120.
Unreviewed.
- platform/chromium-cg-mac-leopard/editing/pasteboard/smart-paste-008-expected.png:
- platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png:
- platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.txt: Removed.
- platform/chromium-linux/editing/pasteboard/smart-paste-008-expected.png:
- platform/chromium-mac-leopard/editing/pasteboard/smart-paste-008-expected.png: Added.
- platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png:
- platform/chromium-win/editing/pasteboard/smart-paste-008-expected.png:
- platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt: Copied from LayoutTests/platform/chromium/editing/pasteboard/smart-paste-008-expected.txt.
- platform/chromium/editing/pasteboard/smart-paste-008-expected.txt:
- 9:16 PM Changeset in webkit [97121] by
-
- 6 edits in trunk/Source/WebCore
Move m_listItems and m_recalcListItems from SelectElementData to HTMLSelectElement
https://bugs.webkit.org/show_bug.cgi?id=69812
Reviewed by Ryosuke Niwa.
Move SelectElementData::m_recalcListItems,
SelectElementData::m_listItems, and related functions of
SelectElementData class to HTMLSelectElement.
Non-const listItems() was removed because it is used only in
recalcListItemsInternal() and it can access m_listItems diretly.
Static recalcListItems() is changed to non-static, and renamed to
recalcListItemsInternal() in order to avoid confusion with the
existing recalcListItems().
No new tests, just a refactoring.
- dom/SelectElement.cpp:
Move checkListItems() and listItems() to HTMLSelectElement.
(WebCore::SelectElementData::SelectElementData):
Remove Initialization of m_recalcListItems.
- dom/SelectElement.h:
Move m_recalcListItems, m_listItems, and related functions to HTMLSelectElement.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::HTMLSelectElement):
Initializes m_recalcListItems.
(WebCore::HTMLSelectElement::recalcListItems):
Rename the static recalcListItems() to recalcListItemsInternal().
(WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
Use m_recalcListItems directly.
(WebCore::HTMLSelectElement::nextSelectableListIndex):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::previousSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::firstSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::lastSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): ditto.
(WebCore::HTMLSelectElement::saveLastSelection): ditto.
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto.
(WebCore::HTMLSelectElement::updateListBoxSelection): ditto.
(WebCore::HTMLSelectElement::listBoxOnChange): ditto.
(WebCore::HTMLSelectElement::checkListItems):
Moved from SelectElementData.
(WebCore::HTMLSelectElement::listItems): ditto.
(WebCore::HTMLSelectElement::setRecalcListItems):
Use m_recalcListItems directly.
(WebCore::HTMLSelectElement::recalcListItemsInternal):
- Make this non-static.
- Renamed from recalcListItems() to avoid confilct with another recalcListItems().
- Use m_recalcListItems and m_listItems directly.
(WebCore::HTMLSelectElement::selectedIndex):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::setSelectedIndexInternal): ditto.
(WebCore::HTMLSelectElement::optionToListIndex): ditto.
(WebCore::HTMLSelectElement::listToOptionIndex): ditto.
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation): ditto.
(WebCore::HTMLSelectElement::saveFormControlState):
Update callsites of listItems() and recalcListItems().
(WebCore::HTMLSelectElement::restoreFormControlState):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::appendFormData): ditto.
(WebCore::HTMLSelectElement::reset): ditto.
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::updateSelectedState): ditto.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::lastSelectedListIndex): ditto.
(WebCore::HTMLSelectElement::typeAheadFind): ditto.
(WebCore::HTMLSelectElement::insertedIntoTree):
Update a recalcListItems() callsite.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::length): ditto.
- html/HTMLSelectElement.h:
Move m_recalcListItems, m_listItems, and related functions from SelectElementData.
- html/HTMLSelectElementWin.cpp:
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
Update a listItems() callsite.
- 8:01 PM Changeset in webkit [97120] by
-
- 3 edits1 move7 adds in trunk/LayoutTests
[Chromium] Rebaselines for r97102 and r97114. Pass 2 more tests.
Unreviewed.
- platform/chromium-cg-mac-leopard/editing/pasteboard/smart-paste-008-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.txt: Added.
- platform/chromium-cg-mac-snowleopard/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
- platform/chromium-linux/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
- platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/pasteboard/smart-paste-008-expected.png.
- platform/chromium-win/editing/pasteboard/smart-paste-008-expected.png:
- platform/chromium-win/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 6:15 PM Changeset in webkit [97119] by
-
- 1 edit1 move in trunk/LayoutTests
Fix r97115. smart-paste-008.html is in editing/paste, not in fast/events.
- platform/chromium/editing/pasteboard/smart-paste-008-expected.txt: Copied from
LayoutTests/platform/chromium/fast/events/smart-paste-008-expected.txt.
- platform/chromium/fast/events/smart-paste-008-expected.txt: Removed.
- 6:14 PM Changeset in webkit [97118] by
-
- 8 edits in trunk/Source/JavaScriptCore
DFG JSVALUE64 spill/fill code should not box integers and doubles
https://bugs.webkit.org/show_bug.cgi?id=69782
Reviewed by Oliver Hunt.
Added the notion of DataFormatInteger and DataFormatDouble to the spillFormat.
This required changing all of the places that spill registers (both silently
and not) and filling registers (both silently and on demand). It also required
changing OSR exit to recognize that a spilled value (DisplacedInRegisterFile)
may have the wrong format for the old JIT (unboxed int or double).
This is a slight win on Kraken (0.25%) and neutral elsewhere.
- dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::spill):
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::spill):
- dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueRecovery::displacedInRegisterFile):
(JSC::DFG::ValueRecovery::virtualRegister):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
- 6:01 PM Changeset in webkit [97117] by
-
- 5 edits in trunk/Source/JavaScriptCore
DFG JIT switch dfgConvert methods to use callOperation
https://bugs.webkit.org/show_bug.cgi?id=69806
Reviewed by Filip Pizlo.
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
- dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
- dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
- dfg/DFGOperations.h:
- 5:57 PM Changeset in webkit [97116] by
-
- 2 edits3 copies in branches/chromium/874
Merge 97114 - <rdar://problem/10246137> Duplicate ::after content when both ::before and ::after are styled as table parts
BUG=99348
Review URL: http://codereview.chromium.org/8222024
- 5:49 PM Changeset in webkit [97115] by
-
- 2 edits2 moves2 deletes in trunk/LayoutTests
Another Chromium rebaseline after r97102.
- platform/chromium-cg-mac-snowleopard/fast/events/ondragenter-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/events/ondragenter-expected.txt: Removed.
- platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt: Removed.
- platform/chromium-win/fast/events/ondragenter-expected.txt: Removed.
- platform/chromium/fast/events/ondragenter-expected.txt: Copied from
LayoutTests/platform/chromium-win/fast/events/ondragenter-expected.txt.
- platform/chromium/fast/events/smart-paste-008-expected.txt: Copied from
LayoutTests/platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt.
- platform/chromium/test_expectations.txt:
- 5:46 PM Changeset in webkit [97114] by
-
- 4 edits3 adds in trunk
<rdar://problem/10246137> Duplicate ::after content when both ::before and ::after are styled as table parts
Reviewed by Sam Weinig.
Source/WebCore:
Test: fast/css-generated-content/table-parts-before-and-after.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild): Prevented table part childern after a ::before table from being merged
into it.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild): Prevented children after a ::before table section from being merged
into it.
LayoutTests:
- fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
- fast/css-generated-content/table-parts-before-and-after-expected.txt: Added.
- fast/css-generated-content/table-parts-before-and-after.html: Added.
- 5:41 PM Changeset in webkit [97113] by
-
- 33 edits1 add in trunk/Source
Source/WebCore: Most of the functions in CachedResourceClient are specific
to a single type of CachedResource. Move these callbacks into
separate subclasses of CachedResourceClient, and leave only
the common callback (notifyFinished) in the base class.
https://bugs.webkit.org/show_bug.cgi?id=69790
Reviewed by Adam Barth.
No new tests, no functionality changed intended.
- css/CSSFontFaceSource.h:
- css/CSSImageValue.h:
- css/CSSImportRule.h:
- dom/ProcessingInstruction.cpp:
- dom/ProcessingInstruction.h:
- html/HTMLLinkElement.h:
- html/ImageDocument.h:
- loader/ImageLoader.h:
- loader/cache/CachedCSSStyleSheet.cpp:
- loader/cache/CachedCSSStyleSheet.h:
- loader/cache/CachedFont.cpp:
- loader/cache/CachedFont.h:
- loader/cache/CachedImage.cpp:
- loader/cache/CachedImage.h:
- loader/cache/CachedResourceClient.h:
- loader/cache/CachedXSLStyleSheet.cpp:
- loader/cache/CachedXSLStyleSheet.h:
- platform/chromium/ClipboardChromium.h:
- platform/gtk/ClipboardGtk.h:
- platform/mac/ClipboardMac.h:
- platform/qt/ClipboardQt.h:
- platform/win/ClipboardWin.h:
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- svg/SVGFEImageElement.h:
- svg/SVGFontFaceUriElement.h:
- xml/XSLImportRule.h:
Source/WebKit/mac: Use a CachedImageClient instead of CachedResourceClient
in WebHTMLView.
https://bugs.webkit.org/show_bug.cgi?id=69790
Reviewed by Adam Barth.
- WebView/WebHTMLView.mm:
(promisedDataClient):
Source/WebKit2: Use a CachedImageClient instead of CachedResourceClient
in WebDragClientMac.
https://bugs.webkit.org/show_bug.cgi?id=69790
Reviewed by Adam Barth.
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(promisedDataClient):
- 5:35 PM Changeset in webkit [97112] by
-
- 3 edits in trunk/LayoutTests
Chromium rebaseline after r97102.
- platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt:
- platform/chromium-win/fast/events/ondragenter-expected.txt:
- 5:29 PM Changeset in webkit [97111] by
-
- 2 edits in trunk/Websites/webkit.org
Fix a typo pointed by Sam (Weinig).
- coding/coding-style.html:
- 5:18 PM Changeset in webkit [97110] by
-
- 7 edits2 deletes in trunk
Unreviewed, rolling out r97087.
http://trac.webkit.org/changeset/97087
https://bugs.webkit.org/show_bug.cgi?id=69805
failing assert on debug builds (Requested by simonjam on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-10
Source/WebCore:
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::replaceDocument):
(WebCore::DocumentWriter::begin):
- loader/DocumentWriter.h:
Source/WebKit/chromium:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadJavaScriptURL):
LayoutTests:
- http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url-expected.txt: Removed.
- http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url.html: Removed.
- 5:11 PM Changeset in webkit [97109] by
-
- 2 edits in trunk/Source/WebCore
[V8] CodeGeneratorV8 shouldn't hardcode the list of ActiveDOMObjects
https://bugs.webkit.org/show_bug.cgi?id=69792
Reviewed by Nate Chapin.
We used to hard code the list of active DOM objects in the code
generator, but now we have an IDL attribute. This patch switches the
code generator over to using the IDL attribute.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateImplementation):
(GetDomMapFunction):
- 5:10 PM Changeset in webkit [97108] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Pull tools/clang from upstream.
https://bugs.webkit.org/show_bug.cgi?id=69797
Reviewed by Adam Barth.
- DEPS:
- 5:08 PM Changeset in webkit [97107] by
-
- 6 edits in trunk/Source/JavaScriptCore
Remove some unused methods from the DFG JIT.
Rubber stamped by Oliver Hunt
Thee methods were only used by the non-speculative JIT, and can be removed.
- dfg/DFGJITCodeGenerator.h:
- dfg/DFGJITCodeGenerator32_64.cpp:
- dfg/DFGJITCodeGenerator64.cpp:
- removed:
nonSpeculativeAdd
nonSpeculativeArithSub
nonSpeculativeArithMod
nonSpeculativeCheckHasInstance
nonSpeculativeInstanceOf
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- removed:
operationArithMod
operationInstanceOf
operationThrowHasInstanceError
- 4:59 PM Changeset in webkit [97106] by
-
- 2 edits in trunk/Tools
Support Distributed-CompileC as an action name in filter-build-webkit
https://bugs.webkit.org/show_bug.cgi?id=69783
Reviewed by Ojan Vafai.
- Scripts/filter-build-webkit:
- 4:56 PM Changeset in webkit [97105] by
-
- 6 edits in trunk/Source/JavaScriptCore
Switch most calls in DFGJITCodeGenerator to use callOperation.
https://bugs.webkit.org/show_bug.cgi?id=69802
Reviewed by Oliver Hunt.
Compares, add, mod are the easy cases.
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
- dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeArithMod):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
- dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- 4:34 PM Changeset in webkit [97104] by
-
- 7 edits in trunk/Tools
3D transforms are flattened in WebKit2 snapshots
https://bugs.webkit.org/show_bug.cgi?id=68276
Reviewed by Anders Carlsson.
Use a snapshot of the window, rather than an image from the web process
for pixel testing in WebKitTestRunner. This correctly captures compositing
layers, so works for 3D transform tests.
- WebKitTestRunner/PlatformWebView.h: Add a windowSnapshotImage() method.
- WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::createCGContextFromImage): Add a param to optionally flip the image when drawing.
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Call windowSnapshotImage(), and if it returns an image,
use that instead of the image we get from the web process.
- WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::windowSnapshotImage): Stub out the new method.
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::windowSnapshotImage): Ditto.
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::windowSnapshotImage): Ditto.
- WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::windowSnapshotImage): Ditto.
- 4:32 PM Changeset in webkit [97103] by
-
- 4 edits3 adds in trunk
PluginDocumentParser uses incorrect syntax for background color
https://bugs.webkit.org/show_bug.cgi?id=69694
Reviewed by Adam Barth.
Source/WebCore:
- html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
LayoutTests:
- platform/mac/plugins/iframe-plugin-bgcolor-expected.txt: Added
- plugins/iframe-plugin-bgcolor.html: Added.
- plugins/iframe-plugin-bgcolor-expected.png: Added.
- 4:09 PM Changeset in webkit [97102] by
-
- 4 edits2 copies in trunk
REGRESSION(r96870): editing/pasteboard/smart-paste-008.html fails on non-Mac
https://bugs.webkit.org/show_bug.cgi?id=69587
Reviewed by Enrica Casucci.
Source/WebCore:
Insert a space at the correct offset when startNode is a text node.
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace):
LayoutTests:
Unskip the test. Also rebaseline a test for a nbsp/sp change.
- platform/win/Skipped:
- platform/win/fast/events/ondragenter-expected.txt:
- 3:54 PM Changeset in webkit [97101] by
-
- 7 edits in trunk/Source/JavaScriptCore
DFG: Switch GetById / PutById to use callOperation
https://bugs.webkit.org/show_bug.cgi?id=69795
Reviewed by Oliver Hunt.
Also make the take base as a cell, so 32_64 doesn't have to set up the cell tag.
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
- dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
- dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGRepatch.cpp:
(JSC::DFG::appropriatePutByIdFunction):
- 3:42 PM QtWebKitBuildSystemCleanup edited by
- (diff)
- 3:42 PM Changeset in webkit [97100] by
-
- 11 edits in trunk
MediaControlSeekButtonElement should support seeking by changing the playback rate.
https://bugs.webkit.org/show_bug.cgi?id=63595
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-controls-scanning.html
Add a new property to HTMLMediaElement, supportsScanning(), which returns whether the
element is capable of playing its media at a rate greater than 1x. HTMLMediaElement passes
this call through to MediaPlayer and MediaPlayerPrivate. If this property returns true, the
built-in scanning controls can prefer to scan by changing the playbackRate, rather than by
repeatedly seeking small amounts of time. Unless overridden by specific media engines, this
property defaults to "false".
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::supportsScanning): Added. Calls through to MediaPlayer.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::supportsScanning): Added. Calls through to MediaPlayerPrivate.
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::supportsScanning): Added. Defaults to "false".
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(WebCore::MediaPlayerPrivateAVFoundation::supportsScanning): Added.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
(WebCore::MediaPlayerPrivateQTKit::supportsScanning): Added.
MediaControlSeekButtonElement now queries HTMLMediaElement::supportsScanning() to see if the
media element can implement its seeking behavior by scanning the media at greater than 1x
rate. Note whether the media was playing or paused when the seek begins, so that the playing
state can be restored when seeking ends. Instead of capturing the mouse after mouseDown,
the seek button now responds to setActive() and begins seeking when the button is active
and stops when it becomes inactive.
Some behaviors have changed: clicking on the seek button no longer causes the media element
to pause; the media will end in the same state it began after the click. cStepTime has been
eliminated; Clicking the seek button will always skip by at least cSeekTime, or 0.2s.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): Initialize new
ivars.
(WebCore::MediaControlSeekButtonElement::defaultEventHandler): Mark mouseDown and mouseUp
as defaultHandled, so as not to trigger drag start and drag end actions.
(WebCore::MediaControlSeekButtonElement::setActive): Call startTimer or stopTimer based
on whether the button is active or not.
(WebCore::MediaControlSeekButtonElement::startTimer): Determine whether to scan or skip
and start the seekTimer.
(WebCore::MediaControlSeekButtonElement::stopTimer): Restore the playing state and
stop the timer.
(WebCore::MediaControlSeekButtonElement::seekTimerFired): Depending on whether we're
scanning or skipping, jump ahead or change the playback rate.
- html/shadow/MediaControlElements.h:
LayoutTests:
- media/video-controls-scanning-expected.txt: Added.
- media/video-controls-scanning.html: Added.
- platform/mac/media/video-controls-scanning-expected.txt: Added.
- 3:41 PM Changeset in webkit [97099] by
-
- 6 edits3 adds in trunk
REGRESSIoN (r95399): Web process hangs when opening documents on Google Docs
https://bugs.webkit.org/show_bug.cgi?id=69412
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JIT.h:
LayoutTests:
- fast/js/dfg-min-max-expected.txt: Added.
- fast/js/dfg-min-max.html: Added.
- fast/js/script-tests/dfg-min-max.js: Added.
(doMin):
(doMax):
- 3:39 PM Changeset in webkit [97098] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py
Adding myself to the committers file.
- 3:32 PM Changeset in webkit [97097] by
-
- 80 edits in trunk/Source
Remove getCallDataVirtual methods
https://bugs.webkit.org/show_bug.cgi?id=69186
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.
- API/JSCallbackFunction.cpp:
- API/JSCallbackFunction.h:
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h:
- API/JSObjectRef.cpp:
(JSObjectIsFunction):
(JSObjectCallAsFunction):
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/ArrayConstructor.cpp:
- runtime/ArrayConstructor.h:
- runtime/BooleanConstructor.cpp:
- runtime/BooleanConstructor.h:
- runtime/DateConstructor.cpp:
- runtime/DateConstructor.h:
Moved StrictModeTypeErrorFunction to Error.h in order to be able to include
the class definition in JSGlobalObject.cpp.
- runtime/Error.cpp:
(JSC::createTypeErrorFunction):
- runtime/Error.h:
(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
(JSC::StrictModeTypeErrorFunction::create):
(JSC::StrictModeTypeErrorFunction::constructThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getConstructData):
(JSC::StrictModeTypeErrorFunction::callThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getCallData):
(JSC::StrictModeTypeErrorFunction::createStructure):
- runtime/ErrorConstructor.cpp:
- runtime/ErrorConstructor.h:
- runtime/FunctionConstructor.cpp:
- runtime/FunctionConstructor.h:
- runtime/FunctionPrototype.cpp:
- runtime/FunctionPrototype.h:
To allow subclasses of InternalFunction (e.g. QtRuntimeMethod) to not have
to declare their own ClassInfo if they don't override getCallData, provided
an implementation that calls ASSERT_NOT_REACHED if called, providing roughly the same
functionality as of the pure virtual method InternalFunction used to have.
Also made this new implementation protected rather than private for the same reason.
Also added an ASSERT in InternalFunction::finishCreation to make sure that whatever
object is being created provides their own implementation of getCallData. This
just makes execution fail earlier in a place where the source of the error is
easy to trace. These ASSERTs are better than putting a null in the MethodTable because
they appear much more intentional to anybody who fails to provide their own
implementation or who tries to explicitly call InternalFunction::getCallData.
- runtime/InternalFunction.cpp:
(JSC::InternalFunction::finishCreation):
(JSC::InternalFunction::getCallData):
- runtime/InternalFunction.h:
- runtime/JSCell.cpp:
- runtime/JSCell.h:
- runtime/JSFunction.cpp:
- runtime/JSFunction.h:
Added a global structure to JSGlobalObject for StrictModeTypeErrorFunction to enable
it to be reused rather than creating a new Structure every time we instantiate it.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::strictModeTypeErrorFunctionStructure):
- runtime/JSONObject.cpp:
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):
- runtime/JSObject.cpp:
(JSC::JSObject::put):
- runtime/JSObject.h:
(JSC::getCallData):
- runtime/NativeErrorConstructor.cpp:
- runtime/NativeErrorConstructor.h:
- runtime/NumberConstructor.cpp:
- runtime/NumberConstructor.h:
- runtime/ObjectConstructor.cpp:
- runtime/ObjectConstructor.h:
- runtime/Operations.cpp:
(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):
(JSC::jsIsFunctionType):
- runtime/PropertySlot.cpp:
(JSC::PropertySlot::functionGetter):
- runtime/RegExpConstructor.cpp:
- runtime/RegExpConstructor.h:
- runtime/StringConstructor.cpp:
- runtime/StringConstructor.h:
- runtime/Structure.h:
Source/JavaScriptGlue:
Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.
- JSValueWrapper.cpp:
(JSValueWrapper::JSObjectCallFunction):
- UserObjectImp.cpp:
- UserObjectImp.h:
Source/WebCore:
No new tests.
Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.
- WebCore.exp.in:
- bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
- bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::handleEvent):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSHTMLAllCollectionCustom.cpp:
- bindings/js/JSHTMLAppletElementCustom.cpp:
- bindings/js/JSHTMLEmbedElementCustom.cpp:
- bindings/js/JSHTMLObjectElementCustom.cpp:
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::evaluate):
- bindings/js/JSPluginElementFunctions.cpp:
(WebCore::runtimeObjectGetCallData):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- bridge/objc/objc_runtime.h:
- bridge/objc/objc_runtime.mm:
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeConnectionMethod::call):
(JSC::Bindings::isJavaScriptFunction):
- bridge/qt/qt_runtime.h:
(JSC::Bindings::QtRuntimeMetaMethod::create):
(JSC::Bindings::QtRuntimeMetaMethod::createStructure):
(JSC::Bindings::QtRuntimeConnectionMethod::create):
(JSC::Bindings::QtRuntimeConnectionMethod::createStructure):
- bridge/runtime_method.cpp:
- bridge/runtime_method.h:
- bridge/runtime_object.cpp:
- bridge/runtime_object.h:
Source/WebKit/mac:
Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
Source/WebKit2:
Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.
- WebProcess/Plugins/Netscape/JSNPMethod.cpp:
- WebProcess/Plugins/Netscape/JSNPMethod.h:
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
- WebProcess/Plugins/Netscape/JSNPObject.h:
- 3:17 PM Changeset in webkit [97096] by
-
- 2 edits6 adds in trunk/LayoutTests
[Chromium] Add baselines for new tests. Update baselines for 10.6 debug and rolled out v8 change.
Unreviewed.
- platform/chromium-mac-snowleopard/fast/lists/inline-before-content-after-list-marker-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/runin/runin-between-list-marker-and-before-content-expected.png: Added.
- platform/chromium-win/fast/lists/inline-before-content-after-list-marker-expected.png: Added.
- platform/chromium-win/fast/runin/runin-between-list-marker-and-before-content-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 3:05 PM Changeset in webkit [97095] by
-
- 5 edits2 adds in trunk/Source/WebKit
<http://webkit.org/b/69575> Extract WebOpenPanelResultListener out into its own file
Reviewed by David Kilzer.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
Extract the WebOpenPanelResultListener class out into
its own file. No functional change.
- WebCoreSupport/WebChromeClient.mm:
- WebCoreSupport/WebOpenPanelResultListener.h: Added.
- WebCoreSupport/WebOpenPanelResultListener.mm: Added.
(-[WebOpenPanelResultListener dealloc]):
(-[WebOpenPanelResultListener finalize]):
(-[WebOpenPanelResultListener cancel]):
(-[WebOpenPanelResultListener chooseFilename:]):
(-[WebOpenPanelResultListener chooseFilenames:]):
- WebView/WebUIDelegate.h:
- 3:02 PM Changeset in webkit [97094] by
-
- 2 edits in trunk/Tools
Quick fix for watchlist unit test failures when using Python 2.7+
Reviewed by Adam Barth.
Filed bug https://bugs.webkit.org/show_bug.cgi?id=69789 about a
better fix.
- Scripts/webkitpy/common/webkitunittest.py: Always use our
version of assertRaisesRegexp.
- 3:01 PM Changeset in webkit [97093] by
-
- 2 edits in trunk/Source/WebCore
media/video-loop.html is failing on Lion because of negative currentTime()
https://bugs.webkit.org/show_bug.cgi?id=69468
Reviewed by Darin Adler.
No new tests. Covered by media/video-loop.html test.
AVFoundation will occasionally return small, negative current times during loop operations.
Clean up these negative times before returning the currentTime.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::currentTime):
- 2:46 PM Changeset in webkit [97092] by
-
- 1 edit6 copies in branches/chromium/874
Merge 97088 - Exiting fullscreen shouldn't crash if the element that was fullscreened had associated anonymous blocks.
BUG=97006
Review URL: http://codereview.chromium.org/8218021
- 2:43 PM Changeset in webkit [97091] by
-
- 4 edits2 copies in branches/chromium/874
Merge 95371 - Don't detach elements from the render tree when entering fullscreen mode
BUG=97006
Review URL: http://codereview.chromium.org/8218020
- 2:32 PM Changeset in webkit [97090] by
-
- 4 edits2 copies in branches/chromium/874
Merge 97087 - ScriptController::executeIfJavaScriptURL gets confused by synchronous frame loads
BUG=99750
Review URL: http://codereview.chromium.org/8223012
- 2:31 PM Changeset in webkit [97089] by
-
- 3 edits1 move in trunk/Tools
Unreviewed, rolling out r97082.
http://trac.webkit.org/changeset/97082
https://bugs.webkit.org/show_bug.cgi?id=69784
broke Windows build (Requested by smfr on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-10
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/cg/TestInvocationCG.cpp: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.mm.
(WTR::createCGContextFromImage):
(WTR::computeMD5HashStringForContext):
(WTR::dumpBitmap):
(WTR::paintRepaintRectOverlay):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
- 2:31 PM Changeset in webkit [97088] by
-
- 3 edits6 adds in trunk
Exiting fullscreen shouldn't crash if the element that was fullscreened
had associated anonymous blocks.
https://bugs.webkit.org/show_bug.cgi?id=68503
Source/WebCore:
Patch by Jeremy Apthorp <jeremya@chromium.org> on 2011-10-10
Reviewed by Simon Fraser.
Test: fullscreen/full-screen-render-inline.html
Test: fullscreen/parent-flow-inline-with-block-child.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::moveChildTo):
(WebCore::RenderBlock::moveChildrenTo):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::moveChildTo):
(WebCore::RenderBlock::moveAllChildrenTo):
(WebCore::RenderBlock::moveChildrenTo):
- rendering/RenderFullScreen.cpp:
(RenderFullScreen::unwrapRenderer):
Move all children back to the parent, not just the firstChild.
LayoutTests:
When exiting fullscreen, if the child of the RenderFullScreen is a
block and the parent has inline flow elements, the parent's children
should be made non-inline before adding the fullscreened element back
to the parent.
Patch by Jeremy Apthorp <jeremya@chromium.org> on 2011-10-10
Reviewed by Simon Fraser.
- fullscreen/full-screen-render-inline.html: Added.
- fullscreen/full-screen-render-inline-expected.png: Added.
- fullscreen/full-screen-render-inline-expected.txt: Added.
- fullscreen/parent-flow-inline-with-block-child.html: Added.
- fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
- fullscreen/parent-flow-inline-with-block-child-expected.txt: Added.
- 2:28 PM Changeset in webkit [97087] by
-
- 7 edits2 adds in trunk
ScriptController::executeIfJavaScriptURL gets confused by synchronous frame loads
https://bugs.webkit.org/show_bug.cgi?id=69777
Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-10-10
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url.html
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::replaceDocument):
(WebCore::DocumentWriter::begin):
- loader/DocumentWriter.h:
Source/WebKit/chromium:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadJavaScriptURL):
LayoutTests:
- http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url-expected.txt: Added.
- http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url.html: Added.
- 2:21 PM Changeset in webkit [97086] by
-
- 4 edits12 copies in branches/chromium/874
Merge 97075 - Style for updated due to inability to locate
:before content in presence of listmarkers and runins.
BUG=97599
Review URL: http://codereview.chromium.org/8216022
- 2:17 PM Changeset in webkit [97085] by
-
- 3 edits3 copies in branches/chromium/874
Merge 97074 - Handle insertion into an anonymous table part that
is followed by a non-anonymous block correctly.
BUG=99338
Review URL: http://codereview.chromium.org/8226006
- 2:15 PM WebKit Team edited by
- (diff)
- 2:14 PM Changeset in webkit [97084] by
-
- 3 edits in trunk/Source/WebCore
Add missing ifdef for JAVASCRIPT_DEBUGGER feature.
https://bugs.webkit.org/show_bug.cgi?id=69758
Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-10
Reviewed by Adam Barth.
No new tests added since this is a build failure fix.
- bindings/v8/custom/V8ScriptProfileCustom.cpp:
- bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
- 2:13 PM WebKit Team edited by
- (diff)
- 2:11 PM WebKit Team edited by
- (diff)
- 2:10 PM WebKit Team edited by
- (diff)
- 2:02 PM Changeset in webkit [97083] by
-
- 10 edits in trunk/Source/JavaScriptCore
Switch last calls from DFGSpeculativeJIT to use callOperation.
https://bugs.webkit.org/show_bug.cgi?id=69780
Reviewed by Oliver Hunt.
Also, rename type in operations for booleans from Z to B, since Z is the mathematical symbol for integers.
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
- dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
- dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):
- wtf/Platform.h:
- 2:02 PM Changeset in webkit [97082] by
-
- 3 edits1 move in trunk/Tools
3D transforms are flattened in WebKit2 snapshots
https://bugs.webkit.org/show_bug.cgi?id=68276
Reviewed by Anders Carlsson.
The WKImage passed from the WebProcess when pixel dumping is created by painting compositing layers
flattened, which flattens 3D transforms. Instead, use CGWindowListCreateImage() to get a snapshot of
the window when doing pixel tests.
Also allow the window to auto-display, so that Core Animation layers are rendered, and animate.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: TestInvocationCG became a .mm file
- WebKitTestRunner/cg/TestInvocationCG.mm: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.cpp.
(WTR::createBitmapCGContext): Utility function to create a bitmap context.
(WTR::computeMD5HashStringForContext):
(WTR::dumpBitmap):
(WTR::paintRepaintRectOverlay):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Use CGWindowListCreateImage() to
grap a snapshot of the window, rather than relying on the WKImage which was passed from the web process.
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView): Remove the line that turned off autoDisplay for the NSWindow.
We need the window to autodisplay for Core Animation to render layers and start animations.
- 2:01 PM Changeset in webkit [97081] by
-
- 16 edits in trunk
WebKitTestRunner needs layoutTestController.setWindowIsKey
https://bugs.webkit.org/show_bug.cgi?id=42688
Reviewed by Anders Carlsson.
Tools:
Implement layoutTestController.setWindowIsKey() in WebKitTestRunner.
This sets a flag that the platform layer uses to indicate that
the window is the key window, which fixes focus ring drawing
in pixel results.
Also focus the web view when we get a 'didCommitLoad' for the main
frame, as DumpRenderTree does.
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::postSetWindowIsKey):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::cacheLayoutTestControllerCallback): Replace some magic numbers with an enum.
(WTR::LayoutTestController::addChromeInputField):
(WTR::LayoutTestController::removeChromeInputField):
(WTR::LayoutTestController::focusWebView):
(WTR::LayoutTestController::setWindowIsKey):
(WTR::LayoutTestController::callAddChromeInputFieldCallback):
(WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
(WTR::LayoutTestController::callFocusWebViewCallback):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
- WebKitTestRunner/PlatformWebView.h: Add an NSWindow subclass
so that we can override -isKeyWindow. Use a boolean member variable
to track window key status.
(WTR::PlatformWebView::setWindowIsKey):
(WTR::PlatformWebView::windowIsKey):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::runModal): Change the window key status when showing a modal alert, as DRT does.
(WTR::closeOtherPage): Use the same cast as other functions.
(WTR::focus): Implement to call setWindowIsKey(true)
(WTR::unfocus): Implement to call setWindowIsKey(false)
(WTR::TestController::createOtherPage): Add page callbacks for focus and unfocus.
(WTR::TestController::initialize):
(WTR::TestController::didCommitLoadForFrame): Hook up callback to focus the web view, as DRT does.
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
- WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::PlatformWebView):
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(-[WebKitTestRunnerWindow isKeyWindow]):
(WTR::PlatformWebView::PlatformWebView): Make a WebKitTestRunnerWindow.
(WTR::PlatformWebView::~PlatformWebView): Clean up the back pointer on the NSWindow subclass, in case it outlives us.
(WTR::PlatformWebView::focus): Set the view as the first responder, and the window as the key window, as DRT does.
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):
- WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::PlatformWebView):
LayoutTests:
Adjust the Skipped list for WebKit2, unskipping some tests, but
keeping others skipped for new reasons.
- platform/wk2/Skipped:
- 1:48 PM Changeset in webkit [97080] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Do not cache a frame's contents size.
https://bugs.webkit.org/show_bug.cgi?id=69772
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-10
Reviewed by Antonio Gomes.
As part of the process of experimenting with having scrollbars with
an actual size, it became clear that setting the contents size via
ChromeClient::contentsSizeChanged() and keeping the value around does
not work.
Case in point: FrameView::adjustViewSize() can result in nested
ScrollView::updateScrollbars() calls in which the innermost ones run
ChromeClient::contentsSizeChanged() before the outermost ones. This
means the ewk_frame's smart data will store an old value.
- ewk/ewk_frame.cpp:
(ewk_frame_contents_size_get):
(ewk_frame_contents_size_changed):
- 1:05 PM Changeset in webkit [97079] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(96070) 25% intl1 PLT regression from scrollbar invalidation
https://bugs.webkit.org/show_bug.cgi?id=69238
Reviewed by Darin Adler.
Fix PLT regression from additional scrollbars invalidations.
Don't invalidate the scrollbar rect from setHasHorizontalScrollbar()
and setHasVerticalScrollbar(), because this is called during FrameView
teardown, at which point the invalidation is redundant.
Instead, invalidate from ScrollView::updateScrollbars(), which is
called only when scrollbars change because of size or layout
changes.
- platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
(WebCore::ScrollView::updateScrollbars):
- 12:54 PM Changeset in webkit [97078] by
-
- 3 edits in trunk/Source/JavaScriptCore
JSVALUE32_64 DFG JIT - bug fix for V8 benchmark cases "crypto" and "raytrace"
https://bugs.webkit.org/show_bug.cgi?id=69748
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-10
Reviewed by Filip Pizlo.
- dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetMethod):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
- 12:52 PM Changeset in webkit [97077] by
-
- 3 edits in trunk/Tools
check-webkit-style: Add readability exception for Ewk_* data types.
https://bugs.webkit.org/show_bug.cgi?id=69763
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-10
Reviewed by David Levin.
Many EFL-related files (such as EditorClientEfl.h or
DumpRenderTreeSupportEfl.h) need to have declarations such as "typedef
struct _Ewk_Foo Ewk_Foo", which currently produce false positives in
check-webkit-style.
Add an exception for them, just like there are exceptions for
Evas_*, Ecore_* and others.
- Scripts/webkitpy/style/checkers/cpp.py:
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
- 12:47 PM Changeset in webkit [97076] by
-
- 2 edits2 copies in branches/chromium/874
Merge 96726 - Mask underlying RENDERER and VENDOR strings
https://bugs.webkit.org/show_bug.cgi?id=69389
Reviewed by Sam Weinig.
Source/WebCore:
Test: fast/canvas/webgl/renderer-and-vendor-strings.html
- html/canvas/WebGLGetInfo.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getParameter):
LayoutTests:
- fast/canvas/webgl/renderer-and-vendor-strings-expected.txt: Added.
- fast/canvas/webgl/renderer-and-vendor-strings.html: Added.
TBR=kbr@google.com
Review URL: http://codereview.chromium.org/8218017
- 12:47 PM Changeset in webkit [97075] by
-
- 6 edits12 adds in trunk
Style for updated due to inability to locate
:before content in presence of listmarkers and runins.
https://bugs.webkit.org/show_bug.cgi?id=68624
Reviewed by Dan Bernstein.
Source/WebCore:
Tests: fast/lists/inline-before-content-after-list-marker.html
fast/runin/runin-between-list-marker-and-before-content.html
fast/runin/runin-into-div-with-float-child.html
fast/runin/runin-not-go-into-float.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::handleRunInChild): Fix as per spec that
we should not be skipping over floating/positioned renderers to
push runins into neighbouring block. This matches Opera renderings.
- rendering/RenderObject.cpp: Add const to parameter variable
to make call from beforePseudoElementRenderer easier. Also matches
CounterNode.h definition.
(WebCore::RenderObject::nextInPreOrder):
(WebCore::RenderObject::nextInPreOrderAfterChildren):
- rendering/RenderObject.h: Same const addition.
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::beforePseudoElementRenderer):
Remove skipping of floating/positioned renderers, similar to
handleRunIn. Revert code change in r94857 and add better next
sibling iterator. This addresses the layouttest in r94857 where
:before content is in its own anonymous rendertable.
LayoutTests:
- fast/lists/inline-before-content-after-list-marker-expected.png: Added.
- fast/lists/inline-before-content-after-list-marker-expected.txt: Added.
- fast/lists/inline-before-content-after-list-marker.html: Added.
- fast/runin/runin-between-list-marker-and-before-content-expected.png: Added.
- fast/runin/runin-between-list-marker-and-before-content-expected.txt: Added.
- fast/runin/runin-between-list-marker-and-before-content.html: Added.
- fast/runin/runin-into-div-with-float-child-expected.png: Added.
- fast/runin/runin-into-div-with-float-child-expected.txt: Added.
- fast/runin/runin-into-div-with-float-child.html: Added.
- fast/runin/runin-not-go-into-float-expected.png: Added.
- fast/runin/runin-not-go-into-float-expected.txt: Added.
- fast/runin/runin-not-go-into-float.html: Added.
- 11:58 AM Changeset in webkit [97074] by
-
- 5 edits3 adds in trunk
Handle insertion into an anonymous table part that
is followed by a non-anonymous block correctly.
https://bugs.webkit.org/show_bug.cgi?id=69536
Reviewed by Dan Bernstein.
Source/WebCore:
Tests: fast/table/table-insert-before-non-anonymous-block.html
- rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::splitColumn):
LayoutTests:
- fast/table/table-insert-before-non-anonymous-block-expected.png: Added.
- fast/table/table-insert-before-non-anonymous-block-expected.txt: Added.
- fast/table/table-insert-before-non-anonymous-block.html: Added.
- 11:56 AM Changeset in webkit [97073] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix
- wtf/MainThread.h: Pull in Platform.h since this file uses PLATFORM() macros.
- 11:45 AM Changeset in webkit [97072] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSVALUE32_64 DFG JIT - Bug fix for BranchNull
https://bugs.webkit.org/show_bug.cgi?id=69743
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-10
Reviewed by Darin Adler.
This fixes the error in access-binary-trees. All SunSpider cases passed.
- dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
- 11:43 AM Changeset in webkit [97071] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG JIT: callOperation should return the Call.
https://bugs.webkit.org/show_bug.cgi?id=69682
Reviewed by Oliver Hunt.
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
(JSC::DFG::appendCallWithExceptionCheckSetResult):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::appendCall):
- wtf/Platform.h:
- 11:12 AM Changeset in webkit [97070] by
-
- 2 edits in trunk/Websites/webkit.org
Style guide should mandate use of pass-by-reference for out arguments
https://bugs.webkit.org/show_bug.cgi?id=69766
Reviewed by Darin Adler.
This matches the convention used throughout WebCore.
- coding/coding-style.html:
- 11:01 AM Changeset in webkit [97069] by
-
- 3 edits in trunk/Source/WebCore
Make static functions in HTMLSelectElement.cpp member functions of HTMLSelectElement class
https://bugs.webkit.org/show_bug.cgi?id=69755
Reviewed by Ryosuke Niwa.
No new tests, just a refactoring.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::nextValidIndex):
Make this a static member function of HTMLSelectElement.
(WebCore::HTMLSelectElement::nextSelectableListIndex):
Make this a member function of HTMLSelectElement.
(WebCore::HTMLSelectElement::previousSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::firstSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::lastSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): ditto.
(WebCore::HTMLSelectElement::selectAll): Update callsite of the above functions.
(WebCore::HTMLSelectElement::setSelectedIndexInternal): ditto.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
- html/HTMLSelectElement.h:
- Add the above function declarations.
- Move SkipDirection definition from HTMLSelectElement.cpp.
- 10:39 AM QtWebKitBuildSystemCleanup edited by
- (diff)
- 10:24 AM Changeset in webkit [97068] by
-
- 4 edits4 deletes in trunk
[Chromium] Get rid of WebAccessibilityCache.
https://bugs.webkit.org/show_bug.cgi?id=68224
Reviewed by Dimitri Glazkov.
Source/WebKit/chromium:
- WebKit.gyp:
- public/WebAccessibilityCache.h: Removed.
- src/WebAccessibilityCache.cpp: Removed.
- src/WebAccessibilityCacheImpl.cpp: Removed.
- src/WebAccessibilityCacheImpl.h: Removed.
Tools:
- DumpRenderTree/chromium/AccessibilityController.cpp:
(AccessibilityController::bindToJavascript):
- 10:19 AM QtWebKitBuildSystemCleanup created by
- 10:03 AM Changeset in webkit [97067] by
-
- 27 edits in trunk
Web Inspector: annotate DOMAgent, Debugger(Presentation)Model with types.
https://bugs.webkit.org/show_bug.cgi?id=69726
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/compile-front-end.sh:
- inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView):
- inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel):
- inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._breakpointResolved):
- inspector/front-end/CSSStyleModel.js:
- inspector/front-end/CompilerSourceMapping.js:
(WebInspector.CompilerSourceMapping.prototype.compiledLocationToSourceLocation):
(WebInspector.CompilerSourceMapping.prototype.sourceLocationToCompiledLocation):
(WebInspector.CompilerSourceMapping.prototype.sources):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._completions.evaluated):
(WebInspector.ConsoleView.prototype._completions.receivedPropertyNamesFromEval):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
- inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView):
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.isXMLNode):
(WebInspector.DOMDocument):
(WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable.onDocumentAvailable):
(WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable):
(WebInspector.DOMDispatcher.prototype.characterDataModified):
(WebInspector.DOMDispatcher.prototype.childNodeCountUpdated):
(WebInspector.DOMDispatcher.prototype.childNodeInserted):
(WebInspector.DOMDispatcher.prototype.childNodeRemoved):
- inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView):
- inspector/front-end/DatabaseTableView.js:
(WebInspector.DatabaseTableView):
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel):
(WebInspector.DebuggerPausedDetails):
(WebInspector.DebuggerModel.prototype.reset):
(WebInspector.DebuggerModel.prototype.get callFrames):
(WebInspector.DebuggerModel.prototype._pausedScript):
(WebInspector.DebuggerModel.prototype._resumedScript):
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerDispatcher.prototype.scriptParsed):
(WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._createPresentationMessage):
(WebInspector.PresentationConsoleMessage):
(WebInspector.PresentationCallFrame.prototype.evaluate):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateSourceAnchors):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._documentUpdated.selectLastSelectedNode):
(WebInspector.ElementsPanel.prototype._documentUpdated):
- inspector/front-end/NetworkPanel.js:
- inspector/front-end/Object.js:
(WebInspector.Object.prototype.dispatchEventToListeners):
(WebInspector.Event):
(WebInspector.Event.prototype.stopPropagation):
(WebInspector.Event.prototype.preventDefault):
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.SourceMapping):
(WebInspector.RawSourceCode.SourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.SourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):
- inspector/front-end/Script.js:
(WebInspector.Script):
(WebInspector.Script.prototype.requestSource):
(WebInspector.Script.prototype.searchInContent):
(WebInspector.Script.prototype.editSource):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.ContentProvider.SearchMatch):
- inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype.update):
- inspector/front-end/externs.js:
- inspector/generate-protocol-externs:
LayoutTests:
- inspector/debugger/raw-source-code.html:
- 9:58 AM Changeset in webkit [97066] by
-
- 2 edits in trunk/LayoutTests
Unreviewed fix for the test. The amount of used memory was calculated incorrectly.
- inspector/performance/resources/network-append-30-requests.html:
- 9:40 AM Changeset in webkit [97065] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Linkifier.reset throw an exception if it is called after reset of debuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=69756
Reviewed by Yury Semikhatsky.
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
- 9:39 AM Changeset in webkit [97064] by
-
- 5 edits1 delete in branches/chromium/874
Revert 91125 - 2011-07-15 Rob Buis <rbuis@rim.com>
Stroking of zero-length paths in SVG should change according to erratum
https://bugs.webkit.org/show_bug.cgi?id=18356
Reviewed by Nikolas Zimmermann.
Ensure rendering of zero-length paths with stroke-linecap=square works by
creating the square rectangle manually.
Tests: svg/W3C-SVG-1.1-SE/painting-control-04-f.svg
svg/custom/zero-path-square-cap-rendering.svg
- platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextStateSaver::context):
- rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::strokeContains): (WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath): (WebCore::RenderSVGPath::zeroLengthSubpathRect): (WebCore::RenderSVGPath::setupSquareCapPath): (WebCore::RenderSVGPath::setupNonScalingStrokePath): (WebCore::RenderSVGPath::fillAndStrokePath): (WebCore::RenderSVGPath::updateCachedBoundaries):
- rendering/svg/RenderSVGPath.h:
TBR=rwlbuis@webkit.org
Review URL: http://codereview.chromium.org/8222009
- 9:14 AM BuildingQt5OnHarmattan edited by
- (diff)
- 9:09 AM Changeset in webkit [97063] by
-
- 8 edits in trunk
Web Inspector: RawSourceCode could be mapped to multiple sources.
https://bugs.webkit.org/show_bug.cgi?id=68526
Source/WebCore:
Replace SourceMapping.uiSourceCode with SourceMapping.uiSourceCodeList as there could be more
then one UISourceCode associated with a RawSourceCode.
Reviewed by Pavel Feldman.
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype._updateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.PresentationCallFrame.prototype.get url):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
- inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype._saveSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiSourceCodeList):
(WebInspector.RawSourceCode.FormattedSourceMapping):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiSourceCodeList):
LayoutTests:
Reviewed by Pavel Feldman.
- inspector/debugger/raw-source-code.html:
- inspector/debugger/scripts-panel.html:
- 7:51 AM Changeset in webkit [97062] by
-
- 4 edits in trunk/Source/WebCore
Shrink RenderLayer and ScrollableArea.
https://bugs.webkit.org/show_bug.cgi?id=69759
Reviewed by Antti Koivisto.
Rearrange the members of RenderLayer and its base class ScrollableArea
to maximize struct packing, shrinking RenderLayer by one CPU word on
32-bit (and two on 64-bit.)
This reduces memory consumption by 134 kB (on 64-bit) when loading the
full HTML5 spec.
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::verticalScrollElasticity):
(WebCore::ScrollableArea::horizontalScrollElasticity):
(WebCore::ScrollableArea::scrollbarOverlayStyle):
Cast the now-bitfield members to the appropriate enum types.
- rendering/RenderLayer.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
Move shouldBeNormalFlowOnly() call out of initializer list since it
depends on m_renderer being initialized.
- 7:47 AM Changeset in webkit [97061] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening after r96958.
https://bugs.webkit.org/show_bug.cgi?id=69757
Unreviewed gardening.
Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-10-10
- platform/qt/Skipped:
- 7:06 AM Changeset in webkit [97060] by
-
- 4 edits in trunk/LayoutTests
2011-10-10 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, fix test after r97056.
- inspector/debugger/script-formatter-expected.txt:
- inspector/debugger/script-formatter.html:
- platform/chromium/test_expectations.txt:
- 6:24 AM Changeset in webkit [97059] by
-
- 5 edits4 deletes in branches/chromium/874
Merge 96319 - Web Inspector: Scripts panel without folders causes errors when creating content scripts section.
https://bugs.webkit.org/show_bug.cgi?id=68827
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
LayoutTests:
- inspector/debugger/scripts-panel-expected.txt:
- inspector/debugger/scripts-panel.html:
- inspector/debugger/scripts-sorting-expected.txt:
- inspector/debugger/scripts-sorting.html:
- platform/chromium-win/inspector/debugger/scripts-panel-expected.txt: Removed.
- platform/chromium/inspector/debugger/scripts-sorting-expected.txt: Removed.
- platform/mac/inspector/debugger/scripts-panel-expected.txt: Removed.
- platform/win/inspector/debugger/scripts-panel-expected.txt: Removed.
TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/8222004
- 6:07 AM Changeset in webkit [97058] by
-
- 2 edits in trunk/Source/WebCore
[Skia on Chromium Mac] Set canExpandAroundIdeographsInComplexText to true
https://bugs.webkit.org/show_bug.cgi?id=69656
https://bugs.webkit.org/show_bug.cgi?id=62987
https://bugs.webkit.org/show_bug.cgi?id=62889
Reviewed by Stephen White.
Skia on Linux and Windows uses different font engines from
Skia on Mac. After determining that the underlying CoreText
can handle it, enabling this allows justification to work
correctly.
Tests: fast/text/justify-ideograph-complex.html
- platform/graphics/skia/FontSkia.cpp:
(WebCore::Font::canExpandAroundIdeographsInComplexText):
- 6:04 AM Changeset in webkit [97057] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: memory leak in Resource panel.
https://bugs.webkit.org/show_bug.cgi?id=69754
Reviewed by Yury Semikhatsky.
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.reset):
- inspector/front-end/View.js:
(WebInspector.View.prototype.childViews):
- 5:40 AM Changeset in webkit [97056] by
-
- 10 edits in trunk
Web Inspector: saving JavaScript after live edit resets scroller position.
https://bugs.webkit.org/show_bug.cgi?id=69340
Source/WebCore:
Do not recreate SourceFrame when content is changed. Instead, update text model in existing SourceFrame.
Reviewed by Yury Semikhatsky.
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype.setCompilerSourceMappingProvider):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._setReadOnly):
(WebInspector.SourceFrame.prototype.contentChanged):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.contentChanged):
LayoutTests:
Reviewed by Yury Semikhatsky.
- inspector/debugger/raw-source-code-expected.txt:
- inspector/debugger/raw-source-code.html:
- inspector/debugger/scripts-panel.html:
- inspector/debugger/ui-source-code-expected.txt:
- inspector/debugger/ui-source-code.html:
- 4:43 AM Changeset in webkit [97055] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed test fix for r97050.
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
- 4:29 AM Changeset in webkit [97054] by
-
- 2 edits in trunk/Source/WebCore
Shrink RenderListItem on 64-bit.
https://bugs.webkit.org/show_bug.cgi?id=69751
Reviewed by Kenneth Rohde Christiansen.
Rearrange members to utilize the padding at the end of RenderBlock.
This shrinks RenderListItem by 8 bytes on 64-bit, reducing memory consumption
by 60 kB when loading the full HTML5 spec.
- rendering/RenderListItem.h:
- 4:27 AM Changeset in webkit [97053] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-10-10 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, mark CCThreadTest.startPostAndWaitOnCondition as flaky on win and mac.
- tests/CCThreadTest.cpp: (WebKit::TEST):
- 3:52 AM BuildingQt5OnHarmattan edited by
- (diff)
- 3:51 AM BuildingQt5OnHarmattan edited by
- (diff)
- 3:48 AM BuildingQt5OnHarmattan edited by
- (diff)
- 3:43 AM BuildingQt5OnHarmattan edited by
- (diff)
- 3:14 AM Changeset in webkit [97052] by
-
- 4 edits in trunk/Source/WebCore
Shrink RootInlineBox.
https://bugs.webkit.org/show_bug.cgi?id=69707
Reviewed by Antti Koivisto.
Move the bitfields from RootInlineBox up into its base class (InlineFlowBox.)
This shrinks RootInlineBox by one CPU word without growing InlineFlowBox.
Enum bitfields were changed to "unsigned" for the MSVC signedness quirk.
Also move one 32-bit member to the head of RootInlineBox so it falls into the
padding at the end of InlineFlowBox on 64-bit.
This reduces memory consumption by 780 kB (on 64-bit) when loading the full
HTML5 spec.
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::lineBreakBidiStatus):
- rendering/RootInlineBox.h:
- 3:08 AM Changeset in webkit [97051] by
-
- 2 edits in trunk/Source/WebCore
2011-10-10 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, attempt to fix chromium mac build after r97034.
- platform/ScrollAnimatorNone.h:
- 2:57 AM BuildingQt5OnHarmattan edited by
- (diff)
- 2:54 AM Changeset in webkit [97050] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: small memory leak in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=69744
Scripts panel doesn't clean the list of child views.
Reviewed by Yury Semikhatsky.
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
- 2:33 AM Changeset in webkit [97049] by
-
- 28 edits in trunk/Source
Web Inspector: allow to start WorkerContext paused
https://bugs.webkit.org/show_bug.cgi?id=69635
Source/WebCore:
Allow to pause WorkerContext on start.
Reviewed by Pavel Feldman.
- bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setPauseOnNextStatement):
- bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
- bindings/v8/WorkerScriptDebugServer.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willEvaluateWorkerScript):
- inspector/InspectorInstrumentation.h:
- inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::pauseWorkerContext): this method will start
running worker message loop in "debug" mode, i.e. it will process only inspector
tasks until method InspectorRuntimeAgent::resume is called.
(WebCore::InspectorRuntimeAgent::resume):
- inspector/InspectorRuntimeAgent.h:
- inspector/WorkerDebuggerAgent.cpp:
- inspector/WorkerDebuggerAgent.h:
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::resume): method which is called from WebKit layer
when it is known that inspector state was restored and it is OK to resume worker execution.
- inspector/WorkerInspectorController.h:
- workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
- workers/DedicatedWorkerThread.h:
- workers/SharedWorkerThread.cpp:
(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::SharedWorkerThread):
- workers/SharedWorkerThread.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerContext):
(WebCore::WorkerMessagingProxy::disconnectFromInspector):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::create):
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread): WorkerThread is passed a booleand flag indicating
whether the context should be paused and wait for explicit resume command before it
starts running its script.
(WebCore::WorkerThread::workerThread):
- workers/WorkerThread.h:
Source/WebKit/chromium:
Expose methods for pausing shared worker on start.
Reviewed by Pavel Feldman.
- public/WebSharedWorker.h:
(WebKit::WebSharedWorker::pauseWorkerContextOnStart): specifies that the worker
context should be paused and weit for explicit call to resumeWorkerContext before
running its script.
(WebKit::WebSharedWorker::resumeWorkerContext):
- src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::startWorkerContext):
(WebKit::WebSharedWorkerImpl::pauseWorkerContextOnStart):
(WebKit::resumeWorkerContextTask):
(WebKit::WebSharedWorkerImpl::resumeWorkerContext):
(WebKit::WebSharedWorkerImpl::attachDevTools):
(WebKit::reconnectToWorkerContextInspectorTask):
(WebKit::WebSharedWorkerImpl::reattachDevTools):
(WebKit::WebSharedWorkerImpl::detachDevTools):
(WebKit::WebSharedWorkerImpl::dispatchDevToolsMessage):
- src/WebSharedWorkerImpl.h:
- src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::startWorkerContext):
(WebKit::WebWorkerClientImpl::updateInspectorStateCookie):
- src/WebWorkerClientImpl.h:
- src/WebWorkerImpl.cpp:
(WebKit::WebWorkerImpl::startWorkerContext):
(WebKit::WebWorkerImpl::detachDevTools):
(WebKit::WebWorkerImpl::dispatchDevToolsMessage):
- 2:23 AM BuildingQt5OnHarmattan edited by
- (diff)
- 2:21 AM Changeset in webkit [97048] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Fix build with qreal == float on MeeGo 1.2 Harmattan
Reviewed by Andreas Kling.
Explicitly choose the qreal variant of qMin, since QPointF is using qreal.
- UIProcess/qt/ViewportInteractionEngine.cpp:
(WebKit::ViewportInteractionEngine::animateContentPositionIntoBoundariesIfNeeded):
- 2:20 AM Changeset in webkit [97047] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Add methods to reload the view to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69613
Reviewed by Martin Robinson.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_reload):
(webkit_web_view_reload_bypass_cache):
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/tests/testloading.c:
(loadReloadProvisionalLoadStarted):
(loadReloadLoadFinished):
(testLoadTimeoutFinishLoop):
(testLoadReload):
(main):
- 2:03 AM Changeset in webkit [97046] by
-
- 9 edits in trunk/Source
Unreviewed, rolling out r97045.
http://trac.webkit.org/changeset/97045
https://bugs.webkit.org/show_bug.cgi?id=69746
makes apple bots very crashy :( (Requested by kling on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-10
Source/JavaScriptCore:
- config.h:
Source/WebCore:
- css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyColor::applyInheritValue):
- page/animation/AnimationBase.cpp:
(WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
(WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
(WebCore::AnimationBase::ensurePropertyMap):
- platform/graphics/Color.h:
(WebCore::Color::Color):
- rendering/style/BorderValue.h:
(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::operator==):
(WebCore::BorderValue::color):
- rendering/style/OutlineValue.h:
(WebCore::OutlineValue::operator==):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setBorderLeftColor):
(WebCore::InheritedFlags::setBorderRightColor):
(WebCore::InheritedFlags::setBorderTopColor):
(WebCore::InheritedFlags::setBorderBottomColor):
(WebCore::InheritedFlags::setOutlineColor):
(WebCore::InheritedFlags::setColumnRuleColor):
(WebCore::InheritedFlags::fillPaintColor):
(WebCore::InheritedFlags::strokePaintColor):
(WebCore::InheritedFlags::borderLeftColor):
(WebCore::InheritedFlags::borderRightColor):
(WebCore::InheritedFlags::borderTopColor):
(WebCore::InheritedFlags::borderBottomColor):
(WebCore::InheritedFlags::backgroundColor):
(WebCore::InheritedFlags::color):
(WebCore::InheritedFlags::columnRuleColor):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::textEmphasisColor):
(WebCore::InheritedFlags::textFillColor):
(WebCore::InheritedFlags::textStrokeColor):
(WebCore::InheritedFlags::stopColor):
(WebCore::InheritedFlags::floodColor):
(WebCore::InheritedFlags::lightingColor):
- 12:50 AM Changeset in webkit [97045] by
-
- 9 edits in trunk/Source
Shrink BorderValue.
https://bugs.webkit.org/show_bug.cgi?id=69521
Reviewed by Antti Koivisto.
Source/JavaScriptCore:
- config.h: Touch to force full rebuild.
Source/WebCore:
Unroll BorderValue's Color member so we can pack the color's validity flag
in BorderValue's bitfield.
This shrinks BorderValue by 32 bit, which in turn shrinks BorderData by
16 bytes. This reduces memory consumption by 760 kB when loading the full
HTML5 spec.
- platform/graphics/Color.h:
(WebCore::Color::Color):
Allow construction of Color objects with specific validity.
- rendering/style/BorderValue.h:
(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::operator==):
(WebCore::BorderValue::setColor):
(WebCore::BorderValue::color):
- rendering/style/OutlineValue.h:
(WebCore::OutlineValue::operator==):
Unroll m_color into BorderValue by splitting it into an RGBA32 and a bool.
Made those variables private and added color(), setColor() accessors.
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setBorderLeftColor):
(WebCore::InheritedFlags::setBorderRightColor):
(WebCore::InheritedFlags::setBorderTopColor):
(WebCore::InheritedFlags::setBorderBottomColor):
(WebCore::InheritedFlags::setOutlineColor):
(WebCore::InheritedFlags::setColumnRuleColor):
Added a SET_BORDERVALUE_COLOR macro and use that instead of SET_VAR
when setting BorderValue colors.
(WebCore::InheritedFlags::fillPaintColor):
(WebCore::InheritedFlags::strokePaintColor):
(WebCore::InheritedFlags::borderLeftColor):
(WebCore::InheritedFlags::borderRightColor):
(WebCore::InheritedFlags::borderTopColor):
(WebCore::InheritedFlags::borderBottomColor):
(WebCore::InheritedFlags::backgroundColor):
(WebCore::InheritedFlags::color):
(WebCore::InheritedFlags::columnRuleColor):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::textEmphasisColor):
(WebCore::InheritedFlags::textFillColor):
(WebCore::InheritedFlags::textStrokeColor):
(WebCore::InheritedFlags::stopColor):
(WebCore::InheritedFlags::floodColor):
(WebCore::InheritedFlags::lightingColor):
Made color getters return "Color" instead of "const Color&" since
BorderValue no longer has an actual object to return the reference to.
- css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyColor::applyInheritValue):
- page/animation/AnimationBase.cpp:
(WebCore::PropertyWrapperColor::PropertyWrapperColor):
(WebCore::PropertyWrapperColor::blend):
(WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
(WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
(WebCore::AnimationBase::ensurePropertyMap):
Adapt to RenderStyle color getters now returning "Color" instead of
"const Color&".
- 12:15 AM Changeset in webkit [97044] by
-
- 2 edits in trunk/Source/WebCore
Missing m_notificationPresenter initialization in WorkerThread constructor
https://bugs.webkit.org/show_bug.cgi?id=69741
Added missing m_notificationPresenter(0)
Reviewed by Pavel Feldman.
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::WorkerThread):
Oct 9, 2011:
- 10:57 PM Changeset in webkit [97043] by
-
- 5 edits in trunk/Source/WebKit/efl
[EFL] Refactor zoom related APIs.
https://bugs.webkit.org/show_bug.cgi?id=62842
Current zoom apis can't support the case of using both page zoom and text
zoom.
As a first step to refactor, this split ewk_{view|frame}_zoom_{get|set}
to use both page_zoom and text zoom individually.
In addition, introduce ewk_view_scale_{get|set} to support proportional scaling.
ewk_view_zoom_{get|set} will remain unchanged until the behavior of smart_zoom
was changed.
Reviewed by Antonio Gomes.
- ewk/ewk_frame.cpp: Remove ewk_frame_zoom_text_only_{get|set}.
(ewk_frame_page_zoom_get): Renamed from ewk_frame_zoom_get().
(ewk_frame_page_zoom_set): Renamed from ewk_frame_zoom_set().
(ewk_frame_text_zoom_get): Extracted from ewk_frame_zoom_get().
(ewk_frame_text_zoom_set): Extracted from ewk_frame_zoom_set().
- ewk/ewk_frame.h:
- ewk/ewk_view.cpp: Remove ewk_view_zoom_text_only_{get|set}
(_ewk_view_smart_zoom_set): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
(ewk_view_zoom_get): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
(ewk_view_page_zoom_get): Extracted from ewk_view_zoom_get().
(ewk_view_page_zoom_set): Extracted from ewk_view_zoom_set().
(ewk_view_scale_get): Added.
(ewk_view_scale_set): Added.
(ewk_view_text_zoom_get): Extracted from ewk_view_zoom_get().
(ewk_view_text_zoom_set): Extracted from ewk_view_zoom_set().
(ewk_view_zoom_weak_set): Change ewk_frame_zoom_get to ewk_frame_page_zoom_get().
(ewk_view_zoom_animated_set): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
(ewk_view_pre_render_region): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
(ewk_view_pre_render_relative_radius): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
- ewk/ewk_view.h:
- 10:09 PM Changeset in webkit [97042] by
-
- 2 edits in trunk/Source/WebCore
Another attempt to fix the Leopard Intel Debug build after changeset 97034 <http://trac.webkit.org/changeset/97034>
(https://bugs.webkit.org/show_bug.cgi?id=68035)
- page/FrameView.cpp:
(WebCore::FrameView::zoomAnimatorTransformChanged): Explicitly convert a double precision result
to a single precision result. I am unsure if this fix is correct. We need to look into this some
more. See <https://bugs.webkit.org/show_bug.cgi?id=69739> for more details.
- 9:54 PM Changeset in webkit [97041] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix the Leopard Intel Debug build after changeset 97034 <http://trac.webkit.org/changeset/97034>
(https://bugs.webkit.org/show_bug.cgi?id=68035)
- page/FrameView.cpp:
(WebCore::FrameView::zoomAnimatorTransformChanged): Explicitly convert double precision result to
an integer. I am unsure if this fix is correct. We need to look into this some more. See
<https://bugs.webkit.org/show_bug.cgi?id=69739> for more details.
- 9:28 PM Changeset in webkit [97040] by
-
- 4 edits in trunk/Source
Fix Lion, Leopard and Snow Leopard builds after changeset 97034 <http://trac.webkit.org/changeset/97034>
(https://bugs.webkit.org/show_bug.cgi?id=68035)
https://bugs.webkit.org/show_bug.cgi?id=69735
Patch by Luke Macpherson <macpherson@chromium.org> on 2011-10-09
Reviewed by Daniel Bates.
Source/WebCore:
- testing/Internals.cpp:
Mark unused parameters to prevent compile errors when GESTURE_EVENTS and SMOOTH_SCROLLING are disabled.
(WebCore::Internals::setEnableScrollAnimator):
(WebCore::Internals::setZoomAnimatorTransform):
(WebCore::Internals::setZoomParameters):
Source/WebKit2:
- WebProcess/Plugins/PDF/BuiltInPDFView.h:
Add symbols that are now required by ScrollableArea.
(WebKit::BuiltInPDFView::zoomAnimatorTransformChanged):
- 9:05 PM Changeset in webkit [97039] by
-
- 3 edits in trunk/Source/JavaScriptCore
Improve Null or Undefined test in 32_64 DFG
https://bugs.webkit.org/show_bug.cgi?id=69734
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Darin Adler.
Currently Null or Undefined value test in 32_64 DFG will check
Null and Undefined tag separately and introduce one more branch.
It can be improved in the way how the baseline JIT is doing - by
relying on the fact that "UndefinedTag + 1 == NullTag and NullTag & 1".
- dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
- 8:25 PM Changeset in webkit [97038] by
-
- 4 edits in trunk/Source/WebCore
Remove redundant code of HTMLSelectElement.
https://bugs.webkit.org/show_bug.cgi?id=69701
Reviewed by Darin Adler.
No new tests, just a refactoring.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::deselectItems):
Rename inner deselectItems() to deselectItemsWithoutValidation().
(WebCore::HTMLSelectElement::setSelectedIndex):
Rename a callsite of another setSelectedIndex() to setSelectedIndexInternal().
(WebCore::HTMLSelectElement::setSelectedIndexByUser):
ditto, and update a callsite of updateSelectedState().
(WebCore::HTMLSelectElement::listBoxSelectItem):
Update a callsite of updateSelectedState().
(WebCore::HTMLSelectElement::activeSelectionEndListIndex):
Update a callsite of lastSelectedListIndex().
(WebCore::HTMLSelectElement::selectAll):
Update callsites of functions which are changed to non-static.
(WebCore::HTMLSelectElement::saveLastSelection):
Merge a static function and a non-static function.
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto.
(WebCore::HTMLSelectElement::setActiveSelectionEndIndex): ditto.
(WebCore::HTMLSelectElement::updateListBoxSelection): ditto.
(WebCore::HTMLSelectElement::listBoxOnChange): ditto.
(WebCore::HTMLSelectElement::menuListOnChange): ditto.
(WebCore::HTMLSelectElement::scrollToSelection): ditto.
(WebCore::HTMLSelectElement::setOptionsChangedOnRenderer): Made this non-static.
(WebCore::HTMLSelectElement::setRecalcListItems):
Merge a static function and a non-static function.
(WebCore::HTMLSelectElement::selectedIndex): ditto.
(WebCore::HTMLSelectElement::setSelectedIndexInternal):
Made this non-static, and renamed from setSelectedIndex() because
of conflict with an existing function.
(WebCore::HTMLSelectElement::optionToListIndex):
Merge a static function and a non-static function.
(WebCore::HTMLSelectElement::listToOptionIndex): ditto.
(WebCore::HTMLSelectElement::dispatchFocusEvent):
Update a callsite of function which is changed to no-staic.
(WebCore::HTMLSelectElement::dispatchBlurEvent): ditto.
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
Made this non-static, and renamed from deselectItems() to avoid conflict.
(WebCore::HTMLSelectElement::restoreFormControlState):
Update a callsite of function which is changed to no-staic.
(WebCore::HTMLSelectElement::reset): ditto.
(WebCore::HTMLSelectElement::platformHandleKeydownEvent): Made this non-static.
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::updateSelectedState): ditto.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::defaultEventHandler):
Merged a static function and a non-static function.
(WebCore::HTMLSelectElement::lastSelectedListIndex): Made this non-static.
(WebCore::HTMLSelectElement::typeAheadFind): ditto.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): ditto.
- html/HTMLSelectElement.h:
- html/HTMLSelectElementWin.cpp:
(WebCore::HTMLSelectElement::platformHandleKeydownEvent): Made this non-static.
- 8:11 PM Changeset in webkit [97037] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSVALUE32_64 DFG JIT - Bug fix for ConvertThis
https://bugs.webkit.org/show_bug.cgi?id=69721
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Darin Adler.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 7:29 PM Changeset in webkit [97036] by
-
- 3 edits in trunk/Tools
Remove "near miss" XSS vulnerabilities in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=69708
Reviewed by David Levin.
Collin Jackson did a security audit of garden-o-matic. He hasn't found
any actual vulnerabilities yet, but he did identify a couple "near
misses" where a slight change in garden-o-matic could lead to a
vulnerability. This patch removes those potential issues.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- 6:15 PM Changeset in webkit [97035] by
-
- 11 edits3 copies3 adds2 deletes in trunk
CSP should log unrecognized directives to the console
https://bugs.webkit.org/show_bug.cgi?id=69728
Reviewed by Sam Weinig.
Source/WebCore:
Several of the web developers who have been experimenting with CSP have
run into trouble with directives we don't support. For example, one
developer was confused for a while why image-src didn't do what he
expected. Logging a message to the console will help these folks
figure out what's going on.
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportUnrecognizedDirective):
(WebCore::ContentSecurityPolicy::addDirective):
- page/ContentSecurityPolicy.h:
LayoutTests:
Update expected results to include new console message about unrecognized directives.
- http/tests/security/contentSecurityPolicy/directive-parsing-expected.txt:
- http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt:
- http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt:
- http/tests/security/contentSecurityPolicy/javascript-url-allowed-expected.txt:
- http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/script-loads-with-img-src-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-in-iframe-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-none-expected.txt:
- 5:21 PM Changeset in webkit [97034] by
-
- 20 edits3 adds in trunk
[chromium] Zoom animator front-end
https://bugs.webkit.org/show_bug.cgi?id=68035
Source/WebCore:
Adds necessary components to ScrollAnimatorNone to support a zoom animation
feature. Includes test infrastructure via testing/Internals to capture
in-progress texture scaling (zoom-animator-scale-test.html) as well as a
final view --- after pageScaleFactor has been applied --- in zoom-animator-scale-test2.html.
Removes temporary test fields from Settings.
Reviewed by Kenneth Russell.
Test: platform/chromium/compositing/zoom-animator-scale-test2.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
- page/FrameView.cpp:
(WebCore::FrameView::zoomAnimatorTransformChanged):
- page/FrameView.h:
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::ScrollAnimator):
(WebCore::ScrollAnimator::notifyZoomChanged):
(WebCore::ScrollAnimator::zoomTranslation):
(WebCore::ScrollAnimator::resetZoom):
(WebCore::ScrollAnimator::setZoomParametersForTest):
- platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::zoomScale):
- platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::ZoomData::ZoomData):
(WebCore::ScrollAnimatorNone::ZoomData::animateZoom):
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::zoom):
(WebCore::ScrollAnimatorNone::handleGestureEvent):
(WebCore::ScrollAnimatorNone::animationTimerFired):
- platform/ScrollAnimatorNone.h:
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::zoomAnimatorTransformChanged):
- platform/ScrollableArea.h:
- testing/Internals.cpp:
(WebCore::Internals::setEnableScrollAnimator):
(WebCore::Internals::setZoomAnimatorTransform):
(WebCore::Internals::getPageScaleFactor):
(WebCore::Internals::setZoomParameters):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit/chromium:
Modifications to get zoom texture-scale parameters from ScaleAnimator directly
instead of via Settings.
Reviewed by Kenneth Russell.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):
LayoutTests:
Reviewed by Kenneth Russell.
- platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test2-expected.png: Added.
- platform/chromium/compositing/zoom-animator-scale-test.html:
- platform/chromium/compositing/zoom-animator-scale-test2-expected.txt: Added.
- platform/chromium/compositing/zoom-animator-scale-test2.html: Added.
- platform/chromium/test_expectations.txt:
- 3:40 PM Changeset in webkit [97033] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove unused callOperation code of DFG JIT on X86
https://bugs.webkit.org/show_bug.cgi?id=69722
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Filip Pizlo.
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
- 1:15 PM Changeset in webkit [97032] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/9484496> REGRESSION (WebKit2): Checkboxes and radio buttons are drawn 1 pixel too high, not repainted properly
https://bugs.webkit.org/show_bug.cgi?id=69727
Reviewed by Anders Carlsson.
- platform/mac/ThemeMac.mm: Made WebCoreFlippedView an NSControl subclass so that the NSButtonCell
used to draw checkboxes and radio buttons can make it its controlView, and consequently check and
obey its flippedness.
- 1:14 PM Changeset in webkit [97031] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSVALUE32_64 DFG JIT - fillJSValue with a pair of GPRs should not set the registerFormat to be DataFormatJSDouble
https://bugs.webkit.org/show_bug.cgi?id=69720
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Filip Pizlo.
In JSVALUE32_64 DFG, DataFormatJSDouble is assumed to be represented by
a FPR and will be used for further optimizations, though we currently
don't fully utilize it. For now when filling a JS value which was
spilled as a JSDouble with a pair of GPRs, we'll set the registerFormat
to DataFormatJS to avoid compilation errors.
- dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillJSValue):
- 1:07 PM Changeset in webkit [97030] by
-
- 8 edits in trunk/Source/JavaScriptCore
DFG should not always speculate that a ByVal access has an integer index
https://bugs.webkit.org/show_bug.cgi?id=69716
Reviewed by Oliver Hunt.
1% win on SunSpider, neutral elsewhere.
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
- dfg/DFGNode.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::byValHasIntBase):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 9:15 AM Changeset in webkit [97029] by
-
- 1 copy in releases/WebKitGTK/webkit-1.6.0
Tagging 1.6.0.
- 9:14 AM Changeset in webkit [97028] by
-
- 1 copy in releases/WebKitGTK/webkit-1.6.1
Tagging 1.6.1.
- 6:09 AM Changeset in webkit [97027] by
-
- 2 edits in trunk/LayoutTests
Change bug of tap-highlight-color.html to bug 66577 and close bug 48544.
https://bugs.webkit.org/show_bug.cgi?id=48544
Unreviewed.
- platform/chromium/test_expectations.txt:
- 3:39 AM Changeset in webkit [97026] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, skip failing tests
- platform/qt-mac/Skipped:
- platform/qt-wk2/Skipped:
- platform/qt/Skipped:
- 3:19 AM Changeset in webkit [97025] by
-
- 6 edits in trunk/Source/JavaScriptCore
Fix value profiling in 32_64 JIT
https://bugs.webkit.org/show_bug.cgi?id=69717
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Filip Pizlo.
Current value profiling for 32_64 JIT is broken and cannot record
correct predicated types, which results in many speculation failures
in the 32_64 DFG JIT, fallbacks to baseline JIT, and re-optimizations
again and again.
With this fix 32_64 DFG JIT can demonstrate real performance gains.
- bytecode/ValueProfile.cpp:
(JSC::ValueProfile::computeStatistics):
- bytecode/ValueProfile.h:
(JSC::ValueProfile::classInfo):
(JSC::ValueProfile::numberOfSamples):
(JSC::ValueProfile::isLive):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfBooleans):
(JSC::ValueProfile::dump):
Empty value check should be performed on decoded JSValue,
as for 32_64 empty value is not identical to encoded 0.
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
- jit/JITStubCall.h:
(JSC::JITStubCall::callWithValueProfiling):
Record the right profiling result for 32_64.
- 3:02 AM Changeset in webkit [97024] by
-
- 1 edit9 adds in trunk/LayoutTests
[Qt] Unreviewed weekend gardening.
- platform/qt/fast/images/color-jpeg-with-color-profile-expected.png: Added after r96970.
- platform/qt/fast/images/color-jpeg-with-color-profile-expected.txt: Added after r96970.
- platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Added after r97021.
- platform/qt/svg/clip-path/clip-path-transform-1-expected.png: Added after r96712.
- platform/qt/svg/clip-path/clip-path-transform-1-expected.txt: Added after r96712.
- platform/qt/svg/clip-path/clip-path-transform-2-expected.png: Added after r96712.
- platform/qt/svg/clip-path/clip-path-transform-2-expected.txt: Added after r96712.
- platform/qt/svg/custom/grayscale-gradient-mask-2-expected.png: Added after r96470.
- platform/qt/svg/custom/grayscale-gradient-mask-2-expected.txt: Added after r96470.
- 3:00 AM Changeset in webkit [97023] by
-
- 2 edits in trunk/Source/WebCore
Do not compare the first glyph to itself in Font::drawGlyphBuffer()
https://bugs.webkit.org/show_bug.cgi?id=69715
Reviewed by Andreas Kling.
When looking for glyphs with similar properties, we should
skip the first one since the comparison of fontData
and offset will always fail.
This is covered by the existing tests.
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::drawGlyphBuffer):
- 1:08 AM Changeset in webkit [97022] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove 32 bit restrictions in DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69711
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Filip Pizlo.
op_call/op_construct support was disabled for 32 bit DFG JIT because
there was regression in javascriptcore tests. Now the bugs are fixed
and there should be no regression. This makes 32 bit DFG have the same
capability as 64 bit DFG, and improves the coverage.
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- 12:23 AM Changeset in webkit [97021] by
-
- 3 edits in trunk/LayoutTests
[Qt] http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml fails
https://bugs.webkit.org/show_bug.cgi?id=69700
Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-10-09
Reviewed by Adam Barth.
- http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml:
- platform/qt/Skipped:
