⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 12, 2011:

11:52 PM Changeset in webkit [97348] by Philippe Normand
  • 8 edits in trunk/LayoutTests

Tests don't override the WebKitWebAudioEnabled runtime preference
​https://bugs.webkit.org/show_bug.cgi?id=69830

Rubber-stamped by Eric Carlson.

Override WebKitWebAudioEnabled in the WebAudio tests so the audio
context can be created even for the WebKit ports not enabling the
runtime WebAudio preference by default.

  • webaudio/biquadfilternode-basic.html:
  • webaudio/delaynode-scheduling.html:
  • webaudio/delaynode.html:
  • webaudio/mediaelementaudiosourcenode-gc.html:
  • webaudio/mediaelementaudiosourcenode.html:
  • webaudio/realtimeanalyser-fft-sizing.html:
  • webaudio/resources/audio-testing.js:
11:14 PM Changeset in webkit [97347] by tkent@chromium.org
  • 2 edits
    1 move
    21 adds
    1 delete in trunk/LayoutTests

[Chromium] Test expectation udpate.

Add baseline files for ruby-base-merge-block-children.html, and
color-jpeg-with-color-profile.html only for Mac.

  • fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Renamed from LayoutTests/platform/gtk/fast/ruby/ruby-base-merge-block-children-crash-expected.txt.
  • platform/chromium-cg-mac-leopard/fast/images/color-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/images/color-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
  • platform/chromium-linux-x86/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
  • platform/chromium-linux/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
  • platform/chromium-linux/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
  • platform/chromium-mac-leopard/fast/images/color-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/images/color-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-win-vista/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
  • platform/chromium-win-xp/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
  • platform/chromium-win/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
  • platform/chromium-win/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
  • platform/chromium/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Removed.
10:40 PM Changeset in webkit [97346] by tkent@chromium.org
  • 1 edit
    14 adds in trunk/LayoutTests

[Chromium] Test expectation update.
Add baseline files for media/video-playing-and-pause.html.

  • platform/chromium-cg-mac-leopard/media/video-playing-and-pause-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/media/video-playing-and-pause-expected.png: Added.
  • platform/chromium-gpu-cg-mac/media/video-playing-and-pause-expected.png: Added.
  • platform/chromium-gpu-mac/media/video-playing-and-pause-expected.png: Added.
  • platform/chromium-gpu-win/media/video-playing-and-pause-expected.png: Added.
  • platform/chromium-linux/media/video-playing-and-pause-expected.png: Added.
  • platform/chromium-mac-leopard/media/video-playing-and-pause-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png: Added.
  • platform/chromium-win/media/video-playing-and-pause-expected.png: Added.
  • platform/chromium-win/media/video-playing-and-pause-expected.txt: Added.
  • platform/chromium/media/video-playing-and-pause-expected.txt: Added.
10:33 PM Changeset in webkit [97345] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Skip some more tests for WK2.

  • platform/wk2/Skipped:
10:17 PM Changeset in webkit [97344] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Mac test expectation update. The failure is tracked by the bug 69999.

  • platform/mac/test_expectations.txt:
10:14 PM Changeset in webkit [97343] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update.

  • platform/chromium/test_expectations.txt:

plugins/refcount-leaks.html is flaky.

10:01 PM Changeset in webkit [97342] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

If an Arguments object is being used to copy the arguments, then
make this explicit
​https://bugs.webkit.org/show_bug.cgi?id=69995

Reviewed by Sam Weinig.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::retrieveArguments):

  • runtime/Arguments.h:

(JSC::Arguments::createAndCopyRegisters):
(JSC::Arguments::finishCreationButDontCopyRegisters):
(JSC::Arguments::finishCreation):
(JSC::Arguments::finishCreationAndCopyRegisters):

9:09 PM Changeset in webkit [97341] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Update kill-old-processes logic.
​https://bugs.webkit.org/show_bug.cgi?id=63651

Patch by Lucas Forschler <Lucas Forschler> on 2011-10-12
Reviewed by Ryosuke Niwa.

Remove unused mac platform specific folder.
Update master.config to use new kill-old-processes.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • BuildSlaveSupport/kill-old-processes:
  • BuildSlaveSupport/mac: Removed.
8:59 PM Changeset in webkit [97340] by Simon Fraser
  • 8 edits in trunk/LayoutTests

Rebaseline Mac region results after r97308.

  • platform/mac/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt:
  • platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-expected.txt:
  • platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.txt:
  • platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-expected.txt:
  • platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt:
  • platform/mac/fast/regions/positioned-objects-spanning-regions-expected.txt:
8:18 PM Changeset in webkit [97339] by rniwa@webkit.org
  • 3 edits in trunk/Tools

[NRWT] New tests without expected files are reported as flakey tests
​https://bugs.webkit.org/show_bug.cgi?id=67268

Reviewed by Dirk Pranke.

The bug was caused by summarize_results's regarding all tests that have an entry in result_summary
and no entry in retry_summary as flaky. Since we don't retry missing tests, there will be no entries
for missing results in retry_summary.

Fixed the bug by treating missing results separately.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
7:51 PM Changeset in webkit [97338] by Joseph Pecoraro
  • 7 edits in trunk/Source

<​http://webkit.org/b/69598> Pass Parsed Accept Attribute MIME Types to WebKit Clients

Part 3 - Add acceptMIMETypes, a parsed list of MIME types, to FileChooserSettings for WebKit ports

Reviewed by David Kilzer.

Source/WebCore:

No new tests. No new functionality in WebCore, just
exposing more information to the WebKit port.

  • html/FileInputType.cpp:

(WebCore::FileInputType::handleDOMActivateEvent):
(WebCore::FileInputType::receiveDropForDirectoryUpload):
Set the MIME type list on the FileChooser settings.

  • html/HTMLInputElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::acceptMIMETypes):
Accessor for a parsed list of MIME types from the accept attribute.

  • platform/FileChooser.h:

Add a slot for a MIME type list on the chooser settings.

Source/WebKit2:

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

7:51 PM Changeset in webkit [97337] by Joseph Pecoraro
  • 12 edits in trunk/Source/WebKit2

<​http://webkit.org/b/69598> Pass Parsed Accept Attribute MIME Types to WebKit Clients

Part 2 - Switch a WebKit2 mirror struct of WebCore::FileChooserSettings to just use FileChooserSettings

Reviewed by Anders Carlsson.

The WebOpenPanelParameters::Data struct was a mirror of
the already existing WebCore::FileChooserSettings struct.
So eliminate the excess struct and generate default
WebCore coders for the WebCore::FileChooserSettings struct.

  • Scripts/webkit2/messages.py:

Switch to the new type. FileChooserSetting's header needs
to be special cased to FileChooser.h.

  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):
Encode and decode all, non-deprecated, values. So we
ignore deprecatedAcceptTypes. A follow-up patch will add it.

  • Shared/WebOpenPanelParameters.cpp:

(WebKit::WebOpenPanelParameters::create):
(WebKit::WebOpenPanelParameters::WebOpenPanelParameters):
Switch to the new type.

  • Shared/WebOpenPanelParameters.h:

(WebKit::WebOpenPanelParameters::allowMultipleFiles):
(WebKit::WebOpenPanelParameters::selectedFileNames):
FileChooserSettings had different property names.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runOpenPanel):
Generate the WebOpenPanelParameters object here, before
passing into the WebUIClient. This seems to be the convention
to not have WebCore types in WebUIClient.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::runOpenPanel):

  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::runOpenPanel):
Switch to the new type.

7:50 PM Changeset in webkit [97336] by Joseph Pecoraro
  • 9 edits in trunk/Source

<​http://webkit.org/b/69598> Pass Parsed Accept Attribute MIME Types to WebKit Clients

Part 1 - Deprecate String version of acceptTypes

Reviewed by Kent Tamura.

Source/WebCore:

Deprecate the old String version of getting the "accept"
mime type values. Instead we will change to include a
list of MIME types.

  • html/FileInputType.cpp:

(WebCore::FileInputType::handleDOMActivateEvent):
(WebCore::FileInputType::receiveDropForDirectoryUpload):

  • platform/FileChooser.h:

Source/WebKit/chromium:

Chromium uses the deprecated accept string. Switching to
the new approach will require coordination with their port.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::runOpenPanel):

Source/WebKit/efl:

EFL uses the deprecated accept string. They can switch
to an Eina_List if they want to update their API.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::runOpenPanel):

Source/WebKit2:

Switch to deprecated for now, but the next patches will
remove the deprecated version from the WebKit2 path.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::runOpenPanel):

7:43 PM Changeset in webkit [97335] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update

  • platform/chromium/test_expectations.txt:

More slow tests for Mac Debug.

7:20 PM Changeset in webkit [97334] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG CFA does not filter structures aggressively enough.
​https://bugs.webkit.org/show_bug.cgi?id=69989

Reviewed by Oliver Hunt.

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::clobberStructures):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::checkConsistency):

7:04 PM Changeset in webkit [97333] by abarth@webkit.org
  • 45 edits
    11 deletes in trunk

Remove ENABLE(XHTMLMP) and associated code
​https://bugs.webkit.org/show_bug.cgi?id=69729

Reviewed by David Levin.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

As discussed on webkit-dev, we are removing this feature as part of our
cleanup of unmaintained code in WebKit.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:

(WebCore::Document::isMediaDocument):

  • dom/Node.cpp:
  • dom/make_names.pl:

(usesDefaultJSWrapper):

  • features.pri:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::rendererIsNeeded):

  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLNoScriptElement.cpp: Removed.
  • html/HTMLNoScriptElement.h: Removed.
  • html/HTMLTagNames.in:
  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::createParser):

  • loader/FrameLoader.cpp:
  • platform/wince/MIMETypeRegistryWinCE.cpp:

(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):

  • xml/parser/XMLDocumentParser.h:

(WebCore::XMLDocumentParser::isXHTMLDocument):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::XMLDocumentParser::endDocument):
(WebCore::XMLDocumentParser::internalSubset):
(WebCore::getEntityHandler):
(WebCore::externalSubsetHandler):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::parse):
(WebCore::XMLDocumentParser::parseStartElement):
(WebCore::XMLDocumentParser::parseEndElement):
(WebCore::XMLDocumentParser::endDocument):
(WebCore::XMLDocumentParser::parseDtd):

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:
  • Scripts/old-run-webkit-tests:
  • Scripts/webkitperl/features.pm:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

These tests are not needed anymore (and they are currently not run).

  • fast/xhtmlmp: Removed.
  • fast/xhtmlmp/check-doctype-declaration.xhtml: Removed.
  • fast/xhtmlmp/check-rootelement.xhtml: Removed.
  • fast/xhtmlmp/noscript-basic-expected.txt: Removed.
  • fast/xhtmlmp/noscript-basic.xhtml: Removed.
  • fast/xhtmlmp/noscript-in-multiscripts.xhtml: Removed.
  • fast/xhtmlmp/noscript-nested.xhtml: Removed.
  • fast/xhtmlmp/noscript.xhtml: Removed.
6:50 PM Changeset in webkit [97332] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Fix CCThreadTest.startPostAndWaitOnCondition
​https://bugs.webkit.org/show_bug.cgi?id=69967

Patch by Antoine Labour <​piman@chromium.org> on 2011-10-12
Reviewed by Darin Fisher.

  • tests/CCThreadTest.cpp:

(WebKit::TEST):

6:44 PM Changeset in webkit [97331] by barraclough@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

MacroAssemblerX86 8-bit register ops unsafe on CPU(X86)
​https://bugs.webkit.org/show_bug.cgi?id=69978

Reviewed by Filip Pizlo.

Certain ops are unsafe if the register passed is esp..edi (will instead test/set the ).

compare32/test8/test32 Call setCC, which sets an 8-bit register - we can fix this by adding
a couple of xchg instructions.

branchTest8 with a register argument is also affected. In all cases this is currently used
this is testing a value that is correct to 32 or more bits, so we can simply switch these
to branchTest32 & remove the corresponding branchTest8 (this is desirable anyway, since the
32-bit form is cheaper to implement on platforms that don't have an 8-bit compare instruction).

This fixes the remaining fast/js failures with the DFG JIT 32_64.

  • assembler/MacroAssemblerARMv7.h
    • removed branchTest8.
  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::compare32):
(JSC::MacroAssemblerX86Common::test8):
(JSC::MacroAssemblerX86Common::test32):
(JSC::MacroAssemblerX86Common::set32):

  • added set32 helper that is 'h' register safe.
  • removed branchTest8.
  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):

  • switch uses of branchTest8 to branchTest32.
  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):

  • switch uses of branchTest8 to branchTest32.
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitBranch):

  • switch uses of branchTest8 to branchTest32.
  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitBranch):

  • switch uses of branchTest8 to branchTest32.
6:33 PM Changeset in webkit [97330] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Kill old run-webkit-tests processes in kill-process on Mac
​https://bugs.webkit.org/show_bug.cgi?id=69976

Reviewed by Dirk Pranke.

Add a system call to remove all python processes running run-webkit-tests.

  • BuildSlaveSupport/kill-old-processes:
  • BuildSlaveSupport/mac: Removed.
6:23 PM Changeset in webkit [97329] by gyuyoung.kim@samsung.com
  • 19 edits in trunk/Source/WebKit/efl

[EFL] Change efl style parameter variables with WebKit coding Style
​https://bugs.webkit.org/show_bug.cgi?id=69073

Reviewed by Antonio Gomes.

This is a third step in order to be more compliant with WebKit coding style.
We have used one-letter| two-letter parameter according to efl style. However, it's more difficult
for other reviewers to review EFL patches. So, this patch changes efl style parameters
with meaningful one.

Majors changes are listed below,

  • Use ewkFrame instead of o parameter in ewk_frame.cpp.
  • Use ewkView instead of o parameter in ewk_view.cpp.
  • Use menu and item instead of o parameter in ewk_contextmenu.cpp.
  • Use ewkTile instead of o parameter in ewk_tile_xxx.cpp.
  • Use tile parameter name instead of t parameter in ewk_tile_xxx.cpp.
  • Use smartData instead of sd parameter for Ewk_XXXX_Smart_Data struct.
  • Use width, height instead of w, h parameter.
  • Use xxxEvent instead of ev parameter for event. (e.g. downEvent, upEvent, wheelEvent)
  • Use scrollX, scrollY, scrollWidth, scrollHeight, centerX, centerY, deltaX, deltaY instead of sx, xy, sw,

sh, cx, cy, dx, dy.

  • Use tileUnusedCache instead of tuc parameter in tiled backing store.
  • Use red, green, blue and alpha instead of r,g,b,a.
  • Remove "_" from parameter variable.
  • Run demarchi's coding style script for ewk_tile_xxx.cpp files.
  • Remove *void* parameter in ewk_tile_xxx.cpp's internal functions.
  • ewk/ewk_auth_soup.cpp:
  • ewk/ewk_contextmenu.cpp:
  • ewk/ewk_cookies.cpp:
  • ewk/ewk_frame.cpp:
  • ewk/ewk_history.cpp:
  • ewk/ewk_js.cpp:
  • ewk/ewk_protocol_handler_soup.cpp:
  • ewk/ewk_settings.cpp:
  • ewk/ewk_tiled_backing_store.cpp:
  • ewk/ewk_tiled_backing_store.h:
  • ewk/ewk_tiled_matrix.cpp:
  • ewk/ewk_tiled_matrix.h:
  • ewk/ewk_tiled_model.cpp:
  • ewk/ewk_tiled_model.h:
  • ewk/ewk_view.cpp:
  • ewk/ewk_view_single.cpp:
  • ewk/ewk_view_tiled.cpp:
  • ewk/ewk_window_features.cpp:
6:07 PM Changeset in webkit [97328] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update.

  • platform/chromium/test_expectations.txt:

Try marking SLOW for Mac Debug timeouts.

5:57 PM Changeset in webkit [97327] by Simon Fraser
  • 3 edits in trunk/Tools

Many WK2 snapshots are blank
​https://bugs.webkit.org/show_bug.cgi?id=69953

Reviewed by Beth Dakin.

Two fixes:

  1. negating a size_t in CGContextTranslateCTM() fails, because

size_t is unsigned. Fix by casing to CGFloat before negation.

  1. Turn on window autodisplay, so that compositing tests snapshot correctly.

Autodisplay is necessary to kick off Core Animation rendering.

  • WebKitTestRunner/cg/TestInvocationCG.cpp:

(WTR::createCGContextFromImage):

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):

5:50 PM Changeset in webkit [97326] by haraken@chromium.org
  • 5 edits in trunk

Implement a WebKitTransitionEvent constructor for V8
​https://bugs.webkit.org/show_bug.cgi?id=69911

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/constructors/webkit-transition-event-constructor.html

  • bindings/v8/custom/V8EventConstructors.cpp: Added a WebKitTransitionEvent constructor.
  • dom/WebKitTransitionEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.

LayoutTests:

Enabled webkit-transition-event-constructor.html, since now V8 has the WebKitTransitionEvent constructor.

  • platform/chromium/test_expectations.txt:
5:37 PM Changeset in webkit [97325] by ojan@chromium.org
  • 2 edits
    1 add
    2 deletes in trunk/LayoutTests

make fast/writing-mode/margins.html a reftest to avoid cross-platform differences
​https://bugs.webkit.org/show_bug.cgi?id=69977

Reviewed by Tony Chang.

  • fast/writing-mode/margins-expected.html: Added.
  • fast/writing-mode/margins-expected.png: Removed.
  • fast/writing-mode/margins-expected.txt: Removed.
  • fast/writing-mode/margins.html:
5:35 PM Changeset in webkit [97324] by haraken@chromium.org
  • 8 edits
    2 adds in trunk

Implement a BeforeLoadEvent constructor for JSC
​https://bugs.webkit.org/show_bug.cgi?id=69893

Reviewed by Adam Barth.

Source/WebCore:

There is no spec for the BeforeLoadEvent constructor
since it is WebKit-specific. However, judging from the current
IDL of initBeforeLoadEvent(), the constructor IDL
should be as follows.

[Constructor(DOMString type, optional BeforeLoadEventInit eventInitDict)]
interface BeforeLoadEvent : Event {

...;

}

dictionary BeforeLoadEventInit : EventInit {

DOMString url;

}

Test: fast/events/constructors/before-load-event-constructor.html

  • bindings/generic/EventConstructors.h: Added a definition for the BeforeLoadEvent constructor.
  • bindings/js/JSEventConstructors.cpp: Added #includes for BeforeLoadEvent.
  • dom/BeforeLoadEvent.h: Added a definition for BeforeLoadEventInit.

(WebCore::BeforeLoadEventInit::BeforeLoadEventInit):
(WebCore::BeforeLoadEvent::create):
(WebCore::BeforeLoadEvent::initBeforeLoadEvent):
(WebCore::BeforeLoadEvent::BeforeLoadEvent):

  • dom/BeforeLoadEvent.idl: Makes BeforeLoadEvent constructible.

LayoutTests:

before-load-event-constructor.html checks the behavior of the BeforeLoadEvent constructor.

  • fast/dom/constructed-objects-prototypes-expected.txt: Added inner.BeforeLoadEvent().
  • fast/events/constructors/before-load-event-constructor-expected.txt: Added.
  • fast/events/constructors/before-load-event-constructor.html: Added.
  • platform/chromium/test_expectations.txt: Skipped before-load-event-constructor.html, since V8 does not yet have the BeforeLoadEvent constructor.
5:34 PM Changeset in webkit [97323] by tkent@chromium.org
  • 2 edits in trunk/WebKitLibraries

C4481 warning should be disabled for OVERRIDE and FINAL.
​https://bugs.webkit.org/show_bug.cgi?id=69904

Reviewed by Adam Roben.

  • win/tools/vsprops/common.vsprops: Disable C4481.
5:21 PM Changeset in webkit [97322] by abarth@webkit.org
  • 7 edits in trunk/Tools

commit-queue doesn't have a friendly error message when the reviewer line is messed up
​https://bugs.webkit.org/show_bug.cgi?id=69979

Reviewed by Eric Seidel.

Rather than combining the ChangeLog validation with a more complicated
command, this patch has the commit-queue run it as a separate command,
which will give us more control over the error message.

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/steps/validatechangelogs.py:
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
5:14 PM Changeset in webkit [97321] by eric@webkit.org
  • 2 edits in trunk/Tools

Layout tests asserting in LayoutTestController::pathToLocalResource()
​https://bugs.webkit.org/show_bug.cgi?id=69898

Reviewed by Simon Fraser.

old-run-webkit-tests just didn't know to set LOCAL_RESOURCE_ROOT, oops.

  • Scripts/old-run-webkit-tests:

(openDumpTool):

5:13 PM Changeset in webkit [97320] by abarth@webkit.org
  • 3 edits in trunk/Tools

The commit-queue doesn't tell me which tests my patch broke
​https://bugs.webkit.org/show_bug.cgi?id=69975

Reviewed by Eric Seidel.

We now print the list of newly failing tests, like we do for the EWS.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
4:59 PM Changeset in webkit [97319] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[skia] Implement Path.currentPoint for skia
​https://bugs.webkit.org/show_bug.cgi?id=69817

Replace FIXME with implementation.

Patch by Ben Wells <​benwells@chromium.org> on 2011-10-12
Reviewed by Kenneth Russell.

  • platform/graphics/skia/PathSkia.cpp:

(WebCore::Path::currentPoint):

4:44 PM Changeset in webkit [97318] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk

Incorrect rendering with one-sided thick border and border-radius
​https://bugs.webkit.org/show_bug.cgi?id=38787

Patch by Ben Wells <​benwells@chromium.org> on 2011-10-12
Reviewed by Simon Fraser.

Source/WebCore:

Incorrect rendering resulted when the inner border could not be properly represented as a rounded
rectangle. When this happens, and the inner border is clipped out, the clipping code clips out the
enclosing rectangle instead.

This change addresses this by clipping in a different way in this case only. The inside is clipped
out one side at a time with a rounded rect created by adjusting the unrenderable inner border
rounded rectangle. The side polygon which is clipped to is also increased in this case to include
the inside of the border so that no areas are missing.

Test: fast/borders/border-radius-complex-inner.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintOneBorderSide):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::calculateSideRectIncludingInner):
(WebCore::calculateAdjustedInnerBorder):
(WebCore::RenderBoxModelObject::clipBorderSideForComplexInnerPath):

  • rendering/RenderBoxModelObject.h:

LayoutTests:

  • fast/borders/border-radius-complex-inner.html: Added.
  • platform/chromium-linux/fast/borders/border-radius-complex-inner-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-radius-different-width-001-expected.png:
  • platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/borders/border-radius-complex-inner-expected.txt: Added.
4:14 PM Changeset in webkit [97317] by aboxhall@chromium.org
  • 2 edits in trunk/Tools

Added myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
4:02 PM Changeset in webkit [97316] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-12

  • DEPS:
3:57 PM Changeset in webkit [97315] by dmazzoni@google.com
  • 2 edits in trunk/LayoutTests

Skip accessibility/menu-list-sends-change-notification.html on Mac.
​https://bugs.webkit.org/show_bug.cgi?id=69970

Reviewed by Simon Fraser.

  • platform/mac/Skipped:
3:51 PM Changeset in webkit [97314] by macpherson@chromium.org
  • 6 edits in trunk/Source/WebCore

Clean up CSSPropertyTextDecoration implementation and ETextDecoration usage.
​https://bugs.webkit.org/show_bug.cgi?id=67625

Reviewed by Eric Seidel.

No new tests - no functionality changed.

The implementation of CSSPropertyTextDecoration is simlified because
1) CSSValueListIterator produces a valid iterator when no results available.
2) CSSParser only allows CSSValueNone or a list of appropriate idents.
3) CSSParser will treat a zero-length list as invalid at parse time.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator ETextDecoration):
Implement cast from CSSPrimitiveValue to ETextDecoration.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.h:

Use ETextDecoration enum instead of int throughout.
(WebCore::InheritedFlags::textDecorationsInEffect):
(WebCore::InheritedFlags::textDecoration):
(WebCore::InheritedFlags::addToTextDecorationsInEffect):
(WebCore::InheritedFlags::setTextDecorationsInEffect):
(WebCore::InheritedFlags::setTextDecoration):

  • rendering/style/RenderStyleConstants.h:

Introduce constant for number of bits required to represent enum.
(WebCore::operator|):
Implement | operator for bitfield enum.
(WebCore::operator|=):
Implement |= operator for bitfield enum.

  • rendering/style/StyleVisualData.h:

Use ETextDecoration instead of int.

3:49 PM Changeset in webkit [97313] by tony@chromium.org
  • 4 edits
    6 adds in trunk

Implement -webkit-flex-align for cross axis alignment in flex-flow: row
​https://bugs.webkit.org/show_bug.cgi?id=69808

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/flex-align-percent-height.html

css3/flexbox/flex-align-vertical-writing-mode.html
css3/flexbox/flex-align.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::isFlowAwareLogicalHeightAuto):
(WebCore::RenderFlexibleBox::flowAwareContentLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareBorderAndPaddingLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareMarginLogicalHeightForChild):
(WebCore::RenderFlexibleBox::flowAwareLogicalLocationForChild):
(WebCore::RenderFlexibleBox::layoutInlineDirection):
(WebCore::RenderFlexibleBox::availableLogicalHeightForChild):
(WebCore::RenderFlexibleBox::marginBoxAscent):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
(WebCore::RenderFlexibleBox::adjustLocationLogicalTopForChild):
(WebCore::RenderFlexibleBox::alignChildrenBlockDirection):

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/flex-align-expected.txt: Added.
  • css3/flexbox/flex-align-percent-height-expected.txt: Added.
  • css3/flexbox/flex-align-percent-height.html: Added.
  • css3/flexbox/flex-align-vertical-writing-mode-expected.txt: Added.
  • css3/flexbox/flex-align-vertical-writing-mode.html: Added.
  • css3/flexbox/flex-align.html: Added.
3:47 PM Changeset in webkit [97312] by ojan@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Expected result accidentally left out of ​http://trac.webkit.org/changeset/97222/.

  • fast/writing-mode/margins-expected.png: Added.
3:44 PM Changeset in webkit [97311] by abarth@webkit.org
  • 2 edits in trunk/Tools

_run_tests is a confusing variable name in webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=69971

Reviewed by Eric Seidel.

Eric and I thought this was a function.

  • Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
3:30 PM Changeset in webkit [97310] by dmazzoni@google.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Changed the order of my email addresses so that it autocompletes the correct one.

3:20 PM Changeset in webkit [97309] by tony@chromium.org
  • 3 edits in trunk/Tools

Fix test-webkitpy after r97307 and r97293.

  • Scripts/webkitpy/layout_tests/port/chromium.py: options.time_out_ms is None during tests so add back the check.
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: The output directory is now build/Debug.
3:14 PM Changeset in webkit [97308] by mihnea@adobe.com
  • 74 edits
    12 deletes in trunk

[CSS Regions]Remove -webkit-content-order property
​https://bugs.webkit.org/show_bug.cgi?id=69848

Reviewed by Tony Chang.

-webkit-content-order property is removed from latest CSS Regions spec.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • dom/Node.cpp:

(WebCore::Node::diff):

  • rendering/RenderFlowThread.cpp:

(WebCore::compareRenderRegions):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeRenderFlowThreads):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/regions/content-flowed-into-regions-with-dyn-index-expected.txt: Removed.
  • fast/regions/content-flowed-into-regions-with-dyn-index.html: Removed.
  • fast/regions/content-flowed-into-regions-with-index-dom-expected.txt: Removed.
  • fast/regions/content-flowed-into-regions-with-index-dom.html: Removed.
  • fast/regions/content-flowed-into-regions-with-index-expected.txt: Removed.
  • fast/regions/content-flowed-into-regions-with-index.html: Removed.
  • fast/regions/script-tests/webkit-content-order-parsing.js: Removed.
  • fast/regions/webkit-content-order-parsing-expected.txt: Removed.
  • fast/regions/webkit-content-order-parsing.html: Removed.
  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
  • platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
  • platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt:
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt:
  • platform/mac/fast/regions/content-flowed-into-regions-with-dyn-index-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-with-index-dom-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-with-index-expected.png: Removed.
  • platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/flow-content-basic-expected.txt:
  • platform/mac/fast/regions/flow-content-basic-vertical-expected.txt:
  • platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.txt:
  • platform/mac/fast/regions/flows-dependency-dynamic-remove-expected.txt:
  • platform/mac/fast/regions/flows-dependency-same-flow-expected.txt:
  • platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/outline-sides-in-region-expected.txt:
  • platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt:
  • platform/mac/fast/regions/overflow-in-uniform-regions-expected.txt:
  • platform/mac/fast/regions/overflow-in-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt:
  • platform/mac/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt:
  • platform/mac/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt:
  • platform/mac/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/percentage-margins-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.txt:
  • platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.txt:
  • platform/mac/fast/regions/positioned-objects-in-regions-expected.txt:
  • platform/mac/fast/regions/positioned-objects-in-rtl-regions-expected.txt:
  • platform/mac/fast/regions/positioned-objects-inline-static-in-regions-expected.txt:
  • platform/mac/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.txt:
  • platform/mac/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.txt:
  • platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt:
  • platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt:
  • platform/mac/fast/regions/region-overflow-break-expected.txt:
  • platform/mac/fast/regions/render-region-renderer-expected.txt:
  • platform/mac/fast/regions/text-region-split-small-pagination-expected.txt:
  • platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt:
  • platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.txt:
  • platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt:
  • platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.txt:
  • platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
  • platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.txt:
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt:
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt:
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt:
  • platform/mac/fast/regions/webkit-flow-renderer-expected.txt:
  • platform/mac/fast/regions/webkit-flow-renderer-layer-expected.txt:
  • platform/mac/fast/regions/webkit-flow-renderer-nested-expected.txt:
  • platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
  • platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
  • platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
  • platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
3:07 PM Changeset in webkit [97307] by tony@chromium.org
  • 2 edits in trunk/Tools

[chromium] remove old build dirs on chromium-win
​https://bugs.webkit.org/show_bug.cgi?id=69961

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_win.py: Output is now always in build and never in chrome or webkit.
2:50 PM Changeset in webkit [97306] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] More timeouts after V8 roll.

  • platform/chromium/test_expectations.txt: Updated.
2:37 PM Changeset in webkit [97305] by commit-queue@webkit.org
  • 14 edits
    1 delete in trunk/Source/WebCore

Update PeerConnection to use WebCore platform interfaces
​https://bugs.webkit.org/show_bug.cgi?id=68462

Patch by Adam Bergkvist <​adam.bergkvist@ericsson.com> on 2011-10-12
Reviewed by Adam Barth.

Currently not testable.

  • WebCore.gypi:
  • WebCore.pro:
  • bindings/js/JSPeerConnectionCustom.cpp:

(WebCore::JSPeerConnectionConstructor::constructJSPeerConnection):

  • bindings/v8/custom/V8PeerConnectionCustom.cpp: Removed.
  • dom/MediaStreamList.cpp:

(WebCore::MediaStreamList::item):
(WebCore::MediaStreamList::append):
(WebCore::MediaStreamList::remove):
(WebCore::MediaStreamList::contains):

  • dom/MediaStreamList.h:
  • p2p/PeerConnection.cpp:

(WebCore::PeerConnection::create):
(WebCore::PeerConnection::PeerConnection):
(WebCore::PeerConnection::processSignalingMessage):
(WebCore::PeerConnection::readyState):
(WebCore::PeerConnection::send):
(WebCore::PeerConnection::addStream):
(WebCore::PeerConnection::removeStream):
(WebCore::PeerConnection::localStreams):
(WebCore::PeerConnection::remoteStreams):
(WebCore::PeerConnection::close):
(WebCore::PeerConnection::iceProcessingCompleted):
(WebCore::PeerConnection::sdpGenerated):
(WebCore::PeerConnection::dataStreamMessageReceived):
(WebCore::PeerConnection::remoteStreamAdded):
(WebCore::PeerConnection::remoteStreamRemoved):
(WebCore::PeerConnection::scriptExecutionContext):
(WebCore::PeerConnection::stop):
(WebCore::PeerConnection::scheduleInitialNegotiation):
(WebCore::PeerConnection::initialNegotiationTimerFired):
(WebCore::PeerConnection::ensureStreamChangeScheduled):
(WebCore::PeerConnection::streamChangeTimerFired):
(WebCore::PeerConnection::scheduleReadyStateChange):
(WebCore::PeerConnection::readyStateChangeTimerFired):
(WebCore::PeerConnection::changeReadyState):

  • p2p/PeerConnection.h:

(WebCore::PeerConnection::refEventTarget):
(WebCore::PeerConnection::derefEventTarget):

  • p2p/PeerConnection.idl:
  • page/MediaStreamClient.h:
  • page/MediaStreamController.cpp:

(WebCore::MediaStreamController::MediaStreamController):

  • page/MediaStreamController.h:
  • page/MediaStreamFrameController.cpp:
  • page/MediaStreamFrameController.h:
2:34 PM Changeset in webkit [97304] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Hang beneath PluginProcessProxy::createPropertyListFile() when using a thin build
​https://bugs.webkit.org/show_bug.cgi?id=69960

Reviewed by Adam Roben.

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::createPropertyListFile): Check for any non-zero return value
from posix_spawn() rather than for a negative return value. The old, incorrect check, caused
this function to hang in waitpid() after failing to spawn a plug-in process for a 32-bit plug-in
when WebKit2 was built for 64-bit only.

2:25 PM Changeset in webkit [97303] by Chris Fleizach
  • 4 edits in trunk/Source/WebCore

AX: CrashTracer: [USER] 296 crashes in WebProcess at com.apple.WebCore: WebCore::AccessibilityScrollbar::document const + 29
​https://bugs.webkit.org/show_bug.cgi?id=69936

AX Scrollbars have a weak pointer to their parent. They need to become AccessibilityMockObjects, so that they can
participate in the detachFromParent() methods that happens when those parents go away.
Could not reproduce the crash, but the backtrace is unequivocal.

Reviewed by Darin Adler.

  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::removeChildScrollbar):

  • accessibility/AccessibilityScrollbar.cpp:

(WebCore::AccessibilityScrollbar::AccessibilityScrollbar):

  • accessibility/AccessibilityScrollbar.h:

(WebCore::AccessibilityScrollbar::scrollbar):
(WebCore::AccessibilityScrollbar::isAccessibilityScrollbar):

2:21 PM Changeset in webkit [97302] by Dimitri Glazkov
  • 4 edits in trunk/Tools

garden-o-matic's "Expect Failure" button does not work correctly, so we should remove it until the plumbing is fixed to avoid landmines.
​https://bugs.webkit.org/show_bug.cgi?id=69954

Also renamed the action and associated event name to address an FIXME.

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed event name.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Renamed the action.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Removed action temporarily.
2:10 PM Changeset in webkit [97301] by thakis@chromium.org
  • 6 edits in trunk/Source/WebKit/chromium

[chromium] Add a setSelectionToRange() method to WebFrame.
​https://bugs.webkit.org/show_bug.cgi?id=69846

Also add a method to WebRange to create a range given a frame and an
interval.

This will be used to implement the "replacement range" feature of OS X
IMEs, see ​http://codereview.chromium.org/8227018 (the change to
render_widget.cc).
The renderer will set the selection to the replacement range before
calling confirmComposition(). This matches how WK2 does this, see
Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm,
WebPage::setComposition(). The function convertToRange() was taken
from there, too.

Reviewed by Darin Fisher.

  • public/WebFrame.h:

(WebKit::WebFrame::setSelectionToRange):

  • src/WebFrameImpl.cpp:

(WebKit::WebViewImpl::setSelectionToRange):

  • src/WebFrameImpl.h:

(WebKit::WebViewImpl::setSelectionToRange):

  • src/WebRange.cpp:

(WebRange::fromGlobalRange):

  • src/WebRange.h:

(WebRange::fromGlobalRange):

2:08 PM Changeset in webkit [97300] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Mark http/tests/media/video-play-stall.html as flaky TIMEOUT.

  • platform/chromium/test_expectations.txt: Marked.
2:01 PM Changeset in webkit [97299] by robert@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

Platform-specific results for r97278

Unreviewed, adding results.

  • platform/gtk/css2.1/20110323/border-conflict-style-079-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-style-088-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-style-079-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-style-088-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-style-079-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-style-088-expected.txt: Added.
1:59 PM Changeset in webkit [97298] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Widen expectation of flakiness according to bots.

  • platform/chromium/test_expectations.txt: Widened.
1:51 PM Changeset in webkit [97297] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Selection is not collapsed in some WK2 editing tests
​https://bugs.webkit.org/show_bug.cgi?id=69889

Skip tests for known reason.

Unreviewed.

Patch by Chang Shu <​cshu@webkit.org> on 2011-10-12

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
1:49 PM Changeset in webkit [97296] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Errrk, revert accidental commit!

  • wtf/Platform.h:
1:47 PM Changeset in webkit [97295] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, re-land changes from #69890, #69903.

These were reverted due to bug #69897, but #69903 fixed this problem.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentFillGPR):

1:28 PM Changeset in webkit [97294] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

ValueProfile::computeUpdatedPrediction doesn't merge statistics correctly
​https://bugs.webkit.org/show_bug.cgi?id=69906

Reviewed by Gavin Barraclough.

It turns out that the simplest fix is to switch computeUpdatedPredictions()
to using predictionFromValue() combined with mergePrediction(). Doing so
allowed me to kill off weakBuckets and visitWeakReferences(). Hence this
not only fixes a performance bug but kills off a lot of code that I never
liked to begin with.

This appears to be a 1% win on V8.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

  • bytecode/CodeBlock.h:
  • bytecode/PredictedType.cpp:

(JSC::predictionFromValue):

  • bytecode/ValueProfile.cpp:

(JSC::ValueProfile::computeStatistics):
(JSC::ValueProfile::computeUpdatedPrediction):

  • bytecode/ValueProfile.h:

(JSC::ValueProfile::classInfo):
(JSC::ValueProfile::numberOfSamples):
(JSC::ValueProfile::isLive):
(JSC::ValueProfile::dump):

1:24 PM Changeset in webkit [97293] by tony@chromium.org
  • 2 edits in trunk/Tools

stop spamming 'stopping test driver timed out, killing it' when running rwt
​https://bugs.webkit.org/show_bug.cgi?id=69938

Reviewed by Adam Barth.

In ​http://trac.webkit.org/changeset/95875 , we made the timeout for
stopping the driver based on time_out_ms, but we based it on the wrong
default times.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
1:23 PM Changeset in webkit [97292] by mhahnenberg@apple.com
  • 15 edits in trunk/Source

De-virtualize JSCell::toString
​https://bugs.webkit.org/show_bug.cgi?id=69677

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Removed toString from JSCallbackObject, since it is no
longer necessary since we now implicitly add toString and valueOf
functions to object prototypes when a convertToType callback
is provided, which is now the standard way to override toString
and valueOf in the JSC C API.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Removed toString from InterruptedExecutionError and
TerminatedExecutionError and replaced it with defaultValue,
which JSObject::toString calls. We'll probably have to de-virtualize
defaultValue eventually, but we'll cross that bridge when we
come to it.

  • runtime/ExceptionHelpers.cpp:

(JSC::InterruptedExecutionError::defaultValue):
(JSC::TerminatedExecutionError::defaultValue):

  • runtime/ExceptionHelpers.h:

Removed toString from JSNotAnObject, since its return value doesn't
actually matter and JSObject::toString can cover it.

  • runtime/JSNotAnObject.cpp:
  • runtime/JSNotAnObject.h:

De-virtualized JSCell::toString, JSObject::toString and JSString::toString.
Added handling of all cases for JSCell to JSCell::toString.

  • runtime/JSObject.h:
  • runtime/JSString.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::toString):

  • runtime/JSCell.h:

Source/JavaScriptGlue:

Removed UserObjectImp::toString because it's no longer necessary since
clients can provide their own toString callback which will in turn be
called by JSObject::toString.

  • UserObjectImp.cpp:
  • UserObjectImp.h:
12:51 PM Changeset in webkit [97291] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Global stringStructure caches its prototype chain, abandoning a web page
​https://bugs.webkit.org/show_bug.cgi?id=69952

Reviewed by Filip Pizlo.

When visiting a structure, we don't keep the prototype chain
alive if we're not the structure for an object type.

  • runtime/Structure.cpp:

(JSC::Structure::visitChildren):

12:47 PM Changeset in webkit [97290] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] More timeouts after V8 roll.

  • platform/chromium/test_expectations.txt: Updated.
12:45 PM Changeset in webkit [97289] by hyatt@apple.com
  • 5 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=69950

REGRESSION: Printing broken because of the isWritingModeRoot addition for unsplittable
paginated content. Make sure not to include the RenderView when checking for writing mode
roots. We only care about children that differ from their parents.

Reviewed by Dimitri Glazkov.

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustForUnsplittableChild):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::isUnsplittableForPagination):

  • rendering/RenderBox.h:
12:41 PM Changeset in webkit [97288] by caryclark@google.com
  • 750 edits
    2 adds in trunk/LayoutTests

Update baseline images affected by subpixel test positioning in
​https://bugs.webkit.org/show_bug.cgi?id=69354 .

Unreviewed rebaselining for Skia.

  • platform/chromium-mac/css1/box_properties/clear_float-expected.png:
  • platform/chromium-mac/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-mac/css1/text_properties/text_align-expected.png:
  • platform/chromium-mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/chromium-mac/css2.1/t0905-c5525-fltmult-00-d-g-expected.png:
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-mac/css2.1/t1202-counter-03-b-expected.png:
  • platform/chromium-mac/css2.1/t1202-counter-04-b-expected.png:
  • platform/chromium-mac/css2.1/t1202-counters-03-b-expected.png:
  • platform/chromium-mac/css2.1/t1202-counters-04-b-expected.png:
  • platform/chromium-mac/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/chromium-mac/css3/unicode-bidi-isolate-aharon-expected.png:
  • platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png:
  • platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-mac/editing/selection/4975120-expected.png:
  • platform/chromium-mac/editing/selection/5240265-expected.png:
  • platform/chromium-mac/editing/selection/extend-inside-transforms-backward-expected.png:
  • platform/chromium-mac/editing/selection/extend-inside-transforms-forward-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac/editing/selection/transformed-selection-rects-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/chromium-mac/editing/style/block-style-001-expected.png:
  • platform/chromium-mac/editing/style/block-style-002-expected.png:
  • platform/chromium-mac/editing/style/block-style-003-expected.png:
  • platform/chromium-mac/editing/style/create-block-for-style-002-expected.png:
  • platform/chromium-mac/editing/style/create-block-for-style-005-expected.png:
  • platform/chromium-mac/editing/style/create-block-for-style-006-expected.png:
  • platform/chromium-mac/editing/style/create-block-for-style-008-expected.png:
  • platform/chromium-mac/editing/style/create-block-for-style-010-expected.png:
  • platform/chromium-mac/editing/style/create-block-for-style-011-expected.png:
  • platform/chromium-mac/editing/style/create-block-for-style-012-expected.png:
  • platform/chromium-mac/editing/style/table-selection-expected.png:
  • platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-mac/fast/block/basic/016-expected.png:
  • platform/chromium-mac/fast/block/float/016-expected.png:
  • platform/chromium-mac/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac/fast/block/positioning/051-expected.png:
  • platform/chromium-mac/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/chromium-mac/fast/borders/bidi-012-expected.png:
  • platform/chromium-mac/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-mac/fast/borders/rtl-border-04-expected.png:
  • platform/chromium-mac/fast/borders/rtl-border-05-expected.png:
  • platform/chromium-mac/fast/box-shadow/no-blur-multiple-offsets-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-mac/fast/clip/overflow-border-radius-composited-expected.png:
  • platform/chromium-mac/fast/clip/overflow-border-radius-transformed-expected.png:
  • platform/chromium-mac/fast/css-generated-content/011-expected.png:
  • platform/chromium-mac/fast/css/beforeSelectorOnCodeElement-expected.png:
  • platform/chromium-mac/fast/css/continuationCrash-expected.png:
  • platform/chromium-mac/fast/css/create_element_align-expected.png:
  • platform/chromium-mac/fast/css/css2-system-fonts-expected.png:
  • platform/chromium-mac/fast/css/font-face-locally-installed-expected.png:
  • platform/chromium-mac/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac/fast/css/line-height-expected.png:
  • platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-mac/fast/css/pseudo-cache-stale-expected.png:
  • platform/chromium-mac/fast/css/rtl-ordering-expected.png:
  • platform/chromium-mac/fast/css/table-text-align-strict-expected.png:
  • platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-bidi-expected.png:
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-expected.png:
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/chromium-mac/fast/css/text-security-expected.png:
  • platform/chromium-mac/fast/dom/34176-expected.png:
  • platform/chromium-mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/chromium-mac/fast/dom/HTMLTableElement/colSpan-expected.png:
  • platform/chromium-mac/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/chromium-mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-mac/fast/dynamic/008-expected.png:
  • platform/chromium-mac/fast/forms/003-expected.png:
  • platform/chromium-mac/fast/forms/004-expected.png:
  • platform/chromium-mac/fast/forms/005-expected.png:
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label01-expected.png:
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label02-expected.png:
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label03-expected.png:
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label04-expected.png:
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label05-expected.png:
  • platform/chromium-mac/fast/forms/basic-buttons-expected.png:
  • platform/chromium-mac/fast/forms/basic-selects-expected.png:
  • platform/chromium-mac/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.png:
  • platform/chromium-mac/fast/forms/blankbuttons-expected.png:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac/fast/forms/button-align-expected.png:
  • platform/chromium-mac/fast/forms/button-cannot-be-nested-expected.png:
  • platform/chromium-mac/fast/forms/button-default-title-expected.png:
  • platform/chromium-mac/fast/forms/button-generated-content-expected.png:
  • platform/chromium-mac/fast/forms/button-positioned-expected.png:
  • platform/chromium-mac/fast/forms/button-sizes-expected.png:
  • platform/chromium-mac/fast/forms/button-style-color-expected.png:
  • platform/chromium-mac/fast/forms/button-table-styles-expected.png:
  • platform/chromium-mac/fast/forms/button-text-transform-expected.png:
  • platform/chromium-mac/fast/forms/button-white-space-expected.png:
  • platform/chromium-mac/fast/forms/control-clip-expected.png:
  • platform/chromium-mac/fast/forms/control-clip-overflow-expected.png:
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac/fast/forms/disabled-select-change-index-expected.png:
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-mac/fast/forms/file/input-file-re-render-expected.png:
  • platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-mac/fast/forms/formmove3-expected.png:
  • platform/chromium-mac/fast/forms/input-align-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-mac/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-mac/fast/forms/input-first-letter-expected.png:
  • platform/chromium-mac/fast/forms/input-placeholder-text-indent-expected.png:
  • platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac/fast/forms/input-spaces-expected.png:
  • platform/chromium-mac/fast/forms/input-table-expected.png:
  • platform/chromium-mac/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-mac/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-mac/fast/forms/isindex-placeholder-expected.png:
  • platform/chromium-mac/fast/forms/listbox-bidi-align-expected.png:
  • platform/chromium-mac/fast/forms/listbox-scrollbar-incremental-load-expected.png:
  • platform/chromium-mac/fast/forms/listbox-width-change-expected.png:
  • platform/chromium-mac/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac/fast/forms/menulist-deselect-update-expected.png:
  • platform/chromium-mac/fast/forms/menulist-no-overflow-expected.png:
  • platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png:
  • platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/chromium-mac/fast/forms/menulist-style-color-expected.png:
  • platform/chromium-mac/fast/forms/menulist-width-change-expected.png:
  • platform/chromium-mac/fast/forms/minWidthPercent-expected.png:
  • platform/chromium-mac/fast/forms/option-script-expected.png:
  • platform/chromium-mac/fast/forms/option-strip-whitespace-expected.png:
  • platform/chromium-mac/fast/forms/option-text-clip-expected.png:
  • platform/chromium-mac/fast/forms/password-placeholder-expected.png:
  • platform/chromium-mac/fast/forms/password-placeholder-text-security-expected.png:
  • platform/chromium-mac/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac/fast/forms/placeholder-set-attribute-expected.png:
  • platform/chromium-mac/fast/forms/placeholder-set-value-expected.png:
  • platform/chromium-mac/fast/forms/placeholder-stripped-expected.png:
  • platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-mac/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/chromium-mac/fast/forms/search-placeholder-value-changed-expected.png:
  • platform/chromium-mac/fast/forms/search-rtl-expected.png:
  • platform/chromium-mac/fast/forms/search-styled-expected.png:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-mac/fast/forms/select-align-expected.png:
  • platform/chromium-mac/fast/forms/select-baseline-expected.png:
  • platform/chromium-mac/fast/forms/select-block-background-expected.png:
  • platform/chromium-mac/fast/forms/select-change-listbox-size-expected.png:
  • platform/chromium-mac/fast/forms/select-change-listbox-to-popup-expected.png:
  • platform/chromium-mac/fast/forms/select-change-popup-to-listbox-expected.png:
  • platform/chromium-mac/fast/forms/select-dirty-parent-pref-widths-expected.png:
  • platform/chromium-mac/fast/forms/select-disabled-appearance-expected.png:
  • platform/chromium-mac/fast/forms/select-initial-position-expected.png:
  • platform/chromium-mac/fast/forms/select-item-background-clip-expected.png:
  • platform/chromium-mac/fast/forms/select-list-box-with-height-expected.png:
  • platform/chromium-mac/fast/forms/select-selected-expected.png:
  • platform/chromium-mac/fast/forms/select-size-expected.png:
  • platform/chromium-mac/fast/forms/select-visual-hebrew-expected.png:
  • platform/chromium-mac/fast/forms/select-writing-direction-natural-expected.png:
  • platform/chromium-mac/fast/forms/stuff-on-my-optgroup-expected.png:
  • platform/chromium-mac/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-mac/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac/fast/forms/textarea-align-expected.png:
  • platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.png:
  • platform/chromium-mac/fast/forms/textarea-placeholder-set-attribute-expected.png:
  • platform/chromium-mac/fast/forms/textarea-placeholder-set-value-expected.png:
  • platform/chromium-mac/fast/forms/textarea-placeholder-wrapping-expected.png:
  • platform/chromium-mac/fast/forms/textarea-scroll-height-expected.png:
  • platform/chromium-mac/fast/forms/textarea-setinnerhtml-expected.png:
  • platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-mac/fast/html/details-replace-text-expected.png:
  • platform/chromium-mac/fast/html/details-writing-mode-expected.png:
  • platform/chromium-mac/fast/html/keygen-expected.png:
  • platform/chromium-mac/fast/inline-block/003-expected.png:
  • platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.png:
  • platform/chromium-mac/fast/inline/inline-box-background-expected.png:
  • platform/chromium-mac/fast/inline/inline-box-background-long-image-expected.png:
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.png:
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.png:
  • platform/chromium-mac/fast/lists/003-vertical-expected.png:
  • platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-mac/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-mac/fast/multicol/overflow-across-columns-expected.png:
  • platform/chromium-mac/fast/multicol/overflow-across-columns-percent-height-expected.png:
  • platform/chromium-mac/fast/multicol/overflow-unsplittable-expected.png:
  • platform/chromium-mac/fast/multicol/positive-leading-expected.png:
  • platform/chromium-mac/fast/overflow/infiniteRecursion-expected.png:
  • platform/chromium-mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-mac/fast/overflow/scrollRevealButton-expected.png:
  • platform/chromium-mac/fast/parser/document-write-option-expected.png:
  • platform/chromium-mac/fast/parser/entity-comment-in-textarea-expected.png:
  • platform/chromium-mac/fast/parser/open-comment-in-textarea-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-in-regions-expected.png:
  • platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-menulist-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-mac/fast/ruby/nested-ruby-expected.png:
  • platform/chromium-mac/fast/ruby/ruby-beforeafter-expected.png:
  • platform/chromium-mac/fast/ruby/ruby-empty-rt-expected.png:
  • platform/chromium-mac/fast/ruby/ruby-inline-table-expected.png:
  • platform/chromium-mac/fast/ruby/ruby-length-expected.png:
  • platform/chromium-mac/fast/ruby/ruby-run-break-expected.png:
  • platform/chromium-mac/fast/ruby/ruby-runs-expected.png:
  • platform/chromium-mac/fast/ruby/ruby-runs-spans-expected.png:
  • platform/chromium-mac/fast/ruby/ruby-simple-expected.png:
  • platform/chromium-mac/fast/ruby/ruby-simple-rp-expected.png:
  • platform/chromium-mac/fast/ruby/ruby-text-before-after-content-expected.png:
  • platform/chromium-mac/fast/ruby/rubyDOM-insert-rt-expected.png:
  • platform/chromium-mac/fast/ruby/rubyDOM-insert-text1-expected.png:
  • platform/chromium-mac/fast/selectors/064-expected.png:
  • platform/chromium-mac/fast/table/011-expected.png:
  • platform/chromium-mac/fast/table/append-cells2-expected.png:
  • platform/chromium-mac/fast/table/border-collapsing/004-expected.png:
  • platform/chromium-mac/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/chromium-mac/fast/table/border-collapsing/rtl-border-collapsing-expected.png:
  • platform/chromium-mac/fast/table/colgroup-preceded-by-caption-expected.png:
  • platform/chromium-mac/fast/table/colgroup-spanning-groups-rules-expected.png:
  • platform/chromium-mac/fast/table/dynamic-caption-add-before-child-expected.png:
  • platform/chromium-mac/fast/table/dynamic-caption-add-remove-before-child-expected.png:
  • platform/chromium-mac/fast/table/frame-and-rules-expected.png:
  • platform/chromium-mac/fast/table/multiple-captions-display-expected.png:
  • platform/chromium-mac/fast/table/percent-heights-expected.png:
  • platform/chromium-mac/fast/table/remove-td-display-none-expected.png:
  • platform/chromium-mac/fast/table/rowindex-expected.png:
  • platform/chromium-mac/fast/table/rowspan-paint-order-vertical-expected.png:
  • platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png:
  • platform/chromium-mac/fast/table/text-field-baseline-expected.png:
  • platform/chromium-mac/fast/text/atsui-negative-spacing-features-expected.png:
  • platform/chromium-mac/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/chromium-mac/fast/text/basic/002-expected.png:
  • platform/chromium-mac/fast/text/basic/015-expected.png:
  • platform/chromium-mac/fast/text/basic/generic-family-reset-expected.png:
  • platform/chromium-mac/fast/text/bidi-embedding-pop-and-push-same-expected.png:
  • platform/chromium-mac/fast/text/break-word-expected.png:
  • platform/chromium-mac/fast/text/capitalize-boundaries-expected.png:
  • platform/chromium-mac/fast/text/cg-vs-atsui-expected.png:
  • platform/chromium-mac/fast/text/drawBidiText-expected.png:
  • platform/chromium-mac/fast/text/emphasis-expected.png:
  • platform/chromium-mac/fast/text/in-rendered-text-rtl-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-L2-run-reordering-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-european-terminators-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-explicit-embedding-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-innertext-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-listbox-atsui-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-listbox-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-menulist-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-override-expected.png:
  • platform/chromium-mac/fast/text/international/hebrew-vowels-expected.png:
  • platform/chromium-mac/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-mac/fast/text/international/rtl-white-space-pre-wrap-expected.png:
  • platform/chromium-mac/fast/text/international/unicode-bidi-plaintext-expected.png:
  • platform/chromium-mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
  • platform/chromium-mac/fast/text/justified-selection-at-edge-expected.png:
  • platform/chromium-mac/fast/text/justify-ideograph-simple-expected.png:
  • platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.png:
  • platform/chromium-mac/fast/text/line-breaks-expected.png:
  • platform/chromium-mac/fast/text/shadow-no-blur-expected.png:
  • platform/chromium-mac/fast/text/trailing-white-space-2-expected.png:
  • platform/chromium-mac/fast/text/trailing-white-space-expected.png:
  • platform/chromium-mac/fast/text/updateNewFont-expected.png:
  • platform/chromium-mac/fast/text/word-break-run-rounding-expected.png:
  • platform/chromium-mac/fast/transforms/transform-on-inline-expected.png:
  • platform/chromium-mac/fast/transforms/transform-table-row-expected.png:
  • platform/chromium-mac/fast/transforms/transformed-document-element-expected.png:
  • platform/chromium-mac/fast/writing-mode/vertical-baseline-alignment-expected.png:
  • platform/chromium-mac/fast/writing-mode/vertical-font-fallback-expected.png:
  • platform/chromium-mac/fonts/sans-serif-expected.png:
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-11-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-77-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/interact-events-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-03-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-04-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-05-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-06-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-07-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-08-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-frag-05-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-frag-06-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-group-03-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-use-03-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/styling-css-04-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/styling-css-05-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-align-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-align-02-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-align-05-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-align-06-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-text-07-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
  • platform/chromium-mac/svg/as-background-image/animated-svg-as-background-expected.png:
  • platform/chromium-mac/svg/as-background-image/svg-as-background-4-expected.png:
  • platform/chromium-mac/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-mac/svg/batik/filters/feTile-expected.png:
  • platform/chromium-mac/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-mac/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-mac/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-mac/svg/batik/paints/patternRegionA-expected.png:
  • platform/chromium-mac/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-mac/svg/batik/text/textAnchor2-expected.png:
  • platform/chromium-mac/svg/batik/text/textAnchor3-expected.png:
  • platform/chromium-mac/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac/svg/batik/text/textDecoration2-expected.png:
  • platform/chromium-mac/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-mac/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
  • platform/chromium-mac/svg/batik/text/textLayout-expected.png:
  • platform/chromium-mac/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-mac/svg/batik/text/textLength-expected.png:
  • platform/chromium-mac/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-mac/svg/batik/text/textOnPath2-expected.png:
  • platform/chromium-mac/svg/batik/text/textOnPath3-expected.png:
  • platform/chromium-mac/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/chromium-mac/svg/batik/text/textPCDATA-expected.png:
  • platform/chromium-mac/svg/batik/text/textPosition-expected.png:
  • platform/chromium-mac/svg/batik/text/textProperties-expected.png:
  • platform/chromium-mac/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-mac/svg/batik/text/textStyles-expected.png:
  • platform/chromium-mac/svg/batik/text/verticalText-expected.png:
  • platform/chromium-mac/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-mac/svg/batik/text/xmlSpace-expected.png:
  • platform/chromium-mac/svg/carto.net/button-expected.png:
  • platform/chromium-mac/svg/carto.net/colourpicker-expected.png:
  • platform/chromium-mac/svg/carto.net/combobox-expected.png:
  • platform/chromium-mac/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-mac/svg/carto.net/slider-expected.png:
  • platform/chromium-mac/svg/carto.net/textbox-expected.png:
  • platform/chromium-mac/svg/carto.net/window-expected.png:
  • platform/chromium-mac/svg/clip-path/clip-path-pixelation-expected.png:
  • platform/chromium-mac/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png:
  • platform/chromium-mac/svg/custom/gradient-with-1d-boundingbox-expected.png:
  • platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
  • platform/chromium-mac/svg/custom/js-late-clipPath-creation-expected.png:
  • platform/chromium-mac/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-mac/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-all-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-mac/svg/custom/linking-uri-01-b-expected.png:
  • platform/chromium-mac/svg/custom/marker-default-width-height-expected.png:
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/chromium-mac/svg/custom/path-textPath-simulation-expected.png:
  • platform/chromium-mac/svg/custom/pattern-incorrect-tiling-expected.png:
  • platform/chromium-mac/svg/custom/preserve-aspect-ratio-syntax-expected.png:
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac/svg/custom/shapes-supporting-markers-expected.png:
  • platform/chromium-mac/svg/custom/stroke-width-large-expected.png:
  • platform/chromium-mac/svg/custom/stroked-pattern-expected.png:
  • platform/chromium-mac/svg/custom/struct-use-09-b-expected.png:
  • platform/chromium-mac/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/chromium-mac/svg/custom/text-dom-01-f-expected.png:
  • platform/chromium-mac/svg/custom/text-linking-expected.png:
  • platform/chromium-mac/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium-mac/svg/custom/text-rotation-expected.png:
  • platform/chromium-mac/svg/custom/text-tref-03-b-change-href-dom-expected.png:
  • platform/chromium-mac/svg/custom/text-tref-03-b-change-href-expected.png:
  • platform/chromium-mac/svg/custom/text-tref-03-b-referenced-element-removal-expected.png:
  • platform/chromium-mac/svg/custom/text-tref-03-b-tref-removal-expected.png:
  • platform/chromium-mac/svg/custom/text-x-dy-lists-expected.png:
  • platform/chromium-mac/svg/custom/tref-own-content-removal-expected.png:
  • platform/chromium-mac/svg/custom/tref-update-expected.png:
  • platform/chromium-mac/svg/custom/use-detach-expected.png:
  • platform/chromium-mac/svg/custom/use-on-disallowed-foreign-object-1-expected.png:
  • platform/chromium-mac/svg/custom/use-on-disallowed-foreign-object-2-expected.png:
  • platform/chromium-mac/svg/custom/use-on-disallowed-foreign-object-3-expected.png:
  • platform/chromium-mac/svg/custom/use-on-disallowed-foreign-object-4-expected.png:
  • platform/chromium-mac/svg/custom/use-on-disallowed-foreign-object-5-expected.png:
  • platform/chromium-mac/svg/custom/use-on-disallowed-foreign-object-6-expected.png:
  • platform/chromium-mac/svg/custom/use-on-non-svg-namespaced-element-expected.png:
  • platform/chromium-mac/svg/custom/use-referencing-nonexisting-symbol-expected.png:
  • platform/chromium-mac/svg/custom/viewbox-syntax-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png:
  • platform/chromium-mac/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac/svg/hixie/mixed/008-expected.png:
  • platform/chromium-mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.png:
  • platform/chromium-mac/svg/hixie/viewbox/preserveAspectRatio/002-expected.png:
  • platform/chromium-mac/svg/text/bidi-reorder-value-lists-expected.png:
  • platform/chromium-mac/svg/text/bidi-text-anchor-direction-expected.png:
  • platform/chromium-mac/svg/text/bidi-text-query-expected.png:
  • platform/chromium-mac/svg/text/bidi-tspans-expected.png:
  • platform/chromium-mac/svg/text/font-size-below-point-five-2-expected.png:
  • platform/chromium-mac/svg/text/scaled-font-expected.png:
  • platform/chromium-mac/svg/text/scaling-font-with-geometric-precision-expected.png:
  • platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-3-expected.png:
  • platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/chromium-mac/svg/text/select-textLength-spacing-stretch-1-expected.png:
  • platform/chromium-mac/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/chromium-mac/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/chromium-mac/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/chromium-mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png:
  • platform/chromium-mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
  • platform/chromium-mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
  • platform/chromium-mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png:
  • platform/chromium-mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
  • platform/chromium-mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png:
  • platform/chromium-mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png:
  • platform/chromium-mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
  • platform/chromium-mac/svg/text/small-fonts-2-expected.png: Added.
  • platform/chromium-mac/svg/text/small-fonts-3-expected.png:
  • platform/chromium-mac/svg/text/small-fonts-expected.png:
  • platform/chromium-mac/svg/text/small-fonts-in-html5-expected.png:
  • platform/chromium-mac/svg/text/text-align-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-align-02-b-expected.png:
  • platform/chromium-mac/svg/text/text-align-03-b-expected.png:
  • platform/chromium-mac/svg/text/text-align-04-b-expected.png:
  • platform/chromium-mac/svg/text/text-align-05-b-expected.png:
  • platform/chromium-mac/svg/text/text-align-06-b-expected.png:
  • platform/chromium-mac/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-fonts-01-t-expected.png:
  • platform/chromium-mac/svg/text/text-fonts-02-t-expected.png:
  • platform/chromium-mac/svg/text/text-intro-05-t-expected.png:
  • platform/chromium-mac/svg/text/text-path-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-path-middle-align-expected.png:
  • platform/chromium-mac/svg/text/text-text-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-text-03-b-expected.png:
  • platform/chromium-mac/svg/text/text-text-07-t-expected.png:
  • platform/chromium-mac/svg/text/text-text-08-b-expected.png:
  • platform/chromium-mac/svg/text/text-tref-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-tselect-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-tselect-02-f-expected.png:
  • platform/chromium-mac/svg/text/text-tspan-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-ws-01-t-expected.png:
  • platform/chromium-mac/svg/text/text-ws-02-t-expected.png:
  • platform/chromium-mac/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-mac/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-009-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-mac/svg/zoom/text/zoom-foreignObject-expected.png:
  • platform/chromium-mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug10633-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug11384q-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug11384s-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1163-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug126742-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1302-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug131020-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug131020_iframe-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1802-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1802s-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug18664-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug194024-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug27038-3-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug29326-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2962-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug30559-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug30692-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug3260-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug3454-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug3977-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug43854-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug43854-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug44505-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug48028-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug50695-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug51727-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug52505-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug52506-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug5838-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug60804-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug60807-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug6304-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug647-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug67915-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug68912-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug69382-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug7112-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug7112-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug72359-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug81934-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug8381-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug88035-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug88035-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug88524-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug8950-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-mac/tables/mozilla/core/captions-expected.png:
  • platform/chromium-mac/tables/mozilla/core/margins-expected.png:
  • platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/body_col-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/body_tfoot-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/colgroup_align_center-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/colgroup_align_justify-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/colgroup_align_left-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/colgroup_align_right-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/colgroup_span-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/colgroup_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/colgroup_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/colgroup_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/colgroup_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/colgroup_width_pct-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/colgroup_width_px-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/table_row_align_center-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tables_caption_align_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tables_td_align_center-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tables_th_align_center-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tables_th_height-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tables_th_width-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_align_center-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_align_center-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_caption_align_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_caption_class-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_caption_id-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_caption_style-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_table-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_tbody_align_center-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_th_colspan-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_th_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_th_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_th_width-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_thead_align_center-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium-mac/tables/mozilla/other/body_col-expected.png:
  • platform/chromium-mac/tables/mozilla/other/test3-expected.png:
  • platform/chromium-mac/tables/mozilla/other/wa_table_tr_align-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1128-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.png:
12:28 PM Changeset in webkit [97287] by abarth@webkit.org
  • 9 edits in trunk/Source/WebCore

Moving ScriptExecutionContext to the front of the argument list for
IDL constructors that use ConstructorWith=ScriptExecutionContext.
​https://bugs.webkit.org/show_bug.cgi?id=69799

Patch by Anna Cavender <​annacc@chromium.org> on 2011-10-12
Reviewed by Adam Barth.

Tests:

  • http/tests/eventsource/* (for EventSource)
  • fast/filesystem/* (for Worker)
  • bindings/js/JSEventSourceCustom.cpp:

(WebCore::JSEventSourceConstructor::constructJSEventSource):

  • bindings/js/JSWorkerCustom.cpp:

(WebCore::JSWorkerConstructor::constructJSWorker):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::constructorCallback):

  • page/EventSource.cpp:

(WebCore::EventSource::create):

  • page/EventSource.h:
  • workers/Worker.cpp:

(WebCore::Worker::create):

  • workers/Worker.h:
12:28 PM Changeset in webkit [97286] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

DFG JIT 32_64 - Fix ArrayPop
​https://bugs.webkit.org/show_bug.cgi?id=69918

Patch by Yuqiang Xian <​yuqiang.xian@intel.com> on 2011-10-12
Reviewed by Filip Pizlo.

The storageLengthGPR is polluted by EmptyValueTag and later used to
index the array, which results in abnormal behaviors in execution.
This fix makes 32_64 DFG pass v8-deltablue and kraken
crypto-sha256-iterative on Linux ia32.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::store32):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::movl_i32m):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

12:23 PM Changeset in webkit [97285] by Simon Fraser
  • 2 edits in trunk/Tools

3D transforms are flattened in WebKit2 snapshots
​https://bugs.webkit.org/show_bug.cgi?id=68276

Reviewed by Adam Roben.

Fix WKImage leak noticed by Adam.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::windowSnapshotImage):

12:13 PM Changeset in webkit [97284] by rniwa@webkit.org
  • 2 edits
    7 adds in trunk/LayoutTests

Chromium rebaseline after r85535. The test only works in Mac because it tests sub pixel layout and
depends on the specific font metrics used in Mac port.

  • platform/chromium-cg-mac-leopard/editing/inserting/typing-at-end-of-line-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/typing-at-end-of-line-expected.png: Added.
  • platform/chromium-linux/editing/inserting/typing-at-end-of-line-expected.png: Added.
  • platform/chromium-mac-leopard/editing/inserting/typing-at-end-of-line-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/typing-at-end-of-line-expected.png: Added.
  • platform/chromium-win/editing/inserting/typing-at-end-of-line-expected.png: Added.
  • platform/chromium-win/editing/inserting/typing-at-end-of-line-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:58 AM Changeset in webkit [97283] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Lion: media tests with invalid URLs failing
​https://bugs.webkit.org/show_bug.cgi?id=69947

Unreviewed.

Add failing tests to the Skipped list.

  • platform/mac-lion/Skipped:
11:51 AM Changeset in webkit [97282] by hyatt@apple.com
  • 15 edits
    21 adds in trunk

Source/WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=69896

[CSS Regions] Make positioned blocks work with variable width regions.

Make positioned objects able to position and size independently in each region. This involves
lifting the restriction in renderBoxRegionInfo for positioned objects and passing in region
information to computeLogicalWidthForPositioned so that it can compute answers for a given
region.

In order to make mixed writing modes work with positioned objects, this patch also takes some
baby steps towards fixing differing writing modes in paginated environments.

Reviewed by Sam Weinig.

Added many new tests in fast/regions.

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):
Disable pagination whenever differing writing modes are encountered. The block effectively becomes
unsplittable (as though it was an image).

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
Remove a FIXME that looks incorrect now.

(WebCore::RenderBlock::adjustPositionedBlock):
Patch static inline position caching to call a new method that unshifts the position to put it back
in the overall block's space rather than having it be per-region.

(WebCore::RenderBlock::layoutPositionedObjects):
Make sure to attempt to set a logicalTop for positioned objects before they lay out so that they
have a chance of paginating correctly the first time around. If for some reason the top estimate proves
to be incorrect, we lay out again. Technically this bug exists for multi-column and printing as well, but
for now just fixing it for regions.

(WebCore::RenderBlock::adjustForUnsplittableChild):
Add writing mode roots to the set of objects we consider to be unsplittable.

(WebCore::RenderBlock::setStaticInlinePositionForChild):
New helper function that handles shifting the inline static position back into the overall block's space
rather than leaving it in a translated region-specific space.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::startOffsetForContent):
New helper function for computing the start offset when no regions are involved.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setStaticPositions):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
Patched to call the new helper function, setStaticInlinePositionForChild.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::positionLineBox):
Patched to call the new helper function, setStaticInlinePositionForChild.

(WebCore::RenderBox::computeLogicalWidthInRegion):
Pass region information into the positioning logical width computation function.

(WebCore::RenderBox::renderBoxRegionInfo):
Remove the positioning restriction and properly compute shifting and left/right offsets for positioned
objects.

(WebCore::RenderBox::computeLogicalHeight):
Add code for perpendicular flows that just positions the object within the first region it is encountered
in. Since the object is unsplittable, this will work out. Should the object be so tall that it can't fit
in any region, then the resulting rendering will potentially be terrible, but the expectation is that authors should
avoid having perpendicular flows break across pages.

(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
Patched to handle regions when they are passed in. Also makes sure that the pagination direction axis computation uses
the flow thread's first region when the flow thread is the positioned object's containing block.

(WebCore::computeInlineStaticDistance):
Patched to examine regions and to modify the static distance computation accordingly so that it is per-region.

(WebCore::RenderBox::computePositionedLogicalWidth):
Pass along the region information when computing the positioned logical width.

(WebCore::computeLogicalLeftPositionedOffset):
Handle the adjustment of the logical left offset for differing writing modes (in this case when the writing mode
is flipped relative to us).

(WebCore::RenderBox::computePositionedLogicalHeight):
Deal with perpendicular writing modes and make sure the object is placed properly using the first region it
occurs in.

(WebCore::computeLogicalTopPositionedOffset):
Remove code that is no longer needed.

(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
Patched to pass in 0 instead of a region since replaced elements aren't handled yet.

  • rendering/RenderBox.h:

Changing the computePositionedLogicalWidth method to take region information.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
Didn't bother fixing deprecated flexible box, and the new flexbox still can't handle positioned objects. When it does,
it will use the new method. Put in some FIXMEs to help the flexbox coders see the issue when they port the code over
to the new flexbox.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::staticInlinePosition):
(WebCore::RenderLayer::staticBlockPosition):
(WebCore::RenderLayer::setStaticInlinePosition):
(WebCore::RenderLayer::setStaticBlockPosition):
Patched to take LayoutUnits instead of ints.

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=69896

[CSS Regions] Make positioned blocks work with variable width regions.

Reviewed by Sam Weinig.

  • fast/regions/overflow-size-change-with-stacking-context-rtl.html: Added.
  • fast/regions/position-writing-modes-in-variable-width-regions.html: Added.
  • fast/regions/positioned-objects-block-static-spanning-regions-rtl.html: Added.
  • fast/regions/positioned-objects-block-static-spanning-regions.html: Added.
  • fast/regions/positioned-objects-inline-static-spanning-regions-rtl.html: Added.
  • fast/regions/positioned-objects-inline-static-spanning-regions.html: Added.
  • fast/regions/positioned-objects-spanning-regions.html: Added.
  • platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt:
  • platform/mac/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Added.
  • platform/mac/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Added.
  • platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Added.
  • platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt: Added.
  • platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.txt:
  • platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.txt:
  • platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-expected.png: Added.
  • platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-expected.txt: Added.
  • platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.png: Added.
  • platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.txt: Added.
  • platform/mac/fast/regions/positioned-objects-inline-static-in-regions-expected.txt:
  • platform/mac/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.txt:
  • platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-expected.png: Added.
  • platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-expected.txt: Added.
  • platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Added.
  • platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Added.
  • platform/mac/fast/regions/positioned-objects-spanning-regions-expected.png: Added.
  • platform/mac/fast/regions/positioned-objects-spanning-regions-expected.txt: Added.
11:46 AM Changeset in webkit [97281] by Dimitri Glazkov
  • 5 edits in trunk/Tools

garden-o-matic should color-code test failure types.
​https://bugs.webkit.org/show_bug.cgi?id=69945

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added an extra span for styling.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Ditto.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added color-coding.
11:45 AM Changeset in webkit [97280] by Nate Chapin
  • 5 edits in trunk/Source/WebCore

Remove logging to determine how null v8::Contexts are happening,
and check the return value of V8DOMWindowShell::initContextIfNeeded()
before using the context it initialized.
​https://bugs.webkit.org/show_bug.cgi?id=68099

Reviewed by Adam Barth.

No new tests, the only symptom is a crash without a known repro.

  • bindings/v8/ScriptController.cpp:
  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initContextIfNeeded): Return true

if a context already existed.

(WebCore::V8DOMWindowShell::namedItemAdded): Remove logging.

  • bindings/v8/V8Proxy.cpp:
11:30 AM Changeset in webkit [97279] by abarth@webkit.org
  • 3 edits in trunk/Tools

webkitpy tests are failing on Mac bots
​https://bugs.webkit.org/show_bug.cgi?id=69929

Reviewed by Simon Fraser.

Admit that Lion exists.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
11:28 AM Changeset in webkit [97278] by robert@webkit.org
  • 4 edits
    6 adds in trunk

CSS 2.1 failure: border-conflict-style-079
​https://bugs.webkit.org/show_bug.cgi?id=69551

Reviewed by Antonio Gomes.

Source/WebCore:

  • css/CSSValueKeywords.in: ridge and outset were the wrong way round
  • rendering/style/RenderStyleConstants.h: ditto

LayoutTests:

  • css2.1/20110323/border-conflict-style-079.htm: Added.
  • css2.1/20110323/border-conflict-style-088.htm: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-style-079-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-style-079-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-style-088-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-style-088-expected.txt: Added.
11:27 AM Changeset in webkit [97277] by Simon Fraser
  • 2 edits in trunk/Tools

Improve output of run-api-tests to make time-outs more obvious
​https://bugs.webkit.org/show_bug.cgi?id=69788

Reviewed by Adam Roben.

List the tests that failed and timed out at the bottom of the output,
if run with --verbose.

  • Scripts/run-api-tests:

(runAllTests):
(runTest):

11:11 AM Changeset in webkit [97276] by abarth@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r97252.
​http://trac.webkit.org/changeset/97252
​https://bugs.webkit.org/show_bug.cgi?id=69944

Broke test-webkpy (Requested by abarth on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-12

  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
10:56 AM Changeset in webkit [97275] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Fix expectation ambiguities.

  • platform/chromium/test_expectations.txt: Fixed.
10:45 AM Changeset in webkit [97274] by jianli@chromium.org
  • 13 edits in trunk

Support passing optional filename when FormData.append() is used to
append a blob
​https://bugs.webkit.org/show_bug.cgi?id=69885

Reviewed by David Levin.

Source/WebCore:

Covered by existing test with new test case added:
http/tests/local/formdata/send-form-data-with-sliced-file.html

  • bindings/js/JSDOMFormDataCustom.cpp:

(WebCore::JSDOMFormData::append):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::appendCallback):

  • html/DOMFormData.cpp:

(WebCore::DOMFormData::append):

  • html/DOMFormData.h:
  • html/DOMFormData.idl:
  • html/FormDataList.cpp:

(WebCore::FormDataList::appendBlob):

  • html/FormDataList.h:

(WebCore::FormDataList::Item::Item):
(WebCore::FormDataList::Item::filename):
(WebCore::FormDataList::appendBlob):

  • platform/network/FormData.cpp:

(WebCore::FormData::appendKeyValuePairItems):

LayoutTests:

  • http/tests/local/formdata/resources/send-form-data-common.js:

(dumpResponse):
(sendFormData):
(testSendingFormData):

  • http/tests/local/formdata/script-tests/send-form-data-with-sliced-file.js:

(runTest):

  • http/tests/local/formdata/send-form-data-with-sliced-file-expected.txt:
10:41 AM Changeset in webkit [97273] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Mark implicit-submission test as slow for all Debug builds.

  • platform/chromium/test_expectations.txt: Marked so.
10:32 AM Changeset in webkit [97272] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Fix ambiguous expectations.

  • platform/chromium/test_expectations.txt: Fixed.
10:27 AM Changeset in webkit [97271] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] More TIMEOUTs and TIMEOUT flakes due to V8 roll.

  • platform/chromium/test_expectations.txt: Added expectations of TIMEOUT.
10:05 AM Changeset in webkit [97270] by abarth@webkit.org
  • 6 edits in trunk/Source

ScriptController::executeIfJavaScriptURL gets confused by synchronous frame loads
​https://bugs.webkit.org/show_bug.cgi?id=69777

Patch by Sergey Glazunov <​serg.glazunov@gmail.com> on 2011-10-12
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url.html

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::replaceDocument):
(WebCore::DocumentWriter::begin):

  • loader/DocumentWriter.h:

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::loadJavaScriptURL):

9:55 AM Changeset in webkit [97269] by kov@webkit.org
  • 8 edits
    1 delete in trunk

Fix build with GLib 2.31
​https://bugs.webkit.org/show_bug.cgi?id=69840

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk> on 2011-10-12
Reviewed by Martin Robinson.

.:

  • configure.ac: add check for pthread rwlock support.

Source/JavaScriptCore:

  • GNUmakefile.list.am: removed ThreadingGtk.cpp.
  • wtf/ThreadingPrimitives.h: remove GTK+-specific definitions.
  • wtf/gobject/GOwnPtr.cpp: remove GCond and GMutex specializations.
  • wtf/gobject/GOwnPtr.h: ditto.
  • wtf/gobject/GTypedefs.h: remove GCond and GMutex forward declarations.
  • wtf/gtk/ThreadingGtk.cpp: Removed.
9:48 AM Changeset in webkit [97268] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Add a bunch of TIMEOUTs due to V8 roll.

  • platform/chromium/test_expectations.txt: Added expectations of TIMEOUT.
9:24 AM Changeset in webkit [97267] by vsevik@chromium.org
  • 14 edits
    2 adds in trunk/Source/WebCore

Web Inspector: Searching in multiple scripts in the scripts tab
​https://bugs.webkit.org/show_bug.cgi?id=38807

Reviewed by Pavel Feldman.

Added support for advanced search capabilities in inspector by means
of showing the new SearchView in Drawer. Advanced search is activated
with Ctrl+Shift+F (Cmd+Shift+F) shortcut.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/AdvancedSearchController.js: Added.
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/ScriptsSearchScope.js: Added.
  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.searchInContent):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/externs.js:

(WebInspector.showViewInDrawer):

  • inspector/front-end/inspector.css:

(.search-view):
(.search-view .search-panel):
(.search-view .search-results):
(#search-results-pane-file-based .search-result):
(#search-results-pane-file-based .search-result:first-child):
(#search-results-pane-file-based .search-result .search-result-file-name):
(#search-results-pane-file-based .search-result .search-result-matches-count):
(#search-results-pane-file-based .search-match):
(#search-results-pane-file-based .search-match .webkit-line-number.search-match-line-number):
(#search-results-pane-file-based .search-match:not(:hover) .webkit-line-number.search-match-line-number):
(#search-results-pane-file-based .search-match:hover):
(#search-results-pane-file-based .search-match .highlighted-match):
(#search-results-pane-file-based a):
(#search-results-pane-file-based .search-match .search-match-content):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):

  • inspector/front-end/utilities.js:

():

9:19 AM QtWebKitBuildBots edited by Csaba Osztrogonác
(diff)
9:07 AM Changeset in webkit [97266] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: testPauseWhenLoadingDevTools is broken
​https://bugs.webkit.org/show_bug.cgi?id=69934

Reviewed by Pavel Feldman.

  • src/js/Tests.js:
8:54 AM Changeset in webkit [97265] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Assertion fail in CSSPrimitiveValue ctor
​https://bugs.webkit.org/show_bug.cgi?id=69933

Unreviewed gardening.

  • platform/qt/Skipped:
8:29 AM Changeset in webkit [97264] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Fix Drawer to make it possible to show views other than Console.
​https://bugs.webkit.org/show_bug.cgi?id=69831

Reviewed by Pavel Feldman.

Animation type extracted to distinguish between slow and normal
animation and immediate show/hide.
Implemented correct console toggle button behavior on showing views
other than console in Drawer.
View shown in Drawer is now shown in drawer-contents div with common
styles moved there.
Removed unused "_safelyRemoveChildren" method from Drawer.

  • inspector/front-end/ConsolePanel.js:

(WebInspector.ConsolePanel.prototype.show):
(WebInspector.ConsolePanel.prototype.hide):

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype._animationDuration):

  • inspector/front-end/inspector.css:

(body.drawer-visible #drawer-contents):

  • inspector/front-end/inspector.js:

(WebInspector._toggleConsoleButtonClicked):
(WebInspector._escPressed):
(WebInspector.showViewInDrawer):
(WebInspector.documentKeyDown):

8:27 AM Changeset in webkit [97263] by commit-queue@webkit.org
  • 3 edits
    3 moves in trunk/Source/WebKit2

[Qt][WK2] Move qweberror* out of API/qt
​https://bugs.webkit.org/show_bug.cgi?id=69875

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2011-10-12
Reviewed by Andreas Kling.

Moving QWebError outside API/qt in order to keep our API folder (layer) aligned.

  • UIProcess/qt/qweberror.cpp: Renamed from Source/WebKit2/UIProcess/API/qt/qweberror.cpp.

(QWebError::QWebError):
(QWebErrorPrivate::createQWebError):
(QWebErrorPrivate::QWebErrorPrivate):
(QWebErrorPrivate::~QWebErrorPrivate):
(QWebError::type):
(QWebError::errorCode):
(QWebError::url):

  • UIProcess/qt/qweberror.h: Renamed from Source/WebKit2/UIProcess/API/qt/qweberror.h.

(QWebError::errorCodeAsHttpStatusCode):
(QWebError::errorCodeAsNetworkError):

  • UIProcess/qt/qweberror_p.h: Renamed from Source/WebKit2/UIProcess/API/qt/qweberror_p.h.
  • WebKit2.pro:
  • WebKit2API.pri:
7:58 AM Changeset in webkit [97262] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WebKit2][gtk] Add few more API's to gtk-doc section file.
​https://bugs.webkit.org/show_bug.cgi?id=69921

Patch by Nayan Kumar K <​nayankk@motorola.com> on 2011-10-12
Reviewed by Gustavo Noronha Silva.

Generate documentation for existing WebKit2-GTK+ API's,
which are not yet the part of gtk-doc documentation.

  • UIProcess/API/gtk/docs/GNUmakefile.am: List ignore files.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: API's addition.
7:56 AM Changeset in webkit [97261] by caryclark@google.com
  • 383 edits
    70 deletes in trunk/LayoutTests

Roll back image baseline changes from
​http://trac.webkit.org/changeset/96814 -- they were generated on a
headless Mac, and thus used the wrong color profile.

Unreviewed rebaselining.

  • platform/chromium-mac/css1/basic/comments-expected.png:
  • platform/chromium-mac/css1/basic/containment-expected.png:
  • platform/chromium-mac/css1/basic/id_as_selector-expected.png:
  • platform/chromium-mac/css1/basic/inheritance-expected.png:
  • platform/chromium-mac/css1/box_properties/border-expected.png:
  • platform/chromium-mac/css1/box_properties/border_bottom-expected.png:
  • platform/chromium-mac/css1/box_properties/border_bottom_width-expected.png:
  • platform/chromium-mac/css1/box_properties/border_left-expected.png:
  • platform/chromium-mac/css1/box_properties/border_left_width-expected.png:
  • platform/chromium-mac/css1/box_properties/border_right_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_right_width-expected.png:
  • platform/chromium-mac/css1/box_properties/border_style-expected.png:
  • platform/chromium-mac/css1/box_properties/border_top-expected.png:
  • platform/chromium-mac/css1/box_properties/border_top_width-expected.png:
  • platform/chromium-mac/css1/box_properties/border_width-expected.png:
  • platform/chromium-mac/css1/box_properties/clear-expected.png:
  • platform/chromium-mac/css1/box_properties/float_margin-expected.png:
  • platform/chromium-mac/css1/box_properties/height-expected.png:
  • platform/chromium-mac/css1/box_properties/margin-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_bottom-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_left-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_right-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_top-expected.png:
  • platform/chromium-mac/css1/box_properties/padding-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_bottom-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_left-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_right-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_top-expected.png:
  • platform/chromium-mac/css1/box_properties/width-expected.png:
  • platform/chromium-mac/css1/cascade/cascade_order-expected.png:
  • platform/chromium-mac/css1/classification/display-expected.png:
  • platform/chromium-mac/css1/classification/list_style_type-expected.png:
  • platform/chromium-mac/css1/classification/white_space-expected.png:
  • platform/chromium-mac/css1/color_and_background/background-expected.png:
  • platform/chromium-mac/css1/color_and_background/background_attachment-expected.png:
  • platform/chromium-mac/css1/color_and_background/background_position-expected.png:
  • platform/chromium-mac/css1/color_and_background/background_repeat-expected.png:
  • platform/chromium-mac/css1/conformance/forward_compatible_parsing-expected.png:
  • platform/chromium-mac/css1/font_properties/font_size-expected.png:
  • platform/chromium-mac/css1/font_properties/font_weight-expected.png:
  • platform/chromium-mac/css1/formatting_model/floating_elements-expected.png:
  • platform/chromium-mac/css1/formatting_model/height_of_lines-expected.png:
  • platform/chromium-mac/css1/formatting_model/horizontal_formatting-expected.png:
  • platform/chromium-mac/css1/formatting_model/inline_elements-expected.png:
  • platform/chromium-mac/css1/formatting_model/replaced_elements-expected.png:
  • platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.png:
  • platform/chromium-mac/css1/pseudo/anchor-expected.png:
  • platform/chromium-mac/css1/pseudo/firstletter-expected.png:
  • platform/chromium-mac/css1/pseudo/firstline-expected.png:
  • platform/chromium-mac/css1/pseudo/multiple_pseudo_elements-expected.png:
  • platform/chromium-mac/css1/text_properties/letter_spacing-expected.png:
  • platform/chromium-mac/css1/text_properties/line_height-expected.png:
  • platform/chromium-mac/css1/text_properties/text_decoration-expected.png:
  • platform/chromium-mac/css1/text_properties/text_indent-expected.png:
  • platform/chromium-mac/css1/text_properties/vertical_align-expected.png:
  • platform/chromium-mac/css1/text_properties/word_spacing-expected.png:
  • platform/chromium-mac/css1/units/color_units-expected.png:
  • platform/chromium-mac/css1/units/length_units-expected.png:
  • platform/chromium-mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-002-expected.png:
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-004-expected.png:
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-006-expected.png:
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-008-expected.png:
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-010-expected.png:
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-012-expected.png:
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-014-expected.png:
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-016-expected.png:
  • platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.png:
  • platform/chromium-mac/css2.1/t0803-c5505-mrgn-02-c-expected.png:
  • platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
  • platform/chromium-mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png: Removed.
  • platform/chromium-mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png: Removed.
  • platform/chromium-mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1002-c5523-width-02-b-g-expected.png:
  • platform/chromium-mac/css2.1/t1202-counters-08-b-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1202-counters-09-b-expected.png: Removed.
  • platform/chromium-mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
  • platform/chromium-mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
  • platform/chromium-mac/css2.1/t1508-c527-font-07-b-expected.png:
  • platform/chromium-mac/editing/inserting/insert-div-023-expected.png:
  • platform/chromium-mac/editing/selection/focus_editable_html-expected.png:
  • platform/chromium-mac/editing/selection/select-all-003-expected.png:
  • platform/chromium-mac/editing/selection/select-all-004-expected.png:
  • platform/chromium-mac/fast/backgrounds/background-inherit-color-bug-expected.png:
  • platform/chromium-mac/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-mac/fast/block/basic/fieldset-stretch-to-legend-expected.png:
  • platform/chromium-mac/fast/block/basic/truncation-rtl-expected.png:
  • platform/chromium-mac/fast/block/float/008-expected.png: Removed.
  • platform/chromium-mac/fast/block/float/013-expected.png:
  • platform/chromium-mac/fast/block/float/019-expected.png: Removed.
  • platform/chromium-mac/fast/block/float/021-expected.png:
  • platform/chromium-mac/fast/block/float/025-expected.png:
  • platform/chromium-mac/fast/block/float/026-expected.png:
  • platform/chromium-mac/fast/block/float/027-expected.png:
  • platform/chromium-mac/fast/block/float/028-expected.png:
  • platform/chromium-mac/fast/block/float/032-expected.png: Removed.
  • platform/chromium-mac/fast/block/float/035-expected.png: Removed.
  • platform/chromium-mac/fast/block/float/avoidance-percent-width-strict-expected.png: Removed.
  • platform/chromium-mac/fast/block/float/br-with-clear-2-expected.png: Removed.
  • platform/chromium-mac/fast/block/float/float-not-removed-from-next-sibling4-expected.png:
  • platform/chromium-mac/fast/block/float/nested-clearance-expected.png: Removed.
  • platform/chromium-mac/fast/block/float/relative-painted-twice-expected.png:
  • platform/chromium-mac/fast/block/lineboxcontain/parsing-invalid-expected.png:
  • platform/chromium-mac/fast/block/margin-collapse/104-expected.png:
  • platform/chromium-mac/fast/block/margin-collapse/empty-clear-blocks-expected.png:
  • platform/chromium-mac/fast/block/positioning/047-expected.png:
  • platform/chromium-mac/fast/block/positioning/055-expected.png:
  • platform/chromium-mac/fast/block/positioning/auto/007-expected.png:
  • platform/chromium-mac/fast/block/positioning/auto/vertical-lr/007-expected.png:
  • platform/chromium-mac/fast/block/positioning/auto/vertical-rl/007-expected.png:
  • platform/chromium-mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.png: Removed.
  • platform/chromium-mac/fast/block/positioning/negative-rel-position-expected.png: Removed.
  • platform/chromium-mac/fast/block/positioning/relative-overflow-block-expected.png: Removed.
  • platform/chromium-mac/fast/block/positioning/relative-overflow-replaced-expected.png:
  • platform/chromium-mac/fast/block/positioning/relative-overflow-replaced-float-expected.png:
  • platform/chromium-mac/fast/block/positioning/vertical-lr/002-expected.png: Removed.
  • platform/chromium-mac/fast/block/positioning/vertical-rl/002-expected.png: Removed.
  • platform/chromium-mac/fast/body-propagation/overflow/002-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/002-xhtml-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/003-declarative-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/003-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/003-xhtml-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/004-declarative-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/004-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/004-xhtml-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/006-declarative-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/006-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/006-xhtml-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/007-declarative-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/007-expected.png:
  • platform/chromium-mac/fast/body-propagation/overflow/007-xhtml-expected.png:
  • platform/chromium-mac/fast/borders/border-image-massive-scale-expected.png:
  • platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac/fast/borders/inline-mask-overlay-image-expected.png:
  • platform/chromium-mac/fast/borders/rtl-border-01-expected.png:
  • platform/chromium-mac/fast/borders/rtl-border-02-expected.png:
  • platform/chromium-mac/fast/borders/rtl-border-03-expected.png:
  • platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac/fast/box-sizing/box-sizing-expected.png: Removed.
  • platform/chromium-mac/fast/canvas/canvas-bg-expected.png:
  • platform/chromium-mac/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium-mac/fast/clip/014-expected.png:
  • platform/chromium-mac/fast/css-generated-content/014-expected.png:
  • platform/chromium-mac/fast/css/005-expected.png:
  • platform/chromium-mac/fast/css/MarqueeLayoutTest-expected.png:
  • platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.png:
  • platform/chromium-mac/fast/css/border-height-expected.png: Removed.
  • platform/chromium-mac/fast/css/color-correction-backgrounds-and-text-expected.png:
  • platform/chromium-mac/fast/css/color-correction-on-background-image-expected.png:
  • platform/chromium-mac/fast/css/empty-pseudo-class-expected.png:
  • platform/chromium-mac/fast/css/first-child-pseudo-class-expected.png:
  • platform/chromium-mac/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/chromium-mac/fast/css/hsl-color-expected.png:
  • platform/chromium-mac/fast/css/last-child-pseudo-class-expected.png:
  • platform/chromium-mac/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/chromium-mac/fast/css/line-height-overflow-expected.png: Removed.
  • platform/chromium-mac/fast/css/nested-floating-relative-position-percentages-expected.png: Removed.
  • platform/chromium-mac/fast/css/nested-rounded-corners-expected.png:
  • platform/chromium-mac/fast/css/only-child-pseudo-class-expected.png:
  • platform/chromium-mac/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/chromium-mac/fast/css/percentage-non-integer-expected.png:
  • platform/chromium-mac/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/chromium-mac/fast/css/word-space-extra-expected.png:
  • platform/chromium-mac/fast/dom/clone-node-dynamic-style-expected.png:
  • platform/chromium-mac/fast/dom/scroll-reveal-top-overflow-expected.png: Removed.
  • platform/chromium-mac/fast/dynamic/anchor-lock-expected.png: Removed.
  • platform/chromium-mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
  • platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-mac/fast/events/pointer-events-2-expected.png:
  • platform/chromium-mac/fast/events/standalone-image-drag-to-editable-expected.png:
  • platform/chromium-mac/fast/flexbox/009-expected.png:
  • platform/chromium-mac/fast/flexbox/016-expected.png:
  • platform/chromium-mac/fast/flexbox/flex-hang-expected.png: Removed.
  • platform/chromium-mac/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac/fast/forms/form-hides-table-expected.png:
  • platform/chromium-mac/fast/forms/textAreaLineHeight-expected.png:
  • platform/chromium-mac/fast/frames/frame-scrolling-attribute-expected.png: Removed.
  • platform/chromium-mac/fast/frames/iframe-scrolling-attribute-expected.png:
  • platform/chromium-mac/fast/gradients/background-clipped-expected.png:
  • platform/chromium-mac/fast/gradients/css3-color-stop-units-expected.png:
  • platform/chromium-mac/fast/html/details-position-expected.png:
  • platform/chromium-mac/fast/images/gif-large-checkerboard-expected.png: Removed.
  • platform/chromium-mac/fast/inline-block/tricky-baseline-expected.png:
  • platform/chromium-mac/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/chromium-mac/fast/inline/inline-continuation-borders-expected.png:
  • platform/chromium-mac/fast/inline/long-wrapped-line-expected.png: Removed.
  • platform/chromium-mac/fast/invalid/residual-style-expected.png:
  • platform/chromium-mac/fast/layers/overflow-scroll-auto-switch-expected.png: Removed.
  • platform/chromium-mac/fast/layers/scroll-rect-to-visible-expected.png:
  • platform/chromium-mac/fast/lists/001-expected.png:
  • platform/chromium-mac/fast/lists/001-vertical-expected.png:
  • platform/chromium-mac/fast/lists/008-expected.png:
  • platform/chromium-mac/fast/lists/008-vertical-expected.png:
  • platform/chromium-mac/fast/lists/li-br-expected.png: Removed.
  • platform/chromium-mac/fast/lists/ol-start-parsing-expected.png:
  • platform/chromium-mac/fast/lists/olstart-expected.png:
  • platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.png:
  • platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.png:
  • platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.png:
  • platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.png:
  • platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.png:
  • platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.png:
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png:
  • platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.png:
  • platform/chromium-mac/fast/media/mq-width-absolute-01-expected.png:
  • platform/chromium-mac/fast/media/mq-width-absolute-02-expected.png:
  • platform/chromium-mac/fast/media/mq-width-absolute-03-expected.png:
  • platform/chromium-mac/fast/media/mq-width-absolute-04-expected.png:
  • platform/chromium-mac/fast/multicol/client-rects-expected.png:
  • platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/column-rules-stacking-expected.png:
  • platform/chromium-mac/fast/multicol/columns-shorthand-parsing-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/float-multicol-expected.png:
  • platform/chromium-mac/fast/multicol/float-paginate-complex-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/float-paginate-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/layers-split-across-columns-expected.png:
  • platform/chromium-mac/fast/multicol/paginate-block-replaced-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/positioned-with-constrained-height-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/scrolling-overflow-expected.png:
  • platform/chromium-mac/fast/multicol/span/anonymous-style-inheritance-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/chromium-mac/fast/multicol/table-vertical-align-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/vertical-lr/float-paginate-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/vertical-rl/float-paginate-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Removed.
  • platform/chromium-mac/fast/overflow/002-expected.png:
  • platform/chromium-mac/fast/overflow/003-expected.png:
  • platform/chromium-mac/fast/overflow/005-expected.png: Removed.
  • platform/chromium-mac/fast/overflow/007-expected.png:
  • platform/chromium-mac/fast/overflow/008-expected.png:
  • platform/chromium-mac/fast/overflow/childFocusRingClip-expected.png:
  • platform/chromium-mac/fast/overflow/clip-rects-fixed-ancestor-expected.png:
  • platform/chromium-mac/fast/overflow/float-in-relpositioned-expected.png:
  • platform/chromium-mac/fast/overflow/hit-test-overflow-controls-expected.png:
  • platform/chromium-mac/fast/overflow/image-selection-highlight-expected.png:
  • platform/chromium-mac/fast/overflow/overflow-auto-position-absolute-expected.png:
  • platform/chromium-mac/fast/overflow/overflow-auto-table-expected.png:
  • platform/chromium-mac/fast/overflow/overflow-rtl-expected.png:
  • platform/chromium-mac/fast/overflow/overflow-rtl-vertical-expected.png:
  • platform/chromium-mac/fast/overflow/overflow-stacking-expected.png:
  • platform/chromium-mac/fast/overflow/overflow-text-hit-testing-expected.png:
  • platform/chromium-mac/fast/overflow/overflow-update-transform-expected.png:
  • platform/chromium-mac/fast/overflow/overflow-with-local-background-attachment-expected.png:
  • platform/chromium-mac/fast/overflow/position-fixed-transform-clipping-expected.png:
  • platform/chromium-mac/fast/overflow/scrollbar-position-update-expected.png:
  • platform/chromium-mac/fast/overflow/table-overflow-float-expected.png:
  • platform/chromium-mac/fast/overflow/unreachable-overflow-rtl-bug-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
  • platform/chromium-mac/fast/repaint/fixed-expected.png:
  • platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/chromium-mac/fast/repaint/fixed-tranformed-expected.png:
  • platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/chromium-mac/fast/repaint/overflow-scroll-body-appear-expected.png:
  • platform/chromium-mac/fast/repaint/repaint-during-scroll-expected.png:
  • platform/chromium-mac/fast/repaint/select-option-background-color-expected.png:
  • platform/chromium-mac/fast/repaint/selection-gap-overflow-scroll-2-expected.png:
  • platform/chromium-mac/fast/replaced/005-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-mac/fast/selectors/166-expected.png:
  • platform/chromium-mac/fast/table/023-expected.png: Removed.
  • platform/chromium-mac/fast/table/027-vertical-expected.png:
  • platform/chromium-mac/fast/table/028-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/table/034-expected.png:
  • platform/chromium-mac/fast/table/038-vertical-expected.png:
  • platform/chromium-mac/fast/table/040-expected.png:
  • platform/chromium-mac/fast/table/040-vertical-expected.png:
  • platform/chromium-mac/fast/table/border-collapsing/002-vertical-expected.png:
  • platform/chromium-mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png:
  • platform/chromium-mac/fast/table/edge-offsets-expected.png:
  • platform/chromium-mac/fast/table/empty-cells-expected.png:
  • platform/chromium-mac/fast/table/height-percent-test-expected.png: Removed.
  • platform/chromium-mac/fast/table/height-percent-test-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/table/overflowHidden-expected.png:
  • platform/chromium-mac/fast/table/prepend-in-anonymous-table-expected.png:
  • platform/chromium-mac/fast/table/table-display-types-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/table/wide-colspan-expected.png: Removed.
  • platform/chromium-mac/fast/table/wide-column-expected.png: Removed.
  • platform/chromium-mac/fast/text/international/thai-line-breaks-expected.png:
  • platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/chromium-mac/fast/text/large-text-composed-char-expected.png:
  • platform/chromium-mac/fast/text/softHyphen-expected.png: Removed.
  • platform/chromium-mac/fast/text/text-letter-spacing-expected.png:
  • platform/chromium-mac/fast/text/wbr-expected.png:
  • platform/chromium-mac/fast/text/whitespace/024-expected.png:
  • platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
  • platform/chromium-mac/fast/text/word-break-expected.png:
  • platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.png:
  • platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.png:
  • platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
  • platform/chromium-mac/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/chromium-mac/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/chromium-mac/fast/writing-mode/fallback-orientation-expected.png:
  • platform/chromium-mac/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-mac/fast/writing-mode/text-orientation-basic-expected.png:
  • platform/chromium-mac/fonts/cursive-expected.png:
  • platform/chromium-mac/fonts/default-expected.png:
  • platform/chromium-mac/fonts/fantasy-expected.png:
  • platform/chromium-mac/fonts/serif-expected.png:
  • platform/chromium-mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-zoom-expected.png:
  • platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac/svg/css/stars-with-shadow-expected.png:
  • platform/chromium-mac/svg/custom/altglyph-expected.png:
  • platform/chromium-mac/svg/custom/external-paintserver-reference-expected.png: Removed.
  • platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
  • platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
  • platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
  • platform/chromium-mac/svg/custom/invisible-text-after-scrolling-expected.png:
  • platform/chromium-mac/svg/custom/junk-data-expected.png:
  • platform/chromium-mac/svg/custom/linking-base-external-reference-expected.png: Removed.
  • platform/chromium-mac/svg/custom/missing-xlink-expected.png:
  • platform/chromium-mac/svg/custom/object-sizing-no-width-height-expected.png:
  • platform/chromium-mac/svg/custom/text-xy-updates-SVGList-expected.png: Removed.
  • platform/chromium-mac/svg/custom/use-font-face-crash-expected.png:
  • platform/chromium-mac/svg/dom/SVGLengthList-appendItem-expected.png:
  • platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.png:
  • platform/chromium-mac/svg/dom/SVGLengthList-initialize-expected.png:
  • platform/chromium-mac/svg/dom/SVGLengthList-insertItemBefore-expected.png:
  • platform/chromium-mac/svg/dom/SVGLengthList-removeItem-expected.png:
  • platform/chromium-mac/svg/dom/SVGLengthList-replaceItem-expected.png:
  • platform/chromium-mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.png:
  • platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.png:
  • platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.png:
  • platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png:
  • platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png:
  • platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.png:
  • platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.png:
  • platform/chromium-mac/svg/dom/SVGPointList-basics-expected.png:
  • platform/chromium-mac/svg/dom/SVGStringList-basics-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
  • platform/chromium-mac/svg/in-html/circle-expected.png:
  • platform/chromium-mac/svg/overflow: Removed.
  • platform/chromium-mac/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Removed.
  • platform/chromium-mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Removed.
  • platform/chromium-mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Removed.
  • platform/chromium-mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Removed.
  • platform/chromium-mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Removed.
  • platform/chromium-mac/svg/text/kerning-expected.png:
  • platform/chromium-mac/svg/text/multichar-glyph-expected.png:
  • platform/chromium-mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
  • platform/chromium-mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug10269-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug10296-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1055-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug113235-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug113235-3-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug11944-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug120364-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug149275-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug22019-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug23151-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug29314-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2947-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug32205-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug38916-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug43039-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46480-1-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug46480-2-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug56405-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug5835-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug650-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug92143-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug96343-expected.png:
  • platform/chromium-mac/tables/mozilla/core/cell_heights-expected.png:
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_fix-expected.png:
  • platform/chromium-mac/tables/mozilla/core/col_widths_fix_fixPer-expected.png:
  • platform/chromium-mac/tables/mozilla/core/nested1-expected.png:
  • platform/chromium-mac/tables/mozilla/core/one_row-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/backgr_index-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_td_height-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_td_nowrap-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_th_height-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_th_nowrap-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
  • platform/chromium-mac/tables/mozilla/other/nestedTables-expected.png:
  • platform/chromium-mac/tables/mozilla/other/test6-expected.png:
  • platform/chromium-mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
  • platform/chromium-mac/tables/mozilla/other/wa_table_tr_align-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/core/backgrounds-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/core/col_span2-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/core/columns-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/core/conflicts-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/core/standards1-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/other/empty_cells-expected.png:
  • platform/chromium-mac/transforms/2d/transform-fixed-container-expected.png:
7:56 AM BuildingQt5OnHarmattan edited by Simon Hausmann
(diff)
7:22 AM Changeset in webkit [97260] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

[v8] Use V8DOMWrapper::isWrapperOfType for determining global object type
​https://bugs.webkit.org/show_bug.cgi?id=69923

Get rid of globalObjectPrototypeIsDOMWindow, use V8DOMWrapper::isWrapperOfType instead.

Reviewed by Pavel Feldman.

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object):
(WebCore::V8DOMWrapper::getEventListener):

6:58 AM Changeset in webkit [97259] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][ARMv5] inspector/elements/edit-dom-actions.html and ~/elements-delete-inline-style.html times out
​https://bugs.webkit.org/show_bug.cgi?id=69925

Unreviewed gardening.

  • platform/qt-arm/Skipped:
6:48 AM Changeset in webkit [97258] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Web Inspector: assertion failure when evaluating expression in worker inspector console
​https://bugs.webkit.org/show_bug.cgi?id=69922

Check that the global object is a DOMWindow wrapper befor casting it to V8DOMWindow.

Reviewed by Pavel Feldman.

  • bindings/v8/ScriptState.cpp:

(WebCore::ScriptState::domWindow):

6:31 AM Changeset in webkit [97257] by caryclark@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Prevent fallback fonts from purging while measuring
​https://bugs.webkit.org/show_bug.cgi?id=69855

Reviewed by Eric Seidel.

When Chrome computes the page width, an international page
may bring in a fallback font. FontCache::getCachedFontData
expects the font cache to be locked, so the measure path
needs to include an instance of FontCachePurgePreventer.

Adding FontCachePurgePreventer suppresses a debug-time assert
when running PageCycler over international tests.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::contentsPreferredWidth):

6:23 AM Changeset in webkit [97256] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-10-12 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, CCThreadTest.startPostAndWaitOnCondition is flaky on linux.

  • tests/CCThreadTest.cpp: (WebKit::TEST):
5:50 AM Changeset in webkit [97255] by hans@chromium.org
  • 3 edits in branches/chromium/874/Source/WebCore/storage

Merge 96007 - IndexedDB: Null key path gets stored as empty string key path
​https://bugs.webkit.org/show_bug.cgi?id=68726

Patch by Joshua Bell <​jsbell@chromium.org> on 2011-09-26
Reviewed by Tony Chang.

Store additional flag to indicate if object store key path
is null vs. empty. Added additional runtime tests for integrity
of object store metadata.

  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::checkObjectStoreAndMetaDataType):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::createObjectStore):

  • storage/IDBLevelDBCoding.cpp:

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/8242009

5:39 AM Changeset in webkit [97254] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-12

  • DEPS:
4:45 AM BuildingQt5OnHarmattan edited by Simon Hausmann
(diff)
4:42 AM Changeset in webkit [97253] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing tests on WK2.

  • platform/qt-wk2/Skipped:
4:27 AM Changeset in webkit [97252] by Csaba Osztrogonác
  • 4 edits
    4 adds in trunk

new-run-webkit-tests does not support qt-4.8 results
​https://bugs.webkit.org/show_bug.cgi?id=64071

Patch by Kristóf Kosztyó <​kkristof@inf.u-szeged.hu> on 2011-10-12
Reviewed by Csaba Osztrogonác.

Tools:

  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

LayoutTests:

  • platform/qt-4.7/Skipped: Added.
  • platform/qt-5.0/Skipped: Added.
2:58 AM Changeset in webkit [97251] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-10-12 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, mark fast/css/text-transform-select.html as IMAGE+TEXT on win.

  • platform/chromium/test_expectations.txt:
2:51 AM Changeset in webkit [97250] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-10-12 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, mark four js tests as failing after v8 roll.

  • platform/chromium/test_expectations.txt:
2:41 AM Changeset in webkit [97249] by yutak@chromium.org
  • 2 edits in trunk/Source/WebCore

WebSocket: Update WebSocket protocol to hybi-17
​https://bugs.webkit.org/show_bug.cgi?id=69910

Reviewed by Kent Tamura.

Essential changes between hybi-10 and hybi-17 are:

  • Sec-WebSocket-Origin header has been renamed to "Origin".
  • Sec-WebSocket-Version header value has been bumped to 13.

No new tests are necessary. pywebsocket has already been updated to the latest version
which understands the new protocol. Tests under http/tests/websocket/ should keep
passing.

  • websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::clientHandshakeMessage):
(WebCore::WebSocketHandshake::clientHandshakeRequest):

2:20 AM Changeset in webkit [97248] by Antti Koivisto
  • 6 edits in trunk/Source/WebCore

Resolve regular and visited link style in a single pass
​https://bugs.webkit.org/show_bug.cgi?id=69838

Reviewed by Darin Adler

We can simplify and speed up selector matching by removing the recursive matching done
to generate the style for the :visited pseudo selector. Both regular and visited link style
can be generated in a single pass through the style selector.

  • Make SelectorChecker::checkSelector to return both :visited and :link matches for all links.
  • For each selector statically determine and cache the link states it may match.
  • When applying the matched style declarations, apply them to the right RenderStyle (regular, visited, or both).

Statically determining which link state will be matched works since we only support :visited matching
based on the current element state (not ancestors or siblings).

A later patch will eliminate the separate RenderStyle for visited style completely and include the
few allowed properties to the regular RenderStyle.

  • css/CSSStyleSelector.cpp:

(WebCore::RuleData::linkMatchType):
(WebCore::RuleSet::linkPseudoClassRules):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::updateFont):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::collectFeatures):
(WebCore::RuleSet::shrinkToFit):
(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::getColorFromPrimitiveValue):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::MatchedStyleDeclaration::MatchedStyleDeclaration):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::SelectorChecker):
(WebCore::SelectorChecker::checkSelector):
(WebCore::SelectorChecker::fastCheckRightmostSelector):
(WebCore::SelectorChecker::fastCheckSelector):
(WebCore::SelectorChecker::checkOneSelector):
(WebCore::SelectorChecker::commonPseudoClassSelectorMatches):
(WebCore::SelectorChecker::determineLinkMatchType):

  • css/SelectorChecker.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::addCachedPseudoStyle):

2:14 AM Changeset in webkit [97247] by tkent@chromium.org
  • 6 edits
    6 adds
    1 delete in trunk/LayoutTests

[Chromium] Update test expectations.

Update fast/forms/input-disabled-color.html, and remove an entry
for fast/forms/file/input-file-label.html.

  • platform/chromium-cg-mac-leopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-disabled-color-expected.png: Added.
  • platform/chromium-linux/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-disabled-color-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-win/fast/forms/input-disabled-color-expected.txt:
  • platform/chromium/test_expectations.txt:
2:13 AM Changeset in webkit [97246] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: add test for pause in shared worker initialization
​https://bugs.webkit.org/show_bug.cgi?id=69915

Add WebKit part of interactive ui test for pause in worker initialization.

Reviewed by Pavel Feldman.

  • src/js/Tests.js:

(.TestSuite.prototype.testPauseInSharedWorkerInitialization):

2:07 AM Changeset in webkit [97245] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: repair interactive tests for debugger pause
​https://bugs.webkit.org/show_bug.cgi?id=69912

Listen to DebuggerModel event instead of overriding private methods on it.

Reviewed by Pavel Feldman.

  • src/js/Tests.js:

(.TestSuite.prototype._waitForScriptPause):

2:07 AM Changeset in webkit [97244] by tkent@chromium.org
  • 5 edits in trunk

REGRESSION(r94836): An assertion fails in HTMLFormControlElement::isValidFormControlElement
when HTMLInputElement::setValue() is called while the element is focused.
​https://bugs.webkit.org/show_bug.cgi?id=69909

Reviewed by Ryosuke Niwa.

Source/WebCore:

setNeedsValidityCheck() should be called after the value update
and before any style recalculation. r94836 moved
setSelectionRange() call, and it recalculates the element style.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue): Move setNeedsValidityCheck() to setValueInternal().
(WebCore::HTMLInputElement::setValueInternal): Move setNeedsValidityCheck() from setValue().

LayoutTests:

  • fast/forms/input-live-pseudo-selectors-expected.txt:
  • fast/forms/resources/input-live-pseudo-selectors.js: Add a testcase for the bug.
1:58 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Update Qt on 4.8.x trunk bot (diff)
1:39 AM Changeset in webkit [97243] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-mac/Skipped: Skip new failing tests.
1:32 AM Changeset in webkit [97242] by mihnea@adobe.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Add myself to committers.

1:12 AM Changeset in webkit [97241] by rgabor@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add platform specific expected result for new tests.

  • platform/qt/fast/writing-mode/margins-expected.png: Added.
  • platform/qt/fast/writing-mode/margins-expected.txt: Added.
  • platform/qt/plugins/iframe-plugin-bgcolor-expected.png: Added.
  • platform/qt/plugins/iframe-plugin-bgcolor-expected.txt: Added.
1:01 AM Changeset in webkit [97240] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Layout tests crashing in DFG JIT code
​https://bugs.webkit.org/show_bug.cgi?id=69897

Reviewed by Gavin Barraclough.

Abstract value filtration didn't take into account cases where a structure
set filter, combined with predicted type knowledge, could lead to a stronger
filter for the structure abstract value.

This bug would have been benign in release builds; it would have just meant
that the analysis was less precise and some optimization opportunities would
be missed. I have an ASSERT that is meant to catch such cases, and it was
triggering sporadically in one of the LayoutTests.

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::filter):

12:50 AM BuildingQt5OnHarmattan edited by Simon Hausmann
(diff)
12:33 AM Changeset in webkit [97239] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

Build fixes for r97238.
​https://bugs.webkit.org/show_bug.cgi?id=69828

  • GNUmakefile.list.am: Remove SelectElement.{cpp,h}.
  • dom/DOMAllInOne.cpp: Remove SelectElement.cpp.
12:14 AM Changeset in webkit [97238] by tkent@chromium.org
  • 9 edits
    2 deletes in trunk/Source/WebCore

Move the content of SelectElementData into HTMLSelectElement, and remove SelectElement.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=69828

Reviewed by Darin Adler.

  • Move all of the data members of SelectElementData to

HTMLSelectElement, and their accessor functions are not needed
anymore.

  • Move SelectElementData::useMenuList() to HTMLSelectElement.

No new tests, just a refactoring.

  • CMakeLists.txt: Remove SelectElement.cpp.
  • WebCore.gypi: Remove SelectElement.{cpp,h}.
  • WebCore.pro: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • dom/OptionElement.cpp: Remove a reference to SelectElement.h.
  • dom/SelectElement.cpp: Removed.
  • dom/SelectElement.h: Removed.
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::HTMLSelectElement):
Initializes the moved data members.
(WebCore::HTMLSelectElement::formControlType):
(WebCore::HTMLSelectElement::setSelectedIndexByUser):
(WebCore::HTMLSelectElement::activeSelectionStartListIndex):
(WebCore::HTMLSelectElement::activeSelectionEndListIndex):
(WebCore::HTMLSelectElement::parseMappedAttribute):
(WebCore::HTMLSelectElement::canSelectAll):
(WebCore::HTMLSelectElement::createRenderer):
(WebCore::HTMLSelectElement::setOption):
(WebCore::HTMLSelectElement::selectAll):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::menuListOnChange):
(WebCore::HTMLSelectElement::scrollToSelection):
(WebCore::HTMLSelectElement::setOptionsChangedOnRenderer):
(WebCore::HTMLSelectElement::setRecalcListItems):
(WebCore::HTMLSelectElement::recalcListItemsInternal):
(WebCore::HTMLSelectElement::setSelectedIndexInternal):
(WebCore::HTMLSelectElement::dispatchFocusEvent):
(WebCore::HTMLSelectElement::dispatchBlurEvent):
(WebCore::HTMLSelectElement::parseMultipleAttribute):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
(WebCore::HTMLSelectElement::defaultEventHandler):
(WebCore::HTMLSelectElement::typeAheadFind):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):

  • html/HTMLSelectElement.h:

(WebCore::HTMLSelectElement::size):
(WebCore::HTMLSelectElement::multiple):
(WebCore::HTMLSelectElement::usesMenuList):

12:09 AM Changeset in webkit [97237] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Chromium Mac build fix after r97227.

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(+[ScrollbarPrefsObserver appearancePrefsChanged:]):

Oct 11, 2011:

11:10 PM Changeset in webkit [97236] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Rebaseline after r97225.

  • fast/dom/constructed-objects-prototypes-expected.txt:
11:09 PM Changeset in webkit [97235] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, temporarily reverted r97216 due to bug #69897.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentFillGPR):

11:05 PM Changeset in webkit [97234] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

DFG 32_64 - fix silentFillGPR
​https://bugs.webkit.org/show_bug.cgi?id=69903

Patch by Yuqiang Xian <​yuqiang.xian@intel.com> on 2011-10-11
Reviewed by Filip Pizlo.

Fix a small bug in silentFillGPR,
and add the newly introduced DFG file to CMakeListsEfl.

  • CMakeListsEfl.txt:
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentFillGPR):

10:56 PM Changeset in webkit [97233] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/chromium

[chromium] Add accessor for plugin request to not scale print output.
​https://bugs.webkit.org/show_bug.cgi?id=68853

Patch by Steve VanDeBogart <​vandebo@chromium.org> on 2011-10-11
Reviewed by Darin Fisher.

  • public/WebFrame.h:
  • public/WebPlugin.h:

(WebKit::WebPlugin::isPrintScalingDisabled):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::isPrintScalingDisabledForPlugin):

  • src/WebFrameImpl.h:
  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::isPrintScalingDisabled):

  • src/WebPluginContainerImpl.h:
10:35 PM Changeset in webkit [97232] by commit-queue@webkit.org
  • 9 edits
    1 add in trunk/Source

Separate compositor client thread from webkit's main thread.
​https://bugs.webkit.org/show_bug.cgi?id=69048

Patch by Antoine Labour <​piman@chromium.org> on 2011-10-11
Reviewed by Darin Fisher.

Source/WebCore:

Covered by compositing tests.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCMainThread.cpp:
  • platform/graphics/chromium/cc/CCMainThread.h:
  • platform/graphics/chromium/cc/CCProxy.cpp:

(WebCore::CCProxy::isMainThread):
(WebCore::CCProxy::setMainThread):
(WebCore::CCProxy::CCProxy):

  • platform/graphics/chromium/cc/CCProxy.h:

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::currentThread):

  • src/CCMainThreadImpl.cpp: Added.

(WTF::TaskWrapper::TaskWrapper):
(WTF::TaskWrapper::~TaskWrapper):
(WTF::TaskWrapper::run):
(WebCore::CCMainThread::initialize):
(WebCore::CCMainThread::postTask):

10:25 PM Changeset in webkit [97231] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Some more WK2 test skipping.

  • platform/wk2/Skipped:
10:14 PM Changeset in webkit [97230] by Simon Fraser
  • 2 edits
    1 delete in trunk/LayoutTests

Add some tests to the WK2 skipped list which require layoutTestController or
textInputController methods not implemented yet, and remove a WK2-specific
result that is not longer correct.

  • platform/mac-wk2/fast/css/pseudo-any-expected.txt: Removed.
  • platform/wk2/Skipped:
9:45 PM Changeset in webkit [97229] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix Leopard and Snow Leopard builds, which don't use the scrollbar painter.

  • platform/mac/ScrollAnimatorMac.mm:
9:36 PM Changeset in webkit [97228] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

Check in failing test expectation after r95897. The failure is tracked by the bug 69069.

  • platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.png:
  • platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
  • platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.png:
  • platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
9:36 PM Changeset in webkit [97227] by Simon Fraser
  • 39 edits
    1 copy in trunk/Source

Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
​https://bugs.webkit.org/show_bug.cgi?id=68134

Reviewed by Darin Adler.

Source/WebCore:

Use ScrollbarThemeMock when the setting to use mock scrollbars is enabled.

Make ScrollbarTheme::nativeTheme() private, and add a new static theme() method
that reads the setting, and returns the mock theme if set. All callers now use
theme() rther than nativeTheme(). Add the new ScrollbarTheme.cpp file to the build.

Fix scroll animator code for Mac and Chromium that was casting the ScrollbarTheme
without type-checking it to test whether it's the mock theme.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::startRepeatingTimer):

  • platform/ScrollAnimatorWin.cpp:

(WebCore::ScrollAnimatorWin::scroll):
(WebCore::ScrollAnimatorWin::accelerationTime):
(WebCore::ScrollAnimatorWin::animateScroll):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::setScrollbarOverlayStyle):

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::maxOverlapBetweenPages):
(WebCore::Scrollbar::Scrollbar):

  • platform/ScrollbarTheme.cpp: Copied from Source/WebCore/platform/mock/ScrollbarThemeMock.h.

(WebCore::ScrollbarTheme::theme):

  • platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::isMockTheme):

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::layout):

  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::chromiumScrollbarTheme):
(WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorChromiumMac::updateScrollerStyle):

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(+[ScrollbarPrefsObserver behaviorPrefsChanged:]):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::macScrollbarTheme):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):

  • platform/mac/ScrollbarThemeMac.mm:

(+[WebScrollbarPrefsObserver appearancePrefsChanged:]):
(+[WebScrollbarPrefsObserver behaviorPrefsChanged:]):

  • platform/mock/ScrollbarThemeMock.h:

(WebCore::ScrollbarThemeMock::isMockTheme):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::calculatePositionAndSize):

  • rendering/RenderLayer.cpp:

(WebCore::cornerRect):

  • rendering/RenderScrollbarPart.cpp:

(WebCore::calcScrollbarThicknessUsing):

  • rendering/RenderScrollbarTheme.h:

(WebCore::RenderScrollbarTheme::scrollbarThickness):
(WebCore::RenderScrollbarTheme::buttonsPlacement):
(WebCore::RenderScrollbarTheme::shouldCenterOnThumb):
(WebCore::RenderScrollbarTheme::initialAutoscrollTimerDelay):
(WebCore::RenderScrollbarTheme::autoscrollTimerDelay):
(WebCore::RenderScrollbarTheme::registerScrollbar):
(WebCore::RenderScrollbarTheme::unregisterScrollbar):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::scrollbarThickness):

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::menuListInternalPadding):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore::RenderThemeChromiumWin::adjustInnerSpinButtonStyle):

Source/WebKit/chromium:

Use ScrollbarThemeMock when the setting to use mock scrollbars is enabled.

Make ScrollbarTheme::nativeTheme() private, and add a new static theme() method
that reads the setting, and returns the mock theme if set. All callers now use
theme() rther than nativeTheme(). Add the new ScrollbarTheme.cpp file to the build.

  • src/WebScrollbarImpl.cpp:

(WebKit::WebScrollbar::defaultThickness):

Source/WebKit/qt:

Use ScrollbarThemeMock when the setting to use mock scrollbars is enabled.

Make ScrollbarTheme::nativeTheme() private, and add a new static theme() method
that reads the setting, and returns the mock theme if set. All callers now use
theme() rther than nativeTheme(). Add the new ScrollbarTheme.cpp file to the build.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::windowResizerRect):

Source/WebKit/win:

Use ScrollbarThemeMock when the setting to use mock scrollbars is enabled.

Make ScrollbarTheme::nativeTheme() private, and add a new static theme() method
that reads the setting, and returns the mock theme if set. All callers now use
theme() rther than nativeTheme(). Add the new ScrollbarTheme.cpp file to the build.

  • WebScrollBar.cpp:

(WebScrollBar::requestedWidth):
(WebScrollBar::requestedHeight):

  • WebView.cpp:

(WebView::WebViewWndProc):

Source/WebKit2:

Use ScrollbarThemeMock when the setting to use mock scrollbars is enabled.

Make ScrollbarTheme::nativeTheme() private, and add a new static theme() method
that reads the setting, and returns the mock theme if set. All callers now use
theme() rther than nativeTheme(). Add the new ScrollbarTheme.cpp file to the build.

  • UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::calculatePositionAndSize):

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::paintControls):

  • WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::bounds):

9:21 PM Changeset in webkit [97226] by Martin Robinson
  • 6 edits
    2 copies
    1 move
    7 adds
    2 deletes in trunk

[GTK] [WebKit2] Make adding another unit test easier
​https://bugs.webkit.org/show_bug.cgi?id=69409

Reviewed by Gustavo Noronha Silva.

.:

  • GNUmakefile.am: Include the new testing makefile.

Source/WebKit2:

  • GNUmakefile.am: Add the new WebKit2 API tests.
  • UIProcess/API/gtk/tests/GNUmakefile.am: Added.
  • UIProcess/API/gtk/tests/LoadTrackingTest.cpp: Added. A fixture for creating load tracking tests.
  • UIProcess/API/gtk/tests/LoadTrackingTest.h: Added.
  • UIProcess/API/gtk/tests/TestMain.cpp: Copied from Source/WebKit2/UIProcess/API/gtk/tests/testwebview.c.

(main):

  • UIProcess/API/gtk/tests/TestMain.h: Added.
  • UIProcess/API/gtk/tests/TestWebKitWebContext.cpp: Copied from Source/WebKit2/UIProcess/API/gtk/tests/testwebview.c.
  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp: Added.
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/testwebview.c.
  • UIProcess/API/gtk/tests/WebViewTest.cpp: Added. A fixture for generic WebView tests.
  • UIProcess/API/gtk/tests/WebViewTest.h: Added.
  • UIProcess/API/gtk/tests/testloading.c: Removed.
  • UIProcess/API/gtk/tests/testwebcontext.c: Removed.

Tools:

  • Scripts/run-gtk-tests: Update run-gtk-tests to be able to execute

new WebKit2 tests.

9:05 PM Changeset in webkit [97225] by haraken@chromium.org
  • 9 edits
    2 adds in trunk

Implement a WebKitTransitionEvent constructor for JSC
​https://bugs.webkit.org/show_bug.cgi?id=69829

Reviewed by Adam Barth.

Source/WebCore:

There is no spec for the WebKitTransitionEvent constructor
since it is WebKit-specific. However, judging from the current
IDL of initWebKitTransitionEvent(), the constructor IDL
should be as follows.

[Constructor(DOMString type, optional WebKitTransitionEventInit eventInitDict)]
interface WebKitTransitionEvent : Event {

...;

}

dictionary WebKitTransitionEventInit : EventInit {

DOMString propertyName;
double elapsedTime;

}

Test: fast/events/constructors/webkit-transition-event-constructor.html

  • bindings/generic/EventConstructors.h: Added a definition for the WebKitTransitionEvent constructor.
  • bindings/js/JSEventConstructors.cpp: Added #includes for WebKitTransitionEvent.
  • dom/WebKitTransitionEvent.cpp:

(WebCore::WebKitTransitionEventInit::WebKitTransitionEventInit):
(WebCore::WebKitTransitionEvent::WebKitTransitionEvent):
(WebCore::WebKitTransitionEvent::initWebKitTransitionEvent):

  • dom/WebKitTransitionEvent.h: Added a definition for WebKitTransitionEventInit.

(WebCore::WebKitTransitionEvent::create):
(WebCore::WebKitTransitionEvent::isWebKitTransitionEvent):

  • dom/WebKitTransitionEvent.idl: Makes WebKitTransitionEvent constructible.

LayoutTests:

webkit-transition-event-constructor.html checks the behavior of the WebKitTransitionEvent constructor.

  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/events/constructors/webkit-transition-event-constructor-expected.txt: Added.
  • fast/events/constructors/webkit-transition-event-constructor.html: Added.
  • platform/chromium/test_expectations.txt: Skipped webkit-transition-event-constructor.html, since V8 does not yet have the WebKitTransitionEvent constructor.
8:45 PM Changeset in webkit [97224] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Source/WebCore: :checked pseudo selector not matching selected option
​https://bugs.webkit.org/show_bug.cgi?id=63192

Patch by Sameer Patil <​mkrp87@motorola.com> on 2011-10-11
Reviewed by Kent Tamura.

Test: fast/css/checked-pseudo-selector.html

Option element selected state need to be checked in checkOneSelector,
so that it can be considered as checked on querySelectorAll(':checked').

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector):

LayoutTests: :checked pseudo selector not matching selected option
​https://bugs.webkit.org/show_bug.cgi?id=63192

Patch by Sameer Patil <​mkrp87@motorola.com> on 2011-10-11
Reviewed by Kent Tamura.

  • fast/css/checked-pseudo-selector-expected.txt: Added.
  • fast/css/checked-pseudo-selector.html: Added.
8:29 PM Changeset in webkit [97223] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

StorageAreaSync::sync needs a transaction for better performance.
​https://bugs.webkit.org/show_bug.cgi?id=57694

Reviewed by Darin Adler.

For now, StorageAreaSync::sync execute SQLite operations for all items outside
a transaction.
However, SQLite operations outside a transaction are all atomic and thus
writes will block on I/O, which makes the process slow during heavy I/O.
This wrapped them with BEGIN TRANSACTION and END TRANSACTION for the better
performance.

No new tests required.
No functional changes if transaction doesn't fail.
And also, it is difficult to test the case of transaction fails.

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::sync):

8:27 PM Changeset in webkit [97222] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

margin-right is ignored with vertical writing mode
​https://bugs.webkit.org/show_bug.cgi?id=69686

Reviewed by Darin Adler.

Source/WebCore:

We need to use the parent's writing mode when grabbing
the margin start/end for the purposes of computing the parent's
preferred widths.

Test: fast/writing-mode/margins.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

  • rendering/RenderBlock.h:

LayoutTests:

  • fast/writing-mode/margins-expected.txt: Added.
  • fast/writing-mode/margins.html: Added.
8:00 PM Changeset in webkit [97221] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WebSocket] update pywebsocket to 0.6b6.
​https://bugs.webkit.org/show_bug.cgi?id=69824

Patch by Takashi Toyoshima <​toyoshim@chromium.org> on 2011-10-11
Reviewed by Kent Tamura.

WebKit supports WebSocket with version 8 based protocol for now.
We should update its protocol to version 13 based one like hybi-17.
pywebsocket 0.6b6 supports both of version 8 and 13.

  • Scripts/webkitpy/thirdparty/init.py:
7:42 PM Changeset in webkit [97220] by commit-queue@webkit.org
  • 16 edits
    2 deletes in trunk

Unreviewed, rolling out r97202, r97207, and r97215.
​http://trac.webkit.org/changeset/97202
​http://trac.webkit.org/changeset/97207
​http://trac.webkit.org/changeset/97215
​https://bugs.webkit.org/show_bug.cgi?id=69894

Broke builds (Requested by rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-11

Source/WebCore:

  • platform/PopupMenuClient.h:
  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::showPopup):

  • rendering/RenderMenuList.h:
  • rendering/RenderObject.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::showPopup):

  • rendering/RenderTextControlSingleLine.h:
  • testing/Internals.cpp:
  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/chromium:

  • src/AutofillPopupMenuClient.cpp:
  • src/AutofillPopupMenuClient.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::applyAutofillSuggestions):

  • tests/PopupMenuTest.cpp:

LayoutTests:

  • fast/dom/popup-menu-client-test-expected.txt: Removed.
  • fast/dom/popup-menu-client-test.html: Removed.
7:26 PM Changeset in webkit [97219] by Martin Robinson
  • 4 edits in trunk

[Soup] ResourceHandleSoup does not handle encodedBlobData
​https://bugs.webkit.org/show_bug.cgi?id=52092

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Add support for sending encoded blob data during requests.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::addFileToSoupMessageBody): Added this helper.
(WebCore::blobIsOutOfDate): Ditto.
(WebCore::addEncodedBlobItemToSoupMessageBody): Ditto.
(WebCore::addEncodedBlobToSoupMessageBody): Ditto.
(WebCore::addFormElementsToSoupMessage): No longer flatten form data, as we
cannot do this in the case where the form data contains blobs. Now handle
the blob case.
(WebCore::loadResourceSynchronously): Add blob support for synchronous loading.

LayoutTests:

  • platform/gtk/Skipped: Unskip tests which are now passing.
7:05 PM Changeset in webkit [97218] by fpizlo@apple.com
  • 22 edits
    6 adds
    1 delete in trunk/Source/JavaScriptCore

DFG does not have flow-sensitive intraprocedural control flow analysis
​https://bugs.webkit.org/show_bug.cgi?id=69690

Reviewed by Gavin Barraclough.

Implemented a control flow analysis (CFA). It currently propagates type
proofs only. For example, if all predecessors to a basic block have
checks that variable X is a JSFinalObject with structure 0xabcdef, then
this basic block will now know this fact and will know that it does not
have to emit either JSFinalObject checks or any structure checks since
the structure is precisely known. The CFA takes heap side-effects into
account (though somewhat conservatively), so that if the object pointed
to by variable X could have possibly undergone a structure transition
then this is reflected: the analysis may simply say that X's structure
is unknown.

This also propagates a wealth of other type information which is
currently not being used. For example, we now know when a variable can
only hold doubles. Even if a variable may hold other types at different
points in its live range, we can still prove exactly when it will only
be double.

There's a bunch of stuff that the CFA could do that it still does not
do, like precise handling of PutStructure (i.e. structure transitions),
precise handling of CheckFunction and CheckMethod, etc. So this is
very much intended to be a starting point rather than an end unto
itself.

This is a 1% win on V8 (mostly due to a 3% win on richards and deltablue)
and a 1% win on Kraken (mostly due to a 6% win on imaging-desaturate).
Neutral on SunSpider.

  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/ActionablePrediction.h: Removed.
  • bytecode/PredictedType.cpp:

(JSC::predictionToString):

  • bytecode/PredictedType.h:
  • dfg/DFGAbstractState.cpp: Added.

(JSC::DFG::AbstractState::AbstractState):
(JSC::DFG::AbstractState::~AbstractState):
(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::reset):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::clobberStructures):
(JSC::DFG::AbstractState::mergeStateAtTail):
(JSC::DFG::AbstractState::merge):
(JSC::DFG::AbstractState::mergeToSuccessors):
(JSC::DFG::AbstractState::mergeVariableBetweenBlocks):
(JSC::DFG::AbstractState::dump):

  • dfg/DFGAbstractState.h: Added.

(JSC::DFG::AbstractState::forNode):
(JSC::DFG::AbstractState::isValid):

  • dfg/DFGAbstractValue.h: Added.

(JSC::DFG::StructureAbstractValue::StructureAbstractValue):
(JSC::DFG::StructureAbstractValue::clear):
(JSC::DFG::StructureAbstractValue::makeTop):
(JSC::DFG::StructureAbstractValue::top):
(JSC::DFG::StructureAbstractValue::add):
(JSC::DFG::StructureAbstractValue::addAll):
(JSC::DFG::StructureAbstractValue::contains):
(JSC::DFG::StructureAbstractValue::isSubsetOf):
(JSC::DFG::StructureAbstractValue::doesNotContainAnyOtherThan):
(JSC::DFG::StructureAbstractValue::isSupersetOf):
(JSC::DFG::StructureAbstractValue::filter):
(JSC::DFG::StructureAbstractValue::isClear):
(JSC::DFG::StructureAbstractValue::isTop):
(JSC::DFG::StructureAbstractValue::size):
(JSC::DFG::StructureAbstractValue::at):
(JSC::DFG::StructureAbstractValue::operator[]):
(JSC::DFG::StructureAbstractValue::last):
(JSC::DFG::StructureAbstractValue::predictionFromStructures):
(JSC::DFG::StructureAbstractValue::operator==):
(JSC::DFG::StructureAbstractValue::dump):
(JSC::DFG::AbstractValue::AbstractValue):
(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::isClear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::clobberStructures):
(JSC::DFG::AbstractValue::isTop):
(JSC::DFG::AbstractValue::top):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::operator==):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::dump):

  • dfg/DFGBasicBlock.h: Added.

(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::getBytecodeBegin):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::setupPredecessors):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::block):

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):

  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::noticeOSREntry):

  • dfg/DFGNode.h:

(JSC::DFG::NodeIndexTraits::defaultValue):
(JSC::DFG::Node::variableAccessData):
(JSC::DFG::Node::takenBytecodeOffsetDuringParsing):
(JSC::DFG::Node::notTakenBytecodeOffsetDuringParsing):
(JSC::DFG::Node::setTakenBlockIndex):
(JSC::DFG::Node::setNotTakenBlockIndex):
(JSC::DFG::Node::takenBlockIndex):
(JSC::DFG::Node::notTakenBlockIndex):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOSREntry.h:
  • dfg/DFGOperands.h: Added.

(JSC::DFG::operandIsArgument):
(JSC::DFG::OperandValueTraits::defaultValue):
(JSC::DFG::Operands::Operands):
(JSC::DFG::Operands::numberOfArguments):
(JSC::DFG::Operands::numberOfLocals):
(JSC::DFG::Operands::argument):
(JSC::DFG::Operands::local):
(JSC::DFG::Operands::setLocal):
(JSC::DFG::Operands::setArgumentFirstTime):
(JSC::DFG::Operands::setLocalFirstTime):
(JSC::DFG::Operands::operand):
(JSC::DFG::Operands::setOperand):
(JSC::DFG::Operands::clear):
(JSC::DFG::dumpOperands):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::propagatePredictions):
(JSC::DFG::Propagator::performBlockCFA):
(JSC::DFG::Propagator::performForwardCFA):
(JSC::DFG::Propagator::globalCFA):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureSet.h:

(JSC::DFG::StructureSet::clear):
(JSC::DFG::StructureSet::predictionFromStructures):
(JSC::DFG::StructureSet::operator==):
(JSC::DFG::StructureSet::dump):

  • dfg/DFGVariableAccessData.h: Added.
7:04 PM Changeset in webkit [97217] by crogers@google.com
  • 2 edits in branches/chromium/874/Source/WebCore/platform/audio

Merge 97214 - Heap buffer overflow in Webaudio FFTFrame::doFFT

BUG=99211
Review URL: ​http://codereview.chromium.org/8231033

6:53 PM Changeset in webkit [97216] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG JIT 32_64 - Fix silentFillGPR for non-integer constants.
​https://bugs.webkit.org/show_bug.cgi?id=69890

Reviewed by Oliver Hunt.

Cell constants are currently hitting the valueOfInt32Constant case, there is no constant handling for JSValues.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentFillGPR):

6:53 PM Changeset in webkit [97215] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Second attempt to fix Chromium Windows build after r97202.

  • tests/PopupMenuTest.cpp:

(WebKit::TestPopupMenuClient::boundingBoxRect):
(WebKit::TestPopupMenuClient::setFocusedNode):

6:48 PM Changeset in webkit [97214] by crogers@google.com
  • 3 edits in trunk/Source/WebCore

Heap buffer overflow in Webaudio FFTFrame::doFFT
​https://bugs.webkit.org/show_bug.cgi?id=69447

Reviewed by Kenneth Russell.

No new tests. This only changes internal implementation details.

  • platform/audio/HRTFKernel.cpp:

(WebCore::extractAverageGroupDelay):

  • platform/audio/HRTFPanner.cpp:

(WebCore::HRTFPanner::fftSizeForSampleRate):

6:40 PM Changeset in webkit [97213] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Second Qt minimum release build fix attempt after r97163.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncCompositingStateSelf):

6:38 PM Changeset in webkit [97212] by Simon Fraser
  • 2 edits in trunk/Tools

WebKitTestRunner needs to link with WebKit for NSURL category methods
​https://bugs.webkit.org/show_bug.cgi?id=69892

Reviewed by Sam Weinig.

WebDragClient::declareAndWriteDragImage() was throwing an Obj-C exception on 10.6 because
the +_web_originalDataAsString selector on NSURL was not recognized. Link with
WebKit.framework to fix this.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
6:37 PM Changeset in webkit [97211] by rniwa@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

GTK build fix attempt after r97197.

  • wtf/BitVector.h:
6:27 PM Changeset in webkit [97210] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Qt minimum release build fix attempt after r97163.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncCompositingStateSelf):

6:18 PM Changeset in webkit [97209] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix Chromium test expectations.

  • platform/chromium/test_expectations.txt:
6:16 PM Changeset in webkit [97208] by oliver@apple.com
  • 10 edits in trunk/Source/WebCore

Clang build broken
​https://bugs.webkit.org/show_bug.cgi?id=69891

Reviewed by Darin Adler.

Rename CachedResourceClient::type to CachedResourceClient::resourceClientType
to avoid conflict in CSSImportRule.

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::didAddClient):

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::didAddClient):

  • loader/cache/CachedFont.h:

(WebCore::CachedFontClient::resourceClientType):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::didAddClient):

  • loader/cache/CachedImage.h:

(WebCore::CachedImageClient::resourceClientType):

  • loader/cache/CachedResourceClient.h:

(WebCore::CachedResourceClient::resourceClientType):

  • loader/cache/CachedResourceClientWalker.h:

(WebCore::CachedResourceClientWalker::next):

  • loader/cache/CachedStyleSheetClient.h:

(WebCore::CachedStyleSheetClient::resourceClientType):

  • loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::didAddClient):

6:12 PM Changeset in webkit [97207] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Chromium build fix attempt after r97202.

  • tests/PopupMenuTest.cpp:

(WebKit::SelectPopupMenuTest::boundingBoxRect):

6:11 PM Changeset in webkit [97206] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove unintentional logging.

6:07 PM Changeset in webkit [97205] by rniwa@webkit.org
  • 5 edits
    4 adds in trunk

Dir attribute is converted into direction property when merging paragraphs
​https://bugs.webkit.org/show_bug.cgi?id=69680

Reviewed by Enrica Casucci.

Source/WebCore:

Don't include direction and unicode-bidi properties in the wrapping style.

Tests: editing/deleting/merge-paragraph-into-h1-with-dir-2.html

editing/deleting/merge-paragraph-into-h1-with-dir.html

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement): Skip unicode-bidi and direction properties.
(WebCore::EditingStyle::wrappingStyleForSerialization): Extracted from StyledMarkupAccumulator::serializeNodes.

  • editing/EditingStyle.h:
  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::serializeNodes): Calls wrappingStyleForSerialization.

LayoutTests:

Added tests to merge paragraphs inside a block with dir attribute. WebKit should not add
direction or unicode-bidi properties.

  • editing/deleting/merge-paragraph-into-h1-with-dir-2-expected.txt: Added.
  • editing/deleting/merge-paragraph-into-h1-with-dir-2.html: Added.
  • editing/deleting/merge-paragraph-into-h1-with-dir-expected.txt: Added.
  • editing/deleting/merge-paragraph-into-h1-with-dir.html: Added.
5:41 PM Changeset in webkit [97204] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Let rule_binding use os.execvp() instead of subprocess.call() to spawn fewer processes.
​https://bugs.webkit.org/show_bug.cgi?id=69589

Reviewed by Dirk Pranke.

When building with make -j40, all the binding rules are built en bloc. Since this script currently
uses subprocess.call(), that actually spawns 80 processes at once. OS X has a max process limit of
255 by default, so the build used to fail with
"open2: fork failed: Resource temporarily unavailable at ../bindings/scripts/preprocessor.pm line 60"
As a fix, use execvp() instead, which replaces the current process instead of spawning a new one.

  • WebCore.gyp/scripts/rule_binding.py:
5:24 PM Changeset in webkit [97203] by oliver@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Tidy up card walking logic
​https://bugs.webkit.org/show_bug.cgi?id=69883

Reviewed by Gavin Barraclough.

Special case common cell sizes when walking a block's
cards.

  • heap/CardSet.h:

(JSC::::testAndClear):

  • heap/Heap.cpp:

(JSC::GCTimer::GCCounter::GCCounter):
(JSC::GCTimer::GCCounter::count):
(JSC::GCTimer::GCCounter::~GCCounter):
(JSC::Heap::markRoots):

  • heap/MarkStack.cpp:

(JSC::MarkStack::reset):

  • heap/MarkStack.h:

(JSC::MarkStack::visitCount):
(JSC::MarkStack::MarkStack):
(JSC::MarkStack::append):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::gatherDirtyCellsWithSize):
(JSC::MarkedBlock::gatherDirtyCells):

  • runtime/Structure.h:

(JSC::MarkStack::internalAppend):

5:19 PM Changeset in webkit [97202] by fsamuel@chromium.org
  • 15 edits
    2 adds in trunk

Towards making PopupMenuClient more testable
​https://bugs.webkit.org/show_bug.cgi?id=69631

Reviewed by Simon Fraser.

Source/WebCore:

Added some functions to window.internals to allow testing of parts of PopupMenuClient.

Test: fast/dom/popup-menu-client-test.html

  • platform/PopupMenuClient.h:
  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::showPopup):
(WebCore::RenderMenuList::boundingBoxRect):

  • rendering/RenderMenuList.h:

(WebCore::RenderMenuList::RenderMenuList::isPopupMenuClient):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isPopupMenuClient):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::boundingBoxRect):

  • rendering/RenderTextControlSingleLine.h:

(WebCore::RenderTextControlSingleLine::isPopupMenuClient):

  • testing/Internals.cpp:

(WebCore::Internals::toPopupMenuClient):
(WebCore::Internals::popupClientPaddingLeft):
(WebCore::Internals::popupClientPaddingRight):
(WebCore::Internals::popupClientBoundingBoxRect):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/chromium:

  • src/AutofillPopupMenuClient.cpp:

(WebKit::AutofillPopupMenuClient::boundingBoxRect):

  • src/AutofillPopupMenuClient.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::applyAutofillSuggestions):

LayoutTests:

  • fast/dom/popup-menu-client-test-expected.txt: Added.
  • fast/dom/popup-menu-client-test.html: Added.
5:17 PM Changeset in webkit [97201] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[Mac] Crash when opening an embedded PDF in a background tab
​https://bugs.webkit.org/show_bug.cgi?id=69880

Reviewed by Darin Adler.

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::BuiltInPDFView): (WebKit::BuiltInPDFView::~BuiltInPDFView): (WebKit::BuiltInPDFView::initialize): (WebKit::BuiltInPDFView::destroy): Moved initialization and destruction code from C++ constructor and destructor to designated functions. Not part of the fix, but seems related enough to fix.
5:16 PM Changeset in webkit [97200] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[Mac] Crash when opening an embedded PDF in a background tab
​https://bugs.webkit.org/show_bug.cgi?id=69880

Reviewed by Darin Adler.

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::paint): Don't call plug-in that doesn't even have a controller yet.
5:12 PM Changeset in webkit [97199] by Nate Chapin
  • 17 edits
    1 delete in trunk/Source/WebCore

Make CachedResourceClientWalker templates, and
have it check and filter out bad casts when iterating
(currently we rely on CachedResourceClients being careful
to inherit from the right subclass for the type of resource
they want to load).
​https://bugs.webkit.org/show_bug.cgi?id=69877

Reviewed by Adam Barth.

No new tests, no functionality change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/cache/CachedCSSStyleSheet.cpp:
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResourceClient.h:
  • loader/cache/CachedResourceClientWalker.cpp: Removed.
  • loader/cache/CachedResourceClientWalker.h:
  • loader/cache/CachedStyleSheetClient.h:
  • loader/cache/CachedXSLStyleSheet.cpp:
4:50 PM Changeset in webkit [97198] by abarth@webkit.org
  • 3 edits in trunk/Tools

sheriffbot takes too long to acknowledge rollout commands
​https://bugs.webkit.org/show_bug.cgi?id=69871

Reviewed by Eric Seidel.

We used to update the working copy before acknowledging the command
because we wanted to ping all the relevant IRC nicks. That's caused a
bunch of frustration because folks don't know whether the bot has heard
their commands.

This patch makes the bot reply immediately before updating the working
copy. All the relevenat folks are still pinged when the bot finishes
preparing the rollout.

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
4:50 PM Changeset in webkit [97197] by fpizlo@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

DFG virtual register allocator should be more aggressive in
reusing temporary slots
​https://bugs.webkit.org/show_bug.cgi?id=69868

Reviewed by Oliver Hunt.

1.2% win on V8, neutral elsewhere. The win is probably because it
increases precision of GC conservative scans.

This required making the DFG::ScoreBoard operate over a bitvector
of preserved variables, rather than just a preserved variable
threshold. To do this, I improved the WTF::BitVector class to make
it more user-friendly. It still retains all previous functionality.
Also made changes to PackedIntVector to accomodate those changes.
Finally, this adds more debugging to the virtual register allocator
and to the OSR exit code, as this was necessary to track down bugs
in an earlier version of this patch.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::getLocal):

  • dfg/DFGGraph.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::allocateVirtualRegisters):

  • dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::ScoreBoard):
(JSC::DFG::ScoreBoard::~ScoreBoard):
(JSC::DFG::ScoreBoard::allocate):
(JSC::DFG::ScoreBoard::use):
(JSC::DFG::ScoreBoard::highWatermark):
(JSC::DFG::ScoreBoard::dump):
(JSC::DFG::ScoreBoard::max):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::ValueRecovery::dump):

  • wtf/BitVector.cpp:

(WTF::BitVector::setSlow):
(WTF::BitVector::resizeOutOfLine):
(WTF::BitVector::dump):

  • wtf/BitVector.h:

(WTF::BitVector::BitVector):
(WTF::BitVector::operator=):
(WTF::BitVector::quickGet):
(WTF::BitVector::quickSet):
(WTF::BitVector::quickClear):
(WTF::BitVector::get):
(WTF::BitVector::set):
(WTF::BitVector::clear):

  • wtf/PackedIntVector.h:

(WTF::PackedIntVector::get):
(WTF::PackedIntVector::set):

4:48 PM Changeset in webkit [97196] by abarth@webkit.org
  • 2 edits in trunk/Tools

test-webkitpy fails on Lion
​https://bugs.webkit.org/show_bug.cgi?id=69873

Reviewed by Eric Seidel.

This patch fixes one of the two failures. I'll need to track down the
other failure another time.

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4:43 PM Changeset in webkit [97195] by wjmaclean@chromium.org
  • 3 edits in trunk/Source/WebCore

[chromium] Fix compilation guards in ScrollAnimatorNone (GESTURE_EVENTS).
​https://bugs.webkit.org/show_bug.cgi?id=69853

Reviewed by Kenneth Russell.

Adding missing guards ENABLE(GESTURE_EVENTS) in ScrollAnimatorNone. So
far this hasn't been a problem since GESTURE_EVENTS are usually turned on
whenever SMOOTH_SCROLLING is, but it could be a problem if this changes.

No new tests (compilation without errors is the test).

  • platform/ScrollAnimatorNone.cpp:
  • platform/ScrollAnimatorNone.h:
4:34 PM Changeset in webkit [97194] by kbr@google.com
  • 3 edits
    3 adds in trunk

[chromium] Check for lost context at beginning of compositor's execution
​https://bugs.webkit.org/show_bug.cgi?id=69776

Reviewed by James Robinson.

Source/WebCore:

Test: platform/chromium/compositing/webgl-loses-compositor-context.html

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):

LayoutTests:

Added test case which asserts when run in Chrome with dynamic GPU
switching enabled and without the fix in this patch.

  • platform/chromium/compositing/webgl-loses-compositor-context-expected.png: Added.
  • platform/chromium/compositing/webgl-loses-compositor-context-expected.txt: Added.
  • platform/chromium/compositing/webgl-loses-compositor-context.html: Added.
4:23 PM Changeset in webkit [97193] by dmazzoni@google.com
  • 3 edits in trunk/Source/WebKit/chromium

WebAccessibilityObject needs titleUIElement
​https://bugs.webkit.org/show_bug.cgi?id=69869

Reviewed by Dimitri Glazkov.

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::titleUIElement):

4:15 PM Changeset in webkit [97192] by abarth@webkit.org
  • 3 edits in trunk/Tools

garden-o-matic should warn me when run-webkit-tests errors out (e.g., due to python screw-ups)
​https://bugs.webkit.org/show_bug.cgi?id=65230

Reviewed by Dimitri Glazkov.

This patch causes us to treat crashed or hung run-webkit-tests runs
similarly to how we treat compile failures. In some sense, they're
similar because they prevent us from getting test coverage.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
4:05 PM Changeset in webkit [97191] by Beth Dakin
  • 2 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=69874
WebKit2 snapshot APIs should take the device scale factor into account
-and corresponding-
<rdar://problem/10269112>

Reviewed by Darin Adler.

Add the deviceScaleFactor as a scale on the snapshot's context to create a
snapshot of the appropriate resolution. This matches the manner in which we scale
the context in DrawingAreaImpl::display().

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotInViewCoordinates):
(WebKit::WebPage::scaledSnapshotInDocumentCoordinates):

4:04 PM Changeset in webkit [97190] by abarth@webkit.org
  • 7 edits in trunk/Tools

Failing builder display in garden-o-matic should have the same visual style as the failure grid
​https://bugs.webkit.org/show_bug.cgi?id=69876

Reviewed by Dimitri Glazkov.

This patch generalizes the view we use for failing builders in the
FailureGrid so that we can use it for the list of builders that aren't
compiling.

One downside of this patch is that it makes it harder to tell when
debug builders are failing (as opposed to release builders) because
that information isn't presented in this view. A future patch will
improve this aspect.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
3:51 PM Changeset in webkit [97189] by barraclough@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG JIT 32_64 - Switch to cdecl calling convention.
​https://bugs.webkit.org/show_bug.cgi?id=69863

Reviewed by Oliver Hunt.

This makes it easier to keep the stack correctly aligned, which is required on OS X.

  • assembler/MacroAssemblerCodeRef.h:

(JSC::FunctionPtr::FunctionPtr):

  • Provide default FunctionPtr constructors for CDECL functions on STDCALL platforms.
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

  • Switch calls to poke arguments rather than pushing them.

(JSC::DFG::resetCallArguments):
(JSC::DFG::addCallArgument):
(JSC::DFG::addCallArgumentBoxed):

  • Helper functions to stack up call arguments on X86.
  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

  • Don't push, poke!
  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::compileBody):

  • Don't push, poke!
  • dfg/DFGOperations.cpp:
    • Switch ReturnAddress wrappers to push return address last, update asm trampolines.
  • dfg/DFGOperations.h:
    • switch DFG_OPERATION to assert CDECL on STDCALL platforms.
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::fmodWithCDecl):
(JSC::DFG::SpeculativeJIT::compile):

  • On STDCALL platforms wrap fmod, since DFG_OPERATION wrappers are CDECL.
3:43 PM Changeset in webkit [97188] by wjmaclean@chromium.org
  • 7 edits in trunk/Source

Loss of precision when converting from double to int and double to float in FrameView::zoomAnimatorTransformChanged()
​https://bugs.webkit.org/show_bug.cgi?id=69739

Source/WebCore:

Reviewed by Simon Fraser.

Change 'double' parameters in FrameView:: & ScrollableArea::zoomAnimatorTransformChanged()
to 'float' to avoid loss of precision warnings when invoking setPageScalefactor.

Test coverage provided by existing zoom-animator tests.

  • page/FrameView.cpp:

(WebCore::FrameView::zoomAnimatorTransformChanged):

  • page/FrameView.h:
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::zoomAnimatorTransformChanged):

  • platform/ScrollableArea.h:

Source/WebKit2:

Change 'double' parameters to 'float' to match changes in FrameView.

Reviewed by Simon Fraser.

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:

(WebKit::BuiltInPDFView::zoomAnimatorTransformChanged):

2:56 PM Changeset in webkit [97187] by fpizlo@apple.com
  • 4 edits in trunk/Tools

Some API tests are timing out in Release
​https://bugs.webkit.org/show_bug.cgi?id=69787

Reviewed by Mark Rowe.

NDEBUG must be set in release builds. Otherwise the world breaks. Also added some
magic to ensure that GTest builds in release mode in clang with NDEBUG set.

  • TestWebKitAPI/Configurations/Base.xcconfig:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/config.h:
2:42 PM Changeset in webkit [97186] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix, unbreaking the Qt minimal bot.
Some #ifdef ENABLED(TILED_BACKING_STORE) clauses were missing.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::computeTiles):
(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::paintSelf):

2:24 PM Changeset in webkit [97185] by rniwa@webkit.org
  • 1 edit
    2 copies in trunk/LayoutTests

Mac rebaseline after r96610.

  • platform/chromium/http/tests/security/redirect-BLOCKED-to-localURL-expected.txt: Copied from

LayoutTests/http/tests/security/redirect-BLOCKED-to-localURL-expected.txt.

  • platform/mac/http/tests/security/redirect-BLOCKED-to-localURL-expected.txt: Copied from

LayoutTests/http/tests/security/redirect-BLOCKED-to-localURL-expected.txt.

2:14 PM Changeset in webkit [97184] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[Mac] Small embedded PDFs are not fully repainted when scrolling
​https://bugs.webkit.org/show_bug.cgi?id=69861

Reviewed by Anders Carlsson.

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::paintContent): Account for vertical centering when deciding which pages to paint.
2:12 PM Changeset in webkit [97183] by inferno@chromium.org
  • 1 edit
    3 copies in branches/chromium/874

Merge 97180 - Source/WebCore: Generalize r95461 change to include table-cell and

allow splitting between :before, :after content.

BUG=99880
Review URL: ​http://codereview.chromium.org/8232016

2:10 PM Changeset in webkit [97182] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Mac rebaseline after r96675.

  • platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
2:09 PM Changeset in webkit [97181] by inferno@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Generalize r95461 change to include table-cell and
allow splitting between :before, :after content.
​https://bugs.webkit.org/show_bug.cgi?id=69854

Reviewed by Eric Seidel.

  • fast/table/table-row-before-after-content-around-table-cell-expected.png: Added.
  • fast/table/table-row-before-after-content-around-table-cell-expected.txt: Added.
  • fast/table/table-row-before-after-content-around-table-cell.html: Added.
2:05 PM Changeset in webkit [97180] by inferno@chromium.org
  • 3 edits
    3 adds in trunk

Source/WebCore: Generalize r95461 change to include table-cell and
allow splitting between :before, :after content.
​https://bugs.webkit.org/show_bug.cgi?id=69854

Reviewed by Eric Seidel.

Test: fast/table/table-row-before-after-content-around-table-cell.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild):

LayoutTests: Style for updated due to inability to locate
:before content in presence of listmarkers and runins.
​https://bugs.webkit.org/show_bug.cgi?id=68624

Reviewed by Eric Seidel.

  • fast/lists/inline-before-content-after-list-marker-expected.png: Added.
  • fast/lists/inline-before-content-after-list-marker-expected.txt: Added.
  • fast/lists/inline-before-content-after-list-marker.html: Added.
  • fast/runin/runin-between-list-marker-and-before-content-expected.png: Added.
  • fast/runin/runin-between-list-marker-and-before-content-expected.txt: Added.
  • fast/runin/runin-between-list-marker-and-before-content.html: Added.
  • fast/runin/runin-into-div-with-float-child-expected.png: Added.
  • fast/runin/runin-into-div-with-float-child-expected.txt: Added.
  • fast/runin/runin-into-div-with-float-child.html: Added.
  • fast/runin/runin-not-go-into-float-expected.png: Added.
  • fast/runin/runin-not-go-into-float-expected.txt: Added.
  • fast/runin/runin-not-go-into-float.html: Added.
2:02 PM Changeset in webkit [97179] by rniwa@webkit.org
  • 4 edits in trunk/LayoutTests

Mac rebaseline after r96958.

  • platform/mac/fast/forms/input-disabled-color-expected.png:
  • platform/mac/fast/forms/input-disabled-color-expected.txt:
  • platform/mac/test_expectations.txt:
1:58 PM Changeset in webkit [97178] by rniwa@webkit.org
  • 1 edit
    1 move
    2 adds in trunk/LayoutTests

Move test expectations added by r96987 to Chromium Linux directory,
and add the baseline for Mac port.

  • fast/css/text-transform-select-expected.txt: Removed.
  • platform/chromium-linux/fast/css/text-transform-select-expected.txt: Copied from

LayoutTests/fast/css/text-transform-select-expected.txt.

  • platform/mac/fast/css/text-transform-select-expected.png: Added.
  • platform/mac/fast/css/text-transform-select-expected.txt: Added.
1:46 PM Changeset in webkit [97177] by dmazzoni@google.com
  • 3 edits
    2 adds in trunk

AccessibilityMenuList should fire change notification when popup is not open.
​https://bugs.webkit.org/show_bug.cgi?id=69440

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/menu-list-sends-change-notification.html

  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::didUpdateActiveOption):

LayoutTests:

  • accessibility/menu-list-sends-change-notification.html: Added.
  • platform/chromium/accessibility/menu-list-sends-change-notification-expected.txt: Added.
1:44 PM Changeset in webkit [97176] by abarth@webkit.org
  • 3 edits in trunk/Tools

garden-o-matic links to flakiness dashboard should open in a new tab
​https://bugs.webkit.org/show_bug.cgi?id=69864

Reviewed by Dimitri Glazkov.

This bug was obvious in the first five minutes of using this new
feature. :)

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1:44 PM Changeset in webkit [97175] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Suddenly, things are crashing sporadically.

  • platform/chromium/test_expectations.txt: Document the crashes.
1:37 PM Changeset in webkit [97174] by abarth@webkit.org
  • 2 edits in trunk/Tools

Tweak the Content-Security-Policy for garden-o-matic. It turns out
that * doesn't really mean "all". I've emailed the W3C working group
about changing the spec.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1:36 PM Changeset in webkit [97173] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] fast/js/regexp-overflow.html is slow everywhere.

  • platform/chromium/test_expectations.txt: Widened platform specifiers.
1:34 PM Changeset in webkit [97172] by abarth@webkit.org
  • 4 edits in trunk/Tools

garden-o-matic should link to the flakiness dashboard
​https://bugs.webkit.org/show_bug.cgi?id=69862

Reviewed by Dimitri Glazkov.

The flakiness dashboard has lots of great information about the failure
history of each test. This patch adds a link from garden-o-matic to
the flakiness dashboard so the gardener can look at this information.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1:21 PM Changeset in webkit [97171] by levin@chromium.org
  • 5 edits in trunk/Tools

watchlist: assertRaisesRegexp implementation should be compatible with python 2.7.
​https://bugs.webkit.org/show_bug.cgi?id=69789

Reviewed by Eric Seidel.

Made the signature of _assertRaisesRegexp match that of Python 2.7.

  • Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adjusted to be compatible with Python 2.7.
  • Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Ditto.
  • Scripts/webkitpy/common/webkitunittest.py: Ditto.
  • Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
12:56 PM Changeset in webkit [97170] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Mark more flakes as flakes.

  • platform/chromium/test_expectations.txt: Marked flakes.
12:37 PM Changeset in webkit [97169] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] DRT: Do not abort() when an unknown key is pressed.
​https://bugs.webkit.org/show_bug.cgi?id=69856

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-10-11
Reviewed by Antonio Gomes.

A lot of tests crash due to the previous behaviour. Just using the
received name of the pressed key works most of the time, and when it
does not the failing tests should tell us.

  • DumpRenderTree/efl/EventSender.cpp:

(keyPadNameFromJSValue):
(keyNameFromJSValue):
(keyDownCallback):

12:22 PM Changeset in webkit [97168] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

IndexedDB: implement IDBFactory.cmp method
​https://bugs.webkit.org/show_bug.cgi?id=62293

Patch by Joshua Bell <​jsbell@chromium.org> on 2011-10-11
Reviewed by Tony Chang.

Source/WebCore:

  • storage/IDBFactory.cpp:

(WebCore::IDBFactory::cmp):

  • storage/IDBFactory.h:
  • storage/IDBFactory.idl:
  • storage/IDBKey.cpp:

(WebCore::IDBKey::compare):
(WebCore::IDBKey::isLessThan):
(WebCore::IDBKey::isEqual):

  • storage/IDBKey.h:

LayoutTests:

Check for IDBFactory.deleteDatabase (NYI) marked as FAIL. crbug.com/72002
Tests for array keys (NYI) marked as FAIL. crbug.com/99876
Tests for invalid key exception types marked as FAIL. crbug.com/98930

  • storage/indexeddb/factory-basics-expected.txt:
  • storage/indexeddb/factory-basics.html:
12:01 PM Changeset in webkit [97167] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Embedding of PDF's with <object> or <embed> fails when there is no MIME type specified
​https://bugs.webkit.org/show_bug.cgi?id=64934

Reviewed by Dan Bernstein.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): Check URL extension, too, like GetPluginPath does in UI process. One difference is that UI process additionally tries platform specific extension to MIME type mapping, but that doesn't matter for PDF, which does not have other standard extensions.
11:39 AM Changeset in webkit [97166] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Unbarf Win testers after ambiguous expectations were added in r97149.

  • platform/chromium/test_expectations.txt: Made expectation more specific.
11:35 AM Changeset in webkit [97165] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

[Texmap] TextureMapperGL leaves GL in a modified state.
​https://bugs.webkit.org/show_bug.cgi?id=68983

Reviewed by Andreas Kling.

Disable the vertexAttribArray after clipping.

No new functionality so no new tests.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::beginClip):

11:07 AM Changeset in webkit [97164] by dmazzoni@google.com
  • 2 edits
    1 add in trunk/LayoutTests

[Chromium] Fix expectations for two accessibility tests.
​https://bugs.webkit.org/show_bug.cgi?id=69827

These tests were never run on Chromium before, so they're not new
failures. aria-roles had different expectations on different Mac
platforms, but on Chromium the results will always be the same, so
added Chromium-specific expectations. image-map-update-parent is
timing out, the cause here is unclear but it was never running before
so there's no new bug.

Unreviewed.

  • platform/chromium/accessibility/aria-roles-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:43 AM Changeset in webkit [97163] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebCore

[Qt][WK2] Synchronize tiling with accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=69151

Reviewed by Kenneth Rohde Christiansen.

Enable "externally managed" tiles in TextureMapperNodes.
Currently, TextureMapperNodes manage tiles themselves, the tiles being there only to
overcome the 2k texture size limitation. For WebKit2, we want those tiles to be managed
externally, namely through the web process via the remote tile backend for
TiledBackingStore.

This patch adds a store for those externally managed tiles, and adds the necessary code to
paint them instead of the owned tiles when appropriate.

In addition, in order to support externally managed remote tiles, we have to calculate per-
layer visible rects and pass them to the web process. The new collectVisibleContentRects
does this - and is directly tied to the externally-managed tile approach.

Code is disabled for now, but covered by existing compositing tests.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::computeTiles):
(WebCore::clampRect):
(WebCore::TextureMapperNode::collectVisibleContentRects):
(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::targetRectForTileRect):
(WebCore::TextureMapperNode::paintSelf):
(WebCore::TextureMapperNode::createContentsTile):
(WebCore::TextureMapperNode::removeContentsTile):
(WebCore::TextureMapperNode::setTileBackBufferTextureForDirectlyCompositedImage):
(WebCore::TextureMapperNode::clearAllDirectlyCompositedImageTiles):
(WebCore::TextureMapperNode::setContentsTileBackBuffer):
(WebCore::TextureMapperNode::swapContentsBuffers):
(WebCore::TextureMapperNode::syncCompositingStateSelf):
(WebCore::TextureMapperNode::syncCompositingState):

  • platform/graphics/texmap/TextureMapperNode.h:

(WebCore::TextureMapperNode::size):
(WebCore::TextureMapperNode::setTileOwnership):
(WebCore::TextureMapperNode::setID):
(WebCore::TextureMapperNode::id):
(WebCore::TextureMapperNode::texture):
(WebCore::TextureMapperNode::ExternallyManagedTile::ExternallyManagedTile):
(WebCore::TextureMapperNode::State::State):

10:41 AM Changeset in webkit [97162] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Gardening flakey test expectations.

  • platform/chromium/test_expectations.txt: Updated for recent flakes.
10:16 AM Changeset in webkit [97161] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] GtkAuthenticationDialog: use GtkGrid instead of GtkTable
​https://bugs.webkit.org/show_bug.cgi?id=69749

Patch by Claudio Saavedra <Claudio Saavedra> on 2011-10-11
Reviewed by Martin Robinson.

  • platform/gtk/GtkAuthenticationDialog.cpp:

(WebCore::addEntryToGrid): Migrate to GtkGrid when using GTK+ 3
(WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog):
Ditto.

10:03 AM Changeset in webkit [97160] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • WebCore.exp.in: Export GraphicsContext::clearShadow().
9:57 AM Changeset in webkit [97159] by adamk@chromium.org
  • 20 edits
    15 adds in trunk

[MutationObservers] Add stub implementation of WebKitMutationObserver
​https://bugs.webkit.org/show_bug.cgi?id=68949

Reviewed by Ryosuke Niwa, Oliver Hunt, and Dimitri Glazkov.

Source/WebCore:

See ​https://bugs.webkit.org/show_bug.cgi?id=68729 for the metabug.

This patch adds a stub WebKitMutationObserver and its supporting classes
MutationCallback and MutationObserverOptions.
No implementation is provided for the all-important observe() and
disconnect() methods.

Note that WebKitMutationObserver is vendor-prefixed since it has a
constructor exposed on DOMWindow. None of the rest of the API needs
prefixing, as it's only available via a call through a MutationObserver
callback (created by instantiating WebKitMutationObserver).

Given the number of files required to get just the stub up and running,
it seems reasonable to leave the actual implementation for the next
patch (or more likely several patches). I've left FIXMEs in all the places
that'll need augmentation.

Tests: fast/mutation/mutation-observer-constructor.html

fast/mutation/observe-exceptions.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDictionary.h:

(WebCore::JSDictionary::tryGetProperty):

  • bindings/js/JSMutationCallbackCustom.cpp: Added.

(WebCore::JSMutationCallback::handleEvent):

  • bindings/js/JSWebKitMutationObserverCustom.cpp: Added.

(WebCore::JSWebKitMutationObserverConstructor::constructJSWebKitMutationObserver):
(WebCore::JSWebKitMutationObserver::observe):

  • bindings/v8/custom/V8MutationCallbackCustom.cpp: Added.

(WebCore::V8MutationCallback::handleEvent):

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp: Added.

(WebCore::V8WebKitMutationObserver::constructorCallback):
(WebCore::V8WebKitMutationObserver::observeCallback):

  • dom/MutationCallback.h: Added.

(WebCore::MutationCallback::~MutationCallback):

  • dom/MutationCallback.idl: Added.
  • dom/MutationObserverOptions.h: Added.

(WebCore::MutationObserverOptions::create):
(WebCore::MutationObserverOptions::childList):
(WebCore::MutationObserverOptions::setChildList):
(WebCore::MutationObserverOptions::attributes):
(WebCore::MutationObserverOptions::setAttributes):
(WebCore::MutationObserverOptions::characterData):
(WebCore::MutationObserverOptions::setCharacterData):
(WebCore::MutationObserverOptions::subtree):
(WebCore::MutationObserverOptions::setSubtree):
(WebCore::MutationObserverOptions::attributeOldValue):
(WebCore::MutationObserverOptions::setAttributeOldValue):
(WebCore::MutationObserverOptions::characterDataOldValue):
(WebCore::MutationObserverOptions::setCharacterDataOldValue):
(WebCore::MutationObserverOptions::MutationObserverOptions):

  • dom/WebKitMutationObserver.cpp: Added.

(WebCore::WebKitMutationObserver::create):
(WebCore::WebKitMutationObserver::WebKitMutationObserver):
(WebCore::WebKitMutationObserver::~WebKitMutationObserver):
(WebCore::WebKitMutationObserver::observe):
(WebCore::WebKitMutationObserver::disconnect):

  • dom/WebKitMutationObserver.h: Added.
  • dom/WebKitMutationObserver.idl: Added.
  • page/DOMWindow.idl:

Source/WebKit/chromium:

  • features.gypi: Added 'enable_mutation_observers' variable.

LayoutTests:

Add basic tests and skip them in all ports for now.

  • fast/mutation/mutation-observer-constructor-expected.txt: Added.
  • fast/mutation/mutation-observer-constructor.html: Added.
  • fast/mutation/observe-exceptions-expected.txt: Added.
  • fast/mutation/observe-exceptions.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
9:53 AM Changeset in webkit [97158] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] [WK2] NRWT failed to launch MiniBrowser after test run
​https://bugs.webkit.org/show_bug.cgi?id=68016

Patch by Kristóf Kosztyó <​kkristof@inf.u-szeged.hu> on 2011-10-11
Reviewed by Chang Shu.

  • Scripts/webkitpy/layout_tests/port/qt.py:
9:48 AM Changeset in webkit [97157] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Need more efficient ways to set inline CSS styles
​https://bugs.webkit.org/show_bug.cgi?id=58157

Patch by Arun Patole <​BMF834@motorola.com> on 2011-10-11
Reviewed by Dimitri Glazkov.

No new tests added as this is just a code optimization.

Code optimization:

-Used CSSPropertyNames, CSSValues and CSSPrimitiveValues instead of Strings.
-Removed displayString(), webkitTransitionString(), opacityString() functions as they will no longer be needed after this change.
-Moved makeOpaque and makeTransparent functionality to MediaControlPanelElement from MediaControlRootElement.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerRateChanged):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlElement::show):
(WebCore::MediaControlElement::hide):
(WebCore::MediaControlPanelElement::MediaControlPanelElement):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):
(WebCore::MediaControlInputElement::show):
(WebCore::MediaControlInputElement::hide):

  • html/shadow/MediaControlElements.h:
  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControlRootElement::makeOpaque):
(WebCore::MediaControlRootElement::makeTransparent):

  • html/shadow/MediaControlRootElement.h:
  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::makeOpaque):
(WebCore::MediaControlRootElementChromium::makeTransparent):

9:43 AM Changeset in webkit [97156] by Dimitri Glazkov
  • 1 copy in branches/components

Created component model branch.

9:41 AM Changeset in webkit [97155] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

[Mac] Should be able to display multi-page PDFs in subframes
​https://bugs.webkit.org/show_bug.cgi?id=69804

Reviewed by Anders Carlsson.

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:
  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::updateScrollbars): Page step should be exactly one page, so that one could step over the document page by page. It certainly shouldn't be a portion of the whole document. (WebKit::BuiltInPDFView::pdfDocumentDidLoad): Moved duplicated code from load callbacks here. (WebKit::BuiltInPDFView::calculateSizes): Calculate document size including gutters, and remember page boxes. (WebKit::BuiltInPDFView::paint): Split into separate functions. (WebKit::BuiltInPDFView::paintBackground): Just paint gray background for the whole dirty rect. (WebKit::BuiltInPDFView::paintContent): Paint pages and shadow under them. This code is still fairly naive, as it doesn't understand annotations or page rotation. Constants for shadows roughly match PDFView, but not quite, since it draws entirely custom shadows. (WebKit::BuiltInPDFView::paintControls): Moved scrollbar and scroll corner painting here. (WebKit::BuiltInPDFView::streamDidFinishLoading): Moved common code into pdfDocumentDidLoad(). (WebKit::BuiltInPDFView::manualStreamDidFinishLoading): Ditto.
9:13 AM Changeset in webkit [97154] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] WebProcess using proxy settings for localhost as well
​https://bugs.webkit.org/show_bug.cgi?id=69611

Patch by Gopal Raghavan <​gopal.1.raghavan@nokia.com> on 2011-10-11
Reviewed by Chang Shu.

Implemented checks in queryProxy to return QNetworkProxy::NoProxy for localhost and 127.0.0.1

  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::EnvHttpProxyFactory::queryProxy):

9:02 AM Changeset in webkit [97153] by commit-queue@webkit.org
  • 11 edits in trunk/Source/JavaScriptCore

Switch RegisterSizedBoolean/dfgConvertJSValueToInt32 return type to size_t
​https://bugs.webkit.org/show_bug.cgi?id=69821

Patch by Gavin Barraclough <​baraclough@apple.com> on 2011-10-11
Reviewed by Filip Pizlo.

Operations returning types Z (int32_t) and B (RegisterSizedBoolean - implemented as an
intptr_t) are indistinguishable on 32-bit Linux, preventing the DFG JIT from building.

dfgConvertJSValueToInt32 would be better returning a value known to be register sized, for
JSVALUE64 (we currently zero-extend in JIT code, potentially introducing an unnecessary
move), so by switching all associated operations to return a size_t we can fix the type
problem on Linux & make it a small tweak that removes an unnecessary instruction.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):

  • comparisons now return a size_t.
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

  • Removed Z_DFGOperation_EJ form.
  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):

  • comparisons now return a size_t.
  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):

  • comparisons now return a size_t.
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
    • Change return types for comparison operations & dfgConvertJSValueToInt32 to size_t, Both need to return values zero extended to fill a register.
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):

  • comparisons now return a size_t.
  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compare):

  • comparisons now return a size_t.
  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compare):

  • comparisons now return a size_t.
7:43 AM Changeset in webkit [97152] by pfeldman@chromium.org
  • 14 edits in trunk/Source/WebCore

Web Inspector: make Extensions component compile.
​https://bugs.webkit.org/show_bug.cgi?id=69833

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/BinarySearch.js:
  • inspector/front-end/ConsoleModel.js:
  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.Network.prototype.addRequestHeaders):
(injectedExtensionAPI.AuditResultImpl.prototype.addResult):
(injectedExtensionAPI.AuditResultNode.prototype.addChild):

  • inspector/front-end/ExtensionAuditCategory.js:
  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionSidebarPane.prototype.setExpression):

  • inspector/front-end/ExtensionRegistryStub.js:
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._postNotification):
(WebInspector.ExtensionServer.prototype._onAddRequestHeaders):
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
(WebInspector.ExtensionServer.prototype._registerExtension):
(WebInspector.ExtensionStatus):

  • inspector/front-end/NetworkLog.js:

(WebInspector.NetworkLog.prototype._onResourceStarted):

  • inspector/front-end/Object.js:

(WebInspector.Object.prototype.dispatchEventToListeners):

  • inspector/front-end/externs.js:

(console.warn):
(console.assert):
(console.error):
():
(AuditResult):
(EventSink):
(ExtensionSidebarPane):
(Panel):
(PanelWithSidebar):
(Request):
(Resource):
(Timeline):

7:04 AM Changeset in webkit [97151] by podivilov@chromium.org
  • 4 edits
    7 adds in trunk

Web Inspector: implement CompilerSourceMappingProvider.
​https://bugs.webkit.org/show_bug.cgi?id=69423

Reviewed by Pavel Feldman.

Source/WebCore:

CompilerSourceMappingProvider implements a cross-domain communication channel for loading source mappings and source files.
Front-end page can't send XHRs to source mapping server directly due to SOP restrictions. Instead, we inject an invisible
iframe that is loaded from source mapping server and use window.postMessage to communicate with it. iframe has a different
origin and thus doesn't have access to front-end window.

Test: http/tests/inspector/compiler-source-mapping-provider.html

  • inspector/front-end/CompilerSourceMappingProvider.js:

(WebInspector.CompilerSourceMappingProvider):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping.frameLoaded.didLoadData):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping.frameLoaded):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceCode):
(WebInspector.CompilerSourceMappingProvider.prototype._sendRequest):
(WebInspector.CompilerSourceMappingProvider.prototype._onMessage):
(WebInspector.CompilerSourceMappingProvider.prototype._cancelRequest):

  • inspector/front-end/inspector.js:

(WebInspector.installSourceMappingForTest):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping-provider-expected.txt: Added.
  • http/tests/inspector/compiler-source-mapping-provider.html: Added.
  • http/tests/inspector/resources/compiler-source-mapping-provider/app-map: Added.
  • http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html: Added.
  • http/tests/inspector/resources/compiler-source-mapping-provider/app.js: Added.

(window.onload):
(handleClick):

  • http/tests/inspector/resources/compiler-source-mapping-provider/foo.js: Added.

(ClickHandler):
(ClickHandler.prototype.handle):

6:30 AM Changeset in webkit [97150] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] DRT: Return the right window count in LayoutTestController.
​https://bugs.webkit.org/show_bug.cgi?id=69764

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-10-11
Reviewed by Antonio Gomes.

Follow-up to r96943: now that we have DumpRenderTreeChrome and
DumpRenderTreeView in the tree, we can correctly count the number of
open windows in DRT.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::windowCount):

6:11 AM Changeset in webkit [97149] by reed@google.com
  • 11 edits in trunk

re-add support for GDI text behind a compile flag
​https://bugs.webkit.org/show_bug.cgi?id=69530

Reviewed by James Robinson.

Source/WebCore:

Reverts back to using GDI for text (when possible)
but keeps skia-text version behind a compile-flag. If/when we can
resolve the outstanding soft-clip and intl-performance bugs with the
skia version, we may change the compile-flag to reenable skia.

Previous change ​http://trac.webkit.org/changeset/94589 removed the GDI code.

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::estimateTextBounds):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):

  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::windowsCanHandleDrawTextShadow):
(WebCore::windowsCanHandleTextDrawing):
(WebCore::windowsCanHandleTextDrawingWithoutShadow):

  • platform/graphics/skia/SkiaFontWin.h:

Source/WebKit/chromium:

  • features.gypi:

LayoutTests:

  • platform/chromium/test_expectations.txt:
5:54 AM Changeset in webkit [97148] by Csaba Osztrogonác
  • 5 edits in trunk

REGRESSION (r96770-r96777): fast/dom/Window/window-properties.html, fast/dom/prototype-inheritance-2.html, fast/js/global-constructors.html failing on SnowLeopard Intel Release (Tests)
​https://bugs.webkit.org/show_bug.cgi?id=69800

Patch by Jer Noble <​jer.noble@apple.com> on 2011-10-11
Reviewed by Csaba Osztrogonác.

Tools:

Enable WEB_AUDIO at runtime.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

LayoutTests:

Rebaseline after r96774.

  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/mac/fast/js/global-constructors-expected.txt:
5:52 AM clutter edited by tomeu.vizoso@collabora.com
(diff)
5:47 AM Changeset in webkit [97147] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] DRT: Make sure IconDatabase is closed before trying to open it again.
​https://bugs.webkit.org/show_bug.cgi?id=69769

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-10-11
Reviewed by Antonio Gomes.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setIconDatabaseEnabled):

5:36 AM clutter edited by tomeu.vizoso@collabora.com
(diff)
5:20 AM Changeset in webkit [97146] by mario@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

[Gtk] Update test expectation after r96712.

Unreviewed gardening.

Patch by Mario Sanchez Prada <​msanchez@igalia.com> on 2011-10-11

  • platform/gtk/svg/clip-path/clip-path-transform-1-expected.png: Added.
  • platform/gtk/svg/clip-path/clip-path-transform-1-expected.txt: Added.
  • platform/gtk/svg/clip-path/clip-path-transform-2-expected.png: Added.
  • platform/gtk/svg/clip-path/clip-path-transform-2-expected.txt: Added.
4:51 AM Changeset in webkit [97145] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-10-11 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, roll chromium revision to pick HTML speech input images update.

  • DEPS:
4:34 AM Changeset in webkit [97144] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

[Gtk] Skip test crashing due to bug 60931.
​https://bugs.webkit.org/show_bug.cgi?id=60931

Unreviewed gardening.

Patch by Mario Sanchez Prada <​msanchez@igalia.com> on 2011-10-11

  • platform/gtk/Skipped: Skipped

http/tests/security/cookies/cookie-theft-with-javascript-doc.html

4:32 AM BuildingQt5OnHarmattan edited by Simon Hausmann
(diff)
4:12 AM Changeset in webkit [97143] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Support multipart responses is not implemented.
​https://bugs.webkit.org/show_bug.cgi?id=47060

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2011-10-11
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
    • Skip multipart tests.
    • Unskip http/tests/misc/timer-vs-loading.htm, because it isn't multipart test and it passes.
4:07 AM Changeset in webkit [97142] by mario@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Gtk] Update test expectation after r96970.

Unreviewed gardening.

Patch by Mario Sanchez Prada <​msanchez@igalia.com> on 2011-10-11

  • platform/gtk/fast/images/color-jpeg-with-color-profile-expected.png: Added.
  • platform/gtk/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
3:49 AM BuildingQt5OnHarmattan edited by Simon Hausmann
(diff)
3:40 AM Changeset in webkit [97141] by mario@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Gtk] Update test expectation after r97103.

Unreviewed gardening.

Patch by Mario Sanchez Prada <​msanchez@igalia.com> on 2011-10-11

  • platform/gtk/plugins/iframe-plugin-bgcolor-expected.png: Added.
  • platform/gtk/plugins/iframe-plugin-bgcolor-expected.txt: Added.
3:35 AM Changeset in webkit [97140] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-10-11 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, mark two accessibility tests as failing on chromium.

  • platform/chromium/test_expectations.txt:
3:30 AM Changeset in webkit [97139] by vestbo@webkit.org
  • 27 edits in trunk

[Qt] Remove all references to QTDIR_build and standalone_package

Qt is now modularized, which means we no longer import WebKit into
the Qt source tree. Instead we use git submodules, and building
QtWebKit as "part of Qt" is really building QtWebKit as from trunk.

To decrease the number of buildsystem configurations we also remove
the standalone_package code-path used when we were providing tarballs
with the derived sources pre-generated.

Reviewed by Simon Hausmann.

3:15 AM Changeset in webkit [97138] by podivilov@chromium.org
  • 13 edits
    3 moves
    16 adds
    10 deletes in trunk/LayoutTests

2011-10-11 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, rebaseline test expectations after r104864 (chromium).

  • platform/chromium-cg-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-cg-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-cg-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-cg-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png: Added.
  • platform/chromium-cg-mac/fast/speech/input-appearance-numberandspeech-expected.png: Removed.
  • platform/chromium-cg-mac/fast/speech/input-appearance-searchandspeech-expected.png: Removed.
  • platform/chromium-cg-mac/fast/speech/input-appearance-speechbutton-expected.png: Removed.
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-linux/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png: Added.
  • platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png: Added.
  • platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png: Added.
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png: Removed.
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt: Removed.
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png: Removed.
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt: Removed.
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png: Removed.
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt: Removed.
  • platform/chromium-mac/fast/speech/speech-bidi-rendering-expected.png: Removed.
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-win/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium/fast/speech/input-appearance-numberandspeech-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/speech/input-appearance-numberandspeech-expected.txt.
  • platform/chromium/fast/speech/input-appearance-searchandspeech-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/speech/input-appearance-searchandspeech-expected.txt.
  • platform/chromium/fast/speech/input-appearance-speechbutton-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/speech/input-appearance-speechbutton-expected.txt.
2:31 AM Changeset in webkit [97137] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

Shrink WebCore::Node on 64-bit.
​https://bugs.webkit.org/show_bug.cgi?id=69768

Reviewed by Antti Koivisto.

Rearrange TreeShared and Node members so that the node flags fall
into the padding at the end of TreeShared on 64-bit, reducing the
size of Node (and all subclasses) by 8 bytes.

  • dom/Document.h:

(WebCore::Node::Node):

  • dom/Node.h:
  • platform/TreeShared.h:

(WebCore::TreeShared::TreeShared):

2:30 AM Changeset in webkit [97136] by mario@webkit.org
  • 1 edit
    8 adds in trunk/LayoutTests

[Gtk] Update test expectations after r96987, r97088 and r97114.

Unreviewed gardening.

Patch by Mario Sanchez Prada <​msanchez@igalia.com> on 2011-10-11

  • platform/gtk/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
  • platform/gtk/fast/css-generated-content/table-parts-before-and-after-expected.txt: Added.
  • platform/gtk/fast/css/text-transform-select-expected.png: Added.
  • platform/gtk/fast/css/text-transform-select-expected.txt: Added.
  • platform/gtk/fullscreen/full-screen-render-inline-expected.png: Added.
  • platform/gtk/fullscreen/full-screen-render-inline-expected.txt: Added.
  • platform/gtk/fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
  • platform/gtk/fullscreen/parent-flow-inline-with-block-child-expected.txt: Added.
1:45 AM Changeset in webkit [97135] by tkent@chromium.org
  • 6 edits in trunk/Source/WebCore

Move m_listItems and m_recalcListItems from SelectElementData to HTMLSelectElement
​https://bugs.webkit.org/show_bug.cgi?id=69812

Reviewed by Ryosuke Niwa.

Move SelectElementData::m_recalcListItems,
SelectElementData::m_listItems, and related functions of
SelectElementData class to HTMLSelectElement.

Non-const listItems() was removed because it is used only in
recalcListItemsInternal() and it can access m_listItems diretly.

Static recalcListItems() is changed to non-static, and renamed to
recalcListItemsInternal() in order to avoid confusion with the
existing recalcListItems().

No new tests, just a refactoring.

  • dom/SelectElement.cpp:

Move checkListItems() and listItems() to HTMLSelectElement.
(WebCore::SelectElementData::SelectElementData):
Remove Initialization of m_recalcListItems.

  • dom/SelectElement.h:

Move m_recalcListItems, m_listItems, and related functions to HTMLSelectElement.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::HTMLSelectElement):
Initializes m_recalcListItems.
(WebCore::HTMLSelectElement::recalcListItems):
Rename the static recalcListItems() to recalcListItemsInternal().
(WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
Use m_recalcListItems directly.
(WebCore::HTMLSelectElement::nextSelectableListIndex):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::previousSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::firstSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::lastSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): ditto.
(WebCore::HTMLSelectElement::saveLastSelection): ditto.
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto.
(WebCore::HTMLSelectElement::updateListBoxSelection): ditto.
(WebCore::HTMLSelectElement::listBoxOnChange): ditto.
(WebCore::HTMLSelectElement::checkListItems):
Moved from SelectElementData.
(WebCore::HTMLSelectElement::listItems): ditto.
(WebCore::HTMLSelectElement::setRecalcListItems):
Use m_recalcListItems directly.
(WebCore::HTMLSelectElement::recalcListItemsInternal):

  • Make this non-static.
  • Renamed from recalcListItems() to avoid confilct with another recalcListItems().
  • Use m_recalcListItems and m_listItems directly.

(WebCore::HTMLSelectElement::selectedIndex):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::setSelectedIndexInternal): ditto.
(WebCore::HTMLSelectElement::optionToListIndex): ditto.
(WebCore::HTMLSelectElement::listToOptionIndex): ditto.
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation): ditto.
(WebCore::HTMLSelectElement::saveFormControlState):
Update callsites of listItems() and recalcListItems().
(WebCore::HTMLSelectElement::restoreFormControlState):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::appendFormData): ditto.
(WebCore::HTMLSelectElement::reset): ditto.
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::updateSelectedState): ditto.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::lastSelectedListIndex): ditto.
(WebCore::HTMLSelectElement::typeAheadFind): ditto.
(WebCore::HTMLSelectElement::insertedIntoTree):
Update a recalcListItems() callsite.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::length): ditto.

  • html/HTMLSelectElement.h:

Move m_recalcListItems, m_listItems, and related functions from SelectElementData.

  • html/HTMLSelectElementWin.cpp:

(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
Update a listItems() callsite.

1:44 AM Changeset in webkit [97134] by dmazzoni@google.com
  • 2 edits in trunk/LayoutTests

Update Chromium text_expectations to skip mac- and win-specific accessibility
tests. Unreviewed.

1:38 AM Changeset in webkit [97133] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Complex script code path breaks on Windows XP when a CFF font is used
​https://bugs.webkit.org/show_bug.cgi?id=69497

Reviewed by Kent Tamura.

Don't use CFF webfonts when ScriptShape() can't handle it.
ScriptShape() indicates us the case by setting fNoGlyphIndex to TRUE.
If it's TRUE, we don't use the font. This could happen with early
version of Uniscribe on WinXP.

No new tests because the version of Uniscribe depends on environment.
One can install newer version of Uniscribe on WinXP.

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::canUseGlyphIndex): Added.
(WebCore::UniscribeHelper::shape): Don't use the shape result when canUseGlyphIndex() returns false.

1:28 AM Changeset in webkit [97132] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix crash with toDataURL to JPEG
​https://bugs.webkit.org/show_bug.cgi?id=69681

Patch by John Bauman <​jbauman@chromium.org> on 2011-10-11
Reviewed by Kenneth Russell.

Move RefPtr declaration outside if to make sure image data still
exists through CGImageToDataURL.

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::toDataURL):

12:54 AM Changeset in webkit [97131] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Expose WebLayer::isNull
​https://bugs.webkit.org/show_bug.cgi?id=69813

Patch by Antoine Labour <​piman@chromium.org> on 2011-10-11
Reviewed by Darin Fisher.

  • public/WebLayer.h:

(WebKit::WebLayer::isNull):

12:50 AM Changeset in webkit [97130] by reni@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Update test expectation after r97109.

Unreviewed gardening.

Patch by Oliver Varga <​voliver@inf.u-szeged.hu> on 2011-10-11

  • platform/qt/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
  • platform/qt/fast/css-generated-content/table-parts-before-and-after-expected.txt: Added.
12:40 AM Changeset in webkit [97129] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Add missing copyright notice in DFG JIT files
​https://bugs.webkit.org/show_bug.cgi?id=69809

Patch by Yuqiang Xian <​yuqiang.xian@intel.com> on 2011-10-11
Reviewed by Gavin Barraclough.

  • dfg/DFGJITCodeGenerator32_64.cpp:
  • dfg/DFGJITCompiler32_64.cpp:
  • dfg/DFGJITCompilerInlineMethods.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:
12:28 AM Changeset in webkit [97128] by dmazzoni@google.com
  • 12 edits
    4 adds in trunk

Tools: Update Chromium accessibility support in DRT.
​https://bugs.webkit.org/show_bug.cgi?id=69676

Reviewed by Chris Fleizach.

Adds several missing properties and methods to enable more
tests to pass, and in particular adds support for notification
callbacks.

  • DumpRenderTree/chromium/AccessibilityController.cpp:

(AccessibilityController::AccessibilityController):
(AccessibilityController::reset):
(AccessibilityController::getFocusedElement):
(AccessibilityController::shouldLogAccessibilityEvents):
(AccessibilityController::notificationReceived):
(AccessibilityController::logAccessibilityEventsCallback):

  • DumpRenderTree/chromium/AccessibilityController.h:
  • DumpRenderTree/chromium/AccessibilityUIElement.cpp:

(getHelpText):
(getStringValue):
(getOrientation):
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElement::isEqual):
(AccessibilityUIElement::notificationReceived):
(AccessibilityUIElement::roleGetterCallback):
(AccessibilityUIElement::titleGetterCallback):
(AccessibilityUIElement::descriptionGetterCallback):
(AccessibilityUIElement::helpTextGetterCallback):
(AccessibilityUIElement::stringValueGetterCallback):
(AccessibilityUIElement::xGetterCallback):
(AccessibilityUIElement::yGetterCallback):
(AccessibilityUIElement::widthGetterCallback):
(AccessibilityUIElement::heightGetterCallback):
(AccessibilityUIElement::intValueGetterCallback):
(AccessibilityUIElement::minValueGetterCallback):
(AccessibilityUIElement::maxValueGetterCallback):
(AccessibilityUIElement::childrenCountGetterCallback):
(AccessibilityUIElement::insertionPointLineNumberGetterCallback):
(AccessibilityUIElement::selectedTextRangeGetterCallback):
(AccessibilityUIElement::isEnabledGetterCallback):
(AccessibilityUIElement::isRequiredGetterCallback):
(AccessibilityUIElement::isFocusedGetterCallback):
(AccessibilityUIElement::isFocusableGetterCallback):
(AccessibilityUIElement::isSelectedGetterCallback):
(AccessibilityUIElement::isSelectableGetterCallback):
(AccessibilityUIElement::isMultiSelectableGetterCallback):
(AccessibilityUIElement::isExpandedGetterCallback):
(AccessibilityUIElement::isCheckedGetterCallback):
(AccessibilityUIElement::isVisibleGetterCallback):
(AccessibilityUIElement::isOffScreenGetterCallback):
(AccessibilityUIElement::isCollapsedGetterCallback):
(AccessibilityUIElement::hasPopupGetterCallback):
(AccessibilityUIElement::isValidGetterCallback):
(AccessibilityUIElement::orientationGetterCallback):
(AccessibilityUIElement::showMenuCallback):
(AccessibilityUIElement::pressCallback):
(AccessibilityUIElement::isEqualCallback):
(AccessibilityUIElement::addNotificationListenerCallback):
(AccessibilityUIElement::removeNotificationListenerCallback):
(AccessibilityUIElement::takeFocusCallback):
(AccessibilityUIElement::fallbackCallback):
(RootAccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElementList::getOrCreate):

  • DumpRenderTree/chromium/AccessibilityUIElement.h:
  • DumpRenderTree/chromium/CppVariant.cpp:

(CppVariant::invokeDefault):

  • DumpRenderTree/chromium/CppVariant.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::reset):

  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::postAccessibilityNotification):

LayoutTests: Enable accessibility tests on chromium and update test expectations.
​https://bugs.webkit.org/show_bug.cgi?id=69676

Reviewed by Chris Fleizach.

  • platform/chromium/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Added.
  • platform/chromium/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
  • platform/chromium/accessibility/div-within-anchors-causes-crash-expected.txt: Added.
  • platform/chromium/accessibility/platform-name-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
12:00 AM Changeset in webkit [97127] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

Update test results.

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::V8TestInterface::existingWrapper):
(WebCore::V8TestInterface::wrap):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::V8TestMediaQueryListListener::existingWrapper):
(WebCore::V8TestMediaQueryListListener::wrap):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjInternal::cachedAttribute1AttrGetter):
(WebCore::TestObjInternal::cachedAttribute2AttrGetter):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore::V8TestObj::existingWrapper):
(WebCore::V8TestObj::wrap):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::V8TestSerializedScriptValueInterface::existingWrapper):
(WebCore::V8TestSerializedScriptValueInterface::wrap):

Note: See TracTimeline for information about the timeline view.