Context Navigation

← Previous Period
Next Period →

Timeline

Oct 15, 2011:

10:59 PM Changeset in webkit [97573] by abarth@webkit.org

9 edits in trunk/Source

Rename ENABLE(SKIA_TEXT) to USE(SKIA_TEXT)
https://bugs.webkit.org/show_bug.cgi?id=70191

Reviewed by Daniel Bates.

Source/WebCore:

SKIA_TEXT is not a WebKit feature. It's a macro that determines
whether we use a feature of the underly library (Skia).

platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::drawComplexText):

platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):

platform/graphics/skia/PlatformContextSkia.h:
platform/graphics/skia/SkiaFontWin.cpp:
platform/graphics/skia/SkiaFontWin.h:

Source/WebKit/chromium:

features.gypi:

10:00 PM Changeset in webkit [97572] by eric.carlson@apple.com

6 edits in trunk/Source/WebCore

2011-10-15 Eric Carlson <eric.carlson@apple.com>

Make VIDEO_TRACK compile with warnings as errors enabled
https://bugs.webkit.org/show_bug.cgi?id=70188

Reviewed by Filip Pizlo.

No new tests, no functionality changed.

html/TextTrackCueList.h: Fix an include.
html/track/CueParser.cpp: (WebCore::CueParser::supportsType): Remove unused param.
html/track/CueParser.h: (WebCore::CueParserClient::~CueParserClient): Add virtual destructor.
html/track/CueParserPrivate.h: (WebCore::CueParserPrivateClient::~CueParserPrivateClient): Ditto.
loader/CueLoader.h: (WebCore::CueLoaderClient::~CueLoaderClient): Ditto. (WebCore::CueLoader::~CueLoader): Ditto.

9:35 PM Changeset in webkit [97571] by abarth@webkit.org

58 edits in trunk

Rename ENABLE(TILED_BACKING_STORE) to USE(TILED_BACKING_STORE)
https://bugs.webkit.org/show_bug.cgi?id=70194

Reviewed by Daniel Bates.

Source/WebCore:

TILED_BACKING_STORE isn't a web platform feature. It's an
implementation strategy for WebKit that's used by some ports
and not by others.

features.pri:
loader/EmptyClients.h:
page/Chrome.cpp:
page/Chrome.h:
page/ChromeClient.h:
page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::setView):

page/Frame.h:
page/FrameView.cpp:

(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::doDeferredRepaints):

page/Settings.cpp:

(WebCore::Settings::setTiledBackingStoreEnabled):

platform/HostWindow.h:
platform/ScrollView.cpp:

(WebCore::ScrollView::setScrollPosition):

platform/graphics/Tile.h:
platform/graphics/TiledBackingStore.cpp:
platform/graphics/TiledBackingStore.h:
platform/graphics/TiledBackingStoreBackend.h:
platform/graphics/TiledBackingStoreClient.h:
platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
(WebCore::GraphicsLayerQtImpl::~GraphicsLayerQtImpl):
(WebCore::GraphicsLayerQtImpl::recache):
(WebCore::GraphicsLayerQtImpl::paint):

platform/graphics/qt/TileQt.cpp:
platform/graphics/qt/TileQt.h:
platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::computeTiles):
(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::paintSelf):
(WebCore::TextureMapperNode::syncCompositingStateSelf):

platform/graphics/texmap/TextureMapperNode.h:

(WebCore::TextureMapperNode::State::State):

Source/WebKit/qt:

Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::_q_scaleChanged):
(QGraphicsWebView::QGraphicsWebView):
(QGraphicsWebView::paint):
(QGraphicsWebView::isTiledBackingStoreFrozen):
(QGraphicsWebView::setTiledBackingStoreFrozen):

Api/qwebframe.cpp:
Api/qwebframe_p.h:
Api/qwebpage.cpp:

(QWebPagePrivate::dynamicPropertyChangeEvent):

Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::invalidateWindow):

WebCoreSupport/ChromeClientQt.h:
WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQGraphicsWidget::createOrDeleteOverlay):

WebCoreSupport/PageClientQt.h:
tests/qgraphicswebview/tst_qgraphicswebview.cpp:

Source/WebKit2:

Shared/DrawingAreaInfo.h:
UIProcess/DrawingAreaProxy.h:
UIProcess/DrawingAreaProxy.messages.in:
UIProcess/PageClient.h:
UIProcess/TiledDrawingAreaProxy.cpp:
UIProcess/TiledDrawingAreaProxy.h:
UIProcess/WebPageProxy.cpp:
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):

WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create):

WebProcess/WebPage/DrawingArea.h:
WebProcess/WebPage/DrawingArea.messages.in:
WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:
WebProcess/WebPage/TiledBackingStoreRemoteTile.h:
WebProcess/WebPage/TiledDrawingArea.cpp:
WebProcess/WebPage/TiledDrawingArea.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setSize):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Tools:

Scripts/build-webkit:

9:19 PM Changeset in webkit [97570] by abarth@webkit.org

2 edits in trunk/Source/WebKit/chromium

Remove unused ENABLE(SKIA_GPU)
https://bugs.webkit.org/show_bug.cgi?id=70192

Reviewed by Daniel Bates.

There do not appear to be any references to this macro.

features.gypi:

8:33 PM Changeset in webkit [97569] by abarth@webkit.org

2 edits in trunk/Source/WebCore

Remove the last remnant of WBXML
https://bugs.webkit.org/show_bug.cgi?id=70187

Reviewed by Daniel Bates.

The bulk of the WBXML code was removed in 2009, but we missed one block.

platform/wince/MIMETypeRegistryWinCE.cpp:

(WebCore::initMIMETypeEntensionMap):

5:54 PM Changeset in webkit [97568] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

The s390 and s390x architectures both use 64-bit double type
that conforms to the IEEE-754 standard.

https://bugs.webkit.org/show_bug.cgi?id=69940

Patch by Dan Horák <dan@danny.cz> on 2011-10-15
Reviewed by Gavin Barraclough.

wtf/dtoa/utils.h:

5:18 PM Changeset in webkit [97567] by ojan@chromium.org

2 edits in trunk/Tools

run-webkit-tests should accept --child-processes
https://bugs.webkit.org/show_bug.cgi?id=69713

Reviewed by Adam Barth.

Only set --child-processes=1 if --child-processes it not
passed on the commandline.

Scripts/run-webkit-tests:

4:46 PM Changeset in webkit [97566] by arv@chromium.org

1055 edits in trunk/LayoutTests

JS Test Harness: Make console and description elements optional in the HTML
https://bugs.webkit.org/show_bug.cgi?id=69881

Reviewed by Darin Adler.

This makes the description element and the console element in the HTML files
optional and these gets created as needed by the call to description() and debug().

This removes the description and console elements from a lots of files in LayoutTests/fast/

fast/js/resources/js-test-pre.js:

3:47 PM Changeset in webkit [97565] by Darin Adler

3 edits in trunk/Source/WebCore

REGRESSION(r97533): fast/forms/select-script-onchange.html failed after
https://bugs.webkit.org/show_bug.cgi?id=70173

Reviewed by Ryosuke Niwa.

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setValue): Removed unneeded boolean argument
[true for deselect].
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Added explicit
boolean arguments for all calls to setSelectedIndex to restore pre-r97533
behavior.
(WebCore::HTMLSelectElement::typeAheadFind): Ditto.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Ditto.

html/HTMLSelectElement.h:

Removed default of true for userDrivenChange. Each caller should pass it
explicitly. Longer term we should use an enum instead of a boolean or find
some other way of avoiding the argument.
(WebCore::HTMLSelectElement::setSelectedIndex):
Pass false for userDrivenChange as the old code did pre-r97533.

2:44 PM Changeset in webkit [97564] by fpizlo@apple.com

6 edits in trunk/Source/JavaScriptCore

FunctionExecutable should expose the ability to create unattached FunctionCodeBlocks
https://bugs.webkit.org/show_bug.cgi?id=70157

Reviewed by Geoff Garen.

Added FunctionExecutable::produceCodeBlockFor() and rewired compileForCallInternal()
and compileForConstructInternal() to use this method. This required more cleanly
exposing some of CodeBlock's tiering functionality and moving the CompilationKind
enum to Executable.h, as this was the easiest way to make it available to the
declarations/definitions of CodeBlock, FunctionExecutable, and BytecodeGenerator.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::copyDataFrom):
(JSC::CodeBlock::copyDataFromAlternative):

bytecode/CodeBlock.h:

(JSC::CodeBlock::setAlternative):

bytecompiler/BytecodeGenerator.h:
runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

runtime/Executable.h:

(JSC::FunctionExecutable::codeBlockFor):

12:35 PM Changeset in webkit [97563] by scheib@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Populate WebMouseEvent movementX/Y on Mac
https://bugs.webkit.org/show_bug.cgi?id=70167

Reviewed by Adam Barth.

src/mac/WebInputEventFactory.mm:

(WebKit::setWebEventLocationFromEventInView):

12:34 PM Changeset in webkit [97562] by dbates@webkit.org

3 edits
1 delete in trunk/Tools

Extract common gdb code into its own function; Remove script gdb-safari
https://bugs.webkit.org/show_bug.cgi?id=68499

Reviewed by David Kilzer.

Almost identical code is used in webkitdirs::{debugMiniBrowser, debugWebKitTestRunner,
runSafari}() and in the script gdb-safari to launch gdb to debug an application.
We should extract the common parts into a function that can be shared by all callers
so as to remove duplicate code.

As a side effect of removing duplicate code we can remove the script gdb-safari since
its code has been incorporated into webkitdirs::debugSafari() which is called by the
script debug-safari.

Scripts/debug-safari: Modified to call webkitdirs::debugSafari().
Scripts/gdb-safari: Removed.
Scripts/webkitdirs.pm:

(execMacWebKitAppForDebugging): Added; Extracted common debugging code from
debugMiniBrowser(), debugWebKitTestRunner(), runSafari() and
script gdb-safari to here.
(debugSafari): Added.
(runSafari): Extracted debugging code to debugSafari() and debugMacWebKitApp();
Also, return the exit status of WebKit launcher (WebKit.exe) on Windows. Currently,
runSafari() always returns 1 on Windows and the script run-safari exits using this
value as its exit status. Hence, the script run-safari always exits with a nonzero
exit status (i.e. abnormal termination) on Windows. Instead, we should return the
exit status of the WebKit launcher application.
(debugMiniBrowser): Modified to call debugMacWebKitApp().
(debugWebKitTestRunner): Ditto.

12:14 PM Changeset in webkit [97561] by robert@webkit.org

3 edits
1 add in trunk/Tools

[webkit-patch] Put Source/Tools changes at the top of patches, LayoutTests at the bottom
https://bugs.webkit.org/show_bug.cgi?id=70056

Reviewed by Adam Barth.

The preferred file-order for patches is LayoutTests at the end and
ChangeLogs before everything else in a subdirectory. Specify this in a git 'orderfile' and use
it when creating patches for review and landing.

Scripts/webkitpy/common/checkout/scm/git.py:
Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
Scripts/webkitpy/common/config/orderfile: Added.

9:17 AM Changeset in webkit [97560] by commit-queue@webkit.org

25 edits
5 deletes in trunk/Source/WebKit2

Unreviewed, rolling out r97559.
http://trac.webkit.org/changeset/97559
https://bugs.webkit.org/show_bug.cgi?id=70176

Broke build on Mac (Requested by noamr_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-15

DerivedSources.pro:
Platform/CoreIPC/MessageID.h:
Scripts/webkit2/messages.py:
Shared/LayerTreeContext.h:
Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):

Shared/WebLayerTreeInfo.h:
Shared/qt/LayerTreeContextQt.cpp:

(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::~LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
(WebKit::LayerTreeContext::isEmpty):
(WebKit::operator==):

UIProcess/DrawingAreaProxy.cpp:
UIProcess/DrawingAreaProxy.h:
UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):

UIProcess/DrawingAreaProxyImpl.h:
UIProcess/LayerTreeHostProxy.h: Removed.
UIProcess/LayerTreeHostProxy.messages.in: Removed.
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):

UIProcess/qt/LayerTreeHostProxyQt.cpp: Removed.
WebKit2.pro:
WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::deletedLayerIDs):
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):
(WebCore::WebGraphicsLayer::setContentsRect):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setNeedsDisplay):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):
(WebCore::WebGraphicsLayer::didSynchronize):
(WebCore::WebGraphicsLayer::layerInfo):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::WebGraphicsLayer::needsDisplayRect):
(WebCore::WebGraphicsLayer::takeLayersToDelete):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::divideIntoTiles):
(WebCore::collectCompositingInfoForThisLayer):
(WebCore::collectCompositingInfoRecursively):
(WebCore::WebGraphicsLayer::sendLayersToUIProcess):

WebProcess/WebCoreSupport/WebGraphicsLayer.h:
WebProcess/WebPage/DrawingArea.h:
WebProcess/WebPage/DrawingAreaImpl.cpp:
WebProcess/WebPage/DrawingAreaImpl.h:
WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):

WebProcess/WebPage/LayerTreeHost.h:
WebProcess/WebPage/LayerTreeHost.messages.in: Removed.
WebProcess/WebPage/TiledDrawingArea.cpp:
WebProcess/WebPage/TiledDrawingArea.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage):

WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
WebProcess/WebPage/qt/LayerTreeHostQt.h: Removed.

9:01 AM Changeset in webkit [97559] by noam.rosenthal@nokia.com

25 edits
5 adds in trunk/Source/WebKit2

[Qt][WK2] Synchronize tiling with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=69151

Reviewed by Simon Hausmann.

Make the tiled "non-composited" content and the composited layers go through the same
code path on WebKit2. Instead of having a "drawing area" that handles the non-composited
content and a seperate layer tree, we put everything in a layer tree, with the non-
composited content being a layer in the tree.

This allows fixing several issues with websites that have large content areas that are
composited or overlap with composited layers.

Layer-tree synchronization is done by passing WebKit2 messages between a LayerTreeHost
on the WebProcess and a LayerTreeHostProxy on the UI process. Every layer in the tree has
its own tiled backing store, and uses the LayerTreeHost communication channel to pass
content up to the UI process. The UI process will later creates its own GraphicsLayer tree,
based on TextureMapper, which can be painted directly with OpenGL.

Several optimizations are available for the non-composited layer as well, e.g. specifying
a trajectory and updating the visible rect together with the content scale.

This code is currently disabled, a separate patch will enable it and glue it to
QTouchWebPage.

DerivedSources.pro:
Platform/CoreIPC/MessageID.h:
Scripts/webkit2/messages.py:
Shared/LayerTreeContext.h:
Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):

Shared/WebLayerTreeInfo.h:
Shared/qt/LayerTreeContextQt.cpp:

UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::updateWebView):
(WebKit::DrawingAreaProxy::contentsRect):

UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::viewportVisibleRect):
(WebKit::DrawingAreaProxy::isBackingStoreReady):
(WebKit::DrawingAreaProxy::paintToCurrentGLContext):
(WebKit::DrawingAreaProxy::setVisibleContentsRectAndScale):
(WebKit::DrawingAreaProxy::setVisibleContentRectTrajectoryVector):
(WebKit::DrawingAreaProxy::createTileForLayer):
(WebKit::DrawingAreaProxy::updateTileForLayer):
(WebKit::DrawingAreaProxy::removeTileForLayer):
(WebKit::DrawingAreaProxy::didReceiveLayerTreeHostProxyMessage):
(WebKit::DrawingAreaProxy::page):

UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::didReceiveLayerTreeHostProxyMessage):
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRectAndScale):
(WebKit::DrawingAreaProxyImpl::setVisibleContentRectTrajectoryVector):
(WebKit::DrawingAreaProxyImpl::paintToCurrentGLContext):

UIProcess/DrawingAreaProxyImpl.h:
UIProcess/LayerTreeHostProxy.h: Added.

(WebKit::LayerTreeHostProxy::layerByID):
(WebKit::LayerTreeHostProxy::rootLayer):
(WebKit::LayerTreeHostProxy::notifyAnimationStarted):
(WebKit::LayerTreeHostProxy::notifySyncRequired):
(WebKit::LayerTreeHostProxy::showDebugBorders):
(WebKit::LayerTreeHostProxy::showRepaintCounter):
(WebKit::LayerTreeHostProxy::paintContents):

UIProcess/LayerTreeHostProxy.messages.in: Added.
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):

UIProcess/qt/LayerTreeHostProxyQt.cpp: Added.
WebKit2.pro:
WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):
(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setNeedsDisplay):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintBegin):
(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::setRootLayer):
(WebCore::WebGraphicsLayer::setVisibleContentRectTrajectoryVector):
(WebCore::WebGraphicsLayer::setVisibleContentRect):
(WebCore::WebGraphicsLayer::tiledBackingStorePaint):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintEnd):
(WebCore::WebGraphicsLayer::tiledBackingStoreUpdatesAllowed):
(WebCore::WebGraphicsLayer::tiledBackingStoreContentsRect):
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::WebGraphicsLayer::tiledBackingStoreBackgroundColor):
(WebCore::WebGraphicsLayer::createTile):
(WebCore::WebGraphicsLayer::updateTile):
(WebCore::WebGraphicsLayer::removeTile):
(WebCore::WebGraphicsLayer::updateTileBuffersRecursively):
(WebCore::WebGraphicsLayer::layerTreeTileClient):
(WebCore::WebGraphicsLayer::updateContentBuffers):

WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebCore::WebGraphicsLayer::setLayerTreeTileClient):

WebProcess/WebPage/DrawingArea.h:
WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::didReceiveLayerTreeHostMessage):

WebProcess/WebPage/DrawingAreaImpl.h:
WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):

WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::setVisibleContentRectAndScale):
(WebKit::LayerTreeHost::setVisibleContentRectTrajectoryVector):
(WebKit::LayerTreeHost::setVisibleContentRectForLayer):
(WebKit::LayerTreeHost::renderNextFrame):

WebProcess/WebPage/LayerTreeHost.messages.in: Added.
WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::didReceiveLayerTreeHostMessage):

WebProcess/WebPage/TiledDrawingArea.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage):

WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::create):
(WebKit::LayerTreeHostQt::~LayerTreeHostQt):
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::setLayerFlushSchedulingEnabled):
(WebKit::LayerTreeHostQt::scheduleLayerFlush):
(WebKit::LayerTreeHostQt::cancelPendingLayerFlush):
(WebKit::LayerTreeHostQt::setShouldNotifyAfterNextScheduledLayerFlush):
(WebKit::LayerTreeHostQt::setRootCompositingLayer):
(WebKit::LayerTreeHostQt::invalidate):
(WebKit::LayerTreeHostQt::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHostQt::scrollNonCompositedContents):
(WebKit::LayerTreeHostQt::forceRepaint):
(WebKit::LayerTreeHostQt::sizeDidChange):
(WebKit::LayerTreeHostQt::didInstallPageOverlay):
(WebKit::LayerTreeHostQt::didUninstallPageOverlay):
(WebKit::LayerTreeHostQt::setPageOverlayNeedsDisplay):
(WebKit::LayerTreeHostQt::flushPendingLayerChanges):
(WebKit::LayerTreeHostQt::didSyncCompositingStateForLayer):
(WebKit::LayerTreeHostQt::didDeleteLayer):
(WebKit::LayerTreeHostQt::performScheduledLayerFlush):
(WebKit::LayerTreeHostQt::layerFlushTimerFired):
(WebKit::LayerTreeHostQt::createPageOverlayLayer):
(WebKit::LayerTreeHostQt::destroyPageOverlayLayer):
(WebKit::LayerTreeHostQt::adoptImageBackingStore):
(WebKit::LayerTreeHostQt::releaseImageBackingStore):
(WebKit::LayerTreeHostQt::notifyAnimationStarted):
(WebKit::LayerTreeHostQt::notifySyncRequired):
(WebKit::LayerTreeHostQt::paintContents):
(WebKit::LayerTreeHostQt::showDebugBorders):
(WebKit::LayerTreeHostQt::showRepaintCounter):
(WebKit::LayerTreeHost::supportsAcceleratedCompositing):
(WebKit::LayerTreeHostQt::createTile):
(WebKit::LayerTreeHostQt::updateTile):
(WebKit::LayerTreeHostQt::removeTile):
(WebKit::LayerTreeHostQt::setVisibleContentRectForLayer):
(WebKit::LayerTreeHostQt::setVisibleContentRectAndScale):
(WebKit::LayerTreeHostQt::setVisibleContentRectTrajectoryVector):
(WebKit::LayerTreeHostQt::renderNextFrame):
(WebKit::LayerTreeHostQt::layerTreeTileUpdatesAllowed):

8:15 AM Changeset in webkit [97558] by robert@webkit.org

1 edit
1 add in trunk/LayoutTests

Missed mac result from r97555

Unreviewed.

platform/mac/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Added.

6:25 AM Changeset in webkit [97557] by Laszlo Gombos

75 edits
4 deletes in trunk

[Qt] [Symbian] Remove support for the Symbian platform for the QtWebKit port
https://bugs.webkit.org/show_bug.cgi?id=69920
Patch by Laszlo Gombos <Laszlo Gombos> on 2011-10-15
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit.pri:
Source/WebKit.pro:

DumpRenderTree/qt/DumpRenderTree.pro:
DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::open):
DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
QtTestBrowser/QtTestBrowser.pro:
QtTestBrowser/launcherwindow.cpp: (LauncherWindow::screenshot): (LauncherWindow::showFPS): (LauncherWindow::updateFPS):
QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
QtTestBrowser/mainwindow.cpp: (MainWindow::buildUI):
Scripts/webkitpy/style/checker.py: Remove rules for the WebKit/qt/symbian/platformplugin directory.
Scripts/webkitpy/style/checker_unittest.py:
Tools.pro:
WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: (WTR::LayoutTestController::platformInitialize):
WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::isExistingLibrary):
WebKitTestRunner/qt/WebKitTestRunner.pro:

benchmarks/qscriptengine/qscriptengine.pro:

JavaScriptCore.pri:
JavaScriptCore.pro:
heap/MarkStack.h: (JSC::::shrinkAllocation):
jit/ExecutableAllocator.cpp:
jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
jit/JITStubs.cpp:
jsc.pro:
runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString):
runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
runtime/StringPrototype.cpp: (JSC::stringProtoFuncLastIndexOf):
runtime/TimeoutChecker.cpp: (JSC::getCPUTime):
wtf/Assertions.cpp:
wtf/Assertions.h:
wtf/Atomics.h:
wtf/MathExtras.h:
wtf/OSAllocator.h: (WTF::OSAllocator::decommitAndRelease):
wtf/OSAllocatorSymbian.cpp: Removed.
wtf/OSRandomSource.cpp: (WTF::cryptographicallyRandomValuesFromOS):
wtf/PageAllocation.h:
wtf/PageAllocatorSymbian.h: Removed.
wtf/PageBlock.cpp:
wtf/Platform.h:
wtf/StackBounds.cpp:
wtf/wtf.pri:

Api/qgraphicswebview.cpp: (QGraphicsWebView::setPage):
Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
Api/qwebview.cpp: (QWebView::QWebView):
QtWebKit.pro:
WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::populate):
declarative/declarative.pro:
declarative/qdeclarativewebview.cpp: (QDeclarativeWebView::setPage):
symbian: Removed.
symbian/backup_registration.xml: Removed.
symbian/bwins: Removed.
symbian/bwins/QtWebKitu.def: Removed.
symbian/eabi: Removed.
symbian/eabi/QtWebKitu.def: Removed.
symbian/platformplugin: Removed.
symbian/platformplugin/HTML5VideoPlugin.cpp: Removed.
symbian/platformplugin/HTML5VideoPlugin.h: Removed.
symbian/platformplugin/HTML5VideoWidget.cpp: Removed.
symbian/platformplugin/HTML5VideoWidget.h: Removed.
symbian/platformplugin/OverlayWidget.cpp: Removed.
symbian/platformplugin/OverlayWidget.h: Removed.
symbian/platformplugin/PlayerButton.cpp: Removed.
symbian/platformplugin/PlayerButton.h: Removed.
symbian/platformplugin/PlayerLabel.cpp: Removed.
symbian/platformplugin/PlayerLabel.h: Removed.
symbian/platformplugin/WebPlugin.cpp: Removed.
symbian/platformplugin/WebPlugin.h: Removed.
symbian/platformplugin/images: Removed.
symbian/platformplugin/images/button_cannotplay.png: Removed.
symbian/platformplugin/images/button_close.png: Removed.
symbian/platformplugin/images/button_pause.png: Removed.
symbian/platformplugin/images/button_play.png: Removed.
symbian/platformplugin/images/button_sound_off.png: Removed.
symbian/platformplugin/images/button_sound_on.png: Removed.
symbian/platformplugin/images/loading_buffering_1.png: Removed.
symbian/platformplugin/images/loading_buffering_2.png: Removed.
symbian/platformplugin/images/loading_buffering_3.png: Removed.
symbian/platformplugin/images/loading_buffering_4.png: Removed.
symbian/platformplugin/platformplugin.pro: Removed.
symbian/platformplugin/platformplugin.qrc: Removed.
symbian/platformplugin/qss: Removed.
symbian/platformplugin/qss/OverlayWidget.qss: Removed.
symbian/platformplugin/qwebkitplatformplugin.h: Removed.
tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::focusInputTypes):
tests/qwebframe/qwebframe.pro:
tests/qwebframe/tst_qwebframe.cpp:
tests/qwebview/tst_qwebview.cpp: (tst_QWebView::focusInputTypes):
tests/tests.pri:

WebCore.gypi:
WebCore.pri:
WebCore.pro:
bindings/v8/V8GCController.cpp: (WebCore::V8GCController::checkMemoryUsage):
config.h:
css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::operator int):
features.pri:
page/NavigatorBase.cpp:
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
platform/network/qt/ResourceRequestQt.cpp: (WebCore::initializeMaximumHTTPConnectionCountPerHost):
platform/text/qt/TextCodecQt.cpp: (WebCore::TextCodecQt::decode):
plugins/PluginDatabase.cpp:
plugins/PluginPackage.cpp: (WebCore::PluginPackage::unload):
plugins/PluginPackage.h: (WebCore::PluginPackage::version):
plugins/PluginView.cpp: (WebCore::PluginView::setFrameRect):
plugins/PluginView.h:
plugins/npapi.h:
plugins/symbian: Removed.
plugins/symbian/PluginContainerSymbian.cpp: Removed.
plugins/symbian/PluginContainerSymbian.h: Removed.
plugins/symbian/PluginDatabaseSymbian.cpp: Removed.
plugins/symbian/PluginPackageSymbian.cpp: Removed.
plugins/symbian/PluginViewSymbian.cpp: Removed.
plugins/symbian/npinterface.h: Removed.

6:00 AM Changeset in webkit [97556] by robert@webkit.org

1 edit
17 adds in trunk/LayoutTests

Platform-specific results for r97555

Unreviewed.

platform/gtk/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Added.
platform/gtk/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Added.
platform/gtk/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
platform/gtk/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Added.
platform/gtk/css2.1/20110323/height-width-inline-table-001-expected.txt: Added.
platform/gtk/css2.1/20110323/height-width-table-001-expected.txt: Added.
platform/mac/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Added.
platform/mac/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Added.
platform/mac/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
platform/mac/css2.1/20110323/height-width-inline-table-001-expected.txt: Added.
platform/mac/css2.1/20110323/height-width-table-001-expected.txt: Added.
platform/qt/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Added.
platform/qt/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Added.
platform/qt/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
platform/qt/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Added.
platform/qt/css2.1/20110323/height-width-inline-table-001-expected.txt: Added.
platform/qt/css2.1/20110323/height-width-table-001-expected.txt: Added.

4:32 AM Changeset in webkit [97555] by robert@webkit.org

3 edits
33 copies
6 moves
31 adds
8 deletes in trunk

CSS 2.1 failure: height-width-table-001.htm
https://bugs.webkit.org/show_bug.cgi?id=69709

Reviewed by Simon Fraser.

Source/WebCore:

CSS 2.1 expects CSS table elements to treat fixed height/width as
excluding table borders, but HTML table elements to treat fixed height/width as
including them.

See http://lists.w3.org/Archives/Public/www-style/2011Jan/0178.html

http://lists.w3.org/Archives/Public/public-css-testsuite/2011Oct/0005.html

It looks like some clarification is pending in the specs, but the new behaviour
lets WebKit pass the following tests in the suite CSS and also match FF:

height-width-table-001.htm
height-width-inline-table-001.htm
abspos-containing-block-initial-004d.htm

rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::layout):

LayoutTests:

css2.1/20110323/abspos-containing-block-initial-001-ref.htm: Added.
css2.1/20110323/abspos-containing-block-initial-001.htm: Added.
css2.1/20110323/abspos-containing-block-initial-004-ref-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-004-ref-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-004-ref.htm: Added.
css2.1/20110323/abspos-containing-block-initial-004a-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-004a-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-004a.htm: Added.
css2.1/20110323/abspos-containing-block-initial-004b-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-004b-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-004b.htm: Added.
css2.1/20110323/abspos-containing-block-initial-004c-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-004c-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-004c.htm: Added.
css2.1/20110323/abspos-containing-block-initial-004d-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-004d-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-004d.htm: Added.
css2.1/20110323/abspos-containing-block-initial-004d.htm.1: Added.
css2.1/20110323/abspos-containing-block-initial-004e-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-004e-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-004e.htm: Added.
css2.1/20110323/abspos-containing-block-initial-004f-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-004f-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-004f.htm: Added.
css2.1/20110323/abspos-containing-block-initial-005-ref-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-005-ref-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-005-ref.htm: Added.
css2.1/20110323/abspos-containing-block-initial-005a-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-005a-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-005a.htm: Added.
css2.1/20110323/abspos-containing-block-initial-005b-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-005b-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-005b.htm: Added.
css2.1/20110323/abspos-containing-block-initial-005c-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-005c-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-005c.htm: Added.
css2.1/20110323/abspos-containing-block-initial-005d-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-005d-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-005d.htm: Added.
css2.1/20110323/abspos-containing-block-initial-007-ref.htm: Added.
css2.1/20110323/abspos-containing-block-initial-007.htm: Added.
css2.1/20110323/abspos-containing-block-initial-009-ref-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-009-ref-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-009-ref.htm: Added.
css2.1/20110323/abspos-containing-block-initial-009a-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-009a-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-009a.htm: Added.
css2.1/20110323/abspos-containing-block-initial-009b-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-009b-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-009b.htm: Added.
css2.1/20110323/abspos-containing-block-initial-009e-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-009e-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-009e.htm: Added.
css2.1/20110323/abspos-containing-block-initial-009f-expected.png: Added.
css2.1/20110323/abspos-containing-block-initial-009f-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-009f.htm: Added.
css2.1/20110323/height-width-inline-table-001.htm: Added.
css2.1/20110323/height-width-table-001.htm: Added.
platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Added.
platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added
platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Added
platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/height-width-inline-table-001-expected.png: Added.
platform/chromium-linux/css2.1/20110323/height-width-inline-table-001-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/height-width-table-001-expected.png: Added.
platform/chromium-linux/css2.1/20110323/height-width-table-001-expected.txt: Added.
platform/gtk/fast/backgrounds/table-root-expected.txt: Removed.
platform/mac/fast/backgrounds/positioned-root-expected.png: Removed.
platform/mac/fast/backgrounds/table-root-expected.png: Removed.
platform/mac/fast/backgrounds/table-root-expected.txt: Removed.
platform/qt/fast/backgrounds/positioned-root-expected.png: Removed.
platform/qt/fast/backgrounds/positioned-root-expected.txt: Removed.
platform/qt/fast/backgrounds/table-root-expected.png: Removed.
platform/qt/fast/backgrounds/table-root-expected.txt: Removed.

2:37 AM Changeset in webkit [97554] by commit-queue@webkit.org

25 edits
5 deletes in trunk/Source/WebKit2

Unreviewed, rolling out r97549.
http://trac.webkit.org/changeset/97549
https://bugs.webkit.org/show_bug.cgi?id=70174

It broke the SL build (Requested by Ossy_weekend on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-15

DerivedSources.pro:
Platform/CoreIPC/MessageID.h:
Scripts/webkit2/messages.py:
Shared/LayerTreeContext.h:
Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):

Shared/WebLayerTreeInfo.h:
Shared/qt/LayerTreeContextQt.cpp:

UIProcess/DrawingAreaProxy.cpp:
UIProcess/DrawingAreaProxy.h:
UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):

UIProcess/DrawingAreaProxyImpl.h:
UIProcess/LayerTreeHostProxy.h: Removed.
UIProcess/LayerTreeHostProxy.messages.in: Removed.
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):

UIProcess/qt/LayerTreeHostProxyQt.cpp: Removed.
WebKit2.pro:
WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

WebProcess/WebCoreSupport/WebGraphicsLayer.h:
WebProcess/WebPage/DrawingArea.h:
WebProcess/WebPage/DrawingAreaImpl.cpp:
WebProcess/WebPage/DrawingAreaImpl.h:
WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):

WebProcess/WebPage/LayerTreeHost.h:
WebProcess/WebPage/LayerTreeHost.messages.in: Removed.
WebProcess/WebPage/TiledDrawingArea.cpp:
WebProcess/WebPage/TiledDrawingArea.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage):

WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
WebProcess/WebPage/qt/LayerTreeHostQt.h: Removed.

1:28 AM Changeset in webkit [97553] by abarth@webkit.org

2 edits in trunk/Tools

Fix typo in webkitpy help
https://bugs.webkit.org/show_bug.cgi?id=70169

Reviewed by Eric Seidel.

Scripts/webkitpy/tool/commands/upload.py:

12:59 AM Changeset in webkit [97552] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Trivial fix for a missing change in r97512
https://bugs.webkit.org/show_bug.cgi?id=70166

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-15
Reviewed by Gavin Barraclough.

dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::link):

12:59 AM Changeset in webkit [97551] by Darin Adler

10 edits in trunk/Source/WebCore

Make toHTMLElement fail to compile if you try to use it on an HTMLElement*
https://bugs.webkit.org/show_bug.cgi?id=70164

Reviewed by Adam Barth.

Refactoring covered by existing tests.

bindings/js/JSHTMLFrameSetElementCustom.cpp:

(WebCore::JSHTMLFrameSetElement::nameGetter): Removed unneeded casts and
some unneeded local variables as well. Changed the name of the local variable
for the HTMLFrameElement to frameElement to avoid confusion with the Frame.

dom/Document.cpp:

(WebCore::Document::openSearchDescriptionURL): Removed unneeded HTMLElement
check; we can call hasTagName directly on a Node and that takes care of
checking both that it's an HTMLElement and checking the tag name.

dom/MicroDataItemList.cpp:

(WebCore::MicroDataItemList::nodeMatches): Use toHTMLElement instead of
a cast. Also changed hasAttribute calls to fastHasAttribute and getAttribute
calls to fastGetAttribute since these are neither style attributes nor SVG
animatables.

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Use toHTMLElement.
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Ditto.

editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::show): Removed unneeded toHTMLElement call.

html/HTMLElement.cpp:

(WebCore::HTMLElement::setOuterHTML): Use toHTMLElement.

html/HTMLElement.h: Added toHTMLElement overload to catch calls when the

pointer is already HTMLElement* or a pointer to a class derived from it.

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::recalcListItems): Use toHTMLElement.

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::innerTextElement): Use toHTMLElement.

12:44 AM Changeset in webkit [97550] by commit-queue@webkit.org

10 edits
3 copies
1 add in trunk/Source

Add WebAcceleratedContentLayer backed by a texture to support accelerated content hosting
https://bugs.webkit.org/show_bug.cgi?id=70084

Patch by Antoine Labour <piman@chromium.org> on 2011-10-15
Reviewed by James Robinson.

Source/WebCore:

Covered by existing compositing/ tests

platform/graphics/chromium/LayerChromium.h:
platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::pluginLayerProgramFlip):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

platform/graphics/chromium/LayerRendererChromium.h:
platform/graphics/chromium/PluginLayerChromium.cpp:

(WebCore::PluginLayerChromium::PluginLayerChromium):
(WebCore::PluginLayerChromium::setTextureId):
(WebCore::PluginLayerChromium::setFlipped):
(WebCore::PluginLayerChromium::pushPropertiesTo):

platform/graphics/chromium/PluginLayerChromium.h:

(WebCore::PluginLayerChromium::flipped):

platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::CCPluginLayerImpl):
(WebCore::CCPluginLayerImpl::draw):

platform/graphics/chromium/cc/CCPluginLayerImpl.h:

(WebCore::CCPluginLayerImpl::setFlipped):

Source/WebKit/chromium:

WebKit.gyp:
public/WebExternalTextureLayer.h: Added.

(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::~WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::operator=):

src/WebExternalTextureLayer.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCPluginLayerImpl.h.

(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayer::setTextureId):
(WebKit::WebExternalTextureLayer::textureId):
(WebKit::WebExternalTextureLayer::setFlipped):
(WebKit::WebExternalTextureLayer::flipped):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::operator=):
(WebKit::WebExternalTextureLayer::operator PassRefPtr<WebExternalTextureLayerImpl>):

src/WebExternalTextureLayerImpl.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCPluginLayerImpl.h.

(WebKit::WebExternalTextureLayerImpl::create):
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::drawsContent):
(WebKit::WebExternalTextureLayerImpl::paintContents):
(WebKit::WebExternalTextureLayerImpl::notifySyncRequired):

src/WebExternalTextureLayerImpl.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCPluginLayerImpl.h.

12:32 AM Changeset in webkit [97549] by noam.rosenthal@nokia.com

25 edits
5 adds in trunk/Source/WebKit2

[Qt][WK2] Synchronize tiling with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=69151

Reviewed by Simon Hausmann.

This allows fixing several issues with websites that have large content areas that are
composited or overlap with composited layers.

Several optimizations are available for the non-composited layer as well, e.g. specifying
a trajectory and updating the visible rect together with the content scale.

This code is currently disabled, a separate patch will enable it and glue it to
QTouchWebPage.

DerivedSources.pro:
Platform/CoreIPC/MessageID.h:
Scripts/webkit2/messages.py:
Shared/LayerTreeContext.h:
Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):

Shared/WebLayerTreeInfo.h:
Shared/qt/LayerTreeContextQt.cpp:

UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::updateWebView):
(WebKit::DrawingAreaProxy::contentsRect):

UIProcess/DrawingAreaProxy.h:

UIProcess/DrawingAreaProxyImpl.cpp:

UIProcess/DrawingAreaProxyImpl.h:
UIProcess/LayerTreeHostProxy.h: Added.

UIProcess/LayerTreeHostProxy.messages.in: Added.
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):

UIProcess/qt/LayerTreeHostProxyQt.cpp: Added.
WebKit2.pro:
WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebCore::WebGraphicsLayer::setLayerTreeTileClient):

WebProcess/WebPage/DrawingArea.h:
WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::didReceiveLayerTreeHostMessage):

WebProcess/WebPage/DrawingAreaImpl.h:
WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):

WebProcess/WebPage/LayerTreeHost.h:

WebProcess/WebPage/LayerTreeHost.messages.in: Added.
WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::didReceiveLayerTreeHostMessage):

WebProcess/WebPage/TiledDrawingArea.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage):

WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

12:28 AM Changeset in webkit [97548] by tony@chromium.org

2 edits in trunk/Tools

fix another typo in treemap.html
https://bugs.webkit.org/show_bug.cgi?id=70149

Reviewed by Ojan Vafai.

Fixes a bug where #treemapfocus=LayoutTests%2Fhttp didn't focus the http tests.

TestResultServer/static-dashboards/treemap.html:

12:19 AM Changeset in webkit [97547] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

IndexedDB: some string keys not properly stored and retrieved
https://bugs.webkit.org/show_bug.cgi?id=62348

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-15
Reviewed by Tony Chang.

Just adding Mark Pilgrim's test case from bug; this was fixed at some
point, presumably when we moved to LevelDB.

storage/indexeddb/odd-strings-expected.txt: Added.
storage/indexeddb/odd-strings.html: Added.

12:16 AM Changeset in webkit [97546] by Michael Nordman

4 edits in trunk/Source

[Chromium] Some WebSQLDatabase in worker bug fixes.
https://bugs.webkit.org/show_bug.cgi?id=70071

Test for a NULL webView WebWorkerClientImpl.
Avoid altering Database instance lifetimes during WorkerThread::stop().

Source/WebCore:

Existing tests coverage applies.

Reviewed by David Levin.

storage/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::interruptAllDatabasesForContext):

Source/WebKit/chromium:

Reviewed by David Levin.

src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::allowFileSystem):
(WebKit::WebWorkerClientImpl::allowDatabase):

12:08 AM Changeset in webkit [97545] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

[FileSystem API] File readonly attributes test
https://bugs.webkit.org/show_bug.cgi?id=69687

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-10-15
Reviewed by Adam Barth.

fast/filesystem/simple-readonly-file-object-expected.txt: Added.
fast/filesystem/simple-readonly-file-object.html: Added.

12:03 AM Changeset in webkit [97544] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

[File API] URL methods required arguments
https://bugs.webkit.org/show_bug.cgi?id=69692

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-10-15
Reviewed by Adam Barth.

fast/files/url-required-arguments-expected.txt: Added.
fast/files/url-required-arguments.html: Added.

12:02 AM Changeset in webkit [97543] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

[File API] Test how FileReader substitutes illegal UTF-8 characters
https://bugs.webkit.org/show_bug.cgi?id=69691

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-10-14
Reviewed by Adam Barth.

fast/files/file-reader-fffd-expected.txt: Added.
fast/files/file-reader-fffd.html: Added.

Oct 14, 2011:

11:52 PM Changeset in webkit [97542] by commit-queue@webkit.org

1 edit
3 adds in trunk/LayoutTests

[FileSystem API] readonly attributes test
https://bugs.webkit.org/show_bug.cgi?id=69655

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-10-14
Reviewed by Adam Barth.

fast/filesystem/resources/simple-readonly.js: Added.

(setReadonlyProperty):
(errorCallback):
(getFileCallback):
(successCallback):

fast/filesystem/simple-readonly-expected.txt: Added.
fast/filesystem/simple-readonly.html: Added.

11:51 PM Changeset in webkit [97541] by commit-queue@webkit.org

1 edit
3 adds in trunk/LayoutTests

[FileSystem API] restricted Unicode characters in names
https://bugs.webkit.org/show_bug.cgi?id=69657

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-10-14
Reviewed by Adam Barth.

fast/filesystem/op-restricted-unicode-expected.txt: Added.
fast/filesystem/op-restricted-unicode.html: Added.
fast/filesystem/resources/op-restricted-unicode.js: Added.

(testCases.name.precondition.tests):
(testCases):

11:26 PM Changeset in webkit [97540] by abarth@webkit.org

2 edits in trunk/Source/WebCore

Update expected results.

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::serializedValueCallback):

10:45 PM Changeset in webkit [97539] by rniwa@webkit.org

3 edits in trunk/Source/WebCore

GTK build fix after r97533.

accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::notifyChildrenSelectionChange):

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(optionFromSelection):
(webkit_accessible_selection_get_selection_count):

9:37 PM Changeset in webkit [97538] by ddkilzer@apple.com

4 edits in trunk/Source

<http://webkit.org/b/70158> Fix clang compiler warnings

Reviewed by Darin Adler.

Source/WebCore:

dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes): Use std::max<float>()
instead of std::max().

Source/WebKit/mac:

The following two methods in WebDelegateImplementationCaching.h
are ambiguous in WebChromeClient::runJavaScriptPrompt() because
the compiler can't decide how to convert the WTF::String
defaultText argument:

id CallUIDelegate(WebView *, SEL, id, id);
id CallUIDelegate(WebView *, SEL, id, BOOL);

The fix is to perform the conversion explicitly.

WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::runJavaScriptPrompt): Extract a defaultString
variable to convert the WTF::String to an NSString*, then
use defaultString in place of defaultText.

7:00 PM Changeset in webkit [97537] by mhahnenberg@apple.com

102 edits in trunk/Source

Rename getOwnPropertySlot to getOwnPropertySlotVirtual
https://bugs.webkit.org/show_bug.cgi?id=69810

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Renamed the virtual version of getOwnPropertySlot to getOwnPropertySlotVirtual
in preparation for when we add the static getOwnPropertySlot to the MethodTable
in ClassInfo.

Also added a few static getOwnPropertySlot functions where they had been overlooked
before (especially in CodeGeneratorJS.pm).

API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertySlotVirtual):
(JSC::::getOwnPropertySlot):
(JSC::::getOwnPropertyDescriptor):
(JSC::::staticFunctionGetter):

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::getOwnPropertySlotVirtual):
(JSC::DebuggerActivation::getOwnPropertySlot):

debugger/DebuggerActivation.h:
runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertySlotVirtual):
(JSC::Arguments::getOwnPropertySlot):

runtime/Arguments.h:
runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getOwnPropertySlotVirtual):
(JSC::ArrayConstructor::getOwnPropertySlot):

runtime/ArrayConstructor.h:
runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertySlotVirtual):

runtime/ArrayPrototype.h:
runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::getOwnPropertySlotVirtual):

runtime/BooleanPrototype.h:
runtime/DateConstructor.cpp:

(JSC::DateConstructor::getOwnPropertySlotVirtual):

runtime/DateConstructor.h:
runtime/DatePrototype.cpp:

(JSC::DatePrototype::getOwnPropertySlotVirtual):

runtime/DatePrototype.h:
runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::getOwnPropertySlotVirtual):

runtime/ErrorPrototype.h:
runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnPropertySlotVirtual):

runtime/JSActivation.h:
runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertySlotVirtual):
(JSC::JSArray::getOwnPropertySlot):

runtime/JSArray.h:
runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::getOwnPropertySlotVirtual):

runtime/JSBoundFunction.h:
runtime/JSByteArray.cpp:

(JSC::JSByteArray::getOwnPropertySlotVirtual):

runtime/JSByteArray.h:
runtime/JSCell.cpp:

(JSC::JSCell::getOwnPropertySlotVirtual):

runtime/JSCell.h:
runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlotVirtual):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnPropertyNames):
(JSC::JSFunction::put):

runtime/JSFunction.h:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::getOwnPropertySlotVirtual):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::hasOwnPropertyForWrite):

runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::getOwnPropertySlotVirtual):

runtime/JSNotAnObject.h:
runtime/JSONObject.cpp:

(JSC::Stringifier::Holder::appendNextProperty):
(JSC::JSONObject::getOwnPropertySlotVirtual):
(JSC::Walker::walk):

runtime/JSONObject.h:
runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertySlotVirtual):
(JSC::JSObject::getOwnPropertySlot):
(JSC::JSObject::hasOwnProperty):

runtime/JSObject.h:

(JSC::JSObject::getOwnPropertySlotVirtual):
(JSC::JSCell::fastGetOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSValue::get):

runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::getOwnPropertySlotVirtual):

runtime/JSStaticScopeObject.h:
runtime/JSString.cpp:

(JSC::JSString::getOwnPropertySlotVirtual):
(JSC::JSString::getOwnPropertySlot):

runtime/JSString.h:
runtime/Lookup.h:

(JSC::getStaticPropertySlot):
(JSC::getStaticFunctionSlot):
(JSC::getStaticValueSlot):

runtime/MathObject.cpp:

(JSC::MathObject::getOwnPropertySlotVirtual):

runtime/MathObject.h:
runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertySlotVirtual):

runtime/NumberConstructor.h:
runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::getOwnPropertySlotVirtual):

runtime/NumberPrototype.h:
runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getOwnPropertySlotVirtual):

runtime/ObjectConstructor.h:
runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::getOwnPropertySlotVirtual):

runtime/ObjectPrototype.h:
runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getOwnPropertySlotVirtual):

runtime/RegExpConstructor.h:
runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::getOwnPropertySlotVirtual):

runtime/RegExpObject.cpp:

(JSC::RegExpObject::getOwnPropertySlotVirtual):

runtime/RegExpObject.h:
runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::getOwnPropertySlotVirtual):

runtime/RegExpPrototype.h:
runtime/StringConstructor.cpp:

(JSC::StringConstructor::getOwnPropertySlotVirtual):

runtime/StringConstructor.h:
runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertySlotVirtual):

runtime/StringObject.h:
runtime/StringPrototype.cpp:

(JSC::StringPrototype::getOwnPropertySlotVirtual):

runtime/StringPrototype.h:

Source/JavaScriptGlue:

Renamed the virtual version of getOwnPropertySlot to getOwnPropertySlotVirtual
in preparation for when we add the static getOwnPropertySlot to the MethodTable
in ClassInfo.

Also added a few static getOwnPropertySlot functions where they had been overlooked
before (especially in CodeGeneratorJS.pm).

UserObjectImp.cpp:

(UserObjectImp::getOwnPropertySlotVirtual):

UserObjectImp.h:

Source/WebCore:

No new tests.

Renamed the virtual version of getOwnPropertySlot to getOwnPropertySlotVirtual
in preparation for when we add the static getOwnPropertySlot to the MethodTable
in ClassInfo.

Also added a few static getOwnPropertySlot functions where they had been overlooked
before (especially in CodeGeneratorJS.pm).

WebCore.exp.in:
bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlotVirtual):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::DialogHandler::returnValue):

bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::getOwnPropertySlotVirtual):
(WebCore::JSDOMWindowShell::getOwnPropertySlot):

bindings/js/JSDOMWindowShell.h:
bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::getOwnPropertySlotDelegate):

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::getSparseIndex):
(WebCore::CloneSerializer::getProperty):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::getOwnPropertySlotVirtual):
(WebCore::JSTestInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestInterface::getOwnPropertySlotVirtual):
(WebCore::JSTestInterface::getOwnPropertySlot):

bindings/scripts/test/JS/JSTestInterface.h:
bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertySlotVirtual):
(WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertySlotVirtual):
(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListener::getOwnPropertySlotVirtual):
(WebCore::JSTestMediaQueryListListener::getOwnPropertySlot):

bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::getOwnPropertySlotVirtual):
(WebCore::JSTestObjConstructor::getOwnPropertySlot):
(WebCore::JSTestObjPrototype::getOwnPropertySlotVirtual):
(WebCore::JSTestObjPrototype::getOwnPropertySlot):
(WebCore::JSTestObj::getOwnPropertySlotVirtual):
(WebCore::JSTestObj::getOwnPropertySlot):

bindings/scripts/test/JS/JSTestObj.h:
bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertySlotVirtual):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlotVirtual):
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlot):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
bridge/objc/objc_runtime.h:
bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertySlotVirtual):

bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::getOwnPropertySlot):

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertySlotVirtual):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertySlotVirtual):

bridge/qt/qt_runtime.h:
bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertySlotVirtual):

bridge/runtime_array.h:
bridge/runtime_method.cpp:

(JSC::RuntimeMethod::getOwnPropertySlotVirtual):

bridge/runtime_method.h:
bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::getOwnPropertySlotVirtual):

bridge/runtime_object.h:

Source/WebKit2:

Renamed the virtual version of getOwnPropertySlot to getOwnPropertySlotVirtual
in preparation for when we add the static getOwnPropertySlot to the MethodTable
in ClassInfo.

Also added a few static getOwnPropertySlot functions where they had been overlooked
before (especially in CodeGeneratorJS.pm).

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getOwnPropertySlotVirtual):

WebProcess/Plugins/Netscape/JSNPObject.h:

6:25 PM Changeset in webkit [97536] by barraclough@apple.com

65 edits in trunk

Most built-in properties are not deletable
https://bugs.webkit.org/show_bug.cgi?id=61014

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Our static hash tables don't allow for deleting properties.
This is the cause of a bunch of expected failures in LayoutTests/sputnik.

This fixes the problem by reifying all static functions immediately prior
to the first deletion. Reification is tracked by a flag on the structure,
so properties will no longer 'bounce-back' on later access.

Theoretically there could probably also be an issue with custom accessor
properties, but we probably do not really require any of these to be
Configurable anyway. I'll follow up with a separate patch to address this.

runtime/ClassInfo.h:

(JSC::ClassInfo::hasStaticProperties):

detects static property tables.

runtime/JSObject.cpp:

(JSC::JSObject::deleteProperty):

call reifyStaticFunctions before deletion.

(JSC::JSObject::reifyStaticFunctions):

If the class has static functions, set them up now.

runtime/JSObject.h:

(JSC::JSObject::staticFunctionsReified):

returns true if static functions have been reified, and as such should no longer be added.

runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

If static functions have been reified do not add.

runtime/Lookup.h:

(JSC::HashTable::ConstIterator::ConstIterator):
(JSC::HashTable::ConstIterator::operator->):
(JSC::HashTable::ConstIterator::operator*):
(JSC::HashTable::ConstIterator::operator!=):
(JSC::HashTable::ConstIterator::operator++):
(JSC::HashTable::ConstIterator::skipInvalidKeys):
(JSC::HashTable::begin):
(JSC::HashTable::end):
(JSC::getStaticPropertySlot):
(JSC::getStaticPropertyDescriptor):
(JSC::getStaticFunctionSlot):
(JSC::getStaticFunctionDescriptor):

setUpStaticFunctionSlot may not add, returns a bool.

(JSC::lookupPut):

remove redundant branch.

runtime/Structure.cpp:

(JSC::Structure::Structure):

initialize new flag in constructors.

runtime/Structure.h:

(JSC::Structure::staticFunctionsReified):
(JSC::Structure::setStaticFunctionsReified):

added flag

LayoutTests:

Mostly checking in passing results, added a couple of extra test cases to fast/js/delete-syntax.

fast/js/delete-syntax-expected.txt:
fast/js/script-tests/delete-syntax.js:
ietestcenter/Javascript/11.4.1-4.a-10-expected.txt:
sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/S15.4.4_A1.1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/S15.5.4.1_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/S15.5.4_A1-expected.txt:
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/S15.5.4_A3-expected.txt:
sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.2/S15.6.2.1_A4-expected.txt:
sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.3/15.6.3.1_Boolean.prototype/S15.6.3.1_A1-expected.txt:
sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.4/S15.6.4_A1-expected.txt:
sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.2/S15.7.2.1_A4-expected.txt:
sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.3/15.7.3.1_Number.prototype/S15.7.3.1_A2_T1-expected.txt:
sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.4/S15.7.4_A1-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.4/15.9.4.2_Date.parse/S15.9.4.2_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.4/15.9.4.3_Date.UTC/S15.9.4.3_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.10_Date.prototype.getFullYear/S15.9.5.10_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.11_Date.prototype.getUTCFullYear/S15.9.5.11_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.12_Date.prototype.getMonth/S15.9.5.12_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.13_Date.prototype.getUTCMonth/S15.9.5.13_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.14_Date.prototype.getDate/S15.9.5.14_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.15_Date.prototype.getUTCDate/S15.9.5.15_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.16_Date.prototype.getDay/S15.9.5.16_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.17_Date.prototype.getUTCDay/S15.9.5.17_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.18_Date.prototype.getHours/S15.9.5.18_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.19_Date.prototype.getUTCHours/S15.9.5.19_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.20_Date.prototype.getMinutes/S15.9.5.20_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.21_Date.prototype.getUTCMinutes/S15.9.5.21_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.22_Date.prototype.getSeconds/S15.9.5.22_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.23_Date.prototype.getUTCSeconds/S15.9.5.23_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.24_Date.prototype.getMilliseconds/S15.9.5.24_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.25_Date.prototype.getUTCMilliseconds/S15.9.5.25_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.26_Date.prototype.getTimezoneOffset/S15.9.5.26_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.27_Date.prototype.setTime/S15.9.5.27_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.28_Date.prototype.setMilliseconds/S15.9.5.28_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.29_Date.prototype.setUTCMilliseconds/S15.9.5.29_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.2_Date.prototype.toString/S15.9.5.2_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.30_Date.prototype.setSeconds/S15.9.5.30_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.31_Date.prototype.setUTCSeconds/S15.9.5.31_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.32_Date.prototype.setMinutes/S15.9.5.32_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.33_Date.prototype.setUTCMinutes/S15.9.5.33_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.34_Date.prototype.setHours/S15.9.5.34_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.35_Date.prototype.setUTCHours/S15.9.5.35_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.36_Date.prototype.setDate/S15.9.5.36_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.37_Date.prototype.setUTCDate/S15.9.5.37_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.38_Date.prototype.setMonth/S15.9.5.38_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.39_Date.prototype.setUTCMonth/S15.9.5.39_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.3_Date.prototype.toDateString/S15.9.5.3_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.40_Date.prototype.setFullYear/S15.9.5.40_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.41_Date.prototype.setUTCFullYear/S15.9.5.41_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.42_Date.prototype.toUTCString/S15.9.5.42_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.4_Date.prototype.toTimeString/S15.9.5.4_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.5_Date.prototype.toLocaleString/S15.9.5.5_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.6_Date.prototype.toLocaleDateString/S15.9.5.6_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.7_Date.prototype.toLocaleTimeString/S15.9.5.7_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.8_Date.prototype.valueOf/S15.9.5.8_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.9_Date.prototype.getTime/S15.9.5.9_A1_T2-expected.txt:

5:53 PM Changeset in webkit [97535] by Darin Adler

2 edits in trunk/Source/WebKit/chromium

Try to fix Chromium build.

tests/PopupMenuTest.cpp:

(WebKit::TestPopupMenuClient::valueChanged):
Use toHTMLSelectElement instead of toSelectElement.

5:48 PM Changeset in webkit [97534] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Windows build fix attempt after r97533.

html/HTMLSelectElementWin.cpp:

(WebCore::HTMLSelectElement::platformHandleKeydownEvent):

5:30 PM Changeset in webkit [97533] by Darin Adler

16 edits in trunk/Source/WebCore

Follow up the recent HTMLSelectElement improvements with a little bit more
https://bugs.webkit.org/show_bug.cgi?id=70139

Reviewed by Ryosuke Niwa.

Refactoring, covered by existing tests.

Mostly, this adds a toHTMLSelectElement and uses it wherever possible.

accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::canSetSelectedChildrenAttribute): Use toHTMLSelectElement.
(WebCore::AccessibilityListBox::addChildren): Ditto. Also removed unneeded toHTMLElement.

accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::addChildren): Ditto.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isMultiSelectable): Ditto.
(WebCore::AccessibilityRenderObject::stringValue): Removed checks on the type of the
underlying node, since other code already assumes that a menu list renderer is only
created for a select element. Streamlined the code a bit and removed some unneeded
local variables.

bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::indexSetter): Use toHTMLSelectElement.

bindings/js/JSHTMLSelectElementCustom.cpp:

(WebCore::JSHTMLSelectElement::remove): Ditto.
(WebCore::JSHTMLSelectElement::indexSetter): Ditto.

editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectAll): Ditto.

html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::shadowSelect): Ditto.

html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::recalcSelectOptions): Ditto.
(WebCore::HTMLOptGroupElement::ownerSelectElement): Ditto.

html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::selected): Changed code to call renamed
updateListItemSelectedStates rather than the confusing old name
recalcListItemsIfNeeded.
(WebCore::HTMLOptionElement::childrenChanged): Changed to call
optionElementChildrenChanged rather than calling childrenChanged,
because the children of the select element did not change!
(WebCore::HTMLOptionElement::ownerSelectElement): Use toHTMLSelectElement.

html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add): Use toHTMLSelectElement.
(WebCore::HTMLOptionsCollection::remove): Use toHTMLSelectElement.
(WebCore::HTMLOptionsCollection::selectedIndex): Use toHTMLSelectElement.
(WebCore::HTMLOptionsCollection::setSelectedIndex): Use toHTMLSelectElement.
(WebCore::HTMLOptionsCollection::setLength): Use toHTMLSelectElement.

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setSelectedIndexByUser): Call setSelectedIndex
without the now-unneeded internal suffix.
(WebCore::HTMLSelectElement::parseMappedAttribute): When the code says that
we should "determine selectedness of the items", call updateListItemSelectedStates
rather than the confusingly named recalcListItemsIfNeeded.
(WebCore::HTMLSelectElement::updateListItemSelectedStates): Renamed
recalcListItemsIfNeeded to this, since that's what this function is for.
(WebCore::HTMLSelectElement::optionElementChildrenChanged): Added. Does
the same work as childrenChanged, although it does not call up to the
base class childrenChanged function. Later we might find we can remove
some of the work here, for example it's not clear we should call the
accessibility childrenChanged function.
(WebCore::HTMLSelectElement::nextValidIndex): Changed this to a member function
and made it get the list items itself rather than requiring they be passed in.
(WebCore::HTMLSelectElement::nextSelectableListIndex): Updated for change to
nextValidIndex.
(WebCore::HTMLSelectElement::previousSelectableListIndex): Ditto.
(WebCore::HTMLSelectElement::firstSelectableListIndex): Ditto.
(WebCore::HTMLSelectElement::lastSelectableListIndex): Ditto.
(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): Ditto.
(WebCore::HTMLSelectElement::listItems): Removed unneeded const_cast, since
recalcListItems is now a const member function. Call recalcListItems by that
name instead of recalcListItemsInternal.
(WebCore::HTMLSelectElement::recalcListItems): Renamed from recalcListItemsInternal
and made this a const member function. The data members that this needs to modify
are now mutable.
(WebCore::HTMLSelectElement::setSelectedIndex): Renamed from setSelectedIndexInternal.
Changed call to updateValidity to instead call setNeedsValidityCheck, since both
do the same thing.
(WebCore::HTMLSelectElement::parseMultipleAttribute): Ditto.
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Updated for change to
nextValidIndex, removed unneeded comparison with zero that's already handled by
casting to an unsigned type, and use setSelectedIndex instead of using
setSelectedIndexInternal since they are both the same thing.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Removed another unneeded
comparision with zero that's handled by casting to an unsigned type.
(WebCore::HTMLSelectElement::lastSelectedListIndex): Use size_t instead of unsigned
for a vector index.
(WebCore::HTMLSelectElement::typeAheadFind): Use setSelectedIndex instead of
setSelectedIndexInternal.
(WebCore::HTMLSelectElement::insertedIntoTree): Removed unneeded explicit boolean
when calling a function that already has a default value of true.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Use setSelectedIndex
instead of setSelectedIndexInternal.

html/HTMLSelectElement.h: Made childrenChanged private. Added

optionElementChildrenChanged. Renamed recalcListItemsIfNeeded to the clearer
updateListItemSelectedStates. Removed unused listBoxSelectItem. Removed
updateValidity after changing all callers to instead call setNeedsValidityCheck.
Made canSelectAll and selectAll non-virtual. Removed recalcListItemsInternal
since it's the same thing as recalcListItems now. Renamed setSelectedIndexInternal
to setSelectedIndex since it's the same function, just with a few arguments we
don't want to allow outside callers to pass. Changed nextValidIndex into a
non-static member function. Made m_listItems and m_shouldRecalcListItems mutable.
Added a toHTMLSelectElement function, modeled on the toElement function.

html/ValidityState.cpp:

(WebCore::ValidityState::valueMissing): Use toHTMLSelectElement.

rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement): Ditto.
(WebCore::RenderListBox::scrollToRevealSelection): Ditto.
(WebCore::RenderListBox::size): Ditto.
(WebCore::RenderListBox::numItems): Ditto.
(WebCore::RenderListBox::addFocusRingRects): Ditto.
(WebCore::RenderListBox::paintItemForeground): Ditto.
(WebCore::RenderListBox::paintItemBackground): Ditto.
(WebCore::RenderListBox::panScroll): Ditto.
(WebCore::RenderListBox::autoscroll): Ditto.
(WebCore::RenderListBox::stopAutoscroll): Ditto.
(WebCore::RenderListBox::valueChanged): Ditto.
(WebCore::RenderListBox::nodeAtPoint): Ditto.

rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::updateOptionsWidth): Ditto.
(WebCore::RenderMenuList::updateFromElement): Ditto.
(WebCore::RenderMenuList::setTextFromOption): Ditto.
(WebCore::RenderMenuList::showPopup): Ditto.
(WebCore::RenderMenuList::valueChanged): Ditto.
(WebCore::RenderMenuList::listBoxSelectItem): Ditto.
(WebCore::RenderMenuList::multiple): Ditto.
(WebCore::RenderMenuList::didSetSelectedIndex): Ditto.
(WebCore::RenderMenuList::didUpdateActiveOption): Ditto.
(WebCore::RenderMenuList::itemText): Ditto.
(WebCore::RenderMenuList::itemAccessibilityText): Ditto.
(WebCore::RenderMenuList::itemToolTip): Ditto.
(WebCore::RenderMenuList::itemIsEnabled): Ditto. Also use the
disabled function instead of the virtual isEnabledFormControl
function to check if the optgroup is enabled.
(WebCore::RenderMenuList::itemStyle): Ditto.
(WebCore::RenderMenuList::itemBackgroundColor): Ditto.
(WebCore::RenderMenuList::listSize): Ditto.
(WebCore::RenderMenuList::selectedIndex): Ditto.
(WebCore::RenderMenuList::itemIsSeparator): Ditto.
(WebCore::RenderMenuList::itemIsLabel): Ditto.
(WebCore::RenderMenuList::itemIsSelected): Ditto.
(WebCore::RenderMenuList::setTextFromItem): Ditto.

5:04 PM Changeset in webkit [97532] by mhahnenberg@apple.com

84 edits in trunk

Rename virtual put to putVirtual
https://bugs.webkit.org/show_bug.cgi?id=69851

Reviewed by Darin Adler.

Renamed virtual versions of put to putVirtual in prepration for
adding the static put to the MethodTable in ClassInfo since the
compiler gets mad if the virtual and static versions have the same
name.

Source/autotools/symbols.filter:

Source/JavaScriptCore:

API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:

(JSC::::putVirtual):

API/JSObjectRef.cpp:

(JSObjectSetProperty):
(JSObjectSetPropertyAtIndex):

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::putVirtual):
(JSC::DebuggerActivation::put):

debugger/DebuggerActivation.h:
dfg/DFGOperations.cpp:

(JSC::DFG::putByVal):

interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

jsc.cpp:

(GlobalObject::finishCreation):

runtime/Arguments.cpp:

(JSC::Arguments::putVirtual):

runtime/Arguments.h:
runtime/ArrayPrototype.cpp:

(JSC::putProperty):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):

runtime/JSActivation.cpp:

(JSC::JSActivation::putVirtual):

runtime/JSActivation.h:
runtime/JSArray.cpp:

(JSC::JSArray::putVirtual):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::push):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCount):

runtime/JSArray.h:
runtime/JSByteArray.cpp:

(JSC::JSByteArray::putVirtual):

runtime/JSByteArray.h:
runtime/JSCell.cpp:

(JSC::JSCell::putVirtual):
(JSC::JSCell::put):

runtime/JSCell.h:
runtime/JSFunction.cpp:

(JSC::JSFunction::putVirtual):

runtime/JSFunction.h:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::putVirtual):
(JSC::JSGlobalObject::putWithAttributes):

runtime/JSGlobalObject.h:
runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::putVirtual):

runtime/JSNotAnObject.h:
runtime/JSONObject.cpp:

(JSC::Walker::walk):

runtime/JSObject.cpp:

(JSC::JSObject::putVirtual):
(JSC::JSObject::put):
(JSC::JSObject::defineOwnProperty):

runtime/JSObject.h:

(JSC::JSValue::put):

runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::putVirtual):

runtime/JSStaticScopeObject.h:
runtime/Lookup.h:

(JSC::lookupPut):

runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::putVirtual):

runtime/ObjectPrototype.h:
runtime/RegExpConstructor.cpp:

(JSC::RegExpMatchesArray::fillArrayInstance):
(JSC::RegExpConstructor::putVirtual):

runtime/RegExpConstructor.h:
runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::putVirtual):

runtime/RegExpObject.cpp:

(JSC::RegExpObject::putVirtual):

runtime/RegExpObject.h:
runtime/StringObject.cpp:

(JSC::StringObject::putVirtual):

runtime/StringObject.h:
runtime/StringPrototype.cpp:

(JSC::stringProtoFuncSplit):

Source/JavaScriptGlue:

JSValueWrapper.cpp:

(JSValueWrapper::JSObjectSetProperty):

UserObjectImp.cpp:

(UserObjectImp::putVirtual):

UserObjectImp.h:

Source/WebCore:

No new tests.

WebCore.exp.in:
bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::putVirtual):

bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::putVirtual):

bindings/js/JSDOMWindowShell.h:
bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::putDelegate):

bindings/js/JSPluginElementFunctions.cpp:

(WebCore::runtimeObjectCustomPut):

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::putProperty):

bindings/objc/WebScriptObject.mm:

(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject setWebScriptValueAtIndex:value:]):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::putVirtual):

bindings/scripts/test/JS/JSTestObj.h:
bridge/NP_jsobject.cpp:

(_NPN_SetProperty):

bridge/jni/jni_jsobject.mm:

(JavaJSObject::setMember):
(JavaJSObject::setSlot):

bridge/objc/objc_runtime.h:
bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::putVirtual):

bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::put):

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertQVariantToValue):

bridge/runtime_array.cpp:

(JSC::RuntimeArray::putVirtual):

bridge/runtime_array.h:
bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::putVirtual):

bridge/runtime_object.h:
bridge/testqtbindings.cpp:

(main):

Source/WebKit/efl:

ewk/ewk_view.cpp:

(ewk_view_js_object_add):

Source/WebKit/mac:

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::setProperty):

Source/WebKit/qt:

Api/qwebframe.cpp:

(QWebFrame::addToJavaScriptWindowObject):

Source/WebKit2:

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::putVirtual):
(WebKit::JSNPObject::put):

WebProcess/Plugins/Netscape/JSNPObject.h:
WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::setProperty):

4:42 PM Changeset in webkit [97531] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r97519.
http://trac.webkit.org/changeset/97519
https://bugs.webkit.org/show_bug.cgi?id=70156

Broke 79+ tests on bots (Requested by dglazkov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-14

platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):

4:13 PM Changeset in webkit [97530] by levin@chromium.org

4 edits in trunk/Tools

watchlist: Add a validation check for the email names in the list.
https://bugs.webkit.org/show_bug.cgi?id=70154

Reviewed by Adam Barth.

If an email is listed which doesn't have a bugzilla log in, then any emails
added to the bug along with that email will fail to happen, so try to prevent this
from happening by validating that emails added to the watchlist are known to be
contributors.

Scripts/webkitpy/common/config/committers.py: Add my other email aliases for bugzilla.
Scripts/webkitpy/common/watchlist/watchlistparser.py: Add the check.
Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: A unit test for the check.

4:04 PM Changeset in webkit [97529] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Windows rebaseline after r97522.

platform/win/fast/harness/results-expected.txt:

3:56 PM Changeset in webkit [97528] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Update expectations after r97522.

platform/chromium/fast/harness/results-expected.txt: Tweakaged.

3:52 PM Changeset in webkit [97527] by Beth Dakin

1 edit
2 adds
2 deletes in trunk/LayoutTests

These tests results should really be in the mac-specific directory. They were
added earlier today with https://bugs.webkit.org/show_bug.cgi?id=68641

Rubber-stamped by Andy Estes and Jon Honeycutt.

fast/css/clip-text-in-scaled-div-expected.png: Removed.
fast/css/clip-text-in-scaled-div-expected.txt: Removed.
platform/mac/fast/css/clip-text-in-scaled-div-expected.png: Added.
platform/mac/fast/css/clip-text-in-scaled-div-expected.txt: Added.

3:51 PM Changeset in webkit [97526] by Dimitri Glazkov

1 edit
1 delete in trunk/LayoutTests

[Chromium] Remove the duplicelious expectation.

platform/chromium/fast/css/getComputedStyle/computed-style-border-image-expected.txt: Removed.

3:49 PM Changeset in webkit [97525] by robert@webkit.org

5 edits
2 adds in trunk

Replaced elements squeezed when width is specified as percentage inside a table with Auto layout
https://bugs.webkit.org/show_bug.cgi?id=29447

If inserting a 'replaced' element (e.g. image, plugin) in a table cell that is not descendant from
a block with fixed layout then do not squeeze the element, let it use its intrinsic width and height.

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/replaced/table-percent-width.html

rendering/RenderBox.cpp:

(WebCore::shouldExpandToIntrinsicDimension):
(WebCore::RenderBox::containingBlockReplacedLogicalWidthForContent):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):

rendering/RenderBox.h:

LayoutTests:

fast/replaced/table-percent-width-expected.txt: Added.
fast/replaced/table-percent-width.html: Added.
platform/chromium-win/fast/replaced/table-percent-height-expected.txt: Rebaselined

3:45 PM Changeset in webkit [97524] by Simon Fraser

2 edits in trunk/LayoutTests

Fix the bad expected result that I added earlier.

fast/css/getComputedStyle/computed-style-border-image-expected.txt:

3:42 PM Changeset in webkit [97523] by abarth@webkit.org

2 edits in trunk/Tools

Hide status bubbles from queues which are very far behind
https://bugs.webkit.org/show_bug.cgi?id=70133

Reviewed by Eric Seidel.

The mac-ews is so far behind that we shouldn't show its status bubble.
The status bubble just makes contributors sad.

QueueStatusServer/handlers/statusbubble.py:

3:40 PM Changeset in webkit [97522] by rniwa@webkit.org

4 edits in trunk/LayoutTests

nrwt's results.html should show crashed tests before flaky tests
https://bugs.webkit.org/show_bug.cgi?id=66041

Reviewed by Ojan Vafai.

Fixed the over by changing the order in which we aggregate results.

fast/harness/resources/results-test.js: Added a test.
fast/harness/results-expected.txt:
fast/harness/results.html:

3:37 PM Changeset in webkit [97521] by Dimitri Glazkov

3 edits in trunk/Tools

Write unit test to ensure style-checker-filter option is passed properly in webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=70143

Reviewed by Adam Barth.

Scripts/webkitpy/tool/commands/download_unittest.py: Added a test for land-cowboy. Not so cowboy after all.
Scripts/webkitpy/tool/steps/checkstyle.py: Fixed a bug, discovered by the newly added test.

3:35 PM Changeset in webkit [97520] by Dimitri Glazkov

2 edits
2 adds in trunk/LayoutTests

[Chromium] Update expectations after r97502.

platform/chromium/fast/css/getComputedStyle/computed-style-border-image-expected.txt: Added.
platform/chromium/test_expectations.txt:

3:24 PM Changeset in webkit [97519] by caryclark@google.com

2 edits in trunk/Source/WebCore

[Chromium Skia on Mac] Improve focus ring
https://bugs.webkit.org/show_bug.cgi?id=70124

Reviewed by Eric Seidel.

The focus ring code formerly outset the bounds of
the component rectangles by fractional amounts. Because
the rectangles are SkIRect (integer based), the fractional
outset had no effect.

The equivalent code in GraphicsContextMac.mm computes
the curve radius and rectangle outset with integers, so
the use of floats in Skia's case, besides not working,
is unnecessary.

The Skia code also failed to take the offset into account.
In LayoutTests, the focus rings either have an offset of
0 or 2. The CoreGraphics code increases the ring's rectangles
by the offset, then passes the result to wkDrawFocusRing.

I did not find any documentation about how wkDrawFocusRing
further inflates the focus ring, but empirically I determined
that adding 2 to the offset generated rings with identical
outer diameters.

With these adjustments, the layout tests generate focus rings
in the Skia on Mac case that match the coverage of the
Chromium CG-based platform, in particular, matching:

editing/inserting/editable-inline-element.html
editing/selection/3690703-2.html

platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):

3:17 PM Changeset in webkit [97518] by commit-queue@webkit.org

5 edits in trunk

[Qt] Enable fullscreen api on Qt
https://bugs.webkit.org/show_bug.cgi?id=70131

Source/WebCore:

As a result, we have 3 passed tests.

Patch by Chang Shu <cshu@webkit.org> on 2011-10-14
Reviewed by Noam Rosenthal.

features.pri:

LayoutTests:

As a result, we have 3 passed tests.
fullscreen/full-screen-api.html
fullscreen/full-screen-iframe-not-allowed.html
fullscreen/full-screen-remove-ancestor-during-transition.html

Patch by Chang Shu <cshu@webkit.org> on 2011-10-14
Reviewed by Noam Rosenthal.

platform/qt-wk2/Skipped:
platform/qt/Skipped:

3:13 PM Changeset in webkit [97517] by Beth Dakin

2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=70148
Should switch to CoreUI version of CorrectionDot, GrammarDot, and SpellingDot
-and corresponding-
<rdar://problem/10208281>

Reviewed by Anders Carlsson.

Use NS*Dot whenever it's available, and fallback to *Dot only when it is not.

platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::createPatternColor):
(WebCore::GraphicsContext::drawLineForTextChecking):

3:13 PM Changeset in webkit [97516] by dslomov@google.com

13 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=70120
[Chromium] Pass MessagePortArray to SerializedScriptValue::serialize/deserialize.
This patch augments SerializedScriptValue with MessagePortArray* parameter to implement MessagePort
transfer within the message in the future.

Reviewed by David Levin.

Source/WebCore:

bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::deserialize):

bindings/v8/SerializedScriptValue.h:
bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):
(WebCore::V8DOMWindow::postMessageCallback):
(WebCore::V8DOMWindow::webkitPostMessageCallback):

bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::handlePostMessageCallback):
(WebCore::V8DedicatedWorkerContext::postMessageCallback):
(WebCore::V8DedicatedWorkerContext::webkitPostMessageCallback):

bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):

bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::handlePostMessageCallback):
(WebCore::V8MessagePort::postMessageCallback):
(WebCore::V8MessagePort::webkitPostMessageCallback):

bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::handlePostMessageCallback):
(WebCore::V8Worker::postMessageCallback):
(WebCore::V8Worker::webkitPostMessageCallback):

workers/Worker.idl:

Source/WebKit/chromium:

src/WebSerializedScriptValue.cpp:

(WebKit::WebSerializedScriptValue::serialize):

3:11 PM Changeset in webkit [97515] by levin@chromium.org

4 edits in trunk/Tools

watchlist: If the style check fails, then the watchlist will not be run.
https://bugs.webkit.org/show_bug.cgi?id=69484

Reviewed by Adam Barth.

Scripts/webkitpy/tool/commands/queues.py: Run the watch list even

if the style part fails and don't allow watch list failures turn the
bot run red.

Scripts/webkitpy/tool/commands/queues_unittest.py: Appropriate unit tests.
Scripts/webkitpy/tool/mocktool.py: Add support to make an executive command throw.

3:11 PM Changeset in webkit [97514] by jeffm@apple.com

8 edits in trunk/Source

../WebCore: InjectedBundleHitTestResult::imageRect() should return rect in WKView coordinates
https://bugs.webkit.org/show_bug.cgi?id=69963

Add infrastructure to convert from any frame view's coordinate system to the
root view's coordinate system.

Reviewed by Simon Fraser.

No new tests (yet), this is covered by <https://bugs.webkit.org/show_bug.cgi?id=70136>.

WebCore.exp.in: Exported WebCore::ScrollView::contentsToRootView(), used by InjectedBundleHitTestResult.cpp.

platform/ScrollView.cpp:

(WebCore::ScrollView::rootViewToContents): Added (both point and rect versions).
(WebCore::ScrollView::contentsToRootView): Ditto.

platform/ScrollView.h: Added member functions to convert to/from root view coordinates.

platform/Widget.cpp:

(WebCore::Widget::convertFromRootView): Added (both point and rect versions).
(WebCore::Widget::convertToRootView): Ditto.

platform/Widget.h: Added member functions to convert to/from root view coordinates.

../WebKit2: InjectedBundleHitTestResult::imageRect() should return rect in WKView coordinates
https://bugs.webkit.org/show_bug.cgi?id=69963

WebKit2 clients only have knowledge of the WKView's coordinate system, they have no way to
convert from subframe view coordinates , so any rect that we expose through WK2 APIs should
be in WKView coordinates.

Reviewed by Simon Fraser.

WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:

(WebKit::InjectedBundleHitTestResult::imageRect): Use WebCore::FrameView::contentsToRootView() to convert the image rect to WKView coordinates.

3:03 PM Changeset in webkit [97513] by Dimitri Glazkov

2 edits
1 add in trunk/LayoutTests

[Chromium] Update expectations after r97487.

platform/chromium-cg-mac-snowleopard/fast/css/clip-text-in-scaled-div-expected.png: Added.
platform/chromium/test_expectations.txt:

3:01 PM Changeset in webkit [97512] by fpizlo@apple.com

17 edits
1 add in trunk/Source/JavaScriptCore

Reflective Arguments retrieval should be hardened for the
possibility of inlining
https://bugs.webkit.org/show_bug.cgi?id=70068

Reviewed by Oliver Hunt.

CodeBlock can now track, as part of its RareData, the virtual inline
stack at callsites. CallFrame walking can now rematerialize "inline"
CallFrames by combining the meta-data in CodeBlock with the information
already in the JS stack. Arguments can now safely retrieve the
arguments from inline CallFrames.

The DFG already had the notion of a "CodeOrigin" in preparation for
inlining. This notion will now be saved into the CodeBlock, if the DFG
had done inlining. So, CodeOrigin has been moved to bytecode/ and has
been changed to behave more like a struct since that is how it's
meant to be used.

GNUmakefile.list.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/CodeBlock.h:

(JSC::CodeBlock::inlineCallFrames):
(JSC::CodeBlock::codeOrigins):
(JSC::CodeBlock::hasCodeOrigins):
(JSC::CodeBlock::codeOriginForReturn):

bytecode/CodeOrigin.h: Added.

(JSC::CodeOrigin::CodeOrigin):
(JSC::CodeOrigin::isSet):
(JSC::getCallReturnOffsetForCodeOrigin):

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

dfg/DFGNode.h:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

interpreter/CallFrame.cpp:

(JSC::CallFrame::isInlineCallFrame):
(JSC::CallFrame::trueCallerFrame):

interpreter/CallFrame.h:

(JSC::ExecState::inlineCallFrame):
(JSC::ExecState::setInlineCallFrame):
(JSC::ExecState::isInlineCallFrame):
(JSC::ExecState::trueCallerFrame):

interpreter/Interpreter.cpp:

(JSC::Interpreter::findFunctionCallFrame):

interpreter/Register.h:

(JSC::Register::operator=):
(JSC::Register::inlineCallFrame):

runtime/Arguments.h:

(JSC::Arguments::getArgumentsData):
(JSC::Arguments::finishCreationButDontCopyRegisters):
(JSC::Arguments::finishCreation):
(JSC::Arguments::finishCreationAndCopyRegisters):

runtime/Executable.h:

(JSC::FunctionExecutable::parameterCount):

3:00 PM Changeset in webkit [97511] by andreas.kling@nokia.com

3 edits in trunk/Source/WebCore

CSSParser: Remove StyleBase usage.
https://bugs.webkit.org/show_bug.cgi?id=70150

Reviewed by Darin Adler.

Split CSSParser::m_parsedStyleObjects into two vectors of
CSSRules and MediaLists.

css/CSSParser.cpp:

(WebCore::CSSParser::createMediaList):
(WebCore::CSSParser::createCharsetRule):
(WebCore::CSSParser::createImportRule):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createKeyframesRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframeRule):

css/CSSParser.h:

2:58 PM Changeset in webkit [97510] by imasaki@chromium.org

2 edits in trunk/LayoutTests

[Chromium] unskipping full screen layout tests. We will do rebaselines later.
https://bugs.webkit.org/show_bug.cgi?id=70144

Reviewed by David Levin.

platform/chromium/test_expectations.txt:

2:50 PM Changeset in webkit [97509] by abarth@webkit.org

18 edits in trunk

canvas getImageData should explain why it throws SECURITY_ERR
https://bugs.webkit.org/show_bug.cgi?id=70088

Reviewed by Darin Adler.

Source/WebCore:

Log as message to the console when getImageData fails because the
canvas is tainted.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::getImageData):

LayoutTests:

Update test results to show the new error message.

http/tests/canvas/philip/tests/security.drawImage.canvas-expected.txt:
http/tests/canvas/philip/tests/security.drawImage.image-expected.txt:
http/tests/canvas/philip/tests/security.pattern.canvas.fillStyle-expected.txt:
http/tests/canvas/philip/tests/security.pattern.canvas.strokeStyle-expected.txt:
http/tests/canvas/philip/tests/security.pattern.cross-expected.txt:
http/tests/canvas/philip/tests/security.pattern.image.fillStyle-expected.txt:
http/tests/canvas/philip/tests/security.pattern.image.strokeStyle-expected.txt:
http/tests/security/canvas-remote-read-data-url-svg-image-expected.txt:
http/tests/security/canvas-remote-read-redirect-to-remote-image-expected.txt:
http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin-expected.txt:
http/tests/security/canvas-remote-read-remote-image-blocked-then-allowed-expected.txt:
http/tests/security/canvas-remote-read-remote-image-expected.txt:
http/tests/security/canvas-remote-read-remote-image-redirect-expected.txt:
http/tests/security/canvas-remote-read-svg-image-expected.txt:

2:33 PM Changeset in webkit [97508] by andreas.kling@nokia.com

4 edits in trunk/Source/WebCore

Inspector: Remove StyleBase usage.
https://bugs.webkit.org/show_bug.cgi?id=70138

Reviewed by Antti Koivisto.

Be fully specific about whether we're operating on a CSSRule or
a CSSStyleSheet.

No behavior change expected, this merely is a cleanup.

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::parentStyleSheet):
(WebCore::InspectorCSSAgent::asCSSStyleRule):

inspector/InspectorCSSAgent.h:
inspector/InspectorStyleSheet.cpp:

(WebCore::asCSSRuleList):

2:25 PM Changeset in webkit [97507] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Update expectations after r97502.

platform/chromium/test_expectations.txt: Updated expectations.

2:18 PM Changeset in webkit [97506] by mhahnenberg@apple.com

58 edits in trunk/Source

Rename virtual deleteProperty to deletePropertyVirtual
https://bugs.webkit.org/show_bug.cgi?id=69884

Reviewed by Darin Adler.

Source/JavaScriptCore:

Renamed virtual versions of deleteProperty to deletePropertyVirtual in prepration for
adding the static deleteProperty to the MethodTable in ClassInfo since the
compiler gets mad if the virtual and static versions have the same name.

API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:

(JSC::::deletePropertyVirtual):
(JSC::::deleteProperty):

API/JSObjectRef.cpp:

(JSObjectDeleteProperty):

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::deletePropertyVirtual):
(JSC::DebuggerActivation::deleteProperty):

debugger/DebuggerActivation.h:
jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

runtime/Arguments.cpp:

(JSC::Arguments::deletePropertyVirtual):

runtime/Arguments.h:
runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):

runtime/JSActivation.cpp:

(JSC::JSActivation::deletePropertyVirtual):

runtime/JSActivation.h:
runtime/JSArray.cpp:

(JSC::JSArray::deletePropertyVirtual):
(JSC::JSArray::deleteProperty):

runtime/JSArray.h:
runtime/JSCell.cpp:

(JSC::JSCell::deletePropertyVirtual):
(JSC::JSCell::deleteProperty):

runtime/JSCell.h:
runtime/JSFunction.cpp:

(JSC::JSFunction::deletePropertyVirtual):

runtime/JSFunction.h:
runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::deletePropertyVirtual):

runtime/JSNotAnObject.h:
runtime/JSONObject.cpp:

(JSC::Walker::walk):

runtime/JSObject.cpp:

(JSC::JSObject::deletePropertyVirtual):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::defineOwnProperty):

runtime/JSObject.h:
runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::deletePropertyVirtual):

runtime/JSVariableObject.h:
runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::deletePropertyVirtual):

runtime/StrictEvalActivation.cpp:

(JSC::StrictEvalActivation::deletePropertyVirtual):

runtime/StrictEvalActivation.h:
runtime/StringObject.cpp:

(JSC::StringObject::deletePropertyVirtual):

runtime/StringObject.h:

Source/WebCore:

No new tests.

WebCore.exp.in:
bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::deletePropertyVirtual):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::deletePropertyVirtual):

bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::deletePropertyVirtual):

bindings/js/JSDOMWindowShell.h:
bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::deletePropertyVirtual):

bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::deletePropertyVirtual):

bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::deletePropertyVirtual):

bindings/js/ScriptObject.cpp:

(WebCore::ScriptGlobalObject::remove):

bindings/objc/WebScriptObject.mm:

(-[WebScriptObject removeWebScriptKey:]):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

bridge/NP_jsobject.cpp:

(_NPN_RemoveProperty):

bridge/jni/jni_jsobject.mm:

(JavaJSObject::removeMember):

bridge/objc/objc_runtime.h:
bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::deletePropertyVirtual):

bridge/runtime_array.cpp:

(JSC::RuntimeArray::deletePropertyVirtual):

bridge/runtime_array.h:
bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::deletePropertyVirtual):

bridge/runtime_object.h:

Source/WebKit/mac:

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::removeProperty):

Source/WebKit2:

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::deletePropertyVirtual):
(WebKit::JSNPObject::deleteProperty):

WebProcess/Plugins/Netscape/JSNPObject.h:
WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::removeProperty):

2:17 PM Changeset in webkit [97505] by inferno@chromium.org

2 edits in branches/chromium/874/Source/WebCore/bindings/v8

Merge 97429
BUG=98582
Review URL: http://codereview.chromium.org/8293008

2:12 PM Changeset in webkit [97504] by Dimitri Glazkov

8 edits in trunk/Tools

Plumb style-checker filter up to command options and make land-cowboy use it.
https://bugs.webkit.org/show_bug.cgi?id=70119

Reviewed by Adam Barth.

Scripts/webkitpy/style/checker.py: Added ChangeLogChecker categories to the big list.
Scripts/webkitpy/style/checkers/changelog.py: Declared categories, used in ChangeLogChecker.
Scripts/webkitpy/tool/commands/download.py: Made LandCowboy use filter.
Scripts/webkitpy/tool/commands/download_unittest.py: Tweaked the test.
Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
Scripts/webkitpy/tool/steps/checkstyle.py: Made check_style_filter work.
Scripts/webkitpy/tool/steps/options.py: Added new option, check-style-filter.

1:58 PM Changeset in webkit [97503] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[WebKit2][gtk] Add documentation for WebKitPluginError and WebKitPolicyError.
https://bugs.webkit.org/show_bug.cgi?id=70016

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-14
Reviewed by Martin Robinson.

UIProcess/API/gtk/WebKitError.h:

1:57 PM Changeset in webkit [97502] by Simon Fraser

4 edits
2 adds in trunk

Web Inspector: WebProcess crashes hard when inspecting elements with border-images applied
https://bugs.webkit.org/show_bug.cgi?id=70105

Source/WebCore:

Reviewed by Dave Hyatt.

Fix three different crashes related to getting computed style for border-image.
In both valueForNinePieceImageSlice() and valueForNinePieceImageQuad(),
assign 'right' to 'left' because we've computed a value for 'right' already.
Otherwise this would leave 'right' as null, causing later crashes in cssText().

In mapNinePieceImage(), borderImage->imageValue() can be null for a border-image
shorthand that is missing the image value.

Test: fast/css/getComputedStyle/computed-style-border-image.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForNinePieceImageSlice):
(WebCore::valueForNinePieceImageQuad):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::mapNinePieceImage):

LayoutTests:

Reviewed by Dave Hyatt.

Computed style test for border-image.

fast/css/getComputedStyle/computed-style-border-image-expected.txt: Added.
fast/css/getComputedStyle/computed-style-border-image.html: Added.

1:53 PM Changeset in webkit [97501] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-14

DEPS:

1:33 PM Changeset in webkit [97500] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[WebKit2][gtk] Skip TestWebKitSettings test.
https://bugs.webkit.org/show_bug.cgi?id=70129

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-14
Reviewed by Martin Robinson.

Skip running TestWebKitSettings test till a bug
https://bugs.webkit.org/show_bug.cgi?id=70127 gets fixed.

UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Skip TestWebKitSettings test.

1:16 PM Changeset in webkit [97499] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Mac build fix after r97497.

editing/markup.cpp:

(WebCore::isNonTableCellHTMLBlockElement):

1:02 PM Changeset in webkit [97498] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/efl

[EFL] Bump class version after r97421.
https://bugs.webkit.org/show_bug.cgi?id=70102

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-14
Reviewed by Joseph Pecoraro.

r97421 changed the signature of the run_open_panel virtual method in
Ewk_Smart_Class, so we need to bump the class version.

ewk/ewk_view.h:

12:55 PM Changeset in webkit [97497] by dcheng@chromium.org

11 edits in trunk/Source

Context-aware HTML paste for Chromium
https://bugs.webkit.org/show_bug.cgi?id=62112

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add createFragmentFromMarkupWithContext which understands enough about DOM structure to
retain necessary elements to preserve structure and appearance when extracting a subset of
a DOM tree.

Covered by existing layout tests.

editing/MarkupAccumulator.h:
editing/markup.cpp:

(WebCore::isNonTableCellHTMLBlockElement):
(WebCore::isHTMLBlockElement):
(WebCore::ancestorToRetainStructureAndAppearanceForBlock):
(WebCore::ancestorToRetainStructureAndAppearance):
(WebCore::ancestorToRetainStructureAndAppearanceWithNoRenderer):
(WebCore::findNodesSurroundingContext):
(WebCore::trimFragment):
(WebCore::createFragmentFromMarkupWithContext):

editing/markup.h:
platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::getData):

platform/chromium/DataTransferItemChromium.cpp:

(WebCore::DataTransferItemChromium::getAsString):

platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::documentFragment):

platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

Add WebKit side for plumbing to receive context for HTML paste.

public/WebClipboard.h:

(WebKit::WebClipboard::readHTML):

src/PlatformSupport.cpp:

(WebCore::PlatformSupport::clipboardReadHTML):

12:52 PM Changeset in webkit [97496] by weinig@apple.com

2 edits in trunk/Tools

Remove the Leopard slaves.

Reviewed by Adam Roben.

BuildSlaveSupport/build.webkit.org-config/config.json:

12:49 PM Changeset in webkit [97495] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[chromium skia] Add media/video-playing-and-pause.html to test expectations pending rebaseline
https://bugs.webkit.org/show_bug.cgi?id=70125

Patch by Brian Salomon <bsalomon@google.com> on 2011-10-14
Reviewed by Stephen White.

platform/chromium/test_expectations.txt:

12:48 PM Changeset in webkit [97494] by chang.shu@nokia.com

4 edits in trunk/LayoutTests

2011-10-14 Chang Shu <cshu@webkit.org>

[WK2] Unreviewed gardening.

Some fullscreen tests are passing now on mac WK2 after EventSender support.

platform/gtk-wk2/Skipped:
platform/win-wk2/Skipped:
platform/wk2/Skipped:

12:47 PM Changeset in webkit [97493] by commit-queue@webkit.org

10 edits in trunk

[Chromium] Inherit settings from Chromium's envsetup.sh, address a NDK todo
https://bugs.webkit.org/show_bug.cgi?id=70028

Patch by Peter Beverloo <peter@chromium.org> on 2011-10-14
Reviewed by Adam Barth.

Source/JavaScriptCore:

JavaScriptCore.gyp/JavaScriptCore.gyp:

Source/WebCore:

WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

WebKit.gyp:
gyp_webkit:

Tools:

Scripts/update-webkit-chromium:
Scripts/webkitdirs.pm:

(buildChromiumMakefile):
(buildChromium):

12:45 PM Changeset in webkit [97492] by bfulgham@webkit.org

2 edits in trunk/LayoutTests

[WinCairo] Unreviewed Skipped change to get bot green again.

platform/wincairo/Skipped: Skipped all animations, since tests do

not exactly match Windows results on Apple test output.

12:31 PM Changeset in webkit [97491] by Nate Chapin

6 edits in trunk/Source/WebCore

Check CachedResourceClient types with ASSERTs rather
than if statements.
https://bugs.webkit.org/show_bug.cgi?id=70113

Reviewed by Adam Barth.

No new tests, no functionality change.

loader/cache/CachedCSSStyleSheet.cpp:
loader/cache/CachedFont.cpp:
loader/cache/CachedImage.cpp:
loader/cache/CachedResourceClientWalker.h:
loader/cache/CachedXSLStyleSheet.cpp:

12:18 PM Changeset in webkit [97490] by mitz@apple.com

5 edits in trunk/WebKitLibraries

REGRESSION (Safari 5.1 - 5.1.1): CSS nesw-resize cursor shows up as a sw-resize cursor
https://bugs.webkit.org/show_bug.cgi?id=70081

Reviewed by Anders Carlsson.

WebKitSystemInterface.h: Unrelated change, perhaps needed for bug 68478.
libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceLion.a:
libWebKitSystemInterfaceSnowLeopard.a:

11:54 AM Changeset in webkit [97489] by andreas.kling@nokia.com

3 edits in trunk/Source/WebCore

Don't assert that CSSRules are CSSRules.

Rubber-stamped by Antti Koivisto.

css/CSSRule.h:

(WebCore::CSSRule::isRule):

css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::append):
(WebCore::CSSStyleSheet::insert):

11:48 AM Changeset in webkit [97488] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Update expectations after r97481.

platform/chromium/test_expectations.txt: Updated.

11:45 AM Changeset in webkit [97487] by Beth Dakin

2 edits in trunk/Source/WebCore

Attempted Leopard build fix.

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::createCompatibleBuffer):

11:41 AM Changeset in webkit [97486] by rniwa@webkit.org

2 edits in trunk/Source/WebKit/chromium

Chromium Mac build fix after r97478.

src/mac/WebSubstringUtil.mm:

(WebKit::WebSubstringUtil::attributedSubstringInRange):

11:36 AM Changeset in webkit [97485] by andreas.kling@nokia.com

15 edits in trunk/Source/WebCore

CSSStyleSheet should only ever contain CSSRules.
https://bugs.webkit.org/show_bug.cgi?id=70116

Reviewed by Antti Koivisto.

Move child management from the StyleSheet class down into
CSSStyleSheet and XSLStyleSheet. XSLStyleSheet continues to
manage StyleBase objects, while CSSStyleSheet now only contains
CSSRule.

This is enforced at both compile time and runtime with explicit
types and assertions.

css/CSSRule.h:

(WebCore::CSSRule::isRule):

Promoted to a public method so we can use it in assertions.

css/CSSRuleList.h:

(WebCore::CSSRuleList::create):
(WebCore::CSSRuleList::styleSheet):

css/CSSRuleList.cpp:

(WebCore::CSSRuleList::CSSRuleList):

bindings/js/JSCSSRuleListCustom.cpp:

(WebCore::JSCSSRuleListOwner::isReachableFromOpaqueRoots):

Change backing to a CSSStyleSheet instead of a StyleSheet.

css/CSSRuleList.cpp:

(WebCore::CSSRuleList::item):

Remove redundant assertions.

css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::isLoading):
(WebCore::CSSStyleSheet::addSubresourceStyleURLs):

css/CSSStyleSelector.cpp:

(WebCore::RuleSet::addRulesFromSheet):

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::collectStyleSheets):

page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeCSSStyleSheet):

Use more specific CSSRule* since that's what we get from
CSSStyleSheet::item() now.

css/StyleSheet.cpp:

(WebCore::StyleSheet::~StyleSheet):

css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::~CSSStyleSheet):

xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::~XSLStyleSheet):

xml/XSLStyleSheetQt.cpp:

(WebCore::XSLStyleSheet::~XSLStyleSheet):

Orphaning logic from ~StyleSheet() moved to subclass dtors.

css/StyleSheet.h:
css/CSSStyleSheet.h:

(WebCore::CSSStyleSheet::length):
(WebCore::CSSStyleSheet::item):

css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::append):
(WebCore::CSSStyleSheet::insert):
(WebCore::CSSStyleSheet::remove):

Moved from StyleSheet and changed to only accept CSSRules.

css/StyleSheet.h:
xml/XSLStyleSheet.h:

(WebCore::XSLStyleSheet::length):
(WebCore::XSLStyleSheet::item):
(WebCore::XSLStyleSheet::append):
(WebCore::XSLStyleSheet::insert):
(WebCore::XSLStyleSheet::remove):

Moved from StyleSheet though still uses StyleBase.

11:34 AM Changeset in webkit [97484] by leandro@webkit.org

3 edits in trunk/Tools

Unreviewed; add missing #includes.

DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
DumpRenderTree/efl/EventSender.cpp:

11:27 AM Changeset in webkit [97483] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit2

Unreviewed, rolling out r97375.
http://trac.webkit.org/changeset/97375
https://bugs.webkit.org/show_bug.cgi?id=70115

It breaks loading of webpages in QtWebKit2 (Requested by jeez_
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-14

UIProcess/qt/ClientImpl.cpp:

(qt_wk_decidePolicyForNavigationAction):

UIProcess/qt/ClientImpl.h:
UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init):

11:26 AM Changeset in webkit [97482] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Include dom/ExceptionCode.h instead of Filesystem APIs headers
to fix compile error when ENABLE_WORKERS=1 and ENABLE_FILE_SYSTEM=0
https://bugs.webkit.org/show_bug.cgi?id=70036

Patch by Yuji Sanachan <sanachan.y@gmail.com> on 2011-10-14
Reviewed by Darin Adler.

workers/WorkerContext.cpp:

(WebCore::WorkerContext::importScript):

11:14 AM Changeset in webkit [97481] by Beth Dakin

5 edits
3 adds in trunk

Text drawn via -webkit-background-clip:text should be non-blurry with all scaling
techniques
https://bugs.webkit.org/show_bug.cgi?id=68641

Source/WebCore:

Patch by Darin Adler <Darin Adler> on 2011-10-14
Reviewed by Simon Fraser. Committed by Beth Dakin.

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::createCompatibleBuffer): Allocate a buffer based on the
scale
factor of the context.

platform/graphics/GraphicsContext.h: Added createCompatibleBuffer.

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended): Use
createCompatibleBuffer.

LayoutTests:

Reviewed by Simon Fraser.

fast/css/clip-text-in-scaled-div-expected.png: Added.
fast/css/clip-text-in-scaled-div-expected.txt: Added.
fast/css/clip-text-in-scaled-div.html: Added.

11:00 AM Changeset in webkit [97480] by rniwa@webkit.org

10 edits in trunk/Source/WebCore

Move selectionStartStyle and selectionHasStyle to EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=69882

Reviewed by Enrica Casucci.

Moved selectionHasStyle and selectionStartStyle from Editor to EditingStyle.
Also moved much of code in Editor::selectionStartCSSPropertyValue to method of EditingStyle.

In addition, moved Range::editingStartPosition to htmlediting where it belongs
and renamed it to adjustedSelectionStartForStyleComputation.

dom/Range.cpp:
dom/Range.h:
editing/EditingStyle.cpp:

(WebCore::EditingStyle::triStateOfStyle): Extracted from selectionHasStyle.
(WebCore::EditingStyle::legacyFontSize): Extracted from selectionStartCSSPropertyValue.
(WebCore::EditingStyle::styleAtSelectionStart): Moved from Editor::selectionStartStyle.

editing/EditingStyle.h:
editing/Editor.cpp:

(WebCore::Editor::fontForSelection):
(WebCore::Editor::selectionStartHasStyle):
(WebCore::Editor::selectionHasStyle):
(WebCore::Editor::selectionStartCSSPropertyValue):

editing/Editor.h:
editing/EditorCommand.cpp:

(WebCore::executeToggleStyleInList):

editing/htmlediting.cpp:

(WebCore::adjustedSelectionStartForStyleComputation): Moved from Range::editingStartPosition.

editing/htmlediting.h:

10:57 AM Changeset in webkit [97479] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Redundant comparison in AccessibilityObject.cpp updateAXLineStartForVisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=70074

Reviewed by Chris Fleizach.

Removed redundant code.

accessibility/AccessibilityObject.cpp:

(WebCore::updateAXLineStartForVisiblePosition):

10:54 AM Changeset in webkit [97478] by rniwa@webkit.org

18 edits in trunk/Source

Make the interface of locationAndLengthFromRange and rangeFromLocationAndLength consistent
https://bugs.webkit.org/show_bug.cgi?id=69964

Reviewed by Enrica Casucci.

Source/WebCore:

Extracted the logic to determine the scope element as FrameSelection::rootEditableElementOrDocumentElement
and deployed it in WebKit layer. Made locationAndLengthFromRange take a scope element and renamed it to
getLocationAndLengthFromRange.

WebCore.exp.in:
editing/FrameSelection.cpp:

(WebCore::FrameSelection::rootEditableElementOrDocumentElement):

editing/FrameSelection.h:
editing/TextIterator.cpp:

(WebCore::TextIterator::getLocationAndLengthFromRange):

editing/TextIterator.h:

Source/WebKit/chromium:

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::firstRectForCharacterRange):
(WebKit::WebFrameImpl::characterIndexForPoint):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::compositionRange):
(WebKit::WebViewImpl::getSelectionOffsetsAndTextInEditableContent):
(WebKit::WebViewImpl::caretOrSelectionRange):

src/mac/WebSubstringUtil.mm:

(WebKit::WebSubstringUtil::attributedSubstringInRange):

Source/WebKit/gtk:

WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::firstRectForCharacterRange):

Source/WebKit/mac:

WebView/WebFrame.mm:

(-[WebFrame _convertToNSRange:]):
(-[WebFrame _convertToDOMRange:]):

Source/WebKit/qt:

WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::firstRectForCharacterRange):

Source/WebKit2:

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::getMarkedRange):
(WebKit::WebPage::getSelectedRange):
(WebKit::WebPage::characterIndexForPoint):
(WebKit::convertToRange):

10:23 AM Changeset in webkit [97477] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

DFG JIT 32_64 - Performance fix for ResolveGlobal
https://bugs.webkit.org/show_bug.cgi?id=70096

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-14
Reviewed by Gavin Barraclough.

Structure check of global object should be a pointer comparison
instead of a tag and payload pair comparison. This fix improves
SunSpider by 7% on Linux 32, with bitops-bitwise-and improved by 4.75X.
Also two trivial fixes for successful 32-bit build are included.

dfg/DFGSpeculativeJIT.cpp:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

10:15 AM Changeset in webkit [97476] by jchaffraix@webkit.org

4 edits in trunk/Source/WebKit/win

Remove layerX / layerY from the Windows API
https://bugs.webkit.org/show_bug.cgi?id=70051

Reviewed by Darin Adler.

Renamed layerX to unused1 and layerY to unused2 to keep the
binary compatibility.

DOMEventsClasses.cpp:

(DOMUIEvent::unused1):
(DOMUIEvent::unused2):

DOMEventsClasses.h:

(DOMKeyboardEvent::unused1):
(DOMKeyboardEvent::unused2):
(DOMMouseEvent::unused1):
(DOMMouseEvent::unused2):
(DOMWheelEvent::unused1):
(DOMWheelEvent::unused2):

Interfaces/DOMEvents.idl:

10:12 AM Changeset in webkit [97475] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] Correctly get the absolute URL in LayoutTestController::queueLoad()
https://bugs.webkit.org/show_bug.cgi?id=69770

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-14
Reviewed by Antonio Gomes.

We were just appending the given URL to the absolute URI of the main
frame, which resulted in "file:///foo/bar/baz.htmltheother/url.html"
instead of "file:///foo/bar/theother/url.html".

This should make fast/dom/navigation-type-navigate.html behave
better (it still fails, but later).

DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::queueLoad):

10:04 AM Changeset in webkit [97474] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[GTK] r97438: Inconsistent use of flattening vs flattering in function names/comments
https://bugs.webkit.org/show_bug.cgi?id=70092

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-14
Reviewed by Martin Robinson.

Fixes the miss-spelling of 'PROP_ENABLE_FRAME_FLATTENING' as 'PROP_ENABLE_FRAME_FLATTERING'
introduced with change set r97438.

UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty): Property name correction.
(webKitSettingsGetProperty): Property name correction.
(webkit_settings_class_init): Property name correction.

UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Spelling correction.

9:49 AM Changeset in webkit [97473] by Csaba Osztrogonác

2 edits
1 add in trunk/LayoutTests

[Qt] Unreviewed gardening.

platform/qt/Skipped:
- Skip a failing test.
- Typo fix after r97471.
platform/qt/http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2-expected.txt: Added after r97388.

9:21 AM Changeset in webkit [97472] by rniwa@webkit.org

3 edits in trunk/LayoutTests

Skip MicroData tests on Mac and WinCairo as well.

platform/mac/Skipped:
platform/wincairo/Skipped:

9:13 AM Changeset in webkit [97471] by rniwa@webkit.org

33 edits
23 adds in trunk

Microdata: Basic implementation of document.getItems() method.
https://bugs.webkit.org/show_bug.cgi?id=68610

Patch by Arko Saha <arko@motorola.com> on 2011-10-13
Reviewed by Ryosuke Niwa.

Added ENABLE(MICRODATA) feature flag.

configure.ac:

Source/WebCore:

Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
Spec: http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html

Tests: fast/dom/MicroData/001.html

fast/dom/MicroData/002.html
fast/dom/MicroData/003.html
fast/dom/MicroData/004.html
fast/dom/MicroData/005.html
fast/dom/MicroData/006.html
fast/dom/MicroData/007.html
fast/dom/MicroData/008.html
fast/dom/MicroData/009.html

CMakeLists.txt:
DerivedSources.make:
GNUmakefile.am:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
dom/Document.cpp:

(WebCore::Document::getItems): Returns NodeList of the element in the Document that
create items, that are not part of other items, and that are of one of the types
given in the argument. If no tokens specified/undefined in the argument, then
return a NodeList containing all top level microdata items.
(WebCore::Document::removeCachedMicroDataItemList): Remove Microdata item node list
from cache.

dom/Document.h:
dom/Document.idl: Added getItems() microdata DOM API.
dom/MicroDataItemList.cpp: Added.

(WebCore::MicroDataItemList::MicroDataItemList):
(WebCore::MicroDataItemList::~MicroDataItemList):
(WebCore::MicroDataItemList::nodeMatches):

dom/MicroDataItemList.h: Added.

(WebCore::MicroDataItemList::create):

dom/Node.cpp:

(WebCore::Node::itemTypeAttributeChanged): It is responsible to invalidate the Microdata
item node cache when itemType attribute changes.
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes):
(WebCore::NodeListsNodeData::invalidateMicrodataItemListCaches): Invalidate Microdata item
list cache.
(WebCore::NodeListsNodeData::isEmpty):

dom/Node.h:
dom/NodeRareData.h:
features.pri:
html/HTMLAttributeNames.in: Added itemid, itemprop, itemscope, itemtype attributes.
html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute): Handle itemtype attribute change.

html/HTMLElement.idl: Added itemid, itemprop, itemscope, itemtypes microdata attributes.

Source/WebKit/chromium:

Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
Spec : http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html

features.gypi:

Tools:

Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
Spec : http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html

Scripts/build-webkit:

WebKitLibraries:

Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
Spec: http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html

win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

Added test-cases for document.getItems() method.
Spec: http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html
Skipping test-cases for now as Microdata DOM API is not yet enabled.

fast/dom/MicroData: Added.
fast/dom/MicroData/001-expected.txt: Added.
fast/dom/MicroData/001.html: Added.
fast/dom/MicroData/002-expected.txt: Added.
fast/dom/MicroData/002.html: Added.
fast/dom/MicroData/003-expected.txt: Added.
fast/dom/MicroData/003.html: Added.
fast/dom/MicroData/004-expected.txt: Added.
fast/dom/MicroData/004.html: Added.
fast/dom/MicroData/005-expected.txt: Added.
fast/dom/MicroData/005.html: Added.
fast/dom/MicroData/006-expected.txt: Added.
fast/dom/MicroData/006.html: Added.
fast/dom/MicroData/007-expected.txt: Added.
fast/dom/MicroData/007.html: Added.
fast/dom/MicroData/008-expected.txt: Added.
fast/dom/MicroData/008.html: Added.
fast/dom/MicroData/009-expected.txt: Added.
fast/dom/MicroData/009.html: Added.
fast/dom/MicroData/resources: Added.
fast/dom/MicroData/resources/microdata-common.js: Added.

(createElem):
(runTest):

platform/win/Skipped:

8:50 AM Changeset in webkit [97470] by Csaba Osztrogonác

2 edits in trunk/Tools

new-run-webkit-tests does not support qt-4.8 results
https://bugs.webkit.org/show_bug.cgi?id=64071

Roll-back second part of r97252. :)

Scripts/webkitpy/layout_tests/port/qt.py:

8:45 AM BuildingQt5OnHarmattan edited by abecsi@webkit.org

(diff)

8:36 AM Changeset in webkit [97469] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] DRT: Do not use OwnFastMallocPtr to manage char*'s.
https://bugs.webkit.org/show_bug.cgi?id=70106

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-14
Reviewed by Antonio Gomes.

OwnFastMallocPtr was being used as a smart pointer that automatically called
free() on the strings returned by the EFL or by ewk.

However, when WTF is built in release mode, it uses its own memory management
code instead of using the system malloc(), free() and friends. This means bad
things will happen when one uses WTF's free() on memory allocated with system
malloc() by the EFL or ewk.

The easiest way to solve this is to call free() ourselves.

DumpRenderTree/efl/DumpRenderTree.cpp:

(dumpFramesAsText):
(getFinalTestURL):

8:32 AM Changeset in webkit [97468] by andreas.kling@nokia.com

5 edits in trunk/Source/WebCore

Stricter management of WebKitCSSKeyframeRules.
https://bugs.webkit.org/show_bug.cgi?id=70109

Reviewed by Antti Koivisto.

Covered by existing tests.

css/CSSParser.h:
css/CSSParser.cpp:

(WebCore::CSSParser::parseKeyframeRule):

Return a WebKitCSSKeyframeRule instead of a CSSRule.

css/CSSRuleList.cpp:

(WebCore::CSSRuleList::deleteRule):

css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::deleteRule):

Moved style sheet orphaning logic for @-webkit-keyframe
from CSSRuleList into WebKitCSSKeyframesRule::deleteRule()
since that's the only caller operating on those rules.

css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::length):
(WebCore::WebKitCSSKeyframesRule::item):
(WebCore::WebKitCSSKeyframesRule::insertRule):

Change isKeyframeRule() checks to assertions since we know
our rules are always WebKitCSSKeyframeRules. Also tidied up.

8:10 AM Changeset in webkit [97467] by andreas.kling@nokia.com

1 edit
2 deletes in trunk/Source/WebCore

Unreviewed, actually remove StyleList.* after r97640.

css/StyleList.cpp: Removed.
css/StyleList.h: Removed.

8:04 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

7:57 AM Changeset in webkit [97466] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[Qt] enable qmltests for qt5
https://bugs.webkit.org/show_bug.cgi?id=70037

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-10-14
Reviewed by Chang Shu.

Qml tests seem to be disabled for some reason. This patch enables the tests by including qmltests to SUBDIRS.

UIProcess/API/qt/tests/tests.pro:

7:49 AM Changeset in webkit [97465] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

Do not cache m_resizesToContentsLayoutSize on WebKit2's WebPage
https://bugs.webkit.org/show_bug.cgi?id=66134

Unreviewed build fix after r97462.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2011-10-14

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

7:43 AM Changeset in webkit [97464] by commit-queue@webkit.org

14 edits
2 adds in trunk

[EFL] Add DumpRenderTreeSupportEfl
https://bugs.webkit.org/show_bug.cgi?id=68458

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-14
Reviewed by Kenneth Rohde Christiansen.

Source/cmake/eflsymbols.filter: Export DumpRenderTreeSupportEfl

symbols so that DumpRenderTree can link to them.

Source/WebKit/efl:

This class is similar to their counterparts present in the Qt and GTK+
ports, and it is responsible for providing an interface to certain
WebCore methods needed by DumpRenderTree.

CMakeListsEfl.txt: Conditionally add the svg directories to the

include path.

WebCoreSupport/DumpRenderTreeSupportEfl.cpp: Added.

(DumpRenderTreeSupportEfl::DumpRenderTreeSupportEfl):
(DumpRenderTreeSupportEfl::~DumpRenderTreeSupportEfl):
(DumpRenderTreeSupportEfl::activeAnimationsCount):
(DumpRenderTreeSupportEfl::clearFrameName):
(DumpRenderTreeSupportEfl::clearOpener):
(DumpRenderTreeSupportEfl::counterValueByElementId):
(DumpRenderTreeSupportEfl::frameChildren):
(DumpRenderTreeSupportEfl::frameParent):
(DumpRenderTreeSupportEfl::layoutFrame):
(DumpRenderTreeSupportEfl::numberOfPages):
(DumpRenderTreeSupportEfl::numberOfPagesForElementId):
(DumpRenderTreeSupportEfl::pauseAnimation):
(DumpRenderTreeSupportEfl::pauseSVGAnimation):
(DumpRenderTreeSupportEfl::pauseTransition):
(DumpRenderTreeSupportEfl::pendingUnloadEventCount):
(DumpRenderTreeSupportEfl::renderTreeDump):
(DumpRenderTreeSupportEfl::responseMimeType):
(DumpRenderTreeSupportEfl::resumeAnimations):
(DumpRenderTreeSupportEfl::selectionRectangle):
(DumpRenderTreeSupportEfl::suitableDRTFrameName):
(DumpRenderTreeSupportEfl::suspendAnimations):
(DumpRenderTreeSupportEfl::findString):
(DumpRenderTreeSupportEfl::garbageCollectorCollect):
(DumpRenderTreeSupportEfl::garbageCollectorCollectOnAlternateThread):
(DumpRenderTreeSupportEfl::javaScriptObjectsCount):
(DumpRenderTreeSupportEfl::workerThreadCount):
(DumpRenderTreeSupportEfl::childHistoryItems):
(DumpRenderTreeSupportEfl::historyItemTarget):
(DumpRenderTreeSupportEfl::isTargetItem):
(DumpRenderTreeSupportEfl::setMockScrollbarsEnabled):

WebCoreSupport/DumpRenderTreeSupportEfl.h: Added.
ewk/ewk_frame.cpp:

(EWKPrivate::coreFrame): Export the WebCore::Frame* related to an
ewk_frame.

ewk/ewk_history.cpp: Remove functions which have been moved to

DumpRenderTreeSupportEfl.
(_ewk_history_item_list_get): _ewk_history_item_new ->
ewk_history_item_new_from_core.
(ewk_history_history_item_back_get): Ditto.
(ewk_history_history_item_current_get): Ditto.
(ewk_history_history_item_forward_get): Ditto.
(ewk_history_history_item_nth_get): Ditto.
(ewk_history_item_new): Ditto.
(ewk_history_item_new_from_core): Rename from _ewk_history_item_new.
(EWKPrivate::coreHistoryItem): Export the WebCore::HistoryItem*
related to an Ewk_History_Item.

ewk/ewk_private.h: Create the EWKPrivate namespace, remove functions

which have been moved to DumpRenderTreeSupportEfl.

ewk/ewk_util.cpp: Remove functions which have been moved to

DumpRenderTreeSupportEfl.

ewk/ewk_view.cpp:

(EWKPrivate::corePage): Export the WebCore::Page* related to an
ewk_view.

Tools:

Make the calls in DumpRenderTree use DumpRenderTreeSupportEfl.

DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::initialize): Turn on mock scrollbars.
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
(DumpRenderTreeChrome::onWindowObjectCleared):
(DumpRenderTreeChrome::onDocumentLoadFinished):

DumpRenderTree/efl/GCControllerEfl.cpp:

(GCController::collect):
(GCController::collectOnAlternateThread):
(GCController::getJSObjectCount):

DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::counterValueForElementById):
(LayoutTestController::pageNumberForElementById):
(LayoutTestController::numberOfPages):
(LayoutTestController::workerThreadCount):
(LayoutTestController::findString):
(LayoutTestController::pauseAnimationAtTimeOnElementWithId):
(LayoutTestController::pauseTransitionAtTimeOnElementWithId):
(LayoutTestController::sampleSVGAnimationForElementAtTime):
(LayoutTestController::numberOfActiveAnimations):
(LayoutTestController::suspendAnimations):
(LayoutTestController::resumeAnimations):

DumpRenderTree/efl/PixelDumpSupportEfl.cpp:

(createBitmapContextFromWebView):

7:17 AM Changeset in webkit [97463] by Csaba Osztrogonác

2 edits in trunk/Tools

[Qt] Enable NRWT for Qt 4.8 version too, because it is supported after r97461.

Unreviewed.

Scripts/run-webkit-tests:

(useNewRunWebKitTests):

7:09 AM Changeset in webkit [97462] by kenneth@webkit.org

4 edits in trunk/Source/WebKit2

Do not cache m_resizesToContentsLayoutSize on WebKit2's WebPage
https://bugs.webkit.org/show_bug.cgi?id=66134

Reviewed by Simon Hausmann.

Do the resize to contents on the web process side.

Based on patch by Zalan Bujtas.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setSize):
(WebKit::WebPage::setResizesToContentsUsingLayoutSize):
(WebKit::WebPage::resizeToContentsIfNeeded):

WebProcess/WebPage/WebPage.h:

7:05 AM QtWebKitBuildBots edited by Csaba Osztrogonác

Update Qt version on Windows bots (diff)

6:55 AM Changeset in webkit [97461] by Csaba Osztrogonác

3 edits in trunk/Tools

new-run-webkit-tests does not support qt-4.8 results
https://bugs.webkit.org/show_bug.cgi?id=64071

Roll-back r97252 with unit test fix.

Reviewed by Csaba Osztrogonác.

Scripts/webkitpy/layout_tests/port/qt.py:
Scripts/webkitpy/layout_tests/port/qt_unittest.py:

5:48 AM Changeset in webkit [97460] by andreas.kling@nokia.com

12 edits in trunk/Source/WebCore

Merge StyleList into StyleSheet.
https://bugs.webkit.org/show_bug.cgi?id=70100

Reviewed by Antti "printf" Koivisto.

Merge all functionality from StyleList into StyleSheet,
since StyleSheet was the only subclass of StyleList anyway.

Also removed FIXME's about throwing exceptions in CSSRuleList
since they were incorrect. The call sites already handle the
relevant cases.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSCSSRuleListCustom.cpp:

(WebCore::JSCSSRuleListOwner::isReachableFromOpaqueRoots):

css/CSSRuleList.cpp:

(WebCore::CSSRuleList::CSSRuleList):
(WebCore::CSSRuleList::length):
(WebCore::CSSRuleList::item):
(WebCore::CSSRuleList::deleteRule):
(WebCore::CSSRuleList::append):
(WebCore::CSSRuleList::insertRule):

css/CSSRuleList.h:

(WebCore::CSSRuleList::create):
(WebCore::CSSRuleList::styleSheet):

css/StyleList.cpp: Removed.
css/StyleList.h: Removed.
css/StyleSheet.cpp:

(WebCore::StyleSheet::StyleSheet):
(WebCore::StyleSheet::append):
(WebCore::StyleSheet::insert):
(WebCore::StyleSheet::remove):

css/StyleSheet.h:

(WebCore::StyleSheet::length):
(WebCore::StyleSheet::item):

5:31 AM BuildingQt5OnHarmattan edited by lars.knudsen@nokia.com

(diff)

4:40 AM QtWebKitBuildBots edited by Csaba Osztrogonác

Update Qt5 on the WK2 bot (diff)

4:30 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

4:00 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

4:00 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

3:23 AM Changeset in webkit [97459] by abarth@webkit.org

6 edits in trunk/LayoutTests

tables/mozilla/bugs/bug53690-1.html has never worked
https://bugs.webkit.org/show_bug.cgi?id=67745

Reviewed by Eric Seidel.

Previously, this script had just errored out. This patch removes the
script, making the results more sane.

platform/chromium-win/tables/mozilla/bugs/bug53690-1-expected.txt:
platform/gtk/tables/mozilla/bugs/bug53690-1-expected.txt:
platform/mac/tables/mozilla/bugs/bug53690-1-expected.txt:
platform/qt/tables/mozilla/bugs/bug53690-1-expected.txt:
tables/mozilla/bugs/bug53690-1.html:

3:17 AM BuildingQt5OnHarmattan edited by zeno.albisser@nokia.com

(diff)

3:15 AM Changeset in webkit [97458] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

[GTK] Build is broken with new ld
https://bugs.webkit.org/show_bug.cgi?id=70097

Reviewed by Philippe Normand.

UIProcess/API/gtk/tests/GNUmakefile.am:

3:14 AM Changeset in webkit [97457] by Simon Hausmann

5 edits in trunk/Source/WebKit2

[Qt][WK2] Fix build after QSGItem API changes
https://bugs.webkit.org/show_bug.cgi?id=69926

Reviewed by Kenneth Rohde Christiansen.

Commit c825865cdd88445aa1db94cdf0da89426919acdb in qtdeclarative changed the
signatures of the Drag & Drop event handlers in QSGItem. The SG specific events
were replaced with the plain QDrag* events, which are now used for widgets as well
as the Qt scene graph.

This patch adapts the desktop webview as well as the page proxy to handle these
kind of events.

UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebView::dragMoveEvent):
(QDesktopWebView::dragEnterEvent):
(QDesktopWebView::dragLeaveEvent):
(QDesktopWebView::dropEvent):

UIProcess/API/qt/qdesktopwebview.h:
UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::handleEvent):
(QDesktopWebPageProxy::handleDragEnterEvent):
(QDesktopWebPageProxy::handleDragLeaveEvent):
(QDesktopWebPageProxy::handleDragMoveEvent):
(QDesktopWebPageProxy::handleDropEvent):

UIProcess/qt/qdesktopwebpageproxy.h:

3:09 AM BuildingGtk edited by nayankk@motorola.com

(diff)

3:04 AM BuildingQt5OnHarmattan edited by kenneth@webkit.org

(diff)

3:02 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

2:55 AM Changeset in webkit [97456] by abarth@webkit.org

2 edits
1 move
3 deletes in trunk/LayoutTests

tables/mozilla/bugs/bug9024.html has never worked
https://bugs.webkit.org/show_bug.cgi?id=67744

Reviewed by Eric Seidel.

Previously, this script had just errored out. This patch removes the
scripts, which lets us share the same baseline across all the ports.

platform/chromium-win/tables/mozilla/bugs/bug9024-expected.txt: Removed.
platform/gtk/tables/mozilla/bugs/bug9024-expected.txt: Removed.
platform/mac/tables/mozilla/bugs/bug9024-expected.txt: Removed.
platform/qt/tables/mozilla/bugs/bug9024-expected.txt: Removed.
tables/mozilla/bugs/bug9024-expected.txt: Added.
tables/mozilla/bugs/bug9024.html:

2:42 AM Changeset in webkit [97455] by tkent@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Test expectation update.
https://bugs.webkit.org/show_bug.cgi?id=70013

platform/chromium/test_expectations.txt:

Add more canvas crashes.

2:28 AM Changeset in webkit [97454] by mihnea@adobe.com

81 edits in trunk

[CSS Regions] Change -webkit-flow to -webkit-flow-into
https://bugs.webkit.org/show_bug.cgi?id=70014

Reviewed by David Hyatt.

-webkit-flow is renamed to -webkit-flow-into
-webkit-flow-into takes <ident> instead of strings

Source/WebCore:

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::validFlowName):
(WebCore::CSSParser::parseFlowThread):

css/CSSPropertyNames.in:
css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
fast/regions/bottom-overflow-out-of-first-region.html:
fast/regions/content-flowed-into-regions-no-scroll.html:
fast/regions/float-pushed-width-change.html:
fast/regions/floats-basic-in-variable-width-regions.html:
fast/regions/flow-anonymous-children.html:
fast/regions/flow-content-basic-vertical-rl.html:
fast/regions/flow-content-basic-vertical.html:
fast/regions/flow-content-basic.html:
fast/regions/flows-dependency-dynamic-remove.html:
fast/regions/flows-dependency-same-flow.html:
fast/regions/hit-test-float.html:
fast/regions/multiple-directionality-changes-in-variable-width-regions.html:
fast/regions/no-split-line-box.html:
fast/regions/outline-sides-in-region.html:
fast/regions/overflow-in-uniform-regions-dynamic.html:
fast/regions/overflow-in-uniform-regions.html:
fast/regions/overflow-in-variable-width-regions.html:
fast/regions/overflow-moving-below-floats-in-variable-width-regions.html:
fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html:
fast/regions/overflow-rtl-in-variable-width-regions.html:
fast/regions/overflow-size-change-in-variable-width-regions.html:
fast/regions/overflow-size-change-with-stacking-context-rtl.html:
fast/regions/overflow-size-change-with-stacking-context.html:
fast/regions/percentage-margins-mixed-ltr-dominant-regions.html:
fast/regions/percentage-margins-mixed-rtl-dominant-regions.html:
fast/regions/percentage-margins-rtl-variable-width-regions.html:
fast/regions/percentage-margins-variable-width-regions.html:
fast/regions/position-writing-modes-in-variable-width-regions.html:
fast/regions/positioned-objects-block-static-in-regions.html:
fast/regions/positioned-objects-block-static-in-rtl-regions.html:
fast/regions/positioned-objects-block-static-spanning-regions-rtl.html:
fast/regions/positioned-objects-block-static-spanning-regions.html:
fast/regions/positioned-objects-in-regions.html:
fast/regions/positioned-objects-in-rtl-regions.html:
fast/regions/positioned-objects-inline-static-in-regions.html:
fast/regions/positioned-objects-inline-static-in-rtl-regions.html:
fast/regions/positioned-objects-inline-static-spanning-regions-rtl.html:
fast/regions/positioned-objects-inline-static-spanning-regions.html:
fast/regions/positioned-objects-perpendicular-flows-in-regions.html:
fast/regions/positioned-objects-spanning-regions.html:
fast/regions/region-overflow-auto-overflow-hidden.html:
fast/regions/region-overflow-auto-overflow-visible.html:
fast/regions/region-overflow-break.html:
fast/regions/resources/region-style.css:

(.flowArticle):

fast/regions/script-tests/webkit-flow-parsing.js:

(test):
(testComputedStyle):
(testNotInherited):

fast/regions/text-region-breaks.html:
fast/regions/text-region-split-after-resize.html:
fast/regions/text-region-split-horizontal-bt.html:
fast/regions/text-region-split-small-pagination.html:
fast/regions/text-region-split-vertical-rl.html:
fast/regions/text-region-split-vertical.html:
fast/regions/text-region-split.html:
fast/regions/top-overflow-out-of-second-region.html:
fast/regions/webkit-flow-double-pagination-float-push.html:
fast/regions/webkit-flow-float-pushed-to-last-region.html:
fast/regions/webkit-flow-float-unable-to-push.html:
fast/regions/webkit-flow-floats-inside-regions-bounds.html:
fast/regions/webkit-flow-inlines-dynamic.html:
fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl.html:
fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html:
fast/regions/webkit-flow-inlines-inside-regions-bounds.html:
fast/regions/webkit-flow-parsing-expected.txt:
fast/regions/webkit-flow-renderer-layer.html:
fast/regions/webkit-flow-renderer-nested.html:
fast/regions/webkit-flow-renderer.html:
fast/repaint/japanese-rl-selection-repaint-in-regions.html:
fast/repaint/line-flow-with-floats-in-regions.html:
fast/repaint/overflow-flipped-writing-mode-block-in-regions.html:
fast/repaint/region-painting-via-layout.html:
platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
svg/css/getComputedStyle-basic-expected.txt:

2:15 AM Changeset in webkit [97453] by hans@chromium.org

17 edits
2 deletes in trunk/Source

IndexedDB: Remove SQLite backing store
https://bugs.webkit.org/show_bug.cgi?id=69620

Reviewed by Darin Fisher.

Remove the SQLite backing store implementation; it is not used anymore.
Also remove the maximumSize parameter, it is not used either.

Source/WebCore:

No new functionality, so no new tests.

GNUmakefile.list.am:
WebCore.gypi:
storage/IDBBackingStore.h:
storage/IDBFactory.cpp:

(WebCore::IDBFactory::getDatabaseNames):
(WebCore::IDBFactory::open):

storage/IDBFactoryBackendImpl.cpp:

(WebCore::computeFileIdentifier):
(WebCore::computeUniqueIdentifier):
(WebCore::IDBFactoryBackendImpl::getDatabaseNames):
(WebCore::IDBFactoryBackendImpl::open):
(WebCore::IDBFactoryBackendImpl::openBackingStore):

storage/IDBFactoryBackendImpl.h:
storage/IDBFactoryBackendInterface.h:
storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::open):

storage/IDBLevelDBBackingStore.h:
storage/IDBSQLiteBackingStore.cpp: Removed.
storage/IDBSQLiteBackingStore.h: Removed.

Source/WebKit/chromium:

public/WebIDBFactory.h:

(WebKit::WebIDBFactory::getDatabaseNames):
(WebKit::WebIDBFactory::open):

src/AssertMatchingEnums.cpp:
src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::getDatabaseNames):
(WebKit::IDBFactoryBackendProxy::open):

src/IDBFactoryBackendProxy.h:
src/WebIDBFactoryImpl.cpp:

(WebKit::WebIDBFactoryImpl::getDatabaseNames):
(WebKit::WebIDBFactoryImpl::open):

src/WebIDBFactoryImpl.h:

2:06 AM Changeset in webkit [97452] by Nikolas Zimmermann

2 edits in trunk/Source/WebCore

2011-10-14 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix mac builds. r97448 broke them.

WebCore.xcodeproj/project.pbxproj: Set ImageBySizeCache.h role to private.

1:36 AM Changeset in webkit [97451] by jschuh@chromium.org

6 edits in trunk/Source

Clear WebMediaPlayerClientImpl back pointer on destruction
https://bugs.webkit.org/show_bug.cgi?id=69973

Reviewed by James Robinson.

Clear the backpointer and remove the unused m_currentFrame

Source/WebCore:

platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::cleanupResources):
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::releaseProvider):

platform/graphics/chromium/VideoLayerChromium.h:

Source/WebKit/chromium:

src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::load):
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):

src/WebMediaPlayerClientImpl.h:

1:34 AM Changeset in webkit [97450] by hans@chromium.org

6 edits in trunk

IndexedDB: Make IDBCursor.value() return an IDBAny object
https://bugs.webkit.org/show_bug.cgi?id=70024

Reviewed by Tony Chang.

Source/WebCore:

This is to work around the fact that the V8 bindings mechanism does
eager deserialization of SerializedScriptValue attributes. This means
that the value is fetched from the back-end only once, when the
IDBCursor is first wrapped. When the cursor's value changes, this is
not reflected.

We work around this by making IDBCursor.value() return the
SerializedScriptValue wrapped in an IDBAny object.

storage/IDBCursor.cpp:

(WebCore::IDBCursor::value):

storage/IDBCursor.h:
storage/IDBCursorWithValue.idl:

LayoutTests:

Update test expectations since more of this test now passes.

storage/indexeddb/cursor-inconsistency-expected.txt:

1:12 AM Changeset in webkit [97449] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

Fix compilation when the JS Debugger is disabled.
https://bugs.webkit.org/show_bug.cgi?id=70007

Patch by Rémi Duraffort <remi.duraffort@st.com> on 2011-10-14
Reviewed by Antti Koivisto.

inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willEvaluateWorkerScript):

inspector/InspectorRuntimeAgent.cpp:
inspector/InspectorRuntimeAgent.h:
inspector/WorkerInspectorController.cpp:
inspector/WorkerInspectorController.h:
workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::disconnectFromInspector):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):

1:11 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

1:08 AM Changeset in webkit [97448] by Nikolas Zimmermann

59 edits
2 copies in trunk/Source/WebCore

2011-10-13 Nikolas Zimmermann <nzimmermann@rim.com>

Prepare SVGImage intrinsic size negotiation: Introduce an IntSize <-> SVGImage cache in CachedImage
https://bugs.webkit.org/show_bug.cgi?id=69416

Reviewed by Antti Koivisto.

Refactor ImageBySizeCache out of CSSImageGeneratorValue as CachedImage wants to use the same type of cache for its purposes.
When introducing the SVGImage intrinsic size negotiation the container size of an SVGImage is dependant on the place where
it gets embedded (eg width/height attributes of host documents <img> force a certain size).

Currently CachedImage only contains a single RefPtr<Image>, which it constructs out of the decoded data.
Multiple RenderObjects share the same CachedImages, when embedding eg. a SVG document in a <html:img> or using it in a background-image for a <div>.
Consider the case where two RenderObjects use the same CachedImage, each with a different container size (200x100 vs 100x200) and the embedded
document contains a viewBox and some arbitary preserveAspectRatio settings. To honour these we have to relayout the document with the desired
size (percentual unit resolving etc, all depend on the RenderSVGRoots size).

With the current design this is hard to realize, w/o requring to relayout the embedded document for each embedder that uses an SVGImage.
This patch introduces a cache right within CachedImage, which manages a map of images to certain sizes, by utilizing the new ImageBySizeCache.

CachedImage::imageForRenderer() takes a RenderObject* parameter, which it uses to look up the last set image container size for a renderer.
Using that size it queries the cache whether it already has an SVGImage for that size, if not it gets created, by creating a whole
new instance of SVGImage, filling it with the already decoded data, and passing on a fixed image container size, which overrides the
size that RenderSVGRoot reports, when computeReplacedLogicalWidth/Height is called and thus laying out the document at the desired size.
This image is then put in the cache for further reusability.

Likewise CachedImage::setContainerSizeForRenderer() now takes a RenderObject* parameter and stores that in the cache with an associated container size.
It requires to touch several files which use CachedImage throughout WebCore/WebKit/WebKit2.

The actual cache is not yet turned on yet, so this is not a functional change so far, as it needs some other changes to SVGImage,
which will come with the master patch in bug 47156.

No new tests yet, as the new cache isn't turned on yet.

CMakeLists.txt: Add rendering/ImageBySizeCache.* to build.
GNUmakefile.list.am: Ditto.
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Use new CachedImage::imageSizeForRenderer(RenderObject*) method.
bindings/objc/DOM.mm: Ditto (for CachedImage::image()). (-[DOMElement image]): (-[DOMElement _imageTIFFRepresentation]):
bridge/qt/qt_pixmapruntime.cpp: (JSC::Bindings::QtPixmapInstance::variantFromObject): Ditto (for CachedImage::image()).
css/CSSCanvasValue.cpp: s/m_clients/clients()/, which now live in the ImageBySizeCache instead of CSSImageGeneratorValue. (WebCore::CSSCanvasValue::canvasChanged): (WebCore::CSSCanvasValue::canvasResized): (WebCore::CSSCanvasValue::image):
css/CSSGradientValue.cpp: Ditto. (WebCore::CSSGradientValue::image):
css/CSSImageGeneratorValue.cpp: Move the sizes/clients/images cache into a new ImageBySizeCache class, to make it usable for CachedImage as well. (WebCore::CSSImageGeneratorValue::addClient): Adapt to move. (WebCore::CSSImageGeneratorValue::removeClient): Ditto. (WebCore::CSSImageGeneratorValue::getImage): Ditto. (WebCore::CSSImageGeneratorValue::putImage): Ditto.
css/CSSImageGeneratorValue.h: (WebCore::CSSImageGeneratorValue::clients): Forwarded to the ImageBySizeCache.
editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): CachedImage::canRender() now takes a RenderObject* parameter.
html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::width): Use new CachedImage::imageSizeForRenderer(RenderObject*) method. (WebCore::HTMLImageElement::height): Ditto. (WebCore::HTMLImageElement::naturalWidth): Ditto. (WebCore::HTMLImageElement::naturalHeight): Ditto.
html/ImageDocument.cpp: (WebCore::ImageDocumentParser::finish): Ditto. (WebCore::ImageDocument::scale): Ditto. (WebCore::ImageDocument::resizeImageToFit): Ditto. (WebCore::ImageDocument::imageUpdated): Ditto. (WebCore::ImageDocument::restoreImageSize): Ditto. (WebCore::ImageDocument::imageFitsInWindow): Ditto.
html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::wouldTaintOrigin): Use new CachedImage::imageForRenderer(RenderObject*) method.
html/canvas/CanvasRenderingContext2D.cpp: (WebCore::isOriginClean): Ditto. (WebCore::size): Ditto (for CachedImage::imageSizeForRenderer()). (WebCore::CanvasRenderingContext2D::drawImage): Ditto. (WebCore::CanvasRenderingContext2D::createPattern): Ditto.
html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::texImage2D): Ditto. (WebCore::WebGLRenderingContext::texSubImage2D): Ditto.
loader/cache/CachedImage.cpp: Add currently _disabled_ cache for SVGImages. The intrinsic size negotiation will need to use multiple SVGImages for each requested size (equal to the size of the embedding place for the image) - make it possible to cache these SVGImages, and maintain a cache for them. The hash code is a 1:1 refactoring from the already present code in CSSImageGeneratorValue, now named 'ImageBySizeCache'. (WebCore::CachedImage::lookupImageForSize): Looks up an Image from the cache for a given IntSize. Currently turned off. (WebCore::CachedImage::lookupImageForRenderer): Looks up an Image from the cache for a given renderer. Currently turned off. (WebCore::CachedImage::lookupOrCreateImageForRenderer): Looks up an Image from the cache or creates a new SVGImage for a given size and caches it, if possible. Currently turned off. All following changes share this: Don't operate on m_image directly, instead always look up one from the cache for a given size or renderer - if that's not present fallback to m_image. When an SVGImage is first created by CachedImage::createImage() and stored in m_image, the cache remains empty.

If eg. <img width="30" height="70" src="foo.svg"> is used which implies a container size of 30x70 a new SVGImage is created with the additional information of a 30x70 container size
which is immediately passed to the SVGImage after its creation. This SVGImage is put in the ImageBySizeCache associated with a container size of 30x70.
We now have two SVGImage objects present, one living in CachedImage::m_image, created by createImage() during data decoding, and one living in the ImageBySizeCache
created by lookupOrCreateImageForRenderer() associated with the 30x70 container. The first SVGImage::size() will return a value as defined in the referenced foo.svg,
whereas the SVGImage::size() call of the new SVGImage living in the cache reports 30x70 and renders according to that.

Whenever any method of CachedImage is called with a RenderObject* or IntSize, we can't just operate on m_image anymore but instead have to lookup the right
images for a certain renderer/size from the cache and operate on these. When calling eg. CachedImage::image() with a null renderer, m_image is returned.
When passing with a valid renderer only cache lookups are done if the m_image is actually a SVGImage, otherwhise lookupImageForSize/Renderer will just return the m_image.
There is no logical change induced for non-SVGImage derived images.

CachedImage::image() of course needs a RenderObject* parameter now, to identify which of the images from the cache to use, if the underlying image is a SVGImage.
Luckily these information are already present in StyleCachedImage/StyleImage & friends and only need to be added for some additional methods.
(WebCore::CachedImage::image): FIXME
(WebCore::CachedImage::imageForRenderer): Call lookupOrCreateImageForRenderer() instead of returning m_image, if it's not null. Its a no-op for non SVGImage derived objects.
(WebCore::CachedImage::setContainerSizeForRenderer): For non-SVGImages, just pass on the size to the m_image. For SVGImages, associate the passed in renderer with the IntSize in the cache.

This does NOT create the SVGImage yet, this is delayed until imageForRenderer() is called for a given renderer that wants this size.

(WebCore::CachedImage::imageSize): Don't operate on m_image, ask lookupImageForRenderer() with the incoming renderer.
(WebCore::CachedImage::imageRect): Ditto.
(WebCore::CachedImage::clear): Force clearing the m_svgImageCache.
(WebCore::CachedImage::data): Call m_image->size() instead of imageSize(), to avoid having to pass a null renderer to imageSize() as here no renderer is available yet.
(WebCore::CachedImage::destroyDecodedData): Don't destroy decoded data for SVG images, as m_data needs to be accessable at any time to construct a cloned SVGImage.

In future we don't need this anymore if we make sure multiple SVGImages share the same trees, but that's for a follow-up patch.

(WebCore::CachedImage::decodedSizeChanged): Don't operate on m_image, ask lookupImageForRenderer() with the incoming renderer.
(WebCore::CachedImage::didDraw): Ditto.
(WebCore::CachedImage::shouldPauseAnimation): Ditto.
(WebCore::CachedImage::animationAdvanced): Ditto.
(WebCore::CachedImage::changedInRect): Ditto. (eg. when leaving out this change animated SVG images wouldn't update anymore, as the animation didn't happen on m_image!)

loader/cache/CachedImage.h: imageForRenderer/canRender/setContainerSizeForRenderer/imageSizeForRenderer now all take a RenderObject* parameter to identifiy the current user of the image. (WebCore::CachedImage::canRender): Pass on the incoming renderer to imageSizeForRenderer().
page/DragController.cpp: (WebCore::getImage): Use new CachedImage::imageForRenderer(RenderObject*) method.
page/EventHandler.cpp: (WebCore::EventHandler::selectCursor): Ditto.
page/PageSerializer.cpp: (WebCore::PageSerializer::serializeFrame): Ditto. (WebCore::PageSerializer::addImageToResources): Ditto. (WebCore::PageSerializer::retrieveResourcesForCSSDeclaration): Ditto.
page/PageSerializer.h:
platform/chromium/ClipboardChromium.cpp: (WebCore::writeImageToDataObject): Ditto.
platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage): Ditto.
platform/graphics/Image.h: (WebCore::Image::isSVGImage): Add boolean helper to identify SVGImages, just like isBitmapImage().
platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::declareAndWriteDragImage): Use new CachedImage::imageForRenderer(RenderObject*) method.
platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeImage): Ditto.
platform/mac/HTMLConverter.mm: (fileWrapperForElement): Ditto.
platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage): Ditto.
platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::declareAndWriteDragImage): Ditto.
platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeImage): Ditto.
platform/win/ClipboardWin.cpp: (WebCore::writeImageToDataObject): Ditto.
platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage): Ditto.
platform/wince/PasteboardWinCE.cpp: (WebCore::Pasteboard::writeImage): Ditto.
rendering/HitTestResult.cpp: (WebCore::HitTestResult::image): Ditto.
rendering/ImageBySizeCache.cpp: Copied from WebCore/css/CSSImageGeneratorValue.cpp, to preserve history for the original cache code. (WebCore::ImageBySizeCache::ImageBySizeCache): Straight copy from CSSImageGeneratorValue, renamed to ImageBySizeCache, removing all but the cache relevant code. (WebCore::ImageBySizeCache::addClient): Ditto. (WebCore::ImageBySizeCache::removeClient): Ditto. (WebCore::ImageBySizeCache::getImage): Ditto. (WebCore::ImageBySizeCache::putImage): Ditto. (WebCore::ImageBySizeCache::clear): New function, that clears the cache, introduced for the needs of CachedImage. (WebCore::ImageBySizeCache::imageForSize): New function to query an Image* for a given IntSize, introduced for the needs of CachedImage. (WebCore::ImageBySizeCache::sizeForClient): New function to query an IntSize for a given renderer.
rendering/ImageBySizeCache.h: Copied from WebCore/css/CSSImageGeneratorValue.h. (WebCore::ImageBySizeCache::clients):
rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayer): CachedImage::canRender() now takes a RenderObject* parameter. (WebCore::InlineFlowBox::paintBoxDecorations): Ditto. (WebCore::InlineFlowBox::paintMask): Ditto.
rendering/RenderBox.cpp: (WebCore::RenderBox::paintMaskImages): Ditto. (WebCore::RenderBox::repaintLayerRectsForImage): Ditto.
rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Ditto. (WebCore::RenderBoxModelObject::calculateFillTileSize): Ditto (for CachedImage::setContainerSizeForRenderer()). (WebCore::RenderBoxModelObject::paintNinePieceImage): Ditto.
rendering/RenderImage.cpp: (WebCore::RenderImage::imageSizeForError): Use new CachedImage::imageForRenderer(RenderObject*) method. (WebCore::RenderImage::setImageSizeForAltText): Ditto. (WebCore::RenderImage::computeReplacedLogicalWidth): FIXME
rendering/RenderImageResource.cpp: (WebCore::RenderImageResource::setContainerSizeForRenderer): Pass on m_renderer to CachedImage::setContainerSizeForRenderer().
rendering/RenderImageResource.h: Remove constness from setContainerSizeForRenderer. (WebCore::RenderImageResource::image): Pass on m_renderer to CachedImage::image(). (WebCore::RenderImageResource::imageSize): Pass on m_renderer to CachedImage::imageSizeForRenderer().
rendering/RenderImageResourceStyleImage.h: (WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer): Remove constness, pass on m_renderer to StyleImage::setContainerSizeForRenderer().
rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::isDirectlyCompositedImage): Use new CachedImage::imageForRenderer(RenderObject*) method. (WebCore::RenderLayerBacking::updateImageContents): Ditto.
rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::computePreferredLogicalWidths): CachedImage::setContainerSizeForRenderer() now takes a RenderObject* parameter.
rendering/RenderObject.cpp: (WebCore::mustRepaintFillLayers): CachedImage::canRender() now takes a RenderObject* parameter. (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Ditto.
rendering/style/StyleCachedImage.cpp: (WebCore::StyleCachedImage::canRender): Pass on incoming renderer to CachedImage::canRender(). (WebCore::StyleCachedImage::imageSize): Pass on incoming renderer to CachedImage::imageSizeForRenderer(). (WebCore::StyleCachedImage::setContainerSizeForRenderer): Pass on incoming renderer to CachedImage::setContainerSizeForRenderer(). (WebCore::StyleCachedImage::addClient): Remove unneeded return statment in void method. (WebCore::StyleCachedImage::removeClient): Ditto. (WebCore::StyleCachedImage::image): Pass on incoming renderer to CachedImage::image().
rendering/style/StyleCachedImage.h: Add RenderObject* parameter to canRender()/setContainerSizeForRenderer(). image() already has one, that was unused so far.
rendering/style/StyleGeneratedImage.cpp: Inlined setContainerSizeForRenderer.
rendering/style/StyleGeneratedImage.h: (WebCore::StyleGeneratedImage::setContainerSizeForRenderer): Add RenderObject* parameter.
rendering/style/StyleImage.h: (WebCore::StyleImage::canRender): Ditto.
rendering/style/StylePendingImage.h: (WebCore::StylePendingImage::setContainerSizeForRenderer): Ditto.
svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::build): Use new CachedImage::imageForRenderer(RenderObject*) method.
svg/graphics/SVGImage.cpp: Cleanup file, the include hack seems not needed anymore. (WebCore::SVGImage::setContainerSize): s/LayoutSize/IntSize/ to match the code in platform/.
svg/graphics/SVGImage.h: Ditto. (WebCore::SVGImage::isSVGImage): Return true.

1:04 AM Changeset in webkit [97447] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

Make it possible for plugins to get current fullscreen element.
WebCore::Document already has webkitCurrentFullScreenElement().
Add a wrapper for it in WebKit::WebDocument.
https://bugs.webkit.org/show_bug.cgi?id=70076

Patch by Polina Sokolova <polina@chromium.org> on 2011-10-14
Reviewed by Darin Fisher.

public/WebDocument.h:
src/WebDocument.cpp:

(WebKit::WebDocument::securityOrigin):
(WebKit::WebDocument::isHTMLDocument):
(WebKit::WebDocument::isPluginDocument):
(WebKit::WebDocument::fullScreenElement):

12:07 AM Changeset in webkit [97446] by fpizlo@apple.com

4 edits in trunk/Source/JavaScriptCore

Speculation failures in ValueToInt32 are causing a 2x slow-down
in Kraken/stanford-crypto-pbkdf2
https://bugs.webkit.org/show_bug.cgi?id=70089

Reviewed by Gavin Barraclough.

If we can't truncate to Int32 using machine code, then don't fail
speculation. Just call JSC::toInt32.

dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

dfg/DFGOperations.h:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueToInt32):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

12:01 AM QtWebKitBuildBots edited by Csaba Osztrogonác

Update Qt version on the bots (diff)

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed