⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 17, 2011:

11:39 PM Changeset in webkit [97724] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

r97638 caused 3 printing crashes
https://bugs.webkit.org/show_bug.cgi?id=70284

Reviewed by Kent Tamura.

Null check element.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclarations):

11:30 PM Changeset in webkit [97723] by tkent@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r97677.
http://trac.webkit.org/changeset/97677
https://bugs.webkit.org/show_bug.cgi?id=70308

A dependent revision was rolled out. (Requested by tkent on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-17

  • public/WebAccessibilityRole.h:
  • src/AssertMatchingEnums.cpp:
11:23 PM Changeset in webkit [97722] by tkent@chromium.org
  • 2 edits in trunk/Tools

A follow-up of r97716.
https://bugs.webkit.org/show_bug.cgi?id=68803

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::reset): Initialize m_dumpCreateView.

10:50 PM Changeset in webkit [97721] by commit-queue@webkit.org
  • 17 edits
    4 deletes in trunk

Unreviewed, rolling out r97669.
http://trac.webkit.org/changeset/97669
https://bugs.webkit.org/show_bug.cgi?id=70305

Broke accessibility tests on Windows (Requested by rniwa on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-17

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

  • accessibility/AccessibilityMockObject.h:
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::elementAccessibilityHitTest):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::boundingBoxRect):
(WebCore::AccessibilityRenderObject::clearChildren):
(WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilitySpinButton.cpp: Removed.
  • accessibility/AccessibilitySpinButton.h: Removed.
  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::repeatingTimerFired):

  • html/shadow/TextControlInnerElements.h:

LayoutTests:

  • platform/mac/accessibility/html5-input-number-expected.txt: Removed.
  • platform/mac/accessibility/html5-input-number.html: Removed.
10:39 PM Changeset in webkit [97720] by tkent@chromium.org
  • 14 edits
    2 deletes in trunk/Source/WebCore

Remove OptionGroupElement
https://bugs.webkit.org/show_bug.cgi?id=70220

Reviewed by Darin Adler.

No new tests, just a refactoring.

  • CMakeLists.txt: Remove OptionGroupElement.cpp and/or OptionGroupElement.h.
  • GNUMakefile.am.list: ditto.
  • WebCore.gypi: ditto.
  • WebCore.pro: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • dom/DOMAllInOne.cpp: ditto.
  • dom/OptionElement.cpp:

(WebCore::OptionElement::collectOptionTextRespectingGroupLabel):
Use hasTagName(optgroupTag) and static_cast<> instead of toOptionGroupElement().

  • dom/OptionGroupElement.cpp: Removed.
  • dom/OptionGroupElement.h: Removed.
  • html/HTMLOptGroupElement.cpp:

(WebCore::isHTMLOptGroupElement): Added.

  • html/HTMLOptGroupElement.h:
    • Don't inherit OptionGroupElement.
    • Make groupLabelText() non-virtual.
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::recalcListItems):
Use Use hasTagName(optgroupTag) instead of isOptionGroupElement().

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
Use hasTagName(optgroupTag) and static_cast<> instead of toOptionGroupElement().
(WebCore::RenderListBox::paintItemForeground):
Use hasTagName(optgroupTag) instead of isOptionGroupElement().

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::itemText):
Use hasTagName(optgroupTag) and static_cast<> instead of toOptionGroupElement().
(WebCore::RenderMenuList::itemIsEnabled):
Use Use hasTagName(optgroupTag) instead of isOptionGroupElement().
(WebCore::RenderMenuList::itemIsLabel): ditto.

10:32 PM Changeset in webkit [97719] by barraclough@apple.com
  • 6 edits in trunk

Reverted r997709, this caused test failures.

Source/JavaScriptCore:

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSObject.cpp:

(JSC::JSObject::hasProperty):
(JSC::JSObject::hasOwnProperty):

LayoutTests:

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:
10:04 PM Changeset in webkit [97718] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[TexMap][QT] TexMapGL renders a strange one-pixel border of BitmapTexture.
https://bugs.webkit.org/show_bug.cgi?id=70293

TextureMapperGL renders the strange border in
http://www.webkit.org/blog-files/leaves/index.html
Bug occurs because BitmapTexture is larger than the content due to rounding to
NPOT, and its pixel data is never initialized.

Patch by Huang Dongsung <luxtella@company100.net> on 2011-10-17
Reviewed by Noam Rosenthal.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::texImage2DResourceSafe):
(WebCore::BitmapTextureGL::reset):

9:57 PM Changeset in webkit [97717] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update

  • platform/chromium/test_expectations.txt:

Correct a dupe.

9:47 PM Changeset in webkit [97716] by jochen@chromium.org
  • 14 edits
    4 adds in trunk

Source/WebCore: Make NavigationAction wrap a ResourceRequest instead of a KURL.
https://bugs.webkit.org/show_bug.cgi?id=68803

With this, FrameLoaderClient::dispatchCreatePage knows about the
request that will be used for the initial navigaion of the to be
created page.

Reviewed by Nate Chapin.

Test: platform/chromium/fast/loader/create-view-target-blank.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::loadDifferentDocumentItem):
(WebCore::createWindow):

  • loader/NavigationAction.cpp:

(WebCore::NavigationAction::NavigationAction):

  • loader/NavigationAction.h:

(WebCore::NavigationAction::isEmpty):
(WebCore::NavigationAction::url):
(WebCore::NavigationAction::resourceRequest):

  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):

  • page/ContextMenuController.cpp:

(WebCore::openNewWindow):

  • WebCore.exp: updated

Source/WebKit/chromium: Make NavigationAction wrap a ResourceRequest instead of a KURL.
https://bugs.webkit.org/show_bug.cgi?id=68803

Use the request in the NavigationAction, if the FrameLoadRequest
doesn't already contain a request.

Reviewed by Nate Chapin.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::createWindow):

Tools: [chromium] add LayoutTestController.dumpCreateView() to monitor calls to WebViewClient::createView
https://bugs.webkit.org/show_bug.cgi?id=68803

Reviewed by Nate Chapin.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::dumpCreateView):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController::shouldDumpCreateView):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createView):

LayoutTests: Verify that the URL to be opened in the new window is passed by dispatchCreateWindow down to createView.
https://bugs.webkit.org/show_bug.cgi?id=68803

Reviewed by Nate Chapin.

  • platform/chromium/fast/loader/create-view-target-blank-expected.txt: Added.
  • platform/chromium/fast/loader/create-view-target-blank.html: Added.
  • platform/chromium/fast/loader/resources/done.html: Added.
9:37 PM Changeset in webkit [97715] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

XSSAuditor bypass with remote script ending in ? character
https://bugs.webkit.org/show_bug.cgi?id=70255

Patch by Tom Sepez <tsepez@chromium.org> on 2011-10-17
Reviewed by Daniel Bates.

Fix XSSAuditor bypass where unterminated src="" attribute could pick up
text from page causing failed XSS detection. Constrain match to domain
portions of src attribute only.

Source/WebCore:

Test: http/tests/security/xssAuditor/script-tag-with-source-unterminated.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::filterObjectToken):
(WebCore::XSSAuditor::filterParamToken):
(WebCore::XSSAuditor::filterEmbedToken):
(WebCore::XSSAuditor::filterAppletToken):
(WebCore::XSSAuditor::filterIframeToken):
(WebCore::XSSAuditor::eraseAttributeIfInjected):
(WebCore::XSSAuditor::decodedSnippetForAttribute):

  • html/parser/XSSAuditor.h:

LayoutTests:

  • http/tests/security/xssAuditor/script-tag-with-source-unterminated-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-unterminated.html: Added.
9:31 PM Changeset in webkit [97714] by adamk@chromium.org
  • 13 edits
    1 delete in trunk/Source/WebCore

Parse MutationObserverOptions directly into a bitfield
https://bugs.webkit.org/show_bug.cgi?id=70287

Reviewed by Ryosuke Niwa.

Replaces the MutationObserverOptions class with a typedef,
used to pass a bitfield composed of enums defined in
WebKitMutationObserver.h.

No new tests because no behavior should change.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDictionary.h: Removed now-unused method.
  • bindings/js/JSWebKitMutationObserverCustom.cpp:

(WebCore::JSWebKitMutationObserver::observe):

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::observeCallback):

  • dom/MutationObserverOptions.h: Removed.
  • dom/Node.cpp:

(WebCore::Node::registerMutationObserver):

  • dom/Node.h:
  • dom/NodeRareData.h:

(WebCore::MutationObserverEntry::MutationObserverEntry):
(WebCore::MutationObserverEntry::matches):

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::observe):

  • dom/WebKitMutationObserver.h:
9:29 PM Changeset in webkit [97713] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update

  • platform/chromium/test_expectations.txt:

fallback-orientation.html is failing on Linux too.

9:08 PM Changeset in webkit [97712] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Add compile-time asserts for RenderStyle::(Non)InheritedFlags size.
https://bugs.webkit.org/show_bug.cgi?id=69803

Reviewed by Darin Adler.

No new tests.

Adds COMPILE_ASSERTs for the size of RenderStyle::InheritedFlags and
RenderStyle::NonInheritedFlags to ensure that they are not accidentally
grown in future changes.
Change types of unsigned bitfields to unsigned char to ensure that the
above assertions remain true when building on windows.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle):
Adds assertions to ensure struct sizes do not change.

  • rendering/style/RenderStyle.h:

Changes unsigned to unsigned char as outlined above.

9:08 PM Changeset in webkit [97711] by ojan@chromium.org
  • 5 edits in trunk/LayoutTests

Test cleanups after http://trac.webkit.org/changeset/97707.

  • platform/chromium/test_expectations.txt:
  • platform/qt/fast/backgrounds/background-leakage-transforms-expected.txt:
  • platform/qt/fast/table/028-vertical-expected.txt:
  • platform/qt/fast/table/height-percent-test-vertical-expected.txt:
8:41 PM Changeset in webkit [97710] by Nate Chapin
  • 2 edits in trunk/Tools

Add myself to watchlists, and add a watch
for Source/WebCore/loader/.
https://bugs.webkit.org/show_bug.cgi?id=70263

Reviewed by David Levin.

  • Scripts/webkitpy/common/config/watchlist:
8:26 PM Changeset in webkit [97709] by barraclough@apple.com
  • 6 edits in trunk

Source/JavaScriptCore: Rename deregister* to unregister*
https://bugs.webkit.org/show_bug.cgi?id=70272

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2011-10-17
Reviewed by Darin Adler.

Renamed deregisterWeakMap to unregisterWeakMap.

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::unregisterWeakMap):

LayoutTests: Poisoning of strict caller/arguments inappropriately poisoning "in"
https://bugs.webkit.org/show_bug.cgi?id=63398

Reviewed by Sam Weinig.

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:
    • added tests.
8:23 PM Changeset in webkit [97708] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix a new[]/delete mismatch in InnerGestureRecognizerTest that makes valgrind sad
https://bugs.webkit.org/show_bug.cgi?id=70273

Patch by James Robinson <jamesr@chromium.org> on 2011-10-17
Reviewed by Mihai Parparita.

  • tests/InnerGestureRecognizerTest.cpp:

(TouchSequence::~TouchSequence):

8:13 PM Changeset in webkit [97707] by ojan@chromium.org
  • 9 edits in trunk

Unreviewed, rolling out r97662.
http://trac.webkit.org/changeset/97662
https://bugs.webkit.org/show_bug.cgi?id=68497

Was not the cause of the test failures.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):

LayoutTests:

  • platform/mac/fast/backgrounds/background-leakage-transforms-expected.txt:
  • platform/mac/fast/table/028-vertical-expected.png:
  • platform/mac/fast/table/028-vertical-expected.txt:
  • platform/mac/fast/table/height-percent-test-vertical-expected.png:
  • platform/mac/fast/table/height-percent-test-vertical-expected.txt:
  • platform/mac/fast/writing-mode/fallback-orientation-expected.txt:
8:12 PM Changeset in webkit [97706] by rniwa@webkit.org
  • 6 edits in trunk/Source

Rename deregister* to unregister*
https://bugs.webkit.org/show_bug.cgi?id=70272

Reviewed by Darin Adler.

Source/JavaScriptCore:

Renamed deregisterWeakMap to unregisterWeakMap.

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::unregisterWeakMap):

Source/WebCore:

Renamed deregisterHandler to unregisterHandler.

  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.ExtensionServerClient.prototype.unregisterHandler):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onSetOpenResourceHandler):

  • inspector/front-end/HandlerRegistry.js:

(get WebInspector.HandlerRegistry.prototype.unregisterHandler):

8:09 PM Changeset in webkit [97705] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] add test failures after http://trac.webkit.org/changeset/97693.
See https://bugs.webkit.org/show_bug.cgi?id=70300 for more details.

  • platform/chromium/test_expectations.txt:
7:59 PM Changeset in webkit [97704] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/efl

[EFL] Expose the kit() frame function to the rest of ewk.
https://bugs.webkit.org/show_bug.cgi?id=70253

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-17
Reviewed by Antonio Gomes.

Now that we have the EWKPrivate namespace, it makes sense to make the
kit() function accessible there instead of having it as a static local
function in ewk_frame.

While on it, get rid of ewk_frame_core_get, which is obsolete after
EWKPrivate::coreFrame.

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::respondToChangedSelection):

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::callPolicyFunction):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientEfl::didTransferChildFrameToNewDocument):
(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
(WebCore::FrameLoaderClientEfl::dispatchCreatePage):
(WebCore::FrameLoaderClientEfl::createNetworkingContext):

  • ewk/ewk_frame.cpp:

(_ewk_frame_loader_efl_get):
(_ewk_frame_children_iterator_next):
(ewk_frame_child_find):
(ewk_frame_hit_test_new):
(EWKPrivate::kitFrame):

  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp:

(ewk_view_setting_encoding_custom_get):
(ewk_view_setting_encoding_custom_set):

7:25 PM Changeset in webkit [97703] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[TexMap][QT] The BGRA32PremultimpliedBuffer should not inherit the RefCounted class.
https://bugs.webkit.org/show_bug.cgi?id=70098

The BitmapTexture has a BGRA32PremultimpliedBuffer object using OwnPtr, not RefPtr.
It causes following assertion fail, RefCountedBase::m_deletionHasBegun.
It is better that the BGRA32PremultimpliedBuffer does not inherit the RefCounted
because the BitmapTexture only has and uses a BGRA32PremultimpliedBuffer object.

Patch by Huang Dongsung <luxtella@company100.net> on 2011-10-17
Reviewed by Noam Rosenthal.

  • platform/graphics/opengl/TextureMapperGL.h:
7:19 PM Changeset in webkit [97702] by vsevik@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Search in resource crashes when there is no resource with given url.
https://bugs.webkit.org/show_bug.cgi?id=69767

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/search/search-in-non-existing-resource.html

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::searchInResource):

LayoutTests:

  • http/tests/inspector/search/search-in-non-existing-resource-expected.txt: Added.
  • http/tests/inspector/search/search-in-non-existing-resource.html: Added.
7:17 PM Changeset in webkit [97701] by mihnea@adobe.com
  • 88 edits in trunk

[CSS Regions]Change content:-webkit-from-flow to -webkit-flow-from
https://bugs.webkit.org/show_bug.cgi?id=70104

Reviewed by David Hyatt.

  1. -webkit-flow-from is now a property instead of being an addition to content property.
  2. -webkit-flow-from takes an identifier instead of string.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseRegionThread):

  • css/CSSParser.h:
  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::cssText):

  • css/CSSPrimitiveValue.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/regions/bottom-overflow-out-of-first-region.html:
  • fast/regions/content-flowed-into-regions-no-scroll.html:
  • fast/regions/content-webkit-from-flow-parsing-expected.txt:
  • fast/regions/float-pushed-width-change.html:
  • fast/regions/floats-basic-in-variable-width-regions.html:
  • fast/regions/flow-anonymous-children.html:
  • fast/regions/flow-content-basic-vertical-rl.html:
  • fast/regions/flow-content-basic-vertical.html:
  • fast/regions/flow-content-basic.html:
  • fast/regions/flows-dependency-dynamic-remove.html:
  • fast/regions/flows-dependency-same-flow.html:
  • fast/regions/hit-test-float.html:
  • fast/regions/multiple-directionality-changes-in-variable-width-regions.html:
  • fast/regions/no-split-line-box.html:
  • fast/regions/outline-sides-in-region.html:
  • fast/regions/overflow-in-uniform-regions-dynamic.html:
  • fast/regions/overflow-in-uniform-regions.html:
  • fast/regions/overflow-in-variable-width-regions.html:
  • fast/regions/overflow-moving-below-floats-in-variable-width-regions.html:
  • fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html:
  • fast/regions/overflow-rtl-in-variable-width-regions.html:
  • fast/regions/overflow-size-change-in-variable-width-regions.html:
  • fast/regions/overflow-size-change-with-stacking-context-rtl.html:
  • fast/regions/overflow-size-change-with-stacking-context.html:
  • fast/regions/percentage-margins-mixed-ltr-dominant-regions.html:
  • fast/regions/percentage-margins-mixed-rtl-dominant-regions.html:
  • fast/regions/percentage-margins-rtl-variable-width-regions.html:
  • fast/regions/percentage-margins-variable-width-regions.html:
  • fast/regions/position-writing-modes-in-variable-width-regions.html:
  • fast/regions/positioned-objects-block-static-in-regions.html:
  • fast/regions/positioned-objects-block-static-in-rtl-regions.html:
  • fast/regions/positioned-objects-block-static-spanning-regions-rtl.html:
  • fast/regions/positioned-objects-block-static-spanning-regions.html:
  • fast/regions/positioned-objects-in-regions.html:
  • fast/regions/positioned-objects-in-rtl-regions.html:
  • fast/regions/positioned-objects-inline-static-in-regions.html:
  • fast/regions/positioned-objects-inline-static-in-rtl-regions.html:
  • fast/regions/positioned-objects-inline-static-spanning-regions-rtl.html:
  • fast/regions/positioned-objects-inline-static-spanning-regions.html:
  • fast/regions/positioned-objects-perpendicular-flows-in-regions.html:
  • fast/regions/positioned-objects-spanning-regions.html:
  • fast/regions/region-element-dynamic-attach-flow.html:
  • fast/regions/region-element-dynamic-detach-flow.html:
  • fast/regions/region-overflow-auto-overflow-hidden.html:
  • fast/regions/region-overflow-auto-overflow-visible.html:
  • fast/regions/region-overflow-break.html:
  • fast/regions/render-region-renderer.html:
  • fast/regions/resources/region-style.css:

(.regionArticle):

  • fast/regions/script-tests/content-webkit-from-flow-parsing.js:

(testCSSText):
(testComputedStyle):

  • fast/regions/script-tests/region-element-display-restriction.js:

(createRegionElement):

  • fast/regions/text-region-breaks.html:
  • fast/regions/text-region-split-after-resize.html:
  • fast/regions/text-region-split-horizontal-bt.html:
  • fast/regions/text-region-split-small-pagination.html:
  • fast/regions/text-region-split-vertical-rl.html:
  • fast/regions/text-region-split-vertical.html:
  • fast/regions/text-region-split.html:
  • fast/regions/top-overflow-out-of-second-region.html:
  • fast/regions/webkit-flow-double-pagination-float-push.html:
  • fast/regions/webkit-flow-float-pushed-to-last-region.html:
  • fast/regions/webkit-flow-float-unable-to-push.html:
  • fast/regions/webkit-flow-floats-inside-regions-bounds.html:
  • fast/regions/webkit-flow-inlines-dynamic.html:
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl.html:
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html:
  • fast/regions/webkit-flow-inlines-inside-regions-bounds.html:
  • fast/regions/webkit-flow-renderer-layer.html:
  • fast/regions/webkit-flow-renderer-nested.html:
  • fast/regions/webkit-flow-renderer.html:
  • fast/repaint/japanese-rl-selection-repaint-in-regions.html:
  • fast/repaint/line-flow-with-floats-in-regions.html:
  • fast/repaint/overflow-flipped-writing-mode-block-in-regions.html:
  • fast/repaint/region-painting-via-layout.html:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
7:11 PM Changeset in webkit [97700] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Assign a bug for flaky layout tests
https://bugs.webkit.org/show_bug.cgi?id=70298

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
7:03 PM Changeset in webkit [97699] by dpranke@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

platform/chromium/compositing/plugins/webplugin* failing on cg snowleopard
https://bugs.webkit.org/show_bug.cgi?id=70294

Unreviewed, expectations change.

  • platform/chromium-gpu-cg-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.png: Added.
  • platform/chromium-gpu-cg-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt: Added.
  • platform/chromium-gpu-cg-mac/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt: Added.
6:55 PM Changeset in webkit [97698] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-17

  • DEPS:
6:50 PM Changeset in webkit [97697] by haraken@chromium.org
  • 9 edits in trunk

MessageEvent.data can be stored as ScriptValue.
https://bugs.webkit.org/show_bug.cgi?id=68978

Reviewed by Hajime Morita.

Source/WebCore:

Currently, the following test cases fail or crash:

  • shouldBe("new MessageEvent('eventType', { data: test_object }).data", "test_object") -> FAIL
  • new MessageEvent('eventType', { data: document }).data -> CRASH

This is because MessageEvent.data is implemented just as SerializedScriptValue
and it cannot keep ScriptValue passed by JavaScript. This patch makes the following changes:

  • If MessageEvent is constructed with ScriptValue, it is stored as ScriptValue internally.

When MessageEvent.data is called, the ScriptValue is returned.

  • If MessageEvent is constructed with SerializedScriptValue, it is stored as

SerializedScriptValue internally (since we cannot deserialize it into ScriptValue
at this point because of lack of ExecState). When MessageEvent.data is called,
the SerializedScriptValue is deserialized into the corresponding ScriptValue,
and the ScriptValue is returned.

This patch does not make a fix for ObjC bindings code, since we need to first fix
the bug 28774, as commented in dom/MessageEvent.h and dom/MessageEvent.cpp.

Test: fast/events/constructors/message-event-constructor.html

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data): Custom getter for MessageEvent.data. Supported ScriptValue.
(WebCore::JSMessageEvent::initMessageEvent): Changed SerializedScriptValue to ScriptValue.

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter): Custom getter for MessageEvent.data. Supported ScriptValue.
(WebCore::V8MessageEvent::portsAccessorGetter): Removed extra spaces.
(WebCore::V8MessageEvent::initMessageEventCallback): Changed SerializedScriptValue to ScriptValue.

  • dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent): Supported ScriptValue.
(WebCore::MessageEvent::initMessageEvent): Supported ScriptValue.
(WebCore::MessageEvent::isMessageEvent): Removed extra spaces.

  • dom/MessageEvent.h: Added DataType::DataTypeScriptValue.

(WebCore::MessageEvent::create): Supported ScriptValue.
(WebCore::MessageEvent::dataAsScriptValue): Getter for data. Insert ASSERT() to guarantee that this accessor is not called for unintended type of data.
(WebCore::MessageEvent::dataAsSerializedScriptValue): Ditto.
(WebCore::MessageEvent::dataAsString): Ditto.
(WebCore::MessageEvent::dataAsBlob): Ditto.
(WebCore::MessageEvent::dataAsArrayBuffer): Ditto.

  • dom/MessageEvent.idl: Changed SerializedScriptValue to DOMObject (i.e. ScriptValue). This patch does not touch an ObjC part.

LayoutTests:

Removed failures and crashes.

  • fast/events/constructors/message-event-constructor-expected.txt:
  • fast/events/constructors/message-event-constructor.html:
6:38 PM Changeset in webkit [97696] by commit-queue@webkit.org
  • 14 edits in trunk/Source/WebCore

Unified spell-checking and legacy spell checking should be easy to switch
https://bugs.webkit.org/show_bug.cgi?id=69242

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-10-17
Reviewed by Hajime Morita.

WebCore has two different code paths for spell-checking:

1) checkTextOfParagraph() for Snow Leopard or later
2) checkSpellingOfString() for checkGrammarOfString() for other platforms.

This patch introduces a flag to change code paths dynamically.
This patch also includes build fix for QT, GTK, and Windows platforms.

No new tests because this patch does not change a behavior.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::hasMisspelling):

Changed static if-USE(UNIFIED_TEXT_CHECKING) statement to dynamic
condition branch to achieve easy code path change.

  • accessibility/mac/WebAccessibilityObjectWrapper.mm: ditto.

(AXAttributeStringSetSpelling):

  • editing/EditingAllInOne.cpp:
  • editing/Editor.cpp:

(WebCore::Editor::advanceToNextMisspelling): ditto.
(WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection): ditto.
(WebCore::Editor::markMisspellingsAfterTypingToWord): ditto.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): ditto.
(WebCore::Editor::changeBackToReplacedString): ditto.
(WebCore::Editor::markMisspellingsAndBadGrammar): ditto.
(WebCore::Editor::unifiedTextCheckerEnabled):

Utility method to check using unified text checking or not.

  • editing/Editor.h:
  • editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):

Same as WebCore::AccessibilityObject::hasMisspelling.

(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): ditto.
(WebCore::TextCheckingHelper::unifiedTextCheckerEnabled):

Utility method to check using unified text checking or not.

(WebCore::unifiedTextCheckerEnabled): ditto.

  • editing/TextCheckingHelper.h:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

Includes a flag to change the code path.

  • page/Settings.h:

(WebCore::Settings::setUnifiedTextCheckerEnabled):

Sets a flag to change the code path.

(WebCore::Settings::unifiedTextCheckerEnabled):

A flag to change the code path.

6:36 PM Changeset in webkit [97695] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after 97691.

  • html/HTMLTableCellElement.h:

(WebCore::toHTMLTableCellElement): Avoid declaring the same function twice.

6:34 PM Changeset in webkit [97694] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Add a missing semi-colon in ExternalPopupMenu.cpp
https://bugs.webkit.org/show_bug.cgi?id=70232

Patch by Peter Beverloo <peter@chromium.org> on 2011-10-17
Reviewed by Andreas Kling.

  • src/ExternalPopupMenu.cpp:

(WebKit::ExternalPopupMenu::didAcceptIndices):

6:33 PM Changeset in webkit [97693] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

Unreviewed, rolling out r97661.
http://trac.webkit.org/changeset/97661

Confirmed this patch was not the cause of the test failures.

Source/WebCore:

display:inline-block elements don't correctly handle orthogonal writing-modes
https://bugs.webkit.org/show_bug.cgi?id=69957

Reading min/maxPreferredLogicalWidth from a child uses the child's writing-mode.
Instead, we need to grab the result based on the parent's writing-mode.
In the case of orthogonal writing-modes, we need the child's logical height.

Tests: fast/writing-mode/borders-expected.html

fast/writing-mode/borders.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

LayoutTests:

display:inline-block elements don't correctly handle orthogonal writing-modes
https://bugs.webkit.org/show_bug.cgi?id=69957

  • fast/writing-mode/borders-expected.html: Added.
  • fast/writing-mode/borders.html: Added.
6:24 PM Changeset in webkit [97692] by jamesr@google.com
  • 9 edits
    1 delete in trunk/Source

Unreviewed, rolling out r97690.
http://trac.webkit.org/changeset/97690
https://bugs.webkit.org/show_bug.cgi?id=70161

Hits assertion in CCLayerTreeHostTests

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCMainThread.h:
  • platform/graphics/chromium/cc/CCMainThreadTask.h:

(WebCore::createMainThreadTask):

  • platform/graphics/chromium/cc/CCScopedMainThreadProxy.h: Removed.
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxySchedulerClient::scheduleBeginFrameAndCommit):
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::stop):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::testTimeout):
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::CCLayerTreeHostTest::endTest):
(WTF::CCLayerTreeHostTestThreadOnly::runTest):
(WTF::TEST_F):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):

  • tests/CCThreadTest.cpp:

(WebKit::PingPongTestUsingTasks::ping):

6:19 PM Changeset in webkit [97691] by jchaffraix@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove colSpan / rowSpan caching from RenderTableCell
https://bugs.webkit.org/show_bug.cgi?id=69569

Reviewed by Darin Adler.

Memory optimization, no change in behavior expected.

This change removes m_colSpan & m_rowSpan from RenderTableCell (inspired by
kling's memory shaving effort).

This makes us save 8 bytes per RenderTableCell on my machine (x86-64). No slowdown
on PageCycler Alexa-US.

This change refactored the way we handle updates from the DOM side to simplify
the code using the following: colspan / rowspan updates always go through
parseMappedAttribute where we already check for the renderer type. Thus removed the
generic updateFromElement and replaced it with colSpanOrRowSpanChanged. This removes
a virtual dispatch.

As there is no way to know if an attribute has changed in the parseMappedAttribute code,
we now unconditionally call colSpanOrRowSpanChanged. Looking at Chromium's page data,
colSpan and rowSpan are never changed outside the HTML markup thus such a change should
have a limited impact.

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::parseMappedAttribute): Updated after updateFromElement
removal.

  • html/HTMLTableCellElement.h:

(WebCore::toHTMLTableCellElement): Added the usual conversion functions.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::RenderTableCell): Added a boolean to know if we have
the right type of associated DOM node to avoid the cost of checking that every
time.

(WebCore::RenderTableCell::colSpan):
(WebCore::RenderTableCell::rowSpan):
Forwarded the calls to our object if we have the right type (normal case).

(WebCore::RenderTableCell::colSpanOrRowSpanChanged): Handles the
updateFromElement calls but in a more streamlined way.

  • rendering/RenderTableCell.h:
6:15 PM Changeset in webkit [97690] by jamesr@google.com
  • 9 edits
    1 add in trunk/Source

[chromium] Fix shutdown race when posting main thread task to CCThreadProxy and enable tests
https://bugs.webkit.org/show_bug.cgi?id=70161

Reviewed by David Levin.

Source/WebCore:

Adds a weak pointer mechanism to cancel main thread tasks posted to CCThreadProxy instances from the compositor
thread. Previously there was a race condition where main thread tasks could run even after the CCThreadProxy was
destroyed.

This race does not exist in the other direction because when tearing down a CCThreadProxy we first post a quit
task to the compositor thread and then suspend execution of the main thread until all compositor tasks for the
CCThreadProxy have been drained.

Covered by the now-enabled CCLayerTreeHostTest* unit tests.

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCScopedMainThreadProxy.h: Added.

(WebCore::CCScopedMainThreadProxy::create):
(WebCore::CCScopedMainThreadProxy::postTask):
(WebCore::CCScopedMainThreadProxy::shutdown):
(WebCore::CCScopedMainThreadProxy::CCScopedMainThreadProxy):
(WebCore::CCScopedMainThreadProxy::runTaskIfNotShutdown):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

Enables the CCLayerTreeHostTest* tests by default. Most tests are run twice in a single thread and multiple
thread configuration. Some tests run only in the multiple thread configuration if they depend on the compositor
thread scheduling draws by itself.

  • tests/CCLayerTreeHostTest.cpp:

(::CCLayerTreeHostTest::timeout):
(::CCLayerTreeHostTest::clearTimeout):
(::CCLayerTreeHostTest::CCLayerTreeHostTest):
(::CCLayerTreeHostTest::onEndTest):
(::CCLayerTreeHostTest::TimeoutTask::TimeoutTask):
(::CCLayerTreeHostTest::TimeoutTask::clearTest):
(::CCLayerTreeHostTest::TimeoutTask::~TimeoutTask):
(::CCLayerTreeHostTest::TimeoutTask::Run):
(::CCLayerTreeHostTest::runTest):
(::CCLayerTreeHostTest::doBeginTest):
(::CCLayerTreeHostTestThreadOnly::runTest):
(::CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):

6:12 PM Changeset in webkit [97689] by tkent@chromium.org
  • 15 edits in branches/chromium/874

Merge 97351 - REGRESSION(r89915): <input type=email multiple> don't show the default value
https://bugs.webkit.org/show_bug.cgi?id=69895

Reviewed by Hajime Morita.

Source/WebCore:

m_valueIfDirty became unexpectedly empty because
EmailInputType::sanitizeValue() returned an empty string for a
null input string.

To solve this issue, HTMLInputElement::sanitizeValue() checks
nullness, and remove the null check of sanitizeValue() of
InputType subclasses.
Also, we make InputType::sanitizeValue() const.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::sanitizeValue):

  • Make this const.
  • Remove null check.
  • html/ColorInputType.h: Make sanitizeValue() const.
  • html/EmailInputType.cpp:

(WebCore::EmailInputType::sanitizeValue): Make this const.

  • html/EmailInputType.h: Make sanitizeValue() const.
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::sanitizeValue):
(WebCore::HTMLInputElement::updateValueIfNeeded):

  • html/InputType.cpp:

(WebCore::InputType::sanitizeValue):
Returns a null string if the input string is null, and
don't call InputType::sanitizeValue() in this case.

  • html/InputType.h: Make sanitizeValue() const.
  • html/NumberInputType.cpp:

(WebCore::NumberInputType::sanitizeValue): Make this const.

  • html/NumberInputType.h: Make sanitizeValue() const.
  • html/RangeInputType.cpp:

(WebCore::RangeInputType::sanitizeValue):

  • Make this const.
  • Remove null check.
  • html/RangeInputType.h: Make sanitizeValue() const.
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::sanitizeValue): Make this const.

  • html/TextFieldInputType.h: Make sanitizeValue() const.

LayoutTests:

  • fast/forms/input-value-sanitization-expected.txt:
  • fast/forms/input-value-sanitization.html:

TBR=tkent@chromium.org
BUG=http://code.google.com/p/chromium/issues/detail?id=99829
Review URL: http://codereview.chromium.org/8336009

6:10 PM Changeset in webkit [97688] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r97641.
http://trac.webkit.org/changeset/97641
https://bugs.webkit.org/show_bug.cgi?id=70288

"This change may have broken mouse/hit-test coordinate tests."
(Requested by jeffm7 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-17

  • platform/Widget.cpp:

(WebCore::Widget::convertFromContainingWindow):
(WebCore::Widget::convertToContainingWindow):

6:07 PM Changeset in webkit [97687] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSParser: Remove unused variable 'propertyComponents'
https://bugs.webkit.org/show_bug.cgi?id=70230

Patch by Andreas Kling <kling@webkit.org> on 2011-10-17
Reviewed by Darin Adler.

(WebCore::CSSParser::markPropertyEnd):

5:56 PM Changeset in webkit [97686] by imasaki@chromium.org
  • 1 edit
    20 adds
    2 deletes in trunk/LayoutTests

[Chromium] rebaseline fullscreen layout tests using rebaseline tools.
https://bugs.webkit.org/show_bug.cgi?id=70165

Reviewed by David Levin.

  • platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png: Added.
  • platform/chromium-cg-mac/fullscreen/full-screen-iframe-zIndex-expected.png: Removed.
  • platform/chromium-cg-mac/fullscreen/full-screen-zIndex-after-expected.png: Removed.
  • platform/chromium-linux/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
  • platform/chromium-linux/fullscreen/full-screen-render-inline-expected.png: Added.
  • platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.png: Added.
  • platform/chromium-linux/fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
  • platform/chromium-mac-leopard/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-mac-leopard/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
  • platform/chromium-mac-leopard/fullscreen/full-screen-zIndex-after-expected.png: Added.
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png: Added.
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-zIndex-after-expected.png: Added.
  • platform/chromium-win/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
  • platform/chromium-win/fullscreen/full-screen-stacking-context-expected.png: Added.
  • platform/chromium/fullscreen/video-controls-override-expected.txt: Added.
5:54 PM Changeset in webkit [97685] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Update comments about transform hierarchy in CCLayerTreeHostCommon
https://bugs.webkit.org/show_bug.cgi?id=69765

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-10-17
Reviewed by James Robinson.

Only comments changed, no tests needed.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

5:46 PM Changeset in webkit [97684] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] DRT: Make non-recognized keys work in events as well.
https://bugs.webkit.org/show_bug.cgi?id=69860

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-17
Reviewed by Antonio Gomes.

fast/forms/select-type-ahead-non-latin.html is the canonical case we fix
here: it has a select box with a few non-latin options, and one of them
is selected via the keyboard.

In this specific case, we need to make EventHandler::keyEvent send a
keyPressEvent to SelectElement, so that
SelectElement::defaultEventHandler calls typeAheadFind(). This happens
only when PlatformKeyEvent::text() is not empty, which was not the case
so far.

  • DumpRenderTree/efl/EventSender.cpp:

(keyDownCallback):

5:45 PM Changeset in webkit [97683] by jchaffraix@webkit.org
  • 1 edit
    8 adds in trunk/LayoutTests
ASSERTION FAILED: !m_layoutRoot->container()
!m_layoutRoot->container()->needsLayout() with generated content

https://bugs.webkit.org/show_bug.cgi?id=61411

Reviewed by Andy Estes.

The bug was fixed by r95926 or bug 62120. Landing the tests from the bug.

  • fast/dynamic/crash-generated-counter-expected.txt: Added.
  • fast/dynamic/crash-generated-counter.html: Added.
  • fast/dynamic/crash-generated-image-expected.txt: Added.
  • fast/dynamic/crash-generated-image.html: Added.
  • fast/dynamic/crash-generated-quote-expected.txt: Added.
  • fast/dynamic/crash-generated-quote.html: Added.
  • fast/dynamic/crash-generated-text-expected.txt: Added.
  • fast/dynamic/crash-generated-text.html: Added.
5:44 PM Changeset in webkit [97682] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Do not check for Frame::contentRenderer() in ewk_view_repaint.
https://bugs.webkit.org/show_bug.cgi?id=70118

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-17
Reviewed by Kenneth Rohde Christiansen.

When we have a scrollbar with an actual width, there might be a call
to ChromeClientEfl::invalidateContentsAndWindow() after
Document::detach() was called, making the call to contentRenderer()
return 0 even though everything is fine.

Example test case: animations/animation-shorthand.html.

  • ewk/ewk_view.cpp:

(ewk_view_repaint):

5:41 PM Changeset in webkit [97681] by jonlee@apple.com
  • 2 edits in trunk/Source/WebKit2

Filtering of URLs when serializing back forward list saves bad current index value
https://bugs.webkit.org/show_bug.cgi?id=70282
<rdar://problem/10057763>

Reviewed by Sam Weinig.

When reading the serialized b-f list, perform a sanity check on the current index.
If it is invalid, we set it to NoCurrentItemIndex to prevent further corruption of
the list.

When serializing the b-f list, currentIndex can be negative in the case where the list
has one item only, and that item gets filtered out. In this instance currentIndex should
just be -1. A crashing case showed an index that was more negative, a situation that I
could not replicate. Since this value will get cleaned up when the b-f list is restored,
I just strengthened the assertion to check for a more negative index in case we run into it again.

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Update the assertion
in case we go beyond NoCurrentItemIndex (which, as an int, is -1).
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation):

5:36 PM BuildingGtk edited by Martin Robinson
(diff)
5:33 PM Changeset in webkit [97680] by barraclough@apple.com
  • 5 edits in trunk

Exception ordering in String.prototype.replace
https://bugs.webkit.org/show_bug.cgi?id=70290

Source/JavaScriptCore:

If pattern is not a regexp, it should be converted toString before the replacement value has it's toString conversion called.

Reviewed by Oliver Hunt.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace):

LayoutTests:

Reviewed by Oliver Hunt.

  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T11-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T12-expected.txt:
    • Check in passing results.
5:26 PM Changeset in webkit [97679] by vrk@chromium.org
  • 4 edits in branches/chromium/874/Source

Merge 97451 - Clear WebMediaPlayerClientImpl back pointer on destruction
https://bugs.webkit.org/show_bug.cgi?id=69973

Reviewed by James Robinson.

Clear the backpointer and remove the unused m_currentFrame

Source/WebCore:

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::cleanupResources):
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::releaseProvider):

  • platform/graphics/chromium/VideoLayerChromium.h:

Source/WebKit/chromium:

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::load):
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):

  • src/WebMediaPlayerClientImpl.h:

TBR=jschuh@chromium.org
Review URL: http://codereview.chromium.org/8333009

5:07 PM Changeset in webkit [97678] by alokp@chromium.org
  • 6 edits
    12 adds in trunk

Add layout tests for WebPlugin compositor path
https://bugs.webkit.org/show_bug.cgi?id=69027

Reviewed by James Robinson.

Source/WebKit/chromium:

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::printEnd):

Tools:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestWebPlugin.cpp: Added.

(premultiplyAlpha):
(TestWebPlugin::TestWebPlugin):
(TestWebPlugin::~TestWebPlugin):
(TestWebPlugin::mimeType):
(TestWebPlugin::initialize):
(TestWebPlugin::destroy):
(TestWebPlugin::updateGeometry):
(TestWebPlugin::parsePrimitive):
(TestWebPlugin::parseColor):
(TestWebPlugin::parseOpacity):
(TestWebPlugin::initScene):
(TestWebPlugin::drawScene):
(TestWebPlugin::destroyScene):
(TestWebPlugin::initProgram):
(TestWebPlugin::initPrimitive):
(TestWebPlugin::drawPrimitive):
(TestWebPlugin::loadShader):
(TestWebPlugin::loadProgram):

  • DumpRenderTree/chromium/TestWebPlugin.h: Added.

(TestWebPlugin::scriptableObject):
(TestWebPlugin::paint):
(TestWebPlugin::updateFocus):
(TestWebPlugin::updateVisibility):
(TestWebPlugin::acceptsInputEvents):
(TestWebPlugin::handleInputEvent):
(TestWebPlugin::didReceiveResponse):
(TestWebPlugin::didReceiveData):
(TestWebPlugin::didFinishLoading):
(TestWebPlugin::didFailLoading):
(TestWebPlugin::didFinishLoadingFrameRequest):
(TestWebPlugin::didFailLoadingFrameRequest):
(TestWebPlugin::Scene::Scene):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createPlugin):

LayoutTests:

  • platform/chromium/compositing/plugins: Added.
  • platform/chromium/compositing/plugins/webplugin-alpha-expected.png: Added.
  • platform/chromium/compositing/plugins/webplugin-alpha-expected.txt: Added.
  • platform/chromium/compositing/plugins/webplugin-alpha.html: Added.
  • platform/chromium/compositing/plugins/webplugin-no-alpha-expected.png: Added.
  • platform/chromium/compositing/plugins/webplugin-no-alpha-expected.txt: Added.
  • platform/chromium/compositing/plugins/webplugin-no-alpha.html: Added.
  • platform/chromium/compositing/plugins/webplugin-reflection-expected.png: Added.
  • platform/chromium/compositing/plugins/webplugin-reflection-expected.txt: Added.
  • platform/chromium/compositing/plugins/webplugin-reflection.html: Added.
4:57 PM Changeset in webkit [97677] by Chris Fleizach
  • 3 edits in trunk/Source/WebKit/chromium

AX: buttons of number type <input> controls are not fully accessible
https://bugs.webkit.org/show_bug.cgi?id=70241

Build fix. Fix matching enums.

  • public/WebAccessibilityRole.h:
  • src/AssertMatchingEnums.cpp:
4:54 PM Changeset in webkit [97676] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Set a default charset when creating a view.
https://bugs.webkit.org/show_bug.cgi?id=69771

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-17
Reviewed by Antonio Gomes.

Most (or all) ports default to iso-8859-1 when creating a view (or their
equivalent of a view), so we should do that too.

This makes fast/dom/Document/document-charset.html pass.

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

4:54 PM Changeset in webkit [97675] by fpizlo@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

DFG bytecode parser should understand inline stacks
https://bugs.webkit.org/show_bug.cgi?id=70278

Reviewed by Oliver Hunt.

The DFG bytecode parser is now capable of parsing multiple code blocks at
once. This remains turned off since not all inlining functionality is
implemented.

This required making a few changes elsewhere in the system. The bytecode
parser now may do some of the same things that the bytecode generator does,
like allocating constants and identifiers. Basic block linking relies on
bytecode indices, which are only meaningful within the context of one basic
block. This is fine, so long as linking is done eagerly whenever switching
from one code block to another.

  • bytecode/CodeOrigin.h:

(JSC::CodeOrigin::CodeOrigin):

  • bytecompiler/BytecodeGenerator.h:
  • dfg/DFGBasicBlock.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getThis):
(JSC::DFG::ByteCodeParser::setThis):
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::InlineStackEntry::executable):
(JSC::DFG::ByteCodeParser::InlineStackEntry::~InlineStackEntry):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::linkBlocks):
(JSC::DFG::ByteCodeParser::setupPredecessors):
(JSC::DFG::ByteCodeParser::buildOperandMapsIfNecessary):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGGraph.h:

(JSC::DFG::GetBytecodeBeginForBlock::GetBytecodeBeginForBlock):
(JSC::DFG::GetBytecodeBeginForBlock::operator()):
(JSC::DFG::Graph::blockIndexForBytecodeOffset):

  • dfg/DFGNode.h:
  • runtime/Identifier.h:

(JSC::IdentifierMapIndexHashTraits::emptyValue):

  • runtime/JSValue.h:
  • wtf/StdLibExtras.h:

(WTF::binarySearchWithFunctor):

4:51 PM Changeset in webkit [97674] by dimich@chromium.org
  • 4 edits in branches/chromium/874/Source/WebCore

Merge 97667 - Re-landing: window.webkitNotifications uses deallocated NotificationPresenter after live Iframe transfer.
https://bugs.webkit.org/show_bug.cgi?id=70147

Reviewed by David Levin.

I only found a way to test this manually, since Chromium TestShell uses static instance
of NotificationPresenter instead of per-page one so the issue does not reproduce.
Adding manual test that works in full build of Chromium.

  • manual-tests/iframe_notifications/iframe-reparenting-close-window-child.html: Added.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window-iframe.html: Added.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window.html: Added.
  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::disconnectFrame):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::resetNotifications):

  • page/DOMWindow.h:
  • page/Frame.cpp:

(WebCore::Frame::transferChildFrameToNewDocument): reset webkitNotifications object.

TBR=dimich@chromium.org
Review URL: http://codereview.chromium.org/8333006

4:49 PM Changeset in webkit [97673] by barraclough@apple.com
  • 9 edits in trunk

Incorrect behavior from String match/search & undefined pattern
https://bugs.webkit.org/show_bug.cgi?id=70286

Reviewed by Sam weinig.

Source/JavaScriptCore:

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncMatch):

  • In case of undefined, pattern is "".

(JSC::stringProtoFuncSearch):

  • In case of undefined, pattern is "".

LayoutTests:

  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T4-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T6-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T7-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T8-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T9-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T4-expected.txt:
    • Check in passing results.
4:42 PM Changeset in webkit [97672] by rniwa@webkit.org
  • 5 edits in trunk/Tools

[nrwt] Add new category for MISSING
https://bugs.webkit.org/show_bug.cgi?id=69990

Reviewed by Dirk Pranke.

Treat missing results as a new category in summerize_results.

Because Chromium port wants to turn bots red when there are tests with missing results,
extracted the logic to compute the exit code as exit_code_from_summarized_results in
base and chromium ports.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4:41 PM Changeset in webkit [97671] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Remove unnecessary calls to columnRectAt()
https://bugs.webkit.org/show_bug.cgi?id=70283

Reviewed by Darin Adler.

These call sites only needed one of the column dimensions, which are independent of the column
index, and can be retrieved directly from the ColumnInfo.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::hitTestColumns):

4:40 PM Changeset in webkit [97670] by commit-queue@webkit.org
  • 18 edits in trunk/Source/WebCore

Protect against incorrect Element::fast*Attribute() usage.
https://bugs.webkit.org/show_bug.cgi?id=67612

Patch by Andreas Kling <kling@webkit.org> on 2011-10-17
Reviewed by Darin Adler.

Add debug-only checks in Element's fastHasAttribute() and fastGetAttribute() to verify
that we aren't looking up the "style" attribute or any of the SVG animatable attributes.

No new tests, erroneous behavior is covered by assertions.

  • WebCore.exp.in: Export Element::fastAttributeLookupAllowed() for debug builds

since it's used by the inline fast*Attribute() calls.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement): Use getAttribute() for class.

  • css/SelectorChecker.cpp:

(WebCore::linkAttribute): Use getAttribute() for xlink:href.

  • dom/Element.cpp:

(WebCore::Element::getAttribute): Manually inline fastGetAttribute() in ideal case.
(WebCore::Element::fastAttributeLookupAllowed): Checks if an attribute can be used
with the fast lookup functions.

  • dom/Element.h:

(WebCore::Element::fastHasAttribute): Add assertion.
(WebCore::Element::fastGetAttribute): Ditto.

  • editing/ApplyStyleCommand.cpp:

(WebCore::hasNoAttributeOrOnlyStyleAttribute): Use getAttribute() for class.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::isInlineNodeWithStyle): Ditto.

  • html/ClassList.cpp:

(WebCore::ClassList::ClassList): Ditto.
(WebCore::ClassList::addInternal): Ditto.
(WebCore::ClassList::removeInternal): Ditto.
(WebCore::ClassList::toString): Ditto.

  • svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::hasValidGlyphElements): Use getAttribute() for xlink:href.

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::rotateMode): Use getAttribute() for rotate.

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::animationMode): Use getAttribute() for values.

  • svg/SVGElement.cpp:

(WebCore::SVGElement::isAnimatableAttribute): Added, returns true if the given
QualifiedName represents an animatable attribute.

  • svg/SVGElement.h:
  • svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::srcValue): Use getAttribute() for xlink:href.
(WebCore::SVGFontFaceUriElement::loadFont): Ditto.

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::xlinkHref): Ditto.

  • svg/SVGGlyphRefElement.cpp:

(WebCore::SVGGlyphRefElement::hasValidGlyphElement): Ditto.

  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::type): Use getAttribute() for type.

4:37 PM Changeset in webkit [97669] by Chris Fleizach
  • 17 edits
    4 adds in trunk

AX: buttons of number type <input> controls are not fully accessible
https://bugs.webkit.org/show_bug.cgi?id=70241

Source/WebCore:

Expose the spin button object to the AX hierarchy. Since there is no distinct
render object that backs this object, a mock object needs to be created for the entire
spin button and the actual increment and decrement buttons inside.

Reviewed by Darin Adler.

Test: platform/mac/accessibility/html5-input-number.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

  • accessibility/AccessibilityMockObject.cpp:

(WebCore::AccessibilityMockObject::AccessibilityMockObject):

  • accessibility/AccessibilityMockObject.h:

(WebCore::AccessibilityMockObject::isMockObject):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::boundingBoxForQuads):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isSpinButton):
(WebCore::AccessibilityObject::isSpinButtonPart):
(WebCore::AccessibilityObject::isMockObject):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::boundingBoxRect):
(WebCore::AccessibilityRenderObject::addImageMapChildren):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilitySpinButton.cpp: Added.

(WebCore::AccessibilitySpinButton::create):
(WebCore::AccessibilitySpinButton::AccessibilitySpinButton):
(WebCore::AccessibilitySpinButton::~AccessibilitySpinButton):
(WebCore::AccessibilitySpinButton::incrementButton):
(WebCore::AccessibilitySpinButton::decrementButton):
(WebCore::AccessibilitySpinButton::elementRect):
(WebCore::AccessibilitySpinButton::addChildren):
(WebCore::AccessibilitySpinButton::step):
(WebCore::AccessibilitySpinButtonPart::AccessibilitySpinButtonPart):
(WebCore::AccessibilitySpinButtonPart::create):
(WebCore::AccessibilitySpinButtonPart::elementRect):
(WebCore::AccessibilitySpinButtonPart::press):

  • accessibility/AccessibilitySpinButton.h: Added.

(WebCore::AccessibilitySpinButton::setSpinButtonElement):
(WebCore::AccessibilitySpinButton::roleValue):
(WebCore::AccessibilitySpinButton::accessibilityIsIgnored):
(WebCore::AccessibilitySpinButton::isSpinButton):
(WebCore::AccessibilitySpinButtonPart::~AccessibilitySpinButtonPart):
(WebCore::AccessibilitySpinButtonPart::isIncrementor):
(WebCore::AccessibilitySpinButtonPart::setIsIncrementor):
(WebCore::AccessibilitySpinButtonPart::roleValue):
(WebCore::AccessibilitySpinButtonPart::isSpinButtonPart):
(WebCore::AccessibilitySpinButtonPart::accessibilityIsIgnored):
(WebCore::toAccessibilitySpinButton):
(WebCore::toAccessibilitySpinButtonPart):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::step):
(WebCore::SpinButtonElement::repeatingTimerFired):

  • html/shadow/TextControlInnerElements.h:

LayoutTests:

Reviewed by Darin Adler.

  • platform/mac/accessibility/html5-input-number-expected.txt: Added.
  • platform/mac/accessibility/html5-input-number.html: Added.
4:34 PM Changeset in webkit [97668] by Lucas Forschler
  • 8 edits in tags/Safari-535.6.2/Source

Merged r97514.

4:30 PM Changeset in webkit [97667] by dimich@chromium.org
  • 5 edits
    3 adds in trunk/Source/WebCore

Re-landing: window.webkitNotifications uses deallocated NotificationPresenter after live Iframe transfer.
https://bugs.webkit.org/show_bug.cgi?id=70147

Reviewed by David Levin.

I only found a way to test this manually, since Chromium TestShell uses static instance
of NotificationPresenter instead of per-page one so the issue does not reproduce.
Adding manual test that works in full build of Chromium.

  • manual-tests/iframe_notifications/iframe-reparenting-close-window-child.html: Added.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window-iframe.html: Added.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window.html: Added.
  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::disconnectFrame):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::resetNotifications):

  • page/DOMWindow.h:
  • page/Frame.cpp:

(WebCore::Frame::transferChildFrameToNewDocument): reset webkitNotifications object.

4:26 PM Changeset in webkit [97666] by Lucas Forschler
  • 5 edits in tags/Safari-535.6.2/Source

Versioning.

4:22 PM Changeset in webkit [97665] by Lucas Forschler
  • 1 copy in tags/Safari-535.6.2

New Tag.

4:15 PM Changeset in webkit [97664] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

quote "attributes" keyword in CodeGeneratorGObject.pm
https://bugs.webkit.org/show_bug.cgi?id=64348

Patch by Arno Renevier <arno@renevier.net> on 2011-10-17
Reviewed by Darin Adler.

No change of functionality. No new tests.

  • bindings/scripts/CodeGeneratorGObject.pm:
4:12 PM Changeset in webkit [97663] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

More tweaking of chromium fullscreen expectations.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
3:56 PM Changeset in webkit [97662] by ojan@chromium.org
  • 9 edits in trunk

Unreviewed, rolling out r97654.
http://trac.webkit.org/changeset/97654
https://bugs.webkit.org/show_bug.cgi?id=68497

Caused a number of Chromium failures.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):

LayoutTests:

  • platform/mac/fast/backgrounds/background-leakage-transforms-expected.txt:
  • platform/mac/fast/table/028-vertical-expected.png:
  • platform/mac/fast/table/028-vertical-expected.txt:
  • platform/mac/fast/table/height-percent-test-vertical-expected.png:
  • platform/mac/fast/table/height-percent-test-vertical-expected.txt:
  • platform/mac/fast/writing-mode/fallback-orientation-expected.txt:
3:53 PM Changeset in webkit [97661] by ojan@chromium.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r97653.
http://trac.webkit.org/changeset/97653
https://bugs.webkit.org/show_bug.cgi?id=69957

Caused a number of Chromium failures.

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

LayoutTests:

  • fast/writing-mode/borders-expected.html: Removed.
  • fast/writing-mode/borders.html: Removed.
3:38 PM Changeset in webkit [97660] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

fullscreen/video-controls-override.html is still failing on chromium bots.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
3:31 PM Changeset in webkit [97659] by adamk@chromium.org
  • 13 edits
    2 adds in trunk

[MutationObservers] Implement WebKitMutationObserver.observe for attributes
https://bugs.webkit.org/show_bug.cgi?id=68956

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-10-17
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/mutation/observe-attributes.html

This adds an initial implementation for registering mutation observers on nodes,
delivering mutation records at the end of the outer-most script invokation and
observing mutations to element attributes.

Note that the outer-most script invokation only works in V8.

Note also that support for observing changes to the style attribute when updated
via the style property is not implemented here.

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::didLeaveScriptContext):

  • dom/Element.cpp:

(WebCore::enqueueAttributesMutationRecord):
(WebCore::Element::setAttribute):

  • dom/MutationRecord.cpp:

(WebCore::MutationRecord::createAttributes):

  • dom/MutationRecord.h:
  • dom/MutationRecord.idl:
  • dom/Node.cpp:

(WebCore::Node::clearRareData):
(WebCore::Node::mutationObserverData):
(WebCore::Node::ensureMutationObserverData):
(WebCore::Node::registeredMutationObserversOfType):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::deregisterMutationObserver):

  • dom/Node.h:
  • dom/NodeRareData.h:

(WebCore::MutationObserverRegistration::MutationObserverRegistration):
(WebCore::MutationObserverRegistration::operator==):
(WebCore::MutationObserverData::MutationObserverData):
(WebCore::MutationObserverData::~MutationObserverData):
(WebCore::NodeRareData::mutationObserverData):
(WebCore::NodeRareData::ensureMutationObserverData):

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::observe):
(WebCore::WebKitMutationObserver::disconnect):
(WebCore::WebKitMutationObserver::wasDeregistered):
(WebCore::activeMutationObservers):
(WebCore::WebKitMutationObserver::enqueueMutationRecord):
(WebCore::WebKitMutationObserver::deliverAllMutations):
(WebCore::WebKitMutationObserver::deliver):

  • dom/WebKitMutationObserver.h:

LayoutTests:

  • fast/mutation/observe-attributes-expected.txt: Added.
  • fast/mutation/observe-attributes.html: Added.
3:30 PM Changeset in webkit [97658] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

HTMLKeygenElement: Don't cache keytype and challenge attributes.
https://bugs.webkit.org/show_bug.cgi?id=68365

Patch by Andreas Kling <kling@webkit.org> on 2011-10-17
Reviewed by Darin Adler.

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::parseMappedAttribute):
(WebCore::HTMLKeygenElement::appendFormData):

  • html/HTMLKeygenElement.h:
3:21 PM Changeset in webkit [97657] by dpranke@chromium.org
  • 3 edits in trunk/LayoutTests

Update chromium gpu baselines for fast/canvas/canvas-composite-transformclip.html .

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
2:54 PM Changeset in webkit [97656] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Remove some expectations that are no longer failing.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
2:51 PM Changeset in webkit [97655] by barraclough@apple.com
  • 5 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=70207
After deleting defineSetter, it is absent but appears in name list

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertyNames):

  • This should check whether static functions have been reified.

LayoutTests:

  • fast/js/delete-syntax-expected.txt:
  • fast/js/script-tests/delete-syntax.js:
    • Added test case for getOwnPropertyNames.
2:50 PM Changeset in webkit [97654] by ojan@chromium.org
  • 9 edits in trunk

incorrect height with height:auto and writing-mode:vertical-rl
https://bugs.webkit.org/show_bug.cgi?id=68497

Reviewed by David Hyatt.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):

LayoutTests:

I'm not sure I completely understand the changes to the height/width
of the body/html elements, but the new height/width look correct to me.

  • platform/mac/fast/backgrounds/background-leakage-transforms-expected.txt:
  • platform/mac/fast/table/028-vertical-expected.txt:
  • platform/mac/fast/table/height-percent-test-vertical-expected.txt:
  • platform/mac/fast/writing-mode/fallback-orientation-expected.txt:
2:46 PM Changeset in webkit [97653] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

display:inline-block elements don't correctly handle orthogonal writing-modes
https://bugs.webkit.org/show_bug.cgi?id=69957

Reviewed by David Hyatt.

Source/WebCore:

Reading min/maxPreferredLogicalWidth from a child uses the child's writing-mode.
Instead, we need to grab the result based on the parent's writing-mode.
In the case of orthogonal writing-modes, we need the child's logical height.

Tests: fast/writing-mode/borders-expected.html

fast/writing-mode/borders.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

LayoutTests:

  • fast/writing-mode/borders-expected.html: Added.
  • fast/writing-mode/borders.html: Added.
2:42 PM Changeset in webkit [97652] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, expectations change.

Add back in the failing fullscreen tests; also add in some
flaky failures.

  • platform/chromium/test_expectations.txt:
2:41 PM Changeset in webkit [97651] by arv@chromium.org
  • 4 edits in trunk/LayoutTests

REGRESSION(r97566) fast/js/stack-overflow-arrity-catch.html fails
https://bugs.webkit.org/show_bug.cgi?id=70210

Reviewed by Darin Adler.

Change the test to not call debug() inside the test functions since that fails on V8
because we are already at the maximum allowed stack depth.

  • fast/js/script-tests/stack-overflow-arrity-catch.js:

(test1): Changed to not call debug but set a boolean variable that is later checked.
(test2): Ditto.

  • fast/js/stack-overflow-arrity-catch-expected.txt:
  • platform/chromium/test_expectations.txt:
2:29 PM Changeset in webkit [97650] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Mac build fix.

2:22 PM Changeset in webkit [97649] by dimich@chromium.org
  • 5 edits
    3 deletes in trunk/Source/WebCore

Unreviewed, rolling out r97643.
http://trac.webkit.org/changeset/97643
https://bugs.webkit.org/show_bug.cgi?id=70270

Broke iframe reparenting tests (Requested by dimich on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-17

  • manual-tests/iframe_notifications/iframe-reparenting-close-window-child.html: Removed.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window-iframe.html: Removed.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window.html: Removed.
  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::disconnectFrame):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::webkitNotifications):

  • page/DOMWindow.h:
  • page/Frame.cpp:

(WebCore::Frame::transferChildFrameToNewDocument):

2:14 PM Changeset in webkit [97648] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

2:09 PM Changeset in webkit [97647] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Removing suppressions for the fullscreen/ tests - it looks
like they're mostly passing now. I will pick up the tests that
are still failing in a subsequent patch.

  • platform/chromium/test_expectations.txt:
1:58 PM Changeset in webkit [97646] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

  • heap/HandleStack.cpp: Added a missing #include.
1:58 PM Changeset in webkit [97645] by leandro@webkit.org
  • 4 edits in trunk

Unreviewed; actually enable/disable microdata support in CMake.

Follow-up to r97471, which did not plug the option to enable/disable
microdata into the buildsystem.

  • Source/cmake/OptionsEfl.cmake: Add ENABLE_MICRODATA feature, turned off by default.
  • Source/cmake/OptionsWinCE.cmake: Ditto.
  • Source/cmakeconfig.h.cmake: Add ENABLE_MICRODATA #cmakedefine.
1:51 PM Changeset in webkit [97644] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Windows build fix.

longer existant symbol.

  • heap/MarkStack.cpp:

(JSC::MarkStackArray::shrinkAllocation): Cast to the right type.

1:46 PM Changeset in webkit [97643] by dimich@chromium.org
  • 5 edits
    4 adds in trunk/Source/WebCore

window.webkitNotifications uses deallocated NotificationPresenter after live Iframe transfer.
https://bugs.webkit.org/show_bug.cgi?id=70147

Reviewed by David Levin.

I only found a way to test this manually, since Chromium TestShell uses static instance
of NotificationPresenter instead of per-page one so the issue does not reproduce.
Adding manual test that works in full build of Chromium.

  • manual-tests/iframe_notifications/iframe-reparenting-close-window-child.html: Added.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window-iframe.html: Added.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window.html: Added.
  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::disconnectFrame):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::resetNotifications):

  • page/DOMWindow.h:
  • page/Frame.cpp:

(WebCore::Frame::transferChildFrameToNewDocument): reset webkitNotifications object.

1:43 PM Changeset in webkit [97642] by ggaren@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

Simplified GC marking logic
https://bugs.webkit.org/show_bug.cgi?id=70258

Reviewed by Filip Pizlo.

No perf. change.

This is a first step toward GC allocating string backing stores, starting
with ropes. It also enables future simplifications and optimizations.

  • Replaced some complex mark stack logic with a simple linear stack of

JSCell pointers.

  • Replaced logic for short-circuiting marking based on JSType and/or

Structure flags with special cases for object, array, and string.

  • Fiddled with inlining for better codegen.
  • heap/Heap.cpp:

(JSC::Heap::Heap): Provide more vptrs to SlotVisitor, for use in marking.

  • heap/HeapRootVisitor.h: Removed unused functions that no longer build.
  • heap/MarkStack.cpp:

(JSC::MarkStackArray::MarkStackArray):
(JSC::MarkStackArray::~MarkStackArray):
(JSC::MarkStackArray::expand):
(JSC::MarkStackArray::shrinkAllocation):
(JSC::MarkStack::reset):
(JSC::visitChildren):
(JSC::SlotVisitor::drain):

  • heap/MarkStack.h:

(JSC::MarkStack::MarkStack):
(JSC::MarkStack::~MarkStack):
(JSC::MarkStackArray::append):
(JSC::MarkStackArray::removeLast):
(JSC::MarkStackArray::isEmpty):
(JSC::MarkStack::append):
(JSC::MarkStack::appendUnbarrieredPointer):
(JSC::MarkStack::internalAppend): Replaced complex mark set logic with
simple linear stack.

  • heap/SlotVisitor.h:

(JSC::SlotVisitor::SlotVisitor): Updated for above changes.

  • runtime/JSArray.cpp:

(JSC::JSArray::visitChildren):

  • runtime/JSArray.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren):

  • runtime/JSObject.h: Don't inline visitChildren; it's too big.
  • runtime/Structure.h:

(JSC::MarkStack::internalAppend): Nixed the short-circuit for CompoundType
because it prevented strings from owning GC pointers.

  • runtime/WriteBarrier.h:

(JSC::MarkStack::appendValues): No need to validate; internalAppend will
do that for us.

1:29 PM Changeset in webkit [97641] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Widget window coordinate functions should use root view coordinate functions
https://bugs.webkit.org/show_bug.cgi?id=70152

Reviewed by Darin Adler.

No new tests, no changes to functionality.

  • platform/Widget.cpp:

(WebCore::Widget::convertFromContainingWindow): Use convertFromRootView().
(WebCore::Widget::convertToContainingWindow): Use convertToRootView().

1:15 PM Changeset in webkit [97640] by cmarrin@apple.com
  • 8 edits in trunk/Source

Throttle rate of requestAnimationFrame when page is not visible
https://bugs.webkit.org/show_bug.cgi?id=67873

Reviewed by Anders Carlsson.

Source/WebCore:

Add logic to suspend and resume scripted animations when page is hidden,
minimized or the tab is not visible. The hide/minimize notification comes
in from WebKit/WebKit2 to a new set of functions.

  • WebCore.exp.in:
  • page/Page.cpp:

(WebCore::Page::didMoveOnscreen):
(WebCore::Page::willMoveOffscreen):
(WebCore::Page::suspendScriptedAnimations):
(WebCore::Page::resumeScriptedAnimations):

  • page/Page.h:

Source/WebKit/mac:

Plumb through notification when the window is hidden/shown or
minimized/unminimized

  • WebView/WebView.mm:

(-[WebView _windowWillOrderOnScreen:]):
(-[WebView _windowWillOrderOffScreen:]):

Source/WebKit2:

Plumb through notification when the window is hidden/shown or
minimized/unminimized

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::suspendPainting):
(WebKit::DrawingAreaImpl::resumePainting):

1:03 PM Changeset in webkit [97639] by noam.rosenthal@nokia.com
  • 25 edits
    5 adds in trunk/Source/WebKit2

[Qt][WK2] Synchronize tiling with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=69151

Reviewed by Simon Hausmann.

Make the tiled "non-composited" content and the composited layers go through the same
code path on WebKit2. Instead of having a "drawing area" that handles the non-composited
content and a seperate layer tree, we put everything in a layer tree, with the non-
composited content being a layer in the tree.

This allows fixing several issues with websites that have large content areas that are
composited or overlap with composited layers.

Layer-tree synchronization is done by passing WebKit2 messages between a LayerTreeHost
on the WebProcess and a LayerTreeHostProxy on the UI process. Every layer in the tree has
its own tiled backing store, and uses the LayerTreeHost communication channel to pass
content up to the UI process. The UI process will later creates its own GraphicsLayer tree,
based on TextureMapper, which can be painted directly with OpenGL.

Several optimizations are available for the non-composited layer as well, e.g. specifying
a trajectory and updating the visible rect together with the content scale.

This code is currently disabled, a separate patch will enable it and glue it to
QTouchWebPage.

  • DerivedSources.pro:
  • Platform/CoreIPC/MessageID.h:
  • Scripts/webkit2/messages.py:
  • Shared/LayerTreeContext.h:
  • Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):

  • Shared/WebLayerTreeInfo.h:
  • Shared/qt/LayerTreeContextQt.cpp:

(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::~LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
(WebKit::LayerTreeContext::isEmpty):
(WebKit::operator==):

  • UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::updateWebView):
(WebKit::DrawingAreaProxy::contentsRect):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::viewportVisibleRect):
(WebKit::DrawingAreaProxy::isBackingStoreReady):
(WebKit::DrawingAreaProxy::paintToCurrentGLContext):
(WebKit::DrawingAreaProxy::setVisibleContentsRectAndScale):
(WebKit::DrawingAreaProxy::setVisibleContentRectTrajectoryVector):
(WebKit::DrawingAreaProxy::createTileForLayer):
(WebKit::DrawingAreaProxy::updateTileForLayer):
(WebKit::DrawingAreaProxy::removeTileForLayer):
(WebKit::DrawingAreaProxy::didReceiveLayerTreeHostProxyMessage):
(WebKit::DrawingAreaProxy::page):

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::didReceiveLayerTreeHostProxyMessage):
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRectAndScale):
(WebKit::DrawingAreaProxyImpl::setVisibleContentRectTrajectoryVector):
(WebKit::DrawingAreaProxyImpl::paintToCurrentGLContext):

  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/LayerTreeHostProxy.h: Added.

(WebKit::LayerTreeHostProxy::layerByID):
(WebKit::LayerTreeHostProxy::rootLayer):
(WebKit::LayerTreeHostProxy::notifyAnimationStarted):
(WebKit::LayerTreeHostProxy::notifySyncRequired):
(WebKit::LayerTreeHostProxy::showDebugBorders):
(WebKit::LayerTreeHostProxy::showRepaintCounter):
(WebKit::LayerTreeHostProxy::paintContents):

  • UIProcess/LayerTreeHostProxy.messages.in: Added.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp: Added.
  • WebKit2.pro:
  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):
(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setNeedsDisplay):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintBegin):
(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::setRootLayer):
(WebCore::WebGraphicsLayer::setVisibleContentRectTrajectoryVector):
(WebCore::WebGraphicsLayer::setVisibleContentRect):
(WebCore::WebGraphicsLayer::tiledBackingStorePaint):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintEnd):
(WebCore::WebGraphicsLayer::tiledBackingStoreUpdatesAllowed):
(WebCore::WebGraphicsLayer::tiledBackingStoreContentsRect):
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::WebGraphicsLayer::tiledBackingStoreBackgroundColor):
(WebCore::WebGraphicsLayer::createTile):
(WebCore::WebGraphicsLayer::updateTile):
(WebCore::WebGraphicsLayer::removeTile):
(WebCore::WebGraphicsLayer::updateTileBuffersRecursively):
(WebCore::WebGraphicsLayer::layerTreeTileClient):
(WebCore::WebGraphicsLayer::updateContentBuffers):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebCore::WebGraphicsLayer::setLayerTreeTileClient):

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::didReceiveLayerTreeHostMessage):

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):

  • WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::setVisibleContentRectAndScale):
(WebKit::LayerTreeHost::setVisibleContentRectTrajectoryVector):
(WebKit::LayerTreeHost::setVisibleContentRectForLayer):
(WebKit::LayerTreeHost::renderNextFrame):

  • WebProcess/WebPage/LayerTreeHost.messages.in: Added.
  • WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::didReceiveLayerTreeHostMessage):

  • WebProcess/WebPage/TiledDrawingArea.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::create):
(WebKit::LayerTreeHostQt::~LayerTreeHostQt):
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::setLayerFlushSchedulingEnabled):
(WebKit::LayerTreeHostQt::scheduleLayerFlush):
(WebKit::LayerTreeHostQt::cancelPendingLayerFlush):
(WebKit::LayerTreeHostQt::setShouldNotifyAfterNextScheduledLayerFlush):
(WebKit::LayerTreeHostQt::setRootCompositingLayer):
(WebKit::LayerTreeHostQt::invalidate):
(WebKit::LayerTreeHostQt::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHostQt::scrollNonCompositedContents):
(WebKit::LayerTreeHostQt::forceRepaint):
(WebKit::LayerTreeHostQt::sizeDidChange):
(WebKit::LayerTreeHostQt::didInstallPageOverlay):
(WebKit::LayerTreeHostQt::didUninstallPageOverlay):
(WebKit::LayerTreeHostQt::setPageOverlayNeedsDisplay):
(WebKit::LayerTreeHostQt::flushPendingLayerChanges):
(WebKit::LayerTreeHostQt::didSyncCompositingStateForLayer):
(WebKit::LayerTreeHostQt::didDeleteLayer):
(WebKit::LayerTreeHostQt::performScheduledLayerFlush):
(WebKit::LayerTreeHostQt::layerFlushTimerFired):
(WebKit::LayerTreeHostQt::createPageOverlayLayer):
(WebKit::LayerTreeHostQt::destroyPageOverlayLayer):
(WebKit::LayerTreeHostQt::adoptImageBackingStore):
(WebKit::LayerTreeHostQt::releaseImageBackingStore):
(WebKit::LayerTreeHostQt::notifyAnimationStarted):
(WebKit::LayerTreeHostQt::notifySyncRequired):
(WebKit::LayerTreeHostQt::paintContents):
(WebKit::LayerTreeHostQt::showDebugBorders):
(WebKit::LayerTreeHostQt::showRepaintCounter):
(WebKit::LayerTreeHost::supportsAcceleratedCompositing):
(WebKit::LayerTreeHostQt::createTile):
(WebKit::LayerTreeHostQt::updateTile):
(WebKit::LayerTreeHostQt::removeTile):
(WebKit::LayerTreeHostQt::setVisibleContentRectForLayer):
(WebKit::LayerTreeHostQt::setVisibleContentRectAndScale):
(WebKit::LayerTreeHostQt::setVisibleContentRectTrajectoryVector):
(WebKit::LayerTreeHostQt::renderNextFrame):
(WebKit::LayerTreeHostQt::layerTreeTileUpdatesAllowed):

12:49 PM Changeset in webkit [97638] by Antti Koivisto
  • 21 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=69966
Eliminate separate RenderStyle for visited link style

Reviewed by Dave Hyatt and Nikolas Zimmermann.

There are only a few properties that can apply to visited links and they can
be part of the regular style. Many things will get simpler when the separate
RenderStyle for visited links is eliminated.

  • Add valid visited link properties as separate fields to RenderStyle. The visitedLinkColor goes to inherited, everything else goes to rare data structures.
  • Make RenderStyle::visitedDependentColor() get the visited style from the new fields.
  • As VISITED_LINK pseudo style doesn't exists anymore, remove all code dealing with it.
  • Make CSSStyleSelector and ApplyPropertyColor apply the visited link style to the newly added fields instead of a separate RenderStyle.
  • Same thing with SVGRenderStyle, SVGCSSStyleSelector.
  • Fixup the SVG visited link style code to use the new fields.

This is ~15% progression in styleForElement performance over the HTML5 spec load.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyColor::ApplyPropertyColor):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::applyColorValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::updateFont):
(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::getColorFromPrimitiveValue):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::applyPropertyToRegularStyle):
(WebCore::CSSStyleSelector::applyPropertyToVisitedLinkStyle):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applySVGProperty):

  • dom/Element.cpp:

(WebCore::Element::pseudoStyleCacheIsInvalid):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getCachedPseudoStyle):
(WebCore::RenderStyle::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setVisitedLinkColor):
(WebCore::InheritedFlags::setVisitedLinkBackgroundColor):
(WebCore::InheritedFlags::setVisitedLinkBorderLeftColor):
(WebCore::InheritedFlags::setVisitedLinkBorderRightColor):
(WebCore::InheritedFlags::setVisitedLinkBorderBottomColor):
(WebCore::InheritedFlags::setVisitedLinkBorderTopColor):
(WebCore::InheritedFlags::setVisitedLinkOutlineColor):
(WebCore::InheritedFlags::setVisitedLinkColumnRuleColor):
(WebCore::InheritedFlags::setVisitedLinkTextEmphasisColor):
(WebCore::InheritedFlags::setVisitedLinkTextFillColor):
(WebCore::InheritedFlags::setVisitedLinkTextStrokeColor):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::setVisitedLinkFillPaint):
(WebCore::SVGRenderStyle::setVisitedLinkStrokePaint):
(WebCore::SVGRenderStyle::visitedLinkFillPaintType):
(WebCore::SVGRenderStyle::visitedLinkFillPaintColor):
(WebCore::SVGRenderStyle::visitedLinkStrokePaintType):
(WebCore::SVGRenderStyle::visitedLinkStrokePaintColor):

  • rendering/style/SVGRenderStyleDefs.cpp:

(WebCore::StyleFillData::StyleFillData):
(WebCore::StyleFillData::operator==):
(WebCore::StyleStrokeData::StyleStrokeData):
(WebCore::StyleStrokeData::operator==):

  • rendering/style/SVGRenderStyleDefs.h:
  • rendering/style/StyleInheritedData.cpp:

(WebCore::StyleInheritedData::StyleInheritedData):
(WebCore::StyleInheritedData::operator==):

  • rendering/style/StyleInheritedData.h:
  • rendering/style/StyleMultiColData.cpp:

(WebCore::StyleMultiColData::StyleMultiColData):
(WebCore::StyleMultiColData::operator==):

  • rendering/style/StyleMultiColData.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:
  • rendering/svg/RenderSVGResource.cpp:

(WebCore::requestPaintingResource):

12:22 PM Changeset in webkit [97637] by eric.carlson@apple.com
  • 12 edits
    2 adds in trunk/Source/WebCore

2011-10-17 Eric Carlson <eric.carlson@apple.com>

Cues should be loaded by the cached resource loader
https://bugs.webkit.org/show_bug.cgi?id=70134

Reviewed by Darin Adler.

No new tests, changes covered by existing tests.

  • CMakeLists.txt: Add CachedCues.cpp/h.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • loader/cache/CachedCues.cpp: Added. (WebCore::CachedCues::CachedCues): (WebCore::CachedCues::~CachedCues): (WebCore::CachedCues::data): Called when new data has been loaded, pass it to all registered

clients.

  • loader/cache/CachedCues.h: Added.
  • loader/cache/CachedResource.cpp: (WebCore::defaultPriorityForResourceType): Cues have low loader priority.
  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceClient.h: (WebCore::CachedResourceClient::didReceiveData): New client interface.
  • loader/cache/CachedResourceLoader.cpp: (WebCore::createResource): Create and return a new cue loader. (WebCore::CachedResourceLoader::requestCues): (WebCore::CachedResourceLoader::checkInsecureContent): Cues aren't mentioned in the CPS spec

yet, but they only work with a media element so use the mdia policy.

(WebCore::CachedResourceLoader::canRequest): Allow cues to be loaded from any origin like media.

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp: (WebCore::cachedResourceTypeToTargetType):
  • platform/network/chromium/ResourceRequest.h:
12:09 PM Changeset in webkit [97636] by inferno@chromium.org
  • 2 edits in branches/chromium/874/Source

Merge 97546 - [Chromium] Some WebSQLDatabase in worker bug fixes.

BUG=71551
Review URL: http://codereview.chromium.org/8317017

11:20 AM Changeset in webkit [97635] by mitz@apple.com
  • 5 edits in trunk

<rdar://problem/10293929> REGRESSION (r97525): iChat transcript has horizontal scroll bar when the conversation includes a wide image
https://bugs.webkit.org/show_bug.cgi?id=70204

Reviewed by Darin Adler.

Source/WebCore:

Reverted r97525, which was supposed to fix <http://webkit.org/b/29447>.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):

  • rendering/RenderBox.h:

LayoutTests:

  • fast/replaced/table-percent-width-expected.txt: Updated the results to

show that this test is failing after reverting r97525.

11:17 AM Changeset in webkit [97634] by Dimitri Glazkov
  • 2 edits in trunk/Tools

garden-o-matic operations fail because of CSP.
https://bugs.webkit.org/show_bug.cgi?id=70249

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Added gardening server to the policy.
10:55 AM Changeset in webkit [97633] by adachan@apple.com
  • 7 edits
    1 add in trunk

Source/WebCore: Export KURL::baseAsString() so it can be called in WebProcessProxy::assumeReadAccessToBaseURL() in WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=70168

Reviewed by Alexey Proskuryakov.

No new tests. There is no change in functionality.

  • WebCore.exp.in: Export KURL::baseAsString().

Source/WebKit2: Calling WKPageLoadAlternateHTMLString() where baseURL does not point to a directory causes an invalid message to be returned from WebProcess
https://bugs.webkit.org/show_bug.cgi?id=70168

Reviewed by Alexey Proskuryakov.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::assumeReadAccessToBaseURL): Add the file path of url's base URL to m_localPathsWithAssumedReadAccess,
since url may not point to a directory.

Tools: Add a test to call WKPageLoadAlternateHTMLString() with a non-directory URL.
https://bugs.webkit.org/show_bug.cgi?id=70168

Reviewed by Alexey Proskuryakov.

  • TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST): Call WKPageLoadAlternateHTMLString() with a file URL and make sure it finishes loading.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Add the new file.

10:24 AM Changeset in webkit [97632] by rniwa@webkit.org
  • 3 edits
    1 copy
    1 move in trunk

Source/WebCore: Touch Internals.cpp to make 64-bit GTK+ build happy.

  • testing/Internals.cpp:

LayoutTests: Moved V8-specific result to platform/chromium and added JSC result in cross-platform directory.

  • fast/files/url-required-arguments-expected.txt: Replaced with

LayoutTests/platform/qt/fast/files/url-required-arguments-expected.txt.

  • platform/chromium/fast/files/url-required-arguments-expected.txt: Copied from

LayoutTests/fast/files/url-required-arguments-expected.txt.

  • platform/qt/fast/files/url-required-arguments-expected.txt: Removed.
10:12 AM Changeset in webkit [97631] by rniwa@webkit.org
  • 2 edits in trunk

GTK build fix patch by Gustavo Noronha Silva.

  • Source/autotools/symbols.filter:
10:09 AM Changeset in webkit [97630] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=70245

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-10-17

  • platform/qt-wk2/Skipped:
10:01 AM Changeset in webkit [97629] by Chris Fleizach
  • 13 edits in trunk/Source/WebCore

AX: children() method should be consolidated in AccessibilityObject
https://bugs.webkit.org/show_bug.cgi?id=70243

Code cleanup, no new tests.

Reviewed by Darin Adler.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::children):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::updateChildrenIfNecessary):
(WebCore::AccessibilityScrollView::updateScrollbars):
(WebCore::AccessibilityScrollView::addChildren):

  • accessibility/AccessibilityScrollView.h:
  • accessibility/AccessibilitySlider.cpp:
  • accessibility/AccessibilitySlider.h:
  • accessibility/AccessibilityTableColumn.cpp:
  • accessibility/AccessibilityTableColumn.h:
  • accessibility/AccessibilityTableHeaderContainer.cpp:
  • accessibility/AccessibilityTableHeaderContainer.h:
9:56 AM Changeset in webkit [97628] by vsevik@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Search matches highlighting in text does not work correctly.
https://bugs.webkit.org/show_bug.cgi?id=70244

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/utilities-highlight-results.html

  • inspector/front-end/utilities.js:

():

LayoutTests:

  • inspector/utilities-highlight-results-expected.txt: Added.
  • inspector/utilities-highlight-results.html: Added.
9:47 AM Changeset in webkit [97627] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: webkit won't always send live region notifications
https://bugs.webkit.org/show_bug.cgi?id=70030

Source/WebCore:

Webkit purposefully does not send live region notifications if some AT client has not accessed the AX tree in between
the last live region update (ostensibly to improve performance).
However, this is problematic if a screen reader misses one notification... it has no idea what happened and the only
recourse is to rescan the page for changes. The correct thing to do is to always send notifications.

Reviewed by Darin Adler.

Test: platform/mac/accessibility/aria-liveregions-notifications-always-sent.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::childrenChanged):

LayoutTests:

Reviewed by Darin Adler.

  • platform/mac/accessibility/aria-liveregions-notifications-always-sent-expected.txt: Added.
  • platform/mac/accessibility/aria-liveregions-notifications-always-sent.html: Added.
9:26 AM Changeset in webkit [97626] by Darin Adler
  • 5 edits in trunk/Tools

Add some more *.pyc ignores in directories with Python scripts.

  • QueueStatusServer: Added property svn:ignore.
  • Scripts/webkitpy/common/watchlist: Added property svn:ignore.
  • Scripts/webkitpy/layout_tests/controllers: Added property svn:ignore.
  • Scripts/webkitpy/layout_tests/views: Added property svn:ignore.
9:25 AM Changeset in webkit [97625] by Darin Adler
  • 2 edits in trunk/LayoutTests

Cleared a stray executable bit.

  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html: Removed property svn:executable.
9:23 AM Changeset in webkit [97624] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Add methods to get/set a custom text enconding to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69524

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_custom_charset):
(webkit_web_view_set_custom_charset):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewCustomCharset):
(beforeAll):

8:28 AM Changeset in webkit [97623] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt][WK2][meta] Fix failing API tests
https://bugs.webkit.org/show_bug.cgi?id=70236

Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-10-17
Reviewed by Csaba Osztrogonác.

In order to run WebKit2 API tests we need the WebProcess to be in
the path so let's add the bin directory when running the API tests of Qt.

  • Scripts/run-qtwebkit-tests:
8:26 AM Changeset in webkit [97622] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt][WK2] Build dependency problems
https://bugs.webkit.org/show_bug.cgi?id=68456

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-10-17
Reviewed by Csaba Osztrogonác.

  • Scripts/webkitdirs.pm:

(buildQMakeProject):

7:53 AM Changeset in webkit [97621] by podivilov@chromium.org
  • 5 edits in trunk

Web Inspector: fix handling of source mapping entries with no mapping.
https://bugs.webkit.org/show_bug.cgi?id=69941

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):

LayoutTests:

  • inspector/debugger/compiler-source-mapping-expected.txt:
  • inspector/debugger/compiler-source-mapping.html:
7:21 AM Changeset in webkit [97620] by Adam Roben
  • 3 edits in trunk/Source/JavaScriptCore

Windows build fix after r97536, part 3

  • runtime/JSAPIValueWrapper.h:
  • runtime/JSObject.h:

Use JS_EXPORTDATA to export the s_info members.

7:10 AM Changeset in webkit [97619] by tkent@chromium.org
  • 33 edits
    48 adds
    7 deletes in trunk/LayoutTests

[Chromium] Update test expectations for r97596 and r97602.

  • platform/chromium-cg-mac-leopard/css2.1/t0511-c21-pseud-link-02-e-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t0511-c21-pseud-link-03-e-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/events/reveal-link-when-focused-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/selectors/017-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/selectors/061-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug46623-1-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug51140-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug8950-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t0511-c21-pseud-link-02-e-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t0511-c21-pseud-link-03-e-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/events/reveal-link-when-focused-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/selectors/017-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/selectors/061-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug46623-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug51140-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug8950-expected.png: Added.
  • platform/chromium-linux/css2.1/t0511-c21-pseud-link-02-e-expected.png:
  • platform/chromium-linux/css2.1/t0511-c21-pseud-link-03-e-expected.png:
  • platform/chromium-linux/fast/events/reveal-link-when-focused-expected.png:
  • platform/chromium-linux/fast/selectors/017-expected.png:
  • platform/chromium-linux/fast/selectors/061-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46623-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug51140-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug8950-expected.png:
  • platform/chromium-mac-leopard/css2.1/t0511-c21-pseud-link-02-e-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t0511-c21-pseud-link-03-e-expected.png: Added.
  • platform/chromium-mac-leopard/fast/events/reveal-link-when-focused-expected.png: Added.
  • platform/chromium-mac-leopard/fast/selectors/017-expected.png: Added.
  • platform/chromium-mac-leopard/fast/selectors/061-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46623-1-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug51140-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug7342-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug8950-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0511-c21-pseud-link-02-e-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0511-c21-pseud-link-03-e-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/34176-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/34176-expected.png.
  • platform/chromium-mac-snowleopard/fast/events/reveal-link-when-focused-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/selectors/017-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/selectors/061-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug26553-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug26553-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46623-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51140-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug8950-expected.png: Added.
  • platform/chromium-mac/fast/events/reveal-link-when-focused-expected.png: Removed.
  • platform/chromium-mac/fast/selectors/017-expected.png: Removed.
  • platform/chromium-mac/fast/selectors/061-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug46623-1-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug51140-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug8950-expected.png: Removed.
  • platform/chromium-win/css2.1/t0511-c21-pseud-link-02-e-expected.png:
  • platform/chromium-win/css2.1/t0511-c21-pseud-link-02-e-expected.txt:
  • platform/chromium-win/css2.1/t0511-c21-pseud-link-03-e-expected.png:
  • platform/chromium-win/css2.1/t0511-c21-pseud-link-03-e-expected.txt:
  • platform/chromium-win/fast/dom/34176-expected.txt:
  • platform/chromium-win/fast/events/reveal-link-when-focused-expected.png:
  • platform/chromium-win/fast/events/reveal-link-when-focused-expected.txt:
  • platform/chromium-win/fast/selectors/017-expected.png:
  • platform/chromium-win/fast/selectors/017-expected.txt:
  • platform/chromium-win/fast/selectors/061-expected.png:
  • platform/chromium-win/fast/selectors/061-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug26553-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug46623-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46623-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug51140-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug51140-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug8950-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug8950-expected.txt:
  • platform/chromium/test_expectations.txt:
7:03 AM Changeset in webkit [97618] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Interpreter build fix after r97564

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
Moved declaration of globalData variable into ENABLE(JIT) blocks, since it is only used
there.

7:02 AM BuildingQt5OnHarmattan edited by Simon Hausmann
(diff)
7:01 AM BuildingQt5OnHarmattan edited by Simon Hausmann
(diff)
7:01 AM Changeset in webkit [97617] by Csaba Osztrogonác
  • 17 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, update Qt specific expected results after r97602.

  • platform/qt/css3/selectors3/html/css3-modsel-17-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-17-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-61-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-61-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-17-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-17-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-61-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-61-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-17-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-17-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-61-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-61-expected.txt:
  • platform/qt/fast/selectors/017-expected.png:
  • platform/qt/fast/selectors/017-expected.txt:
  • platform/qt/fast/selectors/061-expected.png:
  • platform/qt/fast/selectors/061-expected.txt:
7:01 AM Changeset in webkit [97616] by Csaba Osztrogonác
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip a passing test and add platform specific expected result.

  • platform/qt/Skipped:
  • platform/qt/fast/events/reveal-link-when-focused-expected.png: Added.
  • platform/qt/fast/events/reveal-link-when-focused-expected.txt: Added.
6:41 AM Changeset in webkit [97615] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix after r97536, part 2

JSC::setUpStaticFunctionSlot with its new mangled name. SOrted the rest of the file while I
was at it.

6:40 AM Changeset in webkit [97614] by zecke@webkit.org
  • 2 edits in trunk/Tools

[build] Introduce Qt/SH4 buildbot
https://bugs.webkit.org/show_bug.cgi?id=70227

Patch by Holger Hans Peter Freyther <holger@moiji-mobile.com> on 2011-10-17
Reviewed by Adam Roben.

Add buildslave for Linux/Qt/SH4.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
6:39 AM Changeset in webkit [97613] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: don't check for debugger pause details in interactive ui tests
https://bugs.webkit.org/show_bug.cgi?id=70228

Removed debugger pause details validation. The only check left is that debugger pause event is fired when expected.

Reviewed by Pavel Feldman.

  • src/js/Tests.js:

(.TestSuite.prototype.testPauseWhenLoadingDevTools):
(.TestSuite.prototype.testPauseWhenScriptIsRunning.didEvaluateInConsole):
(.TestSuite.prototype.testPauseWhenScriptIsRunning.testScriptPause):
(.TestSuite.prototype.testPauseWhenScriptIsRunning):
(.TestSuite.prototype.testPauseInSharedWorkerInitialization):
(.TestSuite.prototype._waitForScriptPause):

6:25 AM Changeset in webkit [97612] by Adam Roben
  • 2 edits in trunk/WebKitLibraries

Windows build fix

Here's the error:

5>c:\cygwin\home\buildbot\slave\win-release\build\webkitbuild\release\obj\webcore\derivedsources\jssvgpathsegcurvetoquadraticrel.cpp(128) : fatal error C1128: number of sections exceeded object file format limit : compile with /bigobj

  • win/tools/vsprops/common.vsprops: Specify /bigobj to the compiler.
6:21 AM Changeset in webkit [97611] by mnaganov@chromium.org
  • 20 edits in trunk

Web Inspector: [Chromium] Add an ability to look up and explore an object from a heap profile.
https://bugs.webkit.org/show_bug.cgi?id=61179

This is exteremely helpful when dealing with DOM wrappers, as
their properties are mostly implemented with getters and thus not
stored in heap snapshots.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • bindings/js/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::objectByHeapObjectId):

  • bindings/js/ScriptProfiler.h:
  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::objectByHeapObjectId):

  • bindings/v8/ScriptProfiler.h:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::create):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):

  • inspector/InspectorProfilerAgent.h:
  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.queryObjectContent):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent.else.formatResult):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._showObjectPopover):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get canBeQueried):
(WebInspector.HeapSnapshotNode.prototype.get flags):
(WebInspector.HeapSnapshotNode.prototype.get isDOMWindow):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype._flagsOfNode):
(WebInspector.HeapSnapshot.prototype._calculateFlags):
(WebInspector.HeapSnapshot.prototype.updateStaticData):
(WebInspector.HeapSnapshotNodesProvider.prototype._serialize):

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotProxy.prototype.get nodeFlags):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.fromError):

  • inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view tr:not(.selected) td.object-column span.highlight):

  • inspector/profiler/heap-snapshot-expected.txt:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
(initialize_HeapSnapshotTest):

  • inspector/profiler/heap-snapshot.html:
5:58 AM Changeset in webkit [97610] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix after r97536

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed export of

JSC::setUpStaticFunctionSlot, which no longer exists. Also removed incorrect exports of
s_info members, which need to be exported via JS_EXPORTDATA instead.

5:53 AM Changeset in webkit [97609] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Remove reference to third_party/skia/gpu.
It was removed from Chromium DEPS in Chromium r105526.

  • DEPS:
5:41 AM BuildingQt5OnHarmattan edited by Christian Sejersen
(diff)
5:41 AM Changeset in webkit [97608] by jesus@webkit.org
  • 5 edits in trunk/Source/WebKit2

[Qt][WK2] Implement decidePolicyForResponse in our PolicyClient
https://bugs.webkit.org/show_bug.cgi?id=69832

Reviewed by Kenneth Rohde Christiansen.

We implement decidePolicyForResponse in our PolicyClient in order to
decide whether a given ResourceResponse should be downloaded or loaded.

  • Shared/qt/WebCoreArgumentCodersQt.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):
Implement serialization of ResourceResponse.

  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_decidePolicyForResponse):

  • UIProcess/qt/ClientImpl.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init):

5:38 AM BuildingQt5OnHarmattan edited by Christian Sejersen
(diff)
5:35 AM Changeset in webkit [97607] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
4:46 AM Changeset in webkit [97606] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Editing CSS selector doesn't fire onResourceContentCommitted
https://bugs.webkit.org/show_bug.cgi?id=70018

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/styles/commit-selector.html

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
(WebInspector.CSSStyleModel.prototype.setRuleSelector):

LayoutTests:

  • inspector/styles/commit-selector-expected.txt: Added.
  • inspector/styles/commit-selector.html: Added.
4:38 AM Changeset in webkit [97605] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

CSS/XSLStyleSheet: Remove insert() and remove().
https://bugs.webkit.org/show_bug.cgi?id=70226

Reviewed by Antti Koivisto.

Remove insert() and remove() from XSLStyleSheet. CSSStyleSheet retains remove()
since it's used by InspectorStyleSheet as well as SVGFontFaceElement.

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::remove):

Remove range check. This method is internal to WebKit and the call sites
already take care of it.

(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):

  • css/CSSStyleSheet.h:
  • xml/XSLStyleSheet.h:
4:16 AM Changeset in webkit [97604] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=70224

  • platform/chromium/test_expectations.txt:

Mark some tests failing until bots have test results.

4:09 AM Changeset in webkit [97603] by commit-queue@webkit.org
  • 2 edits in trunk

[webkit]Debug Build Bot failure
https://bugs.webkit.org/show_bug.cgi?id=70222

Patch by Vamshikrishna Yellenki <vamshi@motorola.com> on 2011-10-17
Reviewed by Xan Lopez.

  • Source/autotools/symbols.filter: Corrected the filter name for getLocationAndLengthFronRange
3:38 AM Changeset in webkit [97602] by Antti Koivisto
  • 17 edits in trunk/LayoutTests

Make more :visited pseudo class tests work
https://bugs.webkit.org/show_bug.cgi?id=70224

Reviewed by Andreas Kling.

Link <a href=""> is always considered visited so we can use that in tests that try to apply :visited.

Mac results only, requires rebaselining of other platforms.

  • css3/selectors3/html/css3-modsel-17.html:
  • css3/selectors3/html/css3-modsel-61.html:
  • css3/selectors3/xhtml/css3-modsel-17.xml:
  • css3/selectors3/xhtml/css3-modsel-61.xml:
  • css3/selectors3/xml/css3-modsel-17.xml:
  • css3/selectors3/xml/css3-modsel-61.xml:
  • fast/selectors/017.html:
  • fast/selectors/061.html:
  • platform/mac/css3/selectors3/html/css3-modsel-17-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-61-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-17-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-61-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-17-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-61-expected.txt:
  • platform/mac/fast/selectors/017-expected.txt:
  • platform/mac/fast/selectors/061-expected.txt:
3:24 AM Changeset in webkit [97601] by Csaba Osztrogonác
  • 1 edit
    4 deletes in trunk/LayoutTests

[Qt] Unreviewed gardening after r97598. Remove obsolete Qt 4.8 specific expected results.

  • platform/qt-4.8/tables/mozilla/bugs/bug7342-expected.png: Removed.
  • platform/qt-4.8/tables/mozilla/bugs/bug7342-expected.txt: Removed.
  • platform/qt-4.8/tables/mozilla/bugs/bug8950-expected.png: Removed.
  • platform/qt-4.8/tables/mozilla/bugs/bug8950-expected.txt: Removed.
3:23 AM Changeset in webkit [97600] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=70219

  • platform/chromium/test_expectations.txt:

Mark some tests failing until bots have test results.

3:03 AM Changeset in webkit [97599] by Csaba Osztrogonác
  • 1 edit
    6 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/fast/borders/border-radius-complex-inner-expected.png: Added after r97318.
  • platform/qt/fast/borders/border-radius-complex-inner-expected.txt: Added after r97318.
  • platform/qt/fast/css/clip-text-in-scaled-div-expected.png: Added after r97481.
  • platform/qt/fast/css/clip-text-in-scaled-div-expected.txt: Added after r97481.
  • platform/qt/fast/repaint/region-painting-via-layout-expected.png: Added after r97370.
  • platform/qt/fast/repaint/region-painting-via-layout-expected.txt: Added after r97370.
2:51 AM Changeset in webkit [97598] by Csaba Osztrogonác
  • 19 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r97596.

  • platform/qt/css2.1/t0511-c21-pseud-link-02-e-expected.png:
  • platform/qt/css2.1/t0511-c21-pseud-link-02-e-expected.txt:
  • platform/qt/css2.1/t0511-c21-pseud-link-03-e-expected.png:
  • platform/qt/css2.1/t0511-c21-pseud-link-03-e-expected.txt:
  • platform/qt/fast/block/float/float-in-float-hit-testing-expected.png:
  • platform/qt/fast/block/float/float-in-float-hit-testing-expected.txt:
  • platform/qt/fast/history/visited-link-background-color-expected.png:
  • platform/qt/fast/history/visited-link-background-color-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug26553-expected.png:
  • platform/qt/tables/mozilla/bugs/bug26553-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46623-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46623-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug51140-expected.png:
  • platform/qt/tables/mozilla/bugs/bug51140-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug8950-expected.png:
  • platform/qt/tables/mozilla/bugs/bug8950-expected.txt:
2:18 AM Changeset in webkit [97597] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

when CSS pseudo selectors are applied (:before and :after) the *-of-line keyboard navigation does not work
https://bugs.webkit.org/show_bug.cgi?id=10123

Patch by Rosen Dash <rosen.dash@motorola.com> on 2011-10-17
Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch addresses folllowing two issues:

  1. When CSS pseudo elements are before or after is used with content attribute containing single character at the start/end of text and we try to move cursor by right navigation key, the page freezes falling into an infinite loop.
  2. When these elements try to insert some text between a text line, navigation by right/left arrow key is prohibited.

Tests: editing/selection/css-pseudo-element-hang.html

editing/selection/css-pseudo-element.html

  • editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate):

LayoutTests:

  • editing/selection/css-pseudo-element-expected.txt: Added.
  • editing/selection/css-pseudo-element-hang-expected.txt: Added.
  • editing/selection/css-pseudo-element-hang.html: Added.
  • editing/selection/css-pseudo-element.html: Added.
2:15 AM Changeset in webkit [97596] by Antti Koivisto
  • 14 edits in trunk

Test :visited pseudo class
https://bugs.webkit.org/show_bug.cgi?id=70219

Source/WebCore:

Reviewed by Andreas Kling.

Currently DRT doesn't support :visited. All tests where it should match have wrong checked in results.

  • Make <a href=""> to match :visited in DRT. It already does on browsers. A number of existing tests for :visited use it already, the rest can be modified to use it.
  • Make render tree dumps correctly dump the visited state dependent color.
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::determineLinkStateSlowCase):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

LayoutTests:

Reviewed by Andreas Kling.

Update Mac results for tests that already use <a href="">.

All other platforms need rebaselining too.

  • platform/mac/css2.1/t0511-c21-pseud-link-02-e-expected.txt:
  • platform/mac/css2.1/t0511-c21-pseud-link-03-e-expected.txt:
  • platform/mac/fast/dom/34176-expected.txt:
  • platform/mac/fast/events/reveal-link-when-focused-expected.txt:
  • platform/mac/fast/history/visited-link-background-color-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug26553-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46623-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51140-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug8950-expected.txt:
2:04 AM Changeset in webkit [97595] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] test expectation update
https://bugs.webkit.org/show_bug.cgi?id=69624

  • platform/chromium/test_expectations.txt:

Correct expectation of zoom-animator-scale-test2.html.

2:02 AM Changeset in webkit [97594] by satish@chromium.org
  • 3 edits in trunk/Source/WebCore

Avoid leaking document when leaving google.com due to geolocation
permission request.
https://bugs.webkit.org/show_bug.cgi?id=58027

Reviewed by Kenneth Rohde Christiansen.

  • page/Geolocation.cpp:

(WebCore::Geolocation::Watchers::find): added
(WebCore::Geolocation::reset): cleared all pending notifiers.
(WebCore::Geolocation::clearWatch): removed from pending notifier set.

  • page/Geolocation.h:

(WebCore::Geolocation::Watchers::find): added

2:01 AM Changeset in webkit [97593] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Interpreter build fix after r97436, r97506, r97532 and r97537.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

1:58 AM Changeset in webkit [97592] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WebKit2][gtk] Rename WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL to WEBKIT_POLICY_ERROR_CANNOT_SHOW_URI
https://bugs.webkit.org/show_bug.cgi?id=70040

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-17
Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitError.cpp:
  • UIProcess/API/gtk/WebKitError.h:
12:51 AM Changeset in webkit [97591] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix clang WebKitGTK+ build.

Patch by Andrei Lavreniyuk <andy.lavr@gmail.com> on 2011-10-17
Reviewed by Martin Robinson.

  • plugins/gtk/PluginViewGtk.cpp:
12:20 AM Changeset in webkit [97590] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectation.
https://bugs.webkit.org/show_bug.cgi?id=70013

  • platform/chromium/test_expectations.txt:

Add more cavas test crashes on Windows GPU.

Oct 16, 2011:

11:32 PM Changeset in webkit [97589] by abarth@webkit.org
  • 4 edits in trunk/Source

Always disable ENABLE(ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL) and delete associated code
https://bugs.webkit.org/show_bug.cgi?id=70216

Reviewed by Eric Seidel.

Source/JavaScriptCore:

  • wtf/Platform.h:

Source/WebCore:

No port enables this feature. It was added for the previous Android
port (and should have been an editing behavior in any case).

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updateFocusAppearance):

11:29 PM Changeset in webkit [97588] by wjmaclean@chromium.org
  • 3 edits
    1 add in trunk/LayoutTests

[chromium] Rebaseline layout test zoom-animator-scale-test2.html for win, mac
https://bugs.webkit.org/show_bug.cgi?id=69624

Reviewed by Kent Tamura.

Also modifies timeout in zoom-animator-scale-test2.html to try and reduce flake, generate
win baselines.

  • platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test2-expected.png: Added.
  • platform/chromium/compositing/zoom-animator-scale-test2.html:
  • platform/chromium/test_expectations.txt:
11:05 PM Changeset in webkit [97587] by rniwa@webkit.org
  • 8 edits
    2 adds in trunk

Expose rangeFromLocationAndLength and locationAndLengthFromRange via internals object
https://bugs.webkit.org/show_bug.cgi?id=68330

Reviewed by Hajime Morita.

Source/WebCore:

Add rangeFromLocationAndLength, locationFromRange, and lengthFromRange to window.internals.

Test: editing/text-iterator/range-to-from-location-and-length.html

  • WebCore.exp.in:
  • testing/Internals.cpp:

(WebCore::Internals::scrollElementToRect):
(WebCore::Internals::rangeFromLocationAndLength):
(WebCore::Internals::locationFromRange):
(WebCore::Internals::lengthFromRange):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Add a basic test that uses internals.rangeFromLocationAndLength, internals.locationFromRange,
and internals.lengthFromRange.

  • editing/text-iterator/range-to-from-location-and-length-expected.txt: Added.
  • editing/text-iterator/range-to-from-location-and-length.html: Added.
11:02 PM Changeset in webkit [97586] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Generate MessageChannel constructor by [Constructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=70214

Reviewed by Adam Barth.

This patch generates an MessageChannel constructor for JSC by [Constructor] IDL,
but V8 is still using a custom constructor since the V8 constructor requires special logic.

Tests: fast/dom/global-constructors.html

fast/events/message-port.html
fast/events/message-port-no-wrapper.html
fast/dom/Window/window-postmessage-args.html

  • bindings/js/JSMessageChannelCustom.cpp: Removed the MessageChannel constructor.
  • dom/MessageChannel.idl: Generates the MessageChannel constructor for JSC.
10:44 PM Changeset in webkit [97585] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

[Mac] fontForSelection and styleForSelectionStart should be moved to EditorMac
https://bugs.webkit.org/show_bug.cgi?id=70114

Reviewed by Hajime Morita.

Moved fontForSelection and styleForSelectionStart from Editor to EditorMac
and made styleForSelectionStart static local.

  • editing/Editor.cpp:
  • editing/Editor.h:
  • editing/mac/EditorMac.mm:

(WebCore::styleForSelectionStart):
(WebCore::Editor::fontForSelection):
(WebCore::Editor::fontAttributesForSelectionStart):

10:06 PM Changeset in webkit [97584] by haraken@chromium.org
  • 8 edits
    1 delete in trunk/Source/WebCore

Generate EventSource constructor for JSC by [Constructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=70212

Reviewed by Adam Barth.

Removed JSEventSourceCustom.cpp.

Tests: fast/dom/global-constructors.html

fast/eventsource/eventsource-constructor.html
fast/eventsource/eventsource-attribute-listeners.html

  • GNUmakefile.list.am: Removed JSEventSourceCustom.cpp.
  • UseJSC.cmake: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
  • bindings/js/JSEventSourceCustom.cpp: Removed this file.
  • page/EventSource.idl: Removed 'JSCustomConstructor' IDL.
9:27 PM Changeset in webkit [97583] by commit-queue@webkit.org
  • 11 edits
    1 delete in trunk/Source/WebCore

Inline CSSPrimitiveValue::isQuirkValue() as non-virtual function
https://bugs.webkit.org/show_bug.cgi?id=64865

Patch by David Barr <davidbarr@chromium.org> on 2011-10-16
Reviewed by Darin Adler.

Based on profiling and patch from:
Tamas Czene <Czene.Tamas@stud.u-szeged.hu>

This is expected to produce a small performance progression.
Additional memory overhead is avoided by using spare bits.
CSSQuirkPrimitiveValue is removed as it becomes just a factory.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValidPrimitive):

  • css/CSSParserValues.cpp:

(WebCore::CSSParserValue::createCSSValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::createAllowingMarginQuirk):
Moved from CSSQuirkPrimitiveValue::create.
(WebCore::CSSPrimitiveValue::isQuirkValue):

  • css/CSSQuirkPrimitiveValue.h: Removed.
  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

9:03 PM Changeset in webkit [97582] by tkent@chromium.org
  • 16 edits
    72 moves
    252 adds
    123 deletes in trunk/LayoutTests

Update test exepctations.

  • Add baseline files for new tests
  • Update for Skia focus ring change
  • Update for Mac spelling underline change
  • Optimize test results for them
  • css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/20110323/abspos-containing-block-initial-007-expected.txt.
  • css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt.
  • editing/deleting/delete-3959464-fix-expected.txt: Renamed from LayoutTests/platform/gtk/editing/deleting/delete-3959464-fix-expected.txt.
  • editing/deleting/delete-block-contents-003-expected.txt: Renamed from LayoutTests/platform/gtk/editing/deleting/delete-block-contents-003-expected.txt.
  • editing/deleting/delete-trailing-ws-002-expected.txt: Renamed from LayoutTests/platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt.
  • editing/deleting/delete-ws-fixup-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/deleting/delete-ws-fixup-001-expected.txt.
  • editing/inserting/insert-br-004-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-br-004-expected.txt.
  • editing/inserting/insert-br-005-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-br-005-expected.txt.
  • editing/inserting/insert-br-007-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-br-007-expected.txt.
  • editing/inserting/insert-div-007-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-007-expected.txt.
  • editing/inserting/insert-div-012-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-012-expected.txt.
  • editing/inserting/insert-div-013-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-013-expected.txt.
  • editing/inserting/insert-div-014-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-014-expected.txt.
  • editing/inserting/insert-div-015-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-015-expected.txt.
  • editing/inserting/insert-div-016-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-016-expected.txt.
  • editing/inserting/insert-div-017-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-017-expected.txt.
  • editing/inserting/insert-div-018-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-018-expected.txt.
  • editing/inserting/insert-div-019-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-019-expected.txt.
  • editing/inserting/insert-div-020-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-020-expected.txt.
  • editing/inserting/insert-div-022-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-022-expected.txt.
  • editing/inserting/insert-div-025-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-025-expected.txt.
  • editing/inserting/insert-div-027-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-027-expected.txt.
  • editing/inserting/insert-tab-002-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-tab-002-expected.txt.
  • editing/inserting/insert-tab-003-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-tab-003-expected.txt.
  • editing/inserting/return-key-with-selection-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/return-key-with-selection-001-expected.txt.
  • editing/inserting/return-key-with-selection-002-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/return-key-with-selection-002-expected.txt.
  • editing/inserting/return-key-with-selection-003-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/return-key-with-selection-003-expected.txt.
  • editing/inserting/typing-002-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/typing-002-expected.txt.
  • editing/inserting/typing-around-br-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/typing-around-br-001-expected.txt.
  • editing/pasteboard/paste-text-013-expected.txt: Removed.
  • editing/pasteboard/paste-text-019-expected.txt: Renamed from LayoutTests/platform/gtk/editing/pasteboard/paste-text-019-expected.txt.
  • editing/selection/extend-by-word-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/extend-by-word-001-expected.txt.
  • editing/selection/move-backwords-by-word-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/move-backwords-by-word-001-expected.txt.
  • editing/selection/move-by-character-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/move-by-character-001-expected.txt.
  • editing/selection/move-by-line-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/move-by-line-001-expected.txt.
  • editing/selection/move-by-word-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/move-by-word-001-expected.txt.
  • editing/style/block-styles-007-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/block-styles-007-expected.txt.
  • editing/style/create-block-for-style-002-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-002-expected.txt.
  • editing/style/create-block-for-style-003-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-003-expected.txt.
  • editing/style/create-block-for-style-004-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-004-expected.txt.
  • editing/style/create-block-for-style-006-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-006-expected.txt.
  • editing/style/create-block-for-style-008-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-008-expected.txt.
  • editing/style/create-block-for-style-009-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-009-expected.txt.
  • editing/style/create-block-for-style-011-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-011-expected.txt.
  • editing/style/create-block-for-style-012-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-012-expected.txt.
  • editing/style/create-block-for-style-013-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-013-expected.txt.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/height-width-inline-table-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/height-width-table-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-3928305-fix-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-3959464-fix-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-and-undo-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-block-contents-003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-contiguous-ws-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-tab-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-tab-003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-to-select-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-trailing-ws-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-ws-fixup-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-cg-mac-leopard/editing/execCommand/5569741-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/execCommand/insert-list-and-stitch-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-cg-mac-leopard/editing/inserting/5418891-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/editing-empty-divs-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-br-004-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-br-005-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-br-007-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-007-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-012-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-013-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-014-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-015-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-016-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-017-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-018-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-019-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-020-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-022-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-025-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-div-027-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-paragraph-02-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-paragraph-03-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-tab-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-tab-003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/insert-text-with-newlines-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/paragraph-separator-01-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/paragraph-separator-02-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/paragraph-separator-03-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/return-key-with-selection-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/return-key-with-selection-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/return-key-with-selection-003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/typing-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/4242293-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/pasteboard/8145-2-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/pasteboard/cut-text-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/paste-text-013-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/pasteboard/paste-text-014-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/pasteboard/paste-text-019-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/selection/13804-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/selection/5234383-1-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/5234383-2-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/extend-by-word-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/selection/move-backwords-by-word-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/selection/move-by-character-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/selection/move-by-line-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/selection/move-by-word-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/unrendered-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/spelling/inline_spelling_markers-expected.png:
  • platform/chromium-cg-mac-leopard/editing/spelling/spelling-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/5046875-2-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/block-styles-007-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-004-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-006-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-008-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-009-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-011-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-012-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-013-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-3928305-fix-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-3959464-fix-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-and-undo-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-block-contents-003-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-contiguous-ws-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-tab-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-tab-003-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-to-select-table-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-trailing-ws-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-ws-fixup-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/delete-ws-fixup-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/execCommand/5569741-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/execCommand/insert-list-and-stitch-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/execCommand/insertHorizontalRule-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/5418891-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/editing-empty-divs-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-br-004-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-br-005-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-br-007-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-007-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-012-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-013-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-014-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-015-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-016-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-017-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-018-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-019-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-020-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-022-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-025-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-027-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-paragraph-02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-paragraph-03-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-tab-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-tab-003-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/insert-text-with-newlines-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/paragraph-separator-01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/paragraph-separator-02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/paragraph-separator-03-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/return-key-with-selection-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/return-key-with-selection-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/return-key-with-selection-003-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/typing-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/typing-around-br-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/4242293-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/8145-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/cut-text-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/merge-after-delete-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/merge-after-delete-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/merge-after-delete-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/paste-text-013-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/paste-text-014-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/paste-text-019-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/13804-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/5234383-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/5234383-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/extend-by-word-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/move-backwords-by-word-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/move-by-character-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/move-by-line-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/move-by-word-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/unrendered-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/spelling/inline_spelling_markers-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/spelling/spelling-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/5046875-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/block-styles-007-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-003-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-004-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-006-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-008-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-009-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-011-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-012-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-013-expected.png: Added.
  • platform/chromium-cg-mac/editing/deleting/delete-tab-003-expected.png: Removed.
  • platform/chromium-cg-mac/editing/deleting/delete-ws-fixup-001-expected.png: Removed.
  • platform/chromium-cg-mac/editing/deleting/delete-ws-fixup-002-expected.png: Removed.
  • platform/chromium-cg-mac/editing/inserting/insert-tab-003-expected.png: Removed.
  • platform/chromium-cg-mac/editing/inserting/typing-around-br-001-expected.png: Removed.
  • platform/chromium-cg-mac/editing/pasteboard/merge-after-delete-1-expected.png: Removed.
  • platform/chromium-cg-mac/editing/pasteboard/merge-after-delete-2-expected.png: Removed.
  • platform/chromium-cg-mac/editing/pasteboard/merge-after-delete-expected.png: Removed.
  • platform/chromium-cg-mac/editing/selection/5234383-1-expected.png: Removed.
  • platform/chromium-cg-mac/editing/selection/5234383-2-expected.png: Removed.
  • platform/chromium-cg-mac/editing/selection/select-from-textfield-outwards-expected.png: Removed.
  • platform/chromium-cg-mac/editing/spelling/inline_spelling_markers-expected.png: Removed.
  • platform/chromium-cg-mac/editing/style/create-block-for-style-006-expected.png: Removed.
  • platform/chromium-cg-mac/editing/style/create-block-for-style-011-expected.png: Removed.
  • platform/chromium-cg-mac/editing/style/create-block-for-style-012-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/height-width-inline-table-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/height-width-table-001-expected.png: Added.
  • platform/chromium-mac-leopard/editing/deleting/delete-3928305-fix-expected.png: Added.
  • platform/chromium-mac-leopard/editing/deleting/delete-to-select-table-expected.png: Added.
  • platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-002-expected.png: Added.
  • platform/chromium-mac-leopard/editing/execCommand/5569741-expected.png: Added.
  • platform/chromium-mac-leopard/editing/execCommand/insert-list-and-stitch-expected.png: Added.
  • platform/chromium-mac-leopard/editing/execCommand/insertHorizontalRule-expected.png: Added.
  • platform/chromium-mac-leopard/editing/inserting/5418891-expected.png: Added.
  • platform/chromium-mac-leopard/editing/inserting/editing-empty-divs-expected.png: Added.
  • platform/chromium-mac-leopard/editing/inserting/insert-paragraph-02-expected.png: Added.
  • platform/chromium-mac-leopard/editing/inserting/insert-paragraph-03-expected.png: Added.
  • platform/chromium-mac-leopard/editing/inserting/paragraph-separator-01-expected.png: Added.
  • platform/chromium-mac-leopard/editing/inserting/paragraph-separator-02-expected.png: Added.
  • platform/chromium-mac-leopard/editing/inserting/paragraph-separator-03-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/4242293-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/8145-2-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/merge-after-delete-1-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/merge-after-delete-2-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/merge-after-delete-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/paste-text-013-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/paste-text-014-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/13804-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/5234383-1-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/5234383-2-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png: Added.
  • platform/chromium-mac-leopard/editing/spelling/inline_spelling_markers-expected.png: Added.
  • platform/chromium-mac-leopard/editing/spelling/spelling-expected.png: Added.
  • platform/chromium-mac-leopard/editing/style/5046875-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-3928305-fix-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/deleting/delete-3928305-fix-expected.png.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-3959464-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-and-undo-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-contents-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-contiguous-ws-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-to-select-table-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-trailing-ws-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/execCommand/5569741-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/execCommand/insert-list-and-stitch-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/execCommand/insertHorizontalRule-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/5418891-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/editing-empty-divs-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-007-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-007-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-007-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-012-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-012-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-013-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-013-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-014-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-014-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-015-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-015-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-016-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-016-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-017-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-017-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-018-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-018-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-019-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-019-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-020-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-020-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-022-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-022-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-025-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-027-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-027-expected.png.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-02-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-03-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-text-with-newlines-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-01-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-02-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-03-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/typing-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/typing-around-br-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/4242293-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/8145-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/cut-text-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-013-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/pasteboard/paste-text-013-expected.png.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-014-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/pasteboard/paste-text-014-expected.png.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-019-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/13804-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/5234383-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/5234383-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-word-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-backwords-by-word-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-character-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-line-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-word-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/spelling/inline_spelling_markers-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/spelling/inline_spelling_markers-expected.png.
  • platform/chromium-mac-snowleopard/editing/spelling/spelling-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/5046875-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/block-styles-007-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-002-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-002-expected.png.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-003-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-003-expected.png.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-004-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-004-expected.png.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-006-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-006-expected.png.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-008-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-008-expected.png.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-009-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-009-expected.png.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-011-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-011-expected.png.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-012-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-012-expected.png.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-013-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-013-expected.png.
  • platform/chromium-mac/editing/deleting/delete-3959464-fix-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-and-undo-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-block-contents-003-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-contiguous-ws-001-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-tab-002-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-tab-003-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-to-select-table-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-trailing-ws-002-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-002-expected.png: Removed.
  • platform/chromium-mac/editing/execCommand/5569741-expected.png: Removed.
  • platform/chromium-mac/editing/execCommand/insert-list-and-stitch-expected.png: Removed.
  • platform/chromium-mac/editing/execCommand/insertHorizontalRule-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/5418891-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/editing-empty-divs-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-br-004-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-br-005-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-br-007-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-div-025-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-paragraph-02-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-paragraph-03-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-tab-002-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-tab-003-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-text-with-newlines-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/paragraph-separator-01-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/paragraph-separator-02-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/paragraph-separator-03-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/return-key-with-selection-001-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/return-key-with-selection-002-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/return-key-with-selection-003-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/typing-002-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/typing-around-br-001-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/4242293-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/8145-2-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/cut-text-001-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-1-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-2-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-text-019-expected.png: Removed.
  • platform/chromium-mac/editing/selection/13804-expected.png: Removed.
  • platform/chromium-mac/editing/selection/5234383-1-expected.png: Removed.
  • platform/chromium-mac/editing/selection/5234383-2-expected.png: Removed.
  • platform/chromium-mac/editing/selection/extend-by-word-001-expected.png: Removed.
  • platform/chromium-mac/editing/selection/move-backwords-by-word-001-expected.png: Removed.
  • platform/chromium-mac/editing/selection/move-by-character-001-expected.png: Removed.
  • platform/chromium-mac/editing/selection/move-by-line-001-expected.png: Removed.
  • platform/chromium-mac/editing/selection/move-by-word-001-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png: Removed.
  • platform/chromium-mac/editing/selection/unrendered-002-expected.png: Removed.
  • platform/chromium-mac/editing/spelling/spelling-expected.png: Removed.
  • platform/chromium-mac/editing/style/5046875-2-expected.png: Removed.
  • platform/chromium-mac/editing/style/block-styles-007-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/height-width-inline-table-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/height-width-inline-table-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/height-width-inline-table-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/height-width-table-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/height-width-table-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/height-width-table-001-expected.txt.
  • platform/chromium/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Added.
  • platform/chromium/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
  • platform/chromium/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Added.
  • platform/chromium/css2.1/20110323/height-width-inline-table-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/height-width-table-001-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/editing/deleting/delete-3959464-fix-expected.txt: Removed.
  • platform/mac/editing/deleting/delete-block-contents-003-expected.txt: Removed.
  • platform/mac/editing/deleting/delete-trailing-ws-002-expected.txt: Removed.
  • platform/mac/editing/deleting/delete-ws-fixup-001-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-br-004-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-br-005-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-br-007-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-007-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-012-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-013-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-014-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-015-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-016-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-017-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-018-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-019-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-020-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-022-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-025-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-027-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-tab-002-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-tab-003-expected.txt: Removed.
  • platform/mac/editing/inserting/return-key-with-selection-001-expected.txt: Removed.
  • platform/mac/editing/inserting/return-key-with-selection-002-expected.txt: Removed.
  • platform/mac/editing/inserting/return-key-with-selection-003-expected.txt: Removed.
  • platform/mac/editing/inserting/typing-002-expected.txt: Removed.
  • platform/mac/editing/inserting/typing-around-br-001-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-019-expected.txt: Removed.
  • platform/mac/editing/selection/extend-by-word-001-expected.txt: Removed.
  • platform/mac/editing/selection/move-backwords-by-word-001-expected.txt: Removed.
  • platform/mac/editing/selection/move-by-character-001-expected.txt: Removed.
  • platform/mac/editing/selection/move-by-line-001-expected.txt: Removed.
  • platform/mac/editing/selection/move-by-word-001-expected.txt: Removed.
  • platform/mac/editing/style/block-styles-007-expected.txt: Removed.
  • platform/mac/editing/style/create-block-for-style-002-expected.txt: Removed.
  • platform/mac/editing/style/create-block-for-style-003-expected.txt: Removed.
  • platform/mac/editing/style/create-block-for-style-004-expected.txt: Removed.
  • platform/mac/editing/style/create-block-for-style-006-expected.txt: Removed.
  • platform/mac/editing/style/create-block-for-style-008-expected.txt: Removed.
  • platform/mac/editing/style/create-block-for-style-009-expected.txt: Removed.
  • platform/mac/editing/style/create-block-for-style-011-expected.txt: Removed.
  • platform/mac/editing/style/create-block-for-style-012-expected.txt: Removed.
  • platform/mac/editing/style/create-block-for-style-013-expected.txt: Removed.
  • platform/qt/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Removed.
  • platform/qt/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Removed.
  • platform/win/editing/inserting/insert-div-013-expected.txt: Removed.
  • platform/win/editing/inserting/insert-div-015-expected.txt: Removed.
  • platform/win/editing/inserting/insert-div-019-expected.txt: Removed.
  • platform/win/editing/inserting/insert-paragraph-03-expected.txt: Removed.
  • platform/win/editing/selection/move-by-word-001-expected.txt: Removed.
  • platform/win/editing/style/create-block-for-style-008-expected.txt: Removed.
8:13 PM Changeset in webkit [97581] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

Generate XMLHttpRequest constructor for JSC by [Constructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=70208

Reviewed by Adam Barth.

This patch generates an XMLHttpRequest constructor for JSC by [Constructor] IDL,
but V8 is still using a custom constructor since the V8 constructor requires a special logic.

Tests: fast/dom/global-constructors.html

fast/dom/XMLHttpRequest-constants.html
fast/dom/xmlhttprequest-constructor-in-detached-document.html
http/tests/security/cookies/xmlhttprequest.html

  • bindings/js/JSXMLHttpRequestCustom.cpp: Removed an XMLHttpRequest custom constructor.
  • bindings/scripts/CodeGeneratorV8.pm: Currently, CodeGeneratorV8.pm generates constructor code whenever [Constructor] is specified, even if [V8CustomConstructor] is specified. This is wrong. This patch fixes the condition where the constructor code is generated.
  • bindings/scripts/test/V8/V8TestObj.cpp: Updated a run-binding-tests result.
  • xml/XMLHttpRequest.h: Added a necessary header.
  • xml/XMLHttpRequest.idl: V8 is still using a custom constructor.
7:02 PM Changeset in webkit [97580] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Generate XSLTProcessor constructor for JSC by [Constructor] IDL.
https://bugs.webkit.org/show_bug.cgi?id=70206

Reviewed by Adam Barth.

Tests: fast/xsl/xslt-processor.html

fast/xsl/default-html.html
fast/dom/global-constructors.html

  • bindings/js/JSXSLTProcessorCustom.cpp: Removed a custom constructor.
  • xml/XSLTProcessor.idl: Removed 'JSCustomConstructor'.
6:11 PM Changeset in webkit [97579] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

[chromium] Remove PageAllocatorSymbian.h, OSAllocatorSymbian.cpp, gtk/ThreadingGtk.cpp from gyp project files
https://bugs.webkit.org/show_bug.cgi?id=70205

Reviewed by James Robinson.

wtf/PageAllocatorSymbian.h and wtf/OSAllocatorSymbian.cpp were removed in r97557.
wtf/gtk/ThreadingGtk.cpp was removed in r97269.

4:30 PM Changeset in webkit [97578] by haraken@chromium.org
  • 10 edits in trunk/Source/WebCore

Support [Constructor] IDL for JSC.
https://bugs.webkit.org/show_bug.cgi?id=70101

Reviewed by Adam Barth.

The spec for [Constructor] IDL is here: http://www.w3.org/TR/WebIDL/#Constructor
This patch introduced [Constructor] IDL for JSC. This patch also added
[ConstructorRaisesException] for JSC. If [ConstructorRaisesException] is specified,
a placeholder for ExceptionCode is passed to XXX::create(), like XXX::create(..., ec).

Notes:

  • We do not yet support constructor overloading.
  • We do not yet support [Optional] without CallWithDefaultValue for constructor arguments.

Tests: Source/WebCore/bindings/scripts/test/TestInterface.idl

Source/WebCore/bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): Generates constructor declaration code to a header file, if a given DOM object has constructor.
(GenerateImplementation): Uses GenerateArgumentsCountCheck() and GenerateParametersCheck().
(GenerateArgumentsCountCheck): Splits out of GenerateImplementation() for reuse.
(GenerateParametersCheck): Splits out of GenerateImplementation() for reuse.
(GenerateConstructorDefinition): Generates constructor definition code.

  • bindings/scripts/test/JS/JSTestInterface.cpp: Updated the run-binding-tests results.

(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):

  • bindings/scripts/test/JS/JSTestInterface.h: Ditto.

(WebCore::JSTestInterfaceConstructor::create):
(WebCore::JSTestInterfaceConstructor::createStructure):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.

(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h: Ditto.

(WebCore::JSTestMediaQueryListListenerConstructor::create):
(WebCore::JSTestMediaQueryListListenerConstructor::createStructure):

  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.

(WebCore::jsTestObjPrototypeFunctionVoidMethod):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethod):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethod):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionMethodWithException):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrame):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoid):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObj):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContext):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod1):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod2):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5):
(WebCore::jsTestObjPrototypeFunctionClassMethod):
(WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional):

  • bindings/scripts/test/JS/JSTestObj.h: Ditto.

(WebCore::JSTestObjConstructor::create):
(WebCore::JSTestObjConstructor::createStructure):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: Ditto.

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure):

2:37 PM Changeset in webkit [97577] by Csaba Osztrogonác
  • 2 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed weekend gardening.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/files/url-required-arguments-expected.txt: Added.
12:19 PM Changeset in webkit [97576] by dslomov@google.com
  • 10 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=70186
Pass MessagePortArray to JSC's SerializedScriptValue::serialize/deserialize.

Reviewed by Oliver Hunt.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::handlePostMessage):
(WebCore::JSDOMWindow::postMessage):
(WebCore::JSDOMWindow::webkitPostMessage):

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data):
(WebCore::handleInitMessageEvent):
(WebCore::JSMessageEvent::initMessageEvent):
(WebCore::JSMessageEvent::webkitInitMessageEvent):

  • bindings/js/JSMessagePortCustom.h:

(WebCore::handlePostMessage):

  • bindings/js/JSPopStateEventCustom.cpp:

(WebCore::JSPopStateEvent::state):

  • bindings/js/ScriptValue.cpp:

(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::deserialize):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):

  • bindings/js/SerializedScriptValue.h:
8:55 AM Changeset in webkit [97575] by mitz@apple.com
  • 3 edits
    3 adds in trunk

REGRESSION (r96620): Float-avoiding block positioned incorrectly in right-to-left block
https://bugs.webkit.org/show_bug.cgi?id=70197

Reviewed by Dave Kilzer.

Source/WebCore:

Test: fast/block/float/avoidance-rtl.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats): Changed
logicalLeftOffsetForContent() to startOffsetForContent() to get the right value in the
right-to-left case.

LayoutTests:

  • fast/block/float/avoidance-rtl-expected.png: Added.
  • fast/block/float/avoidance-rtl-expected.txt: Added.
  • fast/block/float/avoidance-rtl.html: Added.
3:28 AM Changeset in webkit [97574] by abarth@webkit.org
  • 113 edits in trunk

Always enable ENABLE(DOM_STORAGE)
https://bugs.webkit.org/show_bug.cgi?id=70189

Reviewed by Eric Seidel.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

As discussed on webkit-dev, we are reducing the complexity of WebKit by
removing unnecessary configuration options. DOMStorage is not a core
part of the web platform. It should always be enabled.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.exp.in:
  • WebCore.pro:
  • bindings/js/JSEventCustom.cpp:
  • bindings/js/JSInjectedScriptHostCustom.cpp:
  • bindings/js/JSStorageCustom.cpp:
  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::storageIdCallback):

  • bindings/v8/custom/V8StorageCustom.cpp:
  • dom/Document.cpp:

(WebCore::Document::createEvent):

  • dom/Event.cpp:

(WebCore::Event::isStorageEvent):

  • dom/Event.h:
  • dom/Node.cpp:
  • features.pri:
  • inspector/InjectedScriptHost.cpp:

(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::disconnect):
(WebCore::InjectedScriptHost::storageIdImpl):

  • inspector/InjectedScriptHost.h:

(WebCore::InjectedScriptHost::init):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::restoreInspectorStateFromCookie):

  • inspector/InspectorController.h:
  • inspector/InspectorDOMStorageAgent.cpp:
  • inspector/InspectorDOMStorageResource.cpp:
  • inspector/InspectorDOMStorageResource.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::didUseDOMStorageImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didUseDOMStorage):

  • inspector/InstrumentingAgents.h:

(WebCore::InstrumentingAgents::InstrumentingAgents):

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):

  • inspector/generate-inspector-idl:
  • page/Chrome.cpp:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::clear):
(WebCore::DOMWindow::localStorage):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/Navigator.cpp:

(WebCore::Navigator::getStorageUpdates):

  • page/Navigator.h:
  • page/Navigator.idl:
  • page/Page.cpp:
  • page/Page.h:
  • page/PageGroup.cpp:

(WebCore::PageGroup::closeLocalStorage):

  • page/PageGroup.h:
  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setSessionStorageQuota):

  • page/Settings.h:

(WebCore::Settings::sessionStorageQuota):

  • storage/LocalStorageTask.cpp:
  • storage/LocalStorageTask.h:
  • storage/LocalStorageThread.cpp:
  • storage/LocalStorageThread.h:
  • storage/Storage.cpp:
  • storage/Storage.h:
  • storage/Storage.idl:
  • storage/StorageArea.h:
  • storage/StorageAreaImpl.cpp:
  • storage/StorageAreaImpl.h:
  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::scheduleSync):

  • storage/StorageAreaSync.h:
  • storage/StorageEvent.cpp:
  • storage/StorageEvent.h:
  • storage/StorageEvent.idl:
  • storage/StorageEventDispatcher.cpp:
  • storage/StorageEventDispatcher.h:
  • storage/StorageMap.cpp:
  • storage/StorageMap.h:
  • storage/StorageNamespace.cpp:
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp:
  • storage/StorageNamespaceImpl.h:
  • storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::scheduleDeleteEmptyDatabase):

  • storage/StorageSyncManager.h:
  • storage/StorageTracker.cpp:
  • storage/StorageTracker.h:

Source/WebKit/chromium:

  • features.gypi:
  • src/StorageAreaProxy.cpp:
  • src/StorageAreaProxy.h:
  • src/StorageEventDispatcherChromium.cpp:
  • src/StorageEventDispatcherImpl.cpp:
  • src/StorageEventDispatcherImpl.h:
  • src/StorageNamespaceProxy.cpp:
  • src/StorageNamespaceProxy.h:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableLocalStorage):
(WebKit::WebRuntimeFeatures::isLocalStorageEnabled):
(WebKit::WebRuntimeFeatures::enableSessionStorage):
(WebKit::WebRuntimeFeatures::isSessionStorageEnabled):

  • src/WebStorageAreaImpl.cpp:
  • src/WebStorageAreaImpl.h:
  • src/WebStorageEventDispatcherImpl.cpp:
  • src/WebStorageEventDispatcherImpl.h:
  • src/WebStorageNamespaceImpl.cpp:
  • src/WebStorageNamespaceImpl.h:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • Storage/WebStorageManager.mm:
  • Storage/WebStorageManagerInternal.h:
  • Storage/WebStorageTrackerClient.h:
  • Storage/WebStorageTrackerClient.mm:

(WebStorageTrackerClient::dispatchDidModifyOrigin):

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

Tools:

  • Scripts/build-webkit:
  • waf/build/settings.py:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

  • fast/events/event-creation.html:
Note: See TracTimeline for information about the timeline view.