⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 18, 2011:

11:57 PM Changeset in webkit [97836] by haraken@chromium.org
  • 13 edits
    1 delete in trunk

Generate a SharedWorker constructor of V8 using [Constructor] IDL
​https://bugs.webkit.org/show_bug.cgi?id=67879

Reviewed by Hajime Morita.

Source/WebCore:

Spec: ​http://dev.w3.org/html5/workers/#shared-workers-and-the-sharedworker-interface
This patch changed SharedWorker::create(..., context, ec) to
SharedWorker::create(context, ..., ec), since a parameter specified by [CallWith]
should come at the beginning (c.f. bug 69799).

Test: ui_tests:WorkerTest.FLAKY_SharedWorkerFastConstructor

ui_tests:WorkerTest.FLAKY_SharedWorkerFastName

  • WebCore.gypi: Removed bindings/v8/custom/V8SharedWorkerCustom.cpp
  • WebCore.pro: Ditto.
  • bindings/js/JSSharedWorkerCustom.cpp: Moved ScriptExecutionContext parameter to the beginning.

(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker):

  • bindings/v8/custom/V8SharedWorkerCustom.cpp: Removed.
  • workers/SharedWorker.cpp: Moved ScriptExecutionContext parameter to the beginning.

(WebCore::SharedWorker::create): Ditto.

  • workers/SharedWorker.h: Ditto.
  • workers/SharedWorker.idl: Added [Constructor] IDL.

LayoutTests:

Added test cases for an undefined name and a null name on SharedWorker constructor.

  • fast/workers/resources/shared-worker-name.js:

(test7.try.worker.port.onmessage):
(test7): A test case for a null name.
(test8.worker.port.onmessage):
(test8): Ditto.
(test9.try.worker.port.onmessage):
(test9): A test case for an undefined name.
(test10.worker.port.onmessage):
(test10): Ditto.

  • fast/workers/shared-worker-constructor-expected.txt:
  • fast/workers/shared-worker-constructor.html:
  • fast/workers/shared-worker-name-expected.txt:
  • platform/chromium-win/fast/workers/shared-worker-constructor-expected.txt: Updated SyntaxError with TypeError. The reason why ui_tests has been so far working without updating this error type is that shared-worker-constructor.html is marked FLAKY in chromium.
11:42 PM Changeset in webkit [97835] by yuzo@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Attempt to fix Linux Clang compilation error.

Unreviewed.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestThreadOnly::runTestThreaded):
(WTF::TEST_F):

10:36 PM Changeset in webkit [97834] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Rolled out last Windows build fix because it was wrong.

10:18 PM Changeset in webkit [97833] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/912

Merge 97786 - Crash in RenderDeprecatedFlexibleBox::layoutHorizontalBox

BUG=100459
Review URL: ​http://codereview.chromium.org/8345035

10:16 PM Changeset in webkit [97832] by hayato@chromium.org
  • 1 add in branches/components/README.components-branch

A test commit, adding a README.components-branch file.

9:32 PM Changeset in webkit [97831] by jnd@chromium.org
  • 5 edits in trunk

Source/WebCore: Implement NSProcessInfo::systemUptime on Mac Leopard.
​https://bugs.webkit.org/show_bug.cgi?id=66577

Reviewed by Tony Chang.

  • WebCore.gyp/WebCore.gyp:
  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(-[NSProcessInfo systemUptime]):

LayoutTests: Enable touch tests on Mac Leopard.
​https://bugs.webkit.org/show_bug.cgi?id=66577

Reviewed by Tony Chang.

  • platform/chromium/test_expectations.txt:
8:55 PM Changeset in webkit [97830] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Rolled out last Windows build fix because it was wrong.

8:47 PM Changeset in webkit [97829] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix part of the Windows build.

Export!

8:10 PM Changeset in webkit [97828] by ojan@chromium.org
  • 10 edits
    2 moves
    1 add
    2 deletes in trunk/LayoutTests

Unreviewed. New expected results after ​http://trac.webkit.org/changeset/97707.

  • fast/table/height-percent-test-vertical-expected.txt: Renamed from LayoutTests/platform/gtk/fast/table/height-percent-test-vertical-expected.txt.
  • platform/chromium-linux/fast/table/028-vertical-expected.png:
  • platform/chromium-linux/fast/table/height-percent-test-vertical-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/fallback-orientation-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/writing-mode/fallback-orientation-expected.png.
  • platform/chromium-win-vista/fast/writing-mode/fallback-orientation-expected.png: Removed.
  • platform/chromium-win-xp/fast/writing-mode/fallback-orientation-expected.png:
  • platform/chromium-win/fast/table/028-vertical-expected.png:
  • platform/chromium-win/fast/table/028-vertical-expected.txt:
  • platform/chromium-win/fast/table/height-percent-test-vertical-expected.png:
  • platform/chromium-win/fast/writing-mode/fallback-orientation-expected.png:
  • platform/chromium-win/fast/writing-mode/fallback-orientation-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/qt/fast/table/height-percent-test-vertical-expected.txt: Removed.
7:54 PM Changeset in webkit [97827] by ggaren@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

Switched ropes from malloc memory to GC memory
​https://bugs.webkit.org/show_bug.cgi?id=70364

Reviewed by Gavin Barraclough.

~1% SunSpider speedup. Neutral elsewhere. Removes one cause for strings
having C++ destructors.

  • heap/MarkStack.cpp:

(JSC::visitChildren): Call the JSString visitChildren function now,
since it's no longer a no-op.

  • runtime/JSString.cpp:

(JSC::JSString::~JSString): Moved this destructor out of line because
it's called virtually, so there's no value to inlining.

(JSC::JSString::RopeBuilder::expand): Switched RopeBuilder to be a thin
initializing wrapper around JSString. JSString now represents ropes
directly, rather than relying on an underlying malloc object.

(JSC::JSString::visitChildren): Visit our rope fibers, since they're GC
objects now.

(JSC::JSString::resolveRope):
(JSC::JSString::resolveRopeSlowCase):
(JSC::JSString::outOfMemory): Updated for operating on JSStrings instead
of malloc objects.

(JSC::JSString::replaceCharacter): Removed optimizations for substringing
ropes and replacing subsections of ropes. We want to reimplement versions
of these optimizations in the future, but this patch already has good
performance without them.

  • runtime/JSString.h:

(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::finishCreation):
(JSC::RopeBuilder::createNull):
(JSC::RopeBuilder::create):
(JSC::RopeBuilder::createHasOtherOwner):
(JSC::jsSingleCharacterString):
(JSC::jsSingleCharacterSubstring):
(JSC::jsNontrivialString):
(JSC::jsString):
(JSC::jsSubstring):
(JSC::jsOwnedString): Lots of mechanical changes here. The two important
things are: (1) The fibers in JSString::m_fibers are JSStrings now, not
malloc objects; (2) I simplified the JSString constructor interface to
only accept PassRefPtr<StringImpl>, instead of variations on that like
UString, reducing refcount churn.

  • runtime/JSValue.h:
  • runtime/JSValue.cpp:

(JSC::JSValue::toPrimitiveString): Updated this function to return a
JSString instead of a UString, since that's what clients want now.

  • runtime/Operations.cpp:

(JSC::jsAddSlowCase):

  • runtime/Operations.h:

(JSC::jsString):

  • runtime/SmallStrings.cpp:

(JSC::SmallStrings::createEmptyString): Updated for interface changes above.

  • runtime/StringConstructor.cpp:

(JSC::constructWithStringConstructor):

  • runtime/StringObject.h:

(JSC::StringObject::create): Don't create a new JSString if we already
have a JSString.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncConcat): Updated for interface changes above.

6:50 PM Changeset in webkit [97826] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Errrk, fix partial commit of r97825!

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToISOString):

6:49 PM Changeset in webkit [97825] by barraclough@apple.com
  • 4 edits in trunk

Date.prototype.toISOString fails to throw exception
​https://bugs.webkit.org/show_bug.cgi?id=70394

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToISOString):

  • Should throw a range error if the internal value is not finite.

LayoutTests:

  • fast/js/date-toisostring-expected.txt:
  • fast/js/script-tests/date-toisostring.js:

(throwsRangeError):

  • fixed test case.
6:37 PM Changeset in webkit [97824] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

fix baseline for fast/history/history-back-twice-with-subframes-assert.html
​https://bugs.webkit.org/show_bug.cgi?id=70393

Reviewed by James Robinson.

the baseline added in r97821 appears to have had a couple of
extra lines in it.

  • fast/history/history-back-twice-with-subframes-assert-expected.txt:
6:37 PM Changeset in webkit [97823] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Try to jostle the windows build back to life.

  • rendering/HitTestResult.h:
6:16 PM Changeset in webkit [97822] by dpranke@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Update chromium leopard cg baseline.

Unreviewed, baseline update.

  • platform/chromium-cg-mac-leopard/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
5:52 PM Changeset in webkit [97821] by andersca@apple.com
  • 3 edits
    2 adds in trunk

Assertion failure when going back in page with navigated subframes
​https://bugs.webkit.org/show_bug.cgi?id=70389
<rdar://problem/8988444>

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/history/history-back-twice-with-subframes-assert.html

If a single navigation ends up loading multiple frame, the first committed frame will
end up calling recursiveUpdateForCommit on the main frame which will null out the provisional item
for all frames on the page. This means that it can null out the provisional item for any frames
that are still yet to be committed which causes the aforementioned assertion failure.

Fix this by only nulling out the provisional history item (and saving/restoring the scroll position and
some other things) for frames that already contain the URL that the item requested. If a frame is being loaded,
it will null out its provisional history item when it's committed.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::recursiveUpdateForCommit):

LayoutTests:

  • fast/history/history-back-twice-with-subframes-assert-expected.txt: Added.
  • fast/history/history-back-twice-with-subframes-assert.html: Added.
5:47 PM Changeset in webkit [97820] by levin@chromium.org
  • 7 edits in trunk/Tools

watchlist: Should try to run if it can and not throw on mistakes.
​https://bugs.webkit.org/show_bug.cgi?id=70358

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/system/outputcapture.py: Add the ability to capture log output.
  • Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adapt to the logging of errors.
  • Scripts/webkitpy/common/watchlist/watchlistparser.py: Change to log problems and fix problems when found.
  • Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Adapt to the logging of errors.
  • Scripts/webkitpy/common/watchlist/watchlistrule.py: Expose a way to remove instructions.
  • Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Test the new function.
5:40 PM Changeset in webkit [97819] by weinig@apple.com
  • 14 edits in trunk

Source/WebKit2: Move uses of C SPI out of WKView.h and into WKViewPrivate.h
​https://bugs.webkit.org/show_bug.cgi?id=70387

Reviewed by Dan Bernstein.

  • UIProcess/API/mac/WKViewPrivate.h:

Move declarations here.

  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateRemoteAccessibilityRegistration:]):
(-[WKView initWithFrame:]):
(-[WKView initWithFrame:contextRef:]):
(-[WKView _registerDraggedTypes]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView pageRef]):
(-[WKView canChangeFrameLayout:]):
(-[WKView printOperationWithPrintInfo:forFrame:]):
(-[WKView setFrame:andScrollBy:]):
Move definitions to private category.

  • UIProcess/API/mac/PDFViewController.mm:
  • UIProcess/mac/WKFullScreenWindowController.mm:
  • UIProcess/mac/WebInspectorProxyMac.mm:

Update to include WKViewPrivate.h where necessary.

Tools: Move uses of C-SPI out of WKView.h and into WKViewPrivate.h
​https://bugs.webkit.org/show_bug.cgi?id=70387

Reviewed by Dan Bernstein.

  • MiniBrowser/mac/BrowserWindowController.m:
  • TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
  • TestWebKitAPI/mac/JavaScriptTestMac.mm:
  • TestWebKitAPI/mac/PlatformWebViewMac.mm:
  • TestWebKitAPI/mac/WebKitAgnosticTest.mm:
  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

Update to include WKViewPrivate.h where necessary.

5:22 PM QtWebKitHacking edited by caio.oliveira@openbossa.org
(diff)
5:15 PM Changeset in webkit [97818] by dpranke@chromium.org
  • 18 edits in trunk

Unreviewed, rolling out r97765.
​http://trac.webkit.org/changeset/97765
​https://bugs.webkit.org/show_bug.cgi?id=70388

"broke webkit_unit_tests, http/tests/xmlhttprequest
/xmlhttprequest-test-send-flag.html on linux debug" (Requested
by dpranke on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-18

Source/WebCore:

  • WebCore.gypi:
  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::create):
(WebCore::DocumentThreadableLoader::~DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::cancel):
(WebCore::DocumentThreadableLoader::setDefersLoading):
(WebCore::DocumentThreadableLoader::willSendRequest):
(WebCore::DocumentThreadableLoader::didSendData):
(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::didReceiveData):
(WebCore::DocumentThreadableLoader::didReceiveCachedMetadata):
(WebCore::DocumentThreadableLoader::didFinishLoading):
(WebCore::DocumentThreadableLoader::didFail):
(WebCore::DocumentThreadableLoader::preflightSuccess):
(WebCore::DocumentThreadableLoader::loadRequest):

  • loader/DocumentThreadableLoader.h:
  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::CachedRawResource):
(WebCore::CachedRawResource::data):

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::setRequestedFromNetworkingLayer):

  • loader/cache/CachedResourceClient.h:
  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::~CachedResourceRequest):
(WebCore::CachedResourceRequest::willSendRequest):
(WebCore::CachedResourceRequest::didFinishLoading):
(WebCore::CachedResourceRequest::didReceiveResponse):
(WebCore::CachedResourceRequest::didReceiveData):

  • loader/cache/CachedResourceRequest.h:
  • loader/chromium/CachedRawResourceChromium.cpp: Removed.
  • loader/chromium/CachedResourceRequestChromium.cpp: Removed.
  • loader/chromium/DocumentThreadableLoaderChromium.cpp:

(WebCore::DocumentThreadableLoader::didDownloadData):

  • loader/icon/IconLoader.h:
  • platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::notifyResponse):

LayoutTests:

  • http/tests/inspector/network/network-content-replacement-xhr-expected.txt:
4:53 PM Changeset in webkit [97817] by mhahnenberg@apple.com
  • 22 edits in trunk/Source

Rename static put to putByIndex
​https://bugs.webkit.org/show_bug.cgi?id=70281

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Renaming versions of deleteProperty that use an unsigned as the property
name to "deletePropertyByIndex" in preparation for adding them to the
MethodTable, which requires unique names for each method.

  • dfg/DFGOperations.cpp:

(JSC::DFG::putByVal):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Arguments.cpp:

(JSC::Arguments::putVirtual):
(JSC::Arguments::putByIndex):

  • runtime/Arguments.h:
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncMap):

  • runtime/JSArray.cpp:

(JSC::JSArray::put):
(JSC::JSArray::putVirtual):
(JSC::JSArray::putByIndex):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::putVirtual):
(JSC::JSByteArray::putByIndex):

  • runtime/JSByteArray.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::putVirtual):
(JSC::JSCell::putByIndex):

  • runtime/JSCell.h:
  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::putVirtual):
(JSC::JSNotAnObject::putByIndex):

  • runtime/JSNotAnObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::putVirtual):
(JSC::JSObject::putByIndex):

  • runtime/JSObject.h:
  • runtime/RegExpConstructor.cpp:

(JSC::RegExpMatchesArray::fillArrayInstance):

  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::putVirtual):
(JSC::RegExpMatchesArray::putByIndex):

Source/WebCore:

No new tests.

Renaming versions of deleteProperty that use an unsigned as the property
name to "deletePropertyByIndex" in preparation for adding them to the
MethodTable, which requires unique names for each method.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::putVirtual):
(JSC::RuntimeArray::putByIndex):

  • bridge/runtime_array.h:
4:53 PM Changeset in webkit [97816] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Mark storage/domstorage/events/documentURI as a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=70386

Unreviewed, expectations change.

on chromium snowleopard.

  • platform/chromium/test_expectations.txt:
4:44 PM Changeset in webkit [97815] by dpranke@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

Add a new chromium baseline for fast/multicol/vertical-rl/rule-style.html.

Unreviewed, baseline update.

  • platform/chromium-cg-mac-snowleopard/fast/multicol/vertical-rl/rule-style-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/rule-style-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/rule-style-expected.txt: Added.
4:40 PM Changeset in webkit [97814] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, expectations update.

  • platform/chromium/test_expectations.txt:
4:38 PM Changeset in webkit [97813] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build.

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::absolutePDFURL):
Fix typo.

4:36 PM Changeset in webkit [97812] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

Unreviewed warning fix after ​https://bugs.webkit.org/show_bug.cgi?id=70269

  • WebCore.pro:
4:25 PM Changeset in webkit [97811] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

Stop leaking internal names in WKView API header
​https://bugs.webkit.org/show_bug.cgi?id=70380

Reviewed by Anders Carlsson.

Move _frameSizeUpdatesDisabledCount to WKViewData. Since we cannot change the size of
WKView due to the fragile Objective-C ABI, we must rename the existing variable unused. If
drop 32-bit support, we will be able to remove it.

  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView disableFrameSizeUpdates]):
(-[WKView enableFrameSizeUpdates]):
(-[WKView frameSizeUpdatesDisabled]):

  • WebKit2.xcodeproj/project.pbxproj:
4:20 PM Changeset in webkit [97810] by ap@apple.com
  • 14 edits in trunk/Source

Expose PDF information in hit test result
​https://bugs.webkit.org/show_bug.cgi?id=70353

Reviewed by Sam Weinig.

  • WebCore.exp.in:
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absolutePDFURL):
  • rendering/HitTestResult.h: Added HitTestResult::absolutePDFURL(). It will contain a URL when over a PDF object or embed; not sure if we want this for PDFImageDocuments.
4:19 PM Changeset in webkit [97809] by enne@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Preserve offscreen tiles instead of immediately recycling them
​https://bugs.webkit.org/show_bug.cgi?id=70352

Reviewed by James Robinson.

Tested by existing layout tests.

Prior to having a TextureManager class, tiled layers recycled their
textures internally to avoid reallocation. Unfortunately, it recycled
these tiles as soon as they went offscreen, even if they were still
valid. Instead, keep tiles around forever, letting the TextureManager
decide (via LRU) when to reclaim the underlying textures. This will
improve scrolling performance due to not needing to repaint tiles.

This change does lead to more texture reallocation for any textures
that get reclaimed, but the command buffer implementation already
pools and reuses texture ids, so it should not introduce additional
flush syncs. If there's any performance penalty, it'll be at the
driver level, but I'd prefer to measure that there's a problem before
prematurely optimizing and adding complexity to the TextureManager.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::cleanupResources):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/TiledLayerChromium.h:
4:17 PM Changeset in webkit [97808] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash in WebProcess at com.apple.AppKit: -[NSFilePromiseDragSource draggedImage:endedAt:operation:] + 101
​https://bugs.webkit.org/show_bug.cgi?id=70340
<rdar://problem/9548174>

We have seen a number of crash reports for this issue that seem to occurr when
the user drags an image from a web page onto the desktop.
We have not been able to reproduce this crash, therefore this is a speculative fix,
but the theory is that the dragging source has been already released when draggedImage
is called.
This patch attempts a fix for the problem by retaining the dragging source when
NSFilePromiseDragSource is created.

Reviewed by Darin Adler.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(-[WKPasteboardFilePromiseOwner initWithSource:]):
(-[WKPasteboardFilePromiseOwner dealloc]):

4:14 PM Changeset in webkit [97807] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Crash after storing credentials in Keychain
​https://bugs.webkit.org/show_bug.cgi?id=70376
<rdar://problem/9647503>

Reviewed by Dan Bernstein.

  • Shared/mac/SecKeychainItemResponseData.cpp: (WebKit::SecKeychainItemResponseData::encode): (WebKit::SecKeychainItemResponseData::decode): Actually send keychain item over, too. In shimSecKeychainItemCreateFromContent(), we are going to use it to override SecKeychainItemCreateFromContent(), and we cannot return noErr from this function without returning a non-null keychain item.
4:08 PM Changeset in webkit [97806] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

This revised fix doesn't break SL build.
​https://bugs.webkit.org/show_bug.cgi?id=70345

Reviewed and landed by Sam Weinig.

Patch by Damian Kaleta <​dkaleta@apple.com> on 2011-10-18

  • UIProcess/API/mac/WKView.mm:

(+[WKView hideWordDefinitionWindow]): Hides the definition window.

  • UIProcess/API/mac/WKViewPrivate.h:
4:06 PM Changeset in webkit [97805] by adamk@chromium.org
  • 3 edits
    2 adds in trunk

[MutationObservers] Implement WebKitMutationObserver.observe for characterData changes
​https://bugs.webkit.org/show_bug.cgi?id=68957

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/mutation/observe-characterdata.html

  • dom/CharacterData.cpp:

(WebCore::CharacterData::dispatchModifiedEvent):

LayoutTests:

  • fast/mutation/observe-characterdata-expected.txt: Added.
  • fast/mutation/observe-characterdata.html: Added.
4:06 PM Changeset in webkit [97804] by weinig@apple.com
  • 7 edits in trunk/Source/WebKit2

Move spellCheckerDocumentTag and handleCorrectionPanelResult from WKViewPrivate to WKViewInternal
​https://bugs.webkit.org/show_bug.cgi?id=70377

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView spellCheckerDocumentTag]):
(-[WKView handleCorrectionPanelResult:]):
Move definition of methods to (Internal) area.

  • UIProcess/API/mac/WKViewInternal.h:

Add methods.

  • UIProcess/API/mac/WKViewPrivate.h:

Remove methods.

  • UIProcess/cf/WebBackForwardListCF.cpp:

Add missing newline.

  • UIProcess/mac/CorrectionPanel.mm:

Change #include to WKViewInternal.h

  • WebKit2.xcodeproj/project.pbxproj:

Sort some files.

4:05 PM Changeset in webkit [97803] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Scroll animator tracing
​https://bugs.webkit.org/show_bug.cgi?id=70280

Patch by Scott Byer <​scottbyer@chromium.org> on 2011-10-18
Reviewed by James Robinson.

No functional difference, no test needed.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::animationTimerFired):

4:02 PM Changeset in webkit [97802] by jamesr@google.com
  • 7 edits in trunk/Source

[chromium] Remove USE(THREADED_COMPOSITING) from the tree, this is controlled by a runtime setting
​https://bugs.webkit.org/show_bug.cgi?id=70356

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

  • features.gypi:
  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::scheduleComposite):

  • src/WebLayerTreeViewImpl.h:
  • src/WebViewImpl.h:
3:58 PM Changeset in webkit [97801] by ojan@chromium.org
  • 3 edits in trunk/Source/WebCore

cleanup some FIXMEs in RenderFlexibleBox
​https://bugs.webkit.org/show_bug.cgi?id=70374

Reviewed by Darin Adler.

No new tests. Existing tests cover all changes.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::flowAwareBorderAndPaddingLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareMarginLogicalHeightForChild):

  • rendering/RenderFlexibleBox.h:

Removed the FIXME to implement computePreferredLogicalWidths. It doesn't
seem to be necessary, at least not with the current test cases.

3:57 PM Changeset in webkit [97800] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Move WKView helper files into a sub-group
​https://bugs.webkit.org/show_bug.cgi?id=70375

Reviewed by Darin Adler.

  • WebKit2.xcodeproj/project.pbxproj:

Move some files around.

3:48 PM Changeset in webkit [97799] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Remove expectations for tests that are no longer failing.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
3:47 PM Changeset in webkit [97798] by Joseph Pecoraro
  • 5 edits in trunk

<​http://webkit.org/b/70365> Web Inspector: Some localizedStrings.js Updates

Reviewed by Darin Adler.

Source/WebCore:

Fixed syntax issue, added missing strings, and removed a duplicate.

  • English.lproj/localizedStrings.js:

Tools:

  • Scripts/check-inspector-strings:

Updated to the new webkitpy way to determine checkout root.

  • Scripts/webkitdirs.pm:

(copyInspectorFrontendFiles):
Made it so build-webkit --inspector-frontend copies over
the localizedStrings.js file as well as the frontend files.

3:45 PM Changeset in webkit [97797] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] DRT: Clear list of visited pages before each test.
​https://bugs.webkit.org/show_bug.cgi?id=70355

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-10-18
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Add ewk_history_clear as a way to clear the list of visited pages in a
Ewk_History, in a similar fashion to Qt's QWebHistory::clear().

  • ewk/ewk_history.cpp:

(ewk_history_clear):

  • ewk/ewk_history.h:

Tools:

r97596 uncovered a bug in the implementation: the list of visited
links was not cleared between tests, which caused tests such as
fast/repaint/outline-repaint-glitch.html to be flaky (the link color
changed depending on whether fast/repaint/border-repaint-glitch.html
was visited before or not).

Call ewk_history_clear to make sure the visited links list does not
persist between tests.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

3:38 PM Changeset in webkit [97796] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

fix unused-but-set-variable warnings in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=70344

Reviewed by Adam Barth.

This is a new compiler warning in gcc 4.6.

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::isWrapperOfType):

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp:

(WebCore::ComplexTextController::normalizeSpacesAndMirrorChars):

3:37 PM Changeset in webkit [97795] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Enable out-of-thread compositing in WebKit compositor API
​https://bugs.webkit.org/show_bug.cgi?id=69850

Patch by Antoine Labour <​piman@chromium.org> on 2011-10-18
Reviewed by James Robinson.

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::composite):

3:14 PM Changeset in webkit [97794] by mitz@apple.com
  • 3 edits
    3 adds in trunk

Certain column-rule styles render incorrectly in vertical writing modes
​https://bugs.webkit.org/show_bug.cgi?id=70362

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/multicol/vertical-rl/rule-style.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules): Use the correct border sides for vertical writing modes.

LayoutTests:

  • fast/multicol/vertical-rl/rule-style-expected.png: Added.
  • fast/multicol/vertical-rl/rule-style-expected.txt: Added.
  • fast/multicol/vertical-rl/rule-style.html: Added.
3:07 PM Changeset in webkit [97793] by annacc@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix broken binding tests by changing G_MAXUSHORT to G_MAXUINT in WebKitDOMTestObj.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=70267

Reviewed by Daniel Bates.

Tests: fixing WebKitDOMTestObj.cpp

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_class_init): Change G_MAXUSHORT to G_MAXUINT

3:04 PM Changeset in webkit [97792] by inferno@chromium.org
  • 3 edits in trunk/Source/WebKit2

Unreviewed, rolling out r97788.
​http://trac.webkit.org/changeset/97788
​https://bugs.webkit.org/show_bug.cgi?id=70366

broke compile (Requested by inferno-sec on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-18

  • UIProcess/API/mac/WKView.mm:
  • UIProcess/API/mac/WKViewPrivate.h:
2:57 PM Changeset in webkit [97791] by barraclough@apple.com
  • 5 edits in trunk

Array.prototype methods missing exception checks
​https://bugs.webkit.org/show_bug.cgi?id=70360

Reviewed by Geoff Garen.

Missing exception checks after calls to the static getProperty helper,
these may result in the wrong exception being thrown (or an ASSERT being hit,
as is currently the case running test-262).

Source/JavaScriptCore:

No performance impact.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):

LayoutTests:

  • fast/js/array-proto-func-property-getter-except-expected.txt:
  • fast/js/script-tests/array-proto-func-property-getter-except.js:
    • The test results that change were only testing for an absence of a crash; the new results are correct (the first exception thrown should be the one returned).
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T4-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T6-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T7-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T8-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T9-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T11-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T12-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T4-expected.txt:
    • Check in passing results.
2:07 PM Changeset in webkit [97790] by dpranke@chromium.org
  • 1 edit
    7 adds in trunk/LayoutTests

Add missing baselines for fast/selectors/visited-descendant.

Unreviewed, expectations change.

  • platform/chromium-cg-mac-leopard/fast/selectors/visited-descendant-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/selectors/visited-descendant-expected.png: Added.
  • platform/chromium-linux/fast/selectors/visited-descendant-expected.png: Added.
  • platform/chromium-mac-leopard/fast/selectors/visited-descendant-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/selectors/visited-descendant-expected.png: Added.
  • platform/chromium-win/fast/selectors/visited-descendant-expected.png: Added.
  • platform/chromium-win/fast/selectors/visited-descendant-expected.txt: Added.
2:01 PM Changeset in webkit [97789] by adamk@chromium.org
  • 3 edits in trunk/LayoutTests

Corrected bad cut-and-paste in MutationObserver test description.

Unreviewed.

  • fast/mutation/observe-attributes-expected.txt:
  • fast/mutation/observe-attributes.html:
1:50 PM Changeset in webkit [97788] by kdecker@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-10-18 Damian Kaleta <​dkaleta@apple.com>

Add WebKit API to hide the definition window
​https://bugs.webkit.org/show_bug.cgi?id=70345

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm: (-[WKView hideWordDefinitionWindow]): Hides the definition window.
  • UIProcess/API/mac/WKViewPrivate.h:
1:44 PM Changeset in webkit [97787] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/874

Merge 97786 - Crash in RenderDeprecatedFlexibleBox::layoutHorizontalBox

BUG=97786
Review URL: ​http://codereview.chromium.org/8346010

1:42 PM Changeset in webkit [97786] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in RenderDeprecatedFlexibleBox::layoutHorizontalBox
​https://bugs.webkit.org/show_bug.cgi?id=70183

Patch by Julien Chaffraix <​jchaffraix@webkit.org> on 2011-10-18
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/flexbox/layoutHorizontal-crash.html

The deferred scroll information update logic was not updated when an object was destroy'ed.

The fix is very simple. As the deferred logic was only used with deprecated flexbox, it is a
pretty uncommon cases so let's optimize the new code for the common case.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::willBeDestroyed):

LayoutTests:

  • fast/flexbox/layoutHorizontal-crash-expected.txt: Added.
  • fast/flexbox/layoutHorizontal-crash.html: Added.
1:09 PM Changeset in webkit [97785] by adamk@chromium.org
  • 3 edits in trunk/Source/WebCore

[MutationObservers] Clean up MutationObserver code in Node
​https://bugs.webkit.org/show_bug.cgi?id=70349

Reviewed by Ryosuke Niwa.

Three small cleanups.

No new tests, no behavior change.

  • dom/Node.cpp:

(WebCore::Node::clearRareData): Use indices instead of iterator in for loop; fix typo.
(WebCore::Node::registerMutationObserver): Inline single call to Node::ensureMutationObserverEntries.

  • dom/Node.h: Make mutationObserverEntries private.
12:55 PM Changeset in webkit [97784] by jamesr@google.com
  • 10 edits
    1 add in trunk/Source

[chromium] Fix shutdown race when posting main thread task to CCThreadProxy and enable tests
​https://bugs.webkit.org/show_bug.cgi?id=70161

Reviewed by David Levin.

Source/WebCore:

Adds a weak pointer mechanism to cancel main thread tasks posted to CCThreadProxy instances from the compositor
thread. Previously there was a race condition where main thread tasks could run even after the CCThreadProxy was
destroyed.

This race does not exist in the other direction because when tearing down a CCThreadProxy we first post a quit
task to the compositor thread and then suspend execution of the main thread until all compositor tasks for the
CCThreadProxy have been drained.

Covered by the now-enabled CCLayerTreeHostTest* unit tests.

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCScopedMainThreadProxy.h: Added.

(WebCore::CCScopedMainThreadProxy::create):
(WebCore::CCScopedMainThreadProxy::postTask):
(WebCore::CCScopedMainThreadProxy::shutdown):
(WebCore::CCScopedMainThreadProxy::CCScopedMainThreadProxy):
(WebCore::CCScopedMainThreadProxy::runTaskIfNotShutdown):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

Enables the CCLayerTreeHostTest* tests by default. Most tests are run twice in a single thread and multiple
thread configuration. Some tests run only in the multiple thread configuration if they depend on the compositor
thread scheduling draws by itself.

  • tests/CCLayerTreeHostTest.cpp:

(::CCLayerTreeHostTest::timeout):
(::CCLayerTreeHostTest::clearTimeout):
(::CCLayerTreeHostTest::CCLayerTreeHostTest):
(::CCLayerTreeHostTest::onEndTest):
(::CCLayerTreeHostTest::TimeoutTask::TimeoutTask):
(::CCLayerTreeHostTest::TimeoutTask::clearTest):
(::CCLayerTreeHostTest::TimeoutTask::~TimeoutTask):
(::CCLayerTreeHostTest::TimeoutTask::Run):
(::CCLayerTreeHostTest::runTest):
(::CCLayerTreeHostTest::doBeginTest):
(::CCLayerTreeHostTestThreadOnly::runTest):
(::CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):

12:35 PM Changeset in webkit [97783] by ojan@chromium.org
  • 5 edits
    12 adds in trunk

implement flex-flow:column
​https://bugs.webkit.org/show_bug.cgi?id=70082

Reviewed by David Hyatt.

Source/WebCore:

There's still a bug with a FIXME where we don't compute the right
size for the container of the flexbox in the presence of
orthogonal flows. That's the cause of all the failing cases
in the tests.

Tests: css3/flexbox/flex-flow-border.html

css3/flexbox/flex-flow-margins.html
css3/flexbox/flex-flow-orientations.html
css3/flexbox/flex-flow-overflow.html
css3/flexbox/flex-flow-padding.html
css3/flexbox/flex-flow.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::hasOrthogonalFlow):
(WebCore::RenderFlexibleBox::isColumnFlow):
(WebCore::RenderFlexibleBox::isHorizontalFlow):
(WebCore::RenderFlexibleBox::isLeftToRightFlow):
Use isHorizontalFlow and isLeftToRightFlow so that methods like
flowAwareBorderStart look exactly like borderStart with
isHorizontalWritingMode and isLeftToRightDirection replaced.

(WebCore::RenderFlexibleBox::setFlowAwareLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareLogicalHeightForChild):
(WebCore::RenderFlexibleBox::flowAwareLogicalWidthForChild):
(WebCore::RenderFlexibleBox::flowAwareLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareLogicalWidth):
(WebCore::RenderFlexibleBox::flowAwareContentLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareContentLogicalWidth):
(WebCore::RenderFlexibleBox::transformedWritingMode):
Transform the writing-mode based of the flex-flow and direction
values. That methods like flowAwareBorderBefore look exactly like
borderBefore, except it switches over a different value.

(WebCore::RenderFlexibleBox::flowAwareBorderStart):
(WebCore::RenderFlexibleBox::flowAwareBorderBefore):
(WebCore::RenderFlexibleBox::flowAwareBorderAfter):
(WebCore::RenderFlexibleBox::flowAwarePaddingStart):
(WebCore::RenderFlexibleBox::flowAwarePaddingBefore):
(WebCore::RenderFlexibleBox::flowAwarePaddingAfter):
(WebCore::RenderFlexibleBox::flowAwareMarginStartForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginEndForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginBeforeForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginAfterForChild):
(WebCore::RenderFlexibleBox::setFlowAwareMarginStartForChild):
(WebCore::RenderFlexibleBox::setFlowAwareMarginEndForChild):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
(WebCore::RenderFlexibleBox::alignChildrenBlockDirection):

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/flex-flow-border-expected.txt: Added.
  • css3/flexbox/flex-flow-border.html: Added.

Failures are due to not handling orthogonal flows correctly.

  • css3/flexbox/flex-flow-expected.txt: Added.
  • css3/flexbox/flex-flow-margins-expected.txt: Added.
  • css3/flexbox/flex-flow-margins.html: Added.
  • css3/flexbox/flex-flow-orientations-expected.txt: Added.
  • css3/flexbox/flex-flow-orientations.html: Added.
  • css3/flexbox/flex-flow-overflow-expected.txt: Added.
  • css3/flexbox/flex-flow-overflow.html: Added.
  • css3/flexbox/flex-flow-padding-expected.txt: Added.
  • css3/flexbox/flex-flow-padding.html: Added.

Failures are due to not handling orthogonal flows correctly.

  • css3/flexbox/flex-flow.html: Added.
  • css3/flexbox/resources/flexbox.js:

Added the ability to check offsets that include clientLeft/clientTop
and for checking clientWidth/clientHeight. This is neede dfor the border tests.

12:31 PM Changeset in webkit [97782] by Dimitri Glazkov
  • 4 edits
    2 copies in trunk/Tools

Split TestExpectationsEditor into its own file.
​https://bugs.webkit.org/show_bug.cgi?id=70348

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py.
  • Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py.
  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Adjusted for change.
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
  • Scripts/webkitpy/tool/servers/gardeningserver.py: Ditto.
12:24 PM Changeset in webkit [97781] by rniwa@webkit.org
  • 2 edits in trunk/Tools

[Chromium] buildbot runs nrwt with --chromium instead of --chromium-cg-mac
​https://bugs.webkit.org/show_bug.cgi?id=70313

Reviewed by Adam Barth.

Fixed the bug by passing --platform --chromium-cg-mac in RunWebKitTests. We can't always add
this parameter because build-webkit and other scripts don't accept it.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
12:10 PM Changeset in webkit [97780] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

[chromium] Tracking update rects in LayerChromium and CCLayerImpl.
​https://bugs.webkit.org/show_bug.cgi?id=69441

Patch by Shawn Singh <​shawnsingh@chromium.org> on 2011-10-18
Reviewed by James Robinson.

This patch does not do much on its own, but is just part 1 of a
string of other patches which will use these rects for
visualization and scissoring. The appropriate testing will be
associated with those patches.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::cleanupResources):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::updateRect):
(WebCore::CCLayerImpl::setUpdateRect):

11:19 AM Changeset in webkit [97779] by tony@chromium.org
  • 2 edits in branches/chromium/912/Source/WebCore

Merge 97724 - r97638 caused 3 printing crashes
​https://bugs.webkit.org/show_bug.cgi?id=70284

Reviewed by Kent Tamura.

Null check element.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclarations):

TBR=​tkent@chromium.org
Review URL: ​http://codereview.chromium.org/8344008

11:18 AM Changeset in webkit [97778] by annacc@chromium.org
  • 3 edits in trunk/Source/WebCore

Change CodeGeneratorGObject.pm to use g_value_get_uint() instead of g_value_get_ushort()
for IDL attributes of type unsigned short.
​https://bugs.webkit.org/show_bug.cgi?id=70267

Reviewed by Xan Lopez.

Tests: small change to WebKitDOMTestObj.cpp

  • bindings/scripts/CodeGeneratorGObject.pm:

(GetGValueTypeName): convert unsigned short to uint instead of ushort

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_set_property): expect g_value_get_uint instead of g_value_get_ushort
(webkit_dom_test_obj_class_init): expect G_MAXUSHORT instead of G_MAXUINT16

11:06 AM Changeset in webkit [97777] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: ScriptsPanel's should use similar logic to decide whether it could show an anchor location and actually showing it.
​https://bugs.webkit.org/show_bug.cgi?id=70322

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._showSourceLine):

10:56 AM Changeset in webkit [97776] by abarth@webkit.org
  • 2 edits in trunk/Tools

Subscribe myself to WebIDL changes
​https://bugs.webkit.org/show_bug.cgi?id=70341

Reviewed by David Levin.

I've also added some documentation and refactored my previous
subscriptions to make it eaiser for others to subscribe as well.

  • Scripts/webkitpy/common/config/watchlist:
10:39 AM Changeset in webkit [97775] by caryclark@google.com
  • 174 edits
    55 adds in trunk/LayoutTests

Rebaseline most remaining IMAGE diffs for chromium-mac (Skia)
on SnowLeopard (10.6).

Unreviewed gardening.

  • platform/chromium-mac-snowleopard/editing/deleting/delete-3959464-fix-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5569741-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5418891-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/typing-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4242293-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/13804-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5234383-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5234383-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/spelling/spelling-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/block-styles-007-expected.png:
  • platform/chromium-mac/css2.1/20110323/block-replaced-width-001-expected.png:
  • platform/chromium-mac/css2.1/t1602-c43-center-00-d-ag-expected.png:
  • platform/chromium-mac/editing/deleting/delete-3959464-fix-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-and-undo-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-block-contents-003-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-contiguous-ws-001-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-002-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-tab-003-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-to-select-table-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-trailing-ws-002-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-002-expected.png: Added.
  • platform/chromium-mac/editing/execCommand/5569741-expected.png: Added.
  • platform/chromium-mac/editing/execCommand/insert-list-and-stitch-expected.png: Added.
  • platform/chromium-mac/editing/execCommand/insertHorizontalRule-expected.png: Added.
  • platform/chromium-mac/editing/inserting/5418891-expected.png: Added.
  • platform/chromium-mac/editing/inserting/editable-inline-element-expected.png:
  • platform/chromium-mac/editing/inserting/editing-empty-divs-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-br-004-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-br-005-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-br-007-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-div-025-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-paragraph-02-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-paragraph-03-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-tab-002-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-tab-003-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-text-with-newlines-expected.png: Added.
  • platform/chromium-mac/editing/inserting/paragraph-separator-01-expected.png: Added.
  • platform/chromium-mac/editing/inserting/paragraph-separator-02-expected.png: Added.
  • platform/chromium-mac/editing/inserting/paragraph-separator-03-expected.png: Added.
  • platform/chromium-mac/editing/inserting/return-key-with-selection-001-expected.png: Added.
  • platform/chromium-mac/editing/inserting/return-key-with-selection-002-expected.png: Added.
  • platform/chromium-mac/editing/inserting/return-key-with-selection-003-expected.png: Added.
  • platform/chromium-mac/editing/inserting/typing-002-expected.png: Added.
  • platform/chromium-mac/editing/inserting/typing-around-br-001-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/4242293-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/4641033-expected.png:
  • platform/chromium-mac/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/5478250-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-2-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/cut-text-001-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-1-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-2-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/merge-end-blockquote-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/paste-text-019-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/pasting-tabs-expected.png:
  • platform/chromium-mac/editing/selection/13804-expected.png: Added.
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/4397952-expected.png:
  • platform/chromium-mac/editing/selection/5234383-1-expected.png: Added.
  • platform/chromium-mac/editing/selection/5234383-2-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-before-select-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-word-001-expected.png: Added.
  • platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png:
  • platform/chromium-mac/editing/selection/fake-doubleclick-expected.png:
  • platform/chromium-mac/editing/selection/iframe-expected.png:
  • platform/chromium-mac/editing/selection/move-backwords-by-word-001-expected.png: Added.
  • platform/chromium-mac/editing/selection/move-by-character-001-expected.png: Added.
  • platform/chromium-mac/editing/selection/move-by-line-001-expected.png: Added.
  • platform/chromium-mac/editing/selection/move-by-word-001-expected.png: Added.
  • platform/chromium-mac/editing/selection/move-past-trailing-space-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-mac/editing/selection/select-all-001-expected.png:
  • platform/chromium-mac/editing/selection/select-all-002-expected.png:
  • platform/chromium-mac/editing/selection/select-box-expected.png:
  • platform/chromium-mac/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-mac/editing/selection/selection-3748164-fix-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-001-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-003-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-004-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-005-expected.png:
  • platform/chromium-mac/editing/spelling/spelling-expected.png: Added.
  • platform/chromium-mac/editing/style/5046875-1-expected.png:
  • platform/chromium-mac/editing/style/block-styles-007-expected.png: Added.
  • platform/chromium-mac/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
  • platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/chromium-mac/fast/css/color-correction-expected.png:
  • platform/chromium-mac/fast/css/color-correction-on-backgrounds-expected.png:
  • platform/chromium-mac/fast/css/focus-ring-outline-width-expected.png:
  • platform/chromium-mac/fast/css/outline-auto-location-expected.png:
  • platform/chromium-mac/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac/fast/dom/focus-contenteditable-expected.png:
  • platform/chromium-mac/fast/events/autoscroll-expected.png:
  • platform/chromium-mac/fast/events/context-no-deselect-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac/fast/forms/input-placeholder-visibility-2-expected.png:
  • platform/chromium-mac/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac/fast/forms/listbox-hit-test-zoomed-expected.png:
  • platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac/fast/forms/select-listbox-multiple-no-focusring-expected.png:
  • platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac/fast/forms/textarea-scrollbar-expected.png:
  • platform/chromium-mac/fast/forms/textarea-scrolled-type-expected.png:
  • platform/chromium-mac/fast/forms/textfield-outline-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac/fast/inline/continuation-outlines-expected.png:
  • platform/chromium-mac/fast/inline/continuation-outlines-with-layers-2-expected.png:
  • platform/chromium-mac/fast/inline/continuation-outlines-with-layers-expected.png:
  • platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.png:
  • platform/chromium-mac/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-direction-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-masks-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-masks-opacity-expected.png:
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac/fast/text/international/rtl-caret-expected.png:
  • platform/chromium-mac/fast/text/justify-nbsp-expected.png:
  • platform/chromium-mac/fast/text/justify-padding-distribution-expected.png:
  • platform/chromium-mac/fast/transforms/transformed-caret-expected.png:
  • platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac/svg/clip-path/clip-path-transform-1-expected.png: Added.
  • platform/chromium-mac/svg/clip-path/clip-path-transform-2-expected.png: Added.
  • platform/chromium-mac/svg/css/group-with-shadow-expected.png:
  • platform/chromium-mac/svg/custom/alignment-baseline-modes-expected.png:
  • platform/chromium-mac/svg/custom/createImageElement-expected.png:
  • platform/chromium-mac/svg/custom/dominant-baseline-modes-expected.png:
  • platform/chromium-mac/svg/custom/external-paintserver-reference-expected.png: Added.
  • platform/chromium-mac/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-mac/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac/svg/custom/font-face-cascade-order-expected.png:
  • platform/chromium-mac/svg/custom/font-face-simple-expected.png:
  • platform/chromium-mac/svg/custom/glyph-selection-lang-attribute-expected.png:
  • platform/chromium-mac/svg/custom/group-opacity-expected.png:
  • platform/chromium-mac/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/chromium-mac/svg/custom/invalid-css-expected.png:
  • platform/chromium-mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-expected.png:
  • platform/chromium-mac/svg/custom/linking-base-external-reference-expected.png: Added.
  • platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac/svg/custom/text-image-opacity-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium-mac/svg/filters/filter-source-position-expected.png:
  • platform/chromium-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-mac/transforms/2d/compound-transforms-vs-containers-expected.png:
10:37 AM Changeset in webkit [97774] by Dimitri Glazkov
  • 2 edits in trunk/Tools

Add myself to the newfangled watchlist plumbing.
​https://bugs.webkit.org/show_bug.cgi?id=70338

Reviewed by David Levin.

  • Scripts/webkitpy/common/config/watchlist: Added sheepishly.
10:34 AM Changeset in webkit [97773] by eric.carlson@apple.com
  • 19 edits
    3 deletes in trunk/Source/WebCore

2011-10-18 Eric Carlson <​eric.carlson@apple.com>

Use the new cached cue loader
​https://bugs.webkit.org/show_bug.cgi?id=70269

Reviewed by Antti Koivisto.

No new tests, no functionality changed.

  • CMakeLists.txt: Remove CueParser.cpp/h and CueParserPrivate.h.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadTextTracks): (WebCore::HTMLMediaElement::textTrackReadyStateChanged): New, not implemented yet. (WebCore::HTMLMediaElement::textTrackModeChanged): Ditto. (WebCore::HTMLMediaElement::textTrackCreated): Ditto. (WebCore::HTMLMediaElement::textTrackAddCues): Ditto. (WebCore::HTMLMediaElement::textTrackRemoveCues): Ditto. (WebCore::HTMLMediaElement::textTrackAddCue): Ditto. (WebCore::HTMLMediaElement::textTrackRemoveCue): Ditto.
  • html/HTMLMediaElement.h:
  • html/HTMLTrackElement.cpp: (WebCore::HTMLTrackElement::load): Update for interface change (WebCore::HTMLTrackElement::textTrackLoadingCompleted): New, dispatch 'load' or 'error' event.
  • html/HTMLTrackElement.h:
  • html/LoadableTextTrack.cpp: (WebCore::LoadableTextTrack::LoadableTextTrack): Add TextTrackClient and TextTrackLoadingClient

parameters.

(WebCore::LoadableTextTrack::load): Make url parameter KURL instead of String. Create the

cue loader, trigger the load.

(WebCore::LoadableTextTrack::newCuesAvailable): New callback from the loader. Not implemented yet.
(WebCore::LoadableTextTrack::cueLoadingStarted): Ditto.
(WebCore::LoadableTextTrack::cueLoadingCompleted): Ditto.

  • html/LoadableTextTrack.h:
  • html/MutableTextTrack.cpp: (WebCore::MutableTextTrack::MutableTextTrack): Add TextTrackClient parameter.
  • html/MutableTextTrack.h: (WebCore::MutableTextTrack::create):
  • html/TextTrack.cpp: (WebCore::TextTrack::TextTrack): Add TextTrackClient parameter. (WebCore::TextTrack::~TextTrack): Tell the client to remove all cues, forget the client. (WebCore::TextTrack::setReadyState): Tell client about ready state change. (WebCore::TextTrack::setMode): Tell client about mode change.
  • html/TextTrack.h: (WebCore::TextTrackClient::textTrackAddCues): New client interface. (WebCore::TextTrackClient::textTrackRemoveCues): Ditto. (WebCore::TextTrackClient::textTrackAddCue): Ditto. (WebCore::TextTrackClient::textTrackRemoveCue): Ditto. (WebCore::TextTrack::create): (WebCore::TextTrack::trackType): New. (WebCore::TextTrack::client): Ditto. (WebCore::TextTrack::setClient): Ditto.
  • html/track/CueParser.cpp: Removed.
  • html/track/CueParser.h: Removed.
  • html/track/CueParserPrivate.h: Removed.
  • html/track/WebVTTParser.cpp: (WebCore::WebVTTParser::fileIdentifierMaximumLength): New, return length of WebVTT file

magic number.

(WebCore::WebVTTParser::hasRequiredFileIdentifier): Update to use constants instead of hard

coded lengths.

(WebCore::WebVTTParser::WebVTTParser): Initialize "m_client" in the initilization list

instead of setting it in the constructor.

(WebCore::WebVTTParser::getNewCues): Renamed from fetchParsedCues.

  • html/track/WebVTTParser.h: (WebCore::WebVTTParser::create): Take a WebVTTParserClient* instead of a CueParserPrivateClient*.
  • loader/CueLoader.cpp: (WebCore::CueLoader::CueLoader): (WebCore::CueLoader::~CueLoader): Remove client. (WebCore::CueLoader::cueLoadTimerFired): Tell client about new clues and/or that the load

has finished.

(WebCore::CueLoader::processNewCueData): Process newly loaded data.
(WebCore::CueLoader::didReceiveData): Ditto.
(WebCore::CueLoader::notifyFinished): Do final processing as necessary, prime the timer

to call client.

(WebCore::CueLoader::load): Create resource loader, initiate loading.
(WebCore::CueLoader::newCuesParsed): Prime timer to tell client about newly parsed cues.
(WebCore::CueLoader::getNewCues): Get new cues from parser.

  • loader/CueLoader.h: (WebCore::CueLoader::create):
10:33 AM Changeset in webkit [97772] by Dimitri Glazkov
  • 2 edits in trunk/Tools

Fix a unit test in TestFailures.
​https://bugs.webkit.org/show_bug.cgi?id=70337

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Turns out,

the value of a method property should always be lowercase.

10:26 AM QtWebKitHacking edited by caio.oliveira@openbossa.org
File naming conventions (diff)
10:21 AM Changeset in webkit [97771] by abarth@webkit.org
  • 90 edits in trunk

Always enable ENABLE(XPATH)
​https://bugs.webkit.org/show_bug.cgi?id=70217

Reviewed by Eric Seidel.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

As discussed on webkit-dev, we're reducing the complexity of WebKit by
removing unneeded configuration options. ENABLE(XPATH) is enabled on
every port, so we are removing the ability to disable the feature.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.pro:
  • bindings/js/JSCustomXPathNSResolver.cpp:
  • bindings/js/JSCustomXPathNSResolver.h:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):

  • bindings/js/JSExceptionBase.cpp:

(WebCore::toExceptionBase):

  • bindings/js/JSXPathResultCustom.cpp:
  • bindings/objc/DOMCustomXPathNSResolver.h:
  • bindings/objc/DOMCustomXPathNSResolver.mm:
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMUtility.mm:

(JSC::createDOMWrapper):

  • bindings/objc/DOMXPath.mm:

(kit):

  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::getXPathNSResolver):

  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setDOMException):

  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8CustomXPathNSResolver.cpp:
  • bindings/v8/custom/V8CustomXPathNSResolver.h:
  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):

  • dom/Document.cpp:
  • dom/Document.h:
  • dom/Document.idl:
  • dom/ExceptionCode.cpp:

(WebCore::getExceptionCodeDescription):

  • dom/ExceptionCode.h:
  • features.pri:
  • inspector/InspectorDOMAgent.cpp:
  • page/DOMWindow.idl:
  • xml/NativeXPathNSResolver.cpp:
  • xml/NativeXPathNSResolver.h:
  • xml/XPathEvaluator.cpp:
  • xml/XPathEvaluator.h:
  • xml/XPathEvaluator.idl:
  • xml/XPathException.h:
  • xml/XPathException.idl:
  • xml/XPathExpression.cpp:
  • xml/XPathExpression.h:
  • xml/XPathExpression.idl:
  • xml/XPathExpressionNode.cpp:
  • xml/XPathExpressionNode.h:
  • xml/XPathFunctions.cpp:
  • xml/XPathFunctions.h:
  • xml/XPathGrammar.y:
  • xml/XPathNSResolver.cpp:
  • xml/XPathNSResolver.h:
  • xml/XPathNSResolver.idl:
  • xml/XPathNodeSet.cpp:
  • xml/XPathNodeSet.h:
  • xml/XPathParser.cpp:
  • xml/XPathParser.h:
  • xml/XPathPath.cpp:
  • xml/XPathPath.h:
  • xml/XPathPredicate.cpp:
  • xml/XPathPredicate.h:
  • xml/XPathResult.cpp:
  • xml/XPathResult.h:
  • xml/XPathResult.idl:
  • xml/XPathStep.cpp:
  • xml/XPathStep.h:
  • xml/XPathUtil.cpp:
  • xml/XPathUtil.h:
  • xml/XPathValue.cpp:
  • xml/XPathValue.h:
  • xml/XPathVariableReference.cpp:
  • xml/XPathVariableReference.h:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/win:

  • Interfaces/DOMWindow.idl:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
10:17 AM Changeset in webkit [97770] by Dimitri Glazkov
  • 3 edits in trunk/Tools

garden-o-matic should not report flaking in expected failures as failures.
​https://bugs.webkit.org/show_bug.cgi?id=70279

Reviewed by Adam Barth.

On the bots, flakes that are already expected to fail aren't reported as failures (they keep the bot green).
For example, if TEXT failure is expected, a TEXT TIMEOUT result will not cause the redness. We should do the
same for garden-o-matic.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Spuriously changed to use Array iterators rather than jQuery APIs,

rewrote the logic for determining expected or unexpected failures as a central analysis tool.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Added unit tests.
10:06 AM Changeset in webkit [97769] by Chris Fleizach
  • 4 edits
    2 adds in trunk

AX: buttons of number type <input> controls are not fully accessible
​https://bugs.webkit.org/show_bug.cgi?id=70241

Source/WebCore:

Staged commit, part 6.

Reviewed by Darin Adler.

Test: platform/mac/accessibility/html5-input-number.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::addImageMapChildren):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

Reviewed by Darin Adler.

  • platform/mac/accessibility/html5-input-number-expected.txt: Added.
  • platform/mac/accessibility/html5-input-number.html: Added.
10:04 AM Changeset in webkit [97768] by barraclough@apple.com
  • 6 edits in trunk/LayoutTests

Indexed arguments on the Arguments object should be enumerable.
​https://bugs.webkit.org/show_bug.cgi?id=70302

Reviewed by Sam Weinig.

See ECMA-262 5.1 chapter 10.6 step 11b.
This is visible through a number of means, including Object.keys, Object.getOwnPropertyDescriptor, and operator in.

  • fast/js/kde/function-expected.txt:
  • fast/js/kde/script-tests/function.js:

(foo2):

  • This tests using 'in'.
  • fast/js/arguments-expected.txt:
  • fast/js/script-tests/arguments.js:

(descriptor):

  • This tests using 'Object.getOwnPropertyDescriptor'.
  • ietestcenter/Javascript/15.2.3.14-3-4-expected.txt:
    • This tests using 'Object.keys'.
10:03 AM Changeset in webkit [97767] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Indexed arguments on the Arguments object should be enumerable.
​https://bugs.webkit.org/show_bug.cgi?id=70302

Reviewed by Sam Weinig.

See ECMA-262 5.1 chapter 10.6 step 11b.
This is visible through a number of means, including Object.keys, Object.getOwnPropertyDescriptor, and operator in.

  • runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertyDescriptor):

  • The 'enumerable' property should be true for indexed arguments.

(JSC::Arguments::getOwnPropertyNames):

  • Don't guard the adding of indexed properties with 'IncludeDontEnumProperties'.
9:59 AM Changeset in webkit [97766] by alexis.menard@openbossa.org
  • 21 edits
    3 deletes in trunk

[Qt] Merge QML plugin for WebKit2 with the original WebKit1 plugin

.:

We don't need a sepearate plugin, as we no longer expose the WK2
APIs under QtWebKit.experimental, but now use QtWebKit. The version
was also changed to 3.0 instead of 5.0, as the original plugin was
versioned 1.0, and bumping to 3.0 fits the scheme used by QtWebKit releases.

Patch by Tor Arne Vestbø <​tor.arne.vestbo@nokia.com> on 2011-10-18
Reviewed by Andreas Kling.

  • Source/WebKit.pro:

Source/WebKit/qt:

We don't need a separate plugin, as we no longer expose the WK2
APIs under QtWebKit.experimental, but now use QtWebKit. The version
was also changed to 3.0 instead of 5.0, as the original plugin was
versioned 1.0, and bumping to 3.0 fits the scheme used by QtWebKit releases.

Patch by Tor Arne Vestbø <​tor.arne.vestbo@nokia.com> on 2011-10-18
Reviewed by Andreas Kling.

  • declarative/declarative.pro:
  • declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes):

Source/WebKit2:

We don't need a separate plugin, as we no longer expose the WK2
APIs under QtWebKit.experimental, but now use QtWebKit. The version
was also changed to 3.0 instead of 5.0, as the original plugin was
versioned 1.0, and bumping to 3.0 fits the scheme used by QtWebKit releases.

Patch by Tor Arne Vestbø <​tor.arne.vestbo@nokia.com> on 2011-10-18
Reviewed by Andreas Kling.

  • UIProcess/API/qt/qmlplugin/plugin.cpp: Removed.
  • UIProcess/API/qt/qmlplugin/qmldir: Removed.
  • UIProcess/API/qt/qmlplugin/qmlplugin.pro: Removed.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadFail.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgress.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_load.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadFail.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadNegativeSizeView.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgressSignal.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadZeroSizeView.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml:
9:31 AM Changeset in webkit [97765] by Nate Chapin
  • 16 edits
    2 copies in trunk

Source/WebCore: Make DocumentThreadableLoader a CachedResourceClient.
This will allow us to cache ThreadableLoaderClients as
appropriate in a later patch.
​https://bugs.webkit.org/show_bug.cgi?id=61225

Reviewed by Antti Koivisto.

No new tests, no functionality change intended.

  • WebCore.gypi:
  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::notifyFinished): CachedResourceClients don't send separate callbacks

for didFail() and didFinishLoading(), so we need to differentiate here.

(WebCore::DocumentThreadableLoader::loadRequest): Call CachedResourceLoader::requestRawResource()

instead of ResourceLoadScheduler::scheduleSubresourceLoad().

  • loader/DocumentThreadableLoader.h:
  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::data): Handle the complexity of some ThreadableLoaderClients setting

DoNotBufferData in ResoureLoaderOptions. If the DataBufferingPolicy is BufferData, then the
'data' input parameter will contain all data received so far, and we need to determine the
incremental data to forward to the clients. If the policy is DoNotBufferData, 'data' is just
the incremental data.

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResource.h:

(WebCore::CachedResource::preloadResult):
(WebCore::CachedResource::didSendData):
(WebCore::CachedResource::didDownloadData):
(WebCore::CachedResource::setLoadFinishTime):
(WebCore::CachedResource::loadFinishTime):

  • loader/cache/CachedResourceClient.h: Add several new callbacks needed by DocumentThreadableLoader.
  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveResponse): CachedResource::setResponse() can now cancel

the request, so protect appropriately.

  • loader/cache/CachedResourceRequest.h:
  • loader/chromium/CachedRawResourceChromium.cpp: Added (plumb didDownloadData() to DocumentThreadableLoader).
  • loader/chromium/CachedResourceRequestChromium.cpp: Added (plumb didDownloadData() to DocumentThreadableLoader).
  • loader/chromium/DocumentThreadableLoaderChromium.cpp:
  • platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::notifyResponse): Protect before setting response, since it might kill us.

LayoutTests: Test update for ​https://bugs.webkit.org/show_bug.cgi?id=61225.
Due to changes in the implementation of DocumentThreadableLoader (and
therefore XHR), this test will have empty (rather than null) content
if we go over the length limit.

Reviewed by Antti Koivisto.

  • http/tests/inspector/network/network-content-replacement-xhr-expected.txt:
9:15 AM Changeset in webkit [97764] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

Unreviewed, rolling out r97752.
​http://trac.webkit.org/changeset/97752
​https://bugs.webkit.org/show_bug.cgi?id=70332

Caused assertion failures in MediaList::setParentStyleSheet()
on the apple bots. (Requested by kling on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-18

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.h:
  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::CSSImportRule):
(WebCore::CSSImportRule::~CSSImportRule):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):

  • css/CSSMediaRule.h:
  • css/MediaList.cpp:

(WebCore::MediaList::MediaList):
(WebCore::MediaList::notifyChanged):

  • css/MediaList.h:
  • css/StyleSheet.cpp:

(WebCore::StyleSheet::~StyleSheet):
(WebCore::StyleSheet::setMedia):

9:08 AM Changeset in webkit [97763] by Dimitri Glazkov
  • 1 add in branches/chromium/912/codereview.settings

Added codereview settings.

9:07 AM Changeset in webkit [97762] by annacc@chromium.org
  • 3 edits in trunk/Source/WebCore

Change TextTrack to use the word DISABLED instead of OFF for mode
​https://bugs.webkit.org/show_bug.cgi?id=70268

Reviewed by Daniel Bates.

No new tests. No new functionality.

  • html/TextTrack.cpp:

(WebCore::TextTrack::setMode): use Disabled instead of Off

  • html/TextTrack.h: update Mode enum to use Disabled instead of Off
9:04 AM Changeset in webkit [97761] by Dimitri Glazkov
  • 1 copy in branches/chromium/912

Created branch 912.

8:51 AM Changeset in webkit [97760] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] ASSERT when displaying context menu in input field
​https://bugs.webkit.org/show_bug.cgi?id=69859

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2011-10-18
Reviewed by Simon Hausmann.

When creating a submenu in the context menu, the submenu of type
QWidget is statically cast to QObject before calling setParent on
it. QObject::setParent asserts if the object is a QWidget. So, call
setParent of QWidget itself.

  • UIProcess/qt/WebContextMenuProxyQt.cpp:

(WebKit::WebContextMenuProxyQt::createContextMenu):

8:50 AM Changeset in webkit [97759] by Chris Fleizach
  • 3 edits in trunk/Source/WebCore

AX: buttons of number type <input> controls are not fully accessible
​https://bugs.webkit.org/show_bug.cgi?id=70241

Staged commit, part 5.

Reviewed by Darin Adler.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::boundingBoxRect):

8:48 AM Changeset in webkit [97758] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Move default stylesheet loading to a separate function
​https://bugs.webkit.org/show_bug.cgi?id=70331

Reviewed by Andreas Kling.

  • Move default stylesheet loading out from CSSStyleSelector::styleForElement()
  • Rename e -> element
  • Remove pointless reffing of the placeholder style.
  • css/CSSStyleSelector.cpp:

(WebCore::ensureDefaultStyleSheetsForElement):
(WebCore::isAtShadowBoundary):
(WebCore::CSSStyleSelector::styleForElement):

8:43 AM Changeset in webkit [97757] by Chris Fleizach
  • 4 edits in trunk/Source/WebCore

AX: buttons of number type <input> controls are not fully accessible
​https://bugs.webkit.org/show_bug.cgi?id=70241

Staged commit part 4.

Reviewed by Darin Adler.

  • accessibility/AccessibilityMockObject.h:

(WebCore::AccessibilityMockObject::isMockObject):
(WebCore::AccessibilityMockObject::detachFromParent):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::elementAccessibilityHitTest):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

8:38 AM Changeset in webkit [97756] by Chris Fleizach
  • 7 edits
    2 adds in trunk/Source/WebCore

AX: buttons of number type <input> controls are not fully accessible
​https://bugs.webkit.org/show_bug.cgi?id=70241

Staged commit part 3. Committing the new spin button classes.

Reviewed by Darin Adler.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilitySpinButton.cpp: Added.

(WebCore::AccessibilitySpinButton::create):
(WebCore::AccessibilitySpinButton::AccessibilitySpinButton):
(WebCore::AccessibilitySpinButton::~AccessibilitySpinButton):
(WebCore::AccessibilitySpinButton::incrementButton):
(WebCore::AccessibilitySpinButton::decrementButton):
(WebCore::AccessibilitySpinButton::elementRect):
(WebCore::AccessibilitySpinButton::addChildren):
(WebCore::AccessibilitySpinButton::step):
(WebCore::AccessibilitySpinButtonPart::AccessibilitySpinButtonPart):
(WebCore::AccessibilitySpinButtonPart::create):
(WebCore::AccessibilitySpinButtonPart::elementRect):
(WebCore::AccessibilitySpinButtonPart::press):

  • accessibility/AccessibilitySpinButton.h: Added.

(WebCore::AccessibilitySpinButton::setSpinButtonElement):
(WebCore::AccessibilitySpinButton::roleValue):
(WebCore::AccessibilitySpinButton::accessibilityIsIgnored):
(WebCore::AccessibilitySpinButton::isSpinButton):
(WebCore::AccessibilitySpinButtonPart::~AccessibilitySpinButtonPart):
(WebCore::AccessibilitySpinButtonPart::isIncrementor):
(WebCore::AccessibilitySpinButtonPart::setIsIncrementor):
(WebCore::AccessibilitySpinButtonPart::roleValue):
(WebCore::AccessibilitySpinButtonPart::isSpinButtonPart):
(WebCore::AccessibilitySpinButtonPart::accessibilityIsIgnored):
(WebCore::toAccessibilitySpinButton):
(WebCore::toAccessibilitySpinButtonPart):

8:28 AM Changeset in webkit [97755] by Chris Fleizach
  • 6 edits in trunk/Source

AX: buttons of number type <input> controls are not fully accessible
​https://bugs.webkit.org/show_bug.cgi?id=70241

../WebCore:

Phase 2 of the staged commit.

Reviewed by Darin Adler.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::boundingBoxForQuads):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isSpinButton):
(WebCore::AccessibilityObject::isSpinButtonPart):
(WebCore::AccessibilityObject::isMockObject):

../WebKit/chromium:

Reviewed by Darin Adler.

  • public/WebAccessibilityRole.h:
  • src/AssertMatchingEnums.cpp:
8:26 AM Changeset in webkit [97754] by kov@webkit.org
  • 4 edits in trunk/Source

Fix distcheck.

Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2011-10-18

Source/JavaScriptCore

  • GNUmakefile.list.am: fix a typo and add a missing header to the

list.

Source/WebKit/gtk/po

  • GNUmakefile.am: create po directory when it's not there yet both

when updating the pot and the po files.

8:22 AM Changeset in webkit [97753] by Chris Fleizach
  • 3 edits in trunk/Source/WebCore

AX: buttons of number type <input> controls are not fully accessible
​https://bugs.webkit.org/show_bug.cgi?id=70241

Expose the spin button object to the AX hierarchy. Since there is no distinct
render object that backs this object, a mock object needs to be created for the entire
spin button and the actual increment and decrement buttons inside.

This will be a staged commit since the first time around Windows layout tests started crashing for an undeterminable reason.

Reviewed by Darin Adler.

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::step):
(WebCore::SpinButtonElement::repeatingTimerFired):

  • html/shadow/TextControlInnerElements.h:
8:05 AM Changeset in webkit [97752] by andreas.kling@nokia.com
  • 9 edits in trunk/Source/WebCore

MediaList: Remove inheritance from StyleBase.
​https://bugs.webkit.org/show_bug.cgi?id=70203

Reviewed by Darin Adler.

  • css/MediaList.h:

(WebCore::MediaList::parentStyleSheet):
(WebCore::MediaList::setParentStyleSheet):

  • css/MediaList.cpp:

(WebCore::MediaList::MediaList):
(WebCore::MediaList::notifyChanged):

Change MediaList to no longer inherit from StyleBase. The parent()/setParent()
mechanism was replaced by explicit parentStyleSheet()/setParentStyleSheet().

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::CSSImportRule):
(WebCore::CSSImportRule::~CSSImportRule):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):

Change StyleBase::setParent() calls to MediaList::setParentStyleSheet().
CSSRules are never moved between stylesheets, so the parent style sheet pointer
is valid for the MediaList's lifetime.

  • css/StyleSheet.cpp:

(WebCore::StyleSheet::~StyleSheet):

Change StyleBase::setParent() calls to MediaList::setParentStyleSheet().

(WebCore::StyleSheet::setMedia):

Change StyleBase::setParent() calls to MediaList::setParentStyleSheet().
Assert that the parent sheet is either null, or this, as MediaLists should never
be reparented to other sheets.
Assert that the StyleSheet is indeed a CSSStyleSheet. XSLStyleSheet inherits from
StyleSheet, but it shouldn't be using the MediaList.

  • bindings/js/JSDOMBinding.h:

(WebCore::root):

Add MediaList* specific overload for root() since it can't fall back
to root(StyleBase*) anymore.

  • WebCore.xcodeproj/project.pbxproj:

Add some PrivateHeaders to accomodate the JSDOMBinding.h changes.

  • css/CSSMediaRule.h:

Remove unnecessary forward-declaration of MediaList.

7:35 AM Changeset in webkit [97751] by andreas.kling@nokia.com
  • 7 edits in trunk/Source/WebCore

XSLStyleSheet only needs to manage XSLImportRule children.
​https://bugs.webkit.org/show_bug.cgi?id=70326

Reviewed by Antti Koivisto.

  • css/StyleBase.h:
  • xml/XSLImportRule.h:
  • css/CSSRule.h:

(WebCore::CSSRule::isImportRule):

Move StyleBase::isImportRule() down to CSSRule. Since XSLImportRule no longer
implements it, it's now specific to CSSImportRule.

  • xml/XSLStyleSheet.h:

Change m_children to be a vector of XSLImportRules. Also remove length(),
item() and append() since they were only used internally to modify m_children.

  • xml/XSLStyleSheetQt.cpp:

(WebCore::XSLStyleSheet::~XSLStyleSheet):

  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::~XSLStyleSheet):
(WebCore::XSLStyleSheet::isLoading):
(WebCore::XSLStyleSheet::clearDocuments):
(WebCore::XSLStyleSheet::loadChildSheet):
(WebCore::XSLStyleSheet::locateStylesheetSubResource):

Remove now-unnecessary isImportRule() checks and tidy up the code a bit.

7:22 AM Changeset in webkit [97750] by mihnea@adobe.com
  • 2 edits in trunk/LayoutTests

Unreviewed Qt rebaseline after r97738.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
7:16 AM Changeset in webkit [97749] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Remove const modifier from ctx_menu functions.
​https://bugs.webkit.org/show_bug.cgi?id=70090

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com> on 2011-10-18
Reviewed by Andreas Kling.

Functions ewk_context_menu_show and ewk_context_menu_custom_get
have got const modifer to ensure that Ewk_Context_Menu won't be
changed. The methods emit events through
evas_object_smart_callback_call with Ewk_Context_Menu as parameter
which is converted to void *. In this case an application which
receives those events may change Ewk_Context_Menu.

Additionaly the name of ewk_context_menu_custom_get has been changed
to ewk_context_menu_customize because an application is able to
modify the items of context menu.

  • ewk/ewk_contextmenu.cpp:

(ewk_context_menu_customize):
(ewk_context_menu_show):

  • ewk/ewk_private.h:
7:12 AM Changeset in webkit [97748] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix linkHoveredDoesntEmitRepeated test in the bot
​https://bugs.webkit.org/show_bug.cgi?id=70329

Reviewed by Andreas Kling.

Use LoadSpy::wait() instead of the TestCase::tryCompare(). They should be equivalent,
but I'm getting strange results with tryCompare(). This commit also adds an extra check
to make sure the hovered link is the correct one.

  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml:
6:51 AM Changeset in webkit [97747] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Some QML tests were accidentally committed.
​https://bugs.webkit.org/show_bug.cgi?id=70321

Reviewed by Andreas Kling.

These tests were committed by accident. They should not be there.

  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml:
6:03 AM Changeset in webkit [97746] by Philippe Normand
  • 16 edits
    2 adds
    2 deletes in trunk

[Gtk] Support for client-based geolocation
​https://bugs.webkit.org/show_bug.cgi?id=64970

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2011-10-18
Reviewed by Martin Robinson.

.:

Remove flag for enabling client-based geolocation since
it is used by default on Gtk port and hence not configurable.

  • configure.ac:

Source/WebCore:

Add feature defines for client-based geolocation when geolocation is enabled,
since this is the providing method that is now used by default. Remove
service-based providing method completely as it is not needed anymore.

  • GNUmakefile.am: Add feature defines for client-based geolocation.
  • GNUmakefile.list.am: Remove GeolocationServiceGtk.* files from compilation.
  • platform/gtk/GeolocationServiceGtk.cpp: Removed.
  • platform/gtk/GeolocationServiceGtk.h: Removed.

Source/WebKit/gtk:

Add DumpRenderTree support functions for client-based geolocation tests
and implement GeolocationClientGtk. The implementation is based on Zecke's
implementation of GeolocationService class in WebCore, which is now redundant
and subsequently removed.

  • GNUmakefile.am: Add GeolocationClientGtk.* files to compilation.
  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Add support functions to operate

with GeolocationClientMock.
(DumpRenderTreeSupportGtk::resetGeolocationClientMock):
(DumpRenderTreeSupportGtk::setMockGeolocationPermission):
(DumpRenderTreeSupportGtk::setMockGeolocationPosition):
(DumpRenderTreeSupportGtk::setMockGeolocationError):
(DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
  • WebCoreSupport/GeolocationClientGtk.cpp: Added.

(WebKit::getPositionCallback):
(WebKit::positionChangedCallback):
(WebKit::GeolocationClient::GeolocationClient):
(WebKit::GeolocationClient::geolocationDestroyed):
(WebKit::GeolocationClient::startUpdating):
(WebKit::GeolocationClient::stopUpdating):
(WebKit::GeolocationClient::setEnableHighAccuracy):
(WebKit::GeolocationClient::lastPosition):
(WebKit::GeolocationClient::requestPermission):
(WebKit::GeolocationClient::cancelPermissionRequest):
(WebKit::GeolocationClient::positionChanged):
(WebKit::GeolocationClient::updatePosition):
(WebKit::GeolocationClient::errorOccured):

  • WebCoreSupport/GeolocationClientGtk.h: Added.
  • webkit/webkitwebview.cpp:

(webkit_web_view_init): Use GeolocationClientMock as geolocation client
when running in DumpRenderTree.

Tools:

Add support for testing client-based geolocation tests in DumpRenderTree.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues): Reset GeolocationClientMock.
(createWebView): Create web view after declaring DumpRenderTree mode.
That way a mock client for geolocation is used instead of a GeoClue
client if a web view is created when testing.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Implement functions for

geolocation layout tests.
(LayoutTestController::setMockGeolocationPosition):
(LayoutTestController::setMockGeolocationError):
(LayoutTestController::setGeolocationPermission):
(LayoutTestController::numberOfPendingGeolocationPermissionRequests):

  • Scripts/build-webkit: Note that the Gtk port is using client-based

geolocation, even though changing this flag has no effect on compilation.

LayoutTests:

Unskip geolocation tests that now pass.

  • platform/gtk/Skipped:
5:58 AM Changeset in webkit [97745] by Antti Koivisto
  • 4 edits
    2 adds in trunk

REGRESSION(r97248): :visited as descendant selector broken
​https://bugs.webkit.org/show_bug.cgi?id=70122

Source/WebCore:

Reviewed by Nikolas Zimmerman.

Make ":visited foo" and similar selectors work correctly again. They can affect
the visited style of an element inside a visited link.

Test: fast/selectors/visited-descendant.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclarations):

Apply visited style to children of visited links too.


  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector):

Don't disable visited matching until we run into first ancestor link or use combinator other than child/descendant.

(WebCore::SelectorChecker::determineLinkMatchType):

Look into child/descendant component selectors too to determine the link match type.

LayoutTests:

Reviewed by Nikolas Zimmerman.

  • fast/selectors/visited-descendant.html: Added.
  • platform/mac/fast/selectors/visited-descendant-expected.txt: Added.
5:52 AM Changeset in webkit [97744] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Send mouse move events when we handle HoverEnter/Leave in QDesktopWebView
​https://bugs.webkit.org/show_bug.cgi?id=70297

Reviewed by Simon Hausmann.

Qt treat the first and last hover movements as special HoverMove and HoverLeave events, but
WebKit doesn't make the difference, so we need to create move events for them.

While HoverEnter is in practice equivalent to HoverMove, the HoverLeave event is a bit
different because we want to emulate that the mouse is not only leaving the current node, but
completely leaving the whole document. The way to do this is to manufacture a move event with
a very far position, and was inspired by WebView::handleMouseEvent() in
Source/WebKit/win/WebView.cpp.

This patch fixes DesktopWebViewLinkHovered QML tests.

  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::handleEvent):
(QDesktopWebPageProxy::handleHoverLeaveEvent):

  • UIProcess/qt/qdesktopwebpageproxy.h:
5:51 AM Changeset in webkit [97743] by caseq@chromium.org
  • 4 edits in trunk/Tools

2011-10-07 Andrey Kosyakov <​caseq@chromium.org>

[Chromium] suppress console output from DevTools window
​https://bugs.webkit.org/show_bug.cgi?id=69632

Reviewed by Pavel Feldman.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::showDevTools):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didAddMessageToConsole): (WebViewHost::reset): (WebViewHost::setLogConsoleOutput):
  • DumpRenderTree/chromium/WebViewHost.h:
5:46 AM Changeset in webkit [97742] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

Move CSSRule specific virtuals from StyleBase down into CSSRule.
​https://bugs.webkit.org/show_bug.cgi?id=70240

Reviewed by Darin Adler.

Move all the isFooRule() virtuals except isImportRule() to CSSRule
since they only make sense for its subclasses. isRule() remains in
StyleBase since we still need it for the parent chain traversal.
isImportRule() remains because XSLImportRule implements it.

Also moved insertedIntoParent() and removed its usage in
XSLStyleSheet since it is only reimplemented by CSSImportRule.

  • css/CSSRule.h:

(WebCore::CSSRule::isCharsetRule):
(WebCore::CSSRule::isFontFaceRule):
(WebCore::CSSRule::isKeyframeRule):
(WebCore::CSSRule::isKeyframesRule):
(WebCore::CSSRule::isMediaRule):
(WebCore::CSSRule::isPageRule):
(WebCore::CSSRule::isStyleRule):
(WebCore::CSSRule::isRegionStyleRule):
(WebCore::CSSRule::insertedIntoParent):

  • css/StyleBase.h:

(WebCore::StyleBase::isImportRule):
(WebCore::StyleBase::isCSSStyleSheet):

  • xml/XSLStyleSheet.h:

(WebCore::XSLStyleSheet::append):

5:39 AM Changeset in webkit [97741] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Option.value should trim extra internal html spaces
​https://bugs.webkit.org/show_bug.cgi?id=69455

Patch by Sachin Puranik <​jcqt43@motorola.com> on 2011-10-18
Reviewed by Kent Tamura.

Currently option.value does not trim the internal white space as suggested by spec. This patch implements the same.

Source/WebCore:

Test: fast/forms/option-value-trim-html-spaces.html

  • dom/OptionElement.cpp: Removed a function as this implementation is moved to the HTMLOptionElement.cpp file.
  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::value): Implementation of .value function which will now trim the html white spaces.

LayoutTests:

  • fast/forms/option-value-trim-html-spaces-expected.txt: Test case to test the text triming on the value attribute.
  • fast/forms/option-value-trim-html-spaces.html: Test case to test the text triming on the value attribute.
5:29 AM Changeset in webkit [97740] by alexis.menard@openbossa.org
  • 11 edits
    1 move
    5 adds
    2 deletes in trunk/Source/WebKit2

[Qt][WK2] WebPreferences are impossible to use in QML.
​https://bugs.webkit.org/show_bug.cgi?id=70141

Reviewed by Kenneth Rohde Christiansen.

Make it possible to use qwkpreferences in QML. Renamed it
to follow our new style regarding class names. This class is
now a QObject that is exposed as a property of the view.
The tests give an idea of the usage.

  • UIProcess/API/qt/WKView.h:
  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebView::preferences):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qmlplugin/plugin.cpp:

(WebKit2QmlPlugin::registerTypes):

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::preferences):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qwebpreferences.cpp: Added.

(QWebPreferencesPrivate::createPreferences):
(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferencesPrivate::setFontFamily):
(QWebPreferencesPrivate::fontFamily):
(QWebPreferencesPrivate::setFontSize):
(QWebPreferencesPrivate::fontSize):
(QWebPreferences::QWebPreferences):
(QWebPreferences::~QWebPreferences):
(QWebPreferences::autoLoadImages):
(QWebPreferences::setAutoLoadImages):
(QWebPreferences::javascriptEnabled):
(QWebPreferences::setJavascriptEnabled):
(QWebPreferences::pluginsEnabled):
(QWebPreferences::setPluginsEnabled):
(QWebPreferences::offlineWebApplicationCacheEnabled):
(QWebPreferences::setOfflineWebApplicationCacheEnabled):
(QWebPreferences::localStorageEnabled):
(QWebPreferences::setLocalStorageEnabled):
(QWebPreferences::XSSAuditingEnabled):
(QWebPreferences::setXSSAuditingEnabled):
(QWebPreferences::privateBrowsingEnabled):
(QWebPreferences::setPrivateBrowsingEnabled):
(QWebPreferences::dnsPrefetchEnabled):
(QWebPreferences::setDnsPrefetchEnabled):
(QWebPreferences::standardFontFamily):
(QWebPreferences::setStandardFontFamily):
(QWebPreferences::fixedFontFamily):
(QWebPreferences::setFixedFontFamily):
(QWebPreferences::serifFontFamily):
(QWebPreferences::setSerifFontFamily):
(QWebPreferences::sansSerifFontFamily):
(QWebPreferences::setSansSerifFontFamily):
(QWebPreferences::cursiveFontFamily):
(QWebPreferences::setCursiveFontFamily):
(QWebPreferences::fantasyFontFamily):
(QWebPreferences::setFantasyFontFamily):
(QWebPreferences::minimumFontSize):
(QWebPreferences::setMinimumFontSize):
(QWebPreferences::defaultFontSize):
(QWebPreferences::setDefaultFontSize):
(QWebPreferences::defaultFixedFontSize):
(QWebPreferences::setDefaultFixedFontSize):

  • UIProcess/API/qt/qwebpreferences.h: Added.
  • UIProcess/API/qt/qwebpreferences_p.h: Added.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/javascript.html: Added.
  • UIProcess/API/qt/tests/qmltests/common/localStorage.html: Added.
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::preferences):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/qwkpreferences.cpp: Removed.
  • UIProcess/qt/qwkpreferences.h: Removed.
  • UIProcess/qt/qwkpreferences_p.h: Removed.
  • WebKit2.pro:
  • WebKit2API.pri:
4:52 AM Changeset in webkit [97739] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Fix compilation error by include WebErrors.h file.
​https://bugs.webkit.org/show_bug.cgi?id=70309

Unreviewed build fix

Added a header file to fix compilation error.

Patch by Tomasz Morawski <​t.morawski@samsung.com> on 2011-10-18

  • WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:
4:50 AM Changeset in webkit [97738] by mihnea@adobe.com
  • 29 edits
    4 adds in trunk

[CSS Regions]Parse @-webkit-region rule
​https://bugs.webkit.org/show_bug.cgi?id=70021

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/parsing-region-style-rule.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMCSS.mm:

(kitClass):

  • bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::toV8):

  • css/CSSGrammar.y:
  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::cssText):

  • css/CSSParser.cpp:

(WebCore::CSSParser::setReusableRegionSelectorVector):
(WebCore::CSSParser::createRegionStylingRule):

  • css/CSSParser.h:

(WebCore::CSSParser::reusableRegionSelectorVector):

  • css/CSSRegionStyleRule.cpp: Added.

(WebCore::CSSRegionStyleRule::CSSRegionStyleRule):
(WebCore::CSSRegionStyleRule::~CSSRegionStyleRule):
(WebCore::CSSRegionStyleRule::cssText):

  • css/CSSRegionStyleRule.h: Added.
  • css/CSSRule.h:
  • css/CSSRule.idl:
  • css/CSSRuleList.cpp:

(WebCore::CSSRuleList::item):
(WebCore::CSSRuleList::rulesText):

  • css/CSSRuleList.h:
  • css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::selectorsText):

  • css/CSSSelectorList.h:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::addRegionStyleRule):
(WebCore::RuleSet::addRulesFromSheet):

  • css/CSSStyleSelector.h:
  • css/StyleBase.h:

(WebCore::StyleBase::isRegionStyleRule):

  • css/tokenizer.flex:

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt:
  • fast/regions/parsing-region-style-rule-expected.txt: Added.
  • fast/regions/parsing-region-style-rule.html: Added.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt:
4:41 AM Changeset in webkit [97737] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r97735.
​http://trac.webkit.org/changeset/97735
​https://bugs.webkit.org/show_bug.cgi?id=70317

some people apparently use build-jsc with the qt port without
building webkit first (Requested by torarne on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-18

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(buildQMakeProject):
(buildQMakeQtProject):

3:56 AM Changeset in webkit [97736] by Philippe Normand
  • 35 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r97602 and r97596.

  • platform/gtk/css2.1/t0511-c21-pseud-link-02-e-expected.txt:
  • platform/gtk/css2.1/t0511-c21-pseud-link-03-e-expected.txt:
  • platform/gtk/css3/selectors3/html/css3-modsel-17-expected.txt:
  • platform/gtk/css3/selectors3/html/css3-modsel-61-expected.txt:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-17-expected.txt:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-61-expected.txt:
  • platform/gtk/css3/selectors3/xml/css3-modsel-17-expected.txt:
  • platform/gtk/css3/selectors3/xml/css3-modsel-61-expected.txt:
  • platform/gtk/fast/backgrounds/background-leakage-transforms-expected.txt:
  • platform/gtk/fast/block/float/float-in-float-hit-testing-expected.txt:
  • platform/gtk/fast/block/margin-collapse/056-expected.txt:
  • platform/gtk/fast/dom/34176-expected.txt:
  • platform/gtk/fast/events/reveal-link-when-focused-expected.txt:
  • platform/gtk/fast/history/visited-link-background-color-expected.txt:
  • platform/gtk/fast/overflow/overflow_hidden-expected.txt:
  • platform/gtk/fast/selectors/017-expected.txt:
  • platform/gtk/fast/selectors/061-expected.txt:
  • platform/gtk/fast/table/028-vertical-expected.txt:
  • platform/gtk/fast/table/height-percent-test-vertical-expected.txt:
  • platform/gtk/fast/writing-mode/fallback-orientation-expected.txt:
  • platform/gtk/svg/hixie/cascade/002-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug26553-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug46623-1-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug51140-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug8950-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
3:36 AM Changeset in webkit [97735] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Remove dead code in build-webkit

build-webkit will iterate over a list of subdirectories to build,
but this feature is only used by the Apple ports. For QtWebKit we
always pass an empty directory to buildQMakeProject, which makes
the logic for dealing with sub-projects in buildQMakeProject just
added noise.

If we do want this feature at some point, we should redo it in
the context of the upcoming build system changes for Qt.

Reviewed by Simon Hausmann.

3:14 AM BuildingQt5OnHarmattan edited by jocelyn.turcotte@nokia.com
Updated the patch set to include the latest fixes. (diff)
3:05 AM BuildingQt5OnHarmattan edited by jocelyn.turcotte@nokia.com
Updated the patch set to include the latest fixes. (diff)
3:04 AM Changeset in webkit [97734] by vestbo@webkit.org
  • 3 edits in trunk/Tools

Remove traces of Symbian support from the build scripts

Reviewed by Simon Hausmann.

3:03 AM Changeset in webkit [97733] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Source/WebKit2

[Qt][WK2] Implement geolocation provider for qt port
​https://bugs.webkit.org/show_bug.cgi?id=59199

Patch by Adenilson Cavalcanti <​adenilson.silva@openbossa.org> on 2011-10-18
Reviewed by Simon Hausmann.

Based on patch by Kenneth Christiansen <​kenneth.r.christiansen@nokia.com>

Implements default location provider for WK2 QtWebKit (WebGeolocationProviderQt),
allowing QtWebKit clients to implement or override their own provider using WK2 APIs.

  • UIProcess/API/C/WKGeolocationManager.h:
  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

  • UIProcess/qt/WebGeolocationProviderQt.cpp: Added.

(toLocationProvider):
(locationStartUpdating):
(locationStopUpdating):
(WebGeolocationProviderQt::create):
(WebGeolocationProviderQt::provider):
(WebGeolocationProviderQt::WebGeolocationProviderQt):
(WebGeolocationProviderQt::~WebGeolocationProviderQt):
(WebGeolocationProviderQt::updateTimeout):
(WebGeolocationProviderQt::positionUpdated):
(WebGeolocationProviderQt::startUpdating):
(WebGeolocationProviderQt::stopUpdating):

  • UIProcess/qt/WebGeolocationProviderQt.h: Added.
  • WebKit2.pro:
2:28 AM Changeset in webkit [97732] by podivilov@chromium.org
  • 5 edits in trunk

Web Inspector: support displaying multiple sources per single script in ScriptsPanel.
​https://bugs.webkit.org/show_bug.cgi?id=69847

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._removeSourceFrame):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):

LayoutTests:

  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
2:18 AM Changeset in webkit [97731] by kbalazs@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

ParallelJobs: maximum number of threads should be determined dynamically
​https://bugs.webkit.org/show_bug.cgi?id=68540

Reviewed by Zoltan Herczeg.

Add logic to determine the number of cores and use this as
the maximum number of threads. The implementation currently
covers Linux, Darwin, Windows, AIX, Solaris, OpenBSD and NetBSD.
The patch was tested on Linux, Mac and Windows which was enough to
cover all code path. It should work on the rest accoring to the
documentation of those OS's. The hard coded constant is still used
on uncovered OS's which should be fixed in the future.

  • wtf/ParallelJobs.h: Removed the default value of the requestedJobNumber

argument because clients should always fill it and the 0 default value
was incorrect anyway.
(WTF::ParallelJobs::ParallelJobs):

  • wtf/ParallelJobsGeneric.cpp:

(WTF::ParallelEnvironment::determineMaxNumberOfParallelThreads):

  • wtf/ParallelJobsGeneric.h:

(WTF::ParallelEnvironment::ParallelEnvironment):

2:11 AM Changeset in webkit [97730] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix after r97672.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2:09 AM Changeset in webkit [97729] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2011-10-18 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix lion build breakage s/class Length/struct Length/.

  • loader/cache/CachedImage.h:
  • platform/graphics/Image.h:
1:48 AM Changeset in webkit [97728] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[UNIX] Use SOCK_SEQPACKET when available
​https://bugs.webkit.org/show_bug.cgi?id=61287

Reviewed by Darin Adler.

Sockets of type SEQPACKET are actually DGRAM sockets but that
notifies the other end when the connection is closed. When
SEQPACKET sockets are not available GTK+ port uses STREAM sockets
while Qt port uses DGRAM sockets.

  • PluginProcess/PluginProcess.cpp: Use SOCK_SEQPACKET if possible.
  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess): Ditto.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess): Ditto.

1:39 AM Changeset in webkit [97727] by Nikolas Zimmermann
  • 17 edits in trunk/Source/WebCore

2011-10-18 Nikolas Zimmermann <​nzimmermann@rim.com>

Prepare SVGImage intrinsic size negotiation: Add intrinsic size & ratio calculation functionality to Image
​https://bugs.webkit.org/show_bug.cgi?id=70314

Reviewed by Antti Koivisto.

Add a "void computeIntrinsicDimension(Length& intrinsicWidth, Lengt& intrinsicHeight, FloatSize& intrinsicRatio)" helper method
to Image/GeneratedImage/SVGImage and make it accessible through StyleImage.

For a regular Image the intrinsicWidth/Height contains just a Length(size().width(), Fixed). In contrary SVGImages pass on the
style()->width()/height() values from the render style of the RenderSVGRoot renderer. These information are needed to implement
the size negotiation between embedded SVG images and the embedder.

No new tests, as this new functionality is not yet used.

  • loader/cache/CachedImage.cpp: (WebCore::CachedImage::computeIntrinsicDimensions):
  • loader/cache/CachedImage.h:
  • platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::computeIntrinsicDimensions):
  • platform/graphics/GeneratedImage.h:
  • platform/graphics/Image.cpp: (WebCore::Image::computeIntrinsicDimensions):
  • platform/graphics/Image.h:
  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::computeIntrinsicDimensions):
  • platform/graphics/cg/PDFDocumentImage.h:
  • rendering/style/StyleCachedImage.cpp: (WebCore::StyleCachedImage::computeIntrinsicDimensions):
  • rendering/style/StyleCachedImage.h:
  • rendering/style/StyleGeneratedImage.cpp: (WebCore::StyleGeneratedImage::computeIntrinsicDimensions):
  • rendering/style/StyleGeneratedImage.h:
  • rendering/style/StyleImage.h:
  • rendering/style/StylePendingImage.h: (WebCore::StylePendingImage::computeIntrinsicDimensions):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::computeIntrinsicDimensions):
  • svg/graphics/SVGImage.h:
1:04 AM Changeset in webkit [97726] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] Different dimensions are reported for elements onscreen and in the Metrics pane
​https://bugs.webkit.org/show_bug.cgi?id=70242

Reviewed by Pavel Feldman.

  • inspector/DOMNodeHighlighter.cpp:
12:20 AM Changeset in webkit [97725] by haraken@chromium.org
  • 9 edits in trunk

Unreviewed, rolling out r97697.
​http://trac.webkit.org/changeset/97697
​https://bugs.webkit.org/show_bug.cgi?id=68978

some tests are broken

Source/WebCore:

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):
(WebCore::V8MessageEvent::portsAccessorGetter):
(WebCore::V8MessageEvent::initMessageEventCallback):

  • dom/MessageEvent.cpp:

(WebCore::MessageEventInit::MessageEventInit):
(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::isMessageEvent):

  • dom/MessageEvent.h:

(WebCore::MessageEvent::create):
(WebCore::MessageEvent::dataAsSerializedScriptValue):
(WebCore::MessageEvent::dataAsString):
(WebCore::MessageEvent::dataAsBlob):
(WebCore::MessageEvent::dataAsArrayBuffer):

  • dom/MessageEvent.idl:

LayoutTests:

  • fast/events/constructors/message-event-constructor-expected.txt:
  • fast/events/constructors/message-event-constructor.html:

Oct 17, 2011:

11:39 PM Changeset in webkit [97724] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

r97638 caused 3 printing crashes
​https://bugs.webkit.org/show_bug.cgi?id=70284

Reviewed by Kent Tamura.

Null check element.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclarations):

11:30 PM Changeset in webkit [97723] by tkent@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r97677.
​http://trac.webkit.org/changeset/97677
​https://bugs.webkit.org/show_bug.cgi?id=70308

A dependent revision was rolled out. (Requested by tkent on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-17

  • public/WebAccessibilityRole.h:
  • src/AssertMatchingEnums.cpp:
11:23 PM Changeset in webkit [97722] by tkent@chromium.org
  • 2 edits in trunk/Tools

A follow-up of r97716.
​https://bugs.webkit.org/show_bug.cgi?id=68803

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::reset): Initialize m_dumpCreateView.

10:50 PM Changeset in webkit [97721] by commit-queue@webkit.org
  • 17 edits
    4 deletes in trunk

Unreviewed, rolling out r97669.
​http://trac.webkit.org/changeset/97669
​https://bugs.webkit.org/show_bug.cgi?id=70305

Broke accessibility tests on Windows (Requested by rniwa on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-17

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

  • accessibility/AccessibilityMockObject.h:
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::elementAccessibilityHitTest):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::boundingBoxRect):
(WebCore::AccessibilityRenderObject::clearChildren):
(WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilitySpinButton.cpp: Removed.
  • accessibility/AccessibilitySpinButton.h: Removed.
  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::repeatingTimerFired):

  • html/shadow/TextControlInnerElements.h:

LayoutTests:

  • platform/mac/accessibility/html5-input-number-expected.txt: Removed.
  • platform/mac/accessibility/html5-input-number.html: Removed.
10:39 PM Changeset in webkit [97720] by tkent@chromium.org
  • 14 edits
    2 deletes in trunk/Source/WebCore

Remove OptionGroupElement
​https://bugs.webkit.org/show_bug.cgi?id=70220

Reviewed by Darin Adler.

No new tests, just a refactoring.

  • CMakeLists.txt: Remove OptionGroupElement.cpp and/or OptionGroupElement.h.
  • GNUMakefile.am.list: ditto.
  • WebCore.gypi: ditto.
  • WebCore.pro: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • dom/DOMAllInOne.cpp: ditto.
  • dom/OptionElement.cpp:

(WebCore::OptionElement::collectOptionTextRespectingGroupLabel):
Use hasTagName(optgroupTag) and static_cast<> instead of toOptionGroupElement().

  • dom/OptionGroupElement.cpp: Removed.
  • dom/OptionGroupElement.h: Removed.
  • html/HTMLOptGroupElement.cpp:

(WebCore::isHTMLOptGroupElement): Added.

  • html/HTMLOptGroupElement.h:
    • Don't inherit OptionGroupElement.
    • Make groupLabelText() non-virtual.
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::recalcListItems):
Use Use hasTagName(optgroupTag) instead of isOptionGroupElement().

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
Use hasTagName(optgroupTag) and static_cast<> instead of toOptionGroupElement().
(WebCore::RenderListBox::paintItemForeground):
Use hasTagName(optgroupTag) instead of isOptionGroupElement().

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::itemText):
Use hasTagName(optgroupTag) and static_cast<> instead of toOptionGroupElement().
(WebCore::RenderMenuList::itemIsEnabled):
Use Use hasTagName(optgroupTag) instead of isOptionGroupElement().
(WebCore::RenderMenuList::itemIsLabel): ditto.

10:32 PM Changeset in webkit [97719] by barraclough@apple.com
  • 6 edits in trunk

Reverted r997709, this caused test failures.

Source/JavaScriptCore:

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSObject.cpp:

(JSC::JSObject::hasProperty):
(JSC::JSObject::hasOwnProperty):

LayoutTests:

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:
10:04 PM Changeset in webkit [97718] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[TexMap][QT] TexMapGL renders a strange one-pixel border of BitmapTexture.
​https://bugs.webkit.org/show_bug.cgi?id=70293

TextureMapperGL renders the strange border in
​http://www.webkit.org/blog-files/leaves/index.html
Bug occurs because BitmapTexture is larger than the content due to rounding to
NPOT, and its pixel data is never initialized.

Patch by Huang Dongsung <​luxtella@company100.net> on 2011-10-17
Reviewed by Noam Rosenthal.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::texImage2DResourceSafe):
(WebCore::BitmapTextureGL::reset):

9:57 PM Changeset in webkit [97717] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update

  • platform/chromium/test_expectations.txt:

Correct a dupe.

9:47 PM Changeset in webkit [97716] by jochen@chromium.org
  • 14 edits
    4 adds in trunk

Source/WebCore: Make NavigationAction wrap a ResourceRequest instead of a KURL.
​https://bugs.webkit.org/show_bug.cgi?id=68803

With this, FrameLoaderClient::dispatchCreatePage knows about the
request that will be used for the initial navigaion of the to be
created page.

Reviewed by Nate Chapin.

Test: platform/chromium/fast/loader/create-view-target-blank.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::loadDifferentDocumentItem):
(WebCore::createWindow):

  • loader/NavigationAction.cpp:

(WebCore::NavigationAction::NavigationAction):

  • loader/NavigationAction.h:

(WebCore::NavigationAction::isEmpty):
(WebCore::NavigationAction::url):
(WebCore::NavigationAction::resourceRequest):

  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):

  • page/ContextMenuController.cpp:

(WebCore::openNewWindow):

  • WebCore.exp: updated

Source/WebKit/chromium: Make NavigationAction wrap a ResourceRequest instead of a KURL.
​https://bugs.webkit.org/show_bug.cgi?id=68803

Use the request in the NavigationAction, if the FrameLoadRequest
doesn't already contain a request.

Reviewed by Nate Chapin.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::createWindow):

Tools: [chromium] add LayoutTestController.dumpCreateView() to monitor calls to WebViewClient::createView
​https://bugs.webkit.org/show_bug.cgi?id=68803

Reviewed by Nate Chapin.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::dumpCreateView):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController::shouldDumpCreateView):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createView):

LayoutTests: Verify that the URL to be opened in the new window is passed by dispatchCreateWindow down to createView.
​https://bugs.webkit.org/show_bug.cgi?id=68803

Reviewed by Nate Chapin.

  • platform/chromium/fast/loader/create-view-target-blank-expected.txt: Added.
  • platform/chromium/fast/loader/create-view-target-blank.html: Added.
  • platform/chromium/fast/loader/resources/done.html: Added.
9:37 PM Changeset in webkit [97715] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

XSSAuditor bypass with remote script ending in ? character
​https://bugs.webkit.org/show_bug.cgi?id=70255

Patch by Tom Sepez <​tsepez@chromium.org> on 2011-10-17
Reviewed by Daniel Bates.

Fix XSSAuditor bypass where unterminated src="" attribute could pick up
text from page causing failed XSS detection. Constrain match to domain
portions of src attribute only.

Source/WebCore:

Test: http/tests/security/xssAuditor/script-tag-with-source-unterminated.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::filterObjectToken):
(WebCore::XSSAuditor::filterParamToken):
(WebCore::XSSAuditor::filterEmbedToken):
(WebCore::XSSAuditor::filterAppletToken):
(WebCore::XSSAuditor::filterIframeToken):
(WebCore::XSSAuditor::eraseAttributeIfInjected):
(WebCore::XSSAuditor::decodedSnippetForAttribute):

  • html/parser/XSSAuditor.h:

LayoutTests:

  • http/tests/security/xssAuditor/script-tag-with-source-unterminated-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-unterminated.html: Added.
9:31 PM Changeset in webkit [97714] by adamk@chromium.org
  • 13 edits
    1 delete in trunk/Source/WebCore

Parse MutationObserverOptions directly into a bitfield
​https://bugs.webkit.org/show_bug.cgi?id=70287

Reviewed by Ryosuke Niwa.

Replaces the MutationObserverOptions class with a typedef,
used to pass a bitfield composed of enums defined in
WebKitMutationObserver.h.

No new tests because no behavior should change.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDictionary.h: Removed now-unused method.
  • bindings/js/JSWebKitMutationObserverCustom.cpp:

(WebCore::JSWebKitMutationObserver::observe):

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::observeCallback):

  • dom/MutationObserverOptions.h: Removed.
  • dom/Node.cpp:

(WebCore::Node::registerMutationObserver):

  • dom/Node.h:
  • dom/NodeRareData.h:

(WebCore::MutationObserverEntry::MutationObserverEntry):
(WebCore::MutationObserverEntry::matches):

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::observe):

  • dom/WebKitMutationObserver.h:
9:29 PM Changeset in webkit [97713] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update

  • platform/chromium/test_expectations.txt:

fallback-orientation.html is failing on Linux too.

9:08 PM Changeset in webkit [97712] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Add compile-time asserts for RenderStyle::(Non)InheritedFlags size.
​https://bugs.webkit.org/show_bug.cgi?id=69803

Reviewed by Darin Adler.

No new tests.

Adds COMPILE_ASSERTs for the size of RenderStyle::InheritedFlags and
RenderStyle::NonInheritedFlags to ensure that they are not accidentally
grown in future changes.
Change types of unsigned bitfields to unsigned char to ensure that the
above assertions remain true when building on windows.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle):
Adds assertions to ensure struct sizes do not change.

  • rendering/style/RenderStyle.h:

Changes unsigned to unsigned char as outlined above.

9:08 PM Changeset in webkit [97711] by ojan@chromium.org
  • 5 edits in trunk/LayoutTests

Test cleanups after ​http://trac.webkit.org/changeset/97707.

  • platform/chromium/test_expectations.txt:
  • platform/qt/fast/backgrounds/background-leakage-transforms-expected.txt:
  • platform/qt/fast/table/028-vertical-expected.txt:
  • platform/qt/fast/table/height-percent-test-vertical-expected.txt:
8:41 PM Changeset in webkit [97710] by Nate Chapin
  • 2 edits in trunk/Tools

Add myself to watchlists, and add a watch
for Source/WebCore/loader/.
​https://bugs.webkit.org/show_bug.cgi?id=70263

Reviewed by David Levin.

  • Scripts/webkitpy/common/config/watchlist:
8:26 PM Changeset in webkit [97709] by barraclough@apple.com
  • 6 edits in trunk

Source/JavaScriptCore: Rename deregister* to unregister*
​https://bugs.webkit.org/show_bug.cgi?id=70272

Patch by Ryosuke Niwa <​rniwa@webkit.org> on 2011-10-17
Reviewed by Darin Adler.

Renamed deregisterWeakMap to unregisterWeakMap.

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::unregisterWeakMap):

LayoutTests: Poisoning of strict caller/arguments inappropriately poisoning "in"
​https://bugs.webkit.org/show_bug.cgi?id=63398

Reviewed by Sam Weinig.

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:
    • added tests.
8:23 PM Changeset in webkit [97708] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix a new[]/delete mismatch in InnerGestureRecognizerTest that makes valgrind sad
​https://bugs.webkit.org/show_bug.cgi?id=70273

Patch by James Robinson <​jamesr@chromium.org> on 2011-10-17
Reviewed by Mihai Parparita.

  • tests/InnerGestureRecognizerTest.cpp:

(TouchSequence::~TouchSequence):

8:13 PM Changeset in webkit [97707] by ojan@chromium.org
  • 9 edits in trunk

Unreviewed, rolling out r97662.
​http://trac.webkit.org/changeset/97662
​https://bugs.webkit.org/show_bug.cgi?id=68497

Was not the cause of the test failures.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):

LayoutTests:

  • platform/mac/fast/backgrounds/background-leakage-transforms-expected.txt:
  • platform/mac/fast/table/028-vertical-expected.png:
  • platform/mac/fast/table/028-vertical-expected.txt:
  • platform/mac/fast/table/height-percent-test-vertical-expected.png:
  • platform/mac/fast/table/height-percent-test-vertical-expected.txt:
  • platform/mac/fast/writing-mode/fallback-orientation-expected.txt:
8:12 PM Changeset in webkit [97706] by rniwa@webkit.org
  • 6 edits in trunk/Source

Rename deregister* to unregister*
​https://bugs.webkit.org/show_bug.cgi?id=70272

Reviewed by Darin Adler.

Source/JavaScriptCore:

Renamed deregisterWeakMap to unregisterWeakMap.

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::unregisterWeakMap):

Source/WebCore:

Renamed deregisterHandler to unregisterHandler.

  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.ExtensionServerClient.prototype.unregisterHandler):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onSetOpenResourceHandler):

  • inspector/front-end/HandlerRegistry.js:

(get WebInspector.HandlerRegistry.prototype.unregisterHandler):

8:09 PM Changeset in webkit [97705] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] add test failures after ​http://trac.webkit.org/changeset/97693.
See ​https://bugs.webkit.org/show_bug.cgi?id=70300 for more details.

  • platform/chromium/test_expectations.txt:
7:59 PM Changeset in webkit [97704] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/efl

[EFL] Expose the kit() frame function to the rest of ewk.
​https://bugs.webkit.org/show_bug.cgi?id=70253

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-10-17
Reviewed by Antonio Gomes.

Now that we have the EWKPrivate namespace, it makes sense to make the
kit() function accessible there instead of having it as a static local
function in ewk_frame.

While on it, get rid of ewk_frame_core_get, which is obsolete after
EWKPrivate::coreFrame.

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::respondToChangedSelection):

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::callPolicyFunction):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientEfl::didTransferChildFrameToNewDocument):
(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
(WebCore::FrameLoaderClientEfl::dispatchCreatePage):
(WebCore::FrameLoaderClientEfl::createNetworkingContext):

  • ewk/ewk_frame.cpp:

(_ewk_frame_loader_efl_get):
(_ewk_frame_children_iterator_next):
(ewk_frame_child_find):
(ewk_frame_hit_test_new):
(EWKPrivate::kitFrame):

  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp:

(ewk_view_setting_encoding_custom_get):
(ewk_view_setting_encoding_custom_set):

7:25 PM Changeset in webkit [97703] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[TexMap][QT] The BGRA32PremultimpliedBuffer should not inherit the RefCounted class.
​https://bugs.webkit.org/show_bug.cgi?id=70098

The BitmapTexture has a BGRA32PremultimpliedBuffer object using OwnPtr, not RefPtr.
It causes following assertion fail, RefCountedBase::m_deletionHasBegun.
It is better that the BGRA32PremultimpliedBuffer does not inherit the RefCounted
because the BitmapTexture only has and uses a BGRA32PremultimpliedBuffer object.

Patch by Huang Dongsung <​luxtella@company100.net> on 2011-10-17
Reviewed by Noam Rosenthal.

  • platform/graphics/opengl/TextureMapperGL.h:
7:19 PM Changeset in webkit [97702] by vsevik@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Search in resource crashes when there is no resource with given url.
​https://bugs.webkit.org/show_bug.cgi?id=69767

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/search/search-in-non-existing-resource.html

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::searchInResource):

LayoutTests:

  • http/tests/inspector/search/search-in-non-existing-resource-expected.txt: Added.
  • http/tests/inspector/search/search-in-non-existing-resource.html: Added.
7:17 PM Changeset in webkit [97701] by mihnea@adobe.com
  • 88 edits in trunk

[CSS Regions]Change content:-webkit-from-flow to -webkit-flow-from
​https://bugs.webkit.org/show_bug.cgi?id=70104

Reviewed by David Hyatt.

  1. -webkit-flow-from is now a property instead of being an addition to content property.
  2. -webkit-flow-from takes an identifier instead of string.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseRegionThread):

  • css/CSSParser.h:
  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::cssText):

  • css/CSSPrimitiveValue.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/regions/bottom-overflow-out-of-first-region.html:
  • fast/regions/content-flowed-into-regions-no-scroll.html:
  • fast/regions/content-webkit-from-flow-parsing-expected.txt:
  • fast/regions/float-pushed-width-change.html:
  • fast/regions/floats-basic-in-variable-width-regions.html:
  • fast/regions/flow-anonymous-children.html:
  • fast/regions/flow-content-basic-vertical-rl.html:
  • fast/regions/flow-content-basic-vertical.html:
  • fast/regions/flow-content-basic.html:
  • fast/regions/flows-dependency-dynamic-remove.html:
  • fast/regions/flows-dependency-same-flow.html:
  • fast/regions/hit-test-float.html:
  • fast/regions/multiple-directionality-changes-in-variable-width-regions.html:
  • fast/regions/no-split-line-box.html:
  • fast/regions/outline-sides-in-region.html:
  • fast/regions/overflow-in-uniform-regions-dynamic.html:
  • fast/regions/overflow-in-uniform-regions.html:
  • fast/regions/overflow-in-variable-width-regions.html:
  • fast/regions/overflow-moving-below-floats-in-variable-width-regions.html:
  • fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html:
  • fast/regions/overflow-rtl-in-variable-width-regions.html:
  • fast/regions/overflow-size-change-in-variable-width-regions.html:
  • fast/regions/overflow-size-change-with-stacking-context-rtl.html:
  • fast/regions/overflow-size-change-with-stacking-context.html:
  • fast/regions/percentage-margins-mixed-ltr-dominant-regions.html:
  • fast/regions/percentage-margins-mixed-rtl-dominant-regions.html:
  • fast/regions/percentage-margins-rtl-variable-width-regions.html:
  • fast/regions/percentage-margins-variable-width-regions.html:
  • fast/regions/position-writing-modes-in-variable-width-regions.html:
  • fast/regions/positioned-objects-block-static-in-regions.html:
  • fast/regions/positioned-objects-block-static-in-rtl-regions.html:
  • fast/regions/positioned-objects-block-static-spanning-regions-rtl.html:
  • fast/regions/positioned-objects-block-static-spanning-regions.html:
  • fast/regions/positioned-objects-in-regions.html:
  • fast/regions/positioned-objects-in-rtl-regions.html:
  • fast/regions/positioned-objects-inline-static-in-regions.html:
  • fast/regions/positioned-objects-inline-static-in-rtl-regions.html:
  • fast/regions/positioned-objects-inline-static-spanning-regions-rtl.html:
  • fast/regions/positioned-objects-inline-static-spanning-regions.html:
  • fast/regions/positioned-objects-perpendicular-flows-in-regions.html:
  • fast/regions/positioned-objects-spanning-regions.html:
  • fast/regions/region-element-dynamic-attach-flow.html:
  • fast/regions/region-element-dynamic-detach-flow.html:
  • fast/regions/region-overflow-auto-overflow-hidden.html:
  • fast/regions/region-overflow-auto-overflow-visible.html:
  • fast/regions/region-overflow-break.html:
  • fast/regions/render-region-renderer.html:
  • fast/regions/resources/region-style.css:

(.regionArticle):

  • fast/regions/script-tests/content-webkit-from-flow-parsing.js:

(testCSSText):
(testComputedStyle):

  • fast/regions/script-tests/region-element-display-restriction.js:

(createRegionElement):

  • fast/regions/text-region-breaks.html:
  • fast/regions/text-region-split-after-resize.html:
  • fast/regions/text-region-split-horizontal-bt.html:
  • fast/regions/text-region-split-small-pagination.html:
  • fast/regions/text-region-split-vertical-rl.html:
  • fast/regions/text-region-split-vertical.html:
  • fast/regions/text-region-split.html:
  • fast/regions/top-overflow-out-of-second-region.html:
  • fast/regions/webkit-flow-double-pagination-float-push.html:
  • fast/regions/webkit-flow-float-pushed-to-last-region.html:
  • fast/regions/webkit-flow-float-unable-to-push.html:
  • fast/regions/webkit-flow-floats-inside-regions-bounds.html:
  • fast/regions/webkit-flow-inlines-dynamic.html:
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl.html:
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html:
  • fast/regions/webkit-flow-inlines-inside-regions-bounds.html:
  • fast/regions/webkit-flow-renderer-layer.html:
  • fast/regions/webkit-flow-renderer-nested.html:
  • fast/regions/webkit-flow-renderer.html:
  • fast/repaint/japanese-rl-selection-repaint-in-regions.html:
  • fast/repaint/line-flow-with-floats-in-regions.html:
  • fast/repaint/overflow-flipped-writing-mode-block-in-regions.html:
  • fast/repaint/region-painting-via-layout.html:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
7:11 PM Changeset in webkit [97700] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Assign a bug for flaky layout tests
​https://bugs.webkit.org/show_bug.cgi?id=70298

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
7:03 PM Changeset in webkit [97699] by dpranke@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

platform/chromium/compositing/plugins/webplugin* failing on cg snowleopard
​https://bugs.webkit.org/show_bug.cgi?id=70294

Unreviewed, expectations change.

  • platform/chromium-gpu-cg-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.png: Added.
  • platform/chromium-gpu-cg-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt: Added.
  • platform/chromium-gpu-cg-mac/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt: Added.
6:55 PM Changeset in webkit [97698] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-17

  • DEPS:
6:50 PM Changeset in webkit [97697] by haraken@chromium.org
  • 9 edits in trunk

MessageEvent.data can be stored as ScriptValue.
​https://bugs.webkit.org/show_bug.cgi?id=68978

Reviewed by Hajime Morita.

Source/WebCore:

Currently, the following test cases fail or crash:

  • shouldBe("new MessageEvent('eventType', { data: test_object }).data", "test_object") -> FAIL
  • new MessageEvent('eventType', { data: document }).data -> CRASH

This is because MessageEvent.data is implemented just as SerializedScriptValue
and it cannot keep ScriptValue passed by JavaScript. This patch makes the following changes:

  • If MessageEvent is constructed with ScriptValue, it is stored as ScriptValue internally.

When MessageEvent.data is called, the ScriptValue is returned.

  • If MessageEvent is constructed with SerializedScriptValue, it is stored as

SerializedScriptValue internally (since we cannot deserialize it into ScriptValue
at this point because of lack of ExecState). When MessageEvent.data is called,
the SerializedScriptValue is deserialized into the corresponding ScriptValue,
and the ScriptValue is returned.

This patch does not make a fix for ObjC bindings code, since we need to first fix
the bug 28774, as commented in dom/MessageEvent.h and dom/MessageEvent.cpp.

Test: fast/events/constructors/message-event-constructor.html

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data): Custom getter for MessageEvent.data. Supported ScriptValue.
(WebCore::JSMessageEvent::initMessageEvent): Changed SerializedScriptValue to ScriptValue.

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter): Custom getter for MessageEvent.data. Supported ScriptValue.
(WebCore::V8MessageEvent::portsAccessorGetter): Removed extra spaces.
(WebCore::V8MessageEvent::initMessageEventCallback): Changed SerializedScriptValue to ScriptValue.

  • dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent): Supported ScriptValue.
(WebCore::MessageEvent::initMessageEvent): Supported ScriptValue.
(WebCore::MessageEvent::isMessageEvent): Removed extra spaces.

  • dom/MessageEvent.h: Added DataType::DataTypeScriptValue.

(WebCore::MessageEvent::create): Supported ScriptValue.
(WebCore::MessageEvent::dataAsScriptValue): Getter for data. Insert ASSERT() to guarantee that this accessor is not called for unintended type of data.
(WebCore::MessageEvent::dataAsSerializedScriptValue): Ditto.
(WebCore::MessageEvent::dataAsString): Ditto.
(WebCore::MessageEvent::dataAsBlob): Ditto.
(WebCore::MessageEvent::dataAsArrayBuffer): Ditto.

  • dom/MessageEvent.idl: Changed SerializedScriptValue to DOMObject (i.e. ScriptValue). This patch does not touch an ObjC part.

LayoutTests:

Removed failures and crashes.

  • fast/events/constructors/message-event-constructor-expected.txt:
  • fast/events/constructors/message-event-constructor.html:
6:38 PM Changeset in webkit [97696] by commit-queue@webkit.org
  • 14 edits in trunk/Source/WebCore

Unified spell-checking and legacy spell checking should be easy to switch
​https://bugs.webkit.org/show_bug.cgi?id=69242

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-10-17
Reviewed by Hajime Morita.

WebCore has two different code paths for spell-checking:

1) checkTextOfParagraph() for Snow Leopard or later
2) checkSpellingOfString() for checkGrammarOfString() for other platforms.

This patch introduces a flag to change code paths dynamically.
This patch also includes build fix for QT, GTK, and Windows platforms.

No new tests because this patch does not change a behavior.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::hasMisspelling):

Changed static if-USE(UNIFIED_TEXT_CHECKING) statement to dynamic
condition branch to achieve easy code path change.

  • accessibility/mac/WebAccessibilityObjectWrapper.mm: ditto.

(AXAttributeStringSetSpelling):

  • editing/EditingAllInOne.cpp:
  • editing/Editor.cpp:

(WebCore::Editor::advanceToNextMisspelling): ditto.
(WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection): ditto.
(WebCore::Editor::markMisspellingsAfterTypingToWord): ditto.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): ditto.
(WebCore::Editor::changeBackToReplacedString): ditto.
(WebCore::Editor::markMisspellingsAndBadGrammar): ditto.
(WebCore::Editor::unifiedTextCheckerEnabled):

Utility method to check using unified text checking or not.

  • editing/Editor.h:
  • editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):

Same as WebCore::AccessibilityObject::hasMisspelling.

(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): ditto.
(WebCore::TextCheckingHelper::unifiedTextCheckerEnabled):

Utility method to check using unified text checking or not.

(WebCore::unifiedTextCheckerEnabled): ditto.

  • editing/TextCheckingHelper.h:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

Includes a flag to change the code path.

  • page/Settings.h:

(WebCore::Settings::setUnifiedTextCheckerEnabled):

Sets a flag to change the code path.

(WebCore::Settings::unifiedTextCheckerEnabled):

A flag to change the code path.

6:36 PM Changeset in webkit [97695] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after 97691.

  • html/HTMLTableCellElement.h:

(WebCore::toHTMLTableCellElement): Avoid declaring the same function twice.

6:34 PM Changeset in webkit [97694] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Add a missing semi-colon in ExternalPopupMenu.cpp
​https://bugs.webkit.org/show_bug.cgi?id=70232

Patch by Peter Beverloo <​peter@chromium.org> on 2011-10-17
Reviewed by Andreas Kling.

  • src/ExternalPopupMenu.cpp:

(WebKit::ExternalPopupMenu::didAcceptIndices):

6:33 PM Changeset in webkit [97693] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

Unreviewed, rolling out r97661.
​http://trac.webkit.org/changeset/97661

Confirmed this patch was not the cause of the test failures.

Source/WebCore:

display:inline-block elements don't correctly handle orthogonal writing-modes
​https://bugs.webkit.org/show_bug.cgi?id=69957

Reading min/maxPreferredLogicalWidth from a child uses the child's writing-mode.
Instead, we need to grab the result based on the parent's writing-mode.
In the case of orthogonal writing-modes, we need the child's logical height.

Tests: fast/writing-mode/borders-expected.html

fast/writing-mode/borders.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

LayoutTests:

display:inline-block elements don't correctly handle orthogonal writing-modes
​https://bugs.webkit.org/show_bug.cgi?id=69957

  • fast/writing-mode/borders-expected.html: Added.
  • fast/writing-mode/borders.html: Added.
6:24 PM Changeset in webkit [97692] by jamesr@google.com
  • 9 edits
    1 delete in trunk/Source

Unreviewed, rolling out r97690.
​http://trac.webkit.org/changeset/97690
​https://bugs.webkit.org/show_bug.cgi?id=70161

Hits assertion in CCLayerTreeHostTests

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCMainThread.h:
  • platform/graphics/chromium/cc/CCMainThreadTask.h:

(WebCore::createMainThreadTask):

  • platform/graphics/chromium/cc/CCScopedMainThreadProxy.h: Removed.
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxySchedulerClient::scheduleBeginFrameAndCommit):
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::stop):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::testTimeout):
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::CCLayerTreeHostTest::endTest):
(WTF::CCLayerTreeHostTestThreadOnly::runTest):
(WTF::TEST_F):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):

  • tests/CCThreadTest.cpp:

(WebKit::PingPongTestUsingTasks::ping):

6:19 PM Changeset in webkit [97691] by jchaffraix@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove colSpan / rowSpan caching from RenderTableCell
​https://bugs.webkit.org/show_bug.cgi?id=69569

Reviewed by Darin Adler.

Memory optimization, no change in behavior expected.

This change removes m_colSpan & m_rowSpan from RenderTableCell (inspired by
kling's memory shaving effort).

This makes us save 8 bytes per RenderTableCell on my machine (x86-64). No slowdown
on PageCycler Alexa-US.

This change refactored the way we handle updates from the DOM side to simplify
the code using the following: colspan / rowspan updates always go through
parseMappedAttribute where we already check for the renderer type. Thus removed the
generic updateFromElement and replaced it with colSpanOrRowSpanChanged. This removes
a virtual dispatch.

As there is no way to know if an attribute has changed in the parseMappedAttribute code,
we now unconditionally call colSpanOrRowSpanChanged. Looking at Chromium's page data,
colSpan and rowSpan are never changed outside the HTML markup thus such a change should
have a limited impact.

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::parseMappedAttribute): Updated after updateFromElement
removal.

  • html/HTMLTableCellElement.h:

(WebCore::toHTMLTableCellElement): Added the usual conversion functions.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::RenderTableCell): Added a boolean to know if we have
the right type of associated DOM node to avoid the cost of checking that every
time.

(WebCore::RenderTableCell::colSpan):
(WebCore::RenderTableCell::rowSpan):
Forwarded the calls to our object if we have the right type (normal case).

(WebCore::RenderTableCell::colSpanOrRowSpanChanged): Handles the
updateFromElement calls but in a more streamlined way.

  • rendering/RenderTableCell.h:
6:15 PM Changeset in webkit [97690] by jamesr@google.com
  • 9 edits
    1 add in trunk/Source

[chromium] Fix shutdown race when posting main thread task to CCThreadProxy and enable tests
​https://bugs.webkit.org/show_bug.cgi?id=70161

Reviewed by David Levin.

Source/WebCore:

Adds a weak pointer mechanism to cancel main thread tasks posted to CCThreadProxy instances from the compositor
thread. Previously there was a race condition where main thread tasks could run even after the CCThreadProxy was
destroyed.

This race does not exist in the other direction because when tearing down a CCThreadProxy we first post a quit
task to the compositor thread and then suspend execution of the main thread until all compositor tasks for the
CCThreadProxy have been drained.

Covered by the now-enabled CCLayerTreeHostTest* unit tests.

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCScopedMainThreadProxy.h: Added.

(WebCore::CCScopedMainThreadProxy::create):
(WebCore::CCScopedMainThreadProxy::postTask):
(WebCore::CCScopedMainThreadProxy::shutdown):
(WebCore::CCScopedMainThreadProxy::CCScopedMainThreadProxy):
(WebCore::CCScopedMainThreadProxy::runTaskIfNotShutdown):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

Enables the CCLayerTreeHostTest* tests by default. Most tests are run twice in a single thread and multiple
thread configuration. Some tests run only in the multiple thread configuration if they depend on the compositor
thread scheduling draws by itself.

  • tests/CCLayerTreeHostTest.cpp:

(::CCLayerTreeHostTest::timeout):
(::CCLayerTreeHostTest::clearTimeout):
(::CCLayerTreeHostTest::CCLayerTreeHostTest):
(::CCLayerTreeHostTest::onEndTest):
(::CCLayerTreeHostTest::TimeoutTask::TimeoutTask):
(::CCLayerTreeHostTest::TimeoutTask::clearTest):
(::CCLayerTreeHostTest::TimeoutTask::~TimeoutTask):
(::CCLayerTreeHostTest::TimeoutTask::Run):
(::CCLayerTreeHostTest::runTest):
(::CCLayerTreeHostTest::doBeginTest):
(::CCLayerTreeHostTestThreadOnly::runTest):
(::CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):

6:12 PM Changeset in webkit [97689] by tkent@chromium.org
  • 15 edits in branches/chromium/874

Merge 97351 - REGRESSION(r89915): <input type=email multiple> don't show the default value
​https://bugs.webkit.org/show_bug.cgi?id=69895

Reviewed by Hajime Morita.

Source/WebCore:

m_valueIfDirty became unexpectedly empty because
EmailInputType::sanitizeValue() returned an empty string for a
null input string.

To solve this issue, HTMLInputElement::sanitizeValue() checks
nullness, and remove the null check of sanitizeValue() of
InputType subclasses.
Also, we make InputType::sanitizeValue() const.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::sanitizeValue):

  • Make this const.
  • Remove null check.
  • html/ColorInputType.h: Make sanitizeValue() const.
  • html/EmailInputType.cpp:

(WebCore::EmailInputType::sanitizeValue): Make this const.

  • html/EmailInputType.h: Make sanitizeValue() const.
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::sanitizeValue):
(WebCore::HTMLInputElement::updateValueIfNeeded):

  • html/InputType.cpp:

(WebCore::InputType::sanitizeValue):
Returns a null string if the input string is null, and
don't call InputType::sanitizeValue() in this case.

  • html/InputType.h: Make sanitizeValue() const.
  • html/NumberInputType.cpp:

(WebCore::NumberInputType::sanitizeValue): Make this const.

  • html/NumberInputType.h: Make sanitizeValue() const.
  • html/RangeInputType.cpp:

(WebCore::RangeInputType::sanitizeValue):

  • Make this const.
  • Remove null check.
  • html/RangeInputType.h: Make sanitizeValue() const.
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::sanitizeValue): Make this const.

  • html/TextFieldInputType.h: Make sanitizeValue() const.

LayoutTests:

  • fast/forms/input-value-sanitization-expected.txt:
  • fast/forms/input-value-sanitization.html:

TBR=​tkent@chromium.org
BUG=​http://code.google.com/p/chromium/issues/detail?id=99829
Review URL: ​http://codereview.chromium.org/8336009

6:10 PM Changeset in webkit [97688] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r97641.
​http://trac.webkit.org/changeset/97641
​https://bugs.webkit.org/show_bug.cgi?id=70288

"This change may have broken mouse/hit-test coordinate tests."
(Requested by jeffm7 on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-17

  • platform/Widget.cpp:

(WebCore::Widget::convertFromContainingWindow):
(WebCore::Widget::convertToContainingWindow):

6:07 PM Changeset in webkit [97687] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSParser: Remove unused variable 'propertyComponents'
​https://bugs.webkit.org/show_bug.cgi?id=70230

Patch by Andreas Kling <​kling@webkit.org> on 2011-10-17
Reviewed by Darin Adler.

(WebCore::CSSParser::markPropertyEnd):

5:56 PM Changeset in webkit [97686] by imasaki@chromium.org
  • 1 edit
    20 adds
    2 deletes in trunk/LayoutTests

[Chromium] rebaseline fullscreen layout tests using rebaseline tools.
​https://bugs.webkit.org/show_bug.cgi?id=70165

Reviewed by David Levin.

  • platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png: Added.
  • platform/chromium-cg-mac/fullscreen/full-screen-iframe-zIndex-expected.png: Removed.
  • platform/chromium-cg-mac/fullscreen/full-screen-zIndex-after-expected.png: Removed.
  • platform/chromium-linux/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
  • platform/chromium-linux/fullscreen/full-screen-render-inline-expected.png: Added.
  • platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.png: Added.
  • platform/chromium-linux/fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
  • platform/chromium-mac-leopard/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-mac-leopard/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
  • platform/chromium-mac-leopard/fullscreen/full-screen-zIndex-after-expected.png: Added.
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png: Added.
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-zIndex-after-expected.png: Added.
  • platform/chromium-win/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
  • platform/chromium-win/fullscreen/full-screen-stacking-context-expected.png: Added.
  • platform/chromium/fullscreen/video-controls-override-expected.txt: Added.
5:54 PM Changeset in webkit [97685] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Update comments about transform hierarchy in CCLayerTreeHostCommon
​https://bugs.webkit.org/show_bug.cgi?id=69765

Patch by Shawn Singh <​shawnsingh@chromium.org> on 2011-10-17
Reviewed by James Robinson.

Only comments changed, no tests needed.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

5:46 PM Changeset in webkit [97684] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] DRT: Make non-recognized keys work in events as well.
​https://bugs.webkit.org/show_bug.cgi?id=69860

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-10-17
Reviewed by Antonio Gomes.

fast/forms/select-type-ahead-non-latin.html is the canonical case we fix
here: it has a select box with a few non-latin options, and one of them
is selected via the keyboard.

In this specific case, we need to make EventHandler::keyEvent send a
keyPressEvent to SelectElement, so that
SelectElement::defaultEventHandler calls typeAheadFind(). This happens
only when PlatformKeyEvent::text() is not empty, which was not the case
so far.

  • DumpRenderTree/efl/EventSender.cpp:

(keyDownCallback):

5:45 PM Changeset in webkit [97683] by jchaffraix@webkit.org
  • 1 edit
    8 adds in trunk/LayoutTests
ASSERTION FAILED: !m_layoutRoot->container()
!m_layoutRoot->container()->needsLayout() with generated content

​https://bugs.webkit.org/show_bug.cgi?id=61411

Reviewed by Andy Estes.

The bug was fixed by r95926 or bug 62120. Landing the tests from the bug.

  • fast/dynamic/crash-generated-counter-expected.txt: Added.
  • fast/dynamic/crash-generated-counter.html: Added.
  • fast/dynamic/crash-generated-image-expected.txt: Added.
  • fast/dynamic/crash-generated-image.html: Added.
  • fast/dynamic/crash-generated-quote-expected.txt: Added.
  • fast/dynamic/crash-generated-quote.html: Added.
  • fast/dynamic/crash-generated-text-expected.txt: Added.
  • fast/dynamic/crash-generated-text.html: Added.
5:44 PM Changeset in webkit [97682] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Do not check for Frame::contentRenderer() in ewk_view_repaint.
​https://bugs.webkit.org/show_bug.cgi?id=70118

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-10-17
Reviewed by Kenneth Rohde Christiansen.

When we have a scrollbar with an actual width, there might be a call
to ChromeClientEfl::invalidateContentsAndWindow() after
Document::detach() was called, making the call to contentRenderer()
return 0 even though everything is fine.

Example test case: animations/animation-shorthand.html.

  • ewk/ewk_view.cpp:

(ewk_view_repaint):

5:41 PM Changeset in webkit [97681] by jonlee@apple.com
  • 2 edits in trunk/Source/WebKit2

Filtering of URLs when serializing back forward list saves bad current index value
​https://bugs.webkit.org/show_bug.cgi?id=70282
<rdar://problem/10057763>

Reviewed by Sam Weinig.

When reading the serialized b-f list, perform a sanity check on the current index.
If it is invalid, we set it to NoCurrentItemIndex to prevent further corruption of
the list.

When serializing the b-f list, currentIndex can be negative in the case where the list
has one item only, and that item gets filtered out. In this instance currentIndex should
just be -1. A crashing case showed an index that was more negative, a situation that I
could not replicate. Since this value will get cleaned up when the b-f list is restored,
I just strengthened the assertion to check for a more negative index in case we run into it again.

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Update the assertion
in case we go beyond NoCurrentItemIndex (which, as an int, is -1).
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation):

5:36 PM BuildingGtk edited by Martin Robinson
(diff)
5:33 PM Changeset in webkit [97680] by barraclough@apple.com
  • 5 edits in trunk

Exception ordering in String.prototype.replace
​https://bugs.webkit.org/show_bug.cgi?id=70290

Source/JavaScriptCore:

If pattern is not a regexp, it should be converted toString before the replacement value has it's toString conversion called.

Reviewed by Oliver Hunt.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace):

LayoutTests:

Reviewed by Oliver Hunt.

  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T11-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T12-expected.txt:
    • Check in passing results.
5:26 PM Changeset in webkit [97679] by vrk@chromium.org
  • 4 edits in branches/chromium/874/Source

Merge 97451 - Clear WebMediaPlayerClientImpl back pointer on destruction
​https://bugs.webkit.org/show_bug.cgi?id=69973

Reviewed by James Robinson.

Clear the backpointer and remove the unused m_currentFrame

Source/WebCore:

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::cleanupResources):
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::releaseProvider):

  • platform/graphics/chromium/VideoLayerChromium.h:

Source/WebKit/chromium:

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::load):
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):

  • src/WebMediaPlayerClientImpl.h:

TBR=​jschuh@chromium.org
Review URL: ​http://codereview.chromium.org/8333009

5:07 PM Changeset in webkit [97678] by alokp@chromium.org
  • 6 edits
    12 adds in trunk

Add layout tests for WebPlugin compositor path
​https://bugs.webkit.org/show_bug.cgi?id=69027

Reviewed by James Robinson.

Source/WebKit/chromium:

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::printEnd):

Tools:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestWebPlugin.cpp: Added.

(premultiplyAlpha):
(TestWebPlugin::TestWebPlugin):
(TestWebPlugin::~TestWebPlugin):
(TestWebPlugin::mimeType):
(TestWebPlugin::initialize):
(TestWebPlugin::destroy):
(TestWebPlugin::updateGeometry):
(TestWebPlugin::parsePrimitive):
(TestWebPlugin::parseColor):
(TestWebPlugin::parseOpacity):
(TestWebPlugin::initScene):
(TestWebPlugin::drawScene):
(TestWebPlugin::destroyScene):
(TestWebPlugin::initProgram):
(TestWebPlugin::initPrimitive):
(TestWebPlugin::drawPrimitive):
(TestWebPlugin::loadShader):
(TestWebPlugin::loadProgram):

  • DumpRenderTree/chromium/TestWebPlugin.h: Added.

(TestWebPlugin::scriptableObject):
(TestWebPlugin::paint):
(TestWebPlugin::updateFocus):
(TestWebPlugin::updateVisibility):
(TestWebPlugin::acceptsInputEvents):
(TestWebPlugin::handleInputEvent):
(TestWebPlugin::didReceiveResponse):
(TestWebPlugin::didReceiveData):
(TestWebPlugin::didFinishLoading):
(TestWebPlugin::didFailLoading):
(TestWebPlugin::didFinishLoadingFrameRequest):
(TestWebPlugin::didFailLoadingFrameRequest):
(TestWebPlugin::Scene::Scene):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createPlugin):

LayoutTests:

  • platform/chromium/compositing/plugins: Added.
  • platform/chromium/compositing/plugins/webplugin-alpha-expected.png: Added.
  • platform/chromium/compositing/plugins/webplugin-alpha-expected.txt: Added.
  • platform/chromium/compositing/plugins/webplugin-alpha.html: Added.
  • platform/chromium/compositing/plugins/webplugin-no-alpha-expected.png: Added.
  • platform/chromium/compositing/plugins/webplugin-no-alpha-expected.txt: Added.
  • platform/chromium/compositing/plugins/webplugin-no-alpha.html: Added.
  • platform/chromium/compositing/plugins/webplugin-reflection-expected.png: Added.
  • platform/chromium/compositing/plugins/webplugin-reflection-expected.txt: Added.
  • platform/chromium/compositing/plugins/webplugin-reflection.html: Added.
4:57 PM Changeset in webkit [97677] by Chris Fleizach
  • 3 edits in trunk/Source/WebKit/chromium

AX: buttons of number type <input> controls are not fully accessible
​https://bugs.webkit.org/show_bug.cgi?id=70241

Build fix. Fix matching enums.

  • public/WebAccessibilityRole.h:
  • src/AssertMatchingEnums.cpp:
4:54 PM Changeset in webkit [97676] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Set a default charset when creating a view.
​https://bugs.webkit.org/show_bug.cgi?id=69771

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-10-17
Reviewed by Antonio Gomes.

Most (or all) ports default to iso-8859-1 when creating a view (or their
equivalent of a view), so we should do that too.

This makes fast/dom/Document/document-charset.html pass.

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

4:54 PM Changeset in webkit [97675] by fpizlo@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

DFG bytecode parser should understand inline stacks
​https://bugs.webkit.org/show_bug.cgi?id=70278

Reviewed by Oliver Hunt.

The DFG bytecode parser is now capable of parsing multiple code blocks at
once. This remains turned off since not all inlining functionality is
implemented.

This required making a few changes elsewhere in the system. The bytecode
parser now may do some of the same things that the bytecode generator does,
like allocating constants and identifiers. Basic block linking relies on
bytecode indices, which are only meaningful within the context of one basic
block. This is fine, so long as linking is done eagerly whenever switching
from one code block to another.

  • bytecode/CodeOrigin.h:

(JSC::CodeOrigin::CodeOrigin):

  • bytecompiler/BytecodeGenerator.h:
  • dfg/DFGBasicBlock.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getThis):
(JSC::DFG::ByteCodeParser::setThis):
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::InlineStackEntry::executable):
(JSC::DFG::ByteCodeParser::InlineStackEntry::~InlineStackEntry):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::linkBlocks):
(JSC::DFG::ByteCodeParser::setupPredecessors):
(JSC::DFG::ByteCodeParser::buildOperandMapsIfNecessary):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGGraph.h:

(JSC::DFG::GetBytecodeBeginForBlock::GetBytecodeBeginForBlock):
(JSC::DFG::GetBytecodeBeginForBlock::operator()):
(JSC::DFG::Graph::blockIndexForBytecodeOffset):

  • dfg/DFGNode.h:
  • runtime/Identifier.h:

(JSC::IdentifierMapIndexHashTraits::emptyValue):

  • runtime/JSValue.h:
  • wtf/StdLibExtras.h:

(WTF::binarySearchWithFunctor):

4:51 PM Changeset in webkit [97674] by dimich@chromium.org
  • 4 edits in branches/chromium/874/Source/WebCore

Merge 97667 - Re-landing: window.webkitNotifications uses deallocated NotificationPresenter after live Iframe transfer.
​https://bugs.webkit.org/show_bug.cgi?id=70147

Reviewed by David Levin.

I only found a way to test this manually, since Chromium TestShell uses static instance
of NotificationPresenter instead of per-page one so the issue does not reproduce.
Adding manual test that works in full build of Chromium.

  • manual-tests/iframe_notifications/iframe-reparenting-close-window-child.html: Added.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window-iframe.html: Added.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window.html: Added.
  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::disconnectFrame):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::resetNotifications):

  • page/DOMWindow.h:
  • page/Frame.cpp:

(WebCore::Frame::transferChildFrameToNewDocument): reset webkitNotifications object.

TBR=​dimich@chromium.org
Review URL: ​http://codereview.chromium.org/8333006

4:49 PM Changeset in webkit [97673] by barraclough@apple.com
  • 9 edits in trunk

Incorrect behavior from String match/search & undefined pattern
​https://bugs.webkit.org/show_bug.cgi?id=70286

Reviewed by Sam weinig.

Source/JavaScriptCore:

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncMatch):

  • In case of undefined, pattern is "".

(JSC::stringProtoFuncSearch):

  • In case of undefined, pattern is "".

LayoutTests:

  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T4-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T6-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T7-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T8-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T9-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T4-expected.txt:
    • Check in passing results.
4:42 PM Changeset in webkit [97672] by rniwa@webkit.org
  • 5 edits in trunk/Tools

[nrwt] Add new category for MISSING
​https://bugs.webkit.org/show_bug.cgi?id=69990

Reviewed by Dirk Pranke.

Treat missing results as a new category in summerize_results.

Because Chromium port wants to turn bots red when there are tests with missing results,
extracted the logic to compute the exit code as exit_code_from_summarized_results in
base and chromium ports.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4:41 PM Changeset in webkit [97671] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Remove unnecessary calls to columnRectAt()
​https://bugs.webkit.org/show_bug.cgi?id=70283

Reviewed by Darin Adler.

These call sites only needed one of the column dimensions, which are independent of the column
index, and can be retrieved directly from the ColumnInfo.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::hitTestColumns):

4:40 PM Changeset in webkit [97670] by commit-queue@webkit.org
  • 18 edits in trunk/Source/WebCore

Protect against incorrect Element::fast*Attribute() usage.
​https://bugs.webkit.org/show_bug.cgi?id=67612

Patch by Andreas Kling <​kling@webkit.org> on 2011-10-17
Reviewed by Darin Adler.

Add debug-only checks in Element's fastHasAttribute() and fastGetAttribute() to verify
that we aren't looking up the "style" attribute or any of the SVG animatable attributes.

No new tests, erroneous behavior is covered by assertions.

  • WebCore.exp.in: Export Element::fastAttributeLookupAllowed() for debug builds

since it's used by the inline fast*Attribute() calls.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement): Use getAttribute() for class.

  • css/SelectorChecker.cpp:

(WebCore::linkAttribute): Use getAttribute() for xlink:href.

  • dom/Element.cpp:

(WebCore::Element::getAttribute): Manually inline fastGetAttribute() in ideal case.
(WebCore::Element::fastAttributeLookupAllowed): Checks if an attribute can be used
with the fast lookup functions.

  • dom/Element.h:

(WebCore::Element::fastHasAttribute): Add assertion.
(WebCore::Element::fastGetAttribute): Ditto.

  • editing/ApplyStyleCommand.cpp:

(WebCore::hasNoAttributeOrOnlyStyleAttribute): Use getAttribute() for class.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::isInlineNodeWithStyle): Ditto.

  • html/ClassList.cpp:

(WebCore::ClassList::ClassList): Ditto.
(WebCore::ClassList::addInternal): Ditto.
(WebCore::ClassList::removeInternal): Ditto.
(WebCore::ClassList::toString): Ditto.

  • svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::hasValidGlyphElements): Use getAttribute() for xlink:href.

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::rotateMode): Use getAttribute() for rotate.

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::animationMode): Use getAttribute() for values.

  • svg/SVGElement.cpp:

(WebCore::SVGElement::isAnimatableAttribute): Added, returns true if the given
QualifiedName represents an animatable attribute.

  • svg/SVGElement.h:
  • svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::srcValue): Use getAttribute() for xlink:href.
(WebCore::SVGFontFaceUriElement::loadFont): Ditto.

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::xlinkHref): Ditto.

  • svg/SVGGlyphRefElement.cpp:

(WebCore::SVGGlyphRefElement::hasValidGlyphElement): Ditto.

  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::type): Use getAttribute() for type.

4:37 PM Changeset in webkit [97669] by Chris Fleizach
  • 17 edits
    4 adds in trunk

AX: buttons of number type <input> controls are not fully accessible
​https://bugs.webkit.org/show_bug.cgi?id=70241

Source/WebCore:

Expose the spin button object to the AX hierarchy. Since there is no distinct
render object that backs this object, a mock object needs to be created for the entire
spin button and the actual increment and decrement buttons inside.

Reviewed by Darin Adler.

Test: platform/mac/accessibility/html5-input-number.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

  • accessibility/AccessibilityMockObject.cpp:

(WebCore::AccessibilityMockObject::AccessibilityMockObject):

  • accessibility/AccessibilityMockObject.h:

(WebCore::AccessibilityMockObject::isMockObject):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::boundingBoxForQuads):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isSpinButton):
(WebCore::AccessibilityObject::isSpinButtonPart):
(WebCore::AccessibilityObject::isMockObject):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::boundingBoxRect):
(WebCore::AccessibilityRenderObject::addImageMapChildren):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilitySpinButton.cpp: Added.

(WebCore::AccessibilitySpinButton::create):
(WebCore::AccessibilitySpinButton::AccessibilitySpinButton):
(WebCore::AccessibilitySpinButton::~AccessibilitySpinButton):
(WebCore::AccessibilitySpinButton::incrementButton):
(WebCore::AccessibilitySpinButton::decrementButton):
(WebCore::AccessibilitySpinButton::elementRect):
(WebCore::AccessibilitySpinButton::addChildren):
(WebCore::AccessibilitySpinButton::step):
(WebCore::AccessibilitySpinButtonPart::AccessibilitySpinButtonPart):
(WebCore::AccessibilitySpinButtonPart::create):
(WebCore::AccessibilitySpinButtonPart::elementRect):
(WebCore::AccessibilitySpinButtonPart::press):

  • accessibility/AccessibilitySpinButton.h: Added.

(WebCore::AccessibilitySpinButton::setSpinButtonElement):
(WebCore::AccessibilitySpinButton::roleValue):
(WebCore::AccessibilitySpinButton::accessibilityIsIgnored):
(WebCore::AccessibilitySpinButton::isSpinButton):
(WebCore::AccessibilitySpinButtonPart::~AccessibilitySpinButtonPart):
(WebCore::AccessibilitySpinButtonPart::isIncrementor):
(WebCore::AccessibilitySpinButtonPart::setIsIncrementor):
(WebCore::AccessibilitySpinButtonPart::roleValue):
(WebCore::AccessibilitySpinButtonPart::isSpinButtonPart):
(WebCore::AccessibilitySpinButtonPart::accessibilityIsIgnored):
(WebCore::toAccessibilitySpinButton):
(WebCore::toAccessibilitySpinButtonPart):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::step):
(WebCore::SpinButtonElement::repeatingTimerFired):

  • html/shadow/TextControlInnerElements.h:

LayoutTests:

Reviewed by Darin Adler.

  • platform/mac/accessibility/html5-input-number-expected.txt: Added.
  • platform/mac/accessibility/html5-input-number.html: Added.
4:34 PM Changeset in webkit [97668] by Lucas Forschler
  • 8 edits in tags/Safari-535.6.2/Source

Merged r97514.

4:30 PM Changeset in webkit [97667] by dimich@chromium.org
  • 5 edits
    3 adds in trunk/Source/WebCore

Re-landing: window.webkitNotifications uses deallocated NotificationPresenter after live Iframe transfer.
​https://bugs.webkit.org/show_bug.cgi?id=70147

Reviewed by David Levin.

I only found a way to test this manually, since Chromium TestShell uses static instance
of NotificationPresenter instead of per-page one so the issue does not reproduce.
Adding manual test that works in full build of Chromium.

  • manual-tests/iframe_notifications/iframe-reparenting-close-window-child.html: Added.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window-iframe.html: Added.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window.html: Added.
  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::disconnectFrame):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::resetNotifications):

  • page/DOMWindow.h:
  • page/Frame.cpp:

(WebCore::Frame::transferChildFrameToNewDocument): reset webkitNotifications object.

4:26 PM Changeset in webkit [97666] by Lucas Forschler
  • 5 edits in tags/Safari-535.6.2/Source

Versioning.

4:22 PM Changeset in webkit [97665] by Lucas Forschler
  • 1 copy in tags/Safari-535.6.2

New Tag.

4:15 PM Changeset in webkit [97664] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

quote "attributes" keyword in CodeGeneratorGObject.pm
​https://bugs.webkit.org/show_bug.cgi?id=64348

Patch by Arno Renevier <​arno@renevier.net> on 2011-10-17
Reviewed by Darin Adler.

No change of functionality. No new tests.

  • bindings/scripts/CodeGeneratorGObject.pm:
4:12 PM Changeset in webkit [97663] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

More tweaking of chromium fullscreen expectations.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
3:56 PM Changeset in webkit [97662] by ojan@chromium.org
  • 9 edits in trunk

Unreviewed, rolling out r97654.
​http://trac.webkit.org/changeset/97654
​https://bugs.webkit.org/show_bug.cgi?id=68497

Caused a number of Chromium failures.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):

LayoutTests:

  • platform/mac/fast/backgrounds/background-leakage-transforms-expected.txt:
  • platform/mac/fast/table/028-vertical-expected.png:
  • platform/mac/fast/table/028-vertical-expected.txt:
  • platform/mac/fast/table/height-percent-test-vertical-expected.png:
  • platform/mac/fast/table/height-percent-test-vertical-expected.txt:
  • platform/mac/fast/writing-mode/fallback-orientation-expected.txt:
3:53 PM Changeset in webkit [97661] by ojan@chromium.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r97653.
​http://trac.webkit.org/changeset/97653
​https://bugs.webkit.org/show_bug.cgi?id=69957

Caused a number of Chromium failures.

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

LayoutTests:

  • fast/writing-mode/borders-expected.html: Removed.
  • fast/writing-mode/borders.html: Removed.
3:38 PM Changeset in webkit [97660] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

fullscreen/video-controls-override.html is still failing on chromium bots.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
3:31 PM Changeset in webkit [97659] by adamk@chromium.org
  • 13 edits
    2 adds in trunk

[MutationObservers] Implement WebKitMutationObserver.observe for attributes
​https://bugs.webkit.org/show_bug.cgi?id=68956

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-10-17
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/mutation/observe-attributes.html

This adds an initial implementation for registering mutation observers on nodes,
delivering mutation records at the end of the outer-most script invokation and
observing mutations to element attributes.

Note that the outer-most script invokation only works in V8.

Note also that support for observing changes to the style attribute when updated
via the style property is not implemented here.

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::didLeaveScriptContext):

  • dom/Element.cpp:

(WebCore::enqueueAttributesMutationRecord):
(WebCore::Element::setAttribute):

  • dom/MutationRecord.cpp:

(WebCore::MutationRecord::createAttributes):

  • dom/MutationRecord.h:
  • dom/MutationRecord.idl:
  • dom/Node.cpp:

(WebCore::Node::clearRareData):
(WebCore::Node::mutationObserverData):
(WebCore::Node::ensureMutationObserverData):
(WebCore::Node::registeredMutationObserversOfType):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::deregisterMutationObserver):

  • dom/Node.h:
  • dom/NodeRareData.h:

(WebCore::MutationObserverRegistration::MutationObserverRegistration):
(WebCore::MutationObserverRegistration::operator==):
(WebCore::MutationObserverData::MutationObserverData):
(WebCore::MutationObserverData::~MutationObserverData):
(WebCore::NodeRareData::mutationObserverData):
(WebCore::NodeRareData::ensureMutationObserverData):

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::observe):
(WebCore::WebKitMutationObserver::disconnect):
(WebCore::WebKitMutationObserver::wasDeregistered):
(WebCore::activeMutationObservers):
(WebCore::WebKitMutationObserver::enqueueMutationRecord):
(WebCore::WebKitMutationObserver::deliverAllMutations):
(WebCore::WebKitMutationObserver::deliver):

  • dom/WebKitMutationObserver.h:

LayoutTests:

  • fast/mutation/observe-attributes-expected.txt: Added.
  • fast/mutation/observe-attributes.html: Added.
3:30 PM Changeset in webkit [97658] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

HTMLKeygenElement: Don't cache keytype and challenge attributes.
​https://bugs.webkit.org/show_bug.cgi?id=68365

Patch by Andreas Kling <​kling@webkit.org> on 2011-10-17
Reviewed by Darin Adler.

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::parseMappedAttribute):
(WebCore::HTMLKeygenElement::appendFormData):

  • html/HTMLKeygenElement.h:
3:21 PM Changeset in webkit [97657] by dpranke@chromium.org
  • 3 edits in trunk/LayoutTests

Update chromium gpu baselines for fast/canvas/canvas-composite-transformclip.html .

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
2:54 PM Changeset in webkit [97656] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Remove some expectations that are no longer failing.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
2:51 PM Changeset in webkit [97655] by barraclough@apple.com
  • 5 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=70207
After deleting defineSetter, it is absent but appears in name list

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertyNames):

  • This should check whether static functions have been reified.

LayoutTests:

  • fast/js/delete-syntax-expected.txt:
  • fast/js/script-tests/delete-syntax.js:
    • Added test case for getOwnPropertyNames.
2:50 PM Changeset in webkit [97654] by ojan@chromium.org
  • 9 edits in trunk

incorrect height with height:auto and writing-mode:vertical-rl
​https://bugs.webkit.org/show_bug.cgi?id=68497

Reviewed by David Hyatt.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):

LayoutTests:

I'm not sure I completely understand the changes to the height/width
of the body/html elements, but the new height/width look correct to me.

  • platform/mac/fast/backgrounds/background-leakage-transforms-expected.txt:
  • platform/mac/fast/table/028-vertical-expected.txt:
  • platform/mac/fast/table/height-percent-test-vertical-expected.txt:
  • platform/mac/fast/writing-mode/fallback-orientation-expected.txt:
2:46 PM Changeset in webkit [97653] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

display:inline-block elements don't correctly handle orthogonal writing-modes
​https://bugs.webkit.org/show_bug.cgi?id=69957

Reviewed by David Hyatt.

Source/WebCore:

Reading min/maxPreferredLogicalWidth from a child uses the child's writing-mode.
Instead, we need to grab the result based on the parent's writing-mode.
In the case of orthogonal writing-modes, we need the child's logical height.

Tests: fast/writing-mode/borders-expected.html

fast/writing-mode/borders.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

LayoutTests:

  • fast/writing-mode/borders-expected.html: Added.
  • fast/writing-mode/borders.html: Added.
2:42 PM Changeset in webkit [97652] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, expectations change.

Add back in the failing fullscreen tests; also add in some
flaky failures.

  • platform/chromium/test_expectations.txt:
2:41 PM Changeset in webkit [97651] by arv@chromium.org
  • 4 edits in trunk/LayoutTests

REGRESSION(r97566) fast/js/stack-overflow-arrity-catch.html fails
​https://bugs.webkit.org/show_bug.cgi?id=70210

Reviewed by Darin Adler.

Change the test to not call debug() inside the test functions since that fails on V8
because we are already at the maximum allowed stack depth.

  • fast/js/script-tests/stack-overflow-arrity-catch.js:

(test1): Changed to not call debug but set a boolean variable that is later checked.
(test2): Ditto.

  • fast/js/stack-overflow-arrity-catch-expected.txt:
  • platform/chromium/test_expectations.txt:
2:29 PM Changeset in webkit [97650] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Mac build fix.

2:22 PM Changeset in webkit [97649] by dimich@chromium.org
  • 5 edits
    3 deletes in trunk/Source/WebCore

Unreviewed, rolling out r97643.
​http://trac.webkit.org/changeset/97643
​https://bugs.webkit.org/show_bug.cgi?id=70270

Broke iframe reparenting tests (Requested by dimich on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-17

  • manual-tests/iframe_notifications/iframe-reparenting-close-window-child.html: Removed.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window-iframe.html: Removed.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window.html: Removed.
  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::disconnectFrame):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::webkitNotifications):

  • page/DOMWindow.h:
  • page/Frame.cpp:

(WebCore::Frame::transferChildFrameToNewDocument):

2:14 PM Changeset in webkit [97648] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

2:09 PM Changeset in webkit [97647] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Removing suppressions for the fullscreen/ tests - it looks
like they're mostly passing now. I will pick up the tests that
are still failing in a subsequent patch.

  • platform/chromium/test_expectations.txt:
1:58 PM Changeset in webkit [97646] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

  • heap/HandleStack.cpp: Added a missing #include.
1:58 PM Changeset in webkit [97645] by leandro@webkit.org
  • 4 edits in trunk

Unreviewed; actually enable/disable microdata support in CMake.

Follow-up to r97471, which did not plug the option to enable/disable
microdata into the buildsystem.

  • Source/cmake/OptionsEfl.cmake: Add ENABLE_MICRODATA feature, turned off by default.
  • Source/cmake/OptionsWinCE.cmake: Ditto.
  • Source/cmakeconfig.h.cmake: Add ENABLE_MICRODATA #cmakedefine.
1:51 PM Changeset in webkit [97644] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Windows build fix.

longer existant symbol.

  • heap/MarkStack.cpp:

(JSC::MarkStackArray::shrinkAllocation): Cast to the right type.

1:46 PM Changeset in webkit [97643] by dimich@chromium.org
  • 5 edits
    4 adds in trunk/Source/WebCore

window.webkitNotifications uses deallocated NotificationPresenter after live Iframe transfer.
​https://bugs.webkit.org/show_bug.cgi?id=70147

Reviewed by David Levin.

I only found a way to test this manually, since Chromium TestShell uses static instance
of NotificationPresenter instead of per-page one so the issue does not reproduce.
Adding manual test that works in full build of Chromium.

  • manual-tests/iframe_notifications/iframe-reparenting-close-window-child.html: Added.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window-iframe.html: Added.
  • manual-tests/iframe_notifications/iframe-reparenting-close-window.html: Added.
  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::disconnectFrame):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::resetNotifications):

  • page/DOMWindow.h:
  • page/Frame.cpp:

(WebCore::Frame::transferChildFrameToNewDocument): reset webkitNotifications object.

1:43 PM Changeset in webkit [97642] by ggaren@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

Simplified GC marking logic
​https://bugs.webkit.org/show_bug.cgi?id=70258

Reviewed by Filip Pizlo.

No perf. change.

This is a first step toward GC allocating string backing stores, starting
with ropes. It also enables future simplifications and optimizations.

  • Replaced some complex mark stack logic with a simple linear stack of

JSCell pointers.

  • Replaced logic for short-circuiting marking based on JSType and/or

Structure flags with special cases for object, array, and string.

  • Fiddled with inlining for better codegen.
  • heap/Heap.cpp:

(JSC::Heap::Heap): Provide more vptrs to SlotVisitor, for use in marking.

  • heap/HeapRootVisitor.h: Removed unused functions that no longer build.
  • heap/MarkStack.cpp:

(JSC::MarkStackArray::MarkStackArray):
(JSC::MarkStackArray::~MarkStackArray):
(JSC::MarkStackArray::expand):
(JSC::MarkStackArray::shrinkAllocation):
(JSC::MarkStack::reset):
(JSC::visitChildren):
(JSC::SlotVisitor::drain):

  • heap/MarkStack.h:

(JSC::MarkStack::MarkStack):
(JSC::MarkStack::~MarkStack):
(JSC::MarkStackArray::append):
(JSC::MarkStackArray::removeLast):
(JSC::MarkStackArray::isEmpty):
(JSC::MarkStack::append):
(JSC::MarkStack::appendUnbarrieredPointer):
(JSC::MarkStack::internalAppend): Replaced complex mark set logic with
simple linear stack.

  • heap/SlotVisitor.h:

(JSC::SlotVisitor::SlotVisitor): Updated for above changes.

  • runtime/JSArray.cpp:

(JSC::JSArray::visitChildren):

  • runtime/JSArray.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren):

  • runtime/JSObject.h: Don't inline visitChildren; it's too big.
  • runtime/Structure.h:

(JSC::MarkStack::internalAppend): Nixed the short-circuit for CompoundType
because it prevented strings from owning GC pointers.

  • runtime/WriteBarrier.h:

(JSC::MarkStack::appendValues): No need to validate; internalAppend will
do that for us.

1:29 PM Changeset in webkit [97641] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Widget window coordinate functions should use root view coordinate functions
​https://bugs.webkit.org/show_bug.cgi?id=70152

Reviewed by Darin Adler.

No new tests, no changes to functionality.

  • platform/Widget.cpp:

(WebCore::Widget::convertFromContainingWindow): Use convertFromRootView().
(WebCore::Widget::convertToContainingWindow): Use convertToRootView().

1:15 PM Changeset in webkit [97640] by cmarrin@apple.com
  • 8 edits in trunk/Source

Throttle rate of requestAnimationFrame when page is not visible
​https://bugs.webkit.org/show_bug.cgi?id=67873

Reviewed by Anders Carlsson.

Source/WebCore:

Add logic to suspend and resume scripted animations when page is hidden,
minimized or the tab is not visible. The hide/minimize notification comes
in from WebKit/WebKit2 to a new set of functions.

  • WebCore.exp.in:
  • page/Page.cpp:

(WebCore::Page::didMoveOnscreen):
(WebCore::Page::willMoveOffscreen):
(WebCore::Page::suspendScriptedAnimations):
(WebCore::Page::resumeScriptedAnimations):

  • page/Page.h:

Source/WebKit/mac:

Plumb through notification when the window is hidden/shown or
minimized/unminimized

  • WebView/WebView.mm:

(-[WebView _windowWillOrderOnScreen:]):
(-[WebView _windowWillOrderOffScreen:]):

Source/WebKit2:

Plumb through notification when the window is hidden/shown or
minimized/unminimized

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::suspendPainting):
(WebKit::DrawingAreaImpl::resumePainting):

1:03 PM Changeset in webkit [97639] by noam.rosenthal@nokia.com
  • 25 edits
    5 adds in trunk/Source/WebKit2

[Qt][WK2] Synchronize tiling with accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=69151

Reviewed by Simon Hausmann.

Make the tiled "non-composited" content and the composited layers go through the same
code path on WebKit2. Instead of having a "drawing area" that handles the non-composited
content and a seperate layer tree, we put everything in a layer tree, with the non-
composited content being a layer in the tree.

This allows fixing several issues with websites that have large content areas that are
composited or overlap with composited layers.

Layer-tree synchronization is done by passing WebKit2 messages between a LayerTreeHost
on the WebProcess and a LayerTreeHostProxy on the UI process. Every layer in the tree has
its own tiled backing store, and uses the LayerTreeHost communication channel to pass
content up to the UI process. The UI process will later creates its own GraphicsLayer tree,
based on TextureMapper, which can be painted directly with OpenGL.

Several optimizations are available for the non-composited layer as well, e.g. specifying
a trajectory and updating the visible rect together with the content scale.

This code is currently disabled, a separate patch will enable it and glue it to
QTouchWebPage.

  • DerivedSources.pro:
  • Platform/CoreIPC/MessageID.h:
  • Scripts/webkit2/messages.py:
  • Shared/LayerTreeContext.h:
  • Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):

  • Shared/WebLayerTreeInfo.h:
  • Shared/qt/LayerTreeContextQt.cpp:

(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::~LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
(WebKit::LayerTreeContext::isEmpty):
(WebKit::operator==):

  • UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::updateWebView):
(WebKit::DrawingAreaProxy::contentsRect):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::viewportVisibleRect):
(WebKit::DrawingAreaProxy::isBackingStoreReady):
(WebKit::DrawingAreaProxy::paintToCurrentGLContext):
(WebKit::DrawingAreaProxy::setVisibleContentsRectAndScale):
(WebKit::DrawingAreaProxy::setVisibleContentRectTrajectoryVector):
(WebKit::DrawingAreaProxy::createTileForLayer):
(WebKit::DrawingAreaProxy::updateTileForLayer):
(WebKit::DrawingAreaProxy::removeTileForLayer):
(WebKit::DrawingAreaProxy::didReceiveLayerTreeHostProxyMessage):
(WebKit::DrawingAreaProxy::page):

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::didReceiveLayerTreeHostProxyMessage):
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRectAndScale):
(WebKit::DrawingAreaProxyImpl::setVisibleContentRectTrajectoryVector):
(WebKit::DrawingAreaProxyImpl::paintToCurrentGLContext):

  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/LayerTreeHostProxy.h: Added.

(WebKit::LayerTreeHostProxy::layerByID):
(WebKit::LayerTreeHostProxy::rootLayer):
(WebKit::LayerTreeHostProxy::notifyAnimationStarted):
(WebKit::LayerTreeHostProxy::notifySyncRequired):
(WebKit::LayerTreeHostProxy::showDebugBorders):
(WebKit::LayerTreeHostProxy::showRepaintCounter):
(WebKit::LayerTreeHostProxy::paintContents):

  • UIProcess/LayerTreeHostProxy.messages.in: Added.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp: Added.
  • WebKit2.pro:
  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):
(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setNeedsDisplay):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintBegin):
(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::setRootLayer):
(WebCore::WebGraphicsLayer::setVisibleContentRectTrajectoryVector):
(WebCore::WebGraphicsLayer::setVisibleContentRect):
(WebCore::WebGraphicsLayer::tiledBackingStorePaint):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintEnd):
(WebCore::WebGraphicsLayer::tiledBackingStoreUpdatesAllowed):
(WebCore::WebGraphicsLayer::tiledBackingStoreContentsRect):
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::WebGraphicsLayer::tiledBackingStoreBackgroundColor):
(WebCore::WebGraphicsLayer::createTile):
(WebCore::WebGraphicsLayer::updateTile):
(WebCore::WebGraphicsLayer::removeTile):
(WebCore::WebGraphicsLayer::updateTileBuffersRecursively):
(WebCore::WebGraphicsLayer::layerTreeTileClient):
(WebCore::WebGraphicsLayer::updateContentBuffers):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebCore::WebGraphicsLayer::setLayerTreeTileClient):

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::didReceiveLayerTreeHostMessage):

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):

  • WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::setVisibleContentRectAndScale):
(WebKit::LayerTreeHost::setVisibleContentRectTrajectoryVector):
(WebKit::LayerTreeHost::setVisibleContentRectForLayer):
(WebKit::LayerTreeHost::renderNextFrame):

  • WebProcess/WebPage/LayerTreeHost.messages.in: Added.
  • WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::didReceiveLayerTreeHostMessage):

  • WebProcess/WebPage/TiledDrawingArea.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::create):
(WebKit::LayerTreeHostQt::~LayerTreeHostQt):
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::setLayerFlushSchedulingEnabled):
(WebKit::LayerTreeHostQt::scheduleLayerFlush):
(WebKit::LayerTreeHostQt::cancelPendingLayerFlush):
(WebKit::LayerTreeHostQt::setShouldNotifyAfterNextScheduledLayerFlush):
(WebKit::LayerTreeHostQt::setRootCompositingLayer):
(WebKit::LayerTreeHostQt::invalidate):
(WebKit::LayerTreeHostQt::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHostQt::scrollNonCompositedContents):
(WebKit::LayerTreeHostQt::forceRepaint):
(WebKit::LayerTreeHostQt::sizeDidChange):
(WebKit::LayerTreeHostQt::didInstallPageOverlay):
(WebKit::LayerTreeHostQt::didUninstallPageOverlay):
(WebKit::LayerTreeHostQt::setPageOverlayNeedsDisplay):
(WebKit::LayerTreeHostQt::flushPendingLayerChanges):
(WebKit::LayerTreeHostQt::didSyncCompositingStateForLayer):
(WebKit::LayerTreeHostQt::didDeleteLayer):
(WebKit::LayerTreeHostQt::performScheduledLayerFlush):
(WebKit::LayerTreeHostQt::layerFlushTimerFired):
(WebKit::LayerTreeHostQt::createPageOverlayLayer):
(WebKit::LayerTreeHostQt::destroyPageOverlayLayer):
(WebKit::LayerTreeHostQt::adoptImageBackingStore):
(WebKit::LayerTreeHostQt::releaseImageBackingStore):
(WebKit::LayerTreeHostQt::notifyAnimationStarted):
(WebKit::LayerTreeHostQt::notifySyncRequired):
(WebKit::LayerTreeHostQt::paintContents):
(WebKit::LayerTreeHostQt::showDebugBorders):
(WebKit::LayerTreeHostQt::showRepaintCounter):
(WebKit::LayerTreeHost::supportsAcceleratedCompositing):
(WebKit::LayerTreeHostQt::createTile):
(WebKit::LayerTreeHostQt::updateTile):
(WebKit::LayerTreeHostQt::removeTile):
(WebKit::LayerTreeHostQt::setVisibleContentRectForLayer):
(WebKit::LayerTreeHostQt::setVisibleContentRectAndScale):
(WebKit::LayerTreeHostQt::setVisibleContentRectTrajectoryVector):
(WebKit::LayerTreeHostQt::renderNextFrame):
(WebKit::LayerTreeHostQt::layerTreeTileUpdatesAllowed):

12:49 PM Changeset in webkit [97638] by Antti Koivisto
  • 21 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=69966
Eliminate separate RenderStyle for visited link style

Reviewed by Dave Hyatt and Nikolas Zimmermann.

There are only a few properties that can apply to visited links and they can
be part of the regular style. Many things will get simpler when the separate
RenderStyle for visited links is eliminated.

  • Add valid visited link properties as separate fields to RenderStyle. The visitedLinkColor goes to inherited, everything else goes to rare data structures.
  • Make RenderStyle::visitedDependentColor() get the visited style from the new fields.
  • As VISITED_LINK pseudo style doesn't exists anymore, remove all code dealing with it.
  • Make CSSStyleSelector and ApplyPropertyColor apply the visited link style to the newly added fields instead of a separate RenderStyle.
  • Same thing with SVGRenderStyle, SVGCSSStyleSelector.
  • Fixup the SVG visited link style code to use the new fields.

This is ~15% progression in styleForElement performance over the HTML5 spec load.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyColor::ApplyPropertyColor):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::applyColorValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::updateFont):
(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::getColorFromPrimitiveValue):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::applyPropertyToRegularStyle):
(WebCore::CSSStyleSelector::applyPropertyToVisitedLinkStyle):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applySVGProperty):

  • dom/Element.cpp:

(WebCore::Element::pseudoStyleCacheIsInvalid):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getCachedPseudoStyle):
(WebCore::RenderStyle::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setVisitedLinkColor):
(WebCore::InheritedFlags::setVisitedLinkBackgroundColor):
(WebCore::InheritedFlags::setVisitedLinkBorderLeftColor):
(WebCore::InheritedFlags::setVisitedLinkBorderRightColor):
(WebCore::InheritedFlags::setVisitedLinkBorderBottomColor):
(WebCore::InheritedFlags::setVisitedLinkBorderTopColor):
(WebCore::InheritedFlags::setVisitedLinkOutlineColor):
(WebCore::InheritedFlags::setVisitedLinkColumnRuleColor):
(WebCore::InheritedFlags::setVisitedLinkTextEmphasisColor):
(WebCore::InheritedFlags::setVisitedLinkTextFillColor):
(WebCore::InheritedFlags::setVisitedLinkTextStrokeColor):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::setVisitedLinkFillPaint):
(WebCore::SVGRenderStyle::setVisitedLinkStrokePaint):
(WebCore::SVGRenderStyle::visitedLinkFillPaintType):
(WebCore::SVGRenderStyle::visitedLinkFillPaintColor):
(WebCore::SVGRenderStyle::visitedLinkStrokePaintType):
(WebCore::SVGRenderStyle::visitedLinkStrokePaintColor):

  • rendering/style/SVGRenderStyleDefs.cpp:

(WebCore::StyleFillData::StyleFillData):
(WebCore::StyleFillData::operator==):
(WebCore::StyleStrokeData::StyleStrokeData):
(WebCore::StyleStrokeData::operator==):

  • rendering/style/SVGRenderStyleDefs.h:
  • rendering/style/StyleInheritedData.cpp:

(WebCore::StyleInheritedData::StyleInheritedData):
(WebCore::StyleInheritedData::operator==):

  • rendering/style/StyleInheritedData.h:
  • rendering/style/StyleMultiColData.cpp:

(WebCore::StyleMultiColData::StyleMultiColData):
(WebCore::StyleMultiColData::operator==):

  • rendering/style/StyleMultiColData.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:
  • rendering/svg/RenderSVGResource.cpp:

(WebCore::requestPaintingResource):

12:22 PM Changeset in webkit [97637] by eric.carlson@apple.com
  • 12 edits
    2 adds in trunk/Source/WebCore

2011-10-17 Eric Carlson <​eric.carlson@apple.com>

Cues should be loaded by the cached resource loader
​https://bugs.webkit.org/show_bug.cgi?id=70134

Reviewed by Darin Adler.

No new tests, changes covered by existing tests.

  • CMakeLists.txt: Add CachedCues.cpp/h.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • loader/cache/CachedCues.cpp: Added. (WebCore::CachedCues::CachedCues): (WebCore::CachedCues::~CachedCues): (WebCore::CachedCues::data): Called when new data has been loaded, pass it to all registered

clients.

  • loader/cache/CachedCues.h: Added.
  • loader/cache/CachedResource.cpp: (WebCore::defaultPriorityForResourceType): Cues have low loader priority.
  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceClient.h: (WebCore::CachedResourceClient::didReceiveData): New client interface.
  • loader/cache/CachedResourceLoader.cpp: (WebCore::createResource): Create and return a new cue loader. (WebCore::CachedResourceLoader::requestCues): (WebCore::CachedResourceLoader::checkInsecureContent): Cues aren't mentioned in the CPS spec

yet, but they only work with a media element so use the mdia policy.

(WebCore::CachedResourceLoader::canRequest): Allow cues to be loaded from any origin like media.

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp: (WebCore::cachedResourceTypeToTargetType):
  • platform/network/chromium/ResourceRequest.h:
12:09 PM Changeset in webkit [97636] by inferno@chromium.org
  • 2 edits in branches/chromium/874/Source

Merge 97546 - [Chromium] Some WebSQLDatabase in worker bug fixes.

BUG=71551
Review URL: ​http://codereview.chromium.org/8317017

11:20 AM Changeset in webkit [97635] by mitz@apple.com
  • 5 edits in trunk

<rdar://problem/10293929> REGRESSION (r97525): iChat transcript has horizontal scroll bar when the conversation includes a wide image
​https://bugs.webkit.org/show_bug.cgi?id=70204

Reviewed by Darin Adler.

Source/WebCore:

Reverted r97525, which was supposed to fix <​http://webkit.org/b/29447>.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):

  • rendering/RenderBox.h:

LayoutTests:

  • fast/replaced/table-percent-width-expected.txt: Updated the results to

show that this test is failing after reverting r97525.

11:17 AM Changeset in webkit [97634] by Dimitri Glazkov
  • 2 edits in trunk/Tools

garden-o-matic operations fail because of CSP.
​https://bugs.webkit.org/show_bug.cgi?id=70249

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Added gardening server to the policy.
10:55 AM Changeset in webkit [97633] by adachan@apple.com
  • 7 edits
    1 add in trunk

Source/WebCore: Export KURL::baseAsString() so it can be called in WebProcessProxy::assumeReadAccessToBaseURL() in WebKit2.
​https://bugs.webkit.org/show_bug.cgi?id=70168

Reviewed by Alexey Proskuryakov.

No new tests. There is no change in functionality.

  • WebCore.exp.in: Export KURL::baseAsString().

Source/WebKit2: Calling WKPageLoadAlternateHTMLString() where baseURL does not point to a directory causes an invalid message to be returned from WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=70168

Reviewed by Alexey Proskuryakov.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::assumeReadAccessToBaseURL): Add the file path of url's base URL to m_localPathsWithAssumedReadAccess,
since url may not point to a directory.

Tools: Add a test to call WKPageLoadAlternateHTMLString() with a non-directory URL.
​https://bugs.webkit.org/show_bug.cgi?id=70168

Reviewed by Alexey Proskuryakov.

  • TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST): Call WKPageLoadAlternateHTMLString() with a file URL and make sure it finishes loading.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Add the new file.

10:24 AM Changeset in webkit [97632] by rniwa@webkit.org
  • 3 edits
    1 copy
    1 move in trunk

Source/WebCore: Touch Internals.cpp to make 64-bit GTK+ build happy.

  • testing/Internals.cpp:

LayoutTests: Moved V8-specific result to platform/chromium and added JSC result in cross-platform directory.

  • fast/files/url-required-arguments-expected.txt: Replaced with

LayoutTests/platform/qt/fast/files/url-required-arguments-expected.txt.

  • platform/chromium/fast/files/url-required-arguments-expected.txt: Copied from

LayoutTests/fast/files/url-required-arguments-expected.txt.

  • platform/qt/fast/files/url-required-arguments-expected.txt: Removed.
10:12 AM Changeset in webkit [97631] by rniwa@webkit.org
  • 2 edits in trunk

GTK build fix patch by Gustavo Noronha Silva.

  • Source/autotools/symbols.filter:
10:09 AM Changeset in webkit [97630] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.
​https://bugs.webkit.org/show_bug.cgi?id=70245

Patch by Zsolt Fehér <​feherzs@inf.u-szeged.hu> on 2011-10-17

  • platform/qt-wk2/Skipped:
10:01 AM Changeset in webkit [97629] by Chris Fleizach
  • 13 edits in trunk/Source/WebCore

AX: children() method should be consolidated in AccessibilityObject
​https://bugs.webkit.org/show_bug.cgi?id=70243

Code cleanup, no new tests.

Reviewed by Darin Adler.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::children):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::updateChildrenIfNecessary):
(WebCore::AccessibilityScrollView::updateScrollbars):
(WebCore::AccessibilityScrollView::addChildren):

  • accessibility/AccessibilityScrollView.h:
  • accessibility/AccessibilitySlider.cpp:
  • accessibility/AccessibilitySlider.h:
  • accessibility/AccessibilityTableColumn.cpp:
  • accessibility/AccessibilityTableColumn.h:
  • accessibility/AccessibilityTableHeaderContainer.cpp:
  • accessibility/AccessibilityTableHeaderContainer.h:
9:56 AM Changeset in webkit [97628] by vsevik@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Search matches highlighting in text does not work correctly.
​https://bugs.webkit.org/show_bug.cgi?id=70244

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/utilities-highlight-results.html

  • inspector/front-end/utilities.js:

():

LayoutTests:

  • inspector/utilities-highlight-results-expected.txt: Added.
  • inspector/utilities-highlight-results.html: Added.
9:47 AM Changeset in webkit [97627] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: webkit won't always send live region notifications
​https://bugs.webkit.org/show_bug.cgi?id=70030

Source/WebCore:

Webkit purposefully does not send live region notifications if some AT client has not accessed the AX tree in between
the last live region update (ostensibly to improve performance).
However, this is problematic if a screen reader misses one notification... it has no idea what happened and the only
recourse is to rescan the page for changes. The correct thing to do is to always send notifications.

Reviewed by Darin Adler.

Test: platform/mac/accessibility/aria-liveregions-notifications-always-sent.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::childrenChanged):

LayoutTests:

Reviewed by Darin Adler.

  • platform/mac/accessibility/aria-liveregions-notifications-always-sent-expected.txt: Added.
  • platform/mac/accessibility/aria-liveregions-notifications-always-sent.html: Added.
9:26 AM Changeset in webkit [97626] by Darin Adler
  • 5 edits in trunk/Tools

Add some more *.pyc ignores in directories with Python scripts.

  • QueueStatusServer: Added property svn:ignore.
  • Scripts/webkitpy/common/watchlist: Added property svn:ignore.
  • Scripts/webkitpy/layout_tests/controllers: Added property svn:ignore.
  • Scripts/webkitpy/layout_tests/views: Added property svn:ignore.
9:25 AM Changeset in webkit [97625] by Darin Adler
  • 2 edits in trunk/LayoutTests

Cleared a stray executable bit.

  • http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html: Removed property svn:executable.
9:23 AM Changeset in webkit [97624] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Add methods to get/set a custom text enconding to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=69524

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_custom_charset):
(webkit_web_view_set_custom_charset):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewCustomCharset):
(beforeAll):

8:28 AM Changeset in webkit [97623] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt][WK2][meta] Fix failing API tests
​https://bugs.webkit.org/show_bug.cgi?id=70236

Patch by Alexis Menard <​alexis.menard@openbossa.org> on 2011-10-17
Reviewed by Csaba Osztrogonác.

In order to run WebKit2 API tests we need the WebProcess to be in
the path so let's add the bin directory when running the API tests of Qt.

  • Scripts/run-qtwebkit-tests:
8:26 AM Changeset in webkit [97622] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt][WK2] Build dependency problems
​https://bugs.webkit.org/show_bug.cgi?id=68456

Patch by Kristóf Kosztyó <​kkristof@inf.u-szeged.hu> on 2011-10-17
Reviewed by Csaba Osztrogonác.

  • Scripts/webkitdirs.pm:

(buildQMakeProject):

7:53 AM Changeset in webkit [97621] by podivilov@chromium.org
  • 5 edits in trunk

Web Inspector: fix handling of source mapping entries with no mapping.
​https://bugs.webkit.org/show_bug.cgi?id=69941

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):

LayoutTests:

  • inspector/debugger/compiler-source-mapping-expected.txt:
  • inspector/debugger/compiler-source-mapping.html:
7:21 AM Changeset in webkit [97620] by Adam Roben
  • 3 edits in trunk/Source/JavaScriptCore

Windows build fix after r97536, part 3

  • runtime/JSAPIValueWrapper.h:
  • runtime/JSObject.h:

Use JS_EXPORTDATA to export the s_info members.

7:10 AM Changeset in webkit [97619] by tkent@chromium.org
  • 33 edits
    48 adds
    7 deletes in trunk/LayoutTests

[Chromium] Update test expectations for r97596 and r97602.

  • platform/chromium-cg-mac-leopard/css2.1/t0511-c21-pseud-link-02-e-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t0511-c21-pseud-link-03-e-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/events/reveal-link-when-focused-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/selectors/017-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/selectors/061-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug46623-1-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug51140-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug8950-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t0511-c21-pseud-link-02-e-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t0511-c21-pseud-link-03-e-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/events/reveal-link-when-focused-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/selectors/017-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/selectors/061-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug46623-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug51140-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug8950-expected.png: Added.
  • platform/chromium-linux/css2.1/t0511-c21-pseud-link-02-e-expected.png:
  • platform/chromium-linux/css2.1/t0511-c21-pseud-link-03-e-expected.png:
  • platform/chromium-linux/fast/events/reveal-link-when-focused-expected.png:
  • platform/chromium-linux/fast/selectors/017-expected.png:
  • platform/chromium-linux/fast/selectors/061-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46623-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug51140-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug8950-expected.png:
  • platform/chromium-mac-leopard/css2.1/t0511-c21-pseud-link-02-e-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t0511-c21-pseud-link-03-e-expected.png: Added.
  • platform/chromium-mac-leopard/fast/events/reveal-link-when-focused-expected.png: Added.
  • platform/chromium-mac-leopard/fast/selectors/017-expected.png: Added.
  • platform/chromium-mac-leopard/fast/selectors/061-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46623-1-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug51140-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug7342-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug8950-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0511-c21-pseud-link-02-e-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0511-c21-pseud-link-03-e-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/34176-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/34176-expected.png.
  • platform/chromium-mac-snowleopard/fast/events/reveal-link-when-focused-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/selectors/017-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/selectors/061-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug26553-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug26553-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46623-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51140-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug8950-expected.png: Added.
  • platform/chromium-mac/fast/events/reveal-link-when-focused-expected.png: Removed.
  • platform/chromium-mac/fast/selectors/017-expected.png: Removed.
  • platform/chromium-mac/fast/selectors/061-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug46623-1-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug51140-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug8950-expected.png: Removed.
  • platform/chromium-win/css2.1/t0511-c21-pseud-link-02-e-expected.png:
  • platform/chromium-win/css2.1/t0511-c21-pseud-link-02-e-expected.txt:
  • platform/chromium-win/css2.1/t0511-c21-pseud-link-03-e-expected.png:
  • platform/chromium-win/css2.1/t0511-c21-pseud-link-03-e-expected.txt:
  • platform/chromium-win/fast/dom/34176-expected.txt:
  • platform/chromium-win/fast/events/reveal-link-when-focused-expected.png:
  • platform/chromium-win/fast/events/reveal-link-when-focused-expected.txt:
  • platform/chromium-win/fast/selectors/017-expected.png:
  • platform/chromium-win/fast/selectors/017-expected.txt:
  • platform/chromium-win/fast/selectors/061-expected.png:
  • platform/chromium-win/fast/selectors/061-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug26553-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug46623-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46623-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug51140-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug51140-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug8950-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug8950-expected.txt:
  • platform/chromium/test_expectations.txt:
7:03 AM Changeset in webkit [97618] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Interpreter build fix after r97564

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
Moved declaration of globalData variable into ENABLE(JIT) blocks, since it is only used
there.

7:02 AM BuildingQt5OnHarmattan edited by Simon Hausmann
(diff)
7:01 AM BuildingQt5OnHarmattan edited by Simon Hausmann
(diff)
7:01 AM Changeset in webkit [97617] by Csaba Osztrogonác
  • 17 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, update Qt specific expected results after r97602.

  • platform/qt/css3/selectors3/html/css3-modsel-17-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-17-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-61-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-61-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-17-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-17-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-61-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-61-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-17-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-17-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-61-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-61-expected.txt:
  • platform/qt/fast/selectors/017-expected.png:
  • platform/qt/fast/selectors/017-expected.txt:
  • platform/qt/fast/selectors/061-expected.png:
  • platform/qt/fast/selectors/061-expected.txt:
7:01 AM Changeset in webkit [97616] by Csaba Osztrogonác
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip a passing test and add platform specific expected result.

  • platform/qt/Skipped:
  • platform/qt/fast/events/reveal-link-when-focused-expected.png: Added.
  • platform/qt/fast/events/reveal-link-when-focused-expected.txt: Added.
6:41 AM Changeset in webkit [97615] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix after r97536, part 2

JSC::setUpStaticFunctionSlot with its new mangled name. SOrted the rest of the file while I
was at it.

6:40 AM Changeset in webkit [97614] by zecke@webkit.org
  • 2 edits in trunk/Tools

[build] Introduce Qt/SH4 buildbot
​https://bugs.webkit.org/show_bug.cgi?id=70227

Patch by Holger Hans Peter Freyther <​holger@moiji-mobile.com> on 2011-10-17
Reviewed by Adam Roben.

Add buildslave for Linux/Qt/SH4.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
6:39 AM Changeset in webkit [97613] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: don't check for debugger pause details in interactive ui tests
​https://bugs.webkit.org/show_bug.cgi?id=70228

Removed debugger pause details validation. The only check left is that debugger pause event is fired when expected.

Reviewed by Pavel Feldman.

  • src/js/Tests.js:

(.TestSuite.prototype.testPauseWhenLoadingDevTools):
(.TestSuite.prototype.testPauseWhenScriptIsRunning.didEvaluateInConsole):
(.TestSuite.prototype.testPauseWhenScriptIsRunning.testScriptPause):
(.TestSuite.prototype.testPauseWhenScriptIsRunning):
(.TestSuite.prototype.testPauseInSharedWorkerInitialization):
(.TestSuite.prototype._waitForScriptPause):

6:25 AM Changeset in webkit [97612] by Adam Roben
  • 2 edits in trunk/WebKitLibraries

Windows build fix

Here's the error:

5>c:\cygwin\home\buildbot\slave\win-release\build\webkitbuild\release\obj\webcore\derivedsources\jssvgpathsegcurvetoquadraticrel.cpp(128) : fatal error C1128: number of sections exceeded object file format limit : compile with /bigobj

  • win/tools/vsprops/common.vsprops: Specify /bigobj to the compiler.
6:21 AM Changeset in webkit [97611] by mnaganov@chromium.org
  • 20 edits in trunk

Web Inspector: [Chromium] Add an ability to look up and explore an object from a heap profile.
​https://bugs.webkit.org/show_bug.cgi?id=61179

This is exteremely helpful when dealing with DOM wrappers, as
their properties are mostly implemented with getters and thus not
stored in heap snapshots.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • bindings/js/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::objectByHeapObjectId):

  • bindings/js/ScriptProfiler.h:
  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::objectByHeapObjectId):

  • bindings/v8/ScriptProfiler.h:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::create):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):

  • inspector/InspectorProfilerAgent.h:
  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.queryObjectContent):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent.else.formatResult):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._showObjectPopover):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get canBeQueried):
(WebInspector.HeapSnapshotNode.prototype.get flags):
(WebInspector.HeapSnapshotNode.prototype.get isDOMWindow):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype._flagsOfNode):
(WebInspector.HeapSnapshot.prototype._calculateFlags):
(WebInspector.HeapSnapshot.prototype.updateStaticData):
(WebInspector.HeapSnapshotNodesProvider.prototype._serialize):

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotProxy.prototype.get nodeFlags):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.fromError):

  • inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view tr:not(.selected) td.object-column span.highlight):

  • inspector/profiler/heap-snapshot-expected.txt:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
(initialize_HeapSnapshotTest):

  • inspector/profiler/heap-snapshot.html:
5:58 AM Changeset in webkit [97610] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix after r97536

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed export of

JSC::setUpStaticFunctionSlot, which no longer exists. Also removed incorrect exports of
s_info members, which need to be exported via JS_EXPORTDATA instead.

5:53 AM Changeset in webkit [97609] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Remove reference to third_party/skia/gpu.
It was removed from Chromium DEPS in Chromium r105526.

  • DEPS:
5:41 AM BuildingQt5OnHarmattan edited by Christian Sejersen
(diff)
5:41 AM Changeset in webkit [97608] by jesus@webkit.org
  • 5 edits in trunk/Source/WebKit2

[Qt][WK2] Implement decidePolicyForResponse in our PolicyClient
​https://bugs.webkit.org/show_bug.cgi?id=69832

Reviewed by Kenneth Rohde Christiansen.

We implement decidePolicyForResponse in our PolicyClient in order to
decide whether a given ResourceResponse should be downloaded or loaded.

  • Shared/qt/WebCoreArgumentCodersQt.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):
Implement serialization of ResourceResponse.

  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_decidePolicyForResponse):

  • UIProcess/qt/ClientImpl.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init):

5:38 AM BuildingQt5OnHarmattan edited by Christian Sejersen
(diff)
5:35 AM Changeset in webkit [97607] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
4:46 AM Changeset in webkit [97606] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Editing CSS selector doesn't fire onResourceContentCommitted
​https://bugs.webkit.org/show_bug.cgi?id=70018

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/styles/commit-selector.html

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
(WebInspector.CSSStyleModel.prototype.setRuleSelector):

LayoutTests:

  • inspector/styles/commit-selector-expected.txt: Added.
  • inspector/styles/commit-selector.html: Added.
4:38 AM Changeset in webkit [97605] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

CSS/XSLStyleSheet: Remove insert() and remove().
​https://bugs.webkit.org/show_bug.cgi?id=70226

Reviewed by Antti Koivisto.

Remove insert() and remove() from XSLStyleSheet. CSSStyleSheet retains remove()
since it's used by InspectorStyleSheet as well as SVGFontFaceElement.

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::remove):

Remove range check. This method is internal to WebKit and the call sites
already take care of it.

(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):

  • css/CSSStyleSheet.h:
  • xml/XSLStyleSheet.h:
4:16 AM Changeset in webkit [97604] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
​https://bugs.webkit.org/show_bug.cgi?id=70224

  • platform/chromium/test_expectations.txt:

Mark some tests failing until bots have test results.

4:09 AM Changeset in webkit [97603] by commit-queue@webkit.org
  • 2 edits in trunk

[webkit]Debug Build Bot failure
​https://bugs.webkit.org/show_bug.cgi?id=70222

Patch by Vamshikrishna Yellenki <​vamshi@motorola.com> on 2011-10-17
Reviewed by Xan Lopez.

  • Source/autotools/symbols.filter: Corrected the filter name for getLocationAndLengthFronRange
3:38 AM Changeset in webkit [97602] by Antti Koivisto
  • 17 edits in trunk/LayoutTests

Make more :visited pseudo class tests work
​https://bugs.webkit.org/show_bug.cgi?id=70224

Reviewed by Andreas Kling.

Link <a href=""> is always considered visited so we can use that in tests that try to apply :visited.

Mac results only, requires rebaselining of other platforms.

  • css3/selectors3/html/css3-modsel-17.html:
  • css3/selectors3/html/css3-modsel-61.html:
  • css3/selectors3/xhtml/css3-modsel-17.xml:
  • css3/selectors3/xhtml/css3-modsel-61.xml:
  • css3/selectors3/xml/css3-modsel-17.xml:
  • css3/selectors3/xml/css3-modsel-61.xml:
  • fast/selectors/017.html:
  • fast/selectors/061.html:
  • platform/mac/css3/selectors3/html/css3-modsel-17-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-61-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-17-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-61-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-17-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-61-expected.txt:
  • platform/mac/fast/selectors/017-expected.txt:
  • platform/mac/fast/selectors/061-expected.txt:
3:24 AM Changeset in webkit [97601] by Csaba Osztrogonác
  • 1 edit
    4 deletes in trunk/LayoutTests

[Qt] Unreviewed gardening after r97598. Remove obsolete Qt 4.8 specific expected results.

  • platform/qt-4.8/tables/mozilla/bugs/bug7342-expected.png: Removed.
  • platform/qt-4.8/tables/mozilla/bugs/bug7342-expected.txt: Removed.
  • platform/qt-4.8/tables/mozilla/bugs/bug8950-expected.png: Removed.
  • platform/qt-4.8/tables/mozilla/bugs/bug8950-expected.txt: Removed.
3:23 AM Changeset in webkit [97600] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
​https://bugs.webkit.org/show_bug.cgi?id=70219

  • platform/chromium/test_expectations.txt:

Mark some tests failing until bots have test results.

3:03 AM Changeset in webkit [97599] by Csaba Osztrogonác
  • 1 edit
    6 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/fast/borders/border-radius-complex-inner-expected.png: Added after r97318.
  • platform/qt/fast/borders/border-radius-complex-inner-expected.txt: Added after r97318.
  • platform/qt/fast/css/clip-text-in-scaled-div-expected.png: Added after r97481.
  • platform/qt/fast/css/clip-text-in-scaled-div-expected.txt: Added after r97481.
  • platform/qt/fast/repaint/region-painting-via-layout-expected.png: Added after r97370.
  • platform/qt/fast/repaint/region-painting-via-layout-expected.txt: Added after r97370.
2:51 AM Changeset in webkit [97598] by Csaba Osztrogonác
  • 19 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r97596.

  • platform/qt/css2.1/t0511-c21-pseud-link-02-e-expected.png:
  • platform/qt/css2.1/t0511-c21-pseud-link-02-e-expected.txt:
  • platform/qt/css2.1/t0511-c21-pseud-link-03-e-expected.png:
  • platform/qt/css2.1/t0511-c21-pseud-link-03-e-expected.txt:
  • platform/qt/fast/block/float/float-in-float-hit-testing-expected.png:
  • platform/qt/fast/block/float/float-in-float-hit-testing-expected.txt:
  • platform/qt/fast/history/visited-link-background-color-expected.png:
  • platform/qt/fast/history/visited-link-background-color-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug26553-expected.png:
  • platform/qt/tables/mozilla/bugs/bug26553-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46623-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46623-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug51140-expected.png:
  • platform/qt/tables/mozilla/bugs/bug51140-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug8950-expected.png:
  • platform/qt/tables/mozilla/bugs/bug8950-expected.txt:
2:18 AM Changeset in webkit [97597] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

when CSS pseudo selectors are applied (:before and :after) the *-of-line keyboard navigation does not work
​https://bugs.webkit.org/show_bug.cgi?id=10123

Patch by Rosen Dash <​rosen.dash@motorola.com> on 2011-10-17
Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch addresses folllowing two issues:

  1. When CSS pseudo elements are before or after is used with content attribute containing single character at the start/end of text and we try to move cursor by right navigation key, the page freezes falling into an infinite loop.
  2. When these elements try to insert some text between a text line, navigation by right/left arrow key is prohibited.

Tests: editing/selection/css-pseudo-element-hang.html

editing/selection/css-pseudo-element.html

  • editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate):

LayoutTests:

  • editing/selection/css-pseudo-element-expected.txt: Added.
  • editing/selection/css-pseudo-element-hang-expected.txt: Added.
  • editing/selection/css-pseudo-element-hang.html: Added.
  • editing/selection/css-pseudo-element.html: Added.
2:15 AM Changeset in webkit [97596] by Antti Koivisto
  • 14 edits in trunk

Test :visited pseudo class
​https://bugs.webkit.org/show_bug.cgi?id=70219

Source/WebCore:

Reviewed by Andreas Kling.

Currently DRT doesn't support :visited. All tests where it should match have wrong checked in results.

  • Make <a href=""> to match :visited in DRT. It already does on browsers. A number of existing tests for :visited use it already, the rest can be modified to use it.
  • Make render tree dumps correctly dump the visited state dependent color.
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::determineLinkStateSlowCase):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

LayoutTests:

Reviewed by Andreas Kling.

Update Mac results for tests that already use <a href="">.

All other platforms need rebaselining too.

  • platform/mac/css2.1/t0511-c21-pseud-link-02-e-expected.txt:
  • platform/mac/css2.1/t0511-c21-pseud-link-03-e-expected.txt:
  • platform/mac/fast/dom/34176-expected.txt:
  • platform/mac/fast/events/reveal-link-when-focused-expected.txt:
  • platform/mac/fast/history/visited-link-background-color-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug26553-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46623-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51140-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug8950-expected.txt:
2:04 AM Changeset in webkit [97595] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] test expectation update
​https://bugs.webkit.org/show_bug.cgi?id=69624

  • platform/chromium/test_expectations.txt:

Correct expectation of zoom-animator-scale-test2.html.

2:02 AM Changeset in webkit [97594] by satish@chromium.org
  • 3 edits in trunk/Source/WebCore

Avoid leaking document when leaving google.com due to geolocation
permission request.
​https://bugs.webkit.org/show_bug.cgi?id=58027

Reviewed by Kenneth Rohde Christiansen.

  • page/Geolocation.cpp:

(WebCore::Geolocation::Watchers::find): added
(WebCore::Geolocation::reset): cleared all pending notifiers.
(WebCore::Geolocation::clearWatch): removed from pending notifier set.

  • page/Geolocation.h:

(WebCore::Geolocation::Watchers::find): added

2:01 AM Changeset in webkit [97593] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Interpreter build fix after r97436, r97506, r97532 and r97537.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

1:58 AM Changeset in webkit [97592] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WebKit2][gtk] Rename WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL to WEBKIT_POLICY_ERROR_CANNOT_SHOW_URI
​https://bugs.webkit.org/show_bug.cgi?id=70040

Patch by Nayan Kumar K <​nayankk@motorola.com> on 2011-10-17
Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitError.cpp:
  • UIProcess/API/gtk/WebKitError.h:
12:51 AM Changeset in webkit [97591] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix clang WebKitGTK+ build.

Patch by Andrei Lavreniyuk <​andy.lavr@gmail.com> on 2011-10-17
Reviewed by Martin Robinson.

  • plugins/gtk/PluginViewGtk.cpp:
12:20 AM Changeset in webkit [97590] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectation.
​https://bugs.webkit.org/show_bug.cgi?id=70013

  • platform/chromium/test_expectations.txt:

Add more cavas test crashes on Windows GPU.

Note: See TracTimeline for information about the timeline view.