⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 19, 2011:

11:47 PM Changeset in webkit [97943] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardning.

11:39 PM Changeset in webkit [97942] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG ConvertThis emits slow code when the source node is known to be,
but not predicted to be, a final object
​https://bugs.webkit.org/show_bug.cgi?id=70466

Reviewed by Oliver Hunt.

Added a new case in ConvertThis compilation.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

11:36 PM Changeset in webkit [97941] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Test expectation change for platform/chromium/compositing/zoom-animator-scale-test2.html

Unreviewed.

  • platform/chromium/test_expectations.txt:
11:33 PM Changeset in webkit [97940] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Optimization triggers in the old JIT may sometimes fire repeatedly even
though there is no optimization to be done
​https://bugs.webkit.org/show_bug.cgi?id=70467

Reviewed by Oliver Hunt.

If optimize_from_ret does nothing, it delays the next optimization trigger.
This is performance-neutral.

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Heuristics.cpp:

(JSC::Heuristics::initializeHeuristics):

11:02 PM Changeset in webkit [97939] by haraken@chromium.org
  • 9 edits in trunk

MessageEvent.data can be stored as ScriptValue.
​https://bugs.webkit.org/show_bug.cgi?id=68978

Reviewed by Hajime Morita.

Source/WebCore:

Currently, the following test cases fail or crash:

  • shouldBe("new MessageEvent('eventType', { data: test_object }).data", "test_object") -> FAIL
  • new MessageEvent('eventType', { data: document }).data -> CRASH

This is because MessageEvent.data is implemented just as SerializedScriptValue
and it cannot keep ScriptValue passed by JavaScript. This patch makes the following changes:

  • If MessageEvent is constructed with ScriptValue, it is stored as ScriptValue internally.

When MessageEvent.data is called, the ScriptValue is returned.

  • If MessageEvent is constructed with SerializedScriptValue, it is stored as

SerializedScriptValue internally (since we cannot deserialize it into ScriptValue
at this point because of lack of ExecState). When MessageEvent.data is called,
the SerializedScriptValue is deserialized into the corresponding ScriptValue,
and the ScriptValue is returned.

This patch does not make a fix for ObjC bindings code, since we need to first fix
the bug 28774, as commented in dom/MessageEvent.h and dom/MessageEvent.cpp.

Test: fast/events/constructors/message-event-constructor.html

fast/dom/message-port-deleted-by-accessor.html
fast/events/init-events.html
fast/eventsource/eventsource-attribute-listeners.html

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data): Custom getter for MessageEvent.data. Supported ScriptValue.
(WebCore::JSMessageEvent::handleInitMessageEvent): Changed SerializedScriptValue to ScriptValue. Removed a 'doTransfer' parameter.
(WebCore::JSMessageEvent::initMessageEvent): Removed a 'doTransfer' parameter.
(WebCore::JSMessageEvent::webkitInitMessageEvent): Ditto.

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter): Custom getter for MessageEvent.data. Supported ScriptValue.
(WebCore::V8MessageEvent::portsAccessorGetter): Removed extra spaces.
(WebCore::V8MessageEvent::initMessageEventCallback): Changed SerializedScriptValue to ScriptValue.

  • dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent): Supported ScriptValue.
(WebCore::MessageEvent::initMessageEvent): Supported ScriptValue.
(WebCore::MessageEvent::isMessageEvent): Removed extra spaces.

  • dom/MessageEvent.h: Added DataType::DataTypeScriptValue.

(WebCore::MessageEvent::create): Supported ScriptValue.
(WebCore::MessageEvent::dataAsScriptValue): Getter for data. Insert ASSERT() to guarantee that this accessor is not called for unintended type of data.
(WebCore::MessageEvent::dataAsSerializedScriptValue): Ditto.
(WebCore::MessageEvent::dataAsString): Ditto.
(WebCore::MessageEvent::dataAsBlob): Ditto.
(WebCore::MessageEvent::dataAsArrayBuffer): Ditto.

  • dom/MessageEvent.idl: Changed SerializedScriptValue to DOMObject (i.e. ScriptValue). This patch does not touch an ObjC part. Removed [CachedAttribute] from MessageEvent.data, since it is now a DOMObject and needs not to be cached.

LayoutTests:

Removed failures and crashes.

  • fast/events/constructors/message-event-constructor-expected.txt:
  • fast/events/constructors/message-event-constructor.html:
10:19 PM Changeset in webkit [97938] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to fix GTK build.

  • GNUmakefile.am:
10:16 PM Changeset in webkit [97937] by abarth@webkit.org
  • 1 edit
    1 copy in trunk/Source/WebCore

Rolled over to ChangeLog-2011-10-19

10:11 PM Changeset in webkit [97936] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Another attempted build fix. I managed to screw up every line of this file.

  • CodeGenerators.pri:
10:03 PM Changeset in webkit [97935] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Revert test expectaion change by 97932.

Unreviewed.

  • platform/chromium/test_expectations.txt:
10:03 PM Changeset in webkit [97934] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to fix the Qt build.

  • CodeGenerators.pri:
9:50 PM Changeset in webkit [97933] by abarth@webkit.org
  • 13 edits
    3 adds in trunk/Source

Document.cpp shouldn't need to know about every event for every feature
​https://bugs.webkit.org/show_bug.cgi?id=70469

Reviewed by Eric Seidel.

make_event_factory.pl generates the implementation of EventFactory
based on a simple ".in" file.

  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_makenames.py:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::createEvent):

  • dom/EventFactory.h: Added.
  • dom/EventFactory.in: Added.
  • dom/make_event_factory.pl: Added.

(defaultEventPropertyHash):
(eventHandler):
(parametersHandler):
(readNames):
(readEvents):
(interfaceForEvent):
(printCppFile):
(printLicenseHeader):

9:43 PM Changeset in webkit [97932] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Test expectation change for platform/chromium/compositing/zoom-animator-scale-test2.html

Unreviewed.

  • platform/chromium/test_expectations.txt:
9:22 PM Changeset in webkit [97931] by eric@webkit.org
  • 6 edits in trunk/Tools

Reviewed by Adam Barth.

Teach new-run-webkit-tests about #CRASHED and #CRASHED - WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=63683

  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/common/net/resultsjsonparser.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
9:03 PM Changeset in webkit [97930] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

WebSocket layout tests are flaky on Chromium Win
​https://bugs.webkit.org/show_bug.cgi?id=66730

Reviewed by Mihai Parparita.

Remove test expectations for WebSocket tests which have not been failing since
TcpClientSocketWin fix on Chromium (​http://crrev.com/104852).

  • platform/chromium/test_expectations.txt:
8:53 PM Changeset in webkit [97929] by haraken@chromium.org
  • 14 edits in trunk/Source/WebCore

Added a ConstructorMode check to all existing custom V8 constructors.
​https://bugs.webkit.org/show_bug.cgi?id=70464

Reviewed by Adam Barth.

This patch adds the following two lines to all existing custom V8 constructors:

if (ConstructorMode::current() == ConstructorMode::WrapExistingObject)

return args.Holder();

This checks whether a programmer is trying to allocate an object via "new X",
or C++ is trying to allocate an object via the function template and wrap the
object with a JS flavor. (See here for more details: bug 70015) In the latter case,
a constructor callback should not be executed (i.e. should return immediately).

No new tests. No change in behavior.

  • bindings/v8/custom/V8ArrayBufferCustom.cpp: Added the ConstructorMode check.

(WebCore::V8ArrayBuffer::constructorCallback):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h: Ditto.

(WebCore::constructWebGLArray):

  • bindings/v8/custom/V8AudioContextCustom.cpp: Ditto.

(WebCore::V8AudioContext::constructorCallback):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp: Ditto.

(WebCore::V8DOMFormData::constructorCallback):

  • bindings/v8/custom/V8DataViewCustom.cpp: Ditto.

(WebCore::V8DataView::constructorCallback):

  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: Ditto.

(WebCore::v8HTMLAudioElementConstructorCallback):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: Ditto.

(WebCore::v8HTMLImageElementConstructorCallback):

  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: Ditto.

(WebCore::v8HTMLOptionElementConstructorCallback):

  • bindings/v8/custom/V8MessageChannelConstructor.cpp: Ditto.

(WebCore::V8MessageChannel::constructorCallback):

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp: Ditto.

(WebCore::V8WebKitMutationObserver::constructorCallback):

  • bindings/v8/custom/V8WebKitPointConstructor.cpp: Ditto.

(WebCore::V8WebKitPoint::constructorCallback):

  • bindings/v8/custom/V8WebSocketCustom.cpp: Ditto.

(WebCore::V8WebSocket::constructorCallback):

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: Ditto.

(WebCore::V8XMLHttpRequest::constructorCallback):

8:32 PM Changeset in webkit [97928] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

DFG JIT 32_64 - remove unnecessary double unboxings in fillDouble/fillSpeculateDouble
​https://bugs.webkit.org/show_bug.cgi?id=70460

Patch by Yuqiang Xian <​yuqiang.xian@intel.com> on 2011-10-19
Reviewed by Filip Pizlo.

As pointed out by Gavin in bug #70418, when a value is already in memory
we can avoid loading it to two GPRs at first and then unboxing them to a FPR.
This gives 9% improvement on Kraken if without the change in bug #70418,
and 1% if based on the code with bug #70418 change.
Performance is neutral in V8 and SunSpider.

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::fillDouble):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

8:16 PM Changeset in webkit [97927] by carol@webkit.org
  • 4 edits
    2 adds in trunk

CSS Counters have wrong values
​https://bugs.webkit.org/show_bug.cgi?id=69605

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/counters/after-continuation.html

Added a new method for getting the renderer of the "after"
pseudo-element that handles continuations.
Hooked up the new method with the CSS counter code.

  • rendering/RenderCounter.cpp:

(WebCore::rendererOfAfterPseudoElement):
(WebCore::previousInPreOrder):
(WebCore::nextInPreOrder):

  • rendering/RenderObject.h:

LayoutTests:

This test highlights the ability of the CSS counter handling code to
find a counter attached to a continuation of a renderer.

  • fast/css/counters/after-continuation-expected.txt: Added.
  • fast/css/counters/after-continuation.html: Added.
7:53 PM Changeset in webkit [97926] by annacc@chromium.org
  • 24 edits
    3 copies
    2 adds in trunk/Source/WebCore

Adding some IDL files for <track>.
​https://bugs.webkit.org/show_bug.cgi?id=62887

Reviewed by Adam Barth.

Tests:
MutableTextTrack.idl and addTrack() in HTMLMediaElement.idl are tested by:
media/track/track-mutable.html

TextTrack.idl is tested by:
media/track/track-text-track.html

TextTrackCue.idl is tested by:
media/track/track-webvtt-tc006-cue-identifiers.html
media/track/track-webvtt-tc007-cue-no-id.html
media/track/track-webvtt-tc008-timings-no-hours.html
media/track/track-webvtt-tc009-timings-hour.html
media/track/track-webvtt-tc013-settings.html
media/track/track-webvtt-tc023-markup.html

TextTrackCueList.idl is tested by:
media/track/track-text-track-cue-list.html

  • CMakeLists.txt: Adding files to build systems.
  • CodeGenerators.pri: Adding files to build systems.
  • DerivedSources.cpp: Adding files to build systems.
  • DerivedSources.make: Adding files to build systems.
  • GNUmakefile.list.am: Adding files to build systems.
  • WebCore.gypi: Adding files to build systems.
  • WebCore.pro: Adding files to build systems.
  • WebCore.xcodeproj/project.pbxproj: Adding files to build systems.
  • bindings/gobject/GNUmakefile.am: Adding files to build systems.
  • bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Adding files to build systems.
  • bindings/js/JSBindingsAllInOne.cpp: Adding files to build systems.
  • bindings/js/JSTextTrackCustom.cpp: Added.

(WebCore::toJS):

  • bindings/scripts/CodeGeneratorV8.pm:

(HasCustomToV8Implementation): Special check for TextTrack since V8 can auto-generate
it, but JS cannot yet.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::addTrack): creates and returns a new MutableTextTrack.

  • html/HTMLMediaElement.h: Adding addTrack() function.
  • html/HTMLMediaElement.idl: Adding addTrack() function.
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::track): Adding track getter.

  • html/HTMLTrackElement.h: Adding track getter.
  • html/HTMLTrackElement.idl: Adding track getter.
  • html/MutableTextTrack.idl: Added.
  • html/TextTrack.idl: Added.
  • html/TextTrackCue.idl: Added.
  • html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::length):
(WebCore::TextTrackCueList::item): Used for [] operator.

  • html/TextTrackCueList.h: Added item() for [] operator.
  • html/TextTrackCueList.idl: Added.
  • page/DOMWindow.idl: Adding TextTrackCue new operator.
7:48 PM Changeset in webkit [97925] by arv@chromium.org
  • 28 edits
    1 delete in trunk/LayoutTests

Clean up tests to not depend on js-test-style.css
​https://bugs.webkit.org/show_bug.cgi?id=70462

Reviewed by Ojan Vafai.

  • fast/css/limited-vendor-prefix-behavior.html-disabled:
  • fast/css/link-disabled-attr-expected.txt:
  • fast/css/link-disabled-attr.html:
  • fast/dom/Geolocation/page-reload-cancel-permission-requests.html:
  • fast/dom/SelectorAPI/caseTagX.xhtml:
  • fast/dom/StyleSheet/detached-parent-rule-without-wrapper.html:
  • fast/dom/StyleSheet/detached-style-pi.xhtml:
  • fast/dom/StyleSheet/detached-stylesheet-without-wrapper.html:
  • fast/dom/StyleSheet/gc-declaration-parent-rule.html:
  • fast/dom/StyleSheet/gc-parent-rule.html:
  • fast/dom/StyleSheet/gc-parent-stylesheet.html:
  • fast/dom/StyleSheet/gc-styleheet-wrapper.xhtml:
  • fast/dom/Window/window-resize-nan.html-disabled:
  • fast/dom/dataset-xhtml.xhtml:
  • fast/dom/domListEnumeration-expected.txt:
  • fast/dom/domListEnumeration.html:
  • fast/dom/script-tests/domListEnumeration.js:
  • fast/dom/script-tests/webtiming-document-open.js:

(testTimingWithDocumentOpen):

  • fast/dom/title-content-set-innerText-get.xhtml:
  • fast/forms/focus-selection-input.html:
  • fast/forms/focus-selection-textarea.html:
  • fast/forms/option-value-trim-html-spaces.html:
  • fast/js/garbage-collect-after-string-appends.html-disabled:
  • fast/js/kde/Date.html-disabled:
  • fast/js/string-concatenate-outofmemory.html-disabled:
  • fast/mutation/observe-attributes.html:
  • fast/mutation/observe-characterdata.html:
  • platform/chromium/fast/dom/domListEnumeration-expected.txt: Removed.
7:42 PM Changeset in webkit [97924] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[chromium] Fix webkit style on a few files.
​https://bugs.webkit.org/show_bug.cgi?id=70441

Patch by Shawn Singh <​shawnsingh@chromium.org> on 2011-10-19
Reviewed by James Robinson.

Tested with existing layout and unit tests.

  • platform/graphics/chromium/LayerChromium.cpp:
  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setIsMask):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/LayerRendererChromium.h:
7:28 PM Changeset in webkit [97923] by jochen@chromium.org
  • 2 edits in trunk/Tools

Chromium doesn't support git branch builds, so don't add the branch to the product dir
​https://bugs.webkit.org/show_bug.cgi?id=70449

Reviewed by Eric Seidel.

  • Scripts/webkitdirs.pm:

(determineBaseProductDir):

7:23 PM Changeset in webkit [97922] by nduca@chromium.org
  • 14 edits in trunk/Source

[chromium] Route requestAnimationFrame through CCProxy in threaded mode
​https://bugs.webkit.org/show_bug.cgi?id=70160

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setNeedsAnimate):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCProxy.h:
  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::requestAnimate):

  • platform/graphics/chromium/cc/CCScheduler.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setNeedsAnimate):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setNeedsAnimate):
(WebCore::CCThreadProxy::setNeedsAnimateOnCCThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::scheduleAnimation):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::scheduleAnimation):

  • src/WebViewImpl.h:
7:15 PM Changeset in webkit [97921] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium/mac] Use clang as compiler!
​https://bugs.webkit.org/show_bug.cgi?id=70425

Reviewed by Adam Barth.

It looks like ​http://trac.webkit.org/changeset/97415 was all that's
needed to get this to work.

  • gyp_webkit:

Don't force clang off, which means it's now on by default on mac.

7:14 PM Changeset in webkit [97920] by Martin Robinson
  • 10 edits
    1 copy in trunk/Source/WebKit2

[GTK] [WebKit2] Allow sharing page clients between WebViews
​https://bugs.webkit.org/show_bug.cgi?id=69814

No longer associate WebPage client wrappers with a WebKitWebView. This allows the
same client to be used with more than one WebKitWebView.

Reviewed by Xan Lopez.

  • GNUmakefile.am: Add the new WebKitWebViewPrivate header.
  • UIProcess/API/gtk/WebKitDefines.h: Added some forward declarations for API classes.
  • UIProcess/API/gtk/WebKitWebLoaderClient.cpp: C API callbacks now convert their WKPageRef argument

into a WebKitWebView directly and pass it as a parameter to signals. Remove the web-view property.

  • UIProcess/API/gtk/WebKitWebLoaderClient.h: Move the estimated-progress property to WebKitWebView.
  • UIProcess/API/gtk/WebKitWebView.cpp: Add an estimated-load-progress property.

(webkitWebViewConstructed):Only allocate one default WebKitWebLoaderClient.
(webkitWebViewGetProperty): Add support for the new property.
(webkit_web_view_class_init): Ditto.
(webkitWebViewSetEstimatedLoadProgress): Added this private method so that the WebKitWebLoaderClient
can update the appropriate WebKitWebView.
(webkit_web_view_set_loader_client): Attach the C API callbacks here now.
(webkit_web_view_get_estimated_load_progress): Moved from WebKitWebLoaderClient.

  • UIProcess/API/gtk/WebKitWebView.h: Added new method definition.
  • UIProcess/API/gtk/WebKitWebViewPrivate.h: Copied from Source/WebKit2/UIProcess/API/gtk/WebKitDefines.h.
  • UIProcess/API/gtk/tests/LoadTrackingTest.cpp: Updated the load tracking tests callbacks to take the new parameter.

(LoadTrackingTest::LoadTrackingTest): Listen to the WebKitWebView property now.
(LoadTrackingTest::estimatedProgressChanged):

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp: Added a test to verify that two WebViews share the same default client.
  • UIProcess/API/gtk/webkit2marshal.list: Updated the marshallers here.
7:13 PM Changeset in webkit [97919] by yuzo@google.com
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

[chromium] Test expectation change.

Unreviewed.

  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png.
7:12 PM Changeset in webkit [97918] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Reject invalid MIME type strings for a file selection dialog parameter
​https://bugs.webkit.org/show_bug.cgi?id=70095

Reviewed by Darin Fisher and Darin Adler.

No new tests. This affect only a value passed to WebKit layer.

  • html/HTMLInputElement.cpp:

(WebCore::isRFC2616TokenCharacter): Added.
(WebCore::HTMLInputElement::acceptMIMETypes):
Validate a MIME type string, and don't add invalid strings to the output Vector.

7:08 PM Changeset in webkit [97917] by Darin Adler
  • 13 edits in trunk/Source

Remove OptionElement (first half)
​https://bugs.webkit.org/show_bug.cgi?id=70276

Reviewed by Kent Tamura.

Source/WebCore:

Refactoring that does not require new tests.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector): Use hasTagName
and toHTMLOptionElement instead of toOptionElement.

  • dom/OptionElement.cpp: Deleted contents. Remove file later.
  • dom/OptionElement.h: Ditto.
  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::HTMLOptionElement): Initialize m_isSelected.
(WebCore::HTMLOptionElement::createForJSConstructor): Initialize the
selected attribute rather than calling setDefaultSelected.
(WebCore::HTMLOptionElement::text): Moved the code here from
OptionElement::collectOptionLabelOrText.
(WebCore::HTMLOptionElement::index): Moved the code here from
OptionElement::optionIndex.
(WebCore::HTMLOptionElement::parseMappedAttribute): Removed unneeded
code to call setValue and setLabel. Changed the code that called
setSelected to instead set m_isSelected and added a FIXME about why
that's probably wrong, but same behavior as before.
(WebCore::HTMLOptionElement::value): Moved the code here from
OptionElement::collectOptionValue. Added a FIXME about incorrect
whitespace stripping.
(WebCore::HTMLOptionElement::selected): Use m_isSelected.
(WebCore::HTMLOptionElement::setSelected): Use m_isSelected and
call setSelectedState instead of OptionElement::setSelectedState.
(WebCore::HTMLOptionElement::setSelectedState): Moved the code
here from OptionElement::setSelectedState.
(WebCore::HTMLOptionElement::label): Streamlined the code.
(WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
Moved the code here from OptionElement::collectOptionTextRespectingGroupLabel.
(WebCore::HTMLOptionElement::insertedIntoTree): Use m_isSelected
and rewrote comment for clarity.
(WebCore::HTMLOptionElement::collectOptionInnerText): Moved this
here from OptionElement, and changed to use StringBuilder.
(WebCore::toHTMLOptionElement): Added.

  • html/HTMLOptionElement.h: Removed OptionElement.h include.

Removed OptionElement base class. Removed unneeded friend declarations.
Made value and selected functions non-virtual. Removed unneeded
defaultSelected and setDefaultSelected functions. Made the
textIndentedToRespectGroupLabel and setSelectedState functions
be non-virtual and public. Added a collectOptionInnerText function.
Replaced m_data with m_value, m_label, and m_selected.

  • html/HTMLSelectElement.cpp:

(WebCore::toOptionElement): Added. Helper to keep existing code
close to the same.
(WebCore::HTMLSelectElement::nextValidIndex): Use hasTagName
instead of isOptionElement.
(WebCore::HTMLSelectElement::saveLastSelection): Use HTMLOptionElement
type instead of OptionElement.
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): Ditto.
(WebCore::HTMLSelectElement::updateListBoxSelection): Ditto.
(WebCore::HTMLSelectElement::listBoxOnChange): Ditto.
(WebCore::HTMLSelectElement::recalcListItems): Ditto.
(WebCore::HTMLSelectElement::selectedIndex): Ditto.
(WebCore::HTMLSelectElement::setSelectedIndex): Ditto.
(WebCore::HTMLSelectElement::optionToListIndex): Ditto.
(WebCore::HTMLSelectElement::listToOptionIndex): Ditto.
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation): Ditto.
(WebCore::HTMLSelectElement::saveFormControlState): Ditto.
(WebCore::HTMLSelectElement::restoreFormControlState): Ditto.
(WebCore::HTMLSelectElement::appendFormData): Ditto.
(WebCore::HTMLSelectElement::reset): Ditto.
(WebCore::HTMLSelectElement::updateSelectedState): Ditto.
(WebCore::HTMLSelectElement::lastSelectedListIndex): Ditto.
(WebCore::HTMLSelectElement::typeAheadFind): Ditto.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Ditto.
(WebCore::HTMLSelectElement::length): Ditto.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement): Use HTMLOptionElement,
hasTagName, and toHTMLOptionElement.
(WebCore::RenderListBox::addFocusRingRects): Ditto.
(WebCore::RenderListBox::paintItemForeground): Ditto.
(WebCore::RenderListBox::paintItemBackground): Ditto.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::updateOptionsWidth): Ditto.
(WebCore::RenderMenuList::setTextFromOption): Ditto.
(WebCore::RenderMenuList::itemText): Ditto.
(WebCore::RenderMenuList::itemIsSelected): Ditto.

Source/WebKit/chromium:

Update hand-written binding for option element so it does not depend on otherwise-unneeded functions.

  • src/WebOptionElement.cpp:

(WebKit::WebOptionElement::defaultSelected): Call hasAttribute.
(WebKit::WebOptionElement::setDefaultSelected): Call setAttribute.

  • src/WebSearchableFormData.cpp:

(HTMLNames::IsSelectInDefaultState): Call hasAttribute.

7:06 PM Changeset in webkit [97916] by wjmaclean@chromium.org
  • 3 edits in trunk/LayoutTests

[chromium] Rebaseline layout test zoom-animator-scale-test2.html for win, mac
​https://bugs.webkit.org/show_bug.cgi?id=69624

Mark test as SLOW and increase test's internal timeout value to attempt to
eliminate flakiness on WIN GPU.

Reviewed by Kenneth Russell.

  • platform/chromium/compositing/zoom-animator-scale-test2.html:
  • platform/chromium/test_expectations.txt:
7:02 PM Changeset in webkit [97915] by ojan@chromium.org
  • 2 edits in trunk/Tools

Unreviewed. Adding myself to watchlists.

  • Scripts/webkitpy/common/config/watchlist:
7:02 PM Changeset in webkit [97914] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Fix typos on ewk_view and ewk_js.
​https://bugs.webkit.org/show_bug.cgi?id=70430

Unreviewed build fix.

Fixes for typos that were introduced when renaming variables to follow
webkit coding style.

Patch by Rafael Antognolli <​antognolli@profusion.mobi> on 2011-10-19

  • ewk/ewk_js.cpp:

(ewk_js_property_set):
(ewk_js_class_new):
(ewk_js_npobject_to_object):
(ewk_js_object_new):
(ewk_js_object_invoke):
(ewk_js_object_type_get):
(ewk_js_object_type_set):
(ewk_js_variant_free):

  • ewk/ewk_view.cpp:

(ewk_view_js_object_add):

6:54 PM Changeset in webkit [97913] by kov@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

GTK+ build fix. Rename the INCLUDES variable so it is not picked
up by random bystanders. Also do some more cleanup on stuff we
inherited from gtk-doc.make.

Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2011-10-19

  • GNUmakefile.gtk-doc.am:
  • docs/GNUmakefile.am:
6:52 PM Changeset in webkit [97912] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Flush denormals to zero on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=70140

Patch by Raymond Toy <Raymond Toy> on 2011-10-19
Reviewed by Kenneth Russell.

  • platform/audio/AudioBus.cpp:

(WebCore::AudioBus::processWithGainFromMonoStereo):
Flush any denormals to zero before saving the result. Change
double gain to float gain to match existing float operations.

  • platform/audio/DenormalDisabler.h:

(WebCore::DenormalDisabler::flushDenormalFloatToZero):
New function to flush the given float to zero, if it is a denormal
number.

6:51 PM Changeset in webkit [97911] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[EFL] Remove the empty paint() implementation in ScrollbarEfl.
​https://bugs.webkit.org/show_bug.cgi?id=70428

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-10-19
Reviewed by Antonio Gomes.

Remove the empty reimplementation of Scrollbar::paint(), as this would
cause ScrollView::paintScrollbars() to paint nothing at all.

If we have mock scrollbars enabled, this will paint them; otherwise,
the code path will end up in WidgetEfl::paint(), which also does
nothing, so the behavior should not change.

No new tests, this is machinery needed to run the current ones.

  • platform/efl/ScrollbarEfl.cpp:

(ScrollbarEfl::frameRectsChanged):

  • platform/efl/ScrollbarEfl.h:
6:47 PM Changeset in webkit [97910] by tkent@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium]: Move from FileChooserSettings deprecatedAcceptType to acceptMIMETypes
​https://bugs.webkit.org/show_bug.cgi?id=70003

Reviewed by Darin Fisher.

  • public/WebFileChooserParams.h:

Add acceptMIMETypes, and make acceptTypes deprecated.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::runOpenPanel):

  • Set WebFileChooserParams::acceptMIMETypes
  • Set a joined string to WebFileChooserParams::acceptTypes until we remove acceptTypes.
6:47 PM Changeset in webkit [97909] by imasaki@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update the test expectation file for fullscreen tests.

Unreviewed.

  • platform/chromium/test_expectations.txt:
6:39 PM Changeset in webkit [97908] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Do not always consider a ScrollView will have an Evas/Evas_Object.
​https://bugs.webkit.org/show_bug.cgi?id=70426

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-10-19
Reviewed by Antonio Gomes.

After r95234 turned on a new code path for the port (we erroneously used
ENABLE_AS_IMAGE instead of ENABLE_SVG_AS_IMAGE before), some tests, such
as compositing/image/direct-svg-image.html or
fast/writing-mode/block-level-images.html started writing stderr
messages about the parent passed to ScrollbarEfl::setParent not having
an Evas.

It turns out that a FrameView can be created in places other than
ewk_frame_view_create_for_view, in which case the view will not have an
Evas or an Evas_Object. This is not an error condition, so we can just
return earlier.

No new tests, this was detected by existing ones.

  • platform/efl/ScrollbarEfl.cpp:

(ScrollbarEfl::setParent):

6:36 PM Changeset in webkit [97907] by jchaffraix@webkit.org
  • 3 edits
    4 adds in trunk

Multiple crashes in RenderTable during layout
​https://bugs.webkit.org/show_bug.cgi?id=70392

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/table/crash-anonymous-table-computeLogicalWidth.html

fast/table/crash-anonymous-table-layout.html

r97555 forgot to take into account anonymous tables during layout
where RenderObject::node() is NULL.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::layout):
Added a check for node() before calling Node::hasTagName.

LayoutTests:

  • fast/table/crash-anonymous-table-computeLogicalWidth-expected.txt: Added.
  • fast/table/crash-anonymous-table-computeLogicalWidth.html: Added.
  • fast/table/crash-anonymous-table-layout-expected.txt: Added.
  • fast/table/crash-anonymous-table-layout.html: Added.
6:24 PM Changeset in webkit [97906] by dpranke@chromium.org
  • 3 edits
    2 copies
    2 moves
    3 adds
    10 deletes in trunk/LayoutTests

Update chromium expectations after r97889.

Unreviewed, expectations change.

  • platform/chromium-cg-mac-snowleopard/fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/fast/dom/error-to-string-stack-overflow-expected.txt: Removed.
  • platform/chromium-linux-x86/fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.
  • platform/chromium-linux-x86/fast/dom/error-to-string-stack-overflow-expected.txt: Removed.
  • platform/chromium-linux-x86/fast/parser/entity-end-script-tag-expected.txt: Removed.
  • platform/chromium-linux/fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.
  • platform/chromium-linux/fast/dom/error-to-string-stack-overflow-expected.txt: Removed.
  • platform/chromium-linux/fast/parser/entity-end-script-tag-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/call-a-constructor-as-a-function-expected.txt: Copied from LayoutTests/platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt.
  • platform/chromium-mac-snowleopard/fast/dom/error-to-string-stack-overflow-expected.txt: Copied from LayoutTests/platform/chromium/fast/dom/error-to-string-stack-overflow-expected.txt.
  • platform/chromium-mac-snowleopard/fast/parser/entity-end-script-tag-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/parser/entity-end-script-tag-expected.txt.
  • platform/chromium-mac/fast/parser/entity-end-script-tag-expected.txt: Removed.
  • platform/chromium-win/fast/parser/entity-end-script-tag-expected.txt: Removed.
  • platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt:
  • platform/chromium/fast/dom/error-to-string-stack-overflow-expected.txt:
  • platform/chromium/fast/parser/entity-end-script-tag-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/parser/entity-end-script-tag-expected.txt.
6:18 PM Changeset in webkit [97905] by barraclough@apple.com
  • 14 edits in trunk

Poisoning of strict caller,arguments inappropriately poisoning "in"
​https://bugs.webkit.org/show_bug.cgi?id=63398

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This fixes the problem by correctly implementing the spec -
the error should actually be being thrown from a standard JS getter/setter.
This implements spec correct behaviour for strict mode JS functions & bound
functions, I'll follow up with a patch to do the same for arguments.

  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::finishCreation):

  • Add the poisoned caller/arguments properties.
  • runtime/JSBoundFunction.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::put):

  • If the caller/arguments are accessed on a strict mode function, lazily add the ThrowTypeError getter.
  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::createThrowTypeError):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::throwTypeErrorGetterSetter):

  • Add a ThrowTypeError type, per ES5 13.2.3.
  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncThrowTypeError):

  • runtime/JSGlobalObjectFunctions.h:
    • Implementation of ThrowTypeError.
  • runtime/JSObject.cpp:

(JSC::JSObject::initializeGetterSetterProperty):

  • runtime/JSObject.h:
    • This function adds a new property (must not exist already) that is an initialized getter/setter.

LayoutTests:

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:
    • Add tests.
5:53 PM Changeset in webkit [97904] by commit-queue@webkit.org
  • 19 edits
    4 deletes in trunk/Source

Update MediaStream to use WebCore platform interfaces
​https://bugs.webkit.org/show_bug.cgi?id=68464

Patch by Adam Bergkvist <​adam.bergkvist@ericsson.com> on 2011-10-19
Reviewed by Adam Barth.

Source/WebCore:

This is one in a series of patches that update the MediaStream feature
to use WebCore platform interfaces.

Tests will be provided by ​http://webkit.org/b/56587

  • dom/LocalMediaStream.cpp:

(WebCore::LocalMediaStream::create):
(WebCore::LocalMediaStream::LocalMediaStream):
(WebCore::LocalMediaStream::stop):
(WebCore::LocalMediaStream::stopTimerFired):
(WebCore::LocalMediaStream::~LocalMediaStream):
(WebCore::LocalMediaStream::toLocalMediaStream):

  • dom/LocalMediaStream.h:
  • dom/LocalMediaStream.idl:
  • dom/MediaStream.cpp:

(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::~MediaStream):
(WebCore::MediaStream::readyState):
(WebCore::MediaStream::streamEnded):
(WebCore::MediaStream::scriptExecutionContext):

  • dom/MediaStream.h:

(WebCore::MediaStream::label):
(WebCore::MediaStream::tracks):
(WebCore::MediaStream::descriptor):

  • dom/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::kind):
(WebCore::MediaStreamTrack::label):
(WebCore::MediaStreamTrack::enabled):
(WebCore::MediaStreamTrack::setEnabled):

  • dom/MediaStreamTrack.h:
  • dom/MediaStreamTrack.idl:
  • dom/MediaStreamTrackList.cpp:

(WebCore::MediaStreamTrackList::create):
(WebCore::MediaStreamTrackList::MediaStreamTrackList):
(WebCore::MediaStreamTrackList::length):
(WebCore::MediaStreamTrackList::item):

  • dom/MediaStreamTrackList.h:
  • p2p/PeerConnection.cpp:

(WebCore::PeerConnection::addStream):
(WebCore::PeerConnection::removeStream):
(WebCore::PeerConnection::remoteStreamAdded):

  • page/MediaStreamClient.h:
  • page/MediaStreamController.cpp:

(WebCore::MediaStreamController::unregisterFrameController):
(WebCore::MediaStreamController::streamGenerated):

  • page/MediaStreamController.h:
  • page/MediaStreamFrameController.cpp:

(WebCore::MediaStreamFrameController::enterDetachedState):
(WebCore::MediaStreamFrameController::disconnectFrame):
(WebCore::MediaStreamFrameController::streamGenerated):

  • page/MediaStreamFrameController.h:

Source/WebKit/chromium:

Removed WebMediaStreamTrack* since they will no longer be needed.

  • WebKit.gyp:
  • public/WebMediaStreamTrack.h: Removed.
  • public/WebMediaStreamTrackList.h: Removed.
  • src/WebMediaStreamTrack.cpp: Removed.
  • src/WebMediaStreamTrackList.cpp: Removed.
5:48 PM Changeset in webkit [97903] by commit-queue@webkit.org
  • 7 edits in trunk/Source/JavaScriptCore

DFG JIT 32_64 - improve double boxing/unboxing
​https://bugs.webkit.org/show_bug.cgi?id=70418

Patch by Yuqiang Xian <​yuqiang.xian@intel.com> on 2011-10-19
Reviewed by Gavin Barraclough.

Double boxing/unboxing in DFG JIT 32_64 is currently implemented inefficiently,
which tries to exchange data through memory.
On X86 some SSE instructions can help us on such operations with better performance.
This improves 32-bit DFG performance by 29% on Kraken, 7% on SunSpider,
and 2% on V8, tested on Linux X86 (Core i7 Nehalem).

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::lshiftPacked):
(JSC::MacroAssemblerX86Common::rshiftPacked):
(JSC::MacroAssemblerX86Common::orPacked):
(JSC::MacroAssemblerX86Common::moveInt32ToPacked):
(JSC::MacroAssemblerX86Common::movePackedToInt32):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::movd_rr):
(JSC::X86Assembler::psllq_i8r):
(JSC::X86Assembler::psrlq_i8r):
(JSC::X86Assembler::por_rr):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::boxDouble):
(JSC::DFG::JITCodeGenerator::unboxDouble):

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeUInt32ToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::boxDouble):
(JSC::DFG::JITCompiler::unboxDouble):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::convertToDouble):
(JSC::DFG::SpeculativeJIT::compile):

5:44 PM Changeset in webkit [97902] by wjmaclean@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Shorten animation time for ZoomAnimator.
​https://bugs.webkit.org/show_bug.cgi?id=70419

Reviewed by Kenneth Russell.

Shorten animation time for ZoomAnimator.

Existing test coverage sufficient.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::zoom):

5:35 PM Changeset in webkit [97901] by kov@webkit.org
  • 7 edits
    1 add in trunk

[GTK] Streamline wk1 documentation build
​https://bugs.webkit.org/show_bug.cgi?id=70447

Reviewed by Martin Robinson.

.:

  • GNUmakefile.am: include the documentation's GNUmakefile.am;
  • autogen.sh: we no longer call gtkdocize, since we now ship a modified gtk-doc.make;
  • configure.ac: no longer generate a separate GNUmakefile for the documentation build.

Source/WebKit/gtk:

  • GNUmakefile.am: move files pertaining to the docs build to the docs GNUmakefile.am;
  • GNUmakefile.gtk-doc.make: incorporate the gtk-doc makefile, and customize it to our non-recursive build;
  • docs/GNUmakefile.am: simplification and adaption to work with the rest of the build system.
5:30 PM Changeset in webkit [97900] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/JavaScriptCore

[EFL] Fix DSO linkage of wtf_efl.

Unreviewed build fix.

Need to add -ldl to jsc_efl (requested by dladdr).

  • wtf/CMakeListsEfl.txt:
5:11 PM Changeset in webkit [97899] by arv@chromium.org
  • 3 edits in trunk/LayoutTests

Fix test breakage after r97881

  • fast/forms/file/file-input-change-event-expected.txt:
  • fast/forms/file/file-input-change-event.html:
5:08 PM Changeset in webkit [97898] by dpranke@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Add win baseline for new test.

Unreviewed, expectations change.

  • platform/chromium-win/fast/multicol/flipped-blocks-border-after-expected.png: Added.
5:01 PM Changeset in webkit [97897] by Beth Dakin
  • 5 edits in trunk/WebKitLibraries

Try to fix the Chromium build.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
4:58 PM Changeset in webkit [97896] by zmo@google.com
  • 23 edits
    6 adds in trunk/Source

Implement WEBGL_debug_shaders and WEBGL_debug_renderer_info extensions
​https://bugs.webkit.org/show_bug.cgi?id=70077

Reviewed by Kenneth Russell.

Source/WebCore:

  • WebCore.gypi: added new extension class files.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • WebCore.pro: ditto.
  • CMakeLists.txt: ditto.
  • GNUmakefile.list.am: ditto.
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS): Handles two new extensions.

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object): Ditto.

  • html/canvas/WebGLDebugRendererInfo.cpp: Added.

(WebCore::WebGLDebugRendererInfo::WebGLDebugRendererInfo):
(WebCore::WebGLDebugRendererInfo::~WebGLDebugRendererInfo):
(WebCore::WebGLDebugRendererInfo::getName):
(WebCore::WebGLDebugRendererInfo::create):

  • html/canvas/WebGLDebugRendererInfo.h: Added.
  • html/canvas/WebGLDebugRendererInfo.idl: Added.
  • html/canvas/WebGLDebugShaders.cpp: Added.

(WebCore::WebGLDebugShaders::WebGLDebugShaders):
(WebCore::WebGLDebugShaders::~WebGLDebugShaders):
(WebCore::WebGLDebugShaders::getName):
(WebCore::WebGLDebugShaders::create):
(WebCore::WebGLDebugShaders::getTranslatedShaderSource):

  • html/canvas/WebGLDebugShaders.h: Added.
  • html/canvas/WebGLDebugShaders.idl: Added.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::allowPrivilegedExtensions): To be implemented - deciding whether the two extensions should be allowed or not.
(WebCore::WebGLRenderingContext::getExtension): Handles two new extensions.
(WebCore::WebGLRenderingContext::getParameter): Handles UNMASKED_VENDOR_WEBGL / UNMASKED_RENDERER_WEBGL
(WebCore::WebGLRenderingContext::getSupportedExtensions): Handles two new extensions.

  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/Extensions3D.h: Ditto.
  • platform/graphics/GraphicsTypes3D.h: Add GC3Dchar.
  • platform/graphics/chromium/Extensions3DChromium.h: Handles two new extensions.
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: Ditto.

(WebCore::getTranslatedShaderSourceANGLE):

  • platform/graphics/opengl/Extensions3DOpenGL.h: Ditto.
  • platform/graphics/qt/Extensions3DQt.cpp: Ditto.

(WebCore::Extensions3DQt::getTranslatedShaderSourceANGLE):

  • platform/graphics/qt/Extensions3DQt.h: Ditto.

Source/WebKit/chromium:

  • public/WebGraphicsContext3D.h: Added support for getTranslatedShaderSourceANGLE.

(WebKit::WebGraphicsContext3D::getTranslatedShaderSourceANGLE):

  • src/Extensions3DChromium.cpp: Ditto.

(WebCore::Extensions3DChromium::getTranslatedShaderSourceANGLE):

  • src/GraphicsContext3DChromium.cpp: Ditto.
  • src/GraphicsContext3DPrivate.h: Ditto.
4:58 PM Changeset in webkit [97895] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

White flash when painting a previously crashed WKView
​https://bugs.webkit.org/show_bug.cgi?id=70453
<rdar://problem/10306906>

Reviewed by John Sullivan.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcess):
Call waitForBackingStoreUpdateOnNextPaint so we'll wait for the next paint instead of painting white.

4:55 PM Changeset in webkit [97894] by ggaren@apple.com
  • 11 edits
    4 deletes in trunk/Source

Removed StringImplBase, fusing it into StringImpl
​https://bugs.webkit.org/show_bug.cgi?id=70443

Reviewed by Gavin Barraclough.

../JavaScriptCore:

(WTF::StringImpl::StringImpl):
(WTF::StringImpl::ref):
(WTF::StringImpl::length):

  • wtf/text/StringImplBase.h: Removed.
  • wtf/wtf.pri: Removed!

../JavaScriptGlue:

  • ForwardingHeaders/wtf/text/StringImplBase.h: Removed.

../WebCore:

  • ForwardingHeaders/runtime/RopeImpl.h: Removed.
  • ForwardingHeaders/wtf/text/StringImplBase.h: Removed.
4:31 PM Changeset in webkit [97893] by commit-queue@webkit.org
  • 6 edits in trunk

ArrayBuffer should have slice method.
​https://bugs.webkit.org/show_bug.cgi?id=66646

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-10-19
Reviewed by Kenneth Russell.

Source/WebCore:

  • html/canvas/ArrayBuffer.cpp:

(WebCore::clampValue):
(WebCore::ArrayBuffer::slice):
(WebCore::ArrayBuffer::sliceImpl):
(WebCore::ArrayBuffer::clampIndex):

  • html/canvas/ArrayBuffer.h: Added declaration.
  • html/canvas/ArrayBuffer.idl: Added interface.

LayoutTests:

  • fast/canvas/webgl/array-unit-tests.html: Aded.
4:27 PM Changeset in webkit [97892] by mhahnenberg@apple.com
  • 6 edits in trunk/Source

Add getConstructData to the MethodTable
​https://bugs.webkit.org/show_bug.cgi?id=70163

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Adding getConstructData to the MethodTable in order to be able to
remove all calls to getConstructDataVirtual soon. Part of the process
of de-virtualizing JSCell.

Source/WebCore:

No new tests.

Adding getConstructData to the MethodTable in order to be able to
remove all calls to getConstructDataVirtual soon. Part of the process
of de-virtualizing JSCell.

  • WebCore.exp.in:
4:25 PM Changeset in webkit [97891] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Tools

Add a suggest-nominations command to webkit-patch for computing potential committer/reviewer nominations
​https://bugs.webkit.org/show_bug.cgi?id=62166

Patch by Tom Zakrajsek <​tomz@codeaurora.org> on 2011-10-19
Reviewed by Eric Seidel.

Included options to control committer/reviewer patch count requirements,
an age-limit on patches, and verbose output for more in-depth analysis.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/tool/commands/init.py:
  • Scripts/webkitpy/tool/commands/suggestnominations.py: Added.
  • Scripts/webkitpy/tool/commands/suggestnominations_unittest.py: Added.
4:02 PM Changeset in webkit [97890] by dpranke@chromium.org
  • 9 edits
    2 deletes in trunk

Unreviewed, rolling out r97850.
​http://trac.webkit.org/changeset/97850
​https://bugs.webkit.org/show_bug.cgi?id=70334

tests are crashing on xp debug

Source/WebKit/chromium:

  • DEPS:

LayoutTests:

  • http/tests/inspector/extensions-headers.html:
  • http/tests/inspector/resources/extension-main.js:

():

  • inspector/extensions/extensions-audits.html:
  • inspector/extensions/extensions-console.html:
  • inspector/extensions/extensions-resources.html:
  • platform/chromium/inspector/extensions/extensions-api-expected.txt: Removed.
  • platform/chromium/inspector/extensions/extensions-eval-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
4:02 PM WatchList edited by levin@chromium.org
more witty message (diff)
3:54 PM Changeset in webkit [97889] by arv@chromium.org
  • 1 edit
    13 adds in trunk/LayoutTests

[Chromium] Update the test expectations for r97881.

  • platform/chromium-cg-mac-snowleopard/fast/dom/call-a-constructor-as-a-function-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/dom/error-to-string-stack-overflow-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/parser/entity-end-script-tag-expected.txt: Added.
  • platform/chromium-linux-x86/fast/dom/call-a-constructor-as-a-function-expected.txt: Added.
  • platform/chromium-linux-x86/fast/dom/error-to-string-stack-overflow-expected.txt: Added.
  • platform/chromium-linux-x86/fast/parser/entity-end-script-tag-expected.txt: Added.
  • platform/chromium-linux/fast/dom/call-a-constructor-as-a-function-expected.txt: Added.
  • platform/chromium-linux/fast/dom/error-to-string-stack-overflow-expected.txt: Added.
  • platform/chromium-linux/fast/parser/entity-end-script-tag-expected.txt: Added.
3:42 PM Changeset in webkit [97888] by mitz@apple.com
  • 3 edits
    3 adds in trunk

Incorrect pagination in flipped-blocks writing modes with border/padding before
​https://bugs.webkit.org/show_bug.cgi?id=70444

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/multicol/flipped-blocks-border-after.html

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState): Account for flipped blocks when adjusting the page offset.

LayoutTests:

  • fast/multicol/flipped-blocks-border-after-expected.png: Added.
  • fast/multicol/flipped-blocks-border-after-expected.txt: Added.
  • fast/multicol/flipped-blocks-border-after.html: Added.
3:40 PM WatchList edited by levin@chromium.org
Minor revision. (diff)
3:40 PM Changeset in webkit [97887] by eric@webkit.org
  • 3 edits in trunk/Tools

new-run-webkit-tests -2 was crashing due to both "java" and "java/" being listed in Skipped files.
Make NRWT normalize directory names in Skipped files during parsing.

Unreviewed. Very simple (tested) change.

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
3:37 PM Changeset in webkit [97886] by Beth Dakin
  • 20 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=70396
Focus rings are too thin in HiDPI in WebKit2
-and corresponding-
<rdar://problem/10086876>

Reviewed by Dan Bernstein.

Source/WebCore:

Rename wkSetPatternBaseCTM to wkSetBaseCTM

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

New CG-only function calls into wkSetBaseCTM.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::setBaseCTM):

Call GraphicsContext::setBaseCTM() rather than calling into WebKitSystemInterface
directly.

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::Image::drawPattern):

Source/WebKit/mac:

Rename wkSetPatternBaseCTM to wkSetBaseCTM

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

To create a HiDPI context in DRT, we have to set the base CTM, which currently
requires CG SPI, so we have to do it through WebKitSystemInterface.

  • WebView/WebView.mm:

(-[WebView _setBaseCTM:forContext:]):

  • WebView/WebViewPrivate.h:

Source/WebKit2:

Rename wkSetPatternBaseCTM to wkSetBaseCTM

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

When setting up a HiDPI context, we must also set the base CTM.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::display):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scaledSnapshotInDocumentCoordinates):
(WebKit::WebPage::snapshotInViewCoordinates):

WebKitLibraries:

Renamed an existing WebKitSystemInterface function.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:

LayoutTests:

  • fast/hidpi/focus-rings.html: Added.
  • platform/mac/fast/hidpi/focus-rings-expected.png: Added.
  • platform/mac/fast/hidpi/focus-rings-expected.txt: Added.
3:33 PM Changeset in webkit [97885] by levin@chromium.org
  • 10 edits in trunk/Tools

watchlist: Should be more robust to bad regex.
​https://bugs.webkit.org/show_bug.cgi?id=69486

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/watchlist: Change the instructions due to watchlist being checked by check-webkit-style (bug 69487) and remove the .* from file patterns since they are no longer anchored on the right hand side.
  • Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Change *pattern to take a compiled regex directly.
  • Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Ditto.
  • Scripts/webkitpy/common/watchlist/changedlinepattern.py: Ditto.
  • Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Ditto.
  • Scripts/webkitpy/common/watchlist/filenamepattern.py: Ditto.
  • Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Ditto and change a test now that

filenames are no longer anchored on the right hand side.

  • Scripts/webkitpy/common/watchlist/watchlistparser.py: Catch regex errors and log them as errors.
  • Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add some tests to verify that bad regexes

don't kill everything.

3:31 PM Changeset in webkit [97884] by levin@chromium.org
  • 2 edits
    2 adds in trunk/Tools

watchlist: Add a stylecheck to do validity checks for the watchlist config.
​https://bugs.webkit.org/show_bug.cgi?id=69487

Reviewed by Adam Barth.

  • Scripts/webkitpy/style/checker.py: Add the watchlist file type.
  • Scripts/webkitpy/style/checkers/watchlist.py: Added.
  • Scripts/webkitpy/style/checkers/watchlist_unittest.py: Added.
3:30 PM Changeset in webkit [97883] by annacc@chromium.org
  • 2 edits in trunk/Source/WebCore

Update WebVTTParser to require at least one space between timestamps and arrows, e.g.:
00:04:01.000 --> 00:03:00.500 is OK
00:04:01.000-->00:03:00.500 is not OK
​https://bugs.webkit.org/show_bug.cgi?id=70274

Reviewed by Eric Carlson.

Existing tests:
media/track/track-webvtt-tc008-timings-no-hours.html
(see media/track/captions-webvtt/tc008-timings-no-hour-errors.vtt #6)
media/track/track-webvtt-tc009-timings-hour.html
(see media/track/captions-webvtt/tc009-timings-hour-error.vtt #6)

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::collectTimingsAndSettings): Check that the

character before and after the '-->' is a space character

3:05 PM WikiStart edited by levin@chromium.org
add a watch list link (diff)
3:03 PM Changeset in webkit [97882] by weinig@apple.com
  • 4 edits
    6 adds in trunk/Source/WebKit2

Add skeleton of an Objective-C WebKit2 API
​https://bugs.webkit.org/show_bug.cgi?id=70438

Reviewed by Anders Carlsson.

Adds WKBrowsingContextController (WKPageRef wrapper) and WKProcessCluster
(WKContextRef wrapper) as initial files of an Objective-C WebKit2 API. Also,
hook them up so that you can get a WKBrowsingContextController from the WKView
and you can create a WKView associated with a WKProcessCluster. These names are
not final, and this work is mainly about getting the wrapper lifetimes worked
out.

  • UIProcess/API/mac/WKBrowsingContextController.h: Added.
  • UIProcess/API/mac/WKBrowsingContextController.mm: Added.

(-[WKBrowsingContextController dealloc]):
(-[WKBrowsingContextController pageRef]):
(-[WKBrowsingContextController loadRequest:]):
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:]):
(-[WKBrowsingContextController stopLoading]):
(-[WKBrowsingContextController reload]):
(-[WKBrowsingContextController reloadFromOrigin]):
(-[WKBrowsingContextController goForward]):
(-[WKBrowsingContextController canGoForward]):
(-[WKBrowsingContextController goBack]):
(-[WKBrowsingContextController canGoBack]):
(-[WKBrowsingContextController initWithPageRef:]):

  • UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Added.

Add wrapper for WKPageRef.

  • UIProcess/API/mac/WKProcessCluster.h: Added.
  • UIProcess/API/mac/WKProcessCluster.mm: Added.

(-[WKProcessCluster init]):
(-[WKProcessCluster initWithInjectedBundleURL:]):
(-[WKProcessCluster dealloc]):
(-[WKProcessCluster contextRef]):

  • UIProcess/API/mac/WKProcessClusterInternal.h: Added.

Add wrapper for WKContextRef.

  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:processCluster:]):
Add new init method which takes a WKProcessCluster.

(-[WKView browsingContextController]):
Add accessor for the WKBrowsingContextController. This works by lazily creating
the wrapper and caching it in the view itself.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

3:01 PM WatchList created by levin@chromium.org
instructions about using the watch list
2:54 PM Changeset in webkit [97881] by arv@chromium.org
  • 1626 edits in trunk/LayoutTests

JS Test Harness: Insert the stylesheet dynamically
​https://bugs.webkit.org/show_bug.cgi?id=70432

Reviewed by Ojan Vafai.

This injects the js-test-style.css file dynamically so that the test files can be simpler.
This patch also removes the markup from the existing files in LayoutTests/fast/

  • fast/*.html: Remove <link rel=:"stylesheet" href="...js-test-style.css">
  • fast/js/resources/js-test-pre.js: Inject the stylesheet dynamically.
2:44 PM Changeset in webkit [97880] by dcheng@chromium.org
  • 3 edits in trunk/LayoutTests

Add missing expectations updates for r97878.

  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
  • platform/mac/editing/selection/drag-to-contenteditable-iframe-expected.txt:
2:38 PM Changeset in webkit [97879] by eric@webkit.org
  • 4 edits in trunk/Tools

NRWT ServerProcess can't read lines from stderr and stdio separately
​https://bugs.webkit.org/show_bug.cgi?id=70435

Reviewed by Adam Barth.

This is the underlying bug behind our lack of WK2 support, and timeout detection on Windows.
DRT expects RWT to read one line at a time from stderr and stdout independently.
This allows DRT to communicate errors over stderr and have them responded to immediately
regardless of what state the stdio stream may be in. Previously NRWT's ServerProcess
class only exposed a read_line function which would read a line from stdout
and batch all output from stderr into an error buffer. Callers would only be able
to respond to commands over stderr if they happened to correspond with a stdout line boundary.

  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
2:38 PM Changeset in webkit [97878] by dcheng@chromium.org
  • 8 edits
    2 adds in trunk

Don't always select images during an image drag.
​https://bugs.webkit.org/show_bug.cgi?id=62998

Reviewed by Tony Chang.

Source/WebCore:

Only select an image being dragged if it is contenteditable.

Test: fast/events/drag-selects-image.html

  • dom/Node.cpp:

(WebCore::Node::isContentRichlyEditable):

  • dom/Node.h:
  • page/DragController.cpp:

(WebCore::prepareClipboardForImageDrag):

LayoutTests:

  • fast/events/drag-selects-image-expected.txt: Added.
  • fast/events/drag-selects-image.html: Added.
  • platform/chromium-win/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
  • platform/chromium-win/editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
  • platform/mac/editing/selection/drag-to-contenteditable-iframe-expected.txt:
2:28 PM Changeset in webkit [97877] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

HTMLBodyElement: Simplify link/alink/vlink attribute parsing.
​https://bugs.webkit.org/show_bug.cgi?id=70429

Reviewed by Antonio Gomes.

Instead of carrying around a CSSMutableStyleDeclaration with the body element,
just use CSSParser::parseColor() to parse the three link color attributes.

  • html/HTMLBodyElement.h:
  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::~HTMLBodyElement):

Remove HTMLBodyElement::m_linkDecl and all the voodoo that went along with it.

(WebCore::HTMLBodyElement::parseMappedAttribute):

Use CSSParser directly to parse the color values for {link,alink,vlink}Attr.

2:25 PM Changeset in webkit [97876] by oliver@apple.com
  • 17 edits in trunk/Source

Support CanvasPixelArray in the DFG
​https://bugs.webkit.org/show_bug.cgi?id=70384

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Add support for the old CanvasPixelArray optimisations to the
DFG. This removes the regression seen in the DFG when using
a CPA.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::store8):
(JSC::MacroAssemblerX86Common::truncateDoubleToInt32):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::movb_rm):
(JSC::X86Assembler::X86InstructionFormatter::oneByteOp8):

  • bytecode/PredictedType.cpp:

(JSC::predictionToString):
(JSC::predictionFromClassInfo):

  • bytecode/PredictedType.h:

(JSC::isByteArrayPrediction):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateByteArray):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::compileClampDoubleToByte):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnByteArray):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/JSByteArray.h:

(JSC::JSByteArray::offsetOfStorage):

  • wtf/ByteArray.cpp:
  • wtf/ByteArray.h:

(WTF::ByteArray::offsetOfSize):
(WTF::ByteArray::offsetOfData):

Source/WebCore:

Make CanvasPixelArray inherit from ByteArray's ClassInfo so
can identify it more sensibly.

  • bindings/js/JSImageDataCustom.cpp:

(WebCore::toJS):

2:07 PM Changeset in webkit [97875] by chang.shu@nokia.com
  • 4 edits in trunk

[Qt] Disable fullscreen api on Qt by default
​https://bugs.webkit.org/show_bug.cgi?id=70413

Reviewed by Noam Rosenthal.

Source/WebCore:

As the WebKit side of implementation for fullscreen api feature has not been done yet,
we'd better turn off the feature on the WebCore side by default.

  • features.pri:

LayoutTests:

  • platform/qt/Skipped:
1:34 PM Changeset in webkit [97874] by imasaki@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update the test expectation file for fullscreen related tests.
​https://bugs.webkit.org/show_bug.cgi?id=70378

Reviewed by David Levin.

  • platform/chromium/test_expectations.txt:
1:22 PM Changeset in webkit [97873] by krit@webkit.org
  • 3660 edits in trunk/LayoutTests

2011-10-19 Dirk Schulze <​krit@webkit.org>

Unreviewed, rolling out r97867.
​http://trac.webkit.org/changeset/97863
​https://bugs.webkit.org/show_bug.cgi?id=65769

Rollout rebaseline of RenderSVGShape patch after assertions in RenderSVGShape::createShape().

12:45 PM Changeset in webkit [97872] by ggaren@apple.com
  • 19 edits
    2 deletes in trunk/Source/JavaScriptCore

Some rope cleanup following r97827
​https://bugs.webkit.org/show_bug.cgi?id=70398

Reviewed by Oliver Hunt.

9% speedup on date-format-xparb, neutral overall.

  • Removed RopeImpl*.
  • Removed JSString::m_fiberCount, since this can be deduced from other data.
  • Renamed a jsString() variant to jsStringFromArguments for clarity.
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitLoadCharacterString):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::loadJSStringArgument):

  • jit/ThunkGenerators.cpp:

(JSC::stringCharLoad): Use a NULL m_value to signal rope-iness, instead
of testing m_fiberCount, since m_fiberCount is gone now.

  • runtime/JSString.cpp:

(JSC::JSString::RopeBuilder::expand):
(JSC::JSString::visitChildren):
(JSC::JSString::resolveRope):
(JSC::JSString::resolveRopeSlowCase):
(JSC::JSString::outOfMemory): Use a NULL fiber to indicate "last fiber
in the vector" instead of testing m_fiberCount, since m_fiberCount is gone now.

  • runtime/JSString.h:

(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::finishCreation):
(JSC::RopeBuilder::offsetOfLength):
(JSC::RopeBuilder::isRope):
(JSC::RopeBuilder::string): Removed m_fiberCount. Renamed
jsString => jsStringFromArguments for clarity.

  • runtime/Operations.h:

(JSC::jsStringFromArguments): Renamed.

  • runtime/RopeImpl.cpp: Removed.
  • runtime/RopeImpl.h: Removed.
  • runtime/SmallStrings.cpp:

(JSC::SmallStrings::createEmptyString): Switched to StringImpl::empty,
which is slightly faster.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncConcat): Updated for rename.

  • wtf/text/StringImplBase.h:

(WTF::StringImplBase::StringImplBase): Removed the concept of an invalid
StringImpl, since this was only used by RopeImpl, which is now gone.

11:54 AM Changeset in webkit [97871] by kov@webkit.org
  • 4 edits in trunk/Source/WebKit/gtk

[Gtk][Geolocation] Build guards missing in geolocation clients
​https://bugs.webkit.org/show_bug.cgi?id=70420

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2011-10-19
Reviewed by Gustavo Noronha Silva.

Adds build guards that were forgotten when client-based
geolocation was introduced in r97746. This should make builds
without geolocation support succeed again.

  • WebCoreSupport/GeolocationClientGtk.cpp:
  • WebCoreSupport/GeolocationClientGtk.h:
  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

10:44 AM Changeset in webkit [97870] by krit@webkit.org
  • 40 edits
    8 deletes in trunk

Unreviewed, rolling out r97863.
​http://trac.webkit.org/changeset/97863
​https://bugs.webkit.org/show_bug.cgi?id=65769

Source/WebCore:

Rollout

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/FloatRect.cpp:
  • platform/graphics/FloatRect.h:

(WebCore::FloatRect::contains):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isSVGPath):

  • rendering/RenderTreeAsText.cpp:

(WebCore::write):

  • rendering/svg/RenderSVGAllInOne.cpp:
  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::isGraphicsElement):

  • rendering/svg/RenderSVGPath.cpp:

(WebCore::BoundingRectStrokeStyleApplier::BoundingRectStrokeStyleApplier):
(WebCore::BoundingRectStrokeStyleApplier::strokeStyle):
(WebCore::RenderSVGPath::RenderSVGPath):
(WebCore::RenderSVGPath::fillContains):
(WebCore::RenderSVGPath::strokeContains):
(WebCore::RenderSVGPath::layout):
(WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath):
(WebCore::RenderSVGPath::zeroLengthSubpathRect):
(WebCore::RenderSVGPath::setupSquareCapPath):
(WebCore::RenderSVGPath::setupNonScalingStrokePath):
(WebCore::RenderSVGPath::fillAndStrokePath):
(WebCore::RenderSVGPath::paint):
(WebCore::RenderSVGPath::addFocusRingRects):
(WebCore::RenderSVGPath::nodeAtFloatPoint):
(WebCore::RenderSVGPath::calculateMarkerBoundsIfNeeded):
(WebCore::RenderSVGPath::updateCachedBoundaries):

  • rendering/svg/RenderSVGPath.h:

(WebCore::RenderSVGPath::path):
(WebCore::RenderSVGPath::setNeedsPathUpdate):
(WebCore::RenderSVGPath::setNeedsBoundariesUpdate):
(WebCore::RenderSVGPath::setNeedsTransformUpdate):
(WebCore::RenderSVGPath::objectBoundingBox):
(WebCore::RenderSVGPath::strokeBoundingBox):
(WebCore::RenderSVGPath::repaintRectInLocalCoordinates):
(WebCore::RenderSVGPath::localToParentTransform):
(WebCore::RenderSVGPath::localTransform):
(WebCore::toRenderSVGPath):

  • rendering/svg/RenderSVGRect.cpp: Removed.
  • rendering/svg/RenderSVGRect.h: Removed.
  • rendering/svg/RenderSVGResource.h:

(WebCore::RenderSVGResource::postApplyResource):

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
(WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect):
(WebCore::RenderSVGResourceClipper::hitTestClipContent):

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource):

  • rendering/svg/RenderSVGResourceFilter.h:
  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::applyResource):

  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::postApplyResource):

  • rendering/svg/RenderSVGResourcePattern.h:
  • rendering/svg/RenderSVGResourceSolidColor.cpp:

(WebCore::RenderSVGResourceSolidColor::postApplyResource):

  • rendering/svg/RenderSVGResourceSolidColor.h:
  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paint):

  • rendering/svg/RenderSVGShape.cpp: Removed.
  • rendering/svg/RenderSVGShape.h: Removed.
  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::releasePaintingResource):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::prepareToRenderSVGContent):
(WebCore::SVGRenderSupport::finishRenderSVGContent):
(WebCore::SVGRenderSupport::layoutChildren):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeStyle):
(WebCore::operator<<):
(WebCore::write):

  • rendering/svg/SVGRenderTreeAsText.h:
  • rendering/svg/SVGTextRunRenderingContext.cpp:

(WebCore::SVGTextRunRenderingContext::drawSVGGlyphs):

  • svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::svgAttributeChanged):

  • svg/SVGEllipseElement.cpp:

(WebCore::SVGEllipseElement::svgAttributeChanged):

  • svg/SVGLineElement.cpp:

(WebCore::SVGLineElement::svgAttributeChanged):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::pathSegListChanged):

  • svg/SVGPathElement.h:
  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::svgAttributeChanged):

  • svg/SVGRectElement.cpp:

(WebCore::SVGRectElement::svgAttributeChanged):

  • svg/SVGRectElement.h:

LayoutTests:

Rollout RenderSVGShape patch after assertions in RenderSVGShape::createShape().

  • svg/custom/pointer-events-on-rounded-rect-expected.txt: Removed.
  • svg/custom/pointer-events-on-rounded-rect.xhtml: Removed.
  • svg/custom/pointer-events-with-linecaps-and-miterlimits-expected.txt: Removed.
  • svg/custom/pointer-events-with-linecaps-and-miterlimits.xhtml: Removed.
10:12 AM Changeset in webkit [97869] by caryclark@google.com
  • 19 edits
    4 adds in trunk/LayoutTests

Unreviewed gardening: rebaseline remaining diffs for Chromium-Skia on
SnowLeopard.

  • platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-mac/compositing/masks/direct-image-mask-expected.png:
  • platform/chromium-gpu-mac/compositing/plugins/composited-plugin-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/deeply-nested-reflections-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/simple-composited-reflections-expected.png:
  • platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-mac/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/plugins: Added.
  • platform/chromium-gpu-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.png: Added.
  • platform/chromium-gpu-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt: Added.
  • platform/chromium-gpu-mac/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-mac/fast/text/justify-ideograph-leading-expansion-expected.png:
  • platform/chromium-mac/fast/text/justify-ideograph-leading-expansion-expected.txt:
  • platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/chromium-mac/fast/writing-mode/japanese-ruby-horizontal-bt-expected.png:
  • platform/chromium-mac/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt:
  • platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
  • platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
  • platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
  • platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
10:02 AM Changeset in webkit [97868] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: worker inspector title should contain worker URL
​https://bugs.webkit.org/show_bug.cgi?id=70424

Worker inspector title is now evaluated when the front-end starts.

Reviewed by Pavel Feldman.

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.loaded):
(WebInspector.WorkerManager._calculateWorkerInspectorTitle):

9:29 AM Changeset in webkit [97867] by reni@webkit.org
  • 3660 edits in trunk/LayoutTests

Unreviewed, rebaseline SVG related tests after r97863.

Patch by Renata Hodovan <​reni@webkit.org> on 2011-10-19

8:37 AM Changeset in webkit [97866] by chang.shu@nokia.com
  • 4 edits
    2 adds in trunk

[Qt] Support WK1-only Skipped list
​https://bugs.webkit.org/show_bug.cgi?id=70254

Reviewed by Csaba Osztrogonác.

Tools:

Added a new search path qt-wk1 for skipping WK1-only tests.

  • Scripts/webkitpy/layout_tests/port/qt.py: NRWT
  • Scripts/old-run-webkit-tests: ORWT

LayoutTests:

  • platform/qt-wk1: Added.
  • platform/qt-wk1/Skipped: Added.
8:25 AM Changeset in webkit [97865] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

[GTK] Avoid unecessarily calling gtk_widget_size_allocate on plugin widgets
​https://bugs.webkit.org/show_bug.cgi?id=70190

Reviewed by Xan Lopez.

Instead of always calling gtk_widget_size_allocate on every single plugin
widget during scrolling, only call it on widgets that are both in the view
and that have moved.

No new tests. It's difficult to test scrolling performance in an
automated way.

  • plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::setNPWindowIfNeeded): Reverse the if statement detecting a
clipped out plugin. It was incorrect.
(WebCore::PluginView::updateWidgetAllocationAndClip): If the current allocation of
the plugin widget has not changed or if the widget remains scrolled out, do not call
gtk_widget_size_allocate.

8:13 AM Changeset in webkit [97864] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[EFL] Fix DSO linkage of jsc_efl.
​https://bugs.webkit.org/show_bug.cgi?id=70412

Unreviewed build fix.

Need to add -ldl to jsc_efl (requested by dladdr).

Patch by Rafael Antognolli <​antognolli@profusion.mobi> on 2011-10-19

  • shell/CMakeListsEfl.txt:
7:59 AM Changeset in webkit [97863] by reni@webkit.org
  • 40 edits
    8 adds in trunk

Add new renderer for SVGRectElement.
​https://bugs.webkit.org/show_bug.cgi?id=65769

Source/WebCore:

Patch by Renata Hodovan <​reni@webkit.org> on 2011-10-19
Reviewed by Dirk Schulze.

This patch introduces a new common base class called RenderSVGShape which
replaces the RenderSVGPath. This new base class has the same purpose
as the replaced class and has specialized descendants for common
shapes (like Rectangles and Circles), which allows faster painting
of these shapes when certain conditions are fulfilled. On some
benchmark programs we have seen 5% speedup.

The biggest motivation of this refactor is taking advantage
of faster primitive drawing in the most common and frequent
cases. However in some rare cases, like painting rounded
rects, we need to fallback to the original code path, which
is fully kept in the RenderSVGShape base class. Some other
cases, like dashed strokes, can be painted but mouse pointer
events cannot be handled by the descendant classes. A different
fallback mechanism is used in such cases which redirects
only the pointer event handling to the base class.

Tests: svg/custom/pointer-events-on-rounded-rect.xhtml

svg/custom/pointer-events-with-linecaps-and-miterlimits.xhtml

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::contains):

  • platform/graphics/FloatRect.h:

(WebCore::FloatRect::contains):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isSVGRect):
(WebCore::RenderObject::isSVGShape):

  • rendering/RenderTreeAsText.cpp:

(WebCore::write):

  • rendering/svg/RenderSVGAllInOne.cpp:
  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::isGraphicsElement):

  • rendering/svg/RenderSVGPath.cpp:

(WebCore::RenderSVGPath::RenderSVGPath):
(WebCore::RenderSVGPath::inflateWithMarkerBounds): Unite the markerBounds with strokeBoundingBox.

  • rendering/svg/RenderSVGPath.h:
  • rendering/svg/RenderSVGRect.cpp: Added.

(WebCore::RenderSVGRect::RenderSVGRect):
(WebCore::RenderSVGRect::~RenderSVGRect):
(WebCore::RenderSVGRect::createShape):
(WebCore::RenderSVGRect::objectBoundingBox):
(WebCore::RenderSVGRect::strokeBoundingBox):
(WebCore::RenderSVGRect::fillShape):
(WebCore::RenderSVGRect::strokeShape):
(WebCore::RenderSVGRect::shapeDependentStrokeContains):
(WebCore::RenderSVGRect::shapeDependentFillContains):

  • rendering/svg/RenderSVGRect.h: Added.

(WebCore::RenderSVGRect::isSVGRect):
(WebCore::RenderSVGRect::renderName):
(WebCore::RenderSVGRect::isEmpty):

  • rendering/svg/RenderSVGResource.h:

(WebCore::RenderSVGResource::postApplyResource): A new shape argument was added to allow shape specific faster painting.

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
(WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect):
(WebCore::RenderSVGResourceClipper::hitTestClipContent):

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource):

  • rendering/svg/RenderSVGResourceFilter.h:
  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::applyResource):

  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::postApplyResource):

  • rendering/svg/RenderSVGResourcePattern.h:
  • rendering/svg/RenderSVGResourceSolidColor.cpp:

(WebCore::RenderSVGResourceSolidColor::postApplyResource):

  • rendering/svg/RenderSVGResourceSolidColor.h:
  • rendering/svg/RenderSVGShape.cpp: Copied from Source/WebCore/rendering/svg/RenderSVGPath.cpp.

(WebCore::RenderSVGShape::RenderSVGShape):
(WebCore::RenderSVGShape::~RenderSVGShape):
(WebCore::RenderSVGShape::createShape):
(WebCore::RenderSVGShape::isEmpty):
(WebCore::RenderSVGShape::fillShape):
(WebCore::RenderSVGShape::objectBoundingBox):
(WebCore::RenderSVGShape::strokeBoundingBox):
(WebCore::RenderSVGShape::strokeShape):
(WebCore::RenderSVGShape::shapeDependentStrokeContains):
The purpose of this virtual function allows decendants to use their own fast checks.
(WebCore::RenderSVGShape::shapeDependentFillContains):
The purpose of this virtual function allows decendants to use their own fast checks.
(WebCore::RenderSVGShape::fillContains):
(WebCore::RenderSVGShape::strokeContains):
(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::shouldStrokeZeroLengthSubpath):
(WebCore::RenderSVGShape::zeroLengthSubpathRect):
(WebCore::RenderSVGShape::setupSquareCapPath):
(WebCore::RenderSVGShape::setupNonScalingStrokePath):
(WebCore::RenderSVGShape::fillAndStrokePath):
(WebCore::RenderSVGShape::paint):
(WebCore::RenderSVGShape::addFocusRingRects):
(WebCore::RenderSVGShape::nodeAtFloatPoint):
(WebCore::RenderSVGShape::calculateMarkerBoundsIfNeeded):
(WebCore::RenderSVGShape::updateCachedBoundaries):
(WebCore::RenderSVGShape::strokeWidth):

  • rendering/svg/RenderSVGShape.h: Copied from Source/WebCore/rendering/svg/RenderSVGPath.h.

(WebCore::BoundingRectStrokeStyleApplier::BoundingRectStrokeStyleApplier):
(WebCore::BoundingRectStrokeStyleApplier::strokeStyle):
(WebCore::RenderSVGShape::setNeedsShapeUpdate):
(WebCore::RenderSVGShape::setNeedsBoundariesUpdate):
(WebCore::RenderSVGShape::setNeedsTransformUpdate):
(WebCore::RenderSVGShape::isPaintingFallback):
(WebCore::RenderSVGShape::path):
(WebCore::RenderSVGShape::setIsPaintingFallback):
(WebCore::RenderSVGShape::setStrokeAndMarkerBoundingBox):
(WebCore::RenderSVGShape::hasPath):
(WebCore::RenderSVGShape::repaintRectInLocalCoordinates):
(WebCore::RenderSVGShape::localToParentTransform):
(WebCore::RenderSVGShape::localTransform):
(WebCore::RenderSVGShape::isSVGShape):
(WebCore::RenderSVGShape::renderName):
(WebCore::RenderSVGShape::isRoundedRect):
(WebCore::RenderSVGShape::inflateWithMarkerBounds):
(WebCore::toRenderSVGShape):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::releasePaintingResource):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::finishRenderSVGContent):
(WebCore::SVGRenderSupport::layoutChildren):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeStyle):
(WebCore::operator<<):
(WebCore::write):

  • rendering/svg/SVGRenderTreeAsText.h:
  • rendering/svg/SVGTextRunRenderingContext.cpp:

(WebCore::SVGTextRunRenderingContext::drawSVGGlyphs):

  • svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::svgAttributeChanged):

  • svg/SVGEllipseElement.cpp:

(WebCore::SVGEllipseElement::svgAttributeChanged):

  • svg/SVGLineElement.cpp:

(WebCore::SVGLineElement::svgAttributeChanged):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::pathSegListChanged):
(WebCore::SVGPathElement::createRenderer):

  • svg/SVGPathElement.h:
  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::svgAttributeChanged):

  • svg/SVGRectElement.cpp:

(WebCore::SVGRectElement::svgAttributeChanged):
(WebCore::SVGRectElement::createRenderer):

  • svg/SVGRectElement.h:

LayoutTests:

Add new tests to check the new shape based rendering mechanism of SVGRectElement.

Patch by Renata Hodovan <​reni@webkit.org> on 2011-10-19
Reviewed by Dirk Schulze.

  • svg/custom/pointer-events-on-rounded-rect-expected.txt: Added.
  • svg/custom/pointer-events-on-rounded-rect.xhtml: Added.
  • svg/custom/pointer-events-with-linecaps-and-miterlimits-expected.txt: Added.
  • svg/custom/pointer-events-with-linecaps-and-miterlimits.xhtml: Added.
7:50 AM Changeset in webkit [97862] by kbalazs@webkit.org
  • 3 edits in trunk/LayoutTests

inspector/cookie-parser.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=62662

Unreviewed gardening. Skip the next test that have became crashing after
skipping cookie-parser in the hope that the bug won't spread further.

  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
7:33 AM Changeset in webkit [97861] by Philippe Normand
  • 32 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline.

  • platform/gtk/fast/block/margin-collapse/010-expected.txt:
  • platform/gtk/fast/block/margin-collapse/011-expected.txt:
  • platform/gtk/fast/block/margin-collapse/012-expected.txt:
  • platform/gtk/fast/block/margin-collapse/015-expected.txt:
  • platform/gtk/fast/block/margin-collapse/016-expected.txt:
  • platform/gtk/fast/block/margin-collapse/020-expected.txt:
  • platform/gtk/fast/block/margin-collapse/056-expected.txt:
  • platform/gtk/fast/block/margin-collapse/059-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
7:30 AM Changeset in webkit [97860] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

[Qt] Fix failing tests after migrating to refactored Qt5
​https://bugs.webkit.org/show_bug.cgi?id=69104

Move tests from qt-wk2/Skipped to qt-5.0, because these
fails are related to Qt 5, not to Qt-WK2.

Unreviewed gardening.

  • platform/qt-5.0/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
7:12 AM Changeset in webkit [97859] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

2 inspector/extensions tests times out on Mac after r97850 ​https://bugs.webkit.org/show_bug.cgi?id=70414

Unreviewed gardening.

  • platform/qt-mac/Skipped:
7:09 AM Changeset in webkit [97858] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Skipping test permanently because it is out of date to the current spec.
​https://bugs.webkit.org/show_bug.cgi?id=68796

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2011-10-19
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
7:02 AM Changeset in webkit [97857] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: buttons of number type <input> controls are not fully accessible
​https://bugs.webkit.org/show_bug.cgi?id=70241

Unreviewed. Fix missing </File> tag in Windows WebCore project file.

  • WebCore.vcproj/WebCore.vcproj:
6:59 AM Changeset in webkit [97856] by rgabor@webkit.org
  • 2 edits in trunk/Tools

[GTK] Enable to use built-product-archive on GTK platform
​https://bugs.webkit.org/show_bug.cgi?id=70319

Reviewed by Csaba Osztrogonác.

  • BuildSlaveSupport/built-product-archive:
6:36 AM Changeset in webkit [97855] by loislo@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: [Chromium] Add an ability to show the objects that were allocated between snapshot N-2 and snapshot N-1 and still alive in snapshot N.
​https://bugs.webkit.org/show_bug.cgi?id=61178

This ability will help us to see only the leaked objects.
Scenario:
1) do an action on inspected page which leaks javascript data;
2) make snapshot;
3) repeat first two steps three or more times;
4) select the last snapshot and select the filter 'Objects allocated between Snapshot 1 and Snapshot2' instead of 'All objects'.
The view shows the object that were allocated between snapshot N-2 and snapshot N-1 and still alive in snapshot N

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged.firstSnapshotLoaded):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged.secondSnapshotLoaded):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._baseProfileIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
(WebInspector.DetailedHeapshotView.profileCallback):
(WebInspector.DetailedHeapshotView):
(WebInspector.DetailedHeapshotView.prototype.get statusBarItems):
(WebInspector.DetailedHeapshotView.prototype._changeBase):
(WebInspector.DetailedHeapshotView.prototype._changeFilter):
(WebInspector.DetailedHeapshotView.prototype._loadProfileByIndex):
(WebInspector.DetailedHeapshotView.prototype._changeView):
(WebInspector.DetailedHeapshotView.prototype._updateFilterOptions):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype.get maxNodeId):
(WebInspector.HeapSnapshot.prototype.aggregates):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._sortAggregateIndexes):
(WebInspector.HeapSnapshot.prototype.createNodesProviderForClass):
(WebInspector.HeapSnapshot.prototype.updateStaticData):

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotProxy.prototype.aggregates):
(WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForClass):
(WebInspector.HeapSnapshotProxy.prototype.get maxNodeId):
(WebInspector.HeapSnapshotProxy.prototype.startLoading):

6:31 AM Changeset in webkit [97854] by apavlov@chromium.org
  • 90 edits in trunk/Source/WebCore

Strip trailing whitespace in the WebCore/css C++ code.
​https://bugs.webkit.org/show_bug.cgi?id=70410

Reviewed by Dirk Schulze.

Only affected file names retained below for brevity.
Multiline boolean expression were fixed where necessary to avoid patch style violations.

  • css/CSSBorderImageSliceValue.cpp:
  • css/CSSBorderImageSliceValue.h:
  • css/CSSBorderImageValue.cpp:
  • css/CSSCanvasValue.cpp:
  • css/CSSCanvasValue.h:
  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSCursorImageValue.cpp:
  • css/CSSFontFace.cpp:
  • css/CSSFontFace.h:
  • css/CSSFontFaceSource.cpp:
  • css/CSSFontFaceSource.h:
  • css/CSSFontFaceSrcValue.cpp:
  • css/CSSFontFaceSrcValue.h:
  • css/CSSFontSelector.cpp:
  • css/CSSFontSelector.h:
  • css/CSSFunctionValue.cpp:
  • css/CSSFunctionValue.h:
  • css/CSSGradientValue.cpp:
  • css/CSSGradientValue.h:
  • css/CSSImageGeneratorValue.cpp:
  • css/CSSImageGeneratorValue.h:
  • css/CSSImageValue.cpp:
  • css/CSSImageValue.h:
  • css/CSSImportRule.cpp:
  • css/CSSInitialValue.cpp:
  • css/CSSInitialValue.h:
  • css/CSSMutableStyleDeclaration.cpp:
  • css/CSSMutableStyleDeclaration.h:
  • css/CSSParser.cpp:
  • css/CSSParser.h:
  • css/CSSParserValues.cpp:
  • css/CSSParserValues.h:
  • css/CSSPrimitiveValue.cpp:
  • css/CSSPrimitiveValue.h:
  • css/CSSPrimitiveValueCache.cpp:
  • css/CSSPrimitiveValueCache.h:
  • css/CSSPrimitiveValueMappings.h:
  • css/CSSProperty.cpp:
  • css/CSSProperty.h:
  • css/CSSPropertyLonghand.cpp:
  • css/CSSReflectValue.cpp:
  • css/CSSReflectValue.h:
  • css/CSSReflectionDirection.h:
  • css/CSSSegmentedFontFace.cpp:
  • css/CSSSegmentedFontFace.h:
  • css/CSSSelector.cpp:
  • css/CSSSelector.h:
  • css/CSSSelectorList.cpp:
  • css/CSSSelectorList.h:
  • css/CSSStyleApplyProperty.cpp:
  • css/CSSStyleDeclaration.h:
  • css/CSSStyleSelector.cpp:
  • css/CSSStyleSelector.h:
  • css/CSSStyleSheet.cpp:
  • css/CSSTimingFunctionValue.cpp:
  • css/CSSTimingFunctionValue.h:
  • css/CSSUnicodeRangeValue.cpp:
  • css/CSSUnicodeRangeValue.h:
  • css/CSSValueList.cpp:
  • css/CSSWrapShapes.cpp:
  • css/CSSWrapShapes.h:
  • css/FontValue.cpp:
  • css/MediaList.cpp:
  • css/MediaQuery.cpp:
  • css/MediaQuery.h:
  • css/MediaQueryEvaluator.h:
  • css/MediaQueryExp.cpp:
  • css/MediaQueryExp.h:
  • css/Pair.h:
  • css/SVGCSSComputedStyleDeclaration.cpp:
  • css/SVGCSSParser.cpp:
  • css/SVGCSSStyleSelector.cpp:
  • css/SelectorChecker.cpp:
  • css/SelectorChecker.h:
  • css/StyleBase.cpp:
  • css/StyleMedia.cpp:
  • css/StyleMedia.h:
  • css/StyleSheetList.cpp:
  • css/StyleSheetList.h:
  • css/WebKitCSSFilterValue.cpp:
  • css/WebKitCSSFilterValue.h:
  • css/WebKitCSSKeyframeRule.cpp:
  • css/WebKitCSSKeyframeRule.h:
  • css/WebKitCSSKeyframesRule.cpp:
  • css/WebKitCSSKeyframesRule.h:
  • css/WebKitCSSMatrix.cpp:
  • css/WebKitCSSMatrix.h:
  • css/WebKitCSSTransformValue.cpp:
  • css/WebKitCSSTransformValue.h:
6:27 AM Changeset in webkit [97853] by krit@webkit.org
  • 39 edits in trunk/Source/WebCore

Make FilterEffect::apply() independent of image data management
​https://bugs.webkit.org/show_bug.cgi?id=70350

Reviewed by Zoltan Herczeg.

FilterEffect::apply() needs to be independent from the image data management in FilterEffect.
This allows implementing effective hardware accelerated alternatives, like OpenGL, CI or OpenCL
based filters, to the software rendering. The software rendering code will be used as fallback
and moves to platformApplySoftware().

The patch does not change the behavior of SVG filters. Did not add new test cases.

  • platform/graphics/filters/FEBlend.cpp: Renamed apply() to platformApplyGeneric()

and removed validity checks that are done by FilterEffect::apply(). This is a
recurring pattern for all following effects.

(WebCore::FEBlend::platformApplySoftware):

  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::platformApplySoftware):

  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::platformApplySoftware):

  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::platformApplySoftware):

  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::platformApplySoftware):

  • platform/graphics/filters/FEConvolveMatrix.h:
  • platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::platformApplySoftware):

  • platform/graphics/filters/FEDisplacementMap.h:
  • platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::platformApplySoftware):

  • platform/graphics/filters/FEDropShadow.h:
  • platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::platformApplySoftware):

  • platform/graphics/filters/FEFlood.h:
  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplySoftware):

  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplySoftware):

  • platform/graphics/filters/FELighting.h:
  • platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::platformApplySoftware):

  • platform/graphics/filters/FEMerge.h:
  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApplySoftware):

  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::platformApplySoftware):

  • platform/graphics/filters/FEOffset.h:
  • platform/graphics/filters/FETile.cpp:

(WebCore::FETile::platformApplySoftware):

  • platform/graphics/filters/FETile.h:
  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::platformApplySoftware):

  • platform/graphics/filters/FETurbulence.h:
  • platform/graphics/filters/FilterEffect.cpp: Added non-virtual apply() function. This will call the platform specific apply functions,

which need to be virtual now.

(WebCore::FilterEffect::hasResult): Added a comment for new implementations. This function needs to be updated for every new port.
(WebCore::FilterEffect::apply):
(WebCore::FilterEffect::createImageBufferResult): Removed determineAbsolutePaintRect() call. This is done in apply() now.
(WebCore::FilterEffect::createUnmultipliedImageResult): Ditto.
(WebCore::FilterEffect::createPremultipliedImageResult): Ditto.

  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::platformApplySoftware):

  • platform/graphics/filters/SourceAlpha.h:
  • platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::platformApplySoftware):

  • platform/graphics/filters/SourceGraphic.h:
  • svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::platformApplySoftware):

  • svg/graphics/filters/SVGFEImage.h:
5:58 AM Changeset in webkit [97852] by caio.oliveira@openbossa.org
  • 23 edits
    16 moves in trunk/Source/WebKit2

[Qt] [WK2] Rename files and classes to follow conventions
​https://bugs.webkit.org/show_bug.cgi?id=70391

Reviewed by Noam Rosenthal.

Rename the files and classes following the agreed conventions on
QtWebKit mailing list -- which are based on existing usage we have.

  • Public API follow Qt conventions: qsomething.cpp qsomething.h with class named QSomething
  • Private classes for public API classes follow Qt conventions: qsomething_p.h qsomething_p.cpp (if needed), with class named QSomethingPrivate
  • Subclasses and Qt-specific implementations of WebKit/WebCore classes use Qt suffix: FrameLoaderClientQt.cpp
  • Other classes created for using in our port use Qt prefix: QtFileDownloader, QtViewInterface

This is documented in ​https://trac.webkit.org/wiki/QtWebKitHacking

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::chooseFiles):
(toPolicyAction):
(QDesktopWebViewPrivate::navigationPolicyForURL):

  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::updatePaintNode):
(QTouchWebPagePrivate::setPage):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:
  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::updateViewportConstraints):

  • UIProcess/API/qt/qtouchwebview.h:
  • UIProcess/API/qt/qtouchwebview_p.h:
  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/qt/ClientImpl.cpp:

(toQtViewInterface):
(toQtPolicyInterface):
(qt_wk_runJavaScriptAlert):
(qt_wk_runJavaScriptConfirm):
(qt_wk_runJavaScriptPrompt):
(qt_wk_setStatusText):
(qt_wk_runOpenPanel):
(qt_wk_mouseDidMoveOverElement):
(qt_wk_decidePolicyForNavigationAction):

  • UIProcess/qt/QtDesktopWebPageProxy.cpp: Renamed from Source/WebKit2/UIProcess/qt/qdesktopwebpageproxy.cpp.

(dragOperationToDropAction):
(QtDesktopWebPageProxy::QtDesktopWebPageProxy):
(QtDesktopWebPageProxy::createDrawingAreaProxy):
(QtDesktopWebPageProxy::paintContent):
(QtDesktopWebPageProxy::setViewportArguments):
(QtDesktopWebPageProxy::doneWithTouchEvent):
(QtDesktopWebPageProxy::createPopupMenuProxy):
(QtDesktopWebPageProxy::handleEvent):
(QtDesktopWebPageProxy::handleMouseMoveEvent):
(QtDesktopWebPageProxy::handleMousePressEvent):
(QtDesktopWebPageProxy::handleMouseReleaseEvent):
(QtDesktopWebPageProxy::handleMouseDoubleClickEvent):
(QtDesktopWebPageProxy::handleWheelEvent):
(QtDesktopWebPageProxy::handleHoverLeaveEvent):
(QtDesktopWebPageProxy::handleHoverMoveEvent):
(QtDesktopWebPageProxy::handleDragEnterEvent):
(QtDesktopWebPageProxy::handleDragLeaveEvent):
(QtDesktopWebPageProxy::handleDragMoveEvent):
(QtDesktopWebPageProxy::handleDropEvent):
(QtDesktopWebPageProxy::timerEvent):

  • UIProcess/qt/QtDesktopWebPageProxy.h: Renamed from Source/WebKit2/UIProcess/qt/qdesktopwebpageproxy.h.
  • UIProcess/qt/QtGestureRecognizer.cpp:

(WebKit::QtGestureRecognizer::QtGestureRecognizer):

  • UIProcess/qt/QtGestureRecognizer.h:
  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::QtPanGestureRecognizer):

  • UIProcess/qt/QtPanGestureRecognizer.h:
  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::QtPinchGestureRecognizer):

  • UIProcess/qt/QtPinchGestureRecognizer.h:
  • UIProcess/qt/QtPolicyInterface.h: Renamed from Source/WebKit2/UIProcess/qt/PolicyInterface.h.
  • UIProcess/qt/QtSGTileNode.cpp: Renamed from Source/WebKit2/UIProcess/qt/SGTileNode.cpp.

(WebKit::QtSGTileNode::QtSGTileNode):
(WebKit::QtSGTileNode::setBackBuffer):
(WebKit::QtSGTileNode::swapBuffersIfNeeded):

  • UIProcess/qt/QtSGTileNode.h: Renamed from Source/WebKit2/UIProcess/qt/SGTileNode.h.
  • UIProcess/qt/QtSGUpdateQueue.cpp: Renamed from Source/WebKit2/UIProcess/qt/SGUpdateQueue.cpp.

(WebKit::NodeUpdateCreateTile::NodeUpdateCreateTile):
(WebKit::NodeUpdateRemoveTile::NodeUpdateRemoveTile):
(WebKit::NodeUpdateSetBackBuffer::NodeUpdateSetBackBuffer):
(WebKit::NodeUpdateSwapTileBuffers::NodeUpdateSwapTileBuffers):
(WebKit::QtSGUpdateQueue::QtSGUpdateQueue):
(WebKit::QtSGUpdateQueue::createTileNode):
(WebKit::QtSGUpdateQueue::removeTileNode):
(WebKit::QtSGUpdateQueue::setNodeBackBuffer):
(WebKit::QtSGUpdateQueue::swapTileBuffers):
(WebKit::QtSGUpdateQueue::applyUpdates):
(WebKit::QtSGUpdateQueue::getScaleNode):

  • UIProcess/qt/QtSGUpdateQueue.h: Renamed from Source/WebKit2/UIProcess/qt/SGUpdateQueue.h.

(WebKit::QtSGUpdateQueue::isSwapPending):
(WebKit::NodeUpdate::NodeUpdate):
(WebKit::NodeUpdate::~NodeUpdate):

  • UIProcess/qt/QtTouchViewInterface.cpp: Renamed from Source/WebKit2/UIProcess/qt/TouchViewInterface.cpp.

(WebKit::QtTouchViewInterface::QtTouchViewInterface):
(WebKit::QtTouchViewInterface::didFindZoomableArea):
(WebKit::QtTouchViewInterface::sceneGraphUpdateQueue):
(WebKit::QtTouchViewInterface::setViewNeedsDisplay):
(WebKit::QtTouchViewInterface::drawingAreaSize):
(WebKit::QtTouchViewInterface::contentSizeChanged):
(WebKit::QtTouchViewInterface::isActive):
(WebKit::QtTouchViewInterface::hasFocus):
(WebKit::QtTouchViewInterface::isVisible):
(WebKit::QtTouchViewInterface::startDrag):
(WebKit::QtTouchViewInterface::didReceiveViewportArguments):
(WebKit::QtTouchViewInterface::didChangeUrl):
(WebKit::QtTouchViewInterface::didChangeTitle):
(WebKit::QtTouchViewInterface::didChangeToolTip):
(WebKit::QtTouchViewInterface::didChangeStatusText):
(WebKit::QtTouchViewInterface::didChangeCursor):
(WebKit::QtTouchViewInterface::loadDidBegin):
(WebKit::QtTouchViewInterface::loadDidCommit):
(WebKit::QtTouchViewInterface::loadDidSucceed):
(WebKit::QtTouchViewInterface::loadDidFail):
(WebKit::QtTouchViewInterface::didChangeLoadProgress):
(WebKit::QtTouchViewInterface::showContextMenu):
(WebKit::QtTouchViewInterface::hideContextMenu):
(WebKit::QtTouchViewInterface::runJavaScriptAlert):
(WebKit::QtTouchViewInterface::runJavaScriptConfirm):
(WebKit::QtTouchViewInterface::runJavaScriptPrompt):
(WebKit::QtTouchViewInterface::processDidCrash):
(WebKit::QtTouchViewInterface::didRelaunchProcess):
(WebKit::QtTouchViewInterface::engine):

  • UIProcess/qt/QtTouchViewInterface.h: Renamed from Source/WebKit2/UIProcess/qt/TouchViewInterface.h.

(WebKit::QtTouchViewInterface::chooseFiles):
(WebKit::QtTouchViewInterface::didMouseMoveOverElement):

  • UIProcess/qt/QtTouchWebPageProxy.cpp: Renamed from Source/WebKit2/UIProcess/qt/qtouchwebpageproxy.cpp.

(QtTouchWebPageProxy::QtTouchWebPageProxy):
(QtTouchWebPageProxy::createDrawingAreaProxy):
(QtTouchWebPageProxy::processDidCrash):
(QtTouchWebPageProxy::paintContent):
(QtTouchWebPageProxy::doneWithTouchEvent):
(QtTouchWebPageProxy::handleEvent):
(QtTouchWebPageProxy::setVisibleContentRectAndScale):
(QtTouchWebPageProxy::setVisibleContentRectTrajectoryVector):
(QtTouchWebPageProxy::setResizesToContentsUsingLayoutSize):
(QtTouchWebPageProxy::touchEvent):
(QtTouchWebPageProxy::findZoomableAreaForPoint):
(QtTouchWebPageProxy::renderNextFrame):

  • UIProcess/qt/QtTouchWebPageProxy.h: Renamed from Source/WebKit2/UIProcess/qt/qtouchwebpageproxy.h.

(QtTouchWebPageProxy::touchViewInterface):
(QtTouchWebPageProxy::drawingArea):

  • UIProcess/qt/QtViewInterface.h: Renamed from Source/WebKit2/UIProcess/qt/ViewInterface.h.
  • UIProcess/qt/QtViewportInteractionEngine.cpp: Renamed from Source/WebKit2/UIProcess/qt/ViewportInteractionEngine.cpp.

(WebKit::visibleRectInContentCoordinate):
(WebKit::contentRectInViewportCoordinate):
(WebKit::ViewportUpdateGuard::ViewportUpdateGuard):
(WebKit::ViewportUpdateGuard::~ViewportUpdateGuard):
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::~QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::reset):
(WebKit::QtViewportInteractionEngine::setConstraints):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::panGestureCancelled):
(WebKit::QtViewportInteractionEngine::panGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
(WebKit::QtViewportInteractionEngine::contentViewportChanged):
(WebKit::QtViewportInteractionEngine::updateContentIfNeeded):
(WebKit::QtViewportInteractionEngine::updateContentScaleIfNeeded):
(WebKit::QtViewportInteractionEngine::updateContentPositionIfNeeded):
(WebKit::QtViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):
(WebKit::QtViewportInteractionEngine::animateContentPositionIntoBoundariesIfNeeded):
(WebKit::QtViewportInteractionEngine::animateContentScaleIntoBoundariesIfNeeded):
(WebKit::QtViewportInteractionEngine::scaleContent):

  • UIProcess/qt/QtViewportInteractionEngine.h: Renamed from Source/WebKit2/UIProcess/qt/ViewportInteractionEngine.h.

(WebKit::QtViewportInteractionEngine::Constraints::Constraints):
(WebKit::operator==):

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::registerEditCommand):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/QtWebUndoCommand.cpp: Renamed from Source/WebKit2/UIProcess/qt/WebUndoCommandQt.cpp.

(QtWebUndoCommand::QtWebUndoCommand):
(QtWebUndoCommand::~QtWebUndoCommand):
(QtWebUndoCommand::redo):
(QtWebUndoCommand::undo):

  • UIProcess/qt/QtWebUndoCommand.h: Renamed from Source/WebKit2/UIProcess/qt/WebUndoCommandQt.h.

(QtWebUndoCommand::inUndoRedo):

  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp:

(WebKit::TiledDrawingAreaProxy::updateWebView):

  • UIProcess/qt/WebContextMenuProxyQt.cpp:

(WebKit::WebContextMenuProxyQt::WebContextMenuProxyQt):
(WebKit::WebContextMenuProxyQt::create):

  • UIProcess/qt/WebContextMenuProxyQt.h:
  • WebKit2.pro:
5:36 AM Changeset in webkit [97851] by vsevik@chromium.org
  • 26 edits in trunk

Web Inspector: Enable caseSensitive search / Regex support in advanced search.
​https://bugs.webkit.org/show_bug.cgi?id=70335

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::createSearchRegex):
(WebCore::ContentSearchUtils::searchInTextByLines):

  • inspector/ContentSearchUtils.h:
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::searchInContent):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::searchInResource):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.SearchView):
(WebInspector.SearchView.prototype.get searchConfig):
(WebInspector.FileBasedSearchResultsPane.prototype._createSearchRegex):
(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):
(WebInspector.FileBasedSearchResultsPane.SearchResult):

  • inspector/front-end/ConsolePanel.js:

(WebInspector.ConsolePanel.prototype.performSearch):

  • inspector/front-end/ContentProviders.js:

(WebInspector.ScriptContentProvider.prototype.searchInContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.searchCallback):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent):
(WebInspector.ResourceContentProvider.prototype.searchInContent):
(WebInspector.CompilerSourceMappingContentProvider.prototype.searchInContent):
(WebInspector.StaticContentProvider.prototype.searchInContent):

  • inspector/front-end/ElementsTreeOutline.js:

():

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype.performSearch):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.searchInContent):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.searchInContent):

  • inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchScope.prototype.performSearch.searchCallbackWrapper):
(WebInspector.ScriptsSearchScope.prototype.performSearch):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.createSearchRegex):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.searchInContent):
(WebInspector.ContentProvider.prototype.searchInContent):

  • inspector/front-end/inspector.css:

(.search-view .search-panel input[type="search"].search-config-search):
(.search-view .search-panel label.search-config-label):
(.search-view .search-panel input[type="checkbox"].search-config-checkbox):

  • inspector/front-end/utilities.js:

():

LayoutTests:

  • http/tests/inspector/search/search-in-concatenated-script.html:
  • http/tests/inspector/search/search-in-resource-expected.txt:
  • http/tests/inspector/search/search-in-resource.html:
  • http/tests/inspector/search/search-in-script-expected.txt:
  • http/tests/inspector/search/search-in-script.html:
5:22 AM Changeset in webkit [97850] by caseq@chromium.org
  • 9 edits
    3 adds in trunk

Web Inspector: make extension tests pass on chromium
​https://bugs.webkit.org/show_bug.cgi?id=70334

Reviewed by Pavel Feldman.

Source/WebKit/chromium:

  • DEPS: roll chromium 105970:106056

LayoutTests:

  • http/tests/inspector/extensions-headers.html:
  • http/tests/inspector/resources/extension-main.js:

():

  • inspector/extensions/extensions-audits.html:
  • inspector/extensions/extensions-console.html:
  • inspector/extensions/extensions-resources.html:
  • platform/chromium/inspector/extensions/extensions-api-expected.txt: Added.
  • platform/chromium/inspector/extensions/extensions-eval-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
5:11 AM Changeset in webkit [97849] by andreas.kling@nokia.com
  • 9 edits in trunk/Source/WebCore

MediaList: Remove inheritance from StyleBase.
​https://bugs.webkit.org/show_bug.cgi?id=70203

Reviewed by Darin Adler.

  • css/MediaList.h:

(WebCore::MediaList::parentStyleSheet):
(WebCore::MediaList::setParentStyleSheet):

  • css/MediaList.cpp:

(WebCore::MediaList::MediaList):
(WebCore::MediaList::notifyChanged):

Change MediaList to no longer inherit from StyleBase. The parent()/setParent()
mechanism was replaced by explicit parentStyleSheet()/setParentStyleSheet().

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::CSSImportRule):
(WebCore::CSSImportRule::~CSSImportRule):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):

Change StyleBase::setParent() calls to MediaList::setParentStyleSheet().
CSSRules are never moved between stylesheets, so the parent style sheet pointer
is valid for the MediaList's lifetime.

  • css/StyleSheet.cpp:

(WebCore::StyleSheet::~StyleSheet):

Change StyleBase::setParent() calls to MediaList::setParentStyleSheet().

(WebCore::StyleSheet::setMedia):

Change StyleBase::setParent() calls to MediaList::setParentStyleSheet().
Assert that the parent sheet is either null, or this, as MediaLists should never
be reparented to other sheets.
Assert that the StyleSheet is indeed a CSSStyleSheet. XSLStyleSheet inherits from
StyleSheet, but it shouldn't be using the MediaList.

  • bindings/js/JSDOMBinding.h:

(WebCore::root):

Add MediaList* specific overload for root() since it can't fall back
to root(StyleBase*) anymore.

  • WebCore.xcodeproj/project.pbxproj:

Add some PrivateHeaders to accomodate the JSDOMBinding.h changes.

  • css/CSSMediaRule.h:

Remove unnecessary forward-declaration of MediaList.

5:02 AM Changeset in webkit [97848] by Philippe Normand
  • 10 edits
    1 add in trunk/LayoutTests

Unreviewed, GTK rebaseline and GTK baselines for
fast/multicol/vertical-rl/rule-style.html

  • platform/gtk/Skipped: Skip

fast/files/url-required-arguments.html, affected by bug 66045

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/multicol/vertical-rl/rule-style-expected.txt: Added.
  • platform/gtk/svg/hixie/cascade/002-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
4:29 AM Changeset in webkit [97847] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Console messages for XHR logging should show call stack if available.
​https://bugs.webkit.org/show_bug.cgi?id=70324

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage):

4:18 AM Changeset in webkit [97846] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed fix after r97845.

  • platform/qt/test_expectations.txt: Remove a skipped test, because NRWT can't handle duplicated entries.
4:09 AM Changeset in webkit [97845] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

inspector/cookie-parser.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=62662

[Qt] Assertion fail in CSSPrimitiveValue ctor
​https://bugs.webkit.org/show_bug.cgi?id=69933

  • platform/qt/Skipped: Skip failing tests to paint the bots green.
3:51 AM Changeset in webkit [97844] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip new failing tests.

  • platform/qt-mac/Skipped:
  • platform/qt-wk2/Skipped:
2:48 AM Changeset in webkit [97843] by podivilov@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: move JS specific popover handling to JavaScriptSourceFrame.
​https://bugs.webkit.org/show_bug.cgi?id=70033

Reviewed by Pavel Feldman.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.get paused):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.shouldShowPopover):
(WebInspector.JavaScriptSourceFrame.prototype.onShowPopover.showObjectPopover):
(WebInspector.JavaScriptSourceFrame.prototype.onShowPopover):
(WebInspector.JavaScriptSourceFrame.prototype.onHidePopover):
(WebInspector.JavaScriptSourceFrame.prototype._highlightExpression):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.SourceFrameDelegateForScriptsPanel):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.willHide):
(WebInspector.SourceFrame.prototype._initializeTextViewer):
(WebInspector.SourceFrame.prototype._getPopoverAnchor):
(WebInspector.SourceFrame.prototype.get readOnly):
(WebInspector.SourceFrame.prototype._setReadOnly):
(WebInspector.SourceFrame.prototype.contentChanged):
(WebInspector.SourceFrame.prototype.shouldShowPopover):
(WebInspector.SourceFrame.prototype.onShowPopover):
(WebInspector.SourceFrame.prototype.onHidePopover):

2:48 AM BuildingQt5OnHarmattan edited by Simon Hausmann
(diff)
2:45 AM Changeset in webkit [97842] by rgabor@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add platform specific expected result for new tests.

  • platform/qt/fast/multicol/vertical-rl/rule-style-expected.png: Added.
  • platform/qt/fast/multicol/vertical-rl/rule-style-expected.txt: Added.
  • platform/qt/fast/selectors/visited-descendant-expected.png: Added.
  • platform/qt/fast/selectors/visited-descendant-expected.txt: Added.
1:32 AM Changeset in webkit [97841] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL][WK2] Added missing files to build WebKit2 EFL
​https://bugs.webkit.org/show_bug.cgi?id=70312

Patch by Tomasz Morawski <​t.morawski@samsung.com> on 2011-10-19
Reviewed by Ryosuke Niwa.

Added missing files to WebCore/CMakeListEfl.txt script:

  • platform/network/soup/CredentialStorageSoup.cpp
  • platform/network/soup/ProxyServerSoup.cpp

Fixes few linking time errors.

  • CMakeListsEfl.txt:
12:53 AM Changeset in webkit [97840] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Added missing dummy interpretKeyEvent function
​https://bugs.webkit.org/show_bug.cgi?id=70311

Patch by Tomasz Morawski <​t.morawski@samsung.com> on 2011-10-19
Reviewed by Ryosuke Niwa.

Added missing dummy interpretKeyEvent function needed to compile WK2.

  • WebProcess/WebPage/efl/WebPageEfl.cpp:

(WebKit::WebPage::interpretKeyEvent):

12:47 AM Changeset in webkit [97839] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

Rename AllowAllocation to ConstructorMode
​https://bugs.webkit.org/show_bug.cgi?id=70397

Reviewed by Adam Barth.

The name 'AllowAllocation' is confusing (See discussion here: bug 70015).
This patch renames 'AllowAllocation' to 'ConstructorMode' to clarify that
this class is for distinguishing the following two situations:

  1. A programmer allocates an object via "new X"; X is a function with a C++ constructCallback.
  2. C++ allocates an object via the function template and tries to wrap the object with a JS flavor.

Tests: fast/events/constructors/*

  • bindings/scripts/CodeGeneratorV8.pm: Renamed AllowAllocation to ConstructorMode.

(GenerateConstructorCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp: Updated a run-binding-tests result.

(WebCore::V8TestInterface::constructorCallback):

  • bindings/v8/V8Binding.cpp: Renamed AllowAllocation to ConstructorMode.

(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):

  • bindings/v8/V8Binding.h: Ditto.

(WebCore::ConstructorMode::ConstructorMode):
(WebCore::ConstructorMode::~ConstructorMode):
(WebCore::ConstructorMode::current):
(WebCore::SafeAllocation::newInstance):

  • bindings/v8/V8Proxy.cpp: Ditto.

(WebCore::V8Proxy::checkNewLegal):

  • bindings/v8/custom/V8EventConstructors.cpp: Ditto.

(WebCore::constructV8Event):

12:32 AM Changeset in webkit [97838] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Test expectation change.

Unreviewed.

  • platform/chromium/test_expectations.txt:
12:18 AM Changeset in webkit [97837] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Added missing dummy platformDescription function
​https://bugs.webkit.org/show_bug.cgi?id=70310

Patch by Tomasz Morawski <​t.morawski@samsung.com> on 2011-10-19
Reviewed by Ryosuke Niwa.

Added dummy platformDescription function needed to compile WK2.

  • platform/efl/ContextMenuEfl.cpp:

(WebCore::ContextMenu::platformDescription):

Oct 18, 2011:

11:57 PM Changeset in webkit [97836] by haraken@chromium.org
  • 13 edits
    1 delete in trunk

Generate a SharedWorker constructor of V8 using [Constructor] IDL
​https://bugs.webkit.org/show_bug.cgi?id=67879

Reviewed by Hajime Morita.

Source/WebCore:

Spec: ​http://dev.w3.org/html5/workers/#shared-workers-and-the-sharedworker-interface
This patch changed SharedWorker::create(..., context, ec) to
SharedWorker::create(context, ..., ec), since a parameter specified by [CallWith]
should come at the beginning (c.f. bug 69799).

Test: ui_tests:WorkerTest.FLAKY_SharedWorkerFastConstructor

ui_tests:WorkerTest.FLAKY_SharedWorkerFastName

  • WebCore.gypi: Removed bindings/v8/custom/V8SharedWorkerCustom.cpp
  • WebCore.pro: Ditto.
  • bindings/js/JSSharedWorkerCustom.cpp: Moved ScriptExecutionContext parameter to the beginning.

(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker):

  • bindings/v8/custom/V8SharedWorkerCustom.cpp: Removed.
  • workers/SharedWorker.cpp: Moved ScriptExecutionContext parameter to the beginning.

(WebCore::SharedWorker::create): Ditto.

  • workers/SharedWorker.h: Ditto.
  • workers/SharedWorker.idl: Added [Constructor] IDL.

LayoutTests:

Added test cases for an undefined name and a null name on SharedWorker constructor.

  • fast/workers/resources/shared-worker-name.js:

(test7.try.worker.port.onmessage):
(test7): A test case for a null name.
(test8.worker.port.onmessage):
(test8): Ditto.
(test9.try.worker.port.onmessage):
(test9): A test case for an undefined name.
(test10.worker.port.onmessage):
(test10): Ditto.

  • fast/workers/shared-worker-constructor-expected.txt:
  • fast/workers/shared-worker-constructor.html:
  • fast/workers/shared-worker-name-expected.txt:
  • platform/chromium-win/fast/workers/shared-worker-constructor-expected.txt: Updated SyntaxError with TypeError. The reason why ui_tests has been so far working without updating this error type is that shared-worker-constructor.html is marked FLAKY in chromium.
11:42 PM Changeset in webkit [97835] by yuzo@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Attempt to fix Linux Clang compilation error.

Unreviewed.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestThreadOnly::runTestThreaded):
(WTF::TEST_F):

10:36 PM Changeset in webkit [97834] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Rolled out last Windows build fix because it was wrong.

10:18 PM Changeset in webkit [97833] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/912

Merge 97786 - Crash in RenderDeprecatedFlexibleBox::layoutHorizontalBox

BUG=100459
Review URL: ​http://codereview.chromium.org/8345035

10:16 PM Changeset in webkit [97832] by hayato@chromium.org
  • 1 add in branches/components/README.components-branch

A test commit, adding a README.components-branch file.

9:32 PM Changeset in webkit [97831] by jnd@chromium.org
  • 5 edits in trunk

Source/WebCore: Implement NSProcessInfo::systemUptime on Mac Leopard.
​https://bugs.webkit.org/show_bug.cgi?id=66577

Reviewed by Tony Chang.

  • WebCore.gyp/WebCore.gyp:
  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(-[NSProcessInfo systemUptime]):

LayoutTests: Enable touch tests on Mac Leopard.
​https://bugs.webkit.org/show_bug.cgi?id=66577

Reviewed by Tony Chang.

  • platform/chromium/test_expectations.txt:
8:55 PM Changeset in webkit [97830] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Rolled out last Windows build fix because it was wrong.

8:47 PM Changeset in webkit [97829] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix part of the Windows build.

Export!

8:10 PM Changeset in webkit [97828] by ojan@chromium.org
  • 10 edits
    2 moves
    1 add
    2 deletes in trunk/LayoutTests

Unreviewed. New expected results after ​http://trac.webkit.org/changeset/97707.

  • fast/table/height-percent-test-vertical-expected.txt: Renamed from LayoutTests/platform/gtk/fast/table/height-percent-test-vertical-expected.txt.
  • platform/chromium-linux/fast/table/028-vertical-expected.png:
  • platform/chromium-linux/fast/table/height-percent-test-vertical-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/fallback-orientation-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/writing-mode/fallback-orientation-expected.png.
  • platform/chromium-win-vista/fast/writing-mode/fallback-orientation-expected.png: Removed.
  • platform/chromium-win-xp/fast/writing-mode/fallback-orientation-expected.png:
  • platform/chromium-win/fast/table/028-vertical-expected.png:
  • platform/chromium-win/fast/table/028-vertical-expected.txt:
  • platform/chromium-win/fast/table/height-percent-test-vertical-expected.png:
  • platform/chromium-win/fast/writing-mode/fallback-orientation-expected.png:
  • platform/chromium-win/fast/writing-mode/fallback-orientation-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/qt/fast/table/height-percent-test-vertical-expected.txt: Removed.
7:54 PM Changeset in webkit [97827] by ggaren@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

Switched ropes from malloc memory to GC memory
​https://bugs.webkit.org/show_bug.cgi?id=70364

Reviewed by Gavin Barraclough.

~1% SunSpider speedup. Neutral elsewhere. Removes one cause for strings
having C++ destructors.

  • heap/MarkStack.cpp:

(JSC::visitChildren): Call the JSString visitChildren function now,
since it's no longer a no-op.

  • runtime/JSString.cpp:

(JSC::JSString::~JSString): Moved this destructor out of line because
it's called virtually, so there's no value to inlining.

(JSC::JSString::RopeBuilder::expand): Switched RopeBuilder to be a thin
initializing wrapper around JSString. JSString now represents ropes
directly, rather than relying on an underlying malloc object.

(JSC::JSString::visitChildren): Visit our rope fibers, since they're GC
objects now.

(JSC::JSString::resolveRope):
(JSC::JSString::resolveRopeSlowCase):
(JSC::JSString::outOfMemory): Updated for operating on JSStrings instead
of malloc objects.

(JSC::JSString::replaceCharacter): Removed optimizations for substringing
ropes and replacing subsections of ropes. We want to reimplement versions
of these optimizations in the future, but this patch already has good
performance without them.

  • runtime/JSString.h:

(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::finishCreation):
(JSC::RopeBuilder::createNull):
(JSC::RopeBuilder::create):
(JSC::RopeBuilder::createHasOtherOwner):
(JSC::jsSingleCharacterString):
(JSC::jsSingleCharacterSubstring):
(JSC::jsNontrivialString):
(JSC::jsString):
(JSC::jsSubstring):
(JSC::jsOwnedString): Lots of mechanical changes here. The two important
things are: (1) The fibers in JSString::m_fibers are JSStrings now, not
malloc objects; (2) I simplified the JSString constructor interface to
only accept PassRefPtr<StringImpl>, instead of variations on that like
UString, reducing refcount churn.

  • runtime/JSValue.h:
  • runtime/JSValue.cpp:

(JSC::JSValue::toPrimitiveString): Updated this function to return a
JSString instead of a UString, since that's what clients want now.

  • runtime/Operations.cpp:

(JSC::jsAddSlowCase):

  • runtime/Operations.h:

(JSC::jsString):

  • runtime/SmallStrings.cpp:

(JSC::SmallStrings::createEmptyString): Updated for interface changes above.

  • runtime/StringConstructor.cpp:

(JSC::constructWithStringConstructor):

  • runtime/StringObject.h:

(JSC::StringObject::create): Don't create a new JSString if we already
have a JSString.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncConcat): Updated for interface changes above.

6:50 PM Changeset in webkit [97826] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Errrk, fix partial commit of r97825!

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToISOString):

6:49 PM Changeset in webkit [97825] by barraclough@apple.com
  • 4 edits in trunk

Date.prototype.toISOString fails to throw exception
​https://bugs.webkit.org/show_bug.cgi?id=70394

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToISOString):

  • Should throw a range error if the internal value is not finite.

LayoutTests:

  • fast/js/date-toisostring-expected.txt:
  • fast/js/script-tests/date-toisostring.js:

(throwsRangeError):

  • fixed test case.
6:37 PM Changeset in webkit [97824] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

fix baseline for fast/history/history-back-twice-with-subframes-assert.html
​https://bugs.webkit.org/show_bug.cgi?id=70393

Reviewed by James Robinson.

the baseline added in r97821 appears to have had a couple of
extra lines in it.

  • fast/history/history-back-twice-with-subframes-assert-expected.txt:
6:37 PM Changeset in webkit [97823] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Try to jostle the windows build back to life.

  • rendering/HitTestResult.h:
6:16 PM Changeset in webkit [97822] by dpranke@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Update chromium leopard cg baseline.

Unreviewed, baseline update.

  • platform/chromium-cg-mac-leopard/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
5:52 PM Changeset in webkit [97821] by andersca@apple.com
  • 3 edits
    2 adds in trunk

Assertion failure when going back in page with navigated subframes
​https://bugs.webkit.org/show_bug.cgi?id=70389
<rdar://problem/8988444>

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/history/history-back-twice-with-subframes-assert.html

If a single navigation ends up loading multiple frame, the first committed frame will
end up calling recursiveUpdateForCommit on the main frame which will null out the provisional item
for all frames on the page. This means that it can null out the provisional item for any frames
that are still yet to be committed which causes the aforementioned assertion failure.

Fix this by only nulling out the provisional history item (and saving/restoring the scroll position and
some other things) for frames that already contain the URL that the item requested. If a frame is being loaded,
it will null out its provisional history item when it's committed.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::recursiveUpdateForCommit):

LayoutTests:

  • fast/history/history-back-twice-with-subframes-assert-expected.txt: Added.
  • fast/history/history-back-twice-with-subframes-assert.html: Added.
5:47 PM Changeset in webkit [97820] by levin@chromium.org
  • 7 edits in trunk/Tools

watchlist: Should try to run if it can and not throw on mistakes.
​https://bugs.webkit.org/show_bug.cgi?id=70358

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/system/outputcapture.py: Add the ability to capture log output.
  • Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adapt to the logging of errors.
  • Scripts/webkitpy/common/watchlist/watchlistparser.py: Change to log problems and fix problems when found.
  • Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Adapt to the logging of errors.
  • Scripts/webkitpy/common/watchlist/watchlistrule.py: Expose a way to remove instructions.
  • Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Test the new function.
5:40 PM Changeset in webkit [97819] by weinig@apple.com
  • 14 edits in trunk

Source/WebKit2: Move uses of C SPI out of WKView.h and into WKViewPrivate.h
​https://bugs.webkit.org/show_bug.cgi?id=70387

Reviewed by Dan Bernstein.

  • UIProcess/API/mac/WKViewPrivate.h:

Move declarations here.

  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateRemoteAccessibilityRegistration:]):
(-[WKView initWithFrame:]):
(-[WKView initWithFrame:contextRef:]):
(-[WKView _registerDraggedTypes]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView pageRef]):
(-[WKView canChangeFrameLayout:]):
(-[WKView printOperationWithPrintInfo:forFrame:]):
(-[WKView setFrame:andScrollBy:]):
Move definitions to private category.

  • UIProcess/API/mac/PDFViewController.mm:
  • UIProcess/mac/WKFullScreenWindowController.mm:
  • UIProcess/mac/WebInspectorProxyMac.mm:

Update to include WKViewPrivate.h where necessary.

Tools: Move uses of C-SPI out of WKView.h and into WKViewPrivate.h
​https://bugs.webkit.org/show_bug.cgi?id=70387

Reviewed by Dan Bernstein.

  • MiniBrowser/mac/BrowserWindowController.m:
  • TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
  • TestWebKitAPI/mac/JavaScriptTestMac.mm:
  • TestWebKitAPI/mac/PlatformWebViewMac.mm:
  • TestWebKitAPI/mac/WebKitAgnosticTest.mm:
  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

Update to include WKViewPrivate.h where necessary.

5:22 PM QtWebKitHacking edited by caio.oliveira@openbossa.org
(diff)
5:15 PM Changeset in webkit [97818] by dpranke@chromium.org
  • 18 edits in trunk

Unreviewed, rolling out r97765.
​http://trac.webkit.org/changeset/97765
​https://bugs.webkit.org/show_bug.cgi?id=70388

"broke webkit_unit_tests, http/tests/xmlhttprequest
/xmlhttprequest-test-send-flag.html on linux debug" (Requested
by dpranke on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-18

Source/WebCore:

  • WebCore.gypi:
  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::create):
(WebCore::DocumentThreadableLoader::~DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::cancel):
(WebCore::DocumentThreadableLoader::setDefersLoading):
(WebCore::DocumentThreadableLoader::willSendRequest):
(WebCore::DocumentThreadableLoader::didSendData):
(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::didReceiveData):
(WebCore::DocumentThreadableLoader::didReceiveCachedMetadata):
(WebCore::DocumentThreadableLoader::didFinishLoading):
(WebCore::DocumentThreadableLoader::didFail):
(WebCore::DocumentThreadableLoader::preflightSuccess):
(WebCore::DocumentThreadableLoader::loadRequest):

  • loader/DocumentThreadableLoader.h:
  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::CachedRawResource):
(WebCore::CachedRawResource::data):

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::setRequestedFromNetworkingLayer):

  • loader/cache/CachedResourceClient.h:
  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::~CachedResourceRequest):
(WebCore::CachedResourceRequest::willSendRequest):
(WebCore::CachedResourceRequest::didFinishLoading):
(WebCore::CachedResourceRequest::didReceiveResponse):
(WebCore::CachedResourceRequest::didReceiveData):

  • loader/cache/CachedResourceRequest.h:
  • loader/chromium/CachedRawResourceChromium.cpp: Removed.
  • loader/chromium/CachedResourceRequestChromium.cpp: Removed.
  • loader/chromium/DocumentThreadableLoaderChromium.cpp:

(WebCore::DocumentThreadableLoader::didDownloadData):

  • loader/icon/IconLoader.h:
  • platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::notifyResponse):

LayoutTests:

  • http/tests/inspector/network/network-content-replacement-xhr-expected.txt:
4:53 PM Changeset in webkit [97817] by mhahnenberg@apple.com
  • 22 edits in trunk/Source

Rename static put to putByIndex
​https://bugs.webkit.org/show_bug.cgi?id=70281

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Renaming versions of deleteProperty that use an unsigned as the property
name to "deletePropertyByIndex" in preparation for adding them to the
MethodTable, which requires unique names for each method.

  • dfg/DFGOperations.cpp:

(JSC::DFG::putByVal):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Arguments.cpp:

(JSC::Arguments::putVirtual):
(JSC::Arguments::putByIndex):

  • runtime/Arguments.h:
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncMap):

  • runtime/JSArray.cpp:

(JSC::JSArray::put):
(JSC::JSArray::putVirtual):
(JSC::JSArray::putByIndex):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::putVirtual):
(JSC::JSByteArray::putByIndex):

  • runtime/JSByteArray.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::putVirtual):
(JSC::JSCell::putByIndex):

  • runtime/JSCell.h:
  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::putVirtual):
(JSC::JSNotAnObject::putByIndex):

  • runtime/JSNotAnObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::putVirtual):
(JSC::JSObject::putByIndex):

  • runtime/JSObject.h:
  • runtime/RegExpConstructor.cpp:

(JSC::RegExpMatchesArray::fillArrayInstance):

  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::putVirtual):
(JSC::RegExpMatchesArray::putByIndex):

Source/WebCore:

No new tests.

Renaming versions of deleteProperty that use an unsigned as the property
name to "deletePropertyByIndex" in preparation for adding them to the
MethodTable, which requires unique names for each method.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::putVirtual):
(JSC::RuntimeArray::putByIndex):

  • bridge/runtime_array.h:
4:53 PM Changeset in webkit [97816] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Mark storage/domstorage/events/documentURI as a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=70386

Unreviewed, expectations change.

on chromium snowleopard.

  • platform/chromium/test_expectations.txt:
4:44 PM Changeset in webkit [97815] by dpranke@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

Add a new chromium baseline for fast/multicol/vertical-rl/rule-style.html.

Unreviewed, baseline update.

  • platform/chromium-cg-mac-snowleopard/fast/multicol/vertical-rl/rule-style-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/rule-style-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/rule-style-expected.txt: Added.
4:40 PM Changeset in webkit [97814] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, expectations update.

  • platform/chromium/test_expectations.txt:
4:38 PM Changeset in webkit [97813] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build.

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::absolutePDFURL):
Fix typo.

4:36 PM Changeset in webkit [97812] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

Unreviewed warning fix after ​https://bugs.webkit.org/show_bug.cgi?id=70269

  • WebCore.pro:
4:25 PM Changeset in webkit [97811] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

Stop leaking internal names in WKView API header
​https://bugs.webkit.org/show_bug.cgi?id=70380

Reviewed by Anders Carlsson.

Move _frameSizeUpdatesDisabledCount to WKViewData. Since we cannot change the size of
WKView due to the fragile Objective-C ABI, we must rename the existing variable unused. If
drop 32-bit support, we will be able to remove it.

  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView disableFrameSizeUpdates]):
(-[WKView enableFrameSizeUpdates]):
(-[WKView frameSizeUpdatesDisabled]):

  • WebKit2.xcodeproj/project.pbxproj:
4:20 PM Changeset in webkit [97810] by ap@apple.com
  • 14 edits in trunk/Source

Expose PDF information in hit test result
​https://bugs.webkit.org/show_bug.cgi?id=70353

Reviewed by Sam Weinig.

  • WebCore.exp.in:
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absolutePDFURL):
  • rendering/HitTestResult.h: Added HitTestResult::absolutePDFURL(). It will contain a URL when over a PDF object or embed; not sure if we want this for PDFImageDocuments.
4:19 PM Changeset in webkit [97809] by enne@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Preserve offscreen tiles instead of immediately recycling them
​https://bugs.webkit.org/show_bug.cgi?id=70352

Reviewed by James Robinson.

Tested by existing layout tests.

Prior to having a TextureManager class, tiled layers recycled their
textures internally to avoid reallocation. Unfortunately, it recycled
these tiles as soon as they went offscreen, even if they were still
valid. Instead, keep tiles around forever, letting the TextureManager
decide (via LRU) when to reclaim the underlying textures. This will
improve scrolling performance due to not needing to repaint tiles.

This change does lead to more texture reallocation for any textures
that get reclaimed, but the command buffer implementation already
pools and reuses texture ids, so it should not introduce additional
flush syncs. If there's any performance penalty, it'll be at the
driver level, but I'd prefer to measure that there's a problem before
prematurely optimizing and adding complexity to the TextureManager.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::cleanupResources):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/TiledLayerChromium.h:
4:17 PM Changeset in webkit [97808] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash in WebProcess at com.apple.AppKit: -[NSFilePromiseDragSource draggedImage:endedAt:operation:] + 101
​https://bugs.webkit.org/show_bug.cgi?id=70340
<rdar://problem/9548174>

We have seen a number of crash reports for this issue that seem to occurr when
the user drags an image from a web page onto the desktop.
We have not been able to reproduce this crash, therefore this is a speculative fix,
but the theory is that the dragging source has been already released when draggedImage
is called.
This patch attempts a fix for the problem by retaining the dragging source when
NSFilePromiseDragSource is created.

Reviewed by Darin Adler.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(-[WKPasteboardFilePromiseOwner initWithSource:]):
(-[WKPasteboardFilePromiseOwner dealloc]):

4:14 PM Changeset in webkit [97807] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Crash after storing credentials in Keychain
​https://bugs.webkit.org/show_bug.cgi?id=70376
<rdar://problem/9647503>

Reviewed by Dan Bernstein.

  • Shared/mac/SecKeychainItemResponseData.cpp: (WebKit::SecKeychainItemResponseData::encode): (WebKit::SecKeychainItemResponseData::decode): Actually send keychain item over, too. In shimSecKeychainItemCreateFromContent(), we are going to use it to override SecKeychainItemCreateFromContent(), and we cannot return noErr from this function without returning a non-null keychain item.
4:08 PM Changeset in webkit [97806] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

This revised fix doesn't break SL build.
​https://bugs.webkit.org/show_bug.cgi?id=70345

Reviewed and landed by Sam Weinig.

Patch by Damian Kaleta <​dkaleta@apple.com> on 2011-10-18

  • UIProcess/API/mac/WKView.mm:

(+[WKView hideWordDefinitionWindow]): Hides the definition window.

  • UIProcess/API/mac/WKViewPrivate.h:
4:06 PM Changeset in webkit [97805] by adamk@chromium.org
  • 3 edits
    2 adds in trunk

[MutationObservers] Implement WebKitMutationObserver.observe for characterData changes
​https://bugs.webkit.org/show_bug.cgi?id=68957

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/mutation/observe-characterdata.html

  • dom/CharacterData.cpp:

(WebCore::CharacterData::dispatchModifiedEvent):

LayoutTests:

  • fast/mutation/observe-characterdata-expected.txt: Added.
  • fast/mutation/observe-characterdata.html: Added.
4:06 PM Changeset in webkit [97804] by weinig@apple.com
  • 7 edits in trunk/Source/WebKit2

Move spellCheckerDocumentTag and handleCorrectionPanelResult from WKViewPrivate to WKViewInternal
​https://bugs.webkit.org/show_bug.cgi?id=70377

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView spellCheckerDocumentTag]):
(-[WKView handleCorrectionPanelResult:]):
Move definition of methods to (Internal) area.

  • UIProcess/API/mac/WKViewInternal.h:

Add methods.

  • UIProcess/API/mac/WKViewPrivate.h:

Remove methods.

  • UIProcess/cf/WebBackForwardListCF.cpp:

Add missing newline.

  • UIProcess/mac/CorrectionPanel.mm:

Change #include to WKViewInternal.h

  • WebKit2.xcodeproj/project.pbxproj:

Sort some files.

4:05 PM Changeset in webkit [97803] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Scroll animator tracing
​https://bugs.webkit.org/show_bug.cgi?id=70280

Patch by Scott Byer <​scottbyer@chromium.org> on 2011-10-18
Reviewed by James Robinson.

No functional difference, no test needed.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::animationTimerFired):

4:02 PM Changeset in webkit [97802] by jamesr@google.com
  • 7 edits in trunk/Source

[chromium] Remove USE(THREADED_COMPOSITING) from the tree, this is controlled by a runtime setting
​https://bugs.webkit.org/show_bug.cgi?id=70356

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

  • features.gypi:
  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::scheduleComposite):

  • src/WebLayerTreeViewImpl.h:
  • src/WebViewImpl.h:
3:58 PM Changeset in webkit [97801] by ojan@chromium.org
  • 3 edits in trunk/Source/WebCore

cleanup some FIXMEs in RenderFlexibleBox
​https://bugs.webkit.org/show_bug.cgi?id=70374

Reviewed by Darin Adler.

No new tests. Existing tests cover all changes.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::flowAwareBorderAndPaddingLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareMarginLogicalHeightForChild):

  • rendering/RenderFlexibleBox.h:

Removed the FIXME to implement computePreferredLogicalWidths. It doesn't
seem to be necessary, at least not with the current test cases.

3:57 PM Changeset in webkit [97800] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Move WKView helper files into a sub-group
​https://bugs.webkit.org/show_bug.cgi?id=70375

Reviewed by Darin Adler.

  • WebKit2.xcodeproj/project.pbxproj:

Move some files around.

3:48 PM Changeset in webkit [97799] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Remove expectations for tests that are no longer failing.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
3:47 PM Changeset in webkit [97798] by Joseph Pecoraro
  • 5 edits in trunk

<​http://webkit.org/b/70365> Web Inspector: Some localizedStrings.js Updates

Reviewed by Darin Adler.

Source/WebCore:

Fixed syntax issue, added missing strings, and removed a duplicate.

  • English.lproj/localizedStrings.js:

Tools:

  • Scripts/check-inspector-strings:

Updated to the new webkitpy way to determine checkout root.

  • Scripts/webkitdirs.pm:

(copyInspectorFrontendFiles):
Made it so build-webkit --inspector-frontend copies over
the localizedStrings.js file as well as the frontend files.

3:45 PM Changeset in webkit [97797] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] DRT: Clear list of visited pages before each test.
​https://bugs.webkit.org/show_bug.cgi?id=70355

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-10-18
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Add ewk_history_clear as a way to clear the list of visited pages in a
Ewk_History, in a similar fashion to Qt's QWebHistory::clear().

  • ewk/ewk_history.cpp:

(ewk_history_clear):

  • ewk/ewk_history.h:

Tools:

r97596 uncovered a bug in the implementation: the list of visited
links was not cleared between tests, which caused tests such as
fast/repaint/outline-repaint-glitch.html to be flaky (the link color
changed depending on whether fast/repaint/border-repaint-glitch.html
was visited before or not).

Call ewk_history_clear to make sure the visited links list does not
persist between tests.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

3:38 PM Changeset in webkit [97796] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

fix unused-but-set-variable warnings in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=70344

Reviewed by Adam Barth.

This is a new compiler warning in gcc 4.6.

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::isWrapperOfType):

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp:

(WebCore::ComplexTextController::normalizeSpacesAndMirrorChars):

3:37 PM Changeset in webkit [97795] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Enable out-of-thread compositing in WebKit compositor API
​https://bugs.webkit.org/show_bug.cgi?id=69850

Patch by Antoine Labour <​piman@chromium.org> on 2011-10-18
Reviewed by James Robinson.

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::composite):

3:14 PM Changeset in webkit [97794] by mitz@apple.com
  • 3 edits
    3 adds in trunk

Certain column-rule styles render incorrectly in vertical writing modes
​https://bugs.webkit.org/show_bug.cgi?id=70362

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/multicol/vertical-rl/rule-style.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules): Use the correct border sides for vertical writing modes.

LayoutTests:

  • fast/multicol/vertical-rl/rule-style-expected.png: Added.
  • fast/multicol/vertical-rl/rule-style-expected.txt: Added.
  • fast/multicol/vertical-rl/rule-style.html: Added.
3:07 PM Changeset in webkit [97793] by annacc@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix broken binding tests by changing G_MAXUSHORT to G_MAXUINT in WebKitDOMTestObj.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=70267

Reviewed by Daniel Bates.

Tests: fixing WebKitDOMTestObj.cpp

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_class_init): Change G_MAXUSHORT to G_MAXUINT

3:04 PM Changeset in webkit [97792] by inferno@chromium.org
  • 3 edits in trunk/Source/WebKit2

Unreviewed, rolling out r97788.
​http://trac.webkit.org/changeset/97788
​https://bugs.webkit.org/show_bug.cgi?id=70366

broke compile (Requested by inferno-sec on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-18

  • UIProcess/API/mac/WKView.mm:
  • UIProcess/API/mac/WKViewPrivate.h:
2:57 PM Changeset in webkit [97791] by barraclough@apple.com
  • 5 edits in trunk

Array.prototype methods missing exception checks
​https://bugs.webkit.org/show_bug.cgi?id=70360

Reviewed by Geoff Garen.

Missing exception checks after calls to the static getProperty helper,
these may result in the wrong exception being thrown (or an ASSERT being hit,
as is currently the case running test-262).

Source/JavaScriptCore:

No performance impact.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):

LayoutTests:

  • fast/js/array-proto-func-property-getter-except-expected.txt:
  • fast/js/script-tests/array-proto-func-property-getter-except.js:
    • The test results that change were only testing for an absence of a crash; the new results are correct (the first exception thrown should be the one returned).
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T4-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T6-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T7-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T8-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T9-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T11-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T12-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T4-expected.txt:
    • Check in passing results.
2:07 PM Changeset in webkit [97790] by dpranke@chromium.org
  • 1 edit
    7 adds in trunk/LayoutTests

Add missing baselines for fast/selectors/visited-descendant.

Unreviewed, expectations change.

  • platform/chromium-cg-mac-leopard/fast/selectors/visited-descendant-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/selectors/visited-descendant-expected.png: Added.
  • platform/chromium-linux/fast/selectors/visited-descendant-expected.png: Added.
  • platform/chromium-mac-leopard/fast/selectors/visited-descendant-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/selectors/visited-descendant-expected.png: Added.
  • platform/chromium-win/fast/selectors/visited-descendant-expected.png: Added.
  • platform/chromium-win/fast/selectors/visited-descendant-expected.txt: Added.
2:01 PM Changeset in webkit [97789] by adamk@chromium.org
  • 3 edits in trunk/LayoutTests

Corrected bad cut-and-paste in MutationObserver test description.

Unreviewed.

  • fast/mutation/observe-attributes-expected.txt:
  • fast/mutation/observe-attributes.html:
1:50 PM Changeset in webkit [97788] by kdecker@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-10-18 Damian Kaleta <​dkaleta@apple.com>

Add WebKit API to hide the definition window
​https://bugs.webkit.org/show_bug.cgi?id=70345

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm: (-[WKView hideWordDefinitionWindow]): Hides the definition window.
  • UIProcess/API/mac/WKViewPrivate.h:
1:44 PM Changeset in webkit [97787] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/874

Merge 97786 - Crash in RenderDeprecatedFlexibleBox::layoutHorizontalBox

BUG=97786
Review URL: ​http://codereview.chromium.org/8346010

1:42 PM Changeset in webkit [97786] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in RenderDeprecatedFlexibleBox::layoutHorizontalBox
​https://bugs.webkit.org/show_bug.cgi?id=70183

Patch by Julien Chaffraix <​jchaffraix@webkit.org> on 2011-10-18
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/flexbox/layoutHorizontal-crash.html

The deferred scroll information update logic was not updated when an object was destroy'ed.

The fix is very simple. As the deferred logic was only used with deprecated flexbox, it is a
pretty uncommon cases so let's optimize the new code for the common case.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::willBeDestroyed):

LayoutTests:

  • fast/flexbox/layoutHorizontal-crash-expected.txt: Added.
  • fast/flexbox/layoutHorizontal-crash.html: Added.
1:09 PM Changeset in webkit [97785] by adamk@chromium.org
  • 3 edits in trunk/Source/WebCore

[MutationObservers] Clean up MutationObserver code in Node
​https://bugs.webkit.org/show_bug.cgi?id=70349

Reviewed by Ryosuke Niwa.

Three small cleanups.

No new tests, no behavior change.

  • dom/Node.cpp:

(WebCore::Node::clearRareData): Use indices instead of iterator in for loop; fix typo.
(WebCore::Node::registerMutationObserver): Inline single call to Node::ensureMutationObserverEntries.

  • dom/Node.h: Make mutationObserverEntries private.
12:55 PM Changeset in webkit [97784] by jamesr@google.com
  • 10 edits
    1 add in trunk/Source

[chromium] Fix shutdown race when posting main thread task to CCThreadProxy and enable tests
​https://bugs.webkit.org/show_bug.cgi?id=70161

Reviewed by David Levin.

Source/WebCore:

Adds a weak pointer mechanism to cancel main thread tasks posted to CCThreadProxy instances from the compositor
thread. Previously there was a race condition where main thread tasks could run even after the CCThreadProxy was
destroyed.

This race does not exist in the other direction because when tearing down a CCThreadProxy we first post a quit
task to the compositor thread and then suspend execution of the main thread until all compositor tasks for the
CCThreadProxy have been drained.

Covered by the now-enabled CCLayerTreeHostTest* unit tests.

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCScopedMainThreadProxy.h: Added.

(WebCore::CCScopedMainThreadProxy::create):
(WebCore::CCScopedMainThreadProxy::postTask):
(WebCore::CCScopedMainThreadProxy::shutdown):
(WebCore::CCScopedMainThreadProxy::CCScopedMainThreadProxy):
(WebCore::CCScopedMainThreadProxy::runTaskIfNotShutdown):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

Enables the CCLayerTreeHostTest* tests by default. Most tests are run twice in a single thread and multiple
thread configuration. Some tests run only in the multiple thread configuration if they depend on the compositor
thread scheduling draws by itself.

  • tests/CCLayerTreeHostTest.cpp:

(::CCLayerTreeHostTest::timeout):
(::CCLayerTreeHostTest::clearTimeout):
(::CCLayerTreeHostTest::CCLayerTreeHostTest):
(::CCLayerTreeHostTest::onEndTest):
(::CCLayerTreeHostTest::TimeoutTask::TimeoutTask):
(::CCLayerTreeHostTest::TimeoutTask::clearTest):
(::CCLayerTreeHostTest::TimeoutTask::~TimeoutTask):
(::CCLayerTreeHostTest::TimeoutTask::Run):
(::CCLayerTreeHostTest::runTest):
(::CCLayerTreeHostTest::doBeginTest):
(::CCLayerTreeHostTestThreadOnly::runTest):
(::CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):

12:35 PM Changeset in webkit [97783] by ojan@chromium.org
  • 5 edits
    12 adds in trunk

implement flex-flow:column
​https://bugs.webkit.org/show_bug.cgi?id=70082

Reviewed by David Hyatt.

Source/WebCore:

There's still a bug with a FIXME where we don't compute the right
size for the container of the flexbox in the presence of
orthogonal flows. That's the cause of all the failing cases
in the tests.

Tests: css3/flexbox/flex-flow-border.html

css3/flexbox/flex-flow-margins.html
css3/flexbox/flex-flow-orientations.html
css3/flexbox/flex-flow-overflow.html
css3/flexbox/flex-flow-padding.html
css3/flexbox/flex-flow.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::hasOrthogonalFlow):
(WebCore::RenderFlexibleBox::isColumnFlow):
(WebCore::RenderFlexibleBox::isHorizontalFlow):
(WebCore::RenderFlexibleBox::isLeftToRightFlow):
Use isHorizontalFlow and isLeftToRightFlow so that methods like
flowAwareBorderStart look exactly like borderStart with
isHorizontalWritingMode and isLeftToRightDirection replaced.

(WebCore::RenderFlexibleBox::setFlowAwareLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareLogicalHeightForChild):
(WebCore::RenderFlexibleBox::flowAwareLogicalWidthForChild):
(WebCore::RenderFlexibleBox::flowAwareLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareLogicalWidth):
(WebCore::RenderFlexibleBox::flowAwareContentLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareContentLogicalWidth):
(WebCore::RenderFlexibleBox::transformedWritingMode):
Transform the writing-mode based of the flex-flow and direction
values. That methods like flowAwareBorderBefore look exactly like
borderBefore, except it switches over a different value.

(WebCore::RenderFlexibleBox::flowAwareBorderStart):
(WebCore::RenderFlexibleBox::flowAwareBorderBefore):
(WebCore::RenderFlexibleBox::flowAwareBorderAfter):
(WebCore::RenderFlexibleBox::flowAwarePaddingStart):
(WebCore::RenderFlexibleBox::flowAwarePaddingBefore):
(WebCore::RenderFlexibleBox::flowAwarePaddingAfter):
(WebCore::RenderFlexibleBox::flowAwareMarginStartForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginEndForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginBeforeForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginAfterForChild):
(WebCore::RenderFlexibleBox::setFlowAwareMarginStartForChild):
(WebCore::RenderFlexibleBox::setFlowAwareMarginEndForChild):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
(WebCore::RenderFlexibleBox::alignChildrenBlockDirection):

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/flex-flow-border-expected.txt: Added.
  • css3/flexbox/flex-flow-border.html: Added.

Failures are due to not handling orthogonal flows correctly.

  • css3/flexbox/flex-flow-expected.txt: Added.
  • css3/flexbox/flex-flow-margins-expected.txt: Added.
  • css3/flexbox/flex-flow-margins.html: Added.
  • css3/flexbox/flex-flow-orientations-expected.txt: Added.
  • css3/flexbox/flex-flow-orientations.html: Added.
  • css3/flexbox/flex-flow-overflow-expected.txt: Added.
  • css3/flexbox/flex-flow-overflow.html: Added.
  • css3/flexbox/flex-flow-padding-expected.txt: Added.
  • css3/flexbox/flex-flow-padding.html: Added.

Failures are due to not handling orthogonal flows correctly.

  • css3/flexbox/flex-flow.html: Added.
  • css3/flexbox/resources/flexbox.js:

Added the ability to check offsets that include clientLeft/clientTop
and for checking clientWidth/clientHeight. This is neede dfor the border tests.

12:31 PM Changeset in webkit [97782] by Dimitri Glazkov
  • 4 edits
    2 copies in trunk/Tools

Split TestExpectationsEditor into its own file.
​https://bugs.webkit.org/show_bug.cgi?id=70348

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py.
  • Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py.
  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Adjusted for change.
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
  • Scripts/webkitpy/tool/servers/gardeningserver.py: Ditto.
12:24 PM Changeset in webkit [97781] by rniwa@webkit.org
  • 2 edits in trunk/Tools

[Chromium] buildbot runs nrwt with --chromium instead of --chromium-cg-mac
​https://bugs.webkit.org/show_bug.cgi?id=70313

Reviewed by Adam Barth.

Fixed the bug by passing --platform --chromium-cg-mac in RunWebKitTests. We can't always add
this parameter because build-webkit and other scripts don't accept it.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
12:10 PM Changeset in webkit [97780] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

[chromium] Tracking update rects in LayerChromium and CCLayerImpl.
​https://bugs.webkit.org/show_bug.cgi?id=69441

Patch by Shawn Singh <​shawnsingh@chromium.org> on 2011-10-18
Reviewed by James Robinson.

This patch does not do much on its own, but is just part 1 of a
string of other patches which will use these rects for
visualization and scissoring. The appropriate testing will be
associated with those patches.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::cleanupResources):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::updateRect):
(WebCore::CCLayerImpl::setUpdateRect):

11:19 AM Changeset in webkit [97779] by tony@chromium.org
  • 2 edits in branches/chromium/912/Source/WebCore

Merge 97724 - r97638 caused 3 printing crashes
​https://bugs.webkit.org/show_bug.cgi?id=70284

Reviewed by Kent Tamura.

Null check element.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclarations):

TBR=​tkent@chromium.org
Review URL: ​http://codereview.chromium.org/8344008

11:18 AM Changeset in webkit [97778] by annacc@chromium.org
  • 3 edits in trunk/Source/WebCore

Change CodeGeneratorGObject.pm to use g_value_get_uint() instead of g_value_get_ushort()
for IDL attributes of type unsigned short.
​https://bugs.webkit.org/show_bug.cgi?id=70267

Reviewed by Xan Lopez.

Tests: small change to WebKitDOMTestObj.cpp

  • bindings/scripts/CodeGeneratorGObject.pm:

(GetGValueTypeName): convert unsigned short to uint instead of ushort

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_set_property): expect g_value_get_uint instead of g_value_get_ushort
(webkit_dom_test_obj_class_init): expect G_MAXUSHORT instead of G_MAXUINT16

11:06 AM Changeset in webkit [97777] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: ScriptsPanel's should use similar logic to decide whether it could show an anchor location and actually showing it.
​https://bugs.webkit.org/show_bug.cgi?id=70322

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._showSourceLine):

10:56 AM Changeset in webkit [97776] by abarth@webkit.org
  • 2 edits in trunk/Tools

Subscribe myself to WebIDL changes
​https://bugs.webkit.org/show_bug.cgi?id=70341

Reviewed by David Levin.

I've also added some documentation and refactored my previous
subscriptions to make it eaiser for others to subscribe as well.

  • Scripts/webkitpy/common/config/watchlist:
10:39 AM Changeset in webkit [97775] by caryclark@google.com
  • 174 edits
    55 adds in trunk/LayoutTests

Rebaseline most remaining IMAGE diffs for chromium-mac (Skia)
on SnowLeopard (10.6).

Unreviewed gardening.

  • platform/chromium-mac-snowleopard/editing/deleting/delete-3959464-fix-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5569741-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5418891-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/typing-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4242293-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/13804-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5234383-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5234383-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/spelling/spelling-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/block-styles-007-expected.png:
  • platform/chromium-mac/css2.1/20110323/block-replaced-width-001-expected.png:
  • platform/chromium-mac/css2.1/t1602-c43-center-00-d-ag-expected.png:
  • platform/chromium-mac/editing/deleting/delete-3959464-fix-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-and-undo-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-block-contents-003-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-contiguous-ws-001-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-002-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-tab-003-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-to-select-table-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-trailing-ws-002-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-002-expected.png: Added.
  • platform/chromium-mac/editing/execCommand/5569741-expected.png: Added.
  • platform/chromium-mac/editing/execCommand/insert-list-and-stitch-expected.png: Added.
  • platform/chromium-mac/editing/execCommand/insertHorizontalRule-expected.png: Added.
  • platform/chromium-mac/editing/inserting/5418891-expected.png: Added.
  • platform/chromium-mac/editing/inserting/editable-inline-element-expected.png:
  • platform/chromium-mac/editing/inserting/editing-empty-divs-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-br-004-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-br-005-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-br-007-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-div-025-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-paragraph-02-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-paragraph-03-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-tab-002-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-tab-003-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-text-with-newlines-expected.png: Added.
  • platform/chromium-mac/editing/inserting/paragraph-separator-01-expected.png: Added.
  • platform/chromium-mac/editing/inserting/paragraph-separator-02-expected.png: Added.
  • platform/chromium-mac/editing/inserting/paragraph-separator-03-expected.png: Added.
  • platform/chromium-mac/editing/inserting/return-key-with-selection-001-expected.png: Added.
  • platform/chromium-mac/editing/inserting/return-key-with-selection-002-expected.png: Added.
  • platform/chromium-mac/editing/inserting/return-key-with-selection-003-expected.png: Added.
  • platform/chromium-mac/editing/inserting/typing-002-expected.png: Added.
  • platform/chromium-mac/editing/inserting/typing-around-br-001-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/4242293-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/4641033-expected.png:
  • platform/chromium-mac/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/5478250-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-2-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/cut-text-001-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-1-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-2-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/merge-end-blockquote-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/paste-text-019-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/pasting-tabs-expected.png:
  • platform/chromium-mac/editing/selection/13804-expected.png: Added.
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/4397952-expected.png:
  • platform/chromium-mac/editing/selection/5234383-1-expected.png: Added.
  • platform/chromium-mac/editing/selection/5234383-2-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-before-select-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-word-001-expected.png: Added.
  • platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png:
  • platform/chromium-mac/editing/selection/fake-doubleclick-expected.png:
  • platform/chromium-mac/editing/selection/iframe-expected.png:
  • platform/chromium-mac/editing/selection/move-backwords-by-word-001-expected.png: Added.
  • platform/chromium-mac/editing/selection/move-by-character-001-expected.png: Added.
  • platform/chromium-mac/editing/selection/move-by-line-001-expected.png: Added.
  • platform/chromium-mac/editing/selection/move-by-word-001-expected.png: Added.
  • platform/chromium-mac/editing/selection/move-past-trailing-space-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-mac/editing/selection/select-all-001-expected.png:
  • platform/chromium-mac/editing/selection/select-all-002-expected.png:
  • platform/chromium-mac/editing/selection/select-box-expected.png:
  • platform/chromium-mac/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-mac/editing/selection/selection-3748164-fix-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-001-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-003-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-004-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-005-expected.png:
  • platform/chromium-mac/editing/spelling/spelling-expected.png: Added.
  • platform/chromium-mac/editing/style/5046875-1-expected.png:
  • platform/chromium-mac/editing/style/block-styles-007-expected.png: Added.
  • platform/chromium-mac/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
  • platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/chromium-mac/fast/css/color-correction-expected.png:
  • platform/chromium-mac/fast/css/color-correction-on-backgrounds-expected.png:
  • platform/chromium-mac/fast/css/focus-ring-outline-width-expected.png:
  • platform/chromium-mac/fast/css/outline-auto-location-expected.png:
  • platform/chromium-mac/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac/fast/dom/focus-contenteditable-expected.png:
  • platform/chromium-mac/fast/events/autoscroll-expected.png:
  • platform/chromium-mac/fast/events/context-no-deselect-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac/fast/forms/input-placeholder-visibility-2-expected.png:
  • platform/chromium-mac/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac/fast/forms/listbox-hit-test-zoomed-expected.png:
  • platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac/fast/forms/select-listbox-multiple-no-focusring-expected.png:
  • platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac/fast/forms/textarea-scrollbar-expected.png:
  • platform/chromium-mac/fast/forms/textarea-scrolled-type-expected.png:
  • platform/chromium-mac/fast/forms/textfield-outline-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac/fast/inline/continuation-outlines-expected.png:
  • platform/chromium-mac/fast/inline/continuation-outlines-with-layers-2-expected.png:
  • platform/chromium-mac/fast/inline/continuation-outlines-with-layers-expected.png:
  • platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.png:
  • platform/chromium-mac/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-direction-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-masks-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-masks-opacity-expected.png:
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac/fast/text/international/rtl-caret-expected.png:
  • platform/chromium-mac/fast/text/justify-nbsp-expected.png:
  • platform/chromium-mac/fast/text/justify-padding-distribution-expected.png:
  • platform/chromium-mac/fast/transforms/transformed-caret-expected.png:
  • platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac/svg/clip-path/clip-path-transform-1-expected.png: Added.
  • platform/chromium-mac/svg/clip-path/clip-path-transform-2-expected.png: Added.
  • platform/chromium-mac/svg/css/group-with-shadow-expected.png:
  • platform/chromium-mac/svg/custom/alignment-baseline-modes-expected.png:
  • platform/chromium-mac/svg/custom/createImageElement-expected.png:
  • platform/chromium-mac/svg/custom/dominant-baseline-modes-expected.png:
  • platform/chromium-mac/svg/custom/external-paintserver-reference-expected.png: Added.
  • platform/chromium-mac/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-mac/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac/svg/custom/font-face-cascade-order-expected.png:
  • platform/chromium-mac/svg/custom/font-face-simple-expected.png:
  • platform/chromium-mac/svg/custom/glyph-selection-lang-attribute-expected.png:
  • platform/chromium-mac/svg/custom/group-opacity-expected.png:
  • platform/chromium-mac/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/chromium-mac/svg/custom/invalid-css-expected.png:
  • platform/chromium-mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-expected.png:
  • platform/chromium-mac/svg/custom/linking-base-external-reference-expected.png: Added.
  • platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac/svg/custom/text-image-opacity-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium-mac/svg/filters/filter-source-position-expected.png:
  • platform/chromium-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-mac/transforms/2d/compound-transforms-vs-containers-expected.png:
10:37 AM Changeset in webkit [97774] by Dimitri Glazkov
  • 2 edits in trunk/Tools

Add myself to the newfangled watchlist plumbing.
​https://bugs.webkit.org/show_bug.cgi?id=70338

Reviewed by David Levin.

  • Scripts/webkitpy/common/config/watchlist: Added sheepishly.
10:34 AM Changeset in webkit [97773] by eric.carlson@apple.com
  • 19 edits
    3 deletes in trunk/Source/WebCore

2011-10-18 Eric Carlson <​eric.carlson@apple.com>

Use the new cached cue loader
​https://bugs.webkit.org/show_bug.cgi?id=70269

Reviewed by Antti Koivisto.

No new tests, no functionality changed.

  • CMakeLists.txt: Remove CueParser.cpp/h and CueParserPrivate.h.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadTextTracks): (WebCore::HTMLMediaElement::textTrackReadyStateChanged): New, not implemented yet. (WebCore::HTMLMediaElement::textTrackModeChanged): Ditto. (WebCore::HTMLMediaElement::textTrackCreated): Ditto. (WebCore::HTMLMediaElement::textTrackAddCues): Ditto. (WebCore::HTMLMediaElement::textTrackRemoveCues): Ditto. (WebCore::HTMLMediaElement::textTrackAddCue): Ditto. (WebCore::HTMLMediaElement::textTrackRemoveCue): Ditto.
  • html/HTMLMediaElement.h:
  • html/HTMLTrackElement.cpp: (WebCore::HTMLTrackElement::load): Update for interface change (WebCore::HTMLTrackElement::textTrackLoadingCompleted): New, dispatch 'load' or 'error' event.
  • html/HTMLTrackElement.h:
  • html/LoadableTextTrack.cpp: (WebCore::LoadableTextTrack::LoadableTextTrack): Add TextTrackClient and TextTrackLoadingClient

parameters.

(WebCore::LoadableTextTrack::load): Make url parameter KURL instead of String. Create the

cue loader, trigger the load.

(WebCore::LoadableTextTrack::newCuesAvailable): New callback from the loader. Not implemented yet.
(WebCore::LoadableTextTrack::cueLoadingStarted): Ditto.
(WebCore::LoadableTextTrack::cueLoadingCompleted): Ditto.

  • html/LoadableTextTrack.h:
  • html/MutableTextTrack.cpp: (WebCore::MutableTextTrack::MutableTextTrack): Add TextTrackClient parameter.
  • html/MutableTextTrack.h: (WebCore::MutableTextTrack::create):
  • html/TextTrack.cpp: (WebCore::TextTrack::TextTrack): Add TextTrackClient parameter. (WebCore::TextTrack::~TextTrack): Tell the client to remove all cues, forget the client. (WebCore::TextTrack::setReadyState): Tell client about ready state change. (WebCore::TextTrack::setMode): Tell client about mode change.
  • html/TextTrack.h: (WebCore::TextTrackClient::textTrackAddCues): New client interface. (WebCore::TextTrackClient::textTrackRemoveCues): Ditto. (WebCore::TextTrackClient::textTrackAddCue): Ditto. (WebCore::TextTrackClient::textTrackRemoveCue): Ditto. (WebCore::TextTrack::create): (WebCore::TextTrack::trackType): New. (WebCore::TextTrack::client): Ditto. (WebCore::TextTrack::setClient): Ditto.
  • html/track/CueParser.cpp: Removed.
  • html/track/CueParser.h: Removed.
  • html/track/CueParserPrivate.h: Removed.
  • html/track/WebVTTParser.cpp: (WebCore::WebVTTParser::fileIdentifierMaximumLength): New, return length of WebVTT file

magic number.

(WebCore::WebVTTParser::hasRequiredFileIdentifier): Update to use constants instead of hard

coded lengths.

(WebCore::WebVTTParser::WebVTTParser): Initialize "m_client" in the initilization list

instead of setting it in the constructor.

(WebCore::WebVTTParser::getNewCues): Renamed from fetchParsedCues.

  • html/track/WebVTTParser.h: (WebCore::WebVTTParser::create): Take a WebVTTParserClient* instead of a CueParserPrivateClient*.
  • loader/CueLoader.cpp: (WebCore::CueLoader::CueLoader): (WebCore::CueLoader::~CueLoader): Remove client. (WebCore::CueLoader::cueLoadTimerFired): Tell client about new clues and/or that the load

has finished.

(WebCore::CueLoader::processNewCueData): Process newly loaded data.
(WebCore::CueLoader::didReceiveData): Ditto.
(WebCore::CueLoader::notifyFinished): Do final processing as necessary, prime the timer

to call client.

(WebCore::CueLoader::load): Create resource loader, initiate loading.
(WebCore::CueLoader::newCuesParsed): Prime timer to tell client about newly parsed cues.
(WebCore::CueLoader::getNewCues): Get new cues from parser.

  • loader/CueLoader.h: (WebCore::CueLoader::create):
10:33 AM Changeset in webkit [97772] by Dimitri Glazkov
  • 2 edits in trunk/Tools

Fix a unit test in TestFailures.
​https://bugs.webkit.org/show_bug.cgi?id=70337

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Turns out,

the value of a method property should always be lowercase.

10:26 AM QtWebKitHacking edited by caio.oliveira@openbossa.org
File naming conventions (diff)
10:21 AM Changeset in webkit [97771] by abarth@webkit.org
  • 90 edits in trunk

Always enable ENABLE(XPATH)
​https://bugs.webkit.org/show_bug.cgi?id=70217

Reviewed by Eric Seidel.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

As discussed on webkit-dev, we're reducing the complexity of WebKit by
removing unneeded configuration options. ENABLE(XPATH) is enabled on
every port, so we are removing the ability to disable the feature.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.pro:
  • bindings/js/JSCustomXPathNSResolver.cpp:
  • bindings/js/JSCustomXPathNSResolver.h:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):

  • bindings/js/JSExceptionBase.cpp:

(WebCore::toExceptionBase):

  • bindings/js/JSXPathResultCustom.cpp:
  • bindings/objc/DOMCustomXPathNSResolver.h:
  • bindings/objc/DOMCustomXPathNSResolver.mm:
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMUtility.mm:

(JSC::createDOMWrapper):

  • bindings/objc/DOMXPath.mm:

(kit):

  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::getXPathNSResolver):

  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setDOMException):

  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8CustomXPathNSResolver.cpp:
  • bindings/v8/custom/V8CustomXPathNSResolver.h:
  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):

  • dom/Document.cpp:
  • dom/Document.h:
  • dom/Document.idl:
  • dom/ExceptionCode.cpp:

(WebCore::getExceptionCodeDescription):

  • dom/ExceptionCode.h:
  • features.pri:
  • inspector/InspectorDOMAgent.cpp:
  • page/DOMWindow.idl:
  • xml/NativeXPathNSResolver.cpp:
  • xml/NativeXPathNSResolver.h:
  • xml/XPathEvaluator.cpp:
  • xml/XPathEvaluator.h:
  • xml/XPathEvaluator.idl:
  • xml/XPathException.h:
  • xml/XPathException.idl:
  • xml/XPathExpression.cpp:
  • xml/XPathExpression.h:
  • xml/XPathExpression.idl:
  • xml/XPathExpressionNode.cpp:
  • xml/XPathExpressionNode.h:
  • xml/XPathFunctions.cpp:
  • xml/XPathFunctions.h:
  • xml/XPathGrammar.y:
  • xml/XPathNSResolver.cpp:
  • xml/XPathNSResolver.h:
  • xml/XPathNSResolver.idl:
  • xml/XPathNodeSet.cpp:
  • xml/XPathNodeSet.h:
  • xml/XPathParser.cpp:
  • xml/XPathParser.h:
  • xml/XPathPath.cpp:
  • xml/XPathPath.h:
  • xml/XPathPredicate.cpp:
  • xml/XPathPredicate.h:
  • xml/XPathResult.cpp:
  • xml/XPathResult.h:
  • xml/XPathResult.idl:
  • xml/XPathStep.cpp:
  • xml/XPathStep.h:
  • xml/XPathUtil.cpp:
  • xml/XPathUtil.h:
  • xml/XPathValue.cpp:
  • xml/XPathValue.h:
  • xml/XPathVariableReference.cpp:
  • xml/XPathVariableReference.h:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/win:

  • Interfaces/DOMWindow.idl:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
10:17 AM Changeset in webkit [97770] by Dimitri Glazkov
  • 3 edits in trunk/Tools

garden-o-matic should not report flaking in expected failures as failures.
​https://bugs.webkit.org/show_bug.cgi?id=70279

Reviewed by Adam Barth.

On the bots, flakes that are already expected to fail aren't reported as failures (they keep the bot green).
For example, if TEXT failure is expected, a TEXT TIMEOUT result will not cause the redness. We should do the
same for garden-o-matic.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Spuriously changed to use Array iterators rather than jQuery APIs,

rewrote the logic for determining expected or unexpected failures as a central analysis tool.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Added unit tests.
10:06 AM Changeset in webkit [97769] by Chris Fleizach
  • 4 edits
    2 adds in trunk

AX: buttons of number type <input> controls are not fully accessible
​https://bugs.webkit.org/show_bug.cgi?id=70241

Source/WebCore:

Staged commit, part 6.

Reviewed by Darin Adler.

Test: platform/mac/accessibility/html5-input-number.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::addImageMapChildren):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

Reviewed by Darin Adler.

  • platform/mac/accessibility/html5-input-number-expected.txt: Added.
  • platform/mac/accessibility/html5-input-number.html: Added.
10:04 AM Changeset in webkit [97768] by barraclough@apple.com
  • 6 edits in trunk/LayoutTests

Indexed arguments on the Arguments object should be enumerable.
​https://bugs.webkit.org/show_bug.cgi?id=70302

Reviewed by Sam Weinig.

See ECMA-262 5.1 chapter 10.6 step 11b.
This is visible through a number of means, including Object.keys, Object.getOwnPropertyDescriptor, and operator in.

  • fast/js/kde/function-expected.txt:
  • fast/js/kde/script-tests/function.js:

(foo2):

  • This tests using 'in'.
  • fast/js/arguments-expected.txt:
  • fast/js/script-tests/arguments.js:

(descriptor):

  • This tests using 'Object.getOwnPropertyDescriptor'.
  • ietestcenter/Javascript/15.2.3.14-3-4-expected.txt:
    • This tests using 'Object.keys'.
10:03 AM Changeset in webkit [97767] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Indexed arguments on the Arguments object should be enumerable.
​https://bugs.webkit.org/show_bug.cgi?id=70302

Reviewed by Sam Weinig.

See ECMA-262 5.1 chapter 10.6 step 11b.
This is visible through a number of means, including Object.keys, Object.getOwnPropertyDescriptor, and operator in.

  • runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertyDescriptor):

  • The 'enumerable' property should be true for indexed arguments.

(JSC::Arguments::getOwnPropertyNames):

  • Don't guard the adding of indexed properties with 'IncludeDontEnumProperties'.
9:59 AM Changeset in webkit [97766] by alexis.menard@openbossa.org
  • 21 edits
    3 deletes in trunk

[Qt] Merge QML plugin for WebKit2 with the original WebKit1 plugin

.:

We don't need a sepearate plugin, as we no longer expose the WK2
APIs under QtWebKit.experimental, but now use QtWebKit. The version
was also changed to 3.0 instead of 5.0, as the original plugin was
versioned 1.0, and bumping to 3.0 fits the scheme used by QtWebKit releases.

Patch by Tor Arne Vestbø <​tor.arne.vestbo@nokia.com> on 2011-10-18
Reviewed by Andreas Kling.

  • Source/WebKit.pro:

Source/WebKit/qt:

We don't need a separate plugin, as we no longer expose the WK2
APIs under QtWebKit.experimental, but now use QtWebKit. The version
was also changed to 3.0 instead of 5.0, as the original plugin was
versioned 1.0, and bumping to 3.0 fits the scheme used by QtWebKit releases.

Patch by Tor Arne Vestbø <​tor.arne.vestbo@nokia.com> on 2011-10-18
Reviewed by Andreas Kling.

  • declarative/declarative.pro:
  • declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes):

Source/WebKit2:

We don't need a separate plugin, as we no longer expose the WK2
APIs under QtWebKit.experimental, but now use QtWebKit. The version
was also changed to 3.0 instead of 5.0, as the original plugin was
versioned 1.0, and bumping to 3.0 fits the scheme used by QtWebKit releases.

Patch by Tor Arne Vestbø <​tor.arne.vestbo@nokia.com> on 2011-10-18
Reviewed by Andreas Kling.

  • UIProcess/API/qt/qmlplugin/plugin.cpp: Removed.
  • UIProcess/API/qt/qmlplugin/qmldir: Removed.
  • UIProcess/API/qt/qmlplugin/qmlplugin.pro: Removed.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadFail.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgress.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_load.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadFail.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadNegativeSizeView.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgressSignal.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadZeroSizeView.qml:
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml:
9:31 AM Changeset in webkit [97765] by Nate Chapin
  • 16 edits
    2 copies in trunk

Source/WebCore: Make DocumentThreadableLoader a CachedResourceClient.
This will allow us to cache ThreadableLoaderClients as
appropriate in a later patch.
​https://bugs.webkit.org/show_bug.cgi?id=61225

Reviewed by Antti Koivisto.

No new tests, no functionality change intended.

  • WebCore.gypi:
  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::notifyFinished): CachedResourceClients don't send separate callbacks

for didFail() and didFinishLoading(), so we need to differentiate here.

(WebCore::DocumentThreadableLoader::loadRequest): Call CachedResourceLoader::requestRawResource()

instead of ResourceLoadScheduler::scheduleSubresourceLoad().

  • loader/DocumentThreadableLoader.h:
  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::data): Handle the complexity of some ThreadableLoaderClients setting

DoNotBufferData in ResoureLoaderOptions. If the DataBufferingPolicy is BufferData, then the
'data' input parameter will contain all data received so far, and we need to determine the
incremental data to forward to the clients. If the policy is DoNotBufferData, 'data' is just
the incremental data.

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResource.h:

(WebCore::CachedResource::preloadResult):
(WebCore::CachedResource::didSendData):
(WebCore::CachedResource::didDownloadData):
(WebCore::CachedResource::setLoadFinishTime):
(WebCore::CachedResource::loadFinishTime):

  • loader/cache/CachedResourceClient.h: Add several new callbacks needed by DocumentThreadableLoader.
  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveResponse): CachedResource::setResponse() can now cancel

the request, so protect appropriately.

  • loader/cache/CachedResourceRequest.h:
  • loader/chromium/CachedRawResourceChromium.cpp: Added (plumb didDownloadData() to DocumentThreadableLoader).
  • loader/chromium/CachedResourceRequestChromium.cpp: Added (plumb didDownloadData() to DocumentThreadableLoader).
  • loader/chromium/DocumentThreadableLoaderChromium.cpp:
  • platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::notifyResponse): Protect before setting response, since it might kill us.

LayoutTests: Test update for ​https://bugs.webkit.org/show_bug.cgi?id=61225.
Due to changes in the implementation of DocumentThreadableLoader (and
therefore XHR), this test will have empty (rather than null) content
if we go over the length limit.

Reviewed by Antti Koivisto.

  • http/tests/inspector/network/network-content-replacement-xhr-expected.txt:
9:15 AM Changeset in webkit [97764] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

Unreviewed, rolling out r97752.
​http://trac.webkit.org/changeset/97752
​https://bugs.webkit.org/show_bug.cgi?id=70332

Caused assertion failures in MediaList::setParentStyleSheet()
on the apple bots. (Requested by kling on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-18

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.h:
  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::CSSImportRule):
(WebCore::CSSImportRule::~CSSImportRule):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):

  • css/CSSMediaRule.h:
  • css/MediaList.cpp:

(WebCore::MediaList::MediaList):
(WebCore::MediaList::notifyChanged):

  • css/MediaList.h:
  • css/StyleSheet.cpp:

(WebCore::StyleSheet::~StyleSheet):
(WebCore::StyleSheet::setMedia):

9:08 AM Changeset in webkit [97763] by Dimitri Glazkov
  • 1 add in branches/chromium/912/codereview.settings

Added codereview settings.

9:07 AM Changeset in webkit [97762] by annacc@chromium.org
  • 3 edits in trunk/Source/WebCore

Change TextTrack to use the word DISABLED instead of OFF for mode
​https://bugs.webkit.org/show_bug.cgi?id=70268

Reviewed by Daniel Bates.

No new tests. No new functionality.

  • html/TextTrack.cpp:

(WebCore::TextTrack::setMode): use Disabled instead of Off

  • html/TextTrack.h: update Mode enum to use Disabled instead of Off
9:04 AM Changeset in webkit [97761] by Dimitri Glazkov
  • 1 copy in branches/chromium/912

Created branch 912.

8:51 AM Changeset in webkit [97760] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] ASSERT when displaying context menu in input field
​https://bugs.webkit.org/show_bug.cgi?id=69859

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2011-10-18
Reviewed by Simon Hausmann.

When creating a submenu in the context menu, the submenu of type
QWidget is statically cast to QObject before calling setParent on
it. QObject::setParent asserts if the object is a QWidget. So, call
setParent of QWidget itself.

  • UIProcess/qt/WebContextMenuProxyQt.cpp:

(WebKit::WebContextMenuProxyQt::createContextMenu):

8:50 AM Changeset in webkit [97759] by Chris Fleizach
  • 3 edits in trunk/Source/WebCore

AX: buttons of number type <input> controls are not fully accessible
​https://bugs.webkit.org/show_bug.cgi?id=70241

Staged commit, part 5.

Reviewed by Darin Adler.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::boundingBoxRect):

8:48 AM Changeset in webkit [97758] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Move default stylesheet loading to a separate function
​https://bugs.webkit.org/show_bug.cgi?id=70331

Reviewed by Andreas Kling.

  • Move default stylesheet loading out from CSSStyleSelector::styleForElement()
  • Rename e -> element
  • Remove pointless reffing of the placeholder style.
  • css/CSSStyleSelector.cpp:

(WebCore::ensureDefaultStyleSheetsForElement):
(WebCore::isAtShadowBoundary):
(WebCore::CSSStyleSelector::styleForElement):

8:43 AM Changeset in webkit [97757] by Chris Fleizach
  • 4 edits in trunk/Source/WebCore

AX: buttons of number type <input> controls are not fully accessible
​https://bugs.webkit.org/show_bug.cgi?id=70241

Staged commit part 4.

Reviewed by Darin Adler.

  • accessibility/AccessibilityMockObject.h:

(WebCore::AccessibilityMockObject::isMockObject):
(WebCore::AccessibilityMockObject::detachFromParent):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::elementAccessibilityHitTest):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

8:38 AM Changeset in webkit [97756] by Chris Fleizach
  • 7 edits
    2 adds in trunk/Source/WebCore

AX: buttons of number type <input> controls are not fully accessible
​https://bugs.webkit.org/show_bug.cgi?id=70241

Staged commit part 3. Committing the new spin button classes.

Reviewed by Darin Adler.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilitySpinButton.cpp: Added.

(WebCore::AccessibilitySpinButton::create):
(WebCore::AccessibilitySpinButton::AccessibilitySpinButton):
(WebCore::AccessibilitySpinButton::~AccessibilitySpinButton):
(WebCore::AccessibilitySpinButton::incrementButton):
(WebCore::AccessibilitySpinButton::decrementButton):
(WebCore::AccessibilitySpinButton::elementRect):
(WebCore::AccessibilitySpinButton::addChildren):
(WebCore::AccessibilitySpinButton::step):
(WebCore::AccessibilitySpinButtonPart::AccessibilitySpinButtonPart):
(WebCore::AccessibilitySpinButtonPart::create):
(WebCore::AccessibilitySpinButtonPart::elementRect):
(WebCore::AccessibilitySpinButtonPart::press):

  • accessibility/AccessibilitySpinButton.h: Added.

(WebCore::AccessibilitySpinButton::setSpinButtonElement):
(WebCore::AccessibilitySpinButton::roleValue):
(WebCore::AccessibilitySpinButton::accessibilityIsIgnored):
(WebCore::AccessibilitySpinButton::isSpinButton):
(WebCore::AccessibilitySpinButtonPart::~AccessibilitySpinButtonPart):
(WebCore::AccessibilitySpinButtonPart::isIncrementor):
(WebCore::AccessibilitySpinButtonPart::setIsIncrementor):
(WebCore::AccessibilitySpinButtonPart::roleValue):
(WebCore::AccessibilitySpinButtonPart::isSpinButtonPart):
(WebCore::AccessibilitySpinButtonPart::accessibilityIsIgnored):
(WebCore::toAccessibilitySpinButton):
(WebCore::toAccessibilitySpinButtonPart):

8:28 AM Changeset in webkit [97755] by Chris Fleizach
  • 6 edits in trunk/Source

AX: buttons of number type <input> controls are not fully accessible
​https://bugs.webkit.org/show_bug.cgi?id=70241

../WebCore:

Phase 2 of the staged commit.

Reviewed by Darin Adler.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::boundingBoxForQuads):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isSpinButton):
(WebCore::AccessibilityObject::isSpinButtonPart):
(WebCore::AccessibilityObject::isMockObject):

../WebKit/chromium:

Reviewed by Darin Adler.

  • public/WebAccessibilityRole.h:
  • src/AssertMatchingEnums.cpp:
8:26 AM Changeset in webkit [97754] by kov@webkit.org
  • 4 edits in trunk/Source

Fix distcheck.

Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2011-10-18

Source/JavaScriptCore

  • GNUmakefile.list.am: fix a typo and add a missing header to the

list.

Source/WebKit/gtk/po

  • GNUmakefile.am: create po directory when it's not there yet both

when updating the pot and the po files.

8:22 AM Changeset in webkit [97753] by Chris Fleizach
  • 3 edits in trunk/Source/WebCore

AX: buttons of number type <input> controls are not fully accessible
​https://bugs.webkit.org/show_bug.cgi?id=70241

Expose the spin button object to the AX hierarchy. Since there is no distinct
render object that backs this object, a mock object needs to be created for the entire
spin button and the actual increment and decrement buttons inside.

This will be a staged commit since the first time around Windows layout tests started crashing for an undeterminable reason.

Reviewed by Darin Adler.

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::step):
(WebCore::SpinButtonElement::repeatingTimerFired):

  • html/shadow/TextControlInnerElements.h:
8:05 AM Changeset in webkit [97752] by andreas.kling@nokia.com
  • 9 edits in trunk/Source/WebCore

MediaList: Remove inheritance from StyleBase.
​https://bugs.webkit.org/show_bug.cgi?id=70203

Reviewed by Darin Adler.

  • css/MediaList.h:

(WebCore::MediaList::parentStyleSheet):
(WebCore::MediaList::setParentStyleSheet):

  • css/MediaList.cpp:

(WebCore::MediaList::MediaList):
(WebCore::MediaList::notifyChanged):

Change MediaList to no longer inherit from StyleBase. The parent()/setParent()
mechanism was replaced by explicit parentStyleSheet()/setParentStyleSheet().

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::CSSImportRule):
(WebCore::CSSImportRule::~CSSImportRule):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):

Change StyleBase::setParent() calls to MediaList::setParentStyleSheet().
CSSRules are never moved between stylesheets, so the parent style sheet pointer
is valid for the MediaList's lifetime.

  • css/StyleSheet.cpp:

(WebCore::StyleSheet::~StyleSheet):

Change StyleBase::setParent() calls to MediaList::setParentStyleSheet().

(WebCore::StyleSheet::setMedia):

Change StyleBase::setParent() calls to MediaList::setParentStyleSheet().
Assert that the parent sheet is either null, or this, as MediaLists should never
be reparented to other sheets.
Assert that the StyleSheet is indeed a CSSStyleSheet. XSLStyleSheet inherits from
StyleSheet, but it shouldn't be using the MediaList.

  • bindings/js/JSDOMBinding.h:

(WebCore::root):

Add MediaList* specific overload for root() since it can't fall back
to root(StyleBase*) anymore.

  • WebCore.xcodeproj/project.pbxproj:

Add some PrivateHeaders to accomodate the JSDOMBinding.h changes.

  • css/CSSMediaRule.h:

Remove unnecessary forward-declaration of MediaList.

7:35 AM Changeset in webkit [97751] by andreas.kling@nokia.com
  • 7 edits in trunk/Source/WebCore

XSLStyleSheet only needs to manage XSLImportRule children.
​https://bugs.webkit.org/show_bug.cgi?id=70326

Reviewed by Antti Koivisto.

  • css/StyleBase.h:
  • xml/XSLImportRule.h:
  • css/CSSRule.h:

(WebCore::CSSRule::isImportRule):

Move StyleBase::isImportRule() down to CSSRule. Since XSLImportRule no longer
implements it, it's now specific to CSSImportRule.

  • xml/XSLStyleSheet.h:

Change m_children to be a vector of XSLImportRules. Also remove length(),
item() and append() since they were only used internally to modify m_children.

  • xml/XSLStyleSheetQt.cpp:

(WebCore::XSLStyleSheet::~XSLStyleSheet):

  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::~XSLStyleSheet):
(WebCore::XSLStyleSheet::isLoading):
(WebCore::XSLStyleSheet::clearDocuments):
(WebCore::XSLStyleSheet::loadChildSheet):
(WebCore::XSLStyleSheet::locateStylesheetSubResource):

Remove now-unnecessary isImportRule() checks and tidy up the code a bit.

7:22 AM Changeset in webkit [97750] by mihnea@adobe.com
  • 2 edits in trunk/LayoutTests

Unreviewed Qt rebaseline after r97738.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
7:16 AM Changeset in webkit [97749] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Remove const modifier from ctx_menu functions.
​https://bugs.webkit.org/show_bug.cgi?id=70090

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com> on 2011-10-18
Reviewed by Andreas Kling.

Functions ewk_context_menu_show and ewk_context_menu_custom_get
have got const modifer to ensure that Ewk_Context_Menu won't be
changed. The methods emit events through
evas_object_smart_callback_call with Ewk_Context_Menu as parameter
which is converted to void *. In this case an application which
receives those events may change Ewk_Context_Menu.

Additionaly the name of ewk_context_menu_custom_get has been changed
to ewk_context_menu_customize because an application is able to
modify the items of context menu.

  • ewk/ewk_contextmenu.cpp:

(ewk_context_menu_customize):
(ewk_context_menu_show):

  • ewk/ewk_private.h:
7:12 AM Changeset in webkit [97748] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix linkHoveredDoesntEmitRepeated test in the bot
​https://bugs.webkit.org/show_bug.cgi?id=70329

Reviewed by Andreas Kling.

Use LoadSpy::wait() instead of the TestCase::tryCompare(). They should be equivalent,
but I'm getting strange results with tryCompare(). This commit also adds an extra check
to make sure the hovered link is the correct one.

  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml:
6:51 AM Changeset in webkit [97747] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Some QML tests were accidentally committed.
​https://bugs.webkit.org/show_bug.cgi?id=70321

Reviewed by Andreas Kling.

These tests were committed by accident. They should not be there.

  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml:
6:03 AM Changeset in webkit [97746] by Philippe Normand
  • 16 edits
    2 adds
    2 deletes in trunk

[Gtk] Support for client-based geolocation
​https://bugs.webkit.org/show_bug.cgi?id=64970

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2011-10-18
Reviewed by Martin Robinson.

.:

Remove flag for enabling client-based geolocation since
it is used by default on Gtk port and hence not configurable.

  • configure.ac:

Source/WebCore:

Add feature defines for client-based geolocation when geolocation is enabled,
since this is the providing method that is now used by default. Remove
service-based providing method completely as it is not needed anymore.

  • GNUmakefile.am: Add feature defines for client-based geolocation.
  • GNUmakefile.list.am: Remove GeolocationServiceGtk.* files from compilation.
  • platform/gtk/GeolocationServiceGtk.cpp: Removed.
  • platform/gtk/GeolocationServiceGtk.h: Removed.

Source/WebKit/gtk:

Add DumpRenderTree support functions for client-based geolocation tests
and implement GeolocationClientGtk. The implementation is based on Zecke's
implementation of GeolocationService class in WebCore, which is now redundant
and subsequently removed.

  • GNUmakefile.am: Add GeolocationClientGtk.* files to compilation.
  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Add support functions to operate

with GeolocationClientMock.
(DumpRenderTreeSupportGtk::resetGeolocationClientMock):
(DumpRenderTreeSupportGtk::setMockGeolocationPermission):
(DumpRenderTreeSupportGtk::setMockGeolocationPosition):
(DumpRenderTreeSupportGtk::setMockGeolocationError):
(DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
  • WebCoreSupport/GeolocationClientGtk.cpp: Added.

(WebKit::getPositionCallback):
(WebKit::positionChangedCallback):
(WebKit::GeolocationClient::GeolocationClient):
(WebKit::GeolocationClient::geolocationDestroyed):
(WebKit::GeolocationClient::startUpdating):
(WebKit::GeolocationClient::stopUpdating):
(WebKit::GeolocationClient::setEnableHighAccuracy):
(WebKit::GeolocationClient::lastPosition):
(WebKit::GeolocationClient::requestPermission):
(WebKit::GeolocationClient::cancelPermissionRequest):
(WebKit::GeolocationClient::positionChanged):
(WebKit::GeolocationClient::updatePosition):
(WebKit::GeolocationClient::errorOccured):

  • WebCoreSupport/GeolocationClientGtk.h: Added.
  • webkit/webkitwebview.cpp:

(webkit_web_view_init): Use GeolocationClientMock as geolocation client
when running in DumpRenderTree.

Tools:

Add support for testing client-based geolocation tests in DumpRenderTree.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues): Reset GeolocationClientMock.
(createWebView): Create web view after declaring DumpRenderTree mode.
That way a mock client for geolocation is used instead of a GeoClue
client if a web view is created when testing.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Implement functions for

geolocation layout tests.
(LayoutTestController::setMockGeolocationPosition):
(LayoutTestController::setMockGeolocationError):
(LayoutTestController::setGeolocationPermission):
(LayoutTestController::numberOfPendingGeolocationPermissionRequests):

  • Scripts/build-webkit: Note that the Gtk port is using client-based

geolocation, even though changing this flag has no effect on compilation.

LayoutTests:

Unskip geolocation tests that now pass.

  • platform/gtk/Skipped:
5:58 AM Changeset in webkit [97745] by Antti Koivisto
  • 4 edits
    2 adds in trunk

REGRESSION(r97248): :visited as descendant selector broken
​https://bugs.webkit.org/show_bug.cgi?id=70122

Source/WebCore:

Reviewed by Nikolas Zimmerman.

Make ":visited foo" and similar selectors work correctly again. They can affect
the visited style of an element inside a visited link.

Test: fast/selectors/visited-descendant.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclarations):

Apply visited style to children of visited links too.


  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector):

Don't disable visited matching until we run into first ancestor link or use combinator other than child/descendant.

(WebCore::SelectorChecker::determineLinkMatchType):

Look into child/descendant component selectors too to determine the link match type.

LayoutTests:

Reviewed by Nikolas Zimmerman.

  • fast/selectors/visited-descendant.html: Added.
  • platform/mac/fast/selectors/visited-descendant-expected.txt: Added.
5:52 AM Changeset in webkit [97744] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Send mouse move events when we handle HoverEnter/Leave in QDesktopWebView
​https://bugs.webkit.org/show_bug.cgi?id=70297

Reviewed by Simon Hausmann.

Qt treat the first and last hover movements as special HoverMove and HoverLeave events, but
WebKit doesn't make the difference, so we need to create move events for them.

While HoverEnter is in practice equivalent to HoverMove, the HoverLeave event is a bit
different because we want to emulate that the mouse is not only leaving the current node, but
completely leaving the whole document. The way to do this is to manufacture a move event with
a very far position, and was inspired by WebView::handleMouseEvent() in
Source/WebKit/win/WebView.cpp.

This patch fixes DesktopWebViewLinkHovered QML tests.

  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::handleEvent):
(QDesktopWebPageProxy::handleHoverLeaveEvent):

  • UIProcess/qt/qdesktopwebpageproxy.h:
5:51 AM Changeset in webkit [97743] by caseq@chromium.org
  • 4 edits in trunk/Tools

2011-10-07 Andrey Kosyakov <​caseq@chromium.org>

[Chromium] suppress console output from DevTools window
​https://bugs.webkit.org/show_bug.cgi?id=69632

Reviewed by Pavel Feldman.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::showDevTools):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didAddMessageToConsole): (WebViewHost::reset): (WebViewHost::setLogConsoleOutput):
  • DumpRenderTree/chromium/WebViewHost.h:
5:46 AM Changeset in webkit [97742] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

Move CSSRule specific virtuals from StyleBase down into CSSRule.
​https://bugs.webkit.org/show_bug.cgi?id=70240

Reviewed by Darin Adler.

Move all the isFooRule() virtuals except isImportRule() to CSSRule
since they only make sense for its subclasses. isRule() remains in
StyleBase since we still need it for the parent chain traversal.
isImportRule() remains because XSLImportRule implements it.

Also moved insertedIntoParent() and removed its usage in
XSLStyleSheet since it is only reimplemented by CSSImportRule.

  • css/CSSRule.h:

(WebCore::CSSRule::isCharsetRule):
(WebCore::CSSRule::isFontFaceRule):
(WebCore::CSSRule::isKeyframeRule):
(WebCore::CSSRule::isKeyframesRule):
(WebCore::CSSRule::isMediaRule):
(WebCore::CSSRule::isPageRule):
(WebCore::CSSRule::isStyleRule):
(WebCore::CSSRule::isRegionStyleRule):
(WebCore::CSSRule::insertedIntoParent):

  • css/StyleBase.h:

(WebCore::StyleBase::isImportRule):
(WebCore::StyleBase::isCSSStyleSheet):

  • xml/XSLStyleSheet.h:

(WebCore::XSLStyleSheet::append):

5:39 AM Changeset in webkit [97741] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Option.value should trim extra internal html spaces
​https://bugs.webkit.org/show_bug.cgi?id=69455

Patch by Sachin Puranik <​jcqt43@motorola.com> on 2011-10-18
Reviewed by Kent Tamura.

Currently option.value does not trim the internal white space as suggested by spec. This patch implements the same.

Source/WebCore:

Test: fast/forms/option-value-trim-html-spaces.html

  • dom/OptionElement.cpp: Removed a function as this implementation is moved to the HTMLOptionElement.cpp file.
  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::value): Implementation of .value function which will now trim the html white spaces.

LayoutTests:

  • fast/forms/option-value-trim-html-spaces-expected.txt: Test case to test the text triming on the value attribute.
  • fast/forms/option-value-trim-html-spaces.html: Test case to test the text triming on the value attribute.
5:29 AM Changeset in webkit [97740] by alexis.menard@openbossa.org
  • 11 edits
    1 move
    5 adds
    2 deletes in trunk/Source/WebKit2

[Qt][WK2] WebPreferences are impossible to use in QML.
​https://bugs.webkit.org/show_bug.cgi?id=70141

Reviewed by Kenneth Rohde Christiansen.

Make it possible to use qwkpreferences in QML. Renamed it
to follow our new style regarding class names. This class is
now a QObject that is exposed as a property of the view.
The tests give an idea of the usage.

  • UIProcess/API/qt/WKView.h:
  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebView::preferences):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qmlplugin/plugin.cpp:

(WebKit2QmlPlugin::registerTypes):

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::preferences):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qwebpreferences.cpp: Added.

(QWebPreferencesPrivate::createPreferences):
(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferencesPrivate::setFontFamily):
(QWebPreferencesPrivate::fontFamily):
(QWebPreferencesPrivate::setFontSize):
(QWebPreferencesPrivate::fontSize):
(QWebPreferences::QWebPreferences):
(QWebPreferences::~QWebPreferences):
(QWebPreferences::autoLoadImages):
(QWebPreferences::setAutoLoadImages):
(QWebPreferences::javascriptEnabled):
(QWebPreferences::setJavascriptEnabled):
(QWebPreferences::pluginsEnabled):
(QWebPreferences::setPluginsEnabled):
(QWebPreferences::offlineWebApplicationCacheEnabled):
(QWebPreferences::setOfflineWebApplicationCacheEnabled):
(QWebPreferences::localStorageEnabled):
(QWebPreferences::setLocalStorageEnabled):
(QWebPreferences::XSSAuditingEnabled):
(QWebPreferences::setXSSAuditingEnabled):
(QWebPreferences::privateBrowsingEnabled):
(QWebPreferences::setPrivateBrowsingEnabled):
(QWebPreferences::dnsPrefetchEnabled):
(QWebPreferences::setDnsPrefetchEnabled):
(QWebPreferences::standardFontFamily):
(QWebPreferences::setStandardFontFamily):
(QWebPreferences::fixedFontFamily):
(QWebPreferences::setFixedFontFamily):
(QWebPreferences::serifFontFamily):
(QWebPreferences::setSerifFontFamily):
(QWebPreferences::sansSerifFontFamily):
(QWebPreferences::setSansSerifFontFamily):
(QWebPreferences::cursiveFontFamily):
(QWebPreferences::setCursiveFontFamily):
(QWebPreferences::fantasyFontFamily):
(QWebPreferences::setFantasyFontFamily):
(QWebPreferences::minimumFontSize):
(QWebPreferences::setMinimumFontSize):
(QWebPreferences::defaultFontSize):
(QWebPreferences::setDefaultFontSize):
(QWebPreferences::defaultFixedFontSize):
(QWebPreferences::setDefaultFixedFontSize):

  • UIProcess/API/qt/qwebpreferences.h: Added.
  • UIProcess/API/qt/qwebpreferences_p.h: Added.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/javascript.html: Added.
  • UIProcess/API/qt/tests/qmltests/common/localStorage.html: Added.
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::preferences):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/qwkpreferences.cpp: Removed.
  • UIProcess/qt/qwkpreferences.h: Removed.
  • UIProcess/qt/qwkpreferences_p.h: Removed.
  • WebKit2.pro:
  • WebKit2API.pri:
4:52 AM Changeset in webkit [97739] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Fix compilation error by include WebErrors.h file.
​https://bugs.webkit.org/show_bug.cgi?id=70309

Unreviewed build fix

Added a header file to fix compilation error.

Patch by Tomasz Morawski <​t.morawski@samsung.com> on 2011-10-18

  • WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:
4:50 AM Changeset in webkit [97738] by mihnea@adobe.com
  • 29 edits
    4 adds in trunk

[CSS Regions]Parse @-webkit-region rule
​https://bugs.webkit.org/show_bug.cgi?id=70021

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/parsing-region-style-rule.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMCSS.mm:

(kitClass):

  • bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::toV8):

  • css/CSSGrammar.y:
  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::cssText):

  • css/CSSParser.cpp:

(WebCore::CSSParser::setReusableRegionSelectorVector):
(WebCore::CSSParser::createRegionStylingRule):

  • css/CSSParser.h:

(WebCore::CSSParser::reusableRegionSelectorVector):

  • css/CSSRegionStyleRule.cpp: Added.

(WebCore::CSSRegionStyleRule::CSSRegionStyleRule):
(WebCore::CSSRegionStyleRule::~CSSRegionStyleRule):
(WebCore::CSSRegionStyleRule::cssText):

  • css/CSSRegionStyleRule.h: Added.
  • css/CSSRule.h:
  • css/CSSRule.idl:
  • css/CSSRuleList.cpp:

(WebCore::CSSRuleList::item):
(WebCore::CSSRuleList::rulesText):

  • css/CSSRuleList.h:
  • css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::selectorsText):

  • css/CSSSelectorList.h:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::addRegionStyleRule):
(WebCore::RuleSet::addRulesFromSheet):

  • css/CSSStyleSelector.h:
  • css/StyleBase.h:

(WebCore::StyleBase::isRegionStyleRule):

  • css/tokenizer.flex:

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt:
  • fast/regions/parsing-region-style-rule-expected.txt: Added.
  • fast/regions/parsing-region-style-rule.html: Added.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt:
4:41 AM Changeset in webkit [97737] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r97735.
​http://trac.webkit.org/changeset/97735
​https://bugs.webkit.org/show_bug.cgi?id=70317

some people apparently use build-jsc with the qt port without
building webkit first (Requested by torarne on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-18

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(buildQMakeProject):
(buildQMakeQtProject):

3:56 AM Changeset in webkit [97736] by Philippe Normand
  • 35 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r97602 and r97596.

  • platform/gtk/css2.1/t0511-c21-pseud-link-02-e-expected.txt:
  • platform/gtk/css2.1/t0511-c21-pseud-link-03-e-expected.txt:
  • platform/gtk/css3/selectors3/html/css3-modsel-17-expected.txt:
  • platform/gtk/css3/selectors3/html/css3-modsel-61-expected.txt:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-17-expected.txt:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-61-expected.txt:
  • platform/gtk/css3/selectors3/xml/css3-modsel-17-expected.txt:
  • platform/gtk/css3/selectors3/xml/css3-modsel-61-expected.txt:
  • platform/gtk/fast/backgrounds/background-leakage-transforms-expected.txt:
  • platform/gtk/fast/block/float/float-in-float-hit-testing-expected.txt:
  • platform/gtk/fast/block/margin-collapse/056-expected.txt:
  • platform/gtk/fast/dom/34176-expected.txt:
  • platform/gtk/fast/events/reveal-link-when-focused-expected.txt:
  • platform/gtk/fast/history/visited-link-background-color-expected.txt:
  • platform/gtk/fast/overflow/overflow_hidden-expected.txt:
  • platform/gtk/fast/selectors/017-expected.txt:
  • platform/gtk/fast/selectors/061-expected.txt:
  • platform/gtk/fast/table/028-vertical-expected.txt:
  • platform/gtk/fast/table/height-percent-test-vertical-expected.txt:
  • platform/gtk/fast/writing-mode/fallback-orientation-expected.txt:
  • platform/gtk/svg/hixie/cascade/002-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug26553-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug46623-1-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug51140-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug8950-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
3:36 AM Changeset in webkit [97735] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Remove dead code in build-webkit

build-webkit will iterate over a list of subdirectories to build,
but this feature is only used by the Apple ports. For QtWebKit we
always pass an empty directory to buildQMakeProject, which makes
the logic for dealing with sub-projects in buildQMakeProject just
added noise.

If we do want this feature at some point, we should redo it in
the context of the upcoming build system changes for Qt.

Reviewed by Simon Hausmann.

3:14 AM BuildingQt5OnHarmattan edited by jocelyn.turcotte@nokia.com
Updated the patch set to include the latest fixes. (diff)
3:05 AM BuildingQt5OnHarmattan edited by jocelyn.turcotte@nokia.com
Updated the patch set to include the latest fixes. (diff)
3:04 AM Changeset in webkit [97734] by vestbo@webkit.org
  • 3 edits in trunk/Tools

Remove traces of Symbian support from the build scripts

Reviewed by Simon Hausmann.

3:03 AM Changeset in webkit [97733] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Source/WebKit2

[Qt][WK2] Implement geolocation provider for qt port
​https://bugs.webkit.org/show_bug.cgi?id=59199

Patch by Adenilson Cavalcanti <​adenilson.silva@openbossa.org> on 2011-10-18
Reviewed by Simon Hausmann.

Based on patch by Kenneth Christiansen <​kenneth.r.christiansen@nokia.com>

Implements default location provider for WK2 QtWebKit (WebGeolocationProviderQt),
allowing QtWebKit clients to implement or override their own provider using WK2 APIs.

  • UIProcess/API/C/WKGeolocationManager.h:
  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

  • UIProcess/qt/WebGeolocationProviderQt.cpp: Added.

(toLocationProvider):
(locationStartUpdating):
(locationStopUpdating):
(WebGeolocationProviderQt::create):
(WebGeolocationProviderQt::provider):
(WebGeolocationProviderQt::WebGeolocationProviderQt):
(WebGeolocationProviderQt::~WebGeolocationProviderQt):
(WebGeolocationProviderQt::updateTimeout):
(WebGeolocationProviderQt::positionUpdated):
(WebGeolocationProviderQt::startUpdating):
(WebGeolocationProviderQt::stopUpdating):

  • UIProcess/qt/WebGeolocationProviderQt.h: Added.
  • WebKit2.pro:
2:28 AM Changeset in webkit [97732] by podivilov@chromium.org
  • 5 edits in trunk

Web Inspector: support displaying multiple sources per single script in ScriptsPanel.
​https://bugs.webkit.org/show_bug.cgi?id=69847

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._removeSourceFrame):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):

LayoutTests:

  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
2:18 AM Changeset in webkit [97731] by kbalazs@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

ParallelJobs: maximum number of threads should be determined dynamically
​https://bugs.webkit.org/show_bug.cgi?id=68540

Reviewed by Zoltan Herczeg.

Add logic to determine the number of cores and use this as
the maximum number of threads. The implementation currently
covers Linux, Darwin, Windows, AIX, Solaris, OpenBSD and NetBSD.
The patch was tested on Linux, Mac and Windows which was enough to
cover all code path. It should work on the rest accoring to the
documentation of those OS's. The hard coded constant is still used
on uncovered OS's which should be fixed in the future.

  • wtf/ParallelJobs.h: Removed the default value of the requestedJobNumber

argument because clients should always fill it and the 0 default value
was incorrect anyway.
(WTF::ParallelJobs::ParallelJobs):

  • wtf/ParallelJobsGeneric.cpp:

(WTF::ParallelEnvironment::determineMaxNumberOfParallelThreads):

  • wtf/ParallelJobsGeneric.h:

(WTF::ParallelEnvironment::ParallelEnvironment):

2:11 AM Changeset in webkit [97730] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix after r97672.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2:09 AM Changeset in webkit [97729] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2011-10-18 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix lion build breakage s/class Length/struct Length/.

  • loader/cache/CachedImage.h:
  • platform/graphics/Image.h:
1:48 AM Changeset in webkit [97728] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[UNIX] Use SOCK_SEQPACKET when available
​https://bugs.webkit.org/show_bug.cgi?id=61287

Reviewed by Darin Adler.

Sockets of type SEQPACKET are actually DGRAM sockets but that
notifies the other end when the connection is closed. When
SEQPACKET sockets are not available GTK+ port uses STREAM sockets
while Qt port uses DGRAM sockets.

  • PluginProcess/PluginProcess.cpp: Use SOCK_SEQPACKET if possible.
  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess): Ditto.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess): Ditto.

1:39 AM Changeset in webkit [97727] by Nikolas Zimmermann
  • 17 edits in trunk/Source/WebCore

2011-10-18 Nikolas Zimmermann <​nzimmermann@rim.com>

Prepare SVGImage intrinsic size negotiation: Add intrinsic size & ratio calculation functionality to Image
​https://bugs.webkit.org/show_bug.cgi?id=70314

Reviewed by Antti Koivisto.

Add a "void computeIntrinsicDimension(Length& intrinsicWidth, Lengt& intrinsicHeight, FloatSize& intrinsicRatio)" helper method
to Image/GeneratedImage/SVGImage and make it accessible through StyleImage.

For a regular Image the intrinsicWidth/Height contains just a Length(size().width(), Fixed). In contrary SVGImages pass on the
style()->width()/height() values from the render style of the RenderSVGRoot renderer. These information are needed to implement
the size negotiation between embedded SVG images and the embedder.

No new tests, as this new functionality is not yet used.

  • loader/cache/CachedImage.cpp: (WebCore::CachedImage::computeIntrinsicDimensions):
  • loader/cache/CachedImage.h:
  • platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::computeIntrinsicDimensions):
  • platform/graphics/GeneratedImage.h:
  • platform/graphics/Image.cpp: (WebCore::Image::computeIntrinsicDimensions):
  • platform/graphics/Image.h:
  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::computeIntrinsicDimensions):
  • platform/graphics/cg/PDFDocumentImage.h:
  • rendering/style/StyleCachedImage.cpp: (WebCore::StyleCachedImage::computeIntrinsicDimensions):
  • rendering/style/StyleCachedImage.h:
  • rendering/style/StyleGeneratedImage.cpp: (WebCore::StyleGeneratedImage::computeIntrinsicDimensions):
  • rendering/style/StyleGeneratedImage.h:
  • rendering/style/StyleImage.h:
  • rendering/style/StylePendingImage.h: (WebCore::StylePendingImage::computeIntrinsicDimensions):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::computeIntrinsicDimensions):
  • svg/graphics/SVGImage.h:
1:04 AM Changeset in webkit [97726] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] Different dimensions are reported for elements onscreen and in the Metrics pane
​https://bugs.webkit.org/show_bug.cgi?id=70242

Reviewed by Pavel Feldman.

  • inspector/DOMNodeHighlighter.cpp:
12:20 AM Changeset in webkit [97725] by haraken@chromium.org
  • 9 edits in trunk

Unreviewed, rolling out r97697.
​http://trac.webkit.org/changeset/97697
​https://bugs.webkit.org/show_bug.cgi?id=68978

some tests are broken

Source/WebCore:

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):
(WebCore::V8MessageEvent::portsAccessorGetter):
(WebCore::V8MessageEvent::initMessageEventCallback):

  • dom/MessageEvent.cpp:

(WebCore::MessageEventInit::MessageEventInit):
(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::isMessageEvent):

  • dom/MessageEvent.h:

(WebCore::MessageEvent::create):
(WebCore::MessageEvent::dataAsSerializedScriptValue):
(WebCore::MessageEvent::dataAsString):
(WebCore::MessageEvent::dataAsBlob):
(WebCore::MessageEvent::dataAsArrayBuffer):

  • dom/MessageEvent.idl:

LayoutTests:

  • fast/events/constructors/message-event-constructor-expected.txt:
  • fast/events/constructors/message-event-constructor.html:
Note: See TracTimeline for information about the timeline view.