Context Navigation

← Previous Period
Next Period →

Timeline

Oct 24, 2011:

11:59 PM Changeset in webkit [98323] by Csaba Osztrogonác

1 edit
4 adds in trunk/LayoutTests

[Qt] Unreviewed gardening, add missing result after r98309.

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-10-24

platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
platform/qt/svg/filters/feColorMatrix-default-type-expected.png: Added.
platform/qt/svg/filters/feColorMatrix-default-type-expected.txt: Added.

11:51 PM Changeset in webkit [98322] by Martin Robinson

3 edits in trunk/LayoutTests

REGRESSION (r97865): broke plugins/resize-from-plugin.html on GTK
https://bugs.webkit.org/show_bug.cgi?id=70481

Update test results to reflect that the plugin clipping rectangle
is now correct.

platform/gtk/Skipped: Unskip the test.
platform/gtk/plugins/resize-from-plugin-expected.txt: Update results.

10:43 PM Changeset in webkit [98321] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

DFG JIT 32_64 - fillInteger should accept DataFormatJSInteger
https://bugs.webkit.org/show_bug.cgi?id=70798

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-24
Reviewed by Filip Pizlo.

When filling an integer for a known integer node (not speculated), it
should accept DataFormatJSInteger as well.

dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::fillInteger):

9:57 PM Changeset in webkit [98320] by ggaren@apple.com

2 edits in trunk/Source/WebCore

Chromium build fix: #include window.h for HANDLE.

platform/graphics/opentype/OpenTypeUtilities.h:

9:49 PM Changeset in webkit [98319] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Include ThreadSafeRefCounted.h since the class declared in this header file
inherits from ThreadSafeRefCounted.

storage/IDBIndexBackendInterface.h:

9:33 PM Changeset in webkit [98318] by ggaren@apple.com

5 edits in trunk/Source

Build fix: removed some cases of threadsafeCopy() that I missed in
my previous patch.

Source/JavaScriptCore:

JavaScriptCore.order:

Source/WebKit/win:

WebDatabaseManager.cpp:

(DidModifyOriginData::dispatchToMainThread):

WebDownloadCFNet.cpp:

(WebDownload::initToResumeWithBundle):

WebIconDatabase.cpp:

(WebIconDatabase::didImportIconURLForPageURL):

9:26 PM Changeset in webkit [98317] by rniwa@webkit.org

4 edits in trunk/Source

Source/WebCore: Fix a typo.

bindings/v8/JavaScriptCallFrame.h:

Source/WebKit/win: threadsafeCopy has been renamed to isolatedCopy.

WebDatabaseManager.cpp:

(DidModifyOriginData::dispatchToMainThread):

8:54 PM Changeset in webkit [98316] by ggaren@apple.com

86 edits
3 deletes in trunk/Source

Removed SharedUChar and tightened language around its previous uses
https://bugs.webkit.org/show_bug.cgi?id=70698

Reviewed by David Levin.

Source/JavaScriptCore:

Removed SharedUChar because most of its functionality has moved into

other abstraction layers, and we want remaining clients to choose their
abstractions explicitly instead of relying on StringImpl to provide this
behavior implicitly, since we think they can sometimes make more efficient
choices.

Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because

the former names could give the impression that the resulting object was
thread-safe, but actually it's just an isolated copy, which is not
thread-safe by itself, but can be used to implement a thread-safe
algorithm through isolation.

wtf/CrossThreadRefCounted.h: Removed.

JavaScriptCore.exp: Export!

wtf/text/StringImpl.cpp:

(WTF::StringImpl::~StringImpl): Removed the stuff mentioned above.

wtf/text/StringImpl.h:

(WTF::StringImpl::length): Ditto.

(WTF::StringImpl::isolatedCopy): Inlined this, since it's now trivial.

wtf/text/WTFString.cpp:

(WTF::String::isolatedCopy):

wtf/text/WTFString.h: Updated for StringImpl changes.

API/OpaqueJSString.h:
GNUmakefile.list.am:
JavaScriptCore.exp:
JavaScriptCore.gypi:
JavaScriptCore.order:
JavaScriptCore.vcproj/WTF/WTF.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/OwnFastMallocPtr.h:
wtf/RefCounted.h:
wtf/SizeLimits.cpp:
wtf/ThreadSafeRefCounted.h:
wtf/wtf.pri:
yarr/YarrPattern.h: Updated these files to accomodate removal of

CrossThreadRefCounted.h.

Source/WebCore:

Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because

the former names gave the dangerous misimpression that the resulting object
was thread-safe, which is not true.

Updated a bunch of files for header dependency changes, now that

CrossThreadRefCounted is gone.

ForwardingHeaders/wtf/CrossThreadRefCounted.h: Removed.
WebCore.exp.in:
bindings/js/ScriptHeapSnapshot.h:
bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::release):
(WebCore::SerializedScriptValue::SerializedScriptValue):

css/CSSPropertySourceData.h:
css/CSSValue.h:
css/StyleMedia.h:
css/WebKitCSSMatrix.h:
dom/QualifiedName.h:
fileapi/LocalFileSystem.h:

(WebCore::LocalFileSystem::SystemBasePath::operator String):

history/CachedFrame.h:
history/CachedPage.h:
history/HistoryItem.h:
html/canvas/CanvasStyle.h:
inspector/InspectorResourceAgent.h:
loader/FormState.h:
loader/TextResourceDecoder.h:
loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):

loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::open):
(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::synchronousIconURLForPageURL):
(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::setIconURLForPageURL):
(WebCore::IconDatabase::databasePath):
(WebCore::IconDatabase::defaultDatabaseFilename):
(WebCore::ImportedIconURLForPageURLWorkItem::ImportedIconURLForPageURLWorkItem):
(WebCore::ImportedIconDataForPageURLWorkItem::ImportedIconDataForPageURLWorkItem):

page/ContentSecurityPolicy.h:
page/Coordinates.h:

(WebCore::Coordinates::isolatedCopy):

page/Geoposition.h:

(WebCore::Geoposition::isolatedCopy):

page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::isolatedCopy):

page/SecurityOrigin.h:
page/animation/AnimationBase.h:
platform/CrossThreadCopier.cpp:

(WebCore::::copy):

platform/FileChooser.h:
platform/KURL.cpp:

(WebCore::KURL::copy):

platform/cf/SchedulePair.h:
platform/network/BlobData.cpp:

(WebCore::BlobDataItem::detachFromCurrentThread):
(WebCore::BlobData::detachFromCurrentThread):

platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::copyData):

platform/network/MIMEHeader.h:
platform/network/ResourceErrorBase.cpp:

(WebCore::ResourceErrorBase::copy):

platform/network/ResourceLoadInfo.h:
platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::copyData):

platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::copyData):

platform/sql/SQLValue.cpp:

(WebCore::SQLValue::SQLValue):
(WebCore::SQLValue::string):

rendering/style/QuotesData.h:
storage/AbstractDatabase.cpp:

(WebCore::updateGuidVersionMap):
(WebCore::AbstractDatabase::AbstractDatabase):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::stringIdentifier):
(WebCore::AbstractDatabase::displayName):
(WebCore::AbstractDatabase::fileName):
(WebCore::AbstractDatabase::setExpectedVersion):
(WebCore::AbstractDatabase::getCachedVersion):

storage/ChangeVersionWrapper.cpp:

(WebCore::ChangeVersionWrapper::ChangeVersionWrapper):

storage/Database.cpp:

(WebCore::Database::Database):
(WebCore::Database::tableNames):

storage/DatabaseDetails.h:
storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::setDatabaseDirectoryPath):
(WebCore::DatabaseTracker::databaseDirectoryPath):
(WebCore::DatabaseTracker::trackerDatabasePath):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::originPath):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::populateOrigins):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::recordCreatingDatabase):
(WebCore::DatabaseTracker::recordDeletingDatabase):
(WebCore::DatabaseTracker::recordDeletingOrigin):
(WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged):

storage/OriginQuotaManager.cpp:

(WebCore::OriginQuotaManager::trackOrigin):
(WebCore::OriginQuotaManager::addDatabase):

storage/SQLError.h:

(WebCore::SQLError::message):
(WebCore::SQLError::SQLError):

storage/SQLResultSetRowList.h:
storage/SQLStatement.cpp:

(WebCore::SQLStatement::SQLStatement):

storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::StorageAreaSync):
(WebCore::StorageAreaSync::syncTimerFired):

storage/StorageAreaSync.h:
storage/StorageMap.cpp:

(WebCore::StorageMap::importItem):

storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::StorageNamespaceImpl):

storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::StorageSyncManager):

storage/StorageTracker.cpp:

(WebCore::StorageTracker::StorageTracker):
(WebCore::StorageTracker::syncImportOriginIdentifiers):
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::willDeleteAllOrigins):

svg/SVGPathSeg.h:
workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::url):
(WebCore::SharedWorkerProxy::name):
(WebCore::SharedWorkerProxy::SharedWorkerProxy):
(WebCore::DefaultSharedWorkerRepository::getProxy):

workers/SharedWorkerThread.cpp:

(WebCore::SharedWorkerThread::SharedWorkerThread):

workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerExceptionTask::WorkerExceptionTask):
(WebCore::PostMessageToPageInspectorTask::PostMessageToPageInspectorTask):

workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::Task):

workers/WorkerThread.cpp:

(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):

Source/WebKit/chromium:

Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because

the former names gave the dangerous misimpression that the resulting object
was thread-safe, which is not true.

src/WorkerFileSystemCallbacksBridge.cpp:

Source/WebKit/mac:

Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because

the former names gave the dangerous misimpression that the resulting object
was thread-safe, which is not true.

Storage/WebDatabaseTrackerClient.mm:

(DidModifyOriginData::dispatchToMainThread):

8:36 PM Changeset in webkit [98315] by mnaganov@chromium.org

5 edits in trunk/Tools

Fix bug summary when rolling Chromium DEPS to LKGR.
https://bugs.webkit.org/show_bug.cgi?id=69917

Reviewed by Adam Barth.

Scripts/webkitpy/tool/bot/irc_command.py:
Scripts/webkitpy/tool/bot/sheriff.py:
Scripts/webkitpy/tool/commands/roll.py:
Scripts/webkitpy/tool/commands/roll_unittest.py:

8:17 PM Changeset in webkit [98314] by abarth@webkit.org

1 edit
1 delete in trunk/Source/WebCore

Remove empty directory.

p2p: Removed.

7:54 PM Changeset in webkit [98313] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

[chromium] Refactor painting/updating/drawing code.
https://bugs.webkit.org/show_bug.cgi?id=70057

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-10-24
Reviewed by James Robinson.

This refactoring separates the "early exits" from the actual loop
that draws layers. As part of this, it was also appropriate to
clean up the way that masks and replicas are dealt with when
painting and updating. The purpose of all this is to make things
easier to test, and for a scissoring optimization that needs to
know exatly what gets drawn. Existing layout tests were able to
verify the refactoring did not change behavior.

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):

platform/graphics/chromium/LayerRendererChromium.h:
platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

platform/graphics/chromium/cc/CCLayerTreeHost.h:
platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::layerShouldBeAppended):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):

7:53 PM Changeset in webkit [98312] by jchaffraix@webkit.org

1 edit
2 adds in trunk/LayoutTests

Unreviewed gardening.

Add a new baseline for snow-leopard.

platform/chromium-mac-snowleopard/svg/filters: Added.
platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-default-type-expected.png: Added.

7:47 PM Changeset in webkit [98311] by weinig@apple.com

7 edits in trunk/Source/WebKit2

Simplify url accessors on WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=70797

Reviewed by Anders Carlsson.

UIProcess/API/C/WKPage.cpp:

(WKPageCopyActiveURL):
(WKPageCopyProvisionalURL):
(WKPageCopyCommittedURL):

UIProcess/API/C/WKPage.h:

Add accessors to C SPI.

UIProcess/API/mac/WKBrowsingContextController.h:

Remove unreachableURL accessor for now. It may make a glorious return when we have
error page support.

UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController activeURL]):
(-[WKBrowsingContextController provisionalURL]):
(-[WKBrowsingContextController committedURL]):
Implement these in terms of the new C SPI.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::activeURL):
Add computation of the "active" URL, which is the URL one would show
in an address field. It is the pending URL when there is one, the provisional
URL when there is one, and otherwise the committed/final URL.

(WebKit::WebPageProxy::provisionalURL):
(WebKit::WebPageProxy::committedURL):
Add access to the main frame URL.

UIProcess/WebPageProxy.h:

7:38 PM Changeset in webkit [98310] by macpherson@chromium.org

5 edits in trunk/Source/WebCore

REGRESSION(80893): HTML5 spec takes 2s longer to load due to time spent in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=68944

Reviewed by Antti Koivisto.

No new tests / Covered by existing tests.

Removes all virtual dispatch from CSSStyleApplyProperty by converting to use static function pointers for dispatch.
Uses class templates instead of function templates to allow default parameters and also to share parameter declarations across static functions.
All constructor parameters become template parameters. This improves the level of compiler optimization that can be achieved.
Overall this achieved a ~2% overall speedup on run-safari PerformanceTests/Parser/html5-full-render.html,
and profiling showed a reduction in the time spent inside CSSStyleSelector::applyProperty().

css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyExpanding::createHandler):
(WebCore::ApplyPropertyDefaultBase::setValue):
(WebCore::ApplyPropertyDefaultBase::value):
(WebCore::ApplyPropertyDefaultBase::initial):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefaultBase::createHandler):
(WebCore::ApplyPropertyDefault::setValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyDefault::createHandler):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyStyleImage::createHandler):
(WebCore::ApplyPropertyAuto::setValue):
(WebCore::ApplyPropertyAuto::value):
(WebCore::ApplyPropertyAuto::hasAuto):
(WebCore::ApplyPropertyAuto::setAuto):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyAuto::createHandler):
(WebCore::defaultInitialColor):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::createHandler):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyDirection::createHandler):
(WebCore::ApplyPropertyLength::setValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyLength::createHandler):
(WebCore::ApplyPropertyString::setValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyString::createHandler):
(WebCore::ApplyPropertyBorderRadius::setValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyBorderRadius::createHandler):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyFillLayer::createHandler):
(WebCore::ApplyPropertyComputeLength::setValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyComputeLength::createHandler):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFont::createHandler):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontWeight::createHandler):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCounter::createHandler):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyCursor::createHandler):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::createHandler):
(WebCore::ApplyPropertyAnimation::setValue):
(WebCore::ApplyPropertyAnimation::value):
(WebCore::ApplyPropertyAnimation::test):
(WebCore::ApplyPropertyAnimation::clear):
(WebCore::ApplyPropertyAnimation::initial):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::accessAnimations):
(WebCore::ApplyPropertyAnimation::animations):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyAnimation::createHandler):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyOutlineStyle::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

css/CSSStyleApplyProperty.h:

(WebCore::PropertyHandler::PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):
(WebCore::PropertyHandler::isValid):
(WebCore::PropertyHandler::inheritFunction):
(WebCore::PropertyHandler::initialFunction):
(WebCore::PropertyHandler::applyFunction):
(WebCore::CSSStyleApplyProperty::propertyHandler):
(WebCore::CSSStyleApplyProperty::setPropertyHandler):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::invalidColor):

7:28 PM Changeset in webkit [98309] by commit-queue@webkit.org

4 edits
2 adds in trunk

Canvas drawImage with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
https://bugs.webkit.org/show_bug.cgi?id=66920

Patch by Ben Wells <benwells@chromium.org> on 2011-10-24
Reviewed by James Robinson.

Source/WebCore:

Test: fast/canvas/canvas-composite-image.html

Use the same method as fills to handle composited drawImage calls that will affect the whole
canvas. To do this code used when doing fills has been factored into seperate functions and
used by drawImage. Some functions used to do these types of operations have also been renamed.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::isFullCanvasCompositeMode):
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::calculateCompositingBufferRect):
(WebCore::CanvasRenderingContext2D::createCompositingBuffer):
(WebCore::CanvasRenderingContext2D::compositeBuffer):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill):

html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

fast/canvas/canvas-composite-image-expected.txt: Added.
fast/canvas/canvas-composite-image.html: Added.

7:15 PM Changeset in webkit [98308] by rniwa@webkit.org

3 edits in trunk/LayoutTests

GTK and Windows rebaselines after r98199.

platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
platform/win/fast/dom/prototype-inheritance-2-expected.txt:

6:24 PM Changeset in webkit [98307] by jchaffraix@webkit.org

4 edits in trunk/Source

Unreviewed, rolling out r98294 and r98306.
http://trac.webkit.org/changeset/98294
http://trac.webkit.org/changeset/98306
https://bugs.webkit.org/show_bug.cgi?id=70790

the first patch broke chromium-mac and the second gclient
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-24

Source/WebCore:

WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

WebKit.gypi:

5:44 PM Changeset in webkit [98306] by jchaffraix@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Try to fix mac build after r98294
https://bugs.webkit.org/show_bug.cgi?id=70785

Remove test for ScrollAnimatorNone on mac.

Unreviewed, build fix.

Patch by Nico Weber <thakis@chromium.org> on 2011-10-24

WebKit.gypi:

5:44 PM Changeset in webkit [98305] by rniwa@webkit.org

3 edits in trunk/Source/WebCore

Build fix after r98300.

WebCore.gypi:
WebCore.pro:

5:33 PM Changeset in webkit [98304] by andersca@apple.com

4 edits in trunk/Source/WebCore

It should be possible for Widget subclasses to control whether transforms affect the frame rect
https://bugs.webkit.org/show_bug.cgi?id=70787

Reviewed by Sam Weinig.

Currently RenderWidget sets the frame rect of it's hosted widget to the bounding box of the transformed
content box rect (unless the Widget is a frame view). It should be possible for Widget subclasses to override
this behavior and have the frame rect set to the absolute content box without any transforms applied.

platform/Widget.h:

(WebCore::Widget::transformsAffectFrameRect):
Add new member function.

rendering/RenderWidget.cpp:

(WebCore::RenderWidget::updateWidgetGeometry):
Move shared code from setWidget and updateWidgetPosition out into a new function. If transformsAffectFrameRect returns
false, just set the frame rect to the absolute content box.

(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):
Call updateWidgetGeometry.

rendering/RenderWidget.h:

5:26 PM Changeset in webkit [98303] by eae@chromium.org

39 edits
2 adds in branches/subpixellayout/Source

Add support for chromium port, currently in a state where DRT builds and most layout tests passes.

5:21 PM Changeset in webkit [98302] by oliver@apple.com

7 edits in trunk/Source/JavaScriptCore

Crash in void JSC::validateCell<JSC::RegExp*>(JSC::RegExp*)
https://bugs.webkit.org/show_bug.cgi?id=70689

Reviewed by Filip Pizlo.

While performing codegen we need to make the GlobalData explicitly
aware of the codeblock being compiled, as compilation may trigger GC
and CodeBlock holds GC values, but has not yet been assigned to its
owner executable.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::~BytecodeGenerator):

bytecompiler/BytecodeGenerator.h:
heap/AllocationSpace.cpp:

(JSC::AllocationSpace::allocateSlowCase):

heap/Heap.cpp:

(JSC::Heap::markRoots):

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

runtime/JSGlobalData.h:

(JSC::JSGlobalData::startedCompiling):
(JSC::JSGlobalData::finishedCompiling):

5:19 PM Changeset in webkit [98301] by jchaffraix@webkit.org

1 edit
1 add in trunk/LayoutTests

Unreviewed rebaseline after r98293.

platform/chromium-win/svg/filters/feColorMatrix-default-type-expected.png: Added.

5:13 PM Changeset in webkit [98300] by rniwa@webkit.org

46 edits
36 adds in trunk

Microdata: Add itemprop, itemref, itemvalue attributes.
https://bugs.webkit.org/show_bug.cgi?id=69839

Patch by Arko Saha <arko@motorola.com> on 2011-10-24
Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: fast/dom/MicroData/itemprop-add-remove-tokens.html

fast/dom/MicroData/itemprop-for-an-element-must-be-correct.html
fast/dom/MicroData/itemprop-must-be-read-only.html
fast/dom/MicroData/itemprop-reflected-by-itemProp-property.html
fast/dom/MicroData/itemref-add-remove-tokens.html
fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property.html
fast/dom/MicroData/itemref-for-an-element-must-be-correct.html
fast/dom/MicroData/itemref-must-be-read-only.html
fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element.html
fast/dom/MicroData/itemvalue-reflects-href-attr.html
fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element.html
fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element.html
fast/dom/MicroData/itemvalue-reflects-the-src-attr.html
fast/dom/MicroData/itemvalue-returns-element-itself.html
fast/dom/MicroData/itemvalue-returns-null.html
fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001.html
fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002.html

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
bindings/js/JSHTMLElementCustom.cpp:

(WebCore::toJS):
(WebCore::JSHTMLElement::itemValue):
(WebCore::JSHTMLElement::setItemValue):

bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::toV8Object):
(WebCore::V8HTMLElement::itemValueAccessorGetter):
(WebCore::V8HTMLElement::itemValueAccessorSetter):

dom/MicroDataItemList.cpp:
html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::itemValueText):
(WebCore::HTMLAnchorElement::setItemValueText):

html/HTMLAnchorElement.h:
html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::itemValueText):
(WebCore::HTMLAreaElement::setItemValueText):

html/HTMLAreaElement.h:
html/HTMLAttributeNames.in:
html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::itemProp): Returns element's itemprop content attribute.
(WebCore::HTMLElement::setItemProp): Sets itemprop value on changing elemet's
itemprop attribute.
(WebCore::HTMLElement::itemRef): Returns element's itemref content attribute.
(WebCore::HTMLElement::setItemRef): Sets itemref value on changing elemet's
itemref attribute.
(WebCore::HTMLElement::setItemValue): Sets element's itemvalue. If the element has no
itemprop attribute or if element has an itemscope attribute, it throws INVALID_ACCESS_ERR
exception.
(WebCore::HTMLElement::itemValue): Returns the elements itemvalue.

If the element has no itemprop attribute it returns null.
If the element has an itemscope attribute, it returns the element itself.
If the element is a meta element: It acts as it would if it was reflecting the element's
content content attribute.
If the element is an audio, embed, iframe, img, source, track, or video element: It acts
as it would if it was reflecting the element's src content attribute.
If the element is an a, area, or link element: It act as it would if it was reflecting the
href content attribute.
If the element is an object element: It acts as it would if it was reflecting the element's
data content attribute.

(WebCore::HTMLElement::itemValueText):
(WebCore::HTMLElement::setItemValueText):

html/HTMLElement.h:
html/HTMLElement.idl:
html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::itemValueText):
(WebCore::HTMLEmbedElement::setItemValueText):

html/HTMLEmbedElement.h:
html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::itemValueText):
(WebCore::HTMLIFrameElement::setItemValueText):

html/HTMLIFrameElement.h:
html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::itemValueText):
(WebCore::HTMLImageElement::setItemValueText):

html/HTMLImageElement.h:
html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::itemValueText):
(WebCore::HTMLLinkElement::setItemValueText):

html/HTMLLinkElement.h:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::itemValueText):
(WebCore::HTMLMediaElement::setItemValueText):

html/HTMLMediaElement.h:
html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::itemValueText):
(WebCore::HTMLMetaElement::setItemValueText):

html/HTMLMetaElement.h:
html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::itemValueText):
(WebCore::HTMLObjectElement::setItemValueText):

html/HTMLObjectElement.h:
html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::itemValueText):
(WebCore::HTMLSourceElement::setItemValueText):

html/HTMLSourceElement.h:
html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::itemValueText):
(WebCore::HTMLTrackElement::setItemValueText):

html/HTMLTrackElement.h:
html/MicroDataItemValue.cpp: Added.

(WebCore::MicroDataItemValue::MicroDataItemValue):
(WebCore::MicroDataItemValue::createFromString):
(WebCore::MicroDataItemValue::createFromNode):

html/MicroDataItemValue.h: Added.

(WebCore::MicroDataItemValue::isNode):
(WebCore::MicroDataItemValue::getNode):
(WebCore::MicroDataItemValue::getString):

LayoutTests:

Added test-cases for Microdata itemprop, itemref, itemvalue attributes.

fast/dom/MicroData/002-expected.txt:
fast/dom/MicroData/002.html:
fast/dom/MicroData/003-expected.txt:
fast/dom/MicroData/003.html:
fast/dom/MicroData/005-expected.txt:
fast/dom/MicroData/005.html:
fast/dom/MicroData/006-expected.txt:
fast/dom/MicroData/009.html:
fast/dom/MicroData/itemprop-add-remove-tokens-expected.txt: Added.
fast/dom/MicroData/itemprop-add-remove-tokens.html: Added.
fast/dom/MicroData/itemprop-for-an-element-must-be-correct-expected.txt: Added.
fast/dom/MicroData/itemprop-for-an-element-must-be-correct.html: Added.
fast/dom/MicroData/itemprop-must-be-read-only-expected.txt: Added.
fast/dom/MicroData/itemprop-must-be-read-only.html: Added.
fast/dom/MicroData/itemprop-reflected-by-itemProp-property-expected.txt: Added.
fast/dom/MicroData/itemprop-reflected-by-itemProp-property.html: Added.
fast/dom/MicroData/itemref-add-remove-tokens-expected.txt: Added.
fast/dom/MicroData/itemref-add-remove-tokens.html: Added.
fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property-expected.txt: Added.
fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property.html: Added.
fast/dom/MicroData/itemref-for-an-element-must-be-correct-expected.txt: Added.
fast/dom/MicroData/itemref-for-an-element-must-be-correct.html: Added.
fast/dom/MicroData/itemref-must-be-read-only-expected.txt: Added.
fast/dom/MicroData/itemref-must-be-read-only.html: Added.
fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element-expected.txt: Added.
fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element.html: Added.
fast/dom/MicroData/itemvalue-reflects-href-attr-expected.txt: Added.
fast/dom/MicroData/itemvalue-reflects-href-attr.html: Added.
fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element-expected.txt: Added.
fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element.html: Added.
fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element-expected.txt: Added.
fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element.html: Added.
fast/dom/MicroData/itemvalue-reflects-the-src-attr-expected.txt: Added.
fast/dom/MicroData/itemvalue-reflects-the-src-attr.html: Added.
fast/dom/MicroData/itemvalue-returns-element-itself-expected.txt: Added.
fast/dom/MicroData/itemvalue-returns-element-itself.html: Added.
fast/dom/MicroData/itemvalue-returns-null-expected.txt: Added.
fast/dom/MicroData/itemvalue-returns-null.html: Added.
fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001-expected.txt: Added.
fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001.html: Added.
fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002-expected.txt: Added.
fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002.html: Added.
fast/dom/MicroData/resources/microdata-common.js:

(createElement):
(runTest):

5:00 PM Changeset in webkit [98299] by fpizlo@apple.com

3 edits
3 adds in trunk

Object-or-other branch speculation may corrupt the state for OSR if the child of the
branch is an integer
https://bugs.webkit.org/show_bug.cgi?id=70777

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):

LayoutTests:

fast/js/dfg-other-branch-expected.txt: Added.
fast/js/dfg-other-branch.html: Added.
fast/js/script-tests/dfg-other-branch.js: Added.

(foo):
(bar):

4:45 PM Changeset in webkit [98298] by jchaffraix@webkit.org

2 edits
2 adds
1 delete in trunk/LayoutTests

Unreviewed gardening.

Bug 58013 has landed 3 months ago and it looks like the rebaseline was forgotten.
The new result is consistent with the other platforms.

platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Removed.
platform/chromium-win/fast/repaint/scale-page-shrink-expected.png: Added.
platform/chromium-win/fast/repaint/scale-page-shrink-expected.txt: Added.
platform/chromium/test_expectations.txt:

4:43 PM Changeset in webkit [98297] by leviw@chromium.org

4 edits in branches/subpixellayout/Source/WebCore

Switching FloatingObjectTree/Interval to use rounded ints instead of LayoutUnits to correct comparisons with the line box tree.

4:22 PM Changeset in webkit [98296] by fpizlo@apple.com

3 edits
3 adds in trunk

op_new_array_buffer is not inlined correctly
https://bugs.webkit.org/show_bug.cgi?id=70770

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Disabled inlining of op_new_array_buffer, for now.

dfg/DFGCapabilities.h:

(JSC::DFG::canInlineOpcode):

LayoutTests:

Reviewed by Oliver Hunt.

fast/js/dfg-inline-new-array-buffer-expected.txt: Added.
fast/js/dfg-inline-new-array-buffer.html: Added.
fast/js/script-tests/dfg-inline-new-array-buffer.js: Added.

(foo):
(bar):

4:03 PM Changeset in webkit [98295] by Joseph Pecoraro

2 edits in trunk/Source/WebCore

Remove unused instance variable
https://bugs.webkit.org/show_bug.cgi?id=70750

Reviewed by Dimitri Glazkov.

rendering/RenderTextControl.h:

4:02 PM Changeset in webkit [98294] by thakis@chromium.org

2 edits in trunk/Source/WebCore

[chromium/mac] Fix an ODR violation.
https://bugs.webkit.org/show_bug.cgi?id=70753

Reviewed by Anders Carlsson.

Both ScrollAnimatorNone and ScrollAnimatorMac define ScrollAnimator::create() on OS X.
Remove the unused one.

WebCore.gyp/WebCore.gyp:

3:56 PM Changeset in webkit [98293] by timothy_horton@apple.com

3 edits
3 adds in trunk

feColorMatrix doesn't use the correct default "matrix" type when no type attribute is specified
https://bugs.webkit.org/show_bug.cgi?id=70035
<rdar://problem/10280177>

Reviewed by Nikolas Zimmermann.

Make feColorMatrix's type attribute be "matrix" by default.

Test: svg/filters/feColorMatrix-default-type.svg

svg/SVGFEColorMatrixElement.cpp:

(WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):

3:51 PM Changeset in webkit [98292] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/efl

[EFL] Build fix. Rename all instances of a variable when it gets changed
https://bugs.webkit.org/show_bug.cgi?id=70732

Unreviewed build fix.

Patch by Ivan Briano <ivan@profusion.mobi> on 2011-10-24

ewk/ewk_js.cpp:

(ewk_js_property_set): s/obj/object/

ewk/ewk_view.cpp:

(ewk_view_js_object_add): s/exec/executeState/

3:51 PM Changeset in webkit [98291] by commit-queue@webkit.org

10 edits in trunk/Source/JavaScriptCore

Add boolean speculations to DFG JIT 32_64
https://bugs.webkit.org/show_bug.cgi?id=70706

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-24
Reviewed by Filip Pizlo.

Different from the boolean speculations in DFG 64, the boolean
speculations in DFG 32_64 will use a 32bit GPR to hold the primitive
boolean instead of a JSBoolean. This choice is not only for
performance, but also to save a register as we're short of registers on
X86.
To accomplish this we make use of DataFormatBoolean, allow a value to
be represented as a primitive boolean and converted from/to a
JSBoolean.
This patch also fixes SpillOrder in 32_64, which should be different
from 64, and fixes needDataFormatConversion logic in 32_64.

assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branchTest32):

We don't expect byte test actually as it doesn't work for registers
esp..edi on X86.

dfg/DFGGenerationInfo.h:

(JSC::DFG::needDataFormatConversion):
(JSC::DFG::GenerationInfo::initBoolean):
(JSC::DFG::GenerationInfo::gpr):
(JSC::DFG::GenerationInfo::fillInteger):
(JSC::DFG::GenerationInfo::fillBoolean):

dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::checkConsistency):

dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::spill):
(JSC::DFG::cellResult):
(JSC::DFG::booleanResult):

dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):

dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::ValueSource::forPrediction):
(JSC::DFG::ValueRecovery::alreadyInRegisterFileAsUnboxedBoolean):
(JSC::DFG::ValueRecovery::inGPR):
(JSC::DFG::ValueRecovery::gpr):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

3:49 PM Changeset in webkit [98290] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] Build fix. Add include path to find npapi.h
https://bugs.webkit.org/show_bug.cgi?id=70730

Unreviewed build fix.

Patch by Ivan Briano <ivan@profusion.mobi> on 2011-10-24

DumpRenderTree/efl/CMakeLists.txt: Add include path for npapi.h

3:39 PM Changeset in webkit [98289] by tony@chromium.org

2 edits in trunk/Source/WebCore

Unbreak binding generation tests
https://bugs.webkit.org/show_bug.cgi?id=70768

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-24
Reviewed by Darin Adler.

Update the expected output of V8 binding tests to match
results c/o https://bugs.webkit.org/show_bug.cgi?id=70065

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::idbKeyCallback):

3:26 PM Changeset in webkit [98288] by eric@webkit.org

3 edits in trunk/Tools

Plugin tests are failing after switching WK2 to NRWT
https://bugs.webkit.org/show_bug.cgi?id=70760

Reviewed by Simon Fraser.

Perpetuate this horrible hack.

Scripts/webkitpy/layout_tests/port/webkit.py:

3:19 PM Changeset in webkit [98287] by leviw@chromium.org

2 edits
7 adds
1 delete in trunk/LayoutTests

Adding Chromium expectations from http://trac.webkit.org/changeset/98263

Unreviewed.

platform/chromium-cg-mac-snowleopard/svg/as-object: Added.
platform/chromium-cg-mac-snowleopard/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
platform/chromium-linux-x86/svg/as-object: Removed.
platform/chromium-linux/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
platform/chromium-mac-snowleopard/svg/as-object: Added.
platform/chromium-mac-snowleopard/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
platform/chromium-win/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
platform/chromium-win/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
platform/chromium/test_expectations.txt:

3:15 PM Changeset in webkit [98286] by leviw@chromium.org

2 edits
1 add in trunk/LayoutTests

Fixing a collision in Mac results and adding qt results from http://trac.webkit.org/changeset/98263

Unreviewed test expectations update.

platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Fixing collision that removes

an empty text node.

platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-actual.txt: Added.

3:07 PM Changeset in webkit [98285] by weinig@apple.com

4 edits
1 add in trunk/Source/WebKit2

Hook up minimalist load delegate to WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=70764

Reviewed by Simon Fraser.

UIProcess/API/mac/WKBrowsingContextController.h:
UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadDelegate]):
(-[WKBrowsingContextController setLoadDelegate:]):
Add loadDelegate getter/setter. As per convention, the delegate is not
retained.

(didStartProvisionalLoadForFrame):
(didCommitLoadForFrame):
(didFinishLoadForFrame):
(setUpPageLoaderClient):
(-[WKBrowsingContextController initWithPageRef:]):
Hookup the delegate to a WKPageLoaderClient.

UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Added.

Add load delegate as a proper protocol.

WebKit2.xcodeproj/project.pbxproj:

Add new file.

2:58 PM Changeset in webkit [98284] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r98266.
http://trac.webkit.org/changeset/98266
https://bugs.webkit.org/show_bug.cgi?id=70767

Broke the chromium build. (Requested by dave_levin on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-24

features.gypi:

2:29 PM Changeset in webkit [98283] by Lucas Forschler

5 edits in branches/safari-534.52-branch/Source

Versioning.

2:19 PM Changeset in webkit [98282] by nduca@chromium.org

5 edits in trunk/Source

[chromium] Add isTraceEventEnabled to PlatformSupport.
https://bugs.webkit.org/show_bug.cgi?id=70618

Reviewed by Darin Fisher.

Source/WebCore:

platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

public/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::isTraceEventEnabled):

src/PlatformSupport.cpp:

(WebCore::PlatformSupport::isTraceEventEnabled):

2:01 PM Changeset in webkit [98281] by mihnea@adobe.com

4 edits in trunk/Source/WebCore

Use StringBuilder in CSSRuleList::rulesText()/CSSSelectorList::selectorsText()
https://bugs.webkit.org/show_bug.cgi?id=70746

Reviewed by Tony Chang.

Covered by existing tests.

css/CSSRuleList.cpp:

(WebCore::CSSRuleList::rulesText):

css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::selectorsText):

css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::cssText): Use CSSRuleList::rulesText() method instead of explicit loop.

1:57 PM Changeset in webkit [98280] by msaboff@apple.com

9 edits in trunk/Source

WebKit doesn't build with recent changes to libdispatch
https://bugs.webkit.org/show_bug.cgi?id=70737

Source/WebCore:

Added initialization for new WebKitSystemInterface function
CreateVMPressureDispatchOnMainQueue. Changed MemoryPressureHandler::install
to use new function.

Reviewed by Geoffrey Garen.

No new tests. Moved functionality to WebKitSystemInterface.

WebCore.exp.in:
platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::install):

platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

Added initialization for new WebKitSystemInterface function
CreateVMPressureDispatchOnMainQueue.

Reviewed by Geoffrey Garen.

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

Added initialization for new WebKitSystemInterface function
CreateVMPressureDispatchOnMainQueue.

Reviewed by Geoffrey Garen.

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

1:54 PM Changeset in webkit [98279] by eric@webkit.org

6 edits in trunk/Tools

NRWT doesn't support ORWT's --root option, but should
https://bugs.webkit.org/show_bug.cgi?id=70416

Reviewed by Dirk Pranke.

Add support for ORWT's --root option which is used for
running tests with a nightly build of WebKit.

Scripts/old-run-webkit-tests:
Scripts/webkitpy/layout_tests/port/base.py:
- webkit_build_path was never called by any code, removed.
Scripts/webkitpy/layout_tests/port/webkit.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:

1:51 PM Changeset in webkit [98278] by commit-queue@webkit.org

27 edits in trunk

IndexedDB: Throw DATA_ERR on invalid keys, remove null key support
https://bugs.webkit.org/show_bug.cgi?id=70065

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-24
Reviewed by Tony Chang.

Source/WebCore:

Part 1 of a two-sided commit. Renames IDBKey::NullType to
IDBKey::InvalidType. JS binding yields this type rather
than throwing immediately so the correct exception type can
be raised. Checks for invalid keys added to front-end classes.

bindings/js/JSIDBKeyCustom.cpp:

(WebCore::toJS):

bindings/scripts/CodeGeneratorV8.pm:

(TypeCanFailConversion):

bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue):

bindings/v8/custom/V8IDBKeyCustom.cpp:

(WebCore::toV8):

storage/IDBCursor.cpp:

(WebCore::IDBCursor::continueFunction):

storage/IDBFactory.cpp:

(WebCore::IDBFactory::cmp):

storage/IDBIndex.cpp:

(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):

storage/IDBKey.cpp:

(WebCore::IDBKey::IDBKey):
(WebCore::IDBKey::compare):

storage/IDBKey.h:

(WebCore::IDBKey::createInvalid):

storage/IDBKeyRange.cpp:

(WebCore::IDBKeyRange::only):
(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):
(WebCore::IDBKeyRange::bound):

storage/IDBKeyRange.h:

(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):
(WebCore::IDBKeyRange::bound):

storage/IDBKeyRange.idl:
storage/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeIDBKey):
(WebCore::IDBLevelDBCoding::decodeIDBKey):

storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):

storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):

storage/IDBSQLiteBackingStore.cpp:

(WebCore::whereSyntaxForKey):
(WebCore::bindKeyToQuery):
(WebCore::lowerCursorWhereFragment):
(WebCore::upperCursorWhereFragment):
(WebCore::bindKeyToQueryWithNulls):
(WebCore::keyFromQuery):

Source/WebKit/chromium:

src/AssertMatchingEnums.cpp:
src/WebIDBKey.cpp:

(WebKit::WebIDBKey::assignNull):

LayoutTests:

Updated expectations now that most tests match spec. Includes change to
objectstore-basics test to avoid hitting https://bugs.webkit.org/show_bug.cgi?id=70041
since this CL stops hiding that bug.

storage/indexeddb/factory-cmp-expected.txt:
storage/indexeddb/index-basics-expected.txt:
storage/indexeddb/invalid-keys-expected.txt:
storage/indexeddb/keyrange-expected.txt:
storage/indexeddb/objectstore-basics-expected.txt:
storage/indexeddb/objectstore-basics.html:
storage/indexeddb/open-cursor-expected.txt:

1:48 PM Changeset in webkit [98277] by alokp@chromium.org

5 edits in trunk/Source/WebCore

[chromium] Make accelerated drawing work with threaded compositing
https://bugs.webkit.org/show_bug.cgi?id=70656

Reviewed by James Robinson.

Make sure that the compositor context is not used outside LayerTextureUpdater::updateTextureRect().
Created a FrameBuffer class that wraps skia gpu canvas and manages GL resources.

platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::FrameBuffer::FrameBuffer::FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::~FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::initialize):
(WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::~LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):

platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):

1:47 PM Changeset in webkit [98276] by mhahnenberg@apple.com

2 edits in trunk/Source/JavaScriptCore

Fixing Windows build

Unreviewed build fix

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

1:41 PM Changeset in webkit [98275] by adamk@chromium.org

2 edits in trunk/Source/WebCore

Optimize Node::isInShadowTree to execute in constant-time
https://bugs.webkit.org/show_bug.cgi?id=67686

Reviewed by Dimitri Glazkov.

No expected change in behavior, so no new tests.

dom/Node.cpp:

(WebCore::Node::isInShadowTree):

1:40 PM Changeset in webkit [98274] by ojan@chromium.org

1 edit
4 adds in trunk/LayoutTests

Some more fixups from http://trac.webkit.org/changeset/98265.

The leopard bot results are incorrect, but that's because the
chromium leopard bots have not compiled in a few days. Once
the bots are fixed, we'll need to rebaseline this test again for
leopard.

platform/chromium-cg-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
platform/chromium-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.

1:35 PM Changeset in webkit [98273] by Lucas Forschler

1 copy in tags/Safari-534.52.3

New tag.

1:32 PM Changeset in webkit [98272] by Lucas Forschler

2 edits in branches/safari-534.52-branch/Source/WebCore

Fix Localization.

1:11 PM Changeset in webkit [98271] by nduca@chromium.org

5 edits in trunk/Source

[chromium] Expose WebThread::postDelayedTask to CCThread
https://bugs.webkit.org/show_bug.cgi?id=70712

Reviewed by James Robinson.

Source/WebCore:

platform/graphics/chromium/cc/CCThread.h:

Source/WebKit/chromium:

src/CCThreadImpl.cpp:

(WebKit::CCThreadImpl::postDelayedTask):

src/CCThreadImpl.h:

12:55 PM Changeset in webkit [98270] by weinig@apple.com

3 edits in trunk/Source/WebKit2

Add URL getters for the WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=70752

Reviewed by Anders Carlsson.

UIProcess/API/mac/WKBrowsingContextController.h:
UIProcess/API/mac/WKBrowsingContextController.mm:

(autoreleased):
Added helpers for autoreleasing.

(-[WKBrowsingContextController activeURL]):
Added buy not implemented yet.

(-[WKBrowsingContextController pendingURL]):
(-[WKBrowsingContextController provisionalURL]):
(-[WKBrowsingContextController commitedURL]):
(-[WKBrowsingContextController unreachableURL]):
Added getters.

(-[WKBrowsingContextController title]):
Convert to new autoreleased helper.

12:53 PM Changeset in webkit [98269] by nduca@chromium.org

4 edits in trunk/Source/WebKit/chromium

[chromium] Manage webkit_unit_tests TestSuite lifetime explicitly in DLL build
https://bugs.webkit.org/show_bug.cgi?id=70688

Reviewed by Tony Chang.

tests/RunAllTests.cpp:

(main):

tests/WebUnitTests.cpp:

(WebKit::InitTestSuite):
(WebKit::RunAllUnitTests):
(WebKit::DeleteTestSuite):

tests/WebUnitTests.h:

12:41 PM Changeset in webkit [98268] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

BitVector isInline check could fail
https://bugs.webkit.org/show_bug.cgi?id=70691

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-24
Reviewed by Geoffrey Garen.

Current BitVector uses the highest bit of m_bitsOrPointer to indicate
whether it's an inlined bit set or a pointer to an outOfLine bit set.
This check may fail in case the pointer also has the highest bit set,
which is surely possible on IA32 (Linux).
In this case the check failure can result in unexpected behaviors,
for example if the BitVector is incorrectly determined as having an
inlined bit set, then setting a bit exceeding maxInlineBits will wrongly
modify the memory adjacent to the BitVector object.
This fix is to use the lowest bit of m_bitsOrPointer to indicate inline
or outofline, based on the assumption that the pointer to OutOfLineBits
should be 4 or 8 byte aligned.
We could mark the lowest bit (bit 0) with 1 for inlined bit set,
and bits 1~bitsInPointer are used for bit set/test.
In this case we need do one bit more shift for bit set/test.

wtf/BitVector.cpp:

(WTF::BitVector::resizeOutOfLine):

wtf/BitVector.h:

(WTF::BitVector::quickGet):
(WTF::BitVector::quickSet):
(WTF::BitVector::quickClear):
(WTF::BitVector::makeInlineBits):
(WTF::BitVector::isInline):

12:40 PM Changeset in webkit [98267] by jchaffraix@webkit.org

6 edits
7 adds
3 deletes in trunk/LayoutTests

Unreviewed rebaseline of svg/W3C-SVG-1.1-SE/coords-units-03-b.html

The new baselines all match the existing ones. Not sure if we really pass the test as
2 lines should be 200px but at least all the baselines are consistent (within some font
differences).

platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1-SE: Added.
platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Removed.
platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE: Added.
platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE: Added.
platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
platform/chromium/test_expectations.txt:
platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Removed.
platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Removed.
svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.

12:29 PM Changeset in webkit [98266] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Enable MEDIA_SOURCE feature for Chromium
https://bugs.webkit.org/show_bug.cgi?id=70745

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-10-24
Reviewed by David Levin.

features.gypi:

12:22 PM Changeset in webkit [98265] by ojan@chromium.org

2 edits
1 move
1 add
4 deletes in trunk/LayoutTests

Cleanup some test expectations missed in r98183.

platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
platform/chromium-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.txt: Removed.
platform/chromium/fast/backgrounds/background-leakage-transforms-expected.txt: Removed.
platform/chromium/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt.
platform/chromium/fast/writing-mode/fallback-orientation-expected.txt: Removed.
platform/chromium/test_expectations.txt:

12:02 PM Changeset in webkit [98264] by levin@chromium.org

3 edits in trunk/Tools

check-webkit-style complains about WEBKIT_EXPORT in test/WebUnitTests.h
https://bugs.webkit.org/show_bug.cgi?id=70747

Reviewed by Tony Chang.

Scripts/webkitpy/style/checkers/cpp.py: Allow WEBKIT_EXPORT in tests dir.
Scripts/webkitpy/style/checkers/cpp_unittest.py: Corresponding test.

11:56 AM Changeset in webkit [98263] by leviw@chromium.org

4 edits
3 adds in trunk

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Checking that embedded SVG is in an SVG document before negotiating size
with the host document.

Test: svg/as-object/svg-embedded-in-html-in-iframe.html

rendering/svg/RenderSVGRoot.cpp:

(WebCore::isEmbeddedThroughFrameContainingSVGDocument):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

LayoutTests:

Fixing a bug where SVG negotiated size when embedded in html inside an iframe.

platform/chromium/test_expectations.txt: Will update with results on other platforms.
platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
svg/as-object/svg-embedded-in-html-in-iframe.html: Added.

11:41 AM Changeset in webkit [98262] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Node::registeredMutationObserversOfType should be prefixed by "get"
https://bugs.webkit.org/show_bug.cgi?id=70359

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-10-24
Reviewed by Ojan Vafai.

This change renames Node::registeredMutationObserversOfType to
Node::getRegisteredMutationObserversOfType per the WebKit style guide.

No tests needed as the change is only method renaming.

dom/CharacterData.cpp:

(WebCore::CharacterData::dispatchModifiedEvent):

dom/ChildListMutationScope.cpp:

(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):

dom/Element.cpp:

(WebCore::enqueueAttributesMutationRecord):

dom/Node.cpp:

(WebCore::Node::getRegisteredMutationObserversOfType):

dom/Node.h:

11:37 AM Changeset in webkit [98261] by mhahnenberg@apple.com

27 edits in trunk/Source

Rename static getOwnPropertySlot to getOwnPropertySlotByIndex
https://bugs.webkit.org/show_bug.cgi?id=70271

Reviewed by Darin Adler.

Source/JavaScriptCore:

Renaming versions of getOwnPropertySlot that use an unsigned as the property
name to "getOwnPropertySlotByIndex" in preparation for adding them to the
MethodTable, which requires unique names for each method.

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertySlotVirtual):
(JSC::Arguments::getOwnPropertySlotByIndex):

runtime/Arguments.h:
runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertySlotVirtual):
(JSC::JSArray::getOwnPropertySlotByIndex):
(JSC::JSArray::getOwnPropertySlot):

runtime/JSArray.h:
runtime/JSByteArray.cpp:

(JSC::JSByteArray::getOwnPropertySlotVirtual):
(JSC::JSByteArray::getOwnPropertySlotByIndex):

runtime/JSByteArray.h:
runtime/JSCell.cpp:

(JSC::JSCell::getOwnPropertySlotVirtual):
(JSC::JSCell::getOwnPropertySlotByIndex):

runtime/JSCell.h:
runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::getOwnPropertySlotVirtual):
(JSC::JSNotAnObject::getOwnPropertySlotByIndex):

runtime/JSNotAnObject.h:
runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertySlotVirtual):
(JSC::JSObject::getOwnPropertySlotByIndex):

runtime/JSObject.h:
runtime/JSString.cpp:

(JSC::JSString::getOwnPropertySlotVirtual):
(JSC::JSString::getOwnPropertySlotByIndex):

runtime/JSString.h:
runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::getOwnPropertySlotVirtual):
(JSC::ObjectPrototype::getOwnPropertySlotByIndex):

runtime/ObjectPrototype.h:
runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::getOwnPropertySlotVirtual):
(JSC::RegExpMatchesArray::getOwnPropertySlotByIndex):

runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertySlotVirtual):
(JSC::StringObject::getOwnPropertySlotByIndex):

runtime/StringObject.h:

Source/WebCore:

No new tests.

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::getSparseIndex):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertySlotVirtual):
(JSC::RuntimeArray::getOwnPropertySlotByIndex):

bridge/runtime_array.h:

11:37 AM Changeset in webkit [98260] by jchaffraix@webkit.org

3 edits
7 adds in trunk/LayoutTests

Unreviewed gardening rebaselining.

Updating those baselines as they match Mac and looks like progressions. Linux was needing a wrong
rebaseline, so it was not rebaselined.

platform/chromium-cg-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png: Added.
platform/chromium-cg-mac-snowleopard/fast/repaint: Added.
platform/chromium-cg-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png: Added.
platform/chromium-mac-leopard/fast/repaint: Added.
platform/chromium-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png: Added.
platform/chromium-mac-snowleopard/fast/repaint: Added.
platform/chromium-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png: Added.
platform/chromium-win/fast/repaint/table-cell-collapsed-border-expected.png:
platform/chromium/test_expectations.txt:

11:36 AM Changeset in webkit [98259] by weinig@apple.com

3 edits in trunk/Source/WebKit2

Add zoom and title support to Objective-C WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=70744

Reviewed by Darin Adler.

UIProcess/API/mac/WKBrowsingContextController.h:
UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController title]):
(-[WKBrowsingContextController textZoom]):
(-[WKBrowsingContextController setTextZoom:]):
(-[WKBrowsingContextController pageZoom]):
(-[WKBrowsingContextController setPageZoom:]):

11:31 AM Changeset in webkit [98258] by commit-queue@webkit.org

3 edits
2 adds in trunk

IndexedDB add should fail adding an inline and passed key simultaneously
https://bugs.webkit.org/show_bug.cgi?id=58598

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-24
Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/mozilla/key-requirements-inline-and-passed.html

Implement the spec clause: passing a key into add() or put() when
the object store has a key path ("inline key") is an error.

storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):

LayoutTests:

storage/indexeddb/mozilla/key-requirements-inline-and-passed.html: Added.
storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt: Added.

11:29 AM Changeset in webkit [98257] by Lucas Forschler

5 edits in branches/safari-534.52-branch/Source

Versioning.

11:07 AM Changeset in webkit [98256] by msaboff@apple.com

5 edits in trunk/WebKitLibraries

WebKit doesn't build with recent changes to libdispatch
https://bugs.webkit.org/show_bug.cgi?id=70737

Added new WebKitSystemInterface method CreateVMPressureDispatchOnMainQueue.

WebKitSystemInterface.h:
libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceLion.a:
libWebKitSystemInterfaceSnowLeopard.a:

11:05 AM Changeset in webkit [98255] by Simon Fraser

3 edits in trunk/Source/WebCore

Improve debug compositing border colors
https://bugs.webkit.org/show_bug.cgi?id=70742

Reviewed by Dean Jackson.

Improve the appearance of the debug borders used to indicate compositing:

Use green for normal layers, orange for tiled layers
Make the repaint counter translucent
Change the color of the repaint counter to show when accelerated drawing is enabled.

platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::updateDebugIndicators):

platform/graphics/mac/WebLayer.mm:

(drawLayerContents):

10:54 AM Changeset in webkit [98254] by leviw@chromium.org

5 edits in branches/subpixellayout/Source/WebCore

Fixing repaint issues from truncated damage rects. Fixing a remaining loop in RenderDeprecatedFlexibleBox. Properly constructing FloatWithRect with a LayoutRect, which fixes lots of line layout issues.

10:34 AM Changeset in webkit [98253] by caryclark@google.com

3 edits
741 adds in trunk/LayoutTests

Unreviewed gardening: third chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 736 of 743 files for brevity.]

platform/chromium-mac-leopard/fast/block/positioning/absolute-length-of-neg-666666-expected.png: Added.
platform/chromium-mac-leopard/fast/block/positioning/absolute-position-direction-expected.png: Added.
platform/chromium-mac-leopard/fast/block/positioning/absolute-positioning-no-scrollbar-expected.png: Added.

...

platform/chromium-mac-leopard/fast/lists/ol-display-types-expected.png: Added.
platform/chromium-mac-leopard/fast/lists/ol-start-dynamic-expected.png: Added.
platform/chromium-mac-leopard/fast/lists/olstart-expected.png: Added.
platform/chromium/test_expectations.txt:

10:33 AM Changeset in webkit [98252] by kbalazs@webkit.org

2 edits in trunk/Tools

[Qt][WK2] Crash when running pixel tests
https://bugs.webkit.org/show_bug.cgi?id=70725

Reviewed by Chang Shu.

WebKitTestRunner/qt/TestInvocationQt.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

10:24 AM Changeset in webkit [98251] by abarth@webkit.org

2 edits in trunk/Source/WebKit/win

Attempt to fix Windows build by updating to the new interface.

DOMEventsClasses.cpp:

(DOMEvent::createInstance):

9:44 AM Changeset in webkit [98250] by Carlos Garcia Campos

5 edits in trunk/Source

[GTK] Fix make distcheck build
https://bugs.webkit.org/show_bug.cgi?id=69745

Reviewed by Martin Robinson.

Source/WebCore:

GNUmakefile.am:
GNUmakefile.list.am:

Source/WebKit2:

GNUmakefile.am:

9:39 AM Changeset in webkit [98249] by jchaffraix@webkit.org

2 edits in trunk/LayoutTests

[chromium] New failing test fast/events/dropzone-002.html
https://bugs.webkit.org/show_bug.cgi?id=61625

Unreviewed gardening.

platform/chromium/test_expectations.txt: The test has been passing

on all platforms except leopard for several days.

9:31 AM Changeset in webkit [98248] by apavlov@chromium.org

3 edits in branches/chromium/912

Merge 98243 - Web Inspector: [Styles] Adding a new style rule breaks things
https://bugs.webkit.org/show_bug.cgi?id=70721

Reviewed by Pavel Feldman.

Source/WebCore:

We had used to swap BlankStylePropertiesSection prototype and recently got rid of this hack,
but still had dependencies on the old behavior.

inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._refreshStyleRules):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
(WebInspector.BlankStylePropertiesSection.prototype.get isBlank):
(WebInspector.BlankStylePropertiesSection.prototype.expand):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCancelled):
(WebInspector.BlankStylePropertiesSection.prototype.makeNormal):

LayoutTests:

inspector/styles/styles-add-new-rule-expected.txt:
inspector/styles/styles-add-new-rule.html:

TBR=apavlov@chromium.org
Review URL: http://codereview.chromium.org/8380009

8:54 AM Changeset in webkit [98247] by vsevik@chromium.org

8 edits in branches/chromium/912

Merge 97975 - Web Inspector: Advanced search results should keep working after pretty print toggled.
https://bugs.webkit.org/show_bug.cgi?id=70347

Reviewed by Pavel Feldman.

Source/WebCore:

inspector/front-end/AdvancedSearchController.js:

(WebInspector.SearchScope.prototype.createSearchResultsPane):
(WebInspector.FileBasedSearchResultsPane.prototype.createAnchor):
(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):
(WebInspector.FileBasedSearchResultsPane.prototype._regexMatchRanges):
(WebInspector.FileBasedSearchResultsPane.prototype._createContentSpan):

inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._materializeBreakpoint):

inspector/front-end/CompilerSourceMapping.js:

(WebInspector.CompilerSourceMapping.prototype.sourceLocationToCompiledLocation):

inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.createLinkifier):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.LinkifierFormatter):
(WebInspector.DebuggerPresentationModel.LinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyResource):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawSourceCode):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):

inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.SourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):

inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchResultsPane):
(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):
(WebInspector.ScriptsSearchResultsPane.LinkifierFormatter):
(WebInspector.ScriptsSearchResultsPane.LinkifierFormatter.prototype.formatRawSourceCodeAnchor):

inspector/front-end/inspector.html:

LayoutTests:

inspector/debugger/raw-source-code.html:

BUG=101016
TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/8382007

8:26 AM Changeset in webkit [98246] by Lucas Forschler

5 edits in branches/safari-534.52-branch/Source

Versioning.

8:24 AM Changeset in webkit [98245] by Carlos Garcia Campos

11 edits
6 adds in trunk/Source/WebKit2

[GTK] Initial implementation of back forward list for WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69343

Reviewed by Martin Robinson.

GNUmakefile.am: Add new files to compilation.
UIProcess/API/gtk/WebKitBackForwardList.cpp: Added.

(webkitBackForwardListFinalize):
(webkit_back_forward_list_init):
(webkit_back_forward_list_class_init):
(webkitBackForwardListGetOrCreateItem): Helper function that
creates a new WebKitBackForwardListItem for the given
WebBackForwardListItem or returns it from the cache if it's
already cached.
(webkitBackForwardListCreateList): Helper function to convert a
WKArray of WebBackForwardListItems into a GList of
WebKitBackForwardListItems.
(webkitBackForwardListCreate): Create a new WebKitBackForwardList.
(webkitBackForwardListChanged): Emits changed signal when the back
forward list changes.
(webkit_back_forward_list_get_current_item):
(webkit_back_forward_list_get_back_item):
(webkit_back_forward_list_get_forward_item):
(webkit_back_forward_list_get_nth_item):
(webkit_back_forward_list_get_length):
(webkit_back_forward_list_get_back_list):
(webkit_back_forward_list_get_back_list_with_limit):
(webkit_back_forward_list_get_forward_list):
(webkit_back_forward_list_get_forward_list_with_limit):

UIProcess/API/gtk/WebKitBackForwardList.h: Added.
UIProcess/API/gtk/WebKitBackForwardListItem.cpp: Added.

(webkitBackForwardListItemFinalize):
(webkit_back_forward_list_item_init):
(webkit_back_forward_list_item_class_init):
(historyItemsMap): Global cache for WebKitBackForwardListItems.
(webkitBackForwardListItemFinalized):
(webkitBackForwardListItemGetOrCreate): Helper function that
creates a new WebKitBackForwardListItem for the given
WebBackForwardListItem or returns it from the global cache if it's
already cached.
(webkit_back_forward_list_item_get_uri):
(webkit_back_forward_list_item_get_title):
(webkit_back_forward_list_item_get_original_uri):

UIProcess/API/gtk/WebKitBackForwardListItem.h: Added.
UIProcess/API/gtk/WebKitBackForwardListPrivate.h: Added.
UIProcess/API/gtk/WebKitWebLoaderClient.cpp:

(didChangeBackForwardList): Call webkitBackForwardListChanged() to
notify that the list has changed.
(webkitWebLoaderClientAttachLoaderClientToPage): Add
implementation for didChangeBackForwardList.

UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed):
(webkit_web_view_get_back_forward_list): Return the back forward
list of the view.

UIProcess/API/gtk/WebKitWebView.h:
UIProcess/API/gtk/tests/GNUmakefile.am: Add new test.
UIProcess/API/gtk/tests/TestBackForwardList.cpp: Added.

(serverCallback):
(testBackForwardListNavigation):
(testBackForwardListLimitAndCache):
(beforeAll):
(afterAll):

UIProcess/API/gtk/tests/TestMain.h:

(Test::~Test): Check there are no objects leaked.
(Test::objectFinalized): Callback called when a GObject is
deleted, used to remove the watched object the list.
(Test::assertObjectIsDeletedWhenTestFinishes): Add an object to
the list of watched objects and add a weak pointer to remove it
from the list when the object is finalized. If there aren't
objects leaked, the list should be empty when the test finishes.

UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::WebViewTest): Watch the web view to make sure it's
not leaked.

UIProcess/API/gtk/tests/WebViewTest.h: Make WebViewTest inherit

from Test class.

UIProcess/API/gtk/webkit2.h: Include WebKitBackForwardList.h and

WebKitBackForwardListItem.h.

UIProcess/API/gtk/webkit2marshal.list:

8:23 AM Changeset in webkit [98244] by Lucas Forschler

1 copy in tags/Safari-534.52.1

New tag.

8:23 AM Changeset in webkit [98243] by apavlov@chromium.org

5 edits in trunk

Web Inspector: [Styles] Adding a new style rule breaks things
https://bugs.webkit.org/show_bug.cgi?id=70721

Reviewed by Pavel Feldman.

Source/WebCore:

We had used to swap BlankStylePropertiesSection prototype and recently got rid of this hack,
but still had dependencies on the old behavior.

inspector/front-end/StylesSidebarPane.js:

LayoutTests:

inspector/styles/styles-add-new-rule-expected.txt:
inspector/styles/styles-add-new-rule.html:

8:20 AM Changeset in webkit [98242] by Lucas Forschler

5 edits in branches/safari-534.52-branch/Source

Versioning.

8:17 AM Changeset in webkit [98241] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

[GTK] Add helper function to set the loader client in WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=70594

Reviewed by Martin Robinson.

UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewSetLoaderClient): Helper function to set the loader
client.
(webkitWebViewConstructed): Use webkitWebViewSetLoaderClient() to
avoid unnecessary checks.
(webkit_web_view_set_loader_client): Use
webkitWebViewSetLoaderClient().

8:14 AM Changeset in webkit [98240] by pfeldman@chromium.org

7 edits in trunk

Web Inspector: do not force document loading on reload (should happen on demand).
https://bugs.webkit.org/show_bug.cgi?id=70724

Reviewed by Yury Semikhatsky.

Source/WebCore:

inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):

inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._documentUpdated):

inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.wasShown):

inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype.setVisible):

LayoutTests:

inspector/debugger/dom-breakpoints.html:
inspector/debugger/error-in-watch-expressions.html:

7:56 AM Changeset in webkit [98239] by Carlos Garcia Campos

32 edits in trunk

[GTK] Remove g_thread_init() calls
https://bugs.webkit.org/show_bug.cgi?id=70717

Reviewed by Xan Lopez.

With newer glib it's not needed anymore and with previous versions
it was already called by g_type_init().

Source/WebKit/gtk:

tests/testapplicationcache.c:

(main):

tests/testatk.c:

(main):

tests/testatkroles.c:

(main):

tests/testcopyandpaste.c:

(main):

tests/testdomdocument.c:

(main):

tests/testdomdomwindow.c:

(main):

tests/testdomnode.c:

(main):

tests/testdownload.c:

(main):

tests/testglobals.c:

(main):

tests/testhittestresult.c:

(main):

tests/testhttpbackend.c:

(main):

tests/testkeyevents.c:

(main):

tests/testloading.c:

(main):

tests/testmimehandling.c:

(main):

tests/testnetworkrequest.c:

(main):

tests/testnetworkresponse.c:

(main):

tests/testwebbackforwardlist.c:

(main):

tests/testwebdatasource.c:

(main):

tests/testwebframe.c:

(main):

tests/testwebhistoryitem.c:

(main):

tests/testwebplugindatabase.c:

(main):

tests/testwebresource.c:

(main):

tests/testwebsettings.c:

(main):

tests/testwebview.c:
tests/testwindow.c:

(main):

Source/WebKit2:

UIProcess/API/gtk/tests/TestMain.cpp:

(main):

Tools:

DumpRenderTree/gtk/DumpRenderTree.cpp:

(main):

GtkLauncher/main.c:

(main):

MiniBrowser/gtk/main.c:

(main):

7:41 AM Changeset in webkit [98238] by eric.carlson@apple.com

19 edits
4 deletes in trunk/Source/WebCore

Drop MutableTextTrack and make TextTrack always mutable
https://bugs.webkit.org/show_bug.cgi?id=62890

The MutableTextTrack type was removed from the spec, all text tracks are now mutable.

Reviewed by Sam Weinig.

No new tests needed, the changes just refactor existing code.

CMakeLists.txt: Remove all traces of MutableTextTrack.
CodeGenerators.pri: Ditto.
DerivedSources.cpp: Ditto.
DerivedSources.make: Ditto.
GNUmakefile.list.am: Ditto.
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
bindings/gobject/GNUmakefile.am: Ditto.
bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Ditto.

bindings/js/JSTextTrackCustom.cpp: Removed.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::addTrack): Return a TextTrack instead of a MutableTextTrack.

html/HTMLMediaElement.h:
html/HTMLMediaElement.idl:

html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack): Return a TextTrack instead of a MutableTextTrack.

html/MutableTextTrack.cpp: Removed.
html/MutableTextTrack.h: Removed.
html/MutableTextTrack.idl: Removed.

html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Remove Type parameter.
(WebCore::TextTrack::addCue): New, moved from MutableTextTrack.
(WebCore::TextTrack::removeCue): Ditto.
(WebCore::TextTrack::newCuesLoaded): Ditto.
(WebCore::TextTrack::fetchNewestCues): Ditto.

html/TextTrack.h:

(WebCore::TextTrack::create): Remove Type parameter

html/TextTrack.idl: Add addCue and removeCue.

7:32 AM Changeset in webkit [98237] by yurys@chromium.org

21 edits in trunk

Web Inspector: allow debugging dedicated worker initialization
https://bugs.webkit.org/show_bug.cgi?id=70723

Source/WebCore:

Now it is possible to pause each new dedicated worker on start. The user
needs to select a checkbox and then each newly created dedicated worker
will be paused on the first statement until the user resumes it explicitely.

Reviewed by Pavel Feldman.

inspector/Inspector.json: resume command is added. It is similar to GDB's run

command, i.e. worker execution will be paused until explicit "resume" command is
received.

inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::shouldPauseDedicatedWorkerOnStartImpl):

inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::shouldPauseDedicatedWorkerOnStart):

inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::resume):
(WebCore::InspectorRuntimeAgent::pauseWorkerContext):

inspector/InspectorRuntimeAgent.h:
inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::shouldPauseDedicatedWorkerOnStart): returns true
if the user chose to automatically pause all new workers.

inspector/InspectorWorkerAgent.h:
inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::resume):

inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.loaded):
(WebInspector.WorkerManager.loadCompleted):
(WebInspector.WorkerManager.prototype._workerCreated):
(WebInspector.WorkerManager.prototype.openWorkerInspector):
(WebInspector.WorkerManager.prototype._openInspectorWindow):

inspector/front-end/inspector.js:

(WebInspector.loaded):

workers/Worker.cpp:

(WebCore::Worker::notifyFinished):

workers/WorkerContextProxy.h:
workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerContext): additional flag specifying
worker initial state(paused/not paused) is added to the factory method. The flag
will be carried to the corresponding WorkerThread.
(WebCore::WorkerMessagingProxy::connectToInspector):

workers/WorkerMessagingProxy.h:

Source/WebKit/chromium:

Pass worker thread start mode to the worker thread.

Reviewed by Pavel Feldman.

src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::startWorkerContext):

src/WebWorkerClientImpl.h:

LayoutTests:

Reviewed by Pavel Feldman.

inspector/protocol/runtime-agent-expected.txt:
inspector/protocol/runtime-agent.html:

6:52 AM Changeset in webkit [98236] by pfeldman@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: Make indent configurable
https://bugs.webkit.org/show_bug.cgi?id=69986

Add a setting to choose an indent from "8 spaces", "4 spaces" (default), "2 spaces", or "Tab character".

Patch by Nikita Vasilyev <me@elv1s.ru> on 2011-10-21
Reviewed by Pavel Feldman.

English.lproj/localizedStrings.js:
inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype._createSelectSetting.get p):
(WebInspector.SettingsScreen.prototype._createSelectSetting.changeListener):

inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorModel):

inspector/front-end/TextViewer.js:

6:31 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

5:52 AM Changeset in webkit [98235] by alex

3 edits in trunk/LayoutTests

2011-10-24 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skip failing test in GTK, added bug 70720. Rebaseline
prototype-inheritance-2.html.

platform/gtk/Skipped: skipped fast/events/event-creation.html.
platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Reset expected results after r98199.

5:23 AM Changeset in webkit [98234] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-24

DEPS:

5:08 AM Changeset in webkit [98233] by caseq@chromium.org

8 edits in trunk/Source/WebCore

Web Inspector: add "Add to Watch" option to context menu on selection in source frame
https://bugs.webkit.org/show_bug.cgi?id=69924

Reviewed by Pavel Feldman.

added 'Add to Watch' context menu item in scripts panel;
include both default and custom items into a context menu if selection is present;

inspector/front-end/ScriptsPanel.js:

(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.addToWatch):

inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.populateSelectionContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateSelectionContextMenu):
(WebInspector.SourceFrameDelegate.prototype.suggestedFileName):
(WebInspector.SourceFrameDelegate.prototype.addToWatch):

inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype._contextMenu):
(WebInspector.TextViewerDelegate.prototype.populateSelectionContextMenu):

inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSidebarPane.prototype.addExpression):
(WebInspector.WatchExpressionsSidebarPane.prototype._addButtonClicked):
(WebInspector.WatchExpressionsSection.prototype.addExpression):
(WebInspector.WatchExpressionsSection.prototype.addNewExpressionAndEdit):

page/ContextMenuController.cpp:

(WebCore::ContextMenuController::showContextMenu):

4:04 AM Changeset in webkit [98232] by apavlov@chromium.org

3 edits
2 adds in trunk

Web Inspector: Audits hang on pages without img[src] elements
https://bugs.webkit.org/show_bug.cgi?id=70604

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/audits/audits-panel-noimages-functional.html

inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):

LayoutTests:

inspector/audits/audits-panel-noimages-functional-expected.txt: Added.
inspector/audits/audits-panel-noimages-functional.html: Added.

3:29 AM Changeset in webkit [98231] by commit-queue@webkit.org

6 edits in trunk

[Qt] fast/events/media-focus-in-standalone-media-document.html fails
https://bugs.webkit.org/show_bug.cgi?id=70110

Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-10-24
Reviewed by Simon Hausmann.

Source/WebCore:

ExtensionMap should also include media files mapping.

platform/qt/MIMETypeRegistryQt.cpp: Added media files mapping.

Source/WebKit/qt:

We should check for supported media mime types as well in the MIMETypeRegistry.

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::canShowMIMEType): check for supported media mime type.

LayoutTests:

Remove media-focus-in-standalone-media-document.html from Qt Skipped test list.

platform/qt/Skipped:

3:10 AM Changeset in webkit [98230] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

2011-10-24 Pavel Feldman <pfeldman@google.com>

Not reviewed: [chromium] follow up to 98228 - added missing css.

WebCore.gypi:

3:01 AM Changeset in webkit [98229] by vsevik@chromium.org

8 edits
2 copies in branches/chromium/912

Merge 97959 - Web Inspector: Enable support for advanced search in script's static content provider.
https://bugs.webkit.org/show_bug.cgi?id=70354

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/search/search-in-static.html

inspector/front-end/AdvancedSearchController.js:

(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):

inspector/front-end/ConsolePanel.js:

(WebInspector.ConsolePanel.prototype.performSearch):

inspector/front-end/ContentProviders.js:

(WebInspector.StaticContentProvider.prototype.searchInContent):

inspector/front-end/ElementsTreeOutline.js:

():

inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype.performSearch):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._showSourceLine):

inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.createSearchRegex):

inspector/front-end/utilities.js:

():

LayoutTests:

http/tests/inspector/search/search-in-static-expected.txt: Added.
http/tests/inspector/search/search-in-static.html: Added.

BUG=101008
TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/8368025

3:01 AM Changeset in webkit [98228] by pfeldman@chromium.org

20 edits
1 move
7 adds in trunk/Source/WebCore

Web Inspector: Make CSS files load upon View demand; split inspector.css into views.
https://bugs.webkit.org/show_bug.cgi?id=70694

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-24
Reviewed by Yury Semikhatsky.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):

inspector/front-end/DataGrid.js:

(WebInspector.DataGrid):

inspector/front-end/ElementsPanel.js:
inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView):

inspector/front-end/PanelEnablerView.js:
inspector/front-end/ProfilesPanel.js:
inspector/front-end/ResourceView.js:

(WebInspector.ResourceView):

inspector/front-end/ResourcesPanel.js:
inspector/front-end/ScriptsPanel.js:
inspector/front-end/TextViewer.js:
inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):

inspector/front-end/WebKit.qrc:
inspector/front-end/WelcomeView.js:

(WebInspector.WelcomeView):

inspector/front-end/auditsPanel.css: Renamed from Source/WebCore/inspector/front-end/audits.css.

2:40 AM Changeset in webkit [98227] by pfeldman@chromium.org

5 edits
2 adds in trunk

Web Inspector: make view load CSS files upon show.
https://bugs.webkit.org/show_bug.cgi?id=70696

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-24
Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/view-css.html

inspector/front-end/View.js:

(WebInspector.View):
(WebInspector.View.prototype._callOnVisibleChildren):
(WebInspector.View.prototype._processWillShow):
(WebInspector.View.prototype._processWasShown):
(WebInspector.View.prototype._processWillHide):
(WebInspector.View.prototype._processWasHidden):
(WebInspector.View.prototype._processOnResize):
(WebInspector.View.prototype.show):
(WebInspector.View.prototype.detach):
(WebInspector.View.prototype.registerRequiredCSS):
(WebInspector.View.prototype._loadCSSIfNeeded):
(WebInspector.View.prototype._doLoadCSS):
(WebInspector.View.prototype._disableCSSIfNeeded):
(WebInspector.View.prototype._doUnloadCSS):

LayoutTests:

inspector/view-css-expected.txt: Added.
inspector/view-css.html: Added.
inspector/view-events-expected.txt:
inspector/view-events.html:

2:26 AM Changeset in webkit [98226] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit2

[Qt][WK2] WebView does not get focus when being clicked / touched in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=70613

Make TouchWebView and DesktopWebView take the focus whenever it receives
a MouseClick or a TouchEvent.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-24
Reviewed by Simon Hausmann.

UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebView::mousePressEvent):

UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebView::touchEvent):

UIProcess/API/qt/qtouchwebview.h:

2:25 AM Changeset in webkit [98225] by pfeldman@chromium.org

13 edits in trunk/Source/WebCore

Web Inspector: make DataGrid a view
https://bugs.webkit.org/show_bug.cgi?id=70695

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-24
Reviewed by Yury Semikhatsky.

inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView.prototype._createDataGrid):

inspector/front-end/CookieItemsView.js:

(WebInspector.CookieItemsView.prototype._updateWithCookies):
(WebInspector.SimpleCookiesTable):
(WebInspector.SimpleCookiesTable.prototype.setCookies):

inspector/front-end/CookiesTable.js:

(WebInspector.CookiesTable):

inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):

inspector/front-end/DataGrid.js:

(WebInspector.DataGrid):
(WebInspector.DataGrid.prototype.onResize):

inspector/front-end/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView.prototype._queryFinished):
(WebInspector.DatabaseQueryView.prototype._queryError):
(WebInspector.DatabaseQueryView.prototype._appendViewQueryResult):
(WebInspector.DatabaseQueryView.prototype._appendErrorQueryResult):
(WebInspector.DatabaseQueryView.prototype._appendQueryResult):

inspector/front-end/DatabaseTableView.js:

(WebInspector.DatabaseTableView.prototype._queryFinished):

inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype.wasShown.profileCallback2):
(WebInspector.DetailedHeapshotView.prototype.wasShown):
(WebInspector.DetailedHeapshotView.prototype.onResize):

inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype.onResize):
(WebInspector.NetworkLogView.prototype._createTable):

inspector/front-end/ProfileView.js:
inspector/front-end/ResourceCookiesView.js:

(WebInspector.ResourceCookiesView.prototype._buildCookiesTable):

inspector/front-end/ResourceView.js:

(WebInspector.ResourceView):

1:54 AM Changeset in webkit [98224] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[GTK] [WK2] Memory leaks in WebContextGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=70505

Free the output of g_build_filename()

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2011-10-24
Reviewed by Martin Robinson.

UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultDatabaseDirectory):
(WebKit::WebContext::platformDefaultLocalStorageDirectory):

1:52 AM Changeset in webkit [98223] by rgabor@webkit.org

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r98199

Patch by Kosztyo Kristof <kkristof@inf.u-szeged.hu> on 2011-10-24

platform/qt/fast/dom/prototype-inheritance-2-expected.txt:

1:14 AM Changeset in webkit [98222] by commit-queue@webkit.org

3 edits
2 adds in trunk

[Forms] Setting defaultValue should hide an input placeholder.
https://bugs.webkit.org/show_bug.cgi?id=70586

Patch by Yosifumi Inoue <yosin@chromium.org> on 2011-10-24
Reviewed by Kent Tamura.

Source/WebCore:

Tests: fast/forms/placeholder-and-default-value-expected.html

fast/forms/placeholder-and-default-value.html

When input element has default value, we should not display
placeholder. Changing default value should tell rendering engine about
changing display of input element.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMappedAttribute): Calls updatePlaceholderVisibility for valueAttr if it doesn't have dirty value.

LayoutTests:

This test checks "value" attribute (default value) changing in two
ways, one is using setDefault method and another is setAttribute
method.

fast/forms/placeholder-and-default-value-expected.html: Added. Render text input element with "Default" value.
fast/forms/placeholder-and-default-value.html: Added. Render text input element with placeholder attribute and a script to change default value of input element to "Default" from empty.

12:53 AM Changeset in webkit [98221] by alex

2 edits in trunk/Tools

2011-10-24 Alejandro G. Castro <alex@igalia.com>

[WK2] [GTK] WebKitTestRunner crashes with heap corruption
https://bugs.webkit.org/show_bug.cgi?id=69403

We did not added autotoolsconfig.h to the config.h file and we
were adding Platform.h without the config.h in the
WebKitTestRunnerPrefix.h. Added the autotoolsconfig.h include in
the Prefix file.

Reviewed by Martin Robinson.

WebKitTestRunner/WebKitTestRunnerPrefix.h:

12:42 AM Changeset in webkit [98220] by Patrick Gansterer

2 edits in trunk/Source/JavaScriptCore

Interpreter build fix after r98179.

bytecode/CodeBlock.h:

Moved CodeBlock::baselineVersion() into ENABLE(JIT) block,
since it is only used there.

Oct 23, 2011:

11:59 PM Changeset in webkit [98219] by Darin Adler

10 edits
2 deletes in trunk/Source/WebCore

Eliminate OptionElement (second and final part)
https://bugs.webkit.org/show_bug.cgi?id=70710

Reviewed by Kent Tamura.

CMakeLists.txt: Removed OptionElement.h and OptionElement.cpp.
GNUmakefile.list.am: Ditto.
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
dom/DOMAllInOne.cpp: Ditto.

dom/OptionElement.cpp: Removed.
dom/OptionElement.h: Removed.

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::saveLastSelection): Eliminate use of the
toOptionElement function. Use hasTagName and toHTMLOptionElement instead.
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): Ditto.
(WebCore::HTMLSelectElement::updateListBoxSelection): Ditto.
(WebCore::HTMLSelectElement::listBoxOnChange): Ditto.
(WebCore::HTMLSelectElement::recalcListItems): Ditto.
(WebCore::HTMLSelectElement::selectedIndex): Ditto.
(WebCore::HTMLSelectElement::setSelectedIndex): Ditto.
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation): Ditto.
(WebCore::HTMLSelectElement::saveFormControlState): Ditto.
(WebCore::HTMLSelectElement::restoreFormControlState): Ditto.
(WebCore::HTMLSelectElement::appendFormData): Ditto.
(WebCore::HTMLSelectElement::reset): Ditto.
(WebCore::HTMLSelectElement::updateSelectedState): Ditto.
(WebCore::HTMLSelectElement::lastSelectedListIndex): Ditto.
(WebCore::HTMLSelectElement::typeAheadFind): Ditto.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Ditto.

html/HTMLSelectElement.h: Changed the argument type of the

deselectItemsWithoutValidation function to HTMLElement* since that's
the type of an item in our items vector now.

11:54 PM Changeset in webkit [98218] by yuzo@google.com

2 edits in trunk/Source/WebCore

[chromium] Attempt to fix compilation error for Chromium OS.

Unreviewed.

mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::kind):

10:53 PM Changeset in webkit [98217] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

Fixed a typo Darin spotted.

wtf/StringHasher.h:

(WTF::StringHasher::hash): Expelliarmus!

10:51 PM Changeset in webkit [98216] by ggaren@apple.com

4 edits in trunk/Source/JavaScriptCore

Removed StringImpl::createStrippingNullCharacters
https://bugs.webkit.org/show_bug.cgi?id=70700

Reviewed by David Levin.

It was unused.

JavaScriptCore.exp:
wtf/text/StringImpl.cpp:
wtf/text/StringImpl.h:

9:36 PM Changeset in webkit [98215] by abarth@webkit.org

3 edits
2 adds in trunk

<img crossorigin> should fail to load when CORS check fails
https://bugs.webkit.org/show_bug.cgi?id=69732

Reviewed by Darin Adler.

Source/WebCore:

When loading an image with the crossorigin attribute, the spec says
that we're not supposed to load the image if the CORS check fails.
This "fails fast" behavior is intended to help developers understand
whether they've configured CORS correctly (instead of only catching the
error later when trying to read back the canvas).

Our new behavior matches the spec and Firefox.

Test: http/tests/security/img-with-failed-cors-check-fails-to-load.html

loader/ImageLoader.cpp:

(WebCore::ImageLoader::notifyFinished):

LayoutTests:

Test that images loaded with the crossorigin attribute fail to load if
the CORS access check doesn't pass.

http/tests/security/img-with-failed-cors-check-fails-to-load-expected.txt: Added.
http/tests/security/img-with-failed-cors-check-fails-to-load.html: Added.

8:58 PM Changeset in webkit [98214] by fpizlo@apple.com

9 edits
3 adds in trunk

DFG should inline constructors
https://bugs.webkit.org/show_bug.cgi?id=70675

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Adds support for inlining constructors. Also fixes two pathologies
uncovered along the way: CheckMethod claimed that it never returned a
result (causing CheckMethod -> SetLocal -> GetLocal sequences to
result in the GetLocal doing OSR exit), and get_by_id parsing never
checked if it was hot in slow path. Also fiddled with inlining
heuristics; it appears that for now, the more inlining, the happier
V8 is. Finally, a bug was uncovered where a silent spill of a boxed
integer that had previously been spilled unboxed causes the silent
fill to forget to unbox.

This appears to be a 4% speed-up on V8 in their harness, or a 1%
speed-up in my harness. The difference is due to warm-up: in my
harness we see significant amounts of time spent in compilation, but
in V8's harness compilation gets amortizes. Profiling indicates that
we have the potential for a 5% win from basic optimizations like
generating OSR exits lazily and holding onto bytecode longer.

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):

dfg/DFGCapabilities.h:

(JSC::DFG::mightInlineFunctionForConstruct):
(JSC::DFG::canInlineOpcode):
(JSC::DFG::mightInlineFunctionFor):
(JSC::DFG::canInlineFunctionFor):

dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentFillGPR):

runtime/Executable.h:

(JSC::isCall):
(JSC::ExecutableBase::intrinsicFor):

runtime/Heuristics.cpp:

(JSC::Heuristics::initializeHeuristics):

runtime/Heuristics.h:

LayoutTests:

Reviewed by Oliver Hunt.

Adds test that asserts that register pressure induced by inlining doesn't
result in spilling corrupting values.

fast/js/dfg-inlining-reg-alloc-expected.txt: Added.
fast/js/dfg-inlining-reg-alloc.html: Added.
fast/js/script-tests/dfg-inlining-reg-alloc.js: Added.

(foo):
(bar):
(baz):

8:40 PM Changeset in webkit [98213] by yuzo@google.com

2 edits in trunk/LayoutTests

[chromium] Test expecation change. inspector/elements/edit-dom-actions.html times out since around r98120:98133 (chromium 106751:106770).

Unreviewed.

platform/chromium/test_expectations.txt:

7:57 PM Changeset in webkit [98212] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] Remove unused code from EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=70590

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2011-10-23
Reviewed by Andreas Kling.

Removed unused function on_closeWindow from EWebLauncher

EWebLauncher/main.c:

7:54 PM Changeset in webkit [98211] by yuzo@google.com

2 edits in trunk/LayoutTests

[chromium] Test expectation change for "r98183 causes 4 snowleopard tests to fail".
https://bugs.webkit.org/show_bug.cgi?id=70704

Unreviewed.

platform/chromium/test_expectations.txt:

7:23 PM Changeset in webkit [98210] by noel.gordon@gmail.com

2 edits in trunk/Source/JavaScriptCore

[chromium] Remove RopeImpl.{h,cpp} from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=70703

Reviewed by Kent Tamura.

runtime/RopeImpl.{h,cpp} were removed in r97872, remove references
to these files from the gyp project files.

JavaScriptCore.gypi:

7:18 PM Changeset in webkit [98209] by noel.gordon@gmail.com

2 edits in trunk/Source/WebCore

[chromium] Remove GeolocationServiceGtk.{h,cpp} from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=70702

Reviewed by Kent Tamura.

platform/gtk/GeolocationServiceGtk.{h,cpp} were removed in r97746, so
remove references to these files from the gyp files.

WebCore.gypi:

6:49 PM Changeset in webkit [98208] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Move StyleSheet::addSubresourceStyleURLs() to CSSStyleSheet.
https://bugs.webkit.org/show_bug.cgi?id=70690

Patch by Andreas Kling <kling@webkit.org> on 2011-10-23
Reviewed by Antti Koivisto.

This method isn't part of the StyleSheet DOM interface, nor is it used by
XSLStyleSheet, so move it down to CSSStyleSheet and make it non-virtual.
Also remove some nearby unneeded casts from CSSStyleSheet* to StyleSheet*.

css/CSSStyleSheet.h:
css/StyleSheet.h:
html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::isLoading):
(WebCore::HTMLLinkElement::addSubresourceAttributeURLs):

html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::addSubresourceAttributeURLs):
(WebCore::HTMLStyleElement::disabled):
(WebCore::HTMLStyleElement::setDisabled):

6:42 PM Changeset in webkit [98207] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Remove style sheet constructors that take a style sheet parent.
https://bugs.webkit.org/show_bug.cgi?id=70692

Patch by Andreas Kling <kling@webkit.org> on 2011-10-23
Reviewed by Antti Koivisto.

Style sheets are never directly parented by other style sheets, they always
go via a rule (such as @import.)

css/CSSStyleSheet.cpp:
css/CSSStyleSheet.h:

(WebCore::CSSStyleSheet::create):

css/StyleSheet.cpp:
css/StyleSheet.h:

5:37 PM Changeset in webkit [98206] by macpherson@chromium.org

2 edits in trunk/Tools

Add watchlist for WebCore/css and put myself on it.
https://bugs.webkit.org/show_bug.cgi?id=70701

Reviewed by Adam Barth.

Scripts/webkitpy/common/config/watchlist:

Add watchlist for WebCore/css and put myself on it.

5:21 PM Changeset in webkit [98205] by mhahnenberg@apple.com

6 edits in trunk/Source

Add deleteProperty to the MethodTable
https://bugs.webkit.org/show_bug.cgi?id=70162

Reviewed by Sam Weinig.

Source/JavaScriptCore:

JavaScriptCore.exp:
runtime/ClassInfo.h: Added both versions of deleteProperty to the MethodTable.
runtime/JSFunction.h: Changed JSFunction::deleteProperty to

be protected rather than private for subclasses who don't provide their own
implementation.

Source/WebCore:

No new tests.

WebCore.exp.in:

5:11 PM Changeset in webkit [98204] by abarth@webkit.org

4 edits in trunk/Source/WebCore

Update baselines for run-bindings-tests.

bindings/scripts/test/JS/JSTestInterface.cpp:
bindings/scripts/test/JS/JSTestInterface.h:
bindings/scripts/test/JS/JSTestObj.cpp:

2:14 PM Changeset in webkit [98203] by mhahnenberg@apple.com

54 edits in trunk/Source

Remove getConstructDataVirtual
https://bugs.webkit.org/show_bug.cgi?id=70638

Reviewed by Darin Adler.

Source/JavaScriptCore:

Removed all declarations and definitions of getConstructDataVirtual.
Also replaced all call sites to getConstructDataVirtual with a
corresponding lookup in the MethodTable.

API/JSCallbackConstructor.cpp:
API/JSCallbackConstructor.h:
API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:
API/JSObjectRef.cpp:

(JSObjectIsConstructor):
(JSObjectCallAsConstructor):

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
dfg/DFGOperations.cpp:
interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

runtime/ArrayConstructor.cpp:
runtime/ArrayConstructor.h:
runtime/BooleanConstructor.cpp:
runtime/BooleanConstructor.h:
runtime/DateConstructor.cpp:
runtime/DateConstructor.h:
runtime/Error.h:

(JSC::StrictModeTypeErrorFunction::getConstructData):

runtime/ErrorConstructor.cpp:
runtime/ErrorConstructor.h:
runtime/FunctionConstructor.cpp:
runtime/FunctionConstructor.h:
runtime/JSCell.cpp:
runtime/JSCell.h:
runtime/JSFunction.cpp:
runtime/JSFunction.h:
runtime/JSObject.h:

(JSC::getConstructData):

runtime/NativeErrorConstructor.cpp:
runtime/NativeErrorConstructor.h:
runtime/NumberConstructor.cpp:
runtime/NumberConstructor.h:
runtime/ObjectConstructor.cpp:
runtime/ObjectConstructor.h:
runtime/RegExpConstructor.cpp:
runtime/RegExpConstructor.h:
runtime/StringConstructor.cpp:
runtime/StringConstructor.h:

Source/WebCore:

No new tests.

Removed all declarations and definitions of getConstructDataVirtual.
Also replaced all call sites to getConstructDataVirtual with a
corresponding lookup in the MethodTable.

WebCore.exp.in:
bindings/js/JSAudioConstructor.cpp:
bindings/js/JSAudioConstructor.h:
bindings/js/JSImageConstructor.cpp:
bindings/js/JSImageConstructor.h:
bindings/js/JSOptionConstructor.cpp:
bindings/js/JSOptionConstructor.h:
bindings/js/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::construct):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

bridge/runtime_object.cpp:
bridge/runtime_object.h:

Source/WebKit/mac:

Removed all declarations and definitions of getConstructDataVirtual.
Also replaced all call sites to getConstructDataVirtual with a
corresponding lookup in the MethodTable.

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::construct):

Source/WebKit2:

Removed all declarations and definitions of getConstructDataVirtual.
Also replaced all call sites to getConstructDataVirtual with a
corresponding lookup in the MethodTable.

WebProcess/Plugins/Netscape/JSNPObject.cpp:
WebProcess/Plugins/Netscape/JSNPObject.h:

11:01 AM Changeset in webkit [98202] by ggaren@apple.com

3 edits in trunk/LayoutTests

Not reviewed.

Updated two test results I missed in my last check-in.

These tests depended on non-deterministic effects of hash order, so I
had to update them:

http/tests/inspector/search/search-in-resources-expected.txt:
platform/mac/fast/dom/prototype-inheritance-2-expected.txt:

12:34 AM Changeset in webkit [98201] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

Try to fix the SL build.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry): Cast
away int vs unisgned warning.

12:27 AM Changeset in webkit [98200] by commit-queue@webkit.org

5 edits
1 add in trunk

[GTK] Implement KeyDown function for WebKit2 EventSender.
https://bugs.webkit.org/show_bug.cgi?id=69410

Tools:

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-10-23
Reviewed by Martin Robinson.

Implement the KeyDown function on Gtk platform.

WebKitTestRunner/GNUmakefile.am:
WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: Added.

(WTR::EventSenderProxy::EventSenderProxy):
(WTR::dispatchEvent):
(WTR::getModifiers):
(WTR::getGDKKeySymForKeyRef):
(WTR::EventSenderProxy::keyDown):

LayoutTests:

Unskip passed tests.

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-10-23
Reviewed by Martin Robinson.

platform/gtk-wk2/Skipped:

12:21 AM Changeset in webkit [98199] by ggaren@apple.com

13 edits in trunk

Separated string lifetime bits from character buffer state bits
https://bugs.webkit.org/show_bug.cgi?id=70673

Source/JavaScriptCore:

Reviewed by Anders Carlsson.

Moved the static/immortal bit into the bottom bit of the refcount, and
moved all other bits into the high bits of the hash code.

This is the first step toward a new Characters/PassString class, and it
makes ref/deref slightly more efficient.

create_hash_table:
wtf/StringHasher.h:

(WTF::StringHasher::hash): Tweaked the string hashing function to leave
the top bits clear, so they can be used as flags.

Fixed some small differences between the PERL copy of this function and
the C++ copy of this function, which could have in theory caused subtle
crashes.

wtf/text/StringImpl.cpp:

(WTF::StringImpl::sharedBuffer):
(WTF::StringImpl::createWithTerminatingNullCharacter):

wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl):
(WTF::StringImpl::cost): Renamed s_refCountFlagShouldReportedCost to
s_didReportExtraCost, since the original name was both self-contradictory
and used as a double-negative.

(WTF::StringImpl::isIdentifier):
(WTF::StringImpl::setIsIdentifier):
(WTF::StringImpl::hasTerminatingNullCharacter):
(WTF::StringImpl::isAtomic):
(WTF::StringImpl::setIsAtomic):
(WTF::StringImpl::setHash):
(WTF::StringImpl::rawHash):
(WTF::StringImpl::hasHash):
(WTF::StringImpl::existingHash):
(WTF::StringImpl::hash):
(WTF::StringImpl::hasOneRef):
(WTF::StringImpl::ref):
(WTF::StringImpl::deref):
(WTF::StringImpl::bufferOwnership):
(WTF::StringImpl::isStatic): Moved the static/immortal bit into the bottom
bit of the refcount. Now, all lifetime information lives in the refcount
field. Moved the other bits into the hash code field.

Source/WebCore:

Reviewed by Anders Carlsson.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHashValue): Updated for string hashing changes in JavaScriptCore.

LayoutTests:

Reviewed by Anders Carlsson.

These tests depended on non-deterministic effects of hash order, so I
had to update them:

fast/dom/prototype-inheritance-2-expected.txt: Updated for slightly

different order of discovering properties.

fast/js/delete-syntax-expected.txt:
fast/js/script-tests/delete-syntax.js: Updated not to depend on iteration

order, since that's not what this test is about.

http/tests/inspector/inspector-test.js: Updated not to depend on

global function iteration order. This test setup is pretty spaghetti.
I think I avoided making it even more spaghetti.

Context Navigation

Timeline

Oct 24, 2011:

Oct 23, 2011:

Download in other formats: