Context Navigation

http/tests/inspector/search/search-in-resources-expected.txt:
platform/chromium-linux/http/tests/inspector/search/search-in-resources-expected.txt: Removed.

10:16 PM Changeset in webkit [98534] by rniwa@webkit.org

2 edits
8 adds in trunk/LayoutTests

Chromium Windows and Linux rebaselines.

platform/chromium-linux/http/tests/security/dataTransfer-set-data-file-url-expected.png: Added.
platform/chromium-linux/platform/mac/editing: Added.
platform/chromium-linux/platform/mac/editing/pasteboard: Added.
platform/chromium-linux/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
platform/chromium-win/http/tests/security/dataTransfer-set-data-file-url-expected.png: Added.
platform/chromium-win/http/tests/security/dataTransfer-set-data-file-url-expected.txt: Added.
platform/chromium-win/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
platform/chromium-win/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.txt: Added.
platform/chromium/test_expectations.txt:

9:56 PM Changeset in webkit [98533] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Console message in copy-standalone-image-crash.html bleeds into the result of copy-standalone-image.html
https://bugs.webkit.org/show_bug.cgi?id=70957

Reviewed by Ojan Vafai.

The bug was caused by the delayed hideDiv call in a mousedown event listener.
Fixed the bug by not attaching this event listener inside DRT or TestRunner.

editing/pasteboard/copy-standalone-image-crash.html:

6:51 PM Changeset in webkit [98532] by jchaffraix@webkit.org

2 edits in trunk/LayoutTests

Massive gardening.

platform/chromium/test_expectations.txt: Lots of tests were regularly failing

or timing out but were not marked. Added them as they were consistently flaky.

6:12 PM Changeset in webkit [98531] by jchaffraix@webkit.org

2 edits
3 adds in trunk/LayoutTests

Unreviewed gardening.

platform/chromium-linux/http/tests/inspector: Added.
platform/chromium-linux/http/tests/inspector/search: Added.
platform/chromium-linux/http/tests/inspector/search/search-in-resources-expected.txt: Added.

Rebaselined (looks like the urls are sorted differently on Linux).

platform/chromium/test_expectations.txt: Marked inspector/storage-panel-dom-storage.html

as TEXT as it started failing on the bots.

5:43 PM Changeset in webkit [98530] by sfalken@apple.com

2 edits in trunk/Source/WebCore

ResourceError doesn't support custom domains on Windows
https://bugs.webkit.org/show_bug.cgi?id=70983
<rdar://problem/10352145>

Reviewed by Oliver Hunt.

platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::platformLazyInit): Add fallback case for unknown error types.

5:29 PM Changeset in webkit [98529] by mitz@apple.com

2 edits in trunk/Source/WebCore

Fix a slider thumb rendering regression in Chromium on OS X in r98520.

Reviewed by Anders Carlsson.

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSliderThumb): Reverted the changes to the Chromium code path.

5:26 PM Changeset in webkit [98528] by leviw@chromium.org

5 edits in branches/subpixellayout/Source/WebCore

Fixing FixedPoint's flooredIntSize, adding an adjustedBorderBoxRectForCellRounding method to get Table border painting correct, and fixing float and linebox layout since my last checkin.

5:21 PM Changeset in webkit [98527] by jchaffraix@webkit.org

5 edits in trunk

Unreviewed, rolling out r98486.
http://trac.webkit.org/changeset/98486
https://bugs.webkit.org/show_bug.cgi?id=70748

Broke Chromium's test_expectation.txt

Source/WebCore:

platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::State::State):
(WebCore::PlatformContextSkia::State::cloneInheritedProperties):
(WebCore::PlatformContextSkia::clipPathAntiAliased):
(WebCore::PlatformContextSkia::restore):
(WebCore::PlatformContextSkia::applyAntiAliasedClipPaths):

platform/graphics/skia/PlatformContextSkia.h:

LayoutTests:

platform/chromium/test_expectations.txt:

5:20 PM Changeset in webkit [98526] by ap@apple.com

2 edits in trunk/Source/WebKit2

REGRESSION (r98153): Safari crashes if WebProcess crashed during printing
https://bugs.webkit.org/show_bug.cgi?id=70982

Reviewed by Dan Bernstein.

UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _delayedResumeAutodisplayTimerFired]): Null check page, it may be invalid already.

5:19 PM Changeset in webkit [98525] by oliver@apple.com

3 edits in trunk/Source/JavaScriptCore

Restore structure-clearing behaviour of allocateCell<>
https://bugs.webkit.org/show_bug.cgi?id=70976

Reviewed by Geoffrey Garen.

This restores the logic that allows the markstack to filter
live objects that have not yet been initialised.

runtime/JSCell.h:

(JSC::JSCell::clearStructure):

Validation-safe method to clear a cell's structure.

(JSC::allocateCell):

Call the above method.

runtime/Structure.h:

(JSC::MarkStack::internalAppend):

Don't visit cells that haven't been initialised.

3:42 PM Changeset in webkit [98524] by jchaffraix@webkit.org

1 edit
1 move in trunk/LayoutTests

Unreviewed trivial renaming.

fast/js/dfg-intrinsic-osr-exit-expected.html: Removed.
fast/js/dfg-intrinsic-osr-exit-expected.txt: Copied from LayoutTests/fast/js/dfg-intrinsic-osr-exit-expected.html.

3:26 PM Changeset in webkit [98523] by jchaffraix@webkit.org

2 edits in trunk/LayoutTests

Unreviewed gardening.

platform/chromium/test_expectations.txt:

storage/domstorage/events/basic-setattribute.html is a flaky crasher.

3:12 PM Changeset in webkit [98522] by jamesr@google.com

2 edits in branches/chromium/874/Source/WebCore

Merge 98112 - Fix Windows build.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::hasAnyAdditionalCompositedLayers):

TBR=jamesr@chromium.org
Review URL: http://codereview.chromium.org/8363033

3:11 PM Changeset in webkit [98521] by jamesr@google.com

5 edits in branches/chromium/874

Merge 98060 - Hidden composited iframes cause infinite loop
https://bugs.webkit.org/show_bug.cgi?id=52655

Source/WebCore:

Reviewed by Darin Adler.

visibility:hidden is problematic for compositing, because it causes
RenderLayers to be removed from the z-order layer tree. This confuses
RenderLayerCompositor in several ways; it never sees these layers
when traversing the tree as it computes compositing requirements, or
rebuilds the layer tree.

This is a particular problem with composited iframes. When an iframe
becomes composited, scheduleSetNeedsStyleRecalc() is called on that
iframe's ownerElement in the parent document. If this happens inside
Document::updateStyleForAllDocuments(), we get into an infinite loop
because notifyIFramesOfCompositingChange() queues up style update as we
bounce in and out of compositing mode, so documentsThatNeedStyleRecalc
never empties out.

This is an initial, conservative fix that doesn't attempt to fix all
the issues with visibility. It changes RenderLayerCompositor to count
the number of compositing RenderLayers, and to not leave compositing
mode if there are any (even if they are hidden, so not hit while
traversing the z-order tree). This avoids the infinite loop.

Test: compositing/visibility/hidden-iframe.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::ensureBacking):
(WebCore::RenderLayer::clearBacking):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::hasAnyAdditionalCompositedLayers):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):

rendering/RenderLayerCompositor.h:

(WebCore::RenderLayerCompositor::layerBecameComposited):
(WebCore::RenderLayerCompositor::layerBecameNonComposited):

LayoutTests:

Reviewed by Darin Adler.

Test with a visibility:hidden iframe, whose subframe becomes composited.

compositing/visibility/hidden-iframe-expected.txt: Added.
compositing/visibility/hidden-iframe.html: Added.

TBR=Simon Fraser
Review URL: http://codereview.chromium.org/8403008

2:41 PM Changeset in webkit [98520] by mitz@apple.com

3 edits in trunk/Source/WebCore

<rdar://problem/10350775> REGRESSION (r97032): Slider thumb is not drawn
https://bugs.webkit.org/show_bug.cgi?id=70891

Reviewed by Anders Carlsson.

platform/mac/ThemeMac.mm:

(WebCore::ThemeMac::ensuredView): Set the WebCoreFlippedView’s size, because NSSliderCell
always shrinks the slider thumb to fit in the control view’s bounds.

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSliderThumb): Removed workaround code no longer needed after
r97032.

2:33 PM Changeset in webkit [98519] by Lucas Forschler

5 edits in branches/safari-534.52-branch/Source

Versioning.

2:32 PM Changeset in webkit [98518] by caryclark@google.com

5 edits
676 adds in trunk/LayoutTests

Unreviewed gardening: sixth chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 674 of 680 files for brevity.]

platform/chromium-mac-leopard/svg/as-background-image: Added.
platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png: Added.
platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-5-expected.png: Added.

...

platform/chromium-mac-leopard/tables/mozilla/core/margins-expected.png:
platform/chromium-mac-leopard/tables/mozilla/marvin/x_col_valign_baseline-expected.png: Added.
platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:

2:13 PM Changeset in webkit [98517] by fpizlo@apple.com

3 edits
3 adds in trunk

REGRESSION (r97030): Cannot log in to progressive.com
https://bugs.webkit.org/show_bug.cgi?id=70094

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):

LayoutTests:

fast/js/dfg-intrinsic-osr-exit-expected.html: Added.
fast/js/dfg-intrinsic-osr-exit.html: Added.
fast/js/script-tests/dfg-intrinsic-osr-exit.js: Added.

(foo):

2:09 PM Changeset in webkit [98516] by Lucas Forschler

1 copy in tags/Safari-534.52.4

New tag.

1:43 PM Changeset in webkit [98515] by leandro@webkit.org

1 edit
772 adds in trunk/LayoutTests

[EFL] Unreviewed. Add pixel baselines for CSS3 tests.

platform/efl/css3: [...]

1:20 PM Changeset in webkit [98514] by crogers@google.com

6 edits
1 copy in trunk/Source/WebKit/chromium

Add chromium bridging for AudioSourceProviderClient and setFormat() method so we can know audio stream format
https://bugs.webkit.org/show_bug.cgi?id=70650

Reviewed by Darin Fisher.

WebKit.gyp:
public/WebAudioSourceProvider.h:

(WebKit::WebAudioSourceProvider::setClient):

public/WebAudioSourceProviderClient.h: Copied from Source/WebKit/chromium/public/WebAudioSourceProvider.h.

(WebKit::WebAudioSourceProviderClient::~WebAudioSourceProviderClient):

public/WebMediaPlayer.h:
src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::audioSourceProvider):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::wrap):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::setClient):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::provideInput):
(WebKit::WebMediaPlayerClientImpl::AudioClientImpl::setFormat):

src/WebMediaPlayerClientImpl.h:

(WebKit::WebMediaPlayerClientImpl::AudioClientImpl::AudioClientImpl):
(WebKit::WebMediaPlayerClientImpl::AudioClientImpl::~AudioClientImpl):
(WebKit::WebMediaPlayerClientImpl::AudioClientImpl::wrap):

1:19 PM Changeset in webkit [98513] by jeffm@apple.com

5 edits in trunk/Source/WebKit2

WebKit2 should respect secret WebKitOmitPDFSupport preference on the Mac
https://bugs.webkit.org/show_bug.cgi?id=70943

If WebKitOmitPDFSupport pref is set, disable both the new "plug-in" for subframes and the PDFKit-based support for the main frame only.

Reviewed by Alexey Proskuryakov.

UIProcess/WebContext.cpp:

(WebKit::WebContext::getPlugins): Don't register built-in PDF plugin if WebKitOmitPDFSupport pref is set.

UIProcess/WebContext.h: Added omitPDFSupport().

UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::canShowMIMEType): Don't show PDFs if WebKitOmitPDFSupport is set.

UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::omitPDFSupport): Added.

12:57 PM Changeset in webkit [98512] by crogers@google.com

7 edits
1 copy in trunk/Source/WebCore

Add AudioSourceProviderClient and setFormat() method so we can know audio stream format
https://bugs.webkit.org/show_bug.cgi?id=70155

Reviewed by Eric Carlson.

No new tests. There isn't yet an implementation to test.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::createMediaPlayer):
(WebCore::HTMLMediaElement::setAudioSourceNode):
Let MediaPlayer know about the MediaElementAudioSourceNode so it can callback with audio stream format information.

platform/audio/AudioSourceProvider.h:

(WebCore::AudioSourceProvider::setClient):
Add abstract setClient() method so a client may know about stream format information when it becomes available.

platform/audio/AudioSourceProviderClient.h: Copied from Source/WebCore/webaudio/MediaElementAudioSourceNode.h.

(WebCore::AudioSourceProviderClient::~AudioSourceProviderClient):
Add abstract class AudioSourceProviderClient which implements setFormat() to receive audio stream format information.

webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::setFormat):
Concrete implementation of setFormat() so MediaElementAudioSourceNode can create necessary audio converters.

webaudio/MediaElementAudioSourceNode.h:

Make MediaElementAudioSourceNode implement AudioSourceProviderClient so it can get audio stream format information
when its setFormat() method is called.

12:55 PM Changeset in webkit [98511] by leandro@webkit.org

1 edit
708 adds in trunk/LayoutTests

[EFL] Unreviewed. Add pixel baselines for CSS2.1 tests.

platform/efl/css2.1: [...]

12:06 PM Changeset in webkit [98510] by rniwa@webkit.org

2 edits
1 add in trunk/LayoutTests

Chromium Mac rebaseline.

platform/chromium-mac-leopard/editing/pasteboard/copy-standalone-image-expected.png: Added.
platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.png:

12:01 PM Changeset in webkit [98509] by weinig@apple.com

5 edits
1 add in trunk

Add initial setting to WKBrowsingContextGroup
https://bugs.webkit.org/show_bug.cgi?id=70942

Reviewed by Anders Carlsson.

Source/WebKit2:

Test: WKBrowsingContextGroupTest.

UIProcess/API/mac/WKBrowsingContextGroup.h:
UIProcess/API/mac/WKBrowsingContextGroup.mm:

(-[WKBrowsingContextGroup isJavaScriptEnabled]):
(-[WKBrowsingContextGroup setJavaScriptEnabled:]):
Add setting to enabled/disable javascript. By default it is enabled.

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm: Added.

Add basic test that setting the javaScriptEnabled setting takes. It is not
possible to test its effect quite yet.

11:58 AM Changeset in webkit [98508] by jchaffraix@webkit.org

49 edits
2 adds
94 deletes in trunk

Unreviewed, rolling out r98483.
http://trac.webkit.org/changeset/98483
https://bugs.webkit.org/show_bug.cgi?id=47156

Change is causing some crashes and ASSERTs.

Source/WebCore:

loader/cache/CachedImage.cpp:

(WebCore::CachedImage::lookupImageForSize):
(WebCore::CachedImage::lookupImageForRenderer):
(WebCore::CachedImage::lookupOrCreateImageForRenderer):
(WebCore::CachedImage::setContainerSizeForRenderer):
(WebCore::CachedImage::imageSizeForRenderer):
(WebCore::CachedImage::computeIntrinsicDimensions):
(WebCore::CachedImage::createImage):

loader/cache/CachedImage.h:
page/ChromeClient.h:
rendering/ImageBySizeCache.cpp:

(WebCore::ImageBySizeCache::addClient):
(WebCore::ImageBySizeCache::removeClient):
(WebCore::ImageBySizeCache::imageForSize):
(WebCore::ImageBySizeCache::sizeForClient):

rendering/ImageBySizeCache.h:
rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::RenderBoxModelObject::paintNinePieceImage):

rendering/RenderBoxModelObject.h:
rendering/RenderImage.cpp:

(WebCore::RenderImage::RenderImage):
(WebCore::RenderImage::imageDimensionsChanged):
(WebCore::RenderImage::isLogicalWidthSpecified):
(WebCore::RenderImage::isLogicalHeightSpecified):
(WebCore::RenderImage::computeReplacedLogicalWidth):
(WebCore::RenderImage::computeReplacedLogicalHeight):
(WebCore::RenderImage::calcAspectRatioLogicalWidth):
(WebCore::RenderImage::calcAspectRatioLogicalHeight):

rendering/RenderImage.h:
rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::setContainerSizeForRenderer):

rendering/RenderImageResourceStyleImage.cpp:
rendering/RenderImageResourceStyleImage.h:

(WebCore::RenderImageResourceStyleImage::image):
(WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer):

rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::computePreferredLogicalWidths):

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeIntrinsicLogicalWidth):
(WebCore::RenderReplaced::computeIntrinsicLogicalHeight):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):

rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::computeIntrinsicDimensions):
(WebCore::StyleCachedImage::setContainerSizeForRenderer):
(WebCore::StyleCachedImage::addClient):
(WebCore::StyleCachedImage::removeClient):

rendering/style/StyleCachedImage.h:
rendering/style/StyleGeneratedImage.h:

(WebCore::StyleGeneratedImage::setContainerSizeForRenderer):

rendering/style/StyleImage.h:
rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::setContainerSizeForRenderer):

rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::layout):

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeIntrinsicWidth):
(WebCore::RenderSVGRoot::computeIntrinsicHeight):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::paint):
(WebCore::RenderSVGRoot::calcViewport):
(WebCore::RenderSVGRoot::computeRectForRepaint):

rendering/svg/RenderSVGRoot.h:
svg/SVGLength.cpp:

(WebCore::SVGLength::determineViewport):

svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::relativeWidthValue):
(WebCore::SVGSVGElement::relativeHeightValue):
(WebCore::SVGSVGElement::currentViewBoxRect):

svg/SVGSVGElement.h:

(WebCore::SVGSVGElement::setContainerSize):
(WebCore::SVGSVGElement::containerSize):
(WebCore::SVGSVGElement::hasSetContainerSize):

svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::usesContainerSize):
(WebCore::SVGImage::size):
(WebCore::SVGImage::hasRelativeWidth):
(WebCore::SVGImage::hasRelativeHeight):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::computeIntrinsicDimensions):
(WebCore::SVGImage::dataChanged):

svg/graphics/SVGImage.h:

LayoutTests:

css2.1/20110323/background-intrinsic-001.htm: Removed.
css2.1/20110323/background-intrinsic-002.htm: Removed.
css2.1/20110323/background-intrinsic-003.htm: Removed.
css2.1/20110323/background-intrinsic-004.htm: Removed.
css2.1/20110323/background-intrinsic-005.htm: Removed.
css2.1/20110323/background-intrinsic-006.htm: Removed.
css2.1/20110323/background-intrinsic-007.htm: Removed.
css2.1/20110323/background-intrinsic-008.htm: Removed.
css2.1/20110323/background-intrinsic-009.htm: Removed.
css2.1/20110323/resources/green-intrinsic-height-ratio.svg: Removed.
css2.1/20110323/resources/green-intrinsic-height.svg: Removed.
css2.1/20110323/resources/green-intrinsic-none.svg: Removed.
css2.1/20110323/resources/green-intrinsic-ratio-landscape.svg: Removed.
css2.1/20110323/resources/green-intrinsic-ratio-portrait.svg: Removed.
css2.1/20110323/resources/green-intrinsic-width-height.svg: Removed.
css2.1/20110323/resources/green-intrinsic-width-pc-height-pc.svg: Removed.
css2.1/20110323/resources/green-intrinsic-width-ratio.svg: Removed.
css2.1/20110323/resources/green-intrinsic-width.svg: Removed.
css2.1/20110323/resources/red-intrinsic-height-ratio.svg: Removed.
css2.1/20110323/resources/red-intrinsic-height.svg: Removed.
css2.1/20110323/resources/red-intrinsic-none.svg: Removed.
css2.1/20110323/resources/red-intrinsic-ratio-landscape.svg: Removed.
css2.1/20110323/resources/red-intrinsic-ratio-portrait.svg: Removed.
css2.1/20110323/resources/red-intrinsic-width-height.svg: Removed.
css2.1/20110323/resources/red-intrinsic-width-pc-height-pc.svg: Removed.
css2.1/20110323/resources/red-intrinsic-width-ratio.svg: Removed.
css2.1/20110323/resources/red-intrinsic-width.svg: Removed.
fast/backgrounds/size/contain-and-cover-zoomed.html: Removed.
fast/images/percent-height-image-expected.txt:
fast/images/percent-height-image.html:
platform/mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
platform/mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
platform/mac/css1/text_properties/vertical_align-expected.txt:
platform/mac/css2.1/20110323/background-intrinsic-001-expected.png: Removed.
platform/mac/css2.1/20110323/background-intrinsic-001-expected.txt: Removed.
platform/mac/css2.1/20110323/background-intrinsic-002-expected.png: Removed.
platform/mac/css2.1/20110323/background-intrinsic-002-expected.txt: Removed.
platform/mac/css2.1/20110323/background-intrinsic-003-expected.png: Removed.
platform/mac/css2.1/20110323/background-intrinsic-003-expected.txt: Removed.
platform/mac/css2.1/20110323/background-intrinsic-004-expected.png: Removed.
platform/mac/css2.1/20110323/background-intrinsic-004-expected.txt: Removed.
platform/mac/css2.1/20110323/background-intrinsic-005-expected.png: Removed.
platform/mac/css2.1/20110323/background-intrinsic-005-expected.txt: Removed.
platform/mac/css2.1/20110323/background-intrinsic-006-expected.png: Removed.
platform/mac/css2.1/20110323/background-intrinsic-006-expected.txt: Removed.
platform/mac/css2.1/20110323/background-intrinsic-007-expected.png: Removed.
platform/mac/css2.1/20110323/background-intrinsic-007-expected.txt: Removed.
platform/mac/css2.1/20110323/background-intrinsic-008-expected.png: Removed.
platform/mac/css2.1/20110323/background-intrinsic-008-expected.txt: Removed.
platform/mac/css2.1/20110323/background-intrinsic-009-expected.png: Removed.
platform/mac/css2.1/20110323/background-intrinsic-009-expected.txt: Removed.
platform/mac/fast/backgrounds/size/contain-and-cover-expected.png:
platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Removed.
platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
platform/mac/fast/block/float/015-expected.png:
platform/mac/fast/block/float/015-expected.txt:
platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt:
platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt:
platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Removed.
platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Removed.
platform/mac/svg/as-background-image/background-image-tiled-expected.png: Removed.
platform/mac/svg/as-background-image/background-image-tiled-expected.txt: Removed.
platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.png: Removed.
platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Removed.
platform/mac/svg/as-background-image/svg-as-background-4-expected.png:
platform/mac/svg/as-border-image/svg-as-border-image-expected.png:
platform/mac/svg/as-image/animated-svg-as-image-expected.png:
platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Removed.
platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Removed.
platform/mac/svg/as-image/same-image-two-instances-expected.png: Removed.
platform/mac/svg/as-image/same-image-two-instances-expected.txt: Removed.
platform/mac/svg/as-image/svg-as-relative-image-expected.png:
platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Removed.
platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Removed.
platform/mac/svg/as-image/svg-image-change-content-size-expected.png: Removed.
platform/mac/svg/as-image/svg-image-change-content-size-expected.txt: Removed.
platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.png: Removed.
platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
platform/mac/svg/zoom/page/zoom-background-images-expected.png: Removed.
platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Removed.
platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Removed.
platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Removed.
platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Removed.
platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Removed.
svg/as-background-image/background-image-preserveaspectRatio-support.html: Removed.
svg/as-background-image/background-image-tiled.html: Removed.
svg/as-background-image/resources/construction-tape.svg: Removed.
svg/as-background-image/resources/hearts.svg:
svg/as-background-image/same-image-two-instances-background-image.html: Removed.
svg/as-image/img-preserveAspectRatio-support-1.html: Removed.
svg/as-image/resources/circle-default-meet.svg: Removed.
svg/as-image/resources/circle-default-none.svg: Removed.
svg/as-image/resources/circle-default-slice.svg: Removed.
svg/as-image/resources/circle-nosize.svg: Removed.
svg/as-image/resources/circle-viewbox-default.svg: Removed.
svg/as-image/resources/circle-viewbox-meet.svg: Removed.
svg/as-image/resources/circle-viewbox-none.svg: Removed.
svg/as-image/resources/circle-viewbox-slice.svg: Removed.
svg/as-image/resources/green-relative-size-rect.svg:
svg/as-image/same-image-two-instances.html: Removed.
svg/as-image/svg-as-relative-image-with-explicit-size.html: Removed.
svg/as-image/svg-image-change-content-size.xhtml: Removed.
svg/zoom/page/resources/relative-sized-background-with-viewBox.svg: Removed.
svg/zoom/page/zoom-background-image-tiled.html: Removed.
svg/zoom/page/zoom-background-images.html: Removed.
svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html: Removed.
svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html: Removed.
svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Removed.

11:51 AM Changeset in webkit [98507] by eric.carlson@apple.com

5 edits in trunk

Constructors for all TextTrack interfaces should be available on DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=70734

Source/WebCore:

Reviewed by Sam Weinig.

window-properties-expected.txt and global-constructors-expected.txt updated for this change.

page/DOMWindow.idl: Add HTMLTrackElement, TextTrack, and TextTrackCueList.

LayoutTests:

Reviewed by Sam Weinig.

platform/gtk/fast/dom/Window/window-properties-expected.txt:
platform/gtk/fast/js/global-constructors-expected.txt:

11:41 AM Changeset in webkit [98506] by aestes@apple.com

2 edits in trunk/Source/WebCore

REGRESSION (r93108): Shadow DOM media controls created for plug-in backed media elements.
https://bugs.webkit.org/show_bug.cgi?id=70872

Reviewed by Eric Carlson.

r93108 added a call to HTMLMediaElement::configureMediaControls() in
HTMLMediaElement::prepareForLoad(), which creates shadow DOM media
controls and is only appropriate to call when media elements are not
backed by plug-in proxies.

Resolve this by refactoring configureMediaControls() to do the right
thing for the plug-in proxy case by calling MediaPlayer::setControls().

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::attributeChanged): Call
configureMediaControls() directly and remove the preprocessor
conditional.
(WebCore::HTMLMediaElement::configureMediaControls): Call
MediaPlayer::setControls() if PLUGIN_PROXY_FOR_VIDEO is enabled.

11:36 AM Changeset in webkit [98505] by jonlee@apple.com

4 edits
2 adds in trunk

selectedIndex gets set from -1 to 0 when modifying options
https://bugs.webkit.org/show_bug.cgi?id=70547
<rdar://problem/8388856>

Reviewed by Darin Adler.

Source/WebCore:

Changing the text causes a recalculation of the list items, which in the menu list case
forces the first element to be selected. We check the value of the selected option prior,
and restore it if it differs.

Test: fast/dom/HTMLSelectElement/selected-index-preserved-when-option-text-changes.html

html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::setText):

html/HTMLSelectElement.h: promote usesMenuList() from private to public for use by HTMLOptionElement

LayoutTests:

The added tests set the selected index to either -1 or 1 (a legitimate value), and then change
the text, value, and label of the option. In all cases, the selected index should remain unchanged.

fast/dom/HTMLSelectElement/selected-index-preserved-when-option-text-changes-expected.txt: Added.
fast/dom/HTMLSelectElement/selected-index-preserved-when-option-text-changes.html: Added.

11:29 AM Changeset in webkit [98504] by zherczeg@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add new CSS escape sequence parsing tests
https://bugs.webkit.org/show_bug.cgi?id=70909

Reviewed by Darin Adler.

Test escape various sequences terminated by \n \f \r and \r\n.

fast/css/parsing-css-escapes-expected.txt: Added.
fast/css/parsing-css-escapes.html: Added.

11:11 AM Changeset in webkit [98503] by ap@apple.com

12 edits in trunk/Source

Embedded PDFs should be known to DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=70864

Reviewed by Darin Adler.

WebProcess/Plugins/Plugin.h: Plugin stream load notifications now contain a suggested file name, in case the plug-in wants to save the file properly.

WebProcess/Plugins/PDF/BuiltInPDFView.h:
WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::addArchiveResource): Add the PDF as resource in DocumentLoader. (WebKit::BuiltInPDFView::pdfDocumentDidLoad): Call addArchiveResource. (WebKit::BuiltInPDFView::initialize): We need to remember source URL to create a resource for that. The URL needs to match one in HitTestResult, so we can't use response URL. (WebKit::BuiltInPDFView::streamDidReceiveResponse): Remember suggested file name, so that we could put it in archive resource later. (WebKit::BuiltInPDFView::manualStreamDidReceiveResponse): Ditto.

PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::streamDidReceiveResponse): (WebKit::PluginControllerProxy::manualStreamDidReceiveResponse): Pass an empty string for suggested file name. No plug-in that runs in a separate process cares about it, so it's not sent to the plugin process.

WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::streamDidReceiveResponse): (WebKit::NetscapePlugin::manualStreamDidReceiveResponse):
WebProcess/Plugins/Netscape/NetscapePlugin.h: Updated for new signatures.

WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::streamDidReceiveResponse): (WebKit::PluginProxy::manualStreamDidReceiveResponse):
WebProcess/Plugins/PluginProxy.h: Updated for new signatures.

WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::Stream::didReceiveResponse): (WebKit::PluginView::manualLoadDidReceiveResponse): Pass suggested file name to plug-in, in case the plug-in wants to save the file properly.

10:56 AM Changeset in webkit [98502] by rniwa@webkit.org

2 edits
18 adds in trunk/LayoutTests

Chromium Mac editing test rebaseline.

platform/chromium-cg-mac-leopard/platform/mac/editing: Added.
platform/chromium-cg-mac-leopard/platform/mac/editing/pasteboard: Added.
platform/chromium-cg-mac-leopard/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
platform/chromium-mac-leopard/http/tests/security: Added.
platform/chromium-mac-leopard/http/tests/security/dataTransfer-set-data-file-url-expected.png: Added.
platform/chromium-mac-leopard/platform/mac: Added.
platform/chromium-mac-leopard/platform/mac/editing: Added.
platform/chromium-mac-leopard/platform/mac/editing/pasteboard: Added.
platform/chromium-mac-leopard/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
platform/chromium-mac-snowleopard/http: Added.
platform/chromium-mac-snowleopard/http/tests: Added.
platform/chromium-mac-snowleopard/http/tests/security: Added.
platform/chromium-mac-snowleopard/http/tests/security/dataTransfer-set-data-file-url-expected.png: Added.
platform/chromium-mac-snowleopard/platform: Added.
platform/chromium-mac-snowleopard/platform/mac: Added.
platform/chromium-mac-snowleopard/platform/mac/editing: Added.
platform/chromium-mac-snowleopard/platform/mac/editing/pasteboard: Added.
platform/chromium-mac-snowleopard/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
platform/chromium/test_expectations.txt:

10:55 AM Changeset in webkit [98501] by mhahnenberg@apple.com

89 edits in trunk/Source

Remove getOwnPropertySlotVirtual
https://bugs.webkit.org/show_bug.cgi?id=70741

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Removed all declarations and definitions of getOwnPropertySlotVirtual.
Also replaced all call sites to getOwnPropertyVirtualVirtual with a
corresponding lookup in the MethodTable.

API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertyDescriptor):

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::getOwnPropertySlot):

debugger/DebuggerActivation.h:
runtime/Arguments.cpp:
runtime/Arguments.h:
runtime/ArrayConstructor.cpp:
runtime/ArrayConstructor.h:
runtime/ArrayPrototype.cpp:
runtime/ArrayPrototype.h:
runtime/BooleanPrototype.cpp:
runtime/BooleanPrototype.h:
runtime/DateConstructor.cpp:
runtime/DateConstructor.h:
runtime/DatePrototype.cpp:
runtime/DatePrototype.h:

(JSC::DatePrototype::create):

runtime/ErrorPrototype.cpp:
runtime/ErrorPrototype.h:
runtime/JSActivation.cpp:
runtime/JSActivation.h:
runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertySlotByIndex):

runtime/JSArray.h:
runtime/JSByteArray.cpp:
runtime/JSByteArray.h:
runtime/JSCell.cpp:
runtime/JSCell.h:
runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnPropertyNames):
(JSC::JSFunction::put):

runtime/JSFunction.h:
runtime/JSGlobalObject.cpp:
runtime/JSGlobalObject.h:
runtime/JSNotAnObject.cpp:
runtime/JSNotAnObject.h:
runtime/JSONObject.cpp:

(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):

runtime/JSONObject.h:
runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::hasOwnProperty):

runtime/JSObject.h:

(JSC::JSCell::fastGetOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSValue::get):

runtime/JSStaticScopeObject.cpp:
runtime/JSStaticScopeObject.h:
runtime/JSString.cpp:

(JSC::JSString::getOwnPropertySlot):

runtime/JSString.h:
runtime/MathObject.cpp:
runtime/MathObject.h:

(JSC::MathObject::create):

runtime/NumberConstructor.cpp:
runtime/NumberConstructor.h:
runtime/NumberPrototype.cpp:
runtime/NumberPrototype.h:
runtime/ObjectConstructor.cpp:
runtime/ObjectConstructor.h:
runtime/ObjectPrototype.cpp:
runtime/ObjectPrototype.h:
runtime/RegExpConstructor.cpp:
runtime/RegExpConstructor.h:
runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::createStructure):

runtime/RegExpObject.cpp:
runtime/RegExpObject.h:
runtime/RegExpPrototype.cpp:
runtime/RegExpPrototype.h:
runtime/StringConstructor.cpp:
runtime/StringConstructor.h:
runtime/StringObject.cpp:
runtime/StringObject.h:
runtime/StringPrototype.cpp:
runtime/StringPrototype.h:

Source/JavaScriptGlue:

Removed all declarations and definitions of getOwnPropertySlotVirtual.
Also replaced all call sites to getOwnPropertyVirtualVirtual with a
corresponding lookup in the MethodTable.

UserObjectImp.cpp:
UserObjectImp.h:

Source/WebCore:

No new tests.

Removed all declarations and definitions of getOwnPropertySlotVirtual.
Also replaced all call sites to getOwnPropertyVirtualVirtual with a
corresponding lookup in the MethodTable.

WebCore.exp.in:
bindings/js/JSDOMWindowCustom.cpp:

(WebCore::DialogHandler::returnValue):

bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::getOwnPropertySlot):

bindings/js/JSDOMWindowShell.h:
bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::getSparseIndex):
(WebCore::CloneSerializer::getProperty):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

bridge/objc/objc_runtime.h:
bridge/objc/objc_runtime.mm:
bridge/qt/qt_runtime.cpp:
bridge/qt/qt_runtime.h:
bridge/runtime_array.cpp:
bridge/runtime_array.h:
bridge/runtime_method.cpp:
bridge/runtime_method.h:
bridge/runtime_object.cpp:
bridge/runtime_object.h:

Source/WebKit2:

Removed all declarations and definitions of getOwnPropertySlotVirtual.
Also replaced all call sites to getOwnPropertyVirtualVirtual with a
corresponding lookup in the MethodTable.

WebProcess/Plugins/Netscape/JSNPObject.cpp:
WebProcess/Plugins/Netscape/JSNPObject.h:

10:54 AM Changeset in webkit [98500] by alex

4 edits in trunk

2011-10-26 Alejandro G. Castro <alex@igalia.com>

[GTK] Update NEWS and configure.ac for 1.7.1 release
https://bugs.webkit.org/show_bug.cgi?id=70932

Reviewed by Martin Robinson.

configure.ac: Bumped version number.

2011-10-26 Carlos Garcia Campos <cgarcia@igalia.com>

[GTK] Update NEWS and configure.ac for 1.7.1 release
https://bugs.webkit.org/show_bug.cgi?id=70932

Reviewed by Martin Robinson.

NEWS: Added release notes.

10:53 AM Changeset in webkit [98499] by ojan@chromium.org

3 edits in trunk/LayoutTests

Fix typo. The expected results don't change.

fast/writing-mode/borders.html:
fast/writing-mode/margins.html:

10:45 AM Changeset in webkit [98498] by alex

10 edits in trunk

2011-10-26 Alejandro G. Castro <alex@igalia.com>

[GTK] [WK2] Add WebKit2 distcheck support
https://bugs.webkit.org/show_bug.cgi?id=70933

Reviewed by Martin Robinson.

GNUmakefile.am: Added WebKit2 compilation to the distcheck.
configure.ac: Removed WebKit2 doc generation for the moment.

2011-10-26 Alejandro G. Castro <alex@igalia.com>

[GTK] [WK2] Add WebKit2 distcheck support
https://bugs.webkit.org/show_bug.cgi?id=70933

Reviewed by Martin Robinson.

GNUmakefile.list.am: Add MemoryStatistics.h to the sources list.

2011-10-26 Alejandro G. Castro <alex@igalia.com>

[GTK] [WK2] Add WebKit2 distcheck support
https://bugs.webkit.org/show_bug.cgi?id=70933

Reviewed by Martin Robinson.

GNUmakefile.am: Add a bunch of missing files from API and sources, also include more files in the EXTRA_DIST.
UIProcess/API/gtk/docs/GNUmakefile.am: Add the version.xml to the cleaning section.

2011-10-26 Alejandro G. Castro <alex@igalia.com>

[GTK] [WK2] Add WebKit2 distcheck support
https://bugs.webkit.org/show_bug.cgi?id=70933

Reviewed by Martin Robinson.

WebKitTestRunner/GNUmakefile.am: Add missing files to the sources and EXTRA_DIST.

10:40 AM Changeset in webkit [98497] by alex

5 edits in trunk/Source/WebKit2

2011-10-26 Carlos Garcia Campos <cgarcia@igalia.com>

[GTK] Fix gtk-doc warnings and style issues in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=70930

Reviewed by Martin Robinson.

UIProcess/API/gtk/WebKitBackForwardListItem.cpp:
UIProcess/API/gtk/WebKitSettings.cpp: (webkit_settings_class_init):
UIProcess/API/gtk/WebKitWebView.h:
UIProcess/API/gtk/docs/webkit2gtk-sections.txt:

10:35 AM Changeset in webkit [98496] by alex

4 edits in trunk/Source

2011-10-26 Alejandro G. Castro <alex@igalia.com>

[GTK] Fix distcheck compilation
https://bugs.webkit.org/show_bug.cgi?id=70921

Add EventTargetFactory.in to the dist files, required after
r98388.

Reviewed by Martin Robinson.

GNUmakefile.am:

2011-10-26 Alejandro G. Castro <alex@igalia.com>

[GTK] Fix distcheck compilation
https://bugs.webkit.org/show_bug.cgi?id=70921

Add new files required by doc compilation to the clean process.

Reviewed by Martin Robinson.

docs/GNUmakefile.am:

10:12 AM Changeset in webkit [98495] by msaboff@apple.com

6 edits in trunk/Source

Increase StringImpl Flag Bits for 8 bit Strings
https://bugs.webkit.org/show_bug.cgi?id=70937

Increased the number of bits used for flags in StringImpl
from 6 to 8 bits. This frees up 2 flag bits that will be
used for 8-bit string support. Updated hash methods accordingly.
Changed hash value masking from the low bits to the high
bits.

Reviewed by Darin Adler.

Source/JavaScriptCore:

create_hash_table:
wtf/StringHasher.h:

(WTF::StringHasher::hash):

wtf/text/StringImpl.h:

Source/WebCore:

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHashValue):

10:06 AM Changeset in webkit [98494] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Use the right contents scale factor for non-Mac plug-ins
https://bugs.webkit.org/show_bug.cgi?id=70939

Reviewed by Adam Roben.

WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::update):

10:05 AM Changeset in webkit [98493] by Dimitri Glazkov

7 edits
2 deletes in branches/chromium/912

Merge 98492 - REGRESSION (r94887): Scrolling the HTML spec is more jerky now than it was (regression)
https://bugs.webkit.org/show_bug.cgi?id=70857

Source/WebCore:

Revert r94887, because it regressed performance.

Rubber-stamped by Antti Koivisto.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::parentStylePreventsSharing):

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector):

dom/Element.cpp:

(WebCore::Element::recalcStyle):
(WebCore::checkForSiblingStyleChanges):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::childrenAffectedByDirectAdjacentRules):
(WebCore::InheritedFlags::setChildrenAffectedByDirectAdjacentRules):

LayoutTests:

Rubber-stamped by Antti Koivisto.

fast/css/adjacent-sibling-selector-expected.txt: Removed.
fast/css/adjacent-sibling-selector.html: Removed.

TBR=Dimitri Glazkov
Review URL: http://codereview.chromium.org/8390051

9:58 AM Changeset in webkit [98492] by Dimitri Glazkov

7 edits
2 deletes in trunk

REGRESSION (r94887): Scrolling the HTML spec is more jerky now than it was (regression)
https://bugs.webkit.org/show_bug.cgi?id=70857

Source/WebCore:

Revert r94887, because it regressed performance.

Rubber-stamped by Antti Koivisto.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::parentStylePreventsSharing):

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector):

dom/Element.cpp:

(WebCore::Element::recalcStyle):
(WebCore::checkForSiblingStyleChanges):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::childrenAffectedByDirectAdjacentRules):
(WebCore::InheritedFlags::setChildrenAffectedByDirectAdjacentRules):

LayoutTests:

Rubber-stamped by Antti Koivisto.

fast/css/adjacent-sibling-selector-expected.txt: Removed.
fast/css/adjacent-sibling-selector.html: Removed.

9:30 AM Changeset in webkit [98491] by mitz@apple.com

3 edits in trunk/Source/JavaScriptCore

Build fix.

Reverted r98488, which caused the scripts’ status messages to be included in the generated
files.

create_hash_table:
create_jit_stubs:

9:27 AM Changeset in webkit [98490] by kbalazs@webkit.org

3 edits in trunk/LayoutTests

inspector/cookie-parser.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=62662

Unreviewed Qt-Debug gardening.

Add CRASH+PASS expectation instead of the skipping madness
because the first inspector test is always a flaky crash,
no matter which one is that.

platform/qt/Skipped:
platform/qt/test_expectations.txt:

9:20 AM Changeset in webkit [98489] by apavlov@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: Need workaround for the red crossed circle in the status bar not bringing up the console when clicked
https://bugs.webkit.org/show_bug.cgi?id=70928

Reviewed by Pavel Feldman.

inspector/front-end/inspector.css:

(#error-count-img):
(#error-count + #warning-count-img):
(#warning-count-img):

inspector/front-end/inspector.js:

(WebInspector._updateErrorAndWarningCounts):

9:05 AM Changeset in webkit [98488] by vestbo@webkit.org

3 edits in trunk/Source/JavaScriptCore

Don't print regular output to STDERR when generating hashtables and JIT stubs

Reviewed by Simon Hausmann.

9:02 AM Changeset in webkit [98487] by kbalazs@webkit.org

2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening.

[Qt][WK2] fast/transforms/scrollIntoView-transformed.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=70935

[Qt][WK2] Metric mismatches (fast/text/justify-padding-distribution.html and svg/as-object/svg-embedded-in-html-in-iframe.html)
https://bugs.webkit.org/show_bug.cgi?id=70915
The test became flaky after added platform result.

Skip flaky tests.

platform/qt-wk2/Skipped:

8:48 AM Changeset in webkit [98486] by reed@google.com

5 edits in trunk

[skia] replace offscreen technique with native support for antialiased clipping
https://bugs.webkit.org/show_bug.cgi?id=70748

Reviewed by Stephen White.

~100 layout tests need to be rebaselined, as the native aa-clipping differs sometimes in the low
bits of the result. Other than that, the results should be the same, except that now the drawing
can go directly to the canvas, rather than being direct offscreen and then have that result
"clipped" during the restore. This has the effect of allowing LCD text to be drawing inside a
antialiased clip area.

Source/WebCore:

platform/graphics/skia/PlatformContextSkia.cpp:

LayoutTests:

platform/chromium/test_expectations.txt:

8:43 AM Changeset in webkit [98485] by Carlos Garcia Campos

4 edits in trunk/Source/WebKit2

[GTK] Add missing symbols to WebKit2 gtk-doc files
https://bugs.webkit.org/show_bug.cgi?id=70927

Reviewed by Martin Robinson.

UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add sections for

WebKitBackForwardList, WebKitBackForwardListItem and WebKitSettings.

UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add missing symbols.
UIProcess/API/gtk/docs/webkit2gtk.types: Add missing types.

8:40 AM Changeset in webkit [98484] by Carlos Garcia Campos

3 edits in trunk/Source/WebKit2

[GTK] Inconsistent name of WebKitSettings macros
https://bugs.webkit.org/show_bug.cgi?id=70924

Reviewed by Martin Robinson.

Rename WEBKIT_TYPE_WEB_SETTINGS as WEBKIT_TYPE_SETTINGS and
WEBKIT_IS_WEB_SETTINGS as WEBKIT_IS_SETTINGS.

UIProcess/API/gtk/WebKitSettings.cpp:

(webkit_settings_init):
(webkit_settings_new):
(webkit_settings_get_enable_javascript):
(webkit_settings_set_enable_javascript):
(webkit_settings_get_auto_load_images):
(webkit_settings_set_auto_load_images):
(webkit_settings_get_load_icons_ignoring_image_load_setting):
(webkit_settings_set_load_icons_ignoring_image_load_setting):
(webkit_settings_get_enable_offline_web_application_cache):
(webkit_settings_set_enable_offline_web_application_cache):
(webkit_settings_get_enable_html5_local_storage):
(webkit_settings_set_enable_html5_local_storage):
(webkit_settings_get_enable_html5_database):
(webkit_settings_set_enable_html5_database):
(webkit_settings_get_enable_xss_auditor):
(webkit_settings_set_enable_xss_auditor):
(webkit_settings_get_enable_frame_flattening):
(webkit_settings_set_enable_frame_flattening):
(webkit_settings_get_enable_plugins):
(webkit_settings_set_enable_plugins):
(webkit_settings_get_enable_java):
(webkit_settings_set_enable_java):
(webkit_settings_get_javascript_can_open_windows_automatically):
(webkit_settings_set_javascript_can_open_windows_automatically):
(webkit_settings_get_enable_hyperlink_auditing):
(webkit_settings_set_enable_hyperlink_auditing):

UIProcess/API/gtk/WebKitSettings.h:

8:27 AM Changeset in webkit [98483] by Nikolas Zimmermann

49 edits
94 adds
2 deletes in trunk

2011-10-26 Nikolas Zimmermann <nzimmermann@rim.com>

CSS 2.1 failure: background-intrinsic-*
https://bugs.webkit.org/show_bug.cgi?id=47156

Reviewed by Antti Koivisto.

Add all *intrinsic* tests from the CSS 2.1 Testsuite - we pass all of them now.
All tests regarding SVG are now imported in LayoutTests, none are failing anymore.

Add several new testcases covering the SVG Image size negotiation logic, as defined in CSS 2.1.

css2.1/20110323/background-intrinsic-001.htm: Added.
css2.1/20110323/background-intrinsic-002.htm: Added.
css2.1/20110323/background-intrinsic-003.htm: Added.
css2.1/20110323/background-intrinsic-004.htm: Added.
css2.1/20110323/background-intrinsic-005.htm: Added.
css2.1/20110323/background-intrinsic-006.htm: Added.
css2.1/20110323/background-intrinsic-007.htm: Added.
css2.1/20110323/background-intrinsic-008.htm: Added.
css2.1/20110323/background-intrinsic-009.htm: Added.
css2.1/20110323/resources/green-intrinsic-height-ratio.svg: Added.
css2.1/20110323/resources/green-intrinsic-height.svg: Added.
css2.1/20110323/resources/green-intrinsic-none.svg: Added.
css2.1/20110323/resources/green-intrinsic-ratio-landscape.svg: Added.
css2.1/20110323/resources/green-intrinsic-ratio-portrait.svg: Added.
css2.1/20110323/resources/green-intrinsic-width-height.svg: Added.
css2.1/20110323/resources/green-intrinsic-width-pc-height-pc.svg: Added.
css2.1/20110323/resources/green-intrinsic-width-ratio.svg: Added.
css2.1/20110323/resources/green-intrinsic-width.svg: Added.
css2.1/20110323/resources/red-intrinsic-height-ratio.svg: Added.
css2.1/20110323/resources/red-intrinsic-height.svg: Added.
css2.1/20110323/resources/red-intrinsic-none.svg: Added.
css2.1/20110323/resources/red-intrinsic-ratio-landscape.svg: Added.
css2.1/20110323/resources/red-intrinsic-ratio-portrait.svg: Added.
css2.1/20110323/resources/red-intrinsic-width-height.svg: Added.
css2.1/20110323/resources/red-intrinsic-width-pc-height-pc.svg: Added.
css2.1/20110323/resources/red-intrinsic-width-ratio.svg: Added.
css2.1/20110323/resources/red-intrinsic-width.svg: Added.
fast/backgrounds/size/contain-and-cover-zoomed.html: Added.
fast/images/percent-height-image-expected.txt: Update results, testcase is fixed now.
fast/images/percent-height-image.html: Make test async, to make it work cross-browser. With this patch we now pass this testcase.
platform/mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed.
platform/mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
platform/mac/css1/text_properties/vertical_align-expected.txt: Update for rounding differences.
platform/mac/css2.1/20110323/background-intrinsic-001-expected.png: Added.
platform/mac/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
platform/mac/css2.1/20110323/background-intrinsic-002-expected.png: Added.
platform/mac/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
platform/mac/css2.1/20110323/background-intrinsic-003-expected.png: Added.
platform/mac/css2.1/20110323/background-intrinsic-003-expected.txt: Added.
platform/mac/css2.1/20110323/background-intrinsic-004-expected.png: Added.
platform/mac/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
platform/mac/css2.1/20110323/background-intrinsic-005-expected.png: Added.
platform/mac/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
platform/mac/css2.1/20110323/background-intrinsic-006-expected.png: Added.
platform/mac/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
platform/mac/css2.1/20110323/background-intrinsic-007-expected.png: Added.
platform/mac/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
platform/mac/css2.1/20110323/background-intrinsic-008-expected.png: Added.
platform/mac/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
platform/mac/css2.1/20110323/background-intrinsic-009-expected.png: Added.
platform/mac/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
platform/mac/fast/backgrounds/size/contain-and-cover-expected.png: Updated for rounding differences.
platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
platform/mac/fast/block/float/015-expected.png: Slight changes, due 49x50 -> 50x50 size change.
platform/mac/fast/block/float/015-expected.txt: Ditto.
platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Slight changes due to rounding.
platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Ditto.
platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Ditto.
platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt: Ditto.
platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
platform/mac/svg/as-background-image/background-image-tiled-expected.png: Added.
platform/mac/svg/as-background-image/background-image-tiled-expected.txt: Added.
platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Added.
platform/mac/svg/as-background-image/svg-as-background-4-expected.png: Adapt to preserveAspectRatio changes in hearts.svg.
platform/mac/svg/as-border-image/svg-as-border-image-expected.png: This needed a rebaseline, it was forgotten before.
platform/mac/svg/as-image/animated-svg-as-image-expected.png: Progression, now both images share the same size & ratio, as desired.
platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
platform/mac/svg/as-image/same-image-two-instances-expected.png: Added.
platform/mac/svg/as-image/same-image-two-instances-expected.txt: Added.
platform/mac/svg/as-image/svg-as-relative-image-expected.png: Adapt to green-relative-size-rect.svg - a circle got added to make it easier to compare.
platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Added.
platform/mac/svg/as-image/svg-image-change-content-size-expected.png: Added.
platform/mac/svg/as-image/svg-image-change-content-size-expected.txt: Added.
platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Updated, scrollbars are gone - now matching Opera/FF.
platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Ditto.
platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
platform/mac/svg/zoom/page/zoom-background-images-expected.png: Added.
platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Added.
platform/mac/svg/zoom/page/zoom-foreignObject-expected.png: Updated, scrollbars are gone - now matching Opera/FF.
platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt: Ditto.
platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
svg/as-background-image/background-image-preserveaspectRatio-support.html: Added.
svg/as-background-image/background-image-tiled.html: Added.
svg/as-background-image/resources/construction-tape.svg: Added.
svg/as-background-image/resources/hearts.svg: Fix testcase, by adding pAR="none", which is now respected. Now the image looks as desired across Opera/FF and us.
svg/as-background-image/same-image-two-instances-background-image.html: Added.
svg/as-image/img-preserveAspectRatio-support-1.html: Added.
svg/as-image/resources/circle-default-meet.svg: Added.
svg/as-image/resources/circle-default-none.svg: Added.
svg/as-image/resources/circle-default-slice.svg: Added.
svg/as-image/resources/circle-nosize.svg: Added.
svg/as-image/resources/circle-viewbox-default.svg: Added.
svg/as-image/resources/circle-viewbox-meet.svg: Added.
svg/as-image/resources/circle-viewbox-none.svg: Added.
svg/as-image/resources/circle-viewbox-slice.svg: Added.
svg/as-image/resources/green-relative-size-rect.svg: Use relative units everywhere as intended. Add circle to make it easy to spot ratio changes.
svg/as-image/same-image-two-instances.html: Added.
svg/as-image/svg-as-relative-image-with-explicit-size.html: Added.
svg/as-image/svg-image-change-content-size.xhtml: Added.
svg/zoom/page/resources/relative-sized-background-with-viewBox.svg: Added.
svg/zoom/page/zoom-background-image-tiled.html: Added.
svg/zoom/page/zoom-background-images.html: Added.
svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html: Added.
svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html: Added.
svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Added.

2011-10-26 Nikolas Zimmermann <nzimmermann@rim.com>

CSS 2.1 failure: background-intrinsic-*
https://bugs.webkit.org/show_bug.cgi?id=47156

SVGs do not work as tiled background images
https://bugs.webkit.org/show_bug.cgi?id=16281

Apply preserveAspectRatio and synthesize viewboxes in <img>
https://bugs.webkit.org/show_bug.cgi?id=34521

SVG background doesn't resize properly when dimensions are changed
https://bugs.webkit.org/show_bug.cgi?id=42944

Images with percent height inside a floated div should use intrinsic height.
https://bugs.webkit.org/show_bug.cgi?id=45439

SVG image in HTML changes size as the window is resized
https://bugs.webkit.org/show_bug.cgi?id=52045

Reviewed by Antti Koivisto.

Implement intrinsic sizing support for SVGImage (svg embedded through <html:img>/<svg:image>/background-image/border-image/...).
This is demanded by CSS 2.1, and covered by new layout tests in LayoutTests/css2.1 and several new custom testcases.

Tests: css2.1/20110323/background-intrinsic-001.htm

css2.1/20110323/background-intrinsic-002.htm
css2.1/20110323/background-intrinsic-003.htm
css2.1/20110323/background-intrinsic-004.htm
css2.1/20110323/background-intrinsic-005.htm
css2.1/20110323/background-intrinsic-006.htm
css2.1/20110323/background-intrinsic-007.htm
css2.1/20110323/background-intrinsic-008.htm
css2.1/20110323/background-intrinsic-009.htm
svg/as-background-image/background-image-preserveaspectRatio-support.html (adapted from testcase from bug 34521)
svg/as-background-image/background-image-tiled.html (reduction from bug 16281)
svg/as-background-image/same-image-two-instances-background-image.html
svg/as-image/img-preserveAspectRatio-support-1.html (reduction from bug 34521)
svg/as-image/same-image-two-instances.html
svg/as-image/svg-as-relative-image-with-explicit-size.html
svg/as-image/svg-image-change-content-size.xhtml (reduction from bug 42944)
svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html

loader/cache/CachedImage.cpp: Enable SVGImage <-> IntSize cache. (WebCore::CachedImage::lookupImageForSize): Use recently introduced ImageBySizeCache, to lookup an image for a certain size. (WebCore::CachedImage::lookupImageForRenderer): Lookup image by renderer, which first looks up a size for a renderer, then uses lookupImageForSize(). (WebCore::createSVGImage): Refactored from createImage(), contains the SVGImage creation part only. (WebCore::CachedImage::lookupOrCreateImageForRenderer): Use recently introduced ImageBySizeCache, to dynamically create copies of m_image if needed. (WebCore::CachedImage::setContainerSizeForRenderer): For SVGImages, pass on container size handling to ImageBySizeCache. (WebCore::CachedImage::imageSizeForRenderer): Figure out the image size, respecting per-renderer overrides, for a certain renderer. (WebCore::CachedImage::computeIntrinsicDimensions): Remove unnecessary RenderObject parameter. (WebCore::CachedImage::addClientForRenderer): Special variant of addClient(), overriding the existing in CachedResource. (WebCore::CachedImage::removeClientForRenderer): Special variant of removeClient(), that also clears the image in the ImageBySizeCache. (WebCore::CachedImage::createImage): Refactor SVGImage creation into createSVGImage() free function, to be useable from lookupOrCreateImageForRenderer().
loader/cache/CachedImage.h: Expose removeClientForRenderer().
page/ChromeClient.h: (WebCore::ChromeClient::isSVGImageChromeClient): Used to identify whether a RenderSVGRoot is embedded through a SVGImage. Returns false, by default.
rendering/ImageBySizeCache.cpp: (WebCore::ImageBySizeCache::addClient): Assert the passed renderer is valid. (WebCore::ImageBySizeCache::removeClient): Ditto. Allow removeClient() to be called w/o prio addClient() usage. (WebCore::ImageBySizeCache::setClient): New helper function, that combines the usage of addClient/removeClient, for the use in CachedImage. (WebCore::ImageBySizeCache::imageForSize): Respect empty sizes, just return 0, instead of asserting. (WebCore::ImageBySizeCache::imageForRenderer): Added a helper that retrieves an image for a renderer, by lookup up its size and using imageForSize().
rendering/ImageBySizeCache.h: Expose setClient() & imageForRenderer().
rendering/RenderBoxModelObject.cpp: Implement CSS 2.1 intrinsic size negotiation for images. (WebCore::resolveWidthForRatio): New inline helper function used bz calculateImageIntrinsicDimensions. (WebCore::resolveHeightForRatio): Ditto. (WebCore::resolveAgainstIntrinsicWidthOrHeightAndRatio): Ditto. (WebCore::resolveAgainstIntrinsicRatio): Ditto. (WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): New helper function, containing the main algorithm, which is a pure transcription of the spec. (WebCore::RenderBoxModelObject::calculateFillTileSize): Use new calculateImageIntrinsicDimensions() helper to figure out the intrinsic size. (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Propagate calculateFillTileSize() result to the image resource, via setContainerSizeForRenderer(). (WebCore::RenderBoxModelObject::paintNinePieceImage): Use new calculateImageIntrinsicDimensions() helper to figure out the intrinsic size.
rendering/RenderBoxModelObject.h: Clarify some variable names, added calculateImageIntrinsicDimensions().
rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): Use IntSize(), instead of IntSize(0, 0). (WebCore::RenderImage::updateIntrinsicSizeIfNeeded): Refactored from imageDimensionsChanged(). (WebCore::RenderImage::imageDimensionsChanged): Use updateIntrinsicSizeIfNeeded(). (WebCore::RenderImage::computeReplacedLogicalWidth): Use RenderReplaced::computeReplacedLogicalWidth() exclusively. For this to work, the intrinsic size must be correct. (WebCore::RenderImage::computeIntrinsicRatioInformation): Default implementation for non-SVGImages. (WebCore::RenderImage::needsPreferredWidthsRecalculation): Return true, just like RenderPart, if embeddedContentBox is not null. (WebCore::RenderImage::embeddedContentBox): Returns the RenderSVGRoot* renderer of the embedded SVG, if possible.
rendering/RenderImage.h: Remove isLogicalWidth/HeightSpecified() / computeReplacedLogicalHeight() / calcAspectRatioLogicalWidth/Height().
rendering/RenderImageResource.cpp: (WebCore::RenderImageResource::setContainerSizeForRenderer): Pass around new "float containerZoomFactor" parameter.
rendering/RenderImageResourceStyleImage.cpp: (WebCore::RenderImageResourceStyleImage::image): embeddedContentBox() is now calling image() earlier than before. We now have to handle the case that the image is pending. (WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer): Pass zoom factor.
rendering/RenderImageResourceStyleImage.h:
rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::computePreferredLogicalWidths): Pass effective zoom to setContainerSizeForRenderer().
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::computeIntrinsicLogicalWidth): Generalized this code, as RenderImage is using it as well now. Marginal changes needed. (WebCore::RenderReplaced::computeIntrinsicLogicalHeight): Ditto. (WebCore::RenderReplaced::computeReplacedLogicalWidth): Ditto.
rendering/style/StyleCachedImage.cpp: (WebCore::StyleCachedImage::computeIntrinsicDimensions): Stop passing m_renderer to CachedImage, it's no longer needed. (WebCore::StyleCachedImage::setContainerSizeForRenderer): Add "float containerZoomFactor" parameter. (WebCore::StyleCachedImage::addClient): Forward to new addClientForRenderer(). (WebCore::StyleCachedImage::removeClient): Call new removeClientForRenderer() instead of removeClient(), so the ImageBySizeCache is also updated.
rendering/style/StyleCachedImage.h: Add "float containerZoomFactor" parameter to setContainerSizeForRenderer.
rendering/style/StyleGeneratedImage.h: (WebCore::StyleGeneratedImage::setContainerSizeForRenderer): Ditto.
rendering/style/StyleImage.h: Ditto.
rendering/style/StylePendingImage.h: (WebCore::StylePendingImage::setContainerSizeForRenderer): Ditto.
rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout): Always supply a container size when embedding SVGs in <svg:image>.
rendering/svg/RenderSVGRoot.cpp: Move "override container size" from SVGSVGElement into RenderSVGRoot, where it belongs. (WebCore::RenderSVGRoot::isEmbeddedThroughImageElement): Add helper method to determine whether we're loaded through SVGImage. (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): If we have a valid container size, it has precendence (only supplied via external SVGImages). (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto. (WebCore::RenderSVGRoot::layout): Remove calcViewport() usage, no need to track/override the viewport size anymore, all done in coputeReplacedLogical* now. (WebCore::RenderSVGRoot::paint): Use borderBoxRect() which now always matches the previously computed m_viewportSize. (WebCore::RenderSVGRoot::computeRectForRepaint): Ditto.
rendering/svg/RenderSVGRoot.h: Move "override container size" from SVGSVGElement into RenderSVGRoot, where it belongs. (WebCore::RenderSVGRoot::containerSize): (WebCore::RenderSVGRoot::setContainerSize):
svg/SVGLength.cpp: (WebCore::SVGLength::determineViewport): Resolve lengths against override container size in documents embedded through SVGImage.
svg/SVGSVGElement.cpp: Remove "override container size" handling from SVGSVGElement. (WebCore::SVGSVGElement::SVGSVGElement): Ditto. (WebCore::SVGSVGElement::currentViewBoxRect): Always synthesize a viewBox, if we're embedded through SVGImage, as demanded by SVG 1.1 2nd Edition.
svg/SVGSVGElement.h:
svg/graphics/SVGImage.cpp: (WebCore::SVGImageChromeClient::setObserver): Helper function. (WebCore::SVGImageChromeClient::isSVGImageChromeClient): Return true, used to identify whether RenderSVGRoot is embedded through SVGImage. (WebCore::SVGImage::setContainerZoom): Forwarded to Page::setPageZoomFactor. (WebCore::SVGImage::setContainerSize): Assert that container size is not empty. We should never receive an empty container size. (WebCore::SVGImage::usesContainerSize): Adapt to override container size changes, it now lives in RenderSVGRoot instead of SVGSVGElement. (WebCore::SVGImage::size): New algorithm to figure out the size of an embedded SVG, as demanded by the CSS/SVG specs. (WebCore::SVGImage::draw): Stop calling layout() while painting! (WebCore::SVGImage::embeddedContentBox): Add helper which returns the RenderSVGRoot of the document. (WebCore::SVGImage::computeIntrinsicDimensions): Implement intrinsic ratio calculation. (WebCore::SVGImage::dataChanged): Force calling FrameView::setCanHaveScrollbars(false), as SVG images now always synthesize a viewBox, and thus never receive scrollbars.
svg/graphics/SVGImage.h:

7:59 AM Changeset in webkit [98482] by yurys@chromium.org

2 edits in trunk/LayoutTests

2011-10-26 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark compositing/video/video-poster.html as timing out on Mac10.6 CPU-CG.

platform/chromium/test_expectations.txt:

7:56 AM Changeset in webkit [98481] by kenneth@webkit.org

8 edits in trunk/Source/WebCore

Properly suspend/resume Geolocation/DeviceMotion/DeviceOrientation objects
https://bugs.webkit.org/show_bug.cgi?id=70328

Reviewed by Simon Hausmann.

Also remove checks for m_client in DeviceMotionController as it can never be null.

No new tests, as the suspend/resume functionality is not fully working yet.

dom/DeviceMotionController.cpp:

(WebCore::DeviceMotionController::timerFired):
(WebCore::DeviceMotionController::addListener):
(WebCore::DeviceMotionController::removeListener):
(WebCore::DeviceMotionController::removeAllListeners):
(WebCore::DeviceMotionController::suspend):
(WebCore::DeviceMotionController::resume):

dom/DeviceMotionController.h:
dom/DeviceOrientationController.cpp:

(WebCore::DeviceOrientationController::suspend):
(WebCore::DeviceOrientationController::resume):

dom/DeviceOrientationController.h:
dom/Document.cpp:

(WebCore::Document::suspendActiveDOMObjects):
(WebCore::Document::resumeActiveDOMObjects):
(WebCore::Document::stopActiveDOMObjects):

dom/Document.h:
dom/ScriptExecutionContext.h:
page/GeolocationController.cpp:

(WebCore::GeolocationController::GeolocationController):
(WebCore::GeolocationController::removeObserver):
(WebCore::GeolocationController::suspend):
(WebCore::GeolocationController::resume):

page/GeolocationController.h:

7:54 AM Changeset in webkit [98480] by kbalazs@webkit.org

2 edits
3 adds in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening.

[Qt][WK2] fast/css/font-face-descending-unicode-range.html fails
https://bugs.webkit.org/show_bug.cgi?id=70922
Skipped

platform/qt-wk2/Skipped:
platform/qt-wk2/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.

7:50 AM Changeset in webkit [98479] by Lucas Forschler

5 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r93720.

7:44 AM Changeset in webkit [98478] by Lucas Forschler

2 edits in branches/safari-534.52-branch/Source/WebCore

Merge 98178.

7:44 AM Changeset in webkit [98477] by yurys@chromium.org

2 edits in trunk/LayoutTests

2011-10-26 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Revert change to test_expectations.txt due to test failures.

platform/chromium/test_expectations.txt:

7:32 AM Changeset in webkit [98476] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

2011-10-26 Pavel Feldman <pfeldman@google.com>

Not reviewed: follow up to 98236 - moved inspector settings initialization earlier to unbreak settings panel.

inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel):

6:56 AM Changeset in webkit [98475] by yurys@chromium.org

2 edits in trunk/LayoutTests

2011-10-26 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark compositing/video/video-poster.html as timing out on Mac10.6 GPU.

platform/chromium/test_expectations.txt:

6:50 AM Changeset in webkit [98474] by abecsi@webkit.org

5 edits in trunk/Source/WebKit2

[Qt][WK2] Rename clean-up of QtPinchGestureRecognizer and QtViewportInteractionEngine
https://bugs.webkit.org/show_bug.cgi?id=70903

Reviewed by Kenneth Rohde Christiansen.

Rename computeTouchCenter to computePinchCenter,
and use the plural form of coordinate where appropriate.

UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::_q_viewportUpdated):

UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::computePinchCenter):
(WebKit::QtPinchGestureRecognizer::recognize):

UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::contentRectInViewportCoordinates):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::scaleContent):

UIProcess/qt/QtViewportInteractionEngine.h:

6:34 AM Changeset in webkit [98473] by kbalazs@webkit.org

2 edits in trunk/LayoutTests

Unreviewed Qt-WK2 gardening.

[Qt][WK2] Crash with http/tests/websocket/tests/hixie76/long-invalid-header.html
https://bugs.webkit.org/show_bug.cgi?id=70917

[Qt][WK2] fast/events/drag-selects-image.html fails
https://bugs.webkit.org/show_bug.cgi?id=70907

[Qt][WK2] Metric mismatches (fast/text/justify-padding-distribution.html and svg/as-object/svg-embedded-in-html-in-iframe.html)
https://bugs.webkit.org/show_bug.cgi?id=70915

platform/qt-wk2/Skipped:

6:32 AM Changeset in webkit [98472] by Simon Hausmann

40 edits in trunk/Source

Name viewport change event consistently.
https://bugs.webkit.org/show_bug.cgi?id=70901

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-10-26
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Use ViewportPropertiesDidChange term consistently throughout WebKit.

No tests needed as the change is only method renaming.

page/Chrome.cpp:

(WebCore::Chrome::dispatchViewportPropertiesDidChange):

page/Chrome.h:
page/ChromeClient.h:

(WebCore::ChromeClient::dispatchViewportPropertiesDidChange):

page/Page.cpp:

(WebCore::Page::updateViewportArguments):

Source/WebKit/efl:

Use ViewportPropertiesDidChange term consistently throughout WebKit.

WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::dispatchViewportPropertiesDidChange):

WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

Use ViewportPropertiesDidChange term consistently throughout WebKit.

WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::dispatchViewportPropertiesDidChange):

WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/qt:

Use ViewportPropertiesDidChange term consistently throughout WebKit.

WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::dispatchViewportPropertiesDidChange):

WebCoreSupport/ChromeClientQt.h:

Source/WebKit2:

Use ViewportPropertiesDidChange term consistently throughout WebKit.

UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::didChangeViewportProperties):

UIProcess/API/efl/PageClientImpl.h:
UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::didChangeViewportProperties):

UIProcess/API/gtk/PageClientImpl.h:
UIProcess/API/mac/PageClientImpl.h:
UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didChangeViewportProperties):

UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::didChangeViewportProperties):

UIProcess/API/qt/qdesktopwebview_p.h:
UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::didChangeViewportProperties):

UIProcess/API/qt/qtouchwebview_p.h:
UIProcess/PageClient.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeViewportProperties):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/qt/QtDesktopWebPageProxy.cpp:

(QtDesktopWebPageProxy::didChangeViewportProperties):

UIProcess/qt/QtDesktopWebPageProxy.h:
UIProcess/qt/QtTouchViewInterface.cpp:

(WebKit::QtTouchViewInterface::didChangeViewportProperties):

UIProcess/qt/QtTouchViewInterface.h:
UIProcess/qt/QtViewInterface.h:
UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::didChangeViewportProperties):

UIProcess/qt/QtWebPageProxy.h:
UIProcess/win/WebView.cpp:

(WebKit::WebView::didChangeViewportProperties):

UIProcess/win/WebView.h:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):

WebProcess/WebCoreSupport/WebChromeClient.h:

6:24 AM Changeset in webkit [98471] by senorblanco@chromium.org

12 edits
2 adds in trunk/Source

[chromium] Canvas2D should rate-limit drawing to prevent swamping the GPU process.
https://bugs.webkit.org/show_bug.cgi?id=70367

Source/WebCore:

Reviewed by James Robinson.

Sadly, we don't have infrastructure to test this kind of GPU swamping
yet.

WebCore.gypi:

Add RateLimiter.* to the Chromium build.

platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::contentChanged):
When the layer is notified that the contents have changed, ping the
rate limiter.

platform/graphics/chromium/Canvas2DLayerChromium.h:
platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
Call (new) virtual contentChanged() on a layer when its contents have
been changed (e.g., by a drawing call).

platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::contentChanged):
New virtual contentChanged().

platform/graphics/chromium/RateLimiter.cpp: Added.

(WebCore::RateLimiter::create):
Rate limiter factory function.
(WebCore::RateLimiter::RateLimiter):
(WebCore::RateLimiter::start):
Public API to start rate limiting a context.
(WebCore::RateLimiter::stop):
Public API to stop rate limiting a context.
(WebCore::RateLimiter::rateLimitContext):
Internal timer callback when a context should be rate limited.

platform/graphics/chromium/RateLimiter.h: Added.
platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::WebGLLayerChromium):
Remove rate limiting timer and extension check (moved to RateLimiter).
(WebCore::WebGLLayerChromium::contentChanged):
The function formerly known as setTextureUpdated(), now renamed to
match the base class virtual contentChanged(). Call rate limiter in
CCLayerTreeHost (local implementation removed).
(WebCore::WebGLLayerChromium::setContext):
When the context is changed, stop the pending rate limiter on the old
context. Remove extension check (moved to RateLimiter).

platform/graphics/chromium/WebGLLayerChromium.h:

Remove rate limiting timer and extension check (moved to RateLimiter).

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::startRateLimiter):
Public API for starting per-context rate limiter.
(WebCore::CCLayerTreeHost::stopRateLimiter):
Public API for stopping per-context rate limiter.

platform/graphics/chromium/cc/CCLayerTreeHost.h:

Implementation of per-GraphicsContext3D RateLimiter.

Source/WebKit/chromium:

src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::markContextChanged):
Remove the call to setTextureChanged (it will be handled internally
by the compositor in setContextNeedsDisplay() instead). This decouples
GraphicsContext3D from WebGLLayerChromium a bit.

6:17 AM Changeset in webkit [98470] by Lucas Forschler

3 edits in branches/safari-534.52-branch/Source/WebCore

Merge 98171.

6:10 AM Changeset in webkit [98469] by pfeldman@chromium.org

3 edits in trunk/Source/WebCore

2011-10-26 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: fixing inspector extensions tests.

inspector/front-end/ConsoleMessage.js: (WebInspector.ConsoleMessageImpl):
inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onAddConsoleMessage):

6:03 AM Changeset in webkit [98468] by Lucas Forschler

2 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r98153.

6:01 AM Changeset in webkit [98467] by Lucas Forschler

7 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r98113.

5:58 AM Changeset in webkit [98466] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Skip failing tests temporarily because of missing Qt Mobility on the buildbot.

platform/qt-arm/Skipped:

5:39 AM Changeset in webkit [98465] by Carlos Garcia Campos

4 edits in trunk/Source

[GTK] Remove g_thread_init() calls from gtk-doc scanner too
https://bugs.webkit.org/show_bug.cgi?id=70908

Reviewed by Gustavo Noronha Silva.

Source/WebKit/gtk:

docs/GNUmakefile.am:

Source/WebKit2:

UIProcess/API/gtk/docs/GNUmakefile.am:

5:33 AM Changeset in webkit [98464] by yurys@chromium.org

2 edits in trunk/LayoutTests

2011-10-26 Yury Semikhatsky <yurys@chromium.org>

Unreviewed, gardening. Mark editing/selection/designmode-no-caret.html as failing in debug mode.

platform/chromium/test_expectations.txt:

5:11 AM Changeset in webkit [98463] by kbalazs@webkit.org

2 edits in trunk/LayoutTests

[Qt] inspector/extensions/extensions-console.html is failing
https://bugs.webkit.org/show_bug.cgi?id=70905

Unreviewed gardening. Skip failing test.

platform/qt/Skipped:

4:44 AM Changeset in webkit [98462] by kbalazs@webkit.org

2 edits in trunk/Source/WebCore

ParallelJobs path of FEConvolveMatrix is erroneous
https://bugs.webkit.org/show_bug.cgi?id=70409

Reviewed by Zoltan Herczeg.

Covered by existing tests.

platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::fastSetInteriorPixels):
Reject the silly idea that bytes per pixel ratio is 3 in preserveAlphaValues mode.
The bug was hidden so far because that computation has no effect when we are going
with the full inferior area in one round (in that case clipBottom and yEnd are equals
and the value of the expression is always 0). With ParallelJobs we process sub-areas
on each thread which has triggered the issue.

3:46 AM WebKitGTK/1.6.x edited by kov@webkit.org

(diff)

2:59 AM Changeset in webkit [98461] by Simon Hausmann

4 edits in trunk/Tools

[Qt][WK2] Fix failing assertion on startup of MiniBrowser -touch.

Reviewed by Tor Arne Vestbø.

We're using QScroller since r98460, which requires QWidget/QApplication. So
use QApplication and QtWidgets for the time being.

MiniBrowser/qt/MiniBrowser.pro:
MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::notify):

MiniBrowser/qt/MiniBrowserApplication.h:

2:49 AM Changeset in webkit [98460] by abecsi@webkit.org

7 edits in trunk/Source/WebKit2

[Qt][WK2] Add the animations on the ViewportInteractionEngine
https://bugs.webkit.org/show_bug.cgi?id=66664

Reviewed by Kenneth Rohde Christiansen.

Introduce a QScroller based panning and a QVariantAnimation based scale animation.
QScroller also handles flick gestures and animates overshoot.
If a pinch gesture ends, the scale animation will scale and reposition the content
such that it is within valid boundaries. The content is by default animated such
that the content position as seen in the center of the visible viewport stays
in the center, unless the content would be out of valid bounds.
The patch also simplifies the ViewportUpdateGuard by using reference counting
instead of a boolean for defering update requests.

UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::recognize):

UIProcess/qt/QtPanGestureRecognizer.h:
UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::recognize):

UIProcess/qt/QtTouchWebPageProxy.cpp:

(QtTouchWebPageProxy::doneWithTouchEvent):

UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::bindToScaleLimits):
(WebKit::ViewportUpdateGuard::ViewportUpdateGuard):
(WebKit::ViewportUpdateGuard::~ViewportUpdateGuard):
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::innerBoundedScale):
(WebKit::QtViewportInteractionEngine::outerBoundedScale):
(WebKit::QtViewportInteractionEngine::updateVisibleRect):
(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::stopAnimations):
(WebKit::QtViewportInteractionEngine::calculateBoundariesForScale):
(WebKit::QtViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):
(WebKit::QtViewportInteractionEngine::reset):
(WebKit::QtViewportInteractionEngine::setConstraints):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::panGestureCancelled):
(WebKit::QtViewportInteractionEngine::panGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
(WebKit::QtViewportInteractionEngine::contentViewportChanged):

UIProcess/qt/QtViewportInteractionEngine.h:

(WebKit::QtViewportInteractionEngine::scroller):
(WebKit::QtViewportInteractionEngine::ScaleAnimation::ScaleAnimation):
(WebKit::QtViewportInteractionEngine::ScaleAnimation::updateCurrentValue):

2:41 AM Changeset in webkit [98459] by rgabor@webkit.org

2 edits in trunk/LayoutTests

[Qt] Unreviewed skip. fast/canvas/canvas-composite-image.html failing on Qt

platform/qt/Skipped:

2:38 AM Changeset in webkit [98458] by yurys@chromium.org

8 edits
1 delete in trunk/Source

Unreviewed, rolling out r98393.
http://trac.webkit.org/changeset/98393
https://bugs.webkit.org/show_bug.cgi?id=70892

"Compilation is broken on Chromium Webkit Mac Builder (dbg) "
(Requested by yurys on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-26

Source/WebCore:

platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setMasksToBounds):
(WebCore::LayerChromium::setMaskLayer):

Source/WebKit/chromium:

WebKit.gypi:
src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::setDrawsContent):

src/WebExternalTextureLayerImpl.cpp:

(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):

src/WebLayerImpl.cpp:

(WebKit::WebLayerImpl::~WebLayerImpl):

tests/LayerChromiumTest.cpp:
tests/WebLayerTest.cpp: Removed.

2:33 AM Changeset in webkit [98457] by rniwa@webkit.org

3 edits in trunk/LayoutTests

Fix editing/selection/caret-mode-paragraph-keys-navigation.html for Mac
https://bugs.webkit.org/show_bug.cgi?id=70880

Reviewed by Eric Seidel.

Use option key (instead of control key) to move between word boundaries on Mac.

editing/selection/caret-mode-paragraph-keys-navigation.html:
platform/chromium/test_expectations.txt:

2:25 AM Changeset in webkit [98456] by pfeldman@chromium.org

10 edits in trunk

Web Inspector: order console message parameters for better optional parameters handling.
https://bugs.webkit.org/show_bug.cgi?id=70809

Reviewed by Yury Semikhatsky.

Source/WebCore:

inspector/Inspector.json:
inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl):
(WebInspector.ConsoleMessageImpl.prototype._formatMessage):

inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated):
(WebInspector.ConsoleMessage.create):
(WebInspector.ConsoleDispatcher.prototype.messageAdded):

inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleCommandResult):
(WebInspector.ConsoleMessage.create):

inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onAddConsoleMessage):

inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):

inspector/front-end/inspector.js:

(WebInspector.log.logMessage):
(WebInspector.log):

LayoutTests:

inspector/console/console-preserve-log.html:

2:14 AM Changeset in webkit [98455] by rniwa@webkit.org

1 edit
1 add
2 deletes in trunk/LayoutTests

Fix rebaseline done in r98439.

platform/chromium-cg-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.txt: Removed.
platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.txt: Removed.
platform/chromium/editing/pasteboard/copy-standalone-image-expected.txt: Added.

2:07 AM Changeset in webkit [98454] by vsevik@chromium.org

4 edits
3 adds in trunk

Web Inspector: Debugger fails when there is an invalid watch expression.
https://bugs.webkit.org/show_bug.cgi?id=70718

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/watch-expressions-panel-switch.html

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):

LayoutTests:

inspector/debugger/error-in-watch-expressions.html:
inspector/debugger/watch-expressions-panel-switch-expected.txt: Added.
inspector/debugger/watch-expressions-panel-switch.html: Added.
platform/chromium/inspector/debugger/watch-expressions-panel-switch-expected.txt: Added.

1:52 AM Changeset in webkit [98453] by fsamuel@chromium.org

2 edits in trunk/Source/WebCore

Page Scale Factor broken when navigating history on pages with child frames
https://bugs.webkit.org/show_bug.cgi?id=70459

Reviewed by Darin Fisher.

With frameScaleFactor now always returning 1.0 for subframes and pageScaleFactor for the mainFrame,
and there being only a single pageScaleFactor, history for scaling is broken. Scaling history is
saved on a per frame basis but restored, overriding the per-page pageScaleFactor multiple times.
As a result, sometimes pages that have subframes end up getting a scale factor of 1.0 instead
of the correct scale factor that was assigned to the main frame.

No new tests because I don't know how to test this.

loader/HistoryController.cpp:

(WebCore::HistoryController::restoreScrollPositionAndViewState):

1:52 AM Changeset in webkit [98452] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Filed more bugs.

platform/chromium/test_expectations.txt:

1:45 AM Changeset in webkit [98451] by rniwa@webkit.org

3 edits
2 adds
1 delete in trunk/LayoutTests

More Chromium test expectation updates. Filed a bunch of bugs to track real failures
and removed erroneous failing test expectations.

platform/chromium-cg-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png:
platform/chromium-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png: Added.
platform/chromium-mac-snowleopard/editing/deleting/merge-whitespace-pre-expected.png: Added.
platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png: Removed.
platform/chromium/test_expectations.txt:

1:29 AM Changeset in webkit [98450] by Simon Hausmann

10 edits
9 adds in trunk

[Qt][WK2] Rewrite MiniBrowser in QML
https://bugs.webkit.org/show_bug.cgi?id=70315

Add the first QML based implementation of MiniBrowser.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,

Zeno Albisser <zeno.albisser@nokia.com>

Source/WebKit2:

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-26
Reviewed by Tor Arne Vestbø.

UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebView::mousePressEvent):

2011-10-20 Zeno Albisser <zeno.albisser@nokia.com>

[Qt][WK2] Disable Context Menus until we have a proper QML implementation
https://bugs.webkit.org/show_bug.cgi?id=70537

This is just a temporary fix to avoid crashes in QtGui based
MiniBrowser that does not link to QtWidgets.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,

Zeno Albisser <zeno.albisser@nokia.com>

Reviewed by Simon Hausmann.

UIProcess/qt/WebContextMenuProxyQt.cpp:

(WebKit::WebContextMenuProxyQt::showContextMenu):
(WebKit::WebContextMenuProxyQt::createContextMenu):

Tools:

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-25
Reviewed by Tor Arne Vestbø.

MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::webView):
(BrowserWindow::load):
(BrowserWindow::keyPressEvent):
(BrowserWindow::~BrowserWindow):

MiniBrowser/qt/BrowserWindow.h:
MiniBrowser/qt/MiniBrowser.pro:
MiniBrowser/qt/MiniBrowser.qrc:
MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::handleUserOptions):

MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::WindowOptions):

MiniBrowser/qt/UrlLoader.cpp:

(UrlLoader::UrlLoader):

MiniBrowser/qt/icons/next.png: Added.
MiniBrowser/qt/icons/previous.png: Added.
MiniBrowser/qt/icons/refresh.png: Added.
MiniBrowser/qt/icons/stop.png: Added.
MiniBrowser/qt/main.cpp:

(main):

MiniBrowser/qt/qml/BrowserWindow.qml: Added.

1:29 AM Changeset in webkit [98449] by Simon Hausmann

2 edits in trunk/Source/WebKit2

2011-10-20 Zeno Albisser <zeno.albisser@nokia.com>

[Qt][WK2] Disable Context Menus until we have a proper QML implementation
https://bugs.webkit.org/show_bug.cgi?id=70537

This is just a temporary fix to avoid crashes in QtGui based
MiniBrowser that does not link to QtWidgets.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,

Zeno Albisser <zeno.albisser@nokia.com>

Reviewed by Simon Hausmann.

UIProcess/qt/WebContextMenuProxyQt.cpp:

(WebKit::WebContextMenuProxyQt::showContextMenu):
(WebKit::WebContextMenuProxyQt::createContextMenu):

1:29 AM Changeset in webkit [98448] by Simon Hausmann

8 edits
2 deletes in trunk/Tools

[Qt][WK2] Remove QtWidgets dependency in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=70529

Remove obsolete code for a new QML based implementation
of MiniBrowser.
Change BrowserWindow to derive from QSGView instead of
QMainWindow. QSGView is used as a top level window that
provides the container for placing QML content.
Make MiniBrowserApplication derive from QGuiApplication
instead of QApplication.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,

Zeno Albisser <zeno.albisser@nokia.com>

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-25
Reviewed by Simon Hausmann.

MiniBrowser/qt/BrowserView.cpp: Removed.
MiniBrowser/qt/BrowserView.h: Removed.
MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::load):
(BrowserWindow::screenshot):
(BrowserWindow::loadURLListFromFile):
(BrowserWindow::updateUserAgentList):
(BrowserWindow::~BrowserWindow):

MiniBrowser/qt/BrowserWindow.h:
MiniBrowser/qt/MiniBrowser.pro:
MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::notify):

MiniBrowser/qt/MiniBrowserApplication.h:
MiniBrowser/qt/UrlLoader.cpp:

(UrlLoader::UrlLoader):

MiniBrowser/qt/main.cpp:

1:28 AM Changeset in webkit [98447] by Simon Hausmann

19 edits
1 delete in trunk

[Qt][WK2] Remove QAction from MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=70525

In order to rewrite MiniBrowser in QML we need a suitable
mechanism for triggering navigation actions.
Due to the QtWidgets dependency of QAction the current
solution is not suitable anymore. Therefore we introduce
invokable methods and export properties in QWebNavigationController.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,

Zeno Albisser <zeno.albisser@nokia.com>

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-25
Reviewed by Simon Hausmann.

Source/WebKit2:

UIProcess/API/qt/WKView.h:
UIProcess/API/qt/qdesktopwebview.h:
UIProcess/API/qt/qtouchwebpage.h:
UIProcess/API/qt/qwebkittypes.h: Removed.
UIProcess/API/qt/qwebnavigationcontroller.cpp:

(QWebNavigationController::QWebNavigationController):
(QWebNavigationController::canGoBack):
(QWebNavigationController::canGoForward):
(QWebNavigationController::canStop):
(QWebNavigationController::canReload):
(QWebNavigationController::goBack):
(QWebNavigationController::goForward):
(QWebNavigationController::stop):
(QWebNavigationController::reload):

UIProcess/API/qt/qwebnavigationcontroller.h:
UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:

(tst_CommonViewTests::backAndForward):
(tst_CommonViewTests::reload):
(tst_CommonViewTests::stop):

UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::goBack):
(WebViewAbstraction::goForward):
(WebViewAbstraction::stop):
(WebViewAbstraction::reload):

UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:

(tst_QDesktopWebView::navigationStatusAtStartup):
(LoadStartedCatcher::onLoadStarted):
(tst_QDesktopWebView::stopEnabledAfterLoadStarted):

UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:

(tst_QTouchWebView::navigationStatusAtStartup):

UIProcess/qt/ClientImpl.cpp:

(dispatchLoadSucceeded):
(dispatchLoadFailed):
(qt_wk_didStartProvisionalLoadForFrame):
(qt_wk_didCommitLoadForFrame):
(qt_wk_didSameDocumentNavigationForFrame):

UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::canGoBack):
(QtWebPageProxy::goBack):
(QtWebPageProxy::canGoForward):
(QtWebPageProxy::goForward):
(QtWebPageProxy::canStop):
(QtWebPageProxy::stop):
(QtWebPageProxy::canReload):
(QtWebPageProxy::reload):
(QtWebPageProxy::navigationStateChanged):
(QtWebPageProxy::didRelaunchProcess):
(QtWebPageProxy::processDidCrash):

UIProcess/qt/QtWebPageProxy.h:
WebKit2API.pri:

Tools:

MiniBrowser/qt/BrowserView.cpp:
MiniBrowser/qt/BrowserView.h:
MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):

1:27 AM Changeset in webkit [98446] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/efl

[EFL] Private function _ewk_view_viewport_attributes_compute takes an internal data of ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66366

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-10-26
Reviewed by Ryosuke Niwa.

Passes to _ewk_view_viewport_attributes_compute an internal data of ewk_view instead of the view object.
Adds to ewk_view_viewport_attributes_get NULL checks to avoid unexpected results since this is API.

ewk/ewk_view.cpp:

(_ewk_view_viewport_attributes_compute):
(ewk_view_viewport_attributes_get):

1:24 AM Changeset in webkit [98445] by yurys@chromium.org

15 edits in trunk/Source

Unreviewed, rolling out r98429.
http://trac.webkit.org/changeset/98429
https://bugs.webkit.org/show_bug.cgi?id=70881

"webkit_gpu_tests fail in Chromium" (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-26

Source/WebCore:

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::layerRendererContext):

platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::enabled):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::setNeedsAnimate):
(WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
(WebCore::CCLayerTreeHost::composite):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setThread):

platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

public/WebLayerTreeView.h:
src/WebCompositorImpl.cpp:

(WebKit::WebCompositor::setThread):

src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::composite):

src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::runTest):

1:13 AM Changeset in webkit [98444] by gyuyoung.kim@samsung.com

2 edits in trunk/Tools

[EFL] Unregister viewport,changed signal in EWebLauncher.
https://bugs.webkit.org/show_bug.cgi?id=70478

Reviewed by Eric Seidel.

'viewport,changed' signal was registered by EWebLauncher in order to test viewport meta tag.
However, it sets wrong layout to some web sites which have viewport meta tag. Because, host pc
doesn't support proper DPI value though viewport is using DPI value to compute layout values.
This signal is for mobile device.

EWebLauncher/main.c:

(browserCreate):

1:07 AM Changeset in webkit [98443] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Cleanup Chromium test expectation. These tests were erroneously marked as timing out intermittently
even though the Chromium issue 66085 was fixed a long time ago.

Remove failing expectations from these tests except http/tests/xmlhttprequest/xmlhttprequest-test-send-flag.html
which is still timing out intermittently on Chromium Linux. Filed the bug 70878 to track the failure.

platform/chromium/test_expectations.txt:

12:57 AM Changeset in webkit [98442] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Remove temporary hack needed to ease Chromium/WebKit commit.
https://bugs.webkit.org/show_bug.cgi?id=70791

Patch by Polina Sokolova <polina@chromium.org> on 2011-10-26
Reviewed by Darin Fisher.

public/WebDocument.h:

12:57 AM Changeset in webkit [98441] by rniwa@webkit.org

3 edits
3 adds
2 deletes in trunk/LayoutTests

Chromium editing test rebaselines and editing test expectations updates.

platform/chromium-linux/editing/selection/5354455-2-expected.png:
platform/chromium-mac-leopard/editing/inserting/12882-expected.png: Added.
platform/chromium-mac-snowleopard/editing/inserting/12882-expected.png: Added.
platform/chromium-mac-snowleopard/editing/selection/5354455-2-expected.png: Added.
platform/chromium-mac/editing/inserting/12882-expected.png: Removed.
platform/chromium-mac/editing/selection/5354455-2-expected.png: Removed.
platform/chromium/test_expectations.txt:

12:52 AM Changeset in webkit [98440] by commit-queue@webkit.org

4 edits
2 adds in trunk

Canvas drawImage with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
https://bugs.webkit.org/show_bug.cgi?id=66920

Patch by Ben Wells <benwells@chromium.org> on 2011-10-26
Reviewed by James Robinson.

Source/WebCore:

Test: fast/canvas/canvas-composite-image.html

Use the same method as fills to handle composited drawImage calls that will affect the whole
canvas. To do this code used when doing fills has been factored into seperate functions and
used by drawImage. Some functions used to do these types of operations have also been renamed.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::isFullCanvasCompositeMode):
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::calculateCompositingBufferRect):
(WebCore::CanvasRenderingContext2D::createCompositingBuffer):
(WebCore::CanvasRenderingContext2D::compositeBuffer):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill):

html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

fast/canvas/canvas-composite-image-expected.txt: Added.
fast/canvas/canvas-composite-image.html: Added.

12:36 AM Changeset in webkit [98439] by rniwa@webkit.org

1 edit
3 adds
3 deletes in trunk/LayoutTests

Chromium Mac rebaseline, trusting the baseline optimizer.

platform/chromium-cg-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.txt: Added.
platform/chromium-cg-mac/editing/pasteboard/copy-standalone-image-expected.txt: Removed.
platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.png: Added.
platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.txt: Added.
platform/chromium-mac/editing/pasteboard/copy-standalone-image-expected.png: Removed.
platform/chromium-mac/editing/pasteboard/copy-standalone-image-expected.txt: Removed.

12:07 AM Changeset in webkit [98438] by rniwa@webkit.org

2 edits in trunk/Source/WebKit2

Another GTK build fix attempt after r98413 and r98416.

WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::update):

Oct 25, 2011:

11:57 PM Changeset in webkit [98437] by rniwa@webkit.org

2 edits in trunk/Source/WebKit2

C/C++ needs ; after each statement.

PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::geometryDidChange):

11:56 PM Changeset in webkit [98436] by rniwa@webkit.org

4 edits in trunk/LayoutTests

Mac, Qt, and Windows rebaseline r98407.

platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
platform/win/fast/dom/Window/window-property-descriptors-expected.txt:

11:47 PM Changeset in webkit [98435] by rniwa@webkit.org

2 edits in trunk/Source/WebKit2

GTK build fix attempt after r98413 and r98416.

PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::paint):
(WebKit::PluginControllerProxy::geometryDidChange):

11:46 PM Changeset in webkit [98434] by commit-queue@webkit.org

8 edits in trunk

Unreviewed, rolling out r98379.
http://trac.webkit.org/changeset/98379
https://bugs.webkit.org/show_bug.cgi?id=70875

Did not pass on JSC ports (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-25

Source/WebCore:

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateArgumentsCountCheck):
(GenerateImplementation):

html/canvas/CanvasRenderingContext2D.idl:
page/DOMWindow.idl:

LayoutTests:

fast/canvas/canvas-putImageData-expected.txt:
fast/canvas/canvas-putImageData.js:

11:25 PM Changeset in webkit [98433] by commit-queue@webkit.org

4 edits
2 deletes in trunk

Unreviewed, rolling out r98346.
http://trac.webkit.org/changeset/98346
https://bugs.webkit.org/show_bug.cgi?id=70874

Breaks JSC-based bots. (Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-25

Source/WebCore:

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):

LayoutTests:

inspector/debugger/error-in-watch-expressions.html:
inspector/debugger/watch-expressions-panel-switch-expected.txt: Removed.
inspector/debugger/watch-expressions-panel-switch.html: Removed.

11:20 PM Changeset in webkit [98432] by rniwa@webkit.org

3 edits in trunk/LayoutTests

Flaky Test: editing/pasteboard/copy-standalone-image.html
https://bugs.webkit.org/show_bug.cgi?id=61813

Reviewed by Adam Barth.

The flakiness was caused by the fact test didn't wait until iframe finish loading.

HTML5 section 4.8.2. the iframe element (http://www.whatwg.org/specs/web-apps/current-work/#the-iframe-element):

When there is an active parser in the iframe, and when anything in the iframe is delaying the load event
of the iframe's browsing context's active document, the iframe must delay the load event of its document.

Since an image doesn't require an active parser, it does not delay the load event of the document.

editing/pasteboard/copy-standalone-image.html:
platform/chromium/test_expectations.txt:

10:55 PM Changeset in webkit [98431] by barraclough@apple.com

3 edits in trunk/Source/JavaScriptCore

Split DFGJITCodeGenerator::callOperation methods
https://bugs.webkit.org/show_bug.cgi?id=70870

Reviewed by Filip Pizlo.

The DFGJITCodeGenerator currently contains two sets of callOperation methods.
One set works with the JSVALUE64 value representation and passes arguments in
registers (suitable for use on x86-64), and one set works with the JSVALUE32_64
value representation and passes arguments in memory (suitable for use on x86).
By refactoring out the representation and calling convention specific aspects
of the code we can also configure the DFG JIT to operator on platforms that use
the JSVALUE32_64 value representation but pass arguments in registers.

On platforms supported by the JIT, the payload precedes the tag of a value in
argument/result ordering, as such, in order to make the setupResults method
generally applicable to return the results of a function that are returned in
two registers, the ordering of arguments to this function has been reversed -
as is the ordering of augments passed to setupArguments methods, with respect
to the ordering with which they are passed in to callOperation.
This inconsistency will be resolved in a later change when we combine the pairs
of arguments passed into callOperation, such that the function signatures can
be made consistent across the two value representations (the callOperation
methods will be passed a reference to a struct representing the JSValue
temporary, this will consist of two gprs on 32_64 and one on 64).

dfg/DFGJITCodeGenerator.h:

(JSC::DFG::resetCallArguments):
(JSC::DFG::addCallArgument):

moved, removed tag,payload version of this method.

(JSC::DFG::setupArguments):
(JSC::DFG::setupArgumentsExecState):
(JSC::DFG::setupArgumentsWithExecState):

Calling convention specific portion of callOperation refactored out into these methods.

(JSC::DFG::callOperation):

updated these methods to use setupArguments* methods.

(JSC::DFG::setupResults):

setupResults is now passed payload,tag.

(JSC::DFG::appendCallWithExceptionCheckSetResult):

Added fpr versions of this function.

(JSC::DFG::appendCallSetResult):

Added versions of this function without exception check.

dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

setupResults is now passed payload,tag.

10:17 PM Changeset in webkit [98430] by xji@chromium.org

2 edits in trunk/LayoutTests

Disable editing/selection/move-by-word-visually-inline-block-positioned-element.html in QT after r98428.

platform/qt/Skipped:

10:02 PM Changeset in webkit [98429] by nduca@chromium.org

15 edits in trunk/Source

[chromium] Enable threaded compositing via CCThreadProxy::hasThread only
https://bugs.webkit.org/show_bug.cgi?id=70838

Reviewed by James Robinson.

Source/WebCore:

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::layerRendererContext):

platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::enabled):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::hasThread):

platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

public/WebLayerTreeView.h:
src/WebCompositorImpl.cpp:
src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::composite):

src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

9:57 PM Changeset in webkit [98428] by xji@chromium.org

7 edits
2 adds in trunk

--webkit-visual-word does not work in multi-line
https://bugs.webkit.org/show_bug.cgi?id=61344

Reviewed by Ryosuke Niwa.

Source/WebCore:

Get next or previous root inline box (which is not in the same
render object as the current root inline box) by traversing DOM node.

Test: editing/selection/move-by-word-visually-inline-block-positioned-element.html

editing/visible_units.cpp:

(WebCore::previousRootInlineBox):
(WebCore::nextRootInlineBox):
(WebCore::leftInlineBox):
(WebCore::rightInlineBox):

LayoutTests:

editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt: Added.
editing/selection/move-by-word-visually-inline-block-positioned-element.html: Added.
editing/selection/move-by-word-visually-multi-line-expected.txt:
editing/selection/move-by-word-visually-single-space-one-element-expected.txt:
editing/selection/move-by-word-visually-single-space-one-element.html:
platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt:

8:06 PM Changeset in webkit [98427] by abarth@webkit.org

3 edits in trunk/Source/WebCore

JSEventTarget.cpp has a bunch of unnessary includes
https://bugs.webkit.org/show_bug.cgi?id=70865

Reviewed by Eric Seidel.

In the process of removing these includes, I noticed we had a bunch of
non-autogenerated code in this file, which I've now autogenerated.

bindings/js/JSEventTarget.cpp:

(WebCore::toEventTarget):

One subtly here is the outter static_cast, which is caused by an inheritance infelicity in JavaScriptAudioNode, which I've noted with a FIXME. In any case, the extra static_cast shouldn't cause any trouble.

webaudio/JavaScriptAudioNode.h:

7:14 PM Changeset in webkit [98426] by abarth@webkit.org

2 edits in trunk/Source/WebCore

V8DOMWrapper.cpp has unneeded header includes
https://bugs.webkit.org/show_bug.cgi?id=70863

Reviewed by Eric Seidel.

bindings/v8/V8DOMWrapper.cpp:

7:12 PM Changeset in webkit [98425] by arv@chromium.org

2 edits in trunk/LayoutTests

Fix ad hoc test.

unreviewed.

fast/canvas/webgl/gl-teximage.html:

7:11 PM Changeset in webkit [98424] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/efl

Fix occurrence of unpainted tiles while scrolling and zooming.
https://bugs.webkit.org/show_bug.cgi?id=70711

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-10-25
Reviewed by Adam Barth.

Cast one of operatees to float type when ewk_tiled_backing_store calculate tiles list on viewport.
For the proper calculation to generate a float number, at least one of operatees must be a float type.
But, currently both two operatees to calculate the number of tiles on viewport routine aren't float type,
so it generates smaller result than expected result when it is using ceil API.
As a result, it can lose a line of tiles which should be displayed in viewport area while scrolling and zooming.

ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_recalc_renderers):
(ewk_tiled_backing_store_zoom_weak_set):

6:59 PM Changeset in webkit [98423] by mhahnenberg@apple.com

3 edits in trunk/Source/WebCore

Resetting baseline for test bindings

Unreviewed preemptive build fix

No new tests.

bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/JS/JSTestObj.h:

6:49 PM Changeset in webkit [98422] by mhahnenberg@apple.com

59 edits in trunk/Source

Remove deletePropertyVirtual
https://bugs.webkit.org/show_bug.cgi?id=70738

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Removed all declarations and definitions of deletePropertyVirtual.
Also replaced all call sites to deletePropertyVirtual with a
corresponding lookup in the MethodTable.

API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:

(JSC::::deletePropertyByIndex):

API/JSObjectRef.cpp:

(JSObjectDeleteProperty):

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::deleteProperty):

debugger/DebuggerActivation.h:
interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

runtime/Arguments.cpp:
runtime/Arguments.h:
runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):

runtime/JSActivation.cpp:
runtime/JSActivation.h:
runtime/JSArray.cpp:

(JSC::JSArray::deleteProperty):
(JSC::JSArray::deletePropertyByIndex):

runtime/JSArray.h:
runtime/JSCell.cpp:

(JSC::JSCell::deleteProperty):
(JSC::JSCell::deletePropertyByIndex):

runtime/JSCell.h:
runtime/JSFunction.cpp:
runtime/JSFunction.h:
runtime/JSNotAnObject.cpp:
runtime/JSNotAnObject.h:
runtime/JSONObject.cpp:

(JSC::Walker::walk):

runtime/JSObject.cpp:

(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::defineOwnProperty):

runtime/JSObject.h:
runtime/JSVariableObject.cpp:
runtime/JSVariableObject.h:
runtime/RegExpMatchesArray.h:
runtime/StrictEvalActivation.cpp:
runtime/StrictEvalActivation.h:
runtime/StringObject.cpp:
runtime/StringObject.h:

Source/WebCore:

No new tests.

Removed all declarations and definitions of deletePropertyVirtual.
Also replaced all call sites to deletePropertyVirtual with a
corresponding lookup in the MethodTable.

WebCore.exp.in:
bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::deleteProperty):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::deleteProperty):

bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::deleteProperty):

bindings/js/JSDOMWindowShell.h:
bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::deleteProperty):

bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::deleteProperty):

bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::deleteProperty):

bindings/js/ScriptObject.cpp:

(WebCore::ScriptGlobalObject::remove):

bindings/objc/WebScriptObject.mm:

(-[WebScriptObject removeWebScriptKey:]):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

bridge/NP_jsobject.cpp:

(_NPN_RemoveProperty):

bridge/jni/jni_jsobject.mm:

(JavaJSObject::removeMember):

bridge/objc/objc_runtime.h:
bridge/objc/objc_runtime.mm:
bridge/runtime_array.cpp:
bridge/runtime_array.h:
bridge/runtime_object.cpp:
bridge/runtime_object.h:

Source/WebKit/mac:

Removed all declarations and definitions of deletePropertyVirtual.
Also replaced all call sites to deletePropertyVirtual with a
corresponding lookup in the MethodTable.

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::removeProperty):

Source/WebKit2:

Removed all declarations and definitions of deletePropertyVirtual.
Also replaced all call sites to deletePropertyVirtual with a
corresponding lookup in the MethodTable.

WebProcess/Plugins/Netscape/JSNPObject.cpp:
WebProcess/Plugins/Netscape/JSNPObject.h:
WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::removeProperty):

6:45 PM Changeset in webkit [98421] by Chris Fleizach

4 edits
2 adds in trunk

AX: WebKit does not expose HTML label for slider elements
https://bugs.webkit.org/show_bug.cgi?id=70856

Reviewed by Darin Adler.

Source/WebCore:

Test: platform/mac/accessibility/slider-allows-title-ui-element.html

accessibility/AccessibilitySlider.h:

(WebCore::AccessibilitySlider::isControl):

accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

platform/mac/accessibility/slider-allows-title-ui-element-expected.txt: Added.
platform/mac/accessibility/slider-allows-title-ui-element.html: Added.

6:38 PM Changeset in webkit [98420] by jchaffraix@webkit.org

2 edits in trunk/LayoutTests

Unreviewed gardening.

platform/chromium/test_expectations.txt:

fast/forms/form-associated-element-crash3.html has
been timing out very regularly on linux debug.

6:15 PM Changeset in webkit [98419] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/efl

[EFL] Move assignment of some variables out of loop for ewk_tiled_backing_store.
https://bugs.webkit.org/show_bug.cgi?id=67588

Some of variables which aren't related with loop count or other variables
inside of loop are moved out of loop.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-10-25
Reviewed by Adam Barth.

ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_view_wrap_up):
(_ewk_tiled_backing_store_view_wrap_down):
(_ewk_tiled_backing_store_view_wrap_left):
(_ewk_tiled_backing_store_view_wrap_right):

6:13 PM Changeset in webkit [98418] by bfulgham@webkit.org

2 edits in trunk/Source/WebKit2

[WinCairo] Unreviewed build fix after r97587.

win/WebKit2CFLite.def:

6:01 PM Changeset in webkit [98417] by arv@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Fix expectation.

unreviewed.

platform/chromium/fast/js/kde/garbage-n-expected.txt:

6:00 PM Changeset in webkit [98416] by andersca@apple.com

3 edits in trunk/Source/WebKit2

CG plug-ins are always given a context with a scale factor of 1, even when the device scale factor is something else
https://bugs.webkit.org/show_bug.cgi?id=67227
<rdar://problem/10048319>

Reviewed by Sam Weinig.

PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::paint):
Apply the scale factor when painting.

WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::paint):
Apply the scale factor when painting.

(WebKit::PluginProxy::geometryDidChange):
Make sure to apply the contents scale factor to the backing store size.

(WebKit::PluginProxy::update):
Apply the scale factor (when painting).

5:56 PM Changeset in webkit [98415] by mhahnenberg@apple.com

76 edits in trunk/Source

Remove putVirtual
https://bugs.webkit.org/show_bug.cgi?id=70740

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:
API/JSObjectRef.cpp:

(JSObjectSetProperty):
(JSObjectSetPropertyAtIndex):

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::put):

debugger/DebuggerActivation.h:
dfg/DFGOperations.cpp:
interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):

jsc.cpp:

(GlobalObject::finishCreation):

runtime/Arguments.cpp:
runtime/Arguments.h:
runtime/ArrayPrototype.cpp:

(JSC::putProperty):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):

runtime/JSActivation.cpp:
runtime/JSActivation.h:
runtime/JSArray.cpp:

(JSC::JSArray::putSlowCase):
(JSC::JSArray::push):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCount):

runtime/JSArray.h:
runtime/JSByteArray.cpp:
runtime/JSByteArray.h:
runtime/JSCell.cpp:

(JSC::JSCell::put):
(JSC::JSCell::putByIndex):

runtime/JSCell.h:
runtime/JSFunction.cpp:
runtime/JSFunction.h:
runtime/JSGlobalObject.cpp:
runtime/JSGlobalObject.h:
runtime/JSNotAnObject.cpp:
runtime/JSNotAnObject.h:
runtime/JSONObject.cpp:

(JSC::Walker::walk):

runtime/JSObject.cpp:

(JSC::JSObject::putByIndex):
(JSC::JSObject::defineOwnProperty):

runtime/JSObject.h:

(JSC::JSValue::put):

runtime/JSStaticScopeObject.cpp:
runtime/JSStaticScopeObject.h:
runtime/ObjectPrototype.cpp:
runtime/ObjectPrototype.h:
runtime/RegExpConstructor.cpp:
runtime/RegExpConstructor.h:
runtime/RegExpMatchesArray.h:
runtime/RegExpObject.cpp:
runtime/RegExpObject.h:
runtime/StringObject.cpp:
runtime/StringObject.h:
runtime/StringPrototype.cpp:

(JSC::stringProtoFuncSplit):

Source/JavaScriptGlue:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

JSValueWrapper.cpp:

(JSValueWrapper::JSObjectSetProperty):

UserObjectImp.cpp:
UserObjectImp.h:

Source/WebCore:

No new tests.

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

WebCore.exp.in:
bindings/js/JSDOMWindowCustom.cpp:
bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::put):

bindings/js/JSDOMWindowShell.h:
bindings/js/JSPluginElementFunctions.cpp:

(WebCore::runtimeObjectCustomPut):

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::putProperty):

bindings/objc/WebScriptObject.mm:

(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject setWebScriptValueAtIndex:value:]):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

bridge/NP_jsobject.cpp:

(_NPN_SetProperty):

bridge/jni/jni_jsobject.mm:

(JavaJSObject::setMember):
(JavaJSObject::setSlot):

bridge/objc/objc_runtime.h:
bridge/objc/objc_runtime.mm:
bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertQVariantToValue):

bridge/runtime_array.cpp:
bridge/runtime_array.h:
bridge/runtime_object.cpp:
bridge/runtime_object.h:
bridge/testqtbindings.cpp:

(main):

Source/WebKit/efl:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

ewk/ewk_view.cpp:

(ewk_view_js_object_add):

Source/WebKit/mac:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::setProperty):

Source/WebKit/qt:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

Api/qwebframe.cpp:

(QWebFrame::addToJavaScriptWindowObject):

Source/WebKit2:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

WebProcess/Plugins/Netscape/JSNPObject.cpp:
WebProcess/Plugins/Netscape/JSNPObject.h:
WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::setProperty):

5:34 PM Changeset in webkit [98414] by andersca@apple.com

3 edits in trunk

Add radar.

5:30 PM Changeset in webkit [98413] by andersca@apple.com

18 edits in trunk

Plug-ins have no way to find out when the device scale factor changes
https://bugs.webkit.org/show_bug.cgi?id=67226

Reviewed by Sam Weinig.

Source/WebKit2:

PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::geometryDidChange):

PluginProcess/PluginControllerProxy.h:

This now takes the contentsScaleFactor and calls contentsScaleFactorChanged on its plug-in
if the scale factor changes.

PluginProcess/PluginControllerProxy.messages.in:

GeometryDidChange now takes a contents scale factor parameter.

WebProcess/Plugins/Netscape/NetscapePlugin.h:
WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::contentsScaleFactorChanged):
Implement contentsScaleFactorChanged and call NPP_SetValue with the new scale factor.

WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::contentsScaleFactorChanged):

WebProcess/Plugins/PDF/BuiltInPDFView.h:

Add stub.

WebProcess/Plugins/Plugin.h:

Add pure virtual contentsScaleFactorChanged member function.

WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange):
Add geometryDidChange overload that doesn't take any parameters. Make it send over the
new scale factor to the plug-in process.

(WebKit::PluginProxy::contentsScaleFactorChanged):
Call geometryDidChange.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::setDeviceScaleFactor):
Call Plugin::contentsScaleFactorChanged.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setDeviceScaleFactor):
Call setDeviceScaleFactor on all registered plug-ins.

Tools:

Keep a cached copy of the contents scale and update it when it changes.

DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp:

(ContentsScaleFactor::ContentsScaleFactor):
(ContentsScaleFactor::cachedContentsScaleFactor):
(ContentsScaleFactor::ScriptableObject::hasProperty):
(ContentsScaleFactor::ScriptableObject::getProperty):
(ContentsScaleFactor::NPP_New):
(ContentsScaleFactor::NPP_SetValue):

LayoutTests:

Update test to check that the scale factor is updated correctly.

platform/mac-wk2/plugins/contents-scale-factor.html:

4:43 PM Changeset in webkit [98412] by abarth@webkit.org

4 edits
2 adds in trunk

EventTargetFactory.in is not sorted
https://bugs.webkit.org/show_bug.cgi?id=70855

Reviewed by Eric Seidel.

PerformanceTests:

Add a microbenchmark for wrapping event target.

Bindings: Added.
Bindings/event-target-wrapper.html: Added.
Parser/resources/runner.js:

(runLoop):

Let the user of the harness get a callback when the test is done.

Source/WebCore:

This patch sorts the file. I was not able to measure a performance
difference using the microbenchmark included with this patch.

dom/EventTargetFactory.in:

4:42 PM Changeset in webkit [98411] by fsamuel@chromium.org

7 edits
3 adds in trunk/LayoutTests

Made Table tests for Bug 70678 Platform Independent
https://bugs.webkit.org/show_bug.cgi?id=70850

Reviewed by Adam Barth.

fast/table/table-anonymous-cell-bug-expected.png: Added.
fast/table/table-anonymous-cell-bug-expected.txt:
fast/table/table-anonymous-cell-bug.html:
fast/table/table-anonymous-row-bug-expected.png: Added.
fast/table/table-anonymous-row-bug-expected.txt:
fast/table/table-anonymous-row-bug.html:
fast/table/table-anonymous-section-bug-expected.png: Added.
fast/table/table-anonymous-section-bug-expected.txt:
fast/table/table-anonymous-section-bug.html:

4:39 PM Changeset in webkit [98410] by abarth@webkit.org

3 edits in trunk/Source/WebCore

Attempt to fix the Windows build. Windows mashes all these files into
one, which doesn't respect the compilation unit rules of C++.

bindings/js/JSEventCustom.cpp:
bindings/js/JSEventTarget.cpp:

4:19 PM Changeset in webkit [98409] by weinig@apple.com

2 edits in trunk/Tools

Add WKBrowsingContextLoadDelegateTest test for a failed load
https://bugs.webkit.org/show_bug.cgi?id=70859

Reviewed by Anders Carlsson.

TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:

(TEST_F): Add TEST_F(WKBrowsingContextLoadDelegateTest, SimpleLoadFail).

(-[SimpleLoadFailDelegate browsingContextControllerDidFailProvisionalLoad:withError:]):
Test that we are getting the correct NSError code and domain.

4:17 PM Changeset in webkit [98408] by rniwa@webkit.org

3 edits
2 adds in trunk

Moving to the start of line should not place the caret outside of the table
https://bugs.webkit.org/show_bug.cgi?id=70757

Reviewed by Chang Shu.

Source/WebCore:

The bug was caused by positionAvoidingFirstPositionInTable. Get rid of the function.

Test: editing/selection/table-lineboundary.html

editing/visible_units.cpp:

(WebCore::startPositionForLine):

LayoutTests:

Added a test to move the caret to lineboundaries in the first and the last table cell.
The caret should remain inside a table cell.

editing/selection/table-lineboundary-expected.txt: Added.
editing/selection/table-lineboundary.html: Added.

4:10 PM Changeset in webkit [98407] by arv@chromium.org

1609 edits
1 delete in trunk

JS Test Harness: Make successfullyParsed optional
https://bugs.webkit.org/show_bug.cgi?id=70784

Reviewed by Ojan Vafai.

Tools:

Scripts/make-new-script-test:

(writeTestFile): Update the template for script tests.

LayoutTests:

This makes "successfullyParsed = true" optional in favor of tracking syntax errors
using window.onerror.

fast/*: Remove successfullyParsed.
fast/dom/Window/new-window-opener.html: Cleanup.
fast/dom/Window/resources/window-appendages-cleared-results.html:
fast/dom/Window/webkitConvertPoint.html: Ditto.
fast/dom/Window/webkitConvertPointUpdateLayout.html: Ditto.
fast/js/kde/evil-n.html: This is now a normal test since it is not supposed to fail.
fast/js/kde/garbage-n-expected.txt:
fast/js/kde/garbage-n.html: Use shouldHaveHadError instead of js-test-post-n.js
fast/js/kde/string-1-n.html: Ditto.
fast/js/kde/string-2-n.html: Ditto.
fast/js/resources/js-test-post-async.js: Ensure we didn't get an error.
fast/js/resources/js-test-post-function.js: Ditto.
fast/js/resources/js-test-post-n.js: Removed.
fast/js/resources/js-test-pre.js: Added shouldHaveHadError function that can be used to assert that the

error message is what was expected.
Ensure we didn't get an error in finistJSTest.

4:10 PM Changeset in webkit [98406] by Beth Dakin

9 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=70852
Setting up a HiDPI base-level GraphicsContext should be more straightforward for
WebKit2

Reviewed by Dan Bernstein.

Source/WebCore:

This patch removes the old cg-only GraphicsContext::setBaseCTM() api, and adds
platform-independent GraphicsContext::applyDeviceScaleFactor().

WebCore.exp.in:
platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
(WebCore::GraphicsContext::applyDeviceScaleFactor):

platform/graphics/GraphicsContext.h:
platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):

Since this patch removes GraphicsContext::setBaseCTM(), this code has been
reverted to do what it used to do before that was added; it just calls into
WebCoreSystemInterface directly.

platform/graphics/cg/ImageCG.cpp:

(WebCore::Image::drawPattern):

Source/WebKit2:

When we need a base-level HiDPI GraphicsContext, call into new GraphicsContext api
GraphicsContext::applyDeviceScaleFactor() rather than manually scaling and
adjusting the base CTM.

WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::display):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotInViewCoordinates):
(WebKit::WebPage::scaledSnapshotInDocumentCoordinates):

4:06 PM Changeset in webkit [98405] by barraclough@apple.com

7 edits in trunk/Source/JavaScriptCore

Separate out function linking & exception check data structures.
https://bugs.webkit.org/show_bug.cgi?id=70858

Reviewed by Oliver Hunt.

This will make it easier to refactor the callOperation methods to spilt the value
representation specific handling from the cpu/calling-convention implementation.

dfg/DFGJITCodeGenerator.h:

(JSC::DFG::appendCallWithExceptionCheck):

dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

dfg/DFGJITCompiler.h:

(JSC::DFG::CallLinkRecord::CallLinkRecord):
(JSC::DFG::CallExceptionRecord::CallExceptionRecord):
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::notifyCall):
(JSC::DFG::JITCompiler::appendCall):
(JSC::DFG::JITCompiler::addExceptionCheck):
(JSC::DFG::JITCompiler::addFastExceptionCheck):

dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

4:02 PM Changeset in webkit [98404] by jchaffraix@webkit.org

2 edits in trunk/LayoutTests

More gardening.

platform/chromium/test_expectations.txt: Missed some cases where

video-porter.html times out. Also added zoom-animator-scale-test2.html
that has been timing out for several days.

4:00 PM Changeset in webkit [98403] by andersca@apple.com

19 edits
3 adds in trunk

Source/WebCore: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225

Reviewed by Darin Adler.

Test: platform/mac-wk2/plugins/contents-scale-factor.html

Add NPNVcontentsScaleFactor, as per https://wiki.mozilla.org/NPAPI:ContentsScaleFactor.

plugins/npapi.h:

Source/WebKit2: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225
<rdar://problem/10048258>

Reviewed by Darin Adler.

PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::PluginControllerProxy):
Initialize m_contentsScaleFactor.

PluginProcess/PluginControllerProxy.h:

Add contentsScaleFactor member function and m_contentsScaleFactor member variable.

PluginProcess/PluginCreationParameters.cpp:

(WebKit::PluginCreationParameters::PluginCreationParameters):
(WebKit::PluginCreationParameters::encode):
(WebKit::PluginCreationParameters::decode):

PluginProcess/PluginCreationParameters.h:

Add contentsScaleFactor to the creation parameters.

PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::contentsScaleFactor):
Return the cached m_contentsScaleFactor.

WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Handle getting the scale factor by calling NetscapePlugin::contentsScaleFactor.

WebProcess/Plugins/Netscape/NetscapePlugin.h:
WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::contentsScaleFactor):
Ask the plug-in controller for the contents scale factor.

WebProcess/Plugins/PluginController.h:

Add contentsScaleFactor pure virtual member function.

WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::initialize):
Set contentsScaleFactor in the creation parameters.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::contentsScaleFactor):
Get the device scale factor from the page.

WebProcess/Plugins/PluginView.h:

Add contentsScaleFactor().

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setDeviceScaleFactor):
Bail if the scale factor didn't change.

Tools: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225
<rdar://problem/10048258>

Reviewed by Darin Adler.

Add a plug-in test for getting the contents scale factor.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp: Added.

(ContentsScaleFactor::ContentsScaleFactor):
(ContentsScaleFactor::contentsScaleFactor):
(ContentsScaleFactor::ScriptableObject::hasProperty):
(ContentsScaleFactor::ScriptableObject::getProperty):
(ContentsScaleFactor::ScriptableObject::pluginTest):
(ContentsScaleFactor::NPP_GetValue):

LayoutTests: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225
<rdar://problem/10048258>

Reviewed by Darin Adler.

Add tests.

platform/mac-wk2/plugins/contents-scale-factor-expected.txt: Added.
platform/mac-wk2/plugins/contents-scale-factor.html: Added.

3:55 PM Changeset in webkit [98402] by adamk@chromium.org

2 edits in trunk/Source/WebCore

Forward declare MutationObserverEntry as a struct to fix clang build
https://bugs.webkit.org/show_bug.cgi?id=70853

Reviewed by Ryosuke Niwa.

Node.h forward declared MutationObserverEntry as a class, and clang
complains if the two declarations don't match.

dom/Node.h:

3:51 PM Changeset in webkit [98401] by leviw@chromium.org

8 edits in branches/subpixellayout/Source

Mac build fixes and adding pixelSnapped convenience methods for accessors that needed them.

3:45 PM Changeset in webkit [98400] by mitz@apple.com

3 edits
1 add in trunk/Source/WebCore

Caret can be positioned or repainted incorrectly in flipped-blocks multi-column blocks
https://bugs.webkit.org/show_bug.cgi?id=70851

Reviewed by Dave Hyatt.

manual-tests/caret-in-columns-flipped.html: Added.
rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustForColumns): Removed flipped-blocks writing mode considerations
from this function, since not all callers were expecting it to account for flippedness. This makes
it similar to adjustRectForColumns() in not adjusting for flippedness.

rendering/RenderBox.cpp:

(WebCore::RenderBox::offsetFromContainer): In the columns case, account for flipped-blocks modes
by first mapping the point and the offset to non-flipped, non-columns space, then adjusting for
columns, then flipping.

3:35 PM Changeset in webkit [98399] by weinig@apple.com

6 edits
2 adds in trunk

Flesh out WKBrowsingContextLoadDelegate a bit
https://bugs.webkit.org/show_bug.cgi?id=70846

Source/WebKit2:

Add didReceiveServerRedirectForProvisionalLoad, didFailProvisionalLoad
and didFailLoad.

Reviewed by Anders Carlsson.

Test: WKBrowsingContextLoadDelegateTest

UIProcess/API/mac/WKBrowsingContextController.mm:

(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didFailLoadWithErrorForFrame):
(setUpPageLoaderClient):

UIProcess/API/mac/WKBrowsingContextLoadDelegate.h:

Tools:

Reviewed by Anders Carlsson.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit2ObjC: Added.
TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm: Added.

(WKBrowsingContextLoadDelegateTest::WKBrowsingContextLoadDelegateTest):
(WKBrowsingContextLoadDelegateTest::SetUp):
(WKBrowsingContextLoadDelegateTest::TearDown):
(-[SimpleLoadDelegate browsingContextControllerDidFinishLoad:]):
(TEST_F):
Add basic testing for WKBrowsingContextLoadDelegate.

2:56 PM Changeset in webkit [98398] by fpizlo@apple.com

4 edits in trunk/Source/JavaScriptCore

Tiered compilation may introduce dangling pointers in constant buffers
https://bugs.webkit.org/show_bug.cgi?id=70854

Reviewed by Oliver Hunt.

Tiered compilation now copies constant buffers, which fixes the regression in
https://bugs.webkit.org/show_bug.cgi?id=70246. No new tests because this
regression relies on a subtle interleaving of optimized compilation and garbage
collection, and cannot be reproduced in a simple test.

This also adds some new debug support, which was used to fix this bug and is
likely to be useful in the future.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::copyDataFrom):
(JSC::CodeBlock::usesOpcode):

bytecode/CodeBlock.h:
dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

2:44 PM Changeset in webkit [98397] by jchaffraix@webkit.org

2 edits in trunk/LayoutTests

More unreviewed gardening.

platform/chromium/test_expectations.txt: Mark another test

as crashing. Moved 2 tests together as they hit the same ASSERT
on the bots.

2:25 PM Changeset in webkit [98396] by eae@chromium.org

5 edits in branches/subpixellayout/Source/WebCore/platform

Fix scrollbars for chromium/linux

2:16 PM Changeset in webkit [98395] by ap@apple.com

2 edits in trunk/Tools

make-script-test-wrappers should not look outside fast/js
https://bugs.webkit.org/show_bug.cgi?id=66357

Reviewed by Maciej Stachowiak.

Scripts/make-script-test-wrappers: Don't look for template files everywhere, only support

fast/js.

2:11 PM Changeset in webkit [98394] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Assertion failure when zooming a PDF in an iframe
https://bugs.webkit.org/show_bug.cgi?id=70849

Reviewed by Alexey Proskuryakov.

If the plug-in doesn't want window relative coordinates, we shouldn't give the plug-in window relative coordinates.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::viewGeometryDidChange):

2:10 PM Changeset in webkit [98393] by commit-queue@webkit.org

7 edits
1 add in trunk/Source

Fix teardown in Web*LayerImpl, and add tests for Web*Layer
https://bugs.webkit.org/show_bug.cgi?id=70431

Patch by Antoine Labour <piman@chromium.org> on 2011-10-25
Reviewed by James Robinson.

src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::~WebContentLayerImpl):

src/WebExternalTextureLayerImpl.cpp:

(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):

src/WebLayerImpl.cpp:

(WebKit::WebLayerImpl::~WebLayerImpl):

1:59 PM Changeset in webkit [98392] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

LayerRendererChromium::setVisible called needlessly without a visibility change
https://bugs.webkit.org/show_bug.cgi?id=70766

Patch by Michal Mocny <mmocny@google.com> on 2011-10-25
Reviewed by Kenneth Russell.

Check that visibility has actually changed before calling LayerRendererChromium::setVisible

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setVisible):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

1:56 PM Changeset in webkit [98391] by eae@chromium.org

1101 edits
2420 copies
54 deletes in branches/subpixellayout

Merging trunk changes up until 98381 into subpixel branch.

1:54 PM Changeset in webkit [98390] by abarth@webkit.org

2 edits in trunk/Tools

Add a --make option to update-webkit to engage the Makefile-based build system
https://bugs.webkit.org/show_bug.cgi?id=70847

Reviewed by Dimitri Glazkov.

I can never remember what crazy environment variables I'm supposed to
set to tell GYP what to do.

Scripts/update-webkit:

1:46 PM Changeset in webkit [98389] by andersca@apple.com

2 edits in trunk/Source/WebCore

REGRESSION(97821): HistoryController::itemsAreClones crashes a lot
https://bugs.webkit.org/show_bug.cgi?id=70827
<rdar://problem/10342925>

Reviewed by Adam Barth.

Check that m_currentItem is non-null before passing it to itemsAreClones. While I wasn't
able to make a test case that would reproduce this crash, we do check m_currentItem for null
everywhere else, and the crash log indicates that this would fix the crash.

loader/HistoryController.cpp:

(WebCore::HistoryController::recursiveUpdateForCommit):

1:44 PM Changeset in webkit [98388] by abarth@webkit.org

74 edits
1 add in trunk/Source

EventTarget.h shouldn't need to know about every feature and ifdef
https://bugs.webkit.org/show_bug.cgi?id=70659

Reviewed by Darin Adler.

Source/WebCore:

This patch follows the approach of Event.h and introduces an
interfaceName virtual function that returns the name of the DOM
interface for the concrete type of the object. This function lets us
remove a large number of fake dynamic casts.

CMakeLists.txt:
CodeGenerators.pri:
DerivedSources.make:
GNUmakefile.am:
WebCore.gyp/WebCore.gyp:
WebCore.gyp/scripts/action_makenames.py:
- Teach action_makenames how to handle the new "in" file.
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSEventTarget.cpp:

(WebCore::toJS):

Use the new autogenerated macro to remove a large amount of feature-specific code.

bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::initScript):

bindings/objc/DOM.mm:

(kit):

The SVGElementInstance branch was never taken previously because SVGElementInstance::toNode returns a non-NULL value. This code was introduced in http://trac.webkit.org/changeset/42618 and doesn't appear to have ever worked as the author intended.

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

Use the new autogenerated macro to remove a large amount of feature-specific code.

dom/EventNames.cpp:

(WebCore::EventNames::EventNames):

dom/EventNames.h:
dom/EventTarget.cpp:
dom/EventTarget.h:
dom/EventTargetFactory.in: Added.
- Add a new "in" file that lists all the EventTargets.
dom/LocalMediaStream.cpp:

(WebCore::LocalMediaStream::interfaceName):

dom/LocalMediaStream.h:
dom/MediaStream.cpp:

(WebCore::MediaStream::interfaceName):

dom/MediaStream.h:
dom/MessagePort.cpp:

(WebCore::MessagePort::interfaceName):

dom/MessagePort.h:
dom/Node.cpp:

(WebCore::Node::toNode):
(WebCore::Node::interfaceName):

dom/Node.h:
dom/make_event_factory.pl:
- Generalize make_event_factory.pl to be able to generate interfaces for different namespaces.
fileapi/FileReader.cpp:

(WebCore::FileReader::interfaceName):

fileapi/FileReader.h:
fileapi/FileWriter.cpp:

(WebCore::FileWriter::interfaceName):

fileapi/FileWriter.h:
loader/appcache/DOMApplicationCache.cpp:

(WebCore::DOMApplicationCache::interfaceName):

loader/appcache/DOMApplicationCache.h:
notifications/Notification.cpp:

(WebCore::Notification::interfaceName):

notifications/Notification.h:

(WebCore::Notification::scriptExecutionContext):

p2p/PeerConnection.cpp:

(WebCore::PeerConnection::interfaceName):

p2p/PeerConnection.h:
page/DOMWindow.cpp:

(WebCore::DOMWindow::interfaceName):
(WebCore::DOMWindow::toDOMWindow):

page/DOMWindow.h:
page/EventSource.cpp:

(WebCore::EventSource::interfaceName):

page/EventSource.h:
storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::interfaceName):

storage/IDBDatabase.h:
storage/IDBRequest.cpp:

(WebCore::IDBRequest::interfaceName):

storage/IDBRequest.h:
storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::interfaceName):

storage/IDBTransaction.h:
storage/IDBVersionChangeRequest.cpp:

(WebCore::IDBVersionChangeRequest::interfaceName):

storage/IDBVersionChangeRequest.h:
svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::interfaceName):

svg/SVGElementInstance.h:

(WebCore::SVGElementInstance::toNode):

webaudio/AudioContext.cpp:

(WebCore::AudioContext::interfaceName):
(WebCore::AudioContext::scriptExecutionContext):

webaudio/AudioContext.h:
webaudio/JavaScriptAudioNode.cpp:

(WebCore::JavaScriptAudioNode::interfaceName):

webaudio/JavaScriptAudioNode.h:
websockets/WebSocket.cpp:

(WebCore::WebSocket::interfaceName):

websockets/WebSocket.h:
workers/DedicatedWorkerContext.cpp:

(WebCore::DedicatedWorkerContext::interfaceName):

workers/DedicatedWorkerContext.h:
workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerConnectTask::performTask):

workers/SharedWorker.cpp:

(WebCore::SharedWorker::interfaceName):

workers/SharedWorker.h:
workers/SharedWorkerContext.cpp:

(WebCore::SharedWorkerContext::interfaceName):

workers/SharedWorkerContext.h:
workers/Worker.cpp:

(WebCore::Worker::interfaceName):

workers/Worker.h:
xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::interfaceName):

xml/XMLHttpRequest.h:
xml/XMLHttpRequestUpload.cpp:

(WebCore::XMLHttpRequestUpload::interfaceName):

xml/XMLHttpRequestUpload.h:

Source/WebKit/chromium:

This cast isn't needed because dispatchEvent is a virtual function.

src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::connectTask):

1:42 PM Changeset in webkit [98387] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] DRT: Force layout when sending events.
https://bugs.webkit.org/show_bug.cgi?id=70357

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-25
Reviewed by Antonio Gomes.

Some tests such as editing/input/page-up-down-scrolls.html rely on the
scrollbars being properly set up during the onload events.
Document::implicitClose(), however, dispatches the onload events before
calling FrameView::layout(), so these tests usually fail.

We now do the same as the GTK+ and Chromium ports and manually force the
layout when dispatching events.

DumpRenderTree/efl/EventSender.cpp:

(sendMouseEvent):
(keyDownCallback):

1:38 PM Changeset in webkit [98386] by weinig@apple.com

2 edits in trunk/Source/WebKit2

Make loadFileURL:restrictToFilesWithin: work, albeit, without the correct
restrictions for now.

Reviewed by Anders Carlsson.

UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:]):

1:36 PM Changeset in webkit [98385] by podivilov@chromium.org

5 edits in trunk/Source/WebCore

Fix several minor problems in idls.
https://bugs.webkit.org/show_bug.cgi?id=70811

Reviewed by Adam Barth.

This patch does not have any effect on generated bindings.

dom/DataTransferItems.idl:
page/History.idl:
storage/IDBIndex.idl:
xml/XMLHttpRequest.idl:

1:30 PM Changeset in webkit [98384] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] WebGraphicsContext3D setVisibilityCHROMIUM extension changed to pure virtual.
https://bugs.webkit.org/show_bug.cgi?id=70818

Patch by Michal Mocny <mmocny@google.com> on 2011-10-25
Reviewed by Kenneth Russell.

public/WebGraphicsContext3D.h:

1:23 PM Changeset in webkit [98383] by mhahnenberg@apple.com

2 edits in trunk/Source/JavaScriptCore

Fixing Windows build after r98367

Unreviewed build fix

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

1:22 PM Changeset in webkit [98382] by leandro@webkit.org

1 edit
106 adds in trunk/LayoutTests

[EFL] Unreviewed. Add CSS1 pixel baselines.

platform/efl/css1: [...]

1:01 PM Changeset in webkit [98381] by commit-queue@webkit.org

9 edits
2 adds in trunk/Source/WebKit/chromium

Make it possible to create and dispatch a message event through chromium API

Removed messageChannels parameter, since it's hard to get right and I don't need it. Changed message_data->messageData. Reordered includes.

https://bugs.webkit.org/show_bug.cgi?id=69962

Patch by Dave Michael <dmichael@chromium.org> on 2011-10-25
Reviewed by David Levin.

WebKit.gyp:
public/WebDOMEvent.h:
public/WebDOMMessageEvent.h: Added.
public/WebDocument.h:
public/WebNode.h:
src/PlatformMessagePortChannel.cpp:

(WebCore::PlatformMessagePortChannel::hasPendingActivity):

src/WebDOMEvent.cpp:

(WebKit::WebDOMEvent::operator WTF::PassRefPtr<WebCore::Event>):

src/WebDOMMessageEvent.cpp: Added.

(WebKit::WebDOMMessageEvent::initMessageEvent):

src/WebDocument.cpp:

(WebKit::WebDocument::createEvent):

src/WebNode.cpp:

(WebKit::WebNode::dispatchEvent):

12:50 PM Changeset in webkit [98380] by Nate Chapin

18 edits in trunk

Source/WebCore: Make DocumentThreadableLoader a CachedResourceClient.
This will allow us to cache ThreadableLoaderClients as
appropriate in a later patch.
https://bugs.webkit.org/show_bug.cgi?id=61225

Reviewed by Antti Koivisto.

No new tests, no functionality change intended.

WebCore.gypi:
loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::notifyFinished): CachedResourceClients don't send separate callbacks

for didFail() and didFinishLoading(), so we need to differentiate here.

(WebCore::DocumentThreadableLoader::loadRequest): Call CachedResourceLoader::requestRawResource()

instead of ResourceLoadScheduler::scheduleSubresourceLoad().

loader/DocumentThreadableLoader.h:
loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::data): Handle the complexity of some ThreadableLoaderClients setting

DoNotBufferData in ResoureLoaderOptions. If the DataBufferingPolicy is BufferData, then the
'data' input parameter will contain all data received so far, and we need to determine the
incremental data to forward to the clients. If the policy is DoNotBufferData, 'data' is just
the incremental data.

loader/cache/CachedRawResource.h:
loader/cache/CachedResource.cpp:
loader/cache/CachedResource.h:

(WebCore::CachedResource::preloadResult):
(WebCore::CachedResource::didSendData):
(WebCore::CachedResource::didDownloadData):
(WebCore::CachedResource::setLoadFinishTime):
(WebCore::CachedResource::loadFinishTime):

loader/cache/CachedResourceClient.h: Add several new callbacks needed by DocumentThreadableLoader.
loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveResponse): CachedResource::setResponse() can now cancel

the request, so protect appropriately.

loader/cache/CachedResourceRequest.h:
loader/chromium/CachedRawResourceChromium.cpp: Added (plumb didDownloadData() to DocumentThreadableLoader).
loader/chromium/CachedResourceRequestChromium.cpp: Added (plumb didDownloadData() to DocumentThreadableLoader).
loader/chromium/DocumentThreadableLoaderChromium.cpp:
platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::notifyResponse): Protect before setting response, since it might kill us.

LayoutTests: Test update for https://bugs.webkit.org/show_bug.cgi?id=61225.
Due to changes in the implementation of DocumentThreadableLoader (and
therefore XHR), this test will have empty (rather than null) content
if we go over the length limit.

Reviewed by Antti Koivisto.

http/tests/inspector/network/network-content-replacement-xhr-expected.txt:

12:48 PM Changeset in webkit [98379] by abarth@webkit.org

8 edits in trunk

Get rid of optional parameters in the middle in IDLs.
https://bugs.webkit.org/show_bug.cgi?id=70816

Patch by Pavel Podivilov <podivilov@chromium.org> on 2011-10-25
Reviewed by Adam Barth.

Optional parameters in the middle are prohibited by WebIDL spec.

Source/WebCore:

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateArgumentsCountCheck):
(GenerateImplementation):

html/canvas/CanvasRenderingContext2D.idl:
page/DOMWindow.idl:

LayoutTests:

fast/canvas/canvas-putImageData-expected.txt:
fast/canvas/canvas-putImageData.js:

12:45 PM Changeset in webkit [98378] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/efl

[EFL] Add function to get geometry of focused element
https://bugs.webkit.org/show_bug.cgi?id=70728

Patch by Ivan Briano <ivan@profusion.mobi> on 2011-10-25
Reviewed by Antonio Gomes.

Added function to ewk_frame to get the geometry of the focused
element within the frame object.

ewk/ewk_frame.cpp:

(ewk_frame_focused_element_geometry_get): Retrieves the geometry of
the focused element within the given frame object.

ewk/ewk_frame.h:

12:37 PM Changeset in webkit [98377] by dbates@webkit.org

2 edits in trunk/Tools

build-webkit --clean should only clean build directory for CMake-based ports
https://bugs.webkit.org/show_bug.cgi?id=70834

Reviewed by Antonio Gomes.

Currently build-webkit --clean both cleans the build directory and builds WebKit for
CMake-based ports. Instead, build-webkit --clean should only clean up the build directory
as per its description in the usage message of build-webkit.

Scripts/webkitdirs.pm:

(buildCMakeProjectOrExit):

12:32 PM Changeset in webkit [98376] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/efl

[EFL] Add necessary information for callback instropection
https://bugs.webkit.org/show_bug.cgi?id=70735

Patch by Ivan Briano <ivan@profusion.mobi> on 2011-10-25
Reviewed by Antonio Gomes.

Provide the information about smart callbacks emitted by the ewk_view
object, so that these can be easily forwarded by other objects or used
by bindings in other languages without having to keep track of all of
them manually.

ewk/ewk_view.cpp:

(ewk_view_base_smart_set):

12:31 PM Changeset in webkit [98375] by jchaffraix@webkit.org

2 edits in trunk/LayoutTests

Unreviewed gardening.

platform/chromium/test_expectations.txt: Marking a test as timing

out.

12:28 PM Changeset in webkit [98374] by cevans@google.com

2 edits in trunk/Source/WebCore

Manage the CSS property array length correctly
https://bugs.webkit.org/show_bug.cgi?id=70783

Reviewed by Adam Barth.

css/CSSParser.cpp:

(WebCore::CSSParser::addProperty): don't allow max length to get out of sync with the buffer.

12:26 PM Changeset in webkit [98373] by tony@chromium.org

3 edits in trunk/Source/WebCore

avoid unnecessary layouts of flex items during the flex pass
https://bugs.webkit.org/show_bug.cgi?id=70557

Reviewed by Ojan Vafai.

If the preferred size of a flex item is provided, we don't need to
layout the flex item when computing the preferred size. This allows
us to only call layout on each flex item once in the common case.

No new tests, covered by existing tests.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::flowAwareLogicalWidthLengthForChild):
(WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):

rendering/RenderFlexibleBox.h:

12:12 PM UsingGitWithWebKit edited by jberlin@webkit.org

Add instructions for how to tell git to ignore "changes" by file … (diff)

12:10 PM Changeset in webkit [98372] by fsamuel@chromium.org

5 edits
6 adds in trunk

Crash in WebCore::RenderTableSection::addChild due to assert failure
https://bugs.webkit.org/show_bug.cgi?id=70678

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/table-anonymous-cell-bug.html

fast/table/table-anonymous-row-bug.html
fast/table/table-anonymous-section-bug.html

If the child being added is not a Section/Row/Cell, and the previous sibling is not anonymous,
we need to create a new anonymous Section/Row/Cell respectively, instead of failing an
assert.

rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):

rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::addChild):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild):

LayoutTests:

If the child being added is not a Section/Row/Cell, and the previous sibling is not anonymous,
we need to create a new anonymous Section/Row/Cell respectively, instead of failing an
assert.

fast/table/table-anonymous-cell-bug-expected.txt: Added.
fast/table/table-anonymous-cell-bug.html: Added.
fast/table/table-anonymous-row-bug-expected.txt: Added.
fast/table/table-anonymous-row-bug.html: Added.
fast/table/table-anonymous-section-bug-expected.txt: Added.
fast/table/table-anonymous-section-bug.html: Added.

12:10 PM Changeset in webkit [98371] by leviw@chromium.org

1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp

Fixing false assertion and correcting unrounded values for adjusting height and offset for floats.

12:05 PM Changeset in webkit [98370] by leviw@chromium.org

2 edits
3 copies in branches/chromium/912

Merge 98263 - <svg> fails to use explicit width and height inside <html> inside IFRAME
https://bugs.webkit.org/show_bug.cgi?id=64823

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Checking that embedded SVG is in an SVG document before negotiating size
with the host document.

Test: svg/as-object/svg-embedded-in-html-in-iframe.html

rendering/svg/RenderSVGRoot.cpp:

(WebCore::isEmbeddedThroughFrameContainingSVGDocument):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

LayoutTests:

Fixing a bug where SVG negotiated size when embedded in html inside an iframe.

platform/chromium/test_expectations.txt: Will update with results on other platforms.
platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
svg/as-object/svg-embedded-in-html-in-iframe.html: Added.

TBR=leviw@chromium.org
Review URL: http://codereview.chromium.org/8390012

12:01 PM Changeset in webkit [98369] by andersca@apple.com

10 edits in trunk/Source/WebKit2

PDF SUBFRAMES: Incomplete repaint after pinch to zoom
https://bugs.webkit.org/show_bug.cgi?id=70821
<rdar://problem/10312733>

Reviewed by Simon Fraser.

Add a new pure virtual member function, Plugin::wantsWindowRelativeCoordinates.
If a plug-in subclass returns true, we'll keep giving the plug-in coordinates that
are relative to the containing window. If a plug-in subclass returns false, we'll give it
coordinates in a much more sane coordinate system, with the origin at the top left corner of the plug-in.

Change BuiltinPDFView to return false so that it'll work correctly with pinch to zoom.

WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::wantsWindowRelativeCoordinates):
Make wantsWindowRelativeCoordinates return true.

WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::paint):
Remove translation since the graphics context is already set up in the right way.

(WebKit::BuiltInPDFView::paintContent):
No need to offset by the plug-in view location anymore.

(WebKit::BuiltInPDFView::paintControls):
Account for the scrollbars being children of the parent scroll view here.

(WebKit::BuiltInPDFView::wantsWindowRelativeCoordinates):
Return false.

(WebKit::BuiltInPDFView::convertFromContainingViewToScrollbar):
Implement this so that scrollbar hit testing works correctly.

WebProcess/Plugins/Plugin.h:

Add wantsWindowRelativeCoordinates.

WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::wantsWindowRelativeCoordinates):
Return true for now.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::renderer):
Add simple getter.

(WebKit::PluginView::paint):
Handle the case when the plug-in doesn't want window relative coordinates.

(WebKit::PluginView::transformsAffectFrameRect):
Return true here.

(WebKit::PluginView::viewGeometryDidChange):
No need to adjust the bounds to account for the scale factor now, since the frame rect will always be the
same regardless of the transform.

(WebKit::PluginView::clipRectInWindowCoordinates):
Ditto.

11:59 AM Changeset in webkit [98368] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

Add missing DFG file entries to the make lists for GTK and Qt ports
https://bugs.webkit.org/show_bug.cgi?id=70806

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-25
Reviewed by Darin Adler.

GNUmakefile.list.am:
JavaScriptCore.pro:

11:51 AM Changeset in webkit [98367] by mhahnenberg@apple.com

6 edits in trunk/Source

Add getOwnPropertySlot to MethodTable
https://bugs.webkit.org/show_bug.cgi?id=69807

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

JavaScriptCore.exp:
runtime/ClassInfo.h: Added both versions of getOwnPropertySlot to the MethodTable.
runtime/JSCell.h: Changed getOwnPropertySlot to be protected so other classes can

reference it in their MethodTables.

Source/WebCore:

No new tests.

bridge/runtime_method.h: Changed getOwnPropertySlot to be protected so

subclasses can reference it in their MethodTables.

11:24 AM Changeset in webkit [98366] by zherczeg@webkit.org

3 edits in trunk/LayoutTests

Add new uri tokenizer tests
https://bugs.webkit.org/show_bug.cgi?id=70807

Reviewed by Darin Adler.

Test more cases!

fast/css/uri-token-parsing-expected.txt:
fast/css/uri-token-parsing.html:

11:17 AM Changeset in webkit [98365] by oliver@apple.com

4 edits in trunk/Source/JavaScriptCore

Need to support marking of multiple nested codeblocks when compiling
https://bugs.webkit.org/show_bug.cgi?id=70832

Reviewed by Gavin Barraclough.

When inlining a function we end up with multiple codeblocks being
compiled at the same time, so we need to support a list of live
codeblocks.

heap/Heap.cpp:

(JSC::Heap::markRoots):

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

runtime/JSGlobalData.h:

(JSC::JSGlobalData::startedCompiling):
(JSC::JSGlobalData::finishedCompiling):

11:10 AM Changeset in webkit [98364] by jchaffraix@webkit.org

1 edit
1 delete in trunk/LayoutTests

Unreviewed gardening.

The old rebaseline looked wrong and did not match the other baselines. This is now corrected.

platform/chromium-cg-mac-leopard/fast/backgrounds/background-leakage-transforms-expected.png: Removed.

11:06 AM Changeset in webkit [98363] by jchaffraix@webkit.org

1 edit
1 add
6 deletes in trunk/LayoutTests

Unreviewed gardening.

Partial rebaselining of fast/css/focus-ring-multiline-writingmode-vertical.html as it looks like it progressed
on some platforms.

platform/chromium-cg-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
platform/chromium-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Removed.
platform/chromium/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.

10:54 AM Changeset in webkit [98362] by sullivan@apple.com

2 edits in trunk/Source/WebKit2

"Open with" item missing from PDF context menu in some cases
https://bugs.webkit.org/show_bug.cgi?id=70828
<rdar://problem/10034302>

Reviewed by Anders Carlsson.

UIProcess/API/mac/PDFViewController.mm:

(insertOpenWithDefaultPDFMenuItem):
New helper function, extracted from -menuForEvent:. Identical to original code except
that it inserts the item at a specified index, rather than always at the end.
(-[WKPDFView menuForEvent:]):
Now keeps track of whether the Open With item has been inserted while iterating through
the PDFKit-supplied menu items looking for a "Copy" item. If a "Copy" item is not found,
inserts the Open With item at the top of the context menu.

10:54 AM Changeset in webkit [98361] by Simon Fraser

8 edits
9 adds
2 deletes in trunk

REGRESSION (r88580): Cursor fails to change to pointer on embedded Google maps popups
https://bugs.webkit.org/show_bug.cgi?id=62797

Source/WebCore:

Reviewed by Chris Marrin.

When hit testing through transformed layers, RenderLayer would simply use
the composited bounds of the layer as the localHitTestRect for hit testing sublayers.
However, this broke hit testing on pages that have a composited, non-transformed layer
which falls outside the bounds of its parent, composited-transformed layer, like Google
Maps.

Fix by mapping the hitTestRect through transforms. However this is tricky, because
mapping a rect into the coordinate system of a layer can result in invalid rectangles
when point projection results in a negative w component. Fix TransformationMatrix::projectPoint()
to detect this case and replace X and Y with large values, and add boundsOfProjectedQuad(), which
maps rectangles with possibly-infinite location or bounds into rects which are representable
in an IntRect.

Tests: transforms/3d/hit-testing/composited-hit-test.html

transforms/3d/hit-testing/rotated-hit-test-with-child.html
transforms/3d/hit-testing/rotated-hit-test2.html

platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::projectPoint):
(WebCore::TransformationMatrix::projectQuad):
(WebCore::clampEdgeValue):
(WebCore::TransformationMatrix::boundsOfProjectedQuad):

platform/graphics/transforms/TransformationMatrix.h:
rendering/HitTestingTransformState.cpp:

(WebCore::HitTestingTransformState::boundsOfMappedQuad):

rendering/HitTestingTransformState.h:
rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTestLayer):

LayoutTests:

Reviewed by Chris Marrin.

New tests for hit testing through various configurations of 3D transforms.

platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.png: Removed.
platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.txt: Removed.
transforms/3d/hit-testing/composited-hit-test-expected.txt: Added.
transforms/3d/hit-testing/composited-hit-test.html: Added.
transforms/3d/hit-testing/resources/hit-test-utils.js: Added.
transforms/3d/hit-testing/rotated-hit-test-expected.txt: Added.
transforms/3d/hit-testing/rotated-hit-test-with-child-expected.txt: Added.
transforms/3d/hit-testing/rotated-hit-test-with-child.html: Added.
transforms/3d/hit-testing/rotated-hit-test.html:
transforms/3d/hit-testing/rotated-hit-test2-expected.txt: Added.
transforms/3d/hit-testing/rotated-hit-test2.html: Added.

10:44 AM Changeset in webkit [98360] by enne@google.com

16 edits
2 adds in trunk/Source/WebCore

[chromium] Batch up texture uploads so that they can be updated incrementally
https://bugs.webkit.org/show_bug.cgi?id=70454

Reviewed by James Robinson.

Because texture uploads can sometimes take more than a frame to
complete, collect all the uploads that need to occur in a
CCTextureUpdater so that we can easily incrementally upload some of
them, interleaving input and drawing so that the compositor thread
continues to appear responsive during a commit.

This change doesn't actually interleave the commits, it just pushes
the infrastructure for doing so up to the CCProxy level so that a
future scheduler can make this decision.

VideoLayerChromium is the only layer type to not use this system. It
needs to be converted to use a texture updater first and it is less of
a priority than the tiled layers.

WebCore.gypi:
platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

platform/graphics/chromium/Canvas2DLayerChromium.h:
platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::updateCompositorResources):

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateCompositorResources):

platform/graphics/chromium/TiledLayerChromium.h:
platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::updateCompositorResources):

platform/graphics/chromium/VideoLayerChromium.h:
platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::updateCompositorResources):

platform/graphics/chromium/WebGLLayerChromium.h:
platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::updateCompositorResources):

platform/graphics/chromium/cc/CCLayerTreeHost.h:
platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

platform/graphics/chromium/cc/CCSingleThreadProxy.h:
platform/graphics/chromium/cc/CCTextureUpdater.cpp: Added.

(WebCore::CCTextureUpdater::CCTextureUpdater):
(WebCore::CCTextureUpdater::~CCTextureUpdater):
(WebCore::CCTextureUpdater::append):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):

platform/graphics/chromium/cc/CCTextureUpdater.h: Added.

(WebCore::CCTextureUpdater::allocator):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::commitOnImplThread):

10:42 AM Changeset in webkit [98359] by jer.noble@apple.com

7 edits in trunk

compositing/video tests time out on Lion
https://bugs.webkit.org/show_bug.cgi?id=70448

Reviewed by Simon Fraser.

Source/WebCore:

AVFoundation will not begin loading or decoding media until a consumer for that media is present.
For video-only media, this means that an AVPlayerLayer must be created and attached to the
AVPlayer before the load state will ever reach "canPlayThrough". Once the metadata for a media
is loaded, create a AVPlayerLayer if the media has a video track.

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::updateStates):

LayoutTests:

compositing/video/video-poster.html: Seek, instead of play, to trigger

creation of a layer

http/tests/media/video-load-twice.html: Use waitForEventOnce so that

canPlayThrough listener is triggered only once.

media/video-test.js: Add a new function, waitForEventOnce.

(waitForEventOnce):
(waitForEvent._eventCallback):
(waitForEvent):

10:22 AM Changeset in webkit [98358] by rniwa@webkit.org

3 edits in trunk/Source/WebCore

Merge endOfLine with logicalEndOfLine and startOfLine with logicalStartOfLine
https://bugs.webkit.org/show_bug.cgi?id=70755

Reviewed by Chang Shu.

Merged endOfLine with logicalEndOfLine, and startOfLine with logicalStartOfLine
to reduce the code duplication.

editing/visible_units.cpp:

(WebCore::startPositionForLine):
(WebCore::startOfLine):
(WebCore::logicalStartOfLine):
(WebCore::endPositionForLine):
(WebCore::inSameLogicalLine):
(WebCore::endOfLine):
(WebCore::logicalEndOfLine):

editing/visible_units.h:

10:22 AM Changeset in webkit [98357] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Re-enable touch tests (from 66577)
https://bugs.webkit.org/show_bug.cgi?id=70351

Patch by Gene Girard <girard@chromium.org> on 2011-10-25
Reviewed by Adam Barth.

tests/InnerGestureRecognizerTest.cpp:

(TEST_F):

10:18 AM Changeset in webkit [98356] by nduca@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

DEPS:

10:17 AM Changeset in webkit [98355] by caryclark@google.com

1 edit
742 adds in trunk/LayoutTests

Unreviewed gardening: fifth chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 736 of 742 files for brevity.]

platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png: Added.
platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png: Added.
platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-4-expected.png: Added.

...

platform/chromium-mac-leopard/transitions: Added.
platform/chromium-mac-leopard/transitions/default-timing-function-expected.png: Added.
platform/chromium-mac-leopard/transitions/svg-text-shadow-transition-expected.png: Added.

10:04 AM Changeset in webkit [98354] by annacc@chromium.org

2 edits in trunk/Tools

Enable running of track layout tests for Chromium
https://bugs.webkit.org/show_bug.cgi?id=70803

Reviewed by Adam Barth.

Make DumpRenderTree/TestShell always run with track enabled
(equivalent of --enable-video-track).

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

9:53 AM Changeset in webkit [98353] by commit-queue@webkit.org

9 edits
6 adds in trunk

Source/WebCore: Microdata: itemtype attribute should be space-separated list to allow multiple types.
https://bugs.webkit.org/show_bug.cgi?id=70501

Patch by Arko Saha <arko@motorola.com> on 2011-10-25
Reviewed by Ryosuke Niwa.

Tests: fast/dom/MicroData/getitems-multiple-itemtypes.html

fast/dom/MicroData/itemtype-add-remove-tokens.html
fast/dom/MicroData/itemtype-attribute-test.html

dom/MicroDataItemList.cpp:

(WebCore::MicroDataItemList::nodeMatches):

html/DOMSettableTokenList.h:

(WebCore::DOMSettableTokenList::tokens):

html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::setItemValueText):
(WebCore::HTMLElement::itemType):
(WebCore::HTMLElement::setItemType):

html/HTMLElement.h:
html/HTMLElement.idl:

LayoutTests: Microdata: itemtype attribute should be space-separated list to allow multiple types
https://bugs.webkit.org/show_bug.cgi?id=70501

Patch by Arko Saha <arko@motorola.com> on 2011-10-25
Reviewed by Ryosuke Niwa.

fast/dom/MicroData/006.html:
fast/dom/MicroData/007.html:
fast/dom/MicroData/getitems-multiple-itemtypes-expected.txt: Added.
fast/dom/MicroData/getitems-multiple-itemtypes.html: Added.
fast/dom/MicroData/itemtype-add-remove-tokens-expected.txt: Added.
fast/dom/MicroData/itemtype-add-remove-tokens.html: Added.
fast/dom/MicroData/itemtype-attribute-test-expected.txt: Added.
fast/dom/MicroData/itemtype-attribute-test.html: Added.

9:52 AM Changeset in webkit [98352] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/gtk

[GTK] GtkAdjustment watcher updates adjustments too lazily
https://bugs.webkit.org/show_bug.cgi?id=70180

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-10-25
Reviewed by Gustavo Noronha Silva.

Increase the priority of the GtkAdjustments update in GtkAdjustmentWatcher. This
means that adjustments will more quickly represent the state of the WebKitWebView
when it scrolls. This fixes out-of-sync scrollbars and some visual artifacts.

WebCoreSupport/GtkAdjustmentWatcher.cpp:

(WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater): Use a timeout
with the default priority.

9:40 AM Changeset in webkit [98351] by commit-queue@webkit.org

2 edits in trunk/Tools

[WK2]Main window never gets focus using TAB key in WebKit2 GTK+.
https://bugs.webkit.org/show_bug.cgi?id=70603

Patch by Vamshikrishna Yellenki <vamshi@motorola.com> on 2011-10-25
Reviewed by Gustavo Noronha Silva.

MiniBrowser/gtk/BrowserWindow.c:

(focus):
(unFocus):
(browserWindowUIClientInit):

9:39 AM Changeset in webkit [98350] by mitz@apple.com

4 edits in trunk

<rdar://problem/10337033> DOMRangeOfString:relativeTo:options has problems with -webkit-user-select: none

Reviewed by Adam Roben.

Source/WebCore:

Test: added to TestWebKitAPI/Tests/mac/DOMRangeOfString.mm

page/Page.cpp:

(WebCore::Page::rangeOfString): This function was incorrectly adding the StartInSelection option to
the initial search.

Tools:

TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:

(TestWebKitAPI::TEST):

9:26 AM Changeset in webkit [98349] by caryclark@google.com

1 edit
734 adds in trunk/LayoutTests

Unreviewed gardening: fourth chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 728 of 734 files for brevity.]

platform/chromium-mac-leopard/fast/lists/ordered-list-with-no-ol-tag-expected.png: Added.
platform/chromium-mac-leopard/fast/lists/scrolled-marker-paint-expected.png: Added.
platform/chromium-mac-leopard/fast/media: Added.

...

platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tref-01-b-expected.png: Added.
platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Added.
platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png: Added.

8:35 AM Changeset in webkit [98348] by yurys@chromium.org

13 edits in trunk

Web Inspector: redesign workers sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=70815

Source/WebCore:

Changed workers sidebar pane design.

Now there is a link to worker inspector for each dedicated worker created
by inspected page. The sidebar display a link to a page with list of all
shared workers if there one is supported by the WebKit port. Also there
is a checkbox that allows pause all new workers on first statements.

Reviewed by Pavel Feldman.

inspector/front-end/Settings.js:
inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):

inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.prototype.openWorkerInspector):
(WebInspector.WorkerManager.prototype._workerInspectorClosing):

inspector/front-end/WorkersSidebarPane.js:

(WebInspector.WorkerListSidebarPane):
(WebInspector.WorkerListSidebarPane.prototype._workerRemoved):
(WebInspector.WorkerListSidebarPane.prototype._workersCleared):
(WebInspector.WorkerListSidebarPane.prototype._addWorker):
(WebInspector.WorkerListSidebarPane.prototype._workerItemClicked):
(WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):
(WebInspector.WorkerListSidebarPane.prototype._createSharedWorkersLink.link.onclick):
(WebInspector.WorkerListSidebarPane.prototype._createSharedWorkersLink):

inspector/front-end/elementsPanel.css:
inspector/front-end/inspectorCommon.css:

(.sidebar-separator):
(.sidebar-label):

inspector/front-end/scriptsPanel.css:

(.dedicated-worker-item):
(#shared-workers-list):
(#pause-workers-checkbox > input):

Source/WebKit/chromium:

Reviewed by Pavel Feldman.

src/js/DevTools.js: Expose link to shared workers inspection page to WebCore.

():

LayoutTests:

Update tests in accord with change of class name from
styles-sidebar-pane to sidebar-pane.

Reviewed by Pavel Feldman.

http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles):

8:21 AM Changeset in webkit [98347] by thakis@chromium.org

4 edits in trunk/Source

Source/WebCore: [chromium/mac] Fix an ODR violation.
https://bugs.webkit.org/show_bug.cgi?id=70753

Reviewed by Anders Carlsson.

Both ScrollAnimatorNone and ScrollAnimatorMac define ScrollAnimator::create() on OS X.
Remove the unused one.

WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium: [chromium] Try to fix mac build after r98294
https://bugs.webkit.org/show_bug.cgi?id=70753

Remove test for ScrollAnimatorNone on mac.

Unreviewed, build fix.

WebKit.gypi:

8:06 AM Changeset in webkit [98346] by vsevik@chromium.org

4 edits
2 adds in trunk

Web Inspector: Debugger fails when there is an invalid watch expression.
https://bugs.webkit.org/show_bug.cgi?id=70718

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/watch-expressions-panel-switch.html

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):

LayoutTests:

inspector/debugger/error-in-watch-expressions.html:
inspector/debugger/watch-expressions-panel-switch-expected.txt: Added.
inspector/debugger/watch-expressions-panel-switch.html: Added.

7:26 AM Changeset in webkit [98345] by podivilov@chromium.org

5 edits in trunk

Web Inspector: fix empty line handling in source maps.
https://bugs.webkit.org/show_bug.cgi?id=70726

Reviewed by Yury Semikhatsky.

Source/WebCore:

inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):

LayoutTests:

inspector/debugger/compiler-source-mapping-expected.txt:
inspector/debugger/compiler-source-mapping.html:

7:24 AM Changeset in webkit [98344] by jschuh@chromium.org

3 edits
2 adds in trunk

Check for empty string in parseArcFlag
https://bugs.webkit.org/show_bug.cgi?id=70763

Reviewed by Dirk Schulze.

Source/WebCore:

Test: svg/path-invalid.html

svg/SVGParserUtilities.cpp:

(WebCore::parseArcFlag):

LayoutTests:

svg/path-arc-invalid-expected.txt: Added.
svg/path-arc-invalid.html: Added.

7:22 AM Changeset in webkit [98343] by podivilov@chromium.org

5 edits in trunk

Web Inspector: keep old source mapping when new one could not be loaded.
https://bugs.webkit.org/show_bug.cgi?id=70729

Reviewed by Yury Semikhatsky.

Source/WebCore:

inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
(WebInspector.RawSourceCode.prototype._updateSourceMapping):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didLoadSourceMapping):

LayoutTests:

inspector/debugger/raw-source-code-expected.txt:
inspector/debugger/raw-source-code.html:

7:04 AM Changeset in webkit [98342] by commit-queue@webkit.org

9 edits
2 adds in trunk

Double number step=.5 should be considered valid in <input type="number" step=".5">
https://bugs.webkit.org/show_bug.cgi?id=70320

Patch by Sachin Puranik <sachin.puranik@motorola.com> on 2011-10-25
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/input-step-as-double.html

html/parser/HTMLParserIdioms.cpp:

(WebCore::parseToDoubleForNumberType): Changed the function to consider
step as valid even if it starts with "."

LayoutTests:

fast/forms/ValidityState-typeMismatch-number-expected.txt: Change in result of layout test.
fast/forms/input-step-as-double-expected.txt: Added, expected output for new test case.
fast/forms/input-step-as-double.html: Added, testcase to make sure that all ports

consider .5 as a valid double value for step attribute of input element.

fast/forms/input-valueasnumber-number-expected.txt: Change in result of layout test.
fast/forms/range/input-valueasnumber-range-expected.txt: Change in result of layout test.
fast/forms/range/input-valueasnumber-range.html: Consider .2 as valid real number now.
fast/forms/script-tests/ValidityState-typeMismatch-number.js: Consider

.2 as valid real number now.

fast/forms/script-tests/input-valueasnumber-number.js: Consider .2 as valid real number now.

6:57 AM Changeset in webkit [98341] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] Audits panel context menu for links not working properly
https://bugs.webkit.org/show_bug.cgi?id=70813

Reviewed by Pavel Feldman.

inspector/front-end/AuditResultView.js:

(WebInspector.AuditResultView):
(WebInspector.AuditResultView.prototype._contextMenuEventFired):

6:49 AM Changeset in webkit [98340] by eric@webkit.org

3 edits in trunk/Tools

WIN: editing tests fail under NRWT because editing delegate callbacks aren't stripped
https://bugs.webkit.org/show_bug.cgi?id=64471

Reviewed by Adam Roben.

Speculative fix.

Scripts/webkitpy/layout_tests/port/win.py:
Scripts/webkitpy/layout_tests/port/win_unittest.py:

6:49 AM Changeset in webkit [98339] by vsevik@chromium.org

4 edits
2 adds in trunk

Web Inspector: Resources panel: display the current search match index in the toolbar.
https://bugs.webkit.org/show_bug.cgi?id=66050

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/search/resources-search-match-index.html

inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.performSearch.callback):
(WebInspector.ResourcesPanel.prototype.performSearch):
(WebInspector.ResourcesPanel.prototype._showSearchResult.callback):
(WebInspector.ResourcesPanel.prototype._showSearchResult):
(WebInspector.BaseStorageTreeElement.prototype.get searchMatchesCount):
(WebInspector.ResourcesSearchController):
(WebInspector.ResourcesSearchController.prototype.nextSearchResult):
(WebInspector.ResourcesSearchController.prototype.previousSearchResult):
(WebInspector.ResourcesSearchController.prototype._searchResult):
(WebInspector.SearchResultsTreeElementsTraverser.prototype.next):
(WebInspector.SearchResultsTreeElementsTraverser.prototype.previous):
(WebInspector.SearchResultsTreeElementsTraverser.prototype.matchIndex):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._elementSearchMatchesCount):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traverseNext):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traversePrevious):

inspector/front-end/treeoutline.js:

LayoutTests:

http/tests/inspector/search/resources-search-match-index-expected.txt: Added.
http/tests/inspector/search/resources-search-match-index.html: Added.

6:45 AM Changeset in webkit [98338] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

inspector/cookie-parser.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=62662

platform/qt/Skipped: Skip one more test because of this bug: inspector/evaluate-in-page.html.

6:38 AM Changeset in webkit [98337] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[Qt][WK2] QDesktopWebView and QTouchWebView should be declared in the meta type system.
https://bugs.webkit.org/show_bug.cgi?id=70693

This change allows us to use the template based features of the meta type system
such as using the WebView classes as types for QVariant.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-25
Reviewed by Simon Hausmann.

UIProcess/API/qt/qdesktopwebview.h:
UIProcess/API/qt/qtouchwebview.h:

6:17 AM Changeset in webkit [98336] by vsevik@chromium.org

9 edits in branches/chromium/912/Source/WebCore

Merge 98105 - Web Inspector: Advanced search is working very slowly and does not show searching progress.
https://bugs.webkit.org/show_bug.cgi?id=70611

Search implementation changed so that we do not start searching in the next file unless
the previous one was already searched. This allows to interrupt search.
Not all search matches are added on UI by default now, only first 20 for each file.
Search progress information and search stop button were added to drawer status bar.

Reviewed by Pavel Feldman.

English.lproj/localizedStrings.js:
inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines):
(WebCore::ContentSearchUtils::countRegularExpressionMatches):

inspector/front-end/AdvancedSearchController.js:

(WebInspector.AdvancedSearchController.prototype._onSearchResult):
(WebInspector.AdvancedSearchController.prototype._onSearchFinished):
(WebInspector.AdvancedSearchController.prototype.startSearch):
(WebInspector.AdvancedSearchController.prototype.resetSearch):
(WebInspector.AdvancedSearchController.prototype.stopSearch):
(WebInspector.SearchView):
(WebInspector.SearchView.prototype.get statusBarItems):
(WebInspector.SearchView.prototype.get counterElement):
(WebInspector.SearchView.prototype.set resultsPane):
(WebInspector.SearchView.prototype.searchStarted):
(WebInspector.SearchView.prototype._updateSearchResultsMessage):
(WebInspector.SearchView.prototype._updateSearchProgress):
(WebInspector.SearchView.prototype.resetResults):
(WebInspector.SearchView.prototype._resetCounters):
(WebInspector.SearchView.prototype.nothingFound):
(WebInspector.SearchView.prototype.addSearchResult):
(WebInspector.SearchView.prototype.searchFinished):
(WebInspector.SearchView.prototype._searchStopButtonPressed):
(WebInspector.SearchResultsPane):
(WebInspector.FileBasedSearchResultsPane):
(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):
(WebInspector.FileBasedSearchResultsPane.prototype._fileTreeElementExpanded):
(WebInspector.FileBasedSearchResultsPane.prototype._appendSearchMatches):
(WebInspector.FileBasedSearchResultsPane.prototype._appendShowMoreMatchesElement):
(WebInspector.FileBasedSearchResultsPane.prototype._showMoreMatchesElementSelected):
(WebInspector.FileBasedSearchResultsPane.prototype._addFileTreeElement):
(WebInspector.FileBasedSearchResultsPane.prototype._regexMatchRanges):

inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.hide):

inspector/front-end/Images/statusbarButtonGlyphs.png:
inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchScope):
(WebInspector.ScriptsSearchScope.prototype.performSearch.filterOutContentScripts):
(WebInspector.ScriptsSearchScope.prototype.performSearch.continueSearch):
(WebInspector.ScriptsSearchScope.prototype.performSearch.searchCallbackWrapper):
(WebInspector.ScriptsSearchScope.prototype.performSearch):
(WebInspector.ScriptsSearchScope.prototype.stopSearch):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._registerShortcuts):

inspector/front-end/inspector.css:

(#drawer-status-bar .search-status-bar-item):
(#drawer-status-bar .search-status-bar-message):
(#drawer-status-bar .search-status-bar-progress):
(#drawer-status-bar .search-status-bar-stop-button-item):
(#drawer-status-bar .search-status-bar-stop-button .glyph):
(#drawer-status-bar .search-results-status-bar-message):
(.search-view .search-results):
(#search-results-pane-file-based .search-results-outline-disclosure):
(#search-results-pane-file-based .search-result):
(#search-results-pane-file-based .search-result:hover):
(#search-results-pane-file-based .show-more-matches):
(#search-results-pane-file-based .show-more-matches:hover):
(#search-results-pane-file-based .search-match:hover):

inspector/front-end/utilities.js:

():

BUG=101337
TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/8381041

6:09 AM Changeset in webkit [98335] by vsevik@chromium.org

1 edit in branches/chromium/912/Source/WebCore/English.lproj/localizedStrings.js

Revert 98334 -

TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/8375054

6:00 AM Changeset in webkit [98334] by vsevik@chromium.org

1 edit in branches/chromium/912/Source/WebCore/English.lproj/localizedStrings.js

5:59 AM Changeset in webkit [98333] by caseq@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: JS exception in JavaScriptSourceFrame.onShowPopover/showObjectPopover()
https://bugs.webkit.org/show_bug.cgi?id=70812

Reviewed by Pavel Feldman.

Check if highlighted element is present while displaying object popover.

inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.onShowPopover.showObjectPopover):
(WebInspector.JavaScriptSourceFrame.prototype.onShowPopover):

4:01 AM Changeset in webkit [98332] by commit-queue@webkit.org

13 edits in trunk/Source/WebKit2

[Qt][WK2] Remove redundant setPageIsVisible() API
https://bugs.webkit.org/show_bug.cgi?id=70520

Use DrawingAreaProxy::visibilityDidChange() instead of DrawingAreaProxy::setPageIsVisible()
Remove DrawingAreaProxy::setPageIsVisible(), not used anymore.
This change disables the ability of suspending and resuming painting for TiledDrawingAreaProxy.
However, TiledDrawingAreaProxy is about to be deprecated by using DrawingAreaProxyImpl
as the UI process drawing area proxy for tiled based rendering.

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-10-25
Reviewed by Simon Hausmann.

UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::QTouchWebPage):
(QTouchWebPagePrivate::setPage):

UIProcess/API/qt/qtouchwebpage.h:
UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebView::QTouchWebView):
(QTouchWebView::touchEvent):
(QTouchWebView::onVisibleChanged):

UIProcess/API/qt/qtouchwebview.h:
UIProcess/DrawingAreaProxy.h:
UIProcess/DrawingAreaProxyImpl.cpp:
UIProcess/DrawingAreaProxyImpl.h:
UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
(WebKit::TiledDrawingAreaProxy::deviceScaleFactorDidChange):

UIProcess/TiledDrawingAreaProxy.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewStateDidChange):

UIProcess/qt/QtWebPageProxy.cpp:
UIProcess/qt/QtWebPageProxy.h:

2:54 AM Changeset in webkit [98331] by nduca@chromium.org

2 edits in trunk/Source/WebCore

[chromium] Route Console::time and Console::timeEnd to trace_event
https://bugs.webkit.org/show_bug.cgi?id=70620

Reviewed by Pavel Feldman.

page/Console.cpp:

(WebCore::Console::time):
(WebCore::Console::timeEnd):

2:39 AM Changeset in webkit [98330] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Remove from Skipped list. Test passes: fast/transforms/scrollIntoView-transformed.html
https://bugs.webkit.org/show_bug.cgi?id=58559

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2011-10-25
Reviewed by Simon Hausmann.

platform/qt/Skipped:

2:35 AM Changeset in webkit [98329] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Removing test from Skipped list. Test passes: html5lib/runner.html
https://bugs.webkit.org/show_bug.cgi?id=53030

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2011-10-25
Reviewed by Simon Hausmann.

platform/qt/Skipped:

2:25 AM Changeset in webkit [98328] by caseq@chromium.org

8 edits
2 adds in trunk

Web Inspector: [Extensions API] allow extensions to specify script to be injected on reload
https://bugs.webkit.org/show_bug.cgi?id=70600

Reviewed by Pavel Feldman.

change webInspector.inspectedPage.reload() to accept multiple options in an object
add an ability to inject a script upon a page reload
return script id in addScriptToEvaluateOnLoad()
provide removeScriptToEvaluateOnLoad()
store scripts to evaluate on load in inspector state cookie

Source/WebCore:

Test: inspector/extensions/extensions-reload.html

inspector/Inspector.json:
inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::removeScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::removeAllScriptsToEvaluateOnLoad):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::frameNavigated):

inspector/InspectorPageAgent.h:
inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.InspectedWindow.prototype.reload):

inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onReload):

inspector/front-end/WorkersSidebarPane.js:

(WebInspector.WorkersSidebarPane.prototype.setInstrumentation.callback):
(WebInspector.WorkersSidebarPane.prototype.setInstrumentation):

LayoutTests:

inspector/extensions/extensions-reload-expected.txt: Added.
inspector/extensions/extensions-reload.html: Added.

1:37 AM Changeset in webkit [98327] by Carlos Garcia Campos

6 edits in trunk/Source/WebKit2

[GTK] Add go_to_back_forward_list_item() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69825

Reviewed by Martin Robinson.

UIProcess/API/gtk/WebKitBackForwardListItem.cpp:

(webkitBackForwardListItemGetWKItem):

UIProcess/API/gtk/WebKitBackForwardListPrivate.h:
UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_go_to_back_forward_list_item):

UIProcess/API/gtk/WebKitWebView.h:
UIProcess/API/gtk/tests/TestBackForwardList.cpp:

(testBackForwardListNavigation):

1:24 AM Changeset in webkit [98326] by pfeldman@chromium.org

7 edits in trunk

Web Inspector: print expired message count before remaining messages.
https://bugs.webkit.org/show_bug.cgi?id=70736

Reviewed by Yury Semikhatsky.

inspector/Inspector-0.1.json:
inspector/Inspector.json:
inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::restore):

inspector/InspectorConsoleAgent.h:
inspector/front-end/ConsoleModel.js:

1:19 AM Changeset in webkit [98325] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[WK2]Critical warning while building WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=70591

Patch by Vamshikrishna Yellenki <vamshi@motorola.com> on 2011-10-25
Reviewed by Martin Robinson.

WebProcess/WebPage/WebPage.cpp: Included DataObjectGtk.h to avoid warnings for GTK

12:06 AM Changeset in webkit [98324] by commit-queue@webkit.org

4 edits
2 deletes in trunk

Unreviewed, rolling out r98309.
http://trac.webkit.org/changeset/98309
https://bugs.webkit.org/show_bug.cgi?id=70801

Test fails on mac (Requested by benwells on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-25

Source/WebCore:

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::shouldDisplayTransparencyElsewhere):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):

html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

fast/canvas/canvas-composite-image-expected.txt: Removed.
fast/canvas/canvas-composite-image.html: Removed.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed