⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 30, 2011:

7:50 PM Changeset in webkit [98835] by yutak@chromium.org
  • 5 edits in trunk/LayoutTests

WebSocket: iframe in reload-crash.html reloads forever
​https://bugs.webkit.org/show_bug.cgi?id=71098

Reviewed by Kent Tamura.

iframe in this test should not get reloaded more than once.

  • http/tests/websocket/tests/hixie76/reload-crash.html:

Provide the value of reloadCount to the script in iframe.

  • http/tests/websocket/tests/hixie76/resources/reload-crash-iframe.html:

Call location.reload() only if reloadCount is zero.

  • http/tests/websocket/tests/hybi/reload-crash.html:
  • http/tests/websocket/tests/hybi/resources/reload-crash-iframe.html:
6:50 PM Changeset in webkit [98834] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSParser::parsePrimaryExpression should have an overflow check
​https://bugs.webkit.org/show_bug.cgi?id=71197

Reviewed by Geoff Garen.

  • parser/JSParser.cpp:

(JSC::JSParser::parsePrimaryExpression):

6:43 PM Changeset in webkit [98833] by commit-queue@webkit.org
  • 13 edits in trunk/Tools

Unreviewed, rolling out r98819, r98823, r98825, and r98830.
​http://trac.webkit.org/changeset/98819
​http://trac.webkit.org/changeset/98823
​http://trac.webkit.org/changeset/98825
​http://trac.webkit.org/changeset/98830
​https://bugs.webkit.org/show_bug.cgi?id=71199

Broke Chromium Windows bot (Requested by rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-30

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/efl.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
5:21 PM Changeset in webkit [98832] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG ValueAdd(string, int) should not fail speculation
​https://bugs.webkit.org/show_bug.cgi?id=71195

Reviewed by Geoff Garen.

1% speed-up on V8.

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldNotSpeculateInteger):
(JSC::DFG::Node::shouldSpeculateInteger):

3:47 PM Changeset in webkit [98831] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

The DFG inliner should not flush the callee
​https://bugs.webkit.org/show_bug.cgi?id=71191

Reviewed by Oliver Hunt.

0.6% speed-up on V8.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

  • bytecode/CodeOrigin.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::trueCallerFrameSlow):

3:42 PM Changeset in webkit [98830] by eric@webkit.org
  • 2 edits in trunk/Tools

new-run-webkit-tests is locale dependent
​https://bugs.webkit.org/show_bug.cgi?id=68691

Unreviewed.

This is a temporary hack until someone from the cr-win port
can take a look and determine which environment variable
lighttpd is missing.

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
3:06 PM Changeset in webkit [98829] by rik@webkit.org
  • 2 edits in trunk/Websites/planet.webkit.org

Add Peter Beverloo's feed to Planet WebKit
​https://bugs.webkit.org/show_bug.cgi?id=70316

Reviewed by Andreas Kling.

  • config.ini:
12:34 PM Changeset in webkit [98828] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove crash expectations from tests that have not been crashing on Chromium.

  • platform/chromium/test_expectations.txt:
9:29 AM Changeset in webkit [98827] by Martin Robinson
  • 11 edits in trunk/Source

[GTK] Switch to a backing store approach for painting WebKitWebView
​https://bugs.webkit.org/show_bug.cgi?id=70213

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

No new tests. The changes to WebCore should not change
behavior. The changes in WebKit are covered by existing
tests.

  • platform/cairo/WidgetBackingStore.h:

(WebCore::WidgetBackingStore::size): Added this getter for the size.

  • platform/cairo/WidgetBackingStoreCairo.cpp:

(WebCore::WidgetBackingStore::WidgetBackingStore): Initialize size.

  • platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::copyRectFromCairoSurfaceToContext): Added this new helper.
(WebCore::copyRectFromOneSurfaceToAnother): Use the new helper.

  • platform/graphics/cairo/CairoUtilities.h:
  • platform/gtk/GtkWidgetBackingStoreX11.cpp:

(WebCore::WidgetBackingStore::WidgetBackingStore): Initialize the size.

Source/WebKit/gtk:

Paint the WebView into a backing store. This prevents expose events from
triggering a layout, making scrolling and resizing much smoother.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::ChromeClient): Initialize new members.
(WebKit::repaintEverythingSoonTimeout): Added this helper which repaints
the WebView more quickly during resize events.
(WebKit::clipOutOldWidgetArea): Clips out the old widget area, so that we
can clear out invalid pixels when growing the widget into a pre-existing
backing store.
(WebKit::clearEverywhereInBackingStore): Clear out the entire backing store.
(WebKit::ChromeClient::widgetSizeChanged): Handle widget size changes by
intelligently resizing or reusing the existing backing store.
(WebKit::coalesceRectsIfPossible): Moved this method from webkitwebview.cpp.
(WebKit::paintWebView): Moved this method from webkitwebview.cpp.
(WebKit::ChromeClient::performAllPendingScrolls): If there are any pending
scrolling operations, perform them by scrolling the backing store.
(WebKit::ChromeClient::paint): Added this timer callback, which paints the
WebView after a short timeout.
(WebKit::ChromeClient::invalidateWindow): No need to do anything here any longer.
(WebKit::ChromeClient::invalidateContentsAndWindow): Now unite the rect with
the existing dirty region and queue the paint timeout.
(WebKit::ChromeClient::scroll): Now just queue a scroll event in the repaint timeout.
Intelligently calculate the area to move and the dirty area using code derived
from WebKit2.

  • WebCoreSupport/ChromeClientGtk.h: Added new method definitions and also use

the WebCore namespace to avoid lots of uses of "WebCore::".

  • webkit/webkitwebview.cpp:

(webkit_web_view_draw): Now just blit the backing store into the widget.
(webkit_web_view_expose): Ditto.
(webkit_web_view_size_allocate): Let the ChromeClient know the widget size changed.
(webkit_web_view_init): Turn off GDK double buffering as we have our own double
buffer.

  • webkit/webkitwebviewprivate.h: Add the backing store member.
9:03 AM Changeset in webkit [98826] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r98803.
​http://trac.webkit.org/changeset/98803
​https://bugs.webkit.org/show_bug.cgi?id=71186

Causing test and assertion failures on some platforms
(Requested by anttik on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-30

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyMatchedDeclarations):

12:57 AM Changeset in webkit [98825] by eric@webkit.org
  • 7 edits in trunk/Tools

new-run-webkit-tests is locale dependent
​https://bugs.webkit.org/show_bug.cgi?id=68691

Unreviewed. I would have preferred to have this reviewed,
but relevant reviewers are asleep and bots are broken.

This was a regression from moving to a clean environment.
ChromiumWin (and possibly other ports), need the "PATH"
environment copied over. This wasn't caught in my testing
because although we had unittests to cover this, they
weren't being run on anything but windows. The vast majority
of this change is just fixing the unittests to use our
modern MockFileSystem/MockUser/MockExecutive so they can
be run on any system (and removing the platform checks from
the unittests so they are run everywhere).

The actual fix is the single line "PATH" string added to base.py.
The rest of this change is just fixing the Chromium port unittests
to run on all systems (including changing the Chromium port to
use FileSystem.path_to_module instead of file).

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

Oct 29, 2011:

10:36 PM Changeset in webkit [98824] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • platform/graphics/mac/WebLayer.mm:

(drawLayerContents):

8:06 PM Changeset in webkit [98823] by eric@webkit.org
  • 3 edits in trunk/Tools

new-run-webkit-tests is locale dependent
​https://bugs.webkit.org/show_bug.cgi?id=68691

Unreviewed.

Fix the Qt port and unittest the function so we don't break it again.

  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
5:45 PM Changeset in webkit [98822] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • editing/Editor.cpp:

(WebCore::Editor::markMisspellingsAfterTypingToWord):

4:27 PM Changeset in webkit [98821] by dcheng@chromium.org
  • 16 edits
    7 moves in trunk/Source/WebCore

Rename DataTransferItems to DataTransferItemList
​https://bugs.webkit.org/show_bug.cgi?id=71151

Per feedback that Items and Item are hard to distinguish between, the HTML5 spec renamed
DataTransferItems to DataTransferItemList:
​http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the-datatransferitemlist-interface

Reviewed by Tony Chang.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Clipboard.h:
  • dom/Clipboard.idl:
  • dom/DataTransferItemList.cpp: Renamed from Source/WebCore/dom/DataTransferItems.cpp.

(WebCore::DataTransferItemList::DataTransferItemList):
(WebCore::DataTransferItemList::length):
(WebCore::DataTransferItemList::item):
(WebCore::DataTransferItemList::deleteItem):
(WebCore::DataTransferItemList::clear):
(WebCore::DataTransferItemList::add):

  • dom/DataTransferItemList.h: Renamed from Source/WebCore/dom/DataTransferItems.h.

(WebCore::DataTransferItemList::~DataTransferItemList):

  • dom/DataTransferItemList.idl: Renamed from Source/WebCore/dom/DataTransferItems.idl.
  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::items):

  • platform/chromium/ClipboardChromium.h:
  • platform/chromium/DataTransferItemListChromium.cpp: Renamed from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.

(WebCore::DataTransferItemListChromium::create):
(WebCore::DataTransferItemListChromium::DataTransferItemListChromium):
(WebCore::DataTransferItemListChromium::addPasteboardItem):

  • platform/chromium/DataTransferItemListChromium.h: Renamed from Source/WebCore/platform/chromium/DataTransferItemsChromium.h.
  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::items):

  • platform/qt/ClipboardQt.h:
  • platform/qt/DataTransferItemListQt.cpp: Renamed from Source/WebCore/platform/qt/DataTransferItemsQt.cpp.

(WebCore::DataTransferItemListQt::create):
(WebCore::DataTransferItemListQt::DataTransferItemListQt):
(WebCore::DataTransferItemListQt::addPasteboardItem):

  • platform/qt/DataTransferItemListQt.h: Renamed from Source/WebCore/platform/qt/DataTransferItemsQt.h.
3:55 PM Changeset in webkit [98820] by annacc@chromium.org
  • 3 edits in trunk/LayoutTests

Add track-text-track-destructor-crash.html to Skipped files for mac and win
​https://bugs.webkit.org/show_bug.cgi?id=71182

Reviewed by Ryosuke Niwa.

  • platform/mac/Skipped:
  • platform/win/Skipped:
3:06 PM Changeset in webkit [98819] by eric@webkit.org
  • 7 edits in trunk/Tools

new-run-webkit-tests is locale dependent
​https://bugs.webkit.org/show_bug.cgi?id=68691

Reviewed by Adam Barth.

Make NRWT use a clean environment just like ORWT did.
I've manually validated that NRWT now copies over
the same environment variables that ORWT did.
This new code is exercised by existing setup_environ_for_server tests.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/efl.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
3:04 PM Changeset in webkit [98818] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Mac rebaseline after r98813.

  • platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
2:34 PM Changeset in webkit [98817] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add flaky test expectation to fast/forms/input-step-as-double.html on Chromium.
The failure is tracked by the bug 71181.

  • platform/chromium/test_expectations.txt:
2:20 PM Changeset in webkit [98816] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

GTK+ and Qt rebaselines after r98794.

  • platform/gtk/editing/pasteboard/5134759-expected.txt:
  • platform/qt/editing/pasteboard/5134759-expected.txt:
1:35 PM Changeset in webkit [98815] by robert@webkit.org
  • 2 edits
    2 moves
    1 add in trunk/LayoutTests

Second attempt to add results for tests introduced in ​http://trac.webkit.org/changeset/98812

  • platform/chromium-linux/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/chromium/css2.1/20110323/block-non-replaced-width-008-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.png.
  • platform/chromium/css2.1/20110323/block-non-replaced-width-008-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.txt.
1:14 PM Changeset in webkit [98814] by robert@webkit.org
  • 5 edits in trunk/LayoutTests

Qt and Gtk Results for tests updated by ​http://trac.webkit.org/changeset/98812

Unreviewed, platform-specific results.

  • platform/gtk/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
1:06 PM Changeset in webkit [98813] by robert@webkit.org
  • 1 edit
    1 move
    7 adds in trunk/LayoutTests

Add results for tests introduced in ​http://trac.webkit.org/changeset/98812.

Unreviewed, platform-specific results.

  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/replaced/width100percent-searchfield-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-searchfield-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.txt: Added.
12:15 PM Changeset in webkit [98812] by robert@webkit.org
  • 7 edits in trunk

CSS 2.1 failure: block-non-replaced-width-008.htm
​https://bugs.webkit.org/show_bug.cgi?id=69278

Reviewed by Simon Fraser.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthUsing):

Include the margins in the calculation of logical width even when the containing block's
width is zero. This is required by section '10.3.3 Block-level, non-replaced elements in
normal flow' in the CSS 2.1 spec. Tested by block-non-replaced-width-008.htm in the CSS
test suite.

LayoutTests:

  • platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt: The pixel result is preserved, but the width of the containing block in the render tree now accurately reflects the rendered size of the cells.
  • platform/chromium/test_expectations.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.png:
  • platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.txt:
11:58 AM Changeset in webkit [98811] by abarth@webkit.org
  • 1 edit
    20 adds
    5 deletes in trunk/LayoutTests

Add results for tests introduced in ​http://trac.webkit.org/changeset/98805.

  • platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-001-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-002-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-003-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-004-expected.txt: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
  • platform/chromium-win-vista/css2.1: Removed.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
  • platform/chromium/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/chromium/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/chromium/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
11:29 AM Changeset in webkit [98810] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Update results after ​http://trac.webkit.org/changeset/98794 to remove
0x0 DIV from the render tree.

  • platform/chromium-win/editing/pasteboard/5134759-expected.txt:
11:26 AM Changeset in webkit [98809] by abarth@webkit.org
  • 1 edit
    1 add
    1 delete in trunk/LayoutTests

Update line number in baseline.

  • platform/chromium-linux-x86/fast/dom: Removed.
  • platform/chromium/fast/dom/nested-script-exceptions-expected.txt: Added.
10:28 AM Changeset in webkit [98808] by robert@webkit.org
  • 1 edit
    12 adds in trunk/LayoutTests

Platform-specific results for r98805

Unreviewed, add new results.

  • platform/gtk/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
9:52 AM Changeset in webkit [98807] by annacc@chromium.org
  • 4 edits
    2 adds in trunk

Make sure TextTracks are destructed if HTMLMediaElement goes away.
​https://bugs.webkit.org/show_bug.cgi?id=71148

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-text-track-destructor-crash.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):

Destroy the client (this) on TextTracks.

(WebCore::HTMLMediaElement::loadTextTracks):

Move TextTrack creation to loadNextTextTrack.

(WebCore::HTMLMediaElement::loadNextTextTrack):

Keep track of new TextTrack in a list.

(WebCore::HTMLMediaElement::addTrack):

Keep track of new TextTrack in a list.

  • html/HTMLMediaElement.h:

Add m_textTracks and loadNextTextTrack().

LayoutTests:

  • media/track/track-text-track-destructor-crash-expected.txt: Added.
  • media/track/track-text-track-destructor-crash.html: Added.
9:18 AM Changeset in webkit [98806] by jochen@chromium.org
  • 23 edits
    4 adds in trunk

Implement IDBFactory.deleteDatabase
​https://bugs.webkit.org/show_bug.cgi?id=62622

Reviewed by Tony Chang.

Source/WebCore:

Tests: storage/indexeddb/factory-deletedatabase-interactions.html

storage/indexeddb/factory-deletedatabase.html

  • storage/IDBBackingStore.h:
  • storage/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::callbacks):
(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::PendingDeleteCall):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):

  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBFactory.cpp:

(WebCore::IDBFactory::deleteDatabase):

  • storage/IDBFactory.h:
  • storage/IDBFactory.idl:
  • storage/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::deleteDatabase):

  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:
  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::deleteRange):
(WebCore::IDBLevelDBBackingStore::deleteDatabase):

  • storage/IDBLevelDBBackingStore.h:
  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent):

Source/WebKit/chromium:

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::deleteDatabase):

  • src/IDBFactoryBackendProxy.h:
  • src/WebIDBFactoryImpl.cpp:

(WebKit::WebIDBFactoryImpl::getDatabaseNames):
(WebKit::WebIDBFactoryImpl::open):
(WebKit::WebIDBFactoryImpl::deleteDatabase):

  • src/WebIDBFactoryImpl.h:

LayoutTests:

  • storage/indexeddb/factory-basics-expected.txt: Updated.
  • storage/indexeddb/factory-basics.html: Updated.
  • storage/indexeddb/factory-deletedatabase-expected.txt: Added.
  • storage/indexeddb/factory-deletedatabase-interactions-expected.txt: Added.
  • storage/indexeddb/factory-deletedatabase-interactions.html: Added.
  • storage/indexeddb/factory-deletedatabase.html: Added.
  • storage/indexeddb/open-close-version-expected.txt: Updated.
  • storage/indexeddb/open-close-version.html: Updated.
7:52 AM Changeset in webkit [98805] by robert@webkit.org
  • 7 edits
    12 adds in trunk

CSS 2.1 failure: dynamic-top-change-001 to 004 fail
​https://bugs.webkit.org/show_bug.cgi?id=68149

Reviewed by David Hyatt.

Source/WebCore:

In these tests a child inherits its top value from its parent and the parent's top value
is later updated by an onload event. The updated value is expected to cascade to the child.

The tests were failing because updating the value did not cascade immediately to the child inheriting it, though
it could be forced eventually with a full recalculation of the RenderStyle by changing the zoom factor
or opening the inspector.

The fix is to let the parent RenderStyle know that a child inherits a property explicitly and
recalculate children's style if the parent ever changes. This only happens if the property is inherited
explicitly, it does not apply to cases where the property is inherited by default.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • dom/Node.cpp:

(WebCore::Node::diff):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setHasExplicitlyInheritedProperties):
(WebCore::InheritedFlags::hasExplicitlyInheritedProperties):

LayoutTests:

  • css2.1/20110323/dynamic-top-change-001.htm: Added.
  • css2.1/20110323/dynamic-top-change-002.htm: Added.
  • css2.1/20110323/dynamic-top-change-003.htm: Added.
  • css2.1/20110323/dynamic-top-change-004.htm: Added.
  • fast/table/border-collapsing/cached-change-tbody-border-color-expected.png: See ​https://bugs.webkit.org/show_bug.cgi?id=68149#c15
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
7:45 AM Changeset in webkit [98804] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
​https://bugs.webkit.org/show_bug.cgi?id=34984

Patch by Eric Seidel <​eric@webkit.org> on 2011-10-29
Reviewed by Adam Barth.

Move run-webkit-tests from using a white-list of supported NRWT ports
to a blacklist of ports requiring ORWT.

I've also added the ability to opt-in to parallel testing on a per-port basis.

With these changes I'm going to officially declare this bug dead and
work on remaining polish issues and individual developer complaints.

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):
(platformIsReadyForParallelTesting):

2:36 AM Changeset in webkit [98803] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Tighten font change conditions in matched declaration cache
​https://bugs.webkit.org/show_bug.cgi?id=71026

Reviewed by Darin Adler.

We currently test if font description has changed to see if all properties need to be applied. However
only a few size related metrics can actually affect other properties. We can just test those, making
the cache somewhat more effective while also making the equality test faster.

  • css/CSSStyleSelector.cpp:

(WebCore::fontDifferenceAffectsNonInherited):
(WebCore::CSSStyleSelector::applyMatchedDeclarations):

Test for text computedSize, xHeight and orientation only. Other text properties don't affect computed
values of non-text CSS properties.

2:10 AM Changeset in webkit [98802] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

DOMURL should keep its own state rather than storing it on ScriptExecutionContext
​https://bugs.webkit.org/show_bug.cgi?id=71169

Reviewed by Eric Seidel.

This patch untwists this code. I think this code was originally
twisted because these APIs moved onto DOMURL after they were first
implemented.

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):

  • dom/ScriptExecutionContext.h:
  • fileapi/FileWriter.h:
  • html/DOMURL.cpp:

(WebCore::DOMURL::contextDestroyed):
(WebCore::DOMURL::createObjectURL):
(WebCore::DOMURL::revokeObjectURL):

  • html/DOMURL.h:
1:21 AM Changeset in webkit [98801] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r98780.
​http://trac.webkit.org/changeset/98780
​https://bugs.webkit.org/show_bug.cgi?id=71173

Broke Qt bots (Requested by rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-29

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):

12:58 AM Changeset in webkit [98800] by Antti Koivisto
  • 1 edit
    2 adds in trunk/LayoutTests

REGRESSION(r98542): tables/mozilla_expected_failures/bugs/bug14007-2.html
​https://bugs.webkit.org/show_bug.cgi?id=71032

Reviewed by Ryosuke Niwa.

In an effort to gain Hyatt points, add a less obscure test for this case.

  • fast/css/inherited-properties-explicit-expected.txt: Added.
  • fast/css/inherited-properties-explicit.html: Added.
12:19 AM Changeset in webkit [98799] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r98795.
​http://trac.webkit.org/changeset/98795
​https://bugs.webkit.org/show_bug.cgi?id=71171

Causes worker tests to crash (Requested by abarth on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-29

  • dom/ActiveDOMObject.cpp:

(WebCore::ContextDestructionObserver::contextDestroyed):

  • dom/MessagePort.cpp:

(WebCore::MessagePort::MessagePort):
(WebCore::MessagePort::contextDestroyed):

  • dom/MessagePort.h:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::closeMessagePorts):

12:04 AM Changeset in webkit [98798] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Mac rebaseline after r98617.

  • platform/mac/canvas/philip/tests/2d.imageData.put.wrongtype-expected.txt:
  • platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:
Note: See TracTimeline for information about the timeline view.