Context Navigation

← Previous Period
Next Period →

Timeline

Nov 2, 2011:

11:55 PM Changeset in webkit [99144] by fpizlo@apple.com

6 edits
3 adds in trunk/Source/JavaScriptCore

ValueRecovery should be moved out of the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=71439

Reviewed by Oliver Hunt.

JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/DataFormat.h: Added.

(JSC::dataFormatToString):
(JSC::needDataFormatConversion):
(JSC::isJSFormat):
(JSC::isJSInteger):
(JSC::isJSDouble):
(JSC::isJSCell):
(JSC::isJSBoolean):

bytecode/ValueRecovery.h: Added.

(JSC::ValueRecovery::ValueRecovery):
(JSC::ValueRecovery::alreadyInRegisterFile):
(JSC::ValueRecovery::alreadyInRegisterFileAsUnboxedInt32):
(JSC::ValueRecovery::alreadyInRegisterFileAsUnboxedCell):
(JSC::ValueRecovery::alreadyInRegisterFileAsUnboxedBoolean):
(JSC::ValueRecovery::inGPR):
(JSC::ValueRecovery::inPair):
(JSC::ValueRecovery::inFPR):
(JSC::ValueRecovery::displacedInRegisterFile):
(JSC::ValueRecovery::constant):
(JSC::ValueRecovery::technique):
(JSC::ValueRecovery::isInRegisters):
(JSC::ValueRecovery::gpr):
(JSC::ValueRecovery::tagGPR):
(JSC::ValueRecovery::payloadGPR):
(JSC::ValueRecovery::fpr):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dump):

bytecode/VirtualRegister.h: Added.
dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::isJSFormat):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::ValueSource::dump):

dfg/DFGSpeculativeJIT.h:
dfg/DFGVariableAccessData.h:

11:46 PM Changeset in webkit [99143] by abarth@webkit.org

3 edits
6 adds in trunk

CSP should handle empty URLs as agreed at TPAC
https://bugs.webkit.org/show_bug.cgi?id=71426

Reviewed by Eric Seidel.

Source/WebCore:

It was somewhat unclear how CSP should treat plugins that lacked a URL
because most of the CSP rules are URL-based. At TPAC, we decided to
treat "empty" URLs as if there were the URL of the document. That
means you can use plugins with no URL if you've included 'self' in
object-src, but you can also block them by using 'none' as your
object-src.

Tests: http/tests/security/contentSecurityPolicy/object-src-no-url-allowed.html

http/tests/security/contentSecurityPolicy/object-src-no-url-blocked.html
http/tests/security/contentSecurityPolicy/object-src-none-allowed.html
http/tests/security/contentSecurityPolicy/object-src-none-blocked.html

page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirective::CSPDirective):
(WebCore::CSPDirective::allows):
(WebCore::ContentSecurityPolicy::createCSPDirective):

LayoutTests:

http/tests/security/contentSecurityPolicy/object-src-no-url-allowed-expected.txt: Added.
http/tests/security/contentSecurityPolicy/object-src-no-url-allowed.html: Added.
http/tests/security/contentSecurityPolicy/object-src-no-url-blocked-expected.txt: Added.
http/tests/security/contentSecurityPolicy/object-src-no-url-blocked.html: Added.
- Test the allow and block cases for plugins with no URL.
http/tests/security/contentSecurityPolicy/object-src-none-allowed.html: Added.
http/tests/security/contentSecurityPolicy/object-src-none-blocked.html: Added.
- Somehow these tests got deleted from the repository. This patch just re-adds them.

11:40 PM Changeset in webkit [99142] by caseq@chromium.org

2 edits
3 adds in trunk/LayoutTests

Unerviewed gardening.

platform/chromium-cg-mac-leopard/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
platform/chromium-cg-mac-leopard/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
platform/chromium-cg-mac-leopard/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
platform/chromium/test_expectations.txt: fixed qualifiers limit-layer-bounds-transformed-overflow.html

11:33 PM Changeset in webkit [99141] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[Qt] [WK] Debug build broken
https://bugs.webkit.org/show_bug.cgi?id=71417

Add WKNumber.h for WKBooleanGetTypeID
Replace WKGetTypeId with WKGetTypeID
Add initialization for didDetectXSSForFrame member in WKBundlePageLoaderClient
instance.

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-11-02
Reviewed by Noam Rosenthal.

WebProcess/qt/QtBuiltinBundle.cpp:

(WebKit::QtBuiltinBundle::handleSetNavigatorQtObjectEnabled):

WebProcess/qt/QtBuiltinBundlePage.cpp:

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):

11:16 PM Changeset in webkit [99140] by eric@webkit.org

38 edits
9 copies
5 adds in trunk/Tools

Move Mocks into _mock files near their implementations
https://bugs.webkit.org/show_bug.cgi?id=71425

Reviewed by Adam Barth.

This entire change is splitting mocktool.py into separate _mock.py files
and placing them next to their real implementations.

I also deleted MockPortFactory (since it was wrong) and was just hiding
the fact that the "skipped-ports" command was broken (and has been for a long time).
So I made MockHost use a real PortFactory (passed a MockHost) and changed
the skipped-ports implementation to use modern PortFactory methods.

Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
Scripts/webkitpy/common/checkout/checkout_mock.py: Added.
Scripts/webkitpy/common/checkout/checkout_unittest.py:
Scripts/webkitpy/common/checkout/deps_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/init.py.
Scripts/webkitpy/common/checkout/scm/scm_mock.py: Added.
Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
Scripts/webkitpy/common/config/ports_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
Scripts/webkitpy/common/host.py:
Scripts/webkitpy/common/host_mock.py: Added.
Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: Added.
Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
Scripts/webkitpy/common/net/buildbot/buildbot_mock.py: Added.
Scripts/webkitpy/common/net/credentials_unittest.py:
Scripts/webkitpy/common/net/failuremap_unittest.py:
Scripts/webkitpy/common/net/irc/irc_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/init.py.
Scripts/webkitpy/common/net/statusserver_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
Scripts/webkitpy/common/net/statusserver_unittest.py:
Scripts/webkitpy/common/net/web_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
Scripts/webkitpy/common/system/executive.py:
Scripts/webkitpy/common/system/executive_mock.py:
Scripts/webkitpy/common/system/platforminfo_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/init.py.
Scripts/webkitpy/common/system/user_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
Scripts/webkitpy/common/system/workspace_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/init.py.
Scripts/webkitpy/common/system/workspace_unittest.py:
Scripts/webkitpy/common/watchlist/watchlist_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/init.py.
Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
Scripts/webkitpy/layout_tests/port/init.py:
Scripts/webkitpy/layout_tests/port/base_unittest.py:
Scripts/webkitpy/layout_tests/port/efl_unittest.py:
Scripts/webkitpy/layout_tests/port/factory.py:
Scripts/webkitpy/layout_tests/port/factory_unittest.py:
Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
Scripts/webkitpy/layout_tests/port/mac_unittest.py:
Scripts/webkitpy/layout_tests/port/port_testcase.py:
Scripts/webkitpy/layout_tests/port/qt_unittest.py:
Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
Scripts/webkitpy/layout_tests/port/win_unittest.py:
Scripts/webkitpy/test/main.py:
Scripts/webkitpy/tool/bot/botinfo_unittest.py:
Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
Scripts/webkitpy/tool/bot/irc_command_unittest.py:
Scripts/webkitpy/tool/commands/queries_unittest.py:
Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
Scripts/webkitpy/tool/mocktool.py:
Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

10:28 PM Changeset in webkit [99139] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/mac

Move NSRange / DOMRange conversion functions to WebFramePrivate
https://bugs.webkit.org/show_bug.cgi?id=71435

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2011-11-02
Reviewed by Sam Weinig.

Move conversion functions to WebFramePrivate,
and remove the no longer used versions.

WebView/WebFrame.mm:

(-[WebFrame _convertNSRangeToDOMRange:]):
(-[WebFrame _convertDOMRangeToNSRange:]):

WebView/WebFrameInternal.h:
WebView/WebFramePrivate.h:

9:39 PM Changeset in webkit [99138] by abarth@webkit.org

10 edits
6 adds in trunk

Implement allow-popups for iframe@sandbox
https://bugs.webkit.org/show_bug.cgi?id=66505

Reviewed by Eric Seidel.

Source/WebCore:

There's been some discussion in the HTML working group about adding an
allow-popups directive to the iframe sandbox. Microsoft has added it
to IE10 platform preview and is fairly adamant about this feature
because it's needed by one or their products that's planning to use
iframe sandbox. Hixie says he'll add it to the spec once we implement
it, so here's our implementation. (See discussion in the W3C linked in
the bug for more details.)

Tests: http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html

http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html
http/tests/security/popup-allowed-by-sandbox-when-allowed.html

html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::parseMappedAttribute):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::setOpener):
(WebCore::createWindow):

loader/FrameLoader.h:

(WebCore::FrameLoader::forceSandboxFlags):

loader/FrameLoaderTypes.h:
loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNewWindowPolicy):

page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::parseSandboxPolicy):

page/SecurityOrigin.h:

(WebCore::SecurityOrigin::sandboxFlags):

svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

LayoutTests:

Test that the allow-popups directive works as expected. Note:
no-popup-from-sandbox.html verifies that we still block popups without
the directive.

http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control-expected.txt: Added.
http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html: Added.
http/tests/security/popup-allowed-by-sandbox-is-sandboxed-expected.txt: Added.
http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html: Added.
http/tests/security/popup-allowed-by-sandbox-when-allowed-expected.txt: Added.
http/tests/security/popup-allowed-by-sandbox-when-allowed.html: Added.

9:21 PM Changeset in webkit [99137] by weinig@apple.com

2 edits in trunk/Source/WebCore

Remove the ability to generate custom lookupGetter/lookupSetter functions,
now that they can not be overridden

Reviewed by Adam Roben.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

9:17 PM Changeset in webkit [99136] by weinig@apple.com

4 edits in trunk

Source/JavaScriptCore: Object.getOwnPropertyDescriptor() does not retrieve the getter/setter from a property on the window that has been overridden with a getter/setter
https://bugs.webkit.org/show_bug.cgi?id=71333

Reviewed by Gavin Barraclough.

Tested by fast/dom/getter-on-window-object2.html

runtime/PropertyDescriptor.cpp:

(JSC::PropertyDescriptor::setDescriptor):
The attributes returned from Structure::get do not include Getter or Setter, so
instead check if the value is a GetterSetter like we do elsewhere. If it is, update
the descriptor's attributes accordingly.

LayoutTests: Object.getOwnPropertyDescriptor() does not retrieve the getter/setter from a property on the window that has been overridden with a getter/setter/
https://bugs.webkit.org/show_bug.cgi?id=71333

Reviewed by Gavin Barraclough.

fast/dom/getter-on-window-object2-expected.txt:

Update for now correct results.

8:33 PM Changeset in webkit [99135] by weinig@apple.com

2 edits in trunk/Source/WebCore

Fix crashing tests after r99126 (commit for https://bugs.webkit.org/show_bug.cgi?id=71307)

Reviewed by Adam Roben.

bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::getOwnPropertyNames):
Since we are proxying to the window, we need to pass it as the this object,
not the shell.

8:13 PM Changeset in webkit [99134] by mitz@apple.com

3 edits
1 delete in trunk/Tools

Fixed the build and removed another copy to ColorBits.ttf.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
WebKitTestRunner/fonts/ColorBits.ttf: Removed.

8:13 PM Changeset in webkit [99133] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

FunctionPtr should accept FASTCALL functions on X86
https://bugs.webkit.org/show_bug.cgi?id=71434

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-11-02
Reviewed by Filip Pizlo.

On X86 we sometimes use FASTCALL convention functions, for example the
cti functions, and we may need the pointers to such functions, e.g.,
in current DFG register file check and arity check, though long term
we may avoid such usage of cti calls in DFG.

assembler/MacroAssemblerCodeRef.h:

(JSC::FunctionPtr::FunctionPtr):

7:58 PM Changeset in webkit [99132] by fpizlo@apple.com

4 edits in trunk/Source/JavaScriptCore

Inlined uses of the global object should use the right global object
https://bugs.webkit.org/show_bug.cgi?id=71427

Reviewed by Oliver Hunt.

dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::globalObjectFor):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

7:19 PM Changeset in webkit [99131] by arv@chromium.org

6 edits in trunk/LayoutTests

Add new StorageInfo test to the respective skip lists.

Unreviewed.

platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:
platform/wincairo/Skipped:

6:56 PM Changeset in webkit [99130] by arv@chromium.org

19 edits
4 adds in trunk

Remove LegacyDefaultOptionalArguments flag from storage IDL files
https://bugs.webkit.org/show_bug.cgi?id=65744

Reviewed by Adam Barth.

Source/WebCore:

Test: storage/domstorage/localstorage/missing-arguments.html

storage/DatabaseCallback.idl:
storage/IDBRequest.idl:
storage/IDBTransaction.idl:
storage/SQLResultSetRowList.idl:
storage/SQLStatementCallback.idl:
storage/SQLStatementErrorCallback.idl:
storage/SQLTransaction.idl:
storage/SQLTransactionCallback.idl:
storage/SQLTransactionErrorCallback.idl:
storage/SQLTransactionSync.idl:
storage/SQLTransactionSyncCallback.idl:
storage/Storage.idl:
storage/StorageInfo.idl:
storage/StorageInfoErrorCallback.idl:
storage/StorageInfoQuotaCallback.idl:
storage/StorageInfoUsageCallback.idl:

LayoutTests:

storage/domstorage/localstorage/missing-arguments-expected.txt: Added.
storage/domstorage/localstorage/missing-arguments.html: Added.

6:53 PM Changeset in webkit [99129] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

Remove some unnecessary loads/stores in DFG JIT 32_64
https://bugs.webkit.org/show_bug.cgi?id=71090

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-11-02
Reviewed by Filip Pizlo.

In fillSpeculateCell and OSR exit, some unnecessary loads/stores can
be eliminated.

dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateCell):

6:28 PM Changeset in webkit [99128] by adamk@chromium.org

6 edits in trunk/Source

Replace usage of StringImpl with String where possible in CharacterData and Text
https://bugs.webkit.org/show_bug.cgi?id=71383

Reviewed by Darin Adler.

Source/JavaScriptCore:

wtf/text/WTFString.h:

(WTF::String::containsOnlyWhitespace): Added new method.

Source/WebCore:

Ryosuke Niwa, in http://webkit.org/b/70862, asked me to replace usages
of String with StringImpl. I've done more than what he asked in this
patch, the biggest change being that CharacterData now holds a String
instead of a RefPtr<StringImpl>.

No new tests, as this should have no effect on behavior.

dom/CharacterData.cpp:

(WebCore::CharacterData::setData):
(WebCore::CharacterData::substringData):
(WebCore::CharacterData::parserAppendData):
(WebCore::CharacterData::appendData):
(WebCore::CharacterData::insertData):
(WebCore::CharacterData::deleteData):
(WebCore::CharacterData::replaceData):
(WebCore::CharacterData::containsOnlyWhitespace):
(WebCore::CharacterData::setDataAndUpdate):
(WebCore::CharacterData::updateRenderer):
(WebCore::CharacterData::dispatchModifiedEvent):

dom/CharacterData.h:

(WebCore::CharacterData::length):
(WebCore::CharacterData::dataImpl):
(WebCore::CharacterData::CharacterData):
(WebCore::CharacterData::setDataWithoutUpdate):

dom/Text.cpp:

(WebCore::Text::splitText):

5:55 PM Changeset in webkit [99127] by mitz@apple.com

5 edits
5 deletes in trunk

REGRESSION (r98759-r98773): platform/mac/fonts/color-bitmap.html failing on Lion Intel Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=71424

Reviewed by Sam Weinig.

Tools:

Removed the ColorBits font and the code to register it in the process
running the tests. The font was only used by the aforementioned test,
which is now being removed.

DumpRenderTree/fonts/ColorBits-A.png: Removed.
DumpRenderTree/fonts/ColorBits.ttf: Removed.
DumpRenderTree/mac/DumpRenderTree.mm:

(allowedFontFamilySet):
(activateTestingFonts):

WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:

(WTR::inititializeFontConfigSetting):

WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:

(WTR::allowedFontFamilySet):
(WTR::activateFonts):

LayoutTests:

Removed this test and its results, because it was relying on a feature
that is no longer present in any OS X version. The color bitmap font
rendering code is now covered by another test.

platform/mac/fonts/color-bitmap-expected.png: Removed.
platform/mac/fonts/color-bitmap-expected.txt: Removed.
platform/mac/fonts/color-bitmap.html: Removed.

5:25 PM Changeset in webkit [99126] by mhahnenberg@apple.com

56 edits in trunk/Source

De-virtualize JSObject::getOwnPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=71307

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added getOwnPropertyNames to the MethodTable, changed all the virtual
implementations of getOwnPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertyNames):

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::getOwnPropertyNames):

debugger/DebuggerActivation.h:
runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertyNames):

runtime/Arguments.h:
runtime/ClassInfo.h:
runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnPropertyNames):

runtime/JSActivation.h:
runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertyNames):

runtime/JSArray.h:
runtime/JSByteArray.cpp:

(JSC::JSByteArray::getOwnPropertyNames):

runtime/JSByteArray.h:
runtime/JSCell.cpp:

(JSC::JSCell::getOwnPropertyNames):

runtime/JSCell.h:
runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertyNames):

runtime/JSFunction.h:
runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::getOwnPropertyNames):

runtime/JSNotAnObject.h:
runtime/JSONObject.cpp:

(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):

runtime/JSObject.cpp:

(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):

runtime/JSObject.h:
runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::~JSVariableObject):
(JSC::JSVariableObject::getOwnPropertyNames):

runtime/JSVariableObject.h:
runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):
(JSC::defineProperties):

runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::getOwnPropertyNames):

runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertyNames):

runtime/StringObject.h:
runtime/Structure.h:

Source/JavaScriptGlue:

Added getOwnPropertyNames to the MethodTable, changed all the virtual
implementations of getOwnPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

UserObjectImp.cpp:

(UserObjectImp::getOwnPropertyNames):

UserObjectImp.h:

Source/WebCore:

No new tests.

Added getOwnPropertyNames to the MethodTable, changed all the virtual
implementations of getOwnPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

WebCore.exp.in:
bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::getOwnPropertyNames):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertyNames):

bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::getOwnPropertyNames):

bindings/js/JSDOMWindowShell.h:
bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::getOwnPropertyNames):

bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::getOwnPropertyNames):

bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::getOwnPropertyNames):

bindings/js/ScriptValue.cpp:

(WebCore::jsToInspectorValue):

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyNames):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyNames):

bridge/qt/qt_runtime.h:
bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertyNames):

bridge/runtime_array.h:
bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::getOwnPropertyNames):

bridge/runtime_object.h:

Source/WebKit2:

Added getOwnPropertyNames to the MethodTable, changed all the virtual
implementations of getOwnPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getOwnPropertyNames):

WebProcess/Plugins/Netscape/JSNPObject.h:

5:16 PM Changeset in webkit [99125] by Simon Fraser

2 edits in trunk/LayoutTests

REGRESSION (r97496-r97499): 6 fast/workers tests failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=70619

Skip some failing worker tests.

platform/mac/Skipped:

5:12 PM Changeset in webkit [99124] by mitz@apple.com

2 edits in trunk/Tools

Fix an intermittent hang in RenderedImageFromDOMRange.

Reviewed by Anders Carlsson.

TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::run): Made the call to -runMode:beforeDate: return
immediately if there are no sources by passing a date in the distant past.

5:02 PM Changeset in webkit [99123] by Adam Roben

1 edit
1 add in trunk/Tools

Add git-add-reviewer

I've been using this script for a while to add reviewers to git commits in my local
repository before pushing them to the Subversion repository. Basic usage is:

git-add-reviewer HEAD^{"Joe Schmoe"

or

git-add-reviewer -i trunk}

Fixes <http://webkit.org/b/71419> Would like an easy way to add reviewer names to existing
git commits

Reviewed by Sam Weinig.

Scripts/git-add-reviewer: Added.

(top level): Parse options, check that the working tree is clean, then run in either
interactive or non-interactive mode as appropriate.
(interactive): Write out a temp file that contains each commit with "NOBODY" next to it and
open it in the user's editor. The user can replace "NOBODY" with reviewer names. When the
editor exits, we check out the commit just before the earliest one we're modifying. Then
for each commit, we check it out, update the reviewer, and amend the commit to contain the
new reviewer. Finally, we update the branch that was originally checked out to point to the
last amended commit.
(nonInteractive): Check out the commit to modify, write the current commit message to the
MERGE_MSG file so addReviewer will update it, add the reviewer to the ChangeLog(s), amend
the commit, and rebase the original branch on top of the amended commit. (usage): Print out
a usage message and exit.
(requireCleanWorkTree): Do the same steps git-rebase does to ensure that the working tree
and index are clean.
(fail): Print out the specified error message, if any, and return false. This function is
used as a return value in various error cases throughout the script.
(cherryPick): Cherry-pick the specified commit and return 1 if we succeeded.
(addReviewer): Add the specified reviewer to all the ChangeLogs modified in this commit, and
to .git/MERGE_MSG, which will be used as the commit message for the next commit.
(commit): Call git-commit and use .git/MERGE_MSG as the commit message.

(addReviewerToChangeLog):
(addReviewerToCommitMessage):
These just call through to addReviewerToFile.

(addReviewerToFile): Read in the file, replacing any "NOBODY" text with the reviewer name(s)
and replacing "Reviewed" with "Rubber-stamped" if specified. Write the resulting text to a
temp file, then move the temp file over the original file and stage it for the next commit.
(head): Returns the name of the currently-checked-out branch.
(isAncestor): Returns true if the first commit is an ancestor of the second.
(toCommit): Converts a commitish to a commit ID using git-rev-parse.
(changeLogsForCommit): Returns a list of all the ChangeLogs modified in the given commit.
(resetToCommit): Checks out the given commit, throwing away any local changes.
(writeCommitMessageToFile): Gets the commit message for the current commit and writes it to
the specified file.
(rebaseOntoHead): Rebases the specified branch onto HEAD.
(checkout): Checks out the given commit.
(getConfigValue): Reads the specified config variable from git-config.

4:57 PM Changeset in webkit [99122] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Don't call NPP_SetWindow if the plug-in size or clip rect hasn't changed if the plug-in isn't using window relative coordinates
https://bugs.webkit.org/show_bug.cgi?id=71418

Reviewed by Adam Roben.

This avoids calling into the plug-in when only the plug-in position relative to the window changes.

WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::geometryDidChange):

4:43 PM Changeset in webkit [99121] by jonlee@apple.com

2 edits in trunk/Source/WebKit2

Fix syntax error.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):

4:30 PM Changeset in webkit [99120] by tony@chromium.org

3 edits
2 adds in trunk

force inline flexitems to be wrapped in anonymous blocks
https://bugs.webkit.org/show_bug.cgi?id=71314

Reviewed by Ojan Vafai.

Source/WebCore:

If there is a mix of inline and block items, all the inline items were already getting wrapped
(see RenderBlock::addChildIgnoringAnonymousColumnBlocks). However, if there are only inline items,
we need to force them into an anonymous block.

There are still lots of bugs because we're trying to read style values from the anonymous block,
but this at least causes layout to be called on all the render objects.

Tests: css3/flexbox/anonymous-block.html

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::TreeOrderIterator::next):
(WebCore::RenderFlexibleBox::FlexOrderIterator::next):
(WebCore::RenderFlexibleBox::RenderFlexibleBox): force children into blocks

LayoutTests:

css3/flexbox/anonymous-block-expected.html: Added.
css3/flexbox/anonymous-block.html: Added.

4:22 PM Changeset in webkit [99119] by jonlee@apple.com

2 edits in trunk/Source/WebKit2

Fix build error from r99108.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):

4:17 PM Changeset in webkit [99118] by dino@apple.com

13 edits in trunk

Add ENABLE_CSS_SHADERS flag
https://bugs.webkit.org/show_bug.cgi?id=71394

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Tools:

Scripts/build-webkit:

WebKitLibraries:

win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

4:14 PM Changeset in webkit [99117] by andersca@apple.com

6 edits in trunk/Source/WebKit2

Allow the various plug-in ports to decide whether NPWindow coordinates should be window-relative
https://bugs.webkit.org/show_bug.cgi?id=71415

Reviewed by Darin Adler.

WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::callSetWindow):
Remove the PLUGIN_ARCHITECTURE(X11) ifdef and set the NPWindow members
based on the return value of wantsWindowRelativeNPWindowCoordinates.

WebProcess/Plugins/Netscape/NetscapePlugin.h:
WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::wantsWindowRelativeNPWindowCoordinates):

WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::wantsWindowRelativeNPWindowCoordinates):

WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::wantsWindowRelativeNPWindowCoordinates):
Add platform specific implementations.

4:02 PM Changeset in webkit [99116] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[Qt] [WK] Debug build broken after r99065
https://bugs.webkit.org/show_bug.cgi?id=71397

Remove reference to panGestureActive becuase it is not defined anywhere.

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-11-02
Reviewed by Simon Hausmann.

UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::panGestureStarted):

4:01 PM Changeset in webkit [99115] by leviw@chromium.org

3 copies in branches/chromium/874/LayoutTests

Merge 98263 - <svg> fails to use explicit width and height inside <html> inside IFRAME
https://bugs.webkit.org/show_bug.cgi?id=64823

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Checking that embedded SVG is in an SVG document before negotiating size
with the host document.

Test: svg/as-object/svg-embedded-in-html-in-iframe.html

rendering/svg/RenderSVGRoot.cpp:

(WebCore::isEmbeddedThroughFrameContainingSVGDocument):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

LayoutTests:

Fixing a bug where SVG negotiated size when embedded in html inside an iframe.

platform/chromium/test_expectations.txt: Will update with results on other platforms.
platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
svg/as-object/svg-embedded-in-html-in-iframe.html: Added.

TBR=leviw@chromium.org
Review URL: http://codereview.chromium.org/8439060

4:00 PM Changeset in webkit [99114] by arv@chromium.org

7 edits in trunk/LayoutTests

Remove references to non existing file; js-test-post-function.js
https://bugs.webkit.org/show_bug.cgi?id=71398

Reviewed by Ojan Vafai.

This js file no longer exists and the code it defined is now in js-test-pre.js.

fast/events/touch/gesture/gesture-scroll.html:
storage/indexeddb/factory-deletedatabase-interactions.html:
storage/indexeddb/factory-deletedatabase.html:
storage/indexeddb/open-during-transaction.html:
storage/indexeddb/version-change-abort-expected.txt:
storage/indexeddb/version-change-abort.html:

3:53 PM Changeset in webkit [99113] by eae@chromium.org

4 edits in trunk/Source/WebCore

Switch RenderText to new layout types
https://bugs.webkit.org/show_bug.cgi?id=71389

Reviewed by Eric Seidel.

Switch RenderText methods (and overriden methods in related classes) to
LayoutRect/LayoutUnit.

No new tests.

rendering/RenderText.cpp:

(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::linesBoundingBox):
(WebCore::RenderText::linesVisualOverflowBoundingBox):

rendering/RenderText.h:

Change RenderText to expose its bounding box, selection and caret rects
as LayoutRects.

rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::localCaretRect):

rendering/svg/RenderSVGInlineText.h:

Change localCaretRect to return a LayoutRect.

3:47 PM Changeset in webkit [99112] by jonlee@apple.com

2 edits in trunk/Source/WebKit2

Update dragging info on mac when user is dragging files into view
https://bugs.webkit.org/show_bug.cgi?id=71325
<rdar://problem/10379193>

Reviewed by Darin Adler.

UIProcess/API/mac/WKView.mm:

(-[WKView draggingUpdated:]): Based on the DragSession, we update NSDraggingInfo
to update the badge and dragging formation.

3:44 PM Changeset in webkit [99111] by tony@chromium.org

2 edits
3 moves
29 adds
3 deletes in trunk/LayoutTests

Land chromium baselines for tests added in r94912.

fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt.
fast/borders/inline-mask-overlay-image-outset-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/inline-mask-overlay-image-outset-expected.txt.
fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt.
platform/chromium-cg-mac-snowleopard/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
platform/chromium-cg-mac-snowleopard/fast/borders/border-image-outset-expected.png: Added.
platform/chromium-cg-mac-snowleopard/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
platform/chromium-cg-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
platform/chromium-cg-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
platform/chromium-linux/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
platform/chromium-linux/fast/borders/border-image-outset-expected.png: Added.
platform/chromium-linux/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
platform/chromium-mac-leopard/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
platform/chromium-mac-snowleopard/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
platform/chromium-mac-snowleopard/fast/borders/border-image-outset-expected.png: Added.
platform/chromium-mac-snowleopard/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
platform/chromium-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
platform/chromium-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
platform/chromium-win/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
platform/chromium-win/fast/borders/block-mask-overlay-image-outset-expected.txt: Added.
platform/chromium-win/fast/borders/border-image-outset-expected.png: Added.
platform/chromium-win/fast/borders/border-image-outset-expected.txt: Added.
platform/chromium-win/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
platform/chromium-win/fast/borders/border-image-outset-in-shorthand-expected.txt: Added.
platform/chromium-win/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-expected.txt: Added.
platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt: Added.
platform/chromium/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
platform/chromium/test_expectations.txt:
platform/mac/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Removed.
platform/mac/fast/borders/inline-mask-overlay-image-outset-expected.txt: Removed.
platform/mac/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt: Removed.

3:42 PM Changeset in webkit [99110] by annacc@chromium.org

7 edits
64 deletes in trunk/LayoutTests

Remove <track>-related LayoutTests that don't actually work yet.
https://bugs.webkit.org/show_bug.cgi?id=71378

Reviewed by Eric Carlson.

media/track/track-mutable-expected.txt: Removed.
media/track/track-mutable.html: Removed.
media/track/track-text-track-cue-list-expected.txt: Removed.
media/track/track-text-track-cue-list.html: Removed.
media/track/track-text-track-expected.txt: Removed.
media/track/track-text-track.html: Removed.
media/track/track-webvtt-tc000-empty-expected.txt: Removed.
media/track/track-webvtt-tc000-empty.html: Removed.
media/track/track-webvtt-tc001-utf8-expected.txt: Removed.
media/track/track-webvtt-tc001-utf8.html: Removed.
media/track/track-webvtt-tc002-bom-expected.txt: Removed.
media/track/track-webvtt-tc002-bom.html: Removed.
media/track/track-webvtt-tc003-newlines-expected.txt: Removed.
media/track/track-webvtt-tc003-newlines.html: Removed.
media/track/track-webvtt-tc004-magic-header-expected.txt: Removed.
media/track/track-webvtt-tc004-magic-header.html: Removed.
media/track/track-webvtt-tc005-header-comment-expected.txt: Removed.
media/track/track-webvtt-tc005-header-comment.html: Removed.
media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Removed.
media/track/track-webvtt-tc006-cue-identifiers.html: Removed.
media/track/track-webvtt-tc007-cue-no-id-expected.txt: Removed.
media/track/track-webvtt-tc007-cue-no-id.html: Removed.
media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Removed.
media/track/track-webvtt-tc008-timings-no-hours.html: Removed.
media/track/track-webvtt-tc009-timings-hour-expected.txt: Removed.
media/track/track-webvtt-tc009-timings-hour.html: Removed.
media/track/track-webvtt-tc010-no-timings-expected.txt: Removed.
media/track/track-webvtt-tc010-no-timings.html: Removed.
media/track/track-webvtt-tc011-blank-lines-expected.txt: Removed.
media/track/track-webvtt-tc011-blank-lines.html: Removed.
media/track/track-webvtt-tc012-out-of-order-expected.txt: Removed.
media/track/track-webvtt-tc012-out-of-order.html: Removed.
media/track/track-webvtt-tc013-settings-expected.txt: Removed.
media/track/track-webvtt-tc013-settings.html: Removed.
media/track/track-webvtt-tc014-alignment-expected.txt: Removed.
media/track/track-webvtt-tc014-alignment.html: Removed.
media/track/track-webvtt-tc015-positioning-expected.txt: Removed.
media/track/track-webvtt-tc015-positioning.html: Removed.
media/track/track-webvtt-tc016-align-positioning-expected.txt: Removed.
media/track/track-webvtt-tc016-align-positioning.html: Removed.
media/track/track-webvtt-tc017-line-position-expected.txt: Removed.
media/track/track-webvtt-tc017-line-position.html: Removed.
media/track/track-webvtt-tc018-align-text-line-position-expected.txt: Removed.
media/track/track-webvtt-tc018-align-text-line-position.html: Removed.
media/track/track-webvtt-tc019-cue-size-expected.txt: Removed.
media/track/track-webvtt-tc019-cue-size.html: Removed.
media/track/track-webvtt-tc020-cue-size-align-expected.txt: Removed.
media/track/track-webvtt-tc020-cue-size-align.html: Removed.
media/track/track-webvtt-tc021-valign-expected.txt: Removed.
media/track/track-webvtt-tc021-valign.html: Removed.
media/track/track-webvtt-tc022-entities-expected.txt: Removed.
media/track/track-webvtt-tc022-entities.html: Removed.
media/track/track-webvtt-tc023-markup-expected.txt: Removed.
media/track/track-webvtt-tc023-markup.html: Removed.
media/track/track-webvtt-tc024-timestamp-expected.txt: Removed.
media/track/track-webvtt-tc024-timestamp.html: Removed.
media/track/track-webvtt-tc025-class-markup-expected.txt: Removed.
media/track/track-webvtt-tc025-class-markup.html: Removed.
media/track/track-webvtt-tc026-voice-expected.txt: Removed.
media/track/track-webvtt-tc026-voice.html: Removed.
media/track/track-webvtt-tc027-empty-cue-expected.txt: Removed.
media/track/track-webvtt-tc027-empty-cue.html: Removed.
media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Removed.
media/track/track-webvtt-tc028-unsupported-markup.html: Removed.

platform/chromium/test_expectations.txt: Remove all, remaining tests currently pass.
platform/gtk/Skipped: Remove all, remaining tests currently pass.
platform/mac/Skipped: Make sure all are skipped, <track> not enabled.
platform/qt/Skipped: Remove all, remaining tests currently pass.
platform/win/Skipped: Make sure all are skipped, <track> not enabled.
platform/wk2/Skipped: Remove all, remaining tests currently pass.

3:35 PM Changeset in webkit [99109] by leviw@chromium.org

4 edits
3 adds in trunk

Infinite recursion in RenderSVGResourceContainer::markAllClientsForInvalidation
https://bugs.webkit.org/show_bug.cgi?id=71384

Reviewed by Darin Adler.

Source/WebCore:

Adding a reentrancy guard to RenderSVGResourceContainer to prevent infinite recursion when
resources reference one another and share ids.

Test: svg/custom/resource-invalidation-crash.svg

rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation):

rendering/svg/RenderSVGResourceContainer.h:

LayoutTests:

Fixes a stack overflow when SVG resources reference one another and share ids.

svg/custom/resource-invalidation-crash-expected.png: Added.
svg/custom/resource-invalidation-crash-expected.txt: Added.
svg/custom/resource-invalidation-crash.svg: Added.

3:32 PM Changeset in webkit [99108] by jonlee@apple.com

35 edits
1 copy in trunk

Expand DragController to provide more information about the dragging session
https://bugs.webkit.org/show_bug.cgi?id=71324
<rdar://problem/10379175>

Reviewed by Darin Adler.

Source/WebCore:

WebCore.xcodeproj/project.pbxproj:
page/DragController.cpp:

(WebCore::DragController::dragEntered):
(WebCore::DragController::dragUpdated):
(WebCore::DragController::dragEnteredOrUpdated):
(WebCore::DragController::tryDocumentDrag): In addition to determining the
drag operation, DragSession is updated with data regarding whether the mouse
is over a file input, and the number of items that would be accepted based on
the mouse's location.

page/DragController.h:
page/DragSession.h: Added.

(WebCore::DragSession::DragSession): Keep track of current operation, whether
the mouse is over a file input element, and how many files would be accepted if
dropped.

platform/DragData.h: Added numberOfFiles()
platform/chromium/DragDataChromium.cpp: