⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 4, 2011:

10:50 PM Changeset in webkit [99350] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Update a timing out gpu test.

  • platform/chromium/test_expectations.txt:
6:59 PM Changeset in webkit [99349] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

Canvas drawImage(canvas) with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
​https://bugs.webkit.org/show_bug.cgi?id=71537

Patch by Ben Wells <​benwells@chromium.org> on 2011-11-04
Reviewed by Stephen White.

Source/WebCore:

drawImage(canvas) now uses the same approach as drawImage(image) to fix these errors.

Test: fast/canvas/canvas-composite-canvas.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::drawImageToContext):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):

  • html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

  • fast/canvas/canvas-composite-canvas-expected.txt: Added.
  • fast/canvas/canvas-composite-canvas.html: Added.
  • fast/canvas/canvas-composite-image.html:
  • fast/canvas/resources/canvas-composite-image-common.js: Added.
6:35 PM Changeset in webkit [99348] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/874

Merge 98763
BUG=99597
Review URL: ​http://codereview.chromium.org/8478022

6:32 PM Changeset in webkit [99347] by abarth@webkit.org
  • 16 edits in trunk

JavaScript URLs execute in sandboxed iframes
​https://bugs.webkit.org/show_bug.cgi?id=71599

Reviewed by Eric Seidel.

Source/WebCore:

This patch fixes the intentional regression I introduced earlier today
by moving the sandbox bits from SecurityOrigin to Document. In the
process, I renamed SecurityOrigin::createEmpty to
SecurityOrigin::createUnique to better align with HTML5 terminology.

  • WebCore.exp.in:
  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):

  • dom/Document.cpp:

(WebCore::Document::setIsViewSource):
(WebCore::Document::initSecurityContext):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext):

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::sandboxFlags):
(WebCore::ScriptExecutionContext::enforceSandboxFlags):
(WebCore::ScriptExecutionContext::isSandboxed):

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::canEmbedJava):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

  • loader/FrameLoader.cpp:

(WebCore::isDocumentSandboxed):
(WebCore::FrameLoader::addHTTPOriginIfNeeded):

  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNewWindowPolicy):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestPlugin):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::create):
(WebCore::SecurityOrigin::createUnique):

  • page/SecurityOrigin.h:

LayoutTests:

Update results to show progression.

  • fast/frames/sandboxed-iframe-scripting-expected.txt:
  • fast/frames/sandboxed-iframe-scripting.html:
6:30 PM Changeset in webkit [99346] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/874

Merge 98561
BUG=100526
Review URL: ​http://codereview.chromium.org/8480023

6:26 PM Changeset in webkit [99345] by cevans@google.com
  • 5 edits
    5 copies in branches/chromium/874

Merge 98033
BUG=99603
Review URL: ​http://codereview.chromium.org/8477022

6:26 PM Changeset in webkit [99344] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Potential Unused Param Build Issue
​https://bugs.webkit.org/show_bug.cgi?id=71598

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2011-11-04
Reviewed by Kent Tamura.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::platformHandleKeydownEvent):

6:20 PM Changeset in webkit [99343] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/874

Merge 98010
BUG=100177
Review URL: ​http://codereview.chromium.org/8474016

6:00 PM Changeset in webkit [99342] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/874

Merge 98935
BUG=101018
Review URL: ​http://codereview.chromium.org/8479023

5:58 PM Changeset in webkit [99341] by eric@webkit.org
  • 2 edits in trunk/Tools

Upgrade to the latest Mechanize
​https://bugs.webkit.org/show_bug.cgi?id=71594

Reviewed by Adam Barth.

I noticed our mechanize was somewhat out of date when removing Python 2.5 support.
Mechanize is no longer two separate libraries, so importing it is much simpler.

  • Scripts/webkitpy/thirdparty/init.py:
5:58 PM Changeset in webkit [99340] by cevans@google.com
  • 1 edit in branches/chromium/874/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp

Merge 98796
BUG=102242
Review URL: ​http://codereview.chromium.org/8479022

5:51 PM Changeset in webkit [99339] by commit-queue@webkit.org
  • 8 edits
    23 adds in trunk

Crash in ScrollAnimator.cpp
​https://bugs.webkit.org/show_bug.cgi?id=69865

The code in ScrollAnimator assumes that horizontal per-page mouse
wheel events cannot happen, which is not true. This patch adds layout
tests for all paging wheel event situations and fixes the broken
horizontal case.

Source/WebCore:

Patch by Stephen Chenney <​schenney@chromium.org> on 2011-11-04
Reviewed by Anders Carlsson

Tests: fast/events/platform-wheelevent-paging-x-in-non-scrolling-div.html

fast/events/platform-wheelevent-paging-x-in-non-scrolling-page.html
fast/events/platform-wheelevent-paging-x-in-scrolling-div.html
fast/events/platform-wheelevent-paging-x-in-scrolling-page.html
fast/events/platform-wheelevent-paging-xy-in-scrolling-div.html
fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html
fast/events/platform-wheelevent-paging-y-in-non-scrolling-div.html
fast/events/platform-wheelevent-paging-y-in-non-scrolling-page.html
fast/events/platform-wheelevent-paging-y-in-scrolling-div.html
fast/events/platform-wheelevent-paging-y-in-scrolling-page.html

  • platform/PlatformWheelEvent.h: Modify the comment to reflect the new

reality.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent): Modified the code to handle the
horizontal per-page wheel event case.

Tools:

Patch by Stephen Chenney <​schenney@chromium.org> on 2011-11-04
Reviewed by Anders Carlsson

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::handleMouseWheel): Added the ability to specify that a
mouse wheel event should be paging.

LayoutTests:

Patch by Stephen Chenney <​schenney@chromium.org> on 2011-11-04
Reviewed by Anders Carlsson

  • fast/events/platform-wheelevent-paging-x-in-non-scrolling-div-expected.txt: Added.
  • fast/events/platform-wheelevent-paging-x-in-non-scrolling-div.html: Added.
  • fast/events/platform-wheelevent-paging-x-in-non-scrolling-page-expected.txt: Added.
  • fast/events/platform-wheelevent-paging-x-in-non-scrolling-page.html: Added.
  • fast/events/platform-wheelevent-paging-x-in-scrolling-div-expected.txt: Added.
  • fast/events/platform-wheelevent-paging-x-in-scrolling-div.html: Added.
  • fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt: Added.
  • fast/events/platform-wheelevent-paging-x-in-scrolling-page.html: Added.
  • fast/events/platform-wheelevent-paging-xy-in-scrolling-div-expected.txt: Added.
  • fast/events/platform-wheelevent-paging-xy-in-scrolling-div.html: Added.
  • fast/events/platform-wheelevent-paging-xy-in-scrolling-page-expected.txt: Added.
  • fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html: Added.
  • fast/events/platform-wheelevent-paging-y-in-non-scrolling-div-expected.txt: Added.
  • fast/events/platform-wheelevent-paging-y-in-non-scrolling-div.html: Added.
  • fast/events/platform-wheelevent-paging-y-in-non-scrolling-page-expected.txt: Added.
  • fast/events/platform-wheelevent-paging-y-in-non-scrolling-page.html: Added.
  • fast/events/platform-wheelevent-paging-y-in-scrolling-div-expected.txt: Added.
  • fast/events/platform-wheelevent-paging-y-in-scrolling-div.html: Added.
  • fast/events/platform-wheelevent-paging-y-in-scrolling-page-expected.txt: Added.
  • fast/events/platform-wheelevent-paging-y-in-scrolling-page.html: Added.
  • platform/chromium-mac/fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt: Added.
  • platform/chromium-mac/fast/events/platform-wheelevent-paging-xy-in-scrolling-page-expected.txt: Added.
  • platform/chromium-mac/fast/events/platform-wheelevent-paging-y-in-scrolling-page-expected.txt: Added.
  • platform/mac/Skipped: Added skip for the new tests, as the platform

does not support it.

  • platform/win/Skipped: Added skip for the new tests, as the platform

does not support it.

5:44 PM Changeset in webkit [99338] by commit-queue@webkit.org
  • 14 edits
    1 copy
    1 add in trunk/Source/WebCore

[MutationObservers] Refactor MutationObserverRegistration into its own class that is
referenced by registration points

​https://bugs.webkit.org/show_bug.cgi?id=71577

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-11-04
Reviewed by Ojan Vafai.

MutationObserverRegistration is now owned by the node which is observed. If transient
registrations are created, they hold a reference to this object.

The ownership relationship between Node, MutationObserverRegistration &
WebKitMutationObserver now goes like this: WebKitMutationObserver is RefCounted -
and only script and MutationObserverRegistration take references to it. Exactly
one MutationObserverRegistration can exist for any given tuple of
<Node, WebKitMutationObserver>. This represents an observer observing at a given
Node. Further observation by the same observer has the effect of *resetting*
the existing observation. The Node owns the MutationObserverRegistration.
Transient registrations are only pointers to the registration. The registration
keeps a RefPtr to its registration node and all of its transient registration nodes
as long as *any* transient registrations exist. This ensures the registration
and all registration nodes stay alive at least until the end of the microtask.

No tests required - refactor only.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/CharacterData.cpp:

(WebCore::enqueueCharacterDataMutationRecord):

  • dom/ChildListMutationScope.cpp:

(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):

  • dom/Element.cpp:

(WebCore::enqueueAttributesMutationRecord):

  • dom/MutationObserverRegistration.cpp: Added.

(WebCore::MutationObserverRegistration::create):
(WebCore::MutationObserverRegistration::MutationObserverRegistration):
(WebCore::MutationObserverRegistration::~MutationObserverRegistration):
(WebCore::MutationObserverRegistration::resetObservation):
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
(WebCore::MutationObserverRegistration::clearTransientRegistrations):
(WebCore::MutationObserverRegistration::unregister):
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):

  • dom/MutationObserverRegistration.h: Copied from Source/WebCore/dom/WebKitMutationObserver.h.

(WebCore::MutationObserverRegistration::observer):
(WebCore::MutationObserverRegistration::deliveryOptions):

  • dom/Node.cpp:

(WebCore::Node::clearRareData):
(WebCore::Node::mutationObserverRegistry):
(WebCore::Node::transientMutationObserverRegistry):
(WebCore::addObserverToDeliverySet):
(WebCore::Node::collectMatchingObserversForMutation):
(WebCore::Node::getRegisteredMutationObserversOfType):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::unregisterMutationObserver):
(WebCore::Node::registerTransientMutationObserver):
(WebCore::Node::unregisterTransientMutationObserver):
(WebCore::Node::notifyMutationObserversNodeWillDetach):

  • dom/Node.h:
  • dom/NodeRareData.h:

(WebCore::NodeRareData::mutationObserverRegistry):
(WebCore::NodeRareData::ensureMutationObserverRegistry):
(WebCore::NodeRareData::transientMutationObserverRegistry):
(WebCore::NodeRareData::ensureTransientMutationObserverRegistry):

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::~WebKitMutationObserver):
(WebCore::WebKitMutationObserver::observe):
(WebCore::WebKitMutationObserver::disconnect):
(WebCore::WebKitMutationObserver::observationStarted):
(WebCore::WebKitMutationObserver::observationEnded):
(WebCore::WebKitMutationObserver::deliver):

  • dom/WebKitMutationObserver.h:
5:34 PM Changeset in webkit [99337] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

Add methods to compute magnitude and phase response for biquads
​https://bugs.webkit.org/show_bug.cgi?id=71055

Reviewed by Kenneth Russell.

Patch by Raymond Toy <Raymond Toy> on 2011-11-04

  • platform/audio/Biquad.cpp:

(WebCore::Biquad::getFrequencyResponse):
Computes the magnitude and phase (radians) response for the given
biquad at the specified set of (normalized) frequencies.

  • platform/audio/Biquad.h:

Declare getFrequencyResponse.

  • webaudio/BiquadDSPKernel.cpp:

(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):
Factor out the code that updates filter coefficients. Allow the
caller to specify whether the smoothed values are used or not and
whether we do the update even if the coefficients are not dirty.
(WebCore::BiquadDSPKernel::process):
Use updateCoefficientsIfNecessary to update.
(WebCore::BiquadDSPKernel::getFrequencyResponse):
Implmentation of getFrequencyResponse.

  • webaudio/BiquadDSPKernel.h:

Declare getFrequencyResponse.

  • webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::getFrequencyResponse):
Implementation of getFrequencyResponse

  • webaudio/BiquadFilterNode.h:

Declare getFrequencyResponse.

  • webaudio/BiquadFilterNode.idl:

Define interface to getFrequencyResponse.

  • webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::checkForDirtyCoefficients):
Factor out code for checking for dirty coefficients.
(WebCore::BiquadProcessor::process):
Use checkForDirtyCoefficients.
(WebCore::BiquadProcessor::getFrequencyResponse):
Implementation of getFrequencyResponse

  • webaudio/BiquadProcessor.h:

Declare getFrequencyResponse.

5:29 PM Changeset in webkit [99336] by commit-queue@webkit.org
  • 2 edits
    2 moves
    5 adds in trunk/LayoutTests

Baselines for new test introduced in r99043
​https://bugs.webkit.org/show_bug.cgi?id=71528

Patch by Ben Wells <​benwells@chromium.org> on 2011-11-04
Reviewed by Kenneth Russell.

  • platform/chromium-cg-mac-snowleopard/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
  • platform/chromium-gpu-mac/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-fill-repaint-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/fast/canvas/canvas-composite-fill-repaint-expected.png.
  • platform/chromium-mac-snowleopard/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
  • platform/chromium-win/fast/canvas/canvas-composite-fill-repaint-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/canvas/canvas-composite-fill-repaint-expected.png.
  • platform/chromium/test_expectations.txt:
5:27 PM Changeset in webkit [99335] by eric@webkit.org
  • 2 edits in trunk/Tools

Remove deprecated free functions in port.factory
​https://bugs.webkit.org/show_bug.cgi?id=71494

Unreviewed. Fix exception when running new-run-webkit-httpd.

  • Scripts/new-run-webkit-httpd:
5:02 PM Changeset in webkit [99334] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Mac] ResourceRequest's nsURLRequest() does not differentiate null and empty URLs with CFNetwork
​https://bugs.webkit.org/show_bug.cgi?id=71539

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2011-11-04
Reviewed by David Kilzer.

In order to have CFURL and NSURL to be consistent when both are used on Mac,
KURL::createCFURL() is changed to support empty URL values.

  • platform/cf/KURLCFNet.cpp:

(WebCore::createCFURLFromBuffer):
(WebCore::KURL::createCFURL):

  • platform/mac/KURLMac.mm:

(WebCore::KURL::operator NSURL *):
(WebCore::KURL::createCFURL):

4:51 PM Changeset in webkit [99333] by psolanki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

sqrtDouble and andnotDouble should be declared noreturn
​https://bugs.webkit.org/show_bug.cgi?id=71592

Reviewed by Sam Weinig.

  • assembler/MacroAssemblerARMv7.h:
4:07 PM Changeset in webkit [99332] by fsamuel@chromium.org
  • 15 edits
    4 adds in trunk

CSS Aspect Ratio Property Parsing Stage
​https://bugs.webkit.org/show_bug.cgi?id=70707

Reviewed by Ojan Vafai.

Source/WebCore:

Added parsing support for -webkit-aspect-ratio CSS property.
The spec can be found here: ​http://www.xanthir.com/blog/b4810

Test: fast/css/aspect-ratio-parsing-tests.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAspectRatioValue.cpp: Added.

(WebCore::CSSAspectRatioValue::~CSSAspectRatioValue):
(WebCore::CSSAspectRatioValue::cssText):

  • css/CSSAspectRatioValue.h: Added.

(WebCore::CSSAspectRatioValue::create):
(WebCore::CSSAspectRatioValue::numeratorValue):
(WebCore::CSSAspectRatioValue::denominatorValue):
(WebCore::CSSAspectRatioValue::CSSAspectRatioValue):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSMutableStyleDeclaration.cpp:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseAspectRatio):

  • css/CSSParser.h:
  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

  • fast/css/aspect-ratio-parsing-tests-expected.txt: Added.
  • fast/css/aspect-ratio-parsing-tests.html: Added.
3:52 PM Changeset in webkit [99331] by Adam Roben
  • 2 edits in trunk/Tools

Remove Leopard-specific code from build.webkit.org

We don't have any Leopard bots anymore.

Fixes <​http://webkit.org/b/71583> build.webkit.org configuration contains obsolete Leopard code

Reviewed by Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed now-unused StartATSServer

and StopATSServer steps.
(unitTestsSupported): Removed check for mac-leopard.
(TestFactory.init): Removed Leopard-specific steps.

3:50 PM Changeset in webkit [99330] by abarth@webkit.org
  • 9 edits in trunk

Delete FrameLoader::isSandboxed
​https://bugs.webkit.org/show_bug.cgi?id=71591

Reviewed by Eric Seidel.

Source/WebCore:

We should always use document->securityOrigin()->isSandboxed because
that picks up the sandbox bits that are frozen on the document rather
than the ones that could change on the Frame.

This patch starts preparing us to implement the CSP sandbox directive,
which will cause use to have document sandbox bits without any attribute.

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):

  • This call site was the only functional site left where these two could be different. This patch causes one progression and one regression. The progression is that we now correctly freeze the allow-scripts bit when a document is created, but the regression is we now allow the execution of JavaScript URLs, as noted in fast/frames/sandboxed-iframe-scripting.html. That's even more of an edge case, so I think it's a win overall.
  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

  • I don't think this part of the change is testable. There's no time to execute script between when the bits get copied off the Frame and when they're checked, so there's no time to change them.
  • loader/FrameLoader.cpp:
    • Update FIXME comment that is now fixed.
  • loader/FrameLoader.h:
    • Remove wrong API.

LayoutTests:

This patch updates this test to check a few more cases and notes a bug
in our current implementation.

  • fast/frames/resources/sandboxed-iframe-script-dynamic.html:
  • fast/frames/sandboxed-iframe-scripting-expected.txt:
  • fast/frames/sandboxed-iframe-scripting.html:
3:32 PM Changeset in webkit [99329] by abarth@webkit.org
  • 3 edits
    4 adds in trunk

When CSP blocks mixed content, we shouldn't also warn about mixed content
​https://bugs.webkit.org/show_bug.cgi?id=71588

Reviewed by Eric Seidel.

Source/WebCore:

Getting both warnings confused some early adopters. They thought the
insecure loads were happening even though they blocked them with CSP.
This patch restricts the mixed content warnings to show only when the
load isn't already blocked by CSP or by the embedder.

Test: http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning.html

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):

LayoutTests:

These tests check what kinds of warnings we generate when blocking insecure scripts with CSP.

  • http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/alert-fail.js: Added.
  • http/tests/security/contentSecurityPolicy/resources/mixed-content-with-csp.html: Added.
3:24 PM Changeset in webkit [99328] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Allow ScriptExecutionContext::addMessage to be called from background threads.
​https://bugs.webkit.org/show_bug.cgi?id=71575

Patch by Michael Nordman <​michaeln@google.coom> on 2011-11-04
Reviewed by Nate Chapin.

No new tests.

  • dom/Document.cpp:

(WebCore::Document::addMessage):

  • dom/ScriptExecutionContext.cpp:
  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::AddConsoleMessageTask::create):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::performTask):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::AddConsoleMessageTask):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::addMessage):

3:16 PM Changeset in webkit [99327] by commit-queue@webkit.org
  • 16 edits in trunk/Source

[chromium] Re-named the original scissorRect to clipRect
​https://bugs.webkit.org/show_bug.cgi?id=71580

Patch by Shawn Singh <​shawnsingh@chromium.org> on 2011-11-04
Reviewed by James Robinson.

Source/WebCore:

Existing tests are updated appropriately; and no new behavior is
introduced by this patch.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setUsesLayerClipping):
(WebCore::LayerChromium::usesLayerClipping):
(WebCore::LayerChromium::clipRect):
(WebCore::LayerChromium::setClipRect):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore::RenderSurfaceChromium::clipRect):
(WebCore::RenderSurfaceChromium::setClipRect):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::setUsesLayerClipping):
(WebCore::CCLayerImpl::usesLayerClipping):
(WebCore::CCLayerImpl::clipRect):
(WebCore::CCLayerImpl::setClipRect):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::layerShouldBeSkipped):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::draw):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore::CCRenderSurface::setClipRect):
(WebCore::CCRenderSurface::clipRect):

Source/WebKit/chromium:

  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):

  • tests/LayerChromiumTest.cpp:
3:09 PM Changeset in webkit [99326] by eric@webkit.org
  • 7 edits in trunk/Tools

new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
​https://bugs.webkit.org/show_bug.cgi?id=71549

Reviewed by Adam Barth.

Several members of Host didn't really belong there
and were instead specific to WebKitPatch, so I've moved
them up onto that class.

  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/common/host_mock.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/runtests_unittest.py:
3:01 PM Changeset in webkit [99325] by tony@chromium.org
  • 6 edits
    1 move in trunk/Tools

garden-o-matic: bring back party time!
​https://bugs.webkit.org/show_bug.cgi?id=71582

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.
2:43 PM Changeset in webkit [99324] by dslomov@google.com
  • 8 edits in trunk/Source/WebCore

Add the ability to transfer ArrayBuffer and "neuter" it.
​https://bugs.webkit.org/show_bug.cgi?id=71535

Reviewed by David Levin.

  • html/canvas/ArrayBuffer.cpp:

(WebCore::ArrayBuffer::create):
(WebCore::ArrayBuffer::ArrayBuffer):
(WebCore::ArrayBuffer::data):
(WebCore::ArrayBuffer::byteLength):
(WebCore::ArrayBuffer::transfer):
(WebCore::ArrayBufferContents::~ArrayBufferContents):
(WebCore::ArrayBufferContents::tryAllocate):
(WebCore::ArrayBuffer::addView):
(WebCore::ArrayBuffer::removeView):

  • html/canvas/ArrayBuffer.h:

(WebCore::ArrayBufferContents::ArrayBufferContents):
(WebCore::ArrayBufferContents::data):
(WebCore::ArrayBufferContents::sizeInBytes):
(WebCore::ArrayBufferContents::release):
(WebCore::ArrayBuffer::~ArrayBuffer):

  • html/canvas/ArrayBufferView.cpp:

(WebCore::ArrayBufferView::ArrayBufferView):
(WebCore::ArrayBufferView::~ArrayBufferView):
(WebCore::ArrayBufferView::neuter):

  • html/canvas/ArrayBufferView.h:
  • html/canvas/DataView.cpp:

(WebCore::DataView::neuter):
(WebCore::DataView::neuterBinding):

  • html/canvas/DataView.h:
  • html/canvas/TypedArrayBase.h:

(WebCore::TypedArrayBase::neuter):
(WebCore::TypedArrayBase::neuterBinding):

2:42 PM Changeset in webkit [99323] by commit-queue@webkit.org
  • 2 edits
    5 copies
    6 moves
    2 adds in trunk/LayoutTests

Unreviewed, rolling out r99315.
​http://trac.webkit.org/changeset/99315
​https://bugs.webkit.org/show_bug.cgi?id=71589

baselines still broken after running rebaseline script
(Requested by enne on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-04

  • platform/chromium-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/chromium-gpu-cg-mac/compositing/geometry/fixed-position-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/fixed-position-expected.png.
  • platform/chromium-gpu-cg-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/horizontal-scroll-composited-expected.png.
  • platform/chromium-gpu-cg-mac/compositing/geometry/vertical-scroll-composited-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/vertical-scroll-composited-expected.png.
  • platform/chromium-gpu-cg-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/overflow/fixed-position-ancestor-clip-expected.png.
  • platform/chromium-gpu-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/geometry/fixed-position-expected.png.
  • platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/geometry/horizontal-scroll-composited-expected.png.
  • platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/geometry/vertical-scroll-composited-expected.png.
  • platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/overflow/fixed-position-ancestor-clip-expected.png.
  • platform/chromium-gpu-mac/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:39 PM Changeset in webkit [99322] by Philippe Normand
  • 4 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r99285.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
2:32 PM Changeset in webkit [99321] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add a test for how CSP interacts with about:blank iframes
​https://bugs.webkit.org/show_bug.cgi?id=71578

Reviewed by Dimitri Glazkov.

This issue came up in the discussion on
​http://code.google.com/p/chromium/issues/detail?id=103038. This patch
just adds a test to make sure we don't regress.

  • http/tests/security/contentSecurityPolicy/frame-src-about-blank-allowed-by-scheme-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/frame-src-about-blank-allowed-by-scheme.html: Added.
2:27 PM Changeset in webkit [99320] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

stop running perf LayoutTests in debug builds
​https://bugs.webkit.org/show_bug.cgi?id=71513

Reviewed by Ojan Vafai.

This allows us to get rid of SLOW on some perf tests.

  • platform/chromium/test_expectations.txt:
2:14 PM Changeset in webkit [99319] by noel.gordon@gmail.com
  • 10 edits
    4 adds in trunk

[Chromium] Implement canvas.toDataURL("image/webp")
​https://bugs.webkit.org/show_bug.cgi?id=70172

Reviewed by Adam Barth.

Source/WebCore:

Add a webp image encoder for the chromium skia ports, add it to the canvas
element toDataURL() flow with support for an optional quality [0.0-1.0].
Use a webp compression method (3) that provides good speed and compression
performance for this image format, and works well for various input image
types: line-art, screen-shots, and photographic images.

Test: fast/canvas/canvas-toDataURL-webp.html

  • WebCore.gypi:
  • platform/chromium/MIMETypeRegistryChromium.cpp:

(WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageToDataURL):

  • platform/image-encoders/skia/WEBPImageEncoder.cpp: Added.

(WebCore::writeOutput):
(WebCore::importPicture):
(WebCore::importPictureBGRA):
(WebCore::importPictureRGBA):
(WebCore::encodePixels):
(WebCore::WEBPImageEncoder::encode):

  • platform/image-encoders/skia/WEBPImageEncoder.h: Added.

LayoutTests:

  • fast/canvas/canvas-toDataURL-webp-expected.txt: Added.
  • fast/canvas/canvas-toDataURL-webp.html: Added.
  • platform/chromium/test_expectations.txt: skip test on MAC CPU-CG (CoreGraphics)
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
2:04 PM Changeset in webkit [99318] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] DRT: Fix the order of the items in the dumped history list.
​https://bugs.webkit.org/show_bug.cgi?id=71562

It did not make much sense to hold the history list in a map, as we do not need
the keys. And the printed items must be sorted by target, which is more easily
done with a vector.

Should make tests such as http/tests/navigation/error404-frames.html pass.

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-11-04
Reviewed by Antonio Gomes.

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::childHistoryItems):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

  • DumpRenderTree/efl/DumpHistoryItem.cpp:

(compareHistoryItemsByTarget):
(dumpHistoryItem):

2:00 PM Changeset in webkit [99317] by Patrick Gansterer
  • 5 edits in trunk

[Qt] Remove ENABLE_SQLITE from qmake files
​https://bugs.webkit.org/show_bug.cgi?id=71546

Reviewed by Simon Hausmann.

Source/WebCore:

ENABLE_SQLITE is required to build WebCore, so remove conditions.

  • Target.pri:

Tools:

  • qmake/mkspecs/features/features.prf:
  • qmake/mkspecs/features/webcore.prf:
1:58 PM Changeset in webkit [99316] by arv@chromium.org
  • 3 edits in trunk/LayoutTests

Layout Test storage/indexeddb/exception-in-event-aborts.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=71536

Unreviewed. Updated test and expectations.

  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/exception-in-event-aborts.html:
1:55 PM Changeset in webkit [99315] by enne@google.com
  • 2 edits
    6 moves
    3 adds
    7 deletes in trunk/LayoutTests

[chromium] Unreviewed expectation rebaseline from r99286.

  • platform/chromium-cg-mac-snowleopard/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png: Removed.
  • platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Removed.
  • platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png: Removed.
  • platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Removed.
  • platform/chromium-gpu-mac/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.txt: Removed.
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/fixed-position-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/geometry/fixed-position-expected.png.
  • platform/chromium-gpu/compositing/geometry/horizontal-scroll-composited-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/geometry/horizontal-scroll-composited-expected.png.
  • platform/chromium-gpu/compositing/geometry/vertical-scroll-composited-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/geometry/vertical-scroll-composited-expected.png.
  • platform/chromium-gpu/compositing/overflow/fixed-position-ancestor-clip-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png.
  • platform/chromium-gpu/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/chromium/test_expectations.txt:
1:48 PM Changeset in webkit [99314] by abarth@webkit.org
  • 2 edits in trunk/Tools

watchlist for WebIDL shouldn't trigger on Internals.idl
​https://bugs.webkit.org/show_bug.cgi?id=70657

Reviewed by David Levin.

Internals.idl isn't part of the Web-facing IDL in the project.

  • Scripts/webkitpy/common/config/watchlist:
1:43 PM Changeset in webkit [99313] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] comment out duplicate suppressions for compositing/zoom-animator-scale-test2.html
​https://bugs.webkit.org/show_bug.cgi?id=71587

  • platform/chromium/test_expectations.txt:
1:37 PM Changeset in webkit [99312] by mhahnenberg@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

De-virtualize JSObject::hasInstance
​https://bugs.webkit.org/show_bug.cgi?id=71430

Reviewed by Darin Adler.

Added hasInstance to the MethodTable, changed all the virtual
implementations of hasInstance to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::hasInstance):

  • API/JSValueRef.cpp:

(JSValueIsInstanceOfConstructor):

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ClassInfo.h:
  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::hasInstance):

  • runtime/JSBoundFunction.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::hasInstance):

  • runtime/JSCell.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::hasInstance):

  • runtime/JSObject.h:
1:24 PM Changeset in webkit [99311] by Nate Chapin
  • 3 edits in trunk/Source/WebCore

[V8] Null out V8NPObject::rootObject when the owning
Frame goes away.
​https://bugs.webkit.org/show_bug.cgi?id=71569

Reviewed by Adam Barth.

No new tests, this has only been successfully triggered
using ppapi flash.

  • bindings/v8/V8Helpers.cpp:

(WebCore::toV8Context):

  • bindings/v8/npruntime.cpp:
12:53 PM Changeset in webkit [99310] by commit-queue@webkit.org
  • 4 edits
    21 adds in trunk

Send the submissions character encoding in hidden _charset_ field.
​https://bugs.webkit.org/show_bug.cgi?id=19079

Patch by Vineet Chaudhary <​vineet.chaudhary@motorola.com> on 2011-11-04
Reviewed by Darin Adler.

Source/WebCore:

Spec reference ​http://dev.w3.org/html5/spec/Overview.html#attr-fe-name-charset
If _charset_ used as the name of a hidden control it should send character encoding
as value while submissions.

Tests: http/tests/misc/char-encoding-in-hidden-charset-field-default.html

http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field.html
http/tests/misc/char-encoding-in-text-charset-field-with-value.html
http/tests/misc/char-encoding-without-charset-field.html

  • html/HiddenInputType.cpp:

(WebCore::HiddenInputType::isHiddenType):
(WebCore::HiddenInputType::appendFormData): For _charset_ send value as respective encodingType.

  • html/HiddenInputType.h: Override appendFormData for hidden control types.

LayoutTests:

Spec reference ​http://dev.w3.org/html5/spec/Overview.html#attr-fe-name-charset
If _charset_ used as the name of a hidden control it should send character encoding
as value while submissions.
Added test cases to check this behavior.

  • http/tests/misc/char-encoding-in-hidden-charset-field-default-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-default.html: Added. For Default Encoding.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5.html: Added. For Big5 Encoding.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP.html: Added. For EUC-JP Encoding.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP.html: Added. For ISO-2022-JP Encoding.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS.html: Added. For Shift_JIS Encoding.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset.html: Added. For two input fields.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method.html: Added. For GET method.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field.html: Added. For one input fields.
  • http/tests/misc/char-encoding-in-text-charset-field-with-value-expected.txt: Added.
  • http/tests/misc/char-encoding-in-text-charset-field-with-value.html: Added. If input type is text.
  • http/tests/misc/char-encoding-without-charset-field-expected.txt: Added.
  • http/tests/misc/char-encoding-without-charset-field.html: Added. If no hidden input field.
  • http/tests/misc/resources/char-encoding-in-hidden-charset-field.php: Added. Server side script for test.
12:29 PM Changeset in webkit [99309] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-11-04 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: marked inspector/debugger/script-formatter.html
as skipped for now - sorting it out.

  • platform/mac/Skipped:
  • platform/win/Skipped:
12:12 PM Changeset in webkit [99308] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Use Chromium's copy of libWebKitSystemInterfaceLeopard.a
​https://bugs.webkit.org/show_bug.cgi?id=71563

Patch by Robert Sesek <​rsesek@chromium.org> on 2011-11-04
Reviewed by Adam Barth.

Source/WebCore:

Use libWebKitSystemInterfaceLeopard.a that's in the Chromium port,
rather in WebKitLibraries/.

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

Roll Chromium DEPS r108107:108476 to pull in
libWebKitSystemInterfaceLeopard.a.

  • DEPS:
11:52 AM Changeset in webkit [99307] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

RenderLayer::styleChanged invalidates the GraphicsLayer needlessly
​https://bugs.webkit.org/show_bug.cgi?id=71517

Reviewed by Simon Fraser.

Unused code removal covered by existing tests.

The current code is invalidating the whole RenderLayerBacking as part of
a style change. However this is redundant with the repainting logic which
would invalidate only the necessary bits.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::styleChanged):
Remove the invalidation code as it duplicates and defeats the repaint logic.

11:38 AM Changeset in webkit [99306] by mihnea@adobe.com
  • 3 edits
    2 adds in trunk

Correct parsing of incomplete @-webkit-region rules.
​https://bugs.webkit.org/show_bug.cgi?id=71514

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/regions/parse-incomplete-region-rule.html

Make sure to set the region rule to 0 on the fail branch.

  • css/CSSGrammar.y:

LayoutTests:

  • fast/regions/parse-incomplete-region-rule-expected.txt: Added.
  • fast/regions/parse-incomplete-region-rule.html: Added.
11:34 AM Changeset in webkit [99305] by adamk@chromium.org
  • 4 edits in trunk/Source/WebCore

Reduce refcount churn in ChildListMutationScope
​https://bugs.webkit.org/show_bug.cgi?id=71527

Reviewed by Ryosuke Niwa.

Only the ChildListMutationAccumulator needs to hold a reference to the
target node, and the added/removed children only need be ref'd if a
ChildListMutationAccumulator exists (i.e., if there are interested
observers).

  • dom/ChildListMutationScope.cpp:

(WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::enqueueMutationRecord):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::childAdded):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::willRemoveChild):
(WebCore::ChildListMutationScope::ChildListMutationScope):
(WebCore::ChildListMutationScope::~ChildListMutationScope):
(WebCore::ChildListMutationScope::childAdded):
(WebCore::ChildListMutationScope::willRemoveChild):

  • dom/ChildListMutationScope.h:
  • dom/ContainerNode.cpp:

(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):

11:28 AM Changeset in webkit [99304] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Forgot to skip this test also in r99296.
11:27 AM Changeset in webkit [99303] by leviw@chromium.org
  • 4 edits in trunk/Source/WebCore

Correct usage of LayoutUnits in RenderImage and SVGImage
​https://bugs.webkit.org/show_bug.cgi?id=71525

Reviewed by Darin Adler.

Correcting incorrect usage of LayoutUnits for image sizes that should be integers and fixing overloaded functions that
should be using LayoutUnits.

No new tests -- no change in behavior.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageDimensionsChanged):
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::nodeAtPoint):
(WebCore::RenderImage::computeReplacedLogicalWidth):

  • rendering/RenderImage.h:
  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImageChromeClient::invalidateContentsAndWindow):

11:20 AM Changeset in webkit [99302] by andersca@apple.com
  • 2 edits in trunk/Tools

Fix WKTR crash when running NPN_ConvertPoint test.

Call notifyDone in a timeout - otherwise we'll end up entering layout from layout.

  • DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:

(ConvertPoint::NPP_SetWindow):

11:14 AM Changeset in webkit [99301] by abarth@webkit.org
  • 9 edits in trunk

Implement allow-popups for iframe@sandbox
​https://bugs.webkit.org/show_bug.cgi?id=66505

Reviewed by Darin Adler.

Source/WebCore:

Enable allow-popups sandbox bit. My previous patch attempted to
forward the sandbox bits during setOpener, but that interacted poorly
with out (internal) sandboxing of the initial document. This patch
forwards the bits during createWindow, which is more targeted to the
case when a sandbox frame actually creates a new window.

  • loader/FrameLoader.cpp:

(WebCore::createWindow):

  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNewWindowPolicy):

LayoutTests:

Update test results to show that we now pass.

  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control-expected.txt:
  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html:
  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html:
  • http/tests/security/popup-allowed-by-sandbox-when-allowed-expected.txt:
  • http/tests/security/popup-allowed-by-sandbox-when-allowed.html:
11:12 AM Changeset in webkit [99300] by andersca@apple.com
  • 9 edits in trunk

NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
​https://bugs.webkit.org/show_bug.cgi?id=71570

Reviewed by Simon Fraser.

Tools:

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::NPP_SetWindow):

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:

Remove the NPP parameter from NPP_SetWindow.

  • DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp:

(NPPSetWindowCalledDuringDestruction::NPP_SetWindow):
Remove the NPP parameter from NPP_SetWindow.

  • DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:

(PassDifferentNPPStruct::NPP_SetWindow):
Remove the NPP parameter from NPP_SetWindow and use PluginTest::log for logging.

  • DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:

(ConvertPoint::NPP_SetWindow):
Run the test from NPP_SetWindow and call notifyDone() when done.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_SetWindow):
Remove unnecessary parameter.

LayoutTests:

Add a call to layoutTestController.waitUntilDone(); the plug-in will call notifyDone() when it's done.

  • platform/mac/plugins/convert-point.html:
11:11 AM Changeset in webkit [99299] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove initMediaStreamEvent method
​https://bugs.webkit.org/show_bug.cgi?id=71344

This method has been removed from the spec draft.
​http://www.whatwg.org/specs/web-apps/current-work/multipage/video-conferencing-and-peer-to-peer-communication.html#mediastreamevent

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-11-04
Reviewed by Adam Barth.

No new tests. Removed method.

  • mediastream/MediaStreamEvent.cpp:
  • mediastream/MediaStreamEvent.h:
  • mediastream/MediaStreamEvent.idl:
11:09 AM Changeset in webkit [99298] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

Anonymous CORS fetch for WebGL texture fails when there is no appropriate server response even for the same origin requests
​https://bugs.webkit.org/show_bug.cgi?id=71053

Reviewed by Darin Adler.

Source/WebCore:

The crossorigin attribute should behave like XMLHttpRequest:
same-origin images pass without and CORS headers, but CORS checks are
performed for cross-origin loads. This patch better aligns our
behavior with Firefox, as discussed in the bug.

Test: http/tests/security/img-crossorigin-loads-same-origin.html

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::notifyFinished):

LayoutTests:

Test that we succeed in loading a same-origin image without the help of
CORS even if the image has the crossorigin attribute.

  • http/tests/security/img-crossorigin-loads-same-origin-expected.txt: Added.
  • http/tests/security/img-crossorigin-loads-same-origin.html: Added.
10:55 AM Changeset in webkit [99297] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

HTMLKeygenElement: Fix "keytype" handling in appendFormData.
​https://bugs.webkit.org/show_bug.cgi?id=70617

This fixes a bug introduced by ​http://trac.webkit.org/changeset/97658
which causes all HTML Keygen elements with a keytype optional attribute
to be considered as unsupported.

A regression test is included.

Patch by Gaurav Shah <​gauravsh@chromium.org> on 2011-11-04
Reviewed by Darin Adler.

Source/WebCore:

Test: http/tests/misc/submit-post-keygen.html

  • html/HTMLKeygenElement.cpp:

LayoutTests:

  • http/tests/misc/resources/check-keygen-post.php: Added.
  • http/tests/misc/submit-post-keygen-expected.txt: Added.
  • http/tests/misc/submit-post-keygen.html: Added.
10:51 AM Changeset in webkit [99296] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

[Qt] Temporarily skip failing tests after the build system refactoring.

Rubber-stamped by Ossy.

Bug #71571 tracks the failure so we can look into it next week.

  • platform/qt/Skipped:
10:45 AM Changeset in webkit [99295] by enne@google.com
  • 11 edits in trunk/Source

[chromium] Implement checkerboarding for missing layer tiles
​https://bugs.webkit.org/show_bug.cgi?id=69585

Reviewed by James Robinson.

Source/WebCore:

For tiles that have no texture or haven't even been created yet,
draw using the background color of the layer.

The only background color set is currently the non-composited content,
and all other layers use transparent black by default.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/NonCompositedContentHost.cpp:

(WebCore::NonCompositedContentHost::setBackgroundColor):

  • platform/graphics/chromium/NonCompositedContentHost.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::setBackgroundColor):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::backgroundColor):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::drawTiles):

Source/WebKit/chromium:

To pipe the background color of the document to the non-composited
host, set it during paint. This may be more frequent than necessary,
but it'll catch all style changes.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::nonCompositedContentHost):
(WebKit::WebViewImplContentPainter::paint):

  • src/WebViewImpl.h:
  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

10:41 AM Changeset in webkit [99294] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Fix run-qtwebkit-tests execution on the build bot(s).

Rubber-stamped by Tor Arne Vestbø.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: The path to the tests

changed slightly after the refactoring.

10:37 AM Changeset in webkit [99293] by thakis@chromium.org
  • 4 edits in trunk/Source/WebCore

[chromium] Remove most exit time destructors
​https://bugs.webkit.org/show_bug.cgi?id=71524

Do this by using the DEFINE_STATIC_LOCAL macro, which allocates things on the heaps and then leaks them.

Reviewed by Dimitri Glazkov.

No behavior change, so no new tests.

  • platform/chromium/CursorChromium.cpp:

(WebCore::pointerCursor):
(WebCore::crossCursor):
(WebCore::handCursor):
(WebCore::iBeamCursor):
(WebCore::waitCursor):
(WebCore::helpCursor):
(WebCore::eastResizeCursor):
(WebCore::northResizeCursor):
(WebCore::northEastResizeCursor):
(WebCore::northWestResizeCursor):
(WebCore::southResizeCursor):
(WebCore::southEastResizeCursor):
(WebCore::southWestResizeCursor):
(WebCore::westResizeCursor):
(WebCore::northSouthResizeCursor):
(WebCore::eastWestResizeCursor):
(WebCore::northEastSouthWestResizeCursor):
(WebCore::northWestSouthEastResizeCursor):
(WebCore::columnResizeCursor):
(WebCore::rowResizeCursor):
(WebCore::middlePanningCursor):
(WebCore::eastPanningCursor):
(WebCore::northPanningCursor):
(WebCore::northEastPanningCursor):
(WebCore::northWestPanningCursor):
(WebCore::southPanningCursor):
(WebCore::southEastPanningCursor):
(WebCore::southWestPanningCursor):
(WebCore::westPanningCursor):
(WebCore::moveCursor):
(WebCore::verticalTextCursor):
(WebCore::cellCursor):
(WebCore::contextMenuCursor):
(WebCore::aliasCursor):
(WebCore::progressCursor):
(WebCore::noDropCursor):
(WebCore::copyCursor):
(WebCore::noneCursor):
(WebCore::notAllowedCursor):
(WebCore::zoomInCursor):
(WebCore::zoomOutCursor):
(WebCore::grabCursor):
(WebCore::grabbingCursor):

  • platform/chromium/LanguageChromium.cpp:

(WebCore::platformDefaultLanguage):

  • platform/chromium/MIMETypeRegistryChromium.cpp:

(WebCore::dummyHashSet):

10:29 AM Changeset in webkit [99292] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed expectations update.

Temporarily mark a few tests as failing from r99286 due to tiny
differences on scrollbars. Can be rebaselined once all bots cycle.

  • platform/chromium/test_expectations.txt:
10:10 AM Changeset in webkit [99291] by fsamuel@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Expose deviceScaleFactor to WebKit API
​https://bugs.webkit.org/show_bug.cgi?id=70614

Reviewed by Darin Fisher.

This exposes the device scale factor to the Chromium-WebKit API.
This scale factor is the ratio between the current device's DPI
and the target device's DPI.

For details on how this can be accessed from CSS and javascript, please
see here:

​http://developer.android.com/guide/webapps/targeting.html#DensityCSS

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::deviceScaleFactor):
(WebKit::WebViewImpl::setDeviceScaleFactor):

  • src/WebViewImpl.h:
10:06 AM Changeset in webkit [99290] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Don't warn about disabling WebKit2 when qmake does recursive includes

Reviewed by Simon Hausmann.

  • qmake/mkspecs/features/default_pre.prf:
10:04 AM Changeset in webkit [99289] by andersca@apple.com
  • 6 edits in trunk/Source

Add NetscapePlugin::convertFromRootView
​https://bugs.webkit.org/show_bug.cgi?id=71526

Reviewed by Sam Weinig.

Source/WebCore:

Export some symbols that WebKit2 needs.

  • WebCore.exp.in:

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::convertFromRootView):
New function that converts a point from root view coordinates to plug-in coordinates.
Returns false if the conversion can't be done.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::fillInCocoaEventFromMouseEvent):
(WebKit::initializeMouseEvent):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
Use convertFromRootView instead of subtracting m_frameRectInWindowCoordinates.location() from the
event position (which is in root view coordinates).

10:00 AM Changeset in webkit [99288] by tony@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix svn properties on layout test result files I checked in.

  • platform/chromium-linux/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added property svn:mime-type.
  • platform/chromium-win/printing/setPrinting-expected.txt: Added property svn:eol-style.
  • platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added property svn:mime-type.
  • platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added property svn:eol-style.
  • platform/mac/printing/setPrinting-expected.txt: Added property svn:eol-style.
  • platform/mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added property svn:eol-style.
9:55 AM Changeset in webkit [99287] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Don't error out on wrong Qt version when qmake does recursive includes

Reviewed by Simmon Hausmann.

9:41 AM Changeset in webkit [99286] by enne@google.com
  • 15 edits in trunk/Source

[chromium] Fix incorrect visibility/scissor rect for threaded compositing
​https://bugs.webkit.org/show_bug.cgi?id=70962

Reviewed by James Robinson.

Source/WebCore:

In order to properly scroll independent of layout on the compositor
thread, we have to apply the scroll to the right layer. Previously,
the NonCompositedContentHost was the root of the graphics layer tree
with all other layers underneath it. However, applying a scroll to
that layer would also scroll the clip layer for the main frame
underneath it, causing visibility issues.

This patch moves the NonCompositedHost to be a child of the
RenderLayerCompositor's scroll layer. This was exposed on
RenderLayerCompositor, because there's no other way to get to this
layer in a way that doesn't make assumptions about the structure of
the layers on a frame.

This also removes the hacks in calculateVisibleLayerRect and
tilingTransform for scroll position.

Partially tested by existing compositor tests. Manually tested
threaded compositing scrolling.

  • platform/graphics/chromium/NonCompositedContentHost.cpp:

(WebCore::NonCompositedContentHost::setScrollLayer):
(WebCore::NonCompositedContentHost::setViewport):
(WebCore::NonCompositedContentHost::scrollLayer):

  • platform/graphics/chromium/NonCompositedContentHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::create):
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::applyScrollDeltas):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::setRootLayer):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::findScrollLayer):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::scrollRootLayer):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::tilingTransform):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::scrollLayer):

  • rendering/RenderLayerCompositor.h:

Source/WebKit/chromium:

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::MockLayerTreeHost):

9:09 AM Changeset in webkit [99285] by Philippe Normand
  • 7 edits in trunk

[GTK] Disable VIDEO_TRACK for now
​https://bugs.webkit.org/show_bug.cgi?id=71547

Reviewed by Gustavo Noronha Silva.

.:

  • configure.ac: VIDEO_TRACK is still a moving target, it's best to

disable it for now.

LayoutTests:

Skip media/track tests and rebaseline involved fast/dom test results.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
8:48 AM Changeset in webkit [99284] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Disable inspector tests temporarily because of a bug near build system refactoring.
8:31 AM Changeset in webkit [99283] by caryclark@google.com
  • 478 edits
    131 adds in trunk/LayoutTests

Unreviewed gardening: 8th chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 602 of 608 files for brevity.]

  • platform/chromium-mac-leopard/css3/bdi-element-expected.png: Added.
  • platform/chromium-mac-leopard/css3/bdi-element-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.png: Added.

...

  • platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/svg-vs-css-expected.png: Added.
  • platform/chromium-mac-leopard/transitions/move-after-transition-expected.png: Added.
8:29 AM Changeset in webkit [99282] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Disable STDIN check before cleaning build dir

It didn't work on the bots.

Reviewed by Ossy.

  • Scripts/webkitdirs.pm:
8:20 AM Changeset in webkit [99281] by vestbo@webkit.org
  • 5 edits in trunk

[Qt] Don't build all of webkit when running build-jsc

In case the whole webkit project was built, but we then subsequently
want to build only JSC, we need to run make in the proper subdirectory.

This also means the incremental target needs to be added to all
makefiles.

Reviewed by Simon Hausmann.

8:20 AM Changeset in webkit [99280] by vestbo@webkit.org
  • 1 edit in trunk/Tools/Scripts/webkitdirs.pm

[Qt] Look for STDIN instead of STDOUT when asking to clean the build dir

Reviewed by Ossy.

7:54 AM Changeset in webkit [99279] by Simon Hausmann
  • 2 edits in trunk/Tools

Fix run-javascriptcore-tests for Qt when it's executed by the bot.

Reviewed by Tor Arne Vestbø.

  • Scripts/webkitdirs.pm:

(jscProductDir): jsc path changed.

7:03 AM Changeset in webkit [99278] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Error out early if trying to build against Qt < 4.8

Reviewed by Simon Hausmann.

6:47 AM Changeset in webkit [99277] by Simon Hausmann
  • 2 edits in trunk/Tools

Fix run-launcher for Qt and Gtk.

Rubber-stamped by Tor Arne Vestbø.

  • Scripts/webkitdirs.pm:

(isWK2): Re-add isWK2(), as it's used in run-launcher.

6:39 AM Changeset in webkit [99276] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.

Reviewed by Simon Hausmann.

6:37 AM Changeset in webkit [99275] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Use web view title as window title in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=71544

Reviewed by Philippe Normand.

  • MiniBrowser/gtk/BrowserWindow.c:

(webViewURIChanged): Removed extra space.
(webViewTitleChanged): Set window title using
webkit_web_view_get_title().
(browser_window_init): Set initial default window title.
(browserWindowConstructed): Connect to WebView notify::title
signal.

6:19 AM Changeset in webkit [99274] by vestbo@webkit.org
  • 50 edits
    4 copies
    9 moves
    31 adds
    16 deletes in trunk

[Qt] Refactor and clean up the qmake build system

The qmake build system has accumulated a bit of cruft and redundancy
over time. There's also a fairly tight coupling between how to build
the various targets, and _what_ to build, making it harder to add new
rules or sources. This patch aims to elevate these issues somewhat.

This is a short-list of the changes:

  • The rules for how to build targets are now mostly contained as prf-files in Tools/qmake/mkspecs/features. Using mkspecs also allows us to do pre- and post-processing of each project file, which helps to clean up the actual project files.
  • Derived sources are no longer generated as a separate make-step but is part of each target's project file as a subdir. Makefile rules are used to ensure that we run make on the derived sources before running qmake on the actual target makefile. This makes it easier to keep a proper dependency between derived sources and the target.
  • We use GNU make and the compiler to generate dependencies on UNIX-based systems running Qt 5. This allows us to lessen the need to run qmake, which should reduce compile time.
  • WebKit2 is now build by default if building with Qt 5. It can be disabled by passing --no-webkit2 to build-webkit.

The result of these changes are hopefully a cleaner and easier
build system to modify, and faster build times due to no longer
running qmake on every single build. It's also a first step
towards possibly generating the list of sources using another
build system.

​https://bugs.webkit.org/show_bug.cgi?id=71222

Reviewed by Simon Hausmann.

5:28 AM Changeset in webkit [99273] by kenneth@webkit.org
  • 11 edits in trunk/Source/WebKit2

[Qt] Support programmatic scrolling with the QTouchWebView

Reviewed by Simon Hausmann.

As more code can be shared between the programmatic scrolling and the
method for ensuring that the contents are within valid bounds, this
patch includes a bit of refactoring as well.

  • UIProcess/API/qt/qdesktopwebview_p.h:

(QDesktopWebViewPrivate::scrollPositionRequested):

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::scrollPositionRequested):

  • UIProcess/API/qt/qtouchwebview_p.h:
  • UIProcess/qt/QtTouchViewInterface.cpp:

(WebKit::QtTouchViewInterface::scrollPositionRequested):

  • UIProcess/qt/QtTouchViewInterface.h:
  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::event):
(WebKit::boundPosition):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemAtScale):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::setConstraints):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
(WebKit::QtViewportInteractionEngine::contentViewportChanged):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::pageDidRequestScroll):

  • UIProcess/qt/QtWebPageProxy.h:
4:23 AM Changeset in webkit [99272] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] MediaStream API: Fixing wrong path for PeerConnectionHandler.h in WebCore.gyp
​https://bugs.webkit.org/show_bug.cgi?id=71548

Patch by Tommy Widenflycht <​tommyw@google.com> on 2011-11-04
Reviewed by Tony Gentilcore.

  • WebCore.gypi:
2:20 AM Changeset in webkit [99271] by eric@webkit.org
  • 4 edits in trunk/Tools

Remove deprecated free functions in port.factory
​https://bugs.webkit.org/show_bug.cgi?id=71494

Unreviewed. Fixing exception seen when running test-webkitpy.

Sorry, I previously had deleted the relevant rebaseline-chromium-webkit-tests
unittest, since that script is nearly ready to be deleted. But I added
it back at the last second and failed to run the tests. :(
This fixes the exception the bots were seeing.

  • Scripts/webkitpy/style/checkers/test_expectations.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2:13 AM Changeset in webkit [99270] by Patrick Gansterer
  • 3 edits in trunk/Source/WebKit/wince

[WINCE] Use default LocalizationStrategy
​https://bugs.webkit.org/show_bug.cgi?id=71495

Reviewed by Adam Roben.

Use LocalizationStrategy from WebCore instead of using a copy of the strings in WebKit.

  • WebCoreSupport/PlatformStrategiesWinCE.cpp:
  • WebCoreSupport/PlatformStrategiesWinCE.h:
2:04 AM Changeset in webkit [99269] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip some fast/viewport failing tests on GTK after r99195.

  • platform/gtk/Skipped:
1:53 AM Changeset in webkit [99268] by gyuyoung.kim@samsung.com
  • 21 edits in trunk/Source/WebKit/efl

[EFL] Use standard booleand data type.
​https://bugs.webkit.org/show_bug.cgi?id=71433

This is a fourth step in order to be more compliant with WebKit coding style.
Use standard boolean data type instead of efl boolean data type. It makes efl port
is more close to webkit coding style.

Reviewed by Zoltan Herczeg.

  • WebCoreSupport/ChromeClientEfl.cpp:
  • WebCoreSupport/FrameLoaderClientEfl.cpp:
  • ewk/ewk_contextmenu.cpp:
  • ewk/ewk_cookies.cpp:
  • ewk/ewk_frame.cpp:
  • ewk/ewk_history.cpp:
  • ewk/ewk_js.cpp:
  • ewk/ewk_main.cpp:
  • ewk/ewk_network.cpp:
  • ewk/ewk_private.h:
  • ewk/ewk_protocol_handler.cpp:
  • ewk/ewk_protocol_handler_soup.cpp:
  • ewk/ewk_settings.cpp:
  • ewk/ewk_tiled_backing_store.cpp:
  • ewk/ewk_tiled_matrix.cpp:
  • ewk/ewk_tiled_model.cpp:
  • ewk/ewk_util.cpp:
  • ewk/ewk_view.cpp:
  • ewk/ewk_view_single.cpp:
  • ewk/ewk_view_tiled.cpp:
1:20 AM Changeset in webkit [99267] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Unreviewed CMake build fix for !ENABLE(SQL_DATABASE).

  • CMakeLists.txt: Always compile the SQLite source files, since they are required for build.
1:06 AM Changeset in webkit [99266] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/test_expectations.txt: Add more expectations for recent test flakinesses.
12:45 AM Changeset in webkit [99265] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

More code clean-up in DFG 32_64
​https://bugs.webkit.org/show_bug.cgi?id=71540

Remove unnecessary code duplications, and fix compilation warnings.

Patch by Yuqiang Xian <​yuqiang.xian@intel.com> on 2011-11-04
Reviewed by Gavin Barraclough.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::emitCount):
(JSC::DFG::JITCompiler::setSamplingFlag):
(JSC::DFG::JITCompiler::clearSamplingFlag):
(JSC::DFG::JITCompiler::jitAssertIsCell):

  • dfg/DFGJITCompiler32_64.cpp:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

12:35 AM Changeset in webkit [99264] by Csaba Osztrogonác
  • 15 edits in trunk/Source/JavaScriptCore

De-virtualize JSObject::hasInstance
​https://bugs.webkit.org/show_bug.cgi?id=71430

Unreviewed rolling out r99238, because it made a test crash on all platform.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::hasInstance):

  • API/JSValueRef.cpp:

(JSValueIsInstanceOfConstructor):

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ClassInfo.h:
  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::hasInstance):

  • runtime/JSBoundFunction.h:
  • runtime/JSCell.cpp:
  • runtime/JSCell.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::hasInstance):

  • runtime/JSObject.h:

Nov 3, 2011:

9:53 PM Changeset in webkit [99263] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, forgot to skip a new test in r99261.

  • platform/qt/Skipped:
9:52 PM Changeset in webkit [99262] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

REGRESSION (r99076): Pasting into password fields is broken
​https://bugs.webkit.org/show_bug.cgi?id=71483

Reviewed by Darin Adler.

The bug was caused by plainText serializing secured (instead of original) text.
Fixed the bug by adding new TextIterator behavior that serializes the original text
and using it in ReplacementFragment::ReplacementFragment.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment):

  • editing/TextIterator.cpp:

(WebCore::TextIterator::TextIterator):
(WebCore::TextIterator::emitText):

  • editing/TextIterator.h:
9:18 PM Changeset in webkit [99261] by eric.carlson@apple.com
  • 30 edits
    11 adds in trunk

Add TrackEvent
​https://bugs.webkit.org/show_bug.cgi?id=71178

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/events/constructors/track-event-constructor.html

  • CMakeLists.txt: Add new files for TrackEvent.
  • CodeGenerators.pri: Ditto.
  • DerivedSources.cpp: Ditto.
  • DerivedSources.make: Ditto.
  • GNUmakefile.am: Ditto.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/generic/EventConstructors.h: Ditto.
  • bindings/gobject/GNUmakefile.am: Ditto.
  • bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue): Add method to convert to a Track.

  • bindings/js/JSDictionary.h:
  • bindings/js/JSEventConstructors.cpp: Add new files for TrackEvent.
  • bindings/js/JSTrackCustom.cpp: Added.

(WebCore::toTrack): New, convert from a JSValue to a Track.
(WebCore::toJS): New, return a JS wrapper for a Track.

  • bindings/js/JSTrackCustom.h: Added.
  • bindings/js/JSTrackEventCustom.cpp: Added.

(WebCore::JSTrackEvent::track): New, returns a TextEvent's 'track' attribute.

  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::get): Returns RefPtr<TrackBase>.

  • bindings/v8/custom/V8EventConstructors.cpp: Add Track initializing constructor.
  • bindings/v8/custom/V8TrackEventCustom.cpp: Added.

(WebCore::V8TrackEvent::trackAccessorGetter): New, returns a TextEvent's 'track' attribute.

  • dom/EventFactory.in: Add TrackEvent.
  • dom/EventNames.h: Add 'addtrack' event.
  • html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Call new base class constructor.

  • html/TextTrack.h: Now derive from BaseTrack for the day we implement VideoTrack and AudioTrack.
  • html/track/TrackBase.cpp: Added.

(WebCore::TrackBase::TrackBase):
(WebCore::TrackBase::~TrackBase):

  • html/track/TrackBase.h: Added.

(WebCore::TrackBase::type): Return the track type.

  • html/track/TrackEvent.cpp: Added.

(WebCore::TrackEventInit::TrackEventInit):
(WebCore::TrackEvent::TrackEvent):
(WebCore::TrackEvent::~TrackEvent):
(WebCore::TrackEvent::interfaceName):

  • html/track/TrackEvent.h: Added.

(WebCore::TrackEvent::create):
(WebCore::TrackEvent::isTrackEvent):
(WebCore::TrackEvent::track):

  • html/track/TrackEvent.idl: Added.
  • page/DOMWindow.idl: Add TrackEvent.

LayoutTests:

  • fast/events/constructors/track-event-constructor-expected.txt: Added.
  • fast/events/constructors/track-event-constructor.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/mac/Skipped:
  • platform/win/Skipped:
8:44 PM Changeset in webkit [99260] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/test_expectations.txt: Apply recent expectation changes.
7:21 PM Changeset in webkit [99259] by eae@chromium.org
  • 50 edits in branches/subpixellayout/Source

Revert platform to ints

7:16 PM Changeset in webkit [99258] by arv@chromium.org
  • 786 edits in trunk/LayoutTests

JS Test Harness: Remove successfullyParsed from more tests
​https://bugs.webkit.org/show_bug.cgi?id=71533

Reviewed by Ojan Vafai.

  • LayoutTests/*: Remove successfullyParsed
6:55 PM Changeset in webkit [99257] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Optimize canvas fills / drawImage when covering entire canvas
​https://bugs.webkit.org/show_bug.cgi?id=70789

Patch by Ben Wells <​benwells@chromium.org> on 2011-11-03
Reviewed by Stephen White.

If we're filling a rect or drawing an image, and it covers the entire canvas, we don't
need to worry about clearing outside the area updated by the operation if we're in
a composite mode that requires this (such as source-in, copy, etc.). In this case we
can take the simple path through the code and save a clear (for copy) or a temporary
image buffer (for the other modes).

No new tests - optimization, behaviour is unchanged and covered by existing tests.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::rectContainsCanvas):

  • html/canvas/CanvasRenderingContext2D.h:
6:32 PM Changeset in webkit [99256] by mhahnenberg@apple.com
  • 28 edits in trunk/Source

De-virtualize JSObject::getPropertyNames
​https://bugs.webkit.org/show_bug.cgi?id=71306

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • API/JSObjectRef.cpp:

(JSObjectCopyPropertyNames):

(JSC::DebuggerActivation::getOwnPropertyNames):

  • runtime/ClassInfo.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::getPropertyNames):

  • runtime/JSCell.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):

  • runtime/JSObject.h:
  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::create):

  • runtime/ScopeChain.cpp:

(JSC::ScopeChainNode::print):

  • runtime/Structure.cpp:

(JSC::Structure::getPropertyNamesFromStructure):

  • runtime/Structure.h:

Source/JavaScriptGlue:

Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • JSUtils.cpp:

(KJSValueToCFTypeInternal):

  • JSValueWrapper.cpp:

(JSValueWrapper::JSObjectCopyPropertyNames):

Source/WebCore:

No new tests.

Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getPropertyNames):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::getPropertyNames):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • bridge/NP_jsobject.cpp:

(_NPN_Enumerate):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariantMap):

Source/WebKit/mac:

Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::enumerate):

Source/WebKit2:

Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::enumerate):

6:18 PM Changeset in webkit [99255] by xji@chromium.org
  • 11 edits in trunk

Enable ctrl-arrow move cursor by word in visual order in cr-win by command line flag.
​https://bugs.webkit.org/show_bug.cgi?id=71163

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add m_visualWordMovementEnabled page setting, trigger visual word movement
function (instead of logical one) when it is set as true.

right|leftWordPosition() are tested in editing/selection/move-by-word-visually*
by using --webkit-visual-word flag.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingLeft):
(WebCore::FrameSelection::visualWordMovementEnabled):

  • editing/FrameSelection.h:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setVisualWordMovementEnabled):
(WebCore::Settings::visualWordMovementEnabled):

Source/WebKit/chromium:

To minimize the risk to LTR users, we enable this feature first to chromium win
by command line flag. This and corresponding changset in chromium
(​http://codereview.chromium.org/8400078/)
should be removed after this feature is enabled without command line flag.

The work flow is:

  1. (chromium) adds command line flag --enable-visual-word-movement, pass it to WebCore::Settings through WebPreferences.
  2. in FrameSelection::modifyMovingLeft|Right, when 'visualWordMovementEnabled' is true in page's Settings, trigger visual word movement instead of logical one.


  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setVisualWordMovementEnabled):

  • src/WebSettingsImpl.h:

Tools:

  • DumpRenderTree/chromium/WebPreferences.cpp: Set visualWordMovementEabled to false in DRT.

(WebPreferences::applyTo):

5:56 PM Changeset in webkit [99254] by leviw@chromium.org
  • 8 edits in trunk/Source/WebCore

Correct usage of LayoutUnits and integers in Table rendering classes
​https://bugs.webkit.org/show_bug.cgi?id=71500

Reviewed by Darin Adler.

Fixing the Table layout classes to operate on integers -- sub-pixel table layout breaks
the spec. Meanwhile correcting the Table rendering classes themselves to still use
LayoutUnits.

No new tests -- no change in behavior.

  • rendering/AutoTableLayout.cpp: Reverting to operating on integers.

(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):

  • rendering/AutoTableLayout.h: Reverting to operating on integers.
  • rendering/FixedTableLayout.cpp: Ditto.

(WebCore::FixedTableLayout::computePreferredLogicalWidths):
(WebCore::FixedTableLayout::layout):

  • rendering/RenderTable.h: Switching to LayoutUnits.

(WebCore::RenderTable::getColumnPos):
(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection):

  • rendering/RenderTableCell.cpp: Switching to LayoutUnits.

(WebCore::RenderTableCell::updateLogicalWidth):
(WebCore::RenderTableCell::setOverrideHeightFromRowHeight):
(WebCore::RenderTableCell::computeRectForRepaint):
(WebCore::RenderTableCell::cellBaselinePosition):
(WebCore::RenderTableCell::scrollbarsChanged):

  • rendering/RenderTableCell.h: Switching to LayoutUnits
  • rendering/RenderTableSection.cpp: Ditto.

(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::layoutRows):

5:31 PM Changeset in webkit [99253] by jamesr@google.com
  • 9 edits in trunk/Source

[chromium] Notify scheduler on SwapBuffers in threaded compositor mode
​https://bugs.webkit.org/show_bug.cgi?id=71381

Reviewed by Kenneth Russell.

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::didSwapBuffers):

  • platform/graphics/chromium/cc/CCScheduler.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::drawLayersAndSwapOnImplThread):

5:27 PM Changeset in webkit [99252] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Added ewk_tile_memory_size_get function
​https://bugs.webkit.org/show_bug.cgi?id=71213

Patch by Tomasz Morawski <​t.morawski@samsung.com> on 2011-11-03
Reviewed by Anders Carlsson.

Added the ewk_tile_memory_size_get function returns size of used memory by given tile. Simplify and cleanup
the code.

  • ewk/ewk_tiled_model.cpp:

(ewk_tile_memory_size_get):
(ewk_tile_unused_cache_flush):
(ewk_tile_unused_cache_tile_get):
(ewk_tile_unused_cache_tile_put):

  • ewk/ewk_tiled_model.h:
5:17 PM Changeset in webkit [99251] by abarth@webkit.org
  • 1 edit
    5 adds in trunk/Source/WTF

Add Stub.h and Stub.cpp to Source-level WTF project
​https://bugs.webkit.org/show_bug.cgi?id=71497

Reviewed by Eric Seidel.

This patch adds some stub files and a skelton GYP build file as a
starting point for the new Source-level WTF project. Other build
systems and actual code will arrive in future patches.

  • Stub.cpp: Added.
  • Stub.h: Added.
  • WTF.gyp/WTF.gyp: Added.
  • WTF.gypi: Added.
5:13 PM Changeset in webkit [99250] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Get rid of NetscapePlugin::m_clipRectInWindowCoordinates
​https://bugs.webkit.org/show_bug.cgi?id=71521

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::geometryDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
5:13 PM Changeset in webkit [99249] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Use convertToRootView(IntPoint()) instead of m_frameRectInWindowCoordinates.location() where possible
​https://bugs.webkit.org/show_bug.cgi?id=71520

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
(WebKit::NetscapePlugin::platformPaint):

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):

5:10 PM Changeset in webkit [99248] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Remove an obsolete comment.

  • platform/chromium/test_expectations.txt:
4:55 PM Changeset in webkit [99247] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add NetscapePlugin::convertToRootView
​https://bugs.webkit.org/show_bug.cgi?id=71519

Reviewed by Darin Adler.

Yet another step towards eliminating uses of m_frameRectInWindowCoordinates.

Also, use the "root view" terminology, since that's really what we mean here.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::callSetWindow):
Use convertToRootView to get the plug-in location and clip rect in root view coordinates.

(WebKit::NetscapePlugin::convertToRootView):
Apply the m_pluginToRootViewTransform.mapPoint transform.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add convertToRootView.

4:42 PM Changeset in webkit [99246] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

CMake: Add missing WebGL IDL file html/canvas/WebGLContextEvent.idl

Rubber-stamped by Martin Robinson

  • CMakeLists.txt:
4:35 PM Changeset in webkit [99245] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

CMake: Only generate from WebGL IDLs when building with WebGL
​https://bugs.webkit.org/show_bug.cgi?id=71516

Reviewed by Martin Robinson.

  • CMakeLists.txt:
4:26 PM Changeset in webkit [99244] by arv@chromium.org
  • 10 edits in trunk/Source/WebCore

Remove support for LegacyDefaultOptionalArguments
​https://bugs.webkit.org/show_bug.cgi?id=71489

Reviewed by Darin Adler.

This removes support for LegacyDefaultOptionalArguments and [RequiresAllArguments=Raise].
[RequiresAllArguments=Raise] is now the standard behavior so it would be a no op.

No new tests. Covered by existing tests.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateArgumentsCountCheck): Check the "RequiresAllArguments" extended attribute and generate code

that returns undefined if there are missing arguments.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateArgumentsCountCheck): Ditto.

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod): Add generated argument count checks.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs): Ditto.
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs): Ditto.
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs): Ditto.
(WebCore::jsTestObjPrototypeFunctionSerializedValue): Ditto.
(WebCore::jsTestObjPrototypeFunctionIdbKey): Ditto.
(WebCore::jsTestObjPrototypeFunctionOptionsObject): Ditto.
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException): Ditto.
(WebCore::jsTestObjPrototypeFunctionAddEventListener): Ditto.
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener): Ditto.
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture): Ditto.
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD): Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs): Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7): Ditto.

  • bindings/scripts/test/TestCallback.idl: Remove LegacyDefaultOptionalArguments.
  • bindings/scripts/test/TestMediaQueryListListener.idl: Ditto.
  • bindings/scripts/test/TestObj.idl: Remove LegacyDefaultOptionalArguments and [RequiresAllArguments=Raise]
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: Remove LegacyDefaultOptionalArguments.

(WebCore::TestMediaQueryListListenerInternal::methodCallback): Add generated argument count checks.

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::voidMethodWithArgsCallback): Ditto.
(WebCore::TestObjInternal::intMethodWithArgsCallback): Ditto.
(WebCore::TestObjInternal::objMethodWithArgsCallback): Ditto.
(WebCore::TestObjInternal::serializedValueCallback): Ditto.
(WebCore::TestObjInternal::idbKeyCallback): Ditto.
(WebCore::TestObjInternal::optionsObjectCallback): Ditto.
(WebCore::TestObjInternal::customArgsAndExceptionCallback): Ditto.
(WebCore::TestObjInternal::withDynamicFrameAndArgCallback): Ditto.
(WebCore::TestObjInternal::withDynamicFrameAndOptionalArgCallback): Ditto.
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureCallback): Ditto.
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureASADCallback): Ditto.
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback): Ditto.
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback): Ditto.
(WebCore::TestObjInternal::methodWithCallbackArgCallback): Ditto.
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback): Ditto.
(WebCore::TestObjInternal::overloadedMethod1Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod2Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod3Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod4Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod5Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod6Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod7Callback): Ditto.
(WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback): Ditto.
(WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback): Ditto.

4:17 PM Changeset in webkit [99243] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Move plug-in size and backing store checks to PluginProxy::updateBackingStore
​https://bugs.webkit.org/show_bug.cgi?id=71508

Reviewed by Darin Adler.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange):
Remove code to send back an empty backing store if the plug-in size is empty
or doesn't need a backing store. This check is now done...

(WebKit::PluginProxy::updateBackingStore):
...here.

4:17 PM Changeset in webkit [99242] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Get rid of PluginControllerProxy::m_frameRectInWindowCoordinates
​https://bugs.webkit.org/show_bug.cgi?id=71506

Reviewed by Darin Adler.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::geometryDidChange):
This no longer needs to take the frame rect in window coordinates.

  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginControllerProxy.messages.in:

Remove frameRectInWindowCoordinates from the GeometryDidChange message.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange):
Don't pass frameRectInWindowCoordinates when sending GeometryDidChange.

4:17 PM Changeset in webkit [99241] by andersca@apple.com
  • 10 edits in trunk/Source/WebKit2

Get rid of Plugin::wantsWindowRelativeCoordinates()
​https://bugs.webkit.org/show_bug.cgi?id=71504

Reviewed by Darin Adler.

Since all Plugin subclasses now return false for wantsWindowRelativeCoordinates,
we can go ahead and remove it.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::paint):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::snapshot):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
  • WebProcess/Plugins/PDF/BuiltInPDFView.h:
  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginProxy.cpp:
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::paint):

4:17 PM Changeset in webkit [99240] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

NetscapePlugin::wantsWindowRelativeCoordinates should return false for all ports
​https://bugs.webkit.org/show_bug.cgi?id=71501

Reviewed by Darin Adler.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::wantsWindowRelativeCoordinates):
Return false.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformGeometryDidChange):
Use m_pluginSize instead of m_frameRectInWindowCoordinates.size().

(WebKit::NetscapePlugin::platformPaint):
No need to translate back and forth between window and plug-in relative coordinates anymore.

4:04 PM Changeset in webkit [99239] by Darin Adler
  • 76 edits in trunk/Source

Change remaining callers of releaseRef to call leakRef
​https://bugs.webkit.org/show_bug.cgi?id=71422

../JavaScriptCore:

  • wtf/text/AtomicString.cpp:

(WTF::HashAndUTF8CharactersTranslator::translate): Use leakRef.

../WebCore:

Reviewed by Darin Fisher.

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject _setImp:originRootObject:rootObject:]):
(-[WebScriptObject _setOriginRootObject:andRootObject:]):

  • bridge/NP_jsobject.cpp:

(_NPN_CreateScriptObject):

  • dom/QualifiedName.cpp:

(WebCore::QNameComponentsTranslator::translate):

  • history/PageCache.cpp:

(WebCore::PageCache::add):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::createFrameAtIndex):

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

  • platform/mac/ContextMenuMac.mm:

(WebCore::ContextMenu::releasePlatformDescription):

  • platform/mac/SharedBufferMac.mm:

(WebCore::SharedBuffer::createCFData):

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::platformResource):
Use leakRef.

../WebKit/chromium:

  • public/WebPrivatePtr.h:

(WebKit::WebPrivatePtr::WebPrivatePtr):
(WebKit::WebPrivatePtr::operator=):

  • src/WebDOMEvent.cpp:

(WebKit::WebDOMEvent::WebDOMEvent):

  • src/WebData.cpp:

(WebKit::WebData::assign):
(WebKit::WebData::WebData):
(WebKit::WebData::operator=):

  • src/WebDragData.cpp:

(WebKit::WebDragData::initialize):
(WebKit::WebDragData::WebDragData):
(WebKit::WebDragData::operator=):

  • src/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::initialize):
(WebKit::WebHTTPBody::WebHTTPBody):
(WebKit::WebHTTPBody::operator=):
(WebKit::WebHTTPBody::ensureMutable):

  • src/WebNodeCollection.cpp:

(WebKit::WebNodeCollection::WebNodeCollection):

  • src/WebNodeList.cpp:

(WebKit::WebNodeList::WebNodeList):

  • src/WebNotification.cpp:

(WebKit::WebNotification::WebNotification):
(WebKit::WebNotification::operator=):

  • src/WebRange.cpp:

(WebKit::WebRange::WebRange):
(WebKit::WebRange::operator=):

  • src/WebSecurityOrigin.cpp:

(WebKit::WebSecurityOrigin::WebSecurityOrigin):
(WebKit::WebSecurityOrigin::operator=):

  • src/WebThreadSafeData.cpp:

(WebKit::WebThreadSafeData::WebThreadSafeData):
Use leakRef.

../WebKit/efl:

Reviewed by Darin Fisher.

  • ewk/ewk_history.cpp:

(ewk_history_item_new): Use leakRef.

../WebKit/gtk:

Reviewed by Darin Fisher.

  • webkit/webkitwebdatasource.cpp:

(WebKit::kitNew):

  • webkit/webkitwebhistoryitem.cpp:

(webkit_web_history_item_new):
(webkit_web_history_item_new_with_data):
(webkit_web_history_item_copy):
(WebKit::kit):

  • webkit/webkitwebresource.cpp:

(webkit_web_resource_new_with_core_resource):
(webkit_web_resource_init_with_core_resource):
Use leakRef.

../WebKit/mac:

Reviewed by Darin Fisher.

  • History/WebBackForwardList.mm:

(-[WebBackForwardList initWithBackForwardList:]):

  • History/WebHistoryItem.mm:

(-[WebHistoryItem copyWithZone:]):
(-[WebHistoryItem initWithWebCoreHistoryItem:]):

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView createPlugin]):

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView createPlugin]):

  • WebCoreSupport/WebOpenPanelResultListener.mm:
  • WebView/WebDataSource.mm:

(-[WebDataSource _initWithDocumentLoader:]):

  • WebView/WebResource.mm:

(-[WebResourcePrivate initWithCoreResource:]):
Use leakRef.

../WebKit/win:

Reviewed by Darin Fisher.

  • WebCache.cpp:

(WebCache::statistics):

  • WebDatabaseManager.cpp:

(WebDatabaseManager::origins):
(WebDatabaseManager::databasesWithOrigin):

  • WebHistoryItem.cpp:

(WebHistoryItem::redirectURLs):

  • WebKitClassFactory.cpp:

(leakRefFromCreateInstance):
(WebKitClassFactory::CreateInstance):

  • WebScriptWorld.cpp:

(WebScriptWorld::standardWorld):
Use leakRef.

../WebKit2:

Reviewed by Darin Fisher.

  • Platform/mac/ModuleMac.mm:

(WebKit::Module::load):

  • Shared/API/c/WKArray.cpp:

(WKArrayCreate):

  • Shared/API/c/WKData.cpp:

(WKDataCreate):

  • Shared/API/c/WKDictionary.cpp:

(WKDictionaryCopyKeys):

  • Shared/API/c/WKGeometry.cpp:

(WKPointCreate):
(WKSizeCreate):
(WKRectCreate):

  • Shared/API/c/WKMutableArray.cpp:

(WKMutableArrayCreate):

  • Shared/API/c/WKMutableDictionary.cpp:

(WKMutableDictionaryCreate):

  • Shared/API/c/WKNumber.cpp:

(WKBooleanCreate):
(WKDoubleCreate):
(WKUInt64Create):

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toCopiedAPI):
(WebKit::toCopiedURLAPI):

  • Shared/API/c/cf/WKErrorCF.cpp:

(WKErrorCreateWithCFError):

  • Shared/API/c/cf/WKURLRequestCF.cpp:

(WKURLRequestCreateWithCFURLRequest):

  • Shared/API/c/cf/WKURLResponseCF.cpp:

(WKURLResponseCreateWithCFURLResponse):

  • Shared/API/c/mac/WKURLRequestNS.mm:

(WKURLRequestCreateWithNSURLRequest):

  • Shared/API/c/mac/WKURLResponseNS.mm:

(WKURLResponseCreateWithNSURLResponse):

  • Shared/cf/ArgumentCodersCF.cpp:

(CoreIPC::decode):

  • UIProcess/API/C/WKBackForwardList.cpp:

(WKBackForwardListCopyBackListWithLimit):
(WKBackForwardListCopyForwardListWithLimit):

  • UIProcess/API/C/WKContext.cpp:

(WKContextCreate):
(WKContextCreateWithInjectedBundlePath):

  • UIProcess/API/C/WKCredential.cpp:

(WKCredentialCreate):
(WKCredentialCreateWithCertificateInfo):

  • UIProcess/API/C/WKDatabaseManager.cpp:

(WKDatabaseManagerGetOriginKey):
(WKDatabaseManagerGetOriginQuotaKey):
(WKDatabaseManagerGetOriginUsageKey):
(WKDatabaseManagerGetDatabaseDetailsKey):
(WKDatabaseManagerGetDatabaseDetailsNameKey):
(WKDatabaseManagerGetDatabaseDetailsDisplayNameKey):
(WKDatabaseManagerGetDatabaseDetailsExpectedUsageKey):
(WKDatabaseManagerGetDatabaseDetailsCurrentUsageKey):

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameCopyChildFrames):

  • UIProcess/API/C/WKGeolocationPosition.cpp:

(WKGeolocationPositionCreate):

  • UIProcess/API/C/WKGrammarDetail.cpp:

(WKGrammarDetailCreate):

  • UIProcess/API/C/WKPage.cpp:

(WKPageGetSessionHistoryURLValueType):
(WKPageCopySessionState):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesCreateWithIdentifier):

  • UIProcess/API/C/win/WKView.cpp:

(WKViewCreate):

  • UIProcess/win/WebUndoClient.cpp:

(WebKit::WebUndoClient::registerEditCommand):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCopyChildFrames):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleCreate):
(WKBundleNodeHandleCopyDocument):
(WKBundleNodeHandleCopyHTMLTableCellElementCellAbove):
(WKBundleNodeHandleCopyDocumentFrame):
(WKBundleNodeHandleCopyHTMLFrameElementContentFrame):
(WKBundleNodeHandleCopyHTMLIFrameElementContentFrame):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCopyTrackedRepaintRects):

  • WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:

(WKBundleScriptWorldCreateWorld):
Use leakRef.

3:40 PM Changeset in webkit [99238] by mhahnenberg@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

De-virtualize JSObject::hasInstance
​https://bugs.webkit.org/show_bug.cgi?id=71430

Reviewed by Darin Adler.

Added hasInstance to the MethodTable, changed all the virtual
implementations of hasInstance to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::hasInstance):

  • API/JSValueRef.cpp:

(JSValueIsInstanceOfConstructor):

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ClassInfo.h:
  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::hasInstance):

  • runtime/JSBoundFunction.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::hasInstance):

  • runtime/JSCell.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::hasInstance):

  • runtime/JSObject.h:
3:28 PM Changeset in webkit [99237] by dcheng@chromium.org
  • 5 edits in trunk/Source

[chromium] Remove unused clipboard methods
​https://bugs.webkit.org/show_bug.cgi?id=71512

Reviewed by Tony Chang.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

  • public/WebClipboard.h:

(WebKit::WebClipboard::getSequenceNumber):
(WebKit::WebClipboard::readAvailableTypes):
(WebKit::WebClipboard::writeImage):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::clipboardGetSequenceNumber):
(WebCore::PlatformSupport::clipboardReadAvailableTypes):

1:49 PM Changeset in webkit [99236] by Nate Chapin
  • 4 edits
    3 deletes in branches/chromium/912/Source/WebKit/chromium

Revert 96912 - Always call setActive() in WebViewImpl::setFocus(),
not just when enabling focus.
​https://bugs.webkit.org/show_bug.cgi?id=65220

Reviewed by Darin Fisher.

  • WebKit.gyp:
  • WebKit.gypi:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setFocus):

  • tests/FrameTestHelpers.cpp: Added, refactored out of WebFrameTest.cpp.

(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::loadFrame):
(WebKit::FrameTestHelpers::defaultWebFrameClient):
(WebKit::FrameTestHelpers::defaultWebViewClient):
(WebKit::FrameTestHelpers::createWebViewAndLoad):

  • tests/FrameTestHelpers.h: Added, refactored out of WebFrameTest.cpp.
  • tests/WebFrameTest.cpp:
  • tests/WebViewTest.cpp: Added.

TBR=Nate Chapin
Review URL: ​http://codereview.chromium.org/8378004

1:37 PM Changeset in webkit [99235] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests
​https://bugs.webkit.org/show_bug.cgi?id=61042

Patch by Rafael Brandao <​rafael.lobo@openbossa.org> on 2011-11-03
Reviewed by Simon Hausmann.

At some points we didn't have any guarantee that a favicon has been loaded, so now
it stops to wait for the IconChanged signal. It also had some file paths in wrong format,
making some files to not be resolved and comparing meaningless bitmaps.

  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:

(tst_QDeclarativeWebView::initTestCase):
(tst_QDeclarativeWebView::basicProperties):
(tst_QDeclarativeWebView::historyNav):

1:28 PM Changeset in webkit [99234] by annacc@chromium.org
  • 7 edits
    2 adds in trunk

Source/WebCore: Implement TextTrackCueList.
​https://bugs.webkit.org/show_bug.cgi?id=70451

Reviewed by Eric Carlson.

Test: media/track/track-text-track-cue-list.html

  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::newCuesAvailable):

Update TextTrack's TextTrackCueList (m_cues) when new cues are discovered.

  • html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):

Create an empty TextTrackCueList upon TextTrack creation.

(WebCore::TextTrack::cues):

Return this TextTrack's list of cues.

Implement TextTrackCueList functionality:

  • html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::TextTrackCueList):
(WebCore::TextTrackCueList::length):
(WebCore::TextTrackCueList::item):
(WebCore::TextTrackCueList::getCueById):
(WebCore::TextTrackCueList::add):
(WebCore::TextTrackCueList::remove):
(WebCore::TextTrackCueList::contains):

  • html/TextTrackCueList.h:

(WebCore::TextTrackCueList::~TextTrackCueList):

LayoutTests: Tests for TextTrackCueList implementation.
​https://bugs.webkit.org/show_bug.cgi?id=70451

Reviewed by Eric Carlson.

  • media/track/track-text-track-cue-list-expected.txt: Added.
  • media/track/track-text-track-cue-list.html: Added.
1:24 PM Changeset in webkit [99233] by eric@webkit.org
  • 34 edits in trunk/Tools

Remove deprecated free functions in port.factory
​https://bugs.webkit.org/show_bug.cgi?id=71494

Reviewed by Adam Barth.

I removed port.factory.get, get_all, and all_port_names -- long-since deprecated
free functions in factory.py. To remove these required fixing all callsites
to use MockHost, Host, or PortFactory where appropriate. After this change
we're only left with a handfull of places where we inappropraitely use a
real Executive, FileSystem or User object during unittesting.

  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
    • These PortFactory overrides were from an earlier edition of my previous patch in the end, I removed MockPortFactory so all tests ended up with this same real PortFactory() with a MockHost. This was simply redundent code.
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
    • Use MockHost to get a mocked-out PortFactory.
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
    • This code has no access to a Host object, so we just use a default PortFactory for now. This will still incorrectly create real Executive/FileSystem objects durring unittesting, which is wrong. :(
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
    • Use a MockHost to get a mocked PortFactory.
  • Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
    • Use a MockHost to get a mocked PortFactory.
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
    • ditto.
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
    • ditto.
  • Scripts/webkitpy/layout_tests/port/init.py:
    • factory.get no longer exists. Yay!
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
    • Use a MockHost to get a mocked PortFactory. To do this efficiently, I created a helper function and combined all these (mostly redundant) tests into one test with several calls to the helper function.
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
    • Pass MockUser and MockExecutive in these port testing subclasses.
    • I also removed a bunch of unecessary uses of mocktool. namespacing.
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
    • Awesome windows hacks should only happen on win32. Once we started using MockExecutives these 'svn help' commands started printing in other tests, which is how I found this bug.
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
    • DryRunPort has no Host, so just use a PortFactory() directly. This will do the wrong thing if we're unittesting the DryRun port but it's no worse than the existing code.
  • Scripts/webkitpy/layout_tests/port/factory.py:
    • Remove the free functions.
    • Fix argument overriding to be able to override None.
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
    • Use a mocked-out PortFactory during testing.
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
    • Pass MockExecutive and MockUser to these manual Port instantiations.
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
    • No access to a Host object here, so just using PortFactory directly. This is wrong, but no more wrong than the existing code was.
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
    • Use a MockHost to get a mocked out PortFactory.
  • Scripts/webkitpy/layout_tests/port/test.py:
    • Use our fancy _set_default_overriding_none system to clean this code up and pass a MockExecutive.
  • Scripts/webkitpy/layout_tests/port/win.py:
    • Don't run cmd /c ver from WinPort.init or it shows up in unittests which have logging MockExecutive now that we're actually passing MockExecutive to most Port instantiations during testing.
  • Scripts/webkitpy/layout_tests/port/win_unittest.py:
    • Pass our new "unittesting" bool to _detect_version when actually unittesting.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Host is the future.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
    • Use a MockHost to get a mocked out PortFactory. Once we have a mocked PortFactory we don't need to pass MockUser explicitly, it does that automatically for us.
  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:
    • Use a MockHost to get a mocked out PortFactory.
  • Scripts/webkitpy/style/checkers/test_expectations.py:
    • We don't have access to a Host object, so using PortFactory() directly.
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
    • Remove unused variable.
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
    • Host isn't accessible here, so using PortFactory() directly, which although unfortunate is no worse than before.
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
    • Testing is much easier when you don't need to hack global state...
  • Scripts/webkitpy/tool/commands/expectations.py:
    • Use the port_factory on the tool.
  • Scripts/webkitpy/tool/commands/rebaseline.py:
    • ditto.
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
    • This unittest was wrong. It was trying to pass the tool object, but failing to pass the arguments in the right order. Fixing that made it use a MockFileSystem (like it had been trying to), which then required us to actually populate that MockFileSystem with fake expectation files (instead of using the ones on the real disk).
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
    • Get the port_factory from the tool.
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
    • Ditto.
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
    • Use a MockHost to get a mocked out Port object.
1:21 PM Changeset in webkit [99232] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JIT-specific code should be able to refer to register types even on JIT-disabled builds
​https://bugs.webkit.org/show_bug.cgi?id=71498

Reviewed by Gavin Barraclough.

  • assembler/MacroAssembler.h:

(MacroAssembler::MacroAssembler):

1:20 PM Changeset in webkit [99231] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Mark tests as slow in chromium.

fast/frames/lots-of-iframes.html and fast/frames/lots-of-objects.html
are already marked as timing out, but maybe they will pass in release
if we give them enough time.

  • platform/chromium/test_expectations.txt:
1:19 PM Changeset in webkit [99230] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

NetscapePlugin should use plug-in relative coordinates on Mac
​https://bugs.webkit.org/show_bug.cgi?id=71486

Reviewed by Adam Roben.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::paint):
Don't translate the graphics context when the plug-in doesn't want window relative coordinates.
This also fixed a bug I introduced in my previous commit where we'd always pass the dirty rect in
plug-in coordinates even if the plug-in wants window relative coordinates.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::snapshot):
Don't do the whole translate dance if the plug-in doesn't want window relative coordinates.

(WebKit::NetscapePlugin::wantsWindowRelativeCoordinates):
Return false for PLATFORM_ARCHITECTURE(MAC).

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformPaint):
Simplify code now that we know that the we're always given plug-in relative coordinates.

12:41 PM Changeset in webkit [99229] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

IndexedDB result of deleting a record should be true or false
​https://bugs.webkit.org/show_bug.cgi?id=60197

Patch by Joshua Bell <​jsbell@chromium.org> on 2011-11-03
Reviewed by David Levin.

Source/WebCore:

IDBObjectStore.delete() was incorrectly firing an error if there
was no record to remove. Match the spec, and return true/false
as success values instead. Bring JSC binding implementation of
SerializedScriptValue more in line with V8 version for methods
called from IDB code.

Test: storage/indexeddb/mozilla/delete-result.html

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::createFromWire):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):

  • bindings/js/SerializedScriptValue.h:
  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::nullValue):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):

  • bindings/v8/SerializedScriptValue.h:
  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::deleteInternal):

LayoutTests:

Add tests for IDBObjectStore.delete() - should succeed if
record exists or not, and return true/false as success value.

  • storage/indexeddb/mozilla/delete-result-expected.txt: Added.
  • storage/indexeddb/mozilla/delete-result.html: Added.
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
12:29 PM Changeset in webkit [99228] by abarth@webkit.org
  • 8 edits
    6 adds in trunk

Implement allow-popups for iframe@sandbox
​https://bugs.webkit.org/show_bug.cgi?id=66505

Reviewed by Eric Seidel.

Source/WebCore:

There's been some discussion in the HTML working group about adding an
allow-popups directive to the iframe sandbox. Microsoft has added it
to IE10 platform preview and is fairly adamant about this feature
because it's needed by one or their products that's planning to use
iframe sandbox. Hixie says he'll add it to the spec once we implement
it, so here's our implementation. (See discussion in the W3C linked in
the bug for more details.)

This patch lands most of the infrastructure for this feature, but it
doesn't actually enable the feature. I'll enable it in a follow-up
patch.

Tests: http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html

http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html
http/tests/security/popup-allowed-by-sandbox-when-allowed.html

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::parseMappedAttribute):

  • loader/FrameLoader.h:

(WebCore::FrameLoader::forceSandboxFlags):

  • loader/FrameLoaderTypes.h:
  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::parseSandboxPolicy):

  • page/SecurityOrigin.h:

(WebCore::SecurityOrigin::sandboxFlags):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

LayoutTests:

Test that the allow-popups directive works as expected. Note:
no-popup-from-sandbox.html verifies that we still block popups without
the directive.

These tests currently have expected.txt results that show failures, but
they will pass once this feature is enabled.

  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control-expected.txt: Added.
  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html: Added.
  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed-expected.txt: Added.
  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html: Added.
  • http/tests/security/popup-allowed-by-sandbox-when-allowed-expected.txt: Added.
  • http/tests/security/popup-allowed-by-sandbox-when-allowed.html: Added.
12:25 PM Changeset in webkit [99227] by abarth@webkit.org
  • 4 adds in trunk/Source

Add stubs for WTF and Platform
​https://bugs.webkit.org/show_bug.cgi?id=71492

Reviewed by Eric Seidel.

Source/Platform:

This patch creates the Platform directory, which begins the process of
moving Platform out of WebCore.

Source/WTF:

This patch creates the WTF directory, which begins the process of
moving WTF out of JavaScriptCore.

12:15 PM Changeset in webkit [99226] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[EFL] DRT: Allow choosing which backing store to use.
​https://bugs.webkit.org/show_bug.cgi?id=70532

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-11-03
Reviewed by Antonio Gomes.

This change makes it possible to change the backing store used by DRT
from Tiled Backing Store (TBS) to Single Backing Store (SBS) by
setting the environment variable DRT_USE_SINGLE_BACKING_STORE to 1.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):

  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(shouldUseSingleBackingStore):
(chooseAndInitializeAppropriateSmartClass):
(drtViewAdd):

  • DumpRenderTree/efl/DumpRenderTreeView.h:
11:48 AM Changeset in webkit [99225] by jchaffraix@webkit.org
  • 4 edits in trunk/LayoutTests

Unreviewed gardening after r99212.

  • platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.png:
  • platform/chromium/test_expectations.txt:

Rebaselined the test on Chromium Windows.

  • platform/efl/Skipped:

I forgot to check the visual baseline on EFL. The EFL port does not seem to have the
repaint result (likely due to lack of support) thus it does not need a rebaseline.

11:42 AM Changeset in webkit [99224] by tony@chromium.org
  • 2 edits
    3 deletes in trunk/LayoutTests

Correct chromium expectations for setPrinting and single-line-must-not-be-split-into-two-pages.
​https://bugs.webkit.org/show_bug.cgi?id=71080

  • platform/chromium-cg-mac-leopard/printing/setPrinting-expected.png: Removed.
  • platform/chromium-mac-leopard/printing/setPrinting-expected.txt: Removed.
  • platform/chromium-mac-leopard/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
11:20 AM Changeset in webkit [99223] by mhahnenberg@apple.com
  • 25 edits in trunk/Source

De-virtualize JSObject::className
​https://bugs.webkit.org/show_bug.cgi?id=71428

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Added className to the MethodTable, changed all the virtual
implementations of className to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::className):

(JSC::DebuggerActivation::className):

  • debugger/DebuggerActivation.h:
  • jsc.cpp:

(GlobalObject::createStructure):

  • profiler/Profiler.cpp:

(JSC::Profiler::createCallIdentifier):

  • runtime/ClassInfo.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::className):

  • runtime/JSCell.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::className):

  • runtime/JSObject.h:
  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString):

  • testRegExp.cpp:

(GlobalObject::createStructure):

Source/JavaScriptGlue:

Added className to the MethodTable, changed all the virtual
implementations of className to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • JSUtils.cpp:

(KJSValueToCFTypeInternal):

Source/WebCore:

No new tests.

Added className to the MethodTable, changed all the virtual
implementations of className to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::className):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::internalConstructorName):

  • bridge/testqtbindings.cpp:

(Global::className):

Source/WebKit/efl:

Added className to the MethodTable, changed all the virtual
implementations of className to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • ewk/ewk_js.cpp:

(ewk_js_npobject_to_object):

11:05 AM Changeset in webkit [99222] by jer.noble@apple.com
  • 4 edits
    6 adds in trunk/Source

Add Clock class and platform-specific implementations.
​https://bugs.webkit.org/show_bug.cgi?id=71341

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Add WTF_USE_COREAUDIO macro for use by PlatformClockCA.

  • wtf/Platform.h:

Source/WebCore:

No new tests; these classes will be used and tested by the MediaController feature.

Adds a abstract Clock class and two concrete, platform-specific subclasses.

Clock provides a basic interface for starting, stopping, and querying a generic timeline.
PlatformClockCA implements this interface using a CoreAudio CAClock object, which uses
the default audio device's hardware clock as a timing source. PlatformClockPOSIX
implements this interface using gettimeofday() as its timing source.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Clock.cpp: Added.

(Clock::create): Creates a platform-specific clock.

  • platform/Clock.h: Added.

(WebCore::Clock::~Clock):
(WebCore::Clock::Clock):

  • platform/mac/PlatformClockCA.cpp: Added.

(PlatformClockCA::PlatformClockCA):
(PlatformClockCA::~PlatformClockCA):
(PlatformClockCA::setCurrentTime):
(PlatformClockCA::currentTime):
(PlatformClockCA::setPlayRate):
(PlatformClockCA::PlatformClockCA::playRate):
(PlatformClockCA::start):
(PlatformClockCA::stop):

  • platform/mac/PlatformClockCA.h: Added.

(WebCore::PlatformClockCA::isRunning):

  • platform/posix/PlatformClockPOSIX.cpp: Added.

(timevalToFloat):
(timevalDelta):
(PlatformClockPOSIX::PlatformClockPOSIX):
(PlatformClockPOSIX::setCurrentTime):
(PlatformClockPOSIX::currentTime):
(PlatformClockPOSIX::setPlayRate):
(PlatformClockPOSIX::PlatformClockPOSIX::playRate):
(PlatformClockPOSIX::start):
(PlatformClockPOSIX::stop):
(PlatformClockPOSIX::now):

  • platform/posix/PlatformClockPOSIX.h: Added.

(WebCore::PlatformClockPOSIX::isRunning):

10:57 AM Changeset in webkit [99221] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Brought back TIMEOUT for show-hide-table-rows.html

  • platform/chromium/test_expectations.txt:
10:53 AM Changeset in webkit [99220] by arv@chromium.org
  • 2755 edits in trunk

JS Test Harness: Remove more link tags
​https://bugs.webkit.org/show_bug.cgi?id=71339

Reviewed by Ojan Vafai.

Tools:

  • Scripts/make-new-script-test:

(writeTestFile): Don't output <link>

LayoutTests:

  • LayoutTest/*: Remove links to js-test-style.css.
10:50 AM Changeset in webkit [99219] by leviw@chromium.org
  • 3 copies in branches/chromium/912/LayoutTests/svg/custom

Merge 99109 - Infinite recursion in RenderSVGResourceContainer::markAllClientsForInvalidation
​https://bugs.webkit.org/show_bug.cgi?id=71384

Reviewed by Darin Adler.

Source/WebCore:

Adding a reentrancy guard to RenderSVGResourceContainer to prevent infinite recursion when
resources reference one another and share ids.

Test: svg/custom/resource-invalidation-crash.svg

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation):

  • rendering/svg/RenderSVGResourceContainer.h:

LayoutTests:

Fixes a stack overflow when SVG resources reference one another and share ids.

  • svg/custom/resource-invalidation-crash-expected.png: Added.
  • svg/custom/resource-invalidation-crash-expected.txt: Added.
  • svg/custom/resource-invalidation-crash.svg: Added.

TBR=​leviw@chromium.org
Review URL: ​http://codereview.chromium.org/8446005

10:46 AM Changeset in webkit [99218] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Object stores not persisting between sessions
​https://bugs.webkit.org/show_bug.cgi?id=71313

Patch by Joshua Bell <​jsbell@chromium.org> on 2011-11-03
Reviewed by Tony Chang.

Logic flaw introduced with r98806 skipped the loading of object stores
during subsequent sessions.

  • storage/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):

10:42 AM Changeset in webkit [99217] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: fix heap profiler rendering and resize.
​https://bugs.webkit.org/show_bug.cgi?id=71484

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype.wasShown.profileCallback2):
(WebInspector.DetailedHeapshotView.prototype.wasShown):
(WebInspector.DetailedHeapshotView.prototype._changeView):
(WebInspector.DetailedHeapshotView.prototype._startRetainersHeaderDragging):

10:41 AM Changeset in webkit [99216] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Patch by Thouraya ANDOLSI <​thouraya.andolsi@st.com> on 2011-11-03
Reviewed by Martin Robinson.

[GTK] arguments passed to build-jsc are not taken into account
​https://bugs.webkit.org/show_bug.cgi?id=58333

  • Scripts/build-jsc:
10:37 AM Changeset in webkit [99215] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed evening gardening.

  • platform/qt/test_expectations.txt: Remove a useless entry.
10:34 AM Changeset in webkit [99214] by Csaba Osztrogonác
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Unreviewed evening gardening. Add platform specific expected results after r98989.

  • platform/qt/svg/filters/invalidate-on-child-layout-expected.png: Added.
  • platform/qt/svg/filters/invalidate-on-child-layout-expected.txt: Added.
10:26 AM Changeset in webkit [99213] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed evening gardening. Skip failing tests.

  • platform/qt-mac/Skipped:
  • platform/qt/Skipped:
10:20 AM Changeset in webkit [99212] by jchaffraix@webkit.org
  • 13 edits in trunk

Stop abusing RenderTableSection::needsRecalcCells logic
​https://bugs.webkit.org/show_bug.cgi?id=71420

Reviewed by Darin Adler.

Source/WebCore:

Change covered by existing tests like fast/repaint/table-extra-bottom-grow.html
and fast/table/row-height-recalc* (among others).

Cell recalculation is very expensive and should only be called when the section's structure
changed in a way that requires a safe update to its structure (like removing a row as our
column split may not be appropriate anymore).

The current code would abuse cell recalculation to actually reset the logical height on the
RowStruct. This change makes it do the right thing.

  • rendering/RenderTableCell.h:
  • rendering/RenderTableRow.h:

Removed styleWillChange override as it was unneeded.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleDidChange):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleDidChange):
Move the code from styleWillChange to styleDidChange.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::rowLogicalHeightChanged):
This function just reset the height on the |RowStruct| which is the
only part of recalcCells that we would need.

(WebCore::RenderTableSection::rowIndexForRenderer):
Added this function to find out which index a column has (strangely
RenderTableRow does not have this information).

  • rendering/RenderTableSection.h: Added the 2 previous functions.

LayoutTests:

  • platform/chromium-linux/fast/repaint/table-extra-bottom-grow-expected.png:

Update this test as this is a progression: we are not over-repainting the table
anymore.

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/qt/test_expectations.txt:

Skipped the test here as it needs a rebaseline.

10:16 AM Changeset in webkit [99211] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed rebaselining. Unskipped progress-event-constructor.html in Qt-Arm
since the failure is fixed in r99161.

  • platform/qt-arm/Skipped:
10:13 AM Changeset in webkit [99210] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

PluginControllerProxy's dirty rect should be in plug-in coordinates
​https://bugs.webkit.org/show_bug.cgi?id=71481

Reviewed by Sam Weinig.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::paint):
Convert the dirty rect to window coordinates before passing it to the plug-in.

(WebKit::PluginControllerProxy::invalidate):
No need to convert the dirty rect to window coordinates.

(WebKit::PluginControllerProxy::paintEntirePlugin):
Use m_pluginSize instead of m_frameRectInWindowCoordinates.isEmpty.

10:10 AM Changeset in webkit [99209] by Lucas Forschler
  • 1 copy in tags/Safari-535.8

New tag.

10:06 AM Changeset in webkit [99208] by fsamuel@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Refactor WebFrameImpl::createFrameView() to use Frame:createView
​https://bugs.webkit.org/show_bug.cgi?id=70507

Reviewed by Darin Fisher.

No change in functionality except for fixed layout mode. Fixed layout mode has
not been fully upstreamed yet, so no new tests yet:
​https://bugs.webkit.org/show_bug.cgi?id=70562 will address this.

This patch also fixes ​https://bugs.webkit.org/show_bug.cgi?id=70555
It was decided that fixed layout mode might need to be disabled for some content,
and so this change enables the embedder to decide whether to enable fixed layout on
navigation.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):

10:06 AM Changeset in webkit [99207] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Show url of history items in a status bar in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=71474

Reviewed by Martin Robinson.

  • MiniBrowser/gtk/BrowserWindow.c:

(browserWindowSetStatusText): Set status text and show/hide the
status label.
(resetStatusText): Reset status text when history menu is hidden.
(browserWindowHistoryItemSelected): Show url of currently selected
history item.
(browserWindowCreateBackForwardMenu): Connect to hide signal of
menu to reset the status text.
(browserWindowConstructed): Use GtkOverlay if available to show
status text.

10:01 AM Changeset in webkit [99206] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=71466

Reviewed by Martin Robinson.

  • MiniBrowser/gtk/BrowserWindow.c:

(browserWindowHistoryItemActivated): Go to selected back formard
list item using webkit_web_view_go_to_back_forward_list_item()
(browserWindowCreateBackForwardMenu): Create a GtkMenu for the
given GList of WebKitBackForwardListItems.
(browserWindowUpdateNavigationActions): Enable/disable back and
forward buttons depending on whether it's possible to go
back/forward. Create a menu for back and forward toolbar buttons.
(backForwadlistChanged): Call browserWindowUpdateNavigationActions().
(browserWindowConstructed): Connect to WebKitBackForwardList
changed signal.

9:54 AM Changeset in webkit [99205] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Use the right function to determine whether NPWindow coordinates should be window relative
​https://bugs.webkit.org/show_bug.cgi?id=71480

Reviewed by Adam Roben.

We want to use wantsWindowRelativeNPWindowCoordinates here, and not wantsWindowRelativeCoordinates
which is a temporary function that will be removed (and that returns the wrong value!)

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::geometryDidChange):

9:31 AM Changeset in webkit [99204] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

CSSRuleList: Move rule orphaning from deleteRule() out to callers.
​https://bugs.webkit.org/show_bug.cgi?id=71470

Patch by Andreas Kling <​kling@webkit.org> on 2011-11-03
Reviewed by Antti Koivisto.

Rule parenting is the responsibility of the owner rule (the rule containing
the rule list), so move parent clearing out of CSSRuleList::deleteRule() and
into the (two) call sites.

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::deleteRule):

  • css/CSSRuleList.cpp:

(WebCore::CSSRuleList::deleteRule):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::deleteRule):

9:28 AM Changeset in webkit [99203] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: do not map scripts generated with document.write to the document resources.
​https://bugs.webkit.org/show_bug.cgi?id=71114

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.editSource):
(WebInspector.Script.prototype.isInlineScript):

9:16 AM Changeset in webkit [99202] by Simon Hausmann
  • 24 edits
    2 deletes in trunk

[Qt] Remove Maemo specific code paths
​https://bugs.webkit.org/show_bug.cgi?id=71476

Reviewed by Kenneth Rohde Christiansen.

.:

  • Source/WebKit.pri:

Source/WebCore:

  • WebCore.pri:
  • features.pri:
  • plugins/PluginPackage.cpp:

(WebCore::PluginPackage::determineQuirks):

  • plugins/PluginView.cpp:

(WebCore::PluginView::setValue):

  • plugins/PluginView.h:
  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::platformGetValueStatic):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::userAgentForUrl):

  • Api/qwebview.cpp:

(QWebView::QWebView):

  • QtWebKit.pro:
  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::createSelectPopup):

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::setInputMethodState):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::createPlugin):

  • WebCoreSupport/QtMaemoWebPopup.cpp: Removed.
  • WebCoreSupport/QtMaemoWebPopup.h: Removed.
  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView::focusInputTypes):

  • tests/qwebframe/tst_qwebframe.cpp:
  • tests/qwebview/tst_qwebview.cpp:

(tst_QWebView::focusInputTypes):

Tools:

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::~LauncherWindow):
(LauncherWindow::init):
(LauncherWindow::showLinkHover):
(LauncherWindow::selectElements):
(LauncherWindow::showFPS):
(LauncherWindow::updateFPS):

  • QtTestBrowser/launcherwindow.h:

(WindowOptions::WindowOptions):

  • QtTestBrowser/locationedit.cpp:
  • QtTestBrowser/locationedit.h:
9:13 AM Changeset in webkit [99201] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=71461

Reviewed by Martin Robinson.

  • MiniBrowser/gtk/BrowserWindow.c:

(resetEntryProgress): Reset the entry progress after a while when
load has been completed.
(webViewLoadProgressChanged): Update location entry progress.
(browserWindowConstructed): Connect to WebView
notify::estimated-load-progress signal.

9:10 AM Changeset in webkit [99200] by Carlos Garcia Campos
  • 5 edits
    1 delete in trunk/Tools

[GTK] Remove WebKit2 C API from MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=71459

Reviewed by Martin Robinson.

Use the GTK+ API instead to add minimum functionality. The other
features will be ported to GTK+ API in following patches.

  • MiniBrowser/gtk/BrowserWindow.c:

(activateUriEntryCallback): Use webkit_web_view_load_uri().
(goBackCallback): Use webkit_web_view_go_back().
(goForwardCallback): Use webkit_web_view_go_forward().
(webViewURIChanged): Update location entry with current uri using
webkit_web_view_get_uri().
(browserWindowFinalize):
(browserWindowGetProperty):
(browserWindowSetProperty):
(browser_window_init):
(browserWindowConstructed): Connect to notify::uri signal of
WebView to be notified when the URI changes.
(browser_window_class_init):
(browser_window_new): Use WebKitWebView.
(browser_window_get_view): Use WebKitWebView

  • MiniBrowser/gtk/BrowserWindow.h:
  • MiniBrowser/gtk/GNUmakefile.am:
  • MiniBrowser/gtk/WebBundle/WebBundleMain.c: Removed.
  • MiniBrowser/gtk/main.c:

(loadURI): Use webkit_web_view_new().
(main):

9:07 AM Changeset in webkit [99199] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r99195.

The right name is restrictMinimumScaleFactorToViewportSize.

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::updateViewportConstraints):

9:04 AM Changeset in webkit [99198] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Use WEBKIT_API instead of WK_EXPORT in WebKitEnumTypes.h
​https://bugs.webkit.org/show_bug.cgi?id=71457

Reviewed by Martin Robinson.

  • GNUmakefile.am:
8:40 AM Changeset in webkit [99197] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Bounce back limits are wrong in some situations
​https://bugs.webkit.org/show_bug.cgi?id=71471

Reviewed by Simon Hausmann.

The valid position points were in viewport coordinates, but we were
requiring valid position points in content coordinates.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):

8:31 AM Changeset in webkit [99196] by Simon Hausmann
  • 2 edits
    2 adds in trunk/Source/WebKit/qt

Patch by Jesus Sanchez-Palencia <​jesus@webkit.org> on 2011-11-03
Reviewed by Kenneth Rohde Christiansen.

[Qt] QtWebKit should have documentation clarifying its mobile features usage
​https://bugs.webkit.org/show_bug.cgi?id=41465

Add "QtWebKit Goes Mobile" documentation

  • docs/qtwebkit-goes-mobile.qdoc: Added.
  • docs/qtwebkit.qdoc: Linked to qtwebkit-goes-mobile documentation
  • docs/webkitsnippets/qtwebkit_goes_mobile_snippets.cpp: Added.
8:22 AM Changeset in webkit [99195] by fsamuel@chromium.org
  • 15 edits in trunk/Source

Removing line in computeViewportAttributes that enforces a minimum scale factor to never allow zooming out more than viewport
​https://bugs.webkit.org/show_bug.cgi?id=70609

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Operations in computeViewportAttributes that are not a part of the spec:

​http://www.w3.org/TR/2011/WD-css-device-adapt-20110915/#constraining-viewport-property-values

were moved into the functions restrictMinimumScaleFactorToViewportSize and
restrictScaleFactorToInitialScaleIfNotUserScalable.

  • WebCore.exp.in:
  • dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes):
(WebCore::restrictMinimumScaleFactorToViewportSize):
(WebCore::restrictScaleFactorToInitialScaleIfNotUserScalable):

  • dom/ViewportArguments.h:

Source/WebKit/efl:

  • ewk/ewk_view.cpp:

(_ewk_view_viewport_attributes_compute):

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::dumpConfigurationForViewport):

  • webkit/webkitviewportattributes.cpp:

(webkitViewportAttributesRecompute):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::viewportAttributesForSize):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::viewportAsText):

Source/WebKit2:

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::updateViewportConstraints):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::viewportConfigurationAsText):

8:21 AM Changeset in webkit [99194] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Fix the signal signature of the loadFailed API test.

Rubber-stamped by Simon Hausmann.

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::touchViewLoadFailed):
(WebViewAbstraction::desktopViewLoadFailed):

8:05 AM Changeset in webkit [99193] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Unable to start MiniBrowser after run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=71469

Reviewed by Csaba Osztrogonác.

  • Scripts/run-launcher: Pass @ARGV instead of @args, which is stripped

from things like -2. Neither Gtk or Qt MiniBrowser like unknown command
line arguments.

7:49 AM Changeset in webkit [99192] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix an assertion under WebPage::setViewportSize.
​https://bugs.webkit.org/show_bug.cgi?id=71473

Reviewed by Simon Hausmann.

The web view can have an empty size and it causes the assert in computeViewportAttributes.
Don't notify the web page of such a size change in this case.

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::updateViewportSize):

7:44 AM Changeset in webkit [99191] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations update.

  • platform/chromium/test_expectations.txt:
7:42 AM Changeset in webkit [99190] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix, sigh.

  • css/CSSFontFaceRule.h:
  • css/CSSMutableStyleDeclaration.h:
7:39 AM Changeset in webkit [99189] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping 3 new svg tests presenting pixel differences
between the 32-bits and 64-bits bots.

  • platform/gtk/Skipped:
7:32 AM Changeset in webkit [99188] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WK2] State variable name refactor in WebPageProxy.cpp
​https://bugs.webkit.org/show_bug.cgi?id=71467

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2011-11-03
Reviewed by Andreas Kling.

Renaming m_inDecidePolicyForMIMEType to m_inDecidePolicyForResponse after
​https://bugs.webkit.org/show_bug.cgi?id=55827 .

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForResponse):

  • UIProcess/WebPageProxy.h:
7:27 AM Changeset in webkit [99187] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix, out-of-line StyleSheet::parentStyleSheet()
again since there's a cycle in the includes between CSSRule/StyleSheet.

  • css/StyleSheet.cpp:

(WebCore::StyleSheet::parentStyleSheet):

  • css/StyleSheet.h:
7:12 AM Changeset in webkit [99186] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r99185, removing forward-declaration
of CSSRule since CSSRule.h is already included.

  • css/StyleSheet.h:
7:01 AM Changeset in webkit [99185] by andreas.kling@nokia.com
  • 11 edits in trunk/Source/WebCore

CSSOM: Inline some trivial methods.
​https://bugs.webkit.org/show_bug.cgi?id=71468

Reviewed by Antti Koivisto.

  • css/CSSFontFaceRule.cpp:
  • css/CSSFontFaceRule.h:

(WebCore::CSSFontFaceRule::setDeclaration):

  • css/CSSStyleRule.cpp:
  • css/CSSStyleRule.h:

(WebCore::CSSStyleRule::setDeclaration):

  • css/CSSStyleSheet.cpp:
  • css/CSSStyleSheet.h:

(WebCore::CSSStyleSheet::ownerRule):

  • css/StyleSheet.cpp:
  • css/StyleSheet.h:

(WebCore::StyleSheet::parentStyleSheet):

  • css/WebKitCSSKeyframesRule.cpp:
  • css/WebKitCSSKeyframesRule.h:

(WebCore::WebKitCSSKeyframesRule::name):
(WebCore::WebKitCSSKeyframesRule::length):

6:53 AM Changeset in webkit [99184] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

Devirtualize MediaList.
​https://bugs.webkit.org/show_bug.cgi?id=71464

Reviewed by Antti Koivisto.

  • css/MediaList.h: Make the destructor non-virtual.
6:48 AM Changeset in webkit [99183] by zherczeg@webkit.org
  • 8 edits
    2 adds in trunk/Source/WebCore

Optimizing arithmetic composite filter to ARM-neon SIMD instruction set
​https://bugs.webkit.org/show_bug.cgi?id=65522

Reviewed by Dirk Schulze.

This patch continues the work of Felician Marton.

The arithmetic operation of feComposite SVG filter can be greatly enhanced
by the ARM-NEON instruction set since we are able to calculate the pixel data
for all four RGBA channels at the same time.

It won't affect the general behavior and existing tests will cover the changes.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/filters/FEComposite.cpp:

(WebCore::computeArithmeticPixels):
(WebCore::arithmeticSoftware):
(WebCore::FEComposite::platformArithmeticSoftware):
(WebCore::FEComposite::platformApplySoftware):

  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/arm/FECompositeArithmeticNEON.cpp: Added.
  • platform/graphics/filters/arm/FECompositeArithmeticNEON.h: Added.

(WebCore::FEComposite::platformArithmeticNeon):

6:40 AM Changeset in webkit [99182] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Qt] Add pageScaleFactor to the serialized history item
​https://bugs.webkit.org/show_bug.cgi?id=71463

Reviewed by Tor Arne Vestbø.

r75758 added the pageScaleFactor member, which we need to
serialize.

  • history/qt/HistoryItemQt.cpp:

(WebCore::HistoryItem::restoreState):
(WebCore::HistoryItem::saveState):

6:33 AM Changeset in webkit [99181] by mikelawther@chromium.org
  • 2 edits in trunk/Source/WebCore

Use createPrimitiveNumericValue function
​https://bugs.webkit.org/show_bug.cgi?id=71432

Reviewed by Andreas Kling.

No new tests - no change in functionality.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseWrapShapeRect):
(WebCore::CSSParser::parseWrapShapeCircle):
(WebCore::CSSParser::parseWrapShapeEllipse):
(WebCore::CSSParser::parseWrapShapePolygon):

6:28 AM Changeset in webkit [99180] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip
http/tests/security/xssAuditor/script-tag-with-callbacks.html on
GTK, relying on an unimplemented feature.

  • platform/gtk/Skipped:
6:26 AM Changeset in webkit [99179] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

[GTK][WEBKIT2] Add support for title property in WebKitWebView.
​https://bugs.webkit.org/show_bug.cgi?id=68074

Patch by Nayan Kumar K <​nayankk@motorola.com> on 2011-11-03
Reviewed by Philippe Normand.

Support for 'title' property is added in WebKitWebView.
Functions to get the value of this property is provided.

  • UIProcess/API/gtk/WebKitWebLoaderClient.cpp:

(didReceiveTitleForFrame): LoaderClient titleRecieve callback.
(webkitWebLoaderClientAttachLoaderClientToPage): Register didReceiveTitleForFrame callback.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewGetProperty): 'title' property get function.
(webkit_web_view_class_init): Register new property.
(webkitWebViewSetTitle): Notify WebKitWebView about title receive.
(webkit_web_view_get_title): API to get main frame title.

  • UIProcess/API/gtk/WebKitWebView.h: webkit_web_view_get_title API expose.
  • UIProcess/API/gtk/WebKitWebViewPrivate.h: Added private API.
  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:

(testWebViewTitle): Test webkit_web_view_get_title API.
(beforeAll): Add testWebViewTitle test.

6:05 AM Changeset in webkit [99178] by commit-queue@webkit.org
  • 32 edits
    1 copy
    7 adds in trunk/Source

[Qt][WK2] Download support and API in UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=68962

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2011-11-03
Reviewed by Simon Hausmann.

Source/WebKit/qt:

Registering new qml type QWebDownloadItem.

  • declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes):

Source/WebKit2:

We implement our WkContextDownloadClient and the needed callbacks.
We also add APIs by exposing QWebDownloadItem. Objects from this type
have their ownership handled by QDesktopWebView and will be created or
destroyed as needed. Classes implementing ViewInterface (QDesktopWebViewPrivate
and TouchViewInterface) will receive a signal (downloadRequested) with a pointer
to the recently created QWebDownloadItem. With that they can connect the proper
signals and slots, set the download destination path and then call start().
Objects of this type will provide the progress of a download, a slot to cancel it,
and signals for getting finished or failure status.
QWebDownloadItem was also exposed in QML.
Qt needed an asynchronous way for UIProcess to return a destination path to WebProcess,
therefore the startTransfer API was added to WebKit2's Download handlers.

  • Shared/qt/WebCoreArgumentCodersQt.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):
Add encoding and decoding of suggestedFilename for ResourceResponse.

  • UIProcess/API/qt/WKView.h:
  • UIProcess/API/qt/qbasewebview.h: Add signal downloadRequested.
  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::downloadRequested):

  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/API/qt/qwebdownloaditem.cpp: Added.

(QWebDownloadItemPrivate::QWebDownloadItemPrivate):
(QWebDownloadItem::QWebDownloadItem):
(QWebDownloadItem::~QWebDownloadItem):
(QWebDownloadItem::url):
(QWebDownloadItem::destinationPath):
(QWebDownloadItem::setDestinationPath):
(QWebDownloadItem::suggestedFilename):
(QWebDownloadItem::mimeType):
(QWebDownloadItem::expectedContentLength):
(QWebDownloadItem::totalBytesReceived):
(QWebDownloadItem::cancel):
(QWebDownloadItem::start):

  • UIProcess/API/qt/qwebdownloaditem.h: Added.
  • UIProcess/API/qt/qwebdownloaditem_p.h: Added.

(QWebDownloadItemPrivate::didReceiveResponse):

  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/download.html: Added.
  • UIProcess/API/qt/tests/qmltests/common/download.zip: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::startTransfer): Qt only function added.

  • UIProcess/Downloads/DownloadProxy.h:
  • UIProcess/PageClient.h: Added Qt specific function to call handleDownloadRequest from QtWebPageProxy.
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::download):
Using WebPageProxy::handleDownloadRequest to bootstrap a download through PageClient.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):
Using handleDownloadRequest() to bootstrap a download through PageClient.
(WebKit::WebPageProxy::handleDownloadRequest): Calls PageClient::handleDownloadRequest().

  • UIProcess/WebPageProxy.h:
  • UIProcess/qt/QtDownloadManager.cpp: Added.

(WebKit::toQtDownloadManager):
(WebKit::qt_wk_didReceiveResponse):
(WebKit::qt_wk_didCreateDestination):
(WebKit::qt_wk_didFinishDownload):
(WebKit::qt_wk_didFailDownload):
(WebKit::qt_wk_didReceiveDataForDownload):
(QtDownloadManager::downloadReceivedResponse): Will reach QtWebPageProxy::didReceiveDownloadResponse.
(QtDownloadManager::downloadCreatedDestination):
(QtDownloadManager::downloadFinished):
(QtDownloadManager::downloadFailed):
(QtDownloadManager::downloadDataReceived):

  • UIProcess/qt/QtDownloadManager.h: Added.

Bootstrap our WKContextDownloadClient and set its callbacks.
This entity will also handle all downloads and keep a map of them.
It will be kept alive together with the WebContext as a static member
of QtWebPageProxy, so we can keep it across several WebPages and, therefore,
WebViews.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::defaultWKContext):
(QtWebPageProxy::~QtWebPageProxy):
(QtWebPageProxy::handleDownloadRequest):
(QtWebPageProxy::didReceiveDownloadResponse):

  • UIProcess/qt/QtWebPageProxy.h:

From now on it will keep a static QtDownloadManager to live together
with the default WebContext. It implements PageClient::handleDownloadRequest.
QtWebPageProxy::didReceiveDownloadResponse will emit the view's signal downloadRequested.

  • UIProcess/qt/QtTouchViewInterface.h:

(WebKit::QtTouchViewInterface::downloadRequested):

  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/qweberror.cpp:

(QWebError::description):

  • UIProcess/qt/qweberror.h:

(QWebError::errorCodeAsDownloadError):
Add Download error handling to QWebError and a new API
to retrieve the error description from the original ResourceError.
Also, it now has QWebDownloadItem::DownloadError errorCodeAsDownloadError()
that returns the error code as a DownloadError.

  • WebKit2.pro:
  • WebKit2API.pri:
  • WebProcess/Downloads/Download.h:
  • WebProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::startTransfer):

  • WebProcess/Downloads/DownloadManager.h:

Adding Qt specific startTransfer function.

  • WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::didDecideDestination):
(WebKit::Download::startTransfer):

  • WebProcess/Downloads/qt/QtFileDownloader.cpp:

(WebKit::QtFileDownloader::init): start() was renamed to init().
(WebKit::QtFileDownloader::determineFilename):
Calling onReadyRead() here was unnecessary and it was triggering the overall
download process even before DownloadManager finished startDownload(). This
was leading to a DownloadManager with an empty list of downloads.
(WebKit::QtFileDownloader::startTransfer): decidedDestination() became startTransfer().
(WebKit::QtFileDownloader::abortDownloadWritingAndEmitError):
(WebKit::QtFileDownloader::handleDownloadResponse):
(WebKit::QtFileDownloader::onReadyRead):
(WebKit::QtFileDownloader::onFinished):
(WebKit::QtFileDownloader::cancel):

  • WebProcess/Downloads/qt/QtFileDownloader.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::startTransfer):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

Adding Qt specific message StartTransfer and handling function.

6:04 AM Changeset in webkit [99177] by pfeldman@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-11-03 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: fixing win build. step2.

5:52 AM Changeset in webkit [99176] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

Add webkit_web_view_load_html and webkit_web_view_load_plain_text APIs.
​https://bugs.webkit.org/show_bug.cgi?id=69249

Patch by Nayan Kumar K <​nayankk@motorola.com> on 2011-11-03
Reviewed by Philippe Normand.

This patch adds support for 2 more load APIs, namely
webkit_web_view_load_html and webkit_web_view_load_plain_text.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_load_html): New API to load html string.
(webkit_web_view_load_plain_text): New API to load plain text.

  • UIProcess/API/gtk/WebKitWebView.h: Public API addition.
  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:

(testLoadHtml): Test webkit_web_view_load_html API.
(testLoadPlainText): Test webkit_web_view_load_plain_text API.
(beforeAll): Add new tests.

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::loadHtml): Test webkit_web_view_load_html API.
(WebViewTest::loadPlainText): Test webkit_web_view_load_plain_text API.

  • UIProcess/API/gtk/tests/WebViewTest.h:
5:49 AM Changeset in webkit [99175] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-11-03 Pavel Feldman <​pfeldman@google.com>

Not reviewed: win build fix. Assign autoDPI at all cases (breakage introduced in r99173).

  • dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
5:33 AM Changeset in webkit [99174] by pfeldman@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-11-03 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: fix windows build, step1

5:21 AM Changeset in webkit [99173] by kenneth@webkit.org
  • 4 edits in trunk/Source/WebCore

Differentiate implicit viewport from that of the meta tag
​https://bugs.webkit.org/show_bug.cgi?id=71453

Reviewed by Simon Hausmann.

This is needed because of DPI adjustment taking place with the meta
tag. This is to be avoided when no viewport meta tag is present.

  • dom/Document.cpp:

(WebCore::Document::processViewport):

  • dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes):

  • dom/ViewportArguments.h:

(WebCore::ViewportArguments::ViewportArguments):
(WebCore::ViewportArguments::operator==):

5:16 AM Changeset in webkit [99172] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Another batch of expectations clean-up.

  • platform/chromium/test_expectations.txt:
5:14 AM Changeset in webkit [99171] by andreas.kling@nokia.com
  • 12 edits in trunk/Source/WebCore

Devirtualize CSSRule.
​https://bugs.webkit.org/show_bug.cgi?id=71382

Reviewed by Antti Koivisto.

Remove the virtual destructor from CSSRule, and reimplement RefCounted's deref()
to invoke operator delete on the appropriate subclass type.

This removes the CSSRule vtable and shrinks each instance by one CPU word.

  • css/CSSCharsetRule.h:
  • css/CSSFontFaceRule.h:
  • css/CSSMediaRule.h:
  • css/CSSPageRule.h:
  • css/CSSRegionStyleRule.h:
  • css/CSSRule.cpp:
  • css/CSSRule.h:

(WebCore::CSSRule::deref):
(WebCore::CSSRule::~CSSRule):

  • css/CSSStyleRule.h:
  • css/WebKitCSSKeyframeRule.h:

Devirtualize!

  • css/CSSRule.cpp:

(WebCore::CSSRule::destroy):

Added, invokes operator delete on the right subclass type.

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::CSSImportRule):
(WebCore::CSSImportRule::~CSSImportRule):
(WebCore::CSSImportRule::requestStyleSheet):

  • css/CSSImportRule.h:

(WebCore::CSSImportRule::ImportedStyleSheetClient::ImportedStyleSheetClient):
(WebCore::CSSImportRule::ImportedStyleSheetClient::~ImportedStyleSheetClient):
(WebCore::CSSImportRule::ImportedStyleSheetClient::setCSSStyleSheet):

Break out the inheritance from CachedStyleSheetClient into a member variable
that simply redirects the setCSSStyleSheet() callback to the CSSImportRule.

5:09 AM Changeset in webkit [99170] by Simon Hausmann
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Failing assertion with desktop webview when touch mocking in MinBrowser
​https://bugs.webkit.org/show_bug.cgi?id=71452

Reviewed by Andreas Kling.

Don't re-implement touchEvent(), we don't intend to support touch events as we
receive them from the QQuickCanvas at this point.

  • UIProcess/API/qt/qdesktopwebview.cpp:
  • UIProcess/API/qt/qdesktopwebview.h:
5:03 AM Changeset in webkit [99169] by hans@chromium.org
  • 14 edits in trunk/Source

IndexedDB: Recycle cursor objects when calling continue()
​https://bugs.webkit.org/show_bug.cgi?id=71115

Reviewed by Darin Fisher.

Source/WebCore:

The IndexedDB spec says that cursors should be recycled when calling
continue(). Let the IDBRequest keep track of which cursor to return
upon success, and have the cursor use a new callback:
onSuccessWithContinuation() to signal that the continue was successful.

When we start using the new callback, the
storage/indexeddb/cursor-inconsistency.html layout test will start
passing.

  • storage/IDBCallbacks.h:
  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::continueFunctionInternal):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::setCursor):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):

  • storage/IDBRequest.h:

Source/WebKit/chromium:

Add the new onSuccessWithContinuation() callback to IDB wrappers.

  • public/WebIDBCallbacks.h:

(WebKit::WebIDBCallbacks::onSuccessWithContinuation):

  • src/IDBCallbacksProxy.cpp:

(WebKit::IDBCallbacksProxy::onSuccessWithContinuation):

  • src/IDBCallbacksProxy.h:
  • src/WebIDBCallbacksImpl.cpp:

(WebKit::WebIDBCallbacksImpl::onSuccessWithContinuation):

  • src/WebIDBCallbacksImpl.h:
5:03 AM Changeset in webkit [99168] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip failing tests.
5:02 AM Changeset in webkit [99167] by pfeldman@chromium.org
  • 22 edits
    1 copy in trunk

Web Inspector: preserve script location for inline handlers.
​https://bugs.webkit.org/show_bug.cgi?id=71367

Source/JavaScriptCore:

Makes SourceCode factories receive TextPosition instead of the line number;
Stores consistent position values in SourceCode and SourceProvider;

Patch by Pavel Feldman <​pfeldman@google.com> on 2011-11-03
Reviewed by Yury Semikhatsky.

  • API/JSBase.cpp:

(JSEvaluateScript):
(JSCheckScriptSyntax):

  • API/JSObjectRef.cpp:

(JSObjectMakeFunction):

  • parser/SourceCode.h:

(JSC::makeSource):

  • parser/SourceProvider.h:

(JSC::SourceProvider::SourceProvider):
(JSC::SourceProvider::startPosition):
(JSC::UStringSourceProvider::create):
(JSC::UStringSourceProvider::UStringSourceProvider):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunction):
(JSC::constructFunctionSkippingEvalEnabledCheck):

  • runtime/FunctionConstructor.h:

Source/WebCore:

Makes eventHandler report position, not line number;

Patch by Pavel Feldman <​pfeldman@google.com> on 2011-11-03
Reviewed by Yury Semikhatsky.

  • bindings/js/CachedScriptSourceProvider.h:

(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::initializeJSFunction):

  • bindings/js/JSLazyEventListener.h:

(WebCore::JSLazyEventListener::create):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::eventHandlerPosition):

  • bindings/js/ScriptController.h:
  • bindings/js/ScriptEventListener.cpp:

(WebCore::createAttributeEventListener):

  • bindings/js/ScriptSourceProvider.h:

(WebCore::ScriptSourceProvider::ScriptSourceProvider):

  • bindings/js/StringSourceProvider.h:

(WebCore::StringSourceProvider::create):
(WebCore::StringSourceProvider::StringSourceProvider):
(WebCore::makeSource):

LayoutTests:

Linkifier test reimplemented for simplisity.

Patch by Pavel Feldman <​pfeldman@google.com> on 2011-11-03
Reviewed by Yury Semikhatsky.

  • inspector/debugger/debugger-scripts-expected.txt:
  • inspector/debugger/debugger-scripts.html:
  • inspector/debugger/linkifier-expected.txt:
  • inspector/debugger/linkifier.html:
  • platform/chromium/inspector/debugger/debugger-scripts-expected.txt: Copied from LayoutTests/inspector/debugger/debugger-scripts-expected.txt.
4:52 AM Changeset in webkit [99166] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed update of test expectations.

  • platform/chromium/test_expectations.txt:
4:20 AM Changeset in webkit [99165] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

[Qt] [WK2] MiniBrowser assert in QtWebProccess on startup in debug build.
​https://bugs.webkit.org/show_bug.cgi?id=71196

Reviewed by Kenneth Rohde Christiansen.

Ensure AC is turned off for the desktop view before we launch the process.
This avoids "accidential" enterAc/exitAc calls that cause failing assertions
because we don't really support AC in this setup.

The touch side works the same way, i.e. enable the preference before calling
init().

  • UIProcess/qt/QtDesktopWebPageProxy.cpp:

(QtDesktopWebPageProxy::QtDesktopWebPageProxy):

4:09 AM Changeset in webkit [99164] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Styles] Do not check isEditingAnyField in StylesSidebarPane._createNewRule
​https://bugs.webkit.org/show_bug.cgi?id=71217

Reviewed by Yury Semikhatsky.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype.set _createNewRule):

3:37 AM Changeset in webkit [99163] by kbalazs@webkit.org
  • 6 edits in trunk

[Qt] X11 plugins need to be reworked for Qt5
​https://bugs.webkit.org/show_bug.cgi?id=70023

Reviewed by Simon Hausmann.

Source/WebCore:

Disable X11 plugins with Qt5.

  • features.pri:

Source/WebKit2:

Disable X11 plugins.

  • config.h:

LayoutTests:

Disable plugin tests with Qt5.

  • platform/qt-5.0/Skipped:
3:33 AM Changeset in webkit [99162] by commit-queue@webkit.org
  • 10 edits
    6 deletes in trunk

Unreviewed, rolling out r99138.
​http://trac.webkit.org/changeset/99138
​https://bugs.webkit.org/show_bug.cgi?id=71455

It made 200+ tests flakey on SL and on Qt (Requested by Ossy
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-03

Source/WebCore:

  • html/HTMLIFrameElement.cpp:

(WebCore::parseSandboxAttribute):
(WebCore::HTMLIFrameElement::parseMappedAttribute):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::setOpener):
(WebCore::createWindow):

  • loader/FrameLoader.h:

(WebCore::FrameLoader::setForcedSandboxFlags):

  • loader/FrameLoaderTypes.h:
  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNewWindowPolicy):

  • page/SecurityOrigin.cpp:
  • page/SecurityOrigin.h:
  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

LayoutTests:

  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control-expected.txt: Removed.
  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html: Removed.
  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed-expected.txt: Removed.
  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html: Removed.
  • http/tests/security/popup-allowed-by-sandbox-when-allowed-expected.txt: Removed.
  • http/tests/security/popup-allowed-by-sandbox-when-allowed.html: Removed.
3:23 AM Changeset in webkit [99161] by haraken@chromium.org
  • 9 edits in trunk

Fixed wrong implementation of doubleValue % 2{64}.
​https://bugs.webkit.org/show_bug.cgi?id=67980

Reviewed by Hajime Morita.

Source/JavaScriptCore:

fast/events/constructors/progress-event-constructor.html was failing
because of the wrong implementation of conversion from an ECMAScript value
to an IDL unsigned long long value (Spec: ​http://www.w3.org/TR/WebIDL/#es-unsigned-long-long).
In particular, the calculation of doubleValue % 2{64} was wrong.
This patch implemented it correctly in doubleToInteger() in wtf/MathExtras.h.

  • wtf/MathExtras.h:

(doubleToInteger): Implemented the spec correctly.

Source/WebCore:

fast/events/constructors/progress-event-constructor.html was failing
because of the wrong implementation of conversion from an ECMAScript value
to an IDL unsigned long long value (Spec: ​http://www.w3.org/TR/WebIDL/#es-unsigned-long-long).
In particular, the calculation of doubleValue % 2{64} was wrong.
This patch implemented it correctly in doubleToInteger() in wtf/MathExtras.h.

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue): Uses doubleToInteger().

  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::getKeyValue): Ditto.

LayoutTests:

Enabled progress-event-constructor.html on Chromium-Mac.

  • fast/events/constructors/progress-event-constructor-expected.txt:
  • fast/events/constructors/progress-event-constructor.html: The change from "12345678901234567168" to "12345678901234567890" is not related to this patch. Just to fix typo. The reason for whether "12345678901234567168" or "12345678901234567890" does not matter is that both values are toStringed to the same value "12345678901234567000".
  • platform/chromium/test_expectations.txt:
3:21 AM Changeset in webkit [99160] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip fast/css/webkit-mask-crash-table.html crasher on
GTK.

  • platform/gtk/Skipped:
3:08 AM Changeset in webkit [99159] by apavlov@chromium.org
  • 13 edits
    1 add in trunk/Source/WebCore

Web Inspector: Introduce SuggestBox for TextPrompt
​https://bugs.webkit.org/show_bug.cgi?id=71288

Reviewed by Pavel Feldman.

Drive-by fix for a regression where clicking in the Database query view did not focus the prompt.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype.completions):
(WebInspector.ConsoleView.prototype._completions.receivedPropertyNames):
(WebInspector.ConsoleView.prototype._completions):
(WebInspector.ConsoleView.prototype._reportCompletions):

  • inspector/front-end/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView):
(WebInspector.DatabaseQueryView.prototype.afterShow):
(WebInspector.DatabaseQueryView.prototype.completions):
(WebInspector.DatabaseQueryView.prototype._selectStart.moveBackIfOutside):
(WebInspector.DatabaseQueryView.prototype._selectStart):
(WebInspector.DatabaseQueryView.prototype._appendViewQueryResult):
(WebInspector.DatabaseQueryView.prototype._appendErrorQueryResult):
(WebInspector.DatabaseQueryView.prototype._appendQueryResult):

  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/Popover.js:

(WebInspector.Popover):
(WebInspector.Popover.prototype._positionElement):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype):
():

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt):
(WebInspector.TextPrompt.prototype.setSuggestForceable):
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype._removeFromElement):
(WebInspector.TextPrompt.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.prototype.acceptAutoComplete):
(WebInspector.TextPrompt.prototype.autoCompleteSoon):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.applySuggestion):
(WebInspector.TextPrompt.prototype.acceptSuggestion):
(WebInspector.TextPrompt.prototype.isSuggestBoxVisible):
(WebInspector.TextPrompt.prototype.moveCaretToEndOfPrompt):
(WebInspector.TextPrompt.prototype.tabKeyPressed):
(WebInspector.TextPrompt.prototype.enterKeyPressed):
(WebInspector.TextPrompt.prototype.upKeyPressed):
(WebInspector.TextPrompt.prototype.downKeyPressed):
(WebInspector.TextPrompt.SuggestBoxConfig):
(WebInspector.TextPromptWithHistory):
(WebInspector.TextPromptWithHistory.prototype.pushHistoryItem):
(WebInspector.TextPromptWithHistory.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.SuggestBox):
(WebInspector.TextPrompt.SuggestBox.prototype.get visible):
(WebInspector.TextPrompt.SuggestBox.prototype.get hasSelection):
(WebInspector.TextPrompt.SuggestBox.prototype._onscrollresize):
(WebInspector.TextPrompt.SuggestBox.prototype._updateBoxPosition):
(WebInspector.TextPrompt.SuggestBox.prototype._onboxmousedown):
(WebInspector.TextPrompt.SuggestBox.prototype.hide):
(WebInspector.TextPrompt.SuggestBox.prototype.removeFromElement):
(WebInspector.TextPrompt.SuggestBox.prototype._applySuggestion):
(WebInspector.TextPrompt.SuggestBox.prototype.acceptSuggestion):
(WebInspector.TextPrompt.SuggestBox.prototype._onNextItem):
(WebInspector.TextPrompt.SuggestBox.prototype._onPreviousItem):
(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestionsSoon):
(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestions):
(WebInspector.TextPrompt.SuggestBox.prototype._onItemMouseDown):
(WebInspector.TextPrompt.SuggestBox.prototype._createItemElement):
(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
(WebInspector.TextPrompt.SuggestBox.prototype._updateSelection):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
(WebInspector.TextPrompt.SuggestBox.prototype.upKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.downKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.tabKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.spaceKeyPressed):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:

(.search-view .search-panel):
(#search-results-pane-file-based .search-match .search-match-content):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar, .custom-popup-vertical-scroll ::-webkit-scrollbar):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-corner, .custom-popup-vertical-scroll ::-webkit-scrollbar-corner):
(.custom-popup-horizontal-scroll ::-webkit-resizer, .custom-popup-vertical-scroll ::-webkit-resizer):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-button, .custom-popup-vertical-scroll ::-webkit-scrollbar-button):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar:horizontal:corner-present):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-thumb:horizontal):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-thumb:horizontal:hover):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-thumb:horizontal:active):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-track-piece:horizontal:start):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-track-piece:horizontal:end):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-track-piece:horizontal:end:corner-present):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-track-piece:horizontal:decrement):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-track-piece:horizontal:increment):
(.custom-popup-vertical-scroll ::-webkit-scrollbar:vertical:corner-present):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-thumb:vertical):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-thumb:vertical:hover):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-thumb:vertical:active):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:start):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:end):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:end:corner-present):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:decrement):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:increment):

  • inspector/front-end/popover.css:

(.popover.right-bottom-arrow .arrow):

  • inspector/front-end/textPrompt.css: Added.

(.suggest-box):
(.suggest-box.visible):
(.suggest-box .container):
(.suggest-box-content-item):
(.suggest-box-content-item .prefix):
(.suggest-box-content-item.selected):
(.suggest-box-content-item:hover:not(.selected)):

  • inspector/front-end/utilities.js:

(setupPrototypeUtilities.Element.prototype.boxInWindow):

3:07 AM Changeset in webkit [99158] by Philippe Normand
  • 3 edits in trunk/Tools

[GTK] [WK2] ttf-liberation fonts moved to a new location (in Debian)
​https://bugs.webkit.org/show_bug.cgi?id=71445

Reviewed by Martin Robinson.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(initializeFonts): set directoriesDescription only when needed.

  • WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:

(WTR::inititializeFontConfigSetting): Add the new font path for Debian fonts and
refactored the font files loading code to avoid copy/pastes, ease
maintenance and future font directories additions.

3:00 AM Changeset in webkit [99157] by commit-queue@webkit.org
  • 4 edits in trunk

Source/WebCore: REGRESSION (r94132): broke fast/loader/location-port.html on GTK
​https://bugs.webkit.org/show_bug.cgi?id=67277

Patch by Devdatta Deshpande <​webkit.devdatta@gmail.com> on 2011-11-03
Reviewed by Adam Barth.

If port is 0, SoupURI does not have an explicitly specified port. Due
to this port value is ignored in SoupURI. Hence, an extra check is
required to restore the port.

Test: LayoutTests/fast/loader/location-port.html

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateFromSoupMessage):

LayoutTests: REGRESSION (r94132): broke fast/loader/location-port.html on GTK
​https://bugs.webkit.org/show_bug.cgi?id=67277

Patch by Devdatta Deshpande <​webkit.devdatta@gmail.com> on 2011-11-03
Reviewed by Adam Barth.

Removed LayoutTests/fast/loader/location-port.html from Skipped tests
for GTK

  • platform/gtk/Skipped:
2:59 AM Changeset in webkit [99156] by Carlos Garcia Campos
  • 3 edits in trunk/Tools

[GTK] Remove GtkLauncher2
​https://bugs.webkit.org/show_bug.cgi?id=71449

Reviewed by Martin Robinson.

GtkLauncher2 is the GtkLauncher code compiled with webkit2. This
made sense when we wanted to implement the exactly same wk1 API
for wk2. Now the code would require an ifdef for most the api, so
it's better to remove GtkLauncher2 and port MiniBrowser to the new
GTK+ API.

  • GNUmakefile.am:
  • GtkLauncher/main.c:

(notifyProgressCb):
(closeWebViewCb):
(createBrowser):
(addWebSettingsGroupToContext):
(main):

2:56 AM Changeset in webkit [99155] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL] Enable the Page Visibility API.
​https://bugs.webkit.org/show_bug.cgi?id=69127

Patch by Dongwoo Im <​dw.im@samsung.com> on 2011-11-03
Reviewed by Adam Barth.

.:

Build system changes to support ENABLE(PAGE_VISIBILITY_API) on EFL port.

  • Source/cmake/OptionsEfl.cmake: Add enabled ENABLE_PAGE_VISIBILITY_API definition.
  • Source/cmakeconfig.h.cmake: ditto.

Source/WebKit/efl:

Implement methods to enable the Page Visibility API on EFL port.
(​http://www.w3.org/TR/page-visibility)

When the visibility status of the page is changed, browser could
inform the status to WebKit using the APIs below.

  • ewk/ewk_view.cpp: Add setter/getter functions to query/set page visibility state.

(ewk_view_visibility_state_set): Sets the page visibility status.
(ewk_view_visibility_state_get): Gets the page visibility status.

  • ewk/ewk_view.h: Add public prototypes.

LayoutTests:

  • platform/efl/Skipped: Unskip all of the test cases of page visibility.
2:27 AM Changeset in webkit [99154] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

Web Inspector [chromium]: fix debug front-end zip generation.
​https://bugs.webkit.org/show_bug.cgi?id=71376

Reviewed by Yury Semikhatsky.

  • WebKit.gyp:
  • scripts/generate_devtools_zip.py:
2:25 AM Changeset in webkit [99153] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Cleaned up obsolete suppressions.

  • platform/chromium/test_expectations.txt:
2:10 AM Changeset in webkit [99152] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r99089.
​http://trac.webkit.org/changeset/99089
​https://bugs.webkit.org/show_bug.cgi?id=71448

@plt postfix for math functions cause crash on Linux 32 (the
symbol is defined but it points to NULL) (Requested by
zherczeg on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-03

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:
  • jit/ThunkGenerators.cpp:
2:07 AM Changeset in webkit [99151] by Simon Hausmann
  • 3 edits in trunk/Source/WebKit2

Unreviewed Qt build fix(es).

  • UIProcess/qt/QtDesktopWebPageProxy.cpp:

(QtDesktopWebPageProxy::handleDragMoveEvent): Adapt to dragSession API change.
(QtDesktopWebPageProxy::handleDropEvent): Ditto.

  • WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:

(WebKit::NetscapePlugin::wantsWindowRelativeNPWindowCoordinates): Implement here
also, for plugin-disabled builds.

2:07 AM Changeset in webkit [99150] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Allow the toolbar background to be transparent on mac platforms when remote
​https://bugs.webkit.org/show_bug.cgi?id=71437

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2011-11-03
Reviewed by Yury Semikhatsky.

  • inspector/front-end/inspector.css:

(body.detached.platform-mac-snowleopard #toolbar):

1:54 AM Changeset in webkit [99149] by Philippe Normand
  • 3 edits in trunk/Source/WebKit2

[GTK] Fix build-break on r99143
​https://bugs.webkit.org/show_bug.cgi?id=71440

Patch by ChangSeok Oh <ChangSeok Oh> on 2011-11-03
Reviewed by Philippe Normand.

dragOperation() should be replaced with dragSession().operation since it was removed.
And didDetectXSSForFrame of WKPageLoaderClient should be relocated.

  • UIProcess/API/gtk/WebKitWebLoaderClient.cpp:

(webkitWebLoaderClientAttachLoaderClientToPage):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseDragDataReceived):
(webkitWebViewBaseDragMotion):

1:06 AM Changeset in webkit [99148] by fpizlo@apple.com
  • 15 edits
    3 adds in trunk

Source/JavaScriptCore: DFG inlining breaks function.arguments[something] if the argument being
retrieved was subjected to DFG's unboxing optimizations
​https://bugs.webkit.org/show_bug.cgi?id=71436

Reviewed by Oliver Hunt.

This makes inlined arguments retrieval use some of the same machinery as
OSR to determine where from, and how, to retrieve a value that the DFG
might have somehow squirreled away while the old JIT would put it in its
obvious location, using an obvious format.

To that end, previously DFG-internal notions such as DataFormat,
VirtualRegister, and ValueRecovery are now in bytecode/ since they are
stored as part of InlineCallFrames.

  • bytecode/CodeOrigin.h:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGNode.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::trueCallerFrame):

  • interpreter/CallFrame.h:

(JSC::ExecState::inlineCallFrame):

  • interpreter/Register.h:

(JSC::Register::asInlineCallFrame):
(JSC::Register::unboxedInt32):
(JSC::Register::unboxedBoolean):
(JSC::Register::unboxedCell):

  • runtime/Arguments.h:

(JSC::Arguments::finishCreationAndCopyRegisters):

LayoutTests: DFG inlining breaks function.arguments[something] if the argument being
retrieved was subjected to DFG's unboxing optimizations
​https://bugs.webkit.org/show_bug.cgi?id=71436

Reviewed by Oliver Hunt.

  • fast/js/dfg-inline-arguments-int32-expected.txt: Added.
  • fast/js/dfg-inline-arguments-int32.html: Added.
  • fast/js/script-tests/dfg-inline-arguments-int32.js: Added.

(foo):
(bar):
(baz):
(argsToStr):

12:37 AM Changeset in webkit [99147] by Philippe Normand
  • 2 edits in trunk/Tools

[GTK] [DRT] ttf-liberation fonts moved to a new location (in Debian)
​https://bugs.webkit.org/show_bug.cgi?id=71359

Reviewed by Martin Robinson.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(initializeFonts): Add the new font path for Debian fonts and
refactored the font files loading code to avoid copy/pastes, ease
maintenance and future font directories additions.

12:36 AM Changeset in webkit [99146] by mahesh.kulkarni@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Flagging usage of X11 headers under PLAT_ARCH(X11)
​https://bugs.webkit.org/show_bug.cgi?id=71409

Reviewed by Simon Hausmann.

Build fix for building qtwebkit with latest qt5 which has removed Qt X11 headers.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
12:34 AM Changeset in webkit [99145] by Philippe Normand
  • 2 edits in trunk/Source/WebKit2

Unreviewed, GTK build fix after r99093...

  • PluginProcess/PluginControllerProxy.h:
Note: See TracTimeline for information about the timeline view.