Timeline
Nov 6, 2011:
- 11:18 PM Changeset in webkit [99397] by
-
- 2 edits in trunk/Source/WebCore
Fix some style issues in ImageBuffer.h
https://bugs.webkit.org/show_bug.cgi?id=71649
Reviewed by Kent Tamura.
No new tests. Style change only.
- platform/graphics/ImageBuffer.h:
- 10:48 PM Changeset in webkit [99396] by
-
- 2 edits in trunk/LayoutTests
[GTK] Skip new failing test.
https://bugs.webkit.org/show_bug.cgi?id=71022
Patch by Ben Wells <benwells@chromium.org> on 2011-11-06
Reviewed by Martin Robinson.
- platform/gtk/Skipped:
- 10:27 PM Changeset in webkit [99395] by
-
- 13 edits in trunk/Source/WebCore
InputType::fallbackValue and defaultValue should be const
https://bugs.webkit.org/show_bug.cgi?id=71641
Reviewed by Kent Tamura.
Changing InputType::fallbackValue and defaultValue to const. Also adding OVERRIDE.
- html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::fallbackValue):
- html/BaseCheckableInputType.h:
- html/ColorInputType.cpp:
(WebCore::ColorInputType::fallbackValue):
- html/ColorInputType.h:
- html/InputType.cpp:
(WebCore::InputType::fallbackValue):
(WebCore::InputType::defaultValue):
- html/InputType.h:
- html/RangeInputType.cpp:
(WebCore::RangeInputType::fallbackValue):
- html/RangeInputType.h:
- html/ResetInputType.cpp:
(WebCore::ResetInputType::defaultValue):
- html/ResetInputType.h:
- html/SubmitInputType.cpp:
(WebCore::SubmitInputType::defaultValue):
- html/SubmitInputType.h:
- 7:17 PM Changeset in webkit [99394] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
- platform/chromium/test_expectations.txt:
fast/events/platform-wheelevent-paging-{x,y,xy}-in-scrolling-page.html fails on chromium-cg-mac.
- 7:13 PM Changeset in webkit [99393] by
-
- 3 edits4 copies in branches/chromium/912
Merge 99067 - REGRESSION(r96870): WebKit generates background: transparent on blogger.com
https://bugs.webkit.org/show_bug.cgi?id=71203
Reviewed by Ojan Vafai.
Source/WebCore:
Remove the transparent background color from inline style declarations in the pasted content.
Also fixed a bug in removeStyleFromRulesAndContext that it removes properties in inline style
declarations even if those properties were overridden.
Tests: editing/deleting/merge-paragraphs-with-transparent-background.html
editing/deleting/paste-with-transparent-background-color.html
- editing/EditingStyle.cpp:
(WebCore::removePropertiesInStyle):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
(WebCore::EditingStyle::removePropertiesInElementDefaultStyle):
LayoutTests:
Added a test to merge paragraphs inside a document with background: transparent, and a test to
cut and paste contents with background: transparent, which is overriding a style rule background: blue.
WebKit should preserve the appearance of the pasted content but should not add a redundant
background: transparent.
- editing/deleting/merge-paragraphs-with-transparent-background-expected.txt: Added.
- editing/deleting/merge-paragraphs-with-transparent-background.html: Added.
- editing/deleting/paste-with-transparent-background-color-expected.txt: Added.
- editing/deleting/paste-with-transparent-background-color.html: Added.
TBR=rniwa@webkit.org
Review URL: http://codereview.chromium.org/8493001
- 6:51 PM Changeset in webkit [99392] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r99374): GTK+ build of the jsc binary doesn't like the call
to initializeMainThread, and crashes
https://bugs.webkit.org/show_bug.cgi?id=71643
Reviewed by Sam Weinig.
- jsc.cpp:
(main):
- 6:34 PM Changeset in webkit [99391] by
-
- 3 edits in trunk/Source/WebCore
Remove ColorInputType::handleClickEvent
https://bugs.webkit.org/show_bug.cgi?id=71640
Reviewed by Kent Tamura.
When you click the input color element, both ColorInputType::handleClickEvent and
ColorInputType::handleDOMActivateEvent are called, causing Chrome::openColorChooser
to be called too many times.
- html/ColorInputType.cpp: Removed ColorInputType::handleClickEvent
- html/ColorInputType.h: Removed ColorInputType::handleClickEvent
- 6:25 PM Changeset in webkit [99390] by
-
- 2 edits in trunk/Source/WebCore
Remove extra semicolon in ColorInputType
https://bugs.webkit.org/show_bug.cgi?id=71639
Reviewed by Kent Tamura.
- html/ColorInputType.cpp:
(WebCore::ColorInputType::setValue):
- 6:07 PM Changeset in webkit [99389] by
-
- 10 edits in trunk
Remove initBeforeLoadEvent method
https://bugs.webkit.org/show_bug.cgi?id=71636
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/dom/Window/window-properties.html
- dom/BeforeLoadEvent.h:
- dom/BeforeLoadEvent.idl:
LayoutTests:
- fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/mac/fast/dom/Window/window-properties-expected.txt:
- platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/win/fast/dom/Window/window-properties-expected.txt:
- 4:42 PM Changeset in webkit [99388] by
-
- 2 edits in trunk/LayoutTests
Skip tests for autocorrection panel on Chromium port since
Chromium Mac port doesn't support autocorrection panel.
The failure was tracked by the Chromium issue 58254 (http://crbug.com/58254).
- platform/chromium/test_expectations.txt:
- 4:34 PM Changeset in webkit [99387] by
-
- 2 edits in trunk/LayoutTests
editing/input/scroll-viewport-page-up-down.html is very flaky on chromium win release
https://bugs.webkit.org/show_bug.cgi?id=59642
Unreviewed; remove the failing test expectation since we can no longer observe the said failure.
- platform/chromium/test_expectations.txt:
- 2:52 PM Changeset in webkit [99386] by
-
- 2 edits in trunk/Source/WebCore
Don't crash when a context hasn't been created. This fixed a
testing-only crash on the bots in the Chromium port.
- testing/v8/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject):
- 2:45 PM Changeset in webkit [99385] by
-
- 2 edits in trunk/Tools
[Qt] Unreviewed trivial fix after build system refactoring.
- Scripts/run-qtwebkit-tests: Fix qml_import_path.
- 2:27 PM Changeset in webkit [99384] by
-
- 2 edits in trunk/Source/WebCore
Leaks seen in RenderFlowThread::setRegionRangeForBox on Leaks bot
https://bugs.webkit.org/show_bug.cgi?id=71260
Reviewed by Mark Rowe.
Memory leak fix covered by existing tests.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
Instead of calling remove, call take and then delete, since the
values of the map are owned and need to be deleted when removed.
- 1:31 PM Changeset in webkit [99383] by
-
- 4 edits8 adds in trunk
Implement the sandbox directive for CSP
https://bugs.webkit.org/show_bug.cgi?id=71604
Reviewed by Sam Weinig.
Source/WebCore:
At TPAC, Microsoft was pushing pretty hard to add the sandbox directive
to CSP. There's a question about whether it's going to be in CSP 1.0
or CSP 1.1, but it seems to be clearly headed into the spec.
This patch implements the sandbox directive for CSP. It's built on the
same machinery we use for the sandbox attribute for iframe. Now that
I've done the implementation, I'm going to write up some concrete text
for the spec.
Tests: http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-subframe.html
http/tests/security/contentSecurityPolicy/sandbox-allow-scripts.html
http/tests/security/contentSecurityPolicy/sandbox-empty-subframe.html
http/tests/security/contentSecurityPolicy/sandbox-empty.html
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::applySandboxPolicy):
(WebCore::ContentSecurityPolicy::addDirective):
- page/ContentSecurityPolicy.h:
LayoutTests:
Test that the sandbox directive correctly wires up to the sandbox
flags. Also, test that the policy inherits into subframes. These are
essentially integration tests between the CSP and sandbox subsystems,
which is why they don't cover all the permutations of the sandbox
flags. Those are covered in more detail via tests of the sandbox
attribute.
- http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-subframe-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-subframe.html: Added.
- http/tests/security/contentSecurityPolicy/sandbox-allow-scripts.html: Added.
- http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/sandbox-empty-subframe.html: Added.
- http/tests/security/contentSecurityPolicy/sandbox-empty.html: Added.
- 1:29 PM Changeset in webkit [99382] by
-
- 9 edits in trunk/Source/JavaScriptCore
Add space missing from some class declarations
https://bugs.webkit.org/show_bug.cgi?id=71632
Reviewed by Anders Carlsson.
- assembler/AssemblerBufferWithConstantPool.h:
- bytecode/CodeBlock.h:
- dfg/DFGVariableAccessData.h:
- heap/VTableSpectrum.h:
- jit/ExecutableAllocator.cpp:
- jit/ExecutableAllocatorFixedVMPool.cpp:
- wtf/MetaAllocatorHandle.h:
- wtf/UnionFind.h:
- 1:01 PM Changeset in webkit [99381] by
-
- 3 edits in trunk/Tools
Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
https://bugs.webkit.org/show_bug.cgi?id=66078
Unreviewed. Add an assert about the type of "args"
to our Executive Mocks and fix a piece of code
from this patch which was hitting that assert
when executing for real.
- Scripts/webkitpy/common/system/executive_mock.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- 1:00 PM Changeset in webkit [99380] by
-
- 2 edits in trunk/LayoutTests
Add a crash expectation for platform/mac/accessibility/select-element-selection-with-optgroups.html on Mac.
The failure is tracked by the bug 71421.
- platform/mac/test_expectations.txt:
- 12:49 PM Changeset in webkit [99379] by
-
- 2 edits in trunk/Tools
Split chunk handling out of prepare_lists_and_print_output to make it more readable
https://bugs.webkit.org/show_bug.cgi?id=71629
Reviewed by Adam Barth.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
- 12:38 PM Changeset in webkit [99378] by
-
- 2 edits in trunk/Source/JavaScriptCore
Allow use of FINAL in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=71630
Reviewed by Anders Carlsson.
- Configurations/Base.xcconfig:
Don't warn about C++11 extensions used in C++98 mode.
- 11:48 AM Changeset in webkit [99377] by
-
- 6 edits in trunk/Tools
Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
https://bugs.webkit.org/show_bug.cgi?id=66078
Reviewed by Adam Barth.
The runtime feature detection was fixed to work in bug 64472.
In this bug I moved the symbol-based feature detection from
popen() to Executive.run_command and cleaned up the callers
and unittests to make sure that we're correctly parsing the
nm output correctly. The old code happened to work even though
the runtime-features path was using "str in list" and the
symbol features path was using "str in str" and it just happened
to do what we wanted to. Now runtime features and symbol feature
blacklists are computed separately (and with better documentation).
This system remains confusing, partially because these are black-lists
which are amended to whatever static blacklist may exist for the
port as part of a Skipped list file.
For example, notice how the runtime feature list only has directory
blacklists for a couple features. If all features are off,
how do we skip enough tests with only 2 entries in the blacklist map?
The answer is that Windows is the only port to use runtime feature
detection, and the win/Skipped file turns off all the other features
statically (like mathml, mhtml, wss, etc.) where as some other ports (like AppleMac)
which use symbol-based feature detection turn of mathml, wcss, etc
using the blacklists found in _missing_symbol_to_skipped_tests.
I also noticed a couple places where we still referenced xhtmlmp
even though support for such has been removed from WebKit. Removed those.
This should result in no functional change.
- Scripts/webkitpy/layout_tests/port/gtk.py:
- Use self._filesystem instead of os.path
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
- 9:22 AM Changeset in webkit [99376] by
-
- 2 edits in trunk/Tools
Made show-pretty-diff work when the input path contains spaces.
Reviewed by Anders Carlsson.
- Scripts/show-pretty-diff:
- 3:54 AM Changeset in webkit [99375] by
-
- 7 edits in trunk/Source/JavaScriptCore
Value profiling should just use two buckets
https://bugs.webkit.org/show_bug.cgi?id=71619
Reviewed by Gavin Barraclough.
Added one more configuration options (like Heuristics::minimumOptimizationDelay),
improved debugging in JIT optimization support, changed the number of buckets
in the value profile from 9 to 2, and wrote a more optimal value profiling path
in the old JIT to take advantage of this. It's still possible to play around with
larger numbers of buckets, and we should probably keep this for a little while
until we convince ourselves that using just two buckets is the right call.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shouldOptimizeNow):
- bytecode/ValueProfile.h:
- jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
- runtime/Heuristics.h:
- 3:39 AM Changeset in webkit [99374] by
-
- 18 edits3 adds in trunk/Source
JSC should be able to sample itself in a more flexible way than just sampling flags
https://bugs.webkit.org/show_bug.cgi?id=71522
Source/JavaScriptCore:
Reviewed by Gavin Barraclough.
Added a construct that looks like SamplingRegion samplingRegion("name").
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/SamplingTool.cpp:
(JSC::SamplingRegion::Locker::Locker):
(JSC::SamplingRegion::Locker::~Locker):
(JSC::SamplingRegion::sample):
(JSC::SamplingRegion::dump):
(JSC::SamplingRegion::dumpInternal):
(JSC::SamplingThread::threadStartFunc):
- bytecode/SamplingTool.h:
(JSC::SamplingRegion::SamplingRegion):
(JSC::SamplingRegion::~SamplingRegion):
(JSC::SamplingRegion::exchangeCurrent):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- heap/Heap.cpp:
(JSC::Heap::markRoots):
(JSC::Heap::collect):
- heap/VTableSpectrum.cpp:
(JSC::VTableSpectrum::countVPtr):
(JSC::VTableSpectrum::dump):
- heap/VTableSpectrum.h:
- jsc.cpp:
(main):
(runWithScripts):
- parser/Parser.h:
(JSC::parse):
- runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
- wtf/Atomics.h:
(WTF::weakCompareAndSwap):
- wtf/Platform.h:
- wtf/Spectrum.h: Added.
(WTF::Spectrum::Spectrum):
(WTF::Spectrum::add):
(WTF::Spectrum::get):
(WTF::Spectrum::begin):
(WTF::Spectrum::end):
(WTF::Spectrum::KeyAndCount::KeyAndCount):
(WTF::Spectrum::KeyAndCount::operator<):
(WTF::Spectrum::buildList):
- wtf/wtf.pri:
Source/JavaScriptGlue:
Reviewed by Gavin Barraclough.
- ForwardingHeaders/wtf/Spectrum.h: Added.
Source/WebCore:
Reviewed by Gavin Barraclough.
No new tests, since no functionality changed.
- ForwardingHeaders/wtf/Spectrum.h: Added.
- 3:04 AM Changeset in webkit [99373] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
Skip paged wheel events for Qt, as we don't support them yet.
- platform/qt/Skipped:
Nov 6, 2011:
- 12:23 AM Changeset in webkit [99372] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Unindent edited text by pressing Shift + Tab
https://bugs.webkit.org/show_bug.cgi?id=70181
Indent and unindent text in all selected lines.
Patch by Nikita Vasilyev <me@elv1s.ru> on 2011-11-06
Reviewed by Pavel Feldman.
- inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel.prototype.unindentLines.get var):
(WebInspector.TextEditorMainPanel.prototype.unindentLines):
Nov 5, 2011:
- 11:10 PM Changeset in webkit [99371] by
-
- 2 edits in trunk/LayoutTests
Skip a newly failing test and reclassify some missing DRT features.
- platform/gtk/Skipped: Update skipped list.
- 10:33 PM Changeset in webkit [99370] by
-
- 4 edits2 deletes in trunk/Source/WebCore
Remove ContextShadow
https://bugs.webkit.org/show_bug.cgi?id=71617
Reviewed by Ariya Hidayat.
No new tests. This patch does not change behavior.
Completely remove ContextShadow. It's unused, unmaintained, and
replaced by ShadowBlur.
- WebCore.gypi: Remove references to deleted files.
- WebCore.vcproj/WebCore.vcproj: Remove references to deleted files.
- platform/graphics/ContextShadow.cpp: Removed.
- platform/graphics/ContextShadow.h: Removed.
- platform/gtk/WidgetRenderingContext.cpp: Remove now-inaccurate TODO.
- 9:27 PM Changeset in webkit [99369] by
-
- 6 edits in trunk/Source/WebCore
Dragging a file onto <input type="file"> should give distinct visual feedback
https://bugs.webkit.org/show_bug.cgi?id=13897
<rdar://problem/5232483>
Reviewed by Dan Bernstein.
When hovering over a file input element, we set the button's state to active
to differentiate dragging one file over the input element (which populates that
element) versus over the document (which would load the file into the view).
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::canReceiveDroppedFiles):
(WebCore::HTMLInputElement::setCanReceiveDroppedFiles): If set, the element
is updated, which sets the active state on the button control.
- html/HTMLInputElement.h: Add a boolean member representing whether the file
input can receive dropped files.
- page/DragController.cpp:
(WebCore::DragController::DragController): Update/set the file input that
can receive dropped files.
(WebCore::DragController::dragExited):
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):
- page/DragController.h:
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::updateFromElement): Sets the button active
state if the input can receive dropped files.
- 9:14 PM Changeset in webkit [99368] by
-
- 6 edits in trunk
[chromium] Use the security origin instead of the URL when checking notification permissions
https://bugs.webkit.org/show_bug.cgi?id=71590
Reviewed by Adam Barth.
Source/WebKit/chromium:
- public/WebNotificationPresenter.h:
- src/NotificationPresenterImpl.cpp:
(WebKit::NotificationPresenterImpl::checkPermission):
Tools:
- DumpRenderTree/chromium/NotificationPresenter.cpp:
(NotificationPresenter::checkPermission):
- DumpRenderTree/chromium/NotificationPresenter.h:
- 7:26 PM Changeset in webkit [99367] by
-
- 2 edits in trunk/Source/WebCore
Improve pending resource hash table code, including fixing a memory leak
https://bugs.webkit.org/show_bug.cgi?id=71616
Reviewed by Adam Roben.
Memory leak fix and refactoring covered by existing tests.
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::addPendingResource): Replace the combination
of contains, get, and add with just add, removing an extra unneeded hash table
lookup each time this function is called.
(WebCore::SVGDocumentExtensions::isElementInPendingResources): Added a comment
about the performance of this function. Removed unnecessary check for an empty
map; the code already efficiently exits doing nothing without the check.
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources): Removed
unnecessary check for an empty map; the code already efficiently does nothing
without the check. Use removePendingResource rather than calling remove to
avoid leaking the SVGPendingElements set.
(WebCore::SVGDocumentExtensions::removePendingResource): Replace the
combination of get and remove with a call to take, removing an extra
unneeded hash table lookup each time this function is called
- 6:07 PM Changeset in webkit [99366] by
-
- 2 edits in trunk/Tools
Fix a small leak in Mac version of LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=71615
Reviewed by Mark Rowe.
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::applicationCacheDiskUsageForOrigin): Release the origin.
(LayoutTestController::localStorageDiskUsageForOrigin): Ditto.
- 5:56 PM Changeset in webkit [99365] by
-
- 2 edits in trunk/LayoutTests
Unskip some tests on GTK+ that seem to be passing.
- platform/gtk/Skipped: Unskip tests.
- 5:50 PM Changeset in webkit [99364] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Actually use the user_data arguments to gio async functions
instead of using g_object_set_data() to basically reinvent them.
https://bugs.webkit.org/show_bug.cgi?id=71614
Patch by Dan Winship <danw@gnome.org> on 2011-11-05
Reviewed by Martin Robinson.
No new tests; behavior is unchanged
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::cleanupSoupRequestOperation):
(WebCore::sendRequestCallback):
(WebCore::startHTTPRequest):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::closeCallback):
(WebCore::readCallback):
(WebCore::startNonHTTPRequest):
- 5:39 PM Changeset in webkit [99363] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Don't unnecessarily 0-initialize read buffers.
https://bugs.webkit.org/show_bug.cgi?id=71612
Patch by Dan Winship <danw@gnome.org> on 2011-11-05
Reviewed by Martin Robinson.
No new tests; behavior is unchanged
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sendRequestCallback):
- 5:37 PM Changeset in webkit [99362] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Remove a bit of dead code
https://bugs.webkit.org/show_bug.cgi?id=71613
Patch by Dan Winship <danw@gnome.org> on 2011-11-05
Reviewed by Martin Robinson.
No new tests; behavior is unchanged
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::readCallback): the caller that needed the convertToUTF16
code was removed in r77408, but the code was accidentally left
behind.
- 5:34 PM Changeset in webkit [99361] by
-
- 20 edits in trunk/LayoutTests
[GTK] Frame flattening tests are super-flaky after switching to backing store-based painting
https://bugs.webkit.org/show_bug.cgi?id=71576
Reviewed by Antonio Gomes.
Instead of waiting until <body onload> to toggle the frame flattening
setting. Toggle is as soon as possible. This fixes an issue where
layouts that happen before the onload event lead to flaky results.
- fast/frames/flattening/frameset-flattening-advanced.html:
- fast/frames/flattening/frameset-flattening-grid.html:
- fast/frames/flattening/frameset-flattening-simple.html:
- fast/frames/flattening/frameset-flattening-subframe-resize.html:
- fast/frames/flattening/frameset-flattening-subframesets.html:
- fast/frames/flattening/iframe-flattening-crash.html:
- fast/frames/flattening/iframe-flattening-fixed-height.html:
- fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:
- fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html:
- fast/frames/flattening/iframe-flattening-fixed-width-and-height.html:
- fast/frames/flattening/iframe-flattening-fixed-width.html:
- fast/frames/flattening/iframe-flattening-nested.html:
- fast/frames/flattening/iframe-flattening-offscreen.html:
- fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html:
- fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html:
- fast/frames/flattening/iframe-flattening-out-of-view.html:
- fast/frames/flattening/iframe-flattening-selection-crash.html:
- fast/frames/flattening/iframe-flattening-simple.html:
- platform/gtk/Skipped: Unskip tests which are no longer flaky.
- 4:45 PM Changeset in webkit [99360] by
-
- 2 edits in trunk/LayoutTests
[GTK] Frame flattening tests are super-flaky after switching to backing store-based painting
https://bugs.webkit.org/show_bug.cgi?id=71576
Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-11-05
Reviewed by Martin Robinson.
Skip frame flattening tests. These became flaky after backing store for
painting was introduced for the GTK port in r98827.
- platform/gtk/Skipped:
- 2:55 PM Changeset in webkit [99359] by
-
- 5 edits in trunk/Source/WebCore
Refactor sandbox flag calculation to make implementing CSP sandbox directive easier
https://bugs.webkit.org/show_bug.cgi?id=71603
Reviewed by Sam Weinig.
This patch changes the way we compute sandbox bits. Instead of caching
the result on Frame, we always compute the sandbox bits for a new
document fresh from the inputs to the process (the sandbox attribute
and the forced sandbox flags).
This patch is just refactoring. It shouldn't have an observable
effects. This patch makes it easier to implement CSP's sandbox
directive in a subsequent patch.
- dom/Document.cpp:
(WebCore::Document::initSecurityContext):
- html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::setSandboxFlags):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::init):
(WebCore::FrameLoader::effectiveSandboxFlags):
(WebCore::createWindow):
- loader/FrameLoader.h:
(WebCore::FrameLoader::forceSandboxFlags):
- 1:37 PM Changeset in webkit [99358] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 1:29 PM Changeset in webkit [99357] by
-
- 6 edits in trunk/Source/JavaScriptCore
Reduce the number of putWithAttributes
https://bugs.webkit.org/show_bug.cgi?id=71597
Reviewed by Adam Roben.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Remove exports of removed functions.
- runtime/JSActivation.cpp:
(JSC::JSActivation::putWithAttributes):
Calling the overload without the extra parameters does the same thing.
- runtime/JSObject.cpp:
(JSC::JSObject::putWithAttributes):
- runtime/JSObject.h:
Remove four unused JSObject::putWithAttributes overloads and make one of the remaining
two overloads not virtual, since no one overrides it.
- 11:16 AM Changeset in webkit [99356] by
-
- 2 edits in trunk/LayoutTests
Unskip a test on GTK+ that doesn't seem to be failing on the bots
or locally.
- platform/gtk/Skipped: Unskip a test.
- 9:28 AM Changeset in webkit [99355] by
-
- 5 edits in trunk/Source/WebCore
CSSStyleDeclaration: Devirtualize isMutableStyleDeclaration().
https://bugs.webkit.org/show_bug.cgi?id=71609
Reviewed by Anders Carlsson.
Add a bool member to CSSStyleDeclaration that determines whether
it's a CSSMutableDeclaration.
- css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
- css/CSSMutableStyleDeclaration.h:
- css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
- css/CSSStyleDeclaration.h:
(WebCore::CSSStyleDeclaration::isMutableStyleDeclaration):
- 9:25 AM Changeset in webkit [99354] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Simplify InspectorCSSAgent::inlineStyleElement().
https://bugs.webkit.org/show_bug.cgi?id=71608
Reviewed by Pavel Feldman.
Use CSSMutableStyleDeclaration::isInlineStyleDeclaration() instead
of doing the same checks manually.
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::inlineStyleElement):
- 7:50 AM Changeset in webkit [99353] by
-
- 2 edits1 delete in trunk/Source/WebCore
Reviewed by Andreas Kling.
Removed duplicated npruntime_internal.h from bindings/v8
in favour of the one from bridge/, which has a few more
https://bugs.webkit.org/show_bug.cgi?id=45617
- bindings/v8/npruntime_internal.h: Removed.
- Target.pri: Removed strange occurence here.
- 5:15 AM Changeset in webkit [99352] by
-
- 2 edits1 delete in trunk/Source/WebCore
Remove empty and unused dom/PositionCreationFunctions.h header file
https://bugs.webkit.org/show_bug.cgi?id=71552
Reviewed by Kenneth Rohde Christiansen.
The file is empty (0 bytes) and not used anywhere. It was added in
2009 in r48234 but hasn't been touched since then.
- WebCore.gypi:
- dom/PositionCreationFunctions.h: Removed.
- 12:00 AM Changeset in webkit [99351] by
-
- 2 edits in trunk/Source/WebCore
Fix assert after running tests in dumpAsText folders. See
https://bugs.webkit.org/show_bug.cgi?id=71599 for discussion. This
patch reverts part of a slightly over-agressive refactoring in
http://trac.webkit.org/changeset/99347.
- dom/Document.cpp:
(WebCore::Document::setIsViewSource):
