⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 7, 2011:

11:49 PM Changeset in webkit [99527] by Simon Hausmann
  • 5 edits in trunk/Tools

[Qt][WK2] MiniBrowser should use urlFromUserInput()
​https://bugs.webkit.org/show_bug.cgi?id=71680

Use urlFromUserInput() / QUrl::fromUserInput() to automatically
complete urls in MiniBrowser.

Patch by Zeno Albisser <​zeno.albisser@nokia.com> on 2011-11-07
Reviewed by Tor Arne Vestbø.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::load):

  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • MiniBrowser/qt/utils.cpp:

(Utils::urlFromUserInput):

  • MiniBrowser/qt/utils.h:

(Utils::Utils):

11:32 PM Changeset in webkit [99526] by yuqiang.xian@intel.com
  • 2 edits in trunk/Tools

Added myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
10:51 PM Changeset in webkit [99525] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix gcc 4.4 compilation warnings in DFG 32_64
​https://bugs.webkit.org/show_bug.cgi?id=71762

Reviewed by Filip Pizlo.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::registersMatched):

10:49 PM Changeset in webkit [99524] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test platform/chromium-cg-mac/editing/input/ime-candidate-window-position.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=71653

Reviewed by Kent Tamura.

  • platform/chromium-cg-mac/editing/input/ime-candidate-window-position.html: Calls doTest() after iframe is loaded.
10:40 PM Changeset in webkit [99523] by dbates@webkit.org
  • 4 edits
    1 add in trunk/Source/WebCore

Add CredentialStorage.cpp to WebCore/CMakeLists.txt
​https://bugs.webkit.org/show_bug.cgi?id=71748

Reviewed by Martin Robinson.

Adds CredentialStorage.cpp to WebCore/CMakeLists.txt since its provides a
base implementation of this feature.

Also adds a stub implementation of CredentialStorage to the WinCE port.

  • CMakeLists.txt: Added source file CredentialStorage.cpp.
  • CMakeListsEfl.txt: Added source file CredentialStorageCurl.cpp when building with the Curl networking backend.
  • CMakeListsWinCE.txt: Added source file CredentialStorageWin.cpp.
  • platform/network/win/CredentialStorageWin.cpp: Added.

(WebCore::Credential::getFromPersistentStorage): Stub implementation.

10:27 PM Changeset in webkit [99522] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardening, skip a failing new test: svg/custom/getBBox-path.svg.
​https://bugs.webkit.org/show_bug.cgi?id=71766

  • platform/qt/Skipped:
10:12 PM Changeset in webkit [99521] by ravi.kasibhatla@motorola.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Adding myself to the committer script.

10:03 PM Changeset in webkit [99520] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed webkitpy test fix after r99512.

  • Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:

Xianzhu Wang is now a committer, so we can't nominate him as a committer anymore.

9:48 PM Changeset in webkit [99519] by fpizlo@apple.com
  • 6 edits
    3 adds in trunk/Source/JavaScriptCore

DFG code base should allow for classes not related to DFG::JITCompiler
to use DFG idioms
​https://bugs.webkit.org/show_bug.cgi?id=71746

Reviewed by Gavin Barraclough.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGAssemblyHelpers.cpp: Added.

(JSC::DFG::AssemblyHelpers::decodedCodeMapFor):
(JSC::DFG::AssemblyHelpers::emitCount):
(JSC::DFG::AssemblyHelpers::setSamplingFlag):
(JSC::DFG::AssemblyHelpers::clearSamplingFlag):
(JSC::DFG::AssemblyHelpers::jitAssertIsInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSNumber):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSDouble):
(JSC::DFG::AssemblyHelpers::jitAssertIsCell):

  • dfg/DFGAssemblyHelpers.h: Added.
  • dfg/DFGJITCompiler.cpp:
  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::graph):

  • dfg/DFGJITCompiler32_64.cpp:
  • dfg/DFGOSRExit.h: Added.

(JSC::DFG::SpeculationRecovery::SpeculationRecovery):
(JSC::DFG::SpeculationRecovery::type):
(JSC::DFG::SpeculationRecovery::dest):
(JSC::DFG::SpeculationRecovery::src):
(JSC::DFG::OSRExit::numberOfRecoveries):
(JSC::DFG::OSRExit::valueRecovery):
(JSC::DFG::OSRExit::isArgument):
(JSC::DFG::OSRExit::isVariable):
(JSC::DFG::OSRExit::argumentForIndex):
(JSC::DFG::OSRExit::variableForIndex):
(JSC::DFG::OSRExit::operandForArgument):
(JSC::DFG::OSRExit::operandForIndex):

  • dfg/DFGSpeculativeJIT.h:
8:44 PM Changeset in webkit [99518] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source/WebKit/efl

[EFL] Need to replace api's object parameter with proper name.
​https://bugs.webkit.org/show_bug.cgi?id=71553

Fix wrong parameter names in tiled backing store functions and ewk_view_xxx files.

Reviewed by Filip Pizlo.

  • ewk/ewk_tiled_backing_store.cpp:
  • ewk/ewk_view_single.cpp:
  • ewk/ewk_view_tiled.cpp:
8:31 PM Changeset in webkit [99517] by commit-queue@webkit.org
  • 10 edits
    1 add in trunk/LayoutTests

Add layout test for locale-based font selection
​https://bugs.webkit.org/show_bug.cgi?id=67019

This test relies on overridePreference("WebKit*FontMap"...) which is
implemented only on Chromium DumpRenderTree so far.

Patch by Matt Falkenhagen <​falken@chromium.org> on 2011-11-07
Reviewed by Kent Tamura.

  • fast/text/international/locale-sensitive-fonts.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped: Added skip for non-Chromium ports.
  • platform/gtk-wk2/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
7:02 PM Changeset in webkit [99516] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Switch back to 1+1 value profiling buckets, since it didn't help on arewefastyet,
but it appears to help on other benchmarks.

Rubber stamped by Oliver Hunt.

  • bytecode/ValueProfile.h:
6:41 PM Changeset in webkit [99515] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove [CustomGetter] IDL for window.Image of V8
​https://bugs.webkit.org/show_bug.cgi?id=71739

Reviewed by Adam Barth.

Currently, window.Image uses a custom getter to get the template
of 'HTMLImageElementConstructor'. However, this getter does not need to
be custom and can use a default getter
'DOMWindowInternal::DOMWindowConstructorGetter'.

Tests: fast/js/custom-constructors.html

fast/dom/image-object.html
fast/dom/gc-image-element.html
fast/dom/Window/custom-constructors.html

  • bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter.
  • page/DOMWindow.idl: Removed [CustomGetter] IDL from window.Image of V8. Renamed 'HTMLImageElementConstructor' to 'HTMLImageElementConstructorConstructor' in order to make window.Image use the template of (not 'HTMLImageElement' but) 'HTMLImageElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from the IDL type.
6:25 PM Changeset in webkit [99514] by Chris Fleizach
  • 4 edits in trunk

REGRESSION(r99025-r99037): platform/mac/accessibility/select-element-selection-with-optgroups.html is asserting
​https://bugs.webkit.org/show_bug.cgi?id=71421

Reviewed by Ryosuke Niwa.

Source/WebCore:

Remove an assert that was added by r99035. It was added based on a comment in the code, but not tested.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::selectOption):

LayoutTests:

Re-enable test after removing an erroneous assert.

  • platform/mac/test_expectations.txt:
6:25 PM Changeset in webkit [99513] by ariya@webkit.org
  • 6 edits in trunk

"use strict" can not contain escape sequences or line continuation
​https://bugs.webkit.org/show_bug.cgi?id=71532

Reviewed by Darin Adler.

Source/JavaScriptCore:

Store the actual literal length (before the escapes and line
continuation are encoded) while parsing the directive and use it
for the directive comparison.

  • parser/Parser.cpp:

(JSC::Parser::parseSourceElements):
(JSC::Parser::parseStatement):

  • parser/Parser.h:

LayoutTests:

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:

(testLineContinuation): Added.
(testEscapeSequence): Added.

6:14 PM Changeset in webkit [99512] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

Add myself as a committer.

6:11 PM Changeset in webkit [99511] by eae@chromium.org
  • 22 edits in trunk/Source

Revert platform and scrolling to ints
​https://bugs.webkit.org/show_bug.cgi?id=71585

Reviewed by Eric Seidel.

Replace all uses of LayoutUnit and related types with ints in platform
and scrolling code.

Source/WebCore:

No new tests.

  • page/FrameView.cpp:
  • page/FrameView.h:
  • platform/PopupMenuClient.h:
  • platform/ScrollAnimatorNone.cpp:
  • platform/ScrollAnimatorNone.h:
  • platform/ScrollView.cpp:
  • platform/ScrollView.h:
  • platform/ScrollableArea.h:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp:
  • rendering/RenderListBox.h:
  • rendering/RenderMenuList.cpp:
  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/RenderTextControlSingleLine.h:

Source/WebKit/chromium:

  • tests/ScrollAnimatorNoneTest.cpp:

(MockScrollableArea::visibleHeight):
(MockScrollableArea::visibleWidth):

Source/WebKit2:

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::invalidateScrollbarRect):
(WebKit::BuiltInPDFView::visibleHeight):
(WebKit::BuiltInPDFView::visibleWidth):

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:
6:08 PM Changeset in webkit [99510] by haraken@chromium.org
  • 9 edits in trunk

Fixed wrong test results of fast/js/custom-constructors.html
​https://bugs.webkit.org/show_bug.cgi?id=71669

Reviewed by Darin Adler.

According to the HTMLOptionElement spec
(​http://dev.w3.org/html5/spec/the-button-element.html#the-option-element),
'text', 'label' and 'value' have neither [TreatUndefinedAs=EmptyString]
nor [TreatNullAs=EmptyString]. Thus, an undefined value should be
converted to a string "undefined" and a null value should be
converted to a string "null", following the step 3 of the IDL
conversion spec (​http://dev.w3.org/2006/webapi/WebIDL/#es-DOMString).

Source/WebCore:

  • bindings/js/JSOptionConstructor.cpp:

(WebCore::constructHTMLOptionElement): Removed isUndefined() check from 'text' and 'value' since the spec does not have [TreatUndefinedAs=EmptyString].

  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:

(WebCore::v8HTMLOptionElementConstructorCallback): Ditto.

  • html/HTMLOptionElement.idl: Removed [ConvertNullToNullString] from 'text', 'label' and 'value' since the spec does not have [TreatNullAs=EmptyString].

LayoutTests:

  • fast/dom/element-attribute-js-null-expected.txt: Fixed the test result.
  • fast/dom/element-attribute-js-null.html: Ditto.
  • fast/js/custom-constructors-expected.txt: Ditto.
  • fast/js/script-tests/custom-constructors.js: Ditto.
5:40 PM WebKit Team edited by yuqiang.xian@intel.com
add me to the committer list (diff)
5:37 PM Changeset in webkit [99509] by abarth@webkit.org
  • 17 edits in trunk/Source

Move DomainRelaxationForbidden scheme registry to SchemeRegistry
​https://bugs.webkit.org/show_bug.cgi?id=71750

Reviewed by Eric Seidel.

Source/WebCore:

As stated in the FIXME, scheme registries belong in SchemeRegistry, not
in SecurityOrigin.

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::setDomain):

  • page/SecurityOrigin.cpp:
  • page/SecurityOrigin.h:
  • platform/SchemeRegistry.cpp:

(WebCore::schemesForbiddenFromDomainRelaxation):
(WebCore::SchemeRegistry::setDomainRelaxationForbiddenForURLScheme):
(WebCore::SchemeRegistry::isDomainRelaxationForbiddenForURLScheme):

  • platform/SchemeRegistry.h:

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setDomainRelaxationForbidden):

Source/WebKit/mac:

  • WebView/WebView.mm:

(+[WebView _setDomainRelaxationForbidden:forURLScheme:]):

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setDomainRelaxationForbiddenForURLScheme):

Source/WebKit/win:

  • WebView.cpp:

(WebView::setDomainRelaxationForbiddenForURLScheme):

Source/WebKit2:

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setDomainRelaxationForbiddenForURLScheme):

5:16 PM Changeset in webkit [99508] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/10405215> REGRESSION (r98178): World of Warcraft Launcher crashes in FrameView::isOnActivePage()
​https://bugs.webkit.org/show_bug.cgi?id=71743

Reviewed by Beth Dakin.

  • page/FrameView.cpp:

(WebCore::FrameView::isOnActivePage): Added a check for a null m_frame.

4:59 PM Changeset in webkit [99507] by dslomov@google.com
  • 14 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=71534
[V8] On neutering TypedArrayViews, V8 should be notified to drain code generation cache.

Reviewed by David Levin.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:
  • html/canvas/DataView.cpp:
  • html/canvas/DataView.h:
  • html/canvas/Float32Array.h:
  • html/canvas/Float64Array.h:
  • html/canvas/Int16Array.h:
  • html/canvas/Int32Array.h:
  • html/canvas/Int8Array.h:
  • html/canvas/TypedArrayBase.h:
  • html/canvas/Uint16Array.h:
  • html/canvas/Uint32Array.h:
  • html/canvas/Uint8Array.h:
4:57 PM Changeset in webkit [99506] by abarth@webkit.org
  • 12 edits in trunk/Source/WebCore

addMessage's last few arguments should be optional
​https://bugs.webkit.org/show_bug.cgi?id=70946

Reviewed by Darin Adler.

As requested by Darin Adler. I wanted to call this method addMessage,
but the compiler was unhappy locating the overload on
ScriptExecutionContext when Document had an override too. Changing the
name to addConsoleMessage made all the code happier.

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::addMessage):

  • dom/ScriptExecutionContext.h:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::getImageData):

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterToken):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::notifyFinished):

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation):
(WebCore::ContentSecurityPolicy::logUnrecognizedDirective):

  • page/EventSource.cpp:

(WebCore::EventSource::didReceiveResponse):

  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::looping):
(WebCore::AudioBufferSourceNode::setLooping):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::createLowPass2Filter):
(WebCore::AudioContext::createHighPass2Filter):

  • xml/XMLHttpRequest.cpp:

(WebCore::reportUnsafeUsage):

4:51 PM Changeset in webkit [99505] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

WebWorkers fail with document.domain set when accessing from subdomain
​https://bugs.webkit.org/show_bug.cgi?id=67978

Reviewed by Sam Weinig.

Source/WebCore:

Workers should ignore document.domain when deciding which URLs a
document can request, just like XMLHttpRequest and every other API.

Test: http/tests/workers/worker-document-domain-security.html

  • workers/AbstractWorker.cpp:

(WebCore::AbstractWorker::resolveURL):

LayoutTests:

Test that a document can still create same-origin workers after setting
document.domain.

  • http/tests/workers/worker-document-domain-security-expected.txt: Added.
  • http/tests/workers/worker-document-domain-security.html: Added.
4:44 PM Changeset in webkit [99504] by vangelis@chromium.org
  • 2 edits in branches/chromium/912/Source/WebCore/platform/graphics/chromium/cc

Merge 98392 - LayerRendererChromium::setVisible called needlessly without a visibility change
​https://bugs.webkit.org/show_bug.cgi?id=70766

Patch by Michal Mocny <​mmocny@google.com> on 2011-10-25
Reviewed by Kenneth Russell.

Check that visibility has actually changed before calling LayerRendererChromium::setVisible

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setVisible):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/8491030

4:42 PM Changeset in webkit [99503] by vangelis@chromium.org
  • 10 edits in branches/chromium/912/Source

Merge 98185 - [chromium] Make setVisibility extension- and thread-correct
​https://bugs.webkit.org/show_bug.cgi?id=70635

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::setVisible):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setVisible):

Source/WebKit/chromium:

  • public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::setVisibilityCHROMIUM):

  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::setVisibilityCHROMIUM):

  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DPrivate.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setVisibilityState):

TBR=​nduca@chromium.org
Review URL: ​http://codereview.chromium.org/8479052

4:37 PM Changeset in webkit [99502] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

DFG operationCreateThis slow path may get the wrong callee in case of inlining
​https://bugs.webkit.org/show_bug.cgi?id=71647

Reviewed by Oliver Hunt.

No new tests because I only saw this manifest itself when I had other bugs
leading to spurious slow path executions.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:33 PM Changeset in webkit [99501] by tony@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

Fix chromium cg results for css2.1/20110323/block-non-replaced-width-008.html

  • platform/chromium-cg-mac-leopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png.
4:27 PM Changeset in webkit [99500] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Allow gamepad API to be enabled at runtime
​https://bugs.webkit.org/show_bug.cgi?id=71736

Part of full patch, found at
​https://bugs.webkit.org/show_bug.cgi?id=69451

Patch by Scott Graham <​scottmg@chromium.org> on 2011-11-07
Reviewed by Adam Barth.

No new tests. No new functionality.

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::gamepadsEnabled):

4:21 PM Changeset in webkit [99499] by Lucas Forschler
  • 1 copy in tags/Safari-534.53.1

New tag.

4:10 PM Changeset in webkit [99498] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove [CustomGetter] IDL for window.Option of V8
​https://bugs.webkit.org/show_bug.cgi?id=71735

Reviewed by Nate Chapin.

Currently, window.Option uses a custom getter to get the template
of 'HTMLOptionElementConstructor'. However, this getter does not need to
be custom and can use a default getter
'DOMWindowInternal::DOMWindowConstructorGetter'.

Tests: fast/js/custom-constructors.html

fast/forms/option-index.html
fast/forms/add-and-remove-option.html
fast/dom/dom-add-optionelement.html

  • bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter.
  • page/DOMWindow.idl: Removed [CustomGetter] IDL from window.Option of V8. Renamed 'HTMLOptionElementConstructor' to 'HTMLOptionElementConstructorConstructor' in order to make window.Option use the template of (not 'HTMLOptionElement' but) 'HTMLOptionElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from the IDL type.
3:57 PM Changeset in webkit [99497] by mhahnenberg@apple.com
  • 23 edits in trunk/Source

De-virtualize JSObject::putWithAttributes
​https://bugs.webkit.org/show_bug.cgi?id=71716

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added putWithAttributes to the MethodTable, changed all the virtual
implementations of putWithAttributes to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • API/JSObjectRef.cpp:

(JSObjectSetProperty):

(JSC::DebuggerActivation::putWithAttributes):

  • debugger/DebuggerActivation.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

  • runtime/ClassInfo.h:
  • runtime/JSActivation.cpp:

(JSC::JSActivation::putWithAttributes):

  • runtime/JSActivation.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::putWithAttributes):

  • runtime/JSCell.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::putWithAttributes):

  • runtime/JSGlobalObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::putWithAttributes):
(JSC::putDescriptor):

  • runtime/JSObject.h:
  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::putWithAttributes):

  • runtime/JSStaticScopeObject.h:
  • runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::putWithAttributes):

  • runtime/JSVariableObject.h:

Source/WebCore:

No new tests.

Added putWithAttributes to the MethodTable, changed all the virtual
implementations of putWithAttributes to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::putWithAttributes):

  • bindings/js/JSDOMWindowShell.h:
3:53 PM Changeset in webkit [99496] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] restore original expectation for fast/frames/sandboxed-iframe-navigation-targetlink.html

  • platform/chromium/test_expectations.txt:
3:49 PM Changeset in webkit [99495] by dslomov@google.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Release build fix.

  • parser/Lexer.cpp:

(JSC::assertCharIsIn8BitRange):

3:46 PM Changeset in webkit [99494] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r99470.
​http://trac.webkit.org/changeset/99470
​https://bugs.webkit.org/show_bug.cgi?id=71740

"Broke test-webkitpy" (Requested by eseidel2 on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-07

  • Scripts/webkitpy/common/config/watchlist:
3:45 PM Changeset in webkit [99493] by Beth Dakin
  • 18 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=71490
Support uiStateTransitionProgress for scrollbars
-and corresponding-
<rdar://problem/9849612>

Reviewed by Sam Weinig.

Source/WebCore:

Step 1 of supporting uiStateTransitionProgress is knowing when the mouse has
entered or exited a scrollbar. These changes to Scrollbar pass that information
on to the ScrollAnimator. Also, Scrollbar::mouseUp() now takes a
PlatformMouseEvent as a parameter. This is necessary because m_hoveredNode is not
always up to date on a mouseUp, so mouseUp must hitTest the scrollbar to see if
the mouse has exited the scrollbar.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::mouseMoved):
(WebCore::Scrollbar::mouseExited):
(WebCore::Scrollbar::mouseUp):

  • platform/Scrollbar.h:

These changes are required now that Scrollbar::mouseUp() takes a parameter.

  • WebCore.exp.in:
  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::handleMouseReleaseEvent):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::wndProc):

ScrollAnimator passes the information on to AppKit.

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::mouseEnteredScrollbar):
(WebCore::ScrollAnimator::mouseExitedScrollbar):

  • platform/mac/ScrollAnimatorMac.h:

(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):

There are several new pieces of AppKit api we must call into.

  • platform/mac/NSScrollerImpDetails.h:

This is a temporary function that is needed for the time being since there is new
AppKit api required for this to work.

  • platform/mac/ScrollAnimatorMac.mm:

(supportsUIStateTransitionProgress):

I refactored WebScrollbarPartAnimation so that it can handle the
uiStateTransitionProgress animation as well as the alpha animations it already
handled. This mostly involved re-naming things and making use of a new enum called
FeatureToAnimate which keeps track of what the instance of
WebScrollbarPartAnimation is animating.
(-[WebScrollbarPartAnimation initWithScrollbarPainter:animate:scrollAnimator:animateFrom:animateTo:duration:]):
(-[WebScrollbarPartAnimation setScrollbarPainter:]):
(-[WebScrollbarPartAnimation setStartValue:]):
(-[WebScrollbarPartAnimation setEndValue:]):
(-[WebScrollbarPartAnimation setCurrentProgress:]):

WebScrollbarPainterDelegate has two new animations,
_verticalUIStateTransitionAnimation, and _horizontalUIStateTransitionAnimation. It
also responds to a few new delegate calls.
(-[WebScrollbarPainterDelegate cancelAnimations]):

This is a new delegate call needed for uiStateTransitionProgress.
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):

I re-named setUpAnimation to setUpAlphaAnimation since it does a lot of things
that are specific to the alpha animation and I chose not to re-use it for
uiStateTransition.
(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):

New delegate call for the uiStateTransition animation that sets up that animation
and kicks it off.
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):

Source/WebKit/chromium:

Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter.

  • src/WebScrollbarImpl.cpp:

(WebKit::WebScrollbarImpl::onMouseUp):

Source/WebKit/win:

Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter.

  • WebScrollBar.cpp:

(WebScrollBar::handleMouseEvent):

Source/WebKit2:

Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter.

  • UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::onLButtonUp):

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::handleMouseEvent):

3:43 PM Changeset in webkit [99492] by aboxhall@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary use of function pointer in FrameSelection::modify()
​https://bugs.webkit.org/show_bug.cgi?id=71646

Reviewed by Ryosuke Niwa.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::modify):

3:39 PM Changeset in webkit [99491] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Windows build fix after r99468.

  • css/CSSPrimitiveValue.h: Unmark single-argument constructors

as explicit, since this conflicts with the template constructors
in CSSPrimitiveValueMappings.h.

3:25 PM Changeset in webkit [99490] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Build fix due to a erroneous search-and-replace.

Unreviewed build fix.

Replace all instances of GenericClock with ClockGeneric.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/ClockGeneric.cpp:

(ClockGeneric::ClockGeneric):

3:20 PM Changeset in webkit [99489] by abarth@webkit.org
  • 7 edits in trunk/Source/WebCore

Move parseSandboxPolicy to SecurityContext
​https://bugs.webkit.org/show_bug.cgi?id=71732

Reviewed by Eric Seidel.

As requested by Eric, this patch resolves a layering inversion. Now
that we have SecurityContext to hold the sandbox bits and the origin,
it's a logical place to put the parser for sandbox policies.

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::parseSandboxPolicy):

  • dom/SecurityContext.h:
  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::parseMappedAttribute):

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::applySandboxPolicy):

  • page/SecurityOrigin.cpp:
  • page/SecurityOrigin.h:
3:17 PM Changeset in webkit [99488] by jer.noble@apple.com
  • 6 edits
    2 moves in trunk/Source/WebCore

Rename PlatformClockPOSIX -> ClockGeneric, and use WTF::currentTime() for its timing source.
​https://bugs.webkit.org/show_bug.cgi?id=71702

Reviewed by Sam Weinig.

No new tests; covered by existing tests.

  • platform/Clock.cpp:

(Clock::create):

  • platform/ClockGeneric.cpp: Renamed from Source/WebCore/platform/posix/PlatformClockPOSIX.cpp.

(ClockGeneric::GenericClock):
(ClockGeneric::setCurrentTime):
(ClockGeneric::currentTime):
(ClockGeneric::setPlayRate):
(ClockGeneric::start):
(ClockGeneric::stop):

  • platform/ClockGeneric.h: Renamed from Source/WebCore/platform/posix/PlatformClockPOSIX.h.

(WebCore::ClockGeneric::playRate):
(WebCore::ClockGeneric::isRunning):

Boilerplate project file changes:

  • CMakeLists.txt:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
3:16 PM Changeset in webkit [99487] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] disable 2 tests that are slow in debug

  • platform/chromium/test_expectations.txt: only run

fast/frames/lots-of-iframes.html and fast/frames/lots-of-objects.html
in release builds

3:08 PM Changeset in webkit [99486] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Switch the value profiler back to 8 buckets, because we suspect that while this
is more expensive it's also more stable.

Rubber stamped by Geoff Garen.

  • bytecode/ValueProfile.h:
3:03 PM Changeset in webkit [99485] by vangelis@chromium.org
  • 14 edits in trunk

Source/WebCore: Create a separate setting for compositing of for scrollable [i]frames
that forceCompositingMode can be used without turning frames into composited layers.
​https://bugs.webkit.org/show_bug.cgi?id=71714

Reviewed by James Robinson.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setAcceleratedCompositingForScrollableFramesEnabled):
(WebCore::Settings::acceleratedCompositingForScrollableFramesEnabled):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):

  • testing/Internals.cpp:

(WebCore::Internals::setEnableCompositingForScrollableFrames):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests: [chromium] Make compositing for scrollable [i]frames a setting separate from
forceCompositingMode.
​https://bugs.webkit.org/show_bug.cgi?id=71714

Adjust the force-compositing-mode layout tests to explicitly set the new flag.

Reviewed by James Robinson.

  • platform/chromium/compositing/force-compositing-mode/force-composite-empty.html:
  • platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html:
2:55 PM Changeset in webkit [99484] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[MutationObservers] Fix mac build (with mutation_observers enabled)
​https://bugs.webkit.org/show_bug.cgi?id=71728

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-11-07
Reviewed by Tony Chang.

Errant forward declaration of MutationObserverRegistration removed from
Node.h this would have broken a port that tried to build with mutation_observers=1.

  • dom/Node.h:
2:51 PM Changeset in webkit [99483] by ap@apple.com
  • 14 edits
    2 moves in trunk/Source/WebKit2

The Full Keyboard Access preference should be read in the UI process
​https://bugs.webkit.org/show_bug.cgi?id=71734
<rdar://problem/9237619>

Reviewed by Darin Adler.

This is consistent with how other global preferences (like language) are handled, and lets
us tighten up the sandbox a little.

  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
  • Shared/WebProcessCreationParameters.h: Added fullKeyboardAccessEnabled, so that newly started processes have the right preference value.
  • UIProcess/WebContext.h:
  • UIProcess/WebContext.cpp: (WebKit::WebContext::fullKeyboardAccessModeChanged): If preference changes while a web process is already running, tell it. (WebKit::WebContext::ensureWebProcess): Set parameters.fullKeyboardAccessEnabled from current preference.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::fullKeyboardAccessEnabled):
  • UIProcess/mac/WebProcessProxyMac.mm: (WebKit::WebProcessProxy::fullKeyboardAccessEnabled):
  • UIProcess/WebProcessProxy.h: Proxy it to Objective-C code. WebProcessProxy is as good place to have the static function as any. One day, we will make code more consistent with language and other global preferences.
  • UIProcess/mac/WKFullKeyboardAccessWatcher.h: Copied from Source/WebKit2/WebProcess/mac/WKFullKeyboardAccessWatcher.h.
  • UIProcess/mac/WKFullKeyboardAccessWatcher.mm: Copied from Source/WebKit2/WebProcess/mac/WKFullKeyboardAccessWatcher.mm.
  • WebProcess/mac/WKFullKeyboardAccessWatcher.h: Removed.
  • WebProcess/mac/WKFullKeyboardAccessWatcher.mm: Removed. (-[WKFullKeyboardAccessWatcher retrieveKeyboardUIModeFromPreferences:]): Once retrieved, push the preference value.
  • WebKit2.xcodeproj/project.pbxproj: WKFullKeyboardAccessWatcher is now in UI process.
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): (WebKit::WebProcess::fullKeyboardAccessModeChanged): (WebKit::WebProcess::fullKeyboardAccessEnabled):
  • WebProcess/mac/WebProcessMac.mm: WebCprocess now holds the preference value in a mamber value, which UI process pushes updates to.
  • WebProcess/WebProcess.messages.in: Added a message for changes preference value.
  • WebProcess/com.apple.WebProcess.sb: We no longer need read access to com.apple.universalaccess.plist.
2:46 PM Changeset in webkit [99482] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

Update chromium test_expectations.txt.

  • platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png:

Fix result that was attempted to be fixed in r99457.

  • platform/chromium/test_expectations.txt: Tests that need a baseline

after 99454.

2:39 PM Changeset in webkit [99481] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Remove [CustomGetter] IDL from 'HTMLAudioElementConstructor' of V8
​https://bugs.webkit.org/show_bug.cgi?id=71660

Reviewed by Adam Barth.

Currently, "new Audio()" uses a custom getter to get the template
of 'HTMLAudioElementConstructor'. However, this getter does not need to
be custom and can use a default getter 'DOMWindowInternal::DOMWindowConstructorGetter'.

Tests: fast/js/custom-constructors.html

media/audio-constructor.html
media/audio-constructor-src.html
media/audio-constructor-preload.html
media/audio-controls-do-not-fade-out.html
media/audio-controls-rendering.html

  • bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter.
  • page/DOMWindow.idl: Removed [CustomGetter] IDL from 'HTMLAudioElementConstructor' of V8. Renamed 'HTMLAudioElementConstructor' to 'HTMLAudioElementConstructorConstructor' in order to make 'new Audio()' use the template of (not 'HTMLAudioElement' but) 'HTMLAudioElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from an IDL type.
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation): If an IDL type is 'XXXXConstructorConstructor', then we do not add a header file 'XXXXConstructor.h' to JSDOMWindow.cpp, because the NamedConstructor declaration is written in the header file of class XXXX 'XXXX.h'. Incidentally, the reason why CodeGeneratorV8.pm does not need a corresponding change is that V8 is still generating the NamedConstructor declaration in its dedicated header file 'XXXXConstructor.h'. This V8 issue will be fixed in the upcoming patch that implements [NamedConstructor] IDL in V8.

2:38 PM Changeset in webkit [99480] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Emit the "frame,created" signal earlier.
​https://bugs.webkit.org/show_bug.cgi?id=71696

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-11-07
Reviewed by Kenneth Rohde Christiansen.

FrameLoader::loadURLIntoChildFrame will trigger the machinery that will call
FrameLoaderClientEfl::dispatchDidStartProvisionalLoad. However, since we were
emitting the "frame,created" signal after that, applications would connect to
it after some other frame signals had already been emitted. Should help tests
such as http/tests/loading/empty-subframe.html pass.

  • ewk/ewk_frame.cpp:

(ewk_frame_child_add):

  • ewk/ewk_view.cpp:

(ewk_view_frame_create):

2:35 PM Changeset in webkit [99479] by tony@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

Layout Test fast/events/platform-wheelevent-paging-x-in-scrolling-page.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=71606

Patch by Stephen Chenney <​schenney@chromium.org> on 2011-11-07
Reviewed by Tony Chang.

  • platform/chromium/test_expectations.txt: Remove the expected failure.
2:31 PM Changeset in webkit [99478] by tony@chromium.org
  • 3 edits in trunk/Tools

[chromium] update flakiness dashboard to reflect current bots

Reviewed by Ojan Vafai.

  • TestResultServer/static-dashboards/builders.js: Remove (deps) debug

bots and merged linux debug bots into a single bot.

  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(setupExpectationsTest):

2:20 PM Changeset in webkit [99477] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Uninitialized Heap member var
​https://bugs.webkit.org/show_bug.cgi?id=71722

Patch by Andrew Wason <​rectalogic@rectalogic.com> on 2011-11-07
Reviewed by Filip Pizlo.

  • heap/Heap.cpp:

(JSC::Heap::Heap): Initialize m_blockFreeingThreadShouldQuit

2:13 PM Changeset in webkit [99476] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG 32_64 - registers cannot be reused arbitrarily if speculation failures are possible
​https://bugs.webkit.org/show_bug.cgi?id=71684

Reviewed by Filip Pizlo.

Currently in DFG JIT, we try to reuse the physical register of an
operand for temporary usage if the current use of the operand is the
last use. But sometimes this can be wrong, for example if there are
possible speculation failures and we need to fallback to baseline JIT,
the value of the operand which is supposed to be hold in the physical
register can be modified by register reusing. The fixes the last
inspector failures in layout test on Mac 32-bit if switching on DFG.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):

2:13 PM Changeset in webkit [99475] by Lucas Forschler
  • 5 edits in branches/safari-534.53-branch/Source

Versioning.

2:10 PM Changeset in webkit [99474] by rniwa@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r99436): Broke Snow Leopard debug build
​https://bugs.webkit.org/show_bug.cgi?id=71713

Reviewed by Darin Adler.

Put the assertion in a template and use template specialization
to avoid warning when instantiated with UChar or LChar.

In the long term, we should have traits for unsigned integral types
and use that to specialize template instead of specializing it for UChar and LChar.

  • parser/Lexer.cpp:

(JSC::assertCharIsIn8BitRange):
(JSC::::append8):

2:09 PM Changeset in webkit [99473] by andersca@apple.com
  • 5 edits
    4 copies in trunk/Source/WebKit2

Add TiledCoreAnimationDrawingArea stub classes
​https://bugs.webkit.org/show_bug.cgi?id=71729

Reviewed by Sam Weinig.

  • Shared/DrawingAreaInfo.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _shouldUseTiledDrawingArea]):
(-[WKView WebKit::]):

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm: Copied from Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp.

(WebKit::TiledCoreAnimationDrawingAreaProxy::create):
(WebKit::TiledCoreAnimationDrawingAreaProxy::TiledCoreAnimationDrawingAreaProxy):
(WebKit::TiledCoreAnimationDrawingAreaProxy::~TiledCoreAnimationDrawingAreaProxy):
(WebKit::TiledCoreAnimationDrawingAreaProxy::deviceScaleFactorDidChange):
(WebKit::TiledCoreAnimationDrawingAreaProxy::sizeDidChange):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h: Copied from Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp.
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: Copied from Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp.

(WebKit::TiledCoreAnimationDrawingArea::create):
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::setNeedsDisplay):
(WebKit::TiledCoreAnimationDrawingArea::scroll):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerSync):

2:03 PM Changeset in webkit [99472] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Update WebCore.gyp to not use WebKitLibraries in include_dirs
​https://bugs.webkit.org/show_bug.cgi?id=71694

Patch by Robert Sesek <​rsesek@chromium.org> on 2011-11-07
Reviewed by Adam Barth.

  • WebCore.gyp/WebCore.gyp:
1:59 PM Changeset in webkit [99471] by dominicc@chromium.org
  • 6 edits in trunk

Remove initPopStateEvent method
​https://bugs.webkit.org/show_bug.cgi?id=71691

Reviewed by Ojan Vafai.

Source/WebCore:

  • dom/PopStateEvent.cpp:
  • dom/PopStateEvent.h:
  • dom/PopStateEvent.idl:

LayoutTests:

  • fast/events/fire-popstate-event.html: use 'new PopStateEvent' now
1:30 PM Changeset in webkit [99470] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add cc-bugs group to watch changes in chromium graphics
​https://bugs.webkit.org/show_bug.cgi?id=71690

Patch by Dana Jansens <​danakj@chromium.org> on 2011-11-07
Reviewed by James Robinson.

  • Scripts/webkitpy/common/config/watchlist:
1:20 PM Changeset in webkit [99469] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
​https://bugs.webkit.org/show_bug.cgi?id=70912

Patch by Balazs Ankes <​Ankes.Balazs@stud.u-szeged.hu> on 2011-11-07
Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/port/webkit.py: Add newline at the end of test_expectations.txt.
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Make up the test_test_expectations method for the updated webkit.py.
1:19 PM Changeset in webkit [99468] by andreas.kling@nokia.com
  • 53 edits
    1 add in trunk/Source/WebCore

CSSValue: Devirtualize isFooType().
<​http://webkit.org/b/71668>

Reviewed by Darin Adler.

Add a member to CSSValue to determine which subclass a given
value object is, along with 5 bits to tell us whether the
value is primitive/mutable/initial/inherited/a list.

All non-private subclass constructors now take CSSValue::ClassType
as their first argument. A few constructors were duplicated as
private members to allow calling them from ::create() methods
without passing an explicit ClassType.

Furthermore, since CSSValue::cssValueType() can be inferred from
the subclass type, we compute it instead of storing it in a member.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Adding CSSValue.cpp.

  • css/CSSValue.cpp: Added.

(WebCore::CSSValue::cssValueType):

Out-of-line implementation of this method. Only used by CSSOM.

  • css/CSSValue.h:

(WebCore::CSSValue::isMutableValue):
(WebCore::CSSValue::isPrimitiveValue):
(WebCore::CSSValue::isValueList):
(WebCore::CSSValue::isInitialValue):
(WebCore::CSSValue::isInheritedValue):
(WebCore::CSSValue::isBorderImageValue):
(WebCore::CSSValue::isBorderImageSliceValue):
(WebCore::CSSValue::isCursorImageValue):
(WebCore::CSSValue::isFontFamilyValue):
(WebCore::CSSValue::isFontFeatureValue):
(WebCore::CSSValue::isFontValue):
(WebCore::CSSValue::isImageGeneratorValue):
(WebCore::CSSValue::isImageValue):
(WebCore::CSSValue::isImplicitInitialValue):
(WebCore::CSSValue::isReflectValue):
(WebCore::CSSValue::isShadowValue):
(WebCore::CSSValue::isTimingFunctionValue):
(WebCore::CSSValue::isWebKitCSSTransformValue):
(WebCore::CSSValue::isCSSLineBoxContainValue):
(WebCore::CSSValue::isFlexValue):
(WebCore::CSSValue::isWebKitCSSFilterValue):
(WebCore::CSSValue::isSVGColor):
(WebCore::CSSValue::isSVGPaint):
(WebCore::CSSValue::classType):
(WebCore::CSSValue::CSSValue):
(WebCore::CSSValue::isPrimitiveType):
(WebCore::CSSValue::isListType):
(WebCore::CSSValue::isMutableType):
(WebCore::CSSValue::isInheritedType):
(WebCore::CSSValue::isInitialType):

Store subclass type information into a member variable and
made all the isFooValue() functions non-virtual and inline.
Some subclass type lookups (primitive values, notably) are
cached in a bool member on construction.

  • css/CSSAspectRatioValue.h:

(WebCore::CSSAspectRatioValue::CSSAspectRatioValue):

  • css/CSSBorderImageSliceValue.cpp:

(WebCore::CSSBorderImageSliceValue::CSSBorderImageSliceValue):

  • css/CSSBorderImageSliceValue.h:
  • css/CSSBorderImageValue.cpp:

(WebCore::CSSBorderImageValue::CSSBorderImageValue):

  • css/CSSBorderImageValue.h:
  • css/CSSCanvasValue.h:

(WebCore::CSSCanvasValue::CSSCanvasValue):

  • css/CSSCrossfadeValue.h:

(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):

  • css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::CSSCursorImageValue):

  • css/CSSCursorImageValue.h:
  • css/CSSFlexValue.h:

(WebCore::CSSFlexValue::CSSFlexValue):

  • css/CSSFontFaceSrcValue.h:

(WebCore::CSSFontFaceSrcValue::CSSFontFaceSrcValue):

  • css/CSSFunctionValue.cpp:

(WebCore::CSSFunctionValue::CSSFunctionValue):

  • css/CSSGradientValue.h:

(WebCore::CSSGradientValue::isLinearGradient):
(WebCore::CSSGradientValue::isRadialGradient):
(WebCore::CSSGradientValue::CSSGradientValue):
(WebCore::CSSLinearGradientValue::CSSLinearGradientValue):
(WebCore::CSSRadialGradientValue::CSSRadialGradientValue):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::CSSImageGeneratorValue):

  • css/CSSImageGeneratorValue.h:
  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::CSSImageValue):

  • css/CSSImageValue.h:
  • css/CSSInheritedValue.h:

(WebCore::CSSInheritedValue::CSSInheritedValue):

  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::CSSInitialValue):
(WebCore::CSSInitialValue::create):

  • css/CSSLineBoxContainValue.cpp:

(WebCore::CSSLineBoxContainValue::CSSLineBoxContainValue):

  • css/CSSLineBoxContainValue.h:
  • css/CSSMutableValue.h:

(WebCore::CSSMutableValue::CSSMutableValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSReflectValue.h:

(WebCore::CSSReflectValue::CSSReflectValue):

  • css/CSSTimingFunctionValue.h:

(WebCore::CSSTimingFunctionValue::isLinearTimingFunctionValue):
(WebCore::CSSTimingFunctionValue::isCubicBezierTimingFunctionValue):
(WebCore::CSSTimingFunctionValue::isStepsTimingFunctionValue):
(WebCore::CSSTimingFunctionValue::CSSTimingFunctionValue):
(WebCore::CSSLinearTimingFunctionValue::CSSLinearTimingFunctionValue):
(WebCore::CSSCubicBezierTimingFunctionValue::CSSCubicBezierTimingFunctionValue):
(WebCore::CSSStepsTimingFunctionValue::CSSStepsTimingFunctionValue):

  • css/CSSUnicodeRangeValue.h:

(WebCore::CSSUnicodeRangeValue::CSSUnicodeRangeValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::CSSValueList):

  • css/CSSValueList.h:
  • css/FontFamilyValue.cpp:

(WebCore::FontFamilyValue::FontFamilyValue):

  • css/FontFamilyValue.h:
  • css/FontFeatureValue.cpp:

(WebCore::FontFeatureValue::FontFeatureValue):

  • css/FontFeatureValue.h:
  • css/FontValue.h:

(WebCore::FontValue::FontValue):

  • css/ShadowValue.cpp:

(WebCore::ShadowValue::ShadowValue):

  • css/ShadowValue.h:
  • css/WebKitCSSFilterValue.cpp:

(WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):

  • css/WebKitCSSFilterValue.h:
  • css/WebKitCSSTransformValue.cpp:

(WebCore::WebKitCSSTransformValue::WebKitCSSTransformValue):

  • css/WebKitCSSTransformValue.h:
  • svg/SVGColor.cpp:

(WebCore::SVGColor::SVGColor):

  • svg/SVGColor.h:
  • svg/SVGPaint.cpp:

(WebCore::SVGPaint::SVGPaint):

  • svg/SVGPaint.h:

Propagate subclass type information and kill isFooType() virtuals.

1:14 PM Changeset in webkit [99467] by mihnea@adobe.com
  • 3 edits in trunk/Source/WebCore

Leaks seen in RenderRegion::setRenderBoxRegionInfo on Leaks bot
​https://bugs.webkit.org/show_bug.cgi?id=71259

Reviewed by Darin Adler.

Leak fixes covered by existing tests.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::logicalWidthChangedInRegions):
The RenderBoxRegionInfo taken out of RenderRegion must be deleted on all code paths.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::removeRenderBoxRegionInfo):
The RenderBoxRegionInfo map owns the values, therefore, when values are removed from map
they must also be deleted.

1:07 PM WebKit Team edited by haraken@chromium.org
(diff)
1:05 PM Changeset in webkit [99466] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

iframe sandbox treats vertical tab as a valid delimiter
​https://bugs.webkit.org/show_bug.cgi?id=71704

Reviewed by Eric Seidel.

Source/WebCore:

This patch adjusts our parser slightly to match the HTML5 spec. The
only difference is in how we handle vertical tabs. Previously, we
treated them as a delimiter, but we're not supposed to do that.

Test: fast/frames/sandboxed-iframe-parsing-space-characters.html

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::parseSandboxPolicy):

LayoutTests:

Test which space-like charaters are treating as delimiters.

  • fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt: Added.
  • fast/frames/sandboxed-iframe-parsing-space-characters.html: Added.
1:01 PM Changeset in webkit [99465] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Follow-up build fix.

  • WebProcess/WebPage/DrawingAreaImpl.h:
1:01 PM Changeset in webkit [99464] by abarth@webkit.org
  • 13 edits
    2 adds in trunk/Source/WebCore

Factor SecurityContext out of ScriptExecutionContext
​https://bugs.webkit.org/show_bug.cgi?id=71721

Reviewed by Eric Seidel.

The new SecurityContext object lets us tightly scope control of
the security-critical information in ScriptExecutionContext.
Originally I had hoped to put all this state on SecurityOrigin, but
SecurityOrigin gets shared between documents in some corner cases, so
it's not a good fit for state like the sandbox flags and the CSP policy
that really needs to be per-document.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext):

  • dom/ScriptExecutionContext.h:
  • loader/FrameLoader.h:
  • loader/FrameLoaderTypes.h:
  • page/SecurityOrigin.h:
12:50 PM Changeset in webkit [99463] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

Refactor CodeGeneratorV8.pm before making a core change for bug 71093.
​https://bugs.webkit.org/show_bug.cgi?id=71659

Reviewed by Adam Barth.

Just refactor CodeGeneratorV8.pm without any change in behavior,
as the first step for fixing bug 71093.

Tests: WebCore/bindings/scripts/test/TestObj.idl

WebCore/bindings/scripts/test/TestInterface.idl

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader): Sort generated headers in alphabetical order. Removed unnecessary variable names from method signatures. These changes are for silencing style check errors when a new TestXXXX.idl is added.
(GenerateConstructorCallback): Renamed variables to clarify their roles.
(WriteData): Removed an unused array @implHeaderContent.

  • bindings/scripts/test/V8/V8TestInterface.h: Updated a run-binding-tests result.
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h: Ditto.
  • bindings/scripts/test/V8/V8TestObj.h: Ditto.
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h: Ditto.
12:48 PM Changeset in webkit [99462] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Crash due to mixed direction text runs
​https://bugs.webkit.org/show_bug.cgi?id=66015

Patch by Ken Buchanan <​kenrb@chromium.org> on 2011-11-07
Reviewed by David Hyatt.

Source/WebCore:

Test for bug fix.

  • fast/text/international/bidi-neutral-in-mixed-direction-run-crash.html: Added
  • fast/text/international/bidi-neutral-in-mixed-direction-run-cras-expected.txt: Added

LayoutTests:

In some cases extra bidi runs were being added because appendRun() was being called
after the last run of the line was already appended.

This converts a previous fix for this bug to an ASSERT, because the check is
unnecessary, though it is a symptom that text runs have somehow gotten messed up.

  • rendering/InlineIterator.h:

(WebCore::InlineBidiResolver::appendRun): Abort append if we've already appended the last
run of the line

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::positionLineBox): Revert the previous patch, change to an assert

12:42 PM Changeset in webkit [99461] by eric@webkit.org
  • 4 edits in trunk/Tools

new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=62199

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
12:40 PM Changeset in webkit [99460] by timothy_horton@apple.com
  • 13 edits
    2 adds in trunk

getBBox() on a SVGPathElement with curves incorrectly includes control points
​https://bugs.webkit.org/show_bug.cgi?id=53512
<rdar://problem/9861154>

Reviewed by Oliver Hunt.

Split Path::boundingRect() into two, adding Path::fastBoundingRect()
for a rough estimate of the bounding rect (always equal to or larger
than boundingRect()). fastBoundingRect() currently falls back to
boundingRect() for all ports besides CG, though in most cases
(on a port-by-port basis) the current implementation of boundingRect()
will need to become fastBoundingRect(), and a new, more accurate method will
be implemented for boundingRect().

All previous callers of boundingRect() are transitioned to using fastBoundingRect()
except SVGPathElement::getBBox, which wants an accurate bounding box.

The CoreGraphics implementation of Path::boundingRect() called
CGPathGetBoundingBox, which includes the path's control points in its
calculations. Snow Leopard added CGPathGetPathBoundingBox, which
finds the bounding box of only points within the path, and does not
include control points. On Snow Leopard and above, we now use the latter.

Test: svg/custom/getBBox-path.svg

  • html/HTMLAreaElement.cpp:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • platform/graphics/Path.cpp:
  • platform/graphics/Path.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/PathCG.cpp:

(WebCore::Path::boundingRect):

  • rendering/RenderObject.h:
  • rendering/svg/RenderSVGPath.cpp:
  • svg/SVGPathElement.cpp:
  • svg/SVGPathElement.h:

Add a test that ensures that getBBox does not include control points in the rect it returns.

  • platform/chromium/test_expectations.txt:
  • svg/custom/getBBox-path-expected.txt: Added.
  • svg/custom/getBBox-path.svg: Added.
12:37 PM Changeset in webkit [99459] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Suggest box should be open immediately if forced by Ctrl+Space.
​https://bugs.webkit.org/show_bug.cgi?id=71710

Reviewed by Pavel Feldman.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype.autoCompleteSoon):

12:35 PM Changeset in webkit [99458] by vsevik@chromium.org
  • 5 edits in trunk

Web Inspector: Suggest box should consume enter key pressed event.
​https://bugs.webkit.org/show_bug.cgi?id=71700

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):

LayoutTests:

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest.InspectorTest.evaluateInConsole):

12:29 PM Changeset in webkit [99457] by robert@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[chromium] css2.1/20110323/block-non-replaced-width-008.htm fails on mac 10.5 CG
​https://bugs.webkit.org/show_bug.cgi?id=71214

Reviewed by Adam Barth.

  • platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
12:26 PM Changeset in webkit [99456] by vestbo@webkit.org
  • 4 edits in trunk

[Qt] Build all libraries in both debug and release on Mac OS X

We were already building the final shared library in debug and release,
but were missing the static JavaScriptCore and WebCore libraries, which
then broke the build.

Reviewed-by Andreas Kling.

12:21 PM Changeset in webkit [99455] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Remove unused DrawingArea::syncCompositingLayers
​https://bugs.webkit.org/show_bug.cgi?id=71717

Reviewed by John Sullivan.

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/TiledDrawingArea.h:
12:18 PM Changeset in webkit [99454] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Optimize outline rendering to avoid transparency layers
​https://bugs.webkit.org/show_bug.cgi?id=60750

Source/WebCore:

Add fast path for solid block outlines with alpha.
Improve readability of piecewise path while at it.

Patch by David Barr <​davidbarr@chromium.org> on 2011-11-07
Reviewed by Simon Fraser.

No intended change in behaviour, no new tests.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::paintOutline):

LayoutTests:

Rebaseline pixel tests to accommodate subtle change in rounding.

Patch by David Barr <​davidbarr@chromium.org> on 2011-11-07
Reviewed by Simon Fraser.

  • platform/chromium-linux/fast/box-shadow/box-shadow-radius-expected.png: Added.
  • platform/chromium-linux/fast/layers/self-painting-outline-expected.png: Added.
12:09 PM Changeset in webkit [99453] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Suggest box should not accept suggestion on space key pressed.
​https://bugs.webkit.org/show_bug.cgi?id=71706

Reviewed by Pavel Feldman.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.SuggestBox.prototype.tabKeyPressed):

11:46 AM Changeset in webkit [99452] by Nate Chapin
  • 2 edits in branches/chromium/874/Source/WebCore/bindings/v8

Merge 99311 - [V8] Null out V8NPObject::rootObject when the owning
Frame goes away.
​https://bugs.webkit.org/show_bug.cgi?id=71569

Reviewed by Adam Barth.

No new tests, this has only been successfully triggered
using ppapi flash.

  • bindings/v8/V8Helpers.cpp:

(WebCore::toV8Context):

  • bindings/v8/npruntime.cpp:

TBR=Nate Chapin
Review URL: ​http://codereview.chromium.org/8493015

11:32 AM Changeset in webkit [99451] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark perf/documnet-contians.html as slow.

  • platform/chromium/test_expectations.txt:
11:20 AM Changeset in webkit [99450] by andreas.kling@nokia.com
  • 10 edits in trunk/Source/WebCore

Don't use CSSOM's CSSValue.cssValueType internally in WebCore.
<​http://webkit.org/b/71679>

Reviewed by Darin Adler.

Swap out cssValueType() usage for isPrimitiveValue(), isInitialValue()
and isInheritedValue() to increase code clarity.

The plan is to turn cssValueType() into a computed value based on the
CSSValue subclass (coming soon to <​http://webkit.org/b/71668>.)
This is a clean-up in preparation for that.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::nameGetter):

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(WebCore::V8CSSStyleDeclaration::namedPropertyGetter):

  • css/CSSInheritedValue.h:

(WebCore::CSSInheritedValue::isInheritedValue):

  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::isInitialValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseColor):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapFillAttachment):
(WebCore::CSSStyleSelector::mapFillClip):
(WebCore::CSSStyleSelector::mapFillComposite):
(WebCore::CSSStyleSelector::mapFillOrigin):
(WebCore::CSSStyleSelector::mapFillImage):
(WebCore::CSSStyleSelector::mapFillRepeatX):
(WebCore::CSSStyleSelector::mapFillRepeatY):
(WebCore::CSSStyleSelector::mapFillSize):
(WebCore::CSSStyleSelector::mapFillXPosition):
(WebCore::CSSStyleSelector::mapFillYPosition):
(WebCore::CSSStyleSelector::mapAnimationDelay):
(WebCore::CSSStyleSelector::mapAnimationDirection):
(WebCore::CSSStyleSelector::mapAnimationDuration):
(WebCore::CSSStyleSelector::mapAnimationFillMode):
(WebCore::CSSStyleSelector::mapAnimationIterationCount):
(WebCore::CSSStyleSelector::mapAnimationName):
(WebCore::CSSStyleSelector::mapAnimationPlayState):
(WebCore::CSSStyleSelector::mapAnimationProperty):
(WebCore::CSSStyleSelector::mapAnimationTimingFunction):

  • css/CSSValue.h:

(WebCore::CSSValue::isInheritedValue):
(WebCore::CSSValue::isInitialValue):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applySVGProperty):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::extractFontSizeDelta):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):

11:20 AM Changeset in webkit [99449] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Rename NetscapePlugin::wantsWindowRelativeNPWindowCoordinates to NetscapePlugin::wantsPluginRelativeNPWindowCoordinates
​https://bugs.webkit.org/show_bug.cgi?id=71708

Reviewed by Sam Weinig.

The name wantsPluginRelativeNPWindowCoordinates is more clear than wantsWindowRelativeNPWindowCoordinates. Rename the functions
everywhere and, since the meaning is now inverted, invert the checks and return values.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::callSetWindow):
(WebKit::NetscapePlugin::geometryDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:

(WebKit::NetscapePlugin::wantsPluginRelativeNPWindowCoordinates):

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::wantsPluginRelativeNPWindowCoordinates):

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::wantsPluginRelativeNPWindowCoordinates):

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::wantsPluginRelativeNPWindowCoordinates):

11:20 AM Changeset in webkit [99448] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

NetscapePlugin::wantsWindowRelativeNPWindowCoordinates should return false on Mac
​https://bugs.webkit.org/show_bug.cgi?id=71707

Reviewed by Sam Weinig.

This changes the way the fake Carbon plug-in window is positioned, so that it's always the same size
and location as the plug-in (relative to the screen).

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformGeometryDidChange):
Call updateFakeWindowBounds.

(WebKit::NetscapePlugin::updateFakeWindowBounds):
Convert the plug-in position to screen coordinates and set the window bounds to be the location and
size of the plug-in, where the location is relative to the screen.

(WebKit::NetscapePlugin::wantsWindowRelativeNPWindowCoordinates):
Return false.

(WebKit::NetscapePlugin::windowAndViewFramesChanged):
Call updateFakeWindowBounds.

11:12 AM Changeset in webkit [99447] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r99432.
​http://trac.webkit.org/changeset/99432
​https://bugs.webkit.org/show_bug.cgi?id=71709

It made layout tests extra slow on all bots (Requested by
Ossy_night on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-07

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):

11:10 AM Changeset in webkit [99446] by Lucas Forschler
  • 1 copy in branches/safari-534.54-branch

New Branch.

11:10 AM Changeset in webkit [99445] by Lucas Forschler
  • 1 copy in branches/safari-534.53-branch

New Branch.

11:09 AM Changeset in webkit [99444] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

REGRESSION(r99409): Broke transitions/clip-transition.html
<​http://webkit.org/b/71692>

Reviewed by Darin Adler.

Add missing base class initializers to CSSPrimitiveValue constructors.
This was causing some CSSPrimitiveValues to masquerade as CSS_CUSTOM values.

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

10:46 AM Changeset in webkit [99443] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

WKPage.h should be in PrivateHeaders.

Rubber-stamped by Anders Carlsson.

  • WebKit2.xcodeproj/project.pbxproj:

Mark WKPage.h private.

10:28 AM Changeset in webkit [99442] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL] Support requestAnimationFrame API
​https://bugs.webkit.org/show_bug.cgi?id=67112

Patch by ChangSeok Oh <ChangSeok Oh> on 2011-11-07
Reviewed by Andreas Kling.

.:

Add build-option for requestAnimationFrame feature.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Let EFL port use REQUEST_ANIMATION_FRAME_TIMER.

  • wtf/Platform.h:

Source/WebCore:

Add some files to build-target when enabling requestAnimationFrame option.

fast/animation/request-animation-frame-cancel.html
fast/animation/request-animation-frame-cancel2.html
fast/animation/request-animation-frame-display.html
fast/animation/request-animation-frame-during-modal.html
fast/animation/request-animation-frame-timestamps.html
fast/animation/request-animation-frame-within-callback.html
fast/animation/request-animation-frame.html

  • CMakeLists.txt:
  • UseJSC.cmake:
10:26 AM Changeset in webkit [99441] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Add missing .in and .pl files to the Xcode project for easy access.

Reviewed by Eric Carlson.

  • WebCore.xcodeproj/project.pbxproj:

Add some missing files to the Xcode project.

10:24 AM Changeset in webkit [99440] by fsamuel@chromium.org
  • 7 edits in trunk

[Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
​https://bugs.webkit.org/show_bug.cgi?id=71485

Reviewed by Darin Fisher.

Source/WebKit/chromium:

Created new method setPageScaleFactor to replace scalePage to match
renamed method in WebCore. This change will happen in three stages:

  1. A new method is created called setPageScaleFactor with the same functionality as scalePage.
  2. All call sites of scalePage are changed to setPageScaleFactor in the Chromium repository.
  3. scalePage is deleted from WebView/WebViewImpl
  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::pageScaleFactor):
(WebKit::WebViewImpl::scalePage):
(WebKit::WebViewImpl::setPageScaleFactor):

  • src/WebViewImpl.h:

Tools:

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::scalePageBy):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::resetTestController):

10:16 AM Changeset in webkit [99439] by jberlin@webkit.org
  • 14 edits in trunk/Source

Need a way to allow a scheme access to Local Storage and Databases while Private Browsing is
enabled.
​https://bugs.webkit.org/show_bug.cgi?id=71631

Reviewed by Jon Honeycutt.

Source/WebCore:

Check the SchemeRegistry before preventing read/write access to Local Storage and Databases
in Private Browsing.

  • WebCore.exp.in:

Export the symbols for registering the schemes as allowing Local Storage and Database access
in Private Browsing.

  • dom/Document.cpp:

(WebCore::Document::allowDatabaseAccess):
Check if the scheme allows Database access in Private Browsing.

  • platform/SchemeRegistry.cpp:

(WebCore::schemesAllowingLocalStorageAccessInPrivateBrowsing):
(WebCore::schemesAllowingDatabaseAccessInPrivateBrowsing):
(WebCore::SchemeRegistry::registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing):
(WebCore::SchemeRegistry::allowsLocalStorageAccessInPrivateBrowsing):
(WebCore::SchemeRegistry::registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing):
(WebCore::SchemeRegistry::allowsDatabaseAccessInPrivateBrowsing):

  • platform/SchemeRegistry.h:
  • storage/Storage.cpp:

(WebCore::Storage::length):
Ask the storage area if it is disabled by Private Browsing in the frame instead of just
checking if Private Browsing is enabled for that frame because the answer might depend on
what type of storage that storage area is.
(WebCore::Storage::key):
Ditto.
(WebCore::Storage::getItem):
Ditto.
(WebCore::Storage::contains):
Ditto.

  • storage/StorageArea.h:

Make it possible to query a StorageArea for whether it is disabled by Private Browsing in a
Frame.

  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame):
Renamed from privateBrowsingEnabled.
Check not only if Private Browsing is enabled for the Frame, but also if the storage type is
Local Storage and if there is an exception for the scheme of the resource currently loaded
into the Frame.
(WebCore::StorageAreaImpl::setItem):
Renamed privateBrowsingEnabled -> disabledByPrivateBrowsingInFrame.
(WebCore::StorageAreaImpl::removeItem):
Ditto.
(WebCore::StorageAreaImpl::clear):
Ditto.

  • storage/StorageAreaImpl.h:

Source/WebKit/chromium:

  • src/StorageAreaProxy.h:

(WebCore::StorageAreaProxy::disabledByPrivateBrowsingInFrame):
Chromium uses a different method to track its icognito mode, so always return false.

Source/WebKit/mac:

Add WebKit1 API to register a scheme as ignoring Private Browsing for Local Storage and
Databases.

  • WebView/WebView.mm:

(+[WebView _registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing:]):
Call through to the SchemeRegistry function.
(+[WebView _registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing:]):
Ditto.

  • WebView/WebViewPrivate.h:
10:04 AM Changeset in webkit [99438] by dominicc@chromium.org
  • 11 edits in trunk

Remove initCloseEvent method
​https://bugs.webkit.org/show_bug.cgi?id=71374

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/dom/Window/window-properties.html

  • websockets/CloseEvent.h:

(WebCore::CloseEvent::initCloseEvent):

  • websockets/CloseEvent.idl:

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt:
10:00 AM Changeset in webkit [99437] by andersca@apple.com
  • 6 edits in trunk/Source

Simplify NetscapePlugin::convertPoint and make it work (in theory) with transformed plug-ins
​https://bugs.webkit.org/show_bug.cgi?id=71699

Reviewed by Sam Weinig.

Source/WebCore:

Export AffineTransform symbols used by WebKit2.

  • WebCore.exp.in:

Source/WebKit2:

Add a getScreenTransform function which given a coordinate space returns a transform that converts a
point from that coordinate space to the screen coordinate space. We then get the source -> screen transform
and the destination -> screen transform. We invert the destination -> screen transform, multiply it with the
source -> screen transform and use mapPoint to get a complete affine transform from the source to the destination space
and use mapPoint to map the source point and return the destination point.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::getScreenTransform):
(WebKit::NetscapePlugin::convertPoint):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::initializePlugin):
Call windowAndViewFramesChanged before viewGeometryDidChange so that the window and view frames will be up to date by
the time NPP_SetWindow is called in the plug-in.

9:54 AM Changeset in webkit [99436] by msaboff@apple.com
  • 25 edits in trunk/Source

Towards 8 Bit Strings: Templatize JSC::Lexer class by character type
​https://bugs.webkit.org/show_bug.cgi?id=71331

Source/JavaScriptCore:

Change the Lexer class to be a template class based on the character
type of the source. In the process updated the parseIdentifier()
and parseString() methods to create 8 bit strings where possible.
Also added some helper methods for accumulating temporary string
data in the 8 and 16 bit vectors.

Changed the SourceProvider::data() virtual method to return a
StringImpl* instead of a UChar*.

Updated the KeywordLookup generator to create code to match keywords
for both 8 and 16 bit source strings.

Due to a compiler bug (<rdar://problem/10194295>) moved enum
definition outside of Lexer class declaration. Remove second enum
no longer needed.

Reviewed by Darin Adler.

  • KeywordLookupGenerator.py:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::callEval):

  • parser/Lexer.cpp:

(JSC::::Lexer):
(JSC::::~Lexer):
(JSC::::getInvalidCharMessage):
(JSC::::currentCharacter):
(JSC::::setCode):
(JSC::::internalShift):
(JSC::::shift):
(JSC::::peek):
(JSC::::getUnicodeCharacter):
(JSC::::shiftLineTerminator):
(JSC::::lastTokenWasRestrKeyword):
(JSC::::record8):
(JSC::::append8):
(JSC::::append16):
(JSC::::record16):
(JSC::::parseIdentifier):
(JSC::::parseIdentifierSlowCase):
(JSC::::parseString):
(JSC::::parseStringSlowCase):
(JSC::::parseHex):
(JSC::::parseOctal):
(JSC::::parseDecimal):
(JSC::::parseNumberAfterDecimalPoint):
(JSC::::parseNumberAfterExponentIndicator):
(JSC::::parseMultilineComment):
(JSC::::nextTokenIsColon):
(JSC::::lex):
(JSC::::scanRegExp):
(JSC::::skipRegExp):
(JSC::::clear):
(JSC::::sourceCode):

  • parser/Lexer.h:

(JSC::Lexer::append16):
(JSC::Lexer::currentOffset):
(JSC::Lexer::setOffsetFromCharOffset):
(JSC::::isWhiteSpace):
(JSC::::isLineTerminator):
(JSC::::convertHex):
(JSC::::convertUnicode):
(JSC::::makeIdentifier):
(JSC::::setCodeStart):
(JSC::::makeIdentifierLCharFromUChar):
(JSC::::lexExpectIdentifier):

  • parser/Parser.cpp:

(JSC::Parser::Parser):
(JSC::Parser::parseProperty):
(JSC::Parser::parseMemberExpression):

  • parser/Parser.h:

(JSC::Parser::next):
(JSC::Parser::nextExpectIdentifier):

  • parser/ParserArena.h:

(JSC::IdentifierArena::makeIdentifier):
(JSC::IdentifierArena::makeIdentifierLCharFromUChar):

  • parser/SourceCode.h:

(JSC::SourceCode::subExpression):

  • parser/SourceProvider.h:

(JSC::UStringSourceProvider::stringData):

  • parser/SourceProviderCache.h:
  • parser/SyntaxChecker.h:
  • runtime/FunctionPrototype.cpp:

(JSC::insertSemicolonIfNeeded):

  • runtime/Identifier.cpp:

(JSC::IdentifierTable::add):
(JSC::IdentifierLCharFromUCharTranslator::hash):
(JSC::IdentifierLCharFromUCharTranslator::equal):
(JSC::IdentifierLCharFromUCharTranslator::translate):
(JSC::Identifier::add8):

  • runtime/Identifier.h:

(JSC::Identifier::Identifier):
(JSC::Identifier::createLCharFromUChar):
(JSC::Identifier::canUseSingleCharacterString):
(JSC::IdentifierCharBufferTranslator::hash):
(JSC::IdentifierCharBufferTranslator::equal):
(JSC::IdentifierCharBufferTranslator::translate):
(JSC::Identifier::add):
(JSC::Identifier::equal):
(JSC::IdentifierTable::add):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::decode):
(JSC::parseIntOverflow):
(JSC::globalFuncUnescape):

  • runtime/JSGlobalObjectFunctions.h:

(JSC::parseIntOverflow):

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser::tryJSONPParse):
(JSC::LiteralParser::Lexer::lexString):

  • wtf/text/StringImpl.h:

Source/WebCore:

Changed the SourceProvider::data() virtual method to return a
StringImpl* instead of a UChar*.
Changed Identifier() constructor to use JSGlobalData*.

Reviewed by Darin Adler.

No new tests - refactored SourceProvider class and sub-classes.

  • bindings/js/CachedScriptSourceProvider.h:

(WebCore::CachedScriptSourceProvider::stringData):

  • bindings/js/StringSourceProvider.h:

(WebCore::StringSourceProvider::stringData):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertQVariantToValue):

Source/WebKit/qt:

Changed Identifier() constructor to use JSGlobalData*.

Reviewed by Darin Adler.

  • Api/qwebframe.cpp:

(QWebFrame::addToJavaScriptWindowObject):

9:51 AM Changeset in webkit [99435] by dominicc@chromium.org
  • 5 edits in trunk

Remove initOverflowEvent from JavaScript bindings
​https://bugs.webkit.org/show_bug.cgi?id=71687

Reviewed by Ojan Vafai.

Source/WebCore:

Now that OverflowEvent has a constructor, we don't need the
initOverflowEvent method. It has to remain in the Objective C
binding because it is part of the Objective C public API.

  • dom/OverflowEvent.idl:

LayoutTests:

OverflowEvent initialization is tested in
fast/events/constructors/overflow-event-constructor.html

  • fast/events/init-events-expected.txt:
  • fast/events/script-tests/init-events.js:
9:48 AM Changeset in webkit [99434] by noel.gordon@gmail.com
  • 3 edits in trunk/Source/WebCore

Refactor canvas encoding mimeType validation
​https://bugs.webkit.org/show_bug.cgi?id=71651

Reviewed by Andreas Kling.

No new tests, refactoring only, covered by existing canvas tests.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::toEncodingMimeType): move encoder mimeType
validation logic into a helper routine.
(WebCore::HTMLCanvasElement::toDataURL):

  • html/HTMLCanvasElement.h:
9:43 AM Changeset in webkit [99433] by Philippe Normand
  • 2 edits in trunk/LayoutTests

[GTK] fast/frames/flattening/frameset-flattening-simple.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=71655

Reviewed by Martin Robinson.

  • fast/frames/flattening/frameset-flattening-simple.html: Trigger

the test only after the embedded frame has been loaded.

9:36 AM Changeset in webkit [99432] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Suggest box should consume enter key pressed event.
​https://bugs.webkit.org/show_bug.cgi?id=71700

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):

9:16 AM Changeset in webkit [99431] by dominicc@chromium.org
  • 4 edits in trunk/Source/WebCore

Remove initPageTransitionEvent method
​https://bugs.webkit.org/show_bug.cgi?id=71689

Reviewed by Ojan Vafai.

initPageTransitionEvent was removed from the HTML spec; it has
been replaced by new PageTransitionEvent(...).

Removing a method, so no new tests.

  • dom/PageTransitionEvent.cpp:
  • dom/PageTransitionEvent.h:
  • dom/PageTransitionEvent.idl:
9:15 AM Changeset in webkit [99430] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: TextPrompt+SuggestBox should autocomplete on "Right" keydown and with a single suggestion in place
​https://bugs.webkit.org/show_bug.cgi?id=71676

Reviewed by Pavel Feldman.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):

  • inspector/front-end/inspectorCommon.css:

(body): Revert inadvertent style change from a preceding commit.

8:51 AM Changeset in webkit [99429] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the Qt build on Mac OS X when using the QuickTime media backend

When QtWebKit is built on Mac OS X using the QuickTime media backend
we build both KURLCFNet.cpp and KURLMac, just like the Mac port, so
we have to guard the potentially duplicate symbol createCFURL with
more than just !PLATFORM(MAC).

Reviewed by Andreas Kling.

8:51 AM Changeset in webkit [99428] by vestbo@webkit.org
  • 5 edits in trunk

[Qt] Put the jsc binary in 'bin' instead of leaving it deep in the build tree

Allows us to not package up the whole Source/JavaScriptCore directory for the
buildbots.

Reviewed-by Simon Hausmann.

8:48 AM Changeset in webkit [99427] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-11-07 Pavel Feldman <​pfeldman@google.com>

Not reviewed: follow up to r99407. Style the suggest box.
​https://bugs.webkit.org/show_bug.cgi?id=65511

  • inspector/front-end/TextPrompt.js:
  • inspector/front-end/inspector.css:
  • inspector/front-end/textPrompt.css:
8:31 AM Changeset in webkit [99426] by rolandsteiner@chromium.org
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=70223
CSSStyleSheet: finding the owner node should be in its own method

Add styleSheetOwnerNode() function that returns the owner Node of the style sheet, or 0.

Reviewed by Dimitri Glazkov.

No new tests. (refactoring)

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::styleSheetOwnerNode):
(WebCore::CSSStyleSheet::document):

  • css/CSSStyleSheet.h:
8:24 AM Changeset in webkit [99425] by kenneth@webkit.org
  • 10 edits in trunk/Source/WebKit2

[Qt] Put handling of gestures and their interaction in one place
​https://bugs.webkit.org/show_bug.cgi?id=71682

Reviewed by Simon Hausmann.

Before this patch, the interaction (ie. cancelling animations, events)
was handled in the respective recognizers which then knew about each
others.

  • UIProcess/qt/QtGestureRecognizer.h:

(WebKit::QtGestureRecognizer::isRecognized):

  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::recognize):

  • UIProcess/qt/QtPanGestureRecognizer.h:
  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::recognize):

  • UIProcess/qt/QtPinchGestureRecognizer.h:
  • UIProcess/qt/QtTouchWebPageProxy.cpp:

(QtTouchWebPageProxy::QtTouchWebPageProxy):
(QtTouchWebPageProxy::doneWithTouchEvent):

  • UIProcess/qt/QtTouchWebPageProxy.h:
  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::scrollAnimationActive):
(WebKit::QtViewportInteractionEngine::interruptScrollAnimation):
(WebKit::QtViewportInteractionEngine::panGestureActive):
(WebKit::QtViewportInteractionEngine::scaleAnimationActive):
(WebKit::QtViewportInteractionEngine::interruptScaleAnimation):
(WebKit::QtViewportInteractionEngine::pinchGestureActive):

  • UIProcess/qt/QtViewportInteractionEngine.h:
7:58 AM Changeset in webkit [99424] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

[Qt] Make it possible to include qdesktopwebview.h from apps

Reviewed by Tor Arne Vestbø.

  • UIProcess/API/qt/qdesktopwebview.h: Don't include C API headers, forward

declare the structs manually.

7:43 AM Changeset in webkit [99423] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

[Qt] More gardening. Skip keygen related tests.

Rubber-stamped by Ossy.

  • platform/qt/Skipped: We don't support <keygen>, so group

the keygen failures and add a comment.

7:22 AM Changeset in webkit [99422] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

[Qt] Gardening, unskip tests that appear to pass now.

Rubber-stamped by Ossy.

  • platform/qt/Skipped:
6:43 AM Changeset in webkit [99421] by vestbo@webkit.org
  • 4 edits in trunk

[Qt] Ensure we always export symbols for the QtWebKit API when building WebKit

Reviewed-by Simon Hausmann.

6:43 AM Changeset in webkit [99420] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Sanitize qmake paths correctly before comparing

The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
which caused us to always generate derived webcore sources, but never build
them. The bug has been fixed, and we now also sanitize paths for the injected
bundle derived sources.

Reviewed-by Simon Husmann.

6:42 AM Changeset in webkit [99419] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Print right order for changing feature defines

Reviewed by Simon Hausmann.

6:32 AM Changeset in webkit [99418] by Simon Hausmann
  • 6 edits in trunk

[Qt] Fix failing inspector tests after build system changes ​https://bugs.webkit.org/show_bug.cgi?id=71677

Reviewed by Tor Arne Vestbø.

Source/WebKit/qt:

Ensure symbols from the qt resource system are referenced
from outside the static webcore library. One way of doing that is
to initialize the resources right away, as explained in the documentation
of th Qt resource system.

  • Api/qwebpage.cpp:

(initResources):
(QWebPagePrivate::QWebPagePrivate):

Source/WebKit2:

Ensure symbols from the qt resource system are referenced
from outside the static webcore library. One way of doing that is
to initialize the resources right away, as explained in the documentation
of th Qt resource system.

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(initResources):
(WebKit::WebPage::platformInitialize):

LayoutTests:

  • platform/qt/Skipped: Unskip previously failing tests.
6:30 AM Changeset in webkit [99417] by yurys@chromium.org
  • 8 edits in trunk/Source

[Chromium] Web Inspector: use native worker inspector instead of fake workers
​https://bugs.webkit.org/show_bug.cgi?id=71670

Source/WebCore:

Removed context menu option for switching between native and "fake" workers
debugger. Native debugger is used by default on platforms that support it.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._toggleFormatSource):

  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/WorkersSidebarPane.js:

(WebInspector.WorkerListSidebarPane):
(WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):

  • inspector/front-end/scriptsPanel.css:

(#shared-workers-list):

Source/WebKit/chromium:

chrome://workers link is replaced with instructions on discovering shared workers
in Task Manager.

Reviewed by Pavel Feldman.

  • src/js/DevTools.js:

():

6:20 AM Changeset in webkit [99416] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Add advanced search shortcut to ShortcutsScreen.
​https://bugs.webkit.org/show_bug.cgi?id=71302

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.AdvancedSearchController.createShortcut):

  • inspector/front-end/inspector.js:

(WebInspector._registerShortcuts):

6:10 AM Changeset in webkit [99415] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

CSSImageValue: Remove inheritance from CachedImageClient.
<​http://webkit.org/b/71675>

Reviewed by Antti Koivisto.

CSSImageValue doesn't actually use any of the CachedImageClient
functionality, and holds a reference to the resource via the
CachedResourceHandle in StyleCachedImage.

So we can safely remove the multiple inheritance and simplify
the class.

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::~CSSImageValue):
(WebCore::CSSImageValue::cachedImage):
(WebCore::CSSImageValue::clearCachedImage):

  • css/CSSImageValue.h:
6:09 AM Changeset in webkit [99414] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-07

  • DEPS:
6:04 AM Changeset in webkit [99413] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Skip a new failing test on Qt
​https://bugs.webkit.org/show_bug.cgi?id=70893

Patch by Ben Wells <​benwells@chromium.org> on 2011-11-07
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
5:46 AM Changeset in webkit [99412] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

CSSPrimitiveValue: Remove unused virtual function parseString().
<​http://webkit.org/b/71671>

Reviewed by Antti Koivisto.

  • css/CSSPrimitiveValue.cpp:
  • css/CSSPrimitiveValue.h:
5:43 AM Changeset in webkit [99411] by caseq@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: use toString as the Date object description.
​https://bugs.webkit.org/show_bug.cgi?id=71605

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/remote-object.html

  • inspector/InjectedScriptSource.js:

(.):

LayoutTests:

  • inspector/remote-object-expected.txt: Added.
  • inspector/remote-object.html: Added.
5:40 AM Changeset in webkit [99410] by caseq@chromium.org
  • 7 edits in trunk

Web Inspector: [refactoring] get JS-specific methods out of SourceFrame
​https://bugs.webkit.org/show_bug.cgi?id=70885

Reviewed by Pavel Feldman.

No new tests, as there's no new functionality.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.willHide):
(WebInspector.JavaScriptSourceFrame.prototype.requestContent):
(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.suggestedFileName):
(WebInspector.JavaScriptSourceFrame.prototype.editContent):
(WebInspector.JavaScriptSourceFrame.prototype.contentChanged):
(WebInspector.JavaScriptSourceFrame.prototype.setReadonly):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.cancelEditing):
(WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._getPopoverAnchor):
(WebInspector.JavaScriptSourceFrame.prototype._onShowPopover.showObjectPopover):
(WebInspector.JavaScriptSourceFrame.prototype._onShowPopover):
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):
(WebInspector.JavaScriptSourceFrame.prototype.addBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype.removeBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype._mouseDown):
(WebInspector.JavaScriptSourceFrame.prototype._editBreakpointCondition.finishEditing):
(WebInspector.JavaScriptSourceFrame.prototype._editBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype._createConditionElement):
(WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine):
(WebInspector.JavaScriptSourceFrame.prototype.clearExecutionLine):
(WebInspector.JavaScriptSourceFrame.prototype._lineNumberAfterEditing):
(WebInspector.JavaScriptSourceFrame.prototype._onTextViewerContentLoaded):
(WebInspector.JavaScriptSourceFrameDelegate):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.requestContent):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.setBreakpoint):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.removeBreakpoint):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.updateBreakpoint):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.findBreakpoint):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.continueToLine):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.canEditScriptSource):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.setScriptSource):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.setScriptSourceIsBeingEdited):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.suggestedFileName):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.addToWatch):

  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceSourceFrame):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.SourceFrameDelegateForScriptsPanel):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.willHide):
(WebInspector.SourceFrame.prototype.get textViewer):
(WebInspector.SourceFrame.prototype.requestContent):
(WebInspector.SourceFrame.prototype._saveViewerState):
(WebInspector.SourceFrame.prototype._restoreViewerState):
(WebInspector.SourceFrame.prototype.beforeTextChanged):
(WebInspector.SourceFrame.prototype.afterTextChanged):
(WebInspector.SourceFrame.prototype._initializeTextViewer):
(WebInspector.SourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.SourceFrame.prototype.suggestedFileName):
(WebInspector.SourceFrame.prototype.canEditSource):
(WebInspector.SourceFrame.prototype.startEditing):
(WebInspector.SourceFrame.prototype.commitEditing):
(WebInspector.SourceFrame.prototype.didEditContent):
(WebInspector.SourceFrame.prototype.editContent):
(WebInspector.SourceFrame.prototype.cancelEditing):
(WebInspector.SourceFrame.prototype.setReadOnly):

  • inspector/front-end/inspector.html:
5:31 AM Changeset in webkit [99409] by andreas.kling@nokia.com
  • 10 edits in trunk/Source/WebCore

CSSValue: Devirtualize cssValueType().
<​http://webkit.org/b/71667>

Reviewed by Antti Koivisto.

Keep the cssValueType in a CSSValue member instead of using
virtual functions.

This is part of a project to completely devirtualize CSSValue
<​http://webkit.org/b/71666> and will incur a temporary object
size regression for CSSValue while the work is ongoing.

  • css/CSSInheritedValue.cpp:
  • css/CSSInheritedValue.h:

(WebCore::CSSInheritedValue::CSSInheritedValue):

  • css/CSSInitialValue.cpp:
  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::CSSInitialValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSPrimitiveValue.h:
  • css/CSSValue.h:

(WebCore::CSSValue::cssValueType):
(WebCore::CSSValue::CSSValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::CSSValueList):

  • css/CSSValueList.h:
5:22 AM Changeset in webkit [99408] by pfeldman@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: introduce UserAgent override setting.
​https://bugs.webkit.org/show_bug.cgi?id=71627

Patch by Pavel Feldman <​pfeldman@chromium.org> on 2011-11-07
Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::clearFrontend):
(WebCore::InspectorResourceAgent::applyUserAgentOverride):
(WebCore::InspectorResourceAgent::setUserAgentOverride):

  • inspector/front-end/HelpScreen.js:

(WebInspector.HelpScreen):
(WebInspector.HelpScreen.prototype.show):
(WebInspector.HelpScreen.prototype._onBlur):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.prototype._cacheDisabledSettingChanged):
(WebInspector.NetworkManager.prototype._userAgentSettingChanged):

  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype._createSelectSetting.get for):
(WebInspector.SettingsScreen.prototype._createCustomSetting):
(WebInspector.SettingsScreen.prototype._createUserActionControl.checkboxClicked):
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.textDoubleClicked):
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.textChanged):

  • inspector/front-end/helpScreen.css:

(.help-table td):
(.help-content fieldset label):

4:50 AM Changeset in webkit [99407] by apavlov@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: autocomplete combobox for Styles sidebar and Console.
​https://bugs.webkit.org/show_bug.cgi?id=65511

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype):
():

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt):
(WebInspector.TextPrompt.prototype.setSuggestBoxEnabled):
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.applySuggestion):
(WebInspector.TextPrompt.prototype.acceptSuggestion):
(WebInspector.TextPromptWithHistory):

  • inspector/front-end/inspector.css:

(.suggest-box.generic-suggest):
(.suggest-box.generic-suggest.above-anchor):
(.suggest-box.generic-suggest .content):

4:44 AM Changeset in webkit [99406] by Philippe Normand
  • 4 edits in trunk/LayoutTests

Unreviewed, GTK flaky tests clean-up. Moved most of them to
test_expectations.

  • platform/gtk/Skipped:
  • platform/gtk/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
  • platform/gtk/test_expectations.txt:
4:19 AM Changeset in webkit [99405] by pfeldman@chromium.org
  • 8 edits
    4 adds in trunk

Web Inspector: split script-formatter test into multiple tests.
​https://bugs.webkit.org/show_bug.cgi?id=71607

Patch by Pavel Feldman <​pfeldman@chromium.org> on 2011-11-07
Reviewed by Yury Semikhatsky.

Source/WebCore:

Tests: inspector/debugger/script-formatter-breakpoints.html

inspector/debugger/script-formatter-console.html

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._removeSourceFrame):

LayoutTests:

  • inspector/debugger/script-formatter-breakpoints-expected.txt: Added.
  • inspector/debugger/script-formatter-breakpoints.html: Added.
  • inspector/debugger/script-formatter-console-expected.txt: Added.
  • inspector/debugger/script-formatter-console.html: Added.
  • inspector/debugger/script-formatter-expected.txt:
  • inspector/debugger/script-formatter.html:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
3:46 AM Changeset in webkit [99404] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, fast/dom/gc-11.html is now passing on GTK, it seems.

  • platform/gtk/Skipped:
3:39 AM Changeset in webkit [99403] by keishi@webkit.org
  • 17 edits in trunk

Change ColorChooser from singleton to ordinary object
​https://bugs.webkit.org/show_bug.cgi?id=71644

Reviewed by Kent Tamura.

Source/WebCore:

Changing WebCore::ColorChooser from a singleton to an ordinary object can broaden how browsers implement the color chooser interface.

  • WebCore.exp.in:
  • html/ColorInputType.cpp:

(WebCore::ColorInputType::~ColorInputType):
(WebCore::ColorInputType::setValue): If a chooser exists, calls Chrome::setSelectedColorInColorChooser
(WebCore::ColorInputType::handleDOMActivateEvent):
(WebCore::ColorInputType::detach):
(WebCore::ColorInputType::didCleanup): Called after cleanup is complete.
(WebCore::ColorInputType::cleanupColorChooser): Renamed from cleanupColorChooserIfCurrentClient.

  • html/ColorInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::selectColorInColorChooser):

  • html/HTMLInputElement.h:
  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::cleanupColorChooser): Added colorChooser argument because there are many WebCore::ColorChoosers now.
(WebCore::EmptyChromeClient::setSelectedColorInColorChooser): Ditto.

  • page/Chrome.cpp:

(WebCore::Chrome::cleanupColorChooser): Added colorChooser argument because there are many WebCore::ColorChoosers now.
(WebCore::Chrome::setSelectedColorInColorChooser): Ditto.

  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/ColorChooser.cpp:

(WebCore::ColorChooserClient::~ColorChooserClient):
(WebCore::ColorChooserClient::newColorChooser): Creates a new color chooser that is connected to itself.
(WebCore::ColorChooserClient::discardChooser): Discards the connected color chooser.
(WebCore::ColorChooser::ColorChooser): ColorChooser is RefCounted.
(WebCore::ColorChooser::create): Creates a ColorChooser that is connected to the given ColorChooserClient.
(WebCore::ColorChooser::~ColorChooser):
(WebCore::ColorChooser::didChooseColor): Called from WebKit side when user chose a color. Calls ColorChooserClient::didChooseColor
(WebCore::ColorChooser::didCleanup): Called from WebKit side when user color chooser was cleaned up. Calls ColorChooserClient::didCleanup

  • platform/ColorChooser.h:

(WebCore::ColorChooserClient::chooser): Returns the current ColorChooser.
(WebCore::ColorChooser::disconnectClient): Disconnects the ColorChooserClient.

  • testing/Internals.cpp:

(WebCore::Internals::selectColorInColorChooser): Added element argument. This calls didChooseColor on the ColorChooser of that element.

  • testing/Internals.h:
  • testing/Internals.idl: Removed connectColorChooserClient and updated selectColorInColorChooser.

LayoutTests:

  • fast/forms/color/input-color-onchange-event.html: Changed to match the changes to window.internals object
2:51 AM Changeset in webkit [99402] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

Web Inspector: Cannot edit elements commented with <!--
​https://bugs.webkit.org/show_bug.cgi?id=71357

Patch by Alexander Pavlov <​apavlov@chromium.org> on 2011-11-07
Reviewed by Pavel Feldman.

  • inspector/elements/edit-dom-actions-expected.txt:
  • inspector/elements/edit-dom-actions.html:
2:03 AM BuildingQt5OnHarmattan edited by Simon Hausmann
(diff)
1:59 AM Changeset in webkit [99401] by apavlov@chromium.org
  • 6 edits in trunk

Web Inspector: Cannot edit elements commented with <!--
​https://bugs.webkit.org/show_bug.cgi?id=71357

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getOuterHTML):
(WebCore::InspectorDOMAgent::setOuterHTML):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype.populateContextMenu):
(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
(WebInspector.ElementsTreeElement.prototype._populateTextContextMenu):
(WebInspector.ElementsTreeElement.prototype._populateNodeContextMenu):

LayoutTests:

  • inspector/elements/edit-dom-actions-expected.txt:
  • inspector/elements/edit-dom-actions.html:
1:26 AM Changeset in webkit [99400] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, unkip a working test and reclassify the wheelevent missing DRT features.

  • platform/gtk/Skipped:
12:48 AM Changeset in webkit [99399] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/test_expectations.txt:

Mark two tests as flaky. Remove some obsolete expectations.

12:09 AM Changeset in webkit [99398] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip fast/events/platform-wheelevent-paging on GTK
because this platform does not support a paging mouse wheel event.

  • platform/gtk/Skipped:

Nov 6, 2011:

11:18 PM Changeset in webkit [99397] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

Fix some style issues in ImageBuffer.h
​https://bugs.webkit.org/show_bug.cgi?id=71649

Reviewed by Kent Tamura.

No new tests. Style change only.

  • platform/graphics/ImageBuffer.h:
10:48 PM Changeset in webkit [99396] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Skip new failing test.
​https://bugs.webkit.org/show_bug.cgi?id=71022

Patch by Ben Wells <​benwells@chromium.org> on 2011-11-06
Reviewed by Martin Robinson.

  • platform/gtk/Skipped:
10:27 PM Changeset in webkit [99395] by keishi@webkit.org
  • 13 edits in trunk/Source/WebCore

InputType::fallbackValue and defaultValue should be const
​https://bugs.webkit.org/show_bug.cgi?id=71641

Reviewed by Kent Tamura.

Changing InputType::fallbackValue and defaultValue to const. Also adding OVERRIDE.

  • html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::fallbackValue):

  • html/BaseCheckableInputType.h:
  • html/ColorInputType.cpp:

(WebCore::ColorInputType::fallbackValue):

  • html/ColorInputType.h:
  • html/InputType.cpp:

(WebCore::InputType::fallbackValue):
(WebCore::InputType::defaultValue):

  • html/InputType.h:
  • html/RangeInputType.cpp:

(WebCore::RangeInputType::fallbackValue):

  • html/RangeInputType.h:
  • html/ResetInputType.cpp:

(WebCore::ResetInputType::defaultValue):

  • html/ResetInputType.h:
  • html/SubmitInputType.cpp:

(WebCore::SubmitInputType::defaultValue):

  • html/SubmitInputType.h:
7:17 PM Changeset in webkit [99394] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/test_expectations.txt:

fast/events/platform-wheelevent-paging-{x,y,xy}-in-scrolling-page.html fails on chromium-cg-mac.

7:13 PM Changeset in webkit [99393] by rniwa@webkit.org
  • 3 edits
    4 copies in branches/chromium/912

Merge 99067 - REGRESSION(r96870): WebKit generates background: transparent on blogger.com
​https://bugs.webkit.org/show_bug.cgi?id=71203

Reviewed by Ojan Vafai.

Source/WebCore:

Remove the transparent background color from inline style declarations in the pasted content.
Also fixed a bug in removeStyleFromRulesAndContext that it removes properties in inline style
declarations even if those properties were overridden.

Tests: editing/deleting/merge-paragraphs-with-transparent-background.html

editing/deleting/paste-with-transparent-background-color.html

  • editing/EditingStyle.cpp:

(WebCore::removePropertiesInStyle):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
(WebCore::EditingStyle::removePropertiesInElementDefaultStyle):

LayoutTests:

Added a test to merge paragraphs inside a document with background: transparent, and a test to
cut and paste contents with background: transparent, which is overriding a style rule background: blue.

WebKit should preserve the appearance of the pasted content but should not add a redundant
background: transparent.

  • editing/deleting/merge-paragraphs-with-transparent-background-expected.txt: Added.
  • editing/deleting/merge-paragraphs-with-transparent-background.html: Added.
  • editing/deleting/paste-with-transparent-background-color-expected.txt: Added.
  • editing/deleting/paste-with-transparent-background-color.html: Added.

TBR=​rniwa@webkit.org
Review URL: ​http://codereview.chromium.org/8493001

6:51 PM Changeset in webkit [99392] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r99374): GTK+ build of the jsc binary doesn't like the call
to initializeMainThread, and crashes
​https://bugs.webkit.org/show_bug.cgi?id=71643

Reviewed by Sam Weinig.

  • jsc.cpp:

(main):

6:34 PM Changeset in webkit [99391] by keishi@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove ColorInputType::handleClickEvent
​https://bugs.webkit.org/show_bug.cgi?id=71640

Reviewed by Kent Tamura.

When you click the input color element, both ColorInputType::handleClickEvent and
ColorInputType::handleDOMActivateEvent are called, causing Chrome::openColorChooser
to be called too many times.

  • html/ColorInputType.cpp: Removed ColorInputType::handleClickEvent
  • html/ColorInputType.h: Removed ColorInputType::handleClickEvent
6:25 PM Changeset in webkit [99390] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove extra semicolon in ColorInputType
​https://bugs.webkit.org/show_bug.cgi?id=71639

Reviewed by Kent Tamura.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::setValue):

6:07 PM Changeset in webkit [99389] by dominicc@chromium.org
  • 10 edits in trunk

Remove initBeforeLoadEvent method
​https://bugs.webkit.org/show_bug.cgi?id=71636

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/dom/Window/window-properties.html

  • dom/BeforeLoadEvent.h:
  • dom/BeforeLoadEvent.idl:

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt:
4:42 PM Changeset in webkit [99388] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Skip tests for autocorrection panel on Chromium port since
Chromium Mac port doesn't support autocorrection panel.

The failure was tracked by the Chromium issue 58254 (​http://crbug.com/58254).

  • platform/chromium/test_expectations.txt:
4:34 PM Changeset in webkit [99387] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

editing/input/scroll-viewport-page-up-down.html is very flaky on chromium win release
​https://bugs.webkit.org/show_bug.cgi?id=59642

Unreviewed; remove the failing test expectation since we can no longer observe the said failure.

  • platform/chromium/test_expectations.txt:
2:52 PM Changeset in webkit [99386] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Don't crash when a context hasn't been created. This fixed a
testing-only crash on the bots in the Chromium port.

  • testing/v8/WebCoreTestSupport.cpp:

(WebCoreTestSupport::resetInternalsObject):

2:45 PM Changeset in webkit [99385] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Unreviewed trivial fix after build system refactoring.

  • Scripts/run-qtwebkit-tests: Fix qml_import_path.
2:27 PM Changeset in webkit [99384] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Leaks seen in RenderFlowThread::setRegionRangeForBox on Leaks bot
​https://bugs.webkit.org/show_bug.cgi?id=71260

Reviewed by Mark Rowe.

Memory leak fix covered by existing tests.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
Instead of calling remove, call take and then delete, since the
values of the map are owned and need to be deleted when removed.

1:31 PM Changeset in webkit [99383] by abarth@webkit.org
  • 4 edits
    8 adds in trunk

Implement the sandbox directive for CSP
​https://bugs.webkit.org/show_bug.cgi?id=71604

Reviewed by Sam Weinig.

Source/WebCore:

At TPAC, Microsoft was pushing pretty hard to add the sandbox directive
to CSP. There's a question about whether it's going to be in CSP 1.0
or CSP 1.1, but it seems to be clearly headed into the spec.

This patch implements the sandbox directive for CSP. It's built on the
same machinery we use for the sandbox attribute for iframe. Now that
I've done the implementation, I'm going to write up some concrete text
for the spec.

Tests: http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-subframe.html

http/tests/security/contentSecurityPolicy/sandbox-allow-scripts.html
http/tests/security/contentSecurityPolicy/sandbox-empty-subframe.html
http/tests/security/contentSecurityPolicy/sandbox-empty.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::applySandboxPolicy):
(WebCore::ContentSecurityPolicy::addDirective):

  • page/ContentSecurityPolicy.h:

LayoutTests:

Test that the sandbox directive correctly wires up to the sandbox
flags. Also, test that the policy inherits into subframes. These are
essentially integration tests between the CSP and sandbox subsystems,
which is why they don't cover all the permutations of the sandbox
flags. Those are covered in more detail via tests of the sandbox
attribute.

  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-subframe-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-subframe.html: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts.html: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-empty-subframe.html: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-empty.html: Added.
1:29 PM Changeset in webkit [99382] by weinig@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Add space missing from some class declarations
​https://bugs.webkit.org/show_bug.cgi?id=71632

Reviewed by Anders Carlsson.

  • assembler/AssemblerBufferWithConstantPool.h:
  • bytecode/CodeBlock.h:
  • dfg/DFGVariableAccessData.h:
  • heap/VTableSpectrum.h:
  • jit/ExecutableAllocator.cpp:
  • jit/ExecutableAllocatorFixedVMPool.cpp:
  • wtf/MetaAllocatorHandle.h:
  • wtf/UnionFind.h:
1:01 PM Changeset in webkit [99381] by eric@webkit.org
  • 3 edits in trunk/Tools

Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
​https://bugs.webkit.org/show_bug.cgi?id=66078

Unreviewed. Add an assert about the type of "args"
to our Executive Mocks and fix a piece of code
from this patch which was hitting that assert
when executing for real.

  • Scripts/webkitpy/common/system/executive_mock.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
1:00 PM Changeset in webkit [99380] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add a crash expectation for platform/mac/accessibility/select-element-selection-with-optgroups.html on Mac.
The failure is tracked by the bug 71421.

  • platform/mac/test_expectations.txt:
12:49 PM Changeset in webkit [99379] by eric@webkit.org
  • 2 edits in trunk/Tools

Split chunk handling out of prepare_lists_and_print_output to make it more readable
​https://bugs.webkit.org/show_bug.cgi?id=71629

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
12:38 PM Changeset in webkit [99378] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Allow use of FINAL in JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=71630

Reviewed by Anders Carlsson.

  • Configurations/Base.xcconfig:

Don't warn about C++11 extensions used in C++98 mode.

11:48 AM Changeset in webkit [99377] by eric@webkit.org
  • 6 edits in trunk/Tools

Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
​https://bugs.webkit.org/show_bug.cgi?id=66078

Reviewed by Adam Barth.

The runtime feature detection was fixed to work in bug 64472.
In this bug I moved the symbol-based feature detection from
popen() to Executive.run_command and cleaned up the callers
and unittests to make sure that we're correctly parsing the
nm output correctly. The old code happened to work even though
the runtime-features path was using "str in list" and the
symbol features path was using "str in str" and it just happened
to do what we wanted to. Now runtime features and symbol feature
blacklists are computed separately (and with better documentation).

This system remains confusing, partially because these are black-lists
which are amended to whatever static blacklist may exist for the
port as part of a Skipped list file.

For example, notice how the runtime feature list only has directory
blacklists for a couple features. If all features are off,
how do we skip enough tests with only 2 entries in the blacklist map?
The answer is that Windows is the only port to use runtime feature
detection, and the win/Skipped file turns off all the other features
statically (like mathml, mhtml, wss, etc.) where as some other ports (like AppleMac)
which use symbol-based feature detection turn of mathml, wcss, etc
using the blacklists found in _missing_symbol_to_skipped_tests.

I also noticed a couple places where we still referenced xhtmlmp
even though support for such has been removed from WebKit. Removed those.

This should result in no functional change.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
    • Use self._filesystem instead of os.path
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
9:22 AM Changeset in webkit [99376] by mitz@apple.com
  • 2 edits in trunk/Tools

Made show-pretty-diff work when the input path contains spaces.

Reviewed by Anders Carlsson.

  • Scripts/show-pretty-diff:
3:54 AM Changeset in webkit [99375] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Value profiling should just use two buckets
​https://bugs.webkit.org/show_bug.cgi?id=71619

Reviewed by Gavin Barraclough.

Added one more configuration options (like Heuristics::minimumOptimizationDelay),
improved debugging in JIT optimization support, changed the number of buckets
in the value profile from 9 to 2, and wrote a more optimal value profiling path
in the old JIT to take advantage of this. It's still possible to play around with
larger numbers of buckets, and we should probably keep this for a little while
until we convince ourselves that using just two buckets is the right call.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::shouldOptimizeNow):

  • bytecode/ValueProfile.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitValueProfilingSite):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Heuristics.cpp:

(JSC::Heuristics::initializeHeuristics):

  • runtime/Heuristics.h:
3:39 AM Changeset in webkit [99374] by fpizlo@apple.com
  • 18 edits
    3 adds in trunk/Source

JSC should be able to sample itself in a more flexible way than just sampling flags
​https://bugs.webkit.org/show_bug.cgi?id=71522

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Added a construct that looks like SamplingRegion samplingRegion("name").

(JSC::SamplingRegion::Locker::Locker):
(JSC::SamplingRegion::Locker::~Locker):
(JSC::SamplingRegion::sample):
(JSC::SamplingRegion::dump):
(JSC::SamplingRegion::dumpInternal):
(JSC::SamplingThread::threadStartFunc):

  • bytecode/SamplingTool.h:

(JSC::SamplingRegion::SamplingRegion):
(JSC::SamplingRegion::~SamplingRegion):
(JSC::SamplingRegion::exchangeCurrent):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • heap/Heap.cpp:

(JSC::Heap::markRoots):
(JSC::Heap::collect):

  • heap/VTableSpectrum.cpp:

(JSC::VTableSpectrum::countVPtr):
(JSC::VTableSpectrum::dump):

  • heap/VTableSpectrum.h:
  • jsc.cpp:

(main):
(runWithScripts):

  • parser/Parser.h:

(JSC::parse):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • wtf/Atomics.h:

(WTF::weakCompareAndSwap):

  • wtf/Platform.h:
  • wtf/Spectrum.h: Added.

(WTF::Spectrum::Spectrum):
(WTF::Spectrum::add):
(WTF::Spectrum::get):
(WTF::Spectrum::begin):
(WTF::Spectrum::end):
(WTF::Spectrum::KeyAndCount::KeyAndCount):
(WTF::Spectrum::KeyAndCount::operator<):
(WTF::Spectrum::buildList):

  • wtf/wtf.pri:

Source/JavaScriptGlue:

Reviewed by Gavin Barraclough.

  • ForwardingHeaders/wtf/Spectrum.h: Added.

Source/WebCore:

Reviewed by Gavin Barraclough.

No new tests, since no functionality changed.

  • ForwardingHeaders/wtf/Spectrum.h: Added.
3:04 AM Changeset in webkit [99373] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Skip paged wheel events for Qt, as we don't support them yet.

  • platform/qt/Skipped:

Nov 6, 2011:

12:23 AM Changeset in webkit [99372] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Unindent edited text by pressing Shift + Tab
​https://bugs.webkit.org/show_bug.cgi?id=70181

Indent and unindent text in all selected lines.

Patch by Nikita Vasilyev <​me@elv1s.ru> on 2011-11-06
Reviewed by Pavel Feldman.

  • inspector/front-end/TextViewer.js:

(WebInspector.TextEditorMainPanel.prototype.unindentLines.get var):
(WebInspector.TextEditorMainPanel.prototype.unindentLines):

Note: See TracTimeline for information about the timeline view.