Context Navigation

← Previous Period
Next Period →

Timeline

Nov 12, 2011:

11:40 PM Changeset in webkit [100087] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r100038.
http://trac.webkit.org/changeset/100038
https://bugs.webkit.org/show_bug.cgi?id=72225

It broke more than 500 layout tests on the Qt bots (Requested
by Ossy_night on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-12

platform/qt/ScrollbarThemeQt.h:

8:37 PM Changeset in webkit [100086] by Laszlo Gombos

29 edits in trunk/Source

[Qt][Symbian] Remove support for WINSCW compiler
https://bugs.webkit.org/show_bug.cgi?id=70178

Reviewed by Chang Shu.

Source/JavaScriptCore:

API/JSStringRef.h:
create_hash_table: Revert r45553.
runtime/JSGlobalData.cpp: Revert r45553.
runtime/LiteralParser.cpp: Remove WINSCW comment.

(JSC::LiteralParser::Lexer::lexString):

runtime/Lookup.h: Revert r45553.
runtime/Structure.h: Revert r48461.
wtf/Alignment.h:
wtf/Assertions.h: Revert r52337.
wtf/Compiler.h:
wtf/ListRefPtr.h: Revert r48988.

(WTF::ListRefPtr::~ListRefPtr):

wtf/OwnArrayPtr.h: Revert r45911.

(WTF::OwnArrayPtr::operator UnspecifiedBoolType):

wtf/PassOwnArrayPtr.h:

(WTF::PassOwnArrayPtr::operator UnspecifiedBoolType):

wtf/PassRefPtr.h:
wtf/StaticConstructors.h:
wtf/unicode/qt4/UnicodeQt4.h:

Source/WebCore:

No new tests as there is no new functionality.

config.h: Revert r57076.
loader/cache/CachedResourceHandle.h: Revert r49017 and r49556.

(WebCore::CachedResourceHandle::CachedResourceHandle):

rendering/style/RenderStyle.h: Revert r52733.

(compareEqual):

bindings/scripts/CodeGeneratorJS.pm: Revert r45553.
bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
bindings/scripts/test/JS/JSTestEventConstructor.cpp: Ditto.
bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.
bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.

Source/WebKit2:

Shared/API/c/WKString.h:

4:47 PM Changeset in webkit [100085] by annacc@chromium.org

6 edits
58 adds in trunk

Add WebVTT parsing layout tests. Patch also includes creating a TextTrackCueList
in TextTrack::cues() and observing WebVTT chronological cue order.
https://bugs.webkit.org/show_bug.cgi?id=72215

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-webvtt-tc000-empty.html

media/track/track-webvtt-tc001-utf8.html
media/track/track-webvtt-tc002-bom.html
media/track/track-webvtt-tc003-newlines.html
media/track/track-webvtt-tc004-magic-header.html
media/track/track-webvtt-tc005-header-comment.html
media/track/track-webvtt-tc006-cue-identifiers.html
media/track/track-webvtt-tc007-cue-no-id.html
media/track/track-webvtt-tc008-timings-no-hours.html
media/track/track-webvtt-tc009-timings-hour.html
media/track/track-webvtt-tc010-no-timings.html
media/track/track-webvtt-tc011-blank-lines.html
media/track/track-webvtt-tc012-out-of-order.html
media/track/track-webvtt-tc013-settings.html
media/track/track-webvtt-tc014-alignment.html
media/track/track-webvtt-tc015-positioning.html
media/track/track-webvtt-tc016-align-positioning.html
media/track/track-webvtt-tc017-line-position.html
media/track/track-webvtt-tc018-align-text-line-position.html
media/track/track-webvtt-tc019-cue-size.html
media/track/track-webvtt-tc020-cue-size-align.html
media/track/track-webvtt-tc021-valign.html
media/track/track-webvtt-tc022-entities.html
media/track/track-webvtt-tc023-markup.html
media/track/track-webvtt-tc024-timestamp.html
media/track/track-webvtt-tc025-class-markup.html
media/track/track-webvtt-tc026-voice.html
media/track/track-webvtt-tc027-empty-cue.html
media/track/track-webvtt-tc028-unsupported-markup.html

html/TextTrack.cpp:

(WebCore::TextTrack::~TextTrack): Only call client if m_cues has been allocated.
(WebCore::TextTrack::cues): Create a TextTrackCueList if we don't already have one.

html/TextTrack.h: The cues() function can no longer be const.
html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::add): Only add the cue if the startTime comes after

all other startTimes in the list.

LayoutTests:

media/track/captions-webvtt/tc012-out-of-order.vtt: Fix typo.
media/track/track-webvtt-tc000-empty-expected.txt: Added.
media/track/track-webvtt-tc000-empty.html: Added.
media/track/track-webvtt-tc001-utf8-expected.txt: Added.
media/track/track-webvtt-tc001-utf8.html: Added.
media/track/track-webvtt-tc002-bom-expected.txt: Added.
media/track/track-webvtt-tc002-bom.html: Added.
media/track/track-webvtt-tc003-newlines-expected.txt: Added.
media/track/track-webvtt-tc003-newlines.html: Added.
media/track/track-webvtt-tc004-magic-header-expected.txt: Added.
media/track/track-webvtt-tc004-magic-header.html: Added.
media/track/track-webvtt-tc005-header-comment-expected.txt: Added.
media/track/track-webvtt-tc005-header-comment.html: Added.
media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Added.
media/track/track-webvtt-tc006-cue-identifiers.html: Added.
media/track/track-webvtt-tc007-cue-no-id-expected.txt: Added.
media/track/track-webvtt-tc007-cue-no-id.html: Added.
media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Added.
media/track/track-webvtt-tc008-timings-no-hours.html: Added.
media/track/track-webvtt-tc009-timings-hour-expected.txt: Added.
media/track/track-webvtt-tc009-timings-hour.html: Added.
media/track/track-webvtt-tc010-no-timings-expected.txt: Added.
media/track/track-webvtt-tc010-no-timings.html: Added.
media/track/track-webvtt-tc011-blank-lines-expected.txt: Added.
media/track/track-webvtt-tc011-blank-lines.html: Added.
media/track/track-webvtt-tc012-out-of-order-expected.txt: Added.
media/track/track-webvtt-tc012-out-of-order.html: Added.
media/track/track-webvtt-tc013-settings-expected.txt: Added.
media/track/track-webvtt-tc013-settings.html: Added.
media/track/track-webvtt-tc014-alignment-expected.txt: Added.
media/track/track-webvtt-tc014-alignment.html: Added.
media/track/track-webvtt-tc015-positioning-expected.txt: Added.
media/track/track-webvtt-tc015-positioning.html: Added.
media/track/track-webvtt-tc016-align-positioning-expected.txt: Added.
media/track/track-webvtt-tc016-align-positioning.html: Added.
media/track/track-webvtt-tc017-line-position-expected.txt: Added.
media/track/track-webvtt-tc017-line-position.html: Added.
media/track/track-webvtt-tc018-align-text-line-position-expected.txt: Added.
media/track/track-webvtt-tc018-align-text-line-position.html: Added.
media/track/track-webvtt-tc019-cue-size-expected.txt: Added.
media/track/track-webvtt-tc019-cue-size.html: Added.
media/track/track-webvtt-tc020-cue-size-align-expected.txt: Added.
media/track/track-webvtt-tc020-cue-size-align.html: Added.
media/track/track-webvtt-tc021-valign-expected.txt: Added.
media/track/track-webvtt-tc021-valign.html: Added.
media/track/track-webvtt-tc022-entities-expected.txt: Added.
media/track/track-webvtt-tc022-entities.html: Added.
media/track/track-webvtt-tc023-markup-expected.txt: Added.
media/track/track-webvtt-tc023-markup.html: Added.
media/track/track-webvtt-tc024-timestamp-expected.txt: Added.
media/track/track-webvtt-tc024-timestamp.html: Added.
media/track/track-webvtt-tc025-class-markup-expected.txt: Added.
media/track/track-webvtt-tc025-class-markup.html: Added.
media/track/track-webvtt-tc026-voice-expected.txt: Added.
media/track/track-webvtt-tc026-voice.html: Added.
media/track/track-webvtt-tc027-empty-cue-expected.txt: Added.
media/track/track-webvtt-tc027-empty-cue.html: Added.
media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Added.
media/track/track-webvtt-tc028-unsupported-markup.html: Added.

3:27 PM Changeset in webkit [100084] by nduca@chromium.org

4 edits in trunk/Source/WebCore

Fixes to GraphicsContext3D::makeCurrent on gtk and mac
https://bugs.webkit.org/show_bug.cgi?id=72218

Unreviewed. Forgot to handle corner cases. Thanks Nico!

platform/graphics/gtk/GraphicsContext3DGtk.cpp:

(WebCore::GraphicsContext3D::makeContextCurrent):

platform/graphics/gtk/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::makeContextCurrent):

platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::makeContextCurrent):

2:13 PM Changeset in webkit [100083] by mitz@apple.com

3 edits in trunk/Source/WebKit2

<rdar://problem/10294191> REGRESSION (WebKit2): Lookup bubble sized and positioned incorrectly (vertically off)
https://bugs.webkit.org/show_bug.cgi?id=72217

Reviewed by Dave Hyatt.

UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didPerformDictionaryLookup): Rather than adding the NSFont’s ascender
to the top of the text rect to establish the baseline here...

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupForRange): ...do it here, using the WebCore::Font’s
ascender, which is what’s actually used when drawing the text.

10:43 AM Changeset in webkit [100082] by Patrick Gansterer

3 edits in trunk/Source/JavaScriptCore

Unreviewed. Add ENABLE(DFG_JIT) around DFGCorrectableJumpPoint code.

dfg/DFGCorrectableJumpPoint.cpp:
dfg/DFGCorrectableJumpPoint.h:

9:30 AM Changeset in webkit [100081] by Patrick Gansterer

3 edits in trunk/Source/JavaScriptCore

[CMake] Move list of DFG source files into correct file
https://bugs.webkit.org/show_bug.cgi?id=72212

Reviewed by Daniel Bates.

The DFG files are platform independent. So move them from
the EFL specific file into the general CMakeLists.txt.

CMakeLists.txt:
PlatformEfl.cmake:

8:14 AM Changeset in webkit [100080] by Patrick Gansterer

2 edits in trunk/Source/JavaScriptCore

Fix "unused variable" warning in JSLock
https://bugs.webkit.org/show_bug.cgi?id=72213

Reviewed by Anders Carlsson.

Use ASSERT_UNUSED() instead of ASSERT() to make sure
that the variable is also used in the release build.

runtime/JSLock.cpp:

(JSC::JSLock::lock):
(JSC::JSLock::unlock):

5:51 AM Changeset in webkit [100079] by Patrick Gansterer

6 edits in trunk/Source/WebCore

Add stub implementation for SVGResources::filter()
https://bugs.webkit.org/show_bug.cgi?id=72211

Reviewed by Dirk Schulze.

Add an empty implementation, which only returns 0 for !ENABLE(FILTERS)
to reduce the #if ENABLE(FILTERS) complexity a bit.

rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::selfWillPaint):

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::selfWillPaint):

rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::filtersForceContainerLayout):

rendering/svg/SVGResources.h:

(WebCore::SVGResources::filter):

rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientLayoutChanged):
(WebCore::SVGResourcesCache::clientUpdatedFromElement):

5:33 AM Changeset in webkit [100078] by Antti Koivisto

3 edits
2 adds in trunk

REGRESSION(r98542): Rendering error on Google maps
https://bugs.webkit.org/show_bug.cgi?id=71996

Source/WebCore:

Reviewed by Andreas Kling.

r98542 exposed that StyleBoxData copy constructor and operator== are missing a field.

Test reduction by David Barr.

Test: fast/css/vertical-align-length-copy-bug.html

rendering/style/StyleBoxData.cpp:

(WebCore::StyleBoxData::StyleBoxData):
(WebCore::StyleBoxData::operator==):

LayoutTests:

Reviewed by Andreas Kling.

Test reduction by David Barr.

fast/css/vertical-align-length-copy-bug-expected.txt: Added.
fast/css/vertical-align-length-copy-bug.html: Added.

4:01 AM Changeset in webkit [100077] by commit-queue@webkit.org

2 edits in trunk/Tools

[Qt] Fix minor config typo in the build tool documentation
https://bugs.webkit.org/show_bug.cgi?id=72194

Patch by Ariya Hidayat <ariya@sencha.com> on 2011-11-12
Reviewed by Andreas Kling.

qmake/README:

3:09 AM Changeset in webkit [100076] by commit-queue@webkit.org

10 edits
2 deletes in trunk

Unreviewed, rolling out r100013.
http://trac.webkit.org/changeset/100013
https://bugs.webkit.org/show_bug.cgi?id=72210

It breaks all mac builds (Requested by WildFox on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-12

Source/WebCore:

html/HTMLAnchorElement.idl:
html/HTMLAreaElement.idl:
html/HTMLButtonElement.idl:
html/HTMLElement.idl:
html/HTMLInputElement.idl:
html/HTMLLabelElement.idl:
html/HTMLLegendElement.idl:
html/HTMLTextAreaElement.idl:

LayoutTests:

fast/forms/access-key-for-all-elements-expected.txt: Removed.
fast/forms/access-key-for-all-elements.html: Removed.

2:39 AM Changeset in webkit [100075] by Nikolas Zimmermann

24 edits in trunk/Source/WebCore

2011-11-12 Nikolas Zimmermann <nzimmermann@rim.com>

Finish SVGLengthContext conversion in svg/
https://bugs.webkit.org/show_bug.cgi?id=72105

Reviewed by Antti Koivisto.

Make SVGLengthContext(const SVGElement*) explicit, adapt all remaining call sites.
Now that this process is finished, SVGLengthContext can be shared across renders,
so that its possible to override the length context in a single place. This will
be done in future patches.

Doesn't affect any tests yet.

bindings/js/JSSVGLengthCustom.cpp: (WebCore::JSSVGLength::value): (WebCore::JSSVGLength::setValue): (WebCore::JSSVGLength::convertToSpecifiedUnits):
bindings/scripts/CodeGeneratorObjC.pm: (GenerateImplementation):
bindings/v8/custom/V8SVGLengthCustom.cpp: (WebCore::V8SVGLength::valueAccessorGetter): (WebCore::V8SVGLength::valueAccessorSetter): (WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):
css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::layout):
rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::updateFromElement):
rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::zeroLengthSubpathRect): (WebCore::RenderSVGPath::calculateMarkerBoundsIfNeeded):
rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::referencePoint): (WebCore::RenderSVGResourceMarker::calcViewport):
rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox):
rendering/svg/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::calcViewport):
rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::applyStrokeStyleToContext):
rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::operator<<):
rendering/svg/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeContainerElement::containerTranslation):
rendering/svg/SVGTextChunkBuilder.cpp: (WebCore::SVGTextChunkBuilder::addTextChunk):
rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::extractFloatValuesFromSVGLengthList):
rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::parentDefinesTextLength): (WebCore::SVGTextLayoutEngine::beginTextPathLayout):
rendering/svg/SVGTextLayoutEngineBaseline.cpp: (WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift):
rendering/svg/SVGTextLayoutEngineSpacing.cpp: (WebCore::SVGTextLayoutEngineSpacing::calculateCSSKerningAndSpacing):
svg/SVGElement.h:
svg/SVGLengthContext.cpp: (WebCore::SVGLengthContext::determineViewport):
svg/SVGLengthContext.h:
svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::viewport): (WebCore::SVGSVGElement::localCoordinateSpaceTransform): (WebCore::SVGSVGElement::currentViewBoxRect):
svg/SVGUseElement.cpp: (WebCore::SVGUseElement::toClipPath):

12:52 AM Changeset in webkit [100074] by Patrick Gansterer

2 edits in trunk

[CMake] Use MAIN_DEPENDENCY in GENERATE_* macros
https://bugs.webkit.org/show_bug.cgi?id=71365

Reviewed by Daniel Bates.

Use the MAIN_DEPENDENCY instead of DEPENDS in the custom build commands.
This adds better IDE support for such targets.

Source/cmake/WebKitMacros.cmake:

12:40 AM Changeset in webkit [100073] by Patrick Gansterer

2 edits in trunk/Source/WebCore

Unreviewed build fix for !ENABLE(FILTERS) after r100036.

rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::filtersForceContainerLayout):

Nov 11, 2011:

11:57 PM Changeset in webkit [100072] by Patrick Gansterer

8 edits in trunk/Source/WebCore

[WIN] Fix build without precompiled header.
https://bugs.webkit.org/show_bug.cgi?id=72115

Unreviewed. Add missing includes to fix build without precompiled header.

platform/ContextMenu.h:
platform/graphics/win/DIBPixelData.h:
platform/graphics/win/FontCustomPlatformData.h:
platform/network/cf/ResourceError.h:
platform/win/LanguageWin.cpp:
platform/win/LocalizedStringsWin.cpp:
platform/win/LoggingWin.cpp:

11:11 PM Changeset in webkit [100071] by Joseph Pecoraro

2 edits in trunk/Source/WebCore

<http://webkit.org/b/72205> Remove Duplicate Symbol Exports

Reviewed by Dan Bernstein.

WebCore.exp.in: Remove duplicate symbols listed.

Each dup in this case was already always exported.

9:24 PM Changeset in webkit [100070] by thakis@chromium.org

11 edits in trunk/Source

[chromium] Remove 2 static initializers and 3 exit time destructors. Turn on -Wexit-time-destructors.
https://bugs.webkit.org/show_bug.cgi?id=72146

Reviewed by Nate Chapin.

Source/WebCore:

WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

WebKit.gyp:
src/DebuggerAgentManager.cpp:

(WebKit::DebuggerAgentManager::debugHostDispatchHandler):
(WebKit::DebuggerAgentManager::onWebViewClosed):

src/DebuggerAgentManager.h:
src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::keyboardShortcut):

src/WebViewImpl.cpp:

(WebKit::pageGroupLoadDeferrerStack):
(WebKit::WebView::willEnterModalLoop):
(WebKit::WebView::didExitModalLoop):

8:48 PM Changeset in webkit [100069] by ojan@chromium.org

2 edits
2 moves
16 adds in trunk/LayoutTests

Chromium layout test rebaselines after http://trac.webkit.org/changeset/100045
and http://trac.webkit.org/changeset/100036.

Also add line for failing text test after http://trac.webkit.org/changeset/99963.

platform/chromium-cg-mac-snowleopard/svg/foreignObject/clip-expected.png: Added.
platform/chromium-cg-mac-snowleopard/svg/foreignObject/filter-expected.png: Added.
platform/chromium-cg-mac-snowleopard/svg/foreignObject/mask-expected.png: Added.
platform/chromium-cg-mac-snowleopard/svg/repaint/filter-child-repaint-expected.png: Added.
platform/chromium-mac-snowleopard/svg/repaint/filter-child-repaint-expected.png: Added.
platform/chromium-win/svg/foreignObject/clip-expected.txt: Added.
platform/chromium-win/svg/foreignObject/filter-expected.txt: Added.
platform/chromium-win/svg/foreignObject/mask-expected.txt: Added.
platform/chromium-win/svg/repaint/filter-child-repaint-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/repaint/filter-child-repaint-expected.png.
platform/chromium/svg/foreignObject/clip-expected.txt: Added.
platform/chromium/svg/foreignObject/filter-expected.txt: Added.
platform/chromium/svg/foreignObject/mask-expected.txt: Added.
platform/chromium/svg/repaint/filter-child-repaint-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/repaint/filter-child-repaint-expected.txt.
platform/chromium/test_expectations.txt:

8:45 PM Changeset in webkit [100068] by nduca@chromium.org

10 edits in trunk/Source

Since GraphicsContext3D::makeContextCurrent can fail, return bool.

https://bugs.webkit.org/show_bug.cgi?id=72101

Reviewed by Kenneth Russell.

Source/WebCore:

platform/graphics/GraphicsContext3D.h:
platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::makeContextCurrent):

platform/graphics/gtk/GraphicsContext3DGtk.cpp:

(WebCore::GraphicsContext3D::makeContextCurrent):

platform/graphics/gtk/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::makeContextCurrent):

platform/graphics/gtk/GraphicsContext3DPrivate.h:
platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::makeContextCurrent):

platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::makeContextCurrent):

Source/WebKit/chromium:

src/GraphicsContext3DChromium.cpp:

8:40 PM Changeset in webkit [100067] by ojan@chromium.org

4 edits
6 deletes in trunk

Source/WebCore: Unreviewed. Rollout http://trac.webkit.org/changeset/99744.
https://bugs.webkit.org/show_bug.cgi?id=72203
r99744 causes crash in Chromium's dom_perf test.

rendering/RenderTable.cpp:

(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addCell):
(WebCore::RenderTableSection::recalcCells):
(WebCore::RenderTableSection::appendColumn):

LayoutTests: Unreviewed. Rollout http://trac.webkit.org/changeset/99744.
https://bugs.webkit.org/show_bug.cgi?id=72203
r99744 causes crash in Chromium's dom_perf test.

fast/table/crash-splitColumn-2-expected.txt: Removed.
fast/table/crash-splitColumn-2.html: Removed.
fast/table/crash-splitColumn-3-expected.txt: Removed.
fast/table/crash-splitColumn-3.html: Removed.
fast/table/crash-splitColumn-expected.txt: Removed.
fast/table/crash-splitColumn.html: Removed.

8:28 PM Changeset in webkit [100066] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[chromium] Removed unused local from CCThreadProxy::scheduledActionCommit
https://bugs.webkit.org/show_bug.cgi?id=72200

Patch by James Robinson <jamesr@chromium.org> on 2011-11-11
Reviewed by Kenneth Russell.

How did I get here I am not good with computers.

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionCommit):

8:23 PM Changeset in webkit [100065] by dmazzoni@google.com

3 edits
2 adds in trunk

Source/WebCore: Fix a crash when an anonymous render block is in a continuation.
https://bugs.webkit.org/show_bug.cgi?id=70994

Reviewed by Chris Fleizach.

Test: accessibility/anonymous-render-block-in-continuation-causes-crash.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::renderParentObject):

LayoutTests: Add test to ensure that an anonymous render block in a continuation doesn't crash.
https://bugs.webkit.org/show_bug.cgi?id=70994

Reviewed by Chris Fleizach.

accessibility/anonymous-render-block-in-continuation-causes-crash.html: Added.
accessibility/anonymous-render-block-in-continuation-causes-crash-expected.txt: Added.

7:37 PM Changeset in webkit [100064] by annacc@chromium.org

19 edits
8 adds in trunk

Storage and retrieval of TextTrackCues during video playback, including
cuechange, enter, and exit events.
https://bugs.webkit.org/show_bug.cgi?id=70452

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-cues-cuechange.html

media/track/track-cues-enter-exit.html
media/track/track-cues-seeking.html

Add cuechange, enter, and exit events and make TextTrack and
TextTrackCue EventTargets:

dom/EventNames.h:
dom/EventTarget.h:
dom/EventTargetFactory.in:

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadTimerFired):

Use scheduleLoad() instead of configureTextTracks() to start an async load.

(WebCore::HTMLMediaElement::updateActiveTextTrackCues):

Updates the list of currently active cues during playback.

(WebCore::HTMLMediaElement::textTrackAddCues):

Adds cues to cueTree. Called when cues are discovered/loaded.

(WebCore::HTMLMediaElement::textTrackRemoveCues):

Removes cues from cueTree. Called when cues and/or tracks die.

(WebCore::HTMLMediaElement::textTrackAddCue):

Adds a cue to cueTree. Called when cues are discovered/loaded.

(WebCore::HTMLMediaElement::textTrackRemoveCue):

Removes a cue from cueTree. Called when cues and/or tracks die.

(WebCore::HTMLMediaElement::playbackProgressTimerFired):

Update the active TextTrackCues when playbackProgressTimerFired.

(WebCore::HTMLMediaElement::addTrack):

Pass along a ScriptExecutionContext to TextTrack::create().

(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):

Update the active TextTrackCues when the media player time changes.

html/HTMLMediaElement.h:

Use a PodIntervalTree cueTree to store and retrieve TextTrackCues
during playback.

html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::ensureTrack):

Pass along a ScriptExecutionContext needed for EventTarget interface.

html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack):

Pass along a ScriptExecutionContext needed for EventTarget interface.

(WebCore::LoadableTextTrack::fireCueChangeEvent):

Fire a cue change event on this TextTrack's <track>

html/LoadableTextTrack.h:

(WebCore::LoadableTextTrack::create):

Pass along a ScriptExecutionContext needed for EventTarget interface.

html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):

Pass along a ScriptExecutionContext needed for EventTarget interface.

(WebCore::TextTrack::cues):
(WebCore::TextTrack::activeCues):

Return a TextTrackCueList that represents the currently active cues.

(WebCore::TextTrack::fireCueChangeEvent):

Fires a cue change event.

html/TextTrack.h:

(WebCore::TextTrack::create):

Pass along a ScriptExecutionContext needed for EventTarget interface.

html/TextTrack.idl:

Makes TextTrack extend EventTarget interface and add oncuechange.

html/TextTrackCue.cpp:

(WebCore::TextTrackCue::TextTrackCue):

TextTrackCue should extend EventTarget, not ActiveDOMObject.

(WebCore::TextTrackCue::isActive):
(WebCore::TextTrackCue::setIsActive):

Dispatch an enter or exit event depending on active state and notify
the corresponding track to fire a cuechange event.

The following are needed for EventTarget interface:
(WebCore::TextTrackCue::interfaceName):
(WebCore::TextTrackCue::scriptExecutionContext):
(WebCore::TextTrackCue::eventTargetData):
(WebCore::TextTrackCue::ensureEventTargetData):

html/TextTrackCue.h:

(WebCore::TextTrackCue::refEventTarget):
(WebCore::TextTrackCue::derefEventTarget):

html/TextTrackCue.idl:

Extend EventTarget and add onenter and onexit.

html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::activeCues):

Update and return the list of currently active cues.

(WebCore::TextTrackCueList::clear):

Clear the cues from list (needed to return same object each time).

html/TextTrackCueList.h:

The following are needed for EventTarget interface:

html/track/TrackBase.cpp:

(WebCore::TrackBase::TrackBase):
(WebCore::TrackBase::interfaceName):
(WebCore::TrackBase::scriptExecutionContext):
(WebCore::TrackBase::eventTargetData):
(WebCore::TrackBase::ensureEventTargetData):

html/track/TrackBase.h:

(WebCore::TrackBase::refEventTarget):
(WebCore::TrackBase::derefEventTarget):

LayoutTests:

media/track/captions-webvtt/cues-chrono-order.vtt: Added.
media/track/captions-webvtt/cues-overlapping.vtt: Added.
media/track/track-cues-cuechange-expected.txt: Added.
media/track/track-cues-cuechange.html: Added.
media/track/track-cues-enter-exit-expected.txt: Added.
media/track/track-cues-enter-exit.html: Added.
media/track/track-cues-seeking-expected.txt: Added.
media/track/track-cues-seeking.html: Added.

7:29 PM Changeset in webkit [100063] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Chromium] Remove unused variable added by r99813.
https://bugs.webkit.org/show_bug.cgi?id=72199

Patch by David Reveman <reveman@chromium.org> on 2011-11-11
Reviewed by James Robinson.

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdate):

7:15 PM Changeset in webkit [100062] by ojan@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.
https://bugs.webkit.org/show_bug.cgi?id=72174

DEPS:

6:58 PM Changeset in webkit [100061] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/qt

[Qt] Removing unneeded #ifdef from PopupMenuQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=72193

Patch by Luiz Agostini <luiz.agostini@palm.com> on 2011-11-11
Reviewed by Noam Rosenthal.

Part of PopupMenuQt.cpp code is guarded by #ifndef QT_NO_COMBOBOX although that
code is not related to the class QComboBox.

WebCoreSupport/PopupMenuQt.cpp:

(WebCore::PopupMenuQt::show):

6:56 PM Changeset in webkit [100060] by jamesr@google.com

14 edits in trunk/Source

Rollout http://trac.webkit.org/changeset/99844
Solution is more complicated than the problem it was intended to solve.

Source/WebCore:

platform/graphics/chromium/LayerChromium.cpp:
platform/graphics/chromium/LayerChromium.h:
platform/graphics/chromium/cc/CCLayerImpl.cpp:
platform/graphics/chromium/cc/CCLayerImpl.h:
platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::applyScrollAndScale):

platform/graphics/chromium/cc/CCLayerTreeHost.h:
platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):

platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

6:53 PM Changeset in webkit [100059] by leviw@chromium.org

10 edits in trunk/Source/WebCore

Revert Page to operate on integers
https://bugs.webkit.org/show_bug.cgi?id=72185

Reviewed by Eric Seidel.

Reverting the page classes to integers from LayoutUnits. It's not necessary to expose
LayoutUnits in these classes, so we'll avoid doing so.

No new tests, no change in behavior.

page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::dragHysteresisExceeded):
(WebCore::EventHandler::handleDrag):

page/EventHandler.h:
page/Frame.cpp:

(WebCore::Frame::documentAtPoint):

page/Frame.h:
page/FrameView.cpp:

(WebCore::FrameView::create):
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::invalidateScrollbarRect):
(WebCore::FrameView::getTickmarks):
(WebCore::FrameView::windowResizerRect):
(WebCore::FrameView::setVisibleScrollerThumbRect):
(WebCore::FrameView::updateScrollCorner):
(WebCore::FrameView::paintScrollCorner):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::paintOverhangAreas):
(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):
(WebCore::FrameView::convertToContainingView):
(WebCore::FrameView::convertFromContainingView):

page/FrameView.h:
page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

page/Page.h:
page/SpatialNavigation.cpp:

(WebCore::scrollInDirection):

6:24 PM Changeset in webkit [100058] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Updating the expected value, missed in r81312
https://bugs.webkit.org/show_bug.cgi?id=72170

Patch by Chris Hutten-Czapski <chutten@rim.com> on 2011-11-11
Reviewed by Daniel Bates.

fast/viewport/viewport-128-expected.txt:

6:23 PM Changeset in webkit [100057] by dmazzoni@google.com

8 edits
2 adds in trunk

New iframe content may not be reflected in the ax tree.
https://bugs.webkit.org/show_bug.cgi?id=72100

Reviewed by Chris Fleizach.

Source/WebCore:

The core issue was that when childrenChanged was called on a
web area from an iframe that was just detached, it wasn't calling
childrenChanged on its parent scroll area, or that scroll area's
parent iframe element. To fix this, now AccessibilityScrollView
implements setNeedsToUpdateChildren and parentObjectIfExists,
and childrenChanged calls setNeedsToUpdateChildren on every object
in the parent chain, not just AccessibilityRenderObjects.

Test: accessibility/loading-iframe-updates-axtree.html

accessibility/AXObjectCache.h:
accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::setNeedsToUpdateChildren):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::childrenChanged):

accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::setNeedsToUpdateChildren):

accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::AccessibilityScrollView):
(WebCore::AccessibilityScrollView::updateChildrenIfNecessary):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):

accessibility/AccessibilityScrollView.h:

(WebCore::AccessibilityScrollView::setNeedsToUpdateChildren):

LayoutTests:

Add new test that makes sure that if you explore the accessibility
tree of an iframe and that iframe subsequently loads new content,
the iframe AccessibilityObject's descendants are updated to point
to the new content, not the old content.

accessibility/loading-iframe-updates-axtree-expected.txt: Added.
accessibility/loading-iframe-updates-axtree.html: Added.

6:10 PM Changeset in webkit [100056] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit2

[GTK][WEBKIT2] Add font and charset properties to WebKitWebSettings
https://bugs.webkit.org/show_bug.cgi?id=68996

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-11-11
Reviewed by Martin Robinson.

Provision to query and set the font related properties (such as
font-family, font-size) and charset properties (such as default-
charset) is added.

UIProcess/API/gtk/WebKitSettings.cpp: Added font and encoding properties.

(webKitSettingsSetProperty): GObject set property function.
(webKitSettingsGetProperty): GObject get property function.
(webkit_settings_class_init): Few more signals installed.
(webkit_settings_init): Initialization of instance variables.
(webkit_web_settings_get_default_font_family): Get 'default-font-family'.
(webkit_web_settings_set_default_font_family): Set 'default-font-family'.
(webkit_web_settings_get_monospace_font_family): Get 'monospace-font-family'.
(webkit_web_settings_set_monospace_font_family): Set 'monospace-font-family'.
(webkit_web_settings_get_serif_font_family): Get 'serif-font-family'.
(webkit_web_settings_set_serif_font_family): Set 'serif-font-family'.
(webkit_web_settings_get_sans_serif_font_family): Get 'sans-serif-font-family'.
(webkit_web_settings_set_sans_serif_font_family): Get 'sans-serif-font-family'.
(webkit_web_settings_get_cursive_font_family): Get 'cursive-font-family'.
(webkit_web_settings_set_cursive_font_family): Set 'cursive-font-family'.
(webkit_web_settings_get_fantasy_font_family): Get 'fantasy-font-family'.
(webkit_web_settings_set_fantasy_font_family): Set 'fantasy-font-family'.
(webkit_web_settings_get_pictograph_font_family): Get 'pictograph-font-family'.
(webkit_web_settings_set_pictograph_font_family): Set 'pictograph-font-family'.
(webkit_web_settings_get_default_font_size): Get 'default-font-size'.
(webkit_web_settings_set_default_font_size): Set 'default-font-size'.
(webkit_web_settings_get_default_monospace_font_size): Get 'default-monospace-font-size'.
(webkit_web_settings_set_default_monospace_font_size): Set 'default-monospace-font-size'.
(webkit_web_settings_get_minimum_font_size): Get 'minimum-font-size'.
(webkit_web_settings_set_minimum_font_size): Set 'minimum-font-size'.
(webkit_web_settings_get_default_charset): Get 'default-charset'.
(webkit_web_settings_set_default_charset): Set 'default-charset'.

UIProcess/API/gtk/WebKitSettings.h: Add new sections for gtk-doc generation.
UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Expose new public APIs.
UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Add new tests.

6:05 PM Changeset in webkit [100055] by commit-queue@webkit.org

5 edits in trunk/Source

[chromium] Fix CCThreadProxy::setVisible
https://bugs.webkit.org/show_bug.cgi?id=71903

The behavior is different depending on whether we're showing
or hiding the compositor. This patch fixes both code paths.

Patch by Iain Merrick <husky@google.com> on 2011-11-11
Reviewed by James Robinson.

platform/graphics/chromium/cc/CCCompletionEvent.h:

(WebCore::CCCompletionEvent::CCCompletionEvent):
(WebCore::CCCompletionEvent::~CCCompletionEvent):
(WebCore::CCCompletionEvent::wait):
(WebCore::CCCompletionEvent::signal):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setVisible):

5:52 PM Changeset in webkit [100054] by commit-queue@webkit.org

8 edits in trunk/Source

[chromium] CCThreadProxy::finishAllRendering hangs if !visible
https://bugs.webkit.org/show_bug.cgi?id=71920

Patch by Iain Merrick <husky@google.com> on 2011-11-11
Reviewed by James Robinson.

Source/WebCore:

platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::setNeedsForcedRedraw):

platform/graphics/chromium/cc/CCScheduler.h:
platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::setNeedsForcedRedraw):

platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::requestReadbackOnImplThread):
(WebCore::CCThreadProxy::finishAllRenderingOnImplThread):

Source/WebKit/chromium:

tests/CCSchedulerStateMachineTest.cpp:

(WebCore::TEST):

5:38 PM Changeset in webkit [100053] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/qt

[Qt] Skip tests when no network is present
https://bugs.webkit.org/show_bug.cgi?id=72031

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2011-11-11
Reviewed by Simon Hausmann.

Some benchmark tests requires network connection (they fetch data from
external URL's) and so they fail if no network is present. These tests
should be skipped instead.

tests/benchmarks/loading/tst_loading.cpp:

(tst_Loading::load): Skip test if no network is present.

tests/benchmarks/painting/tst_painting.cpp:

(tst_Painting::paint): Skip test if no network is present.

5:37 PM Changeset in webkit [100052] by jknotten@chromium.org

2 edits in trunk/Source/WebCore

[Chromium] Enable building without shared workers.
https://bugs.webkit.org/show_bug.cgi?id=72122

Reviewed by Yury Semikhatsky.

bindings/v8/WorkerScriptDebugServer.cpp:

(WebCore::retrieveWorkerContext):

5:26 PM Changeset in webkit [100051] by jchaffraix@webkit.org

4 edits
8 adds in trunk

Crash in styleDidChange when changing a table cell's height.
<http://webkit.org/b/72004>

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/table/crash-table-cell-change-height.html

fast/table/table-cell-change-height-with-needsCellRecalc-section.html
fast/table/table-cell-change-last-row-with-needsCellRecalc-section.html
fast/table/table-row-change-height-with-needsCellRecalc-section.html

r99212 removed our call to recalcCells when the logical height changed. This
means that we could end up with a cells without having set its row() properly
which would crash.

The change exposes the was-the-row-properly-set information so that we don't
try to access a bogus index. This should work properly even if the section
needs a cell recalc as the current section's row structure would still be
accurate in this case.

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleDidChange): Check that our row index
was properly set before calling

rendering/RenderTableCell.h:

(WebCore::RenderTableCell::rowWasSet): Helper function to detect
if we have set up our a row.
(WebCore::RenderTableCell::row): Use the previous function in the
ASSERT.

LayoutTests:

fast/table/crash-table-cell-change-height-expected.txt: Added.
fast/table/crash-table-cell-change-height.html: Added.

fast/table/table-cell-change-height-with-needsCellRecalc-section-expected.txt: Added.
fast/table/table-cell-change-height-with-needsCellRecalc-section.html: Added.
fast/table/table-cell-change-last-row-with-needsCellRecalc-section-expected.txt: Added.
fast/table/table-cell-change-last-row-with-needsCellRecalc-section.html: Added.
fast/table/table-row-change-height-with-needsCellRecalc-section-expected.txt: Added.
fast/table/table-row-change-height-with-needsCellRecalc-section.html: Added.

Those tests checks that we don't try to access bad rows when the section needs a recalc.

5:21 PM Changeset in webkit [100050] by commit-queue@webkit.org

11 edits
2 adds in trunk

Implement legacy text check emulation in unified text check interface.
https://bugs.webkit.org/show_bug.cgi?id=70299

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-11
Reviewed by Hajime Morita.

Source/autotools/symbols.filter:

Source/WebCore:

When UNIFIED_TEXT_CHECKING is off, WebCore::checkTextOfParagraph() emulates
TextCheckerClient::checkTextOfParagraph() using checkSpellingOfString and checkGrammarOfString.

This emulation can be used by setting the flag on.
This can be done by WebCore::Internals::setUnifiedTextCheckingEnabled.

Test: editing/spelling/spelling-unified-emulation.html

editing/TextCheckingHelper.cpp:

(WebCore::findBadGrammars): Added.
(WebCore::findMisspellings): Added.
(WebCore::checkTextOfParagraph):

Emulates TextCheckerClients::checkTextOfParagraph if UNIFIED_TEXT_CHECKING is off.

testing/Internals.cpp:

(WebCore::Internals::setUnifiedTextCheckingEnabled): flag setter.
(WebCore::Internals::unifiedTextCheckingEnabled): flag getter.

testing/Internals.h:
testing/Internals.idl:

Source/WebKit2:

win/WebKit2.def:
win/WebKit2CFLite.def:

LayoutTests:

Added tests for the case unified text checker is used when WebCore::checkTextOfParagraph() is not supported.

editing/spelling/spelling-unified-emulation-expected.txt: Added.
editing/spelling/spelling-unified-emulation.html: Added.

5:15 PM Changeset in webkit [100049] by gyuyoung.kim@samsung.com

2 edits in trunk/Source/WebCore

[CMAKE] Add a missing file to PlatformEfl.cmake for curl network backend.
https://bugs.webkit.org/show_bug.cgi?id=72092

Unreviewed. Fix build break when using curl.

ProxyServerCurl.cpp file is not included in PlatformEfl.cmake. So, the file is not built
when EFL port uses curl as network backend.

PlatformEfl.cmake: Add missing ProxyServerCurl.cpp.

5:12 PM Changeset in webkit [100048] by eae@chromium.org

4 edits in trunk/Source/WebCore

Switch remaining RenderBlock/Box methods to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=72075

Reviewed by Eric Seidel.

Move margins, floats and line layout block logic to layout abstraction.

No new tests.

rendering/RenderBlockLineLayout.cpp:

(WebCore::borderPaddingMarginStart):
(WebCore::borderPaddingMarginEnd):
(WebCore::inlineLogicalWidth):
(WebCore::setStaticPositions):
(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::setRepaintRange):
(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::checkFloatsInCleanLine):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
(WebCore::RenderBlock::addOverflowFromInlineChildren):
(WebCore::RenderBlock::checkLinesForTextOverflow):
(WebCore::RenderBlock::positionNewFloatOnLine):

rendering/RenderBox.cpp:

(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::positionLineBox):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):

rendering/RenderBox.h:

(WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):

4:57 PM Changeset in webkit [100047] by commit-queue@webkit.org

11 edits in trunk/Source

[chromium] Add translation/scaling to WebExternalTextureLayer
https://bugs.webkit.org/show_bug.cgi?id=72087

Patch by Antoine Labour <piman@chromium.org> on 2011-11-11
Reviewed by James Robinson.

Source/WebCore:

Covered by WebLayerTest.

platform/graphics/chromium/PluginLayerChromium.cpp:

(WebCore::PluginLayerChromium::PluginLayerChromium):
(WebCore::PluginLayerChromium::setUVRect):
(WebCore::PluginLayerChromium::pushPropertiesTo):

platform/graphics/chromium/PluginLayerChromium.h:

(WebCore::PluginLayerChromium::uvRect):

platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::VertexShaderPosTexStretch::VertexShaderPosTexStretch):
(WebCore::VertexShaderPosTexStretch::init):
(WebCore::VertexShaderPosTexStretch::getShaderString):

platform/graphics/chromium/ShaderChromium.h:

(WebCore::VertexShaderPosTexStretch::matrixLocation):
(WebCore::VertexShaderPosTexStretch::offsetLocation):
(WebCore::VertexShaderPosTexStretch::scaleLocation):

platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::CCPluginLayerImpl):
(WebCore::CCPluginLayerImpl::draw):

platform/graphics/chromium/cc/CCPluginLayerImpl.h:

(WebCore::CCPluginLayerImpl::setUVRect):

Source/WebKit/chromium:

public/WebExternalTextureLayer.h:
src/WebExternalTextureLayer.cpp:

(WebKit::WebExternalTextureLayer::setUVRect):
(WebKit::WebExternalTextureLayer::uvRect):

4:34 PM Changeset in webkit [100046] by commit-queue@webkit.org

5 edits
2 adds in trunk

Null deref when no use element exists for SVG element instance
https://bugs.webkit.org/show_bug.cgi?id=59136

Second attempt, with a fix to handle JS garbage collection.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-11
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/custom/element-instance-held-by-js-crash.svg

svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::~SVGElementInstance): Added call to detach() to clear

anything not yet cleared.

(WebCore::SVGElementInstance::detach): New method to replace old clear methods. This one

clears all the pointers it can, and removes the instance from the corresponding elements
instance list.

svg/SVGElementInstance.h: Removed clear methods and replaced with detach.
svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::detachInstance): Modified calls to clean up an SVGElementInstance.

LayoutTests:

svg/custom/element-instance-held-by-js-crash-expected.txt: Added.
svg/custom/element-instance-held-by-js-crash.svg: Added.

4:30 PM Changeset in webkit [100045] by commit-queue@webkit.org

4 edits
9 adds in trunk

clipPath does not work on foreignObject
https://bugs.webkit.org/show_bug.cgi?id=68251

Patch by Florin Malita <fmalita@google.com> on 2011-11-11
Reviewed by Dirk Schulze.

Source/WebCore:

Add ForeignObject clipping, filtering and masking support using the SVGRenderSupport helpers
(prepareToRenderSVGContent, finishRenderSVGContent) on RenderSVGForeignObject's paint path.
This also allows us to remove explicit transparency handling, since the helpers already cover it.

Tests: svg/foreignObject/clip.html

svg/foreignObject/filter.html
svg/foreignObject/mask.html

rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::paint):

rendering/svg/SVGResources.cpp:

(WebCore::clipperFilterMaskerTags):

LayoutTests:

svg/foreignObject/clip-expected.png: Added.
svg/foreignObject/clip-expected.txt: Added.
svg/foreignObject/clip.html: Added.
svg/foreignObject/filter-expected.png: Added.
svg/foreignObject/filter-expected.txt: Added.
svg/foreignObject/filter.html: Added.
svg/foreignObject/mask-expected.png: Added.
svg/foreignObject/mask-expected.txt: Added.
svg/foreignObject/mask.html: Added.

4:07 PM Changeset in webkit [100044] by ojan@chromium.org

6 edits in trunk/LayoutTests

Revert http://trac.webkit.org/changeset/100008.
Caused hundreds of failures on the Chromium Leopard bots.
https://bugs.webkit.org/show_bug.cgi?id=68270

platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png:
platform/chromium-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png:
platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
platform/chromium/test_expectations.txt:

4:02 PM Changeset in webkit [100043] by ojan@chromium.org

2 edits in trunk/LayoutTests

Update expectations for failing test.

platform/chromium/test_expectations.txt:

3:54 PM Changeset in webkit [100042] by eae@chromium.org

10 edits in branches/subpixellayout/Source/WebCore

Round offsetWidth/Height/Top/Left and client* before returning instead of flooring the values in the binding code

3:54 PM Changeset in webkit [100041] by adamk@chromium.org

10 edits in trunk/Source

Remove no-op StorageNamespace::unlock method
https://bugs.webkit.org/show_bug.cgi?id=72181

Reviewed by Darin Adler.

Source/WebCore:

The method was meant to support the localStorage mutex,
but the approach of using a mutex for localStorage has never been
implemented (and almost certainly won't be). Even if it were implemented,
it's not being called at the right time, due to bugs in the V8 bindings'
use of V8Proxy (see http://webkit.org/b/72063 for details).

If, in the future, some replacement for a mutex is used to synchronize
localStorage access, it can easily be re-added to the (hopefully
fixed-by-then) replacement for V8Proxy::didLeaveScriptContext.

bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::didLeaveScriptContext): Stop calling unlock().

page/Navigator.cpp:

(WebCore::Navigator::getStorageUpdates): Remove implementation (a call to unlock), but leave code as it's exposed to the platform.

page/Navigator.idl: Added a FIXME to remove getStorageUpdates from the platform.
storage/StorageNamespace.h:
storage/StorageNamespaceImpl.cpp:
storage/StorageNamespaceImpl.h:

Source/WebKit/chromium:

src/StorageNamespaceProxy.cpp:
src/StorageNamespaceProxy.h:

3:52 PM Changeset in webkit [100040] by commit-queue@webkit.org

9 edits in trunk

[Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
https://bugs.webkit.org/show_bug.cgi?id=49257

Source/WebKit/chromium:

Add the WebFrame::getPageProperty method for Chromium.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-11
Reviewed by Darin Fisher.

public/WebFrame.h:
src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::getPageProperty):

src/WebFrameImpl.h:

Tools:

Adds the remaining missing layout test functionality for printing.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-11
Reviewed by Darin Fisher.

DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): Add bindings for new JS methods
(parsePageNumber): Method to parse JS arguments for a page number
(parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
(LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
(LayoutTestController::isPageBoxVisible): get the visibility status for printing
(LayoutTestController::pageProperty): get a specific CSS property when in printing mode

DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods

LayoutTests:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-11
Reviewed by Darin Fisher.

platform/chromium/test_expectations.txt: Removed expected fails for

printing tests that were using missing functionality in LayoutTestController.

3:50 PM Changeset in webkit [100039] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

Update iOS compiler version.

Reviewed by David Kilzer.

Configurations/CompilerVersion.xcconfig:
- Update compiler version.

3:44 PM Changeset in webkit [100038] by alexis.menard@openbossa.org

2 edits in trunk/Source/WebCore

[Qt][WK2] Make sure Scrollbars are in their own layer.
https://bugs.webkit.org/show_bug.cgi?id=72064

Reviewed by Kenneth Rohde Christiansen.

Make sure we render our scrollbars in a separate layer.

No new tests : existing ones should cover.

platform/qt/ScrollbarThemeQt.h:

(WebCore::ScrollbarThemeQt::usesOverlayScrollbars):

3:43 PM Changeset in webkit [100037] by barraclough@apple.com

6 edits in trunk/Source/JavaScriptCore

Update iOS port's configuration setting, particularly in Platform.h
https://bugs.webkit.org/show_bug.cgi?id=72187

Reviewed by David Kilzer.

interpreter/Interpreter.h:
- Lower the reentry depth.
runtime/DatePrototype.cpp:
- iOS also uses CF.
wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::IncrementalScavenge):

Update fastmalloc configuration for iOS.

wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveAndCommit):

Added flag.

wtf/Platform.h:
- Update platform configuration for iOS.

3:40 PM Changeset in webkit [100036] by commit-queue@webkit.org

6 edits
4 adds in trunk

Repaint broken when children of filtered SVG elements are updated
https://bugs.webkit.org/show_bug.cgi?id=71733

Patch by Joel Webber <jgw@google.com> on 2011-11-11
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/repaint/filter-child-repaint.svg

rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::layout):

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::layout):

rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::setNeedsLayoutForFilteredContainer):

LayoutTests:

platform/chromium-linux/svg/repaint/filter-child-repaint-expected.png: Added.
platform/chromium-linux/svg/repaint/filter-child-repaint-expected.txt: Added.
svg/repaint/filter-child-repaint.svg: Added.

3:19 PM Changeset in webkit [100035] by timothy@apple.com

2 edits in trunk/Source/WebCore

Don't remove InspectorBackendStub.js in Release builds after it has been
combined into inspector.js. Also remove any *.qrc file on Mac.

https://webkit.org/b/72186

Reviewed by Joseph Pecoraro.

WebCore.xcodeproj/project.pbxproj:

3:15 PM Changeset in webkit [100034] by leviw@chromium.org

6 edits in branches/chromium/874

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Checking that embedded SVG is in an SVG document before negotiating size
with the host document.

Test: svg/as-object/svg-embedded-in-html-in-iframe.html

rendering/svg/RenderSVGRoot.cpp:

(WebCore::isEmbeddedThroughFrameContainingSVGDocument):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

LayoutTests:

Fixing a bug where SVG negotiated size when embedded in html inside an iframe.

platform/chromium/test_expectations.txt: Will update with results on other platforms.
platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
svg/as-object/svg-embedded-in-html-in-iframe.html: Added.

3:06 PM Changeset in webkit [100033] by ap@apple.com

7 edits in trunk

WebProcess should use AppSandbox style quarantine
https://bugs.webkit.org/show_bug.cgi?id=72168
<rdar://problem/10434292>

Reviewed by Darin Adler.

WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox): Just enable it.

2:55 PM Changeset in webkit [100032] by commit-queue@webkit.org

19 edits in trunk/Source

[chromium] Patch that implementing the changes required to allow WebGL
to share its backing store directly with the compositor.
WebGL rendering contexts create and render to FBOs managed by a
DrawingBuffer instance. All PlatformLayer lifetime management is
performed by the DrawingBuffer.
Changes are only relevant to Chromium ports. Functionality is
unchanged for other ports.
https://bugs.webkit.org/show_bug.cgi?id=53201

Patch by Jeff Timanus <twiz@chromium.org> on 2011-11-11
Reviewed by Stephen White.

Source/WebCore:

html/canvas/WebGLRenderingContext.cpp: Construct a DrawingBuffer

during initialization, and forward all framebuffer management calls to
it.
(WebCore::WebGLRenderingContext::create):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::markContextChanged):
(WebCore::WebGLRenderingContext::clearIfComposited):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::paintRenderingResultsToImageData):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::drawingBufferWidth):
(WebCore::WebGLRenderingContext::drawingBufferHeight):
(WebCore::WebGLRenderingContext::bindFramebuffer):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::deleteFramebuffer):
(WebCore::WebGLRenderingContext::disable):
(WebCore::WebGLRenderingContext::enable):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::platformLayer):
(WebCore::WebGLRenderingContext::getBoundFramebufferWidth):
(WebCore::WebGLRenderingContext::getBoundFramebufferHeight):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

html/canvas/WebGLRenderingContext.h:
platform/graphics/GraphicsContext3D.cpp:
platform/graphics/GraphicsContext3D.h: WebGLLayerChromium instances

are no longer tracked by GraphicsContext3D. Callers can now pass a
DrawingBuffer instance to provide access to the WebGLLayerChromium data.

platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::generateColorTexture):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::initialize):
(WebCore::DrawingBuffer::publishToPlatformLayer):
(WebCore::DrawingBuffer::platformLayer):
(WebCore::DrawingBuffer::platformColorBuffer):
(WebCore::DrawingBuffer::framebuffer):
(WebCore::DrawingBuffer::markContextChanged):
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::WebGLLayerChromium):
(WebCore::WebGLLayerChromium::~WebGLLayerChromium):
(WebCore::WebGLLayerChromium::drawsContent):
(WebCore::WebGLLayerChromium::updateCompositorResources):
(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):
(WebCore::WebGLLayerChromium::contentChanged):
(WebCore::WebGLLayerChromium::setDrawingBuffer):
(WebCore::WebGLLayerChromium::context):

platform/graphics/chromium/WebGLLayerChromium.h: WebGLLayerChromium instances

have a raw reference to their owning DrawingBuffer. This reference is set to NULL on
destruction of the DrawingBuffer. This follows the old code, which had the WebGLLayerChromium
refer rawly to a GraphicsContext3D instance, which was also revoked during tear-down of the
GraphicsContext3D.
(WebCore::WebGLLayerChromium::drawingBuffer):

platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

platform/graphics/gpu/DrawingBuffer.cpp: The DrawingBuffer is now the

central point between the GraphicsContext3D, WebGLRenderingContext, and
WebGLLayerChromium classes. GraphicsContext3D, and WebGLLayerChromium only
depend on the DrawingBuffer interface.
(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::clearFramebuffer):
(WebCore::DrawingBuffer::reset):
(WebCore::DrawingBuffer::commit):
(WebCore::DrawingBuffer::multisample):
(WebCore::DrawingBuffer::paintRenderingResultsToImageData):
(WebCore::DrawingBuffer::discardResources):

platform/graphics/gpu/DrawingBuffer.h:

(WebCore::DrawingBuffer::setScissorEnabled):

platform/graphics/gpu/mac/DrawingBufferMac.mm:

(WebCore::DrawingBuffer::DrawingBuffer):

platform/graphics/gpu/qt/DrawingBufferQt.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):

platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

Source/WebKit/chromium:

src/GraphicsContext3DChromium.cpp: GraphicsContext3DPrivate no longer caches

the WebGLLayerChromium instance. Instead, it is accessed via DrawingBuffer instances
passed as arguments to the necessary routines.
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

src/GraphicsContext3DPrivate.h:

2:54 PM Changeset in webkit [100031] by ddkilzer@apple.com

2 edits in trunk/Source/JavaScriptCore

Only define BUILDING_ON_* and TARGETING_* macros when building for Mac OS X
<http://webkit.org/b/72175>

Reviewed by Joseph Pecoraro.

wtf/Platform.h: Move the definition of the BUILDING_ON_* and

TARGETING_* macros to where the WTF_OS_MAC_OS_X macro is defined
so that they're only defined on Mac OS X builds. Also include
Availability.h, which is needed on iOS builds.

2:51 PM Changeset in webkit [100030] by Darin Adler

7 edits in trunk

Remove all releaseRef implementations except for RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=71423

Reviewed by Julien Chaffraix.

Source/JavaScriptCore:

API/JSRetainPtr.h: Removed releaseRef.
wtf/PassRefPtr.h: Removed releaseRef.

Source/WebCore:

platform/win/COMPtr.h: Removed releaseRef.

Tools:

DumpRenderTree/cf/WebArchiveDumpSupport.cpp:

(createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.

2:50 PM Changeset in webkit [100029] by Darin Adler

2 edits in trunk/Source/WebCore

WebCore.xcodeproj/project.pbxproj: Let a newer Xcode update this file.

If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

2:41 PM Changeset in webkit [100028] by ojan@chromium.org

6 edits
3 deletes in trunk

Unreviewed, rolling out r99953.
Caused 4 tests to hit an assert.
https://bugs.webkit.org/show_bug.cgi?id=72163

Source/WebCore:

inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didStartWorkerContext):

inspector/InspectorWorkerAgent.cpp:

inspector/InspectorWorkerAgent.h:

LayoutTests:

http/tests/inspector-enabled/dedicated-workers-list-expected.txt: Removed.
http/tests/inspector-enabled/dedicated-workers-list.html: Removed.
http/tests/inspector-enabled/resources/dedicated-worker.js: Removed.
platform/chromium/test_expectations.txt:

2:37 PM Changeset in webkit [100027] by scheib@chromium.org

5 edits in trunk/Source/WebCore

Unreviewed, rolling out r100024.
http://trac.webkit.org/changeset/100024
https://bugs.webkit.org/show_bug.cgi?id=72158

Broke chromium build

dom/MouseEvent.cpp:

(WebCore::MouseEvent::initMouseEvent):
(WebCore::MouseEventDispatchMediator::dispatchEvent):

dom/MouseEvent.h:
dom/MouseEvent.idl:
dom/MouseRelatedEvent.h:

2:35 PM Changeset in webkit [100026] by ojan@chromium.org

2 edits in trunk/LayoutTests

Fixup wrong expectations from http://trac.webkit.org/changeset/100008.
Pull in expectations from downstream expectations due to V8 roll.
Add new expectation for failure.

platform/chromium/test_expectations.txt:

2:30 PM Changeset in webkit [100025] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/efl

[EFL] Remove unused flags in pre-render implementation
https://bugs.webkit.org/show_bug.cgi?id=65504

The high priority pre-render flag was not used anywhere,
so we can get rid of the whole concept and always consider the requests have low priority

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2011-11-11
Reviewed by Daniel Bates.

ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_pre_render_request_add):
(ewk_tiled_backing_store_pre_render_region):
(ewk_tiled_backing_store_pre_render_relative_radius):

2:29 PM Changeset in webkit [100024] by scheib@chromium.org

5 edits in trunk/Source/WebCore

Mouse Lock: MouseEvent IDL
https://bugs.webkit.org/show_bug.cgi?id=72158

Reviewed by Dimitri Glazkov.

Tests for movementX/Y pending mock mouse lock test infrastructure.

dom/MouseEvent.cpp:

(WebCore::MouseEvent::initMouseEvent):
(WebCore::MouseEventDispatchMediator::dispatchEvent):

dom/MouseEvent.h:
dom/MouseEvent.idl:
dom/MouseRelatedEvent.h:

(WebCore::MouseRelatedEvent::movementX):
(WebCore::MouseRelatedEvent::movementY):

2:20 PM Changeset in webkit [100023] by ojan@chromium.org

6 edits in trunk/LayoutTests

Unreviewed, rolling out r99990.
http://trac.webkit.org/changeset/99990
https://bugs.webkit.org/show_bug.cgi?id=72134

Caused worker tests to fail on the chromium bots.

fast/workers/resources/worker-replace-self.js:

(worker.onmessage):

fast/workers/worker-call.html:
fast/workers/worker-close.html:
fast/workers/worker-messageport-gc.html:
fast/workers/worker-replace-self.html:

2:19 PM Changeset in webkit [100022] by Beth Dakin

2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=72167
REGRESSION: Scroll position not restored on back after scroll
-and corresponding-
<rdar://problem/10410684>

Reviewed by Simon Fraser.

We can't just return early if we are not on an active page.
notifyPositionChanged() is called when a page is going into the page cache (and
therefore when not on an active page). We should not notify AppKit that the page
has scrolled in that case, but we still need to call
ScrollAnimator::notifyPositionChanged();. So this patch removes the early return,
and replaces it with a conditional around the relevant code.

platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::notifyPositionChanged):

2:18 PM Changeset in webkit [100021] by commit-queue@webkit.org

3 edits
3 adds in trunk/Source/WebCore

Added TileCairo and TiledBackingStoreBackendCairo files
https://bugs.webkit.org/show_bug.cgi?id=71350

Patch by Julien Chaffraix <jchaffraix@codeaurora.org>, Zaheer Ahmad <zahimad@codeaurora.org>, Joone Hur <joone.hur@collabora.co.uk>, Tomasz Morawski <t.morawski@samsung.com> on 2011-11-11
Reviewed by Martin Robinson.

Added TileCairo and TiledBackingStoreBackend files needed by Tiled Backing Store implementation that uses cairo
library eg. EFL and Gtk WebKit port.

This patch contains some parts of rebased and updated code from 45423 bug. Originals authors of the code are:

Julien Chaffraix <jchaffraix@codeaurora.org>
Zaheer Ahmad <zahmad@codeaurora.org>
Joone Hur <joone.hur@collabora.co.uk>

platform/graphics/cairo/RefPtrCairo.cpp: Added support of RefPtr for cairo_region object.

(WTF::refIfNotNull): New refIfNotNull function for cairo_region object.
(WTF::derefIfNotNull): New derefIfNotNull function for cairo_region object.

platform/graphics/cairo/RefPtrCairo.h: Added support of RefPtr for cairo_region object.
platform/graphics/cairo/TileCairo.cpp: Added a new file. Implementation of TileCairo class.

(WebCore::TileCairo::TileCairo):
(WebCore::TileCairo::~TileCairo):
(WebCore::TileCairo::isDirty):
(WebCore::TileCairo::isReadyToPaint):
(WebCore::TileCairo::invalidate):
(WebCore::TileCairo::updateBackBuffer):
(WebCore::TileCairo::swapBackBufferToFront):
(WebCore::TileCairo::paint):
(WebCore::TileCairo::resize):

platform/graphics/cairo/TileCairo.h: Added a new file. Implementation of TileCairo class.

(WebCore::TileCairo::create):
(WebCore::TileCairo::coordinate):
(WebCore::TileCairo::rect):

platform/graphics/cairo/TiledBackingStoreBackendCairo.cpp: Added a new file. Implementation of

TiledBackingStoreBackend methods.
(WebCore::TiledBackingStoreBackend::createTile):
(WebCore::checkeredSurface): Helper function that creates checkered surface (see below function)
(WebCore::TiledBackingStoreBackend::paintCheckerPattern): Function is used to draw a place holder when tile no
exist or it is not ready to paint yet. The checkered surface is used here.

2:15 PM Changeset in webkit [100020] by Darin Adler

2 edits in trunk/Source/JavaScriptCore

JavaScriptCore.xcodeproj/project.pbxproj: Let a newer Xcode update this file.

If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

2:15 PM Changeset in webkit [100019] by Darin Adler

2 edits in trunk/Source/ThirdParty/ANGLE

ANGLE.xcodeproj/project.pbxproj: Let a newer Xcode update this file.

If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

2:15 PM Changeset in webkit [100018] by Darin Adler

2 edits in trunk/Source/WebKit2

WebKit2.xcodeproj/project.pbxproj: Let a newer Xcode update this file.

If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

2:14 PM Changeset in webkit [100017] by Darin Adler

2 edits in trunk/Source/WebKit

WebKit.xcodeproj/project.pbxproj: Let a newer Xcode update this file.

If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

2:07 PM Changeset in webkit [100016] by leviw@chromium.org

19 edits in branches/subpixellayout/Source

Reverting Page to integers

2:02 PM Changeset in webkit [100015] by commit-queue@webkit.org

11 edits in trunk/LayoutTests

Update expected results for composited canvas operations
https://bugs.webkit.org/show_bug.cgi?id=71995

Patch by Ben Wells <benwells@chromium.org> on 2011-11-11
Reviewed by Kenneth Russell.

canvas/philip/tests/2d.composite.uncovered.image.copy-expected.txt:
canvas/philip/tests/2d.composite.uncovered.image.destination-atop-expected.txt:
canvas/philip/tests/2d.composite.uncovered.image.destination-in-expected.txt:
canvas/philip/tests/2d.composite.uncovered.image.source-in-expected.txt:
canvas/philip/tests/2d.composite.uncovered.image.source-out-expected.txt:
canvas/philip/tests/2d.composite.uncovered.pattern.copy-expected.txt:
platform/chromium/test_expectations.txt:
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:

2:01 PM Changeset in webkit [100014] by jchaffraix@webkit.org

2 edits in trunk/Source/WebCore

Remove unneeded frame check in FrameView::detachCustomScrollbars
https://bugs.webkit.org/show_bug.cgi?id=71980

Reviewed by Anders Carlsson.

Change covered by the existing tests in scrollbars/.

page/FrameView.cpp:

(WebCore::FrameView::detachCustomScrollbars):
Remove the leftover check that was forgotten by the different refactoring.

1:58 PM Changeset in webkit [100013] by commit-queue@webkit.org

10 edits
2 adds in trunk

Access key should work on all elements.
https://bugs.webkit.org/show_bug.cgi?id=71854

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-11-11
Reviewed by Adam Barth.

Source/WebCore:

As per specification http://dev.w3.org/html5/spec/Overview.html#elements-in-the-dom
says All HTML elements can have the accesskey content attribute set. Adding "accessKey"
attribute idl file as [Reflect].

Test: fast/forms/access-key-for-all-elements.html

html/HTMLAnchorElement.idl: Removed redundant IDL attribute entries.
html/HTMLAreaElement.idl: Ditto.
html/HTMLButtonElement.idl: Ditto.
html/HTMLElement.idl: Added accessKey IDL attribute.
html/HTMLInputElement.idl: Ditto.
html/HTMLLabelElement.idl: Ditto.
html/HTMLLegendElement.idl: Ditto.
html/HTMLTextAreaElement.idl: Ditto.

LayoutTests:

Added test case to check whether all elements can also have accessKey attribute.

fast/forms/access-key-for-all-elements-expected.txt: Added.
fast/forms/access-key-for-all-elements.html: Added.

1:42 PM Changeset in webkit [100012] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

Remove color space information from canvas composited drawImage tests
https://bugs.webkit.org/show_bug.cgi?id=71970

Patch by Ben Wells <benwells@chromium.org> on 2011-11-11
Reviewed by Stephen White.

fast/canvas/canvas-composite-canvas.html:
fast/canvas/canvas-composite-image.html:

1:25 PM Changeset in webkit [100011] by ojan@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r100010.
http://trac.webkit.org/changeset/100010
https://bugs.webkit.org/show_bug.cgi?id=72172

"Broke gclient syncing on the chromium bots." (Requested by
ojan on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

DEPS:

1:05 PM Changeset in webkit [100010] by ojan@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

DEPS:

12:52 PM Changeset in webkit [100009] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

Assertion failed if text field is cleared while drag&drop.
https://bugs.webkit.org/show_bug.cgi?id=61008

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-11-11
Reviewed by Ryosuke Niwa.

Test to drag-drop text from one input element to another clearing the first input
element. Fixed in Change set - http://trac.webkit.org/changeset/99085

fast/events/drag-text-with-clear-expected.txt: Added.
fast/events/drag-text-with-clear.html: Added.

12:51 PM Changeset in webkit [100008] by commit-queue@webkit.org

6 edits in trunk/LayoutTests

Re-enable layout test comparisons on chromium-mac-leopard.
https://bugs.webkit.org/show_bug.cgi?id=68270

Patch by Elliot Poger <epoger@google.com> on 2011-11-11
Reviewed by Adam Barth.

platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png:
platform/chromium-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png: Added.
platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
platform/chromium/test_expectations.txt:

12:48 PM Changeset in webkit [100007] by jochen@chromium.org

3 edits in trunk/LayoutTests

Removing the 4th test in factory-deletedatabase-interactions.html
https://bugs.webkit.org/show_bug.cgi?id=72037

Reviewed by Ojan Vafai.

Removing the test since it's testing not-yet-written code. Once the new
code is written it will obviously come with the appropriate tests.

storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
storage/indexeddb/factory-deletedatabase-interactions.html:

12:40 PM Changeset in webkit [100006] by mhahnenberg@apple.com

96 edits in trunk/Source

Add jsCast to replace static_cast
https://bugs.webkit.org/show_bug.cgi?id=72071

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::toStringCallback):
(JSC::JSCallbackFunction::valueOfCallback):

API/JSCallbackObject.h:

(JSC::JSCallbackObject::visitChildren):

API/JSCallbackObjectFunctions.h:

(JSC::::className):
(JSC::::getOwnPropertySlot):
(JSC::::getOwnPropertyDescriptor):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::deletePropertyByIndex):
(JSC::::getConstructData):
(JSC::::hasInstance):
(JSC::::getCallData):
(JSC::::getOwnPropertyNames):

debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::visitChildren):
(JSC::DebuggerActivation::className):
(JSC::DebuggerActivation::getOwnPropertySlot):
(JSC::DebuggerActivation::put):
(JSC::DebuggerActivation::putWithAttributes):
(JSC::DebuggerActivation::deleteProperty):
(JSC::DebuggerActivation::getOwnPropertyNames):
(JSC::DebuggerActivation::getOwnPropertyDescriptor):
(JSC::DebuggerActivation::defineGetter):
(JSC::DebuggerActivation::defineSetter):

runtime/Arguments.cpp:

(JSC::Arguments::visitChildren):
(JSC::Arguments::getOwnPropertySlotByIndex):
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::getOwnPropertyNames):
(JSC::Arguments::putByIndex):
(JSC::Arguments::put):
(JSC::Arguments::deletePropertyByIndex):
(JSC::Arguments::deleteProperty):

runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getOwnPropertySlot):
(JSC::ArrayConstructor::getOwnPropertyDescriptor):

runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertySlot):
(JSC::ArrayPrototype::getOwnPropertyDescriptor):

runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::getOwnPropertySlot):
(JSC::BooleanPrototype::getOwnPropertyDescriptor):

runtime/DateConstructor.cpp:

(JSC::DateConstructor::getOwnPropertySlot):
(JSC::DateConstructor::getOwnPropertyDescriptor):

runtime/DatePrototype.cpp:

(JSC::DatePrototype::getOwnPropertySlot):
(JSC::DatePrototype::getOwnPropertyDescriptor):

runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::getOwnPropertySlot):
(JSC::ErrorPrototype::getOwnPropertyDescriptor):

runtime/Executable.cpp:

(JSC::ExecutableBase::clearCode):
(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):

runtime/GetterSetter.cpp:

(JSC::GetterSetter::visitChildren):

runtime/JSActivation.cpp:

(JSC::JSActivation::visitChildren):
(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::getOwnPropertySlot):
(JSC::JSActivation::put):
(JSC::JSActivation::putWithAttributes):

runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertySlotByIndex):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::putByIndex):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::deletePropertyByIndex):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::visitChildren):

runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::hasInstance):
(JSC::JSBoundFunction::visitChildren):

runtime/JSByteArray.cpp:

(JSC::JSByteArray::getOwnPropertySlot):
(JSC::JSByteArray::getOwnPropertyDescriptor):
(JSC::JSByteArray::getOwnPropertySlotByIndex):
(JSC::JSByteArray::put):
(JSC::JSByteArray::putByIndex):
(JSC::JSByteArray::getOwnPropertyNames):

runtime/JSCell.h:

(JSC::JSCell::visitChildren):
(JSC::jsCast):

runtime/JSFunction.cpp:

(JSC::JSFunction::visitChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnPropertyNames):
(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::getConstructData):

runtime/JSGlobalData.cpp:

(JSC::StackPreservingRecompiler::operator()):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::put):
(JSC::JSGlobalObject::putWithAttributes):
(JSC::JSGlobalObject::defineGetter):
(JSC::JSGlobalObject::defineSetter):
(JSC::JSGlobalObject::visitChildren):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):
(JSC::JSGlobalObject::clearRareData):

runtime/JSGlobalThis.cpp:

(JSC::JSGlobalThis::visitChildren):

runtime/JSONObject.cpp:

(JSC::JSONObject::getOwnPropertySlot):
(JSC::JSONObject::getOwnPropertyDescriptor):

runtime/JSObject.cpp:

(JSC::JSObject::finalize):
(JSC::JSObject::visitChildren):
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::put):
(JSC::JSObject::putByIndex):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::deletePropertyByIndex):

runtime/JSObject.h:

(JSC::JSObject::getOwnPropertySlot):

runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::visitChildren):

runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::visitChildren):
(JSC::JSStaticScopeObject::put):
(JSC::JSStaticScopeObject::putWithAttributes):
(JSC::JSStaticScopeObject::getOwnPropertySlot):

runtime/JSString.cpp:

(JSC::JSString::visitChildren):
(JSC::JSString::toThisObject):
(JSC::JSString::getOwnPropertySlot):
(JSC::JSString::getOwnPropertySlotByIndex):

runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::deleteProperty):
(JSC::JSVariableObject::getOwnPropertyNames):

runtime/JSWrapperObject.cpp:

(JSC::JSWrapperObject::visitChildren):

runtime/MathObject.cpp:

(JSC::MathObject::getOwnPropertySlot):
(JSC::MathObject::getOwnPropertyDescriptor):

runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::visitChildren):

runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::getOwnPropertyDescriptor):

runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::getOwnPropertySlot):
(JSC::NumberPrototype::getOwnPropertyDescriptor):

runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getOwnPropertySlot):
(JSC::ObjectConstructor::getOwnPropertyDescriptor):

runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::getOwnPropertySlotByIndex):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):

runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getOwnPropertySlot):
(JSC::RegExpConstructor::getOwnPropertyDescriptor):
(JSC::RegExpConstructor::put):

runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::getOwnPropertySlot):
(JSC::RegExpMatchesArray::getOwnPropertySlotByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
(JSC::RegExpMatchesArray::put):
(JSC::RegExpMatchesArray::putByIndex):
(JSC::RegExpMatchesArray::deleteProperty):
(JSC::RegExpMatchesArray::deletePropertyByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyNames):

runtime/RegExpObject.cpp:

(JSC::RegExpObject::visitChildren):
(JSC::RegExpObject::getOwnPropertySlot):
(JSC::RegExpObject::getOwnPropertyDescriptor):
(JSC::RegExpObject::put):

runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::getOwnPropertySlot):
(JSC::RegExpPrototype::getOwnPropertyDescriptor):

runtime/ScopeChain.cpp:

(JSC::ScopeChainNode::visitChildren):

runtime/StringConstructor.cpp:

(JSC::StringConstructor::getOwnPropertySlot):
(JSC::StringConstructor::getOwnPropertyDescriptor):

runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertySlot):
(JSC::StringObject::getOwnPropertySlotByIndex):
(JSC::StringObject::getOwnPropertyDescriptor):
(JSC::StringObject::deleteProperty):
(JSC::StringObject::getOwnPropertyNames):

runtime/StringPrototype.cpp:

(JSC::StringPrototype::getOwnPropertySlot):
(JSC::StringPrototype::getOwnPropertyDescriptor):

runtime/Structure.cpp:

(JSC::Structure::visitChildren):

runtime/StructureChain.cpp:

(JSC::StructureChain::visitChildren):

Source/JavaScriptGlue:

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

UserObjectImp.cpp:

(UserObjectImp::getCallData):
(UserObjectImp::getOwnPropertyNames):
(UserObjectImp::getOwnPropertySlot):
(UserObjectImp::put):
(UserObjectImp::visitChildren):

Source/WebCore:

No new tests.

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

bindings/js/JSAttrCustom.cpp:

(WebCore::JSAttr::visitChildren):

bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContext::visitChildren):

bindings/js/JSCSSRuleCustom.cpp:

(WebCore::JSCSSRule::visitChildren):

bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::visitChildren):

bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::toHTMLCanvasStyle):

bindings/js/JSCanvasRenderingContextCustom.cpp:

(WebCore::JSCanvasRenderingContext::visitChildren):

bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::visitChildren):

bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::getOwnPropertyNames):
(WebCore::JSDOMStringMap::deleteProperty):

bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::toThisObject):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::visitChildren):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::deleteProperty):
(WebCore::JSDOMWindow::getPropertyNames):
(WebCore::JSDOMWindow::getOwnPropertyNames):
(WebCore::JSDOMWindow::defineGetter):
(WebCore::JSDOMWindow::defineSetter):
(WebCore::JSDOMWindow::defineOwnProperty):

bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::className):
(WebCore::JSDOMWindowShell::getOwnPropertySlot):
(WebCore::JSDOMWindowShell::getOwnPropertyDescriptor):
(WebCore::JSDOMWindowShell::put):
(WebCore::JSDOMWindowShell::putWithAttributes):
(WebCore::JSDOMWindowShell::defineOwnProperty):
(WebCore::JSDOMWindowShell::deleteProperty):
(WebCore::JSDOMWindowShell::getPropertyNames):
(WebCore::JSDOMWindowShell::getOwnPropertyNames):
(WebCore::JSDOMWindowShell::defineGetter):
(WebCore::JSDOMWindowShell::defineSetter):

bindings/js/JSHTMLAppletElementCustom.cpp:

(WebCore::JSHTMLAppletElement::getCallData):

bindings/js/JSHTMLEmbedElementCustom.cpp:

(WebCore::JSHTMLEmbedElement::getCallData):

bindings/js/JSHTMLObjectElementCustom.cpp:

(WebCore::JSHTMLObjectElement::getCallData):

bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::deleteProperty):
(WebCore::JSHistory::getOwnPropertyNames):

bindings/js/JSJavaScriptAudioNodeCustom.cpp:

(WebCore::JSJavaScriptAudioNode::visitChildren):

bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::deleteProperty):
(WebCore::JSLocation::getOwnPropertyNames):

bindings/js/JSMessageChannelCustom.cpp:

(WebCore::JSMessageChannel::visitChildren):

bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::visitChildren):

bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::visitChildren):

bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::visitChildren):

bindings/js/JSNodeFilterCustom.cpp:

(WebCore::JSNodeFilter::visitChildren):

bindings/js/JSNodeIteratorCustom.cpp:

(WebCore::JSNodeIterator::visitChildren):

bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::visitChildren):

bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorker::visitChildren):

bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::getOwnPropertyNames):

bindings/js/JSStyleSheetCustom.cpp:

(WebCore::JSStyleSheet::visitChildren):

bindings/js/JSTreeWalkerCustom.cpp:

(WebCore::JSTreeWalker::visitChildren):

bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::JSWebGLRenderingContext::visitChildren):

bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::visitChildren):

bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::visitChildren):

bindings/js/JSXPathResultCustom.cpp:

(WebCore::JSXPathResult::visitChildren):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::getOwnPropertySlot):
(WebCore::JSTestInterface::getOwnPropertyDescriptor):

bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestMediaQueryListListener::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListener::getOwnPropertyDescriptor):

bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructor::getOwnPropertySlot):
(WebCore::JSTestNamedConstructor::getOwnPropertyDescriptor):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjPrototype::getOwnPropertySlot):
(WebCore::JSTestObjPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestObj::getOwnPropertySlot):
(WebCore::JSTestObj::getOwnPropertyDescriptor):
(WebCore::JSTestObj::put):
(WebCore::JSTestObj::visitChildren):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlot):
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertyDescriptor):

bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::getCallData):
(JSC::Bindings::ObjcFallbackObjectImp::defaultValue):

bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObject::visitChildren):

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor):

bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertyNames):
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertyDescriptor):
(JSC::RuntimeArray::getOwnPropertySlotByIndex):
(JSC::RuntimeArray::put):
(JSC::RuntimeArray::putByIndex):

bridge/runtime_method.cpp:

(JSC::RuntimeMethod::getOwnPropertySlot):
(JSC::RuntimeMethod::getOwnPropertyDescriptor):

bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::getOwnPropertySlot):
(JSC::Bindings::RuntimeObject::getOwnPropertyDescriptor):
(JSC::Bindings::RuntimeObject::put):
(JSC::Bindings::RuntimeObject::defaultValue):
(JSC::Bindings::RuntimeObject::getCallData):
(JSC::Bindings::RuntimeObject::getConstructData):
(JSC::Bindings::RuntimeObject::getOwnPropertyNames):

Source/WebKit2:

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getCallData):
(WebKit::JSNPObject::getConstructData):
(WebKit::JSNPObject::getOwnPropertySlot):
(WebKit::JSNPObject::getOwnPropertyDescriptor):
(WebKit::JSNPObject::put):
(WebKit::JSNPObject::deleteProperty):
(WebKit::JSNPObject::deletePropertyByIndex):
(WebKit::JSNPObject::getOwnPropertyNames):

12:31 PM Changeset in webkit [100005] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

Enable DFG JIT for ARMv7/iOS.

Rubber stamped by Oliver Hunt.

wtf/Platform.h:
- enable DFG JIT for ARMv7/iOS.

12:24 PM Changeset in webkit [100004] by scheib@chromium.org

6 edits
3 deletes in trunk/Source/WebCore

Unreviewed, rolling out r99994.
http://trac.webkit.org/changeset/99994
https://bugs.webkit.org/show_bug.cgi?id=72150

Broke chromium windows build

WebCore.gypi:
bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitLockMouseEnabled):
(WebCore::RuntimeEnabledFeatures::webkitUnlockMouseEnabled):
(WebCore::RuntimeEnabledFeatures::webkitMouseLockedEnabled):

page/MouseLockable.cpp: Removed.
page/MouseLockable.h: Removed.
page/MouseLockable.idl: Removed.
page/Navigator.cpp:
page/Navigator.h:
page/Navigator.idl:

11:49 AM Changeset in webkit [100003] by adamk@chromium.org

3 edits in trunk/Source/WebCore

[v8] Remove unused V8Proxy::executingScript method
https://bugs.webkit.org/show_bug.cgi?id=72160

Reviewed by Nate Chapin.

bindings/v8/V8Proxy.cpp:
bindings/v8/V8Proxy.h:

11:47 AM Changeset in webkit [100002] by rniwa@webkit.org

3 edits in trunk/Tools

Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
https://bugs.webkit.org/show_bug.cgi?id=72090

Reviewed by Eric Seidel.

Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.

yay! r100002.

Scripts/webkitpy/common/checkout/changelog.py:
Scripts/webkitpy/common/checkout/changelog_unittest.py:

11:45 AM Changeset in webkit [100001] by beidson@apple.com

1 edit in trunk/Source/WebCore/ChangeLog

Rubberstamped by Andy Estes

100,000!
Congratulations WebKit, and here's to hundreds of thousands more!

ChangeLog: Point out revision 100,000.

11:45 AM Changeset in webkit [100000] by Csaba Osztrogonác

1 edit in trunk/Source/ThirdParty/ChangeLog

100,000 !!!

Reviewed by Zoltan Herczeg.

ChangeLog: Point out revision 100,000.

11:45 AM Changeset in webkit [99999] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

<http://webkit.org/b/71921> Remove use of strcpy in KURL

Reviewed by Antti Koivisto.

platform/KURL.cpp:

(WebCore::KURL::init): Replace strcpy() with strncpy().

11:41 AM Changeset in webkit [99998] by tony@chromium.org

2 edits in trunk/Tools

Remove --force from gclient sync. The bots seem to have made it past
the update step.

Scripts/update-webkit:

11:32 AM Changeset in webkit [99997] by mhahnenberg@apple.com

13 edits in trunk/Source

De-virtualize supportsProfiling, supportsRichSourceInfo, shouldInterruptScript in JSGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=72035

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

De-virtualized the methods through the use of a new method table just for JSGlobalObject and subclasses.

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
bytecompiler/BytecodeGenerator.cpp: Changed call sites to use the new GlobalObjectMethodTable.

(JSC::BytecodeGenerator::BytecodeGenerator):

interpreter/Interpreter.cpp: Ditto.

(JSC::Interpreter::execute):

runtime/JSGlobalObject.cpp: Added a static const GlobalObjectMethodTable with the correct function pointers.
runtime/JSGlobalObject.h: Added a field in JSGlobalObject to keep track of the current method table.

(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::globalObjectMethodTable): The new struct to contain the function pointers.
(JSC::JSGlobalObject::supportsProfiling): Made static to put in the method table.
(JSC::JSGlobalObject::supportsRichSourceInfo): Ditto.
(JSC::JSGlobalObject::shouldInterruptScript): Ditto.

runtime/TimeoutChecker.cpp: Changed call sites to use the new GlobalObjectMethodTable for lookup.

(JSC::TimeoutChecker::didTimeOut):

Source/WebCore:

No new tests.

bindings/js/JSDOMGlobalObject.cpp: Changed constructor to support passing new GlobalObjectMethodTable pointer to parent class.

(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):

bindings/js/JSDOMGlobalObject.h:
bindings/js/JSDOMWindowBase.cpp: Added static const GlobalObjectMethodTable and filled it in with the proper function pointers.

(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::supportsProfiling): Changed to static to put in the method table.
(WebCore::JSDOMWindowBase::supportsRichSourceInfo): Ditto.
(WebCore::JSDOMWindowBase::shouldInterruptScript): Ditto.

bindings/js/JSDOMWindowBase.h:

11:28 AM Changeset in webkit [99996] by tony@chromium.org

2 edits in trunk/Tools

Add --force to gclient sync. Once the cq bots cycle, we can remove
this since it slows down the normal sync.

Scripts/update-webkit:

11:14 AM Changeset in webkit [99995] by ojan@chromium.org

7 edits in trunk

Unreviewed, rolling out r99869.
http://trac.webkit.org/changeset/99869
https://bugs.webkit.org/show_bug.cgi?id=72157

"Caused a ~400% perf regression on the Chromium intl1 page
cyclers" (Requested by ojan on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

Source/WebCore:

dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):

dom/Document.h:
html/CollectionType.h:

LayoutTests:

fast/dom/gc-9-expected.txt:
fast/dom/gc-9.html:

11:09 AM Changeset in webkit [99994] by scheib@chromium.org

6 edits
3 adds in trunk/Source/WebCore

Mouse Lock Navigator IDL
https://bugs.webkit.org/show_bug.cgi?id=72150

Reviewed by Dimitri Glazkov.

Tests require mocking (similar to geolocation) that will be built after this.

WebCore.gypi:
bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):

page/MouseLockable.cpp: Added.

(WebCore::MouseLockable::MouseLockable):
(WebCore::MouseLockable::~MouseLockable):
(WebCore::MouseLockable::webkitLock):
(WebCore::MouseLockable::webkitUnlock):
(WebCore::MouseLockable::webkitIsLocked):

page/MouseLockable.h: Added.

(WebCore::MouseLockable::create):

page/MouseLockable.idl: Added.
page/Navigator.cpp:

(WebCore::Navigator::webkitPointer):

page/Navigator.h:
page/Navigator.idl:

11:07 AM Changeset in webkit [99993] by mhahnenberg@apple.com

5 edits in trunk/Source

De-virtualize JSGlobalObject::allowsAccessFrom
https://bugs.webkit.org/show_bug.cgi?id=71969

Reviewed by Darin Adler.

Source/JavaScriptCore:

runtime/JSGlobalObject.h: Removed allowsAccessFrom from JSGlobalObject since it is exclusive to

JSDOMWindowBase and WebScriptObject.

Source/WebCore:

No new tests.

Since allowsAccessFrom is only used by WebScriptObject, we know that we'll always have a
JSDOMWindowBase, so we can simply have allowsAccessFrom to live in JSDOMWindowBase rather
than JSGlobalObject.

bindings/js/JSDOMWindowBase.h: De-virtualized allowsAccessFrom.
bindings/objc/WebScriptObject.mm:

(-[WebScriptObject _isSafeScript]): Added a cast from a JSGlobalObject to a JSDOMWindowBase in
order to call the allowsAccessFrom method.

10:56 AM Changeset in webkit [99992] by adamk@chromium.org

17 edits in trunk

[MutationObservers] Support attributeFilter for attribute mutations
https://bugs.webkit.org/show_bug.cgi?id=70860

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-11
Reviewed by Dimitri Glazkov.

Source/WebCore:

This patch adds an attributeFilter to the MutationObserverRegistration and
adds support for only observing attributes whose name are in the provided
filter set (array of strings).

Test: fast/mutation/observe-attributes.html.

bindings/js/JSWebKitMutationObserverCustom.cpp:

(WebCore::JSWebKitMutationObserver::observe):

bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::get):

bindings/v8/OptionsObject.h:
bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::observeCallback):

dom/Element.cpp:

(WebCore::enqueueAttributesMutationRecord):

dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::resetObservation):
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):
(WebCore::MutationObserverRegistration::caseInsensitiveAttributeFilter):

dom/MutationObserverRegistration.h:
dom/Node.cpp:

(WebCore::Node::collectMatchingObserversForMutation):
(WebCore::Node::getRegisteredMutationObserversOfType):

dom/Node.h:
dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::observe):

dom/WebKitMutationObserver.h:

LayoutTests:

fast/mutation/observe-attributes-expected.txt:
fast/mutation/observe-attributes.html:

10:40 AM Changeset in webkit [99991] by tony@chromium.org

2 edits in trunk/Tools

When --force is used, also use --reset
https://bugs.webkit.org/show_bug.cgi?id=72129

Patch by Marc-Antoine Ruel <maruel@chromium.org> on 2011-11-11
Reviewed by Dimitri Glazkov.

Scripts/update-webkit-chromium:

10:35 AM Changeset in webkit [99990] by tony@chromium.org

6 edits in trunk/LayoutTests

Speculative fix for a few worker tests.
https://bugs.webkit.org/show_bug.cgi?id=72134

Looking at the recent failures, it looks like the test starts and completes
before the page is done loading completely (the test output is correct except
for the HTML on top of the files). So start the tests from an onload callback so
that the plain HTML text also gets printed correctly.

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-11-11
Reviewed by Tony Chang.

fast/workers/resources/worker-replace-self.js:

(startTest.worker.onmessage):
(startTest):

fast/workers/worker-call.html:
fast/workers/worker-close.html:
fast/workers/worker-messageport-gc.html:
fast/workers/worker-replace-self.html:

10:30 AM Changeset in webkit [99989] by tony@chromium.org

3 edits in trunk/Tools

allow two chromium drivers to run at the same time in NRWT
https://bugs.webkit.org/show_bug.cgi?id=72067

Reviewed by Dirk Pranke.

Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on

posix prevents the subprocesses from sharing the same fd for stdin.
Sharing the same fd prevents us from closing the files unless all references
to the fd are closed.

Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition

to adding a test for this, speed up a test (from 3sec to 0) by fixing
the timeout override. It looks like it regressed in r95875.

10:28 AM Changeset in webkit [99988] by vsevik@chromium.org

9 edits
6 adds in trunk

Application cache status indicator gets stuck at DOWNLOADING after a failure
https://bugs.webkit.org/show_bug.cgi?id=60793

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file.html

inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
(WebCore::InspectorApplicationCacheAgent::restore):
(WebCore::InspectorApplicationCacheAgent::enable):

inspector/InspectorApplicationCacheAgent.h:
inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::restoreInspectorStateFromCookie):

inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype.updateStatus):

LayoutTests:

http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt:
http/tests/inspector/resource-tree/appcache-iframe-manifests.html:
http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt: Added.
http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file.html: Added.
http/tests/inspector/resource-tree/appcache-test.js: Added.

(createAndNavigateIFrame):
(removeIFrame):
(navigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame.frameDetached):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCache):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheTree):
(initialize_ApplicationCacheTest.InspectorTest.frameIdToString):
(initialize_ApplicationCacheTest.InspectorTest.applicationCacheStatusToString):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel):
(initialize_ApplicationCacheTest.InspectorTest.waitForFrameManifestURLAndStatus):
(initialize_ApplicationCacheTest.InspectorTest.startApplicationCacheStatusesRecording):
(initialize_ApplicationCacheTest.InspectorTest.ensureFrameManifestStatusEventReceived):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords):
(initialize_ApplicationCacheTest):

http/tests/inspector/resource-tree/resources/manifest.php:
platform/chromium/http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Added.
platform/chromium/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt: Added.

10:20 AM Changeset in webkit [99987] by tonyg@chromium.org

2 edits in trunk/LayoutTests

[chromium] failing media/track/tracklist-is-reachable
https://bugs.webkit.org/show_bug.cgi?id=72149

platform/chromium/test_expectations.txt: Expect test to fail for now.

10:03 AM Changeset in webkit [99986] by timothy@apple.com

2 edits in trunk/Source/WebKit2

Only use the textured window style mask when there is no override inspector page.

https://webkit.org/b/72142

Reviewed by Dan Bernstein.

UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformOpen): Don't set NSTexturedBackgroundWindowMask if
there is an override inspector page. Make setAutorecalculatesContentBorderThickness:,
setContentBorderThickness: and WKNSWindowMakeBottomCornersSquare conditional.

9:58 AM Changeset in webkit [99985] by tonyg@chromium.org

2 edits in trunk/LayoutTests

Expect chromium to pass this test after r99958.

platform/chromium/fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:

9:33 AM Changeset in webkit [99984] by eric.carlson@apple.com

28 edits
8 adds in trunk

Implement TextTrackList and the textTracks attribute of HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=71123

Reviewed by Sam Weinig.

Source/WebCore:

Test: media/track/track-add-track.html

media/track/tracklist-is-reachable.html

CMakeLists.txt: Add new files for TextTrackList.
DerivedSources.cpp: Ditto.
DerivedSources.make: Ditto.
DerivedSources.pri: Ditto.
GNUmakefile.list.am: Ditto.
Target.pri: Ditto.
WebCore.gypi: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
bindings/js/JSBindingsAllInOne.cpp: Ditto.

bindings/js/JSTextTrackListCustom.cpp: Added.

(WebCore::JSTextTrackListOwner::isReachableFromOpaqueRoots):

dom/EventTargetFactory.in: Add TextTrackList, conditional on VIDEO_TRACK.

html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::createForJSConstructor): Update for scheduleLoad change.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement): Update for m_textTracks change from

generic Vector to TextTrackList.

(WebCore::HTMLMediaElement::attributeChanged): Ditto.
(WebCore::HTMLMediaElement::insertedIntoDocument): Update for scheduleLoad change.
(WebCore::HTMLMediaElement::scheduleLoad): Add a parameter so caller can specify if

the main resource or a text track should be loaded.

(WebCore::HTMLMediaElement::loadTimerFired): Update to allow text track loading.
(WebCore::HTMLMediaElement::loadInternal): Don't call loadTextTracks.
(WebCore::HTMLMediaElement::isSafeToLoadURL): Log when CSP denies load.
(WebCore::HTMLMediaElement::playInternal): Update for scheduleLoad change.
(WebCore::HTMLMediaElement::pauseInternal): Ditto.
(WebCore::HTMLMediaElement::addTrack): Update for m_textTracks change from

generic Vector to TextTrackList.

(WebCore::HTMLMediaElement::addTextTrack): New, add track to m_textTracks and configure.
(WebCore::HTMLMediaElement::configureTextTracks): New, add comments about what this should

do eventually.

(WebCore::HTMLMediaElement::textTracks): New, return TextTrackList.
(WebCore::HTMLMediaElement::trackWasAdded): Bail if runtime feature is not enabled, schedule

asynchronous text track load.

(WebCore::HTMLMediaElement::trackWillBeRemoved): Minor cleanup.
(WebCore::HTMLMediaElement::selectNextSourceChild): Ditto.
(WebCore::HTMLMediaElement::sourceWasAdded): Update for scheduleLoad change.

html/HTMLMediaElement.h:
html/HTMLMediaElement.idl: Add textTracks attribute.

html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedIntoTree): Use new mediaElement() method.
(WebCore::HTMLTrackElement::willRemove): Ditto.
(WebCore::HTMLTrackElement::attributeChanged): When 'src' is changed, call scheduleLoad

instead of HTMLMediaElement

(WebCore::HTMLTrackElement::isDefault): hasAttribute -> fastHasAttribute.
(WebCore::HTMLTrackElement::track): Allocate track if necessary.
(WebCore::HTMLTrackElement::scheduleLoad): New, tell the track to schedule a load.
(WebCore::HTMLTrackElement::canLoadUrl): New, check security policy to see if it is OK

to load a text track. If so, dispatch 'beforeload' event to give it a chance to disallow
load.

(WebCore::HTMLTrackElement::loadingCompleted): Renamed from textTrackLoadingCompleted.
(WebCore::HTMLTrackElement::textTrackReadyStateChanged): New, TextTrackLoadingClient interface

used to inform parent of TextTrack state changes.

(WebCore::HTMLTrackElement::textTrackModeChanged): Ditto.
(WebCore::HTMLTrackElement::textTrackAddCues): Ditto.
(WebCore::HTMLTrackElement::textTrackRemoveCues): Ditto.
(WebCore::HTMLTrackElement::textTrackAddCue): Ditto.
(WebCore::HTMLTrackElement::textTrackRemoveCue): Ditto.
(WebCore::HTMLTrackElement::mediaElement): New, return parent element.

html/HTMLTrackElement.h:

html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack): Initialize new instance variables.
(WebCore::LoadableTextTrack::scheduleLoad): New, prime a timer to kick off loading.
(WebCore::LoadableTextTrack::loadTimerFired): Cancel current load, if any, check to see if

new url is allowed to load, and start new load.

(WebCore::LoadableTextTrack::cueLoadingCompleted):

html/LoadableTextTrack.h:

(WebCore::LoadableTextTrackClient::~LoadableTextTrackClient): TextTrackLoadingClient -> LoadableTextTrackClient
(WebCore::LoadableTextTrackClient::canLoadUrl):
(WebCore::LoadableTextTrackClient::loadingCompleted):
(WebCore::LoadableTextTrack::create):

html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): setClient(0) -> clearClient().

html/TextTrack.h:

(WebCore::TextTrack::clearClient): Renamed from setClient, because it is only used to clear the client pointer.

html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::add): Get rid of a compiler warning that breaks the OS X build.

html/track/TextTrackList.cpp: Added. Implement the TextTrackList object.

(TextTrackList::TextTrackList):
(TextTrackList::~TextTrackList):
(TextTrackList::length):
(TextTrackList::item):
(TextTrackList::append):
(TextTrackList::remove):
(TextTrackList::interfaceName):
(TextTrackList::scheduleAddTrackEvent):
(TextTrackList::asyncEventTimerFired):

html/track/TextTrackList.h: Added.

(WebCore::TextTrackList::create):
(WebCore::TextTrackList::scriptExecutionContext):
(WebCore::TextTrackList::clearOwner):
(WebCore::TextTrackList::owner):
(WebCore::TextTrackList::refEventTarget):
(WebCore::TextTrackList::derefEventTarget):
(WebCore::TextTrackList::eventTargetData):
(WebCore::TextTrackList::ensureEventTargetData):

html/track/TextTrackList.idl: Added.

loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::cancelLoad): New, cancel pending or in progress load and delete loader.
(WebCore::TextTrackLoader::notifyFinished): Call cancelLoad.
(WebCore::TextTrackLoader::load): Ditto.

loader/TextTrackLoader.h:
page/DOMWindow.idl: Add TextTrackList.

LayoutTests:

media/track/track-add-track-expected.txt: Added.
media/track/track-add-track.html: Added.
media/track/tracklist-is-reachable-expected.txt: Added.
media/track/tracklist-is-reachable.html: Added.

9:18 AM Changeset in webkit [99983] by pfeldman@chromium.org

4 edits in trunk

Web Inspector: reimplement DOM search using no XPath.
https://bugs.webkit.org/show_bug.cgi?id=72125

Reviewed by Yury Semikhatsky.

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::buildObjectForNode):

inspector/InspectorDOMAgent.h:

8:55 AM Changeset in webkit [99982] by gavinp@chromium.org

3 edits
3 adds in trunk

Protect Document during error responses
https://bugs.webkit.org/show_bug.cgi?id=72068

Add a Document protector to the error response code handler, just
as exists for other ends of requests.

Reviewed by Nate Chapin.

Source/WebCore:

Test: http/tests/misc/xslt-bad-import.html

loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

LayoutTests:

http/tests/misc/resources/xslt-bad-import-uri.xml: Added.
http/tests/misc/resources/xslt-bad-import-uri.xsl: Added.
http/tests/misc/xslt-bad-import-expected.txt: Added.
http/tests/misc/xslt-bad-import.html: Added.

8:53 AM Changeset in webkit [99981] by gavinp@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r99979.
http://trac.webkit.org/changeset/99979
https://bugs.webkit.org/show_bug.cgi?id=72136

bad commit message (Requested by gavinp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

8:50 AM Changeset in webkit [99980] by yurys@chromium.org

2 edits in trunk/LayoutTests

2011-11-11 Yury Semikhatsky <yurys@chromium.org>

Fixed overlapping expectations.

platform/chromium/test_expectations.txt:

8:47 AM Changeset in webkit [99979] by gavinp@chromium.org

3 edits in trunk

Protect Document during error responses
https://bugs.webkit.org/show_bug.cgi?id=72068

Add a Document protector to the error response code handler, just
as exists for other ends of requests.

Reviewed by NOBODY (OOPS!).

Test: http/tests/misc/xslt-bad-import.html

loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

8:43 AM Changeset in webkit [99978] by yurys@chromium.org

2 edits in trunk/LayoutTests

2011-11-11 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark http/tests/inspector-enabled/dedicated-workers-list.html as timing out on Mac.

platform/chromium/test_expectations.txt:

8:35 AM Changeset in webkit [99977] by Philippe Normand

6 edits in trunk/Source/WebCore

[GStreamer] GstCaps and GstPad RefPtr implementation
https://bugs.webkit.org/show_bug.cgi?id=72023

Reviewed by Martin Robinson.

Smart pointer implementations for GstCaps and GstPad and them
in the media player code.

platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::GstPad):
(WTF::GstCaps):

platform/graphics/gstreamer/GRefPtrGStreamer.h:
platform/graphics/gstreamer/GStreamerGWorld.cpp:

(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::naturalSize):
(WebCore::MediaPlayerPrivateGStreamer::totalBytes):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webkit_web_src_init):
(StreamingClient::didReceiveResponse):

8:33 AM Changeset in webkit [99976] by Csaba Osztrogonác

1 edit
16 adds in trunk/LayoutTests

[Qt] Unreviewed evening gardening. Add platform specific expected results for new passing tests.

platform/qt/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
platform/qt/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
platform/qt/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
platform/qt/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
platform/qt/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
platform/qt/fast/multicol/pagination-h-vertical-lr-expected.txt: Added.
platform/qt/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
platform/qt/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
platform/qt/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
platform/qt/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
platform/qt/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
platform/qt/fast/multicol/pagination-v-horizontal-tb-expected.txt: Added.
platform/qt/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
platform/qt/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
platform/qt/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
platform/qt/fast/multicol/pagination-v-vertical-rl-expected.txt: Added.

8:31 AM Changeset in webkit [99975] by gavinp@chromium.org

3 deletes in trunk/LayoutTests/http/tests/misc

Unreviewed, rilling out 99971,99972.

They were landed in error in using git-svn by gavinp@chromium.org.

8:28 AM Changeset in webkit [99974] by Csaba Osztrogonác

1 edit
4 adds in trunk/LayoutTests

[Qt] Unreviewed evening gardening. Add platform specific expected results for new passing tests.

platform/qt/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
platform/qt/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
platform/qt/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
platform/qt/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.

8:27 AM Changeset in webkit [99973] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, skip 2 failing pasteboard tests after r99924.

platform/gtk/Skipped:

8:25 AM Changeset in webkit [99972] by gavinp@chromium.org

1 add in trunk/LayoutTests/http/tests/misc/xslt-bad-import-expected.txt

Moar

8:25 AM Changeset in webkit [99971] by gavinp@chromium.org

3 adds in trunk/LayoutTests/http/tests/misc

first shot yo

8:22 AM Changeset in webkit [99970] by Csaba Osztrogonác

1 edit
4 adds in trunk/LayoutTests

[Qt] Unreviewed evening gardening. Add platform specific expected results for new passing tests.

platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
platform/qt/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
platform/qt/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.

8:14 AM Changeset in webkit [99969] by tonyg@chromium.org

1 edit
1 add in trunk/LayoutTests

Another baseline for contain-and-cover-zoomed that I didn't catch earlier.

platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.

7:52 AM Changeset in webkit [99968] by Simon Hausmann

14 edits
2 adds
4 deletes in trunk

Unreviewed, rolling out r99964.
http://trac.webkit.org/changeset/99964
https://bugs.webkit.org/show_bug.cgi?id=72124

Broke too many Qt tests (Requested by tronical_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

Source/WebCore:

Target.pri:
html/HTMLSelectElement.h:

(WebCore::HTMLSelectElement::usesMenuList):

platform/qt/QtMobileWebStyle.cpp: Added.

(QtMobileWebStyle::QtMobileWebStyle):
(drawRectangularControlBackground):
(QtMobileWebStyle::drawChecker):
(QtMobileWebStyle::findChecker):
(QtMobileWebStyle::drawRadio):
(QtMobileWebStyle::findRadio):
(QtMobileWebStyle::drawControl):
(QtMobileWebStyle::drawPrimitive):
(QtMobileWebStyle::drawMultipleComboButton):
(QtMobileWebStyle::drawSimpleComboButton):
(QtMobileWebStyle::getButtonImageSize):
(QtMobileWebStyle::findComboButton):
(QtMobileWebStyle::drawComplexControl):

platform/qt/QtMobileWebStyle.h: Added.
platform/qt/QtStyleOptionWebComboBox.h:

(WebCore::QtStyleOptionWebComboBox::QtStyleOptionWebComboBox):
(WebCore::QtStyleOptionWebComboBox::checkMultiple):

platform/qt/RenderThemeQStyle.cpp: Removed.
platform/qt/RenderThemeQStyle.h: Removed.
platform/qt/RenderThemeQt.cpp:

(WebCore::initStyleOption):
(WebCore::StylePainter::StylePainter):
(WebCore::StylePainter::init):
(WebCore::StylePainter::~StylePainter):
(WebCore::RenderThemeQt::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::~RenderThemeQt):
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::popupInternalPaddingBottom):
(WebCore::RenderThemeQt::fallbackStyle):
(WebCore::RenderThemeQt::qStyle):
(WebCore::RenderThemeQt::extraDefaultStyleSheet):
(WebCore::RenderThemeQt::findFrameLineWidth):
(WebCore::inflateButtonRect):
(WebCore::RenderThemeQt::adjustRepaintRect):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::computeSizeBasedOnStyle):
(WebCore::RenderThemeQt::adjustButtonStyle):
(WebCore::RenderThemeQt::setButtonPadding):
(WebCore::RenderThemeQt::paintButton):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::paintTextField):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::setPopupPadding):
(WebCore::RenderThemeQt::paintMenuList):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::paintMenuListButton):
(WebCore::RenderThemeQt::animationDurationForProgressBar):
(WebCore::RenderThemeQt::paintProgressBar):
(WebCore::RenderThemeQt::paintSliderTrack):
(WebCore::RenderThemeQt::paintSliderThumb):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::paintInnerSpinButton):
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::initializeCommonQStyleOptions):
(WebCore::RenderThemeQt::paintMediaFullscreenButton):
(WebCore::RenderThemeQt::paintMediaMuteButton):
(WebCore::RenderThemeQt::paintMediaPlayButton):
(WebCore::RenderThemeQt::paintMediaCurrentTime):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeQt::paintMediaSliderTrack):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
(WebCore::RenderThemeQt::adjustSliderThumbSize):
(WebCore::RenderThemeQt::caretBlinkInterval):
(WebCore::RenderThemeQt::fileListNameForWidth):

platform/qt/RenderThemeQt.h:

(WebCore::StylePainter::isValid):
(WebCore::StylePainter::drawPrimitive):
(WebCore::StylePainter::drawControl):
(WebCore::StylePainter::drawComplexControl):

platform/qt/RenderThemeQtMobile.cpp: Removed.
platform/qt/RenderThemeQtMobile.h: Removed.
platform/qt/ScrollbarThemeQt.cpp:

(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::scrollbarThickness):
(WebCore::ScrollbarThemeQt::paintScrollCorner):

Source/WebKit/qt:

Api/qwebpage.cpp:

(QWebPage::swallowContextMenuEvent):

tests/tests.pri:

Tools:

WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

qmake/mkspecs/features/features.prf:
qmake/mkspecs/features/webcore.prf:

7:42 AM Changeset in webkit [99967] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Not reviewed: fix Snow Leopard build.

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::performSearch):

7:35 AM Changeset in webkit [99966] by Simon Hausmann

2 edits in trunk/Source/WebKit2

[Qt] Remove dead MeeGoTouch code.

Reviewed by Tor Arne Vestbø.

WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt):

7:22 AM Changeset in webkit [99965] by pfeldman@chromium.org

13 edits in trunk

Web Inspector: make search in DOM panel scale.
https://bugs.webkit.org/show_bug.cgi?id=72118

Reviewed by Yury Semikhatsky.

Source/WebCore:

inspector/Inspector.json:
inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::discardSearchResults):

inspector/InspectorDOMAgent.h:
inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype.performSearch.callback):
(WebInspector.DOMAgent.prototype.performSearch):
(WebInspector.DOMAgent.prototype.searchResult.mycallback):
(WebInspector.DOMAgent.prototype.searchResult):
(WebInspector.DOMAgent.prototype.cancelSearch):
(WebInspector.DOMDispatcher.prototype.childNodeRemoved):

inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.searchCanceled):
(WebInspector.ElementsPanel.prototype.performSearch.resultCountCallback):
(WebInspector.ElementsPanel.prototype.performSearch):
(WebInspector.ElementsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.ElementsPanel.prototype._highlightCurrentSearchResult.):
(WebInspector.ElementsPanel.prototype._highlightCurrentSearchResult):
(WebInspector.ElementsPanel.prototype._hideSearchHighlights):

inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._highlightNthMatchedResource):

inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._showSearchResult.callback):
(WebInspector.ResourcesPanel.prototype._showSearchResult):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
(WebInspector.ScriptsPanel.prototype.performSearch):
(WebInspector.ScriptsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):

inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype._updateSearchMatchesCountAndCurrentMatchIndex):

LayoutTests:

inspector/elements/elements-panel-search-expected.txt:
inspector/elements/elements-panel-search.html:

7:16 AM Changeset in webkit [99964] by Simon Hausmann

14 edits
4 adds
2 deletes in trunk

[Qt] Remove the QStyle dependency in Qt's mobile theme https://bugs.webkit.org/show_bug.cgi?id=67773

This refactoring splits up RenderThemeQt with two
subclasses, a QStyle-backed one, and a Mobile version
that uses the old mobile theme for now.

QStyle availability is detected at compile time, and
its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
environment variable.

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-11-11
Reviewed by Simon Hausmann.

Source/WebCore:

Covered by the existing tests.

Target.pri:
platform/qt/QtMobileWebStyle.cpp: Removed. The relevant logic

now lives within RenderThemeQtMobile.

platform/qt/QtMobileWebStyle.h: Removed. Ditto.
platform/qt/RenderThemeQStyle.cpp: Added.

(WebCore::initStyleOption):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::fallbackStyle):
(WebCore::RenderThemeQStyle::qStyle):
(WebCore::RenderThemeQStyle::findFrameLineWidth):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::adjustTextFieldStyle):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):

platform/qt/RenderThemeQStyle.h: Added.

(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::drawPrimitive):
(WebCore::StylePainterQStyle::drawControl):
(WebCore::StylePainterQStyle::drawComplexControl):

platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::inflateButtonRect):
(WebCore::RenderThemeQt::adjustRepaintRect):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::adjustProgressBarStyle):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::paintMediaFullscreenButton):
(WebCore::RenderThemeQt::paintMediaMuteButton):
(WebCore::RenderThemeQt::paintMediaPlayButton):
(WebCore::RenderThemeQt::paintMediaCurrentTime):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeQt::paintMediaSliderTrack):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
(WebCore::RenderThemeQt::adjustSliderThumbSize):
(WebCore::RenderThemeQt::caretBlinkInterval):
(WebCore::RenderThemeQt::fileListNameForWidth):
(WebCore::StylePainter::StylePainter):
(WebCore::StylePainter::init):
(WebCore::StylePainter::~StylePainter):

platform/qt/RenderThemeQt.h:

(WebCore::RenderThemeQt::useMobileTheme):
(WebCore::StylePainter::isValid):

platform/qt/RenderThemeQtMobile.cpp: Added.

(WebCore::drawRectangularControlBackground):
(WebCore::RenderThemeQtMobile::getStylePainter):
(WebCore::StylePainterMobile::StylePainterMobile):
(WebCore::StylePainterMobile::drawChecker):
(WebCore::StylePainterMobile::findChecker):
(WebCore::StylePainterMobile::drawRadio):
(WebCore::StylePainterMobile::findRadio):
(WebCore::StylePainterMobile::drawMultipleComboButton):
(WebCore::StylePainterMobile::drawSimpleComboButton):
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::findComboButton):
(WebCore::StylePainterMobile::drawLineEdit):
(WebCore::StylePainterMobile::drawCheckBox):
(WebCore::StylePainterMobile::drawRadioButton):
(WebCore::StylePainterMobile::drawPushButton):
(WebCore::StylePainterMobile::drawComboBox):
(WebCore::RenderThemeQtMobile::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQtMobile::RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::~RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::isControlStyled):
(WebCore::RenderThemeQtMobile::popupInternalPaddingBottom):
(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):
(WebCore::RenderThemeQtMobile::adjustButtonStyle):
(WebCore::RenderThemeQtMobile::setButtonPadding):
(WebCore::RenderThemeQtMobile::paintButton):
(WebCore::RenderThemeQtMobile::adjustTextFieldStyle):
(WebCore::RenderThemeQtMobile::paintTextField):
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):
(WebCore::RenderThemeQtMobile::setPopupPadding):
(WebCore::RenderThemeQtMobile::paintMenuList):
(WebCore::RenderThemeQtMobile::paintMenuListButton):
(WebCore::RenderThemeQtMobile::animationDurationForProgressBar):
(WebCore::RenderThemeQtMobile::paintProgressBar):
(WebCore::RenderThemeQtMobile::paintSliderTrack):
(WebCore::RenderThemeQtMobile::paintSliderThumb):
(WebCore::RenderThemeQtMobile::checkMultiple):
(WebCore::RenderThemeQtMobile::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQtMobile::adjustSliderThumbSize):

platform/qt/RenderThemeQtMobile.h: Added.
platform/qt/ScrollbarThemeQt.cpp:

(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::scrollbarThickness):
(WebCore::ScrollbarThemeQt::paintScrollCorner):

Source/WebKit/qt:

Api/qwebpage.cpp:

(QWebPage::swallowContextMenuEvent):

tests/tests.pri:

Tools:

WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,

based on availability of QtWidgets.

qmake/mkspecs/features/webcore.prf: cleanup.

7:14 AM Changeset in webkit [99963] by apavlov@chromium.org

7 edits in trunk

Web Inspector: Option to configure indentation of pretty-printed Javascript
https://bugs.webkit.org/show_bug.cgi?id=72119

Reviewed by Pavel Feldman.

Source/WebCore:

Drive-by fix for field names and added indent caching, as suggested by Pavel Podivilov.

inspector/front-end/JavaScriptFormatter.js:

(FormattedContentBuilder):
(FormattedContentBuilder.prototype.increaseNestingLevel):
(FormattedContentBuilder.prototype.decreaseNestingLevel):
(FormattedContentBuilder.prototype._addIndent):

inspector/front-end/ScriptFormatter.js:
inspector/front-end/ScriptFormatterWorker.js:

(onmessage):
(formatScript):
(HTMLScriptFormatter):
(HTMLScriptFormatter.prototype.scriptEnded):

LayoutTests:

inspector/debugger/script-formatter-expected.txt:
inspector/debugger/script-formatter.html:

7:08 AM Changeset in webkit [99962] by andreas.kling@nokia.com

2 edits in trunk/Source/WebCore

Unreviewed Chromium build fix after r99958.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementationCustomCall):o

Remove hack that forced HTMLOptionsCollection to have a custom
callAsFunctionCallback().

6:55 AM Changeset in webkit [99961] by alexis.menard@openbossa.org

2 edits in trunk

[Qt] Build fix of the private QML module with --no-webkit2.
https://bugs.webkit.org/show_bug.cgi?id=67707

Reviewed by Tor Arne Vestbø.

Source/QtWebKit.pro:

6:50 AM Changeset in webkit [99960] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: DevTools InspectorStubs.js incorrectly converting responses to arguments.
https://bugs.webkit.org/show_bug.cgi?id=72096

JSON.parse doesn't garantee the order of keys.
We have to explicitly order the results according to Inspector.json spec.

Patch by Mike Lewis <mikelikespie@gmail.com> on 2011-11-11
Reviewed by Pavel Feldman.

inspector/CodeGeneratorInspector.py:

6:50 AM Changeset in webkit [99959] by Philippe Normand

3 edits in trunk/LayoutTests

Unreviewed, skip a svg test and GTK rebaseline after r99941.

platform/gtk/Skipped:
platform/gtk/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt:

6:37 AM Changeset in webkit [99958] by andreas.kling@nokia.com

7 edits in trunk

Remove ability to call HTMLCollections in V8 bindings as well.
<http://webkit.org/b/72045>

Reviewed by Anders Carlsson.

Source/WebCore:

Follow the JSC bindings and remove the ability to call HTMLCollections
in the V8 bindings (excluding HTMLAllCollection.)

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeaderCustomCall):
(GenerateImplementationCustomCall):

dom/NodeList.idl:
html/HTMLCollection.idl:

Remove the V8CustomCall attribute as it's no longer needed.

bindings/v8/custom/V8HTMLCollectionCustom.cpp:
bindings/v8/custom/V8NodeListCustom.cpp:

LayoutTests:

Add a test verifying that calling collections other than document.all
will now throw.

fast/dom/collection-calling-expected.txt: Added.
fast/dom/collection-calling.html: Added.
fast/dom/script-tests/collection-calling.js: Added.

6:22 AM Changeset in webkit [99957] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Interactive color box for gradients in CSS property values
https://bugs.webkit.org/show_bug.cgi?id=72112

Reviewed by Yury Semikhatsky.

Add "background-image" to the list of color-aware properties (may contain gradient definition).

inspector/front-end/CSSKeywordCompletions.js:

5:47 AM Changeset in webkit [99956] by vestbo@webkit.org

2 edits in trunk/Tools

[Qt] Add missing include to PlatformWebViewQt

Reviewed by Simon Hausmann.

5:40 AM Changeset in webkit [99955] by yurys@chromium.org

2 edits in trunk/LayoutTests

2011-11-11 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Correct test_expectations.

platform/chromium/test_expectations.txt:

5:34 AM Changeset in webkit [99954] by tonyg@chromium.org

6 edits
1 delete in trunk/LayoutTests

Update chromium baselines after r99941.

That patch changed the number of zooms performed, so it seems to make sense that the
baseline would show a different sized image.

platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
platform/chromium/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.

5:20 AM Changeset in webkit [99953] by yurys@chromium.org

6 edits
3 adds in trunk

Web Inspector: [chromium] list dedicated workers in case inspector opened post-worker creation.
https://bugs.webkit.org/show_bug.cgi?id=72020

Source/WebCore:

Collect information about dedicated workers even when inspector is closed. This
way we can list all dedicated workers if the front-end opens later.

Reviewed by Pavel Feldman.

Test: http/tests/inspector-enabled/dedicated-workers-list.html

inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didStartWorkerContext):

inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::setFrontend):
(WebCore::InspectorWorkerAgent::restore):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
(WebCore::InspectorWorkerAgent::didStartWorkerContext):
(WebCore::InspectorWorkerAgent::workerContextTerminated):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannelsForExistingWorkers):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):

inspector/InspectorWorkerAgent.h:

LayoutTests:

Reviewed by Pavel Feldman.

http/tests/inspector-enabled/dedicated-workers-list-expected.txt: Added.
http/tests/inspector-enabled/dedicated-workers-list.html: Added.
http/tests/inspector-enabled/resources/dedicated-worker.js: Added.

(doWork):

5:19 AM Changeset in webkit [99952] by alexis.menard@openbossa.org

7 edits
6 adds in trunk

[Qt] Add a way to have experimental features in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=67707

Reviewed by Kenneth Rohde Christiansen.

Add the new private QML module in the build.

Source/QtWebKit.pro:

Source/WebKit/qt:

This patch is adding a new module for accessing private
method and property from the view. It requires an import
QtWebKit.private in QML to be used.

declarative/private/plugin.cpp: Added.

(WebKitQmlPluginPrivate::registerTypes):

declarative/private/private.pro: Added.
declarative/private/qmldir: Added.

Source/WebKit2:

Add new QML extensions for our public view. This extension
returns the private object of the view so that the user could
use unstable/unreleased APIs. This requires our private class
to be exported and QObject subclass.

Target.pri:
UIProcess/API/qt/qquickwebview.cpp:
UIProcess/API/qt/qquickwebview_p.h:
UIProcess/API/qt/qquickwebviewprivateextension.cpp: Added.

(QQuickWebViewPrivateExtension::QQuickWebViewPrivateExtension):
(QQuickWebViewPrivateExtension::viewPrivate):

UIProcess/API/qt/qquickwebviewprivateextension_p.h: Added.

5:12 AM Changeset in webkit [99951] by yurys@chromium.org

15 edits
3 deletes in trunk

Unreviewed, rolling out r99950.
http://trac.webkit.org/changeset/99950
https://bugs.webkit.org/show_bug.cgi?id=72117

"Landed wrong patch by mistake" (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

Source/JavaScriptCore:

JavaScriptCore.exp:
runtime/JSFunction.cpp:
runtime/JSFunction.h:

Source/WebCore:

bindings/js/JSInjectedScriptHostCustom.cpp:
bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
inspector/InjectedScript.cpp:
inspector/InjectedScript.h:
inspector/InjectedScriptHost.idl:
inspector/InjectedScriptSource.js:
inspector/Inspector.json:
inspector/InspectorDebuggerAgent.cpp:
inspector/InspectorDebuggerAgent.h:

LayoutTests:

inspector/debugger/function-location-expected.txt: Removed.
inspector/debugger/function-location.html: Removed.
platform/chromium/inspector/debugger/function-location-expected.txt: Removed.

5:05 AM Changeset in webkit [99950] by yurys@chromium.org

14 edits
3 adds in trunk

Web Inspector: function remote objetct should provide access to function position in the script
https://bugs.webkit.org/show_bug.cgi?id=71808

Source/WebCore:

Added Debugger.getFunctionLocation command for resolving function location including
start line, column and script id.

Reviewed by Pavel Feldman.

Test: inspector/debugger/function-location.html

bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::functionLocation):

bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::functionLocationCallback):

inspector/InjectedScript.cpp:

(WebCore::InjectedScript::getFunctionLocation):

inspector/InjectedScript.h:
inspector/InjectedScriptHost.idl:
inspector/InjectedScriptSource.js:

(.):

inspector/Inspector.json:
inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::getFunctionLocation):

inspector/InspectorDebuggerAgent.h:

LayoutTests:

Added test for Debugger.getFunctionLocation command.

Reviewed by Pavel Feldman.

inspector/debugger/function-location-expected.txt: Added.
inspector/debugger/function-location.html: Added.
platform/chromium/inspector/debugger/function-location-expected.txt: Added.

4:47 AM Changeset in webkit [99949] by vestbo@webkit.org

2 edits in trunk/Tools

[Qt] Fix incremental builds on Windows after buildsystem refactor

The qmake rules to ensure that we run make on the derived sources
before running qmake on the target were inside a unix-scope, which
resulted in flakey builds on Windows.

We now generate a rule on all platforms that ensures that "make qmake"
will always run make on the derived sources. In addition, on platforms
that have GNU make (where "make incremental" does not run "make qmake",
but only "make"), we add a similar rule that ensures that any time the
target makefile is regenerated we first run qmake and make on the derived
sources. This rule relies on GNU make's order-only-prerequisites to
not trigger a qmake-run of the target every time we run make.

https://bugs.webkit.org/show_bug.cgi?id=71778

Reviewed by Simon Hausmann.

4:46 AM Changeset in webkit [99948] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Not reviewed: roll out changes to InspectorDOMAgent that squeezed into 99933.

inspector/InspectorDOMAgent.cpp:

(WebCore::MatchJob::MatchJob):
(WebCore::InspectorDOMAgent::onMatchJobsTimer):

4:44 AM Changeset in webkit [99947] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Metrics] Editor is committed when scrolling a content box dimension up/down for the first time
https://bugs.webkit.org/show_bug.cgi?id=72108

Reviewed by Pavel Feldman.

inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane.prototype._attributesUpdated):

4:40 AM Changeset in webkit [99946] by Simon Hausmann

14 edits
2 deletes in trunk

[Qt][WK2] Remove QWebNavigationController
https://bugs.webkit.org/show_bug.cgi?id=72113

Reviewed by Andreas Kling.

Source/WebKit/qt:

declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes): Don't register QWebNavigationController with qml.

Source/WebKit2:

Fold the functions and properties of QWebNavigationController into
QQuickWebView.

Target.pri:
UIProcess/API/qt/WKView.h:
UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::QQuickWebPagePrivate):

UIProcess/API/qt/qquickwebpage.h:
UIProcess/API/qt/qquickwebpage_p.h:
UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):
(QQuickWebView::goBack):
(QQuickWebView::goForward):
(QQuickWebView::stop):
(QQuickWebView::reload):
(QQuickWebView::canGoBack):
(QQuickWebView::canGoForward):
(QQuickWebView::canStop):
(QQuickWebView::canReload):
(QQuickWebView::title):

UIProcess/API/qt/qquickwebview.h:
UIProcess/API/qt/qwebnavigationcontroller.cpp: Removed.
UIProcess/API/qt/qwebnavigationcontroller.h: Removed.
UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::navigationStatusAtStartup):
(LoadStartedCatcher::onLoadStarted):
(tst_QQuickWebView::stopEnabledAfterLoadStarted):
(tst_QQuickWebView::backAndForward):
(tst_QQuickWebView::reload):
(tst_QQuickWebView::stop):

Tools:

Adapt to the move of the QWebNavigationController functions/properties to
QQuickWebView.

MiniBrowser/qt/MiniBrowserApplication.cpp:
MiniBrowser/qt/qml/BrowserWindow.qml:

4:33 AM Changeset in webkit [99945] by Simon Hausmann

2 edits in trunk/Tools

[Qt] Build system tweak

Reviewed by Tor Arne Vestbø.

Be a good qmake citizen, return true from our linkStaticLibrary
"test" function.

qmake/mkspecs/features/functions.prf:

4:33 AM Changeset in webkit [99944] by tonyg@chromium.org

1 edit
2 adds in trunk/LayoutTests

Chromium expectations for new test in r99937.

platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
platform/chromium-win/svg/zoom/page/zoom-svg-as-object-expected.png: Added.

4:17 AM Changeset in webkit [99943] by hclam@chromium.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Fix CCLayerTreeHost leak in webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=72081

Patch by James Robinson <jamesr@chromium.org> on 2011-11-11
Reviewed by Kenneth Russell.

LayerChromium and CCLayerTreeHosts hold RefPtr<>s to each other, so if
you do not clear out the layerTreeHost pointer on the LayerChromium
the layer tree is leaked. The real code does this in WebViewImpl but
this test was not.

tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::doBeginTest):

4:16 AM Changeset in webkit [99942] by hclam@chromium.org

3 edits in trunk/Source/WebCore

[chromium] scrolling is broken with compositor thread
https://bugs.webkit.org/show_bug.cgi?id=72059

Reviewed by James Robinson.

No new test. Existing test CCLayerTreeHostImplTest.scrollDeltaRepeatedScrolls checks scroll deltas are applied
on the right layer.

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::scrollLayer):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
Instead of calling on the root layer which doesn't have scroll delta applied. Change this to scrollLayer()
which actually has scroll delta.

3:49 AM Changeset in webkit [99941] by Nikolas Zimmermann

4 edits in trunk/LayoutTests

2011-11-11 Nikolas Zimmermann <nzimmermann@rim.com>

[Qt] 4 new tests fail introduced in r98852
https://bugs.webkit.org/show_bug.cgi?id=71253

Reviewed by Zoltan Herczeg.

Fix a non-Mac only problem with contain-and-cover-zoomed.html. It zooms out four times, which is ignored on Mac, but respected elsewhere.
This is the same fix I applied to the svg/zoom/page tests, I forgot this one.

fast/backgrounds/size/contain-and-cover-zoomed.html: Don't zoom out more than three times, it's otherwise ignored on Mac/DRT!
fast/backgrounds/size/resources/SquirrelFish.svg: Fix typo in XML version, now this shows up in Qt again. Credits to Zoltan Arvai for spotting this.
platform/qt/Skipped: Unskip last regression from bug 7153.

3:47 AM Changeset in webkit [99940] by tonyg@chromium.org

7 edits
1 delete in trunk/Source

Unreviewed, rolling out r99826.
http://trac.webkit.org/changeset/99826
https://bugs.webkit.org/show_bug.cgi?id=72109

"Likely causing test flakiness" (Requested by tonyg-cr on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

Source/WebCore:

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::scheduleArchiveLoad):

Source/WebKit/chromium:

tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::createWebViewAndLoad):

tests/FrameTestHelpers.h:
tests/WebFrameTest.cpp:

(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
(WebKit::TEST_F):

tests/WebViewTest.cpp:

(WebKit::TEST_F):

tests/data/page_with_image.mht: Removed.

3:37 AM Changeset in webkit [99939] by Simon Hausmann

2 edits in trunk/Tools

[Qt] Add support for QT += webkit-private

Reviewed by Tor Arne Vestbø.

qmake/qt_webkit.pri: Declare private headers.

3:02 AM Changeset in webkit [99938] by tonyg@chromium.org

1 edit
3 moves
2 deletes in trunk/LayoutTests

Fixing media/video-frame-accurate-seek.html expectation after r99887.

platform/chromium-cg-mac-leopard/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-frame-accurate-seek-expected.png.
platform/chromium-gpu-mac/media/video-frame-accurate-seek-expected.png: Removed.
platform/chromium-gpu/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/media/video-frame-accurate-seek-expected.png.
platform/chromium-mac-snowleopard/media/video-frame-accurate-seek-expected.png: Removed.
platform/chromium/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/media/video-frame-accurate-seek-expected.png.

2:31 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

1:52 AM Changeset in webkit [99937] by Nikolas Zimmermann

7 edits
4 adds in trunk

2011-11-11 Nikolas Zimmermann <nzimmermann@rim.com>

Zooming in SVGs in <object> is flakey
https://bugs.webkit.org/show_bug.cgi?id=71673

Reviewed by Zoltan Herczeg.

Add another minimal testcase using <object> embedding SVGs + zooming.

platform/qt/Skipped: Unskip zoom-img-preserveAspectRatio-support-1.html.
platform/mac/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
platform/mac/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
svg/zoom/page/resources/zoom-svg-as-object.svg: Added.
svg/zoom/page/zoom-svg-as-object.html: Added.

2011-11-11 Nikolas Zimmermann <nzimmermann@rim.com>

Zooming in SVGs in <object> is flakey
https://bugs.webkit.org/show_bug.cgi?id=71673

Reviewed by Zoltan Herczeg.

It turns out zooming in SVGs in <object> wasn't flakey in Safari at all, only in DRT/Mac. In Safari it failed 100% reproducable.
Scrollbars would always appear when zooming in a HTML document, containing an embedded SVG by <object>/<embed>/<iframe>, even
though the content would visually fit perfectly, also it zoomed properly. Reloading would make the scrollbars disappear again.

If scrollbars should be created for a FrameView or not, is determined by ScrollView::updateScrollbars(), by comparing the
visible size of the scroll view against the contents size. The contents size is propagated to the ScrollView, by
FrameView::adjustViewSize(), which is called during FrameView::layout(). The size thats propagated is RenderView::documentRect().
RenderView::documentRect() returns a writing-mode aware layoutOverflowRect(), computed by RenderBox::layoutOverflowRectForPropagation.

If overflow is "visible", layoutOverflowRect() will return a union of the borderBoxRect() and the layoutOverflowRect(), which
may exceed the visible size of the RenderView. For standalone SVG documents, the default value for the outermost <svg> renderer is
"visible". When embedding SVGs through <object>s into a host document, the same code path is taken, and RenderView::documentRect()
of the embedded SVG document will always return a union of the borderBoxREct() and the layoutOverflowRect().

If that happens while zooming in a HTML document containing a SVG by <object>, scrollbars are created.
By ensuring that overflow is treated as hidden, which is what Opera does (and makes sense!) this can't happen.

The fix is to treat embedded SVGs as they would carry overflow="hidden" on the outermost <svg> renderer. That also makes
sense as the embedded SVG cant paint outside an external "frame rect" thats given by the FrameView, effectively rendering
as overflow "hidden" already.

The fix is realized, by altering the overflow x/y values that are used in FrameView::applyOverflowToViewport(). Previously
we never called that method for SVG, which was fine. Now we always call applyOverflowToViewport(), but only do something
if the FrameView of the SVG is embedded in another document. If so, we force overflow to hidden.

That fixes all zooming+<object> related flakiness seen on the chromium bots, most noticeable, without other side effects.
All svg/overflow tests, still work as expected.

Test: svg/zoom/page/zoom-svg-as-object.html

page/Frame.cpp: (WebCore::Frame::setPageAndTextZoomFactors): Remove unnecessary setNeedsLayout() call in SVG builds.
page/FrameView.cpp: (WebCore::FrameView::applyOverflowToViewport): Always enforce overflow=hidden, when embedding SVGs through object/embed/iframe.

Otherwise scrollbars will appear, even though the contents would fit without them.

(WebCore::FrameView::calculateScrollbarModesForLayout): Always call applyOverflowToViewport, even for RenderSVGRoot. It only has

an effect though, when the FrameView of the SVG is embedded through <object>/etc.

(WebCore::FrameView::layout): Remove unnecessary setChildNeedsLayout() call.

rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::isEmbeddedThroughFrameContainingSVGDocument): Fix this function, its meaning was reversed before! (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): Fix logical error, by negating the result of isEmbeddedThroughFrameContainingSVGDocument. (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto.
rendering/svg/RenderSVGRoot.h: Expose isEmbeddedThroughFrameContainingSVGDocument.

1:44 AM Changeset in webkit [99936] by Nikolas Zimmermann

2 edits in trunk/Source/WebCore

2011-11-11 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Unbreak my 32bit SL build.

rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateOrRemoveFilterEffect): Use narrowPrecisionToFloat() to convert float -> double.

1:03 AM Changeset in webkit [99935] by Philippe Normand

2 edits in trunk/Tools

Unreviewed, build fix attempt after r99907. Since that revision
GTK layout tests were not running at all...

Scripts/webkitpy/layout_tests/port/gtk.py:

12:40 AM Changeset in webkit [99934] by Philippe Normand

3 edits
1 add in trunk/Source/WebCore

HRTF Database consolidation
https://bugs.webkit.org/show_bug.cgi?id=69703

Reviewed by Kenneth Russell.

Access to the consolidated parts of the HRTF database by segmented
chunks. A concatenated Composite HRTF database is provided in
Composite.wav. Additionnally a new build step that concatenates
the platform/audio/resources/ files into one (sox can be used for
this) can be configured for specific ports.

platform/audio/HRTFDatabase.h:
platform/audio/HRTFElevation.cpp:

(WebCore::getConcatenatedImpulseResponsesForSubject):
(WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):

platform/audio/resources/Composite.wav: Added.

12:37 AM Changeset in webkit [99933] by pfeldman@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: provide an id to the root inspector element for third party UA styling.
https://bugs.webkit.org/show_bug.cgi?id=72094

Reviewed by Yury Semikhatsky.

inspector/front-end/inspector.html:

12:11 AM Changeset in webkit [99932] by Patrick Gansterer

2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for !ENABLE(JIT) after r99898.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed