⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 13, 2011:

11:57 PM Changeset in webkit [100103] by Csaba Osztrogonác
  • 1 edit
    9 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r100036.

  • platform/qt/svg/foreignObject/clip-expected.png: Added.
  • platform/qt/svg/foreignObject/clip-expected.txt: Added.
  • platform/qt/svg/foreignObject/filter-expected.png: Added.
  • platform/qt/svg/foreignObject/filter-expected.txt: Added.
  • platform/qt/svg/foreignObject/mask-expected.png: Added.
  • platform/qt/svg/foreignObject/mask-expected.txt: Added.
  • platform/qt/svg/repaint/filter-child-repaint-expected.png: Added.
  • platform/qt/svg/repaint/filter-child-repaint-expected.txt: Added.
11:57 PM Changeset in webkit [100102] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Document::initSecurityOrigin should return earlier more often
​https://bugs.webkit.org/show_bug.cgi?id=72244

Reviewed by Eric Seidel.

This minor tweak was suggested by Darin to make the subsequent patches
easier to read.

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):

11:53 PM Changeset in webkit [100101] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

SecurityPolicy should refer to isUnique rather than isEmpty
​https://bugs.webkit.org/show_bug.cgi?id=72242

Reviewed by Eric Seidel.

It doesn't make sense to tweak the security policy for unique origins
because they're different every time. Previously, this code checked
for empty origins, which are technically a subset of unique origins. I
don't think it's possible to call this code in a way that can detect
the difference, but we're eventually going to remove the isEmpty
function.

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):

11:50 PM Changeset in webkit [100100] by abarth@webkit.org
  • 7 edits in trunk/Source/WebCore

Move isSecureTransitionTo from SecurityOrigin to SecurityContext
​https://bugs.webkit.org/show_bug.cgi?id=72241

Reviewed by Eric Seidel.

This patch is a step towards breaking the patch for
​https://bugs.webkit.org/show_bug.cgi?id=71745 up into tiny,
digestible pieces.

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::isSecureTransitionTo):

  • dom/SecurityContext.h:
  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):

  • page/SecurityOrigin.cpp:
  • page/SecurityOrigin.h:
9:14 PM Changeset in webkit [100099] by nduca@chromium.org
  • 5 edits in trunk/Source

[chromium] LayerRendererChromium::initialize should fail when GaphicsContext3D::makeCurrent fails
​https://bugs.webkit.org/show_bug.cgi?id=72102

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::makeContextCurrent):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

7:06 PM Changeset in webkit [100098] by tkent@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove WebFileChooserParams::acceptTypes
​https://bugs.webkit.org/show_bug.cgi?id=71998

Reviewed by Darin Fisher.

  • public/WebFileChooserParams.h: Remove acceptTypes.
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::runOpenPanel): Remove acceptTypes generatio code.

4:02 PM Changeset in webkit [100097] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Improve the documentation of ewk_view_setting_local_storage_*.
​https://bugs.webkit.org/show_bug.cgi?id=72135

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-11-13
Reviewed by Kenneth Rohde Christiansen.

Add some "see also" pointers, mention the default paths used for local
storage and document how things will not be persisted to disk if a
storage path is not set.

  • ewk/ewk_view.h:
3:03 PM Changeset in webkit [100096] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Simplify eina_stringshare usage in ewk_settings.
​https://bugs.webkit.org/show_bug.cgi?id=72127

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-11-13
Reviewed by Kenneth Rohde Christiansen.

Actually use the eina_stringshare functions in a sane way.

  • ewk/ewk_settings.cpp:

(ewk_settings_web_database_path_set): Just use
eina_stringshare_replace instead of doing needless checks and using
eina_stringshare_add.
(ewk_settings_cache_directory_path_set): Ditto.
(ewk_settings_icon_database_path_set): Ditto and always call
eina_stringshare_del, as passing NULL to it is just a NOP.

2:44 PM Changeset in webkit [100095] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix silent spilling/filling GPRs in DFG 32_64
​https://bugs.webkit.org/show_bug.cgi?id=72201

Reviewed by Gavin Barraclough.

Current silentSpillGPR/silentFillGPR may not work as expected for some
cases in 32_64. If there's a JSValue which was retained by two GPRs,
we may end up failing to spill/fill some GPRs or redundantly
spilling/filling some GPRs. For example, if we tend to exclude "eax"
from spilling while a JSValue is retained by both "eax" and "edx",
then "edx" won't be spilled as well (wrong). And if another JSValue is
retained by "ecx" and "ebx", both "ecx" and "ebx" will be spilled
twice. The similar problem applies to silentFillGPR.
The fix is to make silentSpillGPR/silentFillGPR more straightforward,
i.e., spilling/filling based on the GPR instead of the virtual
register. FPR spilling/filling is also modified accordingly to make it
consistent with GPR spilling/filling.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
(JSC::DFG::JITCodeGenerator::silentFillAllRegisters):

1:30 PM Changeset in webkit [100094] by gavinp@chromium.org
  • 2 edits in trunk/Tools

command line control of webcore log channels in chromium DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=72126

The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
what chromium takes.

Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

1:05 PM Changeset in webkit [100093] by scheib@chromium.org
  • 3 edits in trunk/Source/WebCore

Mouse Lock: MouseEvent IDL
​https://bugs.webkit.org/show_bug.cgi?id=72158

Reviewed by Dimitri Glazkov.

Tests for movementX/Y pending mock mouse lock test infrastructure.

  • dom/MouseEvent.idl:
  • dom/MouseRelatedEvent.h:

(WebCore::MouseRelatedEvent::movementX):
(WebCore::MouseRelatedEvent::movementY):

9:43 AM Changeset in webkit [100092] by jchaffraix@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(99849): NULL-deref in updateLastMediaLine when parsing some media-queries
​https://bugs.webkit.org/show_bug.cgi?id=72222

Reviewed by Pavel Feldman.

Source/WebCore:

Test: fast/media/update-media-query-css-parser.html

  • css/CSSGrammar.y: Added a proper NULL-check.

LayoutTests:

  • fast/media/update-media-query-css-parser-expected.txt: Added.
  • fast/media/update-media-query-css-parser.html: Added.
7:26 AM Changeset in webkit [100091] by scheib@chromium.org
  • 6 edits
    3 adds in trunk/Source/WebCore

Mouse Lock Navigator IDL
​https://bugs.webkit.org/show_bug.cgi?id=72150

Reviewed by Dimitri Glazkov.

Tests require mocking (similar to geolocation) that will be built after this.

  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):

  • page/MouseLockable.cpp: Added.

(WebCore::MouseLockable::MouseLockable):
(WebCore::MouseLockable::~MouseLockable):
(WebCore::MouseLockable::webkitLock):
(WebCore::MouseLockable::webkitUnlock):
(WebCore::MouseLockable::webkitIsLocked):

  • page/MouseLockable.h: Added.

(WebCore::MouseLockable::create):

  • page/MouseLockable.idl: Added.
  • page/Navigator.cpp:

(WebCore::Navigator::webkitPointer):

  • page/Navigator.h:
  • page/Navigator.idl:
6:53 AM Changeset in webkit [100090] by andreas.kling@nokia.com
  • 7 edits in trunk/Source/WebCore

Only HTMLAllCollection needs stateful named item traversal.
<​http://webkit.org/b/71987>

Reviewed by Antti Koivisto.

After the ability to call collections (excluding document.all) was removed
in <​http://webkit.org/b/67579>, chunks of code remained in HTMLCollection
and HTMLFormCollection that was only used for this purpose.

Restrict the nextNamedItem() mechanism to HTMLAllCollection, since it's no
longer used by any of the other collections.

  • html/HTMLCollection.h:

Moved nextNamedItem() to HTMLAllCollection (and made it non-virtual.)
Promoted itemAfter() and checkForNameMatch() to protected methods so
they can be called from HTMLAllCollection.

  • html/HTMLAllCollection.h:
  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::HTMLAllCollection):
(WebCore::HTMLAllCollection::nextNamedItem):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::namedItem):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::namedItem):

  • html/HTMLFormCollection.h:
1:28 AM Changeset in webkit [100089] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the 32-bit build.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox): Use a format specifier and cast that works on more architectures.

12:09 AM Changeset in webkit [100088] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

Update binding generator tests to use jsCast
​https://bugs.webkit.org/show_bug.cgi?id=72224

Reviewed by Geoffrey Garen.

Update the expected results for JS generator after r100006 added jsCast.

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::getOwnPropertySlot):
(WebCore::JSTestEventConstructor::getOwnPropertyDescriptor):

Nov 12, 2011:

11:40 PM Changeset in webkit [100087] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r100038.
​http://trac.webkit.org/changeset/100038
​https://bugs.webkit.org/show_bug.cgi?id=72225

It broke more than 500 layout tests on the Qt bots (Requested
by Ossy_night on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-12

  • platform/qt/ScrollbarThemeQt.h:
8:37 PM Changeset in webkit [100086] by Laszlo Gombos
  • 29 edits in trunk/Source

[Qt][Symbian] Remove support for WINSCW compiler
​https://bugs.webkit.org/show_bug.cgi?id=70178

Reviewed by Chang Shu.

Source/JavaScriptCore:

  • API/JSStringRef.h:
  • create_hash_table: Revert r45553.
  • runtime/JSGlobalData.cpp: Revert r45553.
  • runtime/LiteralParser.cpp: Remove WINSCW comment.

(JSC::LiteralParser::Lexer::lexString):

  • runtime/Lookup.h: Revert r45553.
  • runtime/Structure.h: Revert r48461.
  • wtf/Alignment.h:
  • wtf/Assertions.h: Revert r52337.
  • wtf/Compiler.h:
  • wtf/ListRefPtr.h: Revert r48988.

(WTF::ListRefPtr::~ListRefPtr):

  • wtf/OwnArrayPtr.h: Revert r45911.

(WTF::OwnArrayPtr::operator UnspecifiedBoolType):

  • wtf/PassOwnArrayPtr.h:

(WTF::PassOwnArrayPtr::operator UnspecifiedBoolType):

  • wtf/PassRefPtr.h:
  • wtf/StaticConstructors.h:
  • wtf/unicode/qt4/UnicodeQt4.h:

Source/WebCore:

No new tests as there is no new functionality.

(WebCore::CachedResourceHandle::CachedResourceHandle):

  • rendering/style/RenderStyle.h: Revert r52733.

(compareEqual):

  • bindings/scripts/CodeGeneratorJS.pm: Revert r45553.
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.

Source/WebKit2:

  • Shared/API/c/WKString.h:
4:47 PM Changeset in webkit [100085] by annacc@chromium.org
  • 6 edits
    58 adds in trunk

Add WebVTT parsing layout tests. Patch also includes creating a TextTrackCueList
in TextTrack::cues() and observing WebVTT chronological cue order.
​https://bugs.webkit.org/show_bug.cgi?id=72215

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-webvtt-tc000-empty.html

media/track/track-webvtt-tc001-utf8.html
media/track/track-webvtt-tc002-bom.html
media/track/track-webvtt-tc003-newlines.html
media/track/track-webvtt-tc004-magic-header.html
media/track/track-webvtt-tc005-header-comment.html
media/track/track-webvtt-tc006-cue-identifiers.html
media/track/track-webvtt-tc007-cue-no-id.html
media/track/track-webvtt-tc008-timings-no-hours.html
media/track/track-webvtt-tc009-timings-hour.html
media/track/track-webvtt-tc010-no-timings.html
media/track/track-webvtt-tc011-blank-lines.html
media/track/track-webvtt-tc012-out-of-order.html
media/track/track-webvtt-tc013-settings.html
media/track/track-webvtt-tc014-alignment.html
media/track/track-webvtt-tc015-positioning.html
media/track/track-webvtt-tc016-align-positioning.html
media/track/track-webvtt-tc017-line-position.html
media/track/track-webvtt-tc018-align-text-line-position.html
media/track/track-webvtt-tc019-cue-size.html
media/track/track-webvtt-tc020-cue-size-align.html
media/track/track-webvtt-tc021-valign.html
media/track/track-webvtt-tc022-entities.html
media/track/track-webvtt-tc023-markup.html
media/track/track-webvtt-tc024-timestamp.html
media/track/track-webvtt-tc025-class-markup.html
media/track/track-webvtt-tc026-voice.html
media/track/track-webvtt-tc027-empty-cue.html
media/track/track-webvtt-tc028-unsupported-markup.html

  • html/TextTrack.cpp:

(WebCore::TextTrack::~TextTrack): Only call client if m_cues has been allocated.
(WebCore::TextTrack::cues): Create a TextTrackCueList if we don't already have one.

  • html/TextTrack.h: The cues() function can no longer be const.
  • html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::add): Only add the cue if the startTime comes after

all other startTimes in the list.

LayoutTests:

  • media/track/captions-webvtt/tc012-out-of-order.vtt: Fix typo.
  • media/track/track-webvtt-tc000-empty-expected.txt: Added.
  • media/track/track-webvtt-tc000-empty.html: Added.
  • media/track/track-webvtt-tc001-utf8-expected.txt: Added.
  • media/track/track-webvtt-tc001-utf8.html: Added.
  • media/track/track-webvtt-tc002-bom-expected.txt: Added.
  • media/track/track-webvtt-tc002-bom.html: Added.
  • media/track/track-webvtt-tc003-newlines-expected.txt: Added.
  • media/track/track-webvtt-tc003-newlines.html: Added.
  • media/track/track-webvtt-tc004-magic-header-expected.txt: Added.
  • media/track/track-webvtt-tc004-magic-header.html: Added.
  • media/track/track-webvtt-tc005-header-comment-expected.txt: Added.
  • media/track/track-webvtt-tc005-header-comment.html: Added.
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Added.
  • media/track/track-webvtt-tc006-cue-identifiers.html: Added.
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt: Added.
  • media/track/track-webvtt-tc007-cue-no-id.html: Added.
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Added.
  • media/track/track-webvtt-tc008-timings-no-hours.html: Added.
  • media/track/track-webvtt-tc009-timings-hour-expected.txt: Added.
  • media/track/track-webvtt-tc009-timings-hour.html: Added.
  • media/track/track-webvtt-tc010-no-timings-expected.txt: Added.
  • media/track/track-webvtt-tc010-no-timings.html: Added.
  • media/track/track-webvtt-tc011-blank-lines-expected.txt: Added.
  • media/track/track-webvtt-tc011-blank-lines.html: Added.
  • media/track/track-webvtt-tc012-out-of-order-expected.txt: Added.
  • media/track/track-webvtt-tc012-out-of-order.html: Added.
  • media/track/track-webvtt-tc013-settings-expected.txt: Added.
  • media/track/track-webvtt-tc013-settings.html: Added.
  • media/track/track-webvtt-tc014-alignment-expected.txt: Added.
  • media/track/track-webvtt-tc014-alignment.html: Added.
  • media/track/track-webvtt-tc015-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc015-positioning.html: Added.
  • media/track/track-webvtt-tc016-align-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc016-align-positioning.html: Added.
  • media/track/track-webvtt-tc017-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc017-line-position.html: Added.
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc018-align-text-line-position.html: Added.
  • media/track/track-webvtt-tc019-cue-size-expected.txt: Added.
  • media/track/track-webvtt-tc019-cue-size.html: Added.
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt: Added.
  • media/track/track-webvtt-tc020-cue-size-align.html: Added.
  • media/track/track-webvtt-tc021-valign-expected.txt: Added.
  • media/track/track-webvtt-tc021-valign.html: Added.
  • media/track/track-webvtt-tc022-entities-expected.txt: Added.
  • media/track/track-webvtt-tc022-entities.html: Added.
  • media/track/track-webvtt-tc023-markup-expected.txt: Added.
  • media/track/track-webvtt-tc023-markup.html: Added.
  • media/track/track-webvtt-tc024-timestamp-expected.txt: Added.
  • media/track/track-webvtt-tc024-timestamp.html: Added.
  • media/track/track-webvtt-tc025-class-markup-expected.txt: Added.
  • media/track/track-webvtt-tc025-class-markup.html: Added.
  • media/track/track-webvtt-tc026-voice-expected.txt: Added.
  • media/track/track-webvtt-tc026-voice.html: Added.
  • media/track/track-webvtt-tc027-empty-cue-expected.txt: Added.
  • media/track/track-webvtt-tc027-empty-cue.html: Added.
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Added.
  • media/track/track-webvtt-tc028-unsupported-markup.html: Added.
3:27 PM Changeset in webkit [100084] by nduca@chromium.org
  • 4 edits in trunk/Source/WebCore

Fixes to GraphicsContext3D::makeCurrent on gtk and mac
​https://bugs.webkit.org/show_bug.cgi?id=72218

Unreviewed. Forgot to handle corner cases. Thanks Nico!

  • platform/graphics/gtk/GraphicsContext3DGtk.cpp:

(WebCore::GraphicsContext3D::makeContextCurrent):

  • platform/graphics/gtk/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::makeContextCurrent):

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::makeContextCurrent):

2:13 PM Changeset in webkit [100083] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

<rdar://problem/10294191> REGRESSION (WebKit2): Lookup bubble sized and positioned incorrectly (vertically off)
​https://bugs.webkit.org/show_bug.cgi?id=72217

Reviewed by Dave Hyatt.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didPerformDictionaryLookup): Rather than adding the NSFont’s ascender
to the top of the text rect to establish the baseline here...

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupForRange): ...do it here, using the WebCore::Font’s
ascender, which is what’s actually used when drawing the text.

10:43 AM Changeset in webkit [100082] by Patrick Gansterer
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed. Add ENABLE(DFG_JIT) around DFGCorrectableJumpPoint code.

  • dfg/DFGCorrectableJumpPoint.cpp:
  • dfg/DFGCorrectableJumpPoint.h:
9:30 AM Changeset in webkit [100081] by Patrick Gansterer
  • 3 edits in trunk/Source/JavaScriptCore

[CMake] Move list of DFG source files into correct file
​https://bugs.webkit.org/show_bug.cgi?id=72212

Reviewed by Daniel Bates.

The DFG files are platform independent. So move them from
the EFL specific file into the general CMakeLists.txt.

  • CMakeLists.txt:
  • PlatformEfl.cmake:
8:14 AM Changeset in webkit [100080] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Fix "unused variable" warning in JSLock
​https://bugs.webkit.org/show_bug.cgi?id=72213

Reviewed by Anders Carlsson.

Use ASSERT_UNUSED() instead of ASSERT() to make sure
that the variable is also used in the release build.

  • runtime/JSLock.cpp:

(JSC::JSLock::lock):
(JSC::JSLock::unlock):

5:51 AM Changeset in webkit [100079] by Patrick Gansterer
  • 6 edits in trunk/Source/WebCore

Add stub implementation for SVGResources::filter()
​https://bugs.webkit.org/show_bug.cgi?id=72211

Reviewed by Dirk Schulze.

Add an empty implementation, which only returns 0 for !ENABLE(FILTERS)
to reduce the #if ENABLE(FILTERS) complexity a bit.

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::selfWillPaint):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::selfWillPaint):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::filtersForceContainerLayout):

  • rendering/svg/SVGResources.h:

(WebCore::SVGResources::filter):

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientLayoutChanged):
(WebCore::SVGResourcesCache::clientUpdatedFromElement):

5:33 AM Changeset in webkit [100078] by Antti Koivisto
  • 3 edits
    2 adds in trunk

REGRESSION(r98542): Rendering error on Google maps
​https://bugs.webkit.org/show_bug.cgi?id=71996

Source/WebCore:

Reviewed by Andreas Kling.

r98542 exposed that StyleBoxData copy constructor and operator== are missing a field.

Test reduction by David Barr.

Test: fast/css/vertical-align-length-copy-bug.html

  • rendering/style/StyleBoxData.cpp:

(WebCore::StyleBoxData::StyleBoxData):
(WebCore::StyleBoxData::operator==):

LayoutTests:

Reviewed by Andreas Kling.

Test reduction by David Barr.

  • fast/css/vertical-align-length-copy-bug-expected.txt: Added.
  • fast/css/vertical-align-length-copy-bug.html: Added.
4:01 AM Changeset in webkit [100077] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix minor config typo in the build tool documentation
​https://bugs.webkit.org/show_bug.cgi?id=72194

Patch by Ariya Hidayat <​ariya@sencha.com> on 2011-11-12
Reviewed by Andreas Kling.

  • qmake/README:
3:09 AM Changeset in webkit [100076] by commit-queue@webkit.org
  • 10 edits
    2 deletes in trunk

Unreviewed, rolling out r100013.
​http://trac.webkit.org/changeset/100013
​https://bugs.webkit.org/show_bug.cgi?id=72210

It breaks all mac builds (Requested by WildFox on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-12

Source/WebCore:

  • html/HTMLAnchorElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLTextAreaElement.idl:

LayoutTests:

  • fast/forms/access-key-for-all-elements-expected.txt: Removed.
  • fast/forms/access-key-for-all-elements.html: Removed.
2:39 AM Changeset in webkit [100075] by Nikolas Zimmermann
  • 24 edits in trunk/Source/WebCore

2011-11-12 Nikolas Zimmermann <​nzimmermann@rim.com>

Finish SVGLengthContext conversion in svg/
​https://bugs.webkit.org/show_bug.cgi?id=72105

Reviewed by Antti Koivisto.

Make SVGLengthContext(const SVGElement*) explicit, adapt all remaining call sites.
Now that this process is finished, SVGLengthContext can be shared across renders,
so that its possible to override the length context in a single place. This will
be done in future patches.

Doesn't affect any tests yet.

  • bindings/js/JSSVGLengthCustom.cpp: (WebCore::JSSVGLength::value): (WebCore::JSSVGLength::setValue): (WebCore::JSSVGLength::convertToSpecifiedUnits):
  • bindings/scripts/CodeGeneratorObjC.pm: (GenerateImplementation):
  • bindings/v8/custom/V8SVGLengthCustom.cpp: (WebCore::V8SVGLength::valueAccessorGetter): (WebCore::V8SVGLength::valueAccessorSetter): (WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):
  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
  • rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::layout):
  • rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::updateFromElement):
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::zeroLengthSubpathRect): (WebCore::RenderSVGPath::calculateMarkerBoundsIfNeeded):
  • rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::referencePoint): (WebCore::RenderSVGResourceMarker::calcViewport):
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox):
  • rendering/svg/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::calcViewport):
  • rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::applyStrokeStyleToContext):
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::operator<<):
  • rendering/svg/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeContainerElement::containerTranslation):
  • rendering/svg/SVGTextChunkBuilder.cpp: (WebCore::SVGTextChunkBuilder::addTextChunk):
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::extractFloatValuesFromSVGLengthList):
  • rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::parentDefinesTextLength): (WebCore::SVGTextLayoutEngine::beginTextPathLayout):
  • rendering/svg/SVGTextLayoutEngineBaseline.cpp: (WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift):
  • rendering/svg/SVGTextLayoutEngineSpacing.cpp: (WebCore::SVGTextLayoutEngineSpacing::calculateCSSKerningAndSpacing):
  • svg/SVGElement.h:
  • svg/SVGLengthContext.cpp: (WebCore::SVGLengthContext::determineViewport):
  • svg/SVGLengthContext.h:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::viewport): (WebCore::SVGSVGElement::localCoordinateSpaceTransform): (WebCore::SVGSVGElement::currentViewBoxRect):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::toClipPath):
12:52 AM Changeset in webkit [100074] by Patrick Gansterer
  • 2 edits in trunk

[CMake] Use MAIN_DEPENDENCY in GENERATE_* macros
​https://bugs.webkit.org/show_bug.cgi?id=71365

Reviewed by Daniel Bates.

Use the MAIN_DEPENDENCY instead of DEPENDS in the custom build commands.
This adds better IDE support for such targets.

  • Source/cmake/WebKitMacros.cmake:
12:40 AM Changeset in webkit [100073] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for !ENABLE(FILTERS) after r100036.

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::filtersForceContainerLayout):

Note: See TracTimeline for information about the timeline view.