Context Navigation

← Previous Period
Next Period →

Timeline

Nov 17, 2011:

11:42 PM Changeset in webkit [100730] by loki@webkit.org

2 edits in trunk/LayoutTests

[Qt] REGRESSION(r100510): Enable 8 Bit Strings in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=72602

Unskip tests after the fix on Qt.

platform/qt/Skipped:

11:41 PM Changeset in webkit [100729] by loki@webkit.org

2 edits in trunk/Source/JavaScriptCore

[Qt] REGRESSION(r100510): Enable 8 Bit Strings in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=72602

Fixed StringImpl::foldCase by adding return in the case we need to handle
folding of 8 bit strings with Latin-1 characters.

Fixed case where StringImpl::replace was using a char temp instead of an
LChar temp.

Because of the second change, I changed other uses of char or
unsigned char to LChar.

Patch by Michael Saboff <msaboff@apple.com> on 2011-11-17
Reviewed by Zoltan Herczeg.

wtf/text/StringImpl.cpp:

(WTF::StringImpl::upper):
(WTF::StringImpl::foldCase):
(WTF::equal):
(WTF::equalIgnoringCase):
(WTF::StringImpl::replace):

11:27 PM Changeset in webkit [100728] by bashi@chromium.org

2 edits in trunk/Source/WebCore

crash: WebCore::FontPlatformData::roundsGlyphAdvances on Lion
https://bugs.webkit.org/show_bug.cgi?id=71997

Reviewed by Dan Bernstein.

The cause is a null dereference of a fontData that is stored in
ComplexTextRun. The fontData is initialized by using the
fontCache, but it could be null when the font is in fallback
list. The reason a font from the fallback list might not be in the
font Cache is that it may be a web font. Before looking up the
fontCache, try to see whether the font is in the fallback list.

No new tests. We don't have webfonts that can produce the problem.

platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): See fallback list first, then lookup cache.

10:57 PM Changeset in webkit [100727] by commit-queue@webkit.org

13 edits in trunk

Remove initProgressEvent method
https://bugs.webkit.org/show_bug.cgi?id=71340

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-11-17
Reviewed by Adam Barth.

This method has been removed from the spec draft.
http://www.w3.org/TR/progress-events/#interface-progressevent

Source/WebCore:

No new tests. Removed method.

dom/ProgressEvent.cpp:
dom/ProgressEvent.h:
dom/ProgressEvent.idl:

LayoutTests:

No new tests. Removed method. Updated expected results.

fast/dom/non-numeric-values-numeric-parameters-expected.txt:
fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
fast/events/init-events-expected.txt:
fast/events/script-tests/init-events.js:
fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:

10:14 PM Changeset in webkit [100726] by commit-queue@webkit.org

3 edits
2 adds in trunk/Source/WebCore

[EFL] Move keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName() to the
EflKeyboardUtilities.cpp to use in the WebKit2
https://bugs.webkit.org/show_bug.cgi?id=62451

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2011-11-17
Reviewed by Martin Robinson.

The keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName() were static functions
in the PlatformKeyboardEventEfl.cpp. But they are also needed in the WebKit2 EFL port, so I
moved them to the separated file - EflKeyboardUtilities.cpp.

PlatformEfl.cmake:
platform/efl/EflKeyboardUtilities.cpp: Copied from Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp.

(WebCore::createKeyMap):
(WebCore::createWindowsKeyMap):
(WebCore::keyIdentifierForEvasKeyName):
(WebCore::windowsKeyCodeForEvasKeyName):

platform/efl/EflKeyboardUtilities.h: Added.
platform/efl/PlatformKeyboardEventEfl.cpp:

10:09 PM Changeset in webkit [100725] by Martin Robinson

7 edits in trunk/Source

[GTK] The process freezes when you right click on windowless Flash
https://bugs.webkit.org/show_bug.cgi?id=69123

Reviewed by Xan Lopez.

Source/WebCore:

No new tests. I tried to create a layout test that exercised this
issue, but it appears that EventSender clicks do not trigger
it. This is covered by the manual tests containing Flash.

plugins/PluginPackage.cpp:

(WebCore::PluginPackage::determineQuirks): Always activate the
windowless Flash quirk if on x86_64 and X11.

plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::handleMouseEvent): Avoid sending right-click
events if we have the quirk.

Source/WebKit2:

Add a new plugin quirk for dealing with right-clicking on
windowless Flash on x86_64 machines. This already exists for
WebKit1.

Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::NetscapePluginModule::determineQuirks): If the plugin is
Flash and we are on x86_64, then disable sending right-clicking
events while in windowless mode.

Shared/Plugins/PluginQuirks.h: Add the new quirk.
WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformHandleMouseEvent): If the quirk
is active don't send right click events.

9:52 PM Changeset in webkit [100724] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/efl

[EFL] Add matrix list to reuse tile matrix for each different zoom level.
https://bugs.webkit.org/show_bug.cgi?id=68595

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-11-17
Reviewed by Kenneth Rohde Christiansen.

Add matrix list to keep each tile matrix corresponding to each different zoom level when zoom level is changed.
Then backing store can reuse tile matrix by getting it from this matrix list.

ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_model_matrix_create):
(_ewk_tiled_backing_store_smart_calculate):
(_ewk_tiled_backing_store_zoom_set_internal):

ewk/ewk_tiled_matrix.cpp:

(ewk_tile_matrix_entry_get):
(_ewk_tile_matrix_cell_free):
(_ewk_tile_matrix_tile_free):
(ewk_tile_matrix_new):
(ewk_tile_matrix_zoom_level_set):
(ewk_tile_matrix_invalidate):
(ewk_tile_matrix_free):
(ewk_tile_matrix_tile_new):

ewk/ewk_tiled_matrix.h:

9:47 PM Changeset in webkit [100723] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: clear fixme in generator script
https://bugs.webkit.org/show_bug.cgi?id=71372

Remove unnecessary field name map and update license year number.

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-11-17
Reviewed by Pavel Feldman.

inspector/CodeGeneratorInspector.py:

9:43 PM Changeset in webkit [100722] by commit-queue@webkit.org

8 edits in trunk

[EFL] Clean up the use of DATA_DIR in the buildsystem
https://bugs.webkit.org/show_bug.cgi?id=72681

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-17
Reviewed by Daniel Bates.

Source/cmake/OptionsEfl.cmake: Rename DATA_DIR to DATA_INSTALL_DIR

and add it to the cache; add a variable with the path of the generated
theme and remove the -DDATA_DIR definition, it was moved to
PlatformEFL.cmake in WebCore.

Source/WebCore:

Add the -DDATA_DIR definition here instead of defining it globally in
OptionsEfl.cmake, as WebCore is the only place which needs it.

No new tests, this is a buildsystem change.

PlatformEfl.cmake:

Source/WebKit/efl:

Instead of messing with BUILD_DATA_DIR and PARENT_SCOPE, just use
THEME_BINARY_DIR as defined in OptionsEfl.cmake.

CMakeListsEfl.txt:

Tools:

Instead of adding -DDATA_DIR in all scopes, only define it in
WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
it.

We can then define DATA_DIR to the generated theme directory for
EWebLauncher, since it's what we want here.

CMakeListsEfl.txt:

9:41 PM Changeset in webkit [100721] by adamk@chromium.org

6 edits
2 adds in trunk

Move JS recursion counter from V8Proxy to V8BindingPerIsolateData
https://bugs.webkit.org/show_bug.cgi?id=72645

Reviewed by Adam Barth.

Source/WebCore:

With the JS recursion level stored as a member of V8Proxy, it's tied
to a frame. But this is incorrect, as there's no reason that a JS call
stack need be restricted to a single frame (see my new test case for
an example of code going across frames).

In order to get the correct accounting of JS recursion level, per-Isolate
is the right granularity (per dslomov), which is what this patch accomplishes.

Test: storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html

bindings/v8/V8Binding.cpp:

(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):

bindings/v8/V8Binding.h:

(WebCore::V8BindingPerIsolateData::recursionLevel):
(WebCore::V8BindingPerIsolateData::incrementRecursionLevel):
(WebCore::V8BindingPerIsolateData::decrementRecursionLevel):
(WebCore::V8RecursionScope::V8RecursionScope):
(WebCore::V8RecursionScope::~V8RecursionScope):

bindings/v8/V8Proxy.cpp:

(WebCore::incrementRecursionLevel):
(WebCore::decrementRecursionLevel):
(WebCore::recursionLevel):
(WebCore::V8Proxy::V8Proxy):
(WebCore::V8Proxy::runScript):
(WebCore::V8Proxy::callFunction):
(WebCore::V8Proxy::didLeaveScriptContext):

bindings/v8/V8Proxy.h:

LayoutTests:

Added tests to exercise new timing of call to V8Proxy::didLeaveScriptContext().

storage/indexeddb/transaction-abort-with-js-recursion-cross-frame-expected.txt: Added.
storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html: Added.

9:38 PM Changeset in webkit [100720] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] Move platform includes last in DRT's include directories.
https://bugs.webkit.org/show_bug.cgi?id=72684

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-17
Reviewed by Daniel Bates.

This is the first step in fixing the build when a platform include (in
this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
is included instead of WebKit's.

DumpRenderTree/efl/CMakeLists.txt:

9:30 PM Changeset in webkit [100719] by pkasting@chromium.org

3 edits in trunk/LayoutTests

[chromium] acid3.html didn't actually get rebaselined like I wanted.

Unreviewed, gardening.

platform/chromium-mac-snowleopard/http/tests/misc/acid3-expected.png:
platform/chromium/test_expectations.txt:

9:25 PM Changeset in webkit [100718] by commit-queue@webkit.org

5 edits
3 adds in trunk

[chromium] Font::drawComplexText can not draw a segment of text run
https://bugs.webkit.org/show_bug.cgi?id=72095

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2011-11-17
Reviewed by Adam Barth.

Source/WebCore:

drawComplexText() should respect the 'from' and 'to' arguments.
Drawing the whole text run may result in text overlapping.

Test: platform/chromium-linux/fast/text/international/draw-complex-text-from-to.html

platform/graphics/chromium/ComplexTextControllerLinux.cpp:

(WebCore::ComplexTextController::glyphsForRange):

platform/graphics/chromium/ComplexTextControllerLinux.h:
platform/graphics/chromium/FontLinux.cpp:

(WebCore::Font::drawComplexText):

LayoutTests:

platform/chromium-linux/fast/text/international/draw-complex-text-from-to-expected.png: Added.
platform/chromium-linux/fast/text/international/draw-complex-text-from-to-expected.txt: Added.
platform/chromium-linux/fast/text/international/draw-complex-text-from-to.html: Added.

9:02 PM Changeset in webkit [100717] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Fix broken expectation.

Unreviewed, gardening.

platform/chromium/test_expectations.txt:

8:58 PM Changeset in webkit [100716] by abarth@webkit.org

6 edits in trunk/Source/WebCore

Unique SecurityOrigins shouldn't remember their old schemes and hosts
https://bugs.webkit.org/show_bug.cgi?id=71745

Reviewed by Darin Adler.

This is the final step in this series of patches.

This patch removes the forceUnique flag from SecurityOrigin::create.
Now, we create unique origins without passing in the document's URL,
preventing information from the document's URL from leaking into the
unique origin.

WebCore.exp.in:
dom/Document.cpp:

(WebCore::Document::setIsViewSource):
(WebCore::Document::initSecurityContext):

loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::getOriginsWithCache):

Update this callsite to use createFromString, which does exactly what this code is doing manually.

page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::create):

page/SecurityOrigin.h:

8:55 PM Changeset in webkit [100715] by scheib@chromium.org

7 edits in trunk/Source

Pointer Lock: Page Settings unecessary
https://bugs.webkit.org/show_bug.cgi?id=72662

Reviewed by Darin Fisher.

Source/WebCore:

No new tests.

page/Settings.cpp:

(WebCore::Settings::Settings):

page/Settings.h:

Source/WebKit/chromium:

public/WebSettings.h:
src/WebSettingsImpl.cpp:
src/WebSettingsImpl.h:

8:30 PM Changeset in webkit [100714] by cevans@google.com

2 edits
6 copies in branches/chromium/912

Merge 99744
BUG=99732

8:23 PM Changeset in webkit [100713] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Don't clamp minimumPageScaleFactor when doc width is zero
https://bugs.webkit.org/show_bug.cgi?id=72679

Patch by Alexandre Elias <aelias@google.com> on 2011-11-17
Reviewed by James Robinson.

For a brief period during initialization, the document width can be
zero. In that situation, don't try to limit minimumPageScaleFactor
to the document size.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setPageScaleFactorLimits):

8:13 PM Changeset in webkit [100712] by pkasting@chromium.org

9 edits
20 adds
7 deletes in trunk/LayoutTests

[chromium] Try to rebaseline more tests.

Unreviewed, gardening.

platform/chromium-cg-mac-leopard/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
platform/chromium-cg-mac-leopard/fast/box-shadow/single-pixel-shadow-expected.png: Added.
platform/chromium-cg-mac-leopard/fast/css/shadow-multiple-expected.png:
platform/chromium-cg-mac-snowleopard/fast/layers/layer-absolute-parent-opacity-expected.png: Added.
platform/chromium-cg-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.png: Added.
platform/chromium-cg-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.txt: Added.
platform/chromium-cg-mac/fast/repaint/moving-shadow-on-path-expected.png: Removed.
platform/chromium-linux-x86/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
platform/chromium-linux-x86/fast/box-shadow/single-pixel-shadow-expected.png: Added.
platform/chromium-linux/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
platform/chromium-linux/fast/box-shadow/single-pixel-shadow-expected.png: Added.
platform/chromium-linux/fast/css/shadow-multiple-expected.png: Added.
platform/chromium-mac-leopard/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
platform/chromium-mac-leopard/fast/box-shadow/single-pixel-shadow-expected.png: Added.
platform/chromium-mac-leopard/fast/css/color-correction-on-box-shadow-expected.png: Removed.
platform/chromium-mac-leopard/fast/css/color-correction-on-text-shadow-expected.png: Removed.
platform/chromium-mac-leopard/fast/css/shadow-multiple-expected.png: Added.
platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.png:
platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-clipped-slices-expected.png:
platform/chromium-mac-snowleopard/fast/box-shadow/single-pixel-shadow-expected.png: Added.
platform/chromium-mac-snowleopard/fast/css/shadow-multiple-expected.png:
platform/chromium-mac-snowleopard/fast/layers/layer-absolute-parent-opacity-expected.png: Added.
platform/chromium-mac-snowleopard/fast/multicol/shadow-breaking-expected.png: Added.
platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.png: Added.
platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.png: Removed.
platform/chromium-mac/fast/css/color-correction-on-text-shadow-expected.png: Removed.
platform/chromium-mac/fast/multicol/shadow-breaking-expected.png: Removed.
platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png: Removed.
platform/chromium-win-xp/fast/css/shadow-multiple-expected.png: Added.
platform/chromium-win-xp/fast/multicol/shadow-breaking-expected.png:
platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
platform/chromium-win/fast/box-shadow/single-pixel-shadow-expected.png: Added.
platform/chromium-win/fast/css/shadow-multiple-expected.png:
platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
platform/chromium/test_expectations.txt:

8:12 PM Changeset in webkit [100711] by cevans@google.com

1 edit
2 copies in branches/chromium/912

Merge 100502
BUG=102359
Review URL: http://codereview.chromium.org/8598007

8:09 PM Changeset in webkit [100710] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[chromium] Disable incremental uploading in threaded compositing path
https://bugs.webkit.org/show_bug.cgi?id=72669

Patch by James Robinson <jamesr@chromium.org> on 2011-11-17
Reviewed by Kenneth Russell.

Since we don't currently support atomic incremental uploads, incremental uploads in the threaded path result in
very strange-looking texture popping as tiles come in on pages that require more than 16 tile uploads per frame.
This disables that logic (by setting the upload limit per frame to 99999) until we handle the incremental
updates in an atomic fashion.

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):

6:51 PM Changeset in webkit [100709] by pkasting@chromium.org

4 edits
1 copy in trunk/LayoutTests

[chromium] Attempt to rebaseline a test after http://crrev.com/110053 .

Unreviewed, gardening.

platform/chromium-linux-x86/fast/repaint/moving-shadow-on-path-expected.txt: Copied from platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.txt.
platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.png:
platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png:
platform/chromium/test_expectations.txt:

6:08 PM Changeset in webkit [100708] by nduca@chromium.org

5 edits in trunk/Source

[chromium] Fix handling of setNeedsCommit and setNeedsAnimate in threaded mode
https://bugs.webkit.org/show_bug.cgi?id=71638

Reviewed by James Robinson.

Source/WebCore:

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::setNeedsAnimate):
(WebCore::CCThreadProxy::beginFrameAndCommit):

Source/WebKit/chromium:

tests/CCLayerTreeHostTest.cpp:

(TestHooks::animateAndLayout):
(MockLayerTreeHostClient::animateAndLayout):
(CCLayerTreeHostTest::postSetNeedsAnimateToMainThread):
(CCLayerTreeHostTest::dispatchSetNeedsAnimate):
(CCLayerTreeHostTestSetNeedsAnimate::CCLayerTreeHostTestSetNeedsAnimate):
(CCLayerTreeHostTestSetNeedsAnimate::beginTest):
(CCLayerTreeHostTestSetNeedsAnimate::animateAndLayout):
(CCLayerTreeHostTestSetNeedsAnimate::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsAnimate::afterTest):

5:46 PM Changeset in webkit [100707] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Mark some inspector tests as flakily crashing.
https://bugs.webkit.org/show_bug.cgi?id=72651

Unreviewed, gardening.

platform/chromium/test_expectations.txt:

5:46 PM Changeset in webkit [100706] by abarth@webkit.org

2 edits in trunk/Source/WebCore

Remove bogus ASSERT.

page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):

5:28 PM Changeset in webkit [100705] by pkasting@chromium.org

3 edits
2 copies in trunk

Unreviewed, rolling out r100698.
http://trac.webkit.org/changeset/100698
https://bugs.webkit.org/show_bug.cgi?id=72239

This change wasn't the problem either.

Source/WebCore:

dom/Document.cpp:

(WebCore::Document::implicitClose):

LayoutTests:

accessibility/loading-iframe-sends-notification.html: Copied from LayoutTests/accessibility/loading-iframe-sends-notification.html.
platform/chromium/accessibility/loading-iframe-sends-notification-expected.txt: Copied from LayoutTests/platform/chromium/accessibility/loading-iframe-sends-notification-expected.txt.

5:21 PM Changeset in webkit [100704] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Don't include internal GTK headers so we build with GTK_DISABLE_SINGLE_INCLUDES

https://bugs.webkit.org/show_bug.cgi?id=72653

Patch by Elliot Glaysher <erg@chromium.org> on 2011-11-17
Reviewed by James Robinson.

src/gtk/WebInputEventFactory.cpp:

(WebKit::gdkStateToWebEventModifiers): Remove a
GTK_CHECK_VERSION that will always be true, as the oldest
libgtk we support is 2.18.

5:18 PM Changeset in webkit [100703] by mrowe@apple.com

8 edits in trunk/Source

Roll out r100668 until I can work out why we're using such an ancient version of Xcode on our SnowLeopard bots.

4:48 PM Changeset in webkit [100702] by commit-queue@webkit.org

7 edits in trunk/Source

[Chromium] Calls to paintContentsIfDirty() and updateCompositorResources() should be balanced.
https://bugs.webkit.org/show_bug.cgi?id=72630

Patch by David Reveman <reveman@chromium.org> on 2011-11-17
Reviewed by James Robinson.

Source/WebCore:

Layer property changes during paintContent() can leave the layer
in an invalid state as paintContentsIfDirty() has been called
without a matching updateCompositorResources() call. Removing
conditionals around these calls ensure they are balanced.

This patch is tested by the following unit test:

CCLayerTreeHostTestOpacityChange.runMultiThread

platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):

platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::updateCompositorResources):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

Add test that check if calls to paintContentsIfDirty() and
updateCompositorResources() are balanced when layer opacity
changes during paintContent().

tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::layerTreeHost):
(WTF::TestOpacityChangeLayerDelegate::TestOpacityChangeLayerDelegate):
(WTF::TestOpacityChangeLayerDelegate::paintContents):
(WTF::TestOpacityChangeLayerDelegate::drawsContent):
(WTF::TestOpacityChangeLayerDelegate::preserves3D):
(WTF::TestOpacityChangeLayerDelegate::notifySyncRequired):
(WTF::ContentLayerChromiumWithUpdateTracking::create):
(WTF::ContentLayerChromiumWithUpdateTracking::paintContentsCount):
(WTF::ContentLayerChromiumWithUpdateTracking::resetPaintContentsCount):
(WTF::ContentLayerChromiumWithUpdateTracking::updateCount):
(WTF::ContentLayerChromiumWithUpdateTracking::resetUpdateCount):
(WTF::ContentLayerChromiumWithUpdateTracking::paintContentsIfDirty):
(WTF::ContentLayerChromiumWithUpdateTracking::updateCompositorResources):
(WTF::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
(WTF::CCLayerTreeHostTestOpacityChange::CCLayerTreeHostTestOpacityChange):
(WTF::CCLayerTreeHostTestOpacityChange::beginTest):
(WTF::CCLayerTreeHostTestOpacityChange::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestOpacityChange::afterTest):
(WTF::TEST_F):

4:47 PM Changeset in webkit [100701] by Patrick Gansterer

4 edits in trunk/Source/JavaScriptCore

[CMake] Move FAST_MALLOC specific lines from Platform*.cmake to CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=72644

Reviewed by Brent Fulgham.

All ports need to do the same determination about fast malloc. Move the CMake code from
platform specific files into the generic one, so that additional ports can reuse it.

wtf/CMakeLists.txt:
wtf/PlatformEfl.cmake:
wtf/PlatformWinCE.cmake:

4:46 PM Changeset in webkit [100700] by rniwa@webkit.org

3 edits in trunk/Tools

fuzzy_match doesn't recognize "Dan B" or "hyatt"
https://bugs.webkit.org/show_bug.cgi?id=72636

Reviewed by Eric Seidel.

Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
and user names of email addreses such as rniwa in rniwa@webkit.org.

Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.

Scripts/webkitpy/common/config/committers.py:
Scripts/webkitpy/common/config/committers_unittest.py:

4:39 PM Changeset in webkit [100699] by eric@webkit.org

3 edits in trunk/Tools

Remove support for running check-webkit-style w/o a webkit checkout
https://bugs.webkit.org/show_bug.cgi?id=72678

Reviewed by Adam Barth.

After talking to Dave Levin we've decided to remove this
code. I know of no users of check-webkit-style w/o a webkit checkout
and this needlessly adds complexity.

Scripts/webkitpy/style/main.py:

4:27 PM Changeset in webkit [100698] by pkasting@chromium.org

3 edits
2 deletes in trunk

Source/WebCore: Remove cargo-cult copy/pasting of ScriptExecutionContext namespace
https://bugs.webkit.org/show_bug.cgi?id=72676

Patch by Adam Barth <abarth@webkit.org> on 2011-11-17
Reviewed by Eric Seidel.

It looks like this cargo-cult started with initDNSPrefetch being hacked
into setSecurityOrigin. I've removed this hack along with the
copy/paste code.

dom/DOMImplementation.cpp:
dom/Document.cpp:

(WebCore::Document::setIsViewSource):
(WebCore::Document::open):
(WebCore::Document::initSecurityContext):
(WebCore::Document::setSecurityOrigin):

dom/Document.h:
xml/XSLTProcessor.cpp:

LayoutTests: Unreviewed, rolling out r100584.
http://trac.webkit.org/changeset/100584
https://bugs.webkit.org/show_bug.cgi?id=72239

See if this change caused Linux dbg crashes.

accessibility/loading-iframe-sends-notification.html: Removed.
platform/chromium/accessibility/loading-iframe-sends-notification-expected.txt: Removed.

4:23 PM Changeset in webkit [100697] by eric@webkit.org

7 edits in trunk/Tools

Remove more direct uses of os.path
https://bugs.webkit.org/show_bug.cgi?id=72677

Reviewed by Adam Barth.

Remove more uses of os.path, including refactoring
CommitterValidator to use a Host object instead of
manual hacks to emulate what SCM and FileSystem provide.

Scripts/webkitpy/common/checkout/changelog.py:
Scripts/webkitpy/common/config/committervalidator.py:
Scripts/webkitpy/common/config/committervalidator_unittest.py:
Scripts/webkitpy/common/system/filesystem_mock.py:
- Turns out none of our unittests actually looked at this path. now I've made it be a valid path.
Scripts/webkitpy/tool/bot/feeders.py:
Scripts/webkitpy/tool/commands/queues.py:

4:20 PM Changeset in webkit [100696] by abarth@webkit.org

5 edits in trunk/Source/WebCore

Remove cargo-cult copy/pasting of ScriptExecutionContext namespace
https://bugs.webkit.org/show_bug.cgi?id=72676

Reviewed by Eric Seidel.

It looks like this cargo-cult started with initDNSPrefetch being hacked
into setSecurityOrigin. I've removed this hack along with the
copy/paste code.

dom/DOMImplementation.cpp:
dom/Document.cpp:

(WebCore::Document::setIsViewSource):
(WebCore::Document::open):
(WebCore::Document::initSecurityContext):
(WebCore::Document::setSecurityOrigin):

dom/Document.h:
xml/XSLTProcessor.cpp:

4:11 PM Changeset in webkit [100695] by pkasting@chromium.org

14 edits in trunk/Source

Unreviewed, rolling out r100676.
http://trac.webkit.org/changeset/100676
https://bugs.webkit.org/show_bug.cgi?id=72393

Looks like r100572 was not the source of the crashes.

Source/WebCore:

bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::canSetScriptSource):

bindings/js/ScriptDebugServer.h:
bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::canSetScriptSource):

bindings/v8/ScriptDebugServer.h:
inspector/CodeGeneratorInspector.py:
inspector/Inspector.json:
inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::getCapabilities):

inspector/InspectorDebuggerAgent.h:
inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype.enableDebugger):
(WebInspector.DebuggerModel.prototype.disableDebugger):
(WebInspector.DebuggerModel.prototype.canSetScriptSource):

inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):

inspector/front-end/Settings.js:

Source/WebKit/chromium:

src/js/DevTools.js:

3:55 PM Changeset in webkit [100694] by eric@webkit.org

4 edits in trunk/Tools

Teach TextFileReader about FileSystem
https://bugs.webkit.org/show_bug.cgi?id=72673

Reviewed by Adam Barth.

Unfortunately TextFileReader doesn't use FileSystem
everywhere yet, so we can't move the unittests to
using MockFileSystem, but we're close.

Scripts/webkitpy/style/filereader.py:
Scripts/webkitpy/style/filereader_unittest.py:
Scripts/webkitpy/style/main.py:

3:53 PM Changeset in webkit [100693] by commit-queue@webkit.org

4 edits
3 adds in trunk

Absolute child is not repainted when parent opacity changes
https://bugs.webkit.org/show_bug.cgi?id=68777

Patch by Konstantin Scheglov <scheglov@google.com> on 2011-11-17
Reviewed by Simon Fraser.

Source/WebCore:

First time when we change opacity for parent we don't have layer, so
diff=StyleDifferenceRepaint is used instead of diff=StyleDifferenceRepaintLayer.
Layer is created later, in styleDidChange().
So, when we recalculate later diff, we now check for diff=StyleDifferenceRepaintLayer and
performs repaintIncludingDescendants().

Test: fast/layers/layer-absolute-parent-opacity.html

rendering/RenderObject.cpp:

(WebCore::RenderObject::setStyle): Call repaintIncludingDescendants() instead of repaint().

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): Add ContextSensitivePropertyOpacity when change opacity.

LayoutTests:

fast/layers/layer-absolute-parent-opacity-expected.png: Added.
fast/layers/layer-absolute-parent-opacity-expected.txt: Added.
fast/layers/layer-absolute-parent-opacity.html: Added.

3:35 PM Changeset in webkit [100692] by Nate Chapin

2 edits in trunk/Source/WebCore

r100311 dropped a RefPtr that is very
helpful. Add it back.
https://bugs.webkit.org/show_bug.cgi?id=72647

Reviewed by Adam Barth.

http/tests/misc/xslt-bad-import.html should
stop crashing in full chromium builds.

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::loadDone):

3:33 PM Changeset in webkit [100691] by abarth@webkit.org

3 edits in trunk/Source/WebCore

Refactor SecurityOrigin::create to be easier to understand
https://bugs.webkit.org/show_bug.cgi?id=72342

Reviewed by Eric Seidel.

Over time, the SecurityOrigin constructor has grown a bit out of
control. This patch attempts to separate the different concerns into
free functions. The general approach is to put more logic in the
"create" function and introduce a simple constructor for unique
origins.

This patch shouldn't change any behavior.

page/SecurityOrigin.cpp:

(WebCore::schemeRequiresAuthority):
(WebCore::shouldUseInnerURL):
(WebCore::extractInnerURL):
(WebCore::isDirectory):
(WebCore::shouldTreatAsUniqueOrigin):
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::create):
(WebCore::SecurityOrigin::createUnique):
(WebCore::SecurityOrigin::databaseIdentifier):

page/SecurityOrigin.h:

3:27 PM Changeset in webkit [100690] by enne@google.com

9 edits
4 adds
11 deletes in trunk/LayoutTests

[chromium] Unreviewed, rebaseline tests after r100545.

platform/chromium-cg-mac/compositing/geometry/fixed-position-expected.png: Removed.
platform/chromium-cg-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Removed.
platform/chromium-cg-mac/compositing/geometry/vertical-scroll-composited-expected.png: Removed.
platform/chromium-cg-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Removed.
platform/chromium-linux/compositing/geometry/fixed-position-expected.png:
platform/chromium-linux/compositing/geometry/horizontal-scroll-composited-expected.png: Removed.
platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
platform/chromium-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
platform/chromium-mac/compositing/geometry/fixed-position-expected.png: Removed.
platform/chromium-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Removed.
platform/chromium-mac/compositing/geometry/vertical-scroll-composited-expected.png: Removed.
platform/chromium-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Removed.
platform/chromium-win/compositing/geometry/fixed-position-expected.png:
platform/chromium-win/compositing/geometry/horizontal-scroll-composited-expected.png:
platform/chromium-win/compositing/geometry/horizontal-scroll-composited-expected.txt: Removed.
platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.txt: Removed.
platform/chromium-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
platform/chromium/compositing/geometry/fixed-position-expected.png: Added.
platform/chromium/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
platform/chromium/compositing/geometry/vertical-scroll-composited-expected.png: Added.
platform/chromium/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
platform/chromium/test_expectations.txt:

3:22 PM Changeset in webkit [100689] by eric@webkit.org

5 edits in trunk/Tools

Give check-webkit-style a Host
https://bugs.webkit.org/show_bug.cgi?id=72670

Reviewed by Adam Barth.

Scripts/webkitpy/common/checkout/scm/detection.py:
Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
- We don't run these unittests, but this one was looking for the wrong exception.
Scripts/webkitpy/style/main.py:
Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
- This was create a new scm object even though it already had one?

3:22 PM Changeset in webkit [100688] by dmazzoni@google.com

2 edits in trunk/LayoutTests

Unreviewed - skipping accessibility/loading-iframe-sends-notification.html
on Mac until bug 72624 is resolved.

3:19 PM Changeset in webkit [100687] by commit-queue@webkit.org

4 edits
1 delete in trunk/LayoutTests

Implement CSS3 Images cross-fade() image function
https://bugs.webkit.org/show_bug.cgi?id=52162
<rdar://problem/10209254>

Patch by Tim Horton <hortont424@gmail.com> on 2011-11-17
Reviewed by Simon Fraser.

Fix fast/css/getComputedStyle/computed-style-cross-fade.html to use the "dummy" protocol for its
images, so that we don't have loading errors.

Unskip the test on Qt.

Remove the (now) unnecessary Gtk baselines.

fast/css/getComputedStyle/computed-style-cross-fade-expected.txt:
fast/css/getComputedStyle/computed-style-cross-fade.html:
platform/gtk/fast/css/getComputedStyle/computed-style-cross-fade-expected.txt: Removed.
platform/qt/Skipped:

3:14 PM Changeset in webkit [100686] by Patrick Gansterer

4 edits in trunk

[CMake] Add ENABLE_CLIENT_BASED_GEOLOCATION to cmakeconfig.h
https://bugs.webkit.org/show_bug.cgi?id=72643

Reviewed by Brent Fulgham.

Source/cmake/OptionsEfl.cmake:
Source/cmake/OptionsWinCE.cmake:
Source/cmakeconfig.h.cmake:

3:05 PM Changeset in webkit [100685] by knorton@google.com

3 edits in trunk

Several void functions in FrameView and RenderObject actually return values.
https://bugs.webkit.org/show_bug.cgi?id=72640

Reviewed by Adam Barth.

../../Source/WebCore/page/FrameView.cpp:
../../Source/WebCore/rendering/RenderObject.cpp:

3:02 PM Changeset in webkit [100684] by eric@webkit.org

4 edits in trunk/Tools

Move check-webkit-style change_directory code to more modern mocks
https://bugs.webkit.org/show_bug.cgi?id=72664

Reviewed by Adam Barth.

Scripts/check-webkit-style:
Scripts/webkitpy/style/main.py:
Scripts/webkitpy/style/main_unittest.py:

3:01 PM Changeset in webkit [100683] by commit-queue@webkit.org

2 edits in trunk/Tools

[GTK] enable ref tests
https://bugs.webkit.org/show_bug.cgi?id=72601

Re-enable ref tests. Run the driver under evenly numbered display if performing
pixel tests or under oddly numbered display otherwise. This prevents the ref tests
being run in an already used Xvfb instance if pixel tests are disabled.

Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-11-17
Reviewed by Tony Chang.

Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None

after the process is killed

2:51 PM Changeset in webkit [100682] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[chromium] Fix minor style nit in CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=71070

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-11-17
Reviewed by James Robinson.

Fixes if-statements on several settors to follow WebKit
conventions. Existing CCLayerImplTest unit tests already cover
this change.

platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::setBounds):
(WebCore::CCLayerImpl::setMaskLayer):
(WebCore::CCLayerImpl::setReplicaLayer):
(WebCore::CCLayerImpl::setDrawsContent):
(WebCore::CCLayerImpl::setAnchorPoint):
(WebCore::CCLayerImpl::setAnchorPointZ):
(WebCore::CCLayerImpl::setBackgroundColor):
(WebCore::CCLayerImpl::setMasksToBounds):
(WebCore::CCLayerImpl::setOpaque):
(WebCore::CCLayerImpl::setOpacity):
(WebCore::CCLayerImpl::setPosition):
(WebCore::CCLayerImpl::setPreserves3D):
(WebCore::CCLayerImpl::setZoomAnimatorTransform):
(WebCore::CCLayerImpl::setSublayerTransform):
(WebCore::CCLayerImpl::setTransform):
(WebCore::CCLayerImpl::setDebugBorderColor):
(WebCore::CCLayerImpl::setDebugBorderWidth):
(WebCore::CCLayerImpl::setContentBounds):
(WebCore::CCLayerImpl::setScrollPosition):
(WebCore::CCLayerImpl::setScrollDelta):
(WebCore::CCLayerImpl::setScaleDelta):
(WebCore::CCLayerImpl::setDoubleSided):

2:49 PM Changeset in webkit [100681] by msaboff@apple.com

2 edits in trunk/Source/WebCore

Leaks seen in MemoryPressureHandlerMac.mm on Leaks bot
https://bugs.webkit.org/show_bug.cgi?id=72416

Added code to release _cache_event_source and _timer_event_source
after they are canceled. Also added defensive code to
clean up the _timer_event_source in uninstall().

Reviewed by Geoffrey Garen.

No new tests, fixing leaks caught by leaks bot.

platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::uninstall):
(WebCore::MemoryPressureHandler::holdOff):

2:49 PM Changeset in webkit [100680] by igor.oliveira@openbossa.org

3 edits in trunk/Source/WebKit2

[WK2] Fix TransformOperation serialization
https://bugs.webkit.org/show_bug.cgi?id=72625

SimpleArgumentCoder can encode and decode just POD types. And according the
ISO/IEC 14882, POD types does not have virtual methods, however TransformOperation
has pure virtual methods.

This patch fixes TransformOperation subclass serialization.

Reviewed by Noam Rosenthal.

Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):
(CoreIPC::encodeOperation):
(CoreIPC::decodeOperation):

Shared/WebCoreArgumentCoders.h:

2:36 PM Changeset in webkit [100679] by leviw@chromium.org

12 edits in branches/subpixellayout/Source/WebCore

Correcting MathML painting to use integers and rounding MouseRelatedEvent's offsetX and offsetY results.

2:34 PM Changeset in webkit [100678] by caio.oliveira@openbossa.org

3 edits in trunk/Tools

Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
https://bugs.webkit.org/show_bug.cgi?id=72620

Reviewed by David Levin.

Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
adding the suffix the cpp file. One example of false positive
https://bugs.webkit.org/show_bug.cgi?id=72319#c12.

Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its

basename contains the cpp's basename.

Scripts/webkitpy/style/checkers/cpp_unittest.py:

2:34 PM Changeset in webkit [100677] by commit-queue@webkit.org

3 edits
2 adds in trunk

Crash from positioned generated content under run-in
https://bugs.webkit.org/show_bug.cgi?id=70456

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-11-17
Reviewed by David Hyatt.

Source/WebCore:

Modified handling of run-in children to clear generated children
before removing the parent from the render tree. This caused problems
with absolute positioned children being not properly removed from the
positioned object list of the RenderView.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::handleRunInChild):

LayoutTests:

Layout test for crash condition.

fast/css-generated-content/positioned-generated-content-under-run-in-crash-expected.html: Added
fast/css-generated-content/positioned-generated-content-under-run-in-crash.html: Added

2:32 PM Changeset in webkit [100676] by pkasting@chromium.org

14 edits in trunk/Source

Unreviewed, rolling out r100572.
https://bugs.webkit.org/show_bug.cgi?id=72393
https://bugs.webkit.org/show_bug.cgi?id=72651

May have caused seg faults on Chromium Linux dbg bot.

Source/WebCore:

bindings/js/ScriptDebugServer.cpp:
bindings/js/ScriptDebugServer.h:
bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::stepOutOfFunction):

bindings/v8/ScriptDebugServer.h:
inspector/CodeGeneratorInspector.py:
inspector/Inspector.json:
inspector/InspectorDebuggerAgent.cpp:
inspector/InspectorDebuggerAgent.h:
inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype.enableDebugger):
(WebInspector.DebuggerModel.prototype.disableDebugger):

inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):

inspector/front-end/Settings.js:

Source/WebKit/chromium:

src/js/DevTools.js:

2:27 PM Changeset in webkit [100675] by eric@webkit.org

3 edits in trunk/Tools

Move check-webkit-style's guts into webkitpy/style/main.py
https://bugs.webkit.org/show_bug.cgi?id=72657

Reviewed by Adam Barth.

Scripts/check-webkit-style:
Scripts/webkitpy/style/main.py:

2:13 PM Changeset in webkit [100674] by eric@webkit.org

13 edits in trunk/Tools

new-run-webkit-tests is locale dependent
https://bugs.webkit.org/show_bug.cgi?id=68691

Reviewed by Adam Barth.

Make NRWT use a clean environment, just like ORWT did.

Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/chromium.py:
Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
Scripts/webkitpy/layout_tests/port/chromium_win.py:
Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
Scripts/webkitpy/layout_tests/port/efl.py:
Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
Scripts/webkitpy/layout_tests/port/mac.py:
Scripts/webkitpy/layout_tests/port/qt.py:
Scripts/webkitpy/layout_tests/port/qt_unittest.py:
Scripts/webkitpy/layout_tests/port/webkit.py:
Scripts/webkitpy/layout_tests/port/win.py:

2:08 PM Changeset in webkit [100673] by dpranke@chromium.org

2 edits in trunk/Tools

Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
https://bugs.webkit.org/show_bug.cgi?id=72615

Reviewed by James Robinson.

Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

2:04 PM Changeset in webkit [100672] by mhahnenberg@apple.com

3 edits in trunk/Source/JavaScriptCore

Add finalizer to JSActivation
https://bugs.webkit.org/show_bug.cgi?id=72575

Reviewed by Geoffrey Garen.

runtime/JSActivation.cpp:

(JSC::JSActivation::finishCreation): Attach finalize function to objects during creation.
(JSC::JSActivation::finalize):

runtime/JSActivation.h: Replaced virtual destructor with static finalize function.

2:03 PM Changeset in webkit [100671] by Lucas Forschler

5 edits in trunk/Source

Versioning.

1:57 PM Changeset in webkit [100670] by commit-queue@webkit.org

3 edits
441 deletes in trunk

Unreviewed, rolling out r100652.
http://trac.webkit.org/changeset/100652
https://bugs.webkit.org/show_bug.cgi?id=72648

"Caused outline-offset-min-assert.html to assert on debug
builds" (Requested by mwenge2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-17

Source/WebCore:

rendering/RenderObject.cpp:

(WebCore::RenderObject::paintOutline):

LayoutTests:

css2.1/20110323/outline-color-001.htm: Removed.
css2.1/20110323/outline-color-002.htm: Removed.
css2.1/20110323/outline-color-003.htm: Removed.
css2.1/20110323/outline-color-004.htm: Removed.
css2.1/20110323/outline-color-005.htm: Removed.
css2.1/20110323/outline-color-006.htm: Removed.
css2.1/20110323/outline-color-007.htm: Removed.
css2.1/20110323/outline-color-008.htm: Removed.
css2.1/20110323/outline-color-009.htm: Removed.
css2.1/20110323/outline-color-010.htm: Removed.
css2.1/20110323/outline-color-011.htm: Removed.
css2.1/20110323/outline-color-012.htm: Removed.
css2.1/20110323/outline-color-013.htm: Removed.
css2.1/20110323/outline-color-014.htm: Removed.
css2.1/20110323/outline-color-015.htm: Removed.
css2.1/20110323/outline-color-016.htm: Removed.
css2.1/20110323/outline-color-017.htm: Removed.
css2.1/20110323/outline-color-018.htm: Removed.
css2.1/20110323/outline-color-019.htm: Removed.
css2.1/20110323/outline-color-020.htm: Removed.
css2.1/20110323/outline-color-021.htm: Removed.
css2.1/20110323/outline-color-022.htm: Removed.
css2.1/20110323/outline-color-023.htm: Removed.
css2.1/20110323/outline-color-024.htm: Removed.
css2.1/20110323/outline-color-025.htm: Removed.
css2.1/20110323/outline-color-026.htm: Removed.
css2.1/20110323/outline-color-027.htm: Removed.
css2.1/20110323/outline-color-028.htm: Removed.
css2.1/20110323/outline-color-029.htm: Removed.
css2.1/20110323/outline-color-030.htm: Removed.
css2.1/20110323/outline-color-031.htm: Removed.
css2.1/20110323/outline-color-032.htm: Removed.
css2.1/20110323/outline-color-033.htm: Removed.
css2.1/20110323/outline-color-034.htm: Removed.
css2.1/20110323/outline-color-035.htm: Removed.
css2.1/20110323/outline-color-036.htm: Removed.
css2.1/20110323/outline-color-037.htm: Removed.
css2.1/20110323/outline-color-038.htm: Removed.
css2.1/20110323/outline-color-039.htm: Removed.
css2.1/20110323/outline-color-040.htm: Removed.
css2.1/20110323/outline-color-041.htm: Removed.
css2.1/20110323/outline-color-042.htm: Removed.
css2.1/20110323/outline-color-043.htm: Removed.
css2.1/20110323/outline-color-044.htm: Removed.
css2.1/20110323/outline-color-045.htm: Removed.
css2.1/20110323/outline-color-046.htm: Removed.
css2.1/20110323/outline-color-047.htm: Removed.
css2.1/20110323/outline-color-048.htm: Removed.
css2.1/20110323/outline-color-049.htm: Removed.
css2.1/20110323/outline-color-050.htm: Removed.
css2.1/20110323/outline-color-051.htm: Removed.
css2.1/20110323/outline-color-052.htm: Removed.
css2.1/20110323/outline-color-053.htm: Removed.
css2.1/20110323/outline-color-054.htm: Removed.
css2.1/20110323/outline-color-055.htm: Removed.
css2.1/20110323/outline-color-056.htm: Removed.
css2.1/20110323/outline-color-057.htm: Removed.
css2.1/20110323/outline-color-058.htm: Removed.
css2.1/20110323/outline-color-059.htm: Removed.
css2.1/20110323/outline-color-060.htm: Removed.
css2.1/20110323/outline-color-061.htm: Removed.
css2.1/20110323/outline-color-062.htm: Removed.
css2.1/20110323/outline-color-063.htm: Removed.
css2.1/20110323/outline-color-064.htm: Removed.
css2.1/20110323/outline-color-065.htm: Removed.
css2.1/20110323/outline-color-066.htm: Removed.
css2.1/20110323/outline-color-067.htm: Removed.
css2.1/20110323/outline-color-068.htm: Removed.
css2.1/20110323/outline-color-069.htm: Removed.
css2.1/20110323/outline-color-070.htm: Removed.
css2.1/20110323/outline-color-071.htm: Removed.
css2.1/20110323/outline-color-072.htm: Removed.
css2.1/20110323/outline-color-073.htm: Removed.
css2.1/20110323/outline-color-074.htm: Removed.
css2.1/20110323/outline-color-075.htm: Removed.
css2.1/20110323/outline-color-076.htm: Removed.
css2.1/20110323/outline-color-077.htm: Removed.
css2.1/20110323/outline-color-078.htm: Removed.
css2.1/20110323/outline-color-079.htm: Removed.
css2.1/20110323/outline-color-080.htm: Removed.
css2.1/20110323/outline-color-081.htm: Removed.
css2.1/20110323/outline-color-082.htm: Removed.
css2.1/20110323/outline-color-083.htm: Removed.
css2.1/20110323/outline-color-084.htm: Removed.
css2.1/20110323/outline-color-085.htm: Removed.
css2.1/20110323/outline-color-086.htm: Removed.
css2.1/20110323/outline-color-087.htm: Removed.
css2.1/20110323/outline-color-088.htm: Removed.
css2.1/20110323/outline-color-089.htm: Removed.
css2.1/20110323/outline-color-090.htm: Removed.
css2.1/20110323/outline-color-091.htm: Removed.
css2.1/20110323/outline-color-092.htm: Removed.
css2.1/20110323/outline-color-093.htm: Removed.
css2.1/20110323/outline-color-094.htm: Removed.
css2.1/20110323/outline-color-095.htm: Removed.
css2.1/20110323/outline-color-096.htm: Removed.
css2.1/20110323/outline-color-097.htm: Removed.
css2.1/20110323/outline-color-098.htm: Removed.
css2.1/20110323/outline-color-099.htm: Removed.
css2.1/20110323/outline-color-100.htm: Removed.
css2.1/20110323/outline-color-101.htm: Removed.
css2.1/20110323/outline-color-102.htm: Removed.
css2.1/20110323/outline-color-103.htm: Removed.
css2.1/20110323/outline-color-104.htm: Removed.
css2.1/20110323/outline-color-105.htm: Removed.
css2.1/20110323/outline-color-106.htm: Removed.
css2.1/20110323/outline-color-107.htm: Removed.
css2.1/20110323/outline-color-108.htm: Removed.
css2.1/20110323/outline-color-109.htm: Removed.
css2.1/20110323/outline-color-110.htm: Removed.
css2.1/20110323/outline-color-111.htm: Removed.
css2.1/20110323/outline-color-112.htm: Removed.
css2.1/20110323/outline-color-113.htm: Removed.
css2.1/20110323/outline-color-114.htm: Removed.
css2.1/20110323/outline-color-115.htm: Removed.
css2.1/20110323/outline-color-116.htm: Removed.
css2.1/20110323/outline-color-117.htm: Removed.
css2.1/20110323/outline-color-118.htm: Removed.
css2.1/20110323/outline-color-119.htm: Removed.
css2.1/20110323/outline-color-120.htm: Removed.
css2.1/20110323/outline-color-121.htm: Removed.
css2.1/20110323/outline-color-122.htm: Removed.
css2.1/20110323/outline-color-123.htm: Removed.
css2.1/20110323/outline-color-124.htm: Removed.
css2.1/20110323/outline-color-125.htm: Removed.
css2.1/20110323/outline-color-126.htm: Removed.
css2.1/20110323/outline-color-127.htm: Removed.
css2.1/20110323/outline-color-128.htm: Removed.
css2.1/20110323/outline-color-129.htm: Removed.
css2.1/20110323/outline-color-130.htm: Removed.
css2.1/20110323/outline-color-131.htm: Removed.
css2.1/20110323/outline-color-132.htm: Removed.
css2.1/20110323/outline-color-133.htm: Removed.
css2.1/20110323/outline-color-134.htm: Removed.
css2.1/20110323/outline-color-135.htm: Removed.
css2.1/20110323/outline-color-136.htm: Removed.
css2.1/20110323/outline-color-137.htm: Removed.
css2.1/20110323/outline-color-138.htm: Removed.
css2.1/20110323/outline-color-139.htm: Removed.
css2.1/20110323/outline-color-140.htm: Removed.
css2.1/20110323/outline-color-141.htm: Removed.
css2.1/20110323/outline-color-142.htm: Removed.
css2.1/20110323/outline-color-143.htm: Removed.
css2.1/20110323/outline-color-144.htm: Removed.
css2.1/20110323/outline-color-145.htm: Removed.
css2.1/20110323/outline-color-174.htm: Removed.
css2.1/20110323/outline-color-175.htm: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-001-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-001-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-002-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-002-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-003-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-003-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-004-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-004-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-005-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-005-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-006-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-006-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-007-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-007-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-008-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-008-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-009-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-009-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-010-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-010-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-011-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-011-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-012-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-012-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-013-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-013-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-014-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-014-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-015-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-015-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-016-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-016-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-017-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-017-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-018-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-018-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-019-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-019-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-020-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-020-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-021-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-021-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-022-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-022-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-023-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-023-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-024-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-024-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-025-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-025-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-026-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-026-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-027-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-027-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-028-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-028-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-029-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-029-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-030-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-030-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-031-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-031-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-032-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-032-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-033-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-033-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-034-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-034-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-035-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-035-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-036-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-036-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-037-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-037-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-038-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-038-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-039-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-039-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-040-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-040-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-041-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-041-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-042-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-042-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-043-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-043-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-044-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-044-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-045-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-045-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-046-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-046-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-047-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-047-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-048-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-048-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-049-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-049-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-050-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-050-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-051-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-051-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-052-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-052-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-053-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-053-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-054-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-054-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-055-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-055-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-056-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-056-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-057-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-057-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-058-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-058-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-059-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-059-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-060-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-060-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-061-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-061-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-062-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-062-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-063-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-063-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-064-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-064-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-065-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-065-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-066-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-066-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-067-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-067-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-068-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-068-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-069-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-069-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-070-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-070-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-071-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-071-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-072-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-072-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-073-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-073-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-074-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-074-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-075-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-075-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-076-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-076-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-077-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-077-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-078-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-078-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-079-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-079-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-080-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-080-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-081-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-081-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-082-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-082-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-083-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-083-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-084-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-084-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-085-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-085-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-086-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-086-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-087-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-087-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-088-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-088-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-089-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-089-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-090-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-090-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-091-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-091-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-092-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-092-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-093-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-093-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-094-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-094-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-095-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-095-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-096-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-096-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-097-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-097-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-098-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-098-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-099-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-099-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-100-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-100-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-101-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-101-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-102-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-102-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-103-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-103-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-104-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-104-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-105-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-105-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-106-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-106-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-107-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-107-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-108-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-108-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-109-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-109-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-110-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-110-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-111-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-111-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-112-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-112-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-113-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-113-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-114-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-114-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-115-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-115-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-116-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-116-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-117-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-117-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-118-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-118-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-119-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-119-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-120-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-120-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-121-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-121-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-122-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-122-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-123-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-123-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-124-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-124-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-125-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-125-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-126-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-126-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-127-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-127-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-128-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-128-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-129-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-129-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-130-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-130-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-131-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-131-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-132-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-132-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-133-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-133-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-134-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-134-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-135-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-135-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-136-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-136-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-137-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-137-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-138-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-138-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-139-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-139-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-140-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-140-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-141-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-141-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-142-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-142-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-143-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-143-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-144-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-144-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-145-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-145-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-174-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-174-expected.txt: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-175-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/outline-color-175-expected.txt: Removed.

1:56 PM Changeset in webkit [100669] by Lucas Forschler

5 edits in trunk/Source

Versioning.

1:51 PM Changeset in webkit [100668] by mrowe@apple.com

8 edits in trunk/Source

<http://webkit.org/b/72646> Disable deprecation warnings around code where we cannot easily
switch away from the deprecated APIs.

Reviewed by Dan Bernstein.

Source/WebCore:

platform/mac/WebCoreNSStringExtras.mm:
platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::reportErrorToClient):

Source/WebKit/mac:

Plugins/WebBasePluginPackage.mm:
Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _tryLoad]):

Source/WebKit2:

Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

1:50 PM Changeset in webkit [100667] by mrowe@apple.com

2 edits in trunk/Source/WebCore

<http://webkit.org/b/72637> Stop performing runtime version checks on OS versions where the check can never possibly fail.

Reviewed by Simon Fraser.

platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::haveVImageRoundingErrorFix): When not targeting Snow Leopard we always have the fix.

1:48 PM Changeset in webkit [100666] by Chris Fleizach

6 edits
2 adds in trunk

AX: The scrollArea is not correctly returning the scrollbars
https://bugs.webkit.org/show_bug.cgi?id=70247

Reviewed by Beth Dakin.

Source/WebCore:

A few bugs that were preventing this from working.

1) In accessibilityAttributeValue: when an element did not have a renderer() we were returning earlier than we should have
2) We were not updating and clearing the scrollbars correctly when children were cleared or when asked for.

Test: platform/mac/accessibility/scrollbars.html

accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::scrollBar):
(WebCore::AccessibilityScrollView::clearChildren):

accessibility/AccessibilityScrollView.h:
accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

platform/mac/accessibility/scrollbars-expected.txt: Added.
platform/mac/accessibility/scrollbars.html: Added.

1:47 PM Changeset in webkit [100665] by Patrick Gansterer

2 edits in trunk

[CMake] Make CODE_GENERATOR_PREPROCESSOR more useable
https://bugs.webkit.org/show_bug.cgi?id=72516

Reviewed by Brent Fulgham.

On windows some code generators fail, if the path to the preprocessor contains spaces.
Use only the executable name to avoid this issue for now.

Source/cmake/OptionsCommon.cmake:

1:40 PM Changeset in webkit [100664] by commit-queue@webkit.org

1 edit
135 deletes in trunk/LayoutTests

Unreviewed, rolling out r100659.
http://trac.webkit.org/changeset/100659
https://bugs.webkit.org/show_bug.cgi?id=72649

"Caused outline-offset-min-assert.html to assert on debug
builds" (Requested by mwenge2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-17

platform/qt/css2.1/20110323/outline-color-001-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-002-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-003-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-004-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-005-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-006-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-007-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-008-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-009-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-010-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-011-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-012-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-013-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-014-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-015-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-016-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-017-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-018-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-019-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-020-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-021-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-024-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-025-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-026-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-027-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-028-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-029-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-030-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-031-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-032-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-033-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-034-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-035-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-036-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-037-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-038-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-039-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-040-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-041-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-042-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-045-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-046-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-047-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-048-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-049-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-050-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-051-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-052-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-053-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-054-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-055-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-056-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-057-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-058-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-059-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-060-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-061-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-062-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-063-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-066-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-067-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-068-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-069-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-070-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-071-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-072-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-073-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-074-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-075-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-076-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-077-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-078-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-079-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-080-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-081-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-082-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-083-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-084-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-087-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-088-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-089-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-090-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-091-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-092-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-093-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-094-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-095-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-096-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-097-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-098-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-099-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-100-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-101-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-102-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-103-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-104-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-105-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-108-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-109-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-110-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-111-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-112-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-113-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-114-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-115-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-116-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-117-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-118-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-119-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-120-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-121-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-122-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-123-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-124-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-125-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-126-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-129-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-130-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-131-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-132-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-133-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-134-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-135-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-136-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-137-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-138-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-139-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-140-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-141-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-142-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-143-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-144-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-145-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-174-expected.txt: Removed.
platform/qt/css2.1/20110323/outline-color-175-expected.txt: Removed.

1:34 PM Changeset in webkit [100663] by abarth@webkit.org

14 edits in trunk

Unique origins shouldn't remember their scheme, host, or port
https://bugs.webkit.org/show_bug.cgi?id=72308

Reviewed by Eric Seidel.

Source/WebCore:

This patch contains the bulk (all?) of the behavior differences in this
patch series. Unique origins shouldn't remember their schemes. Doing
so causes some privileges (e.g., local access) to leak into unique
origins.

page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):

Explicitly clear out the protocol, host, and port for unique origins. A future patch will refactor all this code to be more elegant.

platform/SchemeRegistry.cpp:

(WebCore::schemesWithUniqueOrigins):

Merge "about" and "javascript" in with the general case now that we don't have a separate notion of an empty origin.

LayoutTests:

fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
- Inline script because the sandbox iframe isn't allowed to load local resources.
fast/frames/sandboxed-iframe-attribute-parsing.html:
fast/frames/sandboxed-iframe-forms-dynamic.html:
fast/frames/sandboxed-iframe-forms.html:
fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html:
fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html:
fast/frames/sandboxed-iframe-navigation-top-by-name.html:
fast/frames/sandboxed-iframe-navigation-top.html:
media/video-controls-no-scripting.html:
- Previously sandboxed local iframes still got universal access when we're running with universal access for file URLs! Now that they correctly get unique origins, we need to update these tests to allow-same-origin access in order for them to function properly.

1:15 PM Changeset in webkit [100662] by Chris Fleizach

4 edits in trunk/Source/WebCore

AX: cleanup style and naming and code in accessibility search mechanism
https://bugs.webkit.org/show_bug.cgi?id=72570

Reviewed by Beth Dakin.

Cleanup the naming and code style within the element searching mechanism.

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
(WebCore::AccessibilityObject::isAccessibilityTextSearchMatch):
(WebCore::AccessibilityObject::firstAccessibleObjectFromNode):
(WebCore::AccessibilityObject::findMatchingObjects):

accessibility/AccessibilityObject.h:
accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

1:06 PM Changeset in webkit [100661] by jchaffraix@webkit.org

3 edits
12 adds in trunk

CSS table with 100% width can overflow their containing block
https://bugs.webkit.org/show_bug.cgi?id=72180

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/table-in-table-percent-width-collapsing-border-quirks-mode.html

fast/table/table-in-table-percent-width-collapsing-border.html
fast/table/table-in-table-percent-width-quirks-mode.html
fast/table/table-in-table-percent-width.html

After r97555, we would include the borders in a CSS table's logical width even if the 'width'
property was a percent. This does not match what Firefox and IE are doing. Thus don't apply
this behavior to percent 'width'.

rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):

LayoutTests:

Several tests to check that we don't overflow our containing block with width: 100%.

fast/table/table-in-table-percent-width-collapsing-border-expected.png: Added.
fast/table/table-in-table-percent-width-collapsing-border-expected.txt: Added.
fast/table/table-in-table-percent-width-collapsing-border-quirks-mode-expected.png: Added.
fast/table/table-in-table-percent-width-collapsing-border-quirks-mode-expected.txt: Added.
fast/table/table-in-table-percent-width-collapsing-border-quirks-mode.html: Added.
fast/table/table-in-table-percent-width-collapsing-border.html: Added.
fast/table/table-in-table-percent-width-expected.png: Added.
fast/table/table-in-table-percent-width-expected.txt: Added.
fast/table/table-in-table-percent-width-quirks-mode-expected.png: Added.
fast/table/table-in-table-percent-width-quirks-mode-expected.txt: Added.
fast/table/table-in-table-percent-width-quirks-mode.html: Added.
fast/table/table-in-table-percent-width.html: Added.

1:01 PM Changeset in webkit [100660] by enne@google.com

6 edits in trunk/Source

[chromium] Implicitly skip render surfaces that won't be drawn
https://bugs.webkit.org/show_bug.cgi?id=71038

Source/WebCore:

Rather than having redundant checks in three places for how to walk
through a render surface list, instead don't add render surfaces that
don't need to get rendered to the render surface list.

Reviewed by James Robinson.

Covered by existing layout tests and unit tests.

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

Source/WebKit/chromium:

Update a test that depends on a layer not getting removed.

Reviewed by James Robinson.

tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):

12:40 PM Changeset in webkit [100659] by robert@webkit.org

1 edit
135 adds in trunk/LayoutTests

Qt-specific results for tests added in r100652

Unreviewed Qt gardening.

platform/qt/css2.1/20110323/outline-color-001-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-002-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-003-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-004-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-005-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-006-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-007-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-008-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-009-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-010-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-011-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-012-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-013-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-014-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-015-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-016-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-017-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-018-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-019-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-020-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-021-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-024-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-025-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-026-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-027-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-028-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-029-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-030-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-031-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-032-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-033-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-034-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-035-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-036-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-037-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-038-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-039-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-040-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-041-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-042-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-045-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-046-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-047-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-048-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-049-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-050-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-051-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-052-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-053-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-054-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-055-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-056-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-057-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-058-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-059-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-060-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-061-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-062-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-063-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-066-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-067-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-068-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-069-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-070-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-071-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-072-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-073-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-074-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-075-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-076-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-077-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-078-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-079-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-080-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-081-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-082-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-083-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-084-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-087-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-088-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-089-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-090-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-091-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-092-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-093-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-094-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-095-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-096-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-097-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-098-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-099-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-100-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-101-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-102-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-103-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-104-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-105-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-108-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-109-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-110-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-111-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-112-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-113-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-114-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-115-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-116-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-117-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-118-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-119-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-120-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-121-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-122-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-123-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-124-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-125-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-126-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-129-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-130-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-131-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-132-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-133-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-134-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-135-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-136-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-137-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-138-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-139-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-140-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-141-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-142-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-143-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-144-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-145-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-174-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-175-expected.txt: Added.

12:30 PM Changeset in webkit [100658] by Simon Hausmann

15 edits
1 add in trunk

[Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode https://bugs.webkit.org/show_bug.cgi?id=72595

Reviewed by Noam Rosenthal.

Source/WebCore:

Removed QWebElement and QtDRTNode usage that reached from WebCore into
WebKit/qt and replaced it with the ability to register custom JSValue
conversion functions. The old code has been moved to WebKit/qt.

bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::QtInstance): Remove unnecessary meta type registration
(now done in QtWebElementRuntime::initialize in WebKit/qt).

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::registerCustomType):
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):

bridge/qt/qt_runtime.h:

Source/WebKit:

WebKit.pri: Add qwebelement_p.h to HEADERS.

Source/WebKit/qt:

Move QWebElement and QtDRTNode JS bindings from WebCore to WebKit/qt.

Api/qwebelement.cpp: Add QWebElement to JSValue and JSValue to QWebElement

conversion through intermediate QVariant.
(QtWebElementRuntime::create):
(QtWebElementRuntime::get):
(convertJSValueToWebElementVariant):
(convertWebElementVariantToJSValue):
(QtWebElementRuntime::initialize): Register conversion functions for QWebElement.

Api/qwebelement.h:
Api/qwebelement_p.h: Added.
Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate): Initialize QWebElement conversion functions for
the JS runtime.

WebCoreSupport/DumpRenderTreeSupportQt.cpp: Add QtDRTNode to JSValue and JSValue to

QtDRTNode conversion through intermediate QVariant.
(QtDRTNodeRuntime::create):
(QtDRTNodeRuntime::get):
(convertJSValueToNodeVariant):
(convertNodeVariantToJSValue):
(QtDRTNodeRuntime::initialize):
(DumpRenderTreeSupportQt::initialize): Register conversion functions for QtDRTNode.

WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
ensure the registration of the DRTNode JS bindings.

DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
registration of QWebElement (now done implicitly through QWebPage ->
QtWebElementRunTime::initialize code path)

12:25 PM Changeset in webkit [100657] by Adam Roben

3 edits in trunk/Tools

Fix a crash-inducing typo I introduced in r100648

Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
handling a crashing test

Reviewed by Adam Barth.

Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver.run_test): Get the driver name from the port.

Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
right crashed process name.

12:09 PM Changeset in webkit [100656] by fsamuel@chromium.org

8 edits in trunk/Source/WebCore

Pass Aspect Ratio to RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=72350

Reviewed by Ojan Vafai.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyAspectRatio::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

css/CSSValue.h:

(WebCore::CSSValue::isAspectRatioValue):

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hasAspectRatio):
(WebCore::InheritedFlags::aspectRatio):
(WebCore::InheritedFlags::aspectRatioDenominator):
(WebCore::InheritedFlags::aspectRatioNumerator):
(WebCore::InheritedFlags::setHasAspectRatio):
(WebCore::InheritedFlags::setAspectRatioDenominator):
(WebCore::InheritedFlags::setAspectRatioNumerator):
(WebCore::InheritedFlags::initialHasAspectRatio):
(WebCore::InheritedFlags::initialAspectRatioDenominator):
(WebCore::InheritedFlags::initialAspectRatioNumerator):

rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

rendering/style/StyleRareNonInheritedData.h:

11:58 AM Changeset in webkit [100655] by Adam Roben

3 edits in trunk/Tools

Fix NRWT's parsing of the number of excluded leaks

Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
leaks were excluded

Reviewed by Adam Barth.

Scripts/webkitpy/layout_tests/port/leakdetector.py:

(LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
regular expression match, not the entire matched string.

Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:

(LeakDetectorTest): Added some example output that shows how things look when leaks are
excluded.
(LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
correctly.

11:54 AM Changeset in webkit [100654] by Lucas Forschler

5 edits in tags/Safari-535.9/Source

Versioning.

11:46 AM Changeset in webkit [100653] by jesus@webkit.org

7 edits
1 delete in trunk/Source/WebKit2

[Qt][WK2] Fix zero sized views in all QML tests
https://bugs.webkit.org/show_bug.cgi?id=72633

Reviewed by Noam Rosenthal.

After r100590, zero sized WebViews are no longer supported and,
therefore, the QML API tests need to be fixed.

UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml:
UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgress.qml:
UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgressSignal.qml:
UIProcess/API/qt/tests/qmltests/WebView/tst_loadZeroSizeView.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
UIProcess/API/qt/tests/qmltests/WebView/tst_properties.qml:
UIProcess/API/qt/tests/qmltests/qmltests.pro:

11:44 AM Changeset in webkit [100652] by robert@webkit.org

3 edits
441 adds in trunk

CSS 2.1 failure: outline-color-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=71931

Source/WebCore:

Reviewed by Julien Chaffraix.

WebKit wasn't displaying the top block in these tests because it did not paint the outline
of divs with zero size.

rendering/RenderObject.cpp:

(WebCore::RenderObject::paintOutline): paint the outline even when the block has zero size

LayoutTests:

Add tests covering dynamic outlines. At first glance the result
for outline-color-174.htm looks like it might be wrong but it's
really the statement at the top of the test that's misleading,
only the outline should be black not the entire box.

Reviewed by Julien Chaffraix.

css2.1/20110323/outline-color-001.htm: Added.
css2.1/20110323/outline-color-002.htm: Added.
css2.1/20110323/outline-color-003.htm: Added.
css2.1/20110323/outline-color-004.htm: Added.
css2.1/20110323/outline-color-005.htm: Added.
css2.1/20110323/outline-color-006.htm: Added.
css2.1/20110323/outline-color-007.htm: Added.
css2.1/20110323/outline-color-008.htm: Added.
css2.1/20110323/outline-color-009.htm: Added.
css2.1/20110323/outline-color-010.htm: Added.
css2.1/20110323/outline-color-011.htm: Added.
css2.1/20110323/outline-color-012.htm: Added.
css2.1/20110323/outline-color-013.htm: Added.
css2.1/20110323/outline-color-014.htm: Added.
css2.1/20110323/outline-color-015.htm: Added.
css2.1/20110323/outline-color-016.htm: Added.
css2.1/20110323/outline-color-017.htm: Added.
css2.1/20110323/outline-color-018.htm: Added.
css2.1/20110323/outline-color-019.htm: Added.
css2.1/20110323/outline-color-020.htm: Added.
css2.1/20110323/outline-color-021.htm: Added.
css2.1/20110323/outline-color-022.htm: Added.
css2.1/20110323/outline-color-023.htm: Added.
css2.1/20110323/outline-color-024.htm: Added.
css2.1/20110323/outline-color-025.htm: Added.
css2.1/20110323/outline-color-026.htm: Added.
css2.1/20110323/outline-color-027.htm: Added.
css2.1/20110323/outline-color-028.htm: Added.
css2.1/20110323/outline-color-029.htm: Added.
css2.1/20110323/outline-color-030.htm: Added.
css2.1/20110323/outline-color-031.htm: Added.
css2.1/20110323/outline-color-032.htm: Added.
css2.1/20110323/outline-color-033.htm: Added.
css2.1/20110323/outline-color-034.htm: Added.
css2.1/20110323/outline-color-035.htm: Added.
css2.1/20110323/outline-color-036.htm: Added.
css2.1/20110323/outline-color-037.htm: Added.
css2.1/20110323/outline-color-038.htm: Added.
css2.1/20110323/outline-color-039.htm: Added.
css2.1/20110323/outline-color-040.htm: Added.
css2.1/20110323/outline-color-041.htm: Added.
css2.1/20110323/outline-color-042.htm: Added.
css2.1/20110323/outline-color-043.htm: Added.
css2.1/20110323/outline-color-044.htm: Added.
css2.1/20110323/outline-color-045.htm: Added.
css2.1/20110323/outline-color-046.htm: Added.
css2.1/20110323/outline-color-047.htm: Added.
css2.1/20110323/outline-color-048.htm: Added.
css2.1/20110323/outline-color-049.htm: Added.
css2.1/20110323/outline-color-050.htm: Added.
css2.1/20110323/outline-color-051.htm: Added.
css2.1/20110323/outline-color-052.htm: Added.
css2.1/20110323/outline-color-053.htm: Added.
css2.1/20110323/outline-color-054.htm: Added.
css2.1/20110323/outline-color-055.htm: Added.
css2.1/20110323/outline-color-056.htm: Added.
css2.1/20110323/outline-color-057.htm: Added.
css2.1/20110323/outline-color-058.htm: Added.
css2.1/20110323/outline-color-059.htm: Added.
css2.1/20110323/outline-color-060.htm: Added.
css2.1/20110323/outline-color-061.htm: Added.
css2.1/20110323/outline-color-062.htm: Added.
css2.1/20110323/outline-color-063.htm: Added.
css2.1/20110323/outline-color-064.htm: Added.
css2.1/20110323/outline-color-065.htm: Added.
css2.1/20110323/outline-color-066.htm: Added.
css2.1/20110323/outline-color-067.htm: Added.
css2.1/20110323/outline-color-068.htm: Added.
css2.1/20110323/outline-color-069.htm: Added.
css2.1/20110323/outline-color-070.htm: Added.
css2.1/20110323/outline-color-071.htm: Added.
css2.1/20110323/outline-color-072.htm: Added.
css2.1/20110323/outline-color-073.htm: Added.
css2.1/20110323/outline-color-074.htm: Added.
css2.1/20110323/outline-color-075.htm: Added.
css2.1/20110323/outline-color-076.htm: Added.
css2.1/20110323/outline-color-077.htm: Added.
css2.1/20110323/outline-color-078.htm: Added.
css2.1/20110323/outline-color-079.htm: Added.
css2.1/20110323/outline-color-080.htm: Added.
css2.1/20110323/outline-color-081.htm: Added.
css2.1/20110323/outline-color-082.htm: Added.
css2.1/20110323/outline-color-083.htm: Added.
css2.1/20110323/outline-color-084.htm: Added.
css2.1/20110323/outline-color-085.htm: Added.
css2.1/20110323/outline-color-086.htm: Added.
css2.1/20110323/outline-color-087.htm: Added.
css2.1/20110323/outline-color-088.htm: Added.
css2.1/20110323/outline-color-089.htm: Added.
css2.1/20110323/outline-color-090.htm: Added.
css2.1/20110323/outline-color-091.htm: Added.
css2.1/20110323/outline-color-092.htm: Added.
css2.1/20110323/outline-color-093.htm: Added.
css2.1/20110323/outline-color-094.htm: Added.
css2.1/20110323/outline-color-095.htm: Added.
css2.1/20110323/outline-color-096.htm: Added.
css2.1/20110323/outline-color-097.htm: Added.
css2.1/20110323/outline-color-098.htm: Added.
css2.1/20110323/outline-color-099.htm: Added.
css2.1/20110323/outline-color-100.htm: Added.
css2.1/20110323/outline-color-101.htm: Added.
css2.1/20110323/outline-color-102.htm: Added.
css2.1/20110323/outline-color-103.htm: Added.
css2.1/20110323/outline-color-104.htm: Added.
css2.1/20110323/outline-color-105.htm: Added.
css2.1/20110323/outline-color-106.htm: Added.
css2.1/20110323/outline-color-107.htm: Added.
css2.1/20110323/outline-color-108.htm: Added.
css2.1/20110323/outline-color-109.htm: Added.
css2.1/20110323/outline-color-110.htm: Added.
css2.1/20110323/outline-color-111.htm: Added.
css2.1/20110323/outline-color-112.htm: Added.
css2.1/20110323/outline-color-113.htm: Added.
css2.1/20110323/outline-color-114.htm: Added.
css2.1/20110323/outline-color-115.htm: Added.
css2.1/20110323/outline-color-116.htm: Added.
css2.1/20110323/outline-color-117.htm: Added.
css2.1/20110323/outline-color-118.htm: Added.
css2.1/20110323/outline-color-119.htm: Added.
css2.1/20110323/outline-color-120.htm: Added.
css2.1/20110323/outline-color-121.htm: Added.
css2.1/20110323/outline-color-122.htm: Added.
css2.1/20110323/outline-color-123.htm: Added.
css2.1/20110323/outline-color-124.htm: Added.
css2.1/20110323/outline-color-125.htm: Added.
css2.1/20110323/outline-color-126.htm: Added.
css2.1/20110323/outline-color-127.htm: Added.
css2.1/20110323/outline-color-128.htm: Added.
css2.1/20110323/outline-color-129.htm: Added.
css2.1/20110323/outline-color-130.htm: Added.
css2.1/20110323/outline-color-131.htm: Added.
css2.1/20110323/outline-color-132.htm: Added.
css2.1/20110323/outline-color-133.htm: Added.
css2.1/20110323/outline-color-134.htm: Added.
css2.1/20110323/outline-color-135.htm: Added.
css2.1/20110323/outline-color-136.htm: Added.
css2.1/20110323/outline-color-137.htm: Added.
css2.1/20110323/outline-color-138.htm: Added.
css2.1/20110323/outline-color-139.htm: Added.
css2.1/20110323/outline-color-140.htm: Added.
css2.1/20110323/outline-color-141.htm: Added.
css2.1/20110323/outline-color-142.htm: Added.
css2.1/20110323/outline-color-143.htm: Added.
css2.1/20110323/outline-color-144.htm: Added.
css2.1/20110323/outline-color-145.htm: Added.
css2.1/20110323/outline-color-174.htm: Added.
css2.1/20110323/outline-color-175.htm: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-001-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-001-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-002-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-002-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-003-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-003-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-004-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-004-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-005-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-005-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-006-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-006-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-007-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-007-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-008-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-008-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-009-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-009-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-010-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-010-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-011-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-011-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-012-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-012-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-013-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-013-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-014-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-014-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-015-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-015-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-016-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-016-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-017-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-017-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-018-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-018-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-019-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-019-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-020-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-020-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-021-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-021-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-022-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-022-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-023-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-023-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-024-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-024-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-025-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-025-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-026-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-026-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-027-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-027-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-028-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-028-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-029-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-029-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-030-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-030-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-031-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-031-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-032-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-032-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-033-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-033-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-034-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-034-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-035-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-035-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-036-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-036-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-037-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-037-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-038-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-038-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-039-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-039-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-040-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-040-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-041-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-041-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-042-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-042-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-043-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-043-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-044-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-044-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-045-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-045-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-046-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-046-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-047-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-047-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-048-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-048-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-049-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-049-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-050-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-050-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-051-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-051-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-052-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-052-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-053-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-053-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-054-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-054-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-055-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-055-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-056-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-056-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-057-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-057-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-058-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-058-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-059-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-059-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-060-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-060-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-061-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-061-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-062-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-062-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-063-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-063-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-064-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-064-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-065-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-065-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-066-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-066-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-067-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-067-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-068-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-068-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-069-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-069-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-070-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-070-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-071-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-071-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-072-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-072-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-073-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-073-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-074-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-074-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-075-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-075-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-076-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-076-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-077-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-077-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-078-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-078-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-079-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-079-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-080-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-080-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-081-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-081-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-082-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-082-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-083-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-083-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-084-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-084-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-085-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-085-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-086-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-086-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-087-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-087-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-088-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-088-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-089-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-089-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-090-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-090-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-091-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-091-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-092-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-092-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-093-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-093-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-094-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-094-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-095-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-095-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-096-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-096-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-097-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-097-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-098-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-098-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-099-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-099-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-100-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-100-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-101-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-101-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-102-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-102-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-103-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-103-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-104-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-104-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-105-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-105-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-106-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-106-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-107-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-107-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-108-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-108-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-109-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-109-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-110-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-110-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-111-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-111-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-112-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-112-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-113-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-113-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-114-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-114-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-115-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-115-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-116-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-116-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-117-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-117-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-118-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-118-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-119-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-119-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-120-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-120-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-121-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-121-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-122-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-122-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-123-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-123-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-124-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-124-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-125-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-125-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-126-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-126-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-127-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-127-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-128-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-128-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-129-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-129-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-130-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-130-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-131-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-131-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-132-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-132-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-133-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-133-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-134-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-134-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-135-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-135-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-136-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-136-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-137-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-137-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-138-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-138-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-139-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-139-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-140-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-140-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-141-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-141-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-142-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-142-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-143-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-143-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-144-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-144-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-145-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-145-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-174-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-174-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-175-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/outline-color-175-expected.txt: Added.

11:27 AM Changeset in webkit [100651] by Lucas Forschler

1 copy in tags/Safari-535.9

New Tag.

11:27 AM Changeset in webkit [100650] by Lucas Forschler

1 delete in tags/Safari-535.9

remove incorrect tag

11:20 AM Changeset in webkit [100649] by Lucas Forschler

1 copy in tags/Safari-535.9

New Tag.

11:17 AM Changeset in webkit [100648] by Adam Roben

5 edits in trunk/Tools

Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process

Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
when web process crashes, but WebProcess crash log should get saved instead

Reviewed by Eric Seidel.

Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result): Simplified a little to share more code between the case where we
crashed when running the test and where we crashed when checking the expected rendering for
a reftest. Changed to pass the crashed process name down to write_crash_report.
(TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
along to CrashLogs.find_newest_log rather than always using the driver name.

Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
crashed.

Scripts/webkitpy/layout_tests/port/test.py:

(TestInstance.init): Initialize new web_process_crash attribute.
(unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
test this patch adds.
(TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
specifies that the driver crashed or the web process crashed.

Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
which we pretend the web process crashed rather than the driver process.

(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_unexpected_failures):
(EndToEndTest.test_end_to_end):
Updated magic numbers to account for new unexpected failing test added to unit_test_list.

11:16 AM Changeset in webkit [100647] by Lucas Forschler

5 edits in trunk/Source

Revert revision change.

11:12 AM Changeset in webkit [100646] by tony@chromium.org

2 edits in trunk/Tools

[chromium] stop spamming features warning on every build
https://bugs.webkit.org/show_bug.cgi?id=72629

Reviewed by Ojan Vafai.

We toggle $blobSupport on if $mediaStreamSupport is on. Since
$mediaStreamSupport is on by default for chromium, make the default
for $blobSupport also on.

Scripts/build-webkit:

11:11 AM Changeset in webkit [100645] by Lucas Forschler

5 edits in trunk/Source

Versioning.

10:55 AM Changeset in webkit [100644] by Adam Roben

3 edits in trunk/Tools

Remove extra quoting of call stacks and types passed to run-leaks by NRWT

Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
that are supposed to be ignored

Reviewed by Adam Barth.

Scripts/webkitpy/layout_tests/port/leakdetector.py:

(LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
required when passing arguments via the shell (which we aren't doing here). It is not
required by Perl's option-parsing code (as the comment I removed mistakenly claimed).

Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:

(LeakDetectorTest.test_leaks_args): Updated expectations.

10:29 AM Changeset in webkit [100643] by steveblock@google.com

2 edits in trunk/LayoutTests

[Chromium] fast/filesystem/file-writer-abort-depth.html crashes occasionally on Win dbg
https://bugs.webkit.org/show_bug.cgi?id=72631

Add a CRASH expectation for
fast/filesystem/file-writer-abort-depth.html

Unreviewed gardening.

platform/chromium/test_expectations.txt:

10:24 AM Changeset in webkit [100642] by Martin Robinson

4 edits in trunk/Source/WebKit/gtk

[GTK] Remove the last remaining WebKit1 gtkdoc warnings
https://bugs.webkit.org/show_bug.cgi?id=72627

Reviewed by Philippe Normand.

webkit/webkitdownload.h: Add missing enum documentation.
webkit/webkiterror.h: Ditto.
webkit/webkitwebview.h: Ditto.

10:07 AM Changeset in webkit [100641] by Chris Fleizach

2 edits in trunk/LayoutTests

WebKitTestRunner needs to support accessibility-related DRT APIs
https://bugs.webkit.org/show_bug.cgi?id=42131

Unreviewed layout test fix.

I hadn't realized that selection-value-changes-for-aria-textbox.html was being skipped on Lion,
so this test started failing on snow leopard on the bots.

platform/mac/accessibility/selection-value-changes-for-aria-textbox-expected.txt:

9:49 AM Changeset in webkit [100640] by sergio@webkit.org

4 edits in trunk

[GTK] plugins/get-url-notify-with-url-that-fails-to-load.html on bots after r100466
https://bugs.webkit.org/show_bug.cgi?id=72613

Reviewed by Martin Robinson.

Source/WebCore:

Do not assume that a SoupRequest always exists, it is not
generated for example when the provided URL is
invalid. ResourceHandle::platformSetDefersLoading was crashing
because of that.

platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::platformSetDefersLoading):

LayoutTests:

Added a test that times out in WK2.

platform/gtk-wk2/Skipped: added plugins/get-url-notify-with-url-that-fails-to-load.html

9:40 AM Changeset in webkit [100639] by steveblock@google.com

2 edits in trunk/LayoutTests

ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
https://bugs.webkit.org/show_bug.cgi?id=59552

Added a CRASH expectation for
fast/dom/null-document-location-put-crash.html

Unreviewed gardening.

platform/chromium/test_expectations.txt:

9:31 AM Changeset in webkit [100638] by steveblock@google.com

1 edit
1 add
1 delete in trunk/LayoutTests

Rebaseline
fast/css-generated-content/nested-tables-with-before-after-content-crash.html
for Chromium Linux. Also remove a duplicated text expectation.

Unreviewed gardening.

platform/chromium-linux/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png: Added
platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed

9:17 AM Changeset in webkit [100637] by steveblock@google.com

1 edit
2 adds in trunk/LayoutTests

[Chromium] Layout test failures under Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=54322

Rebaseline transforms/no_transform_hit_testing.html. It looks like the
expected results still aren't quite right after
http://trac.webkit.org/changeset/100615.

platform/chromium-mac-snowleopard/transforms/no_transform_hit_testing-expected.png: Added.

9:16 AM Changeset in webkit [100636] by Philippe Normand

2 edits in trunk/Tools

Unreviewed, run-bindings-tests fix after r91028.

Scripts/run-bindings-tests: Use scm.detection module.

9:14 AM Changeset in webkit [100635] by vsevik@chromium.org

5 edits in trunk/Source

Web Inspector: Remove onlineDetectionEnabled from Preferences
https://bugs.webkit.org/show_bug.cgi?id=72617

Reviewed by Pavel Feldman.

Source/WebCore:

inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype.get statusBarItems):

inspector/front-end/Settings.js:

Source/WebKit/chromium:

src/js/DevTools.js:

9:09 AM Changeset in webkit [100634] by steveblock@google.com

2 edits in trunk/LayoutTests

[Chromium] http/tests/inspector/resource-tree/resource-tree-no-xhrs.html fails occasionally
https://bugs.webkit.org/show_bug.cgi?id=72622

Add MISSING and TEXT expectations for
http/tests/inspector/resource-tree/resource-tree-no-xhrs.html.

Unreviewed gardening.

platform/chromium/test_expectations.txt:

8:53 AM Changeset in webkit [100633] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

platform/qt/Skipped: Skip a failing test temporarily.

8:49 AM Changeset in webkit [100632] by Philippe Normand

1 edit
9 adds in trunk/LayoutTests

Unreviewed, GTK baselines for new css3 tests and an accessibility test.

platform/gtk/accessibility/loading-iframe-sends-notification-expected.txt: Added.
platform/gtk/css3/images/cross-fade-blending-expected.txt: Added.
platform/gtk/css3/images/cross-fade-invalidation-expected.txt: Added.
platform/gtk/css3/images/cross-fade-simple-expected.txt: Added.
platform/gtk/css3/images/cross-fade-sizing-expected.txt: Added.
platform/gtk/css3/images/cross-fade-tiled-expected.txt: Added.
platform/gtk/fast/borders/border-mixed-alpha-expected.txt: Added.
platform/gtk/fast/css/getComputedStyle/computed-style-cross-fade-expected.txt: Added.

8:45 AM Changeset in webkit [100631] by mario@webkit.org

2 edits in trunk/Source/WebKit/gtk

[Gtk] Ensure the parent for the webView's a11y object is set.

This should fix some accessibility related GTK API tests.

Rubber-stamped by Philippe Normand.

webkit/webkitwebview.cpp:

(webkit_web_view_get_accessible): Always set the parent to make
navigation across GTK and WebKit worlds work properly.

8:43 AM Changeset in webkit [100630] by inferno@chromium.org

9 edits
5 adds in trunk

Crash from nested tables with generated content
https://bugs.webkit.org/show_bug.cgi?id=68811

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-11-17
Reviewed by David Hyatt.

Source/WebCore:

When adding a child to a table that has generated content, this change
ensures that we leave alone any generated content renderers that belong
to descendants in the tree. They don't need to be touched, and doing so
can create confusion about who the content belongs to.

This patch also simplifies some existing code for finding pseudoelement
renderers.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):

rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild):
(WebCore::RenderObject::isBeforeAfterContentGeneratedByAncestor): Added

rendering/RenderObject.h:

(WebCore::RenderObject::findAfterContentRenderer): Deleted
(WebCore::RenderObject::findBeforeContentRenderer): Deleted

rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::beforePseudoElementRenderer):
(WebCore::RenderObjectChildList::afterPseudoElementRenderer):

rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):

rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::addChild):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild):

LayoutTests:

Layout test for nesting tables with generated content and forcing a
style recalculation.

fast/css-generated-content/nested-tables-with-before-after-content-crash.html: Added
platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png: Added
platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added
platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png: Added
platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added

8:40 AM Changeset in webkit [100629] by alexis.menard@openbossa.org

2 edits in trunk/Source/WebKit2

[Qt][WK2] Don't export the private QQuickView.

Reviewed by Kenneth Rohde Christiansen.

We don't need to export that class anymore as the experimental QML plugin
does not expose this object anymore.

UIProcess/API/qt/qquickwebview_p_p.h:

8:32 AM Changeset in webkit [100628] by Patrick Gansterer

2 edits in trunk/Source/WebCore

Unreviewed WinCE build fix for r94119.

MSVC throws multiply defined symbols linker error when using local class in inline function.

bindings/js/JSDictionary.h:

(WebCore::JSDictionary::IdentitySetter::identitySetter):
(WebCore::JSDictionary::tryGetProperty):

8:27 AM Changeset in webkit [100627] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

platform/qt/plugins/plugin-javascript-access-expected.txt: Updated.

8:26 AM Changeset in webkit [100626] by steveblock@google.com

1 edit
1 delete in trunk/LayoutTests

Several animations/ tests flakily fail due to fragile setTimeout()-based framework
https://bugs.webkit.org/show_bug.cgi?id=66953

Remove expectation for animations/missing-values-last-keyframe.html from
platform/chromium-cg-mac-snowleopard. This was incorrectly added by the
rebaseline tool in r100611.

Unreviewed gardening.

platform/chromium-cg-mac-snowleopard/animations/missing-values-last-keyframe-expected.txt: Removed.

8:15 AM Changeset in webkit [100625] by jochen@chromium.org

2 edits in trunk/Tools

Silence a warning about control reaching the end of a non-void function
https://bugs.webkit.org/show_bug.cgi?id=72616

Reviewed by Tony Gentilcore.

DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::verticalScrollbar):

8:10 AM Changeset in webkit [100624] by jochen@chromium.org

2 edits in trunk

[chromium] add gyp-mac-tool to .gitignore
https://bugs.webkit.org/show_bug.cgi?id=72603

Reviewed by Tony Gentilcore.

This file is generated by the make-based build of the chromium/mac port

.: Modified property svn:ignore.
.gitignore:

7:50 AM Changeset in webkit [100623] by caio.oliveira@openbossa.org

2 edits in trunk/Source/WebKit2

[Qt] Expose setUseTraditionalDesktopBehaviour() in QML experimental API
https://bugs.webkit.org/show_bug.cgi?id=72610

Reviewed by Kenneth Rohde Christiansen.

UIProcess/API/qt/qquickwebview_p.h:

7:42 AM Changeset in webkit [100622] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Enable skipped but now passing tests (http/tests)
https://bugs.webkit.org/show_bug.cgi?id=71911

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2011-11-17
Reviewed by Csaba Osztrogonác.

platform/qt/Skipped: Unskip 24 tests.

7:38 AM Changeset in webkit [100621] by kenneth@webkit.org

6 edits in trunk/Source/WebKit2

Print warning for the Qt port when a process crashes and is relaunched
https://bugs.webkit.org/show_bug.cgi?id=72607

Reviewed by Antonio Gomes.

Make the QtViewInterface::processDidCrash take a URL string argument,
for being able to say which url was the origin of the crash.

We now additionally store the load state and url at process exit. This
is needed for printing the warning and for further crash handling.

UIProcess/PageClient.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidCrash):

UIProcess/qt/QtViewInterface.cpp:

(WebKit::QtViewInterface::processDidCrash):
(WebKit::QtViewInterface::didRelaunchProcess):

UIProcess/qt/QtViewInterface.h:
UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::processDidCrash):

UIProcess/qt/QtWebPageProxy.h:

7:05 AM Changeset in webkit [100620] by steveblock@google.com

2 edits in trunk/LayoutTests

ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
https://bugs.webkit.org/show_bug.cgi?id=59552

Add a CRASH expectation for fast/frames/frame-unload-crash.html on
SnowLeopard dbg.

Unreviewed gardening.

platform/chromium/test_expectations.txt:

6:55 AM Changeset in webkit [100619] by alexis.menard@openbossa.org

2 edits in trunk/Source/WebKit/qt

[Qt] The experimental plugin doesn't work after being renamed.

Reviewed by Tor Arne Vestbø.

It was renamed from private to experimental but the qmldir file
was forgotten.

declarative/experimental/qmldir:

6:53 AM Changeset in webkit [100618] by Adam Roben

5 edits in trunk/Tools

Ignore some leaks in frameworks we link against on Lion

Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
aren't WebKit's fault

Reviewed by Antti Koivisto.

Scripts/old-run-webkit-tests:

(countAndPrintLeaks):

Scripts/webkitpy/layout_tests/port/leakdetector.py:

(LeakDetector._callstacks_to_exclude_from_leaks):
Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.

Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.is_lion): Added.

Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
methods.

6:51 AM Changeset in webkit [100617] by alexis.menard@openbossa.org

3 edits in trunk/Source/WebKit2

[Qt][WK2] Cleanup dead code in QtWebPageProxy.
https://bugs.webkit.org/show_bug.cgi?id=72608

Reviewed by Simon Hausmann.

Remove some dead code after we merged our views.
QQuickWebView is now using AC which means that this
path is never called now.

UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::didReceiveDownloadResponse):

UIProcess/qt/QtWebPageProxy.h:

6:49 AM Changeset in webkit [100616] by eric.carlson@apple.com

9 edits
2 adds in trunk

TextTrackList not sorted correctly
https://bugs.webkit.org/show_bug.cgi?id=72545

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-texttracks.html

WebCore.xcodeproj/project.pbxproj: Add TextTrack.h to WebCore private headers because

it is included by HTMLMediaElement.h.

html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack): Pass track type to base class constructor.
(WebCore::LoadableTextTrack::trackElementIndex): New, return the <track> element's tree order

for sorting.

html/LoadableTextTrack.h:

html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Set track type.

html/TextTrack.h:

(WebCore::TextTrack::create): Ditto.
(WebCore::TextTrack::trackType): Ditto.

html/track/TextTrackList.cpp:

(TextTrackList::length): Update to deal with two TextTrack vectors.
(TextTrackList::item): Ditto.
(TextTrackList::append): Ditto.
(TextTrackList::remove): Ditto

html/track/TextTrackList.h: Store the two types of TextTracks in separate Vectors to make

it simpler to keep them in the correct order.

LayoutTests:

media/track/track-texttracks-expected.txt: Added.
media/track/track-texttracks.html: Added.

6:42 AM Changeset in webkit [100615] by steveblock@google.com

1 edit
2 adds in trunk/LayoutTests

[Chromium] Layout test failures under Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=54322

Rebaseline transforms/no_transform_hit_testing.html. It looks like the
expected results aren't quite right after
http://trac.webkit.org/changeset/100507.

Unreviewed gardening.

platform/chromium-cg-mac-snowleopard/transforms/no_transform_hit_testing-expected.png: Added.

6:23 AM Changeset in webkit [100614] by Simon Hausmann

5 edits in trunk/Source

[Qt] Layer violation: WebCore::dnsPrefetch uses QWebSettings::globalSettings()
https://bugs.webkit.org/show_bug.cgi?id=72596

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

We don't need to use QWebSettings here, because we now propagate the DNS prefetch
setting to WebCore::Settings and the rest of WebCore checks the setting before calling
WebCore::prefetchDNS.

platform/network/qt/DnsPrefetchHelper.cpp:

(WebCore::prefetchDNS): Removed the use of QWebSettings.

platform/network/qt/DnsPrefetchHelper.h: Remove offending qwebsettings.h inclusion.

Source/WebKit/qt:

Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply): Propagate the DNS prefetch setting to WebCore::Settings.

6:22 AM Changeset in webkit [100613] by Simon Hausmann

5 edits in trunk/Source

[Qt] Layer violation: Image::loadPlatformResource uses QWebSettings::webGraphic
https://bugs.webkit.org/show_bug.cgi?id=72594

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Move the cache for the resource pixmaps into ImageQt.cpp.

platform/graphics/Image.h: Add Qt specific setter for resource pixmaps.
platform/graphics/qt/ImageQt.cpp: Moved resource pixmap hash from qwebsettings.

(earlyClearGraphics):
(graphics):
(loadResourcePixmap):
(WebCore::Image::setPlatformResource):

Source/WebKit/qt:

Move resource pixmap cache into ImageQt.cpp.

Api/qwebsettings.cpp:

(resourceNameForWebGraphic): Helper function to translate between public API enums and
resource names.
(QWebSettings::setWebGraphic): Call the new ImageQt::setPlatformResource setter.
(QWebSettings::webGraphic): Call Image::loadPlatformResource to read from the cache
in WebCore.

6:15 AM Changeset in webkit [100612] by zeno.albisser@nokia.com

2 edits in trunk/Source/WebCore

[Qt][WK2] Touch/Mouse events are delivered with wrong coordinates.
https://bugs.webkit.org/show_bug.cgi?id=72604

When using the QtViewportInterationEngine for zooming/panning,
no additional scroll offset should be applied to input events
by the ScrollView.

This patch is based on work by Andreas Kling.

Reviewed by Kenneth Rohde Christiansen.

platform/ScrollView.cpp:

(WebCore::ScrollView::windowToContents):
(WebCore::ScrollView::contentsToWindow):

5:39 AM Changeset in webkit [100611] by steveblock@google.com

1 edit
1 copy
5 moves
9 deletes in trunk/LayoutTests

Several animations/ tests flakily fail due to fragile setTimeout()-based framework
https://bugs.webkit.org/show_bug.cgi?id=66953

Rebaselined missing-values-first-keyframe.html,
missing-values-last-keyframe.html and opacity-transform-animation.html.
Looks like these weren't quite right after
http://trac.webkit.org/changeset/100520.

Unreviewed gardening.

platform/chromium-cg-mac-snowleopard/animations/missing-values-last-keyframe-expected.txt: Copied from LayoutTests/animations/missing-values-last-keyframe-expected.txt.
platform/chromium-linux/animations/missing-values-first-keyframe-expected.png: Removed.
platform/chromium-linux/animations/missing-values-last-keyframe-expected.png: Removed.
platform/chromium-linux/animations/opacity-transform-animation-expected.png: Removed.
platform/chromium-mac-snowleopard/animations/missing-values-first-keyframe-expected.png: Removed.
platform/chromium-mac-snowleopard/animations/missing-values-last-keyframe-expected.png: Removed.
platform/chromium-mac-snowleopard/animations/opacity-transform-animation-expected.png: Removed.
platform/chromium-mac/animations/missing-values-first-keyframe-expected.png: Removed.
platform/chromium-mac/animations/missing-values-last-keyframe-expected.png: Removed.
platform/chromium-mac/animations/opacity-transform-animation-expected.png: Removed.
platform/chromium/animations/missing-values-first-keyframe-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/animations/missing-values-first-keyframe-expected.png.
platform/chromium/animations/missing-values-last-keyframe-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/animations/missing-values-last-keyframe-expected.png.
platform/chromium/animations/opacity-transform-animation-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/animations/opacity-transform-animation-expected.png.
platform/mac/animations/missing-values-first-keyframe-expected.txt: Renamed from LayoutTests/animations/missing-values-first-keyframe-expected.txt.
platform/mac/animations/missing-values-last-keyframe-expected.txt: Renamed from LayoutTests/animations/missing-values-last-keyframe-expected.txt.

5:22 AM Changeset in webkit [100610] by vestbo@webkit.org

1 edit in trunk/Tools/WebKitTestRunner/qt/main.cpp

[Qt] Prospective build fix for WebKit2 on Linux

5:19 AM Changeset in webkit [100609] by benm@google.com

2 edits in trunk/Source/WebCore

Unreviewed build fix.

Fix the Windows builds by adding WorkerEventQueue.cpp|h to the
vcproj. Build break was introduced in
https://bugs.webkit.org/show_bug.cgi?id=72528

WebCore.vcproj/WebCore.vcproj: Add missing files.

5:04 AM Changeset in webkit [100608] by loki@webkit.org

2 edits in trunk/LayoutTests

REGRESSION(r100510): Enable 8 Bit Strings in JavaScriptCore https://bugs.webkit.org/show_bug.cgi?id=72602

Unreviewed gardening after r100510.

platform/qt/Skipped:

5:02 AM Changeset in webkit [100607] by vestbo@webkit.org

2 edits
1 delete in trunk/Source/WebKit2

[Qt] Remove forwarding header for WebKit2 C API

The Qt port of WebKit does not provide a C-API for the View classes.

Reviewed by Simon Hausmann.

5:01 AM Changeset in webkit [100606] by steveblock@google.com

2 edits in trunk/LayoutTests

[Chromium] perf/array-binary-search.html fails as MISSING
https://bugs.webkit.org/show_bug.cgi?id=63057

This is really a TEXT failure, but is reported as MISSING due to Bug

Addding both MISSING and TEXT expectations to keep the tree green

working if/when Bug 63104 is fixed.

Unreviewed gardening.

platform/chromium/test_expectations.txt:

4:53 AM Changeset in webkit [100605] by Philippe Normand

2 edits in trunk/Tools

[GTK] Disable ref tests
https://bugs.webkit.org/show_bug.cgi?id=72599

Reviewed by Xan Lopez.

Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref

tests to avoid massive flakiness.

4:46 AM Changeset in webkit [100604] by mihnea@adobe.com

18 edits
6 adds in trunk

CSS Exclusions: parse the wrap-margin and wrap-padding properties
https://bugs.webkit.org/show_bug.cgi?id=71900

Reviewed by Dean Jackson.

Source/WebCore:

Tests: fast/exclusions/wrap-margin-parsing.html

fast/exclusions/wrap-padding-parsing.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSParser.cpp:

(WebCore::isSimpleLengthPropertyID):
(WebCore::CSSParser::parseValue):

css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

css/CSSPropertyNames.in:
css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::wrapPadding):
(WebCore::InheritedFlags::setWrapPadding):
(WebCore::InheritedFlags::initialWrapPadding):
(WebCore::InheritedFlags::wrapMargin):
(WebCore::InheritedFlags::setWrapMargin):
(WebCore::InheritedFlags::initialWrapMargin):

rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
fast/exclusions/script-tests/wrap-margin-parsing.js: Added.
fast/exclusions/script-tests/wrap-padding-parsing.js: Added.
fast/exclusions/wrap-margin-parsing-expected.txt: Added.
fast/exclusions/wrap-margin-parsing.html: Added.
fast/exclusions/wrap-padding-parsing-expected.txt: Added.
fast/exclusions/wrap-padding-parsing.html: Added.
platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
svg/css/getComputedStyle-basic-expected.txt:

4:28 AM Changeset in webkit [100603] by vestbo@webkit.org

3 edits in trunk/Source/WebKit2

[Qt] Resolve import and web-process paths automatically for QML tests

Reviewed by Kenneth Rohde Christiansen.

UIProcess/API/qt/tests/qmltests/qmltests.pro:
UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(main):

4:27 AM Changeset in webkit [100602] by vestbo@webkit.org

32 edits
7 copies
1 move
2 adds
6 deletes in trunk

[Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that

A new extension object has been added to QQuickWebView (the same approach should be used
for other API classes that need experimental APIs). The QML extension mechanism is then
built on top of the experimental object.

https://bugs.webkit.org/show_bug.cgi?id=72522

Reviewed by Simon Hausmann.

4:16 AM Changeset in webkit [100601] by bashi@chromium.org

9 edits
1 copy in trunk/Source

[chromium] don't call fontconfig twice in complex text path
https://bugs.webkit.org/show_bug.cgi?id=38701

Source/WebCore:

Adds a new API for getting font family. For now, FontCacheLinux calls the new API, but don't use additional properties for compatibility. The old API will be removed when Chromium is ready to use new API.

Reviewed by Tony Chang.

No new tests. No behavior changes for now.

platform/chromium/PlatformSupport.h: Added FontFamily struct and changed the declaration of getFontFamilyForCharacters().
platform/graphics/chromium/FontCacheLinux.cpp:

(WebCore::FontCache::getFontDataForCharacters): Uses new PlatformSupport::getFontFamilyForCharacters().

platform/graphics/chromium/FontPlatformDataLinux.h:

(WebCore::FontPlatformData::setFakeBold): Added.
(WebCore::FontPlatformData::setFakeItalic): Added.

Source/WebKit/chromium:

Reviewed by Tony Chang.

Add new API for getFamilyForChars() so that keeping correct font mapping of the given characters.

public/linux/WebFontFamily.h: Added.
public/linux/WebFontInfo.h: Add a new API.
public/linux/WebSandboxSupport.h:

(WebKit::WebSandboxSupport::getFontFamilyForCharacters): Ditto.

src/PlatformSupport.cpp:

(WebCore::PlatformSupport::getFontFamilyForCharacters): Ditto.

src/linux/WebFontInfo.cpp:

(WebKit::WebFontInfo::familyForChars): Modified to get weight and italic properties of the font. Old API uses new API internally.

4:06 AM Changeset in webkit [100600] by steveblock@google.com

2 edits in trunk/LayoutTests

CSS3 cross-fade tests failing on Chromium after r100535
https://bugs.webkit.org/show_bug.cgi?id=72598

Update test expectations.

Unreviewed gardening.

platform/chromium/test_expectations.txt:

3:57 AM Changeset in webkit [100599] by kenneth@webkit.org

2 edits in trunk/Source/WebKit2

Unreviewed build fix.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

3:51 AM Changeset in webkit [100598] by steveblock@google.com

2 edits in trunk/LayoutTests

Compositing LayoutTests failing on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=72487

Update test expectations.

Unreviewed gardening.

platform/chromium/test_expectations.txt:

3:50 AM Changeset in webkit [100597] by mario@webkit.org

4 edits in trunk/Source

[GTK] Consider parent AtkObject in webkit_accessible_get_parent(), if already set
https://bugs.webkit.org/show_bug.cgi?id=72525

Reviewed by Xan Lopez.

Source/WebCore:

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(webkit_accessible_get_parent): Call to the implementation of
atk_object_get_parent in AtkObject class to check whether a parent
AtkObject has been previously set, before trying to find one.

Source/WebKit/gtk:

tests/testatk.c:

(testWebkitAtkSetParentForObject): New unit test to check that
calls to atk_object_get_parent() over a WebKitGTK's accessibility
wrapper object returns its parent AtkObject if previously set.
(main): Added new test.

3:47 AM Changeset in webkit [100596] by mario@webkit.org

3 edits in trunk/Source/WebKit/gtk

[GTK] ATK API tests failing because of patch for bug 72390
https://bugs.webkit.org/show_bug.cgi?id=72592

Reviewed by Philippe Normand.

tests/testatk.c:

(testWebkitAtkParentForRootObject): Remove the offending line in
the unit test, which is not actually required to test the new
functionality and causes problems in some scenarios, due to the
lazy creation mechanism of AtkObjects.

tests/testatkroles.c:

(finish_loading): Reflect that the document frame object is no
longer the root accessibility object (a scroll pane from now on),
but the only child of that one. Thus, skip that root object.

3:27 AM Changeset in webkit [100595] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Not reviewed: fix IE user agents strings in the inspector.

inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):

3:26 AM Changeset in webkit [100594] by kenneth@webkit.org

6 edits in trunk/Source

Make use-fixed-layout work reliable
https://bugs.webkit.org/show_bug.cgi?id=72511

Reviewed by Simon Hausmann.

Source/WebCore:

Always send a viewport update per page load as we depend on that,
to reset all viewport handling before doing layout.

page/Page.cpp:

(WebCore::Page::updateViewportArguments):

Source/WebKit2:

The code handling use-fixed-layout wasn't 100% reliable. The code
was changed to make sure the value is always correct.

It also doesn't set the value by looking at the previous FrameView,
as that wouldn't work in cases, such as when the web process has
crashes.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::setResizesToContentsUsingLayoutSize):
(WebKit::WebPage::setUseFixedLayout):

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::useFixedLayout):

Store the state as m_useFixedLayout so that it can be used
from the WebFrameLoaderClient.

3:13 AM Changeset in webkit [100593] by steveblock@google.com

2 edits in trunk/LayoutTests

[chromium] Support CoreAnimation plugin model on Mac
https://bugs.webkit.org/show_bug.cgi?id=47925

Update test expectations.

Unreviewed gardening.

platform/chromium/test_expectations.txt:

3:01 AM Changeset in webkit [100592] by abarth@webkit.org

2 edits
1 move in trunk/Tools

Move test_results_uploader.py out of layout_package
https://bugs.webkit.org/show_bug.cgi?id=72590

Reviewed by Eric Seidel.

Most of the lines of code in this file are wrong, but I've restrained
myself and only changed a few of them to generalized this class to the
common package.

This is part of a series of patches to remove layout_package.

Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.

2:58 AM Changeset in webkit [100591] by abarth@webkit.org

2 edits in trunk/Tools

Unreviewed. Fix style nits in printing.py.

Scripts/webkitpy/layout_tests/views/printing.py:

2:56 AM Changeset in webkit [100590] by commit-queue@webkit.org

10 edits in trunk/Source/WebKit2

[Qt][WK2] Do not apply new viewport properties until after the first visually non-empty layout.
https://bugs.webkit.org/show_bug.cgi?id=72508

Delay applying viewport properties on the viewport item until after the first visually non-empty
layout finished. It enables the viewport to be intact until the new page is ready to be rendered.

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-11-17
Reviewed by Kenneth Rohde Christiansen.

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::didFinishFirstNonEmptyLayout):
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::updateViewportSize):
(QQuickWebViewPrivate::computeViewportConstraints):

UIProcess/API/qt/qquickwebview_p.h:

(PostTransitionState::isTransitioningToNewPage):

UIProcess/qt/ClientImpl.cpp:

(qt_wk_didFirstVisuallyNonEmptyLayoutForFrame):
(setupPageLoaderClient):

UIProcess/qt/QtViewInterface.cpp:

(WebKit::QtViewInterface::didFinishFirstNonEmptyLayout):
(WebKit::QtViewInterface::didChangeContentsSize):
(WebKit::QtViewInterface::didChangeViewportProperties):
(WebKit::QtViewInterface::startDrag):

UIProcess/qt/QtViewInterface.h:
UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::reset):
(WebKit::QtViewportInteractionEngine::applyConstraints):

UIProcess/qt/QtViewportInteractionEngine.h:
UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::didFinishFirstNonEmptyLayout):
(QtWebPageProxy::didChangeContentsSize):
(QtWebPageProxy::didChangeViewportProperties):
(QtWebPageProxy::startDrag):

UIProcess/qt/QtWebPageProxy.h:

2:12 AM Changeset in webkit [100589] by abarth@webkit.org

2 edits in trunk/Tools

Minor style nits in run_webkit_tests.py
https://bugs.webkit.org/show_bug.cgi?id=72583

Reviewed by Eric Seidel.

This patch just fixes some minor style issues as I work my way back
into this code.

Scripts/webkitpy/layout_tests/run_webkit_tests.py:

2:10 AM Changeset in webkit [100588] by apavlov@chromium.org

6 edits in trunk

Web Inspector: inspector follows javascript: hrefs as relative
https://bugs.webkit.org/show_bug.cgi?id=72373

Source/WebCore:

javascript: hrefs should never be linkified for security.

Reviewed by Yury Semikhatsky.

inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):

inspector/front-end/ResourceUtils.js:

(WebInspector.completeURL):

LayoutTests:

Reviewed by Yury Semikhatsky.

inspector/styles/styles-url-linkify-expected.txt:
inspector/styles/styles-url-linkify.html:

2:09 AM Changeset in webkit [100587] by abarth@webkit.org

3 edits
1 move in trunk/Tools

Move test_result_writer out of layout_package
https://bugs.webkit.org/show_bug.cgi?id=72586

Rubber-stamped by Eric Seidel.

This is part of a series of patches to remove layout_package.

Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
Scripts/webkitpy/tool/commands/rebaseline.py:

2:08 AM Changeset in webkit [100586] by Nikolas Zimmermann

3 edits in trunk/Source/WebCore

2011-11-17 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix 32bit builds.

platform/ClockGeneric.cpp: (ClockGeneric::now): Use narrowPrecisionToFloat.
rendering/FilterEffectRenderer.cpp: (WebCore::FilterEffectRenderer::build): Use it correctly.

2:04 AM Changeset in webkit [100585] by abarth@webkit.org

2 edits in trunk/Tools

svn-apply shouldn't magically move files into Source anymore
https://bugs.webkit.org/show_bug.cgi?id=72579

Reviewed by Eric Seidel.

The Source directory has existed for long enough that we don't need
svn-apply to magically re-write old-style patches anymore.

Scripts/VCSUtils.pm:

(parseGitDiffHeader):
(parseSvnDiffHeader):

1:44 AM Changeset in webkit [100584] by dmazzoni@google.com

3 edits
2 adds in trunk

Accessibility: Chromium requires an AX notification when an iframe loads.
https://bugs.webkit.org/show_bug.cgi?id=72239

Source/WebCore:

When a document finishes loading, we were sending an AXLoadComplete if it
was the top document. Now, if it's a document in an iframe, send an
AXLayoutComplete on the iframe.

Reviewed by Chris Fleizach.

Test: accessibility/loading-iframe-sends-notification.html

dom/Document.cpp:

(WebCore::Document::implicitClose):

LayoutTests:

Reviewed by Chris Fleizach.

accessibility/loading-iframe-sends-notification.html: Added.
platform/chromium/accessibility/loading-iframe-sends-notification-expected.txt: Added.

1:27 AM Changeset in webkit [100583] by commit-queue@webkit.org

3 edits
1 move
1 add in trunk/Source/WebKit2

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2011-11-17
Reviewed by Martin Robinson.

[WK2] Move gtk/BackingStoreGtk.cpp to cairo/BackingStoreCairo.cpp to share with EFL port.
https://bugs.webkit.org/show_bug.cgi?id=62444

Rename gtk/BackingStoreGtk.cpp to cairo/BackingStoreCairo.cpp to share with EFL port.
The gtk/BackingStoreGtk.cpp only has cairo dependency, so it can be shared with other port
that uses cairo.

GNUmakefile.am:
UIProcess/BackingStore.h:
UIProcess/cairo/BackingStoreCairo.cpp: Renamed from Source/WebKit2/UIProcess/gtk/BackingStoreGtk.cpp.

(WebKit::BackingStore::paint):
(WebKit::BackingStore::incorporateUpdate):
(WebKit::BackingStore::scroll):

1:27 AM Changeset in webkit [100582] by abarth@webkit.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Introduce WebSecurityOrigin::isUnique in preparation for removing WebSecurityOrigin::isEmpty
https://bugs.webkit.org/show_bug.cgi?id=72580

Reviewed by Darin Fisher.

We've removed the concept of empty security origins from WebKit because
it doesn't exist in the specs. Now it's time to remove it from the API.

public/WebSecurityOrigin.h:

(WebKit::WebSecurityOrigin::isUnique):

1:21 AM Changeset in webkit [100581] by mrowe@apple.com

3 edits in trunk/Source/WebCore

<http://webkit.org/b/72574> Remove unnecessary use of CarbonCore APIs from Audio code

Reviewed by Andy Estes.

platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestinationMac::AudioDestinationMac): Switch from using the Carbon Component Manager
to using AudioUnit's own component interface.
(WebCore::AudioDestinationMac::~AudioDestinationMac): Ditto.

platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::AudioFileReader): Remove an unncessary trip through the Carbon File Manager
when converting a char* path to a CFURLRef representing the same.

1:10 AM Changeset in webkit [100580] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit2

[WebKit2][gtk] Add few more properties to WebKitSettings
https://bugs.webkit.org/show_bug.cgi?id=72468

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-11-17
Reviewed by Martin Robinson.

Add 'enable-private-browsing', 'enable-developer-extras, 'enable-resizable-text-areas'
and 'enable-tabs-to-links' properties to WebKitSettings.

UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty): Add new set functions.
(webKitSettingsGetProperty): Add new get functions.
(webkit_settings_class_init): Add new properties.
(webkit_settings_get_enable_private_browsing): Get 'enable-private-browsing' property.
(webkit_settings_set_enable_private_browsing): Set 'enable-private-browsing' property.
(webkit_settings_get_enable_developer_extras): Get 'enable-developer-extras' property.
(webkit_settings_set_enable_developer_extras): Set 'enable-developer-extras' property.
(webkit_settings_get_enable_resizable_text_areas): Get 'enable-resizable-text-areas' property.
(webkit_settings_set_enable_resizable_text_areas): Set 'enable-resizable-text-areas' property.
(webkit_settings_get_enable_tabs_to_links): Get 'enable-tabs-to-links' property.
(webkit_settings_set_enable_tabs_to_links): Set 'enable-tabs-to-links' property.

UIProcess/API/gtk/WebKitSettings.h: New public APIs added.
UIProcess/API/gtk/docs/webkit2gtk-sections.txt: New APIs added.
UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Add new tests.

1:02 AM Changeset in webkit [100579] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

Unreviewed. Fix WebKit2 GTK+ build after r100569.

WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse):

12:53 AM Changeset in webkit [100578] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[WebKit2][gtk] Fix assert while running TestWebKitSettings
https://bugs.webkit.org/show_bug.cgi?id=72469

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-11-17
Reviewed by Martin Robinson.

UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Correct the test.

12:48 AM Changeset in webkit [100577] by cevans@google.com

3 edits
2 copies in branches/chromium/912

Merge 100550
BUG=104223
Review URL: http://codereview.chromium.org/8585026

12:42 AM Changeset in webkit [100576] by cevans@google.com

2 edits
2 copies in branches/chromium/912

Merge 99462
BUG=91911
Review URL: http://codereview.chromium.org/8586021

12:37 AM Changeset in webkit [100575] by cevans@google.com

1 edit
2 copies in branches/chromium/912

Merge 99579
BUG=101235
Review URL: http://codereview.chromium.org/8587027

12:25 AM Changeset in webkit [100574] by abarth@webkit.org

3 edits
2 adds in trunk

CSP report-only mode doesn't work from an HTTP header
https://bugs.webkit.org/show_bug.cgi?id=71958

Reviewed by Eric Seidel.

Source/WebCore:

"It's tested or it's broken." -- Adam Leventhal

Test: http/tests/security/contentSecurityPolicy/report-only-from-header.php

loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

LayoutTests:

Test that X-WebKit-CSP-Report-Only actually sends reports.

http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt: Added.
http/tests/security/contentSecurityPolicy/report-only-from-header.php: Added.

12:24 AM Changeset in webkit [100573] by cevans@google.com

1 edit
3 copies in branches/chromium/912

Merge 9964
BUG=102037
Review URL: http://codereview.chromium.org/8480029

12:16 AM Changeset in webkit [100572] by pfeldman@chromium.org

14 edits in trunk/Source

Web Inspector: introduce Debugger domain capabilities concept.
https://bugs.webkit.org/show_bug.cgi?id=72393

Many of the Preferences that we have in Settings.js and override in DevTools.js
are really not preferences, but capabilities. Protocol clients should have a way
of figuring out whether some capability is present before using it.

Reviewed by Yury Semikhatsky.

Source/WebCore:

bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::canSetScriptSource):

bindings/js/ScriptDebugServer.h:
bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::canSetScriptSource):

bindings/v8/ScriptDebugServer.h:
inspector/CodeGeneratorInspector.py:
inspector/Inspector.json:
inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::getCapabilities):

inspector/InspectorDebuggerAgent.h:
inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype.enableDebugger):
(WebInspector.DebuggerModel.prototype.canSetScriptSource):

inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):

inspector/front-end/Settings.js:

Source/WebKit/chromium:

src/js/DevTools.js:

12:10 AM Changeset in webkit [100571] by cevans@google.com

1 edit
3 deletes in branches/chromium/912

Revert 100566 - Merge 99649
BUG=102037
Review URL: http://codereview.chromium.org/8587026

12:08 AM Changeset in webkit [100570] by mihnea@adobe.com

20 edits
6 adds in trunk

CSS exclusions: parse the wrap-flow and wrap-through properties
https://bugs.webkit.org/show_bug.cgi?id=71904

Reviewed by Dean Jackson.

Source/WebCore:

Tests: fast/exclusions/wrap-flow-parsing.html

fast/exclusions/wrap-through-parsing.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator WrapFlow):
(WebCore::CSSPrimitiveValue::operator WrapThrough):

css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

css/CSSPropertyNames.in:
css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

css/CSSValueKeywords.in:
rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::wrapFlow):
(WebCore::InheritedFlags::wrapThrough):
(WebCore::InheritedFlags::setWrapFlow):
(WebCore::InheritedFlags::setWrapThrough):
(WebCore::InheritedFlags::initialWrapFlow):
(WebCore::InheritedFlags::initialWrapThrough):

rendering/style/RenderStyleConstants.h:
rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
fast/exclusions/script-tests/wrap-flow-parsing.js: Added.
fast/exclusions/script-tests/wrap-through-parsing.js: Added.
fast/exclusions/wrap-flow-parsing-expected.txt: Added.
fast/exclusions/wrap-flow-parsing.html: Added.
fast/exclusions/wrap-through-parsing-expected.txt: Added.
fast/exclusions/wrap-through-parsing.html: Added.
platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
svg/css/getComputedStyle-basic-expected.txt:

Nov 16, 2011:

11:59 PM Changeset in webkit [100569] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

[GTK] Use a URI instead of local path to create download destination in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=72500

Reviewed by Philippe Normand.

WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse): Use
g_file_new_for_uri() instad of g_file_new_for_path(). Also use
adoptGRef to fix a memory leak.

11:50 PM Changeset in webkit [100568] by cevans@google.com

3 edits
2 copies in branches/chromium/912

Merge 99731
BUG=89493
Review URL: http://codereview.chromium.org/8591014

11:46 PM Changeset in webkit [100567] by cevans@google.com

2 edits
2 copies in branches/chromium/912

Merge 99565
BUG=102810
Review URL: http://codereview.chromium.org/8588025

11:42 PM Changeset in webkit [100566] by cevans@google.com

1 edit
3 copies in branches/chromium/912

Merge 99649
BUG=102037
Review URL: http://codereview.chromium.org/8591013

11:24 PM Changeset in webkit [100565] by dino@apple.com

12 edits
32 adds in trunk

Implement filter function shorthands
https://bugs.webkit.org/show_bug.cgi?id=68475

Reviewed by Simon Fraser.

Source/WebCore:

Implement the shorthand functions for filter effects.
This includes grayscale, sepia, invert, hue-rotate, saturate,
opacity, gamma, drop-shadow and blur. At the moment sharpen
and url are not supported.

CSSParser needed to be updated because it was mistakenly
clamping saturation values to [0,1]. Any positive number
is allowed so you can produce super-saturated images.

The biggest change was the API to FilterEffectRenderer. It now
builds a list of effects and applies the filter itself.

Note that the drop-shadow and blur operations don't yet
provide accurate results because they produce an output image
that is larger than the input. See
https://bugs.webkit.org/show_bug.cgi?id=71929
https://bugs.webkit.org/show_bug.cgi?id=71930

While I was there, I fixed a small style issue in
CustomFilterOperation.

Tests: css3/filters/effect-blur.html

css3/filters/effect-combined.html
css3/filters/effect-drop-shadow.html
css3/filters/effect-gamma.html
css3/filters/effect-grayscale.html
css3/filters/effect-hue-rotate.html
css3/filters/effect-invert.html
css3/filters/effect-opacity.html
css3/filters/effect-saturate.html
css3/filters/effect-sepia.html

WebCore.xcodeproj/project.pbxproj: Add StyleShader.h to

the project (missing from earlier commit).

css/CSSParser.cpp:

(WebCore::CSSParser::isValidFilterArgument): Don't clamp
saturate to [0,1]

platform/graphics/filters/CustomFilterOperation.h:
rendering/FilterEffectRenderer.cpp:

(WebCore::endMatrixRow):
(WebCore::lastMatrixRow):
(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::inputContext):
(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::prepare):
(WebCore::FilterEffectRenderer::apply):

rendering/FilterEffectRenderer.h:

(WebCore::FilterEffectRenderer::setSourceImageRect):
(WebCore::FilterEffectRenderer::output):
(WebCore::FilterEffectRenderer::setMaxEffectRects):
(WebCore::FilterEffectRenderer::lastEffect):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::updateOrRemoveFilterEffect):
(WebCore::RenderLayer::updateFilterBackingStore):

LayoutTests:

Test the shorthand functions for filter effects.
This includes grayscale, sepia, invert, hue-rotate, saturate,
opacity, gamma, drop-shadow and blur. At the moment sharpen
and url are not supported.

css3/filters/effect-blur-expected.png: Added.
css3/filters/effect-blur-expected.txt: Added.
css3/filters/effect-blur.html: Added.
css3/filters/effect-combined-expected.png: Added.
css3/filters/effect-combined-expected.txt: Added.
css3/filters/effect-combined.html: Added.
css3/filters/effect-drop-shadow-expected.png: Added.
css3/filters/effect-drop-shadow-expected.txt: Added.
css3/filters/effect-drop-shadow.html: Added.
css3/filters/effect-gamma-expected.png: Added.
css3/filters/effect-gamma-expected.txt: Added.
css3/filters/effect-gamma.html: Added.
css3/filters/effect-grayscale-expected.png: Added.
css3/filters/effect-grayscale-expected.txt: Added.
css3/filters/effect-grayscale.html: Added.
css3/filters/effect-hue-rotate-expected.png: Added.
css3/filters/effect-hue-rotate-expected.txt: Added.
css3/filters/effect-hue-rotate.html: Added.
css3/filters/effect-invert-expected.png: Added.
css3/filters/effect-invert-expected.txt: Added.
css3/filters/effect-invert.html: Added.
css3/filters/effect-opacity-expected.png: Added.
css3/filters/effect-opacity-expected.txt: Added.
css3/filters/effect-opacity.html: Added.
css3/filters/effect-saturate-expected.png: Added.
css3/filters/effect-saturate-expected.txt: Added.
css3/filters/effect-saturate.html: Added.
css3/filters/effect-sepia-expected.png: Added.
css3/filters/effect-sepia-expected.txt: Added.
css3/filters/effect-sepia.html: Added.
css3/filters/resources/reference.png: Added.
css3/filters/script-tests/filter-property-parsing-invalid.js:
css3/filters/script-tests/filter-property-parsing.js:

11:11 PM Changeset in webkit [100564] by haraken@chromium.org

28 edits
2 deletes in trunk/Source/WebCore

Remove all custom constructors of Events from JSC
https://bugs.webkit.org/show_bug.cgi?id=72577

Reviewed by Adam Barth.

Makes CodeGeneratorJS.pm generate Event constructors

if [ConstructorTemplate=Event] IDL is specified.

Removes EventConstructors.h and JSEventConstructors.cpp.
Replaces all JSC custom constructors of Events

with the generated code by [ConstructorTemplate=Event] IDL.

Tests: fast/events/constructors/before-load-event-constructor.html

fast/events/constructors/close-event-constructor.html
fast/events/constructors/custom-event-constructor.html
fast/events/constructors/error-event-constructor.html
fast/events/constructors/event-constructors.html
fast/events/constructors/hash-change-event-constructor.html
fast/events/constructors/message-event-constructor.html
fast/events/constructors/overflow-event-constructor.html
fast/events/constructors/page-transition-event-constructor.html
fast/events/constructors/pop-state-event-constructor.html
fast/events/constructors/progress-event-constructor.html
fast/events/constructors/track-event-constructor.html
fast/events/constructors/webkit-animation-event-constructor.html
fast/events/constructors/webkit-transition-event-constructor.html

bindings/generic/EventConstructors.h: Removed. This is what we wanted to do in this patch.
bindings/js/JSEventConstructors.cpp: Ditto.
GNUmakefile.list.am: Removed EventConstructors.h and JSEventConstructors.cpp.
Target.pri: Ditto.
UseJSC.cmake: Ditto.
WebCore.gypi: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
bindings/js/JSBindingsAllInOne.cpp: Ditto.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): Added JSDictionary.h.
(GenerateConstructorDeclaration): Added a header for fillXXXXEventInit(...).
(GenerateConstructorDefinition): Generates an Event constructor. The generated code is the same as the code that had been written in JSEventConstructors.cpp.
(IsConstructable): Judges if a given interface is constructable.
(IsConstructorTemplate): Judges if a given interface has a given template, e.g. judges if an interface has [ConstructorTemplate=Event].

bindings/scripts/test/TestEventConstructor.idl: Changed 'CustomConstructor=Event' to 'ConstructorTemplate=Event'. We should have changed this in r100108.
bindings/scripts/test/JS/JSTestEventConstructor.cpp: Updated a run-bindings-tests result.

(WebCore::JSTestEventConstructorConstructor::constructJSTestEventConstructor):
(WebCore::fillTestEventConstructorInit):

bindings/scripts/test/JS/JSTestEventConstructor.h: Ditto.
bindings/scripts/test/V8/V8TestEventConstructor.cpp: Ditto.

(WebCore::V8TestEventConstructor::constructorCallback):
(WebCore::fillTestEventConstructorInit):

bindings/scripts/test/V8/V8TestEventConstructor.h: Ditto.

dom/BeforeLoadEvent.idl: In essence, replaced [JSCustomConstructor] IDL with [JSConstructorTemplate=Event] IDL.
dom/CustomEvent.idl: Ditto.
dom/ErrorEvent.idl: Ditto.
dom/Event.idl: Ditto.
dom/HashChangeEvent.idl: Ditto.
dom/MessageEvent.idl: Ditto.
dom/OverflowEvent.idl: Ditto.
dom/PageTransitionEvent.idl: Ditto.
dom/PopStateEvent.idl: Ditto.
dom/ProgressEvent.idl: Ditto.
dom/WebKitAnimationEvent.idl: Ditto.
dom/WebKitTransitionEvent.idl: Ditto.
html/track/TrackEvent.idl: Ditto.
websockets/CloseEvent.idl: Ditto.

10:33 PM Changeset in webkit [100563] by dino@apple.com

2 edits in trunk/Source/WebCore

Build fix for Apple WebKit due to r100560.
When I removed the violating header file it lost the
reference to Color.

No review.

platform/graphics/filters/FilterOperation.h:

10:22 PM Changeset in webkit [100562] by rniwa@webkit.org

1 edit
2 adds in trunk/Tools

Add a list of contribution areas
https://bugs.webkit.org/show_bug.cgi?id=72566

Reviewed by Eric Seidel.

Added ContributionAreas class.

Scripts/webkitpy/common/config/contributionareas.py: Added.
Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.

10:20 PM Changeset in webkit [100561] by rniwa@webkit.org

2 edits in trunk/Tools

Refactor ChangeLogTest.test_parse_reviewer_text
https://bugs.webkit.org/show_bug.cgi?id=72572

Reviewed by Eric Seidel.

Refactored the test code by introduing two helper functions.

Scripts/webkitpy/common/checkout/changelog_unittest.py:

9:24 PM Changeset in webkit [100560] by dino@apple.com

4 edits in trunk/Source/WebCore

DropShadowFilterOperation violates platform isolation
https://bugs.webkit.org/show_bug.cgi?id=72544

Reviewed by Simon Fraser.

Move ShadowData properties into the DropShadowFilterOperation
to avoid depending on something outside platform.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::createFilterOperations):

platform/graphics/filters/FilterOperation.h:

(WebCore::DropShadowFilterOperation::create):
(WebCore::DropShadowFilterOperation::x):
(WebCore::DropShadowFilterOperation::y):
(WebCore::DropShadowFilterOperation::stdDeviation):
(WebCore::DropShadowFilterOperation::color):
(WebCore::DropShadowFilterOperation::operator==):
(WebCore::DropShadowFilterOperation::DropShadowFilterOperation):

9:14 PM Changeset in webkit [100559] by jamesr@google.com

4 edits
3 adds in trunk/LayoutTests

[chromium] Update more chromium baselines and expectations

platform/chromium-cg-mac-snowleopard/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Added.
platform/chromium-linux/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
platform/chromium-mac-leopard/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Added.
platform/chromium-mac-snowleopard/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Added.
platform/chromium-win/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
platform/chromium/test_expectations.txt:

9:08 PM Changeset in webkit [100558] by eric@webkit.org

19 edits in trunk/Tools

Add SCMDetector object to make scm detection mockable
https://bugs.webkit.org/show_bug.cgi?id=72247

Reviewed by Adam Barth.

I think SCM detection may eventually be rolled into Checkout,
but this patch at least makes it possible to mock code-paths
which rely on scm detection.
In the process of replacing callers of these free-functions
I found that one of the functions was no longer used,
and that one of the callers could instead just use the SCM
object it already had access to through port.host.scm().
I also discovered that I was not calling Host._initialize_scm()
and thus host.scm() was always returning None!

Scripts/check-webkit-style:
Scripts/webkitpy/common/checkout/checkout_unittest.py:
Scripts/webkitpy/common/checkout/deps.py:
Scripts/webkitpy/common/checkout/scm/init.py:
Scripts/webkitpy/common/checkout/scm/detection.py:
Scripts/webkitpy/common/checkout/scm/git.py:
Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
Scripts/webkitpy/common/checkout/scm/svn.py:
Scripts/webkitpy/common/host.py:
Scripts/webkitpy/common/host_mock.py:
Scripts/webkitpy/layout_tests/controllers/manager.py:
Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/mock_drt.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
Scripts/webkitpy/tool/servers/rebaselineserver.py:

8:51 PM Changeset in webkit [100557] by jamesr@google.com

15 edits
2 moves
36 adds
7 deletes in trunk/LayoutTests

[chromium] Update baselines for compositing tests with video and canvas

platform/chromium-cg-mac-leopard/compositing/geometry/clipped-video-controller-expected.png: Added.
platform/chromium-cg-mac-leopard/compositing/geometry/video-fixed-scrolling-expected.png: Added.
platform/chromium-cg-mac-leopard/compositing/geometry/video-opacity-overlay-expected.png: Added.
platform/chromium-cg-mac-leopard/compositing/layers-inside-overflow-scroll-expected.png: Added.
platform/chromium-cg-mac-leopard/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
platform/chromium-cg-mac-leopard/compositing/overflow/scroll-ancestor-update-expected.png: Added.
platform/chromium-cg-mac-leopard/compositing/self-painting-layers-expected.png: Added.
platform/chromium-cg-mac-snowleopard/compositing/geometry/clipped-video-controller-expected.png: Added.
platform/chromium-cg-mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png: Added.
platform/chromium-cg-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Added.
platform/chromium-cg-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png:
platform/chromium-cg-mac/compositing/geometry/clipped-video-controller-expected.png: Removed.
platform/chromium-cg-mac/compositing/geometry/video-opacity-overlay-expected.png: Removed.
platform/chromium-gpu-cg-mac/compositing/geometry/clipped-video-controller-expected.png: Added.
platform/chromium-gpu-cg-mac/compositing/geometry/video-fixed-scrolling-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/geometry/video-fixed-scrolling-expected.png.
platform/chromium-gpu-cg-mac/compositing/geometry/video-opacity-overlay-expected.png: Added.
platform/chromium-gpu-cg-mac/compositing/layers-inside-overflow-scroll-expected.png: Added.
platform/chromium-gpu-cg-mac/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
platform/chromium-gpu-cg-mac/compositing/overflow/scroll-ancestor-update-expected.png: Added.
platform/chromium-gpu-cg-mac/compositing/self-painting-layers-expected.png: Added.
platform/chromium-linux/compositing/layers-inside-overflow-scroll-expected.png:
platform/chromium-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png:
platform/chromium-linux/compositing/self-painting-layers-expected.png:
platform/chromium-mac-leopard/compositing/geometry/clipped-video-controller-expected.png: Added.
platform/chromium-mac-leopard/compositing/geometry/video-fixed-scrolling-expected.png: Added.
platform/chromium-mac-leopard/compositing/geometry/video-opacity-overlay-expected.png: Added.
platform/chromium-mac-leopard/compositing/layers-inside-overflow-scroll-expected.png: Added.
platform/chromium-mac-leopard/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
platform/chromium-mac-leopard/compositing/overflow/scroll-ancestor-update-expected.png: Added.
platform/chromium-mac-leopard/compositing/self-painting-layers-expected.png: Added.
platform/chromium-mac-snowleopard/compositing/geometry/clipped-video-controller-expected.png: Added.
platform/chromium-mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png: Added.
platform/chromium-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Added.
platform/chromium-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png:
platform/chromium-mac/compositing/geometry/clipped-video-controller-expected.png: Removed.
platform/chromium-mac/compositing/geometry/video-fixed-scrolling-expected.png: Removed.
platform/chromium-mac/compositing/geometry/video-opacity-overlay-expected.png: Removed.
platform/chromium-mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Removed.
platform/chromium-win/compositing/layers-inside-overflow-scroll-expected.png:
platform/chromium-win/compositing/overflow/overflow-compositing-descendant-expected.png:
platform/chromium-win/compositing/overflow/scroll-ancestor-update-expected.png:
platform/chromium-win/compositing/self-painting-layers-expected.png:
platform/chromium/compositing/overflow/overflow-compositing-descendant-expected.png:
platform/chromium/compositing/overflow/scroll-ancestor-update-expected.png:
platform/chromium/compositing/self-painting-layers-expected.png:
platform/chromium/compositing/video-page-visibility-expected.png: Added.
platform/chromium/test_expectations.txt:
platform/mac-lion/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Renamed from LayoutTests/platform/mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt.
platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Removed.

7:58 PM Changeset in webkit [100556] by fpizlo@apple.com

15 edits
2 adds
2 deletes in trunk/Source/JavaScriptCore

Code block jettisoning should be part of the GC's transitive closure
https://bugs.webkit.org/show_bug.cgi?id=72467

Reviewed by Geoff Garen.

Replaced JettisonedCodeBlocks with DFGCodeBlocks. The latter knows about all
DFG code blocks (i.e. those that may be jettisoned, and may have inlined weak
references) and helps track what state each of those code blocks is in during
GC. The state consists of two flags; mayBeExecuting, which tells if the code block
is live from call frames; and isJettisoned, which tells if the code block is
not owned by any executable and thus should be deleted as soon as it is not
mayBeExecuting.

Not executing, Not jettisoned: The code block may or may not be reachable from any executables, but it is owned by an executable, and hence should be kept alive if its executable is live and if all of its weak references are live. Otherwise it should be deleted during the current GC cycle, and its outgoing references should not be scanned.

Not executing but jettisoned: The code block should be deleted as soon as possible and none of its outgoing references should be scanned.

Executing but not jettisoned: The code block should be kept alive during this GC cycle, and all of its outgoing references (including the weak ones) should be scanned and marked strongly. The mayBeExecuting bit will be cleared at the end of the GC cycle.

Executing and jettisoned: The code block should be kept alive during this GC cycle, and all of its outgoing references (including the weak ones) should be scanned and marked strongly. However, on the next GC cycle, it will have its mayBeExecuting bit cleared and hence it will become a candidate for immediate deletion provided it is not executing again.

This is performance-neutral.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
bytecode/CodeBlock.cpp:

(JSC::CodeBlock::~CodeBlock):

bytecode/CodeBlock.h:

(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::DFGData::DFGData):
(JSC::DFGCodeBlocks::mark):

heap/ConservativeRoots.cpp:

(JSC::ConservativeRoots::add):

heap/ConservativeRoots.h:
heap/DFGCodeBlocks.cpp: Added.

(JSC::DFGCodeBlocks::DFGCodeBlocks):
(JSC::DFGCodeBlocks::~DFGCodeBlocks):
(JSC::DFGCodeBlocks::jettison):
(JSC::DFGCodeBlocks::clearMarks):
(JSC::DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks):
(JSC::DFGCodeBlocks::traceMarkedCodeBlocks):

heap/DFGCodeBlocks.h: Added.
heap/Heap.cpp:

(JSC::Heap::jettisonDFGCodeBlock):
(JSC::Heap::markRoots):
(JSC::Heap::collect):

heap/Heap.h:
heap/JettisonedCodeBlocks.cpp: Removed.
heap/JettisonedCodeBlocks.h: Removed.
interpreter/RegisterFile.cpp:

(JSC::RegisterFile::gatherConservativeRoots):

interpreter/RegisterFile.h:
runtime/Executable.cpp:

(JSC::jettisonCodeBlock):

7:50 PM Changeset in webkit [100555] by commit-queue@webkit.org

9 edits
3 adds
6 deletes in trunk/Source/WebCore

Use a simple page client for user consent in getUserMedia()
https://bugs.webkit.org/show_bug.cgi?id=70897

Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2011-11-16
Reviewed by Adam Barth.

This is one in a series of patches that update the MediaStream feature
to use WebCore platform interfaces.

Covered by existing tests.

GNUmakefile.list.am:
WebCore.gypi:
mediastream/MediaStreamClient.h: Removed.
mediastream/MediaStreamController.cpp: Removed.
mediastream/MediaStreamController.h: Removed.
mediastream/MediaStreamFrameController.cpp: Removed.
mediastream/MediaStreamFrameController.h: Removed.
mediastream/UserMediaClient.h: Added.

(WebCore::UserMediaClient::~UserMediaClient):

mediastream/UserMediaRequest.cpp: Added.

(WebCore::UserMediaRequest::create):
(WebCore::UserMediaRequest::UserMediaRequest):
(WebCore::UserMediaRequest::~UserMediaRequest):
(WebCore::UserMediaRequest::start):
(WebCore::UserMediaRequest::mediaStreamSourcesQueryCompleted):
(WebCore::UserMediaRequest::succeed):
(WebCore::UserMediaRequest::fail):
(WebCore::UserMediaRequest::contextDestroyed):
(WebCore::UserMediaRequest::parseOptions):

mediastream/UserMediaRequest.h: Added.

(WebCore::UserMediaRequest::audio):
(WebCore::UserMediaRequest::video):
(WebCore::UserMediaRequest::cameraPreferenceUser):
(WebCore::UserMediaRequest::cameraPreferenceEnvironment):
(WebCore::UserMediaRequest::successCallback):
(WebCore::UserMediaRequest::errorCallback):

page/CallbackTask.h: Removed.
page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::~Frame):
(WebCore::Frame::pageDestroyed):
(WebCore::Frame::transferChildFrameToNewDocument):

page/Frame.h:
page/Navigator.cpp:

(WebCore::Navigator::webkitGetUserMedia):

page/NavigatorUserMediaErrorCallback.h:
page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::PageClients::PageClients):

page/Page.h:

(WebCore::Page::userMediaClient):

7:42 PM Changeset in webkit [100554] by jamesr@google.com

2 edits in trunk/LayoutTests

[chromium] Fix duplicate expectations for chromium mac leopard

platform/chromium/test_expectations.txt:

7:32 PM Changeset in webkit [100553] by mrowe@apple.com

4 edits in trunk/Tools

Fix the build.

The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
Apply the workaround that we use in other projects to WebKitTestRunner.

WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.

7:22 PM Changeset in webkit [100552] by dgrogan@chromium.org

4 edits in trunk/Source/WebCore

instantiate WorkerEventQueue in WorkerContext
https://bugs.webkit.org/show_bug.cgi?id=72528

Reviewed by David Levin.

No new tests - nothing uses it yet.

workers/WorkerContext.cpp:

(WebCore::WorkerContext::WorkerContext):
Instantiate WorkerEventQueue in InitializerList

workers/WorkerEventQueue.h:

Don't inherit from RefCounted, WorkerContext has an OwnPtr to it

7:13 PM Changeset in webkit [100551] by haraken@chromium.org

13 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::JSTestEventConstructor):
(WebCore::JSTestEventConstructorOwner::finalize):

bindings/scripts/test/JS/JSTestEventConstructor.h:

(WebCore::JSTestEventConstructor::impl):
(WebCore::JSTestEventConstructor::releaseImpl):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::JSTestInterface):
(WebCore::JSTestInterfaceOwner::finalize):

bindings/scripts/test/JS/JSTestInterface.h:

(WebCore::JSTestInterface::impl):
(WebCore::JSTestInterface::releaseImpl):

bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
(WebCore::JSTestMediaQueryListListenerOwner::finalize):

bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::impl):
(WebCore::JSTestMediaQueryListListener::releaseImpl):

bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructor::JSTestNamedConstructor):
(WebCore::JSTestNamedConstructorOwner::finalize):

bindings/scripts/test/JS/JSTestNamedConstructor.h:

(WebCore::JSTestNamedConstructor::impl):
(WebCore::JSTestNamedConstructor::releaseImpl):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::JSTestObj):
(WebCore::JSTestObjOwner::finalize):

bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::impl):
(WebCore::JSTestObj::releaseImpl):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::impl):
(WebCore::JSTestSerializedScriptValueInterface::releaseImpl):

7:08 PM Changeset in webkit [100550] by jcivelli@chromium.org

5 edits
2 adds in trunk

Make sure MHTML documents use the domain of the MHTML file.
https://bugs.webkit.org/show_bug.cgi?id=72445

Reviewed by Adam Barth.

Source/WebCore:

dom/Document.h:

(WebCore::Document::setBaseURL):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::receivedFirstData):

LayoutTests:

mhtml/check_domain-expected.txt: Added.
mhtml/check_domain.mht: Added.

7:06 PM Changeset in webkit [100549] by caio.oliveira@openbossa.org

5 edits in trunk

[Qt] Fix build after WTR AX support
https://bugs.webkit.org/show_bug.cgi?id=72560

Reviewed by Geoffrey Garen.

Source/WebKit2:

WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKAccessibilityRootObject):
(WKAccessibilityFocusedObject):

Tools:

WebKitTestRunner/InjectedBundle/DerivedSources.pri:
WebKitTestRunner/InjectedBundle/Target.pri:

6:58 PM Changeset in webkit [100548] by tony@chromium.org

2 edits in trunk/Tools

repurpose the flexbox bot for grid layout
https://bugs.webkit.org/show_bug.cgi?id=72557

Reviewed by Ryosuke Niwa.

Since new flexbox is enabled everywhere, we don't need this bot
anymore. However, work on grid layout has begun, so we can use this
bot to compile with ENABLE_CSS_GRID_LAYOUT.

BuildSlaveSupport/build.webkit.org-config/config.json: Just rename

the bot on the waterfall, I will change the slave config to enable
the compile flag and tests.

6:54 PM Changeset in webkit [100547] by gyuyoung.kim@samsung.com

5 edits in trunk/Source/WebKit/efl

[EFL] Use standard booleand data type in struct.
https://bugs.webkit.org/show_bug.cgi?id=72565

Reviewed by Martin Robinson.

Change *Eina_Bool* usages with *bool* in member variables of internal struct.

ewk/ewk_contextmenu.cpp:
ewk/ewk_frame.cpp:
ewk/ewk_tiled_backing_store.cpp:
ewk/ewk_view.cpp:

6:20 PM Changeset in webkit [100546] by jchaffraix@webkit.org

2 edits in trunk/Source/WebCore

Update supported display list after -webkit-grid and -webkit-inline-grid addition
https://bugs.webkit.org/show_bug.cgi?id=72559

Reviewed by Tony Chang.

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Added the 2 new supported
values (forgotten in the previous change).

6:09 PM Changeset in webkit [100545] by enne@google.com

20 edits
1 add in trunk

[chromium] Expose mock scrollbars to window.internals
https://bugs.webkit.org/show_bug.cgi?id=72195

Reviewed by James Robinson.

Source/autotools/symbols.filter:

Source/WebCore:

testing/Internals.cpp:

(WebCore::Internals::setMockScrollbarsEnabled):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit/chromium:

public/WebSettings.h:
src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setMockScrollbarsEnabled):

src/WebSettingsImpl.h:

Source/WebKit2:

win/WebKit2.def:
win/WebKit2CFLite.def:

Tools:

Because mock scrollbars are a global setting, reset between runs.

DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::applyTo):

LayoutTests:

Change a small number of initial tests that are failing on Chromium
due to small scrollbar pixel differences to use mock scrollbars. These
tests will be rebaselined once they have run through the bots.

compositing/geometry/fixed-position.html:
compositing/geometry/horizontal-scroll-composited.html:
compositing/geometry/vertical-scroll-composited.html:
compositing/overflow/fixed-position-ancestor-clip.html:
compositing/resources/mock_scrollbars.js: Added.

6:00 PM Changeset in webkit [100544] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix for 32-bit.

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

5:53 PM Changeset in webkit [100543] by Lucas Forschler

2 edits in branches/safari-534.54-branch/Source

Fix the build.

5:49 PM Changeset in webkit [100542] by eae@chromium.org

36 edits in branches/subpixellayout/Source

Update chromium/mac port

5:46 PM Changeset in webkit [100541] by Michael Nordman

6 edits
3 deletes in trunk

ApplicationCache manifest should work with any MIME type.
https://bugs.webkit.org/show_bug.cgi?id=72082

Source/WebCore:

Reviewed by Alexey Proskuryakov.

loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Remove the test for a particular type.

LayoutTests:

Update the wrong-content-type test to expect the appcache to succeed given a text/plain contentType.

Reviewed by Alexey Proskuryakov.

http/tests/appcache/wrong-content-type-expected.txt:
http/tests/appcache/wrong-content-type.html:
platform/chromium/test_expectations.txt: Temporarily skip this test in chromium.
platform/chromium-cg-mac/http/tests/appcache/wrong-content-type-expected.txt: Removed.
platform/chromium-mac/http/tests/appcache/wrong-content-type-expected.txt: Removed.
platform/chromium-win/http/tests/appcache/wrong-content-type-expected.txt: Removed.

5:43 PM Changeset in webkit [100540] by ggaren@apple.com

6 edits in trunk/Source/JavaScriptCore

Some CachedCall cleanup, in preparation for reversing argument order.

Reviewed by Gavin Barraclough.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::stronglyVisitWeakReferences): A build fix for the interpreter,
so I can test it.

interpreter/CachedCall.h:

(JSC::CachedCall::CachedCall): Renamed argCount to argumentCount because
we are not that desperate for character saving.

(JSC::CachedCall::setThis):
(JSC::CachedCall::setArgument): Adopted new 0-based argument indexing for
CallFrameClosure.

interpreter/CallFrameClosure.h:

(JSC::CallFrameClosure::setThis):
(JSC::CallFrameClosure::setArgument):
(JSC::CallFrameClosure::resetCallFrame): Provide 0-based argument indexing,
with an explicit setter for 'this', since that's how most clients think.

interpreter/Interpreter.cpp:

(JSC::Interpreter::prepareForRepeatCall):

interpreter/Interpreter.h: Change argCount to argumentCountIncludingThis,

for clarity.

5:43 PM Changeset in webkit [100539] by tony@chromium.org

3 edits in trunk/LayoutTests

Skip failing ref tests on gtk and mac.

platform/gtk/Skipped:
platform/mac/Skipped:

5:34 PM Changeset in webkit [100538] by Lucas Forschler

10 edits in branches/safari-534.53-branch/Source

Merge 94247.

5:33 PM Changeset in webkit [100537] by mhahnenberg@apple.com

4 edits in trunk/Source/JavaScriptCore

De-virtualize ScriptExecutable::unlinkCalls
https://bugs.webkit.org/show_bug.cgi?id=72546

Reviewed by Geoffrey Garen.

runtime/Executable.cpp:

(JSC::FunctionExecutable::~FunctionExecutable): Added an empty explicit virtual destructor to prevent a very odd compilation error
due to the fact that the compiler was trying to generate the implicit inline destructor in every translation unit, some of which
didn't have complete type information on the things that needed to be destructed in the implicit destructor.

runtime/Executable.h:

(JSC::EvalExecutable::createStructure): Used new type value from JSType
(JSC::ProgramExecutable::createStructure): Ditto
(JSC::FunctionExecutable::createStructure): Ditto
(JSC::ScriptExecutable::unlinkCalls): Condition upon the type value, cast and call the corresponding unlinkCalls implementation.

runtime/JSType.h: Added new values for EvalExecutable, ProgramExecutable, and FunctionExecutable. Remove explicit numbers, since

that just adds noise to patches and they currently have no significance.

5:29 PM Changeset in webkit [100536] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

[Chromium] Avoid color mask operations for root layers
https://bugs.webkit.org/show_bug.cgi?id=72452

Instead of relying on the combination of clearing the surface and initializing
the alpha channel to 1.0 followed by disabling alpha in the color mask when
rendering the root layer tiles, add shaders to support writing out opaque layers
(alpha channel values written as 1.0).

Patch by Daniel Sievers <sievers@chromium.org> on 2011-11-16
Reviewed by James Robinson.

No functional change made that requires new tests.

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::tilerProgramOpaque):
(WebCore::LayerRendererChromium::tilerProgramOpaqueAA):
(WebCore::LayerRendererChromium::tilerProgramSwizzleOpaque):
(WebCore::LayerRendererChromium::tilerProgramSwizzleOpaqueAA):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

platform/graphics/chromium/LayerRendererChromium.h:
platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::FragmentTexOpaqueBinding::FragmentTexOpaqueBinding):
(WebCore::FragmentTexOpaqueBinding::init):
(WebCore::FragmentShaderRGBATexOpaque::getShaderString):
(WebCore::FragmentShaderRGBATexSwizzleOpaque::getShaderString):
(WebCore::FragmentTexClampOpaqueAABinding::FragmentTexClampOpaqueAABinding):
(WebCore::FragmentTexClampOpaqueAABinding::init):
(WebCore::FragmentShaderRGBATexClampOpaqueAA::getShaderString):
(WebCore::FragmentShaderRGBATexClampSwizzleOpaqueAA::getShaderString):

platform/graphics/chromium/ShaderChromium.h:

(WebCore::FragmentTexOpaqueBinding::alphaLocation):
(WebCore::FragmentTexOpaqueBinding::samplerLocation):
(WebCore::FragmentTexClampOpaqueAABinding::alphaLocation):
(WebCore::FragmentTexClampOpaqueAABinding::samplerLocation):
(WebCore::FragmentTexClampOpaqueAABinding::fragmentTexTransformLocation):
(WebCore::FragmentTexClampOpaqueAABinding::edgeLocation):

platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::draw):

platform/graphics/chromium/cc/CCTiledLayerImpl.h:

5:28 PM Changeset in webkit [100535] by timothy_horton@apple.com

25 edits
28 adds in trunk

Implement CSS3 Images cross-fade() image function
https://bugs.webkit.org/show_bug.cgi?id=52162
<rdar://problem/10209254>

Reviewed by Simon Fraser.

Render -webkit-cross-fade. Only cross-fades entirely composed of images will render for now,
cross-fades involving generated images are not yet implemented.

Reorganize GeneratedImage to be the base class for GeneratorGeneratedImage and CrossfadeGeneratedImage.

Add a pending state to CSSImageGeneratorValue, which is used to enable the pending-images loading
mechanism for -webkit-cross-fade's sub-images. Rework the logic in CSSStyleSelector to support pending
generated images.

Support parsing fractional values for the cross-fade amount (for example, 0.5 = 50%). Clamp cross-fade
amount to 0-1 range.

Tests: css3/images/cross-fade-invalidation.html

css3/images/cross-fade-simple.html
css3/images/cross-fade-sizing.html
css3/images/cross-fade-tiled.html

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
css/CSSCanvasValue.h:

(WebCore::CSSCanvasValue::isPending):
(WebCore::CSSCanvasValue::loadSubimages):

css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::isPending):
(WebCore::CSSCrossfadeValue::loadSubimages):
(WebCore::subimageIsPending):
(WebCore::loadSubimage):
(WebCore::cachedImageForCSSValue):
(WebCore::CSSCrossfadeValue::image):
(WebCore::CSSCrossfadeValue::crossfadeChanged):

css/CSSCrossfadeValue.h:

(WebCore::CSSCrossfadeValue::create):
(WebCore::CSSCrossfadeValue::~CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::fixedSize):
(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::CrossfadeObserverProxy::CrossfadeObserverProxy):

css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::image):

css/CSSGradientValue.h:

(WebCore::CSSGradientValue::isPending):
(WebCore::CSSGradientValue::loadSubimages):

css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::generatedOrPendingImage):
(WebCore::CSSImageGeneratorValue::generatedImage):
(WebCore::CSSImageGeneratorValue::isPending):
(WebCore::CSSImageGeneratorValue::loadSubimages):

css/CSSImageGeneratorValue.h:
css/CSSParser.cpp:

(WebCore::CSSParser::parseCrossfade):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleImage):
(WebCore::CSSStyleSelector::generatedOrPendingFromValue):
(WebCore::CSSStyleSelector::loadPendingImage):
(WebCore::CSSStyleSelector::loadPendingImages):

css/CSSStyleSelector.h:
platform/graphics/BitmapImage.h:
platform/graphics/CrossfadeGeneratedImage.cpp: Added.

(WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage):
(WebCore::CrossfadeGeneratedImage::~CrossfadeGeneratedImage):
(WebCore::CrossfadeGeneratedImage::drawCrossfade):
(WebCore::CrossfadeGeneratedImage::draw):
(WebCore::CrossfadeGeneratedImage::drawPattern):
(WebCore::CrossfadeGeneratedImage::imageChanged):

platform/graphics/CrossfadeGeneratedImage.h: Added.

(WebCore::CrossfadeGeneratedImage::create):
(WebCore::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
(WebCore::CrossfadeSubimageObserverProxy::setReady):

platform/graphics/GeneratedImage.h:

(WebCore::GeneratedImage::GeneratedImage):

platform/graphics/GeneratorGeneratedImage.cpp: Renamed from Source/WebCore/platform/graphics/GeneratedImage.cpp.

(WebCore::GeneratorGeneratedImage::draw):
(WebCore::GeneratorGeneratedImage::drawPattern):
(WebCore::GeneratedImage::computeIntrinsicDimensions):

platform/graphics/GeneratorGeneratedImage.h: Copied from Source/WebCore/platform/graphics/GeneratedImage.h.

(WebCore::GeneratorGeneratedImage::create):
(WebCore::GeneratorGeneratedImage::~GeneratorGeneratedImage):
(WebCore::GeneratorGeneratedImage::GeneratorGeneratedImage):

platform/graphics/Image.h:
platform/graphics/ImageBuffer.h:
rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::create):
(WebCore::StylePendingImage::data):
(WebCore::StylePendingImage::cssImageValue):
(WebCore::StylePendingImage::cssImageGeneratorValue):
(WebCore::StylePendingImage::StylePendingImage):

Add tests of -webkit-cross-fade, ensuring that simple cross-fades between
two images work correctly.

Adjust fast/css/getComputedStyle/computed-style-cross-fade.html to test
fractional and out-of-range cross-fade percentage values.

css3/images/cross-fade-invalidation.html: Added.
css3/images/cross-fade-simple.html: Added.
css3/images/cross-fade-sizing.html: Added.
css3/images/cross-fade-tiled.html: Added.
css3/images/resources/blue-10.png: Added.
css3/images/resources/blue-100.png: Added.
css3/images/resources/green-10.png: Added.
css3/images/resources/green-100.png: Added.
css3/images/resources/green-circle.svg: Added.
css3/images/resources/red-10.png: Added.
css3/images/resources/red-100.png: Added.
fast/css/getComputedStyle/computed-style-cross-fade-expected.txt:
fast/css/getComputedStyle/computed-style-cross-fade.html:
platform/mac/css3/images/cross-fade-invalidation-expected.png: Added.
platform/mac/css3/images/cross-fade-invalidation-expected.txt: Added.
platform/mac/css3/images/cross-fade-simple-expected.png: Added.
platform/mac/css3/images/cross-fade-simple-expected.txt: Added.
platform/mac/css3/images/cross-fade-sizing-expected.png: Added.
platform/mac/css3/images/cross-fade-sizing-expected.txt: Added.
platform/mac/css3/images/cross-fade-tiled-expected.png: Added.
platform/mac/css3/images/cross-fade-tiled-expected.txt: Added.

5:19 PM Changeset in webkit [100534] by mitz@apple.com

21 edits
1 add in trunk/Source

Source/WebCore: WebCore part of <rdar://problem/10262242> Add API for paginated display
https://bugs.webkit.org/show_bug.cgi?id=72537

Reviewed by Anders Carlsson.

WebCore.exp.in: Exported Page::pageCount().
page/Page.cpp:

(WebCore::Page::pageCount): Added this getter.

page/Page.h:

Source/WebKit/mac: WebKit/mac part of <rdar://problem/10262242> Add API for paginated display
https://bugs.webkit.org/show_bug.cgi?id=72537

Reviewed by Anders Carlsson.

WebView/WebView.mm:

(-[WebView _setPaginationMode:]): Added this accessor.
(-[WebView _paginationMode]): Ditto.
(-[WebView _setGapBetweenPages:]): Ditto.
(-[WebView _gapBetweenPages]): Ditto.
(-[WebView _pageCount]): Ditto.

WebView/WebViewPrivate.h: Defined WebPaginationMode enum and values.

Source/WebKit2: WebKit2 part of <rdar://problem/10262242> Add API for paginated display
https://bugs.webkit.org/show_bug.cgi?id=72537

Reviewed by Anders Carlsson.

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode): Encode the pagination mode and gap between pages.
(WebKit::WebPageCreationParameters::decode): Decode the pagination mode and gap between pages.

Shared/WebPageCreationParameters.h: Added paginationMode and gapBetweenPages members.
UIProcess/API/C/WKPage.cpp:

(WKPageSetPaginationMode): Added this API wrapper.
(WKPageGetPaginationMode): Ditto.
(WKPageSetGapBetweenPages): Ditto.
(WKPageGetGapBetweenPages): Ditto.
(WKPageGetPageCount): Ditto.

UIProcess/API/C/WKPagePrivate.h: Added an enum and a definition of WKPaginationMode and

accessors.

UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController setPaginationMode:]): Added this API wrapper.
(-[WKBrowsingContextController paginationMode]): Ditto.
(-[WKBrowsingContextController setGapBetweenPages:]): Ditto.
(-[WKBrowsingContextController gapBetweenPages]): Ditto.
(-[WKBrowsingContextController pageCount]): Ditto.

UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Added. Includes an enum and a definition

of WKBrowsingContextPaginationMode and property declarations.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy): Added intialization of m_paginationMode, m_gapBetweenPages,
and m_pageCount.
(WebKit::WebPageProxy::setPaginationMode): Added this accessor, which caches the value and sends
a message to the WebPage.
(WebKit::WebPageProxy::setGapBetweenPages): Ditto.
(WebKit::WebPageProxy::creationParameters): Set the pagination mode and gap between pages in the
creation parameters.
(WebKit::WebPageProxy::didChangePageCount): Added. Updates the cached page count.

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::paginationMode): Added this getter that returns a cached value.
(WebKit::WebPageProxy::gapBetweenPages): Ditto.
(WebKit::WebPageProxy::pageCount): Ditto.

UIProcess/WebPageProxy.messages.in: Added DidChangedPageCount, sent when the page count changes

after layout.

WebKit2.xcodeproj/project.pbxproj: Added WKBrowsingContextControllerPrivate.h.
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidLayout): Added a call to WebPage::mainFrameDidLayout(),
allowing the page to respond to changes in the column count.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Added initializer for m_cachedPageCount.
(WebKit::WebPage::setPaginationMode): Added.
(WebKit::WebPage::setGapBetweenPages): Added.
(WebKit::WebPage::mainFrameDidLayout): Added. Sends a DidChangePageCount message to the UI process
if the page count has changed.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in: Added SetPaginationMode and SetGapBetweenPages messages.

5:14 PM Changeset in webkit [100533] by commit-queue@webkit.org

4 edits in trunk

[chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
https://bugs.webkit.org/show_bug.cgi?id=72562

Patch by James Robinson <jamesr@chromium.org> on 2011-11-16
Reviewed by Dirk Pranke.

Tools:

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::runFileTest):

LayoutTests:

platform/chromium/test_expectations.txt:

5:08 PM Changeset in webkit [100532] by Lucas Forschler

9 edits in branches/safari-534.53-branch/Source

Merge 94122.

5:02 PM Changeset in webkit [100531] by Lucas Forschler

9 edits in branches/safari-534.53-branch/Source/WebCore

Merged r93669.

4:59 PM Changeset in webkit [100530] by commit-queue@webkit.org

9 edits
1 add in trunk/Source

[chromium] Track property changes for render surfaces.
https://bugs.webkit.org/show_bug.cgi?id=72521

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-11-16
Reviewed by James Robinson.

Source/WebCore:

Created CCRenderSurfaceTest for testing.

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):

platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::resetPropertyChangedFlagForSubtree):

platform/graphics/chromium/cc/CCLayerImpl.h:
platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::CCRenderSurface):
(WebCore::CCRenderSurface::setClipRect):
(WebCore::CCRenderSurface::setContentRect):
(WebCore::CCRenderSurface::surfacePropertyChanged):

platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore::CCRenderSurface::resetPropertyChangedFlag):

Source/WebKit/chromium:

WebKit.gypi:
tests/CCLayerImplTest.cpp:

(WebCore::TEST):

tests/CCRenderSurfaceTest.cpp: Added.

(WebCore::TEST):

4:58 PM Changeset in webkit [100529] by Lucas Forschler

8 edits
6 copies in branches/safari-534.53-branch

Merge 99315.

4:57 PM Changeset in webkit [100528] by commit-queue@webkit.org

4 edits
3 adds in trunk

Seaming on border corners with mixed colour alpha borders
https://bugs.webkit.org/show_bug.cgi?id=70471

Patch by Ben Wells <benwells@chromium.org> on 2011-11-16
Reviewed by Simon Fraser.

Source/WebCore:

Seaming is fixed by antialiasing mitred corners for edges that have alpha and are joining
a side that is of a different color.

Test: fast/borders/border-mixed-alpha.html

rendering/RenderBoxModelObject.cpp:

(WebCore::colorNeedsAntiAliasAtCorner):
(WebCore::RenderBoxModelObject::paintOneBorderSide):

LayoutTests:

fast/borders/border-mixed-alpha.html: Added.
platform/chromium/test_expectations.txt:
platform/mac/fast/borders/border-mixed-alpha-expected.png: Added.
platform/mac/fast/borders/border-mixed-alpha-expected.txt: Added.

4:49 PM Changeset in webkit [100527] by fpizlo@apple.com

10 edits in trunk/Source/JavaScriptCore

JSC::CodeBlock should know which references generated by the DFG are weak
https://bugs.webkit.org/show_bug.cgi?id=72563

Reviewed by Geoff Garen.

CodeBlock::m_dfgData now tracks weak references and weak reference transitions
(like ephemerons) generated by the DFG. The DFG makes sure to notify the
CodeBlock of all uses of weak references and weak reference transitions.
CodeBlock currently marks them strongly, since the weak marking logic is not
in place, yet.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::stronglyVisitWeakReferences):

bytecode/CodeBlock.h:

(JSC::CodeBlock::appendWeakReference):
(JSC::CodeBlock::shrinkWeakReferencesToFit):
(JSC::CodeBlock::appendWeakReferenceTransition):
(JSC::CodeBlock::shrinkWeakReferenceTransitionsToFit):
(JSC::CodeBlock::WeakReferenceTransition::WeakReferenceTransition):

bytecode/CodeOrigin.h:

(JSC::CodeOrigin::codeOriginOwner):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addWeakReference):
(JSC::DFG::JITCompiler::addWeakReferenceTransition):
(JSC::DFG::JITCompiler::branchWeakPtr):

dfg/DFGSpeculativeJIT.h:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::compile):

4:46 PM Changeset in webkit [100526] by Lucas Forschler

7 edits in branches/safari-534.53-branch/Tools

Merged r93052.

4:39 PM Changeset in webkit [100525] by Lucas Forschler

9 edits in branches/safari-534.53-branch/Source/WebKit2

Merge 93314.

4:35 PM Changeset in webkit [100524] by Lucas Forschler

54 edits in branches/safari-534.53-branch/Source

Merge 93303.

4:25 PM Changeset in webkit [100523] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

LayoutTests for Debug Builds Crashes in JavaScriptCore/yarr/YarrInterpreter.cpp(185)
https://bugs.webkit.org/show_bug.cgi?id=72561

Removed #if USE(JSC) and therefore the ASSERT_NOT_REACHED().
Simplified the code in the process.

Reviewed by James Robinson.

yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::CharAccess::CharAccess):
(JSC::Yarr::Interpreter::CharAccess::~CharAccess):

4:23 PM Changeset in webkit [100522] by Lucas Forschler

54 edits in branches/safari-534.53-branch/Source

rollout merge of 93303, nee to fixup changelogs.

4:21 PM Changeset in webkit [100521] by ggaren@apple.com

3 edits in trunk/Source/JavaScriptCore

Interpreter build fixes.

bytecode/CodeBlock.h:
interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

4:20 PM Changeset in webkit [100520] by pkasting@chromium.org

5 edits
9 adds
3 deletes in trunk/LayoutTests

[chromium] Clean up some animations/ expectations.
https://bugs.webkit.org/show_bug.cgi?id=66953

Rebaselines some tests that clearly just needed that, tries to condense
a number of other flaky tests onto one bug, updates the set of bots that
are actually failing for some expectations.

Unreviewed, gardening.

platform/chromium-cg-mac/animations/missing-values-first-keyframe-expected.png: Removed.
platform/chromium-cg-mac/animations/missing-values-last-keyframe-expected.png: Removed.
platform/chromium-cg-mac/animations/opacity-transform-animation-expected.png: Removed.
platform/chromium-linux/animations/missing-values-first-keyframe-expected.png: Added.
platform/chromium-linux/animations/missing-values-last-keyframe-expected.png: Added.
platform/chromium-linux/animations/opacity-transform-animation-expected.png: Added.
platform/chromium-mac-leopard/animations/missing-values-first-keyframe-expected.png: Added.
platform/chromium-mac-leopard/animations/missing-values-last-keyframe-expected.png: Added.
platform/chromium-mac-leopard/animations/opacity-transform-animation-expected.png: Added.
platform/chromium-mac-snowleopard/animations/missing-values-first-keyframe-expected.png: Added.
platform/chromium-mac-snowleopard/animations/missing-values-last-keyframe-expected.png: Added.
platform/chromium-mac-snowleopard/animations/opacity-transform-animation-expected.png: Added.
platform/chromium-win/animations/missing-values-first-keyframe-expected.png:
platform/chromium-win/animations/missing-values-last-keyframe-expected.png:
platform/chromium-win/animations/opacity-transform-animation-expected.png:
platform/chromium/test_expectations.txt:

4:16 PM Changeset in webkit [100519] by Lucas Forschler

54 edits in branches/safari-534.53-branch/Source

Merge 93303.

4:04 PM Changeset in webkit [100518] by Patrick Gansterer

2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for !ENABLE(JIT) after r100363.

bytecode/CodeBlock.h:

3:46 PM Changeset in webkit [100517] by weinig@apple.com

4 edits in trunk/Source/WebCore

JS wrappers of DOM objects should have no-op constructors
https://bugs.webkit.org/show_bug.cgi?id=72556

Reviewed by Geoffrey Garen.

Stop using a RefPtr to hold DOM objects contained by JavaScript
wrappers and instead use a raw pointer. We were already releasing
the underlying object before the destructor ran (via the finalizer)
so the default behavior of destroying the RefPtr is always unnecessary
busy work.

bindings/js/JSCSSValueCustom.cpp:

(WebCore::JSCSSValueOwner::finalize):

bindings/js/JSNodeCustom.cpp:

(WebCore::JSNodeOwner::finalize):
(WebCore::JSNode::visitChildren):
Call releaseImpl() instead of clearImpl().

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
Stop storing m_impl in a RefPtr and instead use a raw pointer. Switch
clearImpl() to releaseImpl(), which explicitly derefs the pointer and
clear it.

(GenerateImplementation):
Use leakPtr() to explicitly adopt the PassRefPtr into the raw pointer.
Change default finalize to call releaseImpl() instead of clearImpl().

3:37 PM Changeset in webkit [100516] by ggaren@apple.com

8 edits in trunk/Source/JavaScriptCore

Rolled back in r100375 and r100385 with 32-bit build fixed.

dfg/DFGOperations.cpp:
jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

runtime/ArgList.cpp:

(JSC::ArgList::getSlice):

runtime/ArgList.h:
runtime/JSArray.cpp:

(JSC::JSArray::finishCreation):

runtime/JSArray.h:

(JSC::JSArray::create):

runtime/JSGlobalObject.h:

(JSC::constructArray):

3:33 PM Changeset in webkit [100515] by Lucas Forschler

23 edits in branches/safari-534.53-branch/Source

Merge 93058.

3:21 PM Changeset in webkit [100514] by fpizlo@apple.com

5 edits
3 adds in trunk

DFG global variable CSE mishandles the cross-global-object inlining corner case
https://bugs.webkit.org/show_bug.cgi?id=72542

Source/JavaScriptCore:

Reviewed by Geoff Garen.

Moved code to get the global object for a code origin into CodeBlock, so it is
more broadly accessible. Fixed CSE to compare both the variable number, and the
global object, before deciding to perform elimination.

bytecode/CodeBlock.h:

(JSC::CodeBlock::globalObjectFor):

dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::globalObjectFor):

dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

LayoutTests:

Reviewed by Geoff Garen.

fast/js/cross-global-object-inline-global-var-expected.txt: Added.
fast/js/cross-global-object-inline-global-var.html: Added.
fast/js/script-tests/cross-global-object-inline-global-var.js: Added.

(foo):
(done):
(doit):

3:02 PM Changeset in webkit [100513] by dpranke@chromium.org

2 edits in trunk/Tools

Revert r100509; change was committed twice (first time as r100491).
Unreviewed, build fix.

Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

2:57 PM Changeset in webkit [100512] by jamesr@google.com

3 edits in trunk/LayoutTests

[chromium] Update text baselines for mq-transform-0[23] tests

platform/chromium-mac-snowleopard/fast/media/mq-transform-02-expected.txt:
platform/chromium-mac-snowleopard/fast/media/mq-transform-03-expected.txt:

2:53 PM Changeset in webkit [100511] by tony@chromium.org

3 edits in trunk/Tools

[NRWT] speculative fix for multiple subprocess test on cygwin
https://bugs.webkit.org/show_bug.cgi?id=72518

Reviewed by Adam Barth.

Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably

tries to emulate posix fd behavior.

Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

2:46 PM Changeset in webkit [100510] by msaboff@apple.com

22 edits in trunk/Source

Enable 8 Bit Strings in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=71337

Source/JavaScriptCore:

This patch turns on 8 bit strings in StringImpl and enables
their use in JavaScriptCore. Some of the changes are to
turn on code that had been staged (Lexer.cpp, Identifier.cpp,
SmallStrings.cpp and some of StringImpl.{h,cpp}).
Other changes are minor fixes to make 8 bit strings work
(UString.h, StringImpl::getData16SlowCase()).
Changed StringBuffer to be a templated class based on character
type. This change rippled into WebCore code as well.

Reviewed by Geoffrey Garen.

JavaScriptCore.exp:
parser/Lexer.cpp:

(JSC::::append8): Changed to use 8 bit buffers.
(JSC::::parseIdentifier): Changed to use 8 bit buffers.
(JSC::::parseString): Changed to use 8 bit buffers.

runtime/Identifier.cpp:

(JSC::IdentifierCStringTranslator::translate): 8 bit version keeps data 8 bit
(JSC::Identifier::toUInt32FromCharacters): Templated helper.
(JSC::Identifier::toUInt32): Added 8 bit optimized path.

runtime/SmallStrings.cpp:

(JSC::SmallStringsStorage::SmallStringsStorage): Changed to be 8 bit strings

runtime/UString.h:

(JSC::UString::characters): Now calls StringImpl::characters()

wtf/Forward.h:
wtf/text/StringBuffer.h: Made StringBuffer a template base on character type.

(WTF::StringBuffer::StringBuffer):
(WTF::StringBuffer::characters):
(WTF::StringBuffer::release):

wtf/text/StringImpl.cpp:

(WTF::StringImpl::create):
(WTF::StringImpl::getData16SlowCase): Fixed null terminated case.
(WTF::StringImpl::removeCharacters): Added 8 bit path.
(WTF::StringImpl::simplifyMatchedCharactersToSpace):
(WTF::StringImpl::simplifyWhiteSpace):
(WTF::equal): Removed bug from code copied from null terminated version.
(WTF::StringImpl::adopt): Added 8 bit path.
(WTF::StringImpl::createWithTerminatingNullCharacter): Fixed 8 bi flag propagation.

wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl): Added new 8 bit constructor.
(WTF::StringImpl::characters8): Removed ASSERT_NOT_REACHED().
(WTF::getCharacters<LChar>): Added templated accessor for 8 bit strings.
(WTF::getCharacters<UChar>): Added templated accessor for 16 bit strings.

wtf/text/WTFString.h:

(WTF::String::adopt): Changed to use StringBuffer template.

Source/WebCore:

Reviewed by Geoffrey Garen.

No new tests - Changes in response to refactoring StringBuffer to
be a template on character type.

css/CSSParser.cpp:

(WebCore::quoteCSSString):

css/CSSPrimitiveValue.cpp:

(WebCore::formatNumber):

dom/Document.cpp:

(WebCore::canonicalizedTitle):

platform/Length.cpp:

(WebCore::newCoordsArray):

platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare):

platform/text/TextCodecUTF16.cpp:

(WebCore::TextCodecUTF16::decode):

platform/text/TextCodecUTF8.cpp:

(WebCore::TextCodecUTF8::decode):

rendering/RenderText.cpp:

(WebCore::makeCapitalized):

xml/XSLTProcessorLibxslt.cpp:

(WebCore::writeToStringBuilder):

2:44 PM Changeset in webkit [100509] by dpranke@chromium.org

2 edits in trunk/Tools

Run a dummy test in the gpu configurations if there's nothing to do.
https://bugs.webkit.org/show_bug.cgi?id=72498

Reviewed by James Robinson.

Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

2:37 PM Changeset in webkit [100508] by commit-queue@webkit.org

12 edits in trunk/Source

[chromium] Improvements for page scale delta during commit
https://bugs.webkit.org/show_bug.cgi?id=72471

Patch by Alexandre Elias <aelias@google.com> on 2011-11-16
Reviewed by James Robinson.

Page scale now follows the same commit flow as scroll position:
the delta is folded into m_pageScale at BFAC time, and a "sent" value
is preserved for temporary use until the commit finishes.

I also merged setPageScaleFactor and setPageScaleFactorLimits into one
function on the impl side. The reason is that setPageFactor must
be applied after the limits are updated, but on the other hand setting
the limits first may cause an unnecessary clamp of the scale delta.
Merging the methods avoids this bind.

No new tests. (planning to add later: https://bugs.webkit.org/show_bug.cgi?id=71529)

Source/WebCore:

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::applyScrollAndScale):

platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore::CCLayerTreeHostImpl::adjustScrollsForPageScaleChange):
(WebCore::CCLayerTreeHostImpl::setScaleDelta):
(WebCore::CCLayerTreeHostImpl::applyScaleDeltaToScrollLayer):
(WebCore::CCLayerTreeHostImpl::scrollRootLayer):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Source/WebKit/chromium:

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::applyScrollAndScale):

2:34 PM Changeset in webkit [100507] by pkasting@chromium.org

3 edits
1 add in trunk/LayoutTests

[chromium] Attempt to rebaseline a test.
https://bugs.webkit.org/show_bug.cgi?id=54322

Unreviewed, gardening.

platform/chromium-cg-mac-leopard/transforms/no_transform_hit_testing-expected.png: Added.
platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png:
platform/chromium/test_expectations.txt:

2:24 PM Changeset in webkit [100506] by commit-queue@webkit.org

1 edit
3 adds in trunk/LayoutTests

Platform specific results for svg/foreignObject/{clip,filter,mask}.html
https://bugs.webkit.org/show_bug.cgi?id=72532

Patch by Florin Malita <fmalita@google.com> on 2011-11-16
Reviewed by Steve Block.

platform/chromium-cg-mac-snowleopard/svg/foreignObject/clip-expected.png: Added.
platform/chromium-cg-mac-snowleopard/svg/foreignObject/filter-expected.png: Added.
platform/chromium-cg-mac-snowleopard/svg/foreignObject/mask-expected.png: Added.

2:24 PM Changeset in webkit [100505] by rniwa@webkit.org

3 edits in trunk/Tools

contributors_by_fuzzy_match is super slow
https://bugs.webkit.org/show_bug.cgi?id=72540

Reviewed by Eric Seidel.

Make contributors_by_name do case insensitive search using a dictionary.

Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
because that's the most common case.

Scripts/webkitpy/common/config/committers.py:
Scripts/webkitpy/common/config/committers_unittest.py:

2:21 PM Changeset in webkit [100504] by commit-queue@webkit.org

6 edits in trunk

IndexedDB: Reduce nested key depth threshold, re-enable flaky test
https://bugs.webkit.org/show_bug.cgi?id=72529

Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-16
Reviewed by Adam Barth.

Source/WebCore:

Drop maximum array key depth from 20k to 2k.

bindings/v8/IDBBindingUtilities.cpp:

LayoutTests:

Re-enable flaky test, and drop the maximum depth tested to avoid
crashes/timeouts on test boxes when prepping the test.

platform/chromium/test_expectations.txt:
storage/indexeddb/key-type-array-expected.txt:
storage/indexeddb/key-type-array.html:

2:10 PM Changeset in webkit [100503] by Nate Chapin

5 edits in trunk

Source/WebCore: Fix incorrect multipart handling in r100311.
SubresourceLoader::didReceiveData() is getting called
twice, which has unintended side effects.
https://bugs.webkit.org/show_bug.cgi?id=72436

Reviewed by Adam Barth.

http/tests/multipart/invalid-image-data.html should stop
asserting after this.

loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didReceiveData):
(WebCore::SubresourceLoader::sendDataToResource):

loader/SubresourceLoader.h:

LayoutTests: Remove CRASH expectation for
http/tests/multipart/invalid-image-data.html.
https://bugs.webkit.org/show_bug.cgi?id=72436

Reviewed by Adam Barth.

platform/chromium/test_expectations.txt:

2:07 PM Changeset in webkit [100502] by jschuh@chromium.org

3 edits
2 adds in trunk

Clear SVG filter client when its node is detached
https://bugs.webkit.org/show_bug.cgi?id=71741

Reviewed by Eric Seidel.

Source/WebCore:

Test: svg/filters/reparent-animated-filter-target.html

rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientDestroyed):

LayoutTests:

svg/filters/reparent-animated-filter-target-expected.txt: Added.
svg/filters/reparent-animated-filter-target.html: Added.

2:02 PM Changeset in webkit [100501] by pkasting@chromium.org

2 edits
5 deletes in trunk/LayoutTests

[chromium] Mark some CoreAnimation plugin model tests as WONTFIX on Win/
Linux, and as expected to fail for now on Mac; remove current expected
Mac baselines.
https://bugs.webkit.org/show_bug.cgi?id=47925

Unreviewed, gardening.

platform/chromium-mac/compositing/plugins/composited-plugin-expected.txt: Removed.
platform/chromium-mac/compositing/plugins/small-to-large-composited-plugin-expected.txt: Removed.
platform/chromium-win/compositing/plugins/1x1-composited-plugin-expected.txt: Removed.
platform/chromium-win/compositing/plugins/large-to-small-composited-plugin-expected.txt: Removed.
platform/chromium-win/compositing/plugins/small-to-large-composited-plugin-expected.txt: Removed.
platform/chromium/test_expectations.txt:

1:54 PM Changeset in webkit [100500] by commit-queue@webkit.org

4 edits in trunk/Source

Page/layer flashes after GPU-accelerated CSS transition
https://bugs.webkit.org/show_bug.cgi?id=72343

LayerRendererChromium was resizing the window to 1x1 at initialization.
In some cases, there is no drawLayers before switching back to
software rendering. This left the window resized to 1x1 and the
following software paints would therefore not be visible. This change
moves the reshape call into drawLayers so that it will only be called
if rendering will occur.

Patch by John Bates <jbates@google.com> on 2011-11-16
Reviewed by James Robinson.

New test: CCLayerTreeHostImplTest.reshapeNotCalledUntilDraw.

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::doViewportChanged):
(WebCore::LayerRendererChromium::drawLayersInternal):

platform/graphics/chromium/LayerRendererChromium.h:

1:51 PM Changeset in webkit [100499] by levin@chromium.org

3 edits in trunk/Tools

check-webkit-style should recognize functions even if they have OVERRIDE after them.
https://bugs.webkit.org/show_bug.cgi?id=72515

Reviewed by Adam Barth.

Scripts/webkitpy/style/checkers/cpp.py:
Scripts/webkitpy/style/checkers/cpp_unittest.py:

1:22 PM Changeset in webkit [100498] by jamesr@google.com

10 edits
12 copies
23 adds in trunk/LayoutTests

[chromium] Update chromium expectations for fast/media/mq-transform-0[23].html to reflect that chromium DRT has
2d and 3d transforms enabled

platform/chromium-cg-mac-leopard/fast/media/mq-transform-02-expected.png: Added.
platform/chromium-cg-mac-leopard/fast/media/mq-transform-02-expected.txt: Added.
platform/chromium-cg-mac-leopard/fast/media/mq-transform-03-expected.png: Added.
platform/chromium-cg-mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
platform/chromium-cg-mac-snowleopard/fast/media/mq-transform-02-expected.png: Added.
platform/chromium-cg-mac-snowleopard/fast/media/mq-transform-02-expected.txt: Added.
platform/chromium-cg-mac-snowleopard/fast/media/mq-transform-03-expected.png: Added.
platform/chromium-cg-mac-snowleopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
platform/chromium-gpu-cg-mac/fast/media/mq-transform-02-expected.png: Added.
platform/chromium-gpu-cg-mac/fast/media/mq-transform-02-expected.txt: Added.
platform/chromium-gpu-cg-mac/fast/media/mq-transform-03-expected.png: Added.
platform/chromium-gpu-cg-mac/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
platform/chromium-linux-x86/fast/media/mq-transform-02-expected.png: Added.
platform/chromium-linux-x86/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-02-expected.txt.
platform/chromium-linux-x86/fast/media/mq-transform-03-expected.png: Added.
platform/chromium-linux-x86/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
platform/chromium-linux/fast/media/mq-transform-02-expected.png:
platform/chromium-linux/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-02-expected.txt.
platform/chromium-linux/fast/media/mq-transform-03-expected.png:
platform/chromium-linux/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
platform/chromium-mac-leopard/fast/media/mq-transform-02-expected.png:
platform/chromium-mac-leopard/fast/media/mq-transform-02-expected.txt: Added.
platform/chromium-mac-leopard/fast/media/mq-transform-03-expected.png:
platform/chromium-mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
platform/chromium-mac-snowleopard/fast/media/mq-transform-02-expected.png: Added.
platform/chromium-mac-snowleopard/fast/media/mq-transform-02-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/media/mq-transform-03-expected.png: Added.
platform/chromium-mac-snowleopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
platform/chromium-win-vista/fast/media/mq-transform-02-expected.png: Added.
platform/chromium-win-vista/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-02-expected.txt.
platform/chromium-win-vista/fast/media/mq-transform-03-expected.png: Added.
platform/chromium-win-vista/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
platform/chromium-win-xp/fast/media/mq-transform-02-expected.png: Added.
platform/chromium-win-xp/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-02-expected.txt.
platform/chromium-win-xp/fast/media/mq-transform-03-expected.png: Added.
platform/chromium-win-xp/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
platform/chromium-win/fast/media/mq-transform-02-expected.png:
platform/chromium-win/fast/media/mq-transform-02-expected.txt:
platform/chromium-win/fast/media/mq-transform-03-expected.png:
platform/chromium-win/fast/media/mq-transform-03-expected.txt:
platform/chromium/test_expectations.txt:

1:14 PM Changeset in webkit [100497] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/chromium

Fix up chromium API for creating events, initializing message events
https://bugs.webkit.org/show_bug.cgi?id=71478

Fix a mistake when checking the exception code during event creation.
Change WebFrame parameter to pointer so that NULL may be passed.

This is required for the following chromium CL: http://codereview.chromium.org/8437093/

Tested in Chromium by:

ui_test --gtest_filter=*PPAPITest.PostMessage*

Patch by Dave Michael <dmichael@chromium.org> on 2011-11-16
Reviewed by Darin Fisher.

public/WebDOMMessageEvent.h:
src/WebDOMMessageEvent.cpp:

(WebKit::WebDOMMessageEvent::initMessageEvent):

src/WebDocument.cpp:

(WebKit::WebDocument::createEvent):

1:11 PM Changeset in webkit [100496] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[chromium] Add null pointer check in setDeviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=72464

Patch by Alexandre Elias <aelias@google.com> on 2011-11-16
Reviewed by James Robinson.

No new tests. (Tiny fix.)

page/Page.cpp:

(WebCore::Page::setDeviceScaleFactor):

1:07 PM Changeset in webkit [100495] by commit-queue@webkit.org

10 edits in trunk/Source

Unreviewed, rolling out r100438.
http://trac.webkit.org/changeset/100438
https://bugs.webkit.org/show_bug.cgi?id=72536

Broke unit tests (Requested by jamesr_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-16

Source/WebCore:

platform/PlatformScreen.h:
platform/chromium/PlatformScreenChromium.cpp:
platform/chromium/PlatformSupport.h:
platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeImplOnImplThread):

Source/WebKit/chromium:

public/WebScreenInfo.h:

(WebKit::WebScreenInfo::WebScreenInfo):

src/PlatformSupport.cpp:
src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

1:03 PM Changeset in webkit [100494] by tony@chromium.org

5 edits in trunk/Tools

[NRWT] refactor drivers to require pixel_tests param
https://bugs.webkit.org/show_bug.cgi?id=72517

Reviewed by Ojan Vafai.

No tests, just a refactoring.

Scripts/webkitpy/layout_tests/port/chromium.py:
Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
Scripts/webkitpy/layout_tests/port/webkit.py:
Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

12:50 PM Changeset in webkit [100493] by mhahnenberg@apple.com

3 edits in trunk/Source/JavaScriptCore

De-virtualize ExecutableBase::clearCodeVirtual
https://bugs.webkit.org/show_bug.cgi?id=72337

Reviewed by Darin Adler.

Added static finalize functions to the subclasses of ExecutableBase that provide an implementation
of clearCodeVirtual, changed all of the clearCodeVirtual methods to non-virtual clearCode method,
and had the finalize functions call the corresponding clearCode methods.

runtime/Executable.cpp:

(JSC::ExecutableBase::clearCode):
(JSC::NativeExecutable::finalize):
(JSC::EvalExecutable::finalize):
(JSC::EvalExecutable::clearCode):
(JSC::ProgramExecutable::finalize):
(JSC::ProgramExecutable::clearCode):
(JSC::FunctionExecutable::discardCode):
(JSC::FunctionExecutable::finalize):
(JSC::FunctionExecutable::clearCode):

runtime/Executable.h:

(JSC::ExecutableBase::finishCreation):
(JSC::NativeExecutable::create):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::create):
(JSC::FunctionExecutable::create):

12:43 PM Changeset in webkit [100492] by aestes@apple.com

4 edits in trunk/Source/WebCore

Assertion failure in LayerFlushScheduler::resume() when running some layout tests in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=72535

Reviewed by Anders Carlsson.

LayerFlushScheduler attempted to use a counter strategy for calls to
suspend() and resume(), which allowed us to assert that these calls
were balanced. Unfortunately it is hard to guarantee this in WebKit2,
where we sometimes try to call suspend() before we've entered
compositing mode (hence before we have a LayerTreeHost and a
LayerFlushScheduler). When we later call resume(), this call ends up
being unbalanced and asserts.

For now, remove the assertions and allow unbalanced calls to suspend()
and resume().

platform/graphics/ca/LayerFlushScheduler.cpp:

(WebCore::LayerFlushScheduler::suspend):
(WebCore::LayerFlushScheduler::resume):

platform/graphics/ca/LayerFlushScheduler.h:
platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:

(WebCore::LayerFlushScheduler::LayerFlushScheduler):
(WebCore::LayerFlushScheduler::runLoopObserverCallback):
(WebCore::LayerFlushScheduler::schedule):

12:42 PM Changeset in webkit [100491] by dpranke@chromium.org

2 edits in trunk/Tools

Run a dummy test in the gpu configurations if there's nothing to do.
https://bugs.webkit.org/show_bug.cgi?id=72498

Reviewed by James Robinson.

Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

12:27 PM Changeset in webkit [100490] by robert@webkit.org

17 edits
5 deletes in trunk

Unreviewed, rolling out r100473.
http://trac.webkit.org/changeset/100473
https://bugs.webkit.org/show_bug.cgi?id=72534

"Broke the Mac Build" (Requested by mwenge2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-16

Source/WebCore:

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):

rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):
(WebCore::RenderObject::addChild):

rendering/RenderObject.h:
rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):

rendering/RenderTable.h:
rendering/RenderTableCaption.cpp: Removed.
rendering/RenderTableCaption.h: Removed.

LayoutTests:

css2.1/20110323/border-collapse-offset-002.htm: Removed.
platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.png: Removed.
platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.txt: Removed.
platform/chromium-linux/fast/dom/HTMLTableElement/colSpan-expected.png:
platform/chromium-linux/fast/dom/HTMLTableElement/createCaption-expected.png:
platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:
platform/chromium-win/fast/dom/HTMLTableElement/colSpan-expected.txt:
platform/chromium-win/fast/dom/HTMLTableElement/createCaption-expected.txt:
platform/mac/fast/repaint/table-section-repaint-expected.txt:

12:25 PM Changeset in webkit [100489] by robert@webkit.org

4 edits in trunk/Source/WebCore

Unreviewed, rolling out r100479.
http://trac.webkit.org/changeset/100479
https://bugs.webkit.org/show_bug.cgi?id=72533

"Broke the Mac Build" (Requested by mwenge2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-16

WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
rendering/RenderingAllInOne.cpp:

12:17 PM Changeset in webkit [100488] by Chris Fleizach

47 edits
17 adds in trunk

WebKitTestRunner needs to support accessibility-related DRT APIs
https://bugs.webkit.org/show_bug.cgi?id=42131

Tools:

Reviewed by Beth Dakin.

Port the AX code in DRT to WKTestRunner by using IDL.

DumpRenderTree/AccessibilityUIElement.cpp:

(horizontalScrollbarCallback):
(verticalScrollbarCallback):
(AccessibilityUIElement::horizontalScrollbar):
(AccessibilityUIElement::verticalScrollbar):
(AccessibilityUIElement::getJSClass):

DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::horizontalScrollbar):
(AccessibilityUIElement::verticalScrollbar):

WebKitTestRunner/DerivedSources.make:
WebKitTestRunner/GNUmakefile.am:
WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.

(WTR::AccessibilityController::create):
(WTR::AccessibilityController::AccessibilityController):
(WTR::AccessibilityController::~AccessibilityController):
(WTR::AccessibilityController::makeWindowObject):
(WTR::AccessibilityController::wrapperClass):
(WTR::AccessibilityController::rootElement):
(WTR::AccessibilityController::focusedElement):
(WTR::AccessibilityController::elementAtPoint):

WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.

(WTR::AccessibilityController::logFocusEvents):
(WTR::AccessibilityController::logValueChangeEvents):
(WTR::AccessibilityController::logScrollingStartEvents):
(WTR::AccessibilityController::logAccessibilityEvents):
(WTR::AccessibilityController::addNotificationListener):
(WTR::AccessibilityController::notificationReceived):
(WTR::AccessibilityController::resetToConsistentState):

WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.

(WTR::AccessibilityTextMarker::create):
(WTR::AccessibilityTextMarker::AccessibilityTextMarker):
(WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
(WTR::AccessibilityTextMarker::platformTextMarker):
(WTR::AccessibilityTextMarker::wrapperClass):

WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.

(WTR::AccessibilityTextMarker::isEqual):

WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.

(WTR::AccessibilityTextMarkerRange::create):
(WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
(WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
(WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
(WTR::AccessibilityTextMarkerRange::wrapperClass):

WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.

(WTR::AccessibilityTextMarkerRange::isEqual):

WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.

(WTR::AccessibilityUIElement::create):
(WTR::AccessibilityUIElement::wrapperClass):
(WTR::AccessibilityUIElement::isValid):
(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::~AccessibilityUIElement):
(WTR::AccessibilityUIElement::isEqual):
(WTR::AccessibilityUIElement::elementAtPoint):
(WTR::AccessibilityUIElement::childAtIndex):
(WTR::AccessibilityUIElement::indexOfChild):
(WTR::AccessibilityUIElement::childrenCount):
(WTR::AccessibilityUIElement::titleUIElement):
(WTR::AccessibilityUIElement::parentElement):
(WTR::AccessibilityUIElement::takeFocus):
(WTR::AccessibilityUIElement::takeSelection):
(WTR::AccessibilityUIElement::addSelection):
(WTR::AccessibilityUIElement::removeSelection):
(WTR::AccessibilityUIElement::allAttributes):
(WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
(WTR::AccessibilityUIElement::linkedUIElementAtIndex):
(WTR::AccessibilityUIElement::attributesOfDocumentLinks):
(WTR::AccessibilityUIElement::attributesOfChildren):
(WTR::AccessibilityUIElement::parameterizedAttributeNames):
(WTR::AccessibilityUIElement::increment):
(WTR::AccessibilityUIElement::decrement):
(WTR::AccessibilityUIElement::showMenu):
(WTR::AccessibilityUIElement::press):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::uiElementAttributeValue):
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::boolAttributeValue):
(WTR::AccessibilityUIElement::isAttributeSupported):
(WTR::AccessibilityUIElement::isAttributeSettable):
(WTR::AccessibilityUIElement::isActionSupported):
(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::subrole):
(WTR::AccessibilityUIElement::roleDescription):
(WTR::AccessibilityUIElement::title):
(WTR::AccessibilityUIElement::description):
(WTR::AccessibilityUIElement::language):
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::accessibilityValue):
(WTR::AccessibilityUIElement::helpText):
(WTR::AccessibilityUIElement::orientation):
(WTR::AccessibilityUIElement::x):
(WTR::AccessibilityUIElement::y):
(WTR::AccessibilityUIElement::width):
(WTR::AccessibilityUIElement::height):
(WTR::AccessibilityUIElement::intValue):
(WTR::AccessibilityUIElement::minValue):
(WTR::AccessibilityUIElement::maxValue):
(WTR::AccessibilityUIElement::valueDescription):
(WTR::AccessibilityUIElement::insertionPointLineNumber):
(WTR::AccessibilityUIElement::selectedTextRange):
(WTR::AccessibilityUIElement::isEnabled):
(WTR::AccessibilityUIElement::isRequired):
(WTR::AccessibilityUIElement::isFocused):
(WTR::AccessibilityUIElement::isFocusable):
(WTR::AccessibilityUIElement::isSelected):
(WTR::AccessibilityUIElement::isSelectable):
(WTR::AccessibilityUIElement::isMultiSelectable):
(WTR::AccessibilityUIElement::setSelectedChild):
(WTR::AccessibilityUIElement::selectedChildrenCount):
(WTR::AccessibilityUIElement::selectedChildAtIndex):
(WTR::AccessibilityUIElement::isExpanded):
(WTR::AccessibilityUIElement::isChecked):
(WTR::AccessibilityUIElement::isVisible):
(WTR::AccessibilityUIElement::isOffScreen):
(WTR::AccessibilityUIElement::isCollapsed):
(WTR::AccessibilityUIElement::isIgnored):
(WTR::AccessibilityUIElement::hasPopup):
(WTR::AccessibilityUIElement::hierarchicalLevel):
(WTR::AccessibilityUIElement::clickPointX):
(WTR::AccessibilityUIElement::clickPointY):
(WTR::AccessibilityUIElement::documentEncoding):
(WTR::AccessibilityUIElement::documentURI):
(WTR::AccessibilityUIElement::url):
(WTR::AccessibilityUIElement::speak):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfColumns):
(WTR::AccessibilityUIElement::attributesOfRows):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
(WTR::AccessibilityUIElement::attributesOfHeader):
(WTR::AccessibilityUIElement::indexInTable):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::rowCount):
(WTR::AccessibilityUIElement::columnCount):
(WTR::AccessibilityUIElement::selectedRowAtIndex):
(WTR::AccessibilityUIElement::disclosedByRow):
(WTR::AccessibilityUIElement::disclosedRowAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
(WTR::AccessibilityUIElement::ariaIsGrabbed):
(WTR::AccessibilityUIElement::ariaDropEffects):
(WTR::AccessibilityUIElement::lineForIndex):
(WTR::AccessibilityUIElement::rangeForLine):
(WTR::AccessibilityUIElement::boundsForRange):
(WTR::AccessibilityUIElement::setSelectedTextRange):
(WTR::AccessibilityUIElement::stringForRange):
(WTR::AccessibilityUIElement::attributedStringForRange):
(WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar):
(WTR::AccessibilityUIElement::verticalScrollbar):
(WTR::AccessibilityUIElement::addNotificationListener):
(WTR::AccessibilityUIElement::removeNotificationListener):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::textMarkerRangeLength):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
(WTR::AccessibilityUIElement::textMarkerForPoint):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::stringForTextMarkerRange):

WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.

(WTR::AccessibilityUIElement::platformUIElement):

WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::accessibilityController):

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didClearWindowForFrame):

WebKitTestRunner/InjectedBundle/LayoutTestController.h:
WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:

(WTR::LayoutTestController::platformName):

WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.

(WTR::AccessibilityTextMarker::isEqual):

WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.

(WTR::AccessibilityTextMarkerRange::isEqual):

WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.

(+[NSString stringWithJSStringRef:]):
(-[NSString createJSStringRef]):
(-[AccessibilityNotificationHandler initWithPlatformElement:]):
(-[AccessibilityNotificationHandler dealloc]):
(-[AccessibilityNotificationHandler _notificationReceived:]):
(-[AccessibilityNotificationHandler setCallback:]):
(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::~AccessibilityUIElement):
(WTR::AccessibilityUIElement::isEqual):
(WTR::descriptionOfValue):
(WTR::attributesOfElement):
(WTR::concatenateAttributeAndValue):
(WTR::convertNSArrayToVector):
(WTR::descriptionOfElements):
(WTR::AccessibilityUIElement::getLinkedUIElements):
(WTR::AccessibilityUIElement::getDocumentLinks):
(WTR::AccessibilityUIElement::getChildren):
(WTR::AccessibilityUIElement::getChildrenWithRange):
(WTR::AccessibilityUIElement::childrenCount):
(WTR::AccessibilityUIElement::elementAtPoint):
(WTR::AccessibilityUIElement::indexOfChild):
(WTR::AccessibilityUIElement::childAtIndex):
(WTR::AccessibilityUIElement::linkedUIElementAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
(WTR::AccessibilityUIElement::disclosedRowAtIndex):
(WTR::AccessibilityUIElement::selectedChildAtIndex):
(WTR::AccessibilityUIElement::selectedChildrenCount):
(WTR::AccessibilityUIElement::selectedRowAtIndex):
(WTR::AccessibilityUIElement::titleUIElement):
(WTR::AccessibilityUIElement::parentElement):
(WTR::AccessibilityUIElement::disclosedByRow):
(WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
(WTR::AccessibilityUIElement::attributesOfDocumentLinks):
(WTR::AccessibilityUIElement::attributesOfChildren):
(WTR::AccessibilityUIElement::allAttributes):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::uiElementAttributeValue):
(WTR::AccessibilityUIElement::boolAttributeValue):
(WTR::AccessibilityUIElement::isAttributeSettable):
(WTR::AccessibilityUIElement::isAttributeSupported):
(WTR::AccessibilityUIElement::parameterizedAttributeNames):
(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::subrole):
(WTR::AccessibilityUIElement::roleDescription):
(WTR::AccessibilityUIElement::title):
(WTR::AccessibilityUIElement::description):
(WTR::AccessibilityUIElement::orientation):
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::language):
(WTR::AccessibilityUIElement::helpText):
(WTR::AccessibilityUIElement::x):
(WTR::AccessibilityUIElement::y):
(WTR::AccessibilityUIElement::width):
(WTR::AccessibilityUIElement::height):
(WTR::AccessibilityUIElement::clickPointX):
(WTR::AccessibilityUIElement::clickPointY):
(WTR::AccessibilityUIElement::intValue):
(WTR::AccessibilityUIElement::minValue):
(WTR::AccessibilityUIElement::maxValue):
(WTR::AccessibilityUIElement::valueDescription):
(WTR::AccessibilityUIElement::insertionPointLineNumber):
(WTR::AccessibilityUIElement::isActionSupported):
(WTR::AccessibilityUIElement::isEnabled):
(WTR::AccessibilityUIElement::isRequired):
(WTR::AccessibilityUIElement::isFocused):
(WTR::AccessibilityUIElement::isSelected):
(WTR::AccessibilityUIElement::isExpanded):
(WTR::AccessibilityUIElement::isChecked):
(WTR::AccessibilityUIElement::hierarchicalLevel):
(WTR::AccessibilityUIElement::speak):
(WTR::AccessibilityUIElement::ariaIsGrabbed):
(WTR::AccessibilityUIElement::ariaDropEffects):
(WTR::AccessibilityUIElement::lineForIndex):
(WTR::AccessibilityUIElement::rangeForLine):
(WTR::AccessibilityUIElement::boundsForRange):
(WTR::AccessibilityUIElement::stringForRange):
(WTR::AccessibilityUIElement::attributedStringForRange):
(WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfColumns):
(WTR::AccessibilityUIElement::attributesOfRows):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
(WTR::AccessibilityUIElement::attributesOfHeader):
(WTR::AccessibilityUIElement::rowCount):
(WTR::AccessibilityUIElement::columnCount):
(WTR::AccessibilityUIElement::indexInTable):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar):
(WTR::AccessibilityUIElement::verticalScrollbar):
(WTR::AccessibilityUIElement::selectedTextRange):
(WTR::AccessibilityUIElement::setSelectedTextRange):
(WTR::AccessibilityUIElement::increment):
(WTR::AccessibilityUIElement::decrement):
(WTR::AccessibilityUIElement::showMenu):
(WTR::AccessibilityUIElement::press):
(WTR::AccessibilityUIElement::setSelectedChild):
(WTR::AccessibilityUIElement::accessibilityValue):
(WTR::AccessibilityUIElement::documentEncoding):
(WTR::AccessibilityUIElement::documentURI):
(WTR::AccessibilityUIElement::url):
(WTR::AccessibilityUIElement::addNotificationListener):
(WTR::AccessibilityUIElement::removeNotificationListener):
(WTR::AccessibilityUIElement::isFocusable):
(WTR::AccessibilityUIElement::isSelectable):
(WTR::AccessibilityUIElement::isMultiSelectable):
(WTR::AccessibilityUIElement::isVisible):
(WTR::AccessibilityUIElement::isOffScreen):
(WTR::AccessibilityUIElement::isCollapsed):
(WTR::AccessibilityUIElement::isIgnored):
(WTR::AccessibilityUIElement::hasPopup):
(WTR::AccessibilityUIElement::takeFocus):
(WTR::AccessibilityUIElement::takeSelection):
(WTR::AccessibilityUIElement::addSelection):
(WTR::AccessibilityUIElement::removeSelection):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::textMarkerRangeLength):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::stringForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerForPoint):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):

WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:

(WTR::LayoutTestController::platformName):

WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:

(WTR::LayoutTestController::platformName):

WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:

(WTR::LayoutTestController::platformName):

WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
WebKitTestRunner/win/InjectedBundle.vcproj:

LayoutTests:

Cleanup tests and skip lists so that accessibility tests can run
in WK2. This mostly involved handling returned elements that might be nil,
something that did not happen in DRT.

Reviewed by Beth Dakin.

accessibility/aria-labelledby-overrides-label-expected.txt:
accessibility/aria-labelledby-overrides-label.html:
accessibility/non-data-table-cell-title-ui-element.html:
accessibility/th-as-title-ui.html:

Make sure a nil titleUIElement is accounted for in these tests.

platform/gtk-wk2/Skipped:
platform/mac/accessibility/aria-expanded-notifications-expected.txt:
platform/mac/accessibility/aria-expanded-notifications.html:
platform/mac/accessibility/aria-invalid-expected.txt:
platform/mac/accessibility/aria-invalid.html:
platform/mac/accessibility/aria-liveregions-addedelement-expected.txt:
platform/mac/accessibility/aria-liveregions-addedelement.html:
platform/mac/accessibility/aria-liveregions-changedalt-expected.txt:
platform/mac/accessibility/aria-liveregions-changedalt.html:
platform/mac/accessibility/aria-liveregions-changedtext-expected.txt:
platform/mac/accessibility/aria-liveregions-changedtext.html:
platform/mac/accessibility/aria-liveregions-removedelement-expected.txt:
platform/mac/accessibility/aria-liveregions-removedelement.html:

All the preceeding layout tests use alert() to output the results of notifications. This
is causing re-ordering issues on WK2, so I've moved them all to output that notification
data to a separate element from "console".

platform/mac/accessibility/html-section-elements-expected.txt:
platform/mac/accessibility/html-section-elements.html:

Remove nil element access that is unnecessary.

platform/mac/accessibility/html-slider-indicator-expected.txt:
platform/mac/accessibility/html-slider-indicator.html:
platform/mac/accessibility/search-predicate.html:

Add an alt tag to <img> so that it always shows up in the AX tree.

platform/mac/accessibility/selection-value-changes-for-aria-textbox.html:
platform/mac/accessibility/textbox-role-reports-notifications-expected.txt:

Remove the notification listener properly (was causing flakiness).

platform/mac/accessibility/textbox-role-reports-notifications.html:
platform/mac/accessibility/update-children-when-aria-role-changes-expected.txt:
platform/mac/accessibility/update-children-when-aria-role-changes.html:

Account for when element's returned are nil.

platform/win-wk2/Skipped:

Skip all accessibility tests on win.

platform/wk2/Skipped:

Skip all accessibility tests on gtk.

12:14 PM Changeset in webkit [100487] by Chris Fleizach

6 edits in trunk/Source

WebKitTestRunner needs to support accessibility-related DRT APIs
https://bugs.webkit.org/show_bug.cgi?id=42131

../WebCore:

Minor changes needed to support AX testing in WKTestRunner.

Reviewed by Beth Dakin.

WebCore.exp.in:

Expose focusedUIElementForPage so that the WK2 injected bundle can retrieve it.

accessibility/mac/WebAccessibilityObjectWrapper.mm:

(accessibilitySearchKeyForString):

Remove an unncessary assert that was causing issues with the WK2 test run.

../WebKit2:

Allow the injected bundle to retrieve the focused and root accessibility
objects.

Reviewed by Beth Dakin.

WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKAccessibilityRootObject):
(WKAccessibilityFocusedObject):

WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

12:12 PM Changeset in webkit [100486] by sergio@webkit.org

4 edits in trunk

[Soup] Somet tests fail with FAIL Unexpected response data received: Wrong method: GET
https://bugs.webkit.org/show_bug.cgi?id=69219

Reviewed by Martin Robinson.

Source/WebCore:

Do not stop appending data to the request body if any of the blob
items to upload is not accesible.

platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::addEncodedBlobToSoupMessageBody):

LayoutTests:

Unskipped a test that now pass.

platform/gtk/Skipped: unskipped http/tests/local/blob/send-hybrid-blob.html

11:59 AM Changeset in webkit [100485] by steveblock@google.com

2 edits in trunk/LayoutTests

fast/frames/sandboxed-iframe-navigation-targetlink.html crashes occasionally on Chromium Mac dbg
https://bugs.webkit.org/show_bug.cgi?id=72530

Unreviewed gardening

platform/chromium/test_expectations.txt:

11:58 AM Changeset in webkit [100484] by Lucas Forschler

3 edits in branches/safari-534.53-branch/Source/WebCore

Merged r93043.

11:53 AM Changeset in webkit [100483] by Beth Dakin

9 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=72400
Scrollbar uiStateTransitionProgress requires tracking the mouse all the time
-and corresponding-
<rdar://problem/10409328>

Reviewed by Darin Adler.

Source/WebCore:

This patch makes it so we track the mouse all the time when we have legacy
scrollbars (rather than only tracking the mouse when the window is key). When
we're in that mode, we want to do as little work as possible when handling the
mouseMoved event so that this extra tracking has little to no performance impact.
Also, we don't want to change basic behaviors by having normal web content hover
effects start happening when a window is in the background. So this patch also
introduces a way to handle a mouseMoved event that will only affect scrollbars.

EventHandler::mouseMoved() and EventHandler::handleMouseEvent() both now take a
boolean parameter that indicates if we are only updating scrollbars. If that is
the case, then we make our HitTestRequest ReadOnly, and we return early once
updateLastScrollbarUnderMouse() is called.

WebCore.exp.in:
page/EventHandler.cpp:

(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::handleMouseMoveEvent):

In addition to calling Scrollbar::mouseExited() when appropriate, this function
now calls a new function, Scrollbar::mouseEntered() when appropriate.
(WebCore::EventHandler::updateLastScrollbarUnderMouse):

page/EventHandler.h:

Scrollbar::mouseMoved() used to be responsible for calling
ScrollAnimator::mouseEnteredScrollbar(), but now Scrollbar::mouseEntered() takes
care of that instead, much like how Scrollbar::mouseExited() takes care of calling
the animator's exit function.

platform/Scrollbar.cpp:

(WebCore::Scrollbar::mouseMoved):
(WebCore::Scrollbar::mouseEntered):

platform/Scrollbar.h:

Source/WebKit2:

Set up our initial tracking area based on the currently recommended scrollbar
style. Track the mouse all the time if the style is legacy.

UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]):

Now that we might be getting mouseMoved events all the time even when the window
is not key, make sure we opt into the new 'onlyUpdateScrollbars' mode for
EventHandler::mouseMoved() when the window is not focused.

WebProcess/WebPage/WebPage.cpp:

(WebKit::handleMouseEvent):
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::mouseEventSyncForTesting):

11:47 AM Changeset in webkit [100482] by Lucas Forschler

86 edits in branches/safari-534.53-branch/Source

Merge 93040.

11:42 AM Changeset in webkit [100481] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

CSSValue: isInheritedValue() doesn't need a dedicated bit.
<http://webkit.org/b/72514>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-16
Reviewed by Antti Koivisto.

Remove CSSValue::m_isInherited and have isInheritedValue() check the
class type instead. There's no compelling reason for CSSInheritedValue
to have a dedicated bit, since nobody subclasses it anyway.

css/CSSValue.h:

(WebCore::CSSValue::isInheritedValue):
(WebCore::CSSValue::CSSValue):

11:42 AM Changeset in webkit [100480] by Lucas Forschler

15 edits in branches/safari-534.53-branch/Source

Merge 91161.

11:39 AM Changeset in webkit [100479] by robert@webkit.org

4 edits in trunk/Source/WebCore

Fix build on Windows and Mac after r100473

Unreviewed, fix build.

WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
rendering/RenderingAllInOne.cpp:

11:34 AM Changeset in webkit [100478] by abarth@webkit.org

3 edits in trunk/LayoutTests

Unskip these tests now that they should pass again.

platform/gtk/Skipped:
platform/qt/Skipped:

11:31 AM Changeset in webkit [100477] by Lucas Forschler

3 edits in branches/safari-534.53-branch/Source/WebCore

Merge 89441.

11:29 AM Changeset in webkit [100476] by abarth@webkit.org

3 edits in trunk/LayoutTests

Update test results after tightening up SecurityOrigin logic in
http://trac.webkit.org/changeset/100182. These new results are (minor)
progressions on these tests.

http/tests/security/cross-frame-access-enumeration-expected.txt:
http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:

11:16 AM Changeset in webkit [100475] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Remove extra GraphicsContextStateSaver restore() call.
https://bugs.webkit.org/show_bug.cgi?id=72497

Patch by Philip Rogers <pdr@google.com> on 2011-11-16
Reviewed by Andreas Kling.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

11:13 AM Changeset in webkit [100474] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/chromium

[chromium] Add minimum/maximumPageScaleFactor API and clamp fixes
https://bugs.webkit.org/show_bug.cgi?id=72463

Patch by Alexandre Elias <aelias@google.com> on 2011-11-16
Reviewed by Darin Fisher.

We need a way to read back the computed min/max page scale factor in
order to support the software path, and for some application logic
such as zooming in/out when tapping form fields.

I also added a few clamp calls that are needed in some corner cases.

public/WebView.h:
src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::setPageScaleFactorLimits):
(WebKit::WebViewImpl::minimumPageScaleFactor):
(WebKit::WebViewImpl::maximumPageScaleFactor):

src/WebViewImpl.h:

11:11 AM Changeset in webkit [100473] by robert@webkit.org

17 edits
5 adds in trunk

CSS 2.1 failure: border-collapse-offset-002.htm fails
https://bugs.webkit.org/show_bug.cgi?id=71705

Source/WebCore:

Table captions are implemented as children of the table but have a special
requirement to expand to the full width of the table rather than just the 'available'
width, i.e. the full width minus padding and borders.

To accomodate this create a RenderTableCaption object that reimplements containingBlockLogicalWidthForContent()
to return the full width of the containing block (i.e. the table) rather than the available width.

Reviewed by Antti Koivisto.

CMakeLists.txt: Add RenderTableCaption.[cpp|h]
GNUmakefile.list.am: Add RenderTableCaption.[cpp|h]
Target.pri: Add RenderTableCaption.[cpp|h]
WebCore.gypi: Add RenderTableCaption.[cpp|h]
rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): Use RenderTableCaption

rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject): Add RenderTableCaption.[cpp|h]
(WebCore::RenderObject::addChild): ditto

rendering/RenderObject.h:

(WebCore::RenderObject::isTableCaption):

rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):

rendering/RenderTable.h:
rendering/RenderTableCaption.cpp: Added.

(WebCore::RenderTableCaption::RenderTableCaption): Implement RenderTableCaption
(WebCore::RenderTableCaption::~RenderTableCaption):
(WebCore::RenderTableCaption::containingBlockLogicalWidthForContent): Return the containing block's full width rather than it's available width.

rendering/RenderTableCaption.h: Added.

(WebCore::RenderTableCaption::isTableCaption):
(WebCore::toRenderTableCaption):

LayoutTests:

Table captions now use the width of the table rather than the width of the table minus
the borders. This allows captions to center accurately but unfortunately a lot of mozilla
table tests need to be rebaselined as many of them use captions for explaining the purpose
of individual test files!

Add border-collapse-offset-002.htm which now renders correctly.

Affected tables/mozilla tests are rebaselined in a follow-up patch.

Reviewed by Antti Koivisto.

css2.1/20110323/border-collapse-offset-002.htm: Added.
platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
platform/chromium-linux/fast/dom/HTMLTableElement/colSpan-expected.png:
platform/chromium-linux/fast/dom/HTMLTableElement/createCaption-expected.png:
platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:
platform/chromium-win/fast/dom/HTMLTableElement/colSpan-expected.txt:
platform/chromium-win/fast/dom/HTMLTableElement/createCaption-expected.txt:
platform/mac/fast/repaint/table-section-repaint-expected.txt:

11:03 AM Changeset in webkit [100472] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/efl

[EFL] Add ewk_settings_memory_cache_clear().
https://bugs.webkit.org/show_bug.cgi?id=72141

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-16
Reviewed by Kenneth Rohde Christiansen.

This is the same as Qt's QWebSettings::clearMemoryCaches() and is
responsible for clearing, among others, the page, memory and font
caches.

ewk/ewk_settings.cpp:

(ewk_settings_memory_cache_clear):

ewk/ewk_settings.h:

11:03 AM Changeset in webkit [100471] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

ScriptController::executeIfJavaScriptURL gets confused by synchronous frame loads
https://bugs.webkit.org/show_bug.cgi?id=69777

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-11-16
Reviewed by Adam Barth.

http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url-expected.txt: Added.
http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url.html: Added.

10:56 AM Changeset in webkit [100470] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[Gtk] display:none has no effect on <option> element.
https://bugs.webkit.org/show_bug.cgi?id=72370

Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2011-11-16
Reviewed by Martin Robinson.

platform/gtk/GtkPopupMenu.cpp:

(WebCore::GtkPopupMenu::appendItem):

platform/gtk/PopupMenuGtk.cpp:

(WebCore::PopupMenuGtk::createGtkActionForMenuItem):

10:44 AM Changeset in webkit [100469] by commit-queue@webkit.org

5 edits in trunk

String new RegExp('\n').toString() returns is invalid RegularExpressionLiteral
https://bugs.webkit.org/show_bug.cgi?id=71572

Patch by Yusuke Suzuki <Yusuke Suzuki> on 2011-11-16
Reviewed by Gavin Barraclough and Darin Adler.

Source/JavaScriptCore:

runtime/RegExpObject.cpp:

(JSC::regExpObjectSource):

LayoutTests:

fast/regex/script-tests/toString.js:

(testLineTerminator):

fast/regex/toString-expected.txt:

10:32 AM Changeset in webkit [100468] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[GTK][WEBKIT2] Link error running gtkdoc-scangobj
https://bugs.webkit.org/show_bug.cgi?id=72365

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-11-16
Reviewed by Xan Lopez.

webkit2gtk.pc.in: Add a libjavascriptcore requirement to the WebKit2 pkgconfig

file so that the compiler links to it.

10:30 AM Changeset in webkit [100467] by Lucas Forschler

5 edits in branches/safari-534.54-branch/Source

Versioning.

10:20 AM Changeset in webkit [100466] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[GTK] Fix platformDefersLoading to handle non-http requests, and
to not use broken-ish libsoup APIs.
https://bugs.webkit.org/show_bug.cgi?id=72227

Patch by Dan Winship <danw@gnome.org> on 2011-11-16
Reviewed by Martin Robinson.

platform/network/ResourceHandleInternal.h:
platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback):
(WebCore::startHTTPRequest):
(WebCore::hasBeenSent):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::readCallback): rather than deferring by using
soup_session_pause_message(), let the read complete, but just don't
process the result until we're no longer deferred.
(WebCore::startNonHTTPRequest): Don't start the request if
it's deferred.

10:16 AM Changeset in webkit [100465] by commit-queue@webkit.org

14 edits
22 deletes in trunk/LayoutTests

Recent svg/foreignObject tests failing on Mac & Win
https://bugs.webkit.org/show_bug.cgi?id=72386

Patch by Florin Malita <fmalita@google.com> on 2011-11-16
Reviewed by Simon Fraser.

Drop unnecessary text elements from the svg/FO tests to avoid platform font size variance.

platform/chromium-cg-mac-snowleopard/svg/foreignObject/clip-expected.png: Removed.
platform/chromium-cg-mac-snowleopard/svg/foreignObject/filter-expected.png: Removed.
platform/chromium-cg-mac-snowleopard/svg/foreignObject/mask-expected.png: Removed.
platform/chromium-win/svg/foreignObject/background-render-phase-expected.txt: Removed.
platform/chromium-win/svg/foreignObject/clip-expected.txt: Removed.
platform/chromium-win/svg/foreignObject/filter-expected.txt: Removed.
platform/chromium-win/svg/foreignObject/mask-expected.txt: Removed.
platform/chromium/svg/foreignObject/background-render-phase-expected.txt: Removed.
platform/chromium/svg/foreignObject/clip-expected.txt: Removed.
platform/chromium/svg/foreignObject/filter-expected.txt: Removed.
platform/chromium/svg/foreignObject/mask-expected.txt: Removed.
platform/mac-snowleopard/svg/foreignObject/multiple-foreign-objects-expected.txt: Removed.
platform/qt/svg/foreignObject/background-render-phase-expected.png: Removed.
platform/qt/svg/foreignObject/background-render-phase-expected.txt: Removed.
platform/qt/svg/foreignObject/clip-expected.png: Removed.
platform/qt/svg/foreignObject/clip-expected.txt: Removed.
platform/qt/svg/foreignObject/filter-expected.png: Removed.
platform/qt/svg/foreignObject/filter-expected.txt: Removed.
platform/qt/svg/foreignObject/mask-expected.png: Removed.
platform/qt/svg/foreignObject/mask-expected.txt: Removed.
platform/qt/svg/foreignObject/multiple-foreign-objects-expected.png: Removed.
platform/qt/svg/foreignObject/multiple-foreign-objects-expected.txt: Removed.
svg/foreignObject/background-render-phase-expected.txt:
svg/foreignObject/background-render-phase.html:
svg/foreignObject/clip-expected.png:
svg/foreignObject/clip-expected.txt:
svg/foreignObject/clip.html:
svg/foreignObject/filter-expected.png:
svg/foreignObject/filter-expected.txt:
svg/foreignObject/filter.html:
svg/foreignObject/mask-expected.png:
svg/foreignObject/mask-expected.txt:
svg/foreignObject/mask.html:
svg/foreignObject/multiple-foreign-objects-expected.txt:
svg/foreignObject/multiple-foreign-objects.html:

10:05 AM Changeset in webkit [100464] by kbalazs@webkit.org

2 edits in trunk/Source/WebKit2

[WK2][X11] Don't leak the colormap we created for the plugin
https://bugs.webkit.org/show_bug.cgi?id=72144

Reviewed by Xan Lopez.

WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformDestroy):

9:33 AM Changeset in webkit [100463] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/efl

[EFL] Clean up the web database-related functions in ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72139

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-16
Reviewed by Kenneth Rohde Christiansen.

Mostly remove some unnecessary ENABLE(SQL_DATABASE) checks and use a
more standard naming scheme for the related static variables.

ewk/ewk_settings.cpp:

(ewk_settings_web_database_default_quota_get):
(ewk_settings_web_database_path_set):
(ewk_settings_web_database_path_get):

ewk/ewk_settings.h: Document the default web database path on disk.

9:29 AM Changeset in webkit [100462] by Darin Adler

2 edits in trunk/Source/JavaScriptCore

Specialize HashTraits for OwnPtr to use PassOwnPtr and raw pointer
https://bugs.webkit.org/show_bug.cgi?id=72475

Reviewed by Adam Roben.

wtf/HashTraits.h: Specialize HashTraits for OwnPtr.

Do overloads so we can pass a nullptr and also be sure to get the
raw pointer type from the OwnPtr template so we handle both forms
of OwnPtr: OwnPtr<T> and OwnPtr<T*>.

9:27 AM Changeset in webkit [100461] by vestbo@webkit.org

3 edits in trunk/Tools

[Qt] Fix use of config.tests

We were checking @buildArgs to determine if the optional argument was
passed or not, but this is not the right way to do that in Perl. The
right way is to not use a prototype for the function, and to pass
the list as a reference (to avoid list expansion). That way we can
check the number of arguments, and choose the right code path based
on that.

We were also missing a default-value of 0 for any feature that's not
set in features.prf.

Reviewed by Kenneth Rohde Christiansen.

Scripts/build-webkit:
Scripts/webkitdirs.pm:

(qtFeatureDefaults):
(buildQMakeProject):

9:20 AM Changeset in webkit [100460] by vestbo@webkit.org

2 edits in trunk/Tools

[Qt] Prospective fix for broken plugin tests

Don't hide symbols for the NPAPI test plugin

Rubber-stamped by Andreas Kling.

DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

8:57 AM Changeset in webkit [100459] by jesus@webkit.org

2 edits in trunk/Source/WebKit/qt

Unreviewed, rolling out r100448.
http://trac.webkit.org/changeset/100448
https://bugs.webkit.org/show_bug.cgi?id=72512

It caused a regression breaking LayoutTests/http/tests/loading
/text-content-type-with-binary-extension.html (Requested by
jeez_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-16

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::canShowMIMEType):

8:55 AM Changeset in webkit [100458] by steveblock@google.com

2 edits in trunk/LayoutTests

Web Inspector: Application cache status should be updated after swapCache().
https://bugs.webkit.org/show_bug.cgi?id=72123

Patch by Vsevolod Vlasov <vsevik@chromium.org> on 2011-11-16
Reviewed by Pavel Feldman.

http/tests/inspector/appcache/appcache-iframe-manifests-expected.txt: Added.
http/tests/inspector/appcache/appcache-iframe-manifests.html: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-iframe-manifests.html.
http/tests/inspector/appcache/appcache-manifest-with-non-existing-file-expected.txt: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt.
http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file.html.
http/tests/inspector/appcache/appcache-swap-expected.txt: Added.
http/tests/inspector/appcache/appcache-swap.html: Added.
http/tests/inspector/appcache/appcache-test.js: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-test.js.

(createAndNavigateIFrame):
(removeIFrame):
(navigateIFrame):
(swapFrameCache):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame.frameDetached):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame):
(initialize_ApplicationCacheTest.InspectorTest.swapFrameCache):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCache):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheTree):
(initialize_ApplicationCacheTest.InspectorTest.frameIdToString):
(initialize_ApplicationCacheTest.InspectorTest.applicationCacheStatusToString):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel):
(initialize_ApplicationCacheTest.InspectorTest.waitForFrameManifestURLAndStatus):
(initialize_ApplicationCacheTest.InspectorTest.startApplicationCacheStatusesRecording):
(initialize_ApplicationCacheTest.InspectorTest.ensureFrameStatusEventsReceived):
(initialize_ApplicationCacheTest):

http/tests/inspector/appcache/resources/manifest.php: Renamed from LayoutTests/http/tests/inspector/resource-tree/resources/manifest.php.
http/tests/inspector/appcache/resources/page-with-manifest.php: Renamed from LayoutTests/http/tests/inspector/resource-tree/resources/page-with-manifest.php.
http/tests/inspector/appcache/resources/versioned-manifest.php: Added.
http/tests/inspector/appcache/resources/with-versioned-manifest.php: Added.
http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Removed.
platform/chromium/http/tests/inspector/appcache/appcache-manifest-with-non-existing-file-expected.txt: Added.
platform/chromium/http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Removed.
platform/chromium/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt: Removed.

8:50 AM Changeset in webkit [100457] by Adam Roben

3 edits in trunk/Tools

Move filenames/line numbers off to the right edge in Leaks Viewer

Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
because filenames/line numbers are right next to function names

Reviewed by Andreas Kling.

BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:

(LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
function name. Use the filename as the profile node's URL (we don't have enough info to
compute a real URL currently) and the line number as the profile node's line number so the
Inspector code will put them on the right side of the callstack graph.

BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:

(WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
passed here, just filenames.

(WebInspector.linkifyURLAsNode):
(WebInspector.linkifyResourceAsNode):
Copied and slightly modified from inspector.js.

8:50 AM Changeset in webkit [100456] by Adam Roben

2 edits in trunk/Tools

Make Leaks Viewer load builds from the new Lion Leaks bot

Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds

Reviewed by Andreas Kling.

BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:

(LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
SnowLeopard one.

8:37 AM Changeset in webkit [100455] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[Qt] [WK2] Crash in Connection::readyReadHandler() on socket error
https://bugs.webkit.org/show_bug.cgi?id=72392

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-11-16
Reviewed by Simon Hausmann.

Add QWeakPointer to SocketNotifierResourceGuard::m_socketNotifier to track
deallocation of referenced object.

Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::SocketNotifierResourceGuard::SocketNotifierResourceGuard):
(CoreIPC::SocketNotifierResourceGuard::~SocketNotifierResourceGuard):

8:09 AM Changeset in webkit [100454] by vsevik@chromium.org

7 edits
6 moves
9 adds
3 deletes in trunk

Web Inspector: Application cache status should be updated after swapCache().
https://bugs.webkit.org/show_bug.cgi?id=72123

Reviewed by Pavel Feldman.

Source/WebCore:

Application cache view resources and status are now updated after swapCache() call.
Refresh button removed from application cache view.
Application cache inspector tests are moved to their own folder.

Tests: http/tests/inspector/appcache/appcache-iframe-manifests.html

http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html
http/tests/inspector/appcache/appcache-swap.html

inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype.get statusBarItems):
(WebInspector.ApplicationCacheItemsView.prototype.wasShown):
(WebInspector.ApplicationCacheItemsView.prototype._maybeUpdate):
(WebInspector.ApplicationCacheItemsView.prototype._markDirty):
(WebInspector.ApplicationCacheItemsView.prototype.updateStatus):
(WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
(WebInspector.ApplicationCacheItemsView.prototype._deleteCallback):

loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::setNewestCache):
(WebCore::ApplicationCacheGroup::makeObsolete):
(WebCore::ApplicationCacheGroup::setUpdateStatus):

loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::notifyDOMApplicationCache):
(WebCore::ApplicationCacheHost::swapCache):

Source/WebKit/chromium:

src/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::swapCache):

LayoutTests:

http/tests/inspector/appcache/appcache-iframe-manifests-expected.txt: Added.
http/tests/inspector/appcache/appcache-iframe-manifests.html: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-iframe-manifests.html.
http/tests/inspector/appcache/appcache-manifest-with-non-existing-file-expected.txt: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt.
http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file.html.
http/tests/inspector/appcache/appcache-swap-expected.txt: Added.
http/tests/inspector/appcache/appcache-swap.html: Added.
http/tests/inspector/appcache/appcache-test.js: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-test.js.

http/tests/inspector/appcache/resources/manifest.php: Renamed from LayoutTests/http/tests/inspector/resource-tree/resources/manifest.php.
http/tests/inspector/appcache/resources/page-with-manifest.php: Renamed from LayoutTests/http/tests/inspector/resource-tree/resources/page-with-manifest.php.
http/tests/inspector/appcache/resources/versioned-manifest.php: Added.
http/tests/inspector/appcache/resources/with-versioned-manifest.php: Added.
http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Removed.
platform/chromium/http/tests/inspector/appcache/appcache-manifest-with-non-existing-file-expected.txt: Added.
platform/chromium/http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Removed.
platform/chromium/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt: Removed.

8:05 AM Changeset in webkit [100453] by eric.carlson@apple.com

9 edits
4 adds in trunk

addTrack() must throw an exception if 'kind' is unknown
https://bugs.webkit.org/show_bug.cgi?id=71915

Reviewed by Philippe Normand.

Source/WebCore:

Tests: media/track/track-addtrack-kind.html

media/track/track-kind.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTrackKindChanged): New. Will be implemented for 62885.
(WebCore::HTMLMediaElement::addTrack): Throw if 'kind' is not a known value.
(WebCore::HTMLMediaElement::addTextTrack): Call textTracks(), it will allocate the track

list object if necessary.

(WebCore::HTMLMediaElement::textTracks): Never return NULL, a TextTrackList with no tracks

is allowed.

html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::addTrack): Add variants to deal with optional parameters plus

a mandatory ExceptionCode parameter.

html/HTMLMediaElement.idl: addTrack can generate an exception.

html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::attributeChanged): kind, label, and srclang attribute changes should

percolate down the the TextTrack.

(WebCore::HTMLTrackElement::kind): Return the TextTrack kind because it is not necessarily the

same as the attribute value.

(WebCore::HTMLTrackElement::ensureTrack): Only pass legal 'kind' keywords to create a TextTrack.
(WebCore::HTMLTrackElement::textTrackKindChanged): Notify parent element, if any.

html/HTMLTrackElement.h:

html/TextTrack.cpp:

(WebCore::TextTrack::subtitlesKeyword): New, return legal kind attribute value.
(WebCore::TextTrack::captionsKeyword): Ditto.
(WebCore::TextTrack::descriptionsKeyword): Ditto.
(WebCore::TextTrack::chaptersKeyword): Ditto.
(WebCore::TextTrack::metadataKeyword): Ditto.
(WebCore::TextTrack::TextTrack): Call setKind to make sure m_kind is always set to legal value.
(WebCore::TextTrack::isValidKindKeyword): New, validate 'kind' value.
(WebCore::TextTrack::setKind): Only allow legal values.

html/TextTrack.h:

(WebCore::TextTrack::kind):
(WebCore::TextTrack::label):
(WebCore::TextTrack::setLabel):
(WebCore::TextTrack::language):
(WebCore::TextTrack::setLanguage):
(WebCore::TextTrack::readyState):
(WebCore::TextTrack::mode):

LayoutTests:

media/track/track-addtrack-kind-expected.txt: Added.
media/track/track-addtrack-kind.html: Added.
media/track/track-kind-expected.txt: Added.
media/track/track-kind.html: Added.

8:01 AM QtWebKitLayoutInteraction edited by kenneth@webkit.org

(diff)

7:58 AM Changeset in webkit [100452] by commit-queue@webkit.org

8 edits in trunk

[EFL] Clean up the offline apps-related functions in ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72132

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-16
Reviewed by Kenneth Rohde Christiansen.

ewk_settings_cache' and ewk_view_setting_cache' are too common
prefixes for code that is related only to the HTML5 app cache
features.

Use `ewk_settings_application_cache' and
`ewk_view_setting_application_cache' instead.

Source/WebKit/efl:

While here, improve the documentation and use a more common naming
scheme for the static variable which holds the cache path.

ewk/ewk_main.cpp:

(_ewk_init_body):

ewk/ewk_settings.cpp:

(ewk_settings_application_cache_path_set):
(ewk_settings_application_cache_path_get):

ewk/ewk_settings.h:
ewk/ewk_view.cpp:

(ewk_view_setting_application_cache_get):
(ewk_view_setting_application_cache_set):

ewk/ewk_view.h:

Tools:

DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

7:57 AM Changeset in webkit [100451] by apavlov@chromium.org

3 edits in trunk/LayoutTests

Unreviewed, test fix after http://trac.webkit.org/changeset/100273.

"font" property is no longer mapped to DOMCSSValue, so use "font-family" mapped to DOMCSSValueList instead.

platform/mac/plugins/jsobjc-dom-wrappers-expected.txt:
platform/mac/plugins/jsobjc-dom-wrappers.html:

7:52 AM Changeset in webkit [100450] by kbalazs@webkit.org

2 edits in trunk/LayoutTests

[Qt] inspector/elements/elements-panel-selection-on-refresh.html crashing
https://bugs.webkit.org/show_bug.cgi?id=72504

Unreviewed gardening. Skip crashing test.

platform/qt/Skipped:

7:49 AM Changeset in webkit [100449] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

CSSValue: Clean up initial value construction.
<http://webkit.org/b/72502>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-16
Reviewed by Antti Koivisto.

Instead of determining whether a given CSSInitialValue is 'implicit' or not by
querying the CSSValue::ClassType (InitialClass vs. ImplicitInitialClass),
add a protected CSSValue member and set it from the CSSInitialValue constructor.

Also get rid of the CSSValue::m_isInitial bit since we can now replace the
checks by classType() == InitialClass.

No new tests, this is a cleanup.

css/CSSInitialValue.h:

(WebCore::CSSInitialValue::CSSInitialValue):

Poke 'implicit' constructor argument into CSSValue::m_isImplicit.

css/CSSValue.cpp:

(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

Remove ImplicitInitialClass cases.

css/CSSValue.h:

(WebCore::CSSValue::isImplicitInitialValue):
(WebCore::CSSValue::isInitialValue):
(WebCore::CSSValue::CSSValue):

7:12 AM Changeset in webkit [100448] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/qt

[Qt] FrameLoaderClientQt::canShowMIMEType should always return true
https://bugs.webkit.org/show_bug.cgi?id=72169

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-11-16
Reviewed by Simon Hausmann.

Currently FrameLoaderClientQt::canShowMIMEType is called after
dispatchDecidePolicyForResponse. If decidePolicyForResponse returns
PolicyUse and canShowMIMEType returns false, then we have a bug.
Therefore, FrameLoaderClientQt::canShowMIMEType now will always
return true, following the implemenation of WebKit2.

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::canShowMIMEType):

7:07 AM Rebaseline edited by epoger@google.com

(diff)

7:05 AM Rebaseline edited by epoger@google.com

(diff)

7:04 AM Changeset in webkit [100447] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Remove unnecessary if check from RenderListBox::paintItemForeground.
https://bugs.webkit.org/show_bug.cgi?id=72488

Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2011-11-16
Reviewed by Andreas Kling.

rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintItemForeground):

7:04 AM Rebaseline edited by epoger@google.com

(diff)

7:00 AM Changeset in webkit [100446] by steveblock@google.com

2 edits in trunk/LayoutTests

Layout Test inspector/styles/svg-style.xhtml is flaky
https://bugs.webkit.org/show_bug.cgi?id=72434

Unreviewed gardening

platform/chromium/test_expectations.txt:

6:56 AM Changeset in webkit [100445] by zeno.albisser@nokia.com

2 edits in trunk/Source/WebKit2

[Qt][WK2][Mac] MiniBrowser cannot create socketpair.
https://bugs.webkit.org/show_bug.cgi?id=72389

Use SOCK_DGRAM on mac instead of SOCK_SEQPACKET.

Reviewed by Tor Arne Vestbø.

UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

6:54 AM Changeset in webkit [100444] by rgabor@webkit.org

2 edits in trunk/LayoutTests

[Qt] Skip new failing tests.

Unreviewed gardening.

platform/qt-mac/Skipped:

6:42 AM Changeset in webkit [100443] by rgabor@webkit.org

2 edits in trunk/LayoutTests

[Qt] new test inspector/extensions/extensions-sidebar.html crashing after r100433
https://bugs.webkit.org/show_bug.cgi?id=72493

[Qt] http/tests/misc/onload-remove-iframe-crash-2.html crashing after r100311
https://bugs.webkit.org/show_bug.cgi?id=72491

Unreviewed gardening.

platform/qt/Skipped:

6:28 AM Changeset in webkit [100442] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed, rolling out r100281 and r100437.
http://trac.webkit.org/changeset/100281
http://trac.webkit.org/changeset/100437
https://bugs.webkit.org/show_bug.cgi?id=72496

It made all plugin tests fail with paralel NRWT (Requested by
ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-16

platform/qt/Skipped:

6:20 AM Changeset in webkit [100441] by Simon Hausmann

9 edits in trunk

[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions

Reviewed by Tor Arne Vestbø.

Source/api.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Source/JavaScriptCore:

Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Source/WebCore:

Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Tools:

qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions

magic here where we handle all TEMPLATE = lib .pro files.

6:17 AM Changeset in webkit [100440] by vestbo@webkit.org

2 edits in trunk

Fix path to module file in root project file

Reviewed by Simon Hausmann.

WebKit.pro:

6:08 AM Changeset in webkit [100439] by caseq@chromium.org

4 edits in trunk/LayoutTests

Layout Test inspector/extensions/extensions-events.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72447

Reviewed by Yury Semikhatsky.

inspector/extensions/extensions-events-expected.txt:
inspector/extensions/extensions-events.html:
platform/chromium/test_expectations.txt:

6:04 AM Changeset in webkit [100438] by commit-queue@webkit.org

10 edits in trunk/Source

[chromium] Pass screen refresh rate into compositor.
https://bugs.webkit.org/show_bug.cgi?id=71040

Patch by Iain Merrick <husky@google.com> on 2011-11-16
Reviewed by Tony Gentilcore.

Source/WebCore:

platform/PlatformScreen.h:
platform/chromium/PlatformScreenChromium.cpp:

(WebCore::screenRefreshRate):

platform/chromium/PlatformSupport.h:
platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeImplOnImplThread):

Source/WebKit/chromium:

public/WebScreenInfo.h:

(WebKit::WebScreenInfo::WebScreenInfo):

src/PlatformSupport.cpp:

(WebCore::PlatformSupport::screenRefreshRate):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

6:03 AM Changeset in webkit [100437] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r100281.

platform/qt/Skipped: Skip http/tests/plugins/third-party-cookie-accept-policy.html

again, because it makes all plugin related tests fail intermittently.

5:51 AM Changeset in webkit [100436] by steveblock@google.com

2 edits in trunk/LayoutTests

LayoutTest fast/replaced/width100percent-textarea.html fails on Chromium Mac 10.6
https://bugs.webkit.org/show_bug.cgi?id=72494

Unreviewed gardening

platform/chromium/test_expectations.txt:

5:28 AM EFLWebKit edited by rakuco@FreeBSD.org

Update the port information (diff)

5:13 AM Changeset in webkit [100435] by steveblock@google.com

2 edits in trunk/LayoutTests

Layout Test inspector/extensions/extensions-events.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72447

Unreviewed gardening

platform/chromium/test_expectations.txt:

5:09 AM Changeset in webkit [100434] by rgabor@webkit.org

2 edits in trunk/LayoutTests

[Qt] new test css3/flexbox/line-wrapping.html failing
https://bugs.webkit.org/show_bug.cgi?id=72490

Unreviewed gardening.

platform/qt/Skipped:

4:56 AM Changeset in webkit [100433] by caseq@chromium.org

6 edits
2 moves
2 adds in trunk

Web Inspector: [Extensions API] drop ExtensionSidebarPane.onUpdated, use callbacks instead
https://bugs.webkit.org/show_bug.cgi?id=72388

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: inspector/extensions/extensions-panel.html

inspector/extensions/extensions-sidebar.html

fire ExtensionSidebarPane.on{Hidden,Shown} for non-iframe content (experssions/objects);
drop ExtensionsSidebarPane.onUpdated, provide callback for setObject()/setExpression() instead;
fix an exception when a page is replaced with object/expression.

inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.ExtensionSidebarPaneImpl):
(injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression):
(injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setObject):

inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionNotifierView):
(WebInspector.ExtensionNotifierView.prototype.wasShown):
(WebInspector.ExtensionNotifierView.prototype.willHide):
(WebInspector.ExtensionSidebarPane.prototype.setObject):
(WebInspector.ExtensionSidebarPane.prototype.setExpression):
(WebInspector.ExtensionSidebarPane.prototype.setPage):
(WebInspector.ExtensionSidebarPane.prototype._onEvaluate):
(WebInspector.ExtensionSidebarPane.prototype._makeObjectPropertiesView):
(WebInspector.ExtensionSidebarPane.prototype._setObject):

inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onSetSidebarContent.callback):
(WebInspector.ExtensionServer.prototype._onSetSidebarContent):
(WebInspector.ExtensionServer.prototype._dispatchCallback):

inspector/front-end/View.js:

(WebInspector.View.prototype.detach):

LayoutTests:

split LayoutTests/inspector/extensions.html into extensions-panel.html & extensions-sidebar.html.

inspector/extensions/extensions-panel-expected.txt: Added.
inspector/extensions/extensions-panel.html: Added.
inspector/extensions/extensions-sidebar-expected.txt: Renamed from LayoutTests/inspector/extensions/extensions-expected.txt.
inspector/extensions/extensions-sidebar.html: Renamed from LayoutTests/inspector/extensions/extensions.html.

4:52 AM Changeset in webkit [100432] by commit-queue@webkit.org

2 edits in trunk/Tools

Explicitly include unistd.h in TestNetscapePlugIn
https://bugs.webkit.org/show_bug.cgi?id=72385

This is needed for the sleep() call in the indicateTestFailure method,
which seems to be implicitly available for other platforms. This is not
the case on Android.

Patch by Peter Beverloo <peter@chromium.org> on 2011-11-16
Reviewed by Steve Block.

DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

4:48 AM Changeset in webkit [100431] by rgabor@webkit.org

2 edits
5 adds in trunk/LayoutTests

[Qt] Update Qt specific expected results.

Unreviewed gardening.

platform/qt/fast/loader/file-protocol-fragment-expected.png: Added.
platform/qt/fast/loader/file-protocol-fragment-expected.txt:
platform/qt/inspector: Added.
platform/qt/inspector/console: Added.
platform/qt/inspector/console/console-format-expected.png: Added.
platform/qt/inspector/console/console-format-expected.txt: Added.

4:33 AM Changeset in webkit [100430] by steveblock@google.com

2 edits in trunk/LayoutTests

Compositing LayoutTests failing on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=72487

Unreviewed gardening

platform/chromium/test_expectations.txt:

3:57 AM Changeset in webkit [100429] by steveblock@google.com

2 edits in trunk/LayoutTests

LayoutTest animations/animation-direction-normal.html fails on Chromium dbg bots
https://bugs.webkit.org/show_bug.cgi?id=72485

Unreviewed gardening

platform/chromium/test_expectations.txt:

3:49 AM Changeset in webkit [100428] by commit-queue@webkit.org

3 edits in trunk/Tools

[Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
https://bugs.webkit.org/show_bug.cgi?id=72384

Update to Android NDK r7, which was released last Friday. This adds
support for RTTI and the -mimplicit-it gcc flag, which are required to
respectively build ICU and Skia.

Patch by Peter Beverloo <peter@chromium.org> on 2011-11-16
Reviewed by Steve Block.

Scripts/update-webkit-chromium:
Scripts/webkitdirs.pm:

(buildChromiumMakefile):

2:56 AM Changeset in webkit [100427] by Simon Hausmann

8 edits in trunk

Unreviewed, rolling out r100266.
http://trac.webkit.org/changeset/100266

Broke WTR.

Source/api.pri:

Source/JavaScriptCore:

Target.pri:

Source/WebCore:

Target.pri:

Tools:

qmake/mkspecs/features/default_post.prf:

2:51 AM Changeset in webkit [100426] by rgabor@webkit.org

2 edits in trunk/LayoutTests

[Qt][ARMv5] Websocket tests are fail, skip until fix

Unreviewed, gardening.

platform/qt-arm/Skipped:

2:35 AM Changeset in webkit [100425] by commit-queue@webkit.org

6 edits in trunk

[GTK] fast/events/event-creation.html fails creating MediaStreamEvent
https://bugs.webkit.org/show_bug.cgi?id=70720

Patch by Per-Erik Brodin <per-erik.brodin@ericsson.com> on 2011-11-16
Reviewed by Philippe Normand.

Source/WebCore:

Added missing overriding of Event::interfaceName()

mediastream/MediaStreamEvent.cpp:

(WebCore::MediaStreamEvent::stream): Changed return value to raw pointer.
(WebCore::MediaStreamEvent::interfaceName): Added back from r98044.

mediastream/MediaStreamEvent.h:
mediastream/MediaStreamEvent.idl: Changed module name to "events".

LayoutTests:

platform/gtk/Skipped: Unskipped fast/events/event-creation.html

1:46 AM Changeset in webkit [100424] by mario@webkit.org

3 edits in trunk/Source/WebKit/gtk

[GTK] Do not hide accessibility root object from AT's
https://bugs.webkit.org/show_bug.cgi?id=72390

Reviewed by Martin Robinson.

tests/testatk.c:

(getWebAreaObject): New helper function, to bypass the new root
object in the accessibility hierarchy, since it's not usually
needed for the unit tests.
(testWebkitAtkCaretOffsets): Use getWebAreaObject().
(testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces): Ditto.
(testWebkitAtkComboBox): Ditto.
(testWebkitAtkEmbeddedObjects): Ditto.
(testWebkitAtkGetTextAtOffsetForms): Ditto.
(testWebkitAtkGetTextAtOffset): Ditto.
(testWebkitAtkGetTextAtOffsetNewlines): Ditto.
(testWebkitAtkGetTextAtOffsetTextarea): Ditto.
(testWebkitAtkGetTextAtOffsetTextInput): Ditto.
(testWebkitAtkGetTextAtOffsetWithSpecialCharacters): Ditto.
(testWebkitAtkGetTextInParagraphAndBodySimple): Ditto.
(testWebkitAtkGetTextInParagraphAndBodyModerate): Ditto.
(testWebkitAtkGetTextInTable): Ditto.
(testWebkitAtkGetHeadersInTable): Ditto.
(testWebkitAtkTextAttributes): Ditto.
(testWebkitAtkTextSelections): Ditto.
(testWebkitAtkGetExtents): Ditto.
(testWebkitAtkLayoutAndDataTables): Ditto.
(testWebkitAtkLinksWithInlineImages): Ditto.
(testWebkitAtkHypertextAndHyperlinks): Ditto.
(testWebkitAtkListsOfItems): Ditto.
(testWebkitAtkTextChangedNotifications): Ditto.
(testWebkitAtkParentForRootObject): New test, to make sure that
both top-down and bottom-up navigation among GTK and WebKit worlds
matches accordingly.
(main): Added new test.

webkit/webkitwebview.cpp:

(webkit_web_view_get_accessible): Remove the hack introduced
because of bug 51932, to bypass the root object here.

1:06 AM Changeset in webkit [100423] by eric@webkit.org

2 edits in trunk/Tools

check-webkit-style broken by r99773: "Could not determine the port"
https://bugs.webkit.org/show_bug.cgi?id=72275

Reviewed by Adam Barth.

I will continue engaging hacks, until windows improves.

Scripts/webkitpy/common/host.py:
- Host uses self.executive instead of self._executive like Port does.
- I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.

12:48 AM Changeset in webkit [100422] by jamesr@google.com

2 edits in trunk/LayoutTests

[chromium] Update chromium expectations for compositing tests

platform/chromium/test_expectations.txt:

12:41 AM Changeset in webkit [100421] by eric@webkit.org

3 edits in trunk/Tools

check-webkit-style broken by r99773: "Could not determine the port"
https://bugs.webkit.org/show_bug.cgi?id=72275

Reviewed by Adam Barth.

Engage windows hacks harder.

This is a speculative fix for ChromiumWin. We're now
creating an SCM object much earlier, so we need to
engage our "awesome" windows hacks earlier.

Scripts/webkitpy/common/host.py:
Scripts/webkitpy/layout_tests/port/chromium_win.py:

12:16 AM Changeset in webkit [100420] by jamesr@google.com

10 edits
5 moves
1 add
3 deletes in trunk/LayoutTests

[chromium] Update chromium win and linux compositing baselines
https://bugs.webkit.org/show_bug.cgi?id=72402

platform/chromium-cg-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/layers-inside-overflow-scroll-expected.png.
platform/chromium-linux/compositing/layers-inside-overflow-scroll-expected.png:
platform/chromium-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png:
platform/chromium-linux/compositing/self-painting-layers-expected.png:
platform/chromium-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png: Renamed from LayoutTests/platform/chromium-mac/compositing/layers-inside-overflow-scroll-expected.png.
platform/chromium-mac/compositing/overflow/overflow-compositing-descendant-expected.png: Removed.
platform/chromium-mac/compositing/overflow/scroll-ancestor-update-expected.png: Removed.
platform/chromium-mac/compositing/self-painting-layers-expected.png: Removed.
platform/chromium-win/compositing/layers-inside-overflow-scroll-expected.png:
platform/chromium-win/compositing/overflow/overflow-compositing-descendant-expected.png:
platform/chromium-win/compositing/overflow/scroll-ancestor-update-expected.png:
platform/chromium-win/compositing/self-painting-layers-expected.png:
platform/chromium/compositing/overflow/overflow-compositing-descendant-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/overflow/overflow-compositing-descendant-expected.png.
platform/chromium/compositing/overflow/scroll-ancestor-update-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/overflow/scroll-ancestor-update-expected.png.
platform/chromium/compositing/self-painting-layers-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/self-painting-layers-expected.png.
platform/chromium/test_expectations.txt:

12:16 AM Changeset in webkit [100419] by mario@webkit.org

2 edits in trunk/Source/WebCore

[GTK] Use GQuark's in the ATK wrapper to get and set arbitrary data
https://bugs.webkit.org/show_bug.cgi?id=72394

Reviewed by Martin Robinson.

No new functionality, no new tests needed.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(webkit_accessible_class_init): Initialize GQuarks.
(getGailTextUtilForAtk): Use gailTextUtilQuark.
(getPangoLayoutForAtk): Remove unused call to
g_object_set_data_full, since that data is no used anywhere.
(webkitAccessibleHyperlinkImplGetHyperlink): Use hyperlinkObjectQuark.

12:06 AM Changeset in webkit [100418] by Darin Adler

2 edits in trunk/Source/JavaScriptCore

Add a "pass type" and "peek type" concept to HashTraits
https://bugs.webkit.org/show_bug.cgi?id=72473

Reviewed by Filip Pizlo.

wtf/HashTraits.h: Added the pass type and peek type.

For OwnPtr, the pass type will be PassOwnPtr and the peek
type will be a raw pointer.

12:05 AM Changeset in webkit [100417] by Darin Adler

3 edits in trunk/Source/JavaScriptCore

Fix some hash traits that don't derive from the base hash traits
https://bugs.webkit.org/show_bug.cgi?id=72470

Reviewed by Filip Pizlo.

Hash traits structures need to derive from the base hash traits in
HashTraits.h, but some were not. This is needed for compatibility with
some additional traits we will be adding to make OwnPtr work with HashMap.

runtime/Identifier.h: Make IdentifierMapIndexHashTraits derive from

HashTraits<int>. This enabled removal of all the members except for the
ones that control the empty value, because this is otherwise the same
as the standard int hash.

Context Navigation

Timeline

Nov 17, 2011:

Nov 16, 2011:

Download in other formats: