Timeline
Nov 21, 2011:
- 7:38 PM Changeset in webkit [100978] by
-
- 8 edits in trunk
[GTK] Enable WebSocket hybi tests
https://bugs.webkit.org/show_bug.cgi?id=72870
Reviewed by Xan Lopez.
Source/WebKit/gtk:
Change the settings value through DumpRenderTreeSupportGtk, because we do not
want to expose this as a public API.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setHixie76WebSocketProtocolEnabled):
Change the value of a flag in WebCore::Settings.
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
Tools:
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
Reset the setting value to the default value (true).
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::overridePreference):
Change the setting value through a function in DumpRenderTreeSupportGtk.
LayoutTests:
- platform/gtk/Skipped:
Unskip WebSocket hybi tests. Skip two tests using FileSystem API, which is not yet
supported in GTK port.
- 7:19 PM Changeset in webkit [100977] by
-
- 5 edits5 deletes in trunk/Source/WebKit/chromium
Unreviewed, rolling out r100970.
http://trac.webkit.org/changeset/100970
https://bugs.webkit.org/show_bug.cgi?id=72925
Caused AssociatedURLLoaderTest.Success to fail (Requested by
koz on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-21
- WebKit.gyp:
- public/WebUserMediaClient.h: Removed.
- public/WebUserMediaRequest.h: Removed.
- public/WebViewClient.h:
- src/UserMediaClientImpl.cpp: Removed.
- src/UserMediaClientImpl.h: Removed.
- src/WebUserMediaRequest.cpp: Removed.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
- src/WebViewImpl.h:
- 7:15 PM Changeset in webkit [100976] by
-
- 3 edits3 adds in trunk
REGRESSION(r98542): Chromium: CSS text is rendered on page
https://bugs.webkit.org/show_bug.cgi?id=71703
Patch by David Barr <davidbarr@chromium.org> on 2011-11-21
Reviewed by Dimitri Glazkov.
Source/WebCore:
Matched UA declarations uncacheable when using simpleDefaultStyleSheet.
Test: fast/css/style-tag-display-none.html
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchUARules):
LayoutTests:
- fast/css/style-tag-display-none-expected.txt: Added.
- fast/css/style-tag-display-none.html: Added.
- fast/css/style-tag-display-none-expected.png: Added.
- 7:02 PM Changeset in webkit [100975] by
-
- 11 edits in trunk
DFG should have richer debug output for CFA and phi processing
https://bugs.webkit.org/show_bug.cgi?id=72922
Reviewed by Gavin Barraclough.
In the default verbose mode, we now print information about variable
state at the bottom of basic blocks in addition to the top, and we
also print local variable linking. In the verbose propagation mode,
the state of phi processing is dumped more richly and CFA merging (the
most subtle part of CFA) is traced as well.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::mergeStateAtTail):
- dfg/DFGAbstractValue.h:
(JSC::DFG::StructureAbstractValue::dump):
(JSC::DFG::AbstractValue::dump):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGCommon.h:
(JSC::DFG::NodeIndexTraits::dump):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGNode.h:
(JSC::DFG::Node::dumpChildren):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOperands.h:
(JSC::DFG::OperandValueTraits::dump):
(JSC::DFG::dumpOperands):
- 6:59 PM Changeset in webkit [100974] by
-
- 4 edits4 adds in trunk
If an event listener is a function, it should be called and not checked for handleEvent.
This also covers callbacks, which follow the same spec but are implemented separately.
https://bugs.webkit.org/show_bug.cgi?id=62518
Patch by Rob Brackett <rob@robbrackett.com> on 2011-11-21
Reviewed by Sam Weinig.
Source/WebCore:
Tests: fast/events/dispatch-to-function-with-handle-event.html
fast/js/callback-function-with-handle-event.html
- bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
LayoutTests:
- fast/events/dispatch-to-function-with-handle-event-expected.txt: Added.
- fast/events/dispatch-to-function-with-handle-event.html: Added.
- fast/js/callback-function-with-handle-event-expected.txt: Added.
- fast/js/callback-function-with-handle-event.html: Added.
- 6:56 PM Changeset in webkit [100973] by
-
- 1 edit3 adds in trunk/LayoutTests
Should have a test for corner cases of DFG's integer optimization and CSE.
https://bugs.webkit.org/show_bug.cgi?id=72917
Reviewed by Sam Weinig.
- fast/js/dfg-integer-optimization-expected.txt: Added.
- fast/js/dfg-integer-optimization.html: Added.
- fast/js/script-tests/dfg-integer-optimization.js: Added.
(doAdd):
- 6:15 PM Changeset in webkit [100972] by
-
- 2 edits in trunk/Source/JavaScriptCore
Showing the data overlay in OpenStreetMap doesn't work, zooming partially broken
https://bugs.webkit.org/show_bug.cgi?id=71505
Reviewed by Gavin Barraclough.
It turns out that we were corrupting phi nodes in case of overflow. The bug is
really obvious, but producing a test case that causes the badness is hard. Even
when the phi nodes do get corrupt, there's more that has to happen before it
causes incorrect execution - and I wasn't able to reproduce in any kind of
sensible reduced case.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::processPhiStack):
- 5:27 PM Changeset in webkit [100971] by
-
- 4 edits in branches/subpixellayout/Source/WebCore/rendering
Adding pixel snapped methods for clientWidth/Height and moving internal callers to LayoutUnit versions.
- 5:20 PM Changeset in webkit [100970] by
-
- 5 edits5 adds in trunk/Source/WebKit/chromium
[chromium] MediaStream API: Adding embedding code for GetUserMedia
https://bugs.webkit.org/show_bug.cgi?id=71678
Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-21
Reviewed by Darin Fisher.
- WebKit.gyp:
- public/WebUserMediaClient.h: Added.
(WebKit::WebUserMediaClient::~WebUserMediaClient):
- public/WebUserMediaRequest.h: Added.
(WebKit::WebUserMediaRequest::WebUserMediaRequest):
(WebKit::WebUserMediaRequest::~WebUserMediaRequest):
(WebKit::WebUserMediaRequest::operator=):
(WebKit::WebUserMediaRequest::isNull):
(WebKit::operator==):
- public/WebViewClient.h:
(WebKit::WebViewClient::userMediaClient):
- src/UserMediaClientImpl.cpp: Added.
(WebKit::UserMediaClientImpl::UserMediaClientImpl):
(WebKit::UserMediaClientImpl::pageDestroyed):
(WebKit::UserMediaClientImpl::requestUserMedia):
(WebKit::UserMediaClientImpl::cancelUserMediaRequest):
- src/UserMediaClientImpl.h: Added.
- src/WebUserMediaRequest.cpp: Added.
(WebKit::WebUserMediaRequest::WebUserMediaRequest):
(WebKit::WebUserMediaRequest::reset):
(WebKit::WebUserMediaRequest::audio):
(WebKit::WebUserMediaRequest::video):
(WebKit::WebUserMediaRequest::cameraPreferenceUser):
(WebKit::WebUserMediaRequest::cameraPreferenceEnvironment):
(WebKit::WebUserMediaRequest::securityOrigin):
(WebKit::WebUserMediaRequest::requestSucceeded):
(WebKit::WebUserMediaRequest::requestFailed):
(WebKit::WebUserMediaRequest::equals):
(WebKit::WebUserMediaRequest::assign):
(WebKit::WebUserMediaRequest::operator PassRefPtr<UserMediaRequest>):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
- src/WebViewImpl.h:
- 5:01 PM Changeset in webkit [100969] by
-
- 1 edit6 adds in trunk/LayoutTests
cr-linux rebaselines for r100949. Unreviewed gardening.
- platform/chromium-linux/css2.1/20110323/empty-inline-001-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/empty-inline-002-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/empty-inline-003-expected.png: Added.
- platform/chromium-linux/fast/css/empty-inline-003-quirksmode-expected.png: Added.
- platform/chromium-linux/fast/css/empty-inline-line-height-first-line-expected.png: Added.
- platform/chromium-linux/fast/css/empty-inline-line-height-first-line-quirksmode-expected.png: Added.
- 4:25 PM Changeset in webkit [100968] by
-
- 2 edits in trunk/LayoutTests
Rebaseline after r100958. Unreviewed gardening.
- platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png:
- 3:31 PM Changeset in webkit [100967] by
-
- 3 edits1 add3 deletes in trunk/LayoutTests
[chromium] Layout Test compositing/geometry/clipped-video-controller.html is flaky on Win/Linux
https://bugs.webkit.org/show_bug.cgi?id=72903
Reviewed by James Robinson.
Make this test dumpAsText(true) since what we really care about here is
pixel output.
- compositing/geometry/clipped-video-controller-expected.txt: Added.
- compositing/geometry/clipped-video-controller.html:
- platform/chromium-win/compositing/geometry/clipped-video-controller-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/efl/compositing/geometry/clipped-video-controller-expected.txt: Removed.
- platform/mac/compositing/geometry/clipped-video-controller-expected.txt: Removed.
- 3:27 PM Changeset in webkit [100966] by
-
- 2 edits in trunk/LayoutTests
Optimistically remove expectations for a handful of no-longer-failing tests.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 3:13 PM Changeset in webkit [100965] by
-
- 10 edits8 adds in trunk
Need support for dirname attribute
https://bugs.webkit.org/show_bug.cgi?id=65542
Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-11-21
Reviewed by Eric Seidel.
Implemented 'dirname' form attribute.
Source/WebCore:
Tests: fast/forms/form-dirname-attribute.html
fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html
fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html
fast/forms/submit-form-with-dirname-attribute.html
- html/HTMLAttributeNames.in:
Added "dirname" attribute.
- html/HTMLInputElement.idl:
Add "dirName" property to HTMLInputElement interface.
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::appendFormData):
Append dirname form data.
- html/HTMLTextAreaElement.idl:
Add "dirName" property to HTMLTextAreaElement interface.
- html/HTMLTextFormControlElement.cpp:
(WebCore::parentHTMLElement):
Helper function which returns only HTML parent element.
(WebCore::HTMLTextFormControlElement::directionForFormData):
Helper function for finding directionality of the Element.
- html/HTMLTextFormControlElement.h:
Helper function for finding directionality of the Element.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::appendFormData):
Append dirname form data.
- html/TextFieldInputType.h:
Append dirname form data.
LayoutTests:
- fast/forms/form-dirname-attribute-expected.txt: Added.
- fast/forms/form-dirname-attribute.html: Added.
- fast/forms/submit-form-with-dirname-attribute-expected.txt: Added.
- fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute-expected.txt: Added.
- fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html: Added.
- fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor-expected.txt: Added.
- fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html: Added.
- fast/forms/submit-form-with-dirname-attribute.html: Added.
- 3:11 PM Changeset in webkit [100964] by
-
- 27 edits in branches/subpixellayout/Source
Chromium/linux and qt platform fixes
- 3:09 PM Changeset in webkit [100963] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Fix tiler initialization in TiledLayerChromiumTest
https://bugs.webkit.org/show_bug.cgi?id=72915
Reviewed by Kenneth Russell.
Setting the tile size or tiling option after the tiler is created invalidates it, and by default the newly
created tiler will have border texels so the test doesn't pass. Switch things around in the test so the tiler
is created only after all the options are set, which is closer to what the real code does.
- tests/TiledLayerChromiumTest.cpp:
(WTF::FakeTiledLayerChromium::FakeTiledLayerChromium):
- 3:06 PM Changeset in webkit [100962] by
-
- 7 edits3 copies15 adds in trunk/LayoutTests
Chromium rebaselines after r100949. Unreviewed.
- platform/chromium-cg-mac-leopard/css2.1/20110323/empty-inline-001-expected.png: Added.
- platform/chromium-cg-mac-leopard/css2.1/20110323/empty-inline-002-expected.png: Added.
- platform/chromium-cg-mac-leopard/css2.1/20110323/empty-inline-003-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/empty-inline-001-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/empty-inline-002-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/empty-inline-003-expected.png: Added.
- platform/chromium-win/css2.1/20110323/empty-inline-001-expected.png: Added.
- platform/chromium-win/css2.1/20110323/empty-inline-001-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/empty-inline-001-expected.txt.
- platform/chromium-win/css2.1/20110323/empty-inline-002-expected.png: Added.
- platform/chromium-win/css2.1/20110323/empty-inline-002-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/empty-inline-002-expected.txt.
- platform/chromium-win/css2.1/20110323/empty-inline-003-expected.png: Added.
- platform/chromium-win/css2.1/20110323/empty-inline-003-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/empty-inline-003-expected.txt.
- platform/chromium-win/fast/css/empty-inline-003-quirksmode-expected.png: Added.
- platform/chromium-win/fast/css/empty-inline-line-height-first-line-expected.png: Added.
- platform/chromium-win/fast/css/empty-inline-line-height-first-line-quirksmode-expected.png: Added.
- platform/chromium/css2.1/20110323/empty-inline-001-expected.png:
- platform/chromium/css2.1/20110323/empty-inline-001-expected.txt:
- platform/chromium/css2.1/20110323/empty-inline-002-expected.png:
- platform/chromium/css2.1/20110323/empty-inline-002-expected.txt:
- platform/chromium/css2.1/20110323/empty-inline-003-expected.png:
- platform/chromium/css2.1/20110323/empty-inline-003-expected.txt:
- platform/chromium/fast/css/empty-inline-003-quirksmode-expected.png: Added.
- platform/chromium/fast/css/empty-inline-line-height-first-line-expected.png: Added.
- platform/chromium/fast/css/empty-inline-line-height-first-line-quirksmode-expected.png: Added.
- 3:01 PM Changeset in webkit [100961] by
-
- 4 edits in trunk/Tools
ChangeLogEntry should be able to parse entries with multiple authors
https://bugs.webkit.org/show_bug.cgi?id=72690
Reviewed by Eric Seidel.
Support multi-author change log entries in ChangeLogEntry. Split author names using
the same logic as splitting reviewer names. _authors now stores list of dictionaries
with "name" and "email" as keys. Unlike reviewers, we can't always resolve authors to
accounts because some contributors are never listed in committers.py.
- Scripts/webkitpy/common/checkout/changelog.py:
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
- Scripts/webkitpy/common/config/committers.py: Fixed a bug that *_by_{name|email}
throws an exception when the argument is None.
- 3:00 PM Changeset in webkit [100960] by
-
- 2 edits in trunk/Source/WebKit/chromium
Fix chromium compile bustage - base interface added a parameter so my fake wasn't actually implementing it.
- tests/TiledLayerChromiumTest.cpp:
(WTF::FakeLayerTextureUpdater::prepareToUpdate):
- 2:34 PM Changeset in webkit [100959] by
-
- 17 edits in trunk/Source/WebCore
IndexedDB: Close database connections, abort transactions, and terminate requests on stop()
https://bugs.webkit.org/show_bug.cgi?id=72066
Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-21
Reviewed by Tony Chang.
No new tests; addresses race conditions on document navigate/script context stop.
- dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::enqueueEvent):
- dom/DocumentEventQueue.h:
- dom/EventQueue.h:
- storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::~IDBDatabase):
(WebCore::IDBDatabase::transaction):
(WebCore::IDBDatabase::close):
(WebCore::IDBDatabase::onVersionChange):
(WebCore::IDBDatabase::enqueueEvent):
(WebCore::IDBDatabase::stop):
- storage/IDBDatabase.h:
- storage/IDBFactory.cpp:
(WebCore::IDBFactory::IDBFactory):
(WebCore::IDBFactory::getDatabaseNames):
(WebCore::IDBFactory::open):
(WebCore::IDBFactory::deleteDatabase):
- storage/IDBFactory.h:
- storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::IDBObjectStore):
(WebCore::IDBObjectStore::name):
(WebCore::IDBObjectStore::keyPath):
(WebCore::IDBObjectStore::indexNames):
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):
(WebCore::IDBObjectStore::openCursor):
- storage/IDBObjectStore.h:
- storage/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):
(WebCore::IDBRequest::stop):
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::enqueueEvent):
- storage/IDBRequest.h:
- storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::abort):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
(WebCore::IDBTransaction::dispatchEvent):
(WebCore::IDBTransaction::stop):
(WebCore::IDBTransaction::enqueueEvent):
- storage/IDBTransaction.h:
- storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::commit):
- workers/WorkerEventQueue.cpp:
(WebCore::WorkerEventQueue::enqueueEvent):
- workers/WorkerEventQueue.h:
- 2:22 PM Changeset in webkit [100958] by
-
- 7 edits1 add in trunk/Source
[chromium] Avoid pushing dirty tiles to the impl layer
https://bugs.webkit.org/show_bug.cgi?id=72765
Reviewed by Kenneth Russell.
Source/WebCore:
If a tile has invalidations at pushPropertiesTo, then we know the contents of that tile are no longer valid even
if they still have valid backing textures. This avoids pushing that texture to the impl side so it is not
displayed to the user. The texture is still kept around (managed by the TextureManager) so that when we later do
decide to update the contents for that tile we can use partial results if they are still valid.
Covered by new unit test in TiledLayerChromiumTest.cpp
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::isDirty):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
(WebCore::TiledLayerChromium::setTileSize):
(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::createTiler):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::pushPropertiesTo):
- platform/graphics/chromium/TiledLayerChromium.h:
(WebCore::TiledLayerChromium::setTextureFormat):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::hasTileAt):
(WebCore::CCTiledLayerImpl::drawTiles):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
Source/WebKit/chromium:
Add unit test for TiledLayerChromium's tile pushing behavior. Requires a fair amount of fake classes. If these
fakes are useful in other tests, they should be moved to a shared location.
- WebKit.gypi:
- tests/TiledLayerChromiumTest.cpp: Added.
(::FakeTextureAllocator::createTexture):
(::FakeTextureAllocator::deleteTexture):
(::FakeLayerTextureUpdater::FakeLayerTextureUpdater):
(::FakeLayerTextureUpdater::~FakeLayerTextureUpdater):
(::FakeLayerTextureUpdater::orientation):
(::FakeLayerTextureUpdater::sampledTexelFormat):
(::FakeLayerTextureUpdater::prepareToUpdate):
(::FakeLayerTextureUpdater::updateTextureRect):
(::FakeCCTiledLayerImpl::FakeCCTiledLayerImpl):
(::FakeCCTiledLayerImpl::~FakeCCTiledLayerImpl):
(::FakeCCTiledLayerImpl::hasTileAt):
(::FakeTiledLayerChromium::FakeTiledLayerChromium):
(::FakeTiledLayerChromium::~FakeTiledLayerChromium):
(::FakeTiledLayerChromium::invalidateRect):
(::FakeTiledLayerChromium::prepareToUpdate):
(::FakeTiledLayerChromium::textureManager):
(::FakeTiledLayerChromium::createTextureUpdater):
(::FakeTiledLayerChromium::textureUpdater):
(::TEST):
- 2:10 PM Changeset in webkit [100957] by
-
- 1 edit12 adds in trunk/LayoutTests
Platform-specific results for r100949
Unreviewed gardening.
- platform/gtk/css2.1/20110323/empty-inline-001-expected.txt: Added.
- platform/gtk/css2.1/20110323/empty-inline-002-expected.txt: Added.
- platform/gtk/css2.1/20110323/empty-inline-003-expected.txt: Added.
- platform/gtk/fast/css/empty-inline-003-quirksmode-expected.txt: Added.
- platform/gtk/fast/css/empty-inline-line-height-first-line-expected.txt: Added.
- platform/gtk/fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt: Added.
- platform/qt/css2.1/20110323/empty-inline-001-expected.txt: Added.
- platform/qt/css2.1/20110323/empty-inline-002-expected.txt: Added.
- platform/qt/css2.1/20110323/empty-inline-003-expected.txt: Added.
- platform/qt/fast/css/empty-inline-003-quirksmode-expected.txt: Added.
- platform/qt/fast/css/empty-inline-line-height-first-line-expected.txt: Added.
- platform/qt/fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt: Added.
- 1:58 PM Changeset in webkit [100956] by
-
- 2 edits in trunk/Source/WebKit/mac
Fix the SnowLeopard build.
- Misc/WebNSFileManagerExtras.mm: Forward-declare DADiskCreateFromVolumePath on SnowLeopard as it was
not yet declared in a public header.
- 1:45 PM Changeset in webkit [100955] by
-
- 6 edits in trunk/Source/WebKit2
[Qt][WK2] REGRESSION(100483): It made 2 API tests fail
https://bugs.webkit.org/show_bug.cgi?id=72612
Reviewed by Kenneth Rohde Christiansen.
Make sure that when the view is focused, the page knows about it.
Also set a the view to be the focused item in the failing tests.
- UIProcess/API/qt/qquickwebpage_p.h:
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::isViewFocused):
- 1:40 PM Changeset in webkit [100954] by
-
- 4 edits in trunk/Source/WebKit
<http://webkit.org/b/72661> Switch to a more modern approach to retrieving the startup volume name
Use the DiskArbitration framework to retrieve the name of the startup volume rather than using Carbon
File Manager APIs.
Reviewed by Dan Bernstein.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj: Link against DiskArbitration.framework. It lives in the shared cache
so it should add only negligible launch time overhead.
Source/WebKit/mac:
- Misc/WebNSFileManagerExtras.mm:
(-[NSFileManager _webkit_startupVolumeName]): Retrieve a DADiskRef for the startup volume and copy
the volume name from its description dictionary.
- 1:32 PM Changeset in webkit [100953] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, remove expectations for no-longer-flakey media tests.
- platform/chromium/test_expectations.txt:
- 1:19 PM Changeset in webkit [100952] by
-
- 12 edits1 add in trunk
[Qt] Speed up debug builds.
https://bugs.webkit.org/show_bug.cgi?id=72882
Reviewed by Tor Arne Vestbø.
Source/JavaScriptCore:
- Target.pri: Make BUILDING_JavaScriptCore available earlier, so it can be
used by the build system.
Source/WebCore:
- Target.pri: Make BUILDING_WebCore available earlier, so it can be
used by the build system.
Source/WebKit2:
- Target.pri: Make BUILDING_WebKit2 available, so it can be
used by the build system.
Tools:
Introduce a special type of build that replaces the static jsc/wc/wk2
static libraries with shared libraries, that individually are much faster
to link and don't require relinking into the big library when changing just
one file in one module. It can be enabled with
--qmakearg="CONFIG+=force_static_libs_as_shared"
- qmake/mkspecs/features/force_static_libs_as_shared.prf: Added. With this configuration,
disable symbol visibility, static linkage and enable rpath.
- qmake/mkspecs/features/functions.prf: Add a helper function to determine if
we need to link the convenience libraries together or not and renamed linkStaticLibrary
to just linkLibrary (because linkage is not necessarily static).
- qmake/mkspecs/features/qtwebkit.prf: When using the trick, make sure to also
link against jsc/wc/wk2 when linking app code against QtWebKit.
- qmake/mkspecs/features/javascriptcore.prf: Use new +needToLinkLibrary helper
function.
- qmake/mkspecs/features/webcore.prf: Ditto.
- qmake/mkspecs/features/webkit2.prf: Ditto.
- 1:15 PM Changeset in webkit [100951] by
-
- 2 edits in trunk/Tools
Update flakiness dashboard linkification regexps for crbug.com/100000 and above
https://bugs.webkit.org/show_bug.cgi?id=72898
Reviewed by Ojan Vafai.
Also removed a comment that was going to be more trouble to keep up to
date than seemed worthwhile (the code is now the documentation).
- TestResultServer/static-dashboards/flakiness_dashboard.html:
- 1:06 PM Changeset in webkit [100950] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Remove unnecessary initialize method from QQuickWebView.
https://bugs.webkit.org/show_bug.cgi?id=72905
Reviewed by Kenneth Rohde Christiansen.
We don't need this level of indirection.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebView::QQuickWebView):
- UIProcess/API/qt/qquickwebview_p_p.h:
- 1:06 PM Changeset in webkit [100949] by
-
- 3 edits18 adds in trunk
CSS 2.1 failure: empty-inline-003.htm fails
https://bugs.webkit.org/show_bug.cgi?id=72638
Reviewed by Ryosuke Niwa.
Source/WebCore:
Empty inline elements need to share their inline height with siblings.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineFlowRequiresLineBox): In strict mode, add a LineBox for an empty element if it is
going to affect the line-height.
(WebCore::requiresLineBox): Pass LineInfo to inlineFlowRequiresLineBox
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Pass LineInfo to inlineFlowRequiresLineBox
LayoutTests:
- css2.1/20110323/empty-inline-001.htm: Added.
- css2.1/20110323/empty-inline-002.htm: Added.
- css2.1/20110323/empty-inline-003.htm: Added.
- fast/css/empty-inline-003-quirksmode-expected.png: Result can cover all platforms as there is no text apart from the period.
- fast/css/empty-inline-003-quirksmode-expected.txt: ditto
- fast/css/empty-inline-003-quirksmode.htm: empty-inline-003.htm should only pass in strict mode, this ensures it 'fails' in quirks mode.
- fast/css/empty-inline-line-height-first-line-expected.png: Added.
- fast/css/empty-inline-line-height-first-line-expected.txt: Added.
- fast/css/empty-inline-line-height-first-line-quirksmode-expected.png: Added.
- fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt: Result can cover all platforms as there is no text apart from the period.
- fast/css/empty-inline-line-height-first-line-quirksmode.htm: Like empty-inline-003.htm, empty-inline-line-height-first-line.htm should also fail in quirks mode.
- fast/css/empty-inline-line-height-first-line.htm: Like empty-inline-003.htm but ensures first-line style is respected for line-height in empty elements.
- platform/chromium/css2.1/20110323/empty-inline-001-expected.png: Added.
- platform/chromium/css2.1/20110323/empty-inline-001-expected.txt: Added.
- platform/chromium/css2.1/20110323/empty-inline-002-expected.png: Added.
- platform/chromium/css2.1/20110323/empty-inline-002-expected.txt: Added.
- platform/chromium/css2.1/20110323/empty-inline-003-expected.png: Added.
- platform/chromium/css2.1/20110323/empty-inline-003-expected.txt: Added.
- 1:04 PM Changeset in webkit [100948] by
-
- 6 edits in trunk
[Chromium] WebAccessibilityNotification should use AssertMatchingEnums.
https://bugs.webkit.org/show_bug.cgi?id=72895
Reviewed by Chris Fleizach.
Source/WebKit/chromium:
- public/WebAccessibilityNotification.h:
- src/AssertMatchingEnums.cpp:
- src/ChromeClientImpl.cpp:
(WebKit::toWebAccessibilityNotification):
Tools:
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::postAccessibilityNotification):
- 1:01 PM Changeset in webkit [100947] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Remove incorrect render surface layer list asserts from compositor
https://bugs.webkit.org/show_bug.cgi?id=72744
Reviewed by James Robinson.
These asserts are incorrect, because it's valid for the default render
surface to be created but to have a root layer that doesn't draw. It
won't get added to the single render surface and it'll have an empty
layer list.
Test: compositor_unittests
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):
- 12:40 PM Changeset in webkit [100946] by
-
- 3 edits in trunk/Source/WebKit/wince
Unreviewed WinCE build fix after r100874.
- WebCoreSupport/EditorClientWinCE.h:
- WebCoreSupport/EditorClientWinCE.cpp:
(WebKit::EditorClientWinCE::respondToChangedSelection):
Add WebCore::Frame* parameter to respondToChangedSelection().
- 12:36 PM Changeset in webkit [100945] by
-
- 1 edit1 move1 add in trunk/LayoutTests
Rebaseline font-face-opentype.html on cr-mac-leopard.
Unreviewed gardening.
- platform/chromium-mac-leopard/fast/css/font-face-opentype-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/font-face-opentype-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/css/font-face-opentype-expected.png.
- 12:34 PM Changeset in webkit [100944] by
-
- 4 edits7 adds in trunk/LayoutTests
Unreviewed gardening.
Updated baselines for two SVG tests. These tests have been passing for a while, but the expectations were either stale or completely wrong.
- platform/chromium-cg-mac-leopard/svg/custom/use-elementInstance-event-target-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-02-b-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/svg/custom/use-elementInstance-event-target-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-02-b-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/use-elementInstance-event-target-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-02-b-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/use-elementInstance-event-target-expected.png: Added.
- platform/chromium-win/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
- platform/chromium/test_expectations.txt:
- 12:24 PM Changeset in webkit [100943] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, broaden expecations for inspector test.
- platform/chromium/test_expectations.txt:
- 12:05 PM Changeset in webkit [100942] by
-
- 2 edits in trunk/LayoutTests
Layout Test http/tests/media/video-served-as-text.html is flaky on cr-win
https://bugs.webkit.org/show_bug.cgi?id=72904
Unreviewed gardening, marking test as PASS TEXT.
- platform/chromium/test_expectations.txt:
- 11:38 AM Changeset in webkit [100941] by
-
- 2 edits in trunk/LayoutTests
[chromium] Layout Test compositing/geometry/clipped-video-controller.html is flaky on Win/Linux
https://bugs.webkit.org/show_bug.cgi?id=72903
Unreviewed gardening.
- platform/chromium/test_expectations.txt: Mark as PASS TEXT
- 11:22 AM Changeset in webkit [100940] by
-
- 2 edits in trunk
Add GYP-generated WTF.xcodeproj to .gitignore after r100851.
- .gitignore:
- 11:16 AM Changeset in webkit [100939] by
-
- 2 edits in trunk/LayoutTests
Layout Test perf/array-push-pop.html is slow
https://bugs.webkit.org/show_bug.cgi?id=72901
Mark test as SLOW PASS.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 11:09 AM Changeset in webkit [100938] by
-
- 2 edits in trunk/Tools
Unreviewed, run-gtk-tests temporary workaround after r98500.
- Scripts/run-gtk-tests: Try to find the build directory like in
build-gtkdoc, until webkit-build-directory --configuration gets fixed.
- 11:02 AM Changeset in webkit [100937] by
-
- 2 edits in trunk/LayoutTests
Inspector tests flakily crashing on Linux dbg canary
https://bugs.webkit.org/show_bug.cgi?id=72651
Add TIMEOUT expectation for
inspector/styles/styles-disable-then-change.html.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 10:59 AM Changeset in webkit [100936] by
-
- 5 edits in trunk/LayoutTests
Use canplay instead of canplaythrough in http/tests/media to prevent timeout
https://bugs.webkit.org/show_bug.cgi?id=72758
Reviewed by Eric Carlson.
- http/tests/media/video-cookie-expected.txt:
- http/tests/media/video-cookie.html:
- http/tests/media/video-referer-expected.txt:
- http/tests/media/video-referer.html:
- 10:46 AM Changeset in webkit [100935] by
-
- 5 edits in trunk/Source/WebCore
StyleSheet: Move completeURL() to CSSStyleSheet.
<http://webkit.org/b/72888>
Patch by Andreas Kling <kling@webkit.org> on 2011-11-21
Reviewed by Antti Koivisto.
Since completeURL() is only used on CSSStyleSheets, move it there (and make
it non-virtual) to make StyleSheet a little leaner.
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::completeURL):
- css/CSSStyleSheet.h:
- css/StyleSheet.cpp:
- css/StyleSheet.h:
- 10:40 AM Changeset in webkit [100934] by
-
- 2 edits in trunk/Source/WebCore
[wx] Fix image translation calculations.
https://bugs.webkit.org/show_bug.cgi?id=72892
Reviewed by Kevin Ollivier.
- 10:35 AM Changeset in webkit [100933] by
-
- 3 edits in trunk/Source/WebKit/wx
Add wxWebKit APIs for controlling WebKit caching behavior.
https://bugs.webkit.org/show_bug.cgi?id=72891
Reviewed by Kevin Ollivier.
- 10:31 AM Changeset in webkit [100932] by
-
- 6 edits in trunk/Source/WebKit/wx
Add wxWebKit API for retrieving frame and page URLs.
https://bugs.webkit.org/show_bug.cgi?id=72890
Reviewed by Kevin Ollivier.
- 10:17 AM Changeset in webkit [100931] by
-
- 7 edits in trunk/Source/WebCore
copyright comment style to C from C++ for gamepad module
https://bugs.webkit.org/show_bug.cgi?id=72894
Patch by Scott Graham <scottmg@chromium.org> on 2011-11-21
Reviewed by Sam Weinig.
Just changes comment format, no code/test changes.
- Modules/gamepad/Gamepad.cpp:
- Modules/gamepad/Gamepad.h:
- Modules/gamepad/Gamepad.idl:
- Modules/gamepad/GamepadList.cpp:
- Modules/gamepad/GamepadList.h:
- Modules/gamepad/GamepadList.idl:
- 9:55 AM Changeset in webkit [100930] by
-
- 23 edits2 moves5 deletes in trunk/LayoutTests
Consolidate the many copies of Ahem in our tests
https://bugs.webkit.org/show_bug.cgi?id=72503
Patch by Philip Rogers <pdr@google.com> on 2011-11-21
Reviewed by Andreas Kling.
- css3/flexbox/flex-align-vertical-writing-mode.html:
- css3/flexbox/flex-align.html:
- fast/css/custom-font-xheight.html:
- fast/css/font-face-download-error.html:
- fast/css/font-face-in-shadow-DOM.html-disabled:
- fast/css/font-face-multiple-faces.html:
- fast/css/font-face-multiple-families.html:
- fast/css/font-face-opentype.html:
- fast/css/font-face-remote.html:
- fast/css/font-face-repeated-url.html:
- fast/css/font-face-unicode-range.html:
- fast/css/font-face-unused-source-loaded.html:
- fast/css/font-face-woff.html:
- fast/css/font-face-zero-hash-key.html:
- fast/css/resources/Ahem.otf: Removed.
- fast/css/resources/Ahem.ttf: Removed.
- fast/css/resources/Ahem.woff: Removed.
- inspector/audits/resources/Ahem.ttf: Removed.
- inspector/extensions/extensions-network-expected.txt:
- inspector/extensions/extensions-network.html:
- inspector/extensions/resources/Ahem.ttf: Removed.
- platform/gtk/fonts/font-face-with-complex-text.html:
- platform/gtk/fonts/resources/Ahem.ttf: Removed.
- platform/gtk/fonts/synthetic-oblique-positioning.html:
- resources/Ahem.otf: Added.
- resources/Ahem.woff: Added.
- webarchive/resources/Ahem.ttf: Removed.
- webarchive/test-css-url-resources-in-stylesheets-expected.webarchive:
- webarchive/test-css-url-resources-in-stylesheets.html:
- webarchive/test-css-url-resources-inline-styles-expected.webarchive:
- webarchive/test-css-url-resources-inline-styles.html:
- 9:50 AM Changeset in webkit [100929] by
-
- 2 edits in trunk/LayoutTests
2011-11-21 Pavel Feldman <pfeldman@google.com>
Not reviewed: unskip inspector test on chromium.
https://bugs.webkit.org/show_bug.cgi?id=72887
- platform/chromium/test_expectations.txt:
- 9:43 AM Changeset in webkit [100928] by
-
- 2 edits in trunk/LayoutTests
2011-11-21 Pavel Feldman <pfeldman@google.com>
Not reviewed: unskip inspector tests on Qt
https://bugs.webkit.org/show_bug.cgi?id=70414
https://bugs.webkit.org/show_bug.cgi?id=70905
https://bugs.webkit.org/show_bug.cgi?id=72493
- platform/qt/Skipped:
- 9:40 AM Changeset in webkit [100927] by
-
- 4 edits in trunk/Source/WebKit/chromium
Implement a setter for UnifiedTextCheckerEnabled.
https://bugs.webkit.org/show_bug.cgi?id=72872
Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-21
Reviewed by Darin Fisher.
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setUnifiedTextCheckerEnabled): Added.
- src/WebSettingsImpl.h:
- 9:30 AM Changeset in webkit [100926] by
-
- 2 edits in trunk/LayoutTests
2011-11-21 Pavel Feldman <pfeldman@google.com>
Not reviewed: unflake inspector test.
- inspector/extensions/extensions-events.html:
- 9:24 AM Changeset in webkit [100925] by
-
- 2 edits in trunk/Source/WebCore
JSC/CSSOM: Merge root() for style declaration objects.
<http://webkit.org/b/72881>
Patch by Andreas Kling <kling@webkit.org> on 2011-11-21
Reviewed by Antti Koivisto.
Fold root(CSSMutableStyleDeclaration*) into root(CSSStyleDeclaration*),
removing a duplicated chunk and making it a little easier on the eyes.
- bindings/js/JSDOMBinding.h:
(WebCore::root):
- 9:18 AM Changeset in webkit [100924] by
-
- 2 edits in trunk/LayoutTests
Inspector tests flakily crashing on Linux dbg canary
https://bugs.webkit.org/show_bug.cgi?id=72651
Add TIMEOUT expectations for
inspector/styles/styles-change-node-while-editing.html and
inspector/styles/styles-disable-inherited.html.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 9:15 AM Changeset in webkit [100923] by
-
- 6 edits2 adds in trunk/Source/WebKit2
[Qt][WK2] Implement loadHtml API for QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=72161
Reviewed by Simon Hausmann.
Implement QQuickWebView::loadHtml that calls QtWebPageProxy::loadHTMLString.
This function will use WKPageLoadHTMLString in order to load HTML from a given string.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::loadHtml):
- UIProcess/API/qt/qquickwebview.h:
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadHtml.qml: Added.
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml: Added.
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::loadHTMLString):
- UIProcess/qt/QtWebPageProxy.h:
- 9:03 AM Changeset in webkit [100922] by
-
- 11 edits in trunk/Source
[WK2][Qt] Move Accelerated Composite animations to UIProcess
Source/WebCore:
Add helper method to synchronize animations in TextureMapper.
Reviewed by Noam Rosenthal
- platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::syncAnimationsRecursively):
- platform/graphics/texmap/TextureMapperNode.h:
Source/WebKit2:
Currently, all the accelerated compositing animations are applied in WebProcess and
for each frame generated, WebProcess needs to sync with UIProcess.
This patch moves the accelerated compositing animations to UIProcess reducing the
amount of synchronization messages between WebProcess and UIProcess, this is done
sending animations information to UIProcess.
Reviewed by Noam Rosenthal
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
Encode/Decode RefPtr<Animation> instead of Animation class. This facilitates
the data serialization.
- Shared/WebCoreArgumentCoders.h:
- Shared/WebLayerTreeInfo.cpp:
(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):
(WebKit::WebLayerAnimation::encode):
(WebKit::WebLayerAnimation::decode):
Create WebLayerAnimation struct, it is used to send animation information
to UIProcess.
- Shared/WebLayerTreeInfo.h:
(WebKit::WebLayerAnimation::WebLayerAnimation):
- UIProcess/LayerTreeHostProxy.h:
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::didFireViewportUpdateTimer):
(WebKit::LayerTreeHostProxy::syncLayerParameters):
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::addAnimation):
(WebCore::WebGraphicsLayer::pauseAnimation):
(WebCore::WebGraphicsLayer::removeAnimation):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
- 8:56 AM Changeset in webkit [100921] by
-
- 4 edits in trunk/LayoutTests
Unreviewed Mac gardening, rebaselining MediaController failures after r100159.
- fast/dom/constructed-objects-prototypes-expected.txt:
- platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
- 8:48 AM Changeset in webkit [100920] by
-
- 2 edits in trunk
[Qt] [WK2] WebKitTestRunner doesn't build in debug
https://bugs.webkit.org/show_bug.cgi?id=72827
Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-11-21
Reviewed by Andreas Kling.
Add exports to fix WebKitTestRunner debug build.
- Source/qtwebkit-export.map:
- 8:21 AM Changeset in webkit [100919] by
-
- 2 edits in trunk/Tools
[GTK] Add a way to skip unit tests in the bots
https://bugs.webkit.org/show_bug.cgi?id=72879
Reviewed by Philippe Normand.
Rewrite the script in python to make it easier for everybody to
change it and add support for skipping tests.
- Scripts/run-gtk-tests:
- 8:19 AM Changeset in webkit [100918] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r100906): Broke inspector/extensions/extensions-events.html (Requested by steveblock on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=72887
Add a TIMEOUT expectation
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 8:13 AM Changeset in webkit [100917] by
-
- 9 edits2 adds in trunk/LayoutTests
Unreviewed rebaselining: Re-enable most layout tests on chromium-mac-leopard.
- platform/chromium-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt:
- platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
- platform/chromium-mac-leopard/fast/repaint/text-emphasis-h-expected.png:
- platform/chromium-mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Added.
- platform/chromium-mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added.
- platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
- platform/chromium-mac-leopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
- platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
- platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png:
- platform/chromium/test_expectations.txt:
- 7:47 AM Changeset in webkit [100916] by
-
- 20 edits in trunk/Source
Unreviewed, rolling out r100913.
http://trac.webkit.org/changeset/100913
https://bugs.webkit.org/show_bug.cgi?id=72885
"Break Windows build" (Requested by kbalazs on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-21
Source/JavaScriptCore:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- wtf/ParallelJobs.h:
- wtf/ParallelJobsGeneric.cpp:
- wtf/ParallelJobsGeneric.h:
(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
- wtf/Platform.h:
Source/WebCore:
- platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::platformApplySoftware):
- platform/graphics/filters/FEConvolveMatrix.h:
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApply):
- platform/graphics/filters/FEGaussianBlur.h:
- platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::platformApplyGeneric):
- platform/graphics/filters/FELighting.h:
- platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::platformApply):
- platform/graphics/filters/FEMorphology.h:
- platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::platformApplySoftware):
- platform/graphics/filters/FETurbulence.h:
- platform/graphics/filters/arm/FELightingNEON.cpp:
- platform/graphics/filters/arm/FELightingNEON.h:
(WebCore::FELighting::platformApplyNeon):
- 7:37 AM Changeset in webkit [100915] by
-
- 7 edits in trunk
[EFL] Add more appcache functions to ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72143
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-21
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit/efl:
Add a few more functions to make it possible to have more control over
the offline web application features.
- ewk/ewk_settings.cpp:
(ewk_settings_application_cache_max_quota_get):
(ewk_settings_application_cache_max_quota_set):
(ewk_settings_application_cache_clear):
- ewk/ewk_settings.h:
Tools:
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::clearAllApplicationCaches):
(LayoutTestController::setAppCacheMaximumSize): Use the right
function, this is not related to the memory cache, but rather to the
appcache.
LayoutTests:
LayoutTestController::clearAllApplicationCaches is implemented now.
- platform/efl/Skipped:
- 7:19 AM Changeset in webkit [100914] by
-
- 4 edits in trunk/Source/WebKit2
Web Inspector: [WebKit2] Do not access InspectorController from the "Develop" menu code.
https://bugs.webkit.org/show_bug.cgi?id=63009
Reviewed by Yury Semikhatsky.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::openInspectorFrontend):
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::WebInspector):
(WebKit::WebInspector::createInspectorPage):
(WebKit::WebInspector::showConsole):
(WebKit::WebInspector::startJavaScriptDebugging):
(WebKit::WebInspector::stopJavaScriptDebugging):
(WebKit::WebInspector::setJavaScriptProfilingEnabled):
(WebKit::WebInspector::startJavaScriptProfiling):
(WebKit::WebInspector::stopJavaScriptProfiling):
(WebKit::WebInspector::startPageProfiling):
(WebKit::WebInspector::stopPageProfiling):
- WebProcess/WebPage/WebInspector.h:
- 7:16 AM Changeset in webkit [100913] by
-
- 20 edits in trunk/Source
Enable ParallelJobs by default
https://bugs.webkit.org/show_bug.cgi?id=70032
Reviewed by Zoltan Herczeg.
Source/JavaScriptCore:
According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.
Remove the ENABLE(PARALLEL_JOBS) guard.
Fix build on Windows and Chromium.
- JavaScriptCore.gypi: Add the files to the build. It was
missing for the gyp build system.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Export symbols.
- wtf/ParallelJobs.h:
- wtf/ParallelJobsGeneric.cpp:
(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
Deinline these to avoid exporting a lot of symbols.
These are non-trivial and called only once on a given object
so it doesn't seems to be worthwile to inline them.
Additionally fix a signed-unsigned comparison in the constructor.
- wtf/ParallelJobsGeneric.h:
- wtf/Platform.h:
Source/WebCore:
Covered by existing tests.
According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.
Remove the ENABLE(PARALLEL_JOBS) guard. Fix the Windows build
by qualifying ParallelJobs with the WTF namespace (otherwise
MSVC believes it belongs to WebCore which is likely a compiler bug).
- platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::setInteriorPixelsWorker):
(WebCore::FEConvolveMatrix::platformApplySoftware):
- platform/graphics/filters/FEConvolveMatrix.h:
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplyWorker):
(WebCore::FEGaussianBlur::platformApply):
- platform/graphics/filters/FEGaussianBlur.h:
- platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::platformApplyGenericWorker):
(WebCore::FELighting::platformApplyGeneric):
- platform/graphics/filters/FELighting.h:
- platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::platformApplyWorker):
(WebCore::FEMorphology::platformApply):
- platform/graphics/filters/FEMorphology.h:
- platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::fillRegionWorker):
(WebCore::FETurbulence::platformApplySoftware):
- platform/graphics/filters/FETurbulence.h:
- platform/graphics/filters/arm/FELightingNEON.cpp:
(WebCore::FELighting::platformApplyNeonWorker):
- platform/graphics/filters/arm/FELightingNEON.h:
(WebCore::FELighting::platformApplyNeon):
- 7:15 AM Changeset in webkit [100912] by
-
- 3 edits in trunk/Tools
Make NRWT consider all lines of output from parse-malloc-history, not just the first
Fixes <http://webkit.org/b/72652> REGRESSION (NRWT): NRWT always reports "1 unique leaks
found" even when there are more than 1 unique leaks
Reviewed by Darin Adler.
- Scripts/webkitpy/layout_tests/port/leakdetector.py:
(LeakDetector.count_total_bytes_and_unique_leaks): Pass re.MULTILINE to re.findall so that
"" will be considered to match the beginning of any line, not only the beginning of the
string.
- Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
(LeakDetectorTest.test_count_total_bytes_and_unique_leaks): Added a second callstack to the
fake output and updated expectations to match.
- 7:04 AM Changeset in webkit [100911] by
-
- 2 edits1 delete in trunk/LayoutTests
2011-11-21 Pavel Feldman <pfeldman@google.com>
Not reviewed: updating expectations for the inspector console test (Qt -> all).
- inspector/console/console-format-expected.txt:
- platform/qt/inspector/console/console-format-expected.txt: Removed.
- 6:59 AM Changeset in webkit [100910] by
-
- 2 edits in trunk/Tools
[Qt] Clean up MiniBrowser project file after recent changes
https://bugs.webkit.org/show_bug.cgi?id=72869
Reviewed by Simon Hausmann.
Remove nonexistent files from OTHER_FILES after our touch and desktop webviews were merged.
- MiniBrowser/qt/MiniBrowser.pro:
- 6:41 AM Changeset in webkit [100909] by
-
- 3 edits in trunk/Source/WebCore
Remove CSSStyleSelector::m_additionalAttributeStyleDecls field
https://bugs.webkit.org/show_bug.cgi?id=72876
Reviewed by Andreas Kling.
There is no reason for this temporary to be a field.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchAllRules):
- css/CSSStyleSelector.h:
- 6:37 AM Changeset in webkit [100908] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [REGRESSION] Assertion failed in ScriptsPanel.js
https://bugs.webkit.org/show_bug.cgi?id=72877
Reviewed by Yury Semikhatsky.
- inspector/front-end/ScriptsPanel.js:
- 6:13 AM Changeset in webkit [100907] by
-
- 2 edits in trunk/LayoutTests
Inspector tests flakily crashing on Linux dbg canary
https://bugs.webkit.org/show_bug.cgi?id=72651
Add TIMEOUT expectation for inspector/styles/show-user-agent-styles.html
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 5:37 AM Changeset in webkit [100906] by
-
- 19 edits in trunk/Source/WebCore
Web Inspector: get rid of Panel::reset in the front-end.
https://bugs.webkit.org/show_bug.cgi?id=72587
I'm slowly getting rid of the Inspector protocol domain. It currently
contains methods that did not find their home in the meaningful domains.
This change removes reset protocol method.
Reviewed by Yury Semikhatsky.
- inspector/Inspector.json:
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::didCommitLoad):
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::didClearMainFrameWindowObject):
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
- inspector/front-end/ApplicationCacheModel.js:
(WebInspector.ApplicationCacheModel.prototype._frameNavigated):
(WebInspector.ApplicationCacheModel.prototype._frameDetached):
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype._globalObjectCleared):
(WebInspector.DebuggerDispatcher.prototype.globalObjectCleared):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._mainFrameNavigated):
- inspector/front-end/JavaScriptContextManager.js:
(WebInspector.JavaScriptContextManager.prototype._frameDetached):
(WebInspector.FrameEvaluationContext.prototype.get frameId):
- inspector/front-end/NetworkLog.js:
(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype._mainFrameNavigated):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._mainFrameNavigated):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._reset):
(WebInspector.ResourcesPanel.prototype._frameDetached):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):
(WebInspector.ScriptsPanel.prototype._reset):
- inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager):
(WebInspector.WorkerManager.prototype._mainFrameNavigated):
- inspector/front-end/inspector.js:
- 5:28 AM Changeset in webkit [100905] by
-
- 8 edits in trunk
[Qt] Add WebView.view attached property support for dialogs in QML
https://bugs.webkit.org/show_bug.cgi?id=72825
Reviewed by Simon Hausmann.
.:
Export QQuickWebViewAttached.
- Source/qtwebkit-export.map:
Source/WebKit2:
When creating new dialogs, fill their WebView.view attached property
with the WebView that's creating them. This follows the same pattern
as QtQuick's ListView, enabling the usage of the same dialog component
for different WebViews.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::runJavaScriptAlert):
(QQuickWebViewPrivate::runJavaScriptConfirm):
(QQuickWebViewPrivate::runJavaScriptPrompt):
(QQuickWebViewPrivate::setViewInAttachedProperties):
(QQuickWebViewAttached::QQuickWebViewAttached):
(QQuickWebViewAttached::setView):
(QQuickWebView::qmlAttachedProperties):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
- UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:
- UIProcess/qt/QtDialogRunner.h:
(QtDialogRunner::dialog):
- 5:20 AM Changeset in webkit [100904] by
-
- 2 edits in trunk/Source/WebKit/win
2011-11-21 Pavel Feldman <pfeldman@google.com>
Not reviewed: an attempt to fix windows build.
- WebInspector.cpp: (WebInspector::isJavaScriptProfilingEnabled): (WebInspector::setJavaScriptProfilingEnabled):
- 4:54 AM Changeset in webkit [100903] by
-
- 26 edits1 add in trunk
Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
https://bugs.webkit.org/show_bug.cgi?id=62985
Source/WebCore:
Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.
Reviewed by Yury Semikhatsky.
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::frontendLoaded):
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):
(WebCore::InspectorFrontendClientLocal::isDebuggingEnabled):
(WebCore::InspectorFrontendClientLocal::setDebuggingEnabled):
(WebCore::InspectorFrontendClientLocal::isJavaScriptProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::setJavaScriptProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::isTimelineProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::setTimelineProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::isProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::startProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::stopProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::evaluateAsBoolean):
(WebCore::InspectorFrontendClientLocal::evaluateOnLoad):
- inspector/InspectorFrontendClientLocal.h:
- inspector/front-end/InspectorFrontendAPI.js: Added.
(InspectorFrontendAPI.isDebuggingEnabled):
(InspectorFrontendAPI.setDebuggingEnabled):
(InspectorFrontendAPI.isJavaScriptProfilingEnabled):
(InspectorFrontendAPI.setJavaScriptProfilingEnabled):
(InspectorFrontendAPI.isTimelineProfilingEnabled):
(InspectorFrontendAPI.setTimelineProfilingEnabled):
(InspectorFrontendAPI.isProfilingJavaScript):
(InspectorFrontendAPI.startProfilingJavaScript):
(InspectorFrontendAPI.stopProfilingJavaScript):
(InspectorFrontendAPI.setAttachedWindow):
- inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileType):
(WebInspector.CPUProfileType.prototype.isRecordingProfile):
(WebInspector.CPUProfileType.prototype.startRecordingProfile):
(WebInspector.CPUProfileType.prototype.stopRecordingProfile):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.get profilerEnabled):
(WebInspector.ProfilesPanel.prototype.enableProfiler):
(WebInspector.ProfilesPanel.prototype.disableProfiler):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.get debuggingEnabled):
(WebInspector.ScriptsPanel.prototype.enableDebugging):
(WebInspector.ScriptsPanel.prototype.disableDebugging):
(WebInspector.ScriptsPanel.prototype.toggleDebugging):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._memoryOverviewItemSelected):
(WebInspector.TimelinePanel.prototype.setTimelineProfilingEnabled):
(WebInspector.TimelinePanel.prototype.get timelineProfilingEnabled):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
Source/WebKit/mac:
Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.
Reviewed by Yury Semikhatsky.
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController destroyInspectorView:]):
- WebInspector/WebInspector.mm:
(-showWindow):
(-show:):
(-showConsole:):
(-isDebuggingJavaScript):
(-toggleDebuggingJavaScript:):
(-startDebuggingJavaScript:):
(-stopDebuggingJavaScript:):
(-isProfilingJavaScript):
(-toggleProfilingJavaScript:):
(-startProfilingJavaScript:):
(-stopProfilingJavaScript:):
(-isJavaScriptProfilingEnabled):
(-setJavaScriptProfilingEnabled:):
(-isTimelineProfilingEnabled):
(-setTimelineProfilingEnabled:):
(-setFrontend:):
(-releaseFrontend):
(-showWindow:):
- WebInspector/WebInspectorFrontend.h:
- WebInspector/WebInspectorFrontend.mm:
(-[WebInspectorFrontend isDebuggingEnabled]):
(-[WebInspectorFrontend setDebuggingEnabled:]):
(-[WebInspectorFrontend isProfilingJavaScript]):
(-[WebInspectorFrontend startProfilingJavaScript]):
(-[WebInspectorFrontend stopProfilingJavaScript]):
(-[WebInspectorFrontend isJavaScriptProfilingEnabled]):
(-[WebInspectorFrontend setJavaScriptProfilingEnabled:]):
(-[WebInspectorFrontend isTimelineProfilingEnabled]):
(-[WebInspectorFrontend setTimelineProfilingEnabled:]):
- WebInspector/WebInspectorPrivate.h:
Source/WebKit/win:
Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.
Reviewed by Yury Semikhatsky.
- WebInspector.cpp:
(WebInspector::createInstance):
(WebInspector::WebInspector):
(WebInspector::webViewClosed):
(WebInspector::showConsole):
(WebInspector::isDebuggingJavaScript):
(WebInspector::toggleDebuggingJavaScript):
(WebInspector::isProfilingJavaScript):
(WebInspector::toggleProfilingJavaScript):
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
(WebInspector::isTimelineProfilingEnabled):
(WebInspector::setTimelineProfilingEnabled):
- WebInspector.h:
- WebView.cpp:
(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):
- WebView.h:
LayoutTests:
Reviewed by Yury Semikhatsky.
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
- 4:48 AM Changeset in webkit [100902] by
-
- 1 edit1 add in trunk
Add .dir-locals.el file for better Emacs defaults
https://bugs.webkit.org/show_bug.cgi?id=72483
Patch by Andy Wingo <wingo@igalia.com> on 2011-11-21
Reviewed by Xan Lopez.
- .dir-locals.el: Set appropriate directory-local variables for Emacs.
- 4:46 AM Changeset in webkit [100901] by
-
- 2 edits in trunk/LayoutTests
Inspector tests flakily crashing on Linux dbg canary
https://bugs.webkit.org/show_bug.cgi?id=72651
Add TIMEOUT expectation for inspector/styles/styles-cancel-editing.html.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 4:19 AM Changeset in webkit [100900] by
-
- 13 edits in trunk
Web Inspector: [Protocol] Retain a single universal method for loading a required combination of element styles
https://bugs.webkit.org/show_bug.cgi?id=72701
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/Inspector.json:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
- inspector/InspectorCSSAgent.h:
- inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles.inlineCallback):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles.matchedCallback):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getMatchedStylesAsync):
(WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
(WebInspector.CSSStyleModel.prototype.getInlineStylesAsync):
- inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype._innerUpdate):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.get forcedPseudoClasses):
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate.inlineCallback):
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate.computedCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate):
LayoutTests:
- inspector/styles/get-set-stylesheet-text.html:
- inspector/styles/styles-formatting.html:
- inspector/styles/styles-new-API.html:
- inspector/styles/styles-source-offsets.html:
- 4:19 AM Changeset in webkit [100899] by
-
- 2 edits in trunk
Update .gitignore for latest WebKitLibraries
https://bugs.webkit.org/show_bug.cgi?id=72851
Reviewed by Andreas Kling.
- .gitignore: updates to silence 'git status' about WebKitLibraries files.
- 4:14 AM Changeset in webkit [100898] by
-
- 4 edits in trunk
[GTK] Update NEWS and configure.ac for 1.7.2 release
https://bugs.webkit.org/show_bug.cgi?id=72868
Reviewed by Xan Lopez.
.:
- configure.ac: Bumped version number.
Source/WebKit/gtk:
- NEWS: Added release notes for 1.7.2.
- 4:02 AM Changeset in webkit [100897] by
-
- 2 edits in trunk/LayoutTests
ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
https://bugs.webkit.org/show_bug.cgi?id=59552
Add CRASH expectation for jquery/offset.html.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 3:11 AM Changeset in webkit [100896] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r100856.
http://trac.webkit.org/changeset/100856
https://bugs.webkit.org/show_bug.cgi?id=72867
New test fast/css/style-tag-display-none.html fails on
Chromium (Requested by steveblock on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-21
Source/WebCore:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchUARules):
LayoutTests:
- fast/css/style-tag-display-none-expected.txt: Removed.
- fast/css/style-tag-display-none.html: Removed.
- 2:29 AM Changeset in webkit [100895] by
-
- 26 edits25 adds in trunk
Implement Meta referrer
https://bugs.webkit.org/show_bug.cgi?id=72674
Reviewed by Adam Barth.
Source/WebCore:
http://wiki.whatwg.org/wiki/Meta_referrer
Tests: http/tests/security/referrer-policy-always.html
http/tests/security/referrer-policy-default.html
http/tests/security/referrer-policy-https-always.html
http/tests/security/referrer-policy-https-default.html
http/tests/security/referrer-policy-https-never.html
http/tests/security/referrer-policy-https-origin.html
http/tests/security/referrer-policy-never.html
http/tests/security/referrer-policy-origin.html
http/tests/security/referrer-policy-redirect.html
http/tests/security/referrer-policy-rel-noreferrer.html
- WebCore.exp.in: updated
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::processReferrerPolicy):
- dom/Document.h:
(WebCore::Document::referrerPolicy):
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::handleClick):
- html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::process):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::loadResourceSynchronously):
- loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::reportContentSecurityPolicyViolation):
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadSubframe):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::create):
- page/SecurityPolicy.cpp:
(WebCore::SecurityPolicy::generateReferrerHeader):
- page/SecurityPolicy.h:
Source/WebKit/chromium:
- WebKit.gyp:
- public/WebFrame.h:
- public/WebReferrerPolicy.h: Added.
- public/WebSecurityPolicy.h:
- src/AssertMatchingEnums.cpp:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::referrerPolicy):
(WebKit::WebFrameImpl::setReferrerForRequest):
- src/WebFrameImpl.h:
- src/WebSecurityPolicy.cpp:
(WebKit::WebSecurityPolicy::generateReferrerHeader):
Source/WebKit/mac:
- Plugins/Hosted/HostedNetscapePluginStream.mm:
(WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
- Plugins/WebNetscapePluginStream.mm:
(WebNetscapePluginStream::WebNetscapePluginStream):
Source/WebKit2:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::loadURL):
LayoutTests:
- http/tests/security/referrer-policy-always-expected.txt: Added.
- http/tests/security/referrer-policy-always.html: Added.
- http/tests/security/referrer-policy-default-expected.txt: Added.
- http/tests/security/referrer-policy-default.html: Added.
- http/tests/security/referrer-policy-https-always-expected.txt: Added.
- http/tests/security/referrer-policy-https-always.html: Added.
- http/tests/security/referrer-policy-https-default-expected.txt: Added.
- http/tests/security/referrer-policy-https-default.html: Added.
- http/tests/security/referrer-policy-https-never-expected.txt: Added.
- http/tests/security/referrer-policy-https-never.html: Added.
- http/tests/security/referrer-policy-https-origin-expected.txt: Added.
- http/tests/security/referrer-policy-https-origin.html: Added.
- http/tests/security/referrer-policy-never-expected.txt: Added.
- http/tests/security/referrer-policy-never.html: Added.
- http/tests/security/referrer-policy-origin-expected.txt: Added.
- http/tests/security/referrer-policy-origin.html: Added.
- http/tests/security/referrer-policy-redirect-expected.txt: Added.
- http/tests/security/referrer-policy-redirect.html: Added.
- http/tests/security/referrer-policy-rel-noreferrer-expected.txt: Added.
- http/tests/security/referrer-policy-rel-noreferrer.html: Added.
- http/tests/security/resources/referrer-policy-log.php: Added.
- http/tests/security/resources/referrer-policy-redirect.html: Added.
- http/tests/security/resources/referrer-policy-start.html: Added.
- http/tests/security/resources/rel-noreferrer.html: Added.
- 2:22 AM Changeset in webkit [100894] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: ApplicationCache view should show navigator.onLine indicator.
https://bugs.webkit.org/show_bug.cgi?id=72618
Reviewed by Pavel Feldman.
- inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::enable):
- inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype.wasShown):
- inspector/front-end/ApplicationCacheModel.js:
(WebInspector.ApplicationCacheModel):
(WebInspector.ApplicationCacheModel.prototype.get onLine):
(WebInspector.ApplicationCacheModel.prototype._networkStateUpdated):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.showApplicationCache):
(WebInspector.ResourcesPanel.prototype._applicationCacheNetworkStateChanged):
- 1:55 AM Changeset in webkit [100893] by
-
- 4 edits in trunk/Source
Unreviewed. Fix make distcheck build.
Source/WebCore:
- GNUmakefile.list.am:
Source/WebKit2:
- GNUmakefile.am:
- 1:50 AM Changeset in webkit [100892] by
-
- 16 edits2 adds in trunk
Accessibility: Multiselect list boxes need to report the active option in addition to which items are selected.
https://bugs.webkit.org/show_bug.cgi?id=72479
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/multiselect-list-reports-active-option.html
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::isSelectedOptionActive):
- accessibility/AccessibilityListBoxOption.h:
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isSelectedOptionActive):
Source/WebKit/chromium:
Test: accessibility/multiselect-list-reports-active-option.html
- public/WebAccessibilityObject.h:
- src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::isSelectedOptionActive):
Tools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(getIsSelectedOptionActiveCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/chromium/AccessibilityUIElement.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::isSelectedOptionActiveGetterCallback):
- DumpRenderTree/chromium/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::isSelectedOptionActive):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::isSelectedOptionActive):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::isSelectedOptionActive):
LayoutTests:
- accessibility/multiselect-list-reports-active-option.html: Added.
- platform/chromium/accessibility/multiselect-list-reports-active-option-expected.txt: Added.
- 1:42 AM Changeset in webkit [100891] by
-
- 4 edits in trunk
[Qt] WebSocket close tests are failing
https://bugs.webkit.org/show_bug.cgi?id=72865
Reviewed by Simon Hausmann.
Source/WebCore:
- platform/network/qt/SocketStreamHandleQt.cpp:
(WebCore::SocketStreamHandlePrivate::close):
Emit didCloseSocketStream() callback even before the connection is established.
Call m_socket->abort() to prevent "connected" signal from firing.
LayoutTests:
- platform/qt/Skipped:
Unskip five WebSocket tests. Remove "failing websocket tests" section,
as there are no tests in this section.
- 1:20 AM Changeset in webkit [100890] by
-
- 4 edits in trunk/Source/WebCore
Refactoring: SpellChecker::requestCheckingFor should take Range instead of Node.
https://bugs.webkit.org/show_bug.cgi?id=72847
Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-21
Reviewed by Hajime Morita.
Covered by existing test.
- editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment):
Passes Range to requestCheckingFor instead of Node.
- editing/SpellChecker.cpp: Changed argument type from Node to Range. The corresponding changes are also done in dependent methods.
(WebCore::SpellChecker::initRequest):
(WebCore::SpellChecker::clearRequest):
(WebCore::SpellChecker::canCheckAsynchronously):
(WebCore::SpellChecker::isBusy):
(WebCore::SpellChecker::isValid):
(WebCore::SpellChecker::isCheckable):
(WebCore::SpellChecker::requestCheckingFor):
Changed argument type from Node to Range.
(WebCore::SpellChecker::doRequestCheckingFor):
(WebCore::SpellChecker::didCheck):
- editing/SpellChecker.h:
- 1:12 AM Changeset in webkit [100889] by
-
- 2 edits in trunk/Tools
Use Host().port_factory instead of webkitpy.layout_tests.port.factory.
https://bugs.webkit.org/show_bug.cgi?id=72859
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-11-21
Reviewed by Eric Seidel.
- Scripts/new-run-webkit-websocketserver:
- 12:37 AM Changeset in webkit [100888] by
-
- 2 edits in trunk/Source/JavaScriptCore
Another attempt at a build fix.
- dfg/DFGRepatch.h:
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):
Nov 20, 2011:
- 10:28 PM Changeset in webkit [100887] by
-
- 5 edits in trunk
[Chromium] Layout test does not return correct misspelling positions if there are multiple misspelled words.
https://bugs.webkit.org/show_bug.cgi?id=72655
Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-20
Reviewed by Hajime Morita.
Tools:
Fixed the calculation of offset.
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::finishLastTextCheck):
LayoutTests:
Fixed the calculation of offset, and added test cases having multiple misspelled words.
- editing/spelling/script-tests/spellcheck-paste.js: Added test cases having multiple misspelled words.
(verifyMarker):
(tests):
- editing/spelling/spellcheck-paste-expected.txt: Recreated.
- 10:10 PM Changeset in webkit [100886] by
-
- 10 edits in trunk
[Chromium] Remove old getFontFamilyForCharacters() and familyForChars() APIs.
https://bugs.webkit.org/show_bug.cgi?id=72844
Source/WebCore:
Respects bold and italic properties that is given by fontconfig.
Reviewed by Darin Fisher.
- platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getFontDataForCharacters): Removed #if and old logic.
Source/WebKit/chromium:
Removes old APIs for getting font family for given characters.
Reviewed by Darin Fisher.
- public/linux/WebFontInfo.h: Removed old familyForChars().
- public/linux/WebSandboxSupport.h: Removed old getFontFamilyForCharacters() and changed new getFontFamilyForCharacters() to be a pure virtual function.
- src/linux/WebFontInfo.cpp: Removes old familyForChars().
LayoutTests:
Font selection mechanism of Chromium Linux port has been improved. Rebaselines affected tests.
Reviewed by Darin Fisher.
- platform/chromium-linux/fast/text/cg-fallback-bolding-expected.png:
- platform/chromium-linux/fast/text/cg-fallback-bolding-expected.txt:
- platform/chromium-linux/fast/text/international/khmer-selection-expected.png:
- 9:37 PM Changeset in webkit [100885] by
-
- 3 edits4 adds1 delete in trunk/LayoutTests
Rebaseline for border change in r100528
https://bugs.webkit.org/show_bug.cgi?id=72689
Patch by Ben Wells <benwells@chromium.org> on 2011-11-20
Reviewed by Stephen White.
- platform/chromium-cg-mac-snowleopard/fast/borders/mixed-border-styles-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/borders/border-mixed-alpha-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/borders/mixed-border-styles-expected.png: Added.
- platform/chromium-mac/fast/borders/mixed-border-styles-expected.png: Removed.
- platform/chromium-win/fast/borders/border-mixed-alpha-expected.png: Added.
- platform/chromium-win/fast/borders/mixed-border-styles-expected.png:
- platform/chromium/test_expectations.txt:
- 9:18 PM Changeset in webkit [100884] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Remove qt/QtMobileWebStyle from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=72843
Reviewed by Antonio Gomes.
platform/qt/QtMobileWebStyle.{h,cpp} were removed in r100123
- WebCore.gypi: remove platform/qt/QtMobileWebStyle.{h,cpp}
- 9:03 PM Changeset in webkit [100883] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed interpreter build fix.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finalizeUnconditionally):
- dfg/DFGRepatch.h:
- 9:01 PM Changeset in webkit [100882] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Rebaselined run-bindings-tests results.
- bindings/scripts/test/CPP/WebDOMFloat64Array.cpp:
(WebDOMFloat64Array::WebDOMFloat64Array):
(WebDOMFloat64Array::impl):
(toWebCore):
(toWebKit):
- bindings/scripts/test/CPP/WebDOMFloat64Array.h:
- 8:47 PM Changeset in webkit [100881] by
-
- 6 edits in trunk/Source/JavaScriptCore
Improve modulo operation on 32bit platforms
https://bugs.webkit.org/show_bug.cgi?id=72501
Reviewed by Filip Pizlo.
Extend softModulo to support X86 and MIPS in baseline JIT.
Apply the same optimization to 32bit DFG JIT.
1% gain on Kraken, tested on Linux Core i7 Nehalem 32bit.
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compile):
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::softModulo):
- wtf/Platform.h:
- 8:45 PM Changeset in webkit [100880] by
-
- 19 edits in trunk/Source/JavaScriptCore
Inline caches that refer to otherwise dead objects should be cleared
https://bugs.webkit.org/show_bug.cgi?id=72311
Reviewed by Geoff Garen.
DFG code blocks now participate in the weak reference harvester fixpoint
so that they only consider themselves to be live if either they are
currently executing, or their owner is live and all of their weak references
are live. If not, the relevant code blocks are jettisoned.
Inline caches in both the old JIT and the DFG are now cleared if any of
their references are not marked at the end of a GC.
This is performance-neutral on SunSpider, V8, and Kraken. With the clear-
all-code-on-GC policy that we currently have, it shows a slight reduction
in memory usage. If we turn that policy off, it's pretty easy to come up
with an example program that will cause ToT to experience linear heap
growth, while with this patch, the heap stays small and remains at a
constant size.
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::readCallTarget):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::readCallTarget):
- assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::readCallTarget):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::readCallTarget):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::performTracingFixpointIteration):
(JSC::CodeBlock::visitWeakReferences):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::MethodCallLinkInfo::reset):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::reoptimize):
(JSC::CodeBlock::shouldImmediatelyAssumeLivenessDuringScan):
- bytecode/Instruction.h:
(JSC::PolymorphicAccessStructureList::visitWeak):
- bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::visitWeakReferences):
- bytecode/StructureStubInfo.h:
(JSC::isGetByIdAccess):
(JSC::isPutByIdAccess):
(JSC::StructureStubInfo::reset):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGOperations.cpp:
- dfg/DFGRepatch.cpp:
(JSC::DFG::dfgRepatchByIdSelfAccess):
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):
- dfg/DFGRepatch.h:
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):
- jit/JIT.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITWriteBarrier.h:
(JSC::JITWriteBarrierBase::clearToMaxUnsigned):
- 8:35 PM Changeset in webkit [100879] by
-
- 6 edits3 adds in trunk
Showing the data overlay in OpenStreetMap doesn't work, zooming partially broken
https://bugs.webkit.org/show_bug.cgi?id=71505
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
The bytecode generator was assuming that call_varargs never reuses the base register
(i.e. the function being called) for the result. This is no longer true.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCallVarargs):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::ApplyFunctionCallDotNode::emitBytecode):
LayoutTests:
Reviewed by Oliver Hunt.
- fast/js/function-dot-apply-replace-base-expected.txt: Added.
- fast/js/function-dot-apply-replace-base.html: Added.
- fast/js/script-tests/cross-global-object-inline-global-var.js:
(done):
- fast/js/script-tests/function-dot-apply-replace-base.js: Added.
(foo):
(bar):
- 7:32 PM Changeset in webkit [100878] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG 32_64 should directly store double virtual registers on SetLocal
https://bugs.webkit.org/show_bug.cgi?id=72845
Reviewed by Oliver Hunt.
2% win on Kraken.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 6:26 PM Changeset in webkit [100877] by
-
- 5 edits1 delete in trunk
REGRESSION(r100691): Safari error pages and Growl notifications fail to load stylesheets
https://bugs.webkit.org/show_bug.cgi?id=72836
Reviewed by Sam Weinig.
Source/WebCore:
This patch removes a (minor) security mitigation. Previously, we tried
sequester "directory listings" into unique origins to make it more
difficult for an attacker to crawl the user's local file system.
Unfortunately, this mitigation doesn't really buy us much security
because if the attacker has access to local files, we've probably lost
anyway.
The larger problem, however, is that this condition is overly
complicated and has broken in sublte ways several times in its
(relatively short) lifetime. In the cases reported in this bug, we see
that this check affects error pages in Safari and Growl notifications,
even those have nothing to do with directory listings.
If we have our heart set on this directory listing mitigation, we'll
need a more robust way of triggering the behavior than examining URLs
and guess whether they contain directory listings. For example, if we
implement Allow-From or Access-Control-Deny-Origin, then the embedder
can supply those policies along with the directory listings. Those
seem like much better solutions than the in-engine hack this patch
removes.
- page/SecurityOrigin.cpp:
(WebCore::shouldTreatAsUniqueOrigin):
LayoutTests:
Update test results to show that XMLHttpRequets for directory listings
aren't blocked.
- fast/xmlhttprequest/resources/xmlhttprequest-nonexistent-file-real.html:
- fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
- 6:03 PM Changeset in webkit [100876] by
-
- 2 edits in trunk/Source/JavaScriptCore
[chromium] Remove DFG::JITCodeGenerator from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=72842
Reviewed by Filip Pizlo.
dfg/DFGJITCodeGenerator.{h,cpp} were removed in r100244
- JavaScriptCore.gypi: remove dfg/DFGJITCodeGenerator.{h,cpp}
- 5:26 PM Changeset in webkit [100875] by
-
- 3 edits in trunk/Tools
Change the final place where we use version 3 of the results json output
https://bugs.webkit.org/show_bug.cgi?id=72838
Reviewed by Adam Barth.
This converts the json from being a flat map of test name --> results
to being hierarchical by directory. This will make the json files
considerably smaller.
Also cleaned up some functions that were returning/checking boolean values
that were always True.
- TestResultServer/model/jsonresults.py:
- TestResultServer/model/jsonresults_unittest.py:
- 3:55 PM Changeset in webkit [100874] by
-
- 28 edits in trunk/Source
2011-10-17 Antonio Gomes <agomes@rim.com>
Pass a Frame* parameter in EditorClient::respondToChangedSelection
https://bugs.webkit.org/show_bug.cgi?id=70248
Reviewed by Ryosuke Niwa.
Most of the port specific implementations of EditorClient::respondToChangedSelection
(like EditorClient{Qt,Gtk,etc}) are wrongly relying on FocusController::focusedOrMainFrame
method to get the Frame where the selection is happening on.
It is not right, since a selection can be easily triggered in an inner
frame that is not focused.
No new tests since it is a hard thing to test without
to hook into editor client in layout tests. We could
change the "Dumped Delegate" messages, but it would
require a rebasile of +1200 for a minor change.
No new tests since it is a hard thing to test without
to hook into editor client in layout tests. We could
change the "Dumped Delegate" messages, but it would
require a rebasile of +1200 for a minor change.
Source/WebCore:
- editing/Editor.cpp: Pass the Frame on where the selection is changing to the client. (WebCore::Editor::respondToChangedSelection): Ditto. (WebCore::Editor::changeSelectionAfterCommand): Ditto. (WebCore::EmptyEditorClient::respondToChangedSelection):
- page/EditorClient.h: Pass Frame* to indicate where the selection is happening.
- loader/EmptyClients.h: Changed signature as per base class change.
Source/WebKit/chromium:
- src/EditorClientImpl.cpp: Make use of the newly added Frame* parameter. (WebKit::EditorClientImpl::respondToChangedSelection):
- src/EditorClientImpl.h:
Source/WebKit/efl:
- WebCoreSupport/EditorClientEfl.cpp: Make use of the newly added Frame* parameter. (WebCore::EditorClientEfl::respondToChangedSelection):
- WebCoreSupport/EditorClientEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/EditorClientGtk.cpp: Make use of the newly added Frame* parameter. (WebKit::EditorClient::respondToChangedSelection):
- WebCoreSupport/EditorClientGtk.h:
Source/WebKit/mac:
- WebCoreSupport/WebEditorClient.h: Make use of the newly added Frame* parameter.
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::respondToChangedSelection):
Source/WebKit/qt:
- WebCoreSupport/EditorClientQt.cpp: Make use of the newly added Frame* parameter. (WebCore::EditorClientQt::respondToChangedSelection):
- WebCoreSupport/EditorClientQt.h:
Source/WebKit/win:
- WebCoreSupport/WebEditorClient.cpp: Make use of the newly added Frame* parameter. (WebEditorClient::respondToChangedSelection):
- WebCoreSupport/WebEditorClient.h:
Source/WebKit/wx:
- WebKitSupport/EditorClientWx.cpp: Make use of the newly added Frame* parameter. (WebCore::EditorClientWx::respondToChangedSelection):
- WebKitSupport/EditorClientWx.h:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebEditorClient.cpp: Make use of the newly added Frame* parameter. (WebKit::WebEditorClient::respondToChangedSelection):
- WebProcess/WebCoreSupport/WebEditorClient.h:
- 3:40 PM Changeset in webkit [100873] by
-
- 2 edits in trunk/Tools
Include the master name when querying the test results server.
This will soon be required since leaving the master name out mean
that multiple files could match the query.
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- 2:55 PM Changeset in webkit [100872] by
-
- 8 edits in trunk/Source
<http://webkit.org/b/72646> Disable deprecation warnings around code where we cannot easily
switch away from the deprecated APIs.
Reviewed by Sam Weinig.
Source/WebCore:
- platform/mac/WebCoreNSStringExtras.mm:
- platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::reportErrorToClient):
Source/WebKit/mac:
- Plugins/WebBasePluginPackage.mm:
- Plugins/WebNetscapePluginPackage.mm:
(-[WebNetscapePluginPackage _tryLoad]):
Source/WebKit2:
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
- 8:40 AM Changeset in webkit [100871] by
-
- 3 edits in trunk/Source/WebKit/chromium
Add WebNode::hasEventListeners for Android
https://bugs.webkit.org/show_bug.cgi?id=72817
Reviewed by Darin Fisher.
Expose this EventTarget interface in the Chromium WebKit API for use by
Android.
- public/WebNode.h:
- src/WebNode.cpp:
(WebKit::WebNode::hasEventListeners):
- 8:38 AM Changeset in webkit [100870] by
-
- 4 edits in trunk/Source/WebKit/chromium
[Chromium] Add GestureFlingStart and GestureFlingCancel to WebGestureEvent for Android
https://bugs.webkit.org/show_bug.cgi?id=72819
Reviewed by Darin Fisher.
These gesture types are used with FlingAnimator for scrolling.
- public/WebInputEvent.h:
(WebKit::WebInputEvent::isScrollGestureEventType):
(WebKit::WebGestureEvent::WebGestureEvent):
- src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::handleInputEvent):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):
- 8:36 AM Changeset in webkit [100869] by
-
- 2 edits3 adds in trunk/Source/WebKit/chromium
[Chromium] Add WebInputEventFactory for Android
https://bugs.webkit.org/show_bug.cgi?id=67890
Reviewed by Darin Fisher.
Like every Chromium OS, Android needs a WebInputFactory.
- WebKit.gyp:
- public/android/WebInputEventFactory.h: Added.
- src/android/WebInputEventFactory.cpp: Added.
