Timeline

Nov 23, 2011:

11:47 PM Changeset in webkit [101124] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
​https://bugs.webkit.org/show_bug.cgi?id=52810

Unreviewed gardening.

• platform/qt/Skipped: Skip svg/dom/css-transforms.xhtml introduced in r101062, because 0.0 != -0.0.

11:46 PM Changeset in webkit [101123] by commit-queue@webkit.org

• 4 edits
  2 copies in trunk/Source/WebKit/chromium

Add simple implementation for web intents chromium API data classes.
​https://bugs.webkit.org/show_bug.cgi?id=73036

Patch by Greg Billock <​gbillock@google.com> on 2011-11-23
Reviewed by Darin Fisher.

• WebKit.gyp:
• public/WebIntent.h:
• public/WebIntentServiceInfo.h:
• src/WebIntent.cpp: Copied from Source/WebKit/chromium/public/WebIntent.h.

(WebKit::WebIntent::WebIntent):
(WebKit::WebIntent::action):
(WebKit::WebIntent::setAction):
(WebKit::WebIntent::type):
(WebKit::WebIntent::setType):
(WebKit::WebIntent::data):
(WebKit::WebIntent::setData):
(WebKit::WebIntent::identifier):
(WebKit::WebIntent::setIdentifier):

• src/WebIntentServiceInfo.cpp: Copied from Source/WebKit/chromium/public/WebIntentServiceInfo.h.

(WebKit::WebIntentServiceInfo::WebIntentServiceInfo):
(WebKit::WebIntentServiceInfo::url):
(WebKit::WebIntentServiceInfo::setURL):
(WebKit::WebIntentServiceInfo::title):
(WebKit::WebIntentServiceInfo::setTitle):
(WebKit::WebIntentServiceInfo::action):
(WebKit::WebIntentServiceInfo::setAction):
(WebKit::WebIntentServiceInfo::type):
(WebKit::WebIntentServiceInfo::setType):
(WebKit::WebIntentServiceInfo::disposition):
(WebKit::WebIntentServiceInfo::setDisposition):

11:13 PM Changeset in webkit [101122] by abarth@webkit.org

• 168 edits
  15 copies
  16 adds in trunk/Source/WebKit/chromium

[Chromium] Move WebKitPlatformSupport.h and dependencies to new public/platform directory
​https://bugs.webkit.org/show_bug.cgi?id=73066

Reviewed by Darin Fisher.

This patch creates a new subdirectory in the Chromium WebKit API to
house "platform" header files. As with the other Platform directories
in WebKit, the platform directory cannot depend on headers outside of
platform, but headers outside of platform can depend on platform.

This patch moves WebKitPlatformSupport and its dependencies into this
new directory and creates forwarding headers to easy migration for
embedders of this API. Over time, we will migrate more headers into
this folder, as appropriate.

• public/WebAccessibilityObject.h:
• public/WebAccessibilityRole.h:
• public/WebAnimationController.h:
• public/WebApplicationCacheHost.h:
• public/WebApplicationCacheHostClient.h:
• public/WebArrayBufferView.h:
• public/WebAttribute.h:
• public/WebAudioBus.h: Replaced.
• public/WebAudioDevice.h: Replaced.
• public/WebAudioSourceProvider.h:
• public/WebBindings.h:
• public/WebBlob.h:
• public/WebBlobData.h:
• public/WebBlobRegistry.h:
• public/WebCString.h: Replaced.
• public/WebCache.h:
• public/WebCanvas.h:
• public/WebClipboard.h:
• public/WebColor.h:
• public/WebCommon.h: Replaced.
• public/WebCommonWorkerClient.h:
• public/WebCompositor.h:
• public/WebConsoleMessage.h:
• public/WebContentLayer.h:
• public/WebContextMenuData.h:
• public/WebCookie.h:
• public/WebCrossOriginPreflightResultCache.h:
• public/WebDOMEvent.h:
• public/WebDOMEventListener.h:
• public/WebDOMStringList.h:
• public/WebData.h: Replaced.
• public/WebDataSource.h:
• public/WebDatabase.h:
• public/WebDevToolsAgent.h:
• public/WebDevToolsAgentClient.h:
• public/WebDevToolsFrontend.h:
• public/WebDeviceOrientationClientMock.h:
• public/WebDeviceOrientationController.h:
• public/WebDocument.h:
• public/WebDragData.h:
• public/WebExternalPopupMenuClient.h:
• public/WebExternalTextureLayer.h:
• public/WebFileChooserParams.h:
• public/WebFileInfo.h:
• public/WebFileSystem.h:
• public/WebFileSystemCallbacks.h:
• public/WebFileSystemEntry.h:
• public/WebFileUtilities.h:
• public/WebFileWriter.h:
• public/WebFileWriterClient.h:
• public/WebFindOptions.h:
• public/WebFloatPoint.h:
• public/WebFloatQuad.h:
• public/WebFloatRect.h:
• public/WebFont.h:
• public/WebFontCache.h:
• public/WebFontDescription.h:
• public/WebFormControlElement.h:
• public/WebFormElement.h:
• public/WebFrame.h:
• public/WebFrameClient.h:
• public/WebGamepad.h: Replaced.
• public/WebGamepads.h: Replaced.
• public/WebGeolocationClientMock.h:
• public/WebGeolocationController.h:
• public/WebGeolocationError.h:
• public/WebGeolocationPermissionRequest.h:
• public/WebGeolocationPermissionRequestManager.h:
• public/WebGeolocationPosition.h:
• public/WebGlyphCache.h:
• public/WebGraphicsContext3D.h:
• public/WebHTTPBody.h:
• public/WebHTTPLoadInfo.h:
• public/WebHistoryItem.h:
• public/WebIDBCallbacks.h:
• public/WebIDBCursor.h:
• public/WebIDBDatabase.h:
• public/WebIDBDatabaseCallbacks.h:
• public/WebIDBDatabaseError.h:
• public/WebIDBFactory.h:
• public/WebIDBIndex.h:
• public/WebIDBKey.h:
• public/WebIDBKeyPath.h:
• public/WebIDBKeyRange.h:
• public/WebIDBObjectStore.h:
• public/WebIDBTransaction.h:
• public/WebIDBTransactionCallbacks.h:
• public/WebIconURL.h:
• public/WebImage.h:
• public/WebInputEvent.h:
• public/WebKit.h:
• public/WebKitPlatformSupport.h: Replaced.
• public/WebLayer.h:
• public/WebLayerTreeView.h:
• public/WebLocalizedString.h: Replaced.
• public/WebMediaPlayer.h:
• public/WebMediaStreamDescriptor.h:
• public/WebMediaStreamRegistry.h:
• public/WebMediaStreamSource.h:
• public/WebMenuItemInfo.h:
• public/WebMessagePortChannel.h:
• public/WebMimeRegistry.h:
• public/WebNamedNodeMap.h:
• public/WebNetworkStateNotifier.h:
• public/WebNode.h:
• public/WebNodeCollection.h:
• public/WebNodeList.h:
• public/WebNotification.h:
• public/WebNotificationPresenter.h:
• public/WebOptionElement.h:
• public/WebPageSerializer.h:
• public/WebPasswordFormData.h:
• public/WebPeerConnectionHandler.h:
• public/WebPerformance.h:
• public/WebPlugin.h:
• public/WebPluginParams.h:
• public/WebPoint.h:
• public/WebPopupMenu.h:
• public/WebPopupMenuInfo.h:
• public/WebPrivateOwnPtr.h: Replaced.
• public/WebPrivatePtr.h: Replaced.
• public/WebRange.h:
• public/WebRect.h:
• public/WebRegularExpression.h:
• public/WebRuntimeFeatures.h:
• public/WebScriptController.h:
• public/WebScriptSource.h:
• public/WebScrollbar.h:
• public/WebSearchableFormData.h:
• public/WebSecurityOrigin.h:
• public/WebSecurityPolicy.h:
• public/WebSelectElement.h:
• public/WebSerializedScriptValue.h: Replaced.
• public/WebSettings.h:
• public/WebSharedWorker.h:
• public/WebSharedWorkerRepository.h:
• public/WebSize.h:
• public/WebSocket.h:
• public/WebSocketClient.h:
• public/WebSocketStreamError.h:
• public/WebSocketStreamHandle.h:
• public/WebSocketStreamHandleClient.h:
• public/WebSpeechInputController.h:
• public/WebSpeechInputResult.h:
• public/WebSpellCheckClient.h:
• public/WebStorageArea.h:
• public/WebStorageEventDispatcher.h:
• public/WebStorageNamespace.h:
• public/WebString.h: Replaced.
• public/WebTestingSupport.h:
• public/WebTextCheckingCompletion.h:
• public/WebTextCheckingResult.h:
• public/WebTextRun.h:
• public/WebThread.h:
• public/WebThreadSafeData.h:
• public/WebTouchPoint.h:
• public/WebURL.h: Replaced.
• public/WebURLError.h:
• public/WebURLLoadTiming.h:
• public/WebURLLoader.h:
• public/WebURLRequest.h:
• public/WebURLResponse.h:
• public/WebUserMediaRequest.h:
• public/WebVector.h: Replaced.
• public/WebView.h:
• public/WebViewClient.h:
• public/WebWidget.h:
• public/WebWidgetClient.h:
• public/WebWindowFeatures.h:
• public/android/WebInputEventFactory.h:
• public/gtk/WebInputEventFactory.h:
• public/linux/WebFontFamily.h:
• public/linux/WebFontInfo.h:
• public/linux/WebFontRenderStyle.h:
• public/linux/WebFontRendering.h:
• public/linux/WebRenderTheme.h:
• public/linux/WebSandboxSupport.h:
• public/mac/WebInputEventFactory.h:
• public/mac/WebScreenInfoFactory.h:
• public/platform: Added.
• public/platform/WebAudioBus.h: Copied from Source/WebKit/chromium/public/WebAudioBus.h.
• public/platform/WebAudioDevice.h: Copied from Source/WebKit/chromium/public/WebAudioDevice.h.
• public/platform/WebCString.h: Copied from Source/WebKit/chromium/public/WebCString.h.
• public/platform/WebCommon.h: Copied from Source/WebKit/chromium/public/WebCommon.h.
• public/platform/WebData.h: Copied from Source/WebKit/chromium/public/WebData.h.
• public/platform/WebGamepad.h: Copied from Source/WebKit/chromium/public/WebGamepad.h.
• public/platform/WebGamepads.h: Copied from Source/WebKit/chromium/public/WebGamepads.h.
• public/platform/WebKitPlatformSupport.h: Copied from Source/WebKit/chromium/public/WebKitPlatformSupport.h.
• public/platform/WebLocalizedString.h: Copied from Source/WebKit/chromium/public/WebLocalizedString.h.
• public/platform/WebPrivateOwnPtr.h: Copied from Source/WebKit/chromium/public/WebPrivateOwnPtr.h.
• public/platform/WebPrivatePtr.h: Copied from Source/WebKit/chromium/public/WebPrivatePtr.h.
• public/platform/WebSerializedScriptValue.h: Copied from Source/WebKit/chromium/public/WebSerializedScriptValue.h.
• public/platform/WebString.h: Copied from Source/WebKit/chromium/public/WebString.h.
• public/platform/WebURL.h: Copied from Source/WebKit/chromium/public/WebURL.h.
• public/platform/WebVector.h: Copied from Source/WebKit/chromium/public/WebVector.h.
• public/win/WebInputEventFactory.h:
• public/win/WebScreenInfoFactory.h:
• public/x11/WebScreenInfoFactory.h:

11:03 PM Changeset in webkit [101121] by abarth@webkit.org

• 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove unused WebSecurityOrigin::isEmpty from WebKit API
​https://bugs.webkit.org/show_bug.cgi?id=73065

Reviewed by Eric Seidel.

This API no longer has any callers.

• public/WebSecurityOrigin.h:
• src/WebSecurityOrigin.cpp:

(WebKit::WebSecurityOrigin::isUnique):

10:06 PM Changeset in webkit [101120] by commit-queue@webkit.org

• 8 edits
  2 adds in trunk

[Chromium] Prevent DrawingBuffer instances from corrupting the active
texture state of the WebGL contexts. The DrawingBuffer now tracks the
state of texture unit 0, and the active texture unit, so that state can
be restored.
​https://bugs.webkit.org/show_bug.cgi?id=73033

Patch by Jeff Timanus <​twiz@chromium.org> on 2011-11-23
Reviewed by Kenneth Russell.

Test: fast/canvas/webgl/webgl-texture-binding-preserved.html

Source/WebCore:

• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::activeTexture):
(WebCore::WebGLRenderingContext::bindTexture):

• platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::publishToPlatformLayer):

• platform/graphics/gpu/DrawingBuffer.h:

(WebCore::DrawingBuffer::setTexture2DBinding):
(WebCore::DrawingBuffer::setActiveTextureUnit):

• platform/graphics/gpu/mac/DrawingBufferMac.mm:

(WebCore::DrawingBuffer::DrawingBuffer):

• platform/graphics/gpu/qt/DrawingBufferQt.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):

• platform/graphics/gtk/DrawingBufferGtk.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):

LayoutTests:

• fast/canvas/webgl/webgl-texture-binding-preserved-expected.txt: Added.
• fast/canvas/webgl/webgl-texture-binding-preserved.html: Added.

10:03 PM Changeset in webkit [101119] by macpherson@chromium.org

• 3 edits in trunk/Source/WebCore

CSSValue: reorder ClassType enum to allow faster comparisons, add COMPILE_ASSERT on class size.
​https://bugs.webkit.org/show_bug.cgi?id=72924

Reviewed by Andreas Kling.

Note that the change from unsigned to unsigned char is to improve bit packing when using MSVC.

Covered by existing CSS tests.

• css/CSSValue.h:

(WebCore::CSSValue::isPrimitiveValue):
(WebCore::CSSValue::isValueList):
(WebCore::CSSValue::isImageGeneratorValue):
(WebCore::CSSValue::isTimingFunctionValue):
(WebCore::CSSValue::CSSValue):

9:14 PM Changeset in webkit [101118] by dslomov@google.com

• 19 edits
  1 delete in trunk

Source/WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=73054
[V8][Chromium] Add list of transferred ArrayBuffers to SerializedScriptValue::create.

Reviewed by David Levin.

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::serializedValueCallback):

• bindings/v8/OptionsObject.cpp:

• bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create):

• bindings/v8/SerializedScriptValue.h:
• bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):
(WebCore::getMessagePortArray):

• bindings/v8/V8Utilities.h:
• bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):

• bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::handlePostMessageCallback):

• bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

• bindings/v8/custom/V8MessageEventCustom.cpp:
• bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::handlePostMessageCallback):

• bindings/v8/custom/V8MessagePortCustom.h: Removed.
• bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::handlePostMessageCallback):

Source/WebKit/chromium: ​https://bugs.webkit.org/show_bug.cgi?id=73054
[V8][Chromium] Add list of transferred ArrayBuffers to SerializedScriptValue::create.

Reviewed by David Levin.

• src/WebSerializedScriptValue.cpp:

(WebKit::WebSerializedScriptValue::serialize):

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=73054
[V8][Chromium] Add list of transferred ArrayBuffers to SerializedScriptValue::create.
Tests rebaselined to reflect new error message.

Reviewed by David Levin.

• platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
• platform/chromium/fast/events/constructors/message-event-constructor-expected.txt:

7:24 PM Changeset in webkit [101117] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Cleanup #if usage in V8GCController
​https://bugs.webkit.org/show_bug.cgi?id=73060

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.

No tests needed. Just code cleanup

• bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::checkMemoryUsage):

6:45 PM Changeset in webkit [101116] by commit-queue@webkit.org

• 8 edits in trunk/Source/WebCore

Change CSSMutableStyleDeclaration::m_node to m_element (along with getter/setter)
​https://bugs.webkit.org/show_bug.cgi?id=73050

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.

No tests needed. This is just a refactor.

• css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::operator=):
(WebCore::CSSMutableStyleDeclaration::isInlineStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):

• css/CSSMutableStyleDeclaration.h:

(WebCore::CSSMutableStyleDeclaration::setElement):
(WebCore::CSSMutableStyleDeclaration::element):

• css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

• dom/StyledElement.cpp:

(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::createMappedDecl):

• html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedCellPaddingDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):

• inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::inlineStyleElement):

6:31 PM Changeset in webkit [101115] by commit-queue@webkit.org

• 12 edits in trunk/Source

Teach VideoLayerChromium how to render native texture (to support HW video decode).
​https://bugs.webkit.org/show_bug.cgi?id=73043

Patch by Ami Fischman <​fischman@chromium.org> on 2011-11-23
Reviewed by Kenneth Russell.

Source/WebCore:

No new tests. (depends on chromium support landing, and supporting HW being available)

• platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
(WebCore::LayerRendererChromium::videoLayerNativeTextureProgram):

• platform/graphics/chromium/LayerRendererChromium.h:
• platform/graphics/chromium/VideoFrameChromium.h:
• platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::pushPropertiesTo):
(WebCore::VideoLayerChromium::determineTextureFormat):

• platform/graphics/chromium/VideoLayerChromium.h:
• platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::setNativeTexture):
(WebCore::CCVideoLayerImpl::draw):
(WebCore::CCVideoLayerImpl::drawNativeTexture):

• platform/graphics/chromium/cc/CCVideoLayerImpl.h:

Source/WebKit/chromium:

• public/WebVideoFrame.h:
• src/VideoFrameChromiumImpl.cpp:

(WebKit::VideoFrameChromiumImpl::textureId):

• src/VideoFrameChromiumImpl.h:

6:29 PM Changeset in webkit [101114] by commit-queue@webkit.org

• 4 edits in trunk/LayoutTests

IndexedDB: Remove stylesheet links from layout tests
​https://bugs.webkit.org/show_bug.cgi?id=73053

Remove links to js-test-style.css that slipped in.

Patch by Joshua Bell <​jsbell@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.

• storage/indexeddb/cursor-key-order.html:
• storage/indexeddb/key-type-array.html:
• storage/indexeddb/mozilla/delete-result.html:

5:21 PM Changeset in webkit [101113] by abarth@webkit.org

• 9 edits
  2 deletes in trunk/Tools

Unreviewed, rolling out r101107.
​http://trac.webkit.org/changeset/101107
​https://bugs.webkit.org/show_bug.cgi?id=73062

Breaks the commit-queue (Requested by abarth on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-23

• Scripts/webkitpy/common/host.py:

(Host._engage_awesome_windows_hacks):

• Scripts/webkitpy/common/host_mock.py:

(MockHost.init):

• Scripts/webkitpy/common/system/environment.py: Removed.
• Scripts/webkitpy/common/system/environment_unittest.py: Removed.
• Scripts/webkitpy/common/system/executive.py:

(Executive._run_command_with_teed_output):
(Executive.run_and_throw_if_fail):

• Scripts/webkitpy/common/system/executive_mock.py:

(MockExecutive.run_and_throw_if_fail):
(MockExecutive.run_command):

• Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._driver_build_script_name):
(WebKitPort._run_script):
(WebKitPort._build_driver):

• Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(test_build_driver):

• Scripts/webkitpy/tool/commands/download_unittest.py:
• Scripts/webkitpy/tool/steps/build.py:

(Build.build):

5:15 PM Changeset in webkit [101112] by ojan@chromium.org

• 2 edits in trunk/Tools

Unreviewed, rolling out r101110.
​http://trac.webkit.org/changeset/101110
​https://bugs.webkit.org/show_bug.cgi?id=73057

The bots have now cycled and this patch is no longer needed.

• Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._upload_json_files):

4:25 PM Changeset in webkit [101111] by scheib@chromium.org

• 11 edits in trunk/Source

Pointer Lock: Plumb movement coordinates from PlatformMouseEvent to MouseEvents.
​https://bugs.webkit.org/show_bug.cgi?id=73031

Reviewed by Dimitri Glazkov.

Source/WebCore:

No tests for now, but this patch gets us closer to being able to write layout tests for pointer lock.

• dom/MouseEvent.cpp:

(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):
(WebCore::SimulatedMouseEvent::SimulatedMouseEvent):

• dom/MouseEvent.h:

(WebCore::MouseEvent::create):

• dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::MouseRelatedEvent):

• dom/MouseRelatedEvent.h:
• dom/TouchEvent.cpp:

(WebCore::TouchEvent::TouchEvent):

• dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):

• page/EventHandler.cpp:

(WebCore::EventHandler::dispatchDragEvent):

• platform/PlatformMouseEvent.h:

(WebCore::PlatformMouseEvent::movementX):
(WebCore::PlatformMouseEvent::movementY):

Source/WebKit/chromium:

• src/WebInputEventConversion.cpp:

(WebKit::PlatformMouseEventBuilder::PlatformMouseEventBuilder):

4:16 PM Changeset in webkit [101110] by ojan@chromium.org

• 2 edits in trunk/Tools

Temporarily save the incremental results json in order to identify bug
​https://bugs.webkit.org/show_bug.cgi?id=73057

Reviewed by Dean Jackson.

The test results server needed to be rolled back from tip of tree
due to a JSON merging bug. It's hard to identify what the bug is without
the raw data.

• Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._upload_json_files):

4:04 PM Changeset in webkit [101109] by ojan@chromium.org

• 3 edits in trunk/Tools

Merging two version 4 results hits an error in the test results server
​https://bugs.webkit.org/show_bug.cgi?id=73042

Reviewed by Adam Barth.

The old code assumed that if the aggregate results value was not a leaf
value that the incremental results would exist, which is just totally
wrong. Added a test for that case as well.

• TestResultServer/model/jsonresults.py:

(JsonResults._merge_tests):

• TestResultServer/model/jsonresults_unittest.py:

(JsonResultsTest.test_merge_build_directory_hierarchy_old_version):
(JsonResultsTest.test_merge_build_directory_hierarchy):

3:34 PM Changeset in webkit [101108] by thakis@chromium.org

• 2 edits in trunk/Source/WebCore

Remove one static initializer (for kTickTime)
​https://bugs.webkit.org/show_bug.cgi?id=73049

Reviewed by Adam Barth.

• platform/ScrollAnimatorNone.cpp:

3:23 PM Changeset in webkit [101107] by eric@webkit.org

• 9 edits
  2 copies in trunk/Tools

Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
​https://bugs.webkit.org/show_bug.cgi?id=71983

Reviewed by Adam Barth.

We'll add more code to Environment overtime,
allowing us to mock out more of our direct interactions with os.environ.

This patch also makes run_command print the passed in environment.

• Scripts/webkitpy/common/host_mock.py:
• Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
• Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
• Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
• Scripts/webkitpy/common/system/executive.py:
• Scripts/webkitpy/common/system/executive_mock.py:
• Scripts/webkitpy/layout_tests/port/webkit.py:
• Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
• Scripts/webkitpy/tool/commands/download_unittest.py:
• Scripts/webkitpy/tool/steps/build.py:

3:11 PM Changeset in webkit [101106] by adamk@chromium.org

• 2 edits
  8 moves
  37 adds
  12 deletes in trunk/LayoutTests

More Chromium rebaselines for r101062. Unreviewed gardening.

• platform/chromium-cg-mac-leopard/svg/custom/pointer-events-image-css-transform-expected.png: Added.
• platform/chromium-cg-mac-leopard/svg/custom/pointer-events-text-css-transform-expected.png: Added.
• platform/chromium-cg-mac-leopard/svg/dom/css-transforms-expected.png: Added.
• platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
• platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
• platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
• platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
• platform/chromium-cg-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png: Added.
• platform/chromium-cg-mac-snowleopard/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
• platform/chromium-cg-mac-snowleopard/svg/transforms/svg-css-transforms-expected.png: Added.
• platform/chromium-linux/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
• platform/chromium-linux/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
• platform/chromium-linux/svg/custom/pointer-events-image-css-transform-expected.txt: Removed.
• platform/chromium-linux/svg/custom/pointer-events-text-css-transform-expected.txt: Removed.
• platform/chromium-linux/svg/dom/css-transforms-expected.png: Added.
• platform/chromium-linux/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
• platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
• platform/chromium-linux/svg/transforms/svg-css-transforms-clip-path-expected.txt: Removed.
• platform/chromium-linux/svg/transforms/svg-css-transforms-expected.txt: Removed.
• platform/chromium-mac-leopard/svg/custom/pointer-events-image-css-transform-expected.png: Added.
• platform/chromium-mac-leopard/svg/custom/pointer-events-text-css-transform-expected.png: Added.
• platform/chromium-mac-leopard/svg/dom/css-transforms-expected.png: Added.
• platform/chromium-mac-leopard/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
• platform/chromium-mac-leopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/custom/pointer-events-text-css-transform-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/dom/css-transforms-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/transforms/svg-css-transforms-expected.png: Added.
• platform/chromium-win-vista/svg/custom/pointer-events-image-css-transform-expected.txt: Removed.
• platform/chromium-win-vista/svg/custom/pointer-events-text-css-transform-expected.txt: Removed.
• platform/chromium-win-vista/svg/transforms/svg-css-transforms-clip-path-expected.txt: Removed.
• platform/chromium-win-vista/svg/transforms/svg-css-transforms-expected.txt: Removed.
• platform/chromium-win-xp/svg/custom/pointer-events-image-css-transform-expected.txt: Removed.
• platform/chromium-win-xp/svg/custom/pointer-events-text-css-transform-expected.txt: Removed.
• platform/chromium-win-xp/svg/transforms/svg-css-transforms-clip-path-expected.txt: Removed.
• platform/chromium-win-xp/svg/transforms/svg-css-transforms-expected.txt: Removed.
• platform/chromium-win/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
• platform/chromium-win/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
• platform/chromium-win/svg/custom/pointer-events-image-css-transform-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/svg/custom/pointer-events-image-css-transform-expected.png.
• platform/chromium-win/svg/custom/pointer-events-image-css-transform-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/svg/custom/pointer-events-image-css-transform-expected.txt.
• platform/chromium-win/svg/custom/pointer-events-text-css-transform-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/svg/custom/pointer-events-text-css-transform-expected.png.
• platform/chromium-win/svg/custom/pointer-events-text-css-transform-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/svg/custom/pointer-events-text-css-transform-expected.txt.
• platform/chromium-win/svg/dom/css-transforms-expected.png: Added.
• platform/chromium-win/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
• platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
• platform/chromium-win/svg/transforms/svg-css-transforms-clip-path-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/svg/transforms/svg-css-transforms-clip-path-expected.png.
• platform/chromium-win/svg/transforms/svg-css-transforms-clip-path-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/svg/transforms/svg-css-transforms-clip-path-expected.txt.
• platform/chromium-win/svg/transforms/svg-css-transforms-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/svg/transforms/svg-css-transforms-expected.png.
• platform/chromium-win/svg/transforms/svg-css-transforms-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/svg/transforms/svg-css-transforms-expected.txt.
• platform/chromium/test_expectations.txt:

3:04 PM Changeset in webkit [101105] by reed@google.com

• 2 edits in trunk/LayoutTests

[skia] need to rebaseline after SK_ENABLE_FAST_SHADERMASK is enabled in skia/skia.gyp
​https://bugs.webkit.org/show_bug.cgi?id=73044

unreviewed, expectations update

• platform/chromium/test_expectations.txt:

2:48 PM Changeset in webkit [101104] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

[chromium] Drop root layer tiles on platforms that cache the front buffer
​https://bugs.webkit.org/show_bug.cgi?id=72956

Patch by Jonathan Backer <​backer@chromium.org> on 2011-11-23
Reviewed by Kenneth Russell.

• platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

• platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):

• platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

2:03 PM Changeset in webkit [101103] by jesus@webkit.org

• 4 edits
  1 move
  1 delete in trunk/Source/WebKit2

[Qt][WK2] Move QQuickWebView::downloadRequested signal into experimental
​https://bugs.webkit.org/show_bug.cgi?id=72914

Reviewed by Andreas Kling.

Make the signal downloadRequested an experimental API from QQuickWebView
and modify the qml test to use a WebView instead of a DesktopWebView.

• UIProcess/API/qt/qquickwebview_p.h:
• UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_download.qml.
• UIProcess/API/qt/tests/qmltests/common/download.html: Removed.
• UIProcess/API/qt/tests/qmltests/qmltests.pro:
• UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::didReceiveDownloadResponse):

2:03 PM Changeset in webkit [101102] by arv@chromium.org

• 12 edits in trunk/Source/WebCore

Binding CodeGenerators don't support Conditional= on constants
​https://bugs.webkit.org/show_bug.cgi?id=67666

Reviewed by Adam Barth.

Adds support for [Conditional=LABEL] to const IDL fields.

• bindings/scripts/CodeGenerator.pm:

(GenerateConditionalStringFromAttributeValue): Moved out of CodeGenerator{CPP,JS,V8}.pm.
(GenerateCompileTimeCheckForEnumsIfNeeded): Wrap in conditional #if.

• bindings/scripts/CodeGeneratorCPP.pm:

(GenerateConditionalString):
(GenerateHeader): Ditto.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateConditionalString):
(GenerateHeader): Ditto.
(GenerateImplementation): Ditto.
(GenerateHashTable):
(WriteData):

• bindings/scripts/CodeGeneratorObjC.pm:

(GenerateHeader): Ditto.

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateConditionalString): Ditto.
(GenerateImplementation):
(WriteData):

• bindings/scripts/test/CPP/WebDOMTestObj.h: Generated code now wraps conditional const in #if.
• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjCONDITIONAL_CONST): Ditto

• bindings/scripts/test/JS/JSTestObj.h: Ditto
• bindings/scripts/test/ObjC/DOMTestObj.h: Ditto
• bindings/scripts/test/TestObj.idl: Added a conditional const.
• bindings/scripts/test/V8/V8TestObj.cpp: Generated code now wraps conditional const in #if.

1:40 PM Changeset in webkit [101101] by commit-queue@webkit.org

• 8 edits in trunk

[MutationObservers] Modifications to the style property don't dispatch "attributes" Mutation Records
​https://bugs.webkit.org/show_bug.cgi?id=70137

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-11-23
Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch adds a private AttributesMutationScope mechanism to CSSMutableStyleDeclaration (which uses
the RAII pattern similar to the public ChildListMutationScope). This manages the (sometimes conditional)
pre-change serialization of the style attribute (if an observer has requested oldValue), creation of
the mutation record, and dispatch if the declaration was actual affected.

• css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::removeProperty):
(WebCore::CSSMutableStyleDeclaration::setProperty):
(WebCore::CSSMutableStyleDeclaration::setPropertyInternal):
(WebCore::CSSMutableStyleDeclaration::parseDeclaration):
(WebCore::CSSMutableStyleDeclaration::addParsedProperties):
(WebCore::CSSMutableStyleDeclaration::addParsedProperty):
(WebCore::CSSMutableStyleDeclaration::setCssText):
(WebCore::CSSMutableStyleDeclaration::merge):
(WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):

• dom/Element.cpp:

(WebCore::Element::setAttribute):

LayoutTests:

Added tests asserting that changes to the style property are observable and work correctly if oldValue is requested.

• fast/mutation/observe-attributes-expected.txt:
• fast/mutation/observe-attributes.html:

12:18 PM Changeset in webkit [101100] by staikos@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Remove BlackBerry OS support from RandomNumberSeed, making QNX=UNIX.
​https://bugs.webkit.org/show_bug.cgi?id=73028

Reviewed by Daniel Bates.

• wtf/RandomNumberSeed.h:

(WTF::initializeRandomNumberGenerator):

11:58 AM Changeset in webkit [101099] by dslomov@google.com

• 3 edits in trunk/Source/WebCore

Unreviewed, rebaseline binding tests after ​http://trac.webkit.org/changeset/101064.

• bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore::toFloat64Array):

• bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::wrapSlow):

11:40 AM Changeset in webkit [101098] by adamk@chromium.org

• 1 edit
  1 delete in trunk/LayoutTests

Rebaseline Chromium after r101056. Unreviewed gardening.

• platform/chromium-linux/svg/dom/length-list-parser-expected.txt: Removed.

11:33 AM Changeset in webkit [101097] by eae@chromium.org

• 1 edit in branches/subpixellayout/Source/WebCore/css/CSSPrimitiveValue.cpp

Initialize Lengths from float css values as opposed to the rounded int values.

11:30 AM Changeset in webkit [101096] by adamk@chromium.org

• 1 edit
  26 adds in trunk/LayoutTests

Chromium rebaselines after r101062. Unreviewed gardening.

• platform/chromium-linux-x86/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
• platform/chromium-linux-x86/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
• platform/chromium-linux-x86/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
• platform/chromium-linux-x86/svg/transforms/svg-css-transforms-expected.txt: Added.
• platform/chromium-linux/svg/custom/pointer-events-image-css-transform-expected.png: Added.
• platform/chromium-linux/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
• platform/chromium-linux/svg/custom/pointer-events-text-css-transform-expected.png: Added.
• platform/chromium-linux/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
• platform/chromium-linux/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
• platform/chromium-linux/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
• platform/chromium-linux/svg/transforms/svg-css-transforms-expected.png: Added.
• platform/chromium-linux/svg/transforms/svg-css-transforms-expected.txt: Added.
• platform/chromium-win-vista/svg/custom/pointer-events-image-css-transform-expected.png: Added.
• platform/chromium-win-vista/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
• platform/chromium-win-vista/svg/custom/pointer-events-text-css-transform-expected.png: Added.
• platform/chromium-win-vista/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
• platform/chromium-win-vista/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
• platform/chromium-win-vista/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
• platform/chromium-win-vista/svg/transforms/svg-css-transforms-expected.png: Added.
• platform/chromium-win-vista/svg/transforms/svg-css-transforms-expected.txt: Added.
• platform/chromium-win-xp/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
• platform/chromium-win-xp/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
• platform/chromium-win-xp/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
• platform/chromium-win-xp/svg/transforms/svg-css-transforms-expected.txt: Added.

11:18 AM Changeset in webkit [101095] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

Last rebaseline (really this time) for video-zoom-controls.html.

Unreviewed gardening.

• platform/chromium-gpu-cg-mac/media/video-zoom-controls-expected.png: Copied by hand from bot's zip file.

11:04 AM Changeset in webkit [101094] by commit-queue@webkit.org

• 11 edits
  2 deletes in trunk

Unreviewed, rolling out r101069.
​http://trac.webkit.org/changeset/101069
​https://bugs.webkit.org/show_bug.cgi?id=73032

New test always times out (Requested by aklein on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-23

Source/WebCore:

• inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.get executionLineLocation):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):

LayoutTests:

• http/tests/inspector/compiler-source-mapping-debug-expected.txt: Removed.
• http/tests/inspector/compiler-source-mapping-debug.html: Removed.
• http/tests/inspector/resources/source-map.json:
• http/tests/inspector/resources/source1.js:

(window.onload):

• http/tests/inspector/resources/source2.js:

(ClickHandler.prototype.handle):

• platform/gtk/Skipped:
• platform/mac/Skipped:
• platform/qt/Skipped:
• platform/win/Skipped:
• platform/wincairo/Skipped:

10:51 AM Changeset in webkit [101093] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] Crash in webkit::npapi::PluginInstance::NPP_SetWindow
​https://bugs.webkit.org/show_bug.cgi?id=72271

Unreviewed gardening.

• platform/chromium/test_expectations.txt: Mark fast/dom/node-iterator-reference-node-moved-crash.html as flaky

10:41 AM Changeset in webkit [101092] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

Layout Test http/tests/loading/307-after-303-after-post.html is flaky on cr-mac
​https://bugs.webkit.org/show_bug.cgi?id=73030

Unreviewed gardening.

• platform/chromium/test_expectations.txt:

10:33 AM Changeset in webkit [101091] by Antti Koivisto

• 3 edits
  2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=72354
Image pointer in FillLayer not cleared correctly

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/css/fill-layer-crash.html

We should clear the image pointer too, not just the m_imageSet bit.

• rendering/style/FillLayer.h:

(WebCore::FillLayer::clearImage):

LayoutTests:

• fast/css/fill-layer-crash-expected.txt: Added.
• fast/css/fill-layer-crash.html: Added.

10:29 AM Changeset in webkit [101090] by reed@google.com

• 2 edits in trunk/LayoutTests

[skia] need rebaselining after skia rev. 2735 lands
​https://bugs.webkit.org/show_bug.cgi?id=73023

unreviewed, expectations update

• platform/chromium/test_expectations.txt:

10:19 AM Changeset in webkit [101089] by vestbo@webkit.org

• 6 edits
  1 move in trunk

[Qt] Re-generate QtWebKit API forwarding headers when API changes

The forwarding headers are generated by syncqt, and syncqt is run by qmake,
so we need sync.profile to live in the same directory as the project file
that will be touched when adding/removing API (api.pri in our case).

Since the WebKit2 APIs live in a separate static library, we have to
add the project file for WebKit2 as a dependency of the api.pri file
as well, so that any changes to the WebKit2 API will still trigger a
run of qmake (and then syncqt).

Lastly, we use the new QMAKE_SYNCQT_OUTDIR variable in Qt 5 to ensure
that the forwarding headers are still generated in the root build dir,
not in the Source dir along with the internal forwarding headers.

Reviewed by Andreas Kling.

10:12 AM Changeset in webkit [101088] by commit-queue@webkit.org

• 19 edits in trunk

Unreviewed, rolling out r101057.
​http://trac.webkit.org/changeset/101057
​https://bugs.webkit.org/show_bug.cgi?id=73027

Broke Chromium Windows build (Requested by aklein on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-23

Source/WebCore:

• html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::HTMLTrackElement):
(WebCore::HTMLTrackElement::didCompleteLoad):
(WebCore::HTMLTrackElement::textTrackReadyStateChanged):

• html/HTMLTrackElement.h:
• html/HTMLTrackElement.idl:
• html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::loadTimerFired):
(WebCore::LoadableTextTrack::cueLoadingStarted):
(WebCore::LoadableTextTrack::cueLoadingCompleted):

• html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::setReadyState):

• html/TextTrack.h:

(WebCore::TextTrack::readyState):

• html/TextTrack.idl:

LayoutTests:

• media/track/track-add-track-expected.txt:
• media/track/track-add-track.html:
• media/track/track-constants-expected.txt:
• media/track/track-constants.html:
• media/track/track-load-error-readyState-expected.txt:
• media/track/track-load-error-readyState.html:
• media/track/track-load-from-element-readyState-expected.txt:
• media/track/track-load-from-element-readyState.html:
• media/track/track-load-from-src-readyState-expected.txt:
• media/track/track-load-from-src-readyState.html:

9:49 AM Changeset in webkit [101087] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Missing WEBKIT_EXPORT in WebMediaStreamRegistry
​https://bugs.webkit.org/show_bug.cgi?id=73010

Patch by Tommy Widenflycht <​tommyw@google.com> on 2011-11-23
Reviewed by Darin Fisher.

• public/WebMediaStreamRegistry.h:

8:52 AM Changeset in webkit [101086] by caio.oliveira@openbossa.org

• 7 edits
  1 move in trunk/Source/WebKit2

[Qt] [WK2] Expose onNavigationRequested signal instead of expecting a slot be defined from QML
​https://bugs.webkit.org/show_bug.cgi?id=72976

Reviewed by Tor Arne Vestbø.

Expecting slots/methods to be implemented in QML isn't very idiomatic in
comparison with the alternative of having a signal. So we now use a signal
for handling navigation requests, and expose a 'request' object with relevant
metadata. There's also a settable property 'action' used to indicate whether
the navigation should be ignored or trigger a download.

The pattern signal with an object parameter that can keep the reply is common in QML,
and used for example for mouse signals.

• UIProcess/API/qt/qquickwebview.cpp:
• UIProcess/API/qt/qquickwebview_p.h:
• UIProcess/API/qt/qquickwebview_p_p.h:
• UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationPolicyForUrl.qml.
• UIProcess/API/qt/tests/qmltests/qmltests.pro:
• UIProcess/qt/QtWebPagePolicyClient.cpp:

(NavigationRequest::NavigationRequest):
(NavigationRequest::url):
(NavigationRequest::button):
(NavigationRequest::modifiers):
(NavigationRequest::action):
(NavigationRequest::setAction):
(QtWebPagePolicyClient::decidePolicyForNavigationAction):

• UIProcess/qt/QtWebPagePolicyClient.h:

8:04 AM Changeset in webkit [101085] by yurys@chromium.org

• 5 edits in trunk/Source/WebCore

2011-11-23 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Build fix. Added missing ENABLE(WORKERS) guards.

• inspector/WorkerConsoleAgent.cpp:
• inspector/WorkerConsoleAgent.h:
• inspector/WorkerRuntimeAgent.cpp:
• inspector/WorkerRuntimeAgent.h:

7:53 AM Changeset in webkit [101084] by Philippe Normand

• 2 edits in trunk/LayoutTests

Unreviewed, skip another svg test on GTK showing signed zero issues.

• platform/gtk/Skipped: Skip svg/dom/css-transforms.xhtml.

7:36 AM Changeset in webkit [101083] by Philippe Normand

• 4 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r101060.

• platform/gtk/fast/dom/Window/window-properties-expected.txt:
• platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
• platform/gtk/fast/js/global-constructors-expected.txt:

7:33 AM Changeset in webkit [101082] by Philippe Normand

• 3 edits in trunk/Source/WebCore

[GStreamer] improper usage of gst_object_ref_sink
​https://bugs.webkit.org/show_bug.cgi?id=73014

Reviewed by Martin Robinson.

No new tests. Existing tests cover this already.

• platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef): Ensure this is called with non-floating GstObjects.
(WTF::GstElement): Replace gst_object_ref_sink with
gst_object_ref+gst_object_sink like advised in the GstObject documentation.
(WTF::GstPad): Ditto.

• platform/graphics/gstreamer/GRefPtrGStreamer.h:

7:28 AM Changeset in webkit [101081] by yurys@chromium.org

• 18 edits
  8 copies in trunk/Source/WebCore

Web Inspector: split console agent into worker and page console agents
​https://bugs.webkit.org/show_bug.cgi?id=73019

InspectorConsoleAgent now has two descendants: WorkerConsoleAgent and PageConsoleAgent
which encapsulate functionality specific for the type of inspected instance.

Reviewed by Pavel Feldman.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::clearMessages):
(WebCore::InspectorConsoleAgent::addMessageToConsole):
(WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):
(WebCore::InspectorConsoleAgent::addConsoleMessage):

• inspector/InspectorConsoleAgent.h:
• inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

• inspector/InspectorStyleTextEditor.cpp:
• inspector/InspectorStyleTextEditor.h:
• inspector/PageConsoleAgent.cpp: Copied from Source/WebCore/inspector/PageDebuggerAgent.cpp.

(WebCore::PageConsoleAgent::PageConsoleAgent):
(WebCore::PageConsoleAgent::~PageConsoleAgent):
(WebCore::PageConsoleAgent::clearMessages):
(WebCore::PageConsoleAgent::addInspectedNode):
(WebCore::PageConsoleAgent::developerExtrasEnabled):

• inspector/PageConsoleAgent.h: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.
• inspector/PageDebuggerAgent.cpp:
• inspector/PageDebuggerAgent.h:
• inspector/PageRuntimeAgent.cpp: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.

(WebCore::PageRuntimeAgent::PageRuntimeAgent): PageRuntimeAgent was moved into its own file.
(WebCore::PageRuntimeAgent::~PageRuntimeAgent):
(WebCore::PageRuntimeAgent::scriptStateForFrameId):
(WebCore::PageRuntimeAgent::getDefaultInspectedState):

• inspector/PageRuntimeAgent.h: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.
• inspector/WorkerConsoleAgent.cpp: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.

(WebCore::WorkerConsoleAgent::WorkerConsoleAgent):
(WebCore::WorkerConsoleAgent::~WorkerConsoleAgent):
(WebCore::WorkerConsoleAgent::addInspectedNode):
(WebCore::WorkerConsoleAgent::developerExtrasEnabled):

• inspector/WorkerConsoleAgent.h: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.
• inspector/WorkerDebuggerAgent.cpp:
• inspector/WorkerDebuggerAgent.h:
• inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

• inspector/WorkerInspectorController.h:
• inspector/WorkerRuntimeAgent.cpp: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.

(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent): WorkerRuntimeAgent was moved into its own file.
(WebCore::WorkerRuntimeAgent::~WorkerRuntimeAgent):
(WebCore::WorkerRuntimeAgent::scriptStateForFrameId):
(WebCore::WorkerRuntimeAgent::getDefaultInspectedState):

• inspector/WorkerRuntimeAgent.h: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.

6:34 AM Changeset in webkit [101080] by apavlov@chromium.org

• 5 edits in trunk/Source/WebCore

Web Inspector: warning icon for unrecognized style rule should have tooltip
​https://bugs.webkit.org/show_bug.cgi?id=50638

Reviewed by Yury Semikhatsky.

• English.lproj/localizedStrings.js: Add new tooltip strings.
• inspector/front-end/CSSCompletions.js:

(WebInspector.CSSCompletions.prototype.keySet): Added.

• inspector/front-end/StylesSidebarPane.js: Create a separate IMG element for an exclamation mark.
• inspector/front-end/elementsPanel.css:

(.styles-section .properties li.not-parsed-ok img.exclamation-mark):

6:25 AM Changeset in webkit [101079] by commit-queue@webkit.org

• 4 edits in trunk

[EFL] Add zlib depend when freetype is used.
​https://bugs.webkit.org/show_bug.cgi?id=66365

Unreviewed build fix.

When freetype is enabled, uncompress() function is used by
WOFFFileFormat.cpp. Since zlib is not required by freetype, we need to
add libz as dependency for fix linking issue.

.:

Patch by Halton Huo <​halton.huo@intel.com> on 2011-11-23

• Source/cmake/OptionsEfl.cmake: search for ZLIB

Source/WebCore:

No new test because this change is only to fix linking issue.

Patch by Halton Huo <​halton.huo@intel.com> on 2011-11-23

• PlatformEfl.cmake: add ZLIB as dependency when using freetype

6:23 AM Changeset in webkit [101078] by mihnea@adobe.com

• 10 edits
  3 adds in trunk

CSS Exclusions: parse the shorthand "wrap" property
​https://bugs.webkit.org/show_bug.cgi?id=71905

Reviewed by Dean Jackson.

Source/WebCore:

Test: fast/exclusions/wrap-parsing.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

• css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::getPropertyValue):

• css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

• css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

• css/CSSPropertyLonghand.cpp:

(WebCore::initShorthandMap):

• css/CSSPropertyNames.in:
• css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

• css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

• fast/exclusions/script-tests/wrap-parsing.js: Added.
• fast/exclusions/wrap-parsing-expected.txt: Added.
• fast/exclusions/wrap-parsing.html: Added.

6:14 AM Changeset in webkit [101077] by Alexandru Chiculita

• 4 edits
  3 adds in trunk

[CSS Filters] WebKit crashes when changing the filter
​https://bugs.webkit.org/show_bug.cgi?id=72723

Reviewed by Simon Fraser.

Source/WebCore:

There are three things fixed with this patch:

1. The list of effects wasn't cleared when the FilterOperations were changed.
2. The sourceImage was going to be 0, because the m_sourceGraphicBuffer.release()

was also clearing the reference to m_sourceGraphicBuffer. Next time the build() method
was called m_graphicsBufferAttached was set to false, but the m_sourceGraphicBuffer was
not regenerated, because the size was not invalidated.

3. maxEffectRects were not updated when a new list of effects was built.

Test: css3/filters/crash-filter-change.html

• rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::prepare):

• rendering/FilterEffectRenderer.h:

(WebCore::FilterEffectRenderer::setSourceImageRect):

LayoutTests:

• css3/filters/crash-filter-change-expected.png: Added.
• css3/filters/crash-filter-change-expected.txt: Added.
• css3/filters/crash-filter-change.html: Added.

6:12 AM Changeset in webkit [101076] by jnd@chromium.org

• 4 edits in trunk

Set right default value to baseURL in LayoutTestController::queueLoadHTMLString.
​https://bugs.webkit.org/show_bug.cgi?id=72950

Reviewed by Tony Chang.

Tools:

• DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::queueLoadHTMLString):

LayoutTests:

• platform/chromium/test_expectations.txt:

6:09 AM Changeset in webkit [101075] by caryclark@google.com

• 2 edits
  2 deletes in trunk/LayoutTests

Unreviewed rebaselining: update incorrectly generated baseline images
that masked ​http://crbug.com/105025 ('Regression: WebGL content flipped
with use_skia enabled on mac.')

Marking these tests as expected to fail until we fix the underlying bug.

• platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-expected.png: Removed.
• platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Removed.
• platform/chromium/test_expectations.txt:

5:58 AM Changeset in webkit [101074] by abarth@webkit.org

• 4 edits in trunk/Tools

garden-o-matic should display a message if it can't find results to display
​https://bugs.webkit.org/show_bug.cgi?id=72991

Reviewed by Dimitri Glazkov.

Not all failures (e.g., TIMEOUT) have results that we can display.
This patch adds a short message so that the user can see that we're
done trying to load the results.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:

5:45 AM Changeset in webkit [101073] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Skia] fix duplicate symbol ZN7WebCore11BitmapImage16initPlatformDataEv error
​https://bugs.webkit.org/show_bug.cgi?id=72954

Patch by Elliot Poger <​epoger@google.com> on 2011-11-23
Reviewed by Adam Barth.

• WebCore.gyp/WebCore.gyp:

5:38 AM Changeset in webkit [101072] by abarth@webkit.org

• 5 edits in trunk/Tools

garden-o-matic should explain more clearly what the builder lists at the top of the page mean
​https://bugs.webkit.org/show_bug.cgi?id=72992

Reviewed by Dimitri Glazkov.

This patch also prepares us to list other sorts of failures, like
performance and unit test.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:

5:20 AM Changeset in webkit [101071] by caio.oliveira@openbossa.org

• 9 edits
  1 move
  1 add in trunk/Source/WebKit2

[Qt] [WK2] Move PagePolicyClient related code to QtWebPagePolicyClient
​https://bugs.webkit.org/show_bug.cgi?id=72959

Reviewed by Andreas Kling.

Split PagePolicyClient related code from QtWebPageProxy/ClientImpl. The new
QtWebPagePolicyClient registers itself with WKPageRef and it's owned by the
QQuickWebViewPrivate. This is a move to clean up QtWebPageProxy object.

QtPolicyInterface abstraction was not helping us as much as the separation of
the client code will. It was more useful when we had multiple WebViews.

• Target.pri:
• UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(toPolicyAction):
(QQuickWebViewPrivate::navigationPolicyForURL):

• UIProcess/API/qt/qquickwebview_p.h:
• UIProcess/API/qt/qquickwebview_p_p.h:
• UIProcess/qt/ClientImpl.cpp:
• UIProcess/qt/ClientImpl.h:
• UIProcess/qt/QtWebPagePolicyClient.cpp: Added.

(QtWebPagePolicyClient::QtWebPagePolicyClient):
(QtWebPagePolicyClient::decidePolicyForNavigationAction):
(toQtWebPagePolicyClient):
(toQtMouseButton):
(toQtKeyboardModifiers):
(QtWebPagePolicyClient::decidePolicyForResponse):

• UIProcess/qt/QtWebPagePolicyClient.h: Renamed from Source/WebKit2/UIProcess/qt/QtPolicyInterface.h.
• UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::init):

• UIProcess/qt/QtWebPageProxy.h:

5:15 AM Changeset in webkit [101070] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Add new Chromium tests to the flakiness dashboard
​https://bugs.webkit.org/show_bug.cgi?id=72997

Patch by Ryan Sleevi <​rsleevi@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.

• TestResultServer/static-dashboards/dashboard_base.js:

():

5:10 AM Changeset in webkit [101069] by podivilov@chromium.org

• 11 edits
  2 adds in trunk

Web Inspector: add integration test for compiler source maps.
​https://bugs.webkit.org/show_bug.cgi?id=72730

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/compiler-source-mapping-debug.html

• inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.setCompilerSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.get executionLineLocation):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):

LayoutTests:

• http/tests/inspector/compiler-source-mapping-debug-expected.txt: Added.
• http/tests/inspector/compiler-source-mapping-debug.html: Added.
• http/tests/inspector/resources/source-map.json:
• http/tests/inspector/resources/source1.js:
• http/tests/inspector/resources/source2.js:

(ClickHandler.prototype.handle):

5:03 AM Changeset in webkit [101068] by abarth@webkit.org

• 3 edits in trunk/Tools

garden-o-matic should support AUDIO failures
​https://bugs.webkit.org/show_bug.cgi?id=69477

Reviewed by Dimitri Glazkov.

This is a first iteration at supporting AUDIO failures in
garden-o-matic. We'll probably need to iterate a bit when we have a
real audio failure in the tree to play with. For example, we'll
probably want to add and <audio> element to the "Examine" view to hear
the differences, but that all can be done in a subsequent patch.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:

4:48 AM Changeset in webkit [101067] by Martin Robinson

• 2 edits in trunk/Source/WebCore

Build fix for GTK+.

• platform/graphics/gtk/DrawingBufferGtk.cpp:

(WebCore::DrawingBuffer::DrawingBuffer): Update signature and ASSERT
for the GTK+ port.

4:19 AM Changeset in webkit [101066] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebCore

Remove notifyChange from the public interface of CSSMutableStyleDeclaration
​https://bugs.webkit.org/show_bug.cgi?id=72660

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.

No tests needed. This is only a refactor.

• css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::addParsedProperty):

• css/CSSMutableStyleDeclaration.h:

(WebCore::CSSMutableStyleDeclaration::setProperty):
(WebCore::CSSMutableStyleDeclaration::removeProperty):
(WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):

• css/CSSStyleSelector.cpp:

(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):

• editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):

• html/HTMLElement.cpp:

(WebCore::HTMLElement::setContentEditable):

4:16 AM Changeset in webkit [101065] by commit-queue@webkit.org

• 13 edits
  6 adds in trunk

Adding gamepad support
​https://bugs.webkit.org/show_bug.cgi?id=69451

Source/WebCore:

Patch by Scott Graham <​scottmg@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.

Plumb gamepad data access through platform.

Test: gamepad/gamepad-polling-access.html

• WebCore.gypi:
• page/Navigator.cpp:

(WebCore::Navigator::webkitGamepads):

• page/Navigator.h:
• platform/Gamepads.h: Added.
• platform/chromium/GamepadsChromium.cpp: Added.

(WebCore::sampleGamepads):

• platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

Add implementation of sampleGamepads in Chromium platform. Retrieves
gamepad data from Chromium port and converts to DOM format, i.e.
GamepadList.

Patch by Scott Graham <​scottmg@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.

• src/PlatformSupport.cpp:

(WebCore::PlatformSupport::sampleGamepads):

Tools:

Patch by Scott Graham <​scottmg@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.

Add a 'gamepadController' to Chromium DRT. Allows for setting of mock
gamepad data that will be retrieved when JS code pulls via API access.

• DumpRenderTree/DumpRenderTree.gypi:
• DumpRenderTree/chromium/GamepadController.cpp: Added.

(GamepadController::GamepadController):
(GamepadController::bindToJavascript):
(GamepadController::reset):
(GamepadController::connect):
(GamepadController::disconnect):
(GamepadController::setId):
(GamepadController::setButtonCount):
(GamepadController::setButtonData):
(GamepadController::setAxisCount):
(GamepadController::setAxisData):
(GamepadController::fallbackCallback):

• DumpRenderTree/chromium/GamepadController.h: Added.
• DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):

• DumpRenderTree/chromium/TestShell.h:

(TestShell::gamepadController):

LayoutTests:

Patch by Scott Graham <​scottmg@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.

• fast/dom/script-tests/prototype-inheritance.js: Exclude

gamepadController from enumeration.

• gamepad/gamepad-polling-access-expected.txt: Added.
• gamepad/gamepad-polling-access.html: Added.

4:06 AM Changeset in webkit [101064] by dslomov@google.com

• 19 edits in trunk/Source

Source/WebCore: Get rid of WebCore dependencies from TypedArray implementation types
​https://bugs.webkit.org/show_bug.cgi?id=72783

Reviewed by David Levin.

Remove WebCore specific logic for neutering Typed Array implementations.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

• bindings/scripts/CodeGeneratorV8.pm:
• html/canvas/ArrayBuffer.cpp:

(WTF::ArrayBuffer::transfer):

• html/canvas/ArrayBuffer.h:
• html/canvas/ArrayBufferView.cpp:

(WTF::ArrayBufferView::neuter):

• html/canvas/ArrayBufferView.h:
• html/canvas/DataView.cpp:

(WebCore::DataView::neuter):

• html/canvas/DataView.h:
• html/canvas/Float32Array.h:
• html/canvas/Float64Array.h:
• html/canvas/Int16Array.h:
• html/canvas/Int32Array.h:
• html/canvas/Int8Array.h:
• html/canvas/Uint16Array.h:
• html/canvas/Uint32Array.h:
• html/canvas/Uint8Array.h:

Source/WebKit/chromium: Get rid of WebCore dependencies from TypedArray implementation types
​https://bugs.webkit.org/show_bug.cgi?id=72783
Reviewed by David Levin.

• src/WebArrayBufferView.cpp: WebCore replaced with WTF

3:55 AM Changeset in webkit [101063] by Nikolas Zimmermann

• 1 edit
  1 delete in trunk/LayoutTests

2011-11-23 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Rebaseline win results after r101052.

Win/Mac share the same results now, I suspect the same will hold true for gtk/qt/cr.

• platform/win/svg/dom: Removed.
• platform/win/svg/dom/length-list-parser-expected.txt: Removed.

3:34 AM Changeset in webkit [101062] by commit-queue@webkit.org

• 6 edits
  38 adds in trunk

First step towards ​http://webkit.org/b/70025

Allow -webkit-transform to be have effect to SVG elements.
Currently, the CSS transform takes precedence over the SVG transform attribute

Allow SVG elements to be transformed using webkit-transform
​https://bugs.webkit.org/show_bug.cgi?id=71309

Patch by Raul Hudea <​rhudea@adobe.com> on 2011-11-23
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Tests: svg/clip-path/clip-path-css-transform-1.svg

svg/clip-path/clip-path-css-transform-2.svg
svg/custom/clip-path-with-css-transform-1.svg
svg/custom/clip-path-with-css-transform-2.svg
svg/custom/pointer-events-image-css-transform.svg
svg/custom/pointer-events-text-css-transform.svg
svg/dom/css-transforms.xhtml
svg/dynamic-updates/SVG-dynamic-css-transform.html
svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting.html
svg/transforms/svg-css-transforms-clip-path.xhtml
svg/transforms/svg-css-transforms.xhtml

• manual-tests/svg-animation-css-transform.html: Added.
• manual-tests/svg-css-animate-compound.html: Added.
• manual-tests/svg-css-transition-compound.html: Added.
• rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::styleWillChange):

Set the updateTransform flag on SVG elements whenever a CSS transform is present on the style

• svg/SVGStyledTransformableElement.cpp:

(WebCore::SVGStyledTransformableElement::animatedLocalTransform):

Use the RenderStyle's transform (if it exists) over the SVG's transform

• svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::animatedLocalTransform):

Use the RenderStyle's transform (if it exists) over the SVG's transform

LayoutTests:

• platform/chromium/test_expectations.txt:
• platform/mac/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
• platform/mac/svg/clip-path/clip-path-css-transform-1-expected.txt: Added.
• platform/mac/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
• platform/mac/svg/clip-path/clip-path-css-transform-2-expected.txt: Added.
• platform/mac/svg/custom/clip-path-with-css-transform-1-expected.png: Added.
• platform/mac/svg/custom/clip-path-with-css-transform-1-expected.txt: Added.
• platform/mac/svg/custom/clip-path-with-css-transform-2-expected.png: Added.
• platform/mac/svg/custom/clip-path-with-css-transform-2-expected.txt: Added.
• platform/mac/svg/custom/pointer-events-image-css-transform-expected.png: Added.
• platform/mac/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
• platform/mac/svg/custom/pointer-events-text-css-transform-expected.png: Added.
• platform/mac/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
• platform/mac/svg/dom/css-transforms-expected.png: Added.
• platform/mac/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
• platform/mac/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
• platform/mac/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
• platform/mac/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
• platform/mac/svg/transforms/svg-css-transforms-expected.png: Added.
• platform/mac/svg/transforms/svg-css-transforms-expected.txt: Added.
• svg/clip-path/clip-path-css-transform-1.svg: Added.
• svg/clip-path/clip-path-css-transform-2.svg: Added.
• svg/custom/clip-path-with-css-transform-1.svg: Added.
• svg/custom/clip-path-with-css-transform-2.svg: Added.
• svg/custom/pointer-events-image-css-transform.svg: Added.
• svg/custom/pointer-events-text-css-transform.svg: Added.
• svg/dom/css-transforms-expected.txt: Added.
• svg/dom/css-transforms.xhtml: Added.
• svg/dynamic-updates/SVG-dynamic-css-transform-expected.txt: Added.
• svg/dynamic-updates/SVG-dynamic-css-transform.html: Added.
• svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.txt: Added.
• svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting.html: Added.
• svg/dynamic-updates/script-tests/SVGClipPathElement-css-transform-influences-hitTesting.js: Added.

(executeBackgroundTest):
(executeTest):

• svg/transforms/svg-css-transforms-clip-path.xhtml: Added.
• svg/transforms/svg-css-transforms.xhtml: Added.

2:46 AM Changeset in webkit [101061] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebCore

[MutationObservers] Cleanup duplicated code in Element & CharacterData
​https://bugs.webkit.org/show_bug.cgi?id=72986

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.

This patch creates a MutationObserverInterestGroup which represents the set
of MutationObservers which should receive all mutations of a given type generated
from a specific node.

No tests needed. This patch is only a refactor.

• dom/CharacterData.cpp:

(WebCore::CharacterData::dispatchModifiedEvent):

• dom/ChildListMutationScope.cpp:

(WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::ChildListMutationAccumulator):
(WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::enqueueMutationRecord):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):

• dom/Element.cpp:

(WebCore::enqueueAttributesMutationRecord):

• dom/WebKitMutationObserver.cpp:

(WebCore::MutationObserverInterestGroup::createForChildListMutation):
(WebCore::MutationObserverInterestGroup::createForCharacterDataMutation):
(WebCore::MutationObserverInterestGroup::createForAttributesMutation):
(WebCore::MutationObserverInterestGroup::MutationObserverInterestGroup):
(WebCore::MutationObserverInterestGroup::isOldValueRequested):
(WebCore::MutationObserverInterestGroup::enqueueMutationRecord):

• dom/WebKitMutationObserver.h:

(WebCore::MutationObserverInterestGroup::isEmpty):
(WebCore::MutationObserverInterestGroup::hasOldValue):

2:35 AM Changeset in webkit [101060] by Martin Robinson

• 5 edits in trunk

[GTK] Enable WebGL by default
​https://bugs.webkit.org/show_bug.cgi?id=69706

Reviewed by Xan Lopez.

.:

• configure.ac: Enable WebGL by default if the build target is X11.

LayoutTests:

• platform/gtk/Skipped: Skip all WebGL tests until we can ensure they

run properly on the bots.

• platform/platform/gtk-wk2/Skipped: Ditto.

2:10 AM Changeset in webkit [101059] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[chromium] HDC leak in Uniscribe Helper
​https://bugs.webkit.org/show_bug.cgi?id=68598

Patch by Marc-Andre Decoste <​mad@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.

For some reason the Script functions on Windows sometimes return
E_PENDING even with a non-NULL DC, so we must handle that case.
Also, we should not use the screen DC to select font since this
refreshes the whole desktop, so I added a cached compatible DC.

Note that this doesn't reproduce with WebKit alone, it only reproduces
within Chrome, so we can't write a WebKit test for it. A chromium
browser test will be added once this change gets rolled in the
chromium DEPS file.

• platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::shape):
(WebCore::UniscribeHelper::EnsureCachedDCCreated):
(WebCore::UniscribeHelper::fillShapes):

• platform/graphics/chromium/UniscribeHelper.h:

2:02 AM Changeset in webkit [101058] by commit-queue@webkit.org

• 5 edits
  5 adds in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Adding embedding code for GetUserMedia
​https://bugs.webkit.org/show_bug.cgi?id=71678

This patch includes a fix for ​https://bugs.webkit.org/show_bug.cgi?id=72925.

Patch by Tommy Widenflycht <​tommyw@google.com> on 2011-11-23
Reviewed by Darin Fisher.

• WebKit.gyp:
• public/WebUserMediaClient.h: Added.

(WebKit::WebUserMediaClient::~WebUserMediaClient):

• public/WebUserMediaRequest.h: Added.

(WebKit::WebUserMediaRequest::WebUserMediaRequest):
(WebKit::WebUserMediaRequest::~WebUserMediaRequest):
(WebKit::WebUserMediaRequest::operator=):
(WebKit::WebUserMediaRequest::isNull):
(WebKit::operator==):

• public/WebViewClient.h:

(WebKit::WebViewClient::userMediaClient):

• src/UserMediaClientImpl.cpp: Added.

(WebKit::UserMediaClientImpl::UserMediaClientImpl):
(WebKit::UserMediaClientImpl::pageDestroyed):
(WebKit::UserMediaClientImpl::requestUserMedia):
(WebKit::UserMediaClientImpl::cancelUserMediaRequest):

• src/UserMediaClientImpl.h: Added.
• src/WebUserMediaRequest.cpp: Added.

(WebKit::WebUserMediaRequest::WebUserMediaRequest):
(WebKit::WebUserMediaRequest::reset):
(WebKit::WebUserMediaRequest::audio):
(WebKit::WebUserMediaRequest::video):
(WebKit::WebUserMediaRequest::cameraPreferenceUser):
(WebKit::WebUserMediaRequest::cameraPreferenceEnvironment):
(WebKit::WebUserMediaRequest::securityOrigin):
(WebKit::WebUserMediaRequest::requestSucceeded):
(WebKit::WebUserMediaRequest::requestFailed):
(WebKit::WebUserMediaRequest::equals):
(WebKit::WebUserMediaRequest::assign):
(WebKit::WebUserMediaRequest::operator UserMediaRequest*):

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

• src/WebViewImpl.h:

1:25 AM Changeset in webkit [101057] by annacc@chromium.org

• 19 edits in trunk

Move readyState from TextTrack to HTMLTrackElement
​https://bugs.webkit.org/show_bug.cgi?id=72553

Reviewed by Eric Carlson.

Source/WebCore:

• html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::HTMLTrackElement):

Set initial readyState to NONE.

(WebCore::HTMLTrackElement::didCompleteLoad):

Set readyState based on load completed status.

(WebCore::HTMLTrackElement::setReadyState):

This replaces textTrackReadyStateChanged() because only LoadableTextTrack
needs to notify HTMLTrackElement of readyState changes (i.e.
textTrackReadyStateChanged() is no longer required of TextTrackClient).

• html/HTMLTrackElement.h:

ReadyState enum and m_readyState member variable moved from TextTrack.

(WebCore::HTMLTrackElement::readyState):

New: readyState() getter.

• html/HTMLTrackElement.idl:

Add readyState attribute and associated constants.

• html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::loadTimerFired): Set readyState on HTMLTrackElement.
(WebCore::LoadableTextTrack::cueLoadingStarted): Ditto.
(WebCore::LoadableTextTrack::cueLoadingCompleted): Move code to set readyState

to HTMLTrackElement (it can set it based on loading status).

• html/TextTrack.cpp: Remove readyState from TextTrack.

(WebCore::TextTrack::TextTrack): Ditto.

• html/TextTrack.h: Ditto.
• html/TextTrack.idl: Ditto.

LayoutTests:

• media/track/track-add-track-expected.txt:
• media/track/track-add-track.html:
• media/track/track-constants-expected.txt:
• media/track/track-constants.html:
• media/track/track-load-error-readyState-expected.txt:
• media/track/track-load-error-readyState.html:
• media/track/track-load-from-element-readyState-expected.txt:
• media/track/track-load-from-element-readyState.html:
• media/track/track-load-from-src-readyState-expected.txt:
• media/track/track-load-from-src-readyState.html:

1:22 AM Changeset in webkit [101056] by Nikolas Zimmermann

• 11 edits in trunk

Add flags/precision arguments to String::number(double) to allow fine-grained control over the result string
​https://bugs.webkit.org/show_bug.cgi?id=72793

Reviewed by Zoltan Herczeg.

Source/JavaScriptCore:

This new code will be used in follow-up patches to replace the String::format("%.2f") usage in
platform/text/TextStream.cpp, and String::format("%.6lg") usage in svg/SVGPathStringBuilder.cpp.

The String::number(double) currently calls String::format("%.6lg") in trunk. In order to replace
this by a variant that properly rounds to six significant figures, JSC code could be refactored.
JSCs Number.toPrecision/toFixed uses wtf/dtoa/double-conversion which provides all features we need,
except truncating trailing zeros, needed to mimic the "g" format, which is either f or e but with
trailing zeros removed, producing shorter results. Changed the default signature to:

"static String number(double, unsigned = ShouldRoundSignificantFigures | ShouldTruncateTrailingZeros, unsigned precision = 6);".

In WebCore we can now replace String::format() calls like this:
String::format("%.2f", f) -> String::number(f, ShouldRoundDecimalPlaces, 2)
String::format("%.6lg", f) -> String::number(f)

The default parameters for precison & flags exactly match the format of the string produced now, except that the result
is rounded according to the rounding mode / formatting mode and precision. This paves the way towards reliable results
in the d="" attribute dumps of SVG paths across platforms. The dtoa rounding code enforces a unique zero, resolving
all 0.0 vs. -0.0 issues currently seen on Windows, and some Gtk/Qt bots.

This patch needs a rebaseline of svg/dom/length-list-parser.html as we don't perfecly mimic the String::format() "lg" mode
result for exponentials, we used to return eg. "e-7" and now return "e-07" - the trailing zero truncation hasn't been
implemented for exponentials, as this really affects only this test and thus wasn't worth the trouble - in contrary the
trailing zero truncation is needed for thousands of other results in "f" notation, and thus needed to match the DRT results.

Here's a performance comparision using a JSC release build and some arbitary numbers:
Converting 123.456 using old approach took 95.527100ms. avg 0.000955ms/call.
Converting 123.456 using new approach took 28.126953ms. avg 0.000281ms/call.

Converting 123 using old approach took 85.411133ms. avg 0.000854ms/call.
Converting 123 using new approach took 24.190186ms. avg 0.000242ms/call.

Converting 0.1 using old approach took 92.622803ms. avg 0.000926ms/call.
Converting 0.1 using new approach took 23.317871ms. avg 0.000233ms/call.

Converting 1/i using old approach took 106.893066ms. avg 0.001069ms/call.
Converting 1/i using new approach took 27.164062ms. avg 0.000272ms/call.

For all numbers I've tested in RoundingSignificantFigures mode and 6 digit precision the speedup was at least 250%.

• JavaScriptCore.exp: Change String::number(double) signature.
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Ditto.
• runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToFixed): Refactor this into numberToFixedPrecisionString(), move to wtf/dtoa.cpp.
(JSC::numberProtoFuncToPrecision): Ditto, refactor this into numberToFixedWidthString.

• wtf/dtoa.cpp: Moved fixedWidth/Precision helpers into dtoa, extend numberToFixedPrecisionString(). Add a mode which allows to truncate trailing zeros/decimal point.

to make it possible to use them to generate strings that match the output from String::format("%6.lg"), while using our dtoas rounding facilities.

• wtf/dtoa.h:
• wtf/dtoa/utils.h: Expose new helper method, which allows us to truncate the result, before generating the output const char*.

(WTF::double_conversion::StringBuilder::SetPosition):

• wtf/text/WTFString.cpp:

(WTF::String::number): Remove String::format("%6.lg") usage! Switch to rounding to six significant figures, while matching the output of String::format.

• wtf/text/WTFString.h:

LayoutTests:

Rebaseline one test result, after the String::number(double) changes. Trailing zeros are no longer removed
in the exponential form of the string: e-07 is reported instead of e-7 now. It was decided to leave it as-is
and not introduce trailing zero removal for the exponential formatting, as it only affects this test.

I'll rebaseline other platforms once results are available.

• svg/dom/length-list-parser-expected.txt:

1:20 AM Changeset in webkit [101055] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/chromium

[chromium] Expose showFPSCounter and showPlatformLayerTree in WebLayerTreeView::Settings
​https://bugs.webkit.org/show_bug.cgi?id=72973

Patch by Antoine Labour <​piman@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.

• public/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):

• src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

1:10 AM Changeset in webkit [101054] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

WTF::String has extra WTF_EXPORT_PRIVATE
​https://bugs.webkit.org/show_bug.cgi?id=72858

Patch by Hajime Morrita <​morrita@chromium.org> on 2011-11-23
Reviewed by Kevin Ollivier.

• wtf/text/WTFString.h:

(WTF::String::String):

1:09 AM Changeset in webkit [101053] by Philippe Normand

• 2 edits in trunk/LayoutTests

Unreviewed, skip failing accessibility test on GTK.

• platform/gtk/Skipped: Skip accessibility/multiselect-list-reports-active-option.html

1:08 AM Changeset in webkit [101052] by Patrick Gansterer

• 15 edits
  1 copy
  2 moves
  1 add in trunk

[CMake] Move the top-level logic to the top-level directory.
​https://bugs.webkit.org/show_bug.cgi?id=72685

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-11-23
Reviewed by Brent Fulgham.

.:

Move most of the top-level code in Source/CMakeLists.txt to
CMakeLists.txt. This allows us to replace some INCLUDE() hacks with
proper ADD_SUBDIRECTORY() calls, and actually moves non-Source related
to a non-Source directory.

• CMakeLists.txt: Copied from Source/CMakeLists.txt.

Source/JavaScriptCore:

• CMakeLists.txt: Point to the right Source/ directory.
• wtf/CMakeLists.txt: Ditto.

Source/WebCore:

No new tests, this is a buildsystem changes.

• CMakeLists.txt: Adjust the Source/ directory.
• PlatformBlackBerry.cmake: Ditto.

Source/WebKit:

• blackberry/CMakeListsBlackBerry.txt: Adjust the Source/ directory.

Source/WebKit2:

• CMakeLists.txt: Adjust Source/ directory.

Tools:

• CMakeLists.txt: Added.
• DumpRenderTree/efl/CMakeLists.txt: Keep building into Programs/.
• EWebLauncher/CMakeLists.txt: Renamed from Tools/CMakeListsEfl.txt.
• Scripts/webkitdirs.pm:

(generateBuildSystemFromCMakeProject):

• WinCELauncher/CMakeLists.txt: Renamed from Tools/CMakeListsWinCE.txt.

1:00 AM Changeset in webkit [101051] by Philippe Normand

• 1 edit
  3 adds in trunk/LayoutTests

Unreviewed, GTK baselines for 3 new tests.

• platform/gtk/animations/additive-transform-animations-expected.txt: Added.
• platform/gtk/css3/images/cross-fade-overflow-position-expected.txt: Added.
• platform/gtk/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added.

12:55 AM Changeset in webkit [101050] by Philippe Normand

• 2 edits in trunk/LayoutTests

Unreviewed, skip failing editing/spelling/spellcheck-async.html
test on GTK.

• platform/gtk/Skipped:

12:48 AM Changeset in webkit [101049] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/gtk

Documentation fix for load-committed in webkitwebframe
​https://bugs.webkit.org/show_bug.cgi?id=72927

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-11-23
Reviewed by Martin Robinson.

• webkit/webkitwebframe.cpp:

(webkit_web_frame_class_init):

12:42 AM Changeset in webkit [101048] by mihnea@adobe.com

• 12 edits
  3 copies
  3 moves in trunk

CSS Exclusions: update the name of the shape CSS properties
​https://bugs.webkit.org/show_bug.cgi?id=71898
Instead of a single wrap-shape property, we have wrap-shape-inside and wrap-shape-outside.

Reviewed by Dean Jackson.

Source/WebCore:

Tests: fast/exclusions/parsing-wrap-shape-inside.html

fast/exclusions/parsing-wrap-shape-outside.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

• css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseWrapShape):

• css/CSSParser.h:
• css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

• css/CSSPropertyNames.in:
• css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

• rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setWrapShapeInside):
(WebCore::InheritedFlags::wrapShapeInside):
(WebCore::InheritedFlags::setWrapShapeOutside):
(WebCore::InheritedFlags::wrapShapeOutside):
(WebCore::InheritedFlags::initialWrapShapeInside):
(WebCore::InheritedFlags::initialWrapShapeOutside):

• rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

• rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

• fast/exclusions/parsing-wrap-shape-inside-expected.txt: Copied from LayoutTests/fast/exclusions/parsing-wrap-shape-expected.txt.
• fast/exclusions/parsing-wrap-shape-inside.html: Copied from LayoutTests/fast/exclusions/parsing-wrap-shape.html.
• fast/exclusions/parsing-wrap-shape-outside-expected.txt: Renamed from LayoutTests/fast/exclusions/parsing-wrap-shape-expected.txt.
• fast/exclusions/parsing-wrap-shape-outside.html: Renamed from LayoutTests/fast/exclusions/parsing-wrap-shape.html.
• fast/exclusions/script-tests/parsing-wrap-shape-inside.js: Copied from LayoutTests/fast/exclusions/script-tests/parsing-wrap-shape.js.
• fast/exclusions/script-tests/parsing-wrap-shape-outside.js: Renamed from LayoutTests/fast/exclusions/script-tests/parsing-wrap-shape.js.

12:29 AM Changeset in webkit [101047] by caseq@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: [Extensions API] avoid exception in initExtensions() if elements panel is not present
​https://bugs.webkit.org/show_bug.cgi?id=73007

Reviewed by Yury Semikhatsky.

• inspector/front-end/ExtensionServer.js:

12:26 AM Changeset in webkit [101046] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Use new name for pixel config field of GrTextureDesc
​https://bugs.webkit.org/show_bug.cgi?id=72543

Patch by Brian Salomon <​bsalomon@google.com> on 2011-11-23
Reviewed by Stephen White.

Tested by every canvas2d layout test.

• platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createAcceleratedCanvas):

12:21 AM Changeset in webkit [101045] by eae@chromium.org

• 7 edits in trunk/Source/WebCore

Change remaining scrollTop/Left/Width/Height methods back to int
​https://bugs.webkit.org/show_bug.cgi?id=72771

Reviewed by Eric Seidel.

Change remaining scrollTop/Left/Width/Height, setScrollLeft/Top and
verticalScrollbarWidth, horizontalScrollbarHeight methods back to int as
scrolling will remain int based to line up with device pixels.

No new tests.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::scrollLeft):
(WebCore::RenderBox::scrollTop):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::RenderBox::verticalScrollbarWidth):
(WebCore::RenderBox::horizontalScrollbarHeight):

• rendering/RenderBox.h:

(WebCore::RenderBox::scrollbarLogicalHeight):

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::verticalScrollbarWidth):
(WebCore::RenderListBox::scrollHeight):
(WebCore::RenderListBox::scrollLeft):
(WebCore::RenderListBox::setScrollLeft):
(WebCore::RenderListBox::scrollTop):
(WebCore::RenderListBox::setScrollTop):

• rendering/RenderListBox.h:
• rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::scrollWidth):
(WebCore::RenderTextControlSingleLine::scrollHeight):
(WebCore::RenderTextControlSingleLine::scrollLeft):
(WebCore::RenderTextControlSingleLine::scrollTop):
(WebCore::RenderTextControlSingleLine::setScrollLeft):
(WebCore::RenderTextControlSingleLine::setScrollTop):

• rendering/RenderTextControlSingleLine.h: