⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 4, 2011:

11:58 PM Changeset in webkit [101975] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

ImageDecoder setSize() should check for backing store allocation failure
​https://bugs.webkit.org/show_bug.cgi?id=72864

Reviewed by Adam Barth.

The backing store of a decoded image is a Vector<PixelData> on the affected
ports. And Vector<> provides a resize capacity member that returns false if
memory allocation fails.

setSize() should be called once only during an image decode - add an ASSERT
for that. Resize the backing store capacity to the requested image size and
return false if memory allocation fails.

ImageDecoder::isOverSize(width, height) is called to check that the decoded
width and height won't overflow 'width x height x sizeof(PixelData)' before
calls to setSize(). Refer to ​http://webkit.org/b/48634

No new tests. Covered by fast/images/size-failure.html

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageFrame::setSize):

11:42 PM Changeset in webkit [101974] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Add binary support in WebSocket test server's echo handler.
​https://bugs.webkit.org/show_bug.cgi?id=73649

Patch by Takashi Toyoshima <​toyoshim@chromium.org> on 2011-12-04
Reviewed by Eric Seidel.

  • http/tests/websocket/tests/hybi/echo_wsh.py: Support binary frames.
10:52 PM Changeset in webkit [101973] by eric@webkit.org
  • 2 edits in trunk/Tools

After success with Mac, Win and Gtk, turning on parallel testing
by default for all platforms (except Qt).

We'll add more platforms to the blacklist if we see problems.

Unreviewed.

  • Scripts/run-webkit-tests:

(platformIsReadyForParallelTesting):

9:44 PM Changeset in webkit [101972] by kling@webkit.org
  • 7 edits in trunk/Source/WebCore

CSSStyleSheet can't be reparented, enforce this at compile time.
<​http://webkit.org/b/73793>

Reviewed by Benjamin Poulain.

  • css/StyleSheet.h:

(WebCore::StyleSheet::clearOwnerRule):

Changed setParentRule(CSSImportRule*) to clearOwnerRule() to document and
enforce the fact that style sheets should never be reparented after creation.

(WebCore::StyleSheet::ownerRule):

Renamed parentRule() to ownerRule() to match the CSSOM name.

(WebCore::StyleSheet::ownerNode):
(WebCore::StyleSheet::clearOwnerNode):

Also renamed StyleSheet::m_parentNode to m_ownerNode to match its accessors.

  • css/CSSStyleSheet.h:

Removed ownerRule() as we now inherit it from StyleSheet.

  • bindings/js/JSDOMBinding.h:

(WebCore::root):

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::~CSSImportRule):
(WebCore::CSSImportRule::setCSSStyleSheet):

  • css/StyleSheet.cpp:

(WebCore::StyleSheet::StyleSheet):
(WebCore::StyleSheet::parentStyleSheet):
(WebCore::StyleSheet::baseURL):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::fillMediaListChain):

Update call sites to use the new names.

9:24 PM Changeset in webkit [101971] by tkent@chromium.org
  • 24 edits
    5 moves
    12 adds
    8 deletes in trunk/LayoutTests

[Chromium] Rebaseline of placeholder tests for r101742 and r101848.

  • platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/placeholder-position-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/forms/placeholder-position-expected.png.
  • platform/chromium-cg-mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
  • platform/chromium-linux/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-linux/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-linux/fast/forms/search-styled-expected.txt:
  • platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/placeholder-position-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/search-styled-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/search-styled-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-pseudo-style-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-placeholder-visibility-1-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-placeholder-visibility-3-expected.png: Removed.
  • platform/chromium-mac/fast/forms/textarea-placeholder-visibility-1-expected.png: Removed.
  • platform/chromium-mac/fast/forms/textarea-placeholder-visibility-2-expected.png: Removed.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.png:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.txt: Removed.
6:29 PM Changeset in webkit [101970] by kling@webkit.org
  • 4 edits
    2 adds in trunk

border-width: initial and border-color: initial cannot be removed via CSSOM.
<​http://webkit.org/b/68551>

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/cssom-remove-shorthand-property.html

When asked to remove a shorthand property, we should toss out both the
sub-properties of that shorthand as well as the shorthand itself, should the
declaration contain it. The latter part was missing in our implementation.

  • css/CSSMutableStyleDeclaration.h:
  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
(WebCore::CSSMutableStyleDeclaration::removeShorthandProperty):

Changed to return true only if something was actually removed.

LayoutTests:

Add a test verifying that shorthand properties can be added/removed
via CSSOM'S CSSStyleDeclaration interface.

  • fast/css/cssom-remove-shorthand-property-expected.txt: Added.
  • fast/css/cssom-remove-shorthand-property.html: Added.
3:09 PM Changeset in webkit [101969] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-04

  • DEPS:
2:10 PM Changeset in webkit [101968] by Darin Adler
  • 1 edit
    12 deletes in trunk/LayoutTests

Removed obsolete expected results that should have been removed when converting to a ref test.

  • platform/chromium-cg-mac-leopard/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/chromium-linux/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/chromium-mac-leopard/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/chromium-mac/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/chromium-win/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/chromium-win/css3/unicode-bidi-isolate-aharon-expected.txt: Removed.
  • platform/efl/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/efl/css3/unicode-bidi-isolate-aharon-expected.txt: Removed.
  • platform/gtk/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/gtk/css3/unicode-bidi-isolate-aharon-expected.txt: Removed.
  • platform/mac/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/mac/css3/unicode-bidi-isolate-aharon-expected.txt: Removed.
1:52 PM Changeset in webkit [101967] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

HIERARCHY_REQUEST_ERR check in checkAcceptChild should be optimized for newChild without children
​https://bugs.webkit.org/show_bug.cgi?id=73737

Reviewed by Darin Adler.

It turned out that 50-70% of nodes inserted by DOM APIs such as insertBefore and appendChild
don't have any descendent nodes. Optimize isDescendantOf which is used by checkAcceptChild for this case.
On a test case attached on the bug, we see a 40% improvement.

Also optimize for cases where either new child or new parent but not both are in document as suggested
by Erik Arvidsson. This appears to happen about 40-70% of the time, and the symmetric difference between
the two cases is about 50% so it's worth implementing both optimizations.

Unfortunately no tests because we still have a O(n) algorithm somewhere.

  • dom/Node.cpp:

(WebCore::Node::isDescendantOf):
(WebCore::Node::contains):

1:50 PM Changeset in webkit [101966] by Darin Adler
  • 3 edits in trunk/LayoutTests
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:

Oops, landed the wrong versions of these yesterday. These are the right ones.

1:25 PM Changeset in webkit [101965] by weinig@apple.com
  • 3 edits
    3 adds in trunk/Tools

Add tests for RetainPtr::adoptNS/adoptCF
​https://bugs.webkit.org/show_bug.cgi?id=73470

Reviewed by Adam Roben and Darin Adler.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp: Added.

(TestWebKitAPI::TEST):
Test that adopting using adoptCF creates a RetainPtr with a
value whose retain count is 1.

  • TestWebKitAPI/Tests/WTF/ns: Added.
  • TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added.

(TestWebKitAPI::TEST):
Test that adopting using adoptNS creates a RetainPtr with a
value whose retain count is 1.

1:16 PM Changeset in webkit [101964] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

DFG should optimize strict equality
​https://bugs.webkit.org/show_bug.cgi?id=73764

Reviewed by Oliver Hunt.

1% speed-up on V8.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileStrictEq):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileIntegerCompare):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileIntegerCompare):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compile):

12:42 PM Changeset in webkit [101963] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] cleanup qmltests.pro
​https://bugs.webkit.org/show_bug.cgi?id=73718

Patch by Gopal Raghavan <​gopal.1.raghavan@nokia.com> on 2011-12-04
Reviewed by Simon Hausmann.

Removed unused file WebView/tst_loadZeroSizeView.qml and reordered file list.

  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
11:09 AM Changeset in webkit [101962] by Philippe Normand
  • 5 edits in trunk/Source/WebKit2

[WK2][GTK] enable-fullscreen WebSettings
​https://bugs.webkit.org/show_bug.cgi?id=73774

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_set_enable_fullscreen):
(webkit_settings_get_enable_fullscreen):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings):

10:46 AM Changeset in webkit [101961] by Martin Robinson
  • 2 edits in trunk/Tools

[GTK] Include cairo, pixman and gnome-icon-theme in the jhbuild modules
​https://bugs.webkit.org/show_bug.cgi?id=73748

Reviewed by Gustavo Noronha Silva.

  • gtk/jhbuild.modules: Add some new modules the jhbuild moduleset.
8:58 AM Changeset in webkit [101960] by mario@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[Gtk] Check for the load-complete event only in the unit tests.

There is currently a known issue happening in debug builds when
reloading the webview if it was loaded before through the function
webkit_web_view_load_string, resulting in a ASSERT failing (see
bug 50331) so we can't check for the reload event here, since it
makes the test to fail. Fortunately, checking for load-complete
event is a good enough test, so this small patch is about that.

Rubber-stamped by Philippe Normand.

  • tests/testatk.c:

(testWebkitAtkDocumentLoadingEvents): Don't load and then reload
to check events, just load once and check whether the
'load-complete' event has happened.

8:31 AM Changeset in webkit [101959] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

CSSValuePool: Inline trivial getters.
<​http://webkit.org/b/73763>

Reviewed by Anders Carlsson.

  • css/CSSValuePool.cpp:
  • css/CSSValuePool.h:

(WebCore::CSSValuePool::createInheritedValue): Inlined.
(WebCore::CSSValuePool::createImplicitInitialValue): Ditto.
(WebCore::CSSValuePool::createExplicitInitialValue): Ditto.

7:48 AM Changeset in webkit [101958] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, skip two more tests.

  • platform/gtk/Skipped: Skip

platform/gtk/fonts/custom-font-missing-glyphs.html failing on
64-bit Debug.

  • platform/gtk/test_expectations.txt:

fast/table/multiple-captions-display.xhtml is flaky.

7:32 AM Changeset in webkit [101957] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, moving flaky ref test to Skipped list.

  • platform/gtk/Skipped:
  • platform/gtk/test_expectations.txt:
5:59 AM Changeset in webkit [101956] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, skip two flaky tests and one SVG test timing out on GTK.

  • platform/gtk/test_expectations.txt: Skip two fast/ tests.
  • platform/gtk/Skipped: Skip svg/text/text-style-recalc-crash.html
5:10 AM Changeset in webkit [101955] by Philippe Normand
  • 2 edits in trunk/Tools

Another GTK build fix after r101922.

Rubber-stamped by Martin Robinson.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::pathToLocalResource): Plug possible String ref leak.

4:42 AM Changeset in webkit [101954] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-12-04 Xan Lopez <​xlopez@igalia.com>

Fix compiler warning in LayoutTestController

Reviewed by Philippe Normand.

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): fix warning.
3:56 AM Changeset in webkit [101953] by commit-queue@webkit.org
  • 8 edits in trunk/Tools

Add missing methods used by fast/notifications tests to LayoutTestController
​https://bugs.webkit.org/show_bug.cgi?id=63616

Patch by Alexandre Mazari <​scaroo@gmail.com> on 2011-12-04
Reviewed by Martin Robinson.

Add missing simulateDesktopNotificationClick method used by
fast/notifications. Provide a default implementation for
areDesktopNotificationPermissionRequestsIgnored and
ignoreDesktopNotificationPermissionRequests.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): call into the port implementation.
(simulateDesktopNotificationClickCallback): ditto.
(ignoreDesktopNotificationPermissionRequestsCallback): default implementation.
(LayoutTestController::staticFunctions): declare new methods.
(LayoutTestController::ignoreDesktopNotificationPermissionRequests): default implementation.

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::areDesktopNotificationPermissionRequestsIgnored):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::simulateDesktopNotificationClick): dummy implementation.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::simulateDesktopNotificationClick): ditto.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::simulateDesktopNotificationClick): ditto.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::simulateDesktopNotificationClick): ditto.

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::simulateDesktopNotificationClick): ditto.

3:32 AM Changeset in webkit [101952] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Fix broken UTF-8 characters issue on editor command.
​https://bugs.webkit.org/show_bug.cgi?id=73516

Patch by Kangil Han <​kangil.han@samsung.com> on 2011-12-04
Reviewed by Ryosuke Niwa.

The issue has been described that Korean character is broken on pasting copied text.
In my analysis, this is from lack of format change between C style UTF-8 character pointer and C++ style String reference.
Therefore, this patch will convert types to resolve the problem.

  • ewk/ewk_view.cpp:

(_ewk_view_editor_command):

1:39 AM Changeset in webkit [101951] by mario@webkit.org
  • 8 edits
    2 deletes in trunk

Source/WebKit/gtk: Removing document related events from DRT

[GTK] Don't log document events in DRT
​https://bugs.webkit.org/show_bug.cgi?id=73746

Reviewed by Martin Robinson.

New unit test to check events when reloading a document. This
replaces the former document-reload-events.html layout test.

  • tests/testatk.c:

(updateLoadingEventsResult): New, updates a global variable to
allow checking later on that the right signals were emmitted.
(documentLoadingEventCallback): New, global listener for load-complete
and reload signals over the document object (the web area).
(testWebkitAtkDocumentLoadingEvents): New unit test, globally
connects to document-related signals and check they are properly
emitted when reloading the web view.
(main): Added new test.

Tools: [GTK] Don't log document events in DRT
​https://bugs.webkit.org/show_bug.cgi?id=73746

Reviewed by Martin Robinson.

Stop connecting globally to document-related events.

  • DumpRenderTree/gtk/AccessibilityCallbacks.cpp:

(connectAccessibilityCallbacks): Removed connections.
(disconnectAccessibilityCallbacks): Removed disconnections.

LayoutTests: [GTK] Don't log document events in DRT
​https://bugs.webkit.org/show_bug.cgi?id=73746

Reviewed by Martin Robinson.

Unskip passing test, remove other transformed into a unit test and
rebaseline expectations now we stopped logging document events.

  • platform/gtk/Skipped: Removed two skipped tests.
  • platform/gtk/accessibility/aria-slider-required-attributes-expected.txt: Rebaselined
  • platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Ditto.
  • platform/gtk/accessibility/document-reload-events-expected.txt: Removed.
  • platform/gtk/accessibility/document-reload-events.html: Removed.
12:55 AM Changeset in webkit [101950] by rniwa@webkit.org
  • 6 edits in trunk/LayoutTests

Add failing expectation to css3/unicode-bidi-isolate-aharon-failing.html as it was split from
css3/unicode-bidi-isolate-aharon.html in r101949.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:
12:28 AM Changeset in webkit [101949] by rniwa@webkit.org
  • 3 edits
    3 copies
    2 adds
    32 deletes in trunk/LayoutTests

Convert isolate and plaintext tests to reftests
​https://bugs.webkit.org/show_bug.cgi?id=73680

Reviewed by Darin Adler.

Convert bdi-element-expected.html, unicode-bidi-isolate-aharon.html, and unicode-bidi-plaintext.html to reftests.
In addition, isolate the failing test case in unicode-bidi-plaintext.html as unicode-bidi-isolate-aharon-failing.html.

  • css3/bdi-element-expected.html: Copied from LayoutTests/css3/bdi-element.html.
  • css3/unicode-bidi-isolate-aharon-expected.html: Copied from LayoutTests/css3/unicode-bidi-isolate-aharon.html.
  • css3/unicode-bidi-isolate-aharon-failing-expected.html: Added.
  • css3/unicode-bidi-isolate-aharon-failing.html: Added.
  • css3/unicode-bidi-isolate-aharon.html:
  • fast/text/international/unicode-bidi-plaintext.html:
  • platform/chromium-cg-mac-leopard/css3/bdi-element-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css3/bdi-element-expected.txt: Removed.
  • platform/chromium-cg-mac-leopard/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/chromium-cg-mac/css3/bdi-element-expected.png: Removed.
  • platform/chromium-linux/css3/bdi-element-expected.png: Removed.
  • platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/chromium-mac-leopard/css3/bdi-element-expected.png: Removed.
  • platform/chromium-mac-leopard/css3/bdi-element-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/chromium-mac/css3/bdi-element-expected.png: Removed.
  • platform/chromium-mac/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/chromium-win/css3/bdi-element-expected.png: Removed.
  • platform/chromium-win/css3/bdi-element-expected.txt: Removed.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-expected.txt: Removed.
  • platform/chromium/css3/bdi-element-expected.txt: Removed.
  • platform/efl/css3/bdi-element-expected.png: Removed.
  • platform/efl/css3/bdi-element-expected.txt: Removed.
  • platform/efl/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/efl/fast/text/international/unicode-bidi-plaintext-expected.txt: Removed.
  • platform/gtk/css3/bdi-element-expected.png: Removed.
  • platform/gtk/css3/bdi-element-expected.txt: Removed.
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt: Removed.
  • platform/mac/css3/bdi-element-expected.png: Removed.
  • platform/mac/css3/bdi-element-expected.txt: Removed.
  • platform/mac/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/mac/fast/text/international/unicode-bidi-plaintext-expected.txt: Removed.
  • platform/qt/css3/bdi-element-expected.png: Removed.
  • platform/qt/css3/bdi-element-expected.txt: Removed.
  • platform/win/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/win/fast/text/international/unicode-bidi-plaintext-expected.txt: Removed.

Dec 3, 2011:

10:46 PM Changeset in webkit [101948] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

Fix WebPImageDecoder decoder leak.
​https://bugs.webkit.org/show_bug.cgi?id=73756

Reviewed by Andreas Kling.

Delete the m_decoder member in the destructor if needed with WebPIDelete.

No new tests, it's valgrind territory.

  • platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::~WEBPImageDecoder):

9:49 PM Changeset in webkit [101947] by scheib@chromium.org
  • 2 edits
    2 moves
    1 add
    1 delete in trunk/LayoutTests

[Chromium] Rebaselined /accessibility/aria-checkbox-sends-notification-expected.txt

  • platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt.
  • platform/chromium-cg-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt: Removed.
  • platform/chromium/accessibility/aria-checkbox-sends-notification-expected.txt: Renamed from LayoutTests/platform/chromium-win/accessibility/aria-checkbox-sends-notification-expected.txt.
  • platform/chromium/test_expectations.txt:
9:20 PM Changeset in webkit [101946] by Darin Adler
  • 3 edits in trunk/Source/JavaScriptCore

Use HashMap<OwnPtr> for ScriptSampleRecordMap
​https://bugs.webkit.org/show_bug.cgi?id=73758

Reviewed by Andreas Kling.

  • bytecode/SamplingTool.cpp:

(JSC::SamplingTool::notifyOfScope): Added adoptPtr.
(JSC::SamplingTool::dump): Added get.

  • bytecode/SamplingTool.h: Changed the value type of ScriptSampleRecordMap to be OwnPtr.
9:20 PM Changeset in webkit [101945] by Darin Adler
  • 4 edits in trunk/Source/JavaScriptCore

Use HashMap<OwnPtr> for the opaqueJSClassData map
​https://bugs.webkit.org/show_bug.cgi?id=73759

Reviewed by Andreas Kling.

  • API/JSClassRef.cpp:

(OpaqueJSClass::contextData): Update types.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::~JSGlobalData): Add an explicit clear of opaqueJSClassData to keep the
timing the same. If we didn't care about the order of operations, we could remove this, too.

  • runtime/JSGlobalData.h: Use OwnPtr instead of raw pointer for the mapped type in the

opaqueJSClassData map.

9:11 PM Changeset in webkit [101944] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Supressing more failures via test_expectations.txt

  • platform/chromium/test_expectations.txt:

editing/spelling/markers.html, new expectations fail
svg/animations/svginteger-animation-1.html, merging overlapping lines

7:51 PM Changeset in webkit [101943] by kling@webkit.org
  • 8 edits in trunk/Source/WebCore

CSSStyleSheet: Parent rule can only ever be @import, enforce this at compile time.
<​http://webkit.org/b/73725>

Reviewed by Darin Adler.

Made StyleSheet::m_parentRule a CSSImportRule* rather than a CSSRule*
and updated getters, setters and constructors accordingly.

There is no change in behavior, this simply enforces the status quo.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.h:
  • bindings/scripts/CodeGeneratorV8.pm:

(AddIncludesForType):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::CSSStyleSheet):

  • css/CSSStyleSheet.h:

(WebCore::CSSStyleSheet::create):
(WebCore::CSSStyleSheet::ownerRule):

  • css/StyleSheet.cpp:

(WebCore::StyleSheet::StyleSheet):

  • css/StyleSheet.h:

(WebCore::StyleSheet::parentRule):
(WebCore::StyleSheet::setParentRule):

7:45 PM Changeset in webkit [101942] by Darin Adler
  • 4 edits in trunk/Source/JavaScriptCore

Change HashMap implementation to use the pass type and peek type from traits for the mapped value
​https://bugs.webkit.org/show_bug.cgi?id=72474

Reviewed by Anders Carlsson.

  • wtf/HashMap.h: Added ReferenceTypeMaker struct template. Get PassInType, PassOutType,

and PeekType from the traits of the mapped value instead of hard-coding them here.
Changed inlineAdd to take a reference to the PassInType instead of the PassInType itself,
to accomodate a PassInType that can't be copied. Use the store, peek, and passOut
functions from the traits as well.

  • wtf/HashTraits.h: Updated GenericHashTraits and HashTraits for OwnPtr to include

PassInType, PassOutType, PeekType, store, passOut, and peek. Before this, the file had
an earlier version that was just PassType, PeekType, pass, and peek. Also commented
the HashTraits for RefPtr to foreshadow some work we can do there.

  • wtf/RefPtrHashMap.h: Same changes as HashMap.h.
7:25 PM Changeset in webkit [101941] by Darin Adler
  • 8 edits
    3 adds
    1 delete in trunk/LayoutTests

Update some layout test expected results
​https://bugs.webkit.org/show_bug.cgi?id=73755

Reviewed by Sam Weinig.

  • editing/spelling/markers-expected.txt: Added. We just forgot to check this in when the

test was added, and the test is skipped on most platforms so that was not noticed.

  • fast/css/getComputedStyle/computed-style-without-renderer.html: Changed this test to

share the list of properties to skip and the list of hidden properties.

  • fast/css/getComputedStyle/computed-style.html: Ditt.
  • fast/css/getComputedStyle/resources/property-names.js: Added. Besides the structural

change the change is that CSS_GRID_LAYOUT properties are now in the list to skip.

  • platform/mac/accessibility/multiselect-list-reports-active-option-expected.txt: Added.

Shows this test is failing on Mac, even though it is passing on Chromium. That needs a bug report.

  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:

Updated these results now that we don't use relative positioning for placeholders any more.
The original patch r101742 updated other platforms, including mac-snowleopard, but missed this one.

  • platform/mac/svg/css/getComputedStyle-basic-expected.txt: Removed. The Mac platform can

share the platform-independent expected results as long as we skip the CSS_GRID_LAYOUT
properties.

  • svg/css/getComputedStyle-basic.xhtml: Updated to skip the same properties that the tests

in fast/css/getComputedStyle skip.

5:22 PM Changeset in webkit [101940] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, revert accidental change from r101932.

  • bindings/scripts/CodeGeneratorV8.pm:

(AddIncludesForType):

5:01 PM Changeset in webkit [101939] by mitz@apple.com
  • 4 edits
    1 add in trunk

Source/WebKit/mac: <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
Reviewed by Darin Adler.

  • WebView/WebView.mm:

(-[WebView _removeObjectForIdentifier:]): Changed the CFRelease(self) into
a WebCFAutorelease(self). This prevents re-entry into this method due to
the WebView closing and canceling all subresource loads, including the
one we have just removed.

Tools: Added a test for <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources

Reviewed by Darin Adler.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm: Added.

(TestWebKitAPI::TEST):

3:55 PM Changeset in webkit [101938] by Darin Adler
  • 1 edit
    11 deletes in trunk/LayoutTests

Removed some obsolete expected result files that should have been removed in r97308 and r101738.

  • platform/efl/fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-with-dyn-index-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-with-index-dom-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-with-index-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-expected.png: Removed.
3:32 PM Changeset in webkit [101937] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Revise ewk_view_fixed_layout_size_set
​https://bugs.webkit.org/show_bug.cgi?id=73401

Patch by ChangSeok Oh <ChangSeok Oh> on 2011-12-03
Reviewed by Eric Seidel.

Improve readability and replace forceLayout to setNeedsLayout,
since it sometimes causes double drawing.

  • ewk/ewk_view.cpp:

(ewk_view_fixed_layout_size_set):

3:11 PM Changeset in webkit [101936] by commit-queue@webkit.org
  • 1 edit
    5 adds in trunk/Source/WebCore

Upstream 4 files into WebCore/platform/blackberry
​https://bugs.webkit.org/show_bug.cgi?id=73614

Patch by Mary Wu <​mary.wu@torchmobile.com.cn> on 2011-12-03
Reviewed by Eric Seidel.

  • platform/blackberry/CursorBlackBerry.cpp: Added.

(WebCore::AllCursors::AllCursors):
(WebCore::getCursor):
(WebCore::Cursor::Cursor):
(WebCore::Cursor::~Cursor):
(WebCore::Cursor::operator=):
(WebCore::aliasCursor):
(WebCore::cellCursor):
(WebCore::columnResizeCursor):
(WebCore::contextMenuCursor):
(WebCore::copyCursor):
(WebCore::crossCursor):
(WebCore::eastResizeCursor):
(WebCore::eastWestResizeCursor):
(WebCore::grabbingCursor):
(WebCore::grabCursor):
(WebCore::handCursor):
(WebCore::helpCursor):
(WebCore::iBeamCursor):
(WebCore::moveCursor):
(WebCore::noDropCursor):
(WebCore::noneCursor):
(WebCore::northEastResizeCursor):
(WebCore::northEastSouthWestResizeCursor):
(WebCore::northResizeCursor):
(WebCore::northSouthResizeCursor):
(WebCore::northWestResizeCursor):
(WebCore::northWestSouthEastResizeCursor):
(WebCore::notAllowedCursor):
(WebCore::pointerCursor):
(WebCore::progressCursor):
(WebCore::rowResizeCursor):
(WebCore::southEastResizeCursor):
(WebCore::southResizeCursor):
(WebCore::southWestResizeCursor):
(WebCore::verticalTextCursor):
(WebCore::waitCursor):
(WebCore::westResizeCursor):
(WebCore::zoomInCursor):
(WebCore::zoomOutCursor):
(WebCore::middlePanningCursor):
(WebCore::eastPanningCursor):
(WebCore::northPanningCursor):
(WebCore::northEastPanningCursor):
(WebCore::northWestPanningCursor):
(WebCore::southPanningCursor):
(WebCore::southEastPanningCursor):
(WebCore::southWestPanningCursor):
(WebCore::westPanningCursor):

  • platform/blackberry/DragDataBlackBerry.cpp: Added.

(WebCore::DragData::canSmartReplace):
(WebCore::DragData::containsColor):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsFiles):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::containsURL):
(WebCore::DragData::asFilenames):
(WebCore::DragData::asColor):
(WebCore::DragData::asPlainText):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):

  • platform/blackberry/DragImageBlackBerry.cpp: Added.

(WebCore::createDragImageFromImage):
(WebCore::createDragImageIconForCachedImage):
(WebCore::deleteDragImage):
(WebCore::dissolveDragImageToFraction):
(WebCore::scaleDragImage):
(WebCore::dragImageSize):

  • platform/blackberry/EventLoopBlackBerry.cpp: Added.

(WebCore::EventLoop::platformInit):
(WebCore::EventLoop::cycle):

1:53 PM Changeset in webkit [101935] by kling@webkit.org
  • 9 edits in trunk

Cache CSSInitialValue instances per-document.
<​http://webkit.org/b/73745>

Reviewed by Oliver Hunt.

Source/WebCore:

Test: http/tests/security/cross-origin-css-primitive.html

Have CSSValuePool manage the caching of CSSInitialValue objects.

  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::createExplicit):
(WebCore::CSSInitialValue::createImplicit):
(WebCore::CSSInitialValue::CSSInitialValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseShorthand):

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::CSSValuePool):
(WebCore::CSSValuePool::createImplicitInitialValue):
(WebCore::CSSValuePool::createExplicitInitialValue):

  • css/CSSValuePool.h:

LayoutTests:

Test that 'initial' and 'inherit' values are cached per-document.

  • http/tests/security/cross-origin-css-primitive-expected.txt:
  • http/tests/security/cross-origin-css-primitive.html:
  • http/tests/security/resources/cross-origin-css-primitive-iframe.html:
1:45 PM Changeset in webkit [101934] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

Keep CSSInheritedValue in the CSS value pool.
<​http://webkit.org/b/73747>

Reviewed by Antti Koivisto.

We only need one CSSInheritedValue instance per document, so cache it
in CSSValuePool and have the parser create it through there.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::CSSValuePool):
(WebCore::CSSValuePool::createInheritedValue):

  • css/CSSValuePool.h:
12:06 PM Changeset in webkit [101933] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

[GTK] Implement History API FrameLoaderClient methods
​https://bugs.webkit.org/show_bug.cgi?id=59017

Patch by Xan Lopez <​xlopez@igalia.com> on 2011-12-03
Reviewed by Gustavo Noronha Silva.

Fake the load process when the new HTML5 History APIs are
used. Otherwise the UA does not have a chance of updating the URL
entry, back/forward buttons, etc.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidNavigateWithinPage): fake a
load process.
(WebKit::FrameLoaderClient::dispatchDidPushStateWithinPage): call
dispatchDidNavigateWithinPage.
(WebKit::FrameLoaderClient::dispatchDidReplaceStateWithinPage):
ditto.
(WebKit::FrameLoaderClient::dispatchDidPopStateWithinPage): do
nothing, because push was already called, but note this in a
comment.

  • WebCoreSupport/FrameLoaderClientGtk.h: add the new method.
10:19 AM Changeset in webkit [101932] by kling@webkit.org
  • 14 edits
    2 adds
    2 deletes in trunk/Source/WebCore

Rename CSSPrimitiveValueCache to CSSValuePool.
<​http://webkit.org/b/73742>

Reviewed by Antti Koivisto.

CSSPrimitiveValueCache -> CSSValuePool
Document::primitiveValueCache() -> Document::cssValuePool()

This is in preparation for sharing more than just primitive values.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorV8.pm:

(AddIncludesForType):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForNinePieceImageSlice):
(WebCore::valueForNinePieceImageQuad):
(WebCore::valueForNinePieceImageRepeat):
(WebCore::valueForNinePieceImage):
(WebCore::zoomAdjustedPixelValue):
(WebCore::zoomAdjustedNumberValue):
(WebCore::zoomAdjustedPixelValueForLength):
(WebCore::valueForReflection):
(WebCore::getPositionOffsetValue):
(WebCore::CSSComputedStyleDeclaration::currentColorOrValidColor):
(WebCore::getBorderRadiusCornerValue):
(WebCore::computedTransform):
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
(WebCore::valueForGridTrackList):
(WebCore::getDelayValue):
(WebCore::getDurationValue):
(WebCore::createLineBoxContainValue):
(WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
(WebCore::valueForFamily):
(WebCore::renderTextDecorationFlagsToCSSValue):
(WebCore::fillRepeatToCSSValue):
(WebCore::fillSizeToCSSValue):
(WebCore::contentToCSSValue):
(WebCore::counterToCSSValue):
(WebCore::fontFamilyFromStyle):
(WebCore::lineHeightFromStyle):
(WebCore::fontSizeFromStyle):
(WebCore::fontStyleFromStyle):
(WebCore::fontVariantFromStyle):
(WebCore::fontWeightFromStyle):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::createPrimitiveStringValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore::parseBackgroundClip):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parsePage):
(WebCore::CSSParser::parseSizeParameter):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseAttr):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::CSSParser::parseFillPositionX):
(WebCore::CSSParser::parseFillPositionY):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseAnimationDirection):
(WebCore::CSSParser::parseAnimationFillMode):
(WebCore::CSSParser::parseAnimationIterationCount):
(WebCore::CSSParser::parseAnimationName):
(WebCore::CSSParser::parseAnimationPlayState):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseAnimationTimingFunction):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseCounterContent):
(WebCore::CSSParser::parseShape):
(WebCore::CSSParser::parseWrapShape):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseFontFamily):
(WebCore::CSSParser::parseFontStyle):
(WebCore::CSSParser::parseFontVariant):
(WebCore::CSSParser::parseFontWeight):
(WebCore::CSSParser::parseColor):
(WebCore::ShadowParseContext::ShadowParseContext):
(WebCore::ShadowParseContext::commitLength):
(WebCore::ShadowParseContext::commitStyle):
(WebCore::CSSParser::parseShadow):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::parseFlex):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::BorderImageSliceParseContext::BorderImageSliceParseContext):
(WebCore::BorderImageSliceParseContext::commitNumber):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::BorderImageQuadParseContext::BorderImageQuadParseContext):
(WebCore::BorderImageQuadParseContext::commitNumber):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
(WebCore::CSSParser::parseBorderImageQuad):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseAspectRatio):
(WebCore::CSSParser::parseCounter):
(WebCore::parseDeprecatedGradientPoint):
(WebCore::parseDeprecatedGradientColorStop):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::valueFromSideKeyword):
(WebCore::parseGradientColorOrKeyword):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseCrossfade):
(WebCore::CSSParser::parseCustomFilter):
(WebCore::CSSParser::parseFilter):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::parseRegionThread):
(WebCore::CSSParser::parseTextEmphasisStyle):
(WebCore::CSSParser::parseFontFeatureSettings):

  • css/CSSParser.h:

(WebCore::CSSParser::cssValuePool):

  • css/CSSValuePool.cpp: Renamed from Source/WebCore/css/CSSPrimitiveValueCache.cpp.

(WebCore::CSSValuePool::CSSValuePool):
(WebCore::CSSValuePool::~CSSValuePool):
(WebCore::CSSValuePool::createIdentifierValue):
(WebCore::CSSValuePool::createColorValue):
(WebCore::CSSValuePool::createValue):

  • css/CSSValuePool.h: Renamed from Source/WebCore/css/CSSPrimitiveValueCache.h.

(WebCore::CSSValuePool::create):
(WebCore::CSSValuePool::createValue):

  • css/mediaControlsGtk.css:

(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):

  • dom/Document.cpp:

(WebCore::Document::cssValuePool):

  • dom/Document.h:
10:17 AM Changeset in webkit [101931] by Philippe Normand
  • 2 edits in trunk/Tools

Another GTK build fix after r101922.

Rubber-stamped by Martin James Robinson.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::pathToLocalResource): return value needs to
be a URI.

9:23 AM BuildingGtk edited by Martin Robinson
(diff)
8:37 AM Changeset in webkit [101930] by Martin Robinson
  • 2 edits in trunk/Tools

Small fix for my previous patch. Do not try to delete a member
of a dictionary that does not exist.

Reviewed by Gustavo Noronha Silva.

  • gtk/run-with-jhbuild:

(install_and_run_jhbuild):

7:55 AM Changeset in webkit [101929] by Martin Robinson
  • 2 edits in trunk/Tools

Fix jhbuild installation for people who have unusual MAKE environment
variables such as 'make -j4' as the jhbuild build does not handle it.

Reviewed by Gustavo Noronha Silva.

  • gtk/run-with-jhbuild:

(install_and_run_jhbuild): Remove any MAKE environment variable before building jhbuild.

7:39 AM Changeset in webkit [101928] by Martin Robinson
  • 2 edits in trunk/Tools

Fix the update-webkitgtk-libs script to properly trigger a jhbuild installation
when run for the first time.

Reviewed by Gustavo Noronha Silva.

  • Scripts/update-webkitgtk-libs: Fix first run.
6:07 AM Changeset in webkit [101927] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip new failing tests on GTK.

  • platform/gtk/Skipped: Skip 3 new

http/tests/security/mixedContent failing partly because of bug 73743.

5:55 AM Changeset in webkit [101926] by Philippe Normand
  • 2 edits in trunk/Tools

Unreviewed, GTK build fix after r101922.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::pathToLocalResource): Added sentinel in
g_build_filename call.

5:02 AM Changeset in webkit [101925] by Philippe Normand
  • 2 edits in trunk/Tools

GTK API tests build fix. Run the tests inside jhbuild.

Rubber-stamped by Gustavo Noronha Silva.

  • Scripts/run-gtk-tests:

(TestRunner.init):
(TestRunner.run._error_handler):
(TestRunner):
(TestRunner.run):

4:20 AM Changeset in webkit [101924] by kling@webkit.org
  • 5 edits in trunk/Source/WebCore

Shrink CSSValueList.
<​http://webkit.org/b/73732>

Reviewed by Antti Koivisto.

Packed CSSValueList::m_isSpaceSeparated into the CSSValue bit field
and renamed it to m_isSpaceSeparatedValue, shrinking CSSValueList
by one CPU word.

Also renamed CSSValue::m_isImplicit to m_isImplicitInitialValue
for good measure.

  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::CSSInitialValue):

  • css/CSSValue.h:

(WebCore::CSSValue::isImplicitInitialValue):
(WebCore::CSSValue::CSSValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::CSSValueList):
(WebCore::CSSValueList::copy):
(WebCore::CSSValueList::customCssText):

  • css/CSSValueList.h:

(WebCore::CSSValueList::isSpaceSeparated):

4:12 AM Changeset in webkit [101923] by Martin Robinson
  • 2 edits in trunk/Tools

Small build fix. Properly specify the path to the locally installed jhbuild.

  • Scripts/update-webkitgtk-libs: Fix jhbuild path.
3:33 AM Changeset in webkit [101922] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

[GTK][DRT] Normalize ​file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
​https://bugs.webkit.org/show_bug.cgi?id=67256

Patch by Martin Robinson <​mrobinson@igalia.com> on 2011-12-03
Reviewed by Philippe Normand.

Implement LayoutTestController::pathToLocalResource for GTK+. Instead of passing
WEBKIT_TEST_FONTS to the GTK+ test harnesses, pass a more generic WEBKIT_TOP_LEVEL,
which points to the more generic top-level path of the WebKit checkout. This code is
duplicated between WK1 and WK2 harnesses because we do not currently have a way to
share code here.

If WEBKIT_TOP_LEVEL is not provided, we search for the top level based on the binary
location. This will cause the fallback to fail if you build into a non-typical location
or even fake it with a symlink. In this case it's important to use the environment variable.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(getTopLevelPath): Added.
(initializeFonts): Use the new helper to get the font path.

  • DumpRenderTree/gtk/DumpRenderTreeGtk.h: Expose the new helper.
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::pathToLocalResource):Use the new helper to normalize
test paths.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.setup_environ_for_server):Pass the top-level path of the
checkout instead of passing the font path.

  • WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:

(WTR::getTopLevelPath): Added this helper.
(WTR::inititializeFontConfigSetting): Use the helper to find the font path.

3:26 AM BuildingGtk edited by kov@webkit.org
(diff)
3:19 AM BuildingGtk edited by Martin Robinson
Reorganize things (diff)
3:06 AM Changeset in webkit [101921] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r101858.

  • platform/gtk/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
2:39 AM BuildingGtk edited by kov@webkit.org
jhbuild update (diff)
2:29 AM WebKitGtkLayoutTests edited by kov@webkit.org
Document new jhbuild stuff (diff)
2:26 AM Changeset in webkit [101920] by Philippe Normand
  • 7 edits in trunk

[GStreamer] Fullscreen controller support for the new WebKit Fullscreen API
​https://bugs.webkit.org/show_bug.cgi?id=66968

Reviewed by Martin Robinson.

Source/WebCore:

  • GNUmakefile.am: Don't use the Quicktime fullscreen CSS anymore,

it wasn't suited for GTK in the first place anyway.

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::extraFullScreenStyleSheet): Simply reuse
GTK CSS.

Source/WebKit/gtk:

If the element being fullscreened is a video use the native
fullscreen controls.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::enterFullScreenForElement):
(WebKit::ChromeClient::exitFullScreenForElement):

LayoutTests:

  • platform/gtk/Skipped: Skip

fullscreen/video-controls-override.html now failing because of bug 73583.

1:44 AM Changeset in webkit [101919] by alex
  • 2 edits in trunk/Source/WebCore

2011-12-03 Alejandro G. Castro <​alex@igalia.com>

[GTK] TextureMapperNode should not use Qt types and functions
​https://bugs.webkit.org/show_bug.cgi?id=73713

Replace qreal with double and qMin with min.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperNode.cpp: (WebCore::solveCubicBezierFunction): (WebCore::solveStepsFunction):
1:36 AM Changeset in webkit [101918] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed weekend gardening.

  • platform/qt/Skipped: Skip new failing tests.
  • platform/qt/fast/css/font-face-opentype-expected.png: Updated.
  • platform/qt/fast/css/font-face-opentype-expected.txt: Updated.
1:22 AM Changeset in webkit [101917] by Martin Robinson
  • 6 edits in trunk

.: [GTK] Update required libsoup version
​https://bugs.webkit.org/show_bug.cgi?id=71611

Patch by Dan Winship <​danw@gnome.org> on 2011-12-03
Reviewed by Martin Robinson.

  • configure.ac: require libsoup 2.37.2.1 for SoupRequestHTTP API

changes

Source/WebCore: [GTK] Remove lots of code that is now unnecessary after
SoupRequestHTTP API changes.
​https://bugs.webkit.org/show_bug.cgi?id=71611

Patch by Dan Winship <​danw@gnome.org> on 2011-12-03
Reviewed by Martin Robinson.

No new tests; behavior is unchanged

  • platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal): remove
no-longer-needed fields.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::finishedCallback): remove this, and m_finished, which
we no longer need to explicitly track
(WebCore::statusWillBeHandledBySoup):
(WebCore::soupErrorShouldCauseLoadFailure): No longer needed;
SoupRequestHTTP's logic is now aligned with WebKit's.
(WebCore::gotChunkCallback): remove gotChunkCallback, which
is no longer needed
(WebCore::startHTTPRequest):
(WebCore::sendRequestCallback):
(WebCore::gotHeadersCallback):
(WebCore::contentSniffedCallback): merge the code from
gotHeadersCallback and contentSniffedCallback into
sendRequestCallback

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::updateFromSoupMessage): move the
sniffing override logic here

1:19 AM Changeset in webkit [101916] by Martin Robinson
  • 3 edits
    4 adds in trunk/LayoutTests

[GTK] [EFL] Update some cookie-related tests
​https://bugs.webkit.org/show_bug.cgi?id=73673

Patch by Dan Winship <​danw@gnome.org> on 2011-12-03
Reviewed by Martin Robinson.

  • platform/efl/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt:
  • platform/gtk/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt:

Copied from platform/chromium because libsoup also follows the RFC
6265 behavior.

  • platform/efl/Skipped:
  • platform/gtk/Skipped: Unskip that, and another cookie test that

has been fixed for a while.

1:06 AM Changeset in webkit [101915] by Csaba Osztrogonác
  • 4 edits in trunk

Unreviewed, rolling out r101904.
​http://trac.webkit.org/changeset/101904
​https://bugs.webkit.org/show_bug.cgi?id=73739

It broke zillions of tests on all bot (Requested by
Ossy_weekend on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-03

Source/WebCore:

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::handlePostMessage):

LayoutTests:

  • fast/dom/Window/window-postmessage-args-expected.txt:
Note: See TracTimeline for information about the timeline view.