⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 7, 2011:

11:53 PM Changeset in webkit [102320] by commit-queue@webkit.org
  • 5 edits in trunk

CSS color gets adjusted for disabled input elements
​https://bugs.webkit.org/show_bug.cgi?id=54643

Patch by Yosifumi Inoue <​yosin@chromium.org> on 2011-12-07
Reviewed by Kent Tamura.

Source/WebCore:

No new tests. covered by existing tests. Need rebasing some existing tests for Chromimum.

Remove automatic color adjustment for disabled text control for Chromimum.

  • css/themeChromium.css: Add CSS entries for default style for disabled input and textarea elements.
  • WebCore/rendering/RenderTextControl.cpp:

(disabledTextColor): Removed for PLATFORM(CHROMIUM)
(RenderTextControl::adjustInnerTextStyle): Don't call disabledTextColor for Chromium.

LayoutTests:

  • platform/chromium/test_expectations.txt: Add files need to be updated.
11:33 PM Changeset in webkit [102319] by mrowe@apple.com
  • 5 edits in trunk/Source

Fix the 32-bit build.

Ignore some warnings that only occur in 32-bit.

Source/WebKit/mac:

  • Plugins/WebNetscapePluginPackage.mm:

Source/WebKit2:

  • PluginProcess/mac/PluginProcessShim.mm:
  • Shared/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::NetscapePluginModule::tryLoad):

11:31 PM Changeset in webkit [102318] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Unreviewed buildfix after r102262.

  • Api/qwebelement.cpp:

(QWebElement::setStyleProperty):

10:59 PM Changeset in webkit [102317] by dslomov@google.com
  • 6 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=74038
[V8][Chromium] Support legacy argument order in window.postMessage/window.webkitPostMessage.

Reviewed by David Levin.

Source/WebCore:

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::isLegacyTargetOriginDesignation):
(WebCore::handlePostMessageCallback):

LayoutTests:

  • fast/dom/Window/window-postmessage-args-expected.txt:
  • fast/dom/Window/window-postmessage-args.html: New tests for legacy argument order.
  • platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
10:50 PM Changeset in webkit [102316] by bashi@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed, rebaseline media/controls-layout-direction.html

Patch by Kenichi Ishibashi <​bashi@chromium.org> on 2011-12-07

  • platform/chromium-cg-mac-snowleopard/media/controls-layout-direction-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/controls-layout-direction-expected.png: Added.
  • platform/chromium-win/media/controls-layout-direction-expected.png: Added.
10:29 PM Changeset in webkit [102315] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectation update.

Patch by Kenichi Ishibashi <​bashi@chromium.org> on 2011-12-07

  • platform/chromium/test_expectations.txt:
10:01 PM Changeset in webkit [102314] by commit-queue@webkit.org
  • 2 edits
    4 adds in trunk/Source/WebCore

Upstream 4 files into WebCore/platform/blackberry
​https://bugs.webkit.org/show_bug.cgi?id=73541

Patch by Mary Wu <​mary.wu@torchmobile.com.cn> on 2011-12-07
Reviewed by Antonio Gomes.

Initial upstream of BlackBerry porting of PlatformScreen/
SSLKeyGenerator/Sound/Widget, no new tests.

  • PlatformBlackBerry.cmake: Modified to remove empty file "WheelEventBlackBerry.cpp"
  • platform/blackberry/PlatformScreenBlackBerry.cpp: Added.

(WebCore::screenIsMonochrome):
(WebCore::screenDepthPerComponent):
(WebCore::screenDepth):
(WebCore::screenAvailableRect):
(WebCore::screenRect):

  • platform/blackberry/SSLKeyGeneratorBlackBerry.cpp: Added.

(WebCore::getSupportedKeySizes):
(WebCore::signedPublicKeyAndChallengeString):

  • platform/blackberry/SoundBlackBerry.cpp: Added.

(WebCore::systemBeep):

  • platform/blackberry/WidgetBlackBerry.cpp: Added.

(WebCore::Widget::Widget):
(WebCore::Widget::~Widget):
(WebCore::Widget::hide):
(WebCore::Widget::paint):
(WebCore::Widget::setCursor):
(WebCore::Widget::setFocus):
(WebCore::Widget::setFrameRect):
(WebCore::Widget::setIsSelected):
(WebCore::Widget::show):
(WebCore::Widget::frameRect):

9:38 PM Changeset in webkit [102313] by bashi@chromium.org
  • 4 edits
    2 adds in trunk

Refactor CSSParser::parseFontFaceSrc()
​https://bugs.webkit.org/show_bug.cgi?id=73989

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/font-face-src-parsing.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFontFaceSrcURI): Added.
(WebCore::CSSParser::parseFontFaceSrcLocal): Added.
(WebCore::CSSParser::parseFontFaceSrc): Rewrote.

  • css/CSSParser.h:

LayoutTests:

Added a test that checks parsing result of the src descriptor of @font-face.

  • fast/css/font-face-src-parsing-expected.txt: Added.
  • fast/css/font-face-src-parsing.html: Added.
9:23 PM Changeset in webkit [102312] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Implement the SSE optimization in SincResampler::process()
​https://bugs.webkit.org/show_bug.cgi?id=73789

Patch by Xingnan Wang <​xingnan.wang@intel.com> on 2011-12-07
Reviewed by Benjamin Poulain.

Here is about 70% performance improvement on the hot spot of sample convolving.

  • platform/audio/SincResampler.cpp:
9:08 PM Changeset in webkit [102311] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement border image source properties in CSSStyleApplyProperty.
​https://bugs.webkit.org/show_bug.cgi?id=73981

Reviewed by Andreas Kling.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyBorderImageSource::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

8:58 PM Changeset in webkit [102310] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

WebPImageDecoder should not do a full image decode if progressive decoding is active
​https://bugs.webkit.org/show_bug.cgi?id=74041

Reviewed by Adam Barth.

If the decoder input data state reaches allDataReceived during a progressive image
decode, the decoder performs a full image decode.

On allDataReceived, check if we already have a decoder, and if so, continue to run
the progressive decoder.

No new tests. No change in behavior.

  • platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::decode):

8:42 PM Changeset in webkit [102309] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations update.

Patch by Kenichi Ishibashi <​bashi@chromium.org> on 2011-12-07

  • platform/chromium/test_expectations.txt:
8:35 PM Changeset in webkit [102308] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk/Source

[chromium] Add page-scale animation support to Impl thread
​https://bugs.webkit.org/show_bug.cgi?id=72996

Patch by Alexandre Elias <​aelias@google.com> on 2011-12-07
Reviewed by James Robinson.

This adds a new math helper class to compute the progress of the
animation, and code in the CCLayerTreeHostImpl to apply the animation
frame by frame.

No new tests. (​https://bugs.webkit.org/show_bug.cgi?id=71529 filed.)

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCInputHandler.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::animate):
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCPageScaleAnimation.cpp: Added.

(WebCore::CCPageScaleAnimation::CCPageScaleAnimation):
(WebCore::CCPageScaleAnimation::initialize):
(WebCore::CCPageScaleAnimation::zoomTo):
(WebCore::CCPageScaleAnimation::zoomWithAnchor):
(WebCore::CCPageScaleAnimation::zoomElsewhere):
(WebCore::CCPageScaleAnimation::scrollOffsetAtTime):
(WebCore::CCPageScaleAnimation::pageScaleAtTime):
(WebCore::CCPageScaleAnimation::isAnimationCompleteAtTime):
(WebCore::CCPageScaleAnimation::progressRatioForTime):
(WebCore::CCPageScaleAnimation::scrollOffsetAtRatio):
(WebCore::CCPageScaleAnimation::pageScaleAtRatio):

  • platform/graphics/chromium/cc/CCPageScaleAnimation.h: Added.

(WebCore::CCPageScaleAnimation::startTime):
(WebCore::CCPageScaleAnimation::duration):
(WebCore::CCPageScaleAnimation::endTime):
(WebCore::CCPageScaleAnimation::finalScrollOffset):
(WebCore::CCPageScaleAnimation::finalPageScale):

Source/WebKit/chromium:

  • public/WebCompositor.h:
  • public/WebInputEvent.h:

(WebKit::WebPageScaleAnimationEvent::WebPageScaleAnimationEvent):

  • public/android/WebInputEventFactory.h:
  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositorImpl::handlePageScaleAnimationEvent):

  • src/WebCompositorImpl.h:
  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/android/WebInputEventFactory.cpp:

(WebKit::WebInputEventFactory::pageScaleAnimationEvent):

8:25 PM Changeset in webkit [102307] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Editor::markAndReplaceFor should take Range instead of TextCheckingParagraph.
​https://bugs.webkit.org/show_bug.cgi?id=74035

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-12-07
Reviewed by Hajime Morita.

Editor::markAndReplaceFor takes chekcing range and paragraph range instead of
spelling paragraph and grammar paragraph.

No new tests. Covered by existing tests.

  • editing/Editor.cpp:

(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
(WebCore::Editor::markAndReplaceFor):

  • editing/Editor.h:
  • editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingParagraph::TextCheckingParagraph):

  • editing/TextCheckingHelper.h:
8:13 PM Changeset in webkit [102306] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Force LTR layout for media controls even in RTL documents.
​https://bugs.webkit.org/show_bug.cgi?id=74024

Patch by Ami Fischman <​fischman@chromium.org> on 2011-12-07
Reviewed by Darin Adler.

Source/WebCore:

Test: media/controls-layout-direction.html

  • css/mediaControls.css:

(::-webkit-media-controls):

LayoutTests:

  • media/controls-layout-direction-expected.txt: Added.
  • media/controls-layout-direction.html: Added.
  • platform/chromium-linux/media/controls-layout-direction-expected.png: Added.
7:55 PM Changeset in webkit [102305] by commit-queue@webkit.org
  • 6 edits in trunk

[FileSystem API] requestFileSystem successCallback is required
​https://bugs.webkit.org/show_bug.cgi?id=69637

Patch by Mark Pilgrim <​pilgrim@chromium.org> on 2011-12-07
Reviewed by Darin Adler.

Source/WebCore:

  • page/DOMWindow.idl: remove [Optional] flag from successCallback parameter

LayoutTests:

  • fast/filesystem/filesystem-no-callback-null-ptr-crash.html: fix now-broken logic testing for unrelated bug
  • fast/filesystem/not-enough-arguments-expected.txt:
  • fast/filesystem/not-enough-arguments.html: add checks for webkitRequestFileSystem with not enough parameters
7:43 PM Changeset in webkit [102304] by simonjam@chromium.org
  • 2 edits
    6 adds in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline width-overflow.html and fix test_expectations.txt

  • platform/chromium-cg-mac/printing/width-overflow-expected.png: Added.
  • platform/chromium-cg-mac/printing/width-overflow-expected.txt: Added.
  • platform/chromium-mac-snowleopard/printing/width-overflow-expected.png: Added.
  • platform/chromium-mac-snowleopard/printing/width-overflow-expected.txt: Added.
  • platform/chromium-win/printing/width-overflow-expected.png: Added.
  • platform/chromium-win/printing/width-overflow-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
7:38 PM Changeset in webkit [102303] by leo.yang@torchmobile.com.cn
  • 1 edit
    7 adds in trunk/Source/WebCore

Upstream the BlackBerry porting of network Resource
​https://bugs.webkit.org/show_bug.cgi?id=73388

Reviewed by Rob Buis.

Other main contributors:
Joe Mason <​jmason@rim.com>
Yong Li <​yoli@rim.com>
Gary Simmons <​gsimmons@rim.com>
Genevieve Mak <​gmak@rim.com>
Chris Guan <​chris.guan@torchmobile.com.cn>
Mike Lattanzio <​mlattanzio@rim.com>

Initial upstream, can't be built yet, no new tests.

  • platform/network/blackberry/ResourceError.h: Added.
  • platform/network/blackberry/ResourceErrorBlackBerry.cpp: Added.
  • platform/network/blackberry/ResourceHandleBlackBerry.cpp: Added.
  • platform/network/blackberry/ResourceRequest.h: Added.
  • platform/network/blackberry/ResourceRequestBlackBerry.cpp: Added.
  • platform/network/blackberry/ResourceResponse.h: Added.
  • platform/network/blackberry/ResourceResponseBlackBerry.cpp: Added.
7:11 PM Changeset in webkit [102302] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG CSE should know that CheckFunction is pure
​https://bugs.webkit.org/show_bug.cgi?id=74044

Reviewed by Oliver Hunt.

Possible slight win on V8, no regressions.

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::checkFunctionElimination):

7:03 PM Changeset in webkit [102301] by fsamuel@chromium.org
  • 17 edits in trunk/Source

[Chromium] Plumb DPI info into PlatformScreen
​https://bugs.webkit.org/show_bug.cgi?id=70556

Source/WebCore:

Reviewed by Darin Fisher.

Make DPI information accessible from WebKit through
PlatformScreen. This is useful when making scaling
computations on various devices (e.g. Viewport meta tag).

This patch adds DPI plumbing on Chromium Win/Mac/Linux
platforms.

  • page/Screen.cpp:

(WebCore::Screen::horizontalDPI):
(WebCore::Screen::verticalDPI):

  • page/Screen.h:
  • platform/PlatformScreen.h:
  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):

  • platform/chromium/PlatformSupport.h:
  • platform/efl/PlatformScreenEfl.cpp:

(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):

  • platform/gtk/PlatformScreenGtk.cpp:

(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):

  • platform/mac/PlatformScreenMac.mm:

(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):

  • platform/qt/PlatformScreenQt.cpp:

(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):

  • platform/win/PlatformScreenWin.cpp:

(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):

Source/WebKit/chromium:

Reviewed by Darin Fisher.

Make DPI information accessible from WebKit through
PlatformScreen. This is useful when making scaling
computations on various devices (e.g. Viewport meta tag).

This patch adds DPI plumbing on Chromium Win/Mac/Linux
platforms.

  • public/WebScreenInfo.h:

(WebKit::WebScreenInfo::WebScreenInfo):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::screenHorizontalDPI):
(WebCore::PlatformSupport::screenVerticalDPI):

  • src/mac/WebScreenInfoFactory.mm:

(WebKit::WebScreenInfoFactory::screenInfo):

  • src/win/WebScreenInfoFactory.cpp:

(WebKit::WebScreenInfoFactory::screenInfo):

  • src/x11/WebScreenInfoFactory.cpp:

(WebKit::WebScreenInfoFactory::screenInfo):

6:45 PM Changeset in webkit [102300] by commit-queue@webkit.org
  • 10 edits
    15 deletes in trunk

Revert mixed content handling for video fix and follow-up test expectations & Skipped changes.
(r101883, r101918, r101927, r101981, r101986, r101997)
​https://bugs.webkit.org/show_bug.cgi?id=72178

Patch by Aaron Colwell <​acolwell@chromium.org> on 2011-12-07
Reviewed by Adam Barth.

Source/WebCore:

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

  • loader/cache/CachedRawResource.cpp:
  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp:

(WebCore::defaultPriorityForResourceType):
(WebCore::cachedResourceTypeToTargetType):

  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::checkInsecureContent):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):

LayoutTests:

  • http/tests/security/mixedContent/insecure-video-in-iframe-expected.txt: Removed.
  • http/tests/security/mixedContent/insecure-video-in-iframe.html: Removed.
  • http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
  • http/tests/security/mixedContent/insecure-video-in-main-frame.html: Removed.
  • http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.
  • http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame.html: Removed.
  • http/tests/security/mixedContent/redirect-https-to-http-video-in-main-frame-expected.txt: Removed.
  • http/tests/security/mixedContent/redirect-https-to-http-video-in-main-frame.html: Removed.
  • http/tests/security/mixedContent/resources/frame-with-insecure-video.html: Removed.
  • http/tests/security/mixedContent/resources/frame-with-redirect-http-to-https-video.html: Removed.
  • http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-video.html: Removed.
  • platform/chromium-cg-mac-snowleopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
6:27 PM Changeset in webkit [102299] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Qt] Follow up of r102226.
​https://bugs.webkit.org/show_bug.cgi?id=73987

  • platform/qt-5.0/Skipped: Renamed three number tests.
6:19 PM Changeset in webkit [102298] by msaboff@apple.com
  • 8 edits in trunk

StringBuilderTest.Append and StringBuilderTest.ToStringPreserveCapacity are failing.
​https://bugs.webkit.org/show_bug.cgi?id=73995

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Problem was that a call to characters on an StringImpl associated
with a StringBuilder that is being appended to gets stale.
Added a new m_valid16BitShadowlen that keeps the length of
the 16 bit shadow that has been upconverted or will be up converted
with the first getCharacters(). When StringBuilder::characters or
::reifyString is called, further characters are upconverted if
we have a shadow16bit copy and the m_valid16BitShadowlen is updated.

(WTF::StringBuilder::reifyString):

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::StringBuilder):
(WTF::StringBuilder::characters):
(WTF::StringBuilder::clear): Cleaned up as part of the change.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::getData16SlowCase):
(WTF::StringImpl::upconvertCharacters):

  • wtf/text/StringImpl.h:

Tools:

Reenabled failing tests that the code part of the patch fixes.

Reviewed by Geoffrey Garen.

  • TestWebKitAPI/Tests/WTF/StringBuilder.cpp:

(TestWebKitAPI::TEST):

6:11 PM Changeset in webkit [102297] by ryuan.choi@samsung.com
  • 8 edits
    1 add in trunk/Source

[EFL] Introduce AssertMatchingEnums.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=65238

Reviewed by Filip Pizlo.

Source/WebCore:

Remove switch statement which convert EWK_TOUCH_PointType enum values to
WebCore::PlatformTouchPoint::State enum values.
Newly added AssertMatchingEnums.cpp assure that they are equal.

No new tests, no new functionality.

  • platform/efl/PlatformTouchEventEfl.cpp:

(WebCore::PlatformTouchEvent::PlatformTouchEvent):

Source/WebKit/efl:

Add AssertMatchingEnums.cpp to assert that various WebKit API enum values
match to WebCore defined enum values.

  • CMakeListsEfl.txt: add AssertMatchingEnums.cpp.
  • WebCoreSupport/AssertMatchingEnums.cpp: Added.
  • ewk/ewk_frame.cpp:

(ewk_frame_feed_touch_event): remove switch statement wichi convert WebKit API enum value to WebCore defined enum values.
(ewk_frame_text_selection_type_get): Ditto.

  • ewk/ewk_view.cpp:

(ewk_view_mode_set): Ditto.
(ewk_view_mode_get): Ditto.
(ewk_view_visibility_state_set): Ditto.
(ewk_view_visibility_state_get): Ditto.

  • ewk/ewk_frame.h: fix order of enum values.
  • ewk/ewk_view.h: add missing enum value.
6:09 PM Changeset in webkit [102296] by morrita@google.com
  • 2 edits in trunk/Tools

[filter-build-webkit] should not emit reset color when --no-color is given
​https://bugs.webkit.org/show_bug.cgi?id=73992

Reviewed by Daniel Bates.

Stop printing control sequences when --no-color is given.
After this change, the filter runs nicely even on environments
like Emacs compilation-mode which cannot understand the control sequence.

  • Scripts/filter-build-webkit:

(printLine):

6:09 PM Changeset in webkit [102295] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Compare and Swap should be enabled on ARMv7
​https://bugs.webkit.org/show_bug.cgi?id=74023

Reviewed by Geoff Garen.

Implemented weakCompareAndSwap in terms of LDREX/STREX and enabled PARALLEL_GC.
It gives the expected speed-up on multi-core ARMv7 devices.

  • wtf/Atomics.h:

(WTF::weakCompareAndSwap):

  • wtf/Platform.h:
6:02 PM Changeset in webkit [102294] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] Clearing root surface should happen after damage tracking
​https://bugs.webkit.org/show_bug.cgi?id=73958

Patch by Shawn Singh <​shawnsingh@chromium.org> on 2011-12-07
Reviewed by James Robinson.

No new semantics, covered by existing layout tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::clearSurfaceForDebug):
(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerRendererChromium.h:
6:01 PM Changeset in webkit [102293] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG CSE is overzealous with GetByVal
​https://bugs.webkit.org/show_bug.cgi?id=74042

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Made sure that the purity of GetByVal and the limited-clobber-itude of PutByVal
is tested in all places that matter.

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::byValIsPure):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/js/dfg-get-by-val-getter-cse-expected.txt: Added.
  • fast/js/dfg-get-by-val-getter-cse.html: Added.
  • fast/js/script-tests/dfg-get-by-val-getter-cse.js: Added.

():

5:53 PM Changeset in webkit [102292] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Preserve original pageScale limits in WebViewImpl
​https://bugs.webkit.org/show_bug.cgi?id=72983

Patch by Alexandre Elias <​aelias@google.com> on 2011-12-07
Reviewed by Darin Fisher.

Preserve the originally viewport-tag specified page scale limits, and
compute the final ones in a new private method
computePageScaleFactorLimits(). This is then called when contents
size change (which can affect the minimum).

Also clean up several minor bugs, namely clamping issues (reorder
clampNegativeToZero to avoid negative scroll offsets, and force max to
be greater than min), and incorrect behavior in the presence of
"solid" scrollbars.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::contentsSizeChanged):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::clampPageScaleFactorToLimits):
(WebKit::WebViewImpl::clampOffsetAtScale):
(WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset):
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::setPageScaleFactorLimits):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
(WebKit::WebViewImpl::didChangeContentsSize):

  • src/WebViewImpl.h:
5:50 PM Changeset in webkit [102291] by eric@webkit.org
  • 5 edits in trunk/Tools

Use free memory to determine if we have space for DRT instances instead of total memory
​https://bugs.webkit.org/show_bug.cgi?id=74021

Reviewed by Adam Barth.

This will hopefully make the Mac buildbots behave better.

I also reduced the expected memory needed per DRT now that
we're properly accounting for the system memory in our calculations.

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.total_bytes_memory):
(PlatformInfo._compute_free_bytes_from_vm_stat_output):

  • Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.total_bytes_memory):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.default_child_processes):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_default_child_processes):

5:44 PM Changeset in webkit [102290] by commit-queue@webkit.org
  • 6 edits in trunk

<li value="0"> behaves like <li> (the same for negative numbers)
​https://bugs.webkit.org/show_bug.cgi?id=73911

Patch by Florin Malita <​fmalita@google.com> on 2011-12-07
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Allow LI values <= 0 and consolidate the value processing logic.

  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::parseMappedAttribute):
Delegated value parsing to parseValue().

(WebCore::HTMLLIElement::attach):
Ditto. Explicit value null testing is no longer necessary,
as parseValue's toInt() performs an equivalent check.

(WebCore::HTMLLIElement::parseValue):
Consolidated value parsing logic.

  • html/HTMLLIElement.h:

LayoutTests:

Added tests for values <= 0.

  • fast/lists/li-values-expected.txt:
  • fast/lists/li-values.html:
5:33 PM Changeset in webkit [102289] by commit-queue@webkit.org
  • 4 edits in trunk/Source

IndexedDB: Replace bool args in IDBKeyRange private methods with enum
​https://bugs.webkit.org/show_bug.cgi?id=70743

Patch by Joshua Bell <​jsbell@chromium.org> on 2011-12-07
Reviewed by Tony Chang.

No new tests - no functional changes.

  • storage/IDBKeyRange.cpp:

(WebCore::IDBKeyRange::IDBKeyRange):
(WebCore::IDBKeyRange::bound):

  • storage/IDBKeyRange.h:

(WebCore::IDBKeyRange::create):
(WebCore::IDBKeyRange::lowerOpen):
(WebCore::IDBKeyRange::upperOpen):

5:19 PM Changeset in webkit [102288] by Lucas Forschler
  • 2 edits in branches/safari-534.53-branch/Source/WebCore

Fix a compiler error about implicit conversion from 64 to 32bit int.

Reviewed by Beth Dakin.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):

4:52 PM Changeset in webkit [102287] by kerz@chromium.org
  • 1 add in branches/chromium/963/codereview.settings

add codereview settings file

4:49 PM Changeset in webkit [102286] by kerz@chromium.org
  • 3 edits in branches/chromium/963/Source/WebCore

Merge 102180 - [chromium] Don't crash if tile upload happens without painting first
​https://bugs.webkit.org/show_bug.cgi?id=73939

Reviewed by James Robinson.

Remove at least one place (in ImageLayerChromium) where this could
happen.

Although this shouldn't happen, we should be robust to it in the
chance that other code causes it to.

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateCompositorResources):

TBR=​enne@google.com

4:45 PM Changeset in webkit [102285] by Lucas Forschler
  • 4 edits in branches/safari-534.53-branch/Source

Merged r99617.

4:35 PM Changeset in webkit [102284] by Lucas Forschler
  • 17 edits in branches/safari-534.53-branch/Source

Merge 99493

4:32 PM Changeset in webkit [102283] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Exposing boundsInScreenSpace in WebElement.
​https://bugs.webkit.org/show_bug.cgi?id=71579

Exposing boundsInScreenSpace through a new function,
boundsInViewportSpace, to assist in moving the Autofill UI out of
WebKit in Chromium. Renamed the exposed function to provide a better
meaning of what the function does in the Chromium code.
More information can be found at:
​http://crbug.com/51644

Patch by Chris Sharp <​csharp@chromium.org> on 2011-12-07
Reviewed by Darin Fisher.

  • public/WebElement.h:
  • src/WebElement.cpp:

(WebKit::WebElement::boundsInViewportSpace):

4:28 PM Changeset in webkit [102282] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Unreviewed, rolling out r102267.
​http://trac.webkit.org/changeset/102267
​https://bugs.webkit.org/show_bug.cgi?id=74032

Breaks build on Chromium Mac Debug (Requested by aklein on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-07

Source/JavaScriptCore:

  • wtf/HashTraits.h:

Source/WebCore:

  • dom/ChildListMutationScope.cpp:

(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::childAdded):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::willRemoveChild):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::decrementScopingLevel):

4:25 PM Changeset in webkit [102281] by haraken@chromium.org
  • 9 edits
    6 adds in trunk

REGRESSION (r95249): Right side can be truncated when printing
​https://bugs.webkit.org/show_bug.cgi?id=73868

Reviewed by Darin Adler.

Source/WebCore:

When we print a page with an overflowed width, the right side of the page
can be truncated. This is due to a wrong rendering calculation.
Since 'maximumShrinkFactor' is a ratio based on 'pageSize',
'maximumShrinkFactor' should multiply (not 'originalPageSize') but 'pageSize'.
This bug happens if all the following conditions are met:

  • pageLogicalWidth < docLogicalWidth
  • originalPageSize.width * maximumShrinkFactor < docLogicalWidth
  • docLogicalWidth < pageLogicalWidth * maximumShrinkFactor

Test: printing/width-overflow.html

  • page/FrameView.cpp:

(WebCore::FrameView::forceLayoutForPagination):

LayoutTests:

width-overflow.html checks if the page is printed without its right side
being truncated.

  • printing/width-overflow.html: Added.
  • platform/chromium-linux/printing/width-overflow-expected.png: Added.
  • platform/chromium-linux/printing/width-overflow-expected.txt: Added.
  • platform/mac-snowleopard/printing/width-overflow-expected.png: Added.
  • platform/mac-snowleopard/printing/width-overflow-expected.txt: Added.
  • platform/efl/Skipped: Skips width-overflow.html, since layoutTestController.setPrinting() is not implemented.
  • platform/gtk/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
  • platform/wincairo/Skipped: Ditto.
  • platform/wk2/Skipped: Ditto.
4:12 PM Changeset in webkit [102280] by dpranke@chromium.org
  • 2 edits in trunk/Tools

fix build-webkit --chromium after breakage in r102201
​https://bugs.webkit.org/show_bug.cgi?id=74031

Reviewed by Tony Chang.

r102201 introduced a change to the chromium build that splits
the executables out of WebKit.gyp into other gyp files, and adds
a new "All.gyp" that builds everything. However, I forgot to
update the build script to use All.gyp.

  • Scripts/webkitdirs.pm:

(buildChromium):

3:43 PM Changeset in webkit [102279] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, skip a test that may be causing Win DRT to hang.

  • platform/chromium/test_expectations.txt:
3:41 PM Changeset in webkit [102278] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk

Defer ScriptExecutionContext::Task's in Document when page loading is deferred.
Schedule them with timer when page loading is resumed. The tasks will be performed
in the original order. This fixes the problem that database callbacks could be missed
when page loading was deferred.
​https://bugs.webkit.org/show_bug.cgi?id=49401

Patch by Yong Li <​yoli@rim.com> on 2011-12-07
Reviewed by Darin Adler.

Manual test added: ManualTests/database-callback-deferred.html.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::didReceiveTask):
(WebCore::Document::postTask):
(WebCore::Document::pendingTasksTimerFired):
(WebCore::Document::suspendScheduledTasks):
(WebCore::Document::resumeScheduledTasks):

  • dom/Document.h:
  • page/PageGroupLoadDeferrer.cpp:

(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

2:48 PM Changeset in webkit [102277] by Lucas Forschler
  • 3 edits in branches/safari-534.53-branch/Source/WebKit2

Merged r99090.

2:47 PM Changeset in webkit [102276] by Lucas Forschler
  • 6 edits in branches/safari-534.53-branch/Source

Merged r98892.

2:46 PM Changeset in webkit [102275] by adamk@chromium.org
  • 4 edits in trunk

[MutationObservers] Enable in Chromium trunk
​https://bugs.webkit.org/show_bug.cgi?id=73851

Reviewed by Ojan Vafai.

Source/WebKit/chromium:

Re-landing after fixing Chromium unit test crashes in r102171
and inspector debugger crash in r102264.

  • features.gypi:

LayoutTests:

  • platform/chromium/test_expectations.txt: Stop skipping fast/mutation tests.
2:45 PM Changeset in webkit [102274] by Lucas Forschler
  • 8 edits in branches/safari-534.53-branch/Source/WebKit2

Merged r98873.

2:43 PM Changeset in webkit [102273] by Lucas Forschler
  • 11 edits in branches/safari-534.53-branch/Source

Merged r98664.

2:37 PM Changeset in webkit [102272] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, clean out passing tests from test_expectations.txt

  • platform/chromium/test_expectations.txt:
2:36 PM Changeset in webkit [102271] by Lucas Forschler
  • 8 edits in branches/safari-534.53-branch/Source

Merge 97514. needed for 98664.

1:43 PM Changeset in webkit [102270] by Lucas Forschler
  • 10 edits in branches/safari-534.53-branch/Source/WebKit2

Merged r98646.

1:18 PM Changeset in webkit [102269] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

IndexedDB deleteIndex should throw NOT_ALLOWED_ERR if called outside a VERSION_CHANGE transaction callback
​https://bugs.webkit.org/show_bug.cgi?id=62370

Already behaves correctly, just adding tests.

Patch by Joshua Bell <​jsbell@chromium.org> on 2011-12-07
Reviewed by Tony Chang.

  • storage/indexeddb/deleteIndex-expected.txt: Added.
  • storage/indexeddb/deleteIndex.html: Added.
1:10 PM Changeset in webkit [102268] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

RenderObject::style(): Inline early-return condition.
<​http://webkit.org/b/74019>

Reviewed by Anders Carlsson.

style() was very hot (6.1%) when scrolling around on youtube.com,
and 100% of the calls were taking the early return path.

Inlined the !isRenderFlowThread() check and renamed the function to
styleSlowCase().

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleSlowCase):

  • rendering/RenderObject.h:

(WebCore::RenderObject::style):

1:01 PM Changeset in webkit [102267] by adamk@chromium.org
  • 4 edits in trunk/Source

Use HashMap<Node*, OwnPtr<...>> in ChildListMutationScope
​https://bugs.webkit.org/show_bug.cgi?id=73964

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

  • wtf/HashTraits.h: Add passOut(std::nullptr_t) to allow callers to use HashMap::take on an entry whose value is null.

Source/WebCore:

No new tests, refactoring only.

  • dom/ChildListMutationScope.cpp:

(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::childAdded):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::willRemoveChild):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::incrementScopingLevel):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::decrementScopingLevel):

12:59 PM Changeset in webkit [102266] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

RenderLayer::updateZOrderLists(): Inline early-return condition.
<​http://webkit.org/b/74013>

Reviewed by Anders Carlsson.

updateZOrderLists() was hot (1.2%) when scrolling around on youtube.com,
and 85% of the calls were taking the early return path.

Inlined the two checks for the early return and renamed the function
to updateZOrderListsSlowCase(). Also reversed their order to avoid the
virtual call (RenderObject::isRenderView()) if possible.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateZOrderListsSlowCase):

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::updateZOrderLists):

12:08 PM Changeset in webkit [102265] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed, rolling out r102244.
​http://trac.webkit.org/changeset/102244
​https://bugs.webkit.org/show_bug.cgi?id=74016

caused debug test timeouts (Requested by simonjam on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-07

Source/WebCore:

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::putImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):

LayoutTests:

  • platform/chromium/test_expectations.txt:
12:03 PM Changeset in webkit [102264] by adamk@chromium.org
  • 5 edits in trunk

Layout Test inspector/debugger/dom-breakpoints.html fails on chromium linux debug with ENABLE(MUTATION_OBSERVERS)
​https://bugs.webkit.org/show_bug.cgi?id=73919

Reviewed by Ojan Vafai.

Source/WebCore:

Use StyleAttributeMutationScope to manage DOM breakpoints for style property changes.

Instead of calling InspectorInstrumentation::didInvalidateStyleAttr()
directly in setNeedsStyleRecalc, set a bool in the current
StyleAttributeMutationScope, and delay the call until the scope's
counter runs down to zero. This keeps the inspector JS from re-entering
CSSMutableStyleDeclaration until all StyleAttributeMutationScope work is done.

Also fix a small bug in StyleAttributeMutationScope, where
s_shouldDeliver wasn't getting reset properly to false.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):

LayoutTests:

Added test that no-op style mutations don't create MutationRecords.

  • fast/mutation/observe-attributes-expected.txt:
  • fast/mutation/observe-attributes.html:
12:01 PM Changeset in webkit [102263] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash from multicol spans with layers
​https://bugs.webkit.org/show_bug.cgi?id=68030

Patch by Ken Buchanan <​kenrb@chromium.org> on 2011-12-07
Reviewed by David Hyatt.

Source/WebCore:

The layer tree diverges from the render tree when a span is being split
between columns. This patch causes the layer tree to be updated when necessary.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitFlow)
(WebCore::RenderBlock::splitBlocks)

LayoutTests:

New test for fix to crash on bug 68030.

  • fast/multicol/span/removal-of-multicol-span-crash-expected.txt: Added
  • fast/multicol/span/removal-of-multicol-span-crash.html: Added
11:53 AM Changeset in webkit [102262] by ap@apple.com
  • 10 edits
    1 add
    14 deletes in trunk

Handling of !important in inline style sets is broken
​https://bugs.webkit.org/show_bug.cgi?id=73941

Reviewed by Dave Hyatt.

This behavior was introduced in bug 8223 to match IE and Firefox. But it doesn't appear that we're matching
any browser today, and CSSOM spec agrees with them.

  • WebCore.exp.in: Don't export CSSStyleDeclaration::setProperty(), no one is using it.
  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::putDelegate): Use regular setProperty(), not the incorrect version that's being removed. Properties set via IDL attributes are never important.
  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: (WebCore::V8CSSStyleDeclaration::namedPropertySetter): Made the same fix for v8. Why did v8 bindings authors copy/paste the code?!
  • css/CSSStyleDeclaration.cpp:
  • css/CSSStyleDeclaration.h: Removed a version of setProperty() that attempted to parse the value and extract !important from it.
  • html/ImageDocument.cpp: (WebCore::ImageDocument::resizeImageToFit): (WebCore::ImageDocument::restoreImageSize): (WebCore::ImageDocument::windowSizeChanged):
  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag): We never needed to use this version of setProperty() here, it was just unnecessarily slower.
11:52 AM Changeset in webkit [102261] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Non-Mac devices should benefit from a larger heap
​https://bugs.webkit.org/show_bug.cgi?id=74015

Reviewed by Geoff Garen.

Removed the ENABLE(LARGE_HEAP) option from Platform.h, since it was only used in
Heap.cpp, and got in the way of having more granular, per-platform control over
what the heap size should be. Bumped the heap size to 8MB on iOS (was 512KB).

  • heap/Heap.cpp:

(JSC::GCTimer::heapSizeForHint):

  • wtf/Platform.h:
11:45 AM Changeset in webkit [102260] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

IndexedDB objectStoreNames not updated after aborted transaction
​https://bugs.webkit.org/show_bug.cgi?id=58655

Already functional but there wasn't a test with these specifics.

Patch by Joshua Bell <​jsbell@chromium.org> on 2011-12-07
Reviewed by Tony Chang.

  • storage/indexeddb/mozilla/versionchange-abort-expected.txt: Added.
  • storage/indexeddb/mozilla/versionchange-abort.html: Added.
11:34 AM Changeset in webkit [102259] by Lucas Forschler
  • 2 edits in branches/safari-534.53-branch/Source/WebKit2

Merged r98438.

11:32 AM Changeset in webkit [102258] by Lucas Forschler
  • 2 edits in branches/safari-534.53-branch/Source/WebKit2

Merged r98437.

11:31 AM Changeset in webkit [102257] by Lucas Forschler
  • 2 edits in branches/safari-534.53-branch/Source/WebKit2

Merged r98435.

11:29 AM Changeset in webkit [102256] by Lucas Forschler
  • 3 edits in branches/safari-534.53-branch/Source/WebKit2

Merged r98416.

11:21 AM Changeset in webkit [102255] by wangxianzhu@chromium.org
  • 2 edits in trunk/Source/WebCore

In FontCacheAndroid.cpp should keep the pointer valid returned from CString::data()
​https://bugs.webkit.org/show_bug.cgi?id=73849

The changed code has been covered by many existing layout tests.

Reviewed by Adam Barth.

  • platform/graphics/chromium/FontCacheAndroid.cpp:

(WebCore::FontCache::createFontPlatformData):

11:19 AM Changeset in webkit [102254] by Lucas Forschler
  • 17 edits in branches/safari-534.53-branch

Merged r98413.

11:06 AM Changeset in webkit [102253] by Lucas Forschler
  • 9 edits in branches/safari-534.53-branch/Source

Merged r98406.

11:05 AM Changeset in webkit [102252] by xji@chromium.org
  • 21 edits
    2 adds in trunk

Source/WebCore: Turn on move caret by word visually for Windows platform.
​https://bugs.webkit.org/show_bug.cgi?id=59652

Reviewed by Ryosuke Niwa.

We already support (arrow key) moving cursor by character in visual order.
This patch implements (ctrl/alt-arrow) moving cursor by word in visual order (in Windows).
It matches Firefox's default behavior.

Without this patch, ctrl(alt for mac)-arrow key or
selection.modify("move", "left"/"right", "word") moves cursor by word in logical order.

IE implements moving cursor by logical order for both arrow key and ctrl-arrow key.
Firefox implements moving cursor by visual order for both operations.
From Chromium bug report, native speakers would like moving cursor by visual order since it
is more intuitive.

The patch is only enabled for Windows (by EditingBehavior) because current implementation
matches Windows' native behavior.
For exmaple, if the logical text is "abc def hij", the cursor positions are
"|abc |def |hij|" no matter pressing ctrl-left-arrow or ctrl-right-arrow.

Mac and Linux's native behavior is slightly different. In which, when pressing
ctrl-left-arrow, the cursor positions are "|abc |def |hij|". When pressing ctrl-right-arrow,
the cursor positions are "|abc| def| hij|". We will implement it next.

Test: editing/selection/move-left-right-by-word-mac.html

  • editing/EditingBehavior.h:

(WebCore::EditingBehavior::shouldMoveLeftRightByWordInVisualOrder):

  • editing/FrameSelection.cpp: Remove experimental enum WebKitVisualWordGranularity.

(WebCore::FrameSelection::modifyExtendingRight):
(WebCore::FrameSelection::modifyExtendingForward):
(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingForward):
(WebCore::FrameSelection::modifyExtendingLeft):
(WebCore::FrameSelection::modifyExtendingBackward):
(WebCore::FrameSelection::modifyMovingLeft):
(WebCore::FrameSelection::modifyMovingBackward):

  • editing/TextGranularity.h: Remove experimental enum WebKitVisualWordGranularity.
  • editing/VisibleSelection.cpp: Remove experimental enum WebKitVisualWordGranularity.

(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):

  • page/DOMSelection.cpp: Remove experimental experimental flag -webkit-visual-word.

(WebCore::DOMSelection::modify):

LayoutTests: Turn on move caret by word visually for windows platform.
​https://bugs.webkit.org/show_bug.cgi?id=59652

Reviewed by Ryosuke Niwa.

  • editing/selection/caret-mode-paragraph-keys-navigation.html:
  • editing/selection/move-by-word-visually-crash-test-1.html:
  • editing/selection/move-by-word-visually-crash-test-2.html:
  • editing/selection/move-by-word-visually-crash-test-3.html:
  • editing/selection/move-by-word-visually-crash-test-4.html:
  • editing/selection/move-by-word-visually-crash-test-textarea.html:
  • editing/selection/move-by-word-visually-inline-block-positioned-element.html:
  • editing/selection/move-by-word-visually-multi-line.html:
  • editing/selection/move-by-word-visually-multi-space.html:
  • editing/selection/move-by-word-visually-null-box.html:
  • editing/selection/move-by-word-visually-single-space-inline-element.html:
  • editing/selection/move-by-word-visually-single-space-one-element.html:
  • editing/selection/move-by-word-visually-textarea.html:
  • editing/selection/move-left-right-by-word-mac-expected.txt: Added.
  • editing/selection/move-left-right-by-word-mac.html: Added.
  • editing/selection/resources/move-by-word-visually.js:

(moveByWord):
(moveByWordOnEveryChar):

10:58 AM Changeset in webkit [102251] by kbalazs@webkit.org
  • 1 edit
    1 delete in trunk/Source/WebKit2

ShareableBitmapGtk.cpp has no reason to exist
​https://bugs.webkit.org/show_bug.cgi?id=74011

Reviewed by Martin Robinson.

Remove this file since the real implementation is
exists in ShareableBitmapCairo.cpp.

  • Shared/gtk/ShareableBitmapGtk.cpp: Removed.
10:45 AM Changeset in webkit [102250] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[chromium] Plumb damage from WebExternalTextureLayer and WebPluginContainer to CCDamageTracker
​https://bugs.webkit.org/show_bug.cgi?id=73485

Patch by Jonathan Backer <​backer@chromium.org> on 2011-12-07
Reviewed by Darin Fisher.

Source/WebCore:

  • platform/graphics/chromium/PluginLayerChromium.cpp:

(WebCore::PluginLayerChromium::updateCompositorResources):
(WebCore::PluginLayerChromium::invalidateRect):

  • platform/graphics/chromium/PluginLayerChromium.h:

Source/WebKit/chromium:

  • public/platform/WebExternalTextureLayer.h:
  • src/WebExternalTextureLayer.cpp:

(WebKit::WebExternalTextureLayer::invalidateRect):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::commitBackingTexture):

10:24 AM Changeset in webkit [102249] by commit-queue@webkit.org
  • 2 edits
    5 adds in trunk/Source/WebCore

Upstream 5 files into WebCore/platform/blackberry
​https://bugs.webkit.org/show_bug.cgi?id=73632

Patch by Mary Wu <​mary.wu@torchmobile.com.cn> on 2011-12-07
Reviewed by Rob Buis.

Initial upstream, no new tests.

  • PlatformBlackBerry.cmake: Remove two empty files from build list.
  • platform/blackberry/PopupMenuBlackBerry.cpp: Added.

(WebCore::PopupMenuBlackBerry::PopupMenuBlackBerry):
(WebCore::PopupMenuBlackBerry::~PopupMenuBlackBerry):
(WebCore::PopupMenuBlackBerry::show):
(WebCore::PopupMenuBlackBerry::hide):
(WebCore::PopupMenuBlackBerry::updateFromElement):
(WebCore::PopupMenuBlackBerry::disconnectClient):

  • platform/blackberry/PopupMenuBlackBerry.h: Added.

(WebCore::PopupMenuBlackBerry::client):

  • platform/blackberry/ScrollbarThemeBlackBerry.cpp: Added.

(WebCore::ScrollbarTheme::nativeTheme):

  • platform/blackberry/SearchPopupMenuBlackBerry.cpp: Added.

(WebCore::SearchPopupMenuBlackBerry::SearchPopupMenuBlackBerry):
(WebCore::SearchPopupMenuBlackBerry::popupMenu):
(WebCore::SearchPopupMenuBlackBerry::enabled):
(WebCore::SearchPopupMenuBlackBerry::saveRecentSearches):
(WebCore::SearchPopupMenuBlackBerry::loadRecentSearches):

  • platform/blackberry/SearchPopupMenuBlackBerry.h: Added.
10:24 AM Changeset in webkit [102248] by dbates@webkit.org
  • 2 edits in trunk/Websites/webkit.org

ASSERT_UNREACHED() should be ASSERT_NOT_REACHED() on assertion-guidelines.html
​https://bugs.webkit.org/show_bug.cgi?id=74006

Reviewed by Antonio Gomes.

As far I can tell, we've never had an ASSERT_UNREACHED(). We do have an
ASSERT_NOT_REACHED().

  • coding/assertion-guidelines.html:
10:21 AM Changeset in webkit [102247] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Fixed the definition of BUTTON_CELL_DRAW_WITH_FRAME_DRAWS_FOCUS_RING from r102246.

  • platform/mac/ThemeMac.mm: Added parentheses.
10:15 AM Changeset in webkit [102246] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/10542095> Focus rings are not drawn around push buttons, radio buttons and checkboxes

Reviewed by Darin Adler.

Instead of relying on -setShowsFirstResponder: to make -drawWithFrame:inView: draw the focus
ring, use -drawFocusRingMaskWithFrame:inView:.

  • platform/mac/ThemeMac.mm:

(-[NSCell _web_drawFocusRingWithFrame:inView:]): Added. Sets up the focus ring style and a
transparency layer, then uses -drawFocusRingMaskWithFrame:inView: to draw the focus ring.
(WebCore::updateStates): Eliminated calls to get and set showsFirstResponder.
(WebCore::paintCheckbox): Changed to use -_web_drawFocusRingWithFrame:inView:.
(WebCore::paintRadio): Ditto.
(WebCore::paintButton): Ditto.

10:12 AM Changeset in webkit [102245] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

Skip 3 more metric related tests with Qt5 until test-font fix.

  • platform/qt-5.0/Skipped:
10:08 AM Changeset in webkit [102244] by commit-queue@webkit.org
  • 4 edits in trunk

Source/WebCore: [CHROMIUM/SKIA] Handle put[Un/Pre]multipliedImageData conversions in Skia rather than ImageBuffer
​https://bugs.webkit.org/show_bug.cgi?id=73953

Patch by Brian Salomon <​bsalomon@google.com> on 2011-12-07
Reviewed by Stephen White.

Tested by existing canvas2d layout tests.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::putImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):

LayoutTests: [CHROMIUM] Make canvas/philip/tests/2d.imageData.put.unchanged.html be expected to fail
on the GPU due to slight difference in alpha-premul computation.

​https://bugs.webkit.org/show_bug.cgi?id=73953

Patch by Brian Salomon <​bsalomon@google.com> on 2011-12-07
Reviewed by Stephen White.

  • platform/chromium/test_expectations.txt:
8:40 AM Changeset in webkit [102243] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Micro-optimize ScrollView::visibleContentRect().
<​http://webkit.org/b/74001>

Reviewed by Anders Carlsson.

Reorder the scrollbar exclusion code to minimize the number of virtual calls
to ScrollableArea::verticalScrollbar(), ScrollableArea::horizontalScrollbar()
and Scrollbar::isOverlayScrollbar().

  • platform/ScrollView.cpp:

(WebCore::ScrollView::visibleContentRect):

8:16 AM Changeset in webkit [102242] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

ApplyPropertyBorderImage: Remove unneeded template argument for mapNinePieceImage().
<​http://webkit.org/b/73998>

Reviewed by Antti Koivisto.

Have ApplyPropertyBorderImage call mapNinePieceImage() directly now that it's
public (instead of passing it as a template argument.)

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

8:12 AM Changeset in webkit [102241] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Mac build fix after r102235.

  • WebCore.exp.in:
7:38 AM Changeset in webkit [102240] by tomz@codeaurora.org
  • 2 edits in trunk/Tools

Moved myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
7:32 AM Changeset in webkit [102239] by Simon Hausmann
  • 6 edits in trunk/Source/WebCore

[Qt] V8 debug build fixes.

Reviewed by Tor Arne Vestbø.

  • Target.pri: Add missing files to the build.
  • loader/SubresourceLoader.cpp: Add missing CString.h header file inclusion,

that is implicitly included with Chromium builds.

  • loader/cache/CachedResource.cpp: Ditto.
  • page/FrameTree.cpp: Ditto.
  • platform/graphics/MediaPlayer.cpp: Ditto.
7:29 AM Changeset in webkit [102238] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Fix debug shlib build with V8.

Reviewed by Tor Arne Vestbø.

  • qmake/mkspecs/features/qtwebkit.prf: Don't like jscore with

v8 builds.

7:29 AM Changeset in webkit [102237] by Simon Hausmann
  • 7 edits in trunk

[Qt] V8 build fixes.

Reviewed by Tor Arne Vestbø.

Source/JavaScriptCore:

  • yarr/yarr.pri: Don't rely on Source/JavaScriptCore being in

VPATH. Prefix SOURCES correctly and make sure that runtime/ is
in the include search path when building with v8.

Source/WebCore:

  • Target.pri: Don't load(javascriptcore) if we're building with v8.

Tools:

  • qmake/mkspecs/features/javascriptcore.prf: Don't add

Source/Thirdparty to the include search path here.

  • qmake/mkspecs/features/webcore.prf: Instead it belongs here, because it's

used when building WebCore as well as using it, because header files like
GraphicsContext3D.h include stuff from ThirdParty.

7:10 AM Changeset in webkit [102236] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] REGRESSION(102228): lot of test failures after enabled page cache
​https://bugs.webkit.org/show_bug.cgi?id=73999

Unreviewed gardening. Skip failing tests.

  • platform/qt-wk2/Skipped:
6:54 AM Changeset in webkit [102235] by commit-queue@webkit.org
  • 24 edits in trunk/Source

Change function name InitializeLoggingChannelsIfNecessary to follow coding style guideline
​https://bugs.webkit.org/show_bug.cgi?id=73986

Patch by Mary Wu <​mary.wu@torchmobile.com.cn> on 2011-12-07
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Just function name change, no new tests.

  • platform/Logging.h:
  • platform/efl/LoggingEfl.cpp:

(WebCore::initializeLoggingChannelsIfNecessary):

  • platform/gtk/LoggingGtk.cpp:

(WebCore::initializeLoggingChannelsIfNecessary):

  • platform/mac/LoggingMac.mm:

(WebCore::initializeLoggingChannelsIfNecessary):

  • platform/qt/LoggingQt.cpp:

(WebCore::initializeLoggingChannelsIfNecessary):

  • platform/win/LoggingWin.cpp:

(WebCore::initializeLoggingChannelsIfNecessary):

  • platform/wx/LoggingWx.cpp:

(WebCore::initializeLoggingChannelsIfNecessary):

Source/WebKit/efl:

  • ewk/ewk_main.cpp:

(_ewk_init_body):

Source/WebKit/gtk:

  • webkit/webkitglobals.cpp:

(webkitInit):

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit/qt:

  • WebCoreSupport/InitWebCoreQt.cpp:

(WebCore::initializeWebCoreQt):

Source/WebKit/win:

  • WebView.cpp:

(WebView::initWithFrame):

Source/WebKit/wx:

  • WebView.cpp:

(wxWebView::Create):

Source/WebKit2:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

6:51 AM Changeset in webkit [102234] by mihnea@adobe.com
  • 15 edits
    13 adds in trunk

[CSSRegions]Add support for background-color in region styling
​https://bugs.webkit.org/show_bug.cgi?id=71488

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/regions/region-style-block-background-color.html

fast/regions/region-style-block-background-color2.html
fast/regions/region-style-image-background-color.html
fast/regions/region-style-inline-background-color.html

  • WebCore.exp.in:
  • css/CSSStyleSelector.cpp:

(WebCore::RuleData::regionStyleRule):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::initForRegionStyling):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::addToRuleSet):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::isValidRegionStyleProperty):
(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::setRegionForStyling):
(WebCore::CSSStyleSelector::regionForStyling):
(WebCore::CSSStyleSelector::applyPropertyToRegionStyle):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::clearRenderRegionRangeMap):
(WebCore::RenderFlowThread::~RenderFlowThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::clearRenderObjectCustomStyle):
(WebCore::RenderFlowThread::setRegionRangeForBox):

  • rendering/RenderFlowThread.h:
  • rendering/RenderLayer.cpp:

(WebCore::CurrentRenderRegionMaintainer::CurrentRenderRegionMaintainer):
(WebCore::CurrentRenderRegionMaintainer::~CurrentRenderRegionMaintainer):
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::hitTest):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::style):

  • rendering/RenderObject.h:

(WebCore::RenderObject::canHaveRegionStyle):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::layout):
(WebCore::RenderRegion::renderObjectRegionStyle):
(WebCore::RenderRegion::computeStyleInRegion):
(WebCore::RenderRegion::clearObjectStyleInRegion):

  • rendering/RenderRegion.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/RenderView.h:

(WebCore::RenderView::currentRenderRegion):
(WebCore::RenderView::setCurrentRenderRegion):

LayoutTests:

  • fast/regions/region-style-block-background-color.html: Added.
  • fast/regions/region-style-block-background-color2.html: Added.
  • fast/regions/region-style-image-background-color.html: Added.
  • fast/regions/region-style-inline-background-color.html: Added.
  • fast/regions/resources/transparent.png: Added.
  • platform/mac-snowleopard/fast/regions/region-style-block-background-color-expected.png: Added.
  • platform/mac-snowleopard/fast/regions/region-style-block-background-color-expected.txt: Added.
  • platform/mac-snowleopard/fast/regions/region-style-block-background-color2-expected.png: Added.
  • platform/mac-snowleopard/fast/regions/region-style-block-background-color2-expected.txt: Added.
  • platform/mac-snowleopard/fast/regions/region-style-image-background-color-expected.png: Added.
  • platform/mac-snowleopard/fast/regions/region-style-image-background-color-expected.txt: Added.
  • platform/mac-snowleopard/fast/regions/region-style-inline-background-color-expected.png: Added.
  • platform/mac-snowleopard/fast/regions/region-style-inline-background-color-expected.txt: Added.
6:00 AM Changeset in webkit [102233] by vsevik@chromium.org
  • 14 edits in trunk/Source/WebCore

Web Inspector: Extract default call stack creation and check for front-end from console.
​https://bugs.webkit.org/show_bug.cgi?id=73566

Reviewed by Yury Semikhatsky.

  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

  • bindings/js/ScriptCallStackFactory.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallback):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::customArgsAndExceptionCallback):

  • bindings/v8/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

  • bindings/v8/ScriptCallStackFactory.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::hasFrontendForScriptContext):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::hasFrontendForScriptContext):

  • inspector/WorkerInspectorController.h:

(WebCore::WorkerInspectorController::hasFrontend):

  • page/Console.cpp:
  • page/Console.h:
4:55 AM Changeset in webkit [102232] by peter@chromium.org
  • 2 edits in trunk/Tools

[Chromium] Fix project file generation for the Android bot after r102201
​https://bugs.webkit.org/show_bug.cgi?id=73996

The gyp refactoring in r102201 was didn't explicitly exclude
the Android operating system in Tools/Tools.gyp, which broke
as gcc_version is not defined for that configuration.

Reviewed by Andreas Kling.

  • Tools.gyp:
4:34 AM Changeset in webkit [102231] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

Internals should have a method to reutrn the max sequence number of spellcheck reqeust.
​https://bugs.webkit.org/show_bug.cgi?id=73511

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-12-07
Reviewed by Hajime Morita.

Source/WebCore:

Internal state of SpellChecker should be able to be exposed for testing SpellChecker.
This patch will enable us to know asynchronous spellcheck has finished or not.

Test: editing/spelling/spellcheck-sequencenum.html

  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::SpellChecker):
(WebCore::SpellChecker::createRequest):
(WebCore::SpellChecker::didCheck):

  • editing/SpellChecker.h:

(WebCore::SpellChecker::lastRequestSequence):

Interface to take SpellCheck sequence numbers.

(WebCore::SpellChecker::lastProcessedSequence): ditto.

  • testing/Internals.cpp:

(WebCore::spellchecker):
(WebCore::Internals::lastSpellCheckRequestSequence):
(WebCore::Internals::lastSpellCheckProcessedSequence):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Added tests to check internals.lastSpellCheckRequestSequence and internals.lastSpellCheckProcessedSequence.

  • editing/spelling/spellcheck-sequencenum-expected.txt: Added.
  • editing/spelling/spellcheck-sequencenum.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
4:31 AM Changeset in webkit [102230] by vsevik@chromium.org
  • 2 edits in trunk/Tools

Unreviewed. Disabled failing tests on chromium.

  • TestWebKitAPI/Tests/WTF/StringBuilder.cpp:

(TestWebKitAPI::TEST):

2:19 AM Changeset in webkit [102229] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/test_expectations.txt:
1:56 AM Changeset in webkit [102228] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Enable page cache.
​https://bugs.webkit.org/show_bug.cgi?id=73938

Enable WebCore's page cache for Qt port by setting its capacity to 20. This is temporary
and will be replaced by a computed value based on CacheMode. See bug#73918.

Patch by Zalan Bujtas <​zbujtas@gmail.com> on 2011-12-07
Reviewed by Simon Hausmann.

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::WebProcess::platformSetCacheModel):

1:43 AM Changeset in webkit [102227] by rniwa@webkit.org
  • 1 edit
    1 copy in trunk/LayoutTests

Qt rebaseline after r102149.

  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from

LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.

1:36 AM Changeset in webkit [102226] by tkent@chromium.org
  • 16 edits
    8 copies
    84 moves
    9 adds
    9 deletes in trunk/LayoutTests

Move <input type=number> tests to fast/forms/number/
​https://bugs.webkit.org/show_bug.cgi?id=73987

Reviewed by Hajime Morita.

  • fast/forms/ValidityState-rangeOverflow-expected.txt:
  • fast/forms/ValidityState-rangeUnderflow-expected.txt:
  • fast/forms/ValidityState-stepMismatch-expected.txt:
  • fast/forms/ValidityState-typeMismatch-number-expected.txt: Removed.
  • fast/forms/ValidityState-typeMismatch-number.html: Removed.
  • fast/forms/input-appearance-number-rtl.html: Removed.
  • fast/forms/input-appearance-spinbutton-disabled-readonly.html: Removed.
  • fast/forms/input-appearance-spinbutton-layer.html: Removed.
  • fast/forms/input-appearance-spinbutton-visibility-expected.html: Removed.
  • fast/forms/input-appearance-spinbutton-visibility.html: Removed.
  • fast/forms/input-number-blur-twice-expected.txt: Removed.
  • fast/forms/input-number-blur-twice.html: Removed.
  • fast/forms/input-number-change-type-on-focus-expected.txt: Removed.
  • fast/forms/input-number-change-type-on-focus.html: Removed.
  • fast/forms/input-number-commit-valid-only-expected.txt: Removed.
  • fast/forms/input-number-commit-valid-only.html: Removed.
  • fast/forms/input-number-crash-expected.txt: Removed.
  • fast/forms/input-number-crash.html: Removed.
  • fast/forms/input-number-events-expected.txt: Removed.
  • fast/forms/input-number-events.html: Removed.
  • fast/forms/input-number-keyoperation-expected.txt: Removed.
  • fast/forms/input-number-keyoperation.html: Removed.
  • fast/forms/input-number-large-padding-expected.txt: Removed.
  • fast/forms/input-number-large-padding.html: Removed.
  • fast/forms/input-number-outofrange-expected.txt: Removed.
  • fast/forms/input-number-outofrange.html: Removed.
  • fast/forms/input-number-size-expected.txt: Removed.
  • fast/forms/input-number-size.html: Removed.
  • fast/forms/input-number-spinbutton-crash-expected.txt: Removed.
  • fast/forms/input-number-spinbutton-crash.html: Removed.
  • fast/forms/input-number-unacceptable-style-expected.txt: Removed.
  • fast/forms/input-number-unacceptable-style.html: Removed.
  • fast/forms/input-number-wheel-expected.txt: Removed.
  • fast/forms/input-number-wheel.html: Removed.
  • fast/forms/input-spinbutton-capturing-expected.txt: Removed.
  • fast/forms/input-spinbutton-capturing.html: Removed.
  • fast/forms/input-stepup-stepdown-expected.txt:
  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Removed.
  • fast/forms/input-stepup-stepdown-from-renderer.html: Removed.
  • fast/forms/input-valueasnumber-number-expected.txt: Removed.
  • fast/forms/input-valueasnumber-number.html: Removed.
  • fast/forms/number-input-changeevent-expected.txt: Removed.
  • fast/forms/number-input-changeevent.html: Removed.
  • fast/forms/number/ValidityState-rangeOverflow-number-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeOverflow-expected.txt.
  • fast/forms/number/ValidityState-rangeOverflow-number.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js.
  • fast/forms/number/ValidityState-rangeUnderflow-number-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeUnderflow-expected.txt.
  • fast/forms/number/ValidityState-rangeUnderflow-number.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js.
  • fast/forms/number/ValidityState-stepMismatch-number-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt.
  • fast/forms/number/ValidityState-stepMismatch-number.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
  • fast/forms/number/ValidityState-typeMismatch-number-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-number-expected.txt.
  • fast/forms/number/ValidityState-typeMismatch-number.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-number.js.
  • fast/forms/number/input-appearance-number-rtl.html: Copied from LayoutTests/fast/forms/input-appearance-number-rtl.html.
  • fast/forms/number/input-appearance-spinbutton-disabled-readonly.html: Copied from LayoutTests/fast/forms/input-appearance-spinbutton-disabled-readonly.html.
  • fast/forms/number/input-appearance-spinbutton-layer.html: Copied from LayoutTests/fast/forms/input-appearance-spinbutton-layer.html.
  • fast/forms/number/input-appearance-spinbutton-visibility-expected.html: Copied from LayoutTests/fast/forms/input-appearance-spinbutton-visibility-expected.html.
  • fast/forms/number/input-appearance-spinbutton-visibility.html: Copied from LayoutTests/fast/forms/input-appearance-spinbutton-visibility.html.
  • fast/forms/number/input-number-blur-twice-expected.txt: Copied from LayoutTests/fast/forms/input-number-blur-twice-expected.txt.
  • fast/forms/number/input-number-blur-twice.html: Copied from LayoutTests/fast/forms/input-number-blur-twice.html.
  • fast/forms/number/input-number-change-type-on-focus-expected.txt: Copied from LayoutTests/fast/forms/input-number-change-type-on-focus-expected.txt.
  • fast/forms/number/input-number-change-type-on-focus.html: Copied from LayoutTests/fast/forms/input-number-change-type-on-focus.html.
  • fast/forms/number/input-number-commit-valid-only-expected.txt: Copied from LayoutTests/fast/forms/input-number-commit-valid-only-expected.txt.
  • fast/forms/number/input-number-commit-valid-only.html: Copied from LayoutTests/fast/forms/script-tests/input-number-commit-valid-only.js.
  • fast/forms/number/input-number-crash-expected.txt: Copied from LayoutTests/fast/forms/input-number-crash-expected.txt.
  • fast/forms/number/input-number-crash.html: Copied from LayoutTests/fast/forms/input-number-crash.html.
  • fast/forms/number/input-number-events-expected.txt: Copied from LayoutTests/fast/forms/input-number-events-expected.txt.
  • fast/forms/number/input-number-events.html: Copied from LayoutTests/fast/forms/script-tests/input-number-events.js.
  • fast/forms/number/input-number-keyoperation-expected.txt: Copied from LayoutTests/fast/forms/input-number-keyoperation-expected.txt.
  • fast/forms/number/input-number-keyoperation.html: Copied from LayoutTests/fast/forms/script-tests/input-number-keyoperation.js.
  • fast/forms/number/input-number-large-padding-expected.txt: Copied from LayoutTests/fast/forms/input-number-large-padding-expected.txt.
  • fast/forms/number/input-number-large-padding.html: Copied from LayoutTests/fast/forms/input-number-large-padding.html.
  • fast/forms/number/input-number-outofrange-expected.txt: Copied from LayoutTests/fast/forms/input-number-outofrange-expected.txt.
  • fast/forms/number/input-number-outofrange.html: Copied from LayoutTests/fast/forms/script-tests/input-number-outofrange.js.
  • fast/forms/number/input-number-size-expected.txt: Copied from LayoutTests/fast/forms/input-number-size-expected.txt.
  • fast/forms/number/input-number-size.html: Copied from LayoutTests/fast/forms/input-number-size.html.
  • fast/forms/number/input-number-spinbutton-crash-expected.txt: Copied from LayoutTests/fast/forms/input-number-spinbutton-crash-expected.txt.
  • fast/forms/number/input-number-spinbutton-crash.html: Copied from LayoutTests/fast/forms/input-number-spinbutton-crash.html.
  • fast/forms/number/input-number-unacceptable-style-expected.txt: Copied from LayoutTests/fast/forms/input-number-unacceptable-style-expected.txt.
  • fast/forms/number/input-number-unacceptable-style.html: Copied from LayoutTests/fast/forms/input-number-unacceptable-style.html.
  • fast/forms/number/input-number-wheel-expected.txt: Copied from LayoutTests/fast/forms/input-number-wheel-expected.txt.
  • fast/forms/number/input-number-wheel.html: Copied from LayoutTests/fast/forms/script-tests/input-number-wheel.js.
  • fast/forms/number/input-spinbutton-capturing-expected.txt: Copied from LayoutTests/fast/forms/input-spinbutton-capturing-expected.txt.
  • fast/forms/number/input-spinbutton-capturing.html: Copied from LayoutTests/fast/forms/script-tests/input-spinbutton-capturing.js.
  • fast/forms/number/input-valueasnumber-number-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-number-expected.txt.
  • fast/forms/number/input-valueasnumber-number.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-number.js.
  • fast/forms/number/number-input-changeevent-expected.txt: Copied from LayoutTests/fast/forms/number-input-changeevent-expected.txt.
  • fast/forms/number/number-input-changeevent.html: Copied from LayoutTests/fast/forms/number-input-changeevent.html.
  • fast/forms/number/number-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt.
  • fast/forms/number/number-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt.
  • fast/forms/number/number-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
  • fast/forms/number/number-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
  • fast/forms/number/spin-button-gets-disabled-or-readonly-expected.txt: Copied from LayoutTests/fast/forms/spin-button-gets-disabled-or-readonly-expected.txt.
  • fast/forms/number/spin-button-gets-disabled-or-readonly.html: Copied from LayoutTests/fast/forms/spin-button-gets-disabled-or-readonly.html.
  • fast/forms/script-tests/ValidityState-rangeOverflow.js:
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js:
  • fast/forms/script-tests/ValidityState-stepMismatch.js:
  • fast/forms/script-tests/ValidityState-typeMismatch-number.js: Removed.
  • fast/forms/script-tests/input-number-commit-valid-only.js: Removed.
  • fast/forms/script-tests/input-number-events.js: Removed.
  • fast/forms/script-tests/input-number-keyoperation.js: Removed.
  • fast/forms/script-tests/input-number-outofrange.js: Removed.
  • fast/forms/script-tests/input-number-wheel.js: Removed.
  • fast/forms/script-tests/input-spinbutton-capturing.js: Removed.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed.
  • fast/forms/script-tests/input-stepup-stepdown.js:
  • fast/forms/script-tests/input-valueasnumber-number.js: Removed.
  • fast/forms/spin-button-gets-disabled-or-readonly-expected.txt: Removed.
  • fast/forms/spin-button-gets-disabled-or-readonly.html: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-number-rtl-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/number: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-appearance-number-rtl-expected.png.
  • platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-linux/fast/forms/input-appearance-number-rtl-expected.png: Removed.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/chromium-linux/fast/forms/number: Added.
  • platform/chromium-linux/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-number-rtl-expected.png.
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-number-rtl-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/number: Added.
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/forms/input-appearance-number-rtl-expected.png.
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac/fast/forms/input-appearance-number-rtl-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/chromium-mac/fast/forms/number: Added.
  • platform/chromium-mac/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-appearance-number-rtl-expected.png.
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-win/fast/forms/input-appearance-number-rtl-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-appearance-number-rtl-expected.txt: Removed.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/chromium-win/fast/forms/number: Added.
  • platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-number-rtl-expected.png.
  • platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-number-rtl-expected.txt.
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-spinbutton-layer-expected.txt.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/efl/fast/forms/input-appearance-number-rtl-expected.png: Removed.
  • platform/efl/fast/forms/input-appearance-number-rtl-expected.txt: Removed.
  • platform/efl/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/efl/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/efl/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/efl/fast/forms/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/efl/fast/forms/number: Added.
  • platform/efl/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/efl/fast/forms/input-appearance-number-rtl-expected.png.
  • platform/efl/fast/forms/number/input-appearance-number-rtl-expected.txt: Copied from LayoutTests/platform/efl/fast/forms/input-appearance-number-rtl-expected.txt.
  • platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/efl/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/efl/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/efl/fast/forms/input-appearance-spinbutton-layer-expected.png.
  • platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/efl/fast/forms/input-appearance-spinbutton-layer-expected.txt.
  • platform/gtk/Skipped:
  • platform/gtk/fast/forms/input-appearance-number-rtl-expected.png: Removed.
  • platform/gtk/fast/forms/input-appearance-number-rtl-expected.txt: Removed.
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/gtk/fast/forms/number: Added.
  • platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-number-rtl-expected.png.
  • platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-number-rtl-expected.txt.
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.png.
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt.
  • platform/mac/fast/forms/input-appearance-number-rtl-expected.png: Removed.
  • platform/mac/fast/forms/input-appearance-number-rtl-expected.txt: Removed.
  • platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/mac/fast/forms/number: Added.
  • platform/mac/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-number-rtl-expected.png.
  • platform/mac/fast/forms/number/input-appearance-number-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-number-rtl-expected.txt.
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.png.
  • platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt.
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/forms/input-appearance-number-rtl-expected.png: Removed.
  • platform/qt/fast/forms/input-appearance-number-rtl-expected.txt: Removed.
  • platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/qt/fast/forms/number: Added.
  • platform/qt/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/qt/fast/forms/input-appearance-number-rtl-expected.png.
  • platform/qt/fast/forms/number/input-appearance-number-rtl-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/input-appearance-number-rtl-expected.txt.
  • platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.png.
  • platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.txt.
  • platform/win/Skipped:
  • platform/wk2/Skipped:
1:03 AM Changeset in webkit [102225] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

TypingCommand duplicates code to obtain the last typing command
​https://bugs.webkit.org/show_bug.cgi?id=73984

Reviewed by Kent Tamura.

Extracted lastTypingCommandIfStillOpenForTyping out of isOpenForMoreTypingCommand
and a bunch of TypingCommand static member functions.

Also made more member functions of TypingCommand private.

  • editing/Editor.cpp:

(WebCore::Editor::setComposition):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelection):

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::deleteSelection):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertLineBreak):
(WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
(WebCore::TypingCommand::insertParagraphSeparator):
(WebCore::TypingCommand::lastTypingCommandIfStillOpenForTyping):
(WebCore::TypingCommand::closeTyping):

  • editing/TypingCommand.h:

(WebCore::TypingCommand::isOpenForMoreTyping):
(WebCore::TypingCommand::closeTyping):

12:14 AM Changeset in webkit [102224] by rniwa@webkit.org
  • 1 edit
    1 copy in trunk/LayoutTests

Add back a file accidentally removed in r102210.

  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from

LayoutTests/platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.

Dec 6, 2011:

10:26 PM Changeset in webkit [102223] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebCore

upstream BlackBerry porting of KURL/Logging
​https://bugs.webkit.org/show_bug.cgi?id=73524

Patch by Mary Wu <​mary.wu@torchmobile.com.cn> on 2011-12-06
Reviewed by Antonio Gomes.

  • platform/blackberry/KURLBlackBerry.cpp: Added.

(WebCore::KURL::fileSystemPath):

  • platform/blackberry/LoggingBlackBerry.cpp: Added.

(WebCore::initializeWithUserDefault):
(WebCore::InitializeLoggingChannelsIfNecessary):

9:57 PM Changeset in webkit [102222] by tkent@chromium.org
  • 361 edits in trunk/LayoutTests

Correct svn:mime-type of platform/*/fast/forms/*.png.

  • platform/chromium-cg-mac-leopard/fast/forms/input-align-image-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-leopard/fast/forms/listbox-bidi-align-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-leopard/fast/forms/range/slider-padding-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-leopard/fast/forms/select-baseline-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-leopard/fast/forms/select-visual-hebrew-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-snowleopard/fast/forms/menulist-clip-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-snowleopard/fast/forms/menulist-option-wrap-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-snowleopard/fast/forms/menulist-restrict-line-height-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-snowleopard/fast/forms/menulist-separator-painting-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-snowleopard/fast/forms/menulist-style-color-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-snowleopard/fast/forms/select-baseline-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac-snowleopard/fast/forms/select-empty-option-height-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac/fast/forms/basic-selects-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac/fast/forms/input-align-image-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac/fast/forms/listbox-bidi-align-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac/fast/forms/preserveFormDuringResidualStyle-expected.png: Modified property svn:mime-type.
  • platform/chromium-cg-mac/fast/forms/select-background-none-expected.png: Modified property svn:mime-type.
  • platform/chromium-linux/fast/forms/listbox-bidi-align-expected.png: Modified property svn:mime-type.
  • platform/chromium-linux/fast/forms/select-background-none-expected.png: Added property svn:mime-type.
  • platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.png: Modified property svn:mime-type.
  • platform/chromium-linux/fast/forms/textfield-focus-ring-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-clip-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-narrow-width-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-option-wrap-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-restrict-line-height-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-separator-painting-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-style-color-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/forms/select-empty-option-height-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/003-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/004-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/005-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/006-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/007-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label01-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label02-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label03-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label04-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label05-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/basic-buttons-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/basic-selects-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/basic-textareas-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/blankbuttons-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-align-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-cannot-be-nested-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-default-title-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-generated-content-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-inner-block-reuse-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-positioned-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-sizes-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-style-color-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-table-styles-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-text-transform-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/button-white-space-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/caret-rtl-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/control-clip-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/control-clip-overflow-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/disabled-select-change-index-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/encoding-test-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/fieldset-align-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/fieldset-with-float-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/file/input-file-re-render-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/float-before-fieldset-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/form-added-to-table-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/form-hides-table-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/formmove3-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/hidden-listbox-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/image-border-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-align-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-align-image-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-disabled-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-focus-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-number-rtl-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-preventDefault-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-range-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-selection-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-spinbutton-layer-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-visibility-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-appearance-width-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-baseline-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-field-text-truncated-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-first-letter-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-no-renderer-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-readonly-empty-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-spaces-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-table-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-text-click-inside-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-text-click-outside-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-text-double-click-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-text-drag-down-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-text-option-delete-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-text-self-emptying-click-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-text-word-wrap-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/input-type-text-min-width-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/listbox-bidi-align-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/listbox-hit-test-zoomed-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/listbox-scrollbar-incremental-load-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/listbox-width-change-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/menulist-deselect-update-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/menulist-no-overflow-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/menulist-width-change-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/minWidthPercent-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/negativeLineHeight-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/option-index-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/option-script-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/option-strip-whitespace-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/option-text-clip-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/range-thumb-height-percentage-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/range/slider-padding-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/range/slider-thumb-shared-style-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/range/thumbslider-no-parent-slider-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/search-display-none-cancel-button-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/search-rtl-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/searchfield-heights-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-align-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-background-none-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-block-background-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-change-listbox-size-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-change-listbox-to-popup-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-change-popup-to-listbox-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-dirty-parent-pref-widths-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-disabled-appearance-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-display-none-style-resolve-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-initial-position-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-item-background-clip-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-list-box-with-height-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-selected-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-size-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-style-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-visual-hebrew-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/select-writing-direction-natural-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/selectlist-minsize-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/slider-padding-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/slider-thumb-shared-style-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/stuff-on-my-optgroup-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/targeted-frame-submission-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/text-style-color-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/textAreaLineHeight-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/textarea-align-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/textarea-scroll-height-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/textarea-scrollbar-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/textarea-scrolled-type-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/textarea-setinnerhtml-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/textarea-width-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/textfield-outline-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/textfield-overflow-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/thumbslider-no-parent-slider-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png: Modified property svn:mime-type.
  • platform/chromium-win/fast/forms/listbox-bidi-align-expected.png: Modified property svn:mime-type.
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/001-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/002-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/003-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/004-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/005-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/006-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/007-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/HTMLOptionElement_label01-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/HTMLOptionElement_label02-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/HTMLOptionElement_label03-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/HTMLOptionElement_label04-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/HTMLOptionElement_label05-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/HTMLOptionElement_label06-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/HTMLOptionElement_label07-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/basic-buttons-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/basic-inputs-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/basic-selects-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/basic-textareas-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/basic-textareas-quirks-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/blankbuttons-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/box-shadow-override-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-align-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-cannot-be-nested-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-default-title-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-generated-content-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-inner-block-reuse-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-positioned-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-sizes-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-style-color-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-submit-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-table-styles-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-text-transform-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/button-white-space-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/caret-rtl-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/checkbox-radio-onchange-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/control-clip-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/control-clip-overflow-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/control-restrict-line-height-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/disabled-select-change-index-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/encoding-test-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/fieldset-align-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/fieldset-with-float-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/file/file-input-direction-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/file/file-input-disabled-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/float-before-fieldset-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/floating-textfield-relayout-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/form-added-to-table-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/form-element-geometry-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/form-hides-table-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/form-in-malformed-markup-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/formmove-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/formmove2-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/formmove3-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/hidden-listbox-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/image-border-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/indeterminate-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-align-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-align-image-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-bkcolor-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-default-bkcolor-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-focus-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-height-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-number-rtl-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-preventDefault-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-selection-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-spinbutton-layer-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-visibility-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-appearance-width-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-baseline-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-button-sizes-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-disabled-color-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-double-click-selection-gap-bug-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-field-text-truncated-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-first-letter-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-no-renderer-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-paste-undo-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-placeholder-visibility-1-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-readonly-dimmed-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-readonly-empty-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-spaces-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-table-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-text-click-inside-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-text-option-delete-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-text-scroll-left-on-blur-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-text-self-emptying-click-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-text-word-wrap-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-type-text-min-width-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-value-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/input-width-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/linebox-overflow-in-textarea-padding-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/listbox-bidi-align-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/listbox-clip-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/listbox-hit-test-zoomed-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/listbox-scrollbar-incremental-load-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/listbox-width-change-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/menulist-clip-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/menulist-deselect-update-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/menulist-narrow-width-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/menulist-no-overflow-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/menulist-option-wrap-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/menulist-restrict-line-height-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/menulist-separator-painting-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/menulist-style-color-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/menulist-width-change-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/minWidthPercent-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/negativeLineHeight-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/option-index-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/option-script-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/option-strip-whitespace-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/option-text-clip-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/placeholder-position-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/placeholder-pseudo-style-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/preserveFormDuringResidualStyle-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/radio-attr-order-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/radio-nested-labels-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/radio_checked-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/radio_checked_dynamic-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/range/input-appearance-range-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/range/range-thumb-height-percentage-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/range/slider-padding-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/range/slider-thumb-shared-style-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/range/slider-thumb-stylability-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/range/thumbslider-no-parent-slider-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/search-cancel-button-style-sharing-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/search-display-none-cancel-button-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/search-rtl-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/search-styled-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/search-vertical-alignment-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/searchfield-heights-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-align-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-background-none-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-baseline-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-block-background-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-change-listbox-size-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-change-listbox-to-popup-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-change-popup-to-listbox-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-dirty-parent-pref-widths-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-disabled-appearance-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-display-none-style-resolve-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-empty-option-height-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-initial-position-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-item-background-clip-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-list-box-with-height-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-listbox-multiple-no-focusring-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-selected-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-size-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-style-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-visual-hebrew-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/select-writing-direction-natural-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/selectlist-minsize-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/stuff-on-my-optgroup-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/tabbing-input-iframe-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/targeted-frame-submission-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/text-style-color-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textAreaLineHeight-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textarea-align-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textarea-placeholder-pseudo-style-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textarea-scroll-height-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textarea-scrolled-type-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textarea-setinnerhtml-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textarea-width-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textfield-focus-ring-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textfield-outline-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textfield-overflow-by-value-update-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/textfield-overflow-expected.png: Modified property svn:mime-type.
  • platform/efl/fast/forms/visual-hebrew-text-field-expected.png: Modified property svn:mime-type.
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.png: Added property svn:mime-type.
  • platform/gtk/fast/forms/select-background-none-expected.png: Added property svn:mime-type.
  • platform/mac-leopard/fast/forms/caret-rtl-expected.png: Modified property svn:mime-type.
  • platform/mac-leopard/fast/forms/form-added-to-table-expected.png: Modified property svn:mime-type.
  • platform/mac-leopard/fast/forms/form-in-malformed-markup-expected.png: Modified property svn:mime-type.
  • platform/mac-leopard/fast/forms/image-border-expected.png: Modified property svn:mime-type.
  • platform/mac-leopard/fast/forms/input-field-text-truncated-expected.png: Modified property svn:mime-type.
  • platform/mac-leopard/fast/forms/input-type-text-min-width-expected.png: Modified property svn:mime-type.
  • platform/mac-leopard/fast/forms/menulist-style-color-expected.png: Modified property svn:mime-type.
  • platform/mac-leopard/fast/forms/placeholder-pseudo-style-expected.png: Modified property svn:mime-type.
  • platform/mac-leopard/fast/forms/search-display-none-cancel-button-expected.png: Modified property svn:mime-type.
  • platform/mac-leopard/fast/forms/search-vertical-alignment-expected.png: Modified property svn:mime-type.
  • platform/mac-leopard/fast/forms/textarea-width-expected.png: Modified property svn:mime-type.
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png: Modified property svn:mime-type.
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png: Modified property svn:mime-type.
  • platform/qt/fast/forms/basic-selects-expected.png: Modified property svn:mime-type.
  • platform/qt/fast/forms/input-button-sizes-expected.png: Modified property svn:mime-type.
  • platform/qt/fast/forms/input-placeholder-focus-twice-expected.png: Modified property svn:mime-type.
  • platform/qt/fast/forms/range/slider-crash-expected.png: Added property svn:mime-type.
  • platform/win/fast/forms/input-text-drag-down-expected.png: Modified property svn:mime-type.
9:27 PM Changeset in webkit [102221] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Remove redundant files in PlatformBlackBerry.cmake
​https://bugs.webkit.org/show_bug.cgi?id=73976

Reviewed by Antonio Gomes.

The listing of the following files in PlatformBlackBerry.cmake are redundant. They should be removed.
platform/network/blackberry/MultipartResponseDelegate.cpp
platform/network/blackberry/NetworkManager.cpp
platform/network/blackberry/NetworkStateNotifierBlackBerry.cpp
platform/network/blackberry/ResourceErrorBlackBerry.cpp
platform/network/blackberry/ResourceRequestBlackBerry.cpp

  • PlatformBlackBerry.cmake:
9:25 PM Changeset in webkit [102220] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Zapping a block that is Marked leads to dead objects being mistaken for live ones
​https://bugs.webkit.org/show_bug.cgi?id=73982

Reviewed by Geoff Garen.

Changed the zapping code to ignore blocks that are Marked or Zapped. Additionally,
the code asserts that:

  • If we zap a Marked or Zapped block then the free list is empty, because this can only happen if the block was never free-listed.


  • Zapping can only happen for Marked, Zapped, or FreeListed blocks, since Allocated blocks are those that cannot be referred to by SizeClass::currentBlock (since SizeClass::currentBlock only refers to blocks that are candidates for allocation, and Allocated blocks are those who have been exhausted by allocation and will not be allocated from again), and New blocks cannot be referred to by anything except during a brief window inside the allocation slow-path.
  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::zapFreeList):

9:01 PM Changeset in webkit [102219] by rniwa@webkit.org
  • 1 edit
    1 copy in trunk/LayoutTests

Copy hover-active-drag-expected.txt for Chromium.

  • platform/chromium/fast/css/hover-active-drag-expected.txt: Copied from LayoutTests/fast/css/hover-active-drag-expected.txt.
9:00 PM Changeset in webkit [102218] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Refactoring: Editor::markAllMisspellingsAndBadGrammarInRanges should be refactored.
​https://bugs.webkit.org/show_bug.cgi?id=73628

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-12-06
Reviewed by Hajime Morita.

Extracted a code for adding markers and replacing misspelled words from WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges.

No new tests. covered by existing tests.

  • editing/Editor.cpp:

(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):

Extracted a code for adding markers and replacing missplled words, and moved to markAndReplaceFor.

(WebCore::Editor::markAndReplaceFor):

  • editing/Editor.h:
8:53 PM Changeset in webkit [102217] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Avoid calling calculateRects in RenderLayer::paintLayer when the rectangles are not needed
​https://bugs.webkit.org/show_bug.cgi?id=73754

Reviewed by Simon Fraser.

Performance change, no change in behavior.

RenderLayer::paintLayer can easily be called a million time when scrolling on a big table with
td { overflow: hidden; }. We would spend a lot of time recomputing the rectangles that we never
unused for painting as our layer was not self-painting (clipping layer only) and we did not paint
some overlay scrollbars.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):
Simplified and moved the shouldPaint logic earlier in the function. Now the branches
are checking the same boolean which makes the logic more obvious. A consequence of
filling shouldPaint earlier is that we call |calculateRects| only if there is a chance
the rectangles will used. Also cached the result of isSelfPaintingLayer() in a local
variable (isSelfPaintingLayer() is fairly expensive due to several virtual calls).

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintIntoLayer):
For coherency, applied the same optimizations here too: added an early return instead
of conditionaly call |calculateRects| as we don't have to restore any clip.

8:46 PM Changeset in webkit [102216] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Remove the leapForward accidentally added in the previous commit, and add a failing test expectation
for offsetX-offset-Y.html. The failure is tracked by the bug 73979.

  • fast/events/offsetX-offsetY-expected.txt:
  • fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html:
8:38 PM Changeset in webkit [102215] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fixed the test added by r100111.

  • fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html:
8:24 PM Changeset in webkit [102214] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Simplify KURL's checkEncodedString()
​https://bugs.webkit.org/show_bug.cgi?id=73890

Reviewed by Andreas Kling.

The Macro UNUSED_PARAM is not supposed to be used for this case,
use ASSERT_UNUSED instead.

  • platform/KURL.cpp:

(WebCore::checkEncodedString):

8:14 PM Changeset in webkit [102213] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Skip tests added by r101883 on Mac since they have been failing.
The failure is tracked by the bug 73977.

  • platform/mac/Skipped:
8:04 PM Changeset in webkit [102212] by eric.carlson@apple.com
  • 38 edits in trunk/LayoutTests

Update <track> layout tests
​https://bugs.webkit.org/show_bug.cgi?id=73966

<track> elements won't necessarily load automatically after ​https://bugs.webkit.org/show_bug.cgi?id=72547
is fixed, so update tests now.

Reviewed by Sam Weinig.

  • media/track/text-track-cue-is-reachable-expected.txt: Added.
  • media/track/text-track-cue-is-reachable.html: Added.
  • media/track/text-track-is-reachable-expected.txt: Added.
  • media/track/text-track-is-reachable.html: Added.
  • media/track/track-add-remove-cue.html:
  • media/track/track-cues-cuechange.html:
  • media/track/track-cues-enter-exit.html:
  • media/track/track-cues-seeking.html:
  • media/track/track-load-error-readyState.html:
  • media/track/track-load-from-element-readyState.html:
  • media/track/track-load-from-src-readyState.html:
  • media/track/track-text-track-cue-list.html:
  • media/track/track-webvtt-tc000-empty.html:
  • media/track/track-webvtt-tc001-utf8.html:
  • media/track/track-webvtt-tc002-bom.html:
  • media/track/track-webvtt-tc003-newlines.html:
  • media/track/track-webvtt-tc004-magic-header.html:
  • media/track/track-webvtt-tc005-header-comment.html:
  • media/track/track-webvtt-tc006-cue-identifiers.html:
  • media/track/track-webvtt-tc007-cue-no-id.html:
  • media/track/track-webvtt-tc008-timings-no-hours.html:
  • media/track/track-webvtt-tc009-timings-hour.html:
  • media/track/track-webvtt-tc010-no-timings.html:
  • media/track/track-webvtt-tc011-blank-lines.html:
  • media/track/track-webvtt-tc013-settings.html:
  • media/track/track-webvtt-tc014-alignment.html:
  • media/track/track-webvtt-tc015-positioning.html:
  • media/track/track-webvtt-tc016-align-positioning.html:
  • media/track/track-webvtt-tc017-line-position.html:
  • media/track/track-webvtt-tc018-align-text-line-position.html:
  • media/track/track-webvtt-tc019-cue-size.html:
  • media/track/track-webvtt-tc020-cue-size-align.html:
  • media/track/track-webvtt-tc021-valign.html:
  • media/track/track-webvtt-tc022-entities.html:
  • media/track/track-webvtt-tc023-markup.html:
  • media/track/track-webvtt-tc024-timestamp.html:
  • media/track/track-webvtt-tc025-class-markup.html:
  • media/track/track-webvtt-tc026-voice.html:
  • media/track/track-webvtt-tc027-empty-cue.html:
  • media/track/track-webvtt-tc028-unsupported-markup.html:
  • media/video-test.js:

(testTracks):
(testCues):
(allTestsEnded):
(enableAllTextTracks):

7:53 PM Changeset in webkit [102211] by rniwa@webkit.org
  • 1 edit
    1 copy in trunk/LayoutTests

Add a failing expectation for the test added by r101619.
The failure is tracked by the bug 73975.

  • platform/mac/fast/css/hover-active-drag-expected.txt: Copied from LayoutTests/fast/css/hover-active-drag-expected.txt.
7:41 PM Changeset in webkit [102210] by rniwa@webkit.org
  • 1 edit
    1 move in trunk/LayoutTests

GTK rebaseline after r102149.

  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
7:28 PM Changeset in webkit [102209] by kbr@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Suppress failure of fast/canvas/webgl/canvas-2d-webgl-texture.html
on Mac; tracking bug ​https://bugs.webkit.org/show_bug.cgi?id=73974 .

  • platform/mac/Skipped:
7:17 PM Changeset in webkit [102208] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

The code to create a NodeListsNodeData is duplicated everywhere
​https://bugs.webkit.org/show_bug.cgi?id=73961

Reviewed by Darin Adler.

Extracted the logic to create NodeListsNodeData as NodeRareData::ensureNodeLists.

  • dom/Document.cpp:

(WebCore::Document::getItems):

  • dom/Node.cpp:

(WebCore::Node::childNodes):
(WebCore::Node::registerDynamicNodeList):
(WebCore::Node::getElementsByTagName):
(WebCore::Node::getElementsByTagNameNS):
(WebCore::Node::getElementsByName):
(WebCore::Node::getElementsByClassName):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::ensureNodeLists):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::labels):

6:37 PM Changeset in webkit [102207] by leo.yang@torchmobile.com.cn
  • 4 edits
    7 adds in trunk/Source

Upstream about: feature in WebKit/blackberry/WebCoreSupport/
​https://bugs.webkit.org/show_bug.cgi?id=73612

Reviewed by Antonio Gomes.

Source/WebCore:

  • PlatformBlackBerry.cmake: Move platform/network/blackberry/AboutData.{h, cpp}

to WebKit/blackberry/WebCoreSupport

Source/WebKit:

  • blackberry/CMakeListsBlackBerry.txt:
  • blackberry/WebCoreSupport/AboutData.cpp: Added.

(WebCore::numberToHTMLTr):
(WebCore::configPage):
(WebCore::cacheTypeStatisticToHTMLTr):
(WebCore::memoryPage):

  • blackberry/WebCoreSupport/AboutData.h: Added.
  • blackberry/WebCoreSupport/AboutDataEnableFeatures.in: Added.
  • blackberry/WebCoreSupport/AboutDataHaveFeatures.in: Added.
  • blackberry/WebCoreSupport/AboutDataUseFeatures.in: Added.
  • blackberry/WebCoreSupport/generateAboutDataFeatures.pl: Added.
6:34 PM Changeset in webkit [102206] by Lucas Forschler
  • 18 edits
    2 copies
    1 delete in branches/safari-534.53-branch

Merged r98403. Reverted DumpRenderTree portion of this merge, as it fails. To be merged again after investigation

6:11 PM Changeset in webkit [102205] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

WebKit Mac does not build without CONTEXT MENU
​https://bugs.webkit.org/show_bug.cgi?id=73962

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2011-12-06
Reviewed by Pavel Feldman.

In the patch r100903, the symbols were exported under ENABLE(CONTEXT_MENUS)
because the feature is triggered from the menus.

The implementation has no dependency on the context menu but is necessary to build
when the inspector is enabled.
This patch moves the exported symbols from ENABLE(CONTEXT_MENUS) to ENABLE(INSPECTOR).

  • WebCore.exp.in:
6:10 PM Changeset in webkit [102204] by Lucas Forschler
  • 8 edits
    3 copies
    2 deletes in branches/safari-534.53-branch

Merged r94598.

5:52 PM Changeset in webkit [102203] by Lucas Forschler
  • 15 edits in branches/safari-534.53-branch/Source

Merged r97886.

5:48 PM Changeset in webkit [102202] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Fix typo in WebKit.gyp introduced in previous change.

Unreviewed, build fix.

  • WebKit.gyp:
5:39 PM Changeset in webkit [102201] by dpranke@chromium.org
  • 6 edits
    3 adds in trunk

.: Add Tools/Tool.xcodeproj,
Source/WebKit/chromium/WebKitUnitTests.xcodeproj,
Source/WebKit/chromium/All.xcodeproj to .gitignore

​https://bugs.webkit.org/show_bug.cgi?id=73823

Reviewed by Tony Chang.

  • .gitignore:

Source/WebKit/chromium: binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
​https://bugs.webkit.org/show_bug.cgi?id=73382

Reviewed by Tony Chang.

XCode (and hence GYP) can't handle circular dependencies between
files (and projects). Accordingly, although the binaries in
WebKit.gyp depend on webkit_support and webkit_support depends
on webkit, we don't mention the latter dependency in the file.
To fix this, this change moves the binaries like DRT into a new
GYP file, and modifies gyp_webkit to build from that file
instead of WebKit.gyp.

  • WebKit.gyp:
  • All.gyp:
  • WebKitUnitTests.gyp:
  • gyp_webkit:

Tools: binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
​https://bugs.webkit.org/show_bug.cgi?id=73382

Reviewed by Tony Chang.

XCode (and hence GYP) can't handle circular dependencies between
files (and projects). Accordingly, although the binaries in
WebKit.gyp depend on webkit_support and webkit_support depends
on webkit, we don't mention the latter dependency in the file.
To fix this, this change moves the binaries like DRT into a new
GYP file, and modifies gyp_webkit to build from that file
instead of WebKit.gyp.

  • Tools.gyp: Added.
5:29 PM Changeset in webkit [102200] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG 32_64 call linking does not handle non-cell callees correctly
​https://bugs.webkit.org/show_bug.cgi?id=73965

Reviewed by Sam Weinig.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

5:29 PM Changeset in webkit [102199] by Lucas Forschler
  • 2 edits in branches/safari-534.53-branch/Source/WebCore

Merged r97517.

5:23 PM Changeset in webkit [102198] by Lucas Forschler
  • 2 edits in branches/safari-534.53-branch/Source/WebKit2

Merged r97191.

5:22 PM Changeset in webkit [102197] by Lucas Forschler
  • 3 edits in branches/safari-534.53-branch/Source/WebKit2

Merged r92491.

5:17 PM Changeset in webkit [102196] by enne@google.com
  • 8 edits in trunk/Source

[chromium] setNeedsCommit on non-composited host layers should trigger commit
​https://bugs.webkit.org/show_bug.cgi?id=73711

Reviewed by James Robinson.

Source/WebCore:

Pipe non-composited content host syncs to setNeedsCommit.

Since now the NonCompositedContentHost generates setNeedsCommit, don't
call it unnecessarily, e.g. calling setBackgroundColor to the same
color each frame should not retrigger more commits.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setAnchorPoint):
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::setChildrenTransform):
(WebCore::GraphicsLayerChromium::setMasksToBounds):
(WebCore::GraphicsLayerChromium::setBackgroundColor):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setNeedsCommit):
(WebCore::LayerChromium::setAnchorPoint):
(WebCore::LayerChromium::setAnchorPointZ):
(WebCore::LayerChromium::setBackgroundColor):
(WebCore::LayerChromium::setMasksToBounds):
(WebCore::LayerChromium::setMaskLayer):
(WebCore::LayerChromium::setOpacity):
(WebCore::LayerChromium::setOpaque):
(WebCore::LayerChromium::setPosition):
(WebCore::LayerChromium::setSublayerTransform):
(WebCore::LayerChromium::setTransform):
(WebCore::LayerChromium::setScrollPosition):
(WebCore::LayerChromium::setScrollable):
(WebCore::LayerChromium::setDoubleSided):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setReplicaLayer):

  • platform/graphics/chromium/NonCompositedContentHost.cpp:

(WebCore::NonCompositedContentHost::notifySyncRequired):

  • platform/graphics/chromium/NonCompositedContentHost.h:

Source/WebKit/chromium:

Add some tests to make sure that modifying the noncomposited content
host triggers commits.

Properties that trigger setNeedsCommit should only do so when the
property changes. Additionally, make more property changes properly
trigger commits.

  • tests/LayerChromiumTest.cpp:
5:03 PM Changeset in webkit [102195] by Lucas Forschler
  • 7 edits in branches/safari-534.53-branch/Source/WebCore

Merged r95697.

4:55 PM Changeset in webkit [102194] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove unintentional type name shadowing in the Interpreter
​https://bugs.webkit.org/show_bug.cgi?id=73963

Reviewed by Oliver Hunt.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::prepareForRepeatCall): Replace the parameter name FunctionExecutable,
which shadows the FunctionExecutable type name, with functionExecutable.

4:51 PM Changeset in webkit [102193] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.53-branch

Merged r95386.

4:45 PM Changeset in webkit [102192] by Lucas Forschler
  • 6 edits in branches/safari-534.53-branch/Source/WebCore

Merged r95244.

4:41 PM Changeset in webkit [102191] by Lucas Forschler
  • 8 edits
    6 copies in branches/safari-534.53-branch

Merged r95129.

4:38 PM Changeset in webkit [102190] by bashi@chromium.org
  • 3 edits
    2 adds in trunk

[Chromium] unknown characters symbol on \n in complex script text (RTL and LTR)
​https://bugs.webkit.org/show_bug.cgi?id=73806

Reviewed by Tony Chang.

Source/WebCore:

Sets fMergeNeutralItems to 1 instead of merging script items based on their tags.

Tests: platform/chromium/fast/text/international/chromium-complex-text-non-printable-expected.html

platform/chromium/fast/text/international/chromium-complex-text-non-printable.html

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::fillRuns): Removed a block which merges script items.

LayoutTests:

Adds a test to ensure the missing glyph doesn't appear on LF in complex text.

  • fast/text/international/chromium-complex-text-non-printable-expected.html: Added.
  • fast/text/international/chromium-complex-text-non-printable.html: Added.
4:35 PM Changeset in webkit [102189] by Lucas Forschler
  • 91 edits in branches/safari-534.53-branch

Merge 95121.

4:26 PM Changeset in webkit [102188] by macpherson@chromium.org
  • 4 edits in trunk/Source/WebCore

Implement remaining border-image and webkit-maskbox-image properties in CSSStyleApplyProperty.
​https://bugs.webkit.org/show_bug.cgi?id=73391

Reviewed by Hajime Morita.

No new tests / refacoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyBorderImageModifier::getValue):
(WebCore::ApplyPropertyBorderImageModifier::setValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSStyleSelector.h:
3:49 PM Changeset in webkit [102187] by pfeldman@chromium.org
  • 12 edits
    2 adds in trunk/Source/WebCore

Web Inspector: introduce a memory agent stub.
​https://bugs.webkit.org/show_bug.cgi?id=73930

Reviewed by Timothy Hatcher.

We'd like to experiment with the memory stats and hence need a
nice home for that. Adding this undocumented agent / domain for now.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptProfiler.h:

(WebCore::ScriptProfiler::nodeCount):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::nodeCount):

  • bindings/v8/ScriptProfiler.h:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorMemoryAgent.cpp: Added.

(WebCore::InspectorMemoryAgent::~InspectorMemoryAgent):
(WebCore::InspectorMemoryAgent::getNodeCounter):
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):

  • inspector/InspectorMemoryAgent.h: Added.

(WebCore::InspectorMemoryAgent::create):

3:46 PM Changeset in webkit [102186] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after 102183.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::initialGridTrackValue):
Use DEFINE_STATIC_LOCAL to avoid having an exit-time destructor.

3:38 PM Changeset in webkit [102185] by jchaffraix@webkit.org
  • 6 edits in trunk/Source/WebCore

Inline RenderObject::view()
​https://bugs.webkit.org/show_bug.cgi?id=73733

Reviewed by Darin Adler.

Micro-performance optimization, no change in behavior.

RenderObject::view() is super hot and is taking ~4-5% of the time in some
benchmarks as it is called several hundred thousands times. For some reason,
the compiler did not inline it even though it is very simple in release builds.

  • WebCore.exp.in: Removed RenderObject::view() as it is inlined now.
  • rendering/RenderObject.cpp: Moved the implementation from here ...
  • rendering/RenderView.h:

(WebCore::RenderObject::view): ... to here to avoid a cyclic
dependency between RenderObject and RenderView. Also marked the
function as ALWAYS_INLINE.

  • rendering/RenderObject.h:
  • rendering/svg/RenderSVGResourceContainer.cpp:

Added #include "RenderView.h" as the code checks for view() during repaint.

3:29 PM Changeset in webkit [102184] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r101838): Crash in LayerTreeHostCA::initialize() when accelerated drawing is enabled
​https://bugs.webkit.org/show_bug.cgi?id=73955

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::initialize): m_webPage->drawingArea() will be
null here if we are initializing the layer tree host in DrawingArea's
ctor (as is the case when accelerated drawing is enabled), before
WebPage has set its m_drawingArea pointer. Since the layer tree cannot
have been frozen at this point, it's safe to enable layer flush
scheduling if drawingArea() is null.

3:11 PM Changeset in webkit [102183] by jchaffraix@webkit.org
  • 10 edits
    3 adds in trunk

CSS Grid Layout: Add support for parsing multiple grid-columns or grid-rows
​https://bugs.webkit.org/show_bug.cgi?id=73272

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-grid-layout/grid-columns-rows-get-set-multiple.html

Updated our supported syntax to match the following:
<track-list> := [ <track-breadth> ]+ | 'none'
<track-breadth> := <length> | <percentage> | 'auto'
(the naming loosely matches the specification)

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridTrackBreadth): Added function to handle a breadth
(extended with 'auto' that the spec puts in <track-minmax>).

(WebCore::valueForGridTrackList): Create a space seperated list of
track breadth or none.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Updated
to use the new functions.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseGridTrackList): Extended the function to
match the new syntax.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Removed our
simple implementation. Replaced by the CSSStyleSelector functions.

  • css/CSSStyleSelector.cpp:

(WebCore::createGridTrackBreadth):
(WebCore::createGridTrackList):
Added those 2 functions to convert the CSSPrimitiveValue to a Vector
as expected by RenderStyle.

(WebCore::CSSStyleSelector::applyProperty): Added our 2 properties
now that it is not handled by CSSStyleApplyProperty.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::gridColumns):
(WebCore::InheritedFlags::gridRows):
(WebCore::InheritedFlags::setGridColumns):
(WebCore::InheritedFlags::setGridRows):
(WebCore::InheritedFlags::initialGridColumns):
(WebCore::InheritedFlags::initialGridRows):
Updated the previous methods to take a Vector of Length.

(WebCore::InheritedFlags::initialGridTrackValue):
Needed function to return a Vector with one 'none' Length (the initial
value per the specification).

  • rendering/style/StyleGridData.h: Updated to use a Vector.

LayoutTests:

  • fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
  • fast/css-grid-layout/resources/grid-columns-rows-get-set.js:

Added more testing for the single case.

  • fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt: Added.
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple.html: Added.
  • fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js: Added.
2:41 PM Changeset in webkit [102182] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

r102146 from 73875 broke fast/js/encode-URI-test.html
​https://bugs.webkit.org/show_bug.cgi?id=73950

Reviewed by Gavin Barraclough.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncUnescape): Restructured to handle
the %uHHHH case to output the resulting character
and continue so that a failure in finding 4 hex
digits will fall through and output the '%'.
Due to style check, changed the temporary
character variable to a more descriptive name.

2:37 PM Changeset in webkit [102181] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk/Source

[Chromium] Implement tile-sized painting using SkPicture.
​https://bugs.webkit.org/show_bug.cgi?id=71869

Patch by David Reveman <​reveman@chromium.org> on 2011-12-06
Reviewed by James Robinson.

Source/WebCore:

Add texture uploader that paints tile-sized chunks using SkPicture
recording and playback. Expose setting which allows this texture
updater to be enabled.

No new tests. Covered by existing tests.

  • WebCore.gypi:
  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp: Added.

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::Texture):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::create):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::BitmapSkPictureCanvasLayerTextureUpdater):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::~BitmapSkPictureCanvasLayerTextureUpdater):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::createTexture):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::sampledTexelFormat):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::prepareToUpdate):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::paintContentsRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h: Added.

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::textureUpdater):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::orientation):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

Source/WebKit/chromium:

Add perTilePainting setting that is used by compositor to determine
what texture uploader to use.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setPerTilePainting):

  • src/WebSettingsImpl.h:

(WebKit::WebSettingsImpl::perTilePainting):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

2:26 PM Changeset in webkit [102180] by enne@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Don't crash if tile upload happens without painting first
​https://bugs.webkit.org/show_bug.cgi?id=73939

Reviewed by James Robinson.

Remove at least one place (in ImageLayerChromium) where this could
happen.

Although this shouldn't happen, we should be robust to it in the
chance that other code causes it to.

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateCompositorResources):

2:12 PM Changeset in webkit [102179] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

GC zapping logic could benefit from some more assertions
​https://bugs.webkit.org/show_bug.cgi?id=73947

Reviewed by Gavin Barraclough.

  • If you're in a zapped block and you're zapped, then your mark bit should never be set.


  • If you're being marked, then you should never be zapped.
  • heap/MarkedBlock.h:

(JSC::MarkedBlock::isLive):

  • runtime/Structure.h:

(JSC::MarkStack::internalAppend):

2:07 PM Changeset in webkit [102178] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Enable web audio by default on non-Mac POSIX platforms
​https://bugs.webkit.org/show_bug.cgi?id=73491

Patch by Ruben <​chromium@hybridsource.org> on 2011-12-06
Reviewed by Tony Chang.

No new tests, just changing gyp includes.

  • WebCore.gyp/WebCore.gyp:
2:02 PM Changeset in webkit [102177] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Put length in its own variable in KURL copyASCII
​https://bugs.webkit.org/show_bug.cgi?id=73928

Reviewed by Darin Adler.

  • platform/KURL.cpp:

(WebCore::copyASCII):

1:58 PM Changeset in webkit [102176] by Lucas Forschler
  • 4 edits in branches/safari-534.53-branch/Source/WebCore

Merged r95103.

1:54 PM Changeset in webkit [102175] by Lucas Forschler
  • 2 edits in branches/safari-534.53-branch/Source/WebCore

Merge 95099.

1:37 PM Changeset in webkit [102174] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk/Source

[chromium] Set opaque flag for ImageLayerChromium
​https://bugs.webkit.org/show_bug.cgi?id=72964

Patch by Dana Jansens <​danakj@chromium.org> on 2011-12-06
Reviewed by James Robinson.

Source/WebCore:

Unit test in tests/ImageLayerChromiumTest.cpp.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToImage):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore::GraphicsLayerChromium::contentsLayer):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::setContents):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/DragImageTest.cpp:

(WebCore::TestImage::TestImage):
(WebCore::TestImage::nativeImageForCurrentFrame):

  • tests/ImageLayerChromiumTest.cpp: Added.

(WebCore::MockGraphicsLayerClient::notifyAnimationStarted):
(WebCore::MockGraphicsLayerClient::notifySyncRequired):
(WebCore::MockGraphicsLayerClient::paintContents):
(WebCore::MockGraphicsLayerClient::showDebugBorders):
(WebCore::MockGraphicsLayerClient::showRepaintCounter):
(WebCore::TestImage::create):
(WebCore::TestImage::TestImage):
(WebCore::TestImage::isBitmapImage):
(WebCore::TestImage::currentFrameHasAlpha):
(WebCore::TestImage::size):
(WebCore::TestImage::nativeImageForCurrentFrame):
(WebCore::TestImage::destroyDecodedData):
(WebCore::TestImage::decodedSize):
(WebCore::TestImage::draw):
(WebCore::TEST):

1:19 PM Changeset in webkit [102173] by Lucas Forschler
  • 10 edits in branches/safari-534.53-branch

Merged r95096.

1:12 PM Changeset in webkit [102172] by Lucas Forschler
  • 4 edits
    3 copies in branches/safari-534.53-branch

Merged r95058.

1:06 PM Changeset in webkit [102171] by adamk@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Guard access to WebKitPlatformSupport::currentThread with a null check
​https://bugs.webkit.org/show_bug.cgi?id=73937

Reviewed by Adam Barth.

Though |currentThread| is never null in production code, it is null in
unit tests (such as Chromium's unit_tests) that call WebKit::initialize()
without first constructing a MessageLoop.

  • src/WebKit.cpp:

(WebKit::initialize):
(WebKit::shutdown):

1:00 PM Changeset in webkit [102170] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[chromium] Apply sent deltas on finishCommit
​https://bugs.webkit.org/show_bug.cgi?id=73884

Patch by Alexandre Elias <​aelias@google.com> on 2011-12-06
Reviewed by James Robinson.

This moves scroll and pageScale "sent" deltas to be applied to
the layer at the end of the commit, instead of the beginning.

This has several advantages, especially for page scale:

  • When pageScale changes, no longer any need to change the scroll's

coordinate space at beginning of commit, which is complex and prone to
bugs (this fixes a problem where we were forgetting to modify the
scrollPosition before).

  • No need for non-commit-related code to consider the "sent" values.

m_pageScale is now always the content scale factor, and
m_pageScaleDelta is the scale to be on the impl-side matrix.

  • This will make it easy to send arbitrary fake or future delta

values for example while pinch zooming out.

The scroll logic is similarly altered for consistency's sake. Note that
I also moved the tree synchronize to the beginning of finishCommit
in order to avoid having to change the pageScale coordinate space of
sentScrollDelta in adjustScrollsForPageScaleChange().

Source/WebCore:

No new tests. (Refactoring of existing code.)

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore::CCLayerTreeHostImpl::applyPageScaleDeltaToScrollLayer):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

12:48 PM Changeset in webkit [102169] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Don't allocate register in typedarray control flow
​https://bugs.webkit.org/show_bug.cgi?id=73944

Reviewed by Gavin Barraclough.

Move a temporary allocation outside of control flow.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):

12:47 PM Changeset in webkit [102168] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix assertion in QtViewportInteractionEngine.cpp:468
​https://bugs.webkit.org/show_bug.cgi?id=73914

Patch by Alexander Færøy <​alexander.faeroy@nokia.com> on 2011-12-06
Reviewed by Kenneth Rohde Christiansen.

m_suspendCount should always be zero when a pinch gesture is started.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::pinchGestureStarted):

12:46 PM Changeset in webkit [102167] by barraclough@apple.com
  • 15 edits
    1 move in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=68328
The generator and intrinsic fields in HashTableValue/HashEntry and associated structures and methods are redundant

Reviewed by Geoff Garen.

../JavaScriptCore:

Move the instrinsic enum out of the DFG, into runtime. Add entires for all host functions
that have an intrinsic in the form of a generated thunk. Remove the thunk pointer from the
hashtable, and make Intrinsic field no longer ifdef on JIT/DFG. In getHostFunction select
a thunk genertaor to use based on the Intrinsic.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • create_hash_table:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • dfg/DFGCapabilities.h:
  • dfg/DFGIntrinsic.h: Removed.
  • jit/JITStubs.cpp:

(JSC::JITThunks::hostFunctionStub):

  • jit/JITStubs.h:
  • runtime/Executable.cpp:

(JSC::ExecutableBase::intrinsic):
(JSC::NativeExecutable::intrinsic):

  • runtime/Executable.h:

(JSC::ExecutableBase::intrinsicFor):
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):

  • runtime/Intrinsic.h: Copied from Source/JavaScriptCore/dfg/DFGIntrinsic.h.
  • runtime/JSGlobalData.cpp:

(JSC::thunkGeneratorForIntrinsic):
(JSC::JSGlobalData::getHostFunction):

  • runtime/JSGlobalData.h:
  • runtime/Lookup.cpp:

(JSC::HashTable::createTable):
(JSC::setUpStaticFunctionSlot):

  • runtime/Lookup.h:

(JSC::HashEntry::initialize):
(JSC::HashEntry::intrinsic):

../WebCore:

Intrinsic is no longer in the DFG namespace, is always in the
hash table. Removed ThunkGenerator.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHashTable):

12:39 PM Changeset in webkit [102166] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/Source/WebKit/chromium

Remove forwarding header now that downstream has been fixed to refer to
the actual location of this header.

  • public/WebRect.h: Removed.
12:27 PM Changeset in webkit [102165] by Dimitri Glazkov
  • 8 edits in trunk/Source

Unreviewed, rolling out r102091.
​http://trac.webkit.org/changeset/102091
​https://bugs.webkit.org/show_bug.cgi?id=73711

Caused Clang Linux compile failure.

Source/WebCore:

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setAnchorPoint):
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::setChildrenTransform):
(WebCore::GraphicsLayerChromium::setMasksToBounds):
(WebCore::GraphicsLayerChromium::setBackgroundColor):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setNeedsCommit):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setAnchorPoint):
(WebCore::LayerChromium::setAnchorPointZ):
(WebCore::LayerChromium::setBackgroundColor):
(WebCore::LayerChromium::setMasksToBounds):
(WebCore::LayerChromium::setMaskLayer):
(WebCore::LayerChromium::setOpacity):
(WebCore::LayerChromium::setOpaque):
(WebCore::LayerChromium::setPosition):
(WebCore::LayerChromium::setSublayerTransform):
(WebCore::LayerChromium::setTransform):
(WebCore::LayerChromium::setScrollPosition):
(WebCore::LayerChromium::setScrollable):
(WebCore::LayerChromium::setDoubleSided):
(WebCore::LayerChromium::setReplicaLayer):

  • platform/graphics/chromium/NonCompositedContentHost.cpp:

(WebCore::NonCompositedContentHost::notifySyncRequired):

  • platform/graphics/chromium/NonCompositedContentHost.h:

Source/WebKit/chromium:

  • tests/LayerChromiumTest.cpp:
12:17 PM Changeset in webkit [102164] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Chromium] Make root layer always opaque
​https://bugs.webkit.org/show_bug.cgi?id=70564

Patch by Dana Jansens <​danakj@chromium.org> on 2011-12-06
Reviewed by James Robinson.

  • platform/graphics/chromium/NonCompositedContentHost.cpp:

(WebCore::NonCompositedContentHost::NonCompositedContentHost):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::draw):

12:04 PM Changeset in webkit [102163] by Adam Roben
  • 6 edits in trunk/Tools

Add a pid parameter to CrashLogs.find_newest_log

When a PID is passed, only crash logs corresponding to a crashed process with that PID are
considered.

Fixes <​http://webkit.org/b/73942> webkitpy provides no way to specify the PID of the crashed
process whose crash log you want to find

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs.find_newest_log): Added an optional pid parameter.
(CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
candidate log's app_description extended attribute to see if that log corresponds to a
crashed process with the specified PID.

  • Scripts/webkitpy/common/system/crashlogs_unittest.py:

(CrashLogsTest.test_find_newest_log_darwin): Added a few more mock crash logs with various
contents and PIDs. Added tests that show that the pid parameter to find_newest_log is
respected. Also fixed an erroneous use of assertTrue instead of assertEqual.

  • Scripts/webkitpy/common/system/filesystem.py:

(FileSystem.getxattr): Added. On Darwin, calls through to the xattr module. On other
systems, raises a KeyError, mimicking the behavior on Darwin when the given attribute isn't
present.

  • Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.init): Added an optional xattrs parameter. Documented other parameters.
(MockFileSystem.getxattr): Added. Just pulls the given attribute out of the xattrs
dictionary.

  • Scripts/webkitpy/tool/commands/queries.py:

(CrashLog): Added help text. Added an optional PID parameter.
(CrashLog.execute): Pass the PID, if any, through to find_newest_log.

12:04 PM Changeset in webkit [102162] by Adam Roben
  • 4 edits in trunk/Tools

Wait for Crash Reporter to finish even when it lets the crashed process die quickly

NRWT was only waiting for Crash Reporter in cases where it was keeping the crashed process
alive beyond the normal timeout limit. In cases where the crashed process was able to die
faster, NRWT would assume that Crash Reporter had finished even though it often was still
running, which would lead to an incorrect crash log being picked up.

Part of <​http://webkit.org/b/71380> NRWT incorrectly associates crash logs with tests

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess._reset):
(ServerProcess.write):
(ServerProcess._check_for_crash): Changed to use new set_crashed function instead of setting
.crashed directly. Added wait_for_crash_reporter parameter, which we pass along to
set_crashed.

(ServerProcess._handle_timeout): Fixed a logic error that would cause .crashed and
.timed_out both to be set to True in cases where Crash Reporter took a long time to run. Now
we bail out of handling the failure as a timeout if we find out that the process in fact
crashed. We tell _check_for_crash not to wait for Crash Reporter because we've already done
so.
(ServerProcess.set_crashed): Added. When the process crashes, we wait for Crash Reporter to
finish running (unless directed otherwise) so we can be sure the crash log has been saved to
disk.

  • Scripts/webkitpy/layout_tests/port/server_process_unittest.py:

(TrivialMockPort.is_crash_reporter): Added.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver._check_for_driver_crash): Changed to use set_crashed. (This also fixed a typo
that would have partially broken crash detection on Windows, if NRWT worked on Windows.)

12:00 PM Changeset in webkit [102161] by abarth@webkit.org
  • 6 edits in trunk/Tools

NRWT fails on unreleased versions of Mac OS X
​https://bugs.webkit.org/show_bug.cgi?id=72748

Reviewed by Dirk Pranke.

Hopefully this patch will make NRWT work on future versions on Mac OS X.
Most of the infrastructure was already in place, but there were some
asserts that failed. I've tested this patch by haxoring the version
detection logic to simulate an unknown version. We might need to
iterate based on feedback from folks with a real future version.

  • Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort.init):

  • mac-future is an allowed port_name that's used internally by webkitpy to represent future versions of Mac OS X.
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(test_versions):

  • Test that we don't throw exceptions when dealing with future versions of Mac OS X.
  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._expectations_from_skipped_files):

  • Demote this logging message to "debug". It's expected that mac-future doesn't have a Skipped file.
  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.init):

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort.init):

  • Re-order some code in these constructors so that self._operating_system is available to the ApplePort constructor.
11:58 AM Changeset in webkit [102160] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

UI process crashes if the Web Process crashes on launch
​https://bugs.webkit.org/show_bug.cgi?id=73943

Reviewed by Sam Weinig.

When the Web Process crashes on launch, the WebConnectionToWebProcess
object was getting deleted inside of didClose. Add a protector to
prevent this.

  • UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::didClose):

11:29 AM Changeset in webkit [102159] by kubo@profusion.mobi
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Do not lose message flags when converting to/from Soup Requests/Responses
​https://bugs.webkit.org/show_bug.cgi?id=73924

Reviewed by Gustavo Noronha Silva.

Apply the same change added to the GTK+ port in r55086 to prevent
soup message flags from being lost by updating the request flags when
a response is received.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):

11:29 AM Changeset in webkit [102158] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

WebPImageDecoder computes image width and height multiple times
​https://bugs.webkit.org/show_bug.cgi?id=73796

Reviewed by Adam Barth.

Once sufficient image data arrives, we can compute the decoded image height
and width from the WEBP image header data.

From then on, the decoded image size is known so there's no need to re-read
it from the WEBP image header again.

No change in behavior, so no new tests.

  • platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::decode):

11:27 AM Changeset in webkit [102157] by reed@google.com
  • 2 edits in trunk/Source/WebCore

optimize TransformationMatrix::scale by not calling through to generic multiply
​https://bugs.webkit.org/show_bug.cgi?id=73830

Reviewed by Kenneth Russell.

No new tests. Optimization only, existing tests exercise the code

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::scaleNonUniform):
(WebCore::TransformationMatrix::scale3d):

11:26 AM Changeset in webkit [102156] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix page overlay rendering with AC.
​https://bugs.webkit.org/show_bug.cgi?id=73935

Reviewed by Noam Rosenthal.

The inspector node highlight would display old highlights as well
since the overlay is normally rendered right after the page on top
of the same graphics context.

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::paintContents):

11:07 AM Changeset in webkit [102155] by Darin Adler
  • 20 edits
    7 adds in trunk/LayoutTests

Generated some new expected results for Lion.

Discussed aspects of this with Adam Roben and Dan Bernstein.

  • platform/mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
  • platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
  • platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
  • platform/mac/fast/regions/region-overflow-break-expected.txt: Added.
  • platform/mac/fast/regions/render-region-custom-style-mark-expected.txt: Added.
  • platform/mac/http/tests/inspector/resource-har-conversion-expected.txt: Updated.
  • platform/mac/media/controls-strict-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Updated.
  • platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Updated.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Updated.
  • platform/mac/svg/text/text-intro-05-t-expected.txt: Updated.
11:01 AM Changeset in webkit [102154] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

Revert WebCore track Settings changes made in r101977
​https://bugs.webkit.org/show_bug.cgi?id=73879

Reviewed by Sam Weinig.

No new tests yet, still nothing to test.

  • page/Settings.cpp: Move the preference setters back into the .h file.
  • page/Settings.h:

(WebCore::Settings::setShouldDisplaySubtitles):
(WebCore::Settings::setShouldDisplayCaptions):
(WebCore::Settings::setShouldDisplayTextDescriptions):

10:37 AM Changeset in webkit [102153] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations update.

  • platform/chromium/test_expectations.txt:
10:19 AM Changeset in webkit [102152] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

MediaList: Remove constructor that takes a CSSImportRule*.
<​http://webkit.org/b/73833>

Reviewed by Antti Koivisto.

  • css/MediaList.h:
  • css/MediaList.cpp:

Remove MediaList(CSSImportRule*, ...) constructor.

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::CSSImportRule):

Have CSSImportRule construct its MediaList by passing the parent
style sheet, which is exactly what the old constructor accomplished.
Also assert that we're always created with a non-null parent sheet.

9:59 AM Changeset in webkit [102151] by vsevik@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed chromium tests rebaseline.

  • platform/chromium-cg-mac-leopard/fast/table/027-expected.png: Added.
9:57 AM Changeset in webkit [102150] by tommyw@google.com
  • 2 edits in trunk/Tools

Added myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
9:43 AM Changeset in webkit [102149] by jarred@sencha.com
  • 7 edits
    2 adds in trunk

getComputedStyle returns wrong value for margin-*
​https://bugs.webkit.org/show_bug.cgi?id=73334

Source/WebCore:

margin-* getComputedStyle values should return the "used" absolute value when there is a renderer
and the specified value is relative (percentage, auto, etc.).
When there is no renderer, the specified value should be returned.
See ​http://dev.w3.org/csswg/cssom/#resolved-values.

Reviewed by Darin Adler.

Test: fast/css/getComputedStyle/getComputedStyle-resolved-values.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Modified baseline tests for getComputedStyle margin values where a "used" value is returned.

Reviewed by Darin Adler.

  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-margin-auto-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-resolved-values-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-resolved-values.html: Added.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
9:36 AM Changeset in webkit [102148] by ap@apple.com
  • 9 edits
    2 adds in trunk

REGRESSION (WebKit2): Kill ring is not cleared when selection changes
​https://bugs.webkit.org/show_bug.cgi?id=73888
<rdar://problem/10532310>

Reviewed by Mark Rowe.

Test: editing/pasteboard/emacs-ctrl-k-with-move.html

  • editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection): Moved the code to clear kill ring from Mac WebKit, as it's needed in all Mac ports at least.
9:30 AM Changeset in webkit [102147] by Darin Adler
  • 5 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> in CollectionCache
​https://bugs.webkit.org/show_bug.cgi?id=73784

Reviewed by Andreas Kling.

  • html/CollectionCache.cpp:

(WebCore::CollectionCache::copyCacheMap): Use adoptPtr.
(WebCore::CollectionCache::reset): Removed now-unneeded calls to deleteAllValues.
(WebCore::append): Added. Helper function for appending elements to the maps from
the collection cache.

  • html/CollectionCache.h: Changed mapped type in NodeCacheMap to OwnPtr.

Added append function.

  • html/HTMLCollection.cpp:

(WebCore::nameShouldBeVisibleInDocumentAll): Added, to factor out common code in
two functions below.
(WebCore::HTMLCollection::checkForNameMatch): Changed to call nameShouldBeVisibleInDocumentAll.
(WebCore::HTMLCollection::updateNameCache): Ditto. Also updated cache code to use the append
function, so it will work with OwnPtr. Also eliminated an unneeded get call before
each hash table add; we do both at once in the new append function.

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::updateNameCache): More of the same.

9:21 AM Changeset in webkit [102146] by msaboff@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Add 8 bit paths to global object functions
​https://bugs.webkit.org/show_bug.cgi?id=73875

Added 8 bit paths for converions methods.

This is worth 1.5% on kraken audio-oscillator,
1.6% on stanford-crypto-ccm and 2.5% on
stanford-crypto-sha256-iterative. See bug for
a full report.

Reviewed by Oliver Hunt.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::decode): Split into a templated helper.
(JSC::parseInt): Split into a templated helper.
(JSC::parseFloat): Added an 8 bit path
(JSC::globalFuncEscape): Added 8 bit path
(JSC::globalFuncUnescape): Added 8 bit path

  • runtime/JSStringBuilder.h:

(JSC::JSStringBuilder::append): New append for LChar

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::append): New append for LChar

9:20 AM Changeset in webkit [102145] by kerz@chromium.org
  • 1 copy in branches/chromium/963

Branching webkit for Chromium

9:05 AM Changeset in webkit [102144] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations update.

  • platform/chromium/test_expectations.txt:
8:36 AM Changeset in webkit [102143] by peter@chromium.org
  • 2 edits in trunk/Tools

Added myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
8:35 AM Changeset in webkit [102142] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[qt][wk2] Tests of QQuickWebView assert in debug builds when destroying QQuickWebViewPrivate
​https://bugs.webkit.org/show_bug.cgi?id=73907

Patch by Michael Brüning <​michael.bruning@nokia.com> on 2011-12-06
Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/qquickwebview.cpp: Disconnect signals from

QtViewportInteractionEngine in ~QQuickWebViewPrivate.
(QQuickWebViewPrivate::~QQuickWebViewPrivate):

  • UIProcess/API/qt/qquickwebview_p_p.h: Remove empty inline implementation of ~QQuickWebViewPrivate.
8:25 AM Changeset in webkit [102141] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r102102.
​http://trac.webkit.org/changeset/102102
​https://bugs.webkit.org/show_bug.cgi?id=73925

Causes segmentation fault on chromium unit_tests,
content_unittests, sync_unit_tests (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-06

  • features.gypi:
8:16 AM Changeset in webkit [102140] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

[Chromium] Web Inspector: getFunctionLocation should return scriptId as String not as int
​https://bugs.webkit.org/show_bug.cgi?id=73892

Reviewed by Pavel Feldman.

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::functionLocationCallback): scriptId should be a string not a number

  • inspector/Inspector.json: removed unused parameter
7:38 AM Changeset in webkit [102139] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations update.

  • platform/chromium/test_expectations.txt:
7:36 AM Changeset in webkit [102138] by vsevik@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed chromium tests rebaseline.

  • platform/chromium-cg-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.
  • platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.
7:31 AM Changeset in webkit [102137] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations update.

  • platform/chromium/test_expectations.txt:
7:24 AM Changeset in webkit [102136] by kenneth@webkit.org
  • 12 edits in trunk/Source/WebKit2

[Qt] Add initial support for focusing when entering edit mode.

Reviewed by Simon Hausmann.

Next step would be to properly upstream our EditorState code.

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::focusEditableArea):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::focusEditableArea):

  • UIProcess/qt/QtPageClient.h:
  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::itemCoordFromCSS):
(WebKit::QtViewportInteractionEngine::itemRectFromCSS):
(WebKit::QtViewportInteractionEngine::focusEditableArea):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::focusEditableArea):

  • UIProcess/qt/QtWebPageEventHandler.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::respondToChangedSelection):
(WebKit::WebEditorClient::setInputMethodState):

7:05 AM Changeset in webkit [102135] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[WK2] Unreviewed gardening. Skip a failing test because of missing layoutTestController.dumpFrameLoadCallbacks()
​https://bugs.webkit.org/show_bug.cgi?id=42331

  • platform/wk2/Skipped: Skip http/tests/security/mixedContent/insecure-video-in-iframe.html.
7:04 AM Changeset in webkit [102134] by vsevik@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed chromium expectations update.

  • platform/chromium-cg-mac-leopard/fast/table/027-vertical-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug2947-expected.png: Added.
6:38 AM Changeset in webkit [102133] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations update.

  • platform/chromium/test_expectations.txt:
6:30 AM Changeset in webkit [102132] by kbalazs@webkit.org
  • 20 edits in trunk/Source

Enable ParallelJobs by default
​https://bugs.webkit.org/show_bug.cgi?id=70032

Reviewed by Zoltan Herczeg.

Source/JavaScriptCore:

Relanding with typo fix.

According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.

Remove the ENABLE(PARALLEL_JOBS) guard.
Fix build on Windows and Chromium.

missing for the gyp build system.

Export symbols.

  • wtf/ParallelJobs.h:
  • wtf/ParallelJobsGeneric.cpp:

(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
Deinline these to avoid exporting a lot of symbols.
These are non-trivial and called only once on a given object
so it doesn't seems to be worthwile to inline them.
Additionally fix a signed-unsigned comparison in the constructor.

  • wtf/ParallelJobsGeneric.h:
  • wtf/Platform.h:

Source/WebCore:

Covered by existing tests.

According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.

Remove the ENABLE(PARALLEL_JOBS) guard. Fix the Windows build
by qualifying ParallelJobs with the WTF namespace (otherwise
MSVC believes it belongs to WebCore which is likely a compiler bug).

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::setInteriorPixelsWorker):
(WebCore::FEConvolveMatrix::platformApplySoftware):

  • platform/graphics/filters/FEConvolveMatrix.h:
  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplyWorker):
(WebCore::FEGaussianBlur::platformApply):

  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplyGenericWorker):
(WebCore::FELighting::platformApplyGeneric):

  • platform/graphics/filters/FELighting.h:
  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApplyWorker):
(WebCore::FEMorphology::platformApply):

  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::fillRegionWorker):
(WebCore::FETurbulence::platformApplySoftware):

  • platform/graphics/filters/FETurbulence.h:
  • platform/graphics/filters/arm/FELightingNEON.cpp:

(WebCore::FELighting::platformApplyNeonWorker):

  • platform/graphics/filters/arm/FELightingNEON.h:

(WebCore::FELighting::platformApplyNeon):

6:19 AM Changeset in webkit [102131] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed gardening. Paint the bot green skipping with all failing tests.

  • platform/qt-mac/Skipped:
6:17 AM Changeset in webkit [102130] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix assertion in QtWebPageEventHandler.cpp
​https://bugs.webkit.org/show_bug.cgi?id=73908

Patch by Alexander Færøy <​alexander.faeroy@nokia.com> on 2011-12-06
Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):

6:13 AM Changeset in webkit [102129] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] fast/forms/access-key-for-all-elements.html fails
​https://bugs.webkit.org/show_bug.cgi?id=73917

  • platform/qt-wk2/Skipped: Skip fast/forms/access-key-for-all-elements.html.
5:59 AM Changeset in webkit [102128] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed assertion fix for r102123.

  • platform/KURL.cpp:

(WebCore::checkEncodedString):

5:55 AM Changeset in webkit [102127] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[WK2] Unreviewed gardening. New tests introduced in 100895 fail
​https://bugs.webkit.org/show_bug.cgi?id=73913

  • platform/wk2/Skipped: Skip failing tests.
5:49 AM Changeset in webkit [102126] by vsevik@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed chromium expectations update.

  • platform/chromium-cg-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
  • platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
5:43 AM Changeset in webkit [102125] by commit-queue@webkit.org
  • 4 edits in trunk

[Qt] build-jsc script doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=73910

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2011-12-06
Reviewed by Tor Arne Vestbø.

.:

  • WebKit.pro: Move WTF SUBDIR stuff out of here and

straight into JavaScriptCore/JavaScriptCore.pro.
Unconditionally "recurse" into JavaScriptCore now,
as we'll do the v8 scoping there to only build WTF.

Source/JavaScriptCore:

(moved from top-level WebKit.pro). Also add v8 scopes to only build
WTF during v8 builds.

5:43 AM Changeset in webkit [102124] by vsevik@chromium.org
  • 6 edits in trunk/LayoutTests

Unreviewed chromium expectations update.

  • platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt:
  • platform/chromium-cg-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt:
  • platform/chromium-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt:
  • platform/chromium-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt:
  • platform/chromium/test_expectations.txt:
5:04 AM Changeset in webkit [102123] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Simplify KURL's checkEncodedString()
​https://bugs.webkit.org/show_bug.cgi?id=73890

Reviewed by Andreas Kling.

The method was reimplementing String::containsOnlyASCII().
Use the method from String and we can remove the #if NDEBUG.

  • platform/KURL.cpp:

(WebCore::checkEncodedString):

4:53 AM Changeset in webkit [102122] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed chromium expectations update.

  • tests/KURLTest.cpp:

(ComponentCase::TEST):

4:12 AM Changeset in webkit [102121] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations update.

  • platform/chromium/test_expectations.txt:
3:38 AM Changeset in webkit [102120] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r102111.
​http://trac.webkit.org/changeset/102111
​https://bugs.webkit.org/show_bug.cgi?id=73902

Breaks compilation (Requested by vsevik on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-06

  • editing/Editor.cpp:

(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):

  • editing/Editor.h:
3:30 AM Changeset in webkit [102119] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Refactoring] Accessing Node::m_document should be minimized.
​https://bugs.webkit.org/show_bug.cgi?id=73800

Patch by Hajime Morrita <​morrita@chromium.org> on 2011-12-06
Reviewed by Kent Tamura.

No new tests. No behavioral change.

Replaced m_document reference with the document() accessor
or temporaril variables. This is a preparation for using
m_document space to point a shadow root pointer.

  • dom/Document.h:

(WebCore::Node::Node):

  • dom/Node.cpp:

(WebCore::Node::~Node):

3:24 AM Changeset in webkit [102118] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=73889
TextCheckingParagraph::offsetTo should not have a side effect.

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-12-06
Reviewed by Hajime Morita.

Since TextCheckingParagraph::offsetTo had a side effect, its cache often became inconsistent.
This is likely to cause a bug when changing SpellChecker and Editor.

No new tests. Covered by existing tests.

  • editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingParagraph::offsetTo):

3:20 AM Changeset in webkit [102117] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] http/tests/misc/drag-over-iframe-invalid-source-crash.html and fast/events/drag-selects-image.html fails with timeout
​https://bugs.webkit.org/show_bug.cgi?id=73901

  • platform/qt-wk1/Skipped: Skip the failint tests.
3:12 AM Changeset in webkit [102116] by vsevik@chromium.org
  • 6 edits
    1 move
    1 add in trunk/LayoutTests

Unreviewed chromium tests rebaseline.

  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug14929-expected.png: Renamed from LayoutTests/platform/chromium/tables/mozilla/bugs/bug14929-expected.png.
  • platform/chromium-mac-leopard/fast/table/027-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2947-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/027-vertical-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug14929-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2947-expected.png:
3:05 AM Changeset in webkit [102115] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[chromium] Set texture limits as multiples of viewport size instead of hardcoded values
​https://bugs.webkit.org/show_bug.cgi?id=72202

Patch by Eric Penner <​epenner@google.com> on 2011-12-06
Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayers): added viewport param
(WebCore::LayerRendererChromium::initializeSharedObjects): ditto

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::highLimitBytes): calculated based on viewport
(WebCore::TextureManager::reclaimLimitBytes): ditto
(WebCore::TextureManager::lowLimitBytes): ditto
(WebCore::TextureManager::TextureManager): added viewport param
(WebCore::TextureManager::setMaxMemoryLimitBytes): changed name
(WebCore::TextureManager::setPreferredMemoryLimitBytes): added function
(WebCore::TextureManager::requestTexture): added viewport param

  • platform/graphics/chromium/TextureManager.h: ditto

(WebCore::TextureManager::create): ditto

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp: ditto

(WebCore::CCLayerTreeHost::initialize): ditto
(WebCore::CCLayerTreeHost::beginCommitOnImplThread): ditto
(WebCore::CCLayerTreeHost::setViewport): ditto
(WebCore::CCLayerTreeHost::setVisible): ditto
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread): ditto

Source/WebKit/chromium:

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

2:52 AM Changeset in webkit [102114] by Csaba Osztrogonác
  • 2 edits
    3 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0/Skipped:
    • Skip one more failing tests because of missing testfont handling.
    • Remove non-existent files.
  • platform/qt-5.0/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
  • platform/qt-5.0/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
2:47 AM Changeset in webkit [102113] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[TexMap][QT] Draw the borders of media and webgl elements in TexMap.
​https://bugs.webkit.org/show_bug.cgi?id=73817

GraphicsContext3D only draws the content of the WebGL canvas, not the additional
CSS such as the borders. TextureMapper should render the content of a
media/webgl layer before drawing the actual canvas.
This makes LayoutTests/compositing/webgl/webgl-reflection.html work.

Patch by Huang Dongsung <​luxtella@company100.net> on 2011-12-06
Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::paintSelf):

2:37 AM Changeset in webkit [102112] by vsevik@chromium.org
  • 6 edits
    1 delete in trunk/Source

Unreviewed, rolling out r102043.
​http://trac.webkit.org/changeset/102043
​https://bugs.webkit.org/show_bug.cgi?id=73898

Breaks chromium mac-cg compilation. (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-06

Source/WebCore:

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToImage):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore::GraphicsLayerChromium::contentsLayer):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::setContents):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/ImageLayerChromiumTest.cpp: Removed.
2:31 AM Changeset in webkit [102111] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Refactoring: Editor::markAllMisspellingsAndBadGrammarInRanges should be refactored.
​https://bugs.webkit.org/show_bug.cgi?id=73628

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-12-06
Reviewed by Hajime Morita.

Extracted a code for adding markers and replacing misspelled words from WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges.

No new tests. covered by existing tests.

  • editing/Editor.cpp:

(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):

Extracted a code for adding markers and replacing missplled words, and moved to markAndReplaceFor.

(WebCore::Editor::markAndReplaceFor):

  • editing/Editor.h:
2:06 AM Changeset in webkit [102110] by zeno.albisser@nokia.com
  • 3 edits in trunk/Source/WebKit/qt

[Qt][Mac] Building debug version only fails.
​https://bugs.webkit.org/show_bug.cgi?id=73895

WebKit pro/pri files should not explicitly adjust
the debug_and_release settings.

Reviewed by Kenneth Rohde Christiansen.

  • declarative/experimental/experimental.pri:
  • declarative/public.pri:
2:05 AM Changeset in webkit [102109] by apavlov@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: [Audits] Implement "Stop" button and progress bar instead of spinner.
​https://bugs.webkit.org/show_bug.cgi?id=73626

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/AuditLauncherView.js:

(WebInspector.AuditLauncherView):
(WebInspector.AuditLauncherView.prototype._setAuditRunning):
(WebInspector.AuditLauncherView.prototype._launchButtonClicked):
(WebInspector.AuditLauncherView.prototype._createLauncherUI):
(WebInspector.AuditLauncherView.prototype._updateResourceProgress):
(WebInspector.AuditLauncherView.prototype._updateButton):

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.documentLoaded):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
(WebInspector.AuditRules.CacheControlRule.prototype.doRun):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.onDocumentAvailable):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.onDocumentAvailable):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun.resultCallback):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun):

  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):
(WebInspector.AuditsPanel.prototype._executeAudit.ruleResultReadyCallback):
(WebInspector.AuditsPanel.prototype._executeAudit):
(WebInspector.AuditsPanel.prototype._auditFinishedCallback):
(WebInspector.AuditsPanel.prototype.terminateAudit):
(WebInspector.AuditCategory.prototype.run):
(WebInspector.AuditRule.prototype.run):
(WebInspector.AuditRule.prototype.doRun):
(WebInspector.AuditProgressMonitor):
(WebInspector.AuditProgressMonitor.prototype.setTotalWork):
(WebInspector.AuditProgressMonitor.prototype.worked):
(WebInspector.AuditProgressMonitor.prototype.get indeterminate):
(WebInspector.AuditProgressMonitor.prototype.done):
(WebInspector.AuditProgressMonitor.prototype.get canceled):
(WebInspector.AuditProgressMonitor.prototype.set canceled):

12:38 AM Changeset in webkit [102108] by rolandsteiner@chromium.org
  • 3 edits in trunk/WebKitLibraries

<style scoped>: disable on Windows by default
​https://bugs.webkit.org/show_bug.cgi?id=73893

Reviewed by Andreas Kling.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
12:38 AM Changeset in webkit [102107] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] [WK2] MiniBrowser assert on startup in debug build after r101713
​https://bugs.webkit.org/show_bug.cgi?id=73874

This change partially reverts r101713 restoring original behaviour for
KUrl creation from empty string and fixes asserts in debug build.

Patch by Viatcheslav Ostapenko <​ostapenko.viatcheslav@nokia.com> on 2011-12-06
Reviewed by Alexey Proskuryakov.

No new tests. Tests from r101713 pass.

  • platform/KURL.cpp:

(WebCore::KURL::init):
(WebCore::KURL::parse):

  • platform/KURL.h:
12:21 AM Changeset in webkit [102106] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> for EventListenerMap's internal map.
<​http://webkit.org/b/73761>

Reviewed by Benjamin Poulain.

Changed the value type of EventListenerMap::m_hashMap to OwnPtr<EventListenerVector>.
This means we no longer need to manually delete the vectors when taking them out of
the map, which makes the code a little prettier.

A few tweaks were necessary; release() instead of leakPtr() when switching modes
and adoptPtr()/get() sprinkled as needed.

  • dom/EventListenerMap.h:
  • dom/EventListenerMap.cpp:

(WebCore::EventListenerMap::clear):
(WebCore::EventListenerMap::add):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):

12:05 AM Changeset in webkit [102105] by haraken@chromium.org
  • 3 edits in trunk/Tools

[Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
​https://bugs.webkit.org/show_bug.cgi?id=73637

Reviewed by Adam Barth.

This patch replaces subprocess.Popen() with Executive, similar to other
Python scripts in webkitpy/. I manually confirmed that run-bindings-tests
works well for cases where no exception is raised, no exception is raised
but diff is found, and ScriptError is raised.

  • Scripts/run-bindings-tests:

(main):

  • Scripts/webkitpy/bindings/main.py: Replaces subprocess.Popen() with Executive.

(BindingsTests.init):
(BindingsTests.generate_from_idl):
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.detect_changes):

12:00 AM Changeset in webkit [102104] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Layout Test fast/forms/input-step-as-double.html fails after running touch event tests
​https://bugs.webkit.org/show_bug.cgi?id=71181

  • platform/qt/Skipped: Skip fast/forms/input-step-as-double.html until fix.
Note: See TracTimeline for information about the timeline view.