Timeline
Dec 8, 2011:
- 11:26 PM Changeset in webkit [102438] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rebaseline fast/forms/select-listbox-multiple-no-focusring.html
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08
- platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.png:
- 11:01 PM Changeset in webkit [102437] by
-
- 5 edits in trunk/Source
Versioning.
- 10:59 PM Changeset in webkit [102436] by
-
- 1 copy in tags/Safari-535.12
New Tag.
- 10:54 PM Changeset in webkit [102435] by
-
- 18 edits3 adds in trunk/Source
[Qt] [WK2] Webkit should release TextureMapper GL objects if page paint node is deallocated.
https://bugs.webkit.org/show_bug.cgi?id=73591
Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-12-08
Reviewed by Noam Rosenthal.
Source/WebCore:
Implementation of helper function to remove all GL allocated tiles
when QQuickWebView gets removed from canvas.
Tested by new API test in WK2 (tst_QQuickWebView::removeFromCanvas).
- platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::purgeNodeTexturesRecursive):
- platform/graphics/texmap/TextureMapperNode.h:
Source/WebKit2:
Implement deallocation of TextureMapper GL objects when QQuickWebPage paint node deallocated.
Also adds purging GraphicsLayer backing stores on WebProcess side in order to force repainting
when page becomes visible and painting resumes and fixes incorrect initialization of view
visibility state.
- UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::resetPaintNode):
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
- UIProcess/API/qt/tests/html/direct-image-compositing.html: Added.
- UIProcess/API/qt/tests/html/resources/simple_image.png: Added.
- UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::showWebView):
(tst_QQuickWebView::removeFromCanvas):
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::layerTreeHostProxy):
- UIProcess/LayerTreeHostProxy.h:
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::purgeGLResources):
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::purgeGLResources):
- UIProcess/qt/QtWebPageProxy.h:
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::purgeBackingStores):
(WebCore::WebGraphicsLayer::recreateBackingStoreIfNeeded):
- WebProcess/WebCoreSupport/WebGraphicsLayer.h:
- WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::purgeBackingStores):
- WebProcess/WebPage/LayerTreeHost.messages.in:
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::flushPendingLayerChanges):
(WebKit::LayerTreeHostQt::purgeBackingStores):
(WebKit::LayerTreeHostQt::recreateBackingStoreIfNeeded):
- WebProcess/WebPage/qt/LayerTreeHostQt.h:
- 10:53 PM Changeset in webkit [102434] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, chromium test expectation update.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08
- platform/chromium/test_expectations.txt:
- 10:43 PM Changeset in webkit [102433] by
-
- 1 edit6 adds in trunk/Source/WebCore
Upstream platform/network/blackberry/DeferredData.{h, cpp}, NetworkJob.{h, cpp} and NetworkManager.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=73791
Reviewed by Rob Buis.
Other main contributors:
Joe Mason <jmason@rim.com>
Lianghui Chen <liachen@rim.com>
Charles Wei <charles.wei@torchmobile.com.cn>
Initial upstream, can't be built yet, no new tests.
- platform/network/blackberry/DeferredData.cpp: Added.
- platform/network/blackberry/DeferredData.h: Added.
- platform/network/blackberry/NetworkJob.cpp: Added.
- platform/network/blackberry/NetworkJob.h: Added.
- platform/network/blackberry/NetworkManager.cpp: Added.
- platform/network/blackberry/NetworkManager.h: Added.
- 9:36 PM Changeset in webkit [102432] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed, rebaseline fast/repaint/textarea-set-disabled.html for
Chromium Linux.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08
- platform/chromium-linux/fast/repaint/textarea-set-disabled-expected.png: Added.
- 9:26 PM Changeset in webkit [102431] by
-
- 10 edits in trunk/Source/WebCore
It's semantically incorrect to call notifyNodeListsAttributeChanged in dispatchSubtreeModifiedEvent
https://bugs.webkit.org/show_bug.cgi?id=74028
Reviewed by Darin Adler.
Remove a call to notifyNodeListsAttributeChanged in dispatchSubtreeModified and add explicit calls
to notifyNodeListsAttributeChanged at appropriate places.
Also merge notifyNodeListsChildrenChanged with notifyLocalNodeListsChildrenChanged, and
notifyNodeListsAttributeChanged with notifyLocalNodeListsAttributeChanged, and rename them to
invalidateNodeListsCacheAfterAttributeChanges and invalidateNodeListsCacheAfterNodeChanges respectively.
- dom/Attr.cpp:
(WebCore::Attr::childrenChanged):
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::childrenChanged):
- dom/Document.cpp:
(WebCore::Document::updateRangesAfterNodeChanges):
- dom/Document.h:
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::addAttribute):
(WebCore::NamedNodeMap::removeAttribute):
- dom/Node.cpp:
(WebCore::removeNodeListCacheIfPossible):
(WebCore::Node::unregisterDynamicNodeList):
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanges):
(WebCore::Node::invalidateNodeListsCacheAfterNodeChanges):
(WebCore::Node::dispatchSubtreeModifiedEvent):
- dom/Node.h:
- dom/NodeRareData.h:
- dom/StyledElement.cpp:
(WebCore::StyledElement::classAttributeChanged):
- 9:23 PM Changeset in webkit [102430] by
-
- 19 edits3 moves in trunk
Unreviewed, rolling out r102418.
http://trac.webkit.org/changeset/102418
https://bugs.webkit.org/show_bug.cgi?id=71870
Caused Chromium build failure.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08
Source/WebCore:
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::maybeRestoreContext):
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebKitLoseContext.cpp: Renamed from Source/WebCore/html/canvas/WebGLLoseContext.cpp.
(WebCore::WebKitLoseContext::WebKitLoseContext):
(WebCore::WebKitLoseContext::~WebKitLoseContext):
(WebCore::WebKitLoseContext::getName):
(WebCore::WebKitLoseContext::create):
(WebCore::WebKitLoseContext::loseContext):
(WebCore::WebKitLoseContext::restoreContext):
- html/canvas/WebKitLoseContext.h: Renamed from Source/WebCore/html/canvas/WebGLLoseContext.h.
- html/canvas/WebKitLoseContext.idl: Renamed from Source/WebCore/html/canvas/WebGLLoseContext.idl.
LayoutTests:
- fast/canvas/webgl/WebGLContextEvent.html:
- fast/canvas/webgl/context-destroyed-crash.html:
- fast/canvas/webgl/context-lost-expected.txt:
- fast/canvas/webgl/context-lost-restored.html:
- fast/canvas/webgl/context-lost.html:
- 9:15 PM Changeset in webkit [102429] by
-
- 12 edits in trunk/Source
[Chromium] Enable viewport metatag
https://bugs.webkit.org/show_bug.cgi?id=73495
Reviewed by Darin Fisher.
Source/JavaScriptCore:
- wtf/Platform.h: Added ENABLE(VIEWPORT) tag.
Source/WebCore:
Recompute viewpot parameters on frame rect resize.
- page/FrameView.cpp:
(WebCore::FrameView::setFrameRect):
Source/WebKit/chromium:
Compute the appropriate fixed layout size, page, and device scale factors,
based on the viewport meta tag parameters.
See http://developer.android.com/guide/webapps/targeting.html for more information.
- features.gypi:
- public/WebView.h:
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::layoutUpdated):
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
- src/ChromeClientImpl.h:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::isPageScaleFactorSet):
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::observeNewNavigation):
- src/WebViewImpl.h:
- 9:00 PM WebKit Team edited by
- Updated my (very outdated) entry (diff)
- 9:00 PM Changeset in webkit [102428] by
-
- 2 edits in trunk/Source/WebCore
Build fix for r102419.
https://bugs.webkit.org/show_bug.cgi?id=73916
- platform/PopupMenuClient.h:
(WebCore::PopupMenuClient::listBoxSelectItem):
Remove unused argument names.
- 8:51 PM Changeset in webkit [102427] by
-
- 8 edits in trunk/Source/WebCore
Unreviewed. Rebaselined run-bindings-tests results.
- bindings/scripts/test/JS/JSFloat64Array.cpp:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- 8:37 PM Changeset in webkit [102426] by
-
- 1 edit2 adds in trunk/Source/WebCore
Upstream BlackBerry porting of MIMETypeRegistry/KeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=73534
Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-08
Reviewed by Rob Buis.
Other main contributors:
Mike Fenton <mifenton@rim.com>
Joe Mason <jmason@rim.com>
Max Feil <mfeil@qnx.com>
Lukas Sydorowski <lsydorowski@rim.com>
Crystal Zhang <haizhang@rim.com>
Initial upstream, no new tests.
- platform/blackberry/MIMETypeRegistryBlackBerry.cpp: Added.
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
(WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
- platform/blackberry/PlatformKeyboardEventBlackBerry.cpp: Added.
(WebCore::keyIdentifierForBlackBerryCharacter):
(WebCore::windowsKeyCodeForBlackBerryCharacter):
(WebCore::adjustCharacterFromOS):
(WebCore::toWebCorePlatformKeyboardEventType):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
(WebCore::PlatformKeyboardEvent::currentCapsLockState):
(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
(WebCore::PlatformKeyboardEvent::getCurrentModifierState):
- 8:22 PM Changeset in webkit [102425] by
-
- 4 edits2 deletes in trunk
Unreviewed, rolling out r101619.
http://trac.webkit.org/changeset/101619
https://bugs.webkit.org/show_bug.cgi?id=74158
this patch produces bad behaviour on mac (Requested by
jeremya_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-08
Source/WebCore:
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::dragSourceEndedAt):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateHoverActiveState):
LayoutTests:
- fast/css/hover-active-drag-expected.txt: Removed.
- fast/css/hover-active-drag.html: Removed.
- 8:19 PM Changeset in webkit [102424] by
-
- 6 edits2 adds in trunk
[MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
https://bugs.webkit.org/show_bug.cgi?id=73492
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/mutation/inline-event-listener.html
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject): Call v8::Script::Run directly instead of going through V8Proxy.
Tools:
Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
keypress event without any script on the stack.
- DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
(EventSender::keyDown):
(KeyDownTask::KeyDownTask):
(KeyDownTask::runIfValid):
(EventSender::scheduleAsynchronousKeyDown):
- DumpRenderTree/chromium/EventSender.h:
LayoutTests:
- fast/mutation/inline-event-listener-expected.txt: Added.
- fast/mutation/inline-event-listener.html: Added.
- 8:16 PM Changeset in webkit [102423] by
-
- 3 edits2 adds in trunk
Suppress rendering of light children when ShadowRoot is dynamically created.
https://bugs.webkit.org/show_bug.cgi?id=72441
Reviewed by Ryosuke Niwa.
Source/WebCore:
Tests: fast/dom/shadow/dynamically-created-shadow-root-expected.html
fast/dom/shadow/dynamically-created-shadow-root.html
- dom/Element.cpp:
(WebCore::Element::setShadowRoot):
LayoutTests:
- fast/dom/shadow/dynamically-created-shadow-root-expected.html: Added.
- fast/dom/shadow/dynamically-created-shadow-root.html: Added.
- 8:12 PM Changeset in webkit [102422] by
-
- 2 edits43 adds in trunk/LayoutTests
Unreviewed, chromium test rebaseline tests added in r102388. Updates expectations.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08
- platform/chromium-cg-mac-leopard/transitions/cross-fade-background-image-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/animations/cross-fade-background-image-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/animations/cross-fade-border-image-source-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/animations/cross-fade-border-image-source-expected.txt: Added.
- platform/chromium-cg-mac-snowleopard/animations/cross-fade-list-style-image-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/animations/cross-fade-webkit-mask-image-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/transitions/cross-fade-background-image-expected.png: Added.
- platform/chromium-linux/animations/cross-fade-background-image-expected.png: Added.
- platform/chromium-linux/animations/cross-fade-border-image-source-expected.png: Added.
- platform/chromium-linux/animations/cross-fade-list-style-image-expected.png: Added.
- platform/chromium-linux/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
- platform/chromium-linux/animations/cross-fade-webkit-mask-image-expected.png: Added.
- platform/chromium-linux/transitions/cross-fade-background-image-expected.png: Added.
- platform/chromium-linux/transitions/cross-fade-border-image-expected.png: Added.
- platform/chromium-mac-leopard/animations/cross-fade-background-image-expected.png: Added.
- platform/chromium-mac-leopard/animations/cross-fade-border-image-source-expected.png: Added.
- platform/chromium-mac-leopard/animations/cross-fade-list-style-image-expected.png: Added.
- platform/chromium-mac-leopard/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
- platform/chromium-mac-leopard/animations/cross-fade-webkit-mask-image-expected.png: Added.
- platform/chromium-mac-leopard/transitions/cross-fade-background-image-expected.png: Added.
- platform/chromium-mac-leopard/transitions/cross-fade-border-image-expected.png: Added.
- platform/chromium-mac-snowleopard/animations/cross-fade-background-image-expected.png: Added.
- platform/chromium-mac-snowleopard/animations/cross-fade-list-style-image-expected.png: Added.
- platform/chromium-mac-snowleopard/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
- platform/chromium-mac-snowleopard/animations/cross-fade-webkit-mask-image-expected.png: Added.
- platform/chromium-mac-snowleopard/transitions/cross-fade-background-image-expected.png: Added.
- platform/chromium-win/animations/cross-fade-background-image-expected.png: Added.
- platform/chromium-win/animations/cross-fade-background-image-expected.txt: Added.
- platform/chromium-win/animations/cross-fade-border-image-source-expected.png: Added.
- platform/chromium-win/animations/cross-fade-border-image-source-expected.txt: Added.
- platform/chromium-win/animations/cross-fade-list-style-image-expected.png: Added.
- platform/chromium-win/animations/cross-fade-list-style-image-expected.txt: Added.
- platform/chromium-win/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
- platform/chromium-win/animations/cross-fade-webkit-mask-box-image-expected.txt: Added.
- platform/chromium-win/animations/cross-fade-webkit-mask-image-expected.png: Added.
- platform/chromium-win/animations/cross-fade-webkit-mask-image-expected.txt: Added.
- platform/chromium-win/transitions/cross-fade-background-image-expected.png: Added.
- platform/chromium-win/transitions/cross-fade-background-image-expected.txt: Added.
- platform/chromium-win/transitions/cross-fade-border-image-expected.png: Added.
- platform/chromium-win/transitions/cross-fade-border-image-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 7:28 PM Changeset in webkit [102421] by
-
- 3 edits in trunk/LayoutTests
Accessibility object searching layout tests are incomplete.
https://bugs.webkit.org/show_bug.cgi?id=74130
Patch by Sam White <samuel.white@rochester.edu> on 2011-12-08
Reviewed by Chris Fleizach.
Added a layout test to support visited link searching and removed frame searching
(which was unimplemented) as it's fully covered by the tests in:
platform/mac/accessibility/search-with-frames.html
- platform/mac/accessibility/search-predicate-expected.txt:
- platform/mac/accessibility/search-predicate.html:
- 7:24 PM Changeset in webkit [102420] by
-
- 2 edits in trunk/Tools
[gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
https://bugs.webkit.org/show_bug.cgi?id=73980
Reviewed by Tony Chang.
- gdb/webkit.py:
(guess_string_length):
(ustring_to_string):
(lstring_to_string):
(LCharStringPrinter):
(LCharStringPrinter.to_string):
(WTFStringImplPrinter.get_length):
(WTFStringImplPrinter.to_string):
(WTFStringImplPrinter.is_8bit):
(WTFStringPrinter.stringimpl_ptr):
(WTFStringPrinter.get_length):
(WTFStringPrinter.to_string):
(add_pretty_printers.lookup_function):
- 7:22 PM Changeset in webkit [102419] by
-
- 14 edits in trunk
Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
https://bugs.webkit.org/show_bug.cgi?id=73916
Source/WebCore:
This was needed for Qt since the mobile theme, which can be picked
up at runtime, delegates the rendering of list boxes.
Reviewed by Kent Tamura.
No new tests, there's no functional change.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::usesMenuList):
- html/HTMLSelectElement.h:
- platform/PopupMenuClient.h:
(WebCore::PopupMenuClient::listBoxSelectItem):
(WebCore::PopupMenuClient::multiple):
- platform/qt/RenderThemeQtMobile.h:
(WebCore::RenderThemeQtMobile::delegatesMenuListRendering):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::multiple):
- rendering/RenderMenuList.h:
- rendering/RenderTheme.h:
(WebCore::RenderTheme::delegatesMenuListRendering):
Source/WebKit/chromium:
Reviewed by Kent Tamura.
- src/ExternalPopupMenu.cpp:
(WebKit::ExternalPopupMenu::didAcceptIndices):
(WebKit::ExternalPopupMenu::getPopupMenuInfo):
Source/WebKit/qt:
Reviewed by Kent Tamura.
- WebCoreSupport/PopupMenuQt.cpp:
(SelectData::multiple):
(WebCore::PopupMenuQt::selectItem):
Tools:
Reviewed by Kent Tamura.
- qmake/mkspecs/features/features.prf:
- 7:07 PM Changeset in webkit [102418] by
-
- 19 edits3 moves in trunk
Rename WEBKIT_lose_context to WEBKIT_WEBGL_lose_context
https://bugs.webkit.org/show_bug.cgi?id=71870
Source/WebCore:
Reviewed by James Robinson.
Rename largely done with do-webcore-rename with a couple of
necessary manual fixups. Ran WebGL layout tests.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLLoseContext.cpp: Copied from Source/WebCore/html/canvas/WebKitLoseContext.cpp.
(WebCore::WebGLLoseContext::WebGLLoseContext):
(WebCore::WebGLLoseContext::~WebGLLoseContext):
(WebCore::WebGLLoseContext::getName):
(WebCore::WebGLLoseContext::create):
(WebCore::WebGLLoseContext::loseContext):
(WebCore::WebGLLoseContext::restoreContext):
- html/canvas/WebGLLoseContext.h: Copied from Source/WebCore/html/canvas/WebKitLoseContext.h.
- html/canvas/WebGLLoseContext.idl: Copied from Source/WebCore/html/canvas/WebKitLoseContext.idl.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::maybeRestoreContext):
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebKitLoseContext.cpp: Removed.
- html/canvas/WebKitLoseContext.h: Removed.
- html/canvas/WebKitLoseContext.idl: Removed.
LayoutTests:
Synchronized context-lost-restored.html and context-lost.html with
Khronos repository; upstream tests must check for multiple vendor
prefixes.
Reviewed by James Robinson.
- fast/canvas/webgl/WebGLContextEvent.html:
- fast/canvas/webgl/context-destroyed-crash.html:
- fast/canvas/webgl/context-lost-expected.txt:
- fast/canvas/webgl/context-lost-restored.html:
- fast/canvas/webgl/context-lost.html:
- 6:59 PM Changeset in webkit [102417] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed chromium rebaseline fast/repaint/textarea-set-disabled.html.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08
- platform/chromium-win/fast/repaint/textarea-set-disabled-expected.png: Added.
- platform/chromium/fast/repaint/textarea-set-disabled-expected.png: Added.
- 6:49 PM Changeset in webkit [102416] by
-
- 6 edits1 add in trunk/Source/WebCore
Use the [Supplemental] IDL for webaudio attributes in Chromium
https://bugs.webkit.org/show_bug.cgi?id=73394
Reviewed by Adam Barth.
- Overview: Using the [Supplemental] IDL, this patch moves the attribute
declarations of webaudio from DOMWindow.idl into a new IDL file
webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained
feature (aka a module).
- This patch changes the build flow of WebCore.gyp as follows:
Previous build flow:
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;
}
New build flow (See the discussions in bug 72138 for more details):
resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl;
}
- This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL
will be removed after build scripts for all platforms support the [Supplemental] IDL.
The motivation for the [Supplemented] IDL is as follows:
In order to support the [Supplemental] IDL, we need to
(1) run resolve-supplemental.pl and generate supplemental_dependency.tmp
(2) and run generate-bindings.pl with the supplemental_dependency.tmp.
This build flow requires a change on the following build scripts,
but changing all the build scripts all at once without any regression is too difficult:
- DerivedSources.make
- DerivedSources.pri
- GNUmakefile.am
- PlatformBlackBerry.cmake
- UseJSC.cmake
- UseV8.cmake
- WebCore.vcproj/MigrateScripts
- WebCore.vcproj/WebCore.vcproj
- bindings/gobject/GNUmakefile.am
- WebCore.gyp/WebCore.gyp
Thus, we are planning to change the build scripts one by one, which implies that
we need to allow the temporary state in which some build scripts support [Supplemental] IDL
but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented].
The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental]
in another IDL file somewhere, like this:
DOMWindowWebAudio.idl:
interface [
Supplemental=DOMWindow
] DOMWindowWebAudio {
attribute attr1;
attribute attr2;
};
DOMWindow.idl:
interface [
] DOMWindow {
attribute [Supplemented] attr1; This line will be removed after all build scripts support the [Su IDL
attribute [Supplemented] attr2; This line will be removed after all build scripts support the [Su IDL.
attribute attr3;
attribute attr4;
};
Assuming these IDL files, this patch implements the following logic in generate-bindings.pl:
- If a given build script supports the [Supplemental] IDL, generate-bindings.pl ignores all attributes with the [Supplemented] IDL.
- Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL as normal attributes and instead ignores all attributes with the [Supplemental] IDL (i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL).
Tests: webaudio/*
- WebCore.gyp/WebCore.gyp: Describes the build flow that I described above.
- WebCore.gyp/scripts/action_derivedsourcesallinone.py:
(main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file. If the file name is a "/cygdrive/c/..."-style path, it is converted to a "C:\cygwin\..."-style path by the cygpath command.
- WebCore.gypi: Added DOMWindowWebAudio.idl.
- bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL.
- page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL.
- webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in DOMWindow.idl.
- 6:38 PM Changeset in webkit [102415] by
-
- 1 edit2 adds in trunk/LayoutTests
Add test for inline style block in HTML tag
https://bugs.webkit.org/show_bug.cgi?id=72360
Patch by Szilard Ledan <Ledan-Muntean.Szilard@stud.u-szeged.hu> on 2011-12-08
Reviewed by Darin Adler.
- fast/css/parsing-css-block-expected.txt: Added.
- fast/css/parsing-css-block.html: Added.
- 6:32 PM Changeset in webkit [102414] by
-
- 2 edits2 adds in trunk/LayoutTests
Unreviewed, rolling out r102396.
http://trac.webkit.org/changeset/102396
https://bugs.webkit.org/show_bug.cgi?id=74153
over-active-drag test still failing. (Requested by macpherson
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-08
- fast/css/hover-active-drag.html:
- platform/chromium/fast/css/hover-active-drag-expected.txt: Added.
- platform/mac/fast/css/hover-active-drag-expected.txt: Added.
- 6:28 PM Changeset in webkit [102413] by
-
- 4 edits in trunk/Source/WebCore
Caret keeps blinking during forward-delete
https://bugs.webkit.org/show_bug.cgi?id=38564
Patch by Van Lam <vanlam@google.com> on 2011-12-08
Reviewed by Darin Adler.
Currently updateAppearance determines if the caret should stop blinking
based on whether or not the editing operation changed the position of
the caret; so the caret stops blinking in case of typing text and
backwards delete (which always displace the caret) but does not stop
blinking in the case of forward delete (which does not displace the
caret).
Added a boolean member function shouldStopCaretBlinking in EditCommand
which will return true if the object is a TypingCommand (my
understanding here is that all TypingCommands should stop the caret
from blinking for a cycle, currently 0.5 seconds). Then used this
function to stop the caret from blinking if the last editing command
is a TypingCommand.
- editing/EditCommand.h:
(WebCore::EditCommand::shouldStopCaretBlinking):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::updateAppearance):
- editing/TypingCommand.h:
(WebCore::TypingCommand::shouldStopCaretBlinking):
- 6:00 PM Changeset in webkit [102412] by
-
- 2 edits in trunk/Tools
Unreviewed contributor additions to committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 5:59 PM Changeset in webkit [102411] by
-
- 21 edits3 copies4 moves29 adds1 delete in trunk/LayoutTests
[Chromium] Rebaseline for r102320.
- platform/chromium-cg-mac-leopard/fast/forms/basic-inputs-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/forms/file/file-input-disabled-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/forms/file/file-input-disabled-expected.txt: Added.
- platform/chromium-cg-mac-leopard/fast/forms/input-disabled-color-expected.png:
- platform/chromium-cg-mac-snowleopard/fast/forms/basic-inputs-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/file/file-input-disabled-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/file/file-input-disabled-expected.txt: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
- platform/chromium-cg-mac/fast/forms/file/file-input-disabled-expected.png: Removed.
- platform/chromium-linux-x86/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/file/file-input-disabled-expected.txt.
- platform/chromium-linux/fast/forms/file/file-input-disabled-expected.png:
- platform/chromium-linux/fast/forms/file/file-input-disabled-expected.txt:
- platform/chromium-linux/fast/forms/input-disabled-color-expected.png:
- platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
- platform/chromium-mac-leopard/fast/forms/basic-inputs-expected.png: Added.
- platform/chromium-mac-leopard/fast/forms/file/file-input-disabled-expected.png: Added.
- platform/chromium-mac-leopard/fast/forms/file/file-input-disabled-expected.txt: Added.
- platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/basic-textareas-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/basic-textareas-quirks-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/file/file-input-disabled-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/file/file-input-disabled-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/input-appearance-disabled-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
- platform/chromium-win-vista/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/file/file-input-disabled-expected.txt.
- platform/chromium-win-xp/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/file/file-input-disabled-expected.txt.
- platform/chromium-win/fast/forms/basic-inputs-expected.txt:
- platform/chromium-win/fast/forms/basic-textareas-expected.txt:
- platform/chromium-win/fast/forms/basic-textareas-quirks-expected.txt:
- platform/chromium-win/fast/forms/file/file-input-disabled-expected.png:
- platform/chromium-win/fast/forms/file/file-input-disabled-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-disabled-expected.txt:
- platform/chromium-win/fast/forms/input-disabled-color-expected.png:
- platform/chromium-win/fast/forms/input-disabled-color-expected.txt:
- platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
- platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
- platform/chromium/fast/forms/basic-inputs-expected.txt: Added.
- platform/chromium/fast/forms/basic-textareas-expected.txt: Added.
- platform/chromium/fast/forms/basic-textareas-quirks-expected.txt: Added.
- platform/chromium/fast/forms/input-appearance-disabled-expected.txt: Added.
- platform/chromium/fast/forms/input-disabled-color-expected.txt: Added.
- platform/chromium/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.
- platform/chromium/fast/forms/placeholder-pseudo-style-expected.txt: Added.
- platform/chromium/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 5:56 PM Changeset in webkit [102410] by
-
- 4 edits in trunk/Source
Use HashMap<Node*, OwnPtr<...>> in ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=73964
Reviewed by Darin Adler.
Source/JavaScriptCore:
- wtf/HashTraits.h: Add passOut(std::nullptr_t) to allow callers to use HashMap::take on a HashMap of OwnPtrs.
Source/WebCore:
Re-landing r102267 with a fix for the clang build.
No new tests, refactoring only.
- dom/ChildListMutationScope.cpp:
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::childAdded):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::willRemoveChild):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::incrementScopingLevel):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::decrementScopingLevel):
- 5:54 PM Changeset in webkit [102409] by
-
- 2 edits in trunk/Source/WebCore
WebScrollbarPainterDelegate should have a pointer to its Scrollbar
https://bugs.webkit.org/show_bug.cgi?id=74149
Reviewed by Darin Adler.
This is another step towards making the scroll animation code more robust.
- platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate initWithScrollbar:WebCore::]):
(-[WebScrollbarPainterDelegate scrollAnimator]):
(-[WebScrollbarPainterDelegate layer]):
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
- 5:46 PM Changeset in webkit [102408] by
-
- 3 edits2 adds in trunk
keyboard event doesn't fire while moving mouse with button pressed
https://bugs.webkit.org/show_bug.cgi?id=73821
Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-12-08
Reviewed by Alexey Proskuryakov.
Autoscroll should not stop on key press.
Source/WebCore:
Test: fast/events/autoscroll-should-not-stop-on-keypress.html
- page/EventHandler.cpp:
(WebCore::EventHandler::keyEvent):
Removed the check for autoscroll so that autoscroll is not stopped on
key press and key event is processed.
LayoutTests:
- fast/events/autoscroll-should-not-stop-on-keypress-expected.txt: Added.
- fast/events/autoscroll-should-not-stop-on-keypress.html: Added.
- 5:46 PM Changeset in webkit [102407] by
-
- 9 edits in trunk/Source/WebKit2
Forced compositing mode breaks display of full-page PDFs in WK2
https://bugs.webkit.org/show_bug.cgi?id=74122
<rdar://problem/9550059>
Reviewed by Dan Bernstein.
Full page PDFs are displayed in WK2 in a subview of the WKView. However,
when the WKView is forced to use accelerated compositing, the layer obscures
the PDF subview.
To fix this we have to drop out of compositing mode when the WKView is showing
a custom representation.
- UIProcess/API/mac/WKView.mm:
(-[WKView _setPageHasCustomRepresentation:]): Tell the drawing area that the view
gained or lost a custom representation.
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::pageCustomRepresentationChanged):
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::pageCustomRepresentationChanged): Send a messgae to the web process
to indicate that the custom representation changed.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::pageCustomRepresentationChanged):
- WebProcess/WebPage/DrawingArea.messages.in:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::pageCustomRepresentationChanged): Enter or exit compositing mode
as appropriate when we gain or lost a custom represenetation.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
- WebProcess/WebPage/DrawingAreaImpl.h:
- 5:35 PM Changeset in webkit [102406] by
-
- 2 edits in trunk/Source/WebCore
Add scrollAnimator getter method to WebScrollbarPainterDelegate
https://bugs.webkit.org/show_bug.cgi?id=74146
Reviewed by Beth Dakin.
- platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate scrollAnimator]):
(-[WebScrollbarPainterDelegate layer]):
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
- 5:33 PM Changeset in webkit [102405] by
-
- 7 edits2 adds in trunk
Source/WebCore: Improve handling of frame removal during requestAnimationFrame callback invocation
https://bugs.webkit.org/show_bug.cgi?id=74036
Reviewed by Adam Barth.
See bug for details.
Test: fast/animation/request-animation-frame-detach-element.html
- dom/Document.cpp:
(WebCore::Document::removedLastRef):
(WebCore::Document::detach):
- dom/Document.h:
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::~ScriptedAnimationController):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::scheduleAnimation):
- dom/ScriptedAnimationController.h:
(WebCore::ScriptedAnimationController::create):
(WebCore::ScriptedAnimationController::clearDocumentPointer):
- page/FrameView.cpp:
(WebCore::FrameView::serviceScriptedAnimations):
LayoutTests: Add some tests for removing frames from the document while servicing requestAnimationFrame callbacks
https://bugs.webkit.org/show_bug.cgi?id=74036
Reviewed by Adam Barth.
- fast/animation/request-animation-frame-detach-element-expected.txt: Added.
- fast/animation/request-animation-frame-detach-element.html: Added.
- 5:31 PM Changeset in webkit [102404] by
-
- 7 edits in trunk/Source/WebCore
Use bitfield for bool data members in BitmapImage.
https://bugs.webkit.org/show_bug.cgi?id=74102
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2011-12-08
Reviewed by Darin Adler.
Class BitmapImage and FrameData has bool data members, we can use bitfield for those data
members to reduce the BitmapImage's memory footprint.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage):
- platform/graphics/BitmapImage.h:
(WebCore::FrameData::FrameData):
- platform/graphics/cairo/ImageCairo.cpp:
(WebCore::BitmapImage::BitmapImage):
- platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::BitmapImage):
- platform/graphics/openvg/ImageOpenVG.cpp:
(WebCore::BitmapImage::BitmapImage):
- platform/graphics/qt/ImageQt.cpp:
(WebCore::BitmapImage::BitmapImage):
- 5:16 PM Changeset in webkit [102403] by
-
- 2 edits in trunk/Source/WebCore
Fix a paste-o in ScrollAnimatorMac::updateScrollerStyle
https://bugs.webkit.org/show_bug.cgi?id=74145
Reviewed by Sam Weinig.
Call setHorizontalScrollerImp to set the horizontal scrollbar painter.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
- 5:13 PM Changeset in webkit [102402] by
-
- 1 edit3 adds12 deletes in trunk/LayoutTests
Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=74116
Patch by Jacob Goldstein <jacobg@adobe.com> on 2011-12-08
Reviewed by Darin Adler.
- fast/regions/webkit-flow-renderer-expected.html: Added.
- fast/regions/webkit-flow-renderer-layer-expected.html: Added.
- fast/regions/webkit-flow-renderer-nested-expected.html: Added.
- platform/efl/fast/regions/webkit-flow-renderer-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-renderer-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-renderer-layer-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-renderer-layer-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-renderer-nested-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-renderer-nested-expected.txt: Removed.
- platform/mac/fast/regions/webkit-flow-renderer-expected.png: Removed.
- platform/mac/fast/regions/webkit-flow-renderer-expected.txt: Removed.
- platform/mac/fast/regions/webkit-flow-renderer-layer-expected.png: Removed.
- platform/mac/fast/regions/webkit-flow-renderer-layer-expected.txt: Removed.
- platform/mac/fast/regions/webkit-flow-renderer-nested-expected.png: Removed.
- platform/mac/fast/regions/webkit-flow-renderer-nested-expected.txt: Removed.
- 5:11 PM Changeset in webkit [102401] by
-
- 3 edits in trunk/Source/WebCore
Create one WebScrollbarPainterDelegate for each scrollbar
https://bugs.webkit.org/show_bug.cgi?id=74142
Reviewed by Sam Weinig.
Create and destroy WebScrollbarPainterDelegate objects as scrollbars come and go.
This is a step towards simplifying the WebScrollbarPainterDelegate object.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::cancelAnimations):
- 5:04 PM Changeset in webkit [102400] by
-
- 17 edits in trunk
[Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
https://bugs.webkit.org/show_bug.cgi?id=74017
Source/WebCore:
Patch by David Reveman <reveman@chromium.org> on 2011-12-08
Reviewed by James Robinson.
Add per-tile drawing to page settings.
No new tests.
- page/Settings.h:
(WebCore::Settings::setPerTileDrawingEnabled):
(WebCore::Settings::perTileDrawingEnabled):
- testing/Internals.cpp:
(WebCore::Internals::setPerTileDrawingEnabled):
- testing/Internals.h:
Source/WebKit/chromium:
Patch by David Reveman <reveman@chromium.org> on 2011-12-08
Reviewed by James Robinson.
Add WebSettings::setAcceleratedPaintingEnabled to public API.
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setAcceleratedPaintingEnabled):
(WebKit::WebSettingsImpl::setPerTilePaintingEnabled):
- src/WebSettingsImpl.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
Tools:
Patch by David Reveman <reveman@chromium.org> on 2011-12-08
Reviewed by James Robinson.
Add support for command line flag enable-per-tile-painting in DumpRenderTree.
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
- DumpRenderTree/chromium/TestShell.h:
(TestShell::setAcceleratedPaintingEnabled):
(TestShell::setPerTilePaintingEnabled):
- DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
- DumpRenderTree/chromium/WebPreferences.h:
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver._wrapper_options):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 4:58 PM Changeset in webkit [102399] by
-
- 1 edit3 adds in trunk/LayoutTests
REGRESSION: Changing disabled state of a textarea does not do a repaint
https://bugs.webkit.org/show_bug.cgi?id=23789
Reviewed by Darin Adler.
The bug got fixed (I did not bisect to find out when) thus landing
the test case converted to a repaint test and made cross-platform.
- fast/repaint/textarea-set-disabled-expected.png: Added.
- fast/repaint/textarea-set-disabled-expected.txt: Added.
- fast/repaint/textarea-set-disabled.html: Added.
- 4:52 PM Changeset in webkit [102398] by
-
- 2 edits in trunk/Source/WebCore
Add a scrollbarPainterForScrollbar helper function
https://bugs.webkit.org/show_bug.cgi?id=74139
Reviewed by Sam Weinig.
- platform/mac/ScrollAnimatorMac.mm:
(macScrollbarTheme):
(scrollbarPainterForScrollbar):
(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
- 4:42 PM Changeset in webkit [102397] by
-
- 9 edits2 moves in trunk/Source
[chromium] Move NonCompositedContentHost to WebKit
https://bugs.webkit.org/show_bug.cgi?id=74047
Patch by James Robinson <jamesr@chromium.org> on 2011-12-08
Reviewed by Kenneth Russell.
Source/WebCore:
Updates WebCore.gypi to remove files no longer within WebCore and removes unused forward declaration and include
from LayerRendererChromium.
- WebCore.gypi:
- platform/graphics/chromium/LayerRendererChromium.cpp:
- platform/graphics/chromium/LayerRendererChromium.h:
Source/WebKit/chromium:
Moves NonCompositedContentHost into WebKit/chromium/src. This class is a helper class designed to make it easier
for WebViewImpl to interface with the compositor. The compositor proper should not depend on this class, and
other clients of the compositor do not need this functionality.
Follow-up patches will transition this code from using compositor-internal interfaces directly to using
higher-level interfaces like the WebKit platform APIs. This patch simply does a file mv and updates namespaces
to keep things simpler.
Refactor only and covered by several unit tests.
- WebKit.gyp:
- src/NonCompositedContentHost.cpp: Renamed from Source/WebCore/platform/graphics/chromium/NonCompositedContentHost.cpp.
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::~NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setBackgroundColor):
(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::scrollLayer):
(WebKit::NonCompositedContentHost::protectVisibleTileTextures):
(WebKit::NonCompositedContentHost::invalidateRect):
(WebKit::NonCompositedContentHost::notifyAnimationStarted):
(WebKit::NonCompositedContentHost::notifySyncRequired):
(WebKit::NonCompositedContentHost::paintContents):
(WebKit::NonCompositedContentHost::showDebugBorders):
(WebKit::NonCompositedContentHost::showRepaintCounter):
- src/NonCompositedContentHost.h: Renamed from Source/WebCore/platform/graphics/chromium/NonCompositedContentHost.h.
(WebKit::NonCompositedContentHost::create):
(WebKit::NonCompositedContentHost::topLevelRootLayer):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::nonCompositedContentHost):
- src/WebViewImpl.h:
- tests/LayerChromiumTest.cpp:
- 4:41 PM Changeset in webkit [102396] by
-
- 2 edits2 deletes in trunk/LayoutTests
Fix fast/css/hover-active-drag.html on Mac
https://bugs.webkit.org/show_bug.cgi?id=74046
Patch by Jeremy Apthorp <jeremya@chromium.org> on 2011-12-08
Reviewed by Darin Adler.
- fast/css/hover-active-drag.html:
- platform/chromium/fast/css/hover-active-drag-expected.txt: Removed.
- platform/mac/fast/css/hover-active-drag-expected.txt: Removed.
- 4:37 PM Changeset in webkit [102395] by
-
- 4 edits in trunk/Source
[chromium] Layer contents scale change should trigger invalidation
https://bugs.webkit.org/show_bug.cgi?id=74086
When the contents scale of a layer is changed, the entire contents of
the layer should be marked dirty.
Patch by Sami Kyostila <skyostil@google.com> on 2011-12-08
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setContentsScale):
Source/WebKit/chromium:
- tests/LayerChromiumTest.cpp:
- 4:22 PM Changeset in webkit [102394] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Add CSS_FILTERS custom binding file to WebCore.gypi.
https://bugs.webkit.org/show_bug.cgi?id=74091
Reviewed by Adam Barth.
If it builds, you're happy.
- WebCore.gypi:
- 4:20 PM Changeset in webkit [102393] by
-
- 3 edits2 adds in trunk/Tools
create a "SystemHost" object for webkitpy to slim down the Host object
https://bugs.webkit.org/show_bug.cgi?id=72680
Reviewed by Eric Siedel.
This creates a SystemHost object that other objects that should
only have dependencies on functionality in webkitpy.common.system
can use; this will allow them to not require a full Host.
- Scripts/webkitpy/common/host.py:
- Scripts/webkitpy/common/host_mock.py:
- Scripts/webkitpy/common/system/systemhost.py: Added.
- Scripts/webkitpy/common/system/systemhost_mock.py: Added.
- 4:15 PM Changeset in webkit [102392] by
-
- 2 edits2 adds in trunk
Line breaks are lost when pasted into textarea text starting with a blank line set while textarea is hidden
https://bugs.webkit.org/show_bug.cgi?id=74126
Reviewed by Tony Chang.
The bug was caused by the code that generated text out of pre-rendered text was generating div's inside the fragment
pasted into textarea even though serialization algorithm in textarea doesn't handle block elements.
Fixed the bug by special-casing this in createFragmentFromText. In the long run, we should really get rid of this
whole pre-rendering trick.
- editing/markup.cpp:
(WebCore::createFragmentFromText):
- 4:07 PM Changeset in webkit [102391] by
-
- 3 edits3 adds in trunk
Moving SVG elements on the page doesn't always erase element at the old position
https://bugs.webkit.org/show_bug.cgi?id=74002
Patch by Florin Malita <fmalita@google.com> on 2011-12-08
Reviewed by Darin Adler.
Source/WebCore:
Test: svg/repaint/container-repaint.svg
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layout):
Save the old repaint bounds before updating the viewport.
LayoutTests:
- svg/repaint/container-repaint-expected.png: Added.
- svg/repaint/container-repaint-expected.txt: Added.
- svg/repaint/container-repaint.svg: Added.
- 3:38 PM Changeset in webkit [102390] by
-
- 3 edits in trunk/LayoutTests
Mark tests added in r102388 as failing on Chromium. Fix the cross platform
expected results for transitions/svg-transitions.html (the line number changed).
- platform/chromium/test_expectations.txt:
- transitions/svg-transitions-expected.txt:
- 3:16 PM Changeset in webkit [102389] by
-
- 7 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=74005
fix unaligned access memory in generatePatternCharacterOnce function
for SH4 platforms.
Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2011-12-08
Reviewed by Gavin Barraclough.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::load16Unaligned):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load16Unaligned):
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::load16Unaligned):
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::lshift32):
(JSC::MacroAssemblerSH4::load8):
(JSC::MacroAssemblerSH4::load16):
(JSC::MacroAssemblerSH4::load16Unaligned):
(JSC::MacroAssemblerSH4::branch8):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::load16Unaligned):
- jit/JIT.h:
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
- 3:06 PM Changeset in webkit [102388] by
-
- 11 edits24 adds in trunk
Enable animations of CSS images using -webkit-cross-fade
https://bugs.webkit.org/show_bug.cgi?id=74049
<rdar://problem/10209303>
Reviewed by Simon Fraser.
Add support for animating CSS images in the following properties:
- background(-image)
- border-image(-source)
- list-style(-image)
- -webkit-mask-box-image(-source)
- -webkit-mask-image(-source)
This patch only adds support for transitioning between NinePieceImages
where all of the properties except the image itself are equal, and the
size of the images are equal. Other cases will not animate.
Add animation blend functions for StyleImage and NinePieceImage.
Apply the proper compositing operation to -webkit-cross-fade, and
fix handling of the destination and source areas to support scaling.
Tests: animations/cross-fade-background-image.html
animations/cross-fade-border-image-source.html
animations/cross-fade-list-style-image.html
animations/cross-fade-webkit-mask-box-image.html
animations/cross-fade-webkit-mask-image.html
- css/CSSCrossfadeValue.cpp:
(WebCore::cachedImageForCSSValue):
(WebCore::CSSCrossfadeValue::fixedSize):
(WebCore::CSSCrossfadeValue::image):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::CSSImageValue):
- css/CSSImageValue.h:
(WebCore::CSSImageValue::create):
- page/animation/AnimationBase.cpp:
(WebCore::crossfadeBlend):
(WebCore::blendFunc):
(WebCore::RefCountedPropertyWrapper::RefCountedPropertyWrapper):
(WebCore::RefCountedPropertyWrapper::blend):
(WebCore::FillLayerRefCountedPropertyWrapper::FillLayerRefCountedPropertyWrapper):
(WebCore::FillLayerRefCountedPropertyWrapper::blend):
(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
(WebCore::AnimationBase::ensurePropertyMap):
(WebCore::addShorthandProperties):
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::drawCrossfade):
(WebCore::CrossfadeGeneratedImage::draw):
(WebCore::CrossfadeGeneratedImage::drawPattern):
- platform/graphics/CrossfadeGeneratedImage.h:
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setMaskImage):
Add tests of -webkit-animation (using -webkit-cross-fade) between:
- background-image
- border-image
- list-style-image
- -webkit-mask-box-image
- -webkit-mask-image
Add the ability for animation tests to compare an animated element to a static element.
Add tests of -webkit-transition (using -webkit-cross-fade) between:
- background-image
- border-image
- animations/cross-fade-background-image-expected.txt: Added.
- animations/cross-fade-background-image.html: Added.
- animations/cross-fade-border-image-source-expected.txt: Added.
- animations/cross-fade-border-image-source.html: Added.
- animations/cross-fade-list-style-image-expected.txt: Added.
- animations/cross-fade-list-style-image.html: Added.
- animations/cross-fade-webkit-mask-box-image-expected.txt: Added.
- animations/cross-fade-webkit-mask-box-image.html: Added.
- animations/cross-fade-webkit-mask-image-expected.txt: Added.
- animations/cross-fade-webkit-mask-image.html: Added.
- animations/resources/animation-test-helpers.js:
(parseCrossFade):
(checkExpectedValue):
- animations/resources/blue-100.png: Added.
- animations/resources/green-100.png: Added.
- animations/resources/stripes-100.png: Added.
- platform/mac/animations/cross-fade-background-image-expected.png: Added.
- platform/mac/animations/cross-fade-border-image-source-expected.png: Added.
- platform/mac/animations/cross-fade-list-style-image-expected.png: Added.
- platform/mac/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
- platform/mac/animations/cross-fade-webkit-mask-image-expected.png: Added.
- platform/mac/transitions/cross-fade-background-image-expected.png: Added.
- platform/mac/transitions/cross-fade-border-image-expected.png: Added.
- transitions/cross-fade-background-image-expected.txt: Added.
- transitions/cross-fade-background-image.html: Added.
- transitions/cross-fade-border-image-expected.txt: Added.
- transitions/cross-fade-border-image.html: Added.
- transitions/resources/transition-test-helpers.js:
(expected):
- 3:00 PM Changeset in webkit [102387] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Set opaque() for VideoLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=73858
Patch by Dana Jansens <danakj@chromium.org> on 2011-12-08
Reviewed by James Robinson.
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::isVideoFrameFormatOpaque):
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
- 2:38 PM Changeset in webkit [102386] by
-
- 6 edits in branches/chromium/963
Merge 102317 - https://bugs.webkit.org/show_bug.cgi?id=74038
[V8][Chromium] Support legacy argument order in window.postMessage/window.webkitPostMessage.
Reviewed by David Levin.
Source/WebCore:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::isLegacyTargetOriginDesignation):
(WebCore::handlePostMessageCallback):
LayoutTests:
- fast/dom/Window/window-postmessage-args-expected.txt:
- fast/dom/Window/window-postmessage-args.html: New tests for legacy argument order.
- platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
TBR=caseq@chromium.org
ISSUE=http://code.google.com/p/chromium/issues/detail?id=106797
Review URL: http://codereview.chromium.org/8883032
- 2:29 PM Changeset in webkit [102385] by
-
- 5 edits2 adds in trunk/Source/WebCore
Use Skia's implementation of Gaussian blur when accelerated filters
are enabled.
https://bugs.webkit.org/show_bug.cgi?id=73949
Reviewed by Zoltan Herczeg.
In the future, this will be covered by the SVG tests run in GPU mode.
- WebCore.gypi:
Add FEGaussianBlurSkia.cpp to the build.
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplySoftware):
Call out to platformApplySkia() when USE_SKIA is enabled.
- platform/graphics/filters/FEGaussianBlur.h:
platformApplySkia() declaration.
- platform/graphics/filters/skia: Added.
- platform/graphics/filters/skia/FEGaussianBlurSkia.cpp: Added.
(WebCore::FEGaussianBlur::platformApplySkia):
On the Skia port, use SkBlurImageFilter for drawing
Gaussian blurs in accelerated mode.
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::copyImage):
Implement ImageBuffer::copyImage() with DontCopyBackingStore semantics.
- 2:20 PM Changeset in webkit [102384] by
-
- 5 edits in branches/safari-534.53-branch/Source
Versioning.
- 2:15 PM Changeset in webkit [102383] by
-
- 1 copy in tags/Safari-534.53.7
New tag.
- 2:11 PM Changeset in webkit [102382] by
-
- 6 edits in trunk
Tools: AX: platform/mac/accessibility/search-with-frames.html crashes
https://bugs.webkit.org/show_bug.cgi?id=74093
Reviewed by Darin Adler.
Take care of the case when an incoming element is null.
- DumpRenderTree/AccessibilityUIElement.cpp:
(uiElementForSearchPredicateCallback):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::uiElementForSearchPredicate):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
LayoutTests: platform/mac/accessibility/search-with-frames.html crashes
https://bugs.webkit.org/show_bug.cgi?id=74093
Reviewed by Darin Adler.
Unskip the crashing test.
- platform/mac/Skipped:
- 2:08 PM Changeset in webkit [102381] by
-
- 3 edits in trunk/Tools
[Qt] Visualize mock point ID's in the MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=74098
Patch by Alexander Færøy <ahf@0x90.dk> on 2011-12-08
Reviewed by Tor Arne Vestbø.
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
- MiniBrowser/qt/qml/MockTouchPoint.qml:
- 2:02 PM WebKit Team edited by
- (diff)
- 1:47 PM Changeset in webkit [102380] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add 8 bit paths for StringTypeAdapter classes
https://bugs.webkit.org/show_bug.cgi?id=73882
Reviewed by Darin Adler.
Added is8Bit() method and writeTo(LChar*) methods
to StringTypeAdapter<> classes. The writeTo(LChar*)
method can be used if is8Bit() returns true. The
non-native 8 bit classes contain ASSERT(is8Bit())
in their writeTo(LChar*).
Updated all of the various versions of tryMakeString() to
use 8 bit processing in the updated StringTypeAdapter<>
classes.
This has slight if any performance improvement on kraken.
- runtime/UStringConcatenate.h:
- wtf/text/StringConcatenate.h:
(WTF::tryMakeString):
- wtf/text/StringOperators.h:
(WTF::StringAppend::is8Bit):
(WTF::StringAppend::writeTo):
- 1:29 PM Changeset in webkit [102379] by
-
- 3 edits in trunk/Source/WebCore
CodeGeneratorV8: Fix issue with overloaded static conditional methods
https://bugs.webkit.org/show_bug.cgi?id=74114
Reviewed by Adam Barth.
The code generator was missing checks for Conditional for overloaded methods.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateOverloadedFunctionCallback): Generate needed #ifdefs.
(GenerateFunctionCallback): Ditto.
- bindings/scripts/test/V8/V8TestObj.cpp: Wrap conditional methods with #ifdefs.
(WebCore::ConfigureV8TestObjTemplate):
- 1:27 PM Changeset in webkit [102378] by
-
- 24 edits3 copies5 adds in trunk
Source/WebCore: AccessibilityController should support listening to notifications on all elements.
https://bugs.webkit.org/show_bug.cgi?id=72866
Changes accessibilitySetShouldRepostNotifications from an instance method
into a class method so that it can be used for global notification listeners,
not just for listeners on a particular object.
Reviewed by Chris Fleizach.
Test: accessibility/notification-listeners.html
- accessibility/mac/WebAccessibilityObjectWrapper.h:
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(+[WebAccessibilityObjectWrapper accessibilitySetShouldRepostNotifications:]):
(-[WebAccessibilityObjectWrapper accessibilityPostedNotification:]):
Tools: Accessibility: AccessibilityController should support listening to notifications on all elements.
https://bugs.webkit.org/show_bug.cgi?id=72866
Adds addNotificationListener and removeNotificationListener methods
to AccessibilityController, to listen to notifications on any element
rather than a specific element. Mac (DRT and WKTR) and Chromium (DRT)
implementations are all contained in this change.
On Mac, refactors AccessibilityNotificationHandler into its own
source file that can be used by both AccessibilityController and
AccessibilityUIElement. (Both DRT and WKTR.)
Reviewed by Chris Fleizach.
- DumpRenderTree/AccessibilityController.cpp:
(addNotificationListenerCallback):
(removeNotificationListenerCallback):
(AccessibilityController::getJSClass):
- DumpRenderTree/AccessibilityController.h:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/chromium/AccessibilityController.cpp:
(AccessibilityController::AccessibilityController):
(AccessibilityController::notificationReceived):
(AccessibilityController::addNotificationListenerCallback):
(AccessibilityController::removeNotificationListenerCallback):
- DumpRenderTree/chromium/AccessibilityController.h:
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::addNotificationListener):
(AccessibilityController::removeNotificationListener):
- DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::~AccessibilityController):
(AccessibilityController::addNotificationListener):
(AccessibilityController::removeNotificationListener):
- DumpRenderTree/mac/AccessibilityNotificationHandler.h: Added.
- DumpRenderTree/mac/AccessibilityNotificationHandler.mm: Added.
(-[NSString createJSStringRef]):
(-[AccessibilityNotificationHandler init]):
(-[AccessibilityNotificationHandler setPlatformElement:]):
(-[AccessibilityNotificationHandler dealloc]):
(-[AccessibilityNotificationHandler setCallback:]):
(-[AccessibilityNotificationHandler startObserving]):
(-[AccessibilityNotificationHandler _notificationReceived:]):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::addNotificationListener):
- DumpRenderTree/win/AccessibilityControllerWin.cpp:
(notificationListenerProc):
(AccessibilityController::addNotificationListener):
(AccessibilityController::removeNotificationListener):
(AccessibilityController::winNotificationReceived):
(AccessibilityController::winAddNotificationListener):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::addNotificationListener):
- WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR::AccessibilityController::addNotificationListener):
(WTR::AccessibilityController::removeNotificationListener):
- WebKitTestRunner/InjectedBundle/AccessibilityController.h:
(WTR::AccessibilityController::logAccessibilityEvents):
- WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
(WTR::AccessibilityTextMarker::AccessibilityTextMarker):
- WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
(WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: Added.
(WTR::AccessibilityController::addNotificationListener):
(WTR::AccessibilityController::removeNotificationListener):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h: Added.
- WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: Added.
(-[NSString createJSStringRef]):
(-[AccessibilityNotificationHandler init]):
(-[AccessibilityNotificationHandler setPlatformElement:]):
(-[AccessibilityNotificationHandler dealloc]):
(-[AccessibilityNotificationHandler setCallback:]):
(-[AccessibilityNotificationHandler startObserving]):
(-[AccessibilityNotificationHandler _notificationReceived:]):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::verticalScrollbar):
(WTR::AccessibilityUIElement::addNotificationListener):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
LayoutTests: Accessibility: AccessibilityController should support listening to notifications on all elements.
https://bugs.webkit.org/show_bug.cgi?id=72866
Previously, the Mac implementation of AccessibilityUIElement.addNotificationListener
incorrectly triggered on notifications from all elements. Now it only triggers on
notifications from the correct element, and a new addNotificationListener method
in AccessibilityController can be used to trigger on notifications from all elements.
Updates 2 tests that depended on the old incorrect behavior.
Reviewed by Chris Fleizach.
- accessibility/notification-listeners.html: Added.
- platform/chromium/accessibility/notification-listeners-expected.txt: Added.
- platform/gtk/Skipped:
- platform/mac/accessibility/aria-expanded-notifications.html:
- platform/mac/accessibility/aria-listbox-selectedchildren-change.html:
- platform/mac/accessibility/notification-listeners-expected.txt: Added.
- platform/win/Skipped:
- 1:23 PM Changeset in webkit [102377] by
-
- 2 edits in trunk/Source/WebKit2
HiDPI: Switching a video element to full screen in HiDPI mode doesn't fit the screen correctly
https://bugs.webkit.org/show_bug.cgi?id=74119
rdar://problem/10356869
Reviewed by Darin Adler.
Use the Lion-only -[NSWindow convertRectToScreen:] function to convert between window
coordinates and screen coordinates.
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController enterFullScreen:]):
- 1:21 PM Changeset in webkit [102376] by
-
- 2 edits in branches/safari-534.53-branch/Source/WebCore
Merged r96777.
- 1:15 PM Changeset in webkit [102375] by
-
- 9 edits in trunk/Source/WebCore
Web Inspector: Rename createScriptCallStack() without parameters to createScriptCallStackForInspector().
https://bugs.webkit.org/show_bug.cgi?id=74120
Reviewed by Pavel Feldman.
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackForInspector):
- bindings/js/ScriptCallStackFactory.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
- bindings/v8/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackForInspector):
- bindings/v8/ScriptCallStackFactory.h:
- 1:11 PM Changeset in webkit [102374] by
-
- 2 edits in branches/safari-534.53-branch/Source/WebKit2
Merged r101719.
- 1:07 PM Changeset in webkit [102373] by
-
- 4 edits in trunk/Source/WebCore
[chromium] Remove dead code in compositor
https://bugs.webkit.org/show_bug.cgi?id=74103
Reviewed by James Robinson.
Tested via the compiler.
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
- platform/graphics/chromium/LayerRendererChromium.h:
- 1:06 PM Changeset in webkit [102372] by
-
- 4 edits in branches/safari-534.53-branch
Merged r101532.
- 1:05 PM Changeset in webkit [102371] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Need to adjust memory limit and viewport multipliers.
https://bugs.webkit.org/show_bug.cgi?id=74022
Patch by Eric Penner <epenner@google.com> on 2011-12-08
Reviewed by James Robinson.
- platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::highLimitBytes): Changing constants
(WebCore::TextureManager::reclaimLimitBytes): ditto
- 1:03 PM Changeset in webkit [102370] by
-
- 19 edits in branches/safari-534.53-branch/Source
Merged r101290.
- 12:59 PM Changeset in webkit [102369] by
-
- 2 edits in trunk/Source/WebKit/chromium
Chromium DEPS roll 112974 -> 113603
https://bugs.webkit.org/show_bug.cgi?id=74105
Patch by Elliot Poger <epoger@google.com> on 2011-12-08
Reviewed by Adam Barth.
- DEPS:
- 12:53 PM Changeset in webkit [102368] by
-
- 2 edits1 add in trunk/Source/WebCore
Add a platform EventLoop for iOS
https://bugs.webkit.org/show_bug.cgi?id=74043
Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-08
Reviewed by David Kilzer.
- WebCore.xcodeproj/project.pbxproj:
- platform/ios/EventLoopIOS.mm: Added.
(WebCore::EventLoop::cycle):
- 12:47 PM Changeset in webkit [102367] by
-
- 9 edits in branches/safari-534.53-branch/Source
Merged r100483.
- 12:41 PM Changeset in webkit [102366] by
-
- 9 edits in trunk/Source/WebCore
Web Inspector: return node counts on the document / detached root basis
https://bugs.webkit.org/show_bug.cgi?id=74104
Reviewed by Yury Semikhatsky.
- bindings/js/ScriptProfiler.h:
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::domNodeCount):
- bindings/v8/ScriptProfiler.h:
- inspector/Inspector.json:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getDOMNodeCount):
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
- inspector/InspectorMemoryAgent.h:
(WebCore::InspectorMemoryAgent::create):
- 12:34 PM Changeset in webkit [102365] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] remove headers from WebKit.gyp that moved into WebKit/chromium/public/platform
https://bugs.webkit.org/show_bug.cgi?id=74106
Reviewed by Darin Fisher.
- WebKit.gyp:
- 12:29 PM Changeset in webkit [102364] by
-
- 4 edits in trunk/Source/WebCore
RenderObject: Rename styleSlowCase() to styleInRegion().
Rubber-stamped by David Hyatt.
- WebCore.exp.in:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleInRegion):
- rendering/RenderObject.h:
(WebCore::RenderObject::style):
- 12:21 PM Changeset in webkit [102363] by
-
- 4 edits in trunk
[Qt][WK2] Unreviewed buildfix after r102352.
Source/WebKit2:
- DerivedSources.pri:
Tools:
- qmake/mkspecs/features/webkit2.prf:
- 12:16 PM Changeset in webkit [102362] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Exclude the four RenderTableCellDeathTest death tests for Android
https://bugs.webkit.org/show_bug.cgi?id=73997
The ASSERT_DEATH macro is not yet available in Google Test when
building for Android, which causes compilation errors. This code
will be removed once support lands in the GTest version Chromium
uses. See https://bugs.webkit.org/show_bug.cgi?id=74089.
Reviewed by Julien Chaffraix.
- tests/RenderTableCellTest.cpp:
- 12:11 PM Changeset in webkit [102361] by
-
- 3 edits in trunk/Source/WebKit/chromium
IndexedDB: WebKit API addition of IDBObjectStore.count() and IDBIndex.count()
https://bugs.webkit.org/show_bug.cgi?id=73685
Patch by Joshua Bell <jsbell@chromium.org> on 2011-12-08
Reviewed by Darin Fisher.
Implementation to follow - this just extends the WebKit API.
- public/WebIDBIndex.h:
(WebKit::WebIDBIndex::count):
- public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::count):
- 12:01 PM Changeset in webkit [102360] by
-
- 2 edits in trunk/Source/WebCore
Optimize RenderObject::containingBlock().
<http://webkit.org/b/74109>
Reviewed by David Hyatt.
When climbing the parent chain to locate the containing block-level element,
use !isRenderBlock() to reject renderers rather than checking against an arbitrary
list of non-block renderers and then rejecting anything that isn't a block anyway.
RenderObject::containingBlock() was very hot (2.0%) when scrolling on youtube.com.
This change takes it down to 1.0% (60% of which is RenderObject::isRenderBlock().)
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
- 11:39 AM Changeset in webkit [102359] by
-
- 2 edits in trunk/Source/WebCore
Define DEBUG_GL_COMMANDS only in debug builds.
https://bugs.webkit.org/show_bug.cgi?id=74083
Reviewed by Noam Rosenthal.
No tests added as this change does not affect functionality.
- platform/graphics/opengl/TextureMapperGL.cpp:
- 11:35 AM Changeset in webkit [102358] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Removed suppressions for inspector extensions tests following a fix in r10231.
- platform/chromium/test_expectations.txt:
- 11:32 AM Changeset in webkit [102357] by
-
- 8 edits in trunk/Source/WebCore
CompositeEditCommand should not be kept alive for undo and redo
https://bugs.webkit.org/show_bug.cgi?id=64414
Reviewed by Enrica Casucci.
This patch introduces EditCommandComposition that replaces CompositeEditCommand for
undo and redo purposes. Furthermore, we now keep a list of commands instead of a tree of commands
to unapply and reapply edit commands that composes an undoable action.
Each top-level CompositeEditCommand holds a ref-pointer to EditCommandComposition,
and applyCommandToComposite adds new SimpleEditCommands to the list.
- editing/CompositeEditCommand.cpp:
(WebCore::EditCommandComposition::create):
(WebCore::EditCommandComposition::doApply): Never used.
(WebCore::EditCommandComposition::doUnapply):
(WebCore::EditCommandComposition::doReapply):
(WebCore::EditCommandComposition::append):
(WebCore::CompositeEditCommand::~CompositeEditCommand): Add an assertion to ensure we didn't create
a composition for CompositeEditCommands that have parents.
(WebCore::CompositeEditCommand::doUnapply): Never used.
(WebCore::CompositeEditCommand::doReapply): Never used.
(WebCore::CompositeEditCommand::ensureComposition): Creates and attaches a EditCommandComposition.
(WebCore::CompositeEditCommand::applyCommandToComposite): Append a SimpleEditCommand to the composition.
- editing/CompositeEditCommand.h:
(WebCore::EditCommandComposition::EditCommandComposition):
(WebCore::CompositeEditCommand::composition):
(WebCore::toEditCommandComposition):
(WebCore::toCompositeEditCommand):
- editing/DeleteButtonController.cpp: Wrap RemoveNodeCommand in RemoveTargetCommand since top level
commands are now required to be a CompositeEditCommand.
(WebCore::RemoveTargetCommand::create):
(WebCore::RemoveTargetCommand::RemoveTargetCommand):
(WebCore::RemoveTargetCommand::doApply):
(WebCore::DeleteButtonController::deleteTarget):
- editing/EditCommand.cpp:
(WebCore::EditCommand::EditCommand): New constructor; used by EditCommandComposition.
(WebCore::EditCommand::apply): Create a composition for a top-level command.
(WebCore::EditCommand::unapply): Since we clear m_parent of SimpleEditCommand as soon as they are
added to EditCommandComposition, we can't use isTopLevelCommand() to differentiate EditCommandComposition
from SimpleEditCommand. Use isEditCommandComposition() instead.
(WebCore::EditCommand::reapply): Ditto.
(WebCore::compositionIfPossible):
(WebCore::EditCommand::setStartingSelection): Update the starting selection of EditCommandComposition.
(WebCore::EditCommand::setEndingSelection): Ditto.
(WebCore::EditCommand::setParent): Accepts a null pointer in order to avoid keeping a stale pointer in
m_parent inside SimpleEditCommand when CompositeEditCommand goes away.
- editing/EditCommand.h:
(WebCore::EditCommand::isSimpleEditCommand):
(WebCore::EditCommand::isCompositeEditCommand):
(WebCore::EditCommand::isEditCommandComposition):
(WebCore::EditCommand::parent):
(WebCore::toSimpleEditCommand):
- editing/Editor.cpp:
(WebCore::Editor::appliedEditing): Register a EditCommandComposition, instead of a CompositeEditCommand
to the undo stack.
(WebCore::Editor::unappliedEditing): Unapplied or reapplied commands are now always EditCommandComposition.
(WebCore::Editor::reappliedEditing):
- editing/Editor.h:
- 11:25 AM Changeset in webkit [102356] by
-
- 1 edit1 add in trunk/Source/WebCore
Add missing V8 bindings to get CSS_FILTERS to compile in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=74091
Reviewed by Kenneth Russell.
Will be covered by tests in css3/filters (when enabled).
- bindings/v8/custom/V8WebKitCSSFilterValueCustom.cpp: Added.
(WebCore::V8WebKitCSSFilterValue::indexedPropertyGetter):
- 11:19 AM Changeset in webkit [102355] by
-
- 3 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=73348
REGRESSION: Assertion when loading a page with a scrollable RenderLayer
-and corresponding-
<rdar://problem/10518918>
Reviewed by Darin Adler.
The main problem here is that certain delegate calls into AppKit for overlay
scrollbars can cause AppKit to call back into WebKit looking for more information.
The assertion happens when WebKit tells AppKit that the scroll position has
changed during a layout, and AppKit immediately asks WebKit to convert some
coordinates, and WebKit asserts that you shouldn't do that while a layout is still
happening. It's still possible for AppKit to call this delegate method while a
layout is happening, and we should guard against that. This patch, however, does
not do that.
This change instead addresses the reason this assertion started happening much
more frequently recently, which is that it recently became true that
notifyPositionChanged() can be called when the position has not changed. To fix
the assertion AND the bug that that change was intended to fix, we can just make
sure that either the position OR the scroll origin has changed before calling
notifyPositionChanged().
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
Call resetScrollOriginChanged() after the scroll instead of before so that we know
whether or not to call notifyPositionChanged().
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
- 11:16 AM Changeset in webkit [102354] by
-
- 6 edits in trunk/Tools
Make finding crash logs by PID work on Snow Leopard
Crash Reporter on Snow Leopard doesn't set the "app_description" extended attribute that we
were using to check the PID of the crashed process. (Crash Reporter on Lion does.) Now we
read the first line of the crash log and pull the PID out of there.
Fixes <http://webkit.org/b/74094> "webkit-patch crash-log <process> <PID>" doesn't work on
Snow Leopard
Reviewed by Darin Adler.
- Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs._find_newest_log_darwin): Read the first line of the crash log to get the process
name and PID for the log, rather than checking the Lion-only app_description extended
attribute. We now also reject the log if the process name doesn't match what we expect.
- Scripts/webkitpy/common/system/crashlogs_unittest.py:
(make_mock_crash_report_darwin): Added. Returns a mock crash report given a process name and
PID.
(CrashLogsTest.assertLinesEqual): Added. This is a compatibility shim around
unittest.TestCase.assertMultiLineEqual, which didn't exist before Python 2.7.
(CrashLogsTest.test_find_log_darwin): Made the mock crash reports more believable by using
the new make_mock_crash_report_darwin function. Also added tests for files that can't be
read, files that actually contain a crash log for some other process, and files that are
misformatted.
- Scripts/webkitpy/common/system/filesystem.py: Removed FileSystem.getxattr, which is now
unused.
- Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.init): Removed xattr support, which is now unused.
(MockFileSystem.open_text_file_for_reading): Changed to actually pass the file's data to
ReadableTextFileObject. This function was completely broken before!
(ReadableBinaryFileObject.init): Made the data parameter non-optional to try to prevent
bugs like the above.
(ReadableTextFileObject.init): Added. Wraps the data in a StringIO object so we can do
things like readline() and seek().
(ReadableTextFileObject.close):
(ReadableTextFileObject.read):
Added. We override the superclass implementation to account for using a StringIO object.
(ReadableTextFileObject.readline):
(ReadableTextFileObject.seek):
Added. These just call through to StringIO.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_crash_log):
(MainTest.test_web_process_crash_log):
Changed to use make_mock_crash_report_darwin.
- 11:12 AM Changeset in webkit [102353] by
-
- 1 edit4 adds16 deletes in trunk/LayoutTests
Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=73866
Patch by Jacob Goldstein <jacobg@adobe.com> on 2011-12-08
Reviewed by Darin Adler.
- fast/regions/positioned-objects-block-static-in-regions-expected.html: Added.
- fast/regions/positioned-objects-block-static-in-rtl-regions-expected.html: Added.
- fast/regions/positioned-objects-block-static-spanning-regions-expected.html: Added.
- fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.html: Added.
- platform/efl/fast/regions/positioned-objects-block-static-in-regions-expected.png: Removed.
- platform/efl/fast/regions/positioned-objects-block-static-in-regions-expected.txt: Removed.
- platform/efl/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.png: Removed.
- platform/efl/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.txt: Removed.
- platform/efl/fast/regions/positioned-objects-block-static-spanning-regions-expected.png: Removed.
- platform/efl/fast/regions/positioned-objects-block-static-spanning-regions-expected.txt: Removed.
- platform/efl/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.png: Removed.
- platform/efl/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.txt: Removed.
- platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.png: Removed.
- platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.txt: Removed.
- platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.png: Removed.
- platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.txt: Removed.
- platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-expected.png: Removed.
- platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-expected.txt: Removed.
- platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.png: Removed.
- platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.txt: Removed.
- 11:06 AM Changeset in webkit [102352] by
-
- 26 edits7 copies7 moves2 adds in trunk
[WK2] Add permissions support (73960)
https://bugs.webkit.org/show_bug.cgi?id=73960
<rdar://problem/10357008>
Reviewed by Darin Adler.
Source/WebKit2:
- DerivedSources.make: Moved notification files to its own directory. Need to add that path.
- WebKit2.xcodeproj/project.pbxproj: New header and impl files.
- Target.pri: Ditto.
- GNUmakefile.am: Ditto.
- win/WebKit2.vcproj: Ditto.
- win/WebKit2Common.vsprops: Add path to Notifications directory.
Implement permission functions, which go through permission request manager.
- WebProcess/WebCoreSupport/WebNotificationClient.cpp:
(WebKit::WebNotificationClient::requestPermission):
(WebKit::WebNotificationClient::cancelRequestsForPermission):
(WebKit::WebNotificationClient::checkPermission):
New NotificationPermissionRequestManager to make and cancel permission requests, and to retrieve current
policy.
- WebProcess/Notifications/NotificationPermissionRequestManager.cpp: Added.
(WebKit::generateRequestID):
(WebKit::NotificationPermissionRequestManager::create):
(WebKit::NotificationPermissionRequestManager::NotificationPermissionRequestManager):
(WebKit::NotificationPermissionRequestManager::startRequest): Keep track of the provided callback once
policy decision is made.
(WebKit::NotificationPermissionRequestManager::cancelRequest):
(WebKit::NotificationPermissionRequestManager::permissionLevel): Retrieve level through a synchronous
message to the proxy.
(WebKit::NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision): Invoke the callback.
- WebProcess/Notifications/NotificationPermissionRequestManager.h: Added.
(WebKit::isRequestIDValid): Make sure any provided request IDs are valid.
Added new NotificationPermissionRequest class.
- UIProcess/Notifications/NotificationPermissionRequest.cpp: Added.
(WebKit::NotificationPermissionRequest::create):
(WebKit::NotificationPermissionRequest::NotificationPermissionRequest):
(WebKit::NotificationPermissionRequest::allow): Notify manager of decision.
(WebKit::NotificationPermissionRequest::deny): Ditto.
(WebKit::NotificationPermissionRequest::invalidate): Disassociate with manager.
(WebKit::NotificationPermissionRequest::type):
- UIProcess/Notifications/NotificationPermissionRequest.h: Added.
WKAPI support for NotificationPermissionRequest:
- Shared/API/c/WKBase.h:
- Shared/APIObject.h:
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKNotificationPermissionRequest.cpp: Added.
(WKNotificationPermissionRequestGetTypeID):
(WKNotificationPermissionRequestAllow):
(WKNotificationPermissionRequestDeny):
- UIProcess/API/C/WKNotificationPermissionRequest.h: Added.
Other additions to WK API:
- UIProcess/API/C/WKNotificationProvider.h: Added new callback for WKNotificationProviders, to return policy
for a given security origin.
- UIProcess/API/C/WKPage.h: Added new callback to WKPageUIClient to ask user to decide on policy.
New NotificationPermissionRequestManagerProxy to create requests.
- UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp: Added.
(WebKit::NotificationPermissionRequestManagerProxy::NotificationPermissionRequestManagerProxy):
(WebKit::NotificationPermissionRequestManagerProxy::invalidateRequests):
(WebKit::NotificationPermissionRequestManagerProxy::createRequest):
(WebKit::NotificationPermissionRequestManagerProxy::didReceiveNotificationPermissionDecision):
- UIProcess/Notifications/NotificationPermissionRequestManagerProxy.h: Added.
Added new message to notification manager: NotificationPermissionLevel, to retrieve policy. The current
JS API retrieves the permission synchronously, so the message needs to be sent synchronously also.
- UIProcess/Notifications/WebNotificationManagerProxy.messages.in: Moved from Source/WebKit2/UIProcess/WebNotificationManagerProxy.messages.in.
- UIProcess/Notifications/WebNotificationProvider.cpp: Moved from Source/WebKit2/UIProcess/WebNotificationProvider.cpp.
(WebKit::WebNotificationProvider::policyForNotificationPermissionAtOrigin): Added.
- UIProcess/Notifications/WebNotificationProvider.h: Moved from Source/WebKit2/UIProcess/WebNotificationProvider.h.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveSyncMessage): Boilerplate to forward messages to notification manager.
- UIProcess/Notifications/WebNotificationManagerProxy.cpp: Moved from Source/WebKit2/UIProcess/WebNotificationManagerProxy.cpp.
(WebKit::WebNotificationManagerProxy::create):
(WebKit::WebNotificationManagerProxy::WebNotificationManagerProxy):
(WebKit::WebNotificationManagerProxy::invalidate):
(WebKit::WebNotificationManagerProxy::initializeProvider):
(WebKit::WebNotificationManagerProxy::didReceiveMessage):
(WebKit::WebNotificationManagerProxy::didReceiveSyncMessage):
(WebKit::WebNotificationManagerProxy::show):
(WebKit::WebNotificationManagerProxy::cancel):
(WebKit::WebNotificationManagerProxy::didDestroyNotification):
(WebKit::WebNotificationManagerProxy::notificationPermissionLevel): Retrieve the policy from the provider.
(WebKit::WebNotificationManagerProxy::providerDidShowNotification):
(WebKit::WebNotificationManagerProxy::providerDidClickNotification):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):
- UIProcess/Notifications/WebNotificationManagerProxy.h: Moved from Source/WebKit2/UIProcess/WebNotificationManagerProxy.h.
(WebKit::WebNotificationManagerProxy::clearContext):
(WebKit::WebNotificationManagerProxy::type):
Added NotificationPermissionRequestManagerProxy to WebPageProxy, to allow a request for permission to
go through to the UI client. Added new message to WebPageProxy, RequestNotificationPermission.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close): Invalidate pending requests.
(WebKit::WebPageProxy::processDidCrash): Ditto.
(WebKit::WebPageProxy::requestNotificationPermission): Forward request to UI client.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::decidePolicyForNotificationPermissionRequest):
- UIProcess/WebUIClient.h:
Added new message DidReceiveNotificationPermissionDecision. The WebPage forwards the message to the
permission request manager.
- WebProcess/WebPage/WebPage.messages.in: Added new message DidReceiveNotificationPermissionDecision
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::notificationPermissionRequestManager): Create manager on request.
(WebKit::WebPage::didReceiveNotificationPermissionDecision):
- WebProcess/WebPage/WebPage.h:
Moving files to Notifications/ subdirectory.
- UIProcess/Notifications/WebNotification.cpp: Moved from Source/WebKit2/UIProcess/WebNotification.cpp.
- UIProcess/Notifications/WebNotification.h: Moved from Source/WebKit2/UIProcess/WebNotification.h.
Tools:
Add null function item to comply with added callback to WKPageUIClient.
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
- 10:55 AM Changeset in webkit [102351] by
-
- 12 edits in trunk/Source/WebCore
Fixing support for static conditional overloaded functions.
https://bugs.webkit.org/show_bug.cgi?id=74068
Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-12-08
Reviewed by Adam Barth.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation): Pushing "static" keyword after condition "#if".
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::overloadedMethod1): Added newly generated bindings.
- bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
(webkit_dom_test_obj_overloaded_method1):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
- bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod1):
- bindings/scripts/test/JS/JSTestObj.h: Ditto.
- bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
- bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
(-[DOMTestObj overloadedMethod1:]):
- bindings/scripts/test/TestObj.idl: Ditto.
- bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
(WebCore::TestObjInternal::overloadedMethod11Callback):
(WebCore::TestObjInternal::overloadedMethod12Callback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::ConfigureV8TestObjTemplate):
- 10:53 AM Changeset in webkit [102350] by
-
- 1 edit2 adds in trunk/LayoutTests
Added a test for css number types problem.
It's testing the css number types parser, where 'px' defined like escape sequences (\70\78) or uppercase / lowercase.
https://bugs.webkit.org/show_bug.cgi?id=72007
Patch by Szilard Ledan <Ledan-Muntean.Szilard@stud.u-szeged.hu> on 2011-12-08
Reviewed by Darin Adler.
- fast/css/parsing-css-number-types-expected.txt: Added.
- fast/css/parsing-css-number-types.html: Added.
- 10:50 AM Changeset in webkit [102349] by
-
- 3 edits in trunk/Source/WebCore
Remove EventListenerMap destructor.
<http://webkit.org/b/74096>
Reviewed by Darin Adler.
Let the compiler generate ~EventListenerMap(). We only needed it when the hash map
was managing raw pointers.
We're losing the no-iterators assertion from clear() by doing this, but that was
superfluous to begin with - we were just using it to avoid duplicating code.
- dom/EventListenerMap.cpp:
- dom/EventListenerMap.h:
- 10:38 AM Changeset in webkit [102348] by
-
- 6 edits1 copy1 add in trunk/Tools
[Qt] Visualize mock points in the Qt MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=74074
Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-12-08
Reviewed by Tor Arne Vestbø.
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
- MiniBrowser/qt/BrowserWindow.h:
- MiniBrowser/qt/MiniBrowser.qrc:
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify):
(MiniBrowserApplication::sendTouchEvent):
- MiniBrowser/qt/MiniBrowserApplication.h:
- MiniBrowser/qt/icons/touchpoint.png: Added.
- MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
- 10:23 AM Changeset in webkit [102347] by
-
- 1 edit2 moves1 add2 deletes in trunk/LayoutTests
[chromium] Rebaseline printing/width-overflow.html on Chromium Mac Leopard.
- platform/chromium-cg-mac-snowleopard/printing/width-overflow-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/printing/width-overflow-expected.png.
- platform/chromium-linux/printing/width-overflow-expected.txt: Removed.
- platform/chromium-mac-leopard/printing/width-overflow-expected.png: Added.
- platform/chromium-mac-snowleopard/printing/width-overflow-expected.txt: Removed.
- platform/chromium/printing/width-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/printing/width-overflow-expected.txt.
- 9:57 AM Changeset in webkit [102346] by
-
- 7 edits1 add in trunk/Source/WebKit2
[WebKit2] Initialize threading in UI process.
https://bugs.webkit.org/show_bug.cgi?id=70127
Reviewed by Anders Carlsson.
- CMakeLists.txt:
- GNUmakefile.am:
- Shared/APIObject.cpp: Added.
(WebKit::APIObject::APIObject):
- Shared/APIObject.h:
- Target.pri:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- 9:25 AM Changeset in webkit [102345] by
-
- 3 edits in branches/safari-534.53-branch/Source/WebKit2
Merged r99912.
- 9:23 AM Changeset in webkit [102344] by
-
- 14 edits in branches/safari-534.53-branch/Source/WebKit2
Merged r99911.
- 8:36 AM Changeset in webkit [102343] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skipping failing test platform/mac/accessibility/search-with-frames.html
- 8:16 AM Changeset in webkit [102342] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] [WK2] Directly composited images doesn't render
https://bugs.webkit.org/show_bug.cgi?id=74058
Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-12-08
Reviewed by Noam Rosenthal.
Attach image to WebGraphicsLayer even if layerTreeTileClient is not set
and create/assign remote image tiles later during sync.
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
- 8:06 AM Changeset in webkit [102341] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r102334): Various Qt WK2 layout tests crash
Reviewed by Tor Arne Vestbø.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState): Add missing null pointer check for the editable
element (scope) before calling innerText.
- 7:46 AM Changeset in webkit [102340] by
-
- 5 edits in trunk
[Qt] WebKitTestRunner crashes with debug builds https://bugs.webkit.org/show_bug.cgi?id=74090
Reviewed by Tor Arne Vestbø.
Source/WebKit2:
Export private C++ API style platformInitialize function needed
by low-level WTR.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::platformInitialize):
- UIProcess/API/qt/qquickwebview_p.h:
Tools:
- WebKitTestRunner/qt/TestControllerQt.cpp:
(WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
to ensure WTF/JSC threading is initialized.
- 7:45 AM Changeset in webkit [102339] by
-
- 3 edits in trunk/Source/WebCore
Provide more specific error description for SocketStreamError.
https://bugs.webkit.org/show_bug.cgi?id=74066
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-12-08
Reviewed by Martin Robinson.
No new tests because this change just improve error messages for unexpected failures.
- platform/network/soup/SocketStreamError.h: Add an argument for passing error description.
(WebCore::SocketStreamError::SocketStreamError):
- platform/network/soup/SocketStreamHandleSoup.cpp: Add error description for SocketStreamError.
(WebCore::SocketStreamHandle::connected):
(WebCore::SocketStreamHandle::readBytes):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
- 7:32 AM Changeset in webkit [102338] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Fix non-animated pinch-zoom scale commit.
https://bugs.webkit.org/show_bug.cgi?id=74007
Reviewed by Kenneth Rohde Christiansen.
The update deferrer object was only destroyed at the end of the animation
and wouldn't be if the pinch-zoom was ended within legal bounds.
This patch also makes sure that the deferrer isn't destroyed and re-created
once the animation is started if it was already there.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
- UIProcess/qt/QtViewportInteractionEngine.h:
- 7:30 AM Changeset in webkit [102337] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r101683): QQuickWebView doesn't work with OpenGL/ES 2.0
https://bugs.webkit.org/show_bug.cgi?id=74077
Reviewed by Kenneth Rohde Christiansen.
Replace Desktop OpenGL idiom of using gl_Vertex with a simple vertex attribute
that's tied to the same register 0 (by being the first in the array).
- UIProcess/API/qt/qquickwebpage.cpp:
(PageProxyMaterialShader::attributeNames): Define "vertex" attribute, which is
bound to register 0, which is the current vertex.
(PageProxyMaterialShader::vertexShader): Use the vertex attribute instead of the
built-in gl_Vertex, which is only present in Desktop GL.
- 7:29 AM Changeset in webkit [102336] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Fix the memory leak of AC layer update message contents on the UI process.
https://bugs.webkit.org/show_bug.cgi?id=74012
Reviewed by Noam Rosenthal.
Since the messages didn't have a virtual destructor, the destructor
of child class members wouldn't be called and would cause the all tile
update buffers, contained in a QImage, to be leaked as well.
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeMessageToRenderer::~LayerTreeMessageToRenderer):
- 6:50 AM Changeset in webkit [102335] by
-
- 2 edits in trunk/Tools
fix build-webkit --chromium after breakage in r102201
https://bugs.webkit.org/show_bug.cgi?id=74031
Reviewed by Tony Chang.
- Scripts/webkitdirs.pm:
(buildChromium):
- 6:27 AM Changeset in webkit [102334] by
-
- 8 edits1 add in trunk/Source/WebKit2
Upsteam the Qt changes to the EditorState https://bugs.webkit.org/show_bug.cgi?id=74080
Reviewed by Simon Hausmann.
We are not doing the serialization manually due to it not being a POD
structure anymore in the case of Qt.
- GNUmakefile.am:
- Shared/EditorState.h:
(WebKit::EditorState::EditorState):
- Target.pri:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):
- win/WebKit2.vcproj:
- 6:23 AM Changeset in webkit [102333] by
-
- 28 edits15 adds in trunk
[CSSRegions][CSSOM] Implement NamedFlow interface
https://bugs.webkit.org/show_bug.cgi?id=66642
Reviewed by David Hyatt.
Add WebKitNamedFlow to support the NamedFlow interface. No methods are
yet implemented on this interface. The NamedFlow object is a live object.
The first time user asks for it, it gets a valid JS object whose properties
will reflect the changes to the flow thread.
Source/WebCore:
Tests: fast/regions/webkit-named-flow-existing-flow.html
fast/regions/webkit-named-flow-flow-added.html
fast/regions/webkit-named-flow-modified-flow.html
fast/regions/webkit-named-flow-non-existing-flow.html
fast/regions/webkit-named-flow-removed-flow.html
fast/regions/webkit-named-flow-same-object.html
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/gobject/GNUmakefile.am:
- dom/DOMAllInOne.cpp:
- dom/Document.cpp:
(WebCore::Document::webkitGetFlowByName):
- dom/Document.h:
- dom/Document.idl:
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
- dom/WebKitNamedFlow.cpp: Added.
(WebCore::WebKitNamedFlow::WebKitNamedFlow):
(WebCore::WebKitNamedFlow::~WebKitNamedFlow):
- dom/WebKitNamedFlow.h: Added.
(WebCore::WebKitNamedFlow::create):
- dom/WebKitNamedFlow.idl: Added.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::ensureNamedFlow):
- rendering/RenderFlowThread.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
- rendering/RenderView.cpp:
(WebCore::RenderView::ensureRenderFlowThreadWithName):
- rendering/RenderView.h:
LayoutTests:
- fast/dom/Window/window-properties-expected.txt:
- fast/regions/webkit-named-flow-existing-flow-expected.txt: Added.
- fast/regions/webkit-named-flow-existing-flow.html: Added.
- fast/regions/webkit-named-flow-flow-added-expected.txt: Added.
- fast/regions/webkit-named-flow-flow-added.html: Added.
- fast/regions/webkit-named-flow-modified-flow-expected.txt: Added.
- fast/regions/webkit-named-flow-modified-flow.html: Added.
- fast/regions/webkit-named-flow-non-existing-flow-expected.txt: Added.
- fast/regions/webkit-named-flow-non-existing-flow.html: Added.
- fast/regions/webkit-named-flow-removed-flow-expected.txt: Added.
- fast/regions/webkit-named-flow-removed-flow.html: Added.
- fast/regions/webkit-named-flow-same-object-expected.txt: Added.
- fast/regions/webkit-named-flow-same-object.html: Added.
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/mac/fast/dom/Window/window-properties-expected.txt:
- platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/win/fast/dom/Window/window-properties-expected.txt:
- 5:04 AM Changeset in webkit [102332] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r102280.
http://trac.webkit.org/changeset/102280
https://bugs.webkit.org/show_bug.cgi?id=74031
Chromium/Windows build is broken
- Scripts/webkitdirs.pm:
(buildChromium):
- 3:52 AM Changeset in webkit [102331] by
-
- 1 edit1 delete in trunk/Source/WebKit2
2011-12-08 Gopal Raghavan <gopal.1.raghavan@nokia.com>
[Qt] cleanup qmlplugin
https://bugs.webkit.org/show_bug.cgi?id=73834
Reviewed by Tor Arne Vestbø.
Removed empty folder qmlplugin.
- 3:24 AM Changeset in webkit [102330] by
-
- 6 edits1 delete in trunk/Source/WebCore
Unreviewed, rolling out r102321.
http://trac.webkit.org/changeset/102321
https://bugs.webkit.org/show_bug.cgi?id=74072
"Breaks all Chromium clobbered builds" (Requested by apavlov_
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-08
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/scripts/action_derivedsourcesallinone.py:
(main):
- WebCore.gypi:
- bindings/scripts/generate-bindings.pl:
- page/DOMWindow.idl:
- webaudio/DOMWindowWebAudio.idl: Removed.
- 3:09 AM Changeset in webkit [102329] by
-
- 2 edits in trunk/Tools
Adding myself to committers list.
Unreviewed.
- Scripts/webkitpy/common/config/committers.py:
- 2:46 AM Changeset in webkit [102328] by
-
- 4 edits in trunk/Source/WebCore
Refactoring: Editor::requestCheckingFor should take SpellCheckRequest object.
https://bugs.webkit.org/show_bug.cgi?id=74033
Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-08
Reviewed by Hajime Morita.
SpellChecker::requestCheckingFor takes SpellCheckRequest object in order to make it easy to
pass necessary information to requestCheckingFor.
No new tests. Covered by existing tests.
- editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment):
Uses the new interface.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): ditto.
- editing/SpellChecker.cpp:
(WebCore::SpellCheckRequest::SpellCheckRequest):
(WebCore::SpellCheckRequest::~SpellCheckRequest):
(WebCore::SpellCheckRequest::create):
Creates a new SpellCheckRequest object.
(WebCore::SpellChecker::requestCheckingFor):
Uses the new interface.
(WebCore::SpellChecker::didCheck):
- editing/SpellChecker.h:
(WebCore::SpellCheckRequest::setSequence):
(WebCore::SpellCheckRequest::sequence):
(WebCore::SpellCheckRequest::checkingRange):
(WebCore::SpellCheckRequest::paragraphRange):
(WebCore::SpellCheckRequest::text):
(WebCore::SpellCheckRequest::mask):
(WebCore::SpellCheckRequest::rootEditableElement):
- 2:44 AM Changeset in webkit [102327] by
-
- 3 edits in trunk/LayoutTests
Fix failed layout test, bufferedAmount-after-close-in-busy.html
https://bugs.webkit.org/show_bug.cgi?id=73666
Originally the failed layout test use simple_wsh server side WebSocket
handler. But this handler starts closing handshake after a while and
it bring flakiness on the test.
Now the test use echo_wsh instead of simple_wsh. It never perform
server initiated closing handshake.
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-12-08
Reviewed by Kent Tamura.
- http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html:
- platform/gtk/Skipped:
- 2:37 AM Changeset in webkit [102326] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Remove duplicated entries from skipped list.
- platform/qt-5.0/Skipped:
- 2:26 AM Changeset in webkit [102325] by
-
- 2 edits in trunk/LayoutTests
[WK2] Unreviewed gardening.
WebKitTestRunner needs layoutTestController.setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=42689
- platform/wk2/Skipped: Skip new failing tests.
- 2:12 AM Changeset in webkit [102324] by
-
- 35 edits in trunk
Unreviewed, rolling out r102323.
http://trac.webkit.org/changeset/102323
https://bugs.webkit.org/show_bug.cgi?id=74069
Caused Chromium and GTK build failure (Requested by bashi on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-08
.:
- Source/autotools/symbols.filter:
Source/WebCore:
- testing/Internals.cpp:
(WebCore::Internals::getPageScaleFactor):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
- compositing/geometry/fixed-position-composited-page-scale-down.html:
- compositing/geometry/fixed-position-composited-page-scale.html:
- compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
- compositing/geometry/fixed-position-iframe-composited-page-scale.html:
- compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
- compositing/geometry/fixed-position-transform-composited-page-scale.html:
- compositing/scaling/tiled-layer-recursion.html:
- fast/dom/Element/scale-page-bounding-client-rect.html:
- fast/dom/Element/scale-page-client-rects.html:
- fast/dom/Range/scale-page-bounding-client-rect.html:
- fast/dom/Range/scale-page-client-rects.html:
- fast/events/scale-and-scroll-body.html:
- fast/events/scale-and-scroll-iframe-body.html:
- fast/events/scale-and-scroll-iframe-window.html:
- fast/events/scale-and-scroll-window.html:
- fast/events/script-tests/page-scaled-mouse-click-iframe.js:
(iframeLoaded):
- fast/events/script-tests/page-scaled-mouse-click.js:
- fast/events/scroll-in-scaled-page-with-overflow-hidden.html:
- fast/events/touch/page-scaled-touch-gesture-click.html:
- fast/frames/frame-set-rotation-hit.html:
- fast/frames/frame-set-scaling-hit.html:
- fast/frames/iframe-double-scale-contents.html:
- fast/repaint/background-scaling.html:
- fast/repaint/scale-page-shrink.html:
- fast/transforms/selection-bounds-in-transformed-view.html:
- 1:18 AM Changeset in webkit [102323] by
-
- 35 edits in trunk
Move scalePageBy from eventSender to window.internals
https://bugs.webkit.org/show_bug.cgi?id=64512
Reviewed by Simon Fraser.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
Added setPageScaleFactor to window.internals.
Renamed window.internals.getPageScaleFactor to window.internals.pageScaleFactor
to match the webkit style.
- testing/Internals.cpp:
(WebCore::Internals::pageScaleFactor):
(WebCore::Internals::setPageScaleFactor):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
Updated layout tests to use window.internals.setPageScaleFactor.
- compositing/geometry/fixed-position-composited-page-scale-down.html:
- compositing/geometry/fixed-position-composited-page-scale.html:
- compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
- compositing/geometry/fixed-position-iframe-composited-page-scale.html:
- compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
- compositing/geometry/fixed-position-transform-composited-page-scale.html:
- compositing/scaling/tiled-layer-recursion.html:
- fast/dom/Element/scale-page-bounding-client-rect.html:
- fast/dom/Element/scale-page-client-rects.html:
- fast/dom/Range/scale-page-bounding-client-rect.html:
- fast/dom/Range/scale-page-client-rects.html:
- fast/events/scale-and-scroll-body.html:
- fast/events/scale-and-scroll-iframe-body.html:
- fast/events/scale-and-scroll-iframe-window.html:
- fast/events/scale-and-scroll-window.html:
- fast/events/script-tests/page-scaled-mouse-click-iframe.js:
(iframeLoaded):
- fast/events/script-tests/page-scaled-mouse-click.js:
- fast/events/scroll-in-scaled-page-with-overflow-hidden.html:
- fast/events/touch/page-scaled-touch-gesture-click.html:
- fast/frames/frame-set-rotation-hit.html:
- fast/frames/frame-set-scaling-hit.html:
- fast/frames/iframe-double-scale-contents.html:
- fast/repaint/background-scaling.html:
- fast/repaint/scale-page-shrink.html:
- fast/transforms/selection-bounds-in-transformed-view.html:
- 1:01 AM Writing Layout Tests for DumpRenderTree edited by
- (diff)
- 12:48 AM Changeset in webkit [102322] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, remove duplicate test expectations.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08
- platform/chromium/test_expectations.txt:
- 12:20 AM Changeset in webkit [102321] by
-
- 6 edits1 add in trunk/Source/WebCore
Use the [Supplemental] IDL for webaudio attributes in Chromium
https://bugs.webkit.org/show_bug.cgi?id=73394
Reviewed by Adam Barth.
- Overview: Using the [Supplemental] IDL, this patch moves the attribute
declarations of webaudio from DOMWindow.idl into a new IDL file
webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained
feature (aka a module).
- This patch changes the build flow of WebCore.gyp as follows:
Previous build flow:
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;
}
New build flow (See the discussions in bug 72138 for more details):
resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl;
}
- This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL
will be removed after build scripts for all platforms support the [Supplemental] IDL.
The motivation for the [Supplemented] IDL is as follows:
In order to support the [Supplemental] IDL, we need to
(1) run resolve-supplemental.pl and generate supplemental_dependency.tmp
(2) and run generate-bindings.pl with the supplemental_dependency.tmp.
This build flow requires a change on the following build scripts,
but changing all the build scripts all at once without any regression is too difficult:
- DerivedSources.make
- DerivedSources.pri
- GNUmakefile.am
- PlatformBlackBerry.cmake
- UseJSC.cmake
- UseV8.cmake
- WebCore.vcproj/MigrateScripts
- WebCore.vcproj/WebCore.vcproj
- bindings/gobject/GNUmakefile.am
- WebCore.gyp/WebCore.gyp
Thus, we are planning to change the build scripts one by one, which implies that
we need to allow the temporary state in which some build scripts support [Supplemental] IDL
but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented].
The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental]
in another IDL file somewhere, like this:
DOMWindowWebAudio.idl:
interface [
Supplemental=DOMWindow
] DOMWindowWebAudio {
attribute attr1;
attribute attr2;
};
DOMWindow.idl:
interface [
] DOMWindow {
attribute [Supplemented] attr1; This line will be removed after all build scripts support the [Su IDL
attribute [Supplemented] attr2; This line will be removed after all build scripts support the [Su IDL.
attribute attr3;
attribute attr4;
};
Assuming these IDL files, this patch implements the following logic in generate-bindings.pl:
- If a given build script supports the [Supplemental] IDL, generate-bindings.pl ignores all attributes with the [Supplemented] IDL.
- Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL as normal attributes and instead ignores all attributes with the [Supplemental] IDL (i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL).
Tests: webaudio/*
- WebCore.gyp/WebCore.gyp: Describes the build flow that I described above.
- WebCore.gyp/scripts/action_derivedsourcesallinone.py:
(main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file. If the file name is a "/cygdrive/c/..."-style path, it is converted to a "C:\cygwin\..."-style path by the cygpath command.
- WebCore.gypi: Added DOMWindowWebAudio.idl.
- bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL.
- page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL.
- webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in DOMWindow.idl.
Dec 7, 2011:
- 11:53 PM Changeset in webkit [102320] by
-
- 5 edits in trunk
CSS color gets adjusted for disabled input elements
https://bugs.webkit.org/show_bug.cgi?id=54643
Patch by Yosifumi Inoue <yosin@chromium.org> on 2011-12-07
Reviewed by Kent Tamura.
Source/WebCore:
No new tests. covered by existing tests. Need rebasing some existing tests for Chromimum.
Remove automatic color adjustment for disabled text control for Chromimum.
- css/themeChromium.css: Add CSS entries for default style for disabled input and textarea elements.
- WebCore/rendering/RenderTextControl.cpp:
(disabledTextColor): Removed for PLATFORM(CHROMIUM)
(RenderTextControl::adjustInnerTextStyle): Don't call disabledTextColor for Chromium.
LayoutTests:
- platform/chromium/test_expectations.txt: Add files need to be updated.
- 11:33 PM Changeset in webkit [102319] by
-
- 5 edits in trunk/Source
Fix the 32-bit build.
Ignore some warnings that only occur in 32-bit.
Source/WebKit/mac:
- Plugins/WebNetscapePluginPackage.mm:
Source/WebKit2:
- PluginProcess/mac/PluginProcessShim.mm:
- Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryLoad):
- 11:31 PM Changeset in webkit [102318] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Unreviewed buildfix after r102262.
- Api/qwebelement.cpp:
(QWebElement::setStyleProperty):
- 10:59 PM Changeset in webkit [102317] by
-
- 6 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=74038
[V8][Chromium] Support legacy argument order in window.postMessage/window.webkitPostMessage.
Reviewed by David Levin.
Source/WebCore:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::isLegacyTargetOriginDesignation):
(WebCore::handlePostMessageCallback):
LayoutTests:
- fast/dom/Window/window-postmessage-args-expected.txt:
- fast/dom/Window/window-postmessage-args.html: New tests for legacy argument order.
- platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
- 10:50 PM Changeset in webkit [102316] by
-
- 1 edit3 adds in trunk/LayoutTests
Unreviewed, rebaseline media/controls-layout-direction.html
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-07
- platform/chromium-cg-mac-snowleopard/media/controls-layout-direction-expected.png: Added.
- platform/chromium-mac-snowleopard/media/controls-layout-direction-expected.png: Added.
- platform/chromium-win/media/controls-layout-direction-expected.png: Added.
- 10:29 PM Changeset in webkit [102315] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectation update.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-07
- platform/chromium/test_expectations.txt:
- 10:01 PM Changeset in webkit [102314] by
-
- 2 edits4 adds in trunk/Source/WebCore
Upstream 4 files into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=73541
Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-07
Reviewed by Antonio Gomes.
Initial upstream of BlackBerry porting of PlatformScreen/
SSLKeyGenerator/Sound/Widget, no new tests.
- PlatformBlackBerry.cmake: Modified to remove empty file "WheelEventBlackBerry.cpp"
- platform/blackberry/PlatformScreenBlackBerry.cpp: Added.
(WebCore::screenIsMonochrome):
(WebCore::screenDepthPerComponent):
(WebCore::screenDepth):
(WebCore::screenAvailableRect):
(WebCore::screenRect):
- platform/blackberry/SSLKeyGeneratorBlackBerry.cpp: Added.
(WebCore::getSupportedKeySizes):
(WebCore::signedPublicKeyAndChallengeString):
- platform/blackberry/SoundBlackBerry.cpp: Added.
(WebCore::systemBeep):
- platform/blackberry/WidgetBlackBerry.cpp: Added.
(WebCore::Widget::Widget):
(WebCore::Widget::~Widget):
(WebCore::Widget::hide):
(WebCore::Widget::paint):
(WebCore::Widget::setCursor):
(WebCore::Widget::setFocus):
(WebCore::Widget::setFrameRect):
(WebCore::Widget::setIsSelected):
(WebCore::Widget::show):
(WebCore::Widget::frameRect):
- 9:38 PM Changeset in webkit [102313] by
-
- 4 edits2 adds in trunk
Refactor CSSParser::parseFontFaceSrc()
https://bugs.webkit.org/show_bug.cgi?id=73989
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/css/font-face-src-parsing.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFontFaceSrcURI): Added.
(WebCore::CSSParser::parseFontFaceSrcLocal): Added.
(WebCore::CSSParser::parseFontFaceSrc): Rewrote.
- css/CSSParser.h:
LayoutTests:
Added a test that checks parsing result of the src descriptor of @font-face.
- fast/css/font-face-src-parsing-expected.txt: Added.
- fast/css/font-face-src-parsing.html: Added.
- 9:23 PM Changeset in webkit [102312] by
-
- 2 edits in trunk/Source/WebCore
Implement the SSE optimization in SincResampler::process()
https://bugs.webkit.org/show_bug.cgi?id=73789
Patch by Xingnan Wang <xingnan.wang@intel.com> on 2011-12-07
Reviewed by Benjamin Poulain.
Here is about 70% performance improvement on the hot spot of sample convolving.
- platform/audio/SincResampler.cpp:
- 9:08 PM Changeset in webkit [102311] by
-
- 3 edits in trunk/Source/WebCore
Implement border image source properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=73981
Reviewed by Andreas Kling.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyBorderImageSource::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- 8:58 PM Changeset in webkit [102310] by
-
- 2 edits in trunk/Source/WebCore
WebPImageDecoder should not do a full image decode if progressive decoding is active
https://bugs.webkit.org/show_bug.cgi?id=74041
Reviewed by Adam Barth.
If the decoder input data state reaches allDataReceived during a progressive image
decode, the decoder performs a full image decode.
On allDataReceived, check if we already have a decoder, and if so, continue to run
the progressive decoder.
No new tests. No change in behavior.
- platform/image-decoders/webp/WEBPImageDecoder.cpp:
(WebCore::WEBPImageDecoder::decode):
- 8:42 PM Changeset in webkit [102309] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium expectations update.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-07
- platform/chromium/test_expectations.txt:
- 8:35 PM Changeset in webkit [102308] by
-
- 6 edits2 adds in trunk/Source
[chromium] Add page-scale animation support to Impl thread
https://bugs.webkit.org/show_bug.cgi?id=72996
Patch by Alexandre Elias <aelias@google.com> on 2011-12-07
Reviewed by James Robinson.
This adds a new math helper class to compute the progress of the
animation, and code in the CCLayerTreeHostImpl to apply the animation
frame by frame.
No new tests. (https://bugs.webkit.org/show_bug.cgi?id=71529 filed.)
Source/WebCore:
- WebCore.gypi:
- platform/graphics/chromium/cc/CCInputHandler.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::animate):
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCPageScaleAnimation.cpp: Added.
(WebCore::CCPageScaleAnimation::CCPageScaleAnimation):
(WebCore::CCPageScaleAnimation::initialize):
(WebCore::CCPageScaleAnimation::zoomTo):
(WebCore::CCPageScaleAnimation::zoomWithAnchor):
(WebCore::CCPageScaleAnimation::zoomElsewhere):
(WebCore::CCPageScaleAnimation::scrollOffsetAtTime):
(WebCore::CCPageScaleAnimation::pageScaleAtTime):
(WebCore::CCPageScaleAnimation::isAnimationCompleteAtTime):
(WebCore::CCPageScaleAnimation::progressRatioForTime):
(WebCore::CCPageScaleAnimation::scrollOffsetAtRatio):
(WebCore::CCPageScaleAnimation::pageScaleAtRatio):
- platform/graphics/chromium/cc/CCPageScaleAnimation.h: Added.
(WebCore::CCPageScaleAnimation::startTime):
(WebCore::CCPageScaleAnimation::duration):
(WebCore::CCPageScaleAnimation::endTime):
(WebCore::CCPageScaleAnimation::finalScrollOffset):
(WebCore::CCPageScaleAnimation::finalPageScale):
Source/WebKit/chromium:
- public/WebCompositor.h:
- public/WebInputEvent.h:
(WebKit::WebPageScaleAnimationEvent::WebPageScaleAnimationEvent):
- public/android/WebInputEventFactory.h:
- src/WebCompositorImpl.cpp:
(WebKit::WebCompositorImpl::handlePageScaleAnimationEvent):
- src/WebCompositorImpl.h:
- src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::handleInputEvent):
- src/android/WebInputEventFactory.cpp:
(WebKit::WebInputEventFactory::pageScaleAnimationEvent):
- 8:25 PM Changeset in webkit [102307] by
-
- 5 edits in trunk/Source/WebCore
Editor::markAndReplaceFor should take Range instead of TextCheckingParagraph.
https://bugs.webkit.org/show_bug.cgi?id=74035
Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-07
Reviewed by Hajime Morita.
Editor::markAndReplaceFor takes chekcing range and paragraph range instead of
spelling paragraph and grammar paragraph.
No new tests. Covered by existing tests.
- editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
(WebCore::Editor::markAndReplaceFor):
- editing/Editor.h:
- editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingParagraph::TextCheckingParagraph):
- editing/TextCheckingHelper.h:
- 8:13 PM Changeset in webkit [102306] by
-
- 3 edits3 adds in trunk
Force LTR layout for media controls even in RTL documents.
https://bugs.webkit.org/show_bug.cgi?id=74024
Patch by Ami Fischman <fischman@chromium.org> on 2011-12-07
Reviewed by Darin Adler.
Source/WebCore:
Test: media/controls-layout-direction.html
- css/mediaControls.css:
(::-webkit-media-controls):
LayoutTests:
- media/controls-layout-direction-expected.txt: Added.
- media/controls-layout-direction.html: Added.
- platform/chromium-linux/media/controls-layout-direction-expected.png: Added.
- 7:55 PM Changeset in webkit [102305] by
-
- 6 edits in trunk
[FileSystem API] requestFileSystem successCallback is required
https://bugs.webkit.org/show_bug.cgi?id=69637
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-12-07
Reviewed by Darin Adler.
Source/WebCore:
- page/DOMWindow.idl: remove [Optional] flag from successCallback parameter
LayoutTests:
- fast/filesystem/filesystem-no-callback-null-ptr-crash.html: fix now-broken logic testing for unrelated bug
- fast/filesystem/not-enough-arguments-expected.txt:
- fast/filesystem/not-enough-arguments.html: add checks for webkitRequestFileSystem with not enough parameters
- 7:43 PM Changeset in webkit [102304] by
-
- 2 edits6 adds in trunk/LayoutTests
[Chromium] Unreviewed, rebaseline width-overflow.html and fix test_expectations.txt
- platform/chromium-cg-mac/printing/width-overflow-expected.png: Added.
- platform/chromium-cg-mac/printing/width-overflow-expected.txt: Added.
- platform/chromium-mac-snowleopard/printing/width-overflow-expected.png: Added.
- platform/chromium-mac-snowleopard/printing/width-overflow-expected.txt: Added.
- platform/chromium-win/printing/width-overflow-expected.png: Added.
- platform/chromium-win/printing/width-overflow-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 7:38 PM Changeset in webkit [102303] by
-
- 1 edit7 adds in trunk/Source/WebCore
Upstream the BlackBerry porting of network Resource
https://bugs.webkit.org/show_bug.cgi?id=73388
Reviewed by Rob Buis.
Other main contributors:
Joe Mason <jmason@rim.com>
Yong Li <yoli@rim.com>
Gary Simmons <gsimmons@rim.com>
Genevieve Mak <gmak@rim.com>
Chris Guan <chris.guan@torchmobile.com.cn>
Mike Lattanzio <mlattanzio@rim.com>
Initial upstream, can't be built yet, no new tests.
- platform/network/blackberry/ResourceError.h: Added.
- platform/network/blackberry/ResourceErrorBlackBerry.cpp: Added.
- platform/network/blackberry/ResourceHandleBlackBerry.cpp: Added.
- platform/network/blackberry/ResourceRequest.h: Added.
- platform/network/blackberry/ResourceRequestBlackBerry.cpp: Added.
- platform/network/blackberry/ResourceResponse.h: Added.
- platform/network/blackberry/ResourceResponseBlackBerry.cpp: Added.
- 7:11 PM Changeset in webkit [102302] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG CSE should know that CheckFunction is pure
https://bugs.webkit.org/show_bug.cgi?id=74044
Reviewed by Oliver Hunt.
Possible slight win on V8, no regressions.
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::checkFunctionElimination):
- 7:03 PM Changeset in webkit [102301] by
-
- 17 edits in trunk/Source
[Chromium] Plumb DPI info into PlatformScreen
https://bugs.webkit.org/show_bug.cgi?id=70556
Source/WebCore:
Reviewed by Darin Fisher.
Make DPI information accessible from WebKit through
PlatformScreen. This is useful when making scaling
computations on various devices (e.g. Viewport meta tag).
This patch adds DPI plumbing on Chromium Win/Mac/Linux
platforms.
- page/Screen.cpp:
(WebCore::Screen::horizontalDPI):
(WebCore::Screen::verticalDPI):
- page/Screen.h:
- platform/PlatformScreen.h:
- platform/chromium/PlatformScreenChromium.cpp:
(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):
- platform/chromium/PlatformSupport.h:
- platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):
- platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):
- platform/mac/PlatformScreenMac.mm:
(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):
- platform/qt/PlatformScreenQt.cpp:
(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):
- platform/win/PlatformScreenWin.cpp:
(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):
Source/WebKit/chromium:
Reviewed by Darin Fisher.
Make DPI information accessible from WebKit through
PlatformScreen. This is useful when making scaling
computations on various devices (e.g. Viewport meta tag).
This patch adds DPI plumbing on Chromium Win/Mac/Linux
platforms.
- public/WebScreenInfo.h:
(WebKit::WebScreenInfo::WebScreenInfo):
- src/PlatformSupport.cpp:
(WebCore::PlatformSupport::screenHorizontalDPI):
(WebCore::PlatformSupport::screenVerticalDPI):
- src/mac/WebScreenInfoFactory.mm:
(WebKit::WebScreenInfoFactory::screenInfo):
- src/win/WebScreenInfoFactory.cpp:
(WebKit::WebScreenInfoFactory::screenInfo):
- src/x11/WebScreenInfoFactory.cpp:
(WebKit::WebScreenInfoFactory::screenInfo):
- 6:45 PM Changeset in webkit [102300] by
-
- 10 edits15 deletes in trunk
Revert mixed content handling for video fix and follow-up test expectations & Skipped changes.
(r101883, r101918, r101927, r101981, r101986, r101997)
https://bugs.webkit.org/show_bug.cgi?id=72178
Patch by Aaron Colwell <acolwell@chromium.org> on 2011-12-07
Reviewed by Adam Barth.
Source/WebCore:
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest):
- loader/cache/CachedRawResource.cpp:
- loader/cache/CachedRawResource.h:
- loader/cache/CachedResource.cpp:
(WebCore::defaultPriorityForResourceType):
(WebCore::cachedResourceTypeToTargetType):
- loader/cache/CachedResource.h:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource):
(WebCore::CachedResourceLoader::checkInsecureContent):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
LayoutTests:
- http/tests/security/mixedContent/insecure-video-in-iframe-expected.txt: Removed.
- http/tests/security/mixedContent/insecure-video-in-iframe.html: Removed.
- http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
- http/tests/security/mixedContent/insecure-video-in-main-frame.html: Removed.
- http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.
- http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame.html: Removed.
- http/tests/security/mixedContent/redirect-https-to-http-video-in-main-frame-expected.txt: Removed.
- http/tests/security/mixedContent/redirect-https-to-http-video-in-main-frame.html: Removed.
- http/tests/security/mixedContent/resources/frame-with-insecure-video.html: Removed.
- http/tests/security/mixedContent/resources/frame-with-redirect-http-to-https-video.html: Removed.
- http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-video.html: Removed.
- platform/chromium-cg-mac-snowleopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
- platform/chromium-cg-mac-snowleopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.
- platform/chromium-mac-snowleopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
- platform/chromium-mac-snowleopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 6:27 PM Changeset in webkit [102299] by
-
- 2 edits in trunk/LayoutTests
[Qt] Follow up of r102226.
https://bugs.webkit.org/show_bug.cgi?id=73987
- platform/qt-5.0/Skipped: Renamed three number tests.
- 6:19 PM Changeset in webkit [102298] by
-
- 8 edits in trunk
StringBuilderTest.Append and StringBuilderTest.ToStringPreserveCapacity are failing.
https://bugs.webkit.org/show_bug.cgi?id=73995
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
Problem was that a call to characters on an StringImpl associated
with a StringBuilder that is being appended to gets stale.
Added a new m_valid16BitShadowlen that keeps the length of
the 16 bit shadow that has been upconverted or will be up converted
with the first getCharacters(). When StringBuilder::characters or
::reifyString is called, further characters are upconverted if
we have a shadow16bit copy and the m_valid16BitShadowlen is updated.
- JavaScriptCore.exp:
- wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::reifyString):
- wtf/text/StringBuilder.h:
(WTF::StringBuilder::StringBuilder):
(WTF::StringBuilder::characters):
(WTF::StringBuilder::clear): Cleaned up as part of the change.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::getData16SlowCase):
(WTF::StringImpl::upconvertCharacters):
- wtf/text/StringImpl.h:
Tools:
Reenabled failing tests that the code part of the patch fixes.
Reviewed by Geoffrey Garen.
- TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
(TestWebKitAPI::TEST):
- 6:11 PM Changeset in webkit [102297] by
-
- 8 edits1 add in trunk/Source
[EFL] Introduce AssertMatchingEnums.cpp.
https://bugs.webkit.org/show_bug.cgi?id=65238
Reviewed by Filip Pizlo.
Source/WebCore:
Remove switch statement which convert EWK_TOUCH_PointType enum values to
WebCore::PlatformTouchPoint::State enum values.
Newly added AssertMatchingEnums.cpp assure that they are equal.
No new tests, no new functionality.
- platform/efl/PlatformTouchEventEfl.cpp:
(WebCore::PlatformTouchEvent::PlatformTouchEvent):
Source/WebKit/efl:
Add AssertMatchingEnums.cpp to assert that various WebKit API enum values
match to WebCore defined enum values.
- CMakeListsEfl.txt: add AssertMatchingEnums.cpp.
- WebCoreSupport/AssertMatchingEnums.cpp: Added.
- ewk/ewk_frame.cpp:
(ewk_frame_feed_touch_event): remove switch statement wichi convert WebKit API enum value to WebCore defined enum values.
(ewk_frame_text_selection_type_get): Ditto.
- ewk/ewk_view.cpp:
(ewk_view_mode_set): Ditto.
(ewk_view_mode_get): Ditto.
(ewk_view_visibility_state_set): Ditto.
(ewk_view_visibility_state_get): Ditto.
- ewk/ewk_frame.h: fix order of enum values.
- ewk/ewk_view.h: add missing enum value.
- 6:09 PM Changeset in webkit [102296] by
-
- 2 edits in trunk/Tools
[filter-build-webkit] should not emit reset color when --no-color is given
https://bugs.webkit.org/show_bug.cgi?id=73992
Reviewed by Daniel Bates.
Stop printing control sequences when --no-color is given.
After this change, the filter runs nicely even on environments
like Emacs compilation-mode which cannot understand the control sequence.
- Scripts/filter-build-webkit:
(printLine):
- 6:09 PM Changeset in webkit [102295] by
-
- 3 edits in trunk/Source/JavaScriptCore
Compare and Swap should be enabled on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=74023
Reviewed by Geoff Garen.
Implemented weakCompareAndSwap in terms of LDREX/STREX and enabled PARALLEL_GC.
It gives the expected speed-up on multi-core ARMv7 devices.
- wtf/Atomics.h:
(WTF::weakCompareAndSwap):
- wtf/Platform.h:
- 6:02 PM Changeset in webkit [102294] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Clearing root surface should happen after damage tracking
https://bugs.webkit.org/show_bug.cgi?id=73958
Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-12-07
Reviewed by James Robinson.
No new semantics, covered by existing layout tests.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::clearSurfaceForDebug):
(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
(WebCore::LayerRendererChromium::drawLayersInternal):
- platform/graphics/chromium/LayerRendererChromium.h:
- 6:01 PM Changeset in webkit [102293] by
-
- 3 edits3 adds in trunk
DFG CSE is overzealous with GetByVal
https://bugs.webkit.org/show_bug.cgi?id=74042
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
Made sure that the purity of GetByVal and the limited-clobber-itude of PutByVal
is tested in all places that matter.
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::byValIsPure):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
LayoutTests:
Reviewed by Oliver Hunt.
- fast/js/dfg-get-by-val-getter-cse-expected.txt: Added.
- fast/js/dfg-get-by-val-getter-cse.html: Added.
- fast/js/script-tests/dfg-get-by-val-getter-cse.js: Added.
():
- 5:53 PM Changeset in webkit [102292] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Preserve original pageScale limits in WebViewImpl
https://bugs.webkit.org/show_bug.cgi?id=72983
Patch by Alexandre Elias <aelias@google.com> on 2011-12-07
Reviewed by Darin Fisher.
Preserve the originally viewport-tag specified page scale limits, and
compute the final ones in a new private method
computePageScaleFactorLimits(). This is then called when contents
size change (which can affect the minimum).
Also clean up several minor bugs, namely clamping issues (reorder
clampNegativeToZero to avoid negative scroll offsets, and force max to
be greater than min), and incorrect behavior in the presence of
"solid" scrollbars.
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::contentsSizeChanged):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::clampPageScaleFactorToLimits):
(WebKit::WebViewImpl::clampOffsetAtScale):
(WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset):
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::setPageScaleFactorLimits):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
(WebKit::WebViewImpl::didChangeContentsSize):
- src/WebViewImpl.h:
- 5:50 PM Changeset in webkit [102291] by
-
- 5 edits in trunk/Tools
Use free memory to determine if we have space for DRT instances instead of total memory
https://bugs.webkit.org/show_bug.cgi?id=74021
Reviewed by Adam Barth.
This will hopefully make the Mac buildbots behave better.
I also reduced the expected memory needed per DRT now that
we're properly accounting for the system memory in our calculations.
- Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.total_bytes_memory):
(PlatformInfo._compute_free_bytes_from_vm_stat_output):
- Scripts/webkitpy/common/system/platforminfo_mock.py:
(MockPlatformInfo.total_bytes_memory):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.default_child_processes):
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_default_child_processes):
- 5:44 PM Changeset in webkit [102290] by
-
- 6 edits in trunk
<li value="0"> behaves like <li> (the same for negative numbers)
https://bugs.webkit.org/show_bug.cgi?id=73911
Patch by Florin Malita <fmalita@google.com> on 2011-12-07
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Allow LI values <= 0 and consolidate the value processing logic.
- html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::parseMappedAttribute):
Delegated value parsing to parseValue().
(WebCore::HTMLLIElement::attach):
Ditto. Explicit value null testing is no longer necessary,
as parseValue's toInt() performs an equivalent check.
(WebCore::HTMLLIElement::parseValue):
Consolidated value parsing logic.
- html/HTMLLIElement.h:
LayoutTests:
Added tests for values <= 0.
- fast/lists/li-values-expected.txt:
- fast/lists/li-values.html:
- 5:33 PM Changeset in webkit [102289] by
-
- 4 edits in trunk/Source
IndexedDB: Replace bool args in IDBKeyRange private methods with enum
https://bugs.webkit.org/show_bug.cgi?id=70743
Patch by Joshua Bell <jsbell@chromium.org> on 2011-12-07
Reviewed by Tony Chang.
No new tests - no functional changes.
- storage/IDBKeyRange.cpp:
(WebCore::IDBKeyRange::IDBKeyRange):
(WebCore::IDBKeyRange::bound):
- storage/IDBKeyRange.h:
(WebCore::IDBKeyRange::create):
(WebCore::IDBKeyRange::lowerOpen):
(WebCore::IDBKeyRange::upperOpen):
- 5:19 PM Changeset in webkit [102288] by
-
- 2 edits in branches/safari-534.53-branch/Source/WebCore
Fix a compiler error about implicit conversion from 64 to 32bit int.
Reviewed by Beth Dakin.
- platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
- 4:52 PM Changeset in webkit [102287] by
-
- 1 add in branches/chromium/963/codereview.settings
add codereview settings file
- 4:49 PM Changeset in webkit [102286] by
-
- 3 edits in branches/chromium/963/Source/WebCore
Merge 102180 - [chromium] Don't crash if tile upload happens without painting first
https://bugs.webkit.org/show_bug.cgi?id=73939
Reviewed by James Robinson.
Remove at least one place (in ImageLayerChromium) where this could
happen.
Although this shouldn't happen, we should be robust to it in the
chance that other code causes it to.
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):
TBR=enne@google.com
- 4:45 PM Changeset in webkit [102285] by
-
- 4 edits in branches/safari-534.53-branch/Source
Merged r99617.
- 4:35 PM Changeset in webkit [102284] by
-
- 17 edits in branches/safari-534.53-branch/Source
Merge 99493
- 4:32 PM Changeset in webkit [102283] by
-
- 3 edits in trunk/Source/WebKit/chromium
Exposing boundsInScreenSpace in WebElement.
https://bugs.webkit.org/show_bug.cgi?id=71579
Exposing boundsInScreenSpace through a new function,
boundsInViewportSpace, to assist in moving the Autofill UI out of
WebKit in Chromium. Renamed the exposed function to provide a better
meaning of what the function does in the Chromium code.
More information can be found at:
http://crbug.com/51644
Patch by Chris Sharp <csharp@chromium.org> on 2011-12-07
Reviewed by Darin Fisher.
- public/WebElement.h:
- src/WebElement.cpp:
(WebKit::WebElement::boundsInViewportSpace):
- 4:28 PM Changeset in webkit [102282] by
-
- 4 edits in trunk/Source
Unreviewed, rolling out r102267.
http://trac.webkit.org/changeset/102267
https://bugs.webkit.org/show_bug.cgi?id=74032
Breaks build on Chromium Mac Debug (Requested by aklein on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-07
Source/JavaScriptCore:
- wtf/HashTraits.h:
Source/WebCore:
- dom/ChildListMutationScope.cpp:
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::childAdded):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::willRemoveChild):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::decrementScopingLevel):
- 4:25 PM Changeset in webkit [102281] by
-
- 9 edits6 adds in trunk
REGRESSION (r95249): Right side can be truncated when printing
https://bugs.webkit.org/show_bug.cgi?id=73868
Reviewed by Darin Adler.
Source/WebCore:
When we print a page with an overflowed width, the right side of the page
can be truncated. This is due to a wrong rendering calculation.
Since 'maximumShrinkFactor' is a ratio based on 'pageSize',
'maximumShrinkFactor' should multiply (not 'originalPageSize') but 'pageSize'.
This bug happens if all the following conditions are met:
- pageLogicalWidth < docLogicalWidth
- originalPageSize.width * maximumShrinkFactor < docLogicalWidth
- docLogicalWidth < pageLogicalWidth * maximumShrinkFactor
Test: printing/width-overflow.html
- page/FrameView.cpp:
(WebCore::FrameView::forceLayoutForPagination):
LayoutTests:
width-overflow.html checks if the page is printed without its right side
being truncated.
- printing/width-overflow.html: Added.
- platform/chromium-linux/printing/width-overflow-expected.png: Added.
- platform/chromium-linux/printing/width-overflow-expected.txt: Added.
- platform/mac-snowleopard/printing/width-overflow-expected.png: Added.
- platform/mac-snowleopard/printing/width-overflow-expected.txt: Added.
- platform/efl/Skipped: Skips width-overflow.html, since layoutTestController.setPrinting() is not implemented.
- platform/gtk/Skipped: Ditto.
- platform/qt/Skipped: Ditto.
- platform/win/Skipped: Ditto.
- platform/wincairo/Skipped: Ditto.
- platform/wk2/Skipped: Ditto.
- 4:12 PM Changeset in webkit [102280] by
-
- 2 edits in trunk/Tools
fix build-webkit --chromium after breakage in r102201
https://bugs.webkit.org/show_bug.cgi?id=74031
Reviewed by Tony Chang.
r102201 introduced a change to the chromium build that splits
the executables out of WebKit.gyp into other gyp files, and adds
a new "All.gyp" that builds everything. However, I forgot to
update the build script to use All.gyp.
- Scripts/webkitdirs.pm:
(buildChromium):
- 3:43 PM Changeset in webkit [102279] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, skip a test that may be causing Win DRT to hang.
- platform/chromium/test_expectations.txt:
- 3:41 PM Changeset in webkit [102278] by
-
- 4 edits1 add in trunk
Defer ScriptExecutionContext::Task's in Document when page loading is deferred.
Schedule them with timer when page loading is resumed. The tasks will be performed
in the original order. This fixes the problem that database callbacks could be missed
when page loading was deferred.
https://bugs.webkit.org/show_bug.cgi?id=49401
Patch by Yong Li <yoli@rim.com> on 2011-12-07
Reviewed by Darin Adler.
Manual test added: ManualTests/database-callback-deferred.html.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::didReceiveTask):
(WebCore::Document::postTask):
(WebCore::Document::pendingTasksTimerFired):
(WebCore::Document::suspendScheduledTasks):
(WebCore::Document::resumeScheduledTasks):
- dom/Document.h:
- page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
- 2:48 PM Changeset in webkit [102277] by
-
- 3 edits in branches/safari-534.53-branch/Source/WebKit2
Merged r99090.
- 2:47 PM Changeset in webkit [102276] by
-
- 6 edits in branches/safari-534.53-branch/Source
Merged r98892.
- 2:46 PM Changeset in webkit [102275] by
-
- 4 edits in trunk
[MutationObservers] Enable in Chromium trunk
https://bugs.webkit.org/show_bug.cgi?id=73851
Reviewed by Ojan Vafai.
Source/WebKit/chromium:
Re-landing after fixing Chromium unit test crashes in r102171
and inspector debugger crash in r102264.
- features.gypi:
LayoutTests:
- platform/chromium/test_expectations.txt: Stop skipping fast/mutation tests.
- 2:45 PM Changeset in webkit [102274] by
-
- 8 edits in branches/safari-534.53-branch/Source/WebKit2
Merged r98873.
- 2:43 PM Changeset in webkit [102273] by
-
- 11 edits in branches/safari-534.53-branch/Source
Merged r98664.
- 2:37 PM Changeset in webkit [102272] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, clean out passing tests from test_expectations.txt
- platform/chromium/test_expectations.txt:
- 2:36 PM Changeset in webkit [102271] by
-
- 8 edits in branches/safari-534.53-branch/Source
Merge 97514. needed for 98664.
- 1:43 PM Changeset in webkit [102270] by
-
- 10 edits in branches/safari-534.53-branch/Source/WebKit2
Merged r98646.
- 1:18 PM Changeset in webkit [102269] by
-
- 1 edit2 adds in trunk/LayoutTests
IndexedDB deleteIndex should throw NOT_ALLOWED_ERR if called outside a VERSION_CHANGE transaction callback
https://bugs.webkit.org/show_bug.cgi?id=62370
Already behaves correctly, just adding tests.
Patch by Joshua Bell <jsbell@chromium.org> on 2011-12-07
Reviewed by Tony Chang.
- storage/indexeddb/deleteIndex-expected.txt: Added.
- storage/indexeddb/deleteIndex.html: Added.
- 1:10 PM Changeset in webkit [102268] by
-
- 4 edits in trunk/Source/WebCore
RenderObject::style(): Inline early-return condition.
<http://webkit.org/b/74019>
Reviewed by Anders Carlsson.
style() was very hot (6.1%) when scrolling around on youtube.com,
and 100% of the calls were taking the early return path.
Inlined the !isRenderFlowThread() check and renamed the function to
styleSlowCase().
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleSlowCase):
- rendering/RenderObject.h:
(WebCore::RenderObject::style):
- 1:01 PM Changeset in webkit [102267] by
-
- 4 edits in trunk/Source
Use HashMap<Node*, OwnPtr<...>> in ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=73964
Reviewed by Ryosuke Niwa.
Source/JavaScriptCore:
- wtf/HashTraits.h: Add passOut(std::nullptr_t) to allow callers to use HashMap::take on an entry whose value is null.
Source/WebCore:
No new tests, refactoring only.
- dom/ChildListMutationScope.cpp:
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::childAdded):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::willRemoveChild):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::incrementScopingLevel):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::decrementScopingLevel):
- 12:59 PM Changeset in webkit [102266] by
-
- 3 edits in trunk/Source/WebCore
RenderLayer::updateZOrderLists(): Inline early-return condition.
<http://webkit.org/b/74013>
Reviewed by Anders Carlsson.
updateZOrderLists() was hot (1.2%) when scrolling around on youtube.com,
and 85% of the calls were taking the early return path.
Inlined the two checks for the early return and renamed the function
to updateZOrderListsSlowCase(). Also reversed their order to avoid the
virtual call (RenderObject::isRenderView()) if possible.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateZOrderListsSlowCase):
- rendering/RenderLayer.h:
(WebCore::RenderLayer::updateZOrderLists):
- 12:08 PM Changeset in webkit [102265] by
-
- 4 edits in trunk
Unreviewed, rolling out r102244.
http://trac.webkit.org/changeset/102244
https://bugs.webkit.org/show_bug.cgi?id=74016
caused debug test timeouts (Requested by simonjam on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-07
Source/WebCore:
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::putImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):
LayoutTests:
- platform/chromium/test_expectations.txt:
- 12:03 PM Changeset in webkit [102264] by
-
- 5 edits in trunk
Layout Test inspector/debugger/dom-breakpoints.html fails on chromium linux debug with ENABLE(MUTATION_OBSERVERS)
https://bugs.webkit.org/show_bug.cgi?id=73919
Reviewed by Ojan Vafai.
Source/WebCore:
Use StyleAttributeMutationScope to manage DOM breakpoints for style property changes.
Instead of calling InspectorInstrumentation::didInvalidateStyleAttr()
directly in setNeedsStyleRecalc, set a bool in the current
StyleAttributeMutationScope, and delay the call until the scope's
counter runs down to zero. This keeps the inspector JS from re-entering
CSSMutableStyleDeclaration until all StyleAttributeMutationScope work is done.
Also fix a small bug in StyleAttributeMutationScope, where
s_shouldDeliver wasn't getting reset properly to false.
- css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
LayoutTests:
Added test that no-op style mutations don't create MutationRecords.
- fast/mutation/observe-attributes-expected.txt:
- fast/mutation/observe-attributes.html:
- 12:01 PM Changeset in webkit [102263] by
-
- 3 edits2 adds in trunk
Crash from multicol spans with layers
https://bugs.webkit.org/show_bug.cgi?id=68030
Patch by Ken Buchanan <kenrb@chromium.org> on 2011-12-07
Reviewed by David Hyatt.
Source/WebCore:
The layer tree diverges from the render tree when a span is being split
between columns. This patch causes the layer tree to be updated when necessary.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::splitFlow)
(WebCore::RenderBlock::splitBlocks)
LayoutTests:
New test for fix to crash on bug 68030.
- fast/multicol/span/removal-of-multicol-span-crash-expected.txt: Added
- fast/multicol/span/removal-of-multicol-span-crash.html: Added
- 11:53 AM Changeset in webkit [102262] by
-
- 10 edits1 add14 deletes in trunk
Handling of !important in inline style sets is broken
https://bugs.webkit.org/show_bug.cgi?id=73941
Reviewed by Dave Hyatt.
This behavior was introduced in bug 8223 to match IE and Firefox. But it doesn't appear that we're matching
any browser today, and CSSOM spec agrees with them.
- WebCore.exp.in: Don't export CSSStyleDeclaration::setProperty(), no one is using it.
- bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::putDelegate): Use regular setProperty(), not the incorrect version that's being removed. Properties set via IDL attributes are never important.
- bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: (WebCore::V8CSSStyleDeclaration::namedPropertySetter): Made the same fix for v8. Why did v8 bindings authors copy/paste the code?!
- css/CSSStyleDeclaration.cpp:
- css/CSSStyleDeclaration.h: Removed a version of setProperty() that attempted to parse the value and extract !important from it.
- html/ImageDocument.cpp: (WebCore::ImageDocument::resizeImageToFit): (WebCore::ImageDocument::restoreImageSize): (WebCore::ImageDocument::windowSizeChanged):
- page/DragController.cpp: (WebCore::DragController::concludeEditDrag): We never needed to use this version of setProperty() here, it was just unnecessarily slower.
- 11:52 AM Changeset in webkit [102261] by
-
- 3 edits in trunk/Source/JavaScriptCore
Non-Mac devices should benefit from a larger heap
https://bugs.webkit.org/show_bug.cgi?id=74015
Reviewed by Geoff Garen.
Removed the ENABLE(LARGE_HEAP) option from Platform.h, since it was only used in
Heap.cpp, and got in the way of having more granular, per-platform control over
what the heap size should be. Bumped the heap size to 8MB on iOS (was 512KB).
- heap/Heap.cpp:
(JSC::GCTimer::heapSizeForHint):
- wtf/Platform.h:
- 11:45 AM Changeset in webkit [102260] by
-
- 1 edit2 adds in trunk/LayoutTests
IndexedDB objectStoreNames not updated after aborted transaction
https://bugs.webkit.org/show_bug.cgi?id=58655
Already functional but there wasn't a test with these specifics.
Patch by Joshua Bell <jsbell@chromium.org> on 2011-12-07
Reviewed by Tony Chang.
- storage/indexeddb/mozilla/versionchange-abort-expected.txt: Added.
- storage/indexeddb/mozilla/versionchange-abort.html: Added.
- 11:34 AM Changeset in webkit [102259] by
-
- 2 edits in branches/safari-534.53-branch/Source/WebKit2
Merged r98438.
- 11:32 AM Changeset in webkit [102258] by
-
- 2 edits in branches/safari-534.53-branch/Source/WebKit2
Merged r98437.
- 11:31 AM Changeset in webkit [102257] by
-
- 2 edits in branches/safari-534.53-branch/Source/WebKit2
Merged r98435.
- 11:29 AM Changeset in webkit [102256] by
-
- 3 edits in branches/safari-534.53-branch/Source/WebKit2
Merged r98416.
- 11:21 AM Changeset in webkit [102255] by
-
- 2 edits in trunk/Source/WebCore
In FontCacheAndroid.cpp should keep the pointer valid returned from CString::data()
https://bugs.webkit.org/show_bug.cgi?id=73849
The changed code has been covered by many existing layout tests.
Reviewed by Adam Barth.
- platform/graphics/chromium/FontCacheAndroid.cpp:
(WebCore::FontCache::createFontPlatformData):
- 11:19 AM Changeset in webkit [102254] by
-
- 17 edits in branches/safari-534.53-branch
Merged r98413.
- 11:06 AM Changeset in webkit [102253] by
-
- 9 edits in branches/safari-534.53-branch/Source
Merged r98406.
- 11:05 AM Changeset in webkit [102252] by
-
- 21 edits2 adds in trunk
Source/WebCore: Turn on move caret by word visually for Windows platform.
https://bugs.webkit.org/show_bug.cgi?id=59652
Reviewed by Ryosuke Niwa.
We already support (arrow key) moving cursor by character in visual order.
This patch implements (ctrl/alt-arrow) moving cursor by word in visual order (in Windows).
It matches Firefox's default behavior.
Without this patch, ctrl(alt for mac)-arrow key or
selection.modify("move", "left"/"right", "word") moves cursor by word in logical order.
IE implements moving cursor by logical order for both arrow key and ctrl-arrow key.
Firefox implements moving cursor by visual order for both operations.
From Chromium bug report, native speakers would like moving cursor by visual order since it
is more intuitive.
The patch is only enabled for Windows (by EditingBehavior) because current implementation
matches Windows' native behavior.
For exmaple, if the logical text is "abc def hij", the cursor positions are
"|abc |def |hij|" no matter pressing ctrl-left-arrow or ctrl-right-arrow.
Mac and Linux's native behavior is slightly different. In which, when pressing
ctrl-left-arrow, the cursor positions are "|abc |def |hij|". When pressing ctrl-right-arrow,
the cursor positions are "|abc| def| hij|". We will implement it next.
Test: editing/selection/move-left-right-by-word-mac.html
- editing/EditingBehavior.h:
(WebCore::EditingBehavior::shouldMoveLeftRightByWordInVisualOrder):
- editing/FrameSelection.cpp: Remove experimental enum WebKitVisualWordGranularity.
(WebCore::FrameSelection::modifyExtendingRight):
(WebCore::FrameSelection::modifyExtendingForward):
(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingForward):
(WebCore::FrameSelection::modifyExtendingLeft):
(WebCore::FrameSelection::modifyExtendingBackward):
(WebCore::FrameSelection::modifyMovingLeft):
(WebCore::FrameSelection::modifyMovingBackward):
- editing/TextGranularity.h: Remove experimental enum WebKitVisualWordGranularity.
- editing/VisibleSelection.cpp: Remove experimental enum WebKitVisualWordGranularity.
(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
- page/DOMSelection.cpp: Remove experimental experimental flag -webkit-visual-word.
(WebCore::DOMSelection::modify):
LayoutTests: Turn on move caret by word visually for windows platform.
https://bugs.webkit.org/show_bug.cgi?id=59652
Reviewed by Ryosuke Niwa.
- editing/selection/caret-mode-paragraph-keys-navigation.html:
- editing/selection/move-by-word-visually-crash-test-1.html:
- editing/selection/move-by-word-visually-crash-test-2.html:
- editing/selection/move-by-word-visually-crash-test-3.html:
- editing/selection/move-by-word-visually-crash-test-4.html:
- editing/selection/move-by-word-visually-crash-test-textarea.html:
- editing/selection/move-by-word-visually-inline-block-positioned-element.html:
- editing/selection/move-by-word-visually-multi-line.html:
- editing/selection/move-by-word-visually-multi-space.html:
- editing/selection/move-by-word-visually-null-box.html:
- editing/selection/move-by-word-visually-single-space-inline-element.html:
- editing/selection/move-by-word-visually-single-space-one-element.html:
- editing/selection/move-by-word-visually-textarea.html:
- editing/selection/move-left-right-by-word-mac-expected.txt: Added.
- editing/selection/move-left-right-by-word-mac.html: Added.
- editing/selection/resources/move-by-word-visually.js:
(moveByWord):
(moveByWordOnEveryChar):
- 10:58 AM Changeset in webkit [102251] by
-
- 1 edit1 delete in trunk/Source/WebKit2
ShareableBitmapGtk.cpp has no reason to exist
https://bugs.webkit.org/show_bug.cgi?id=74011
Reviewed by Martin Robinson.
Remove this file since the real implementation is
exists in ShareableBitmapCairo.cpp.
- Shared/gtk/ShareableBitmapGtk.cpp: Removed.
- 10:45 AM Changeset in webkit [102250] by
-
- 7 edits in trunk/Source
[chromium] Plumb damage from WebExternalTextureLayer and WebPluginContainer to CCDamageTracker
https://bugs.webkit.org/show_bug.cgi?id=73485
Patch by Jonathan Backer <backer@chromium.org> on 2011-12-07
Reviewed by Darin Fisher.
Source/WebCore:
- platform/graphics/chromium/PluginLayerChromium.cpp:
(WebCore::PluginLayerChromium::updateCompositorResources):
(WebCore::PluginLayerChromium::invalidateRect):
- platform/graphics/chromium/PluginLayerChromium.h:
Source/WebKit/chromium:
- public/platform/WebExternalTextureLayer.h:
- src/WebExternalTextureLayer.cpp:
(WebKit::WebExternalTextureLayer::invalidateRect):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::commitBackingTexture):
- 10:24 AM Changeset in webkit [102249] by
-
- 2 edits5 adds in trunk/Source/WebCore
Upstream 5 files into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=73632
Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-07
Reviewed by Rob Buis.
Initial upstream, no new tests.
- PlatformBlackBerry.cmake: Remove two empty files from build list.
- platform/blackberry/PopupMenuBlackBerry.cpp: Added.
(WebCore::PopupMenuBlackBerry::PopupMenuBlackBerry):
(WebCore::PopupMenuBlackBerry::~PopupMenuBlackBerry):
(WebCore::PopupMenuBlackBerry::show):
(WebCore::PopupMenuBlackBerry::hide):
(WebCore::PopupMenuBlackBerry::updateFromElement):
(WebCore::PopupMenuBlackBerry::disconnectClient):
- platform/blackberry/PopupMenuBlackBerry.h: Added.
(WebCore::PopupMenuBlackBerry::client):
- platform/blackberry/ScrollbarThemeBlackBerry.cpp: Added.
(WebCore::ScrollbarTheme::nativeTheme):
- platform/blackberry/SearchPopupMenuBlackBerry.cpp: Added.
(WebCore::SearchPopupMenuBlackBerry::SearchPopupMenuBlackBerry):
(WebCore::SearchPopupMenuBlackBerry::popupMenu):
(WebCore::SearchPopupMenuBlackBerry::enabled):
(WebCore::SearchPopupMenuBlackBerry::saveRecentSearches):
(WebCore::SearchPopupMenuBlackBerry::loadRecentSearches):
- platform/blackberry/SearchPopupMenuBlackBerry.h: Added.
- 10:24 AM Changeset in webkit [102248] by
-
- 2 edits in trunk/Websites/webkit.org
ASSERT_UNREACHED() should be ASSERT_NOT_REACHED() on assertion-guidelines.html
https://bugs.webkit.org/show_bug.cgi?id=74006
Reviewed by Antonio Gomes.
As far I can tell, we've never had an ASSERT_UNREACHED(). We do have an
ASSERT_NOT_REACHED().
- coding/assertion-guidelines.html:
- 10:21 AM Changeset in webkit [102247] by
-
- 2 edits in trunk/Source/WebCore
Fixed the definition of BUTTON_CELL_DRAW_WITH_FRAME_DRAWS_FOCUS_RING from r102246.
- platform/mac/ThemeMac.mm: Added parentheses.
- 10:15 AM Changeset in webkit [102246] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/10542095> Focus rings are not drawn around push buttons, radio buttons and checkboxes
Reviewed by Darin Adler.
Instead of relying on -setShowsFirstResponder: to make -drawWithFrame:inView: draw the focus
ring, use -drawFocusRingMaskWithFrame:inView:.
- platform/mac/ThemeMac.mm:
(-[NSCell _web_drawFocusRingWithFrame:inView:]): Added. Sets up the focus ring style and a
transparency layer, then uses -drawFocusRingMaskWithFrame:inView: to draw the focus ring.
(WebCore::updateStates): Eliminated calls to get and set showsFirstResponder.
(WebCore::paintCheckbox): Changed to use -_web_drawFocusRingWithFrame:inView:.
(WebCore::paintRadio): Ditto.
(WebCore::paintButton): Ditto.
- 10:12 AM Changeset in webkit [102245] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Skip 3 more metric related tests with Qt5 until test-font fix.
- platform/qt-5.0/Skipped:
- 10:08 AM Changeset in webkit [102244] by
-
- 4 edits in trunk
Source/WebCore: [CHROMIUM/SKIA] Handle put[Un/Pre]multipliedImageData conversions in Skia rather than ImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=73953
Patch by Brian Salomon <bsalomon@google.com> on 2011-12-07
Reviewed by Stephen White.
Tested by existing canvas2d layout tests.
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::putImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):
LayoutTests: [CHROMIUM] Make canvas/philip/tests/2d.imageData.put.unchanged.html be expected to fail
on the GPU due to slight difference in alpha-premul computation.
https://bugs.webkit.org/show_bug.cgi?id=73953
Patch by Brian Salomon <bsalomon@google.com> on 2011-12-07
Reviewed by Stephen White.
- platform/chromium/test_expectations.txt:
- 8:40 AM Changeset in webkit [102243] by
-
- 2 edits in trunk/Source/WebCore
Micro-optimize ScrollView::visibleContentRect().
<http://webkit.org/b/74001>
Reviewed by Anders Carlsson.
Reorder the scrollbar exclusion code to minimize the number of virtual calls
to ScrollableArea::verticalScrollbar(), ScrollableArea::horizontalScrollbar()
and Scrollbar::isOverlayScrollbar().
- platform/ScrollView.cpp:
(WebCore::ScrollView::visibleContentRect):
- 8:16 AM Changeset in webkit [102242] by
-
- 2 edits in trunk/Source/WebCore
ApplyPropertyBorderImage: Remove unneeded template argument for mapNinePieceImage().
<http://webkit.org/b/73998>
Reviewed by Antti Koivisto.
Have ApplyPropertyBorderImage call mapNinePieceImage() directly now that it's
public (instead of passing it as a template argument.)
- css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- 8:12 AM Changeset in webkit [102241] by
-
- 2 edits in trunk/Source/WebCore
Mac build fix after r102235.
- WebCore.exp.in:
- 7:38 AM Changeset in webkit [102240] by
-
- 2 edits in trunk/Tools
Moved myself to the committers list.
- Scripts/webkitpy/common/config/committers.py:
- 7:32 AM Changeset in webkit [102239] by
-
- 6 edits in trunk/Source/WebCore
[Qt] V8 debug build fixes.
Reviewed by Tor Arne Vestbø.
- Target.pri: Add missing files to the build.
- loader/SubresourceLoader.cpp: Add missing CString.h header file inclusion,
that is implicitly included with Chromium builds.
- loader/cache/CachedResource.cpp: Ditto.
- page/FrameTree.cpp: Ditto.
- platform/graphics/MediaPlayer.cpp: Ditto.
- 7:29 AM Changeset in webkit [102238] by
-
- 2 edits in trunk/Tools
[Qt] Fix debug shlib build with V8.
Reviewed by Tor Arne Vestbø.
- qmake/mkspecs/features/qtwebkit.prf: Don't like jscore with
v8 builds.
- 7:29 AM Changeset in webkit [102237] by
-
- 7 edits in trunk
[Qt] V8 build fixes.
Reviewed by Tor Arne Vestbø.
Source/JavaScriptCore:
- yarr/yarr.pri: Don't rely on Source/JavaScriptCore being in
VPATH. Prefix SOURCES correctly and make sure that runtime/ is
in the include search path when building with v8.
Source/WebCore:
- Target.pri: Don't load(javascriptcore) if we're building with v8.
Tools:
- qmake/mkspecs/features/javascriptcore.prf: Don't add
Source/Thirdparty to the include search path here.
- qmake/mkspecs/features/webcore.prf: Instead it belongs here, because it's
used when building WebCore as well as using it, because header files like
GraphicsContext3D.h include stuff from ThirdParty.
- 7:10 AM Changeset in webkit [102236] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] REGRESSION(102228): lot of test failures after enabled page cache
https://bugs.webkit.org/show_bug.cgi?id=73999
Unreviewed gardening. Skip failing tests.
- platform/qt-wk2/Skipped:
- 6:54 AM Changeset in webkit [102235] by
-
- 24 edits in trunk/Source
Change function name InitializeLoggingChannelsIfNecessary to follow coding style guideline
https://bugs.webkit.org/show_bug.cgi?id=73986
Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-07
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Just function name change, no new tests.
- platform/Logging.h:
- platform/efl/LoggingEfl.cpp:
(WebCore::initializeLoggingChannelsIfNecessary):
- platform/gtk/LoggingGtk.cpp:
(WebCore::initializeLoggingChannelsIfNecessary):
- platform/mac/LoggingMac.mm:
(WebCore::initializeLoggingChannelsIfNecessary):
- platform/qt/LoggingQt.cpp:
(WebCore::initializeLoggingChannelsIfNecessary):
- platform/win/LoggingWin.cpp:
(WebCore::initializeLoggingChannelsIfNecessary):
- platform/wx/LoggingWx.cpp:
(WebCore::initializeLoggingChannelsIfNecessary):
Source/WebKit/efl:
- ewk/ewk_main.cpp:
(_ewk_init_body):
Source/WebKit/gtk:
- webkit/webkitglobals.cpp:
(webkitInit):
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Source/WebKit/qt:
- WebCoreSupport/InitWebCoreQt.cpp:
(WebCore::initializeWebCoreQt):
Source/WebKit/win:
- WebView.cpp:
(WebView::initWithFrame):
Source/WebKit/wx:
- WebView.cpp:
(wxWebView::Create):
Source/WebKit2:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
- 6:51 AM Changeset in webkit [102234] by
-
- 15 edits13 adds in trunk
[CSSRegions]Add support for background-color in region styling
https://bugs.webkit.org/show_bug.cgi?id=71488
Reviewed by David Hyatt.
Source/WebCore:
Tests: fast/regions/region-style-block-background-color.html
fast/regions/region-style-block-background-color2.html
fast/regions/region-style-image-background-color.html
fast/regions/region-style-inline-background-color.html
- WebCore.exp.in:
- css/CSSStyleSelector.cpp:
(WebCore::RuleData::regionStyleRule):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::initForRegionStyling):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::addToRuleSet):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::isValidRegionStyleProperty):
(WebCore::CSSStyleSelector::applyProperty):
- css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::setRegionForStyling):
(WebCore::CSSStyleSelector::regionForStyling):
(WebCore::CSSStyleSelector::applyPropertyToRegionStyle):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::clearRenderRegionRangeMap):
(WebCore::RenderFlowThread::~RenderFlowThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::clearRenderObjectCustomStyle):
(WebCore::RenderFlowThread::setRegionRangeForBox):
- rendering/RenderFlowThread.h:
- rendering/RenderLayer.cpp:
(WebCore::CurrentRenderRegionMaintainer::CurrentRenderRegionMaintainer):
(WebCore::CurrentRenderRegionMaintainer::~CurrentRenderRegionMaintainer):
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::hitTest):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::style):
- rendering/RenderObject.h:
(WebCore::RenderObject::canHaveRegionStyle):
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::layout):
(WebCore::RenderRegion::renderObjectRegionStyle):
(WebCore::RenderRegion::computeStyleInRegion):
(WebCore::RenderRegion::clearObjectStyleInRegion):
- rendering/RenderRegion.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
- rendering/RenderView.h:
(WebCore::RenderView::currentRenderRegion):
(WebCore::RenderView::setCurrentRenderRegion):
LayoutTests:
- fast/regions/region-style-block-background-color.html: Added.
- fast/regions/region-style-block-background-color2.html: Added.
- fast/regions/region-style-image-background-color.html: Added.
- fast/regions/region-style-inline-background-color.html: Added.
- fast/regions/resources/transparent.png: Added.
- platform/mac-snowleopard/fast/regions/region-style-block-background-color-expected.png: Added.
- platform/mac-snowleopard/fast/regions/region-style-block-background-color-expected.txt: Added.
- platform/mac-snowleopard/fast/regions/region-style-block-background-color2-expected.png: Added.
- platform/mac-snowleopard/fast/regions/region-style-block-background-color2-expected.txt: Added.
- platform/mac-snowleopard/fast/regions/region-style-image-background-color-expected.png: Added.
- platform/mac-snowleopard/fast/regions/region-style-image-background-color-expected.txt: Added.
- platform/mac-snowleopard/fast/regions/region-style-inline-background-color-expected.png: Added.
- platform/mac-snowleopard/fast/regions/region-style-inline-background-color-expected.txt: Added.
- 6:00 AM Changeset in webkit [102233] by
-
- 14 edits in trunk/Source/WebCore
Web Inspector: Extract default call stack creation and check for front-end from console.
https://bugs.webkit.org/show_bug.cgi?id=73566
Reviewed by Yury Semikhatsky.
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
- bindings/js/ScriptCallStackFactory.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
- bindings/v8/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
- bindings/v8/ScriptCallStackFactory.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::hasFrontendForScriptContext):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::hasFrontendForScriptContext):
- inspector/WorkerInspectorController.h:
(WebCore::WorkerInspectorController::hasFrontend):
- page/Console.cpp:
- page/Console.h:
- 4:55 AM Changeset in webkit [102232] by
-
- 2 edits in trunk/Tools
[Chromium] Fix project file generation for the Android bot after r102201
https://bugs.webkit.org/show_bug.cgi?id=73996
The gyp refactoring in r102201 was didn't explicitly exclude
the Android operating system in Tools/Tools.gyp, which broke
as gcc_version is not defined for that configuration.
Reviewed by Andreas Kling.
- Tools.gyp:
- 4:34 AM Changeset in webkit [102231] by
-
- 9 edits2 adds in trunk
Internals should have a method to reutrn the max sequence number of spellcheck reqeust.
https://bugs.webkit.org/show_bug.cgi?id=73511
Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-07
Reviewed by Hajime Morita.
Source/WebCore:
Internal state of SpellChecker should be able to be exposed for testing SpellChecker.
This patch will enable us to know asynchronous spellcheck has finished or not.
Test: editing/spelling/spellcheck-sequencenum.html
- editing/SpellChecker.cpp:
(WebCore::SpellChecker::SpellChecker):
(WebCore::SpellChecker::createRequest):
(WebCore::SpellChecker::didCheck):
- editing/SpellChecker.h:
(WebCore::SpellChecker::lastRequestSequence):
Interface to take SpellCheck sequence numbers.
(WebCore::SpellChecker::lastProcessedSequence): ditto.
- testing/Internals.cpp:
(WebCore::spellchecker):
(WebCore::Internals::lastSpellCheckRequestSequence):
(WebCore::Internals::lastSpellCheckProcessedSequence):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Added tests to check internals.lastSpellCheckRequestSequence and internals.lastSpellCheckProcessedSequence.
- editing/spelling/spellcheck-sequencenum-expected.txt: Added.
- editing/spelling/spellcheck-sequencenum.html: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 4:31 AM Changeset in webkit [102230] by
-
- 2 edits in trunk/Tools
Unreviewed. Disabled failing tests on chromium.
- TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
(TestWebKitAPI::TEST):
- 2:19 AM Changeset in webkit [102229] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
- platform/chromium/test_expectations.txt:
- 1:56 AM Changeset in webkit [102228] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Enable page cache.
https://bugs.webkit.org/show_bug.cgi?id=73938
Enable WebCore's page cache for Qt port by setting its capacity to 20. This is temporary
and will be replaced by a computed value based on CacheMode. See bug#73918.
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-12-07
Reviewed by Simon Hausmann.
- WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformSetCacheModel):
- 1:43 AM Changeset in webkit [102227] by
-
- 1 edit1 copy in trunk/LayoutTests
Qt rebaseline after r102149.
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from
LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
- 1:36 AM Changeset in webkit [102226] by
-
- 16 edits8 copies84 moves9 adds9 deletes in trunk/LayoutTests
Move <input type=number> tests to fast/forms/number/
https://bugs.webkit.org/show_bug.cgi?id=73987
Reviewed by Hajime Morita.
- fast/forms/ValidityState-rangeOverflow-expected.txt:
- fast/forms/ValidityState-rangeUnderflow-expected.txt:
- fast/forms/ValidityState-stepMismatch-expected.txt:
- fast/forms/ValidityState-typeMismatch-number-expected.txt: Removed.
- fast/forms/ValidityState-typeMismatch-number.html: Removed.
- fast/forms/input-appearance-number-rtl.html: Removed.
- fast/forms/input-appearance-spinbutton-disabled-readonly.html: Removed.
- fast/forms/input-appearance-spinbutton-layer.html: Removed.
- fast/forms/input-appearance-spinbutton-visibility-expected.html: Removed.
- fast/forms/input-appearance-spinbutton-visibility.html: Removed.
- fast/forms/input-number-blur-twice-expected.txt: Removed.
- fast/forms/input-number-blur-twice.html: Removed.
- fast/forms/input-number-change-type-on-focus-expected.txt: Removed.
- fast/forms/input-number-change-type-on-focus.html: Removed.
- fast/forms/input-number-commit-valid-only-expected.txt: Removed.
- fast/forms/input-number-commit-valid-only.html: Removed.
- fast/forms/input-number-crash-expected.txt: Removed.
- fast/forms/input-number-crash.html: Removed.
- fast/forms/input-number-events-expected.txt: Removed.
- fast/forms/input-number-events.html: Removed.
- fast/forms/input-number-keyoperation-expected.txt: Removed.
- fast/forms/input-number-keyoperation.html: Removed.
- fast/forms/input-number-large-padding-expected.txt: Removed.
- fast/forms/input-number-large-padding.html: Removed.
- fast/forms/input-number-outofrange-expected.txt: Removed.
- fast/forms/input-number-outofrange.html: Removed.
- fast/forms/input-number-size-expected.txt: Removed.
- fast/forms/input-number-size.html: Removed.
- fast/forms/input-number-spinbutton-crash-expected.txt: Removed.
- fast/forms/input-number-spinbutton-crash.html: Removed.
- fast/forms/input-number-unacceptable-style-expected.txt: Removed.
- fast/forms/input-number-unacceptable-style.html: Removed.
- fast/forms/input-number-wheel-expected.txt: Removed.
- fast/forms/input-number-wheel.html: Removed.
- fast/forms/input-spinbutton-capturing-expected.txt: Removed.
- fast/forms/input-spinbutton-capturing.html: Removed.
- fast/forms/input-stepup-stepdown-expected.txt:
- fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Removed.
- fast/forms/input-stepup-stepdown-from-renderer.html: Removed.
- fast/forms/input-valueasnumber-number-expected.txt: Removed.
- fast/forms/input-valueasnumber-number.html: Removed.
- fast/forms/number-input-changeevent-expected.txt: Removed.
- fast/forms/number-input-changeevent.html: Removed.
- fast/forms/number/ValidityState-rangeOverflow-number-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeOverflow-expected.txt.
- fast/forms/number/ValidityState-rangeOverflow-number.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js.
- fast/forms/number/ValidityState-rangeUnderflow-number-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeUnderflow-expected.txt.
- fast/forms/number/ValidityState-rangeUnderflow-number.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js.
- fast/forms/number/ValidityState-stepMismatch-number-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt.
- fast/forms/number/ValidityState-stepMismatch-number.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
- fast/forms/number/ValidityState-typeMismatch-number-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-number-expected.txt.
- fast/forms/number/ValidityState-typeMismatch-number.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-number.js.
- fast/forms/number/input-appearance-number-rtl.html: Copied from LayoutTests/fast/forms/input-appearance-number-rtl.html.
- fast/forms/number/input-appearance-spinbutton-disabled-readonly.html: Copied from LayoutTests/fast/forms/input-appearance-spinbutton-disabled-readonly.html.
- fast/forms/number/input-appearance-spinbutton-layer.html: Copied from LayoutTests/fast/forms/input-appearance-spinbutton-layer.html.
- fast/forms/number/input-appearance-spinbutton-visibility-expected.html: Copied from LayoutTests/fast/forms/input-appearance-spinbutton-visibility-expected.html.
- fast/forms/number/input-appearance-spinbutton-visibility.html: Copied from LayoutTests/fast/forms/input-appearance-spinbutton-visibility.html.
- fast/forms/number/input-number-blur-twice-expected.txt: Copied from LayoutTests/fast/forms/input-number-blur-twice-expected.txt.
- fast/forms/number/input-number-blur-twice.html: Copied from LayoutTests/fast/forms/input-number-blur-twice.html.
- fast/forms/number/input-number-change-type-on-focus-expected.txt: Copied from LayoutTests/fast/forms/input-number-change-type-on-focus-expected.txt.
- fast/forms/number/input-number-change-type-on-focus.html: Copied from LayoutTests/fast/forms/input-number-change-type-on-focus.html.
- fast/forms/number/input-number-commit-valid-only-expected.txt: Copied from LayoutTests/fast/forms/input-number-commit-valid-only-expected.txt.
- fast/forms/number/input-number-commit-valid-only.html: Copied from LayoutTests/fast/forms/script-tests/input-number-commit-valid-only.js.
- fast/forms/number/input-number-crash-expected.txt: Copied from LayoutTests/fast/forms/input-number-crash-expected.txt.
- fast/forms/number/input-number-crash.html: Copied from LayoutTests/fast/forms/input-number-crash.html.
- fast/forms/number/input-number-events-expected.txt: Copied from LayoutTests/fast/forms/input-number-events-expected.txt.
- fast/forms/number/input-number-events.html: Copied from LayoutTests/fast/forms/script-tests/input-number-events.js.
- fast/forms/number/input-number-keyoperation-expected.txt: Copied from LayoutTests/fast/forms/input-number-keyoperation-expected.txt.
- fast/forms/number/input-number-keyoperation.html: Copied from LayoutTests/fast/forms/script-tests/input-number-keyoperation.js.
- fast/forms/number/input-number-large-padding-expected.txt: Copied from LayoutTests/fast/forms/input-number-large-padding-expected.txt.
- fast/forms/number/input-number-large-padding.html: Copied from LayoutTests/fast/forms/input-number-large-padding.html.
- fast/forms/number/input-number-outofrange-expected.txt: Copied from LayoutTests/fast/forms/input-number-outofrange-expected.txt.
- fast/forms/number/input-number-outofrange.html: Copied from LayoutTests/fast/forms/script-tests/input-number-outofrange.js.
- fast/forms/number/input-number-size-expected.txt: Copied from LayoutTests/fast/forms/input-number-size-expected.txt.
- fast/forms/number/input-number-size.html: Copied from LayoutTests/fast/forms/input-number-size.html.
- fast/forms/number/input-number-spinbutton-crash-expected.txt: Copied from LayoutTests/fast/forms/input-number-spinbutton-crash-expected.txt.
- fast/forms/number/input-number-spinbutton-crash.html: Copied from LayoutTests/fast/forms/input-number-spinbutton-crash.html.
- fast/forms/number/input-number-unacceptable-style-expected.txt: Copied from LayoutTests/fast/forms/input-number-unacceptable-style-expected.txt.
- fast/forms/number/input-number-unacceptable-style.html: Copied from LayoutTests/fast/forms/input-number-unacceptable-style.html.
- fast/forms/number/input-number-wheel-expected.txt: Copied from LayoutTests/fast/forms/input-number-wheel-expected.txt.
- fast/forms/number/input-number-wheel.html: Copied from LayoutTests/fast/forms/script-tests/input-number-wheel.js.
- fast/forms/number/input-spinbutton-capturing-expected.txt: Copied from LayoutTests/fast/forms/input-spinbutton-capturing-expected.txt.
- fast/forms/number/input-spinbutton-capturing.html: Copied from LayoutTests/fast/forms/script-tests/input-spinbutton-capturing.js.
- fast/forms/number/input-valueasnumber-number-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-number-expected.txt.
- fast/forms/number/input-valueasnumber-number.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-number.js.
- fast/forms/number/number-input-changeevent-expected.txt: Copied from LayoutTests/fast/forms/number-input-changeevent-expected.txt.
- fast/forms/number/number-input-changeevent.html: Copied from LayoutTests/fast/forms/number-input-changeevent.html.
- fast/forms/number/number-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt.
- fast/forms/number/number-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt.
- fast/forms/number/number-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
- fast/forms/number/number-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
- fast/forms/number/spin-button-gets-disabled-or-readonly-expected.txt: Copied from LayoutTests/fast/forms/spin-button-gets-disabled-or-readonly-expected.txt.
- fast/forms/number/spin-button-gets-disabled-or-readonly.html: Copied from LayoutTests/fast/forms/spin-button-gets-disabled-or-readonly.html.
- fast/forms/script-tests/ValidityState-rangeOverflow.js:
- fast/forms/script-tests/ValidityState-rangeUnderflow.js:
- fast/forms/script-tests/ValidityState-stepMismatch.js:
- fast/forms/script-tests/ValidityState-typeMismatch-number.js: Removed.
- fast/forms/script-tests/input-number-commit-valid-only.js: Removed.
- fast/forms/script-tests/input-number-events.js: Removed.
- fast/forms/script-tests/input-number-keyoperation.js: Removed.
- fast/forms/script-tests/input-number-outofrange.js: Removed.
- fast/forms/script-tests/input-number-wheel.js: Removed.
- fast/forms/script-tests/input-spinbutton-capturing.js: Removed.
- fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed.
- fast/forms/script-tests/input-stepup-stepdown.js:
- fast/forms/script-tests/input-valueasnumber-number.js: Removed.
- fast/forms/spin-button-gets-disabled-or-readonly-expected.txt: Removed.
- fast/forms/spin-button-gets-disabled-or-readonly.html: Removed.
- platform/chromium-cg-mac-leopard/fast/forms/input-appearance-number-rtl-expected.png: Removed.
- platform/chromium-cg-mac-leopard/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
- platform/chromium-cg-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
- platform/chromium-cg-mac-leopard/fast/forms/number: Added.
- platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-appearance-number-rtl-expected.png.
- platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
- platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png.
- platform/chromium-linux/fast/forms/input-appearance-number-rtl-expected.png: Removed.
- platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
- platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
- platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
- platform/chromium-linux/fast/forms/number: Added.
- platform/chromium-linux/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-number-rtl-expected.png.
- platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
- platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt.
- platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.png.
- platform/chromium-mac-leopard/fast/forms/input-appearance-number-rtl-expected.png: Removed.
- platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
- platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
- platform/chromium-mac-leopard/fast/forms/number: Added.
- platform/chromium-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/forms/input-appearance-number-rtl-expected.png.
- platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
- platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png.
- platform/chromium-mac/fast/forms/input-appearance-number-rtl-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
- platform/chromium-mac/fast/forms/number: Added.
- platform/chromium-mac/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-appearance-number-rtl-expected.png.
- platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
- platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-appearance-spinbutton-layer-expected.png.
- platform/chromium-win/fast/forms/input-appearance-number-rtl-expected.png: Removed.
- platform/chromium-win/fast/forms/input-appearance-number-rtl-expected.txt: Removed.
- platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
- platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
- platform/chromium-win/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
- platform/chromium-win/fast/forms/input-appearance-spinbutton-layer-expected.txt: Removed.
- platform/chromium-win/fast/forms/number: Added.
- platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-number-rtl-expected.png.
- platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-number-rtl-expected.txt.
- platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
- platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt.
- platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-spinbutton-layer-expected.png.
- platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-spinbutton-layer-expected.txt.
- platform/chromium/test_expectations.txt:
- platform/efl/Skipped:
- platform/efl/fast/forms/input-appearance-number-rtl-expected.png: Removed.
- platform/efl/fast/forms/input-appearance-number-rtl-expected.txt: Removed.
- platform/efl/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
- platform/efl/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
- platform/efl/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
- platform/efl/fast/forms/input-appearance-spinbutton-layer-expected.txt: Removed.
- platform/efl/fast/forms/number: Added.
- platform/efl/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/efl/fast/forms/input-appearance-number-rtl-expected.png.
- platform/efl/fast/forms/number/input-appearance-number-rtl-expected.txt: Copied from LayoutTests/platform/efl/fast/forms/input-appearance-number-rtl-expected.txt.
- platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/efl/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
- platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/efl/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt.
- platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/efl/fast/forms/input-appearance-spinbutton-layer-expected.png.
- platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/efl/fast/forms/input-appearance-spinbutton-layer-expected.txt.
- platform/gtk/Skipped:
- platform/gtk/fast/forms/input-appearance-number-rtl-expected.png: Removed.
- platform/gtk/fast/forms/input-appearance-number-rtl-expected.txt: Removed.
- platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
- platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
- platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
- platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt: Removed.
- platform/gtk/fast/forms/number: Added.
- platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-number-rtl-expected.png.
- platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-number-rtl-expected.txt.
- platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
- platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt.
- platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.png.
- platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt.
- platform/mac/fast/forms/input-appearance-number-rtl-expected.png: Removed.
- platform/mac/fast/forms/input-appearance-number-rtl-expected.txt: Removed.
- platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
- platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
- platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
- platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt: Removed.
- platform/mac/fast/forms/number: Added.
- platform/mac/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-number-rtl-expected.png.
- platform/mac/fast/forms/number/input-appearance-number-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-number-rtl-expected.txt.
- platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
- platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt.
- platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.png.
- platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt.
- platform/qt-wk2/Skipped:
- platform/qt/Skipped:
- platform/qt/fast/forms/input-appearance-number-rtl-expected.png: Removed.
- platform/qt/fast/forms/input-appearance-number-rtl-expected.txt: Removed.
- platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
- platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
- platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.png: Removed.
- platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.txt: Removed.
- platform/qt/fast/forms/number: Added.
- platform/qt/fast/forms/number/input-appearance-number-rtl-expected.png: Copied from LayoutTests/platform/qt/fast/forms/input-appearance-number-rtl-expected.png.
- platform/qt/fast/forms/number/input-appearance-number-rtl-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/input-appearance-number-rtl-expected.txt.
- platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png.
- platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt.
- platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.png.
- platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/input-appearance-spinbutton-layer-expected.txt.
- platform/win/Skipped:
- platform/wk2/Skipped:
- 1:03 AM Changeset in webkit [102225] by
-
- 5 edits in trunk/Source/WebCore
TypingCommand duplicates code to obtain the last typing command
https://bugs.webkit.org/show_bug.cgi?id=73984
Reviewed by Kent Tamura.
Extracted lastTypingCommandIfStillOpenForTyping out of isOpenForMoreTypingCommand
and a bunch of TypingCommand static member functions.
Also made more member functions of TypingCommand private.
- editing/Editor.cpp:
(WebCore::Editor::setComposition):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelection):
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteSelection):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertLineBreak):
(WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
(WebCore::TypingCommand::insertParagraphSeparator):
(WebCore::TypingCommand::lastTypingCommandIfStillOpenForTyping):
(WebCore::TypingCommand::closeTyping):
- editing/TypingCommand.h:
(WebCore::TypingCommand::isOpenForMoreTyping):
(WebCore::TypingCommand::closeTyping):
- 12:14 AM Changeset in webkit [102224] by
-
- 1 edit1 copy in trunk/LayoutTests
Add back a file accidentally removed in r102210.
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from
LayoutTests/platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
