Timeline
Dec 9, 2011:
- 9:47 PM Changeset in webkit [102518] by
-
- 5 edits in branches/safari-534.53-branch/Source
Versioning.
- 9:34 PM Changeset in webkit [102517] by
-
- 3 edits2 adds in trunk/Source/WebCore
Add the FileSystem functions of iOS
https://bugs.webkit.org/show_bug.cgi?id=74164
Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-09
Reviewed by David Kilzer.
Two functions are needed on iOS for temporary files and directories.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- platform/ios/FileSystemIOS.h: Added.
- platform/ios/FileSystemIOS.mm: Added.
(WebCore::createTemporaryDirectory):
(WebCore::createTemporaryFile):
- 9:18 PM Changeset in webkit [102516] by
-
- 1 copy in tags/Safari-534.53.8
New tag.
- 7:03 PM Changeset in webkit [102515] by
-
- 2 edits in trunk/Source/WebCore
Remove ResourceHandle::bufferedData() from ResourceHandleBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=74197
The bufferedData() was removed in r95120.
Patch by Jacky Jiang <zhajiang@rim.com> on 2011-12-09
Reviewed by Rob Buis.
Trivial fix, so no new tests.
- platform/network/blackberry/ResourceHandleBlackBerry.cpp:
- 6:46 PM Changeset in webkit [102514] by
-
- 1 edit4 adds in trunk/Source/WebKit
Upstream BlackBerry API backing store files
https://bugs.webkit.org/show_bug.cgi?id=73668
Patch by Jacky Jiang <zhajiang@rim.com> on 2011-12-09
Reviewed by Daniel Bates.
Contributed by Torch team, the main contributor is Adam Treat
<atreat@rim.com>.
Initial upstream, no new tests.
- blackberry/Api/BackingStore.cpp: Added.
- blackberry/Api/BackingStore.h: Added.
- blackberry/Api/BackingStore_p.h: Added.
- 6:42 PM Changeset in webkit [102513] by
-
- 5 edits in branches/safari-534.53-branch/Source/WebKit2
Merge 98588.
- 6:35 PM Changeset in webkit [102512] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Prevent ASSERT in legitimate out-of-memory case.
https://bugs.webkit.org/show_bug.cgi?id=74215
Patch by Eric Penner <epenner@google.com> on 2011-12-09
Reviewed by James Robinson.
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):
- 6:29 PM Changeset in webkit [102511] by
-
- 14 edits2 adds in trunk
NameNodeListCache should be invalidated when name attribute changes/modified.
https://bugs.webkit.org/show_bug.cgi?id=70810
Patch by Arko Saha <arko@motorola.com> on 2011-12-09
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: fast/dom/getelementsbyname-invalidation-cache.html
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseMappedAttribute):
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::parseMappedAttribute):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::parseMappedAttribute):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::parseMappedAttribute):
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseMappedAttribute):
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseMappedAttribute):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseMappedAttribute):
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::parseMappedAttribute):
- html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::parseMappedAttribute):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
- html/HTMLParamElement.cpp:
(WebCore::HTMLParamElement::parseMappedAttribute):
LayoutTests:
- fast/dom/getelementsbyname-invalidation-cache-expected.txt: Added.
- fast/dom/getelementsbyname-invalidation-cache.html: Added.
- 6:26 PM Changeset in webkit [102510] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r97496-r97499): 6 fast/workers tests failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=70619
Reviewed by Alexey Proskuryakov.
- platform/mac/Skipped: Unskip various worker tests as they should work
now that bug 71695 is fixed.
- 6:15 PM Changeset in webkit [102509] by
-
- 3 edits3 adds in trunk
DFG ArithMul power-of-two case does not check for overflow
https://bugs.webkit.org/show_bug.cgi?id=74230
Source/JavaScriptCore:
Reviewed by Gavin Barraclough.
Disabled power-of-2 peephole optimization for multiplication, because it was wrong,
and any attempt to fix it would likely introduce code bloat and register pressure.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithMul):
LayoutTests:
Reviewed by Gavin Barraclough.
- fast/js/dfg-multiply-expected.txt: Added.
- fast/js/dfg-multiply.html: Added.
- fast/js/script-tests/dfg-multiply.js: Added.
(doMultiplyConstant2):
(doMultiplyConstant3):
(doMultiplyConstant4):
- 6:13 PM Changeset in webkit [102508] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r101863-r102042): Assertion hit: m_verifier.isSafeToUse() in RefCountedBase::ref in FunctionCodeBlock
https://bugs.webkit.org/show_bug.cgi?id=73886
Reviewed by Darin Adler.
- runtime/SymbolTable.h:
(JSC::SharedSymbolTable::SharedSymbolTable): Added deprecatedTurnOffVerifier for
another JavaScriptObject, since JavaScriptCore objects allow use on multiple threads.
Bug 58091 is about changing these deprecated calls to something else but that something
else will still need to be in all of these places.
- 6:06 PM Changeset in webkit [102507] by
-
- 2 edits in trunk/Source/WebKit2
Fix the Snow Leopard build some more.
Move the #if to a location where it will do some good.
- UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
- 5:59 PM Changeset in webkit [102506] by
-
- 2 edits in trunk/LayoutTests
[Gtk] Unskip two passing Shadow DOM tests
https://bugs.webkit.org/show_bug.cgi?id=74186
Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-12-09
Reviewed by Martin Robinson.
Unskip two passing tests after bug #59571 was fixed.
- platform/gtk/Skipped:
- 5:57 PM Changeset in webkit [102505] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove unnecessary file DissasemblerARM.cpp from build system
https://bugs.webkit.org/show_bug.cgi?id=74184
Patch by Konrad Piascik <kpiascik@rim.com> on 2011-12-09
Reviewed by Daniel Bates.
- PlatformBlackBerry.cmake:
- 5:54 PM Changeset in webkit [102504] by
-
- 4 edits in trunk/Source/WebKit2
Fix the Snow Leopard build.
Wrap some code that is only applicable to Lion and newer in the appropriate #if's.
- UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h:
- UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
- 5:44 PM Changeset in webkit [102503] by
-
- 2 edits in trunk/Source/WebCore
Fix Lion release build.
- platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
- 5:41 PM Changeset in webkit [102502] by
-
- 8 edits2 adds in trunk
[Qt] request parameter of QQuickWebView::navigationRequested is not a registered type
https://bugs.webkit.org/show_bug.cgi?id=73826
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-12-09
Reviewed by Tor Arne Vestbø.
.:
- Source/qtwebkit-export.map: Adding QWebNavigationRequest
Source/WebKit/qt:
- declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes): Registering QWebNavigationRequest
Source/WebKit2:
Adding QWebNavigationRequest by moving NavigationRequest out of QtWebPagePolicyClient.
- Target.pri:
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qwebnavigationrequest.cpp: Added.
(QWebNavigationRequestPrivate::QWebNavigationRequestPrivate):
(QWebNavigationRequestPrivate::~QWebNavigationRequestPrivate):
(QWebNavigationRequest::QWebNavigationRequest):
(QWebNavigationRequest::~QWebNavigationRequest):
(QWebNavigationRequest::setAction):
(QWebNavigationRequest::url):
(QWebNavigationRequest::button):
(QWebNavigationRequest::modifiers):
(QWebNavigationRequest::action):
- UIProcess/API/qt/qwebnavigationrequest_p.h: Added.
- UIProcess/qt/QtWebPagePolicyClient.cpp:
(QtWebPagePolicyClient::decidePolicyForNavigationAction):
(QtWebPagePolicyClient::decidePolicyForResponse):
- 5:39 PM Changeset in webkit [102501] by
-
- 3 edits3 adds in trunk
[FileSystem API] Entry.remove successCallback is required
https://bugs.webkit.org/show_bug.cgi?id=69639
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-12-09
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/filesystem/simple-required-arguments-remove.html
- fileapi/Entry.idl: remove [Optional] flag from Entry.remove.successCallback parameter
LayoutTests:
- fast/filesystem/resources/simple-required-arguments-remove.js: Added.
(errorCallback):
(successCallback):
- fast/filesystem/simple-required-arguments-remove-expected.txt: Added.
- fast/filesystem/simple-required-arguments-remove.html: Added.
- 5:31 PM Changeset in webkit [102500] by
-
- 2 edits7 deletes in trunk/Source/WebKit/chromium
[chromium] Remove forwarding headers for WebLayer APIs
https://bugs.webkit.org/show_bug.cgi?id=73729
Reviewed by Adam Barth.
These are no longer necessary.
- WebKit.gyp:
- public/WebContentLayer.h: Removed.
- public/WebContentLayerClient.h: Removed.
- public/WebExternalTextureLayer.h: Removed.
- public/WebLayer.h: Removed.
- public/WebLayerClient.h: Removed.
- public/WebLayerTreeView.h: Removed.
- public/WebLayerTreeViewClient.h: Removed.
- 5:28 PM Changeset in webkit [102499] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] Unskip API tests
https://bugs.webkit.org/show_bug.cgi?id=74180
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-12-09
Reviewed by Tor Arne Vestbø.
Unskip API tests for geolocation and javascript dialogs.
- UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:
- 5:26 PM Changeset in webkit [102498] by
-
- 3 edits2 adds in trunk
background-image transitions trigger between equivalent images
https://bugs.webkit.org/show_bug.cgi?id=74229
<rdar://problem/10558627>
Reviewed by Darin Adler.
Patch by Simon Fraser.
For animation property wrappers around StyleImage properties,
test the equivalence of the image itself, instead of equality of
the StyleImage pointer.
Test: transitions/equivalent-background-image-no-transition.html
- page/animation/AnimationBase.cpp:
(WebCore::StyleImagePropertyWrapper::StyleImagePropertyWrapper):
(WebCore::StyleImagePropertyWrapper::equals):
(WebCore::FillLayerStyleImagePropertyWrapper::FillLayerStyleImagePropertyWrapper):
(WebCore::FillLayerStyleImagePropertyWrapper::equals):
(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
(WebCore::AnimationBase::ensurePropertyMap):
Add a test ensuring that background-images aren't needlessly transitioned
when they are equivalent.
- transitions/equivalent-background-image-no-transition-expected.txt: Added.
- transitions/equivalent-background-image-no-transition.html: Added.
- 5:25 PM Changeset in webkit [102497] by
-
- 3 edits2 adds in trunk/Source/WebKit2
<http://webkit.org/b/74061> WebProcess and PluginProcess should inherit environment variables provided in LC_DYLD_ENVIRONMENT of main executable binary.
Reviewed by Darin Adler.
- UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h: Added.
- UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm: Added.
(WebKit::DynamicLinkerEnvironmentExtractor::DynamicLinkerEnvironmentExtractor):
(WebKit::DynamicLinkerEnvironmentExtractor::processEnvironmentVariable): Parse out the name
and value from the environment string and add an entry to our variable map if the variable
is one that dyld would respect in LC_DYLD_ENVIRONMENT.
(WebKit::DynamicLinkerEnvironmentExtractor::processLoadCommand): Look for a LC_DYLD_ENVIRONMENT
load command and extract any environment string that we find within.
(WebKit::DynamicLinkerEnvironmentExtractor::processLoadCommands): Iterate over each
load command in the Mach-O file.
(WebKit::DynamicLinkerEnvironmentExtractor::processSingleArchitecture): Determine whether
the Mach-O file is of the correct architecture, and if so then process the load commands
found within.
(WebKit::DynamicLinkerEnvironmentExtractor::processFatFile): Process each architecture of the
Mach-O file in turn.
(WebKit::DynamicLinkerEnvironmentExtractor::getExtractedEnvironmentVariables): Add our
extracted variables to the passed-in EnvironmentVariables object. We skip adding any
variables that already exist so as to allow variables passed in the environment to override
those that we extract from the executable file.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess): Extract the environment variables from the
main binary and add them to the launch environment of our subprocess.
- WebKit2.xcodeproj/project.pbxproj:
- 5:18 PM Changeset in webkit [102496] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] add accessors to WebDOMMessageEvent
https://bugs.webkit.org/show_bug.cgi?id=73346
Patch by Karl Koscher <supersat@chromium.org> on 2011-12-09
Reviewed by Darin Fisher.
- public/WebDOMMessageEvent.h:
- src/WebDOMMessageEvent.cpp:
(WebKit::WebDOMMessageEvent::data):
(WebKit::WebDOMMessageEvent::origin):
- 5:17 PM WebKit Team edited by
- (diff)
- 5:15 PM WebKit Team edited by
- (diff)
- 5:09 PM Changeset in webkit [102495] by
-
- 8 edits in trunk/Source/WebKit/chromium
[chromium] add event methods to WebFrame
https://bugs.webkit.org/show_bug.cgi?id=73259
Patch by Karl Koscher <supersat@chromium.org> on 2011-12-09
Reviewed by Darin Fisher.
- public/WebDOMEventListener.h: Use EventTarget instead of Node
- public/WebFrame.h: Add event methods
- src/WebDOMEventListener.cpp: Use EventTarget instead of Node
(WebKit::WebDOMEventListener::createEventListenerWrapper):
(WebKit::WebDOMEventListener::getEventListenerWrapper):
- src/WebDOMEventListenerPrivate.cpp: Use EventTarget instead of Node
(WebKit::WebDOMEventListenerPrivate::createEventListenerWrapper):
(WebKit::WebDOMEventListenerPrivate::getEventListenerWrapper):
- src/WebDOMEventListenerPrivate.h: Use EventTarget instead of Node
(WebKit::WebDOMEventListenerPrivate::ListenerInfo::ListenerInfo):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::addEventListener): register a listener on a WebFrame
(WebKit::WebFrameImpl::removeEventListener): remove a listener on a WebFrame
(WebKit::WebFrameImpl::dispatchEvent): dispatch an event to a WebFrame
- src/WebFrameImpl.h: Add event methods
- 5:05 PM Changeset in webkit [102494] by
-
- 2 edits in trunk/Source/WebKit2
Add WKView implementation for quickLookPreviewItemsAtWindowLocation.
<rdar://problem/10472505>
Reviewed by Dan Bernstein.
- UIProcess/API/mac/WKView.mm:
(-[WKView quickLookPreviewItemsAtWindowLocation:]):
- 5:01 PM Changeset in webkit [102493] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Open shared memory files with shm_open.
https://bugs.webkit.org/show_bug.cgi?id=74078
Original patch by Kimmo Kinnunen
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2011-12-09
Reviewed by Kenneth Rohde Christiansen.
Open shared memory files with shm_open. This uses mount point that is
intended to host shared memory files. Typically this is /dev/shm.
This fixes crashes when filesystem that hosts QDir::temp() is full.
This is also more well-defined with respect to question whether SHM
writes to temp dir would cause unintended wear if hosted on flash drives.
This also fixes performance problems regarding QDir::temp() and
mkostemp(), both of which appear to be long operations.
- Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::create):
- 5:01 PM Changeset in webkit [102492] by
-
- 2 edits in trunk/Source/WebCore
Small style fix on DragDataBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=74171
Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-09
Reviewed by Rob Buis.
Style fix, no function impact, no new tests.
- platform/blackberry/DragDataBlackBerry.cpp:
(WebCore::DragData::containsURL):
(WebCore::DragData::asFilenames):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
- 4:47 PM Changeset in webkit [102491] by
-
- 10 edits in trunk/LayoutTests
Fix test expectations from r102486: flex-flow returns direction and wrap now.
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium/svg/css/getComputedStyle-basic-expected.txt:
- platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 4:41 PM Changeset in webkit [102490] by
-
- 4 edits in trunk
chromium win build: revert build_webkit_exes_from_webkit_gyp change
https://bugs.webkit.org/show_bug.cgi?id=74225
Source/WebKit/chromium:
Reviewed by Tony Chang.
This change sets build_webkit_exes_from_webkit_gyp back to 1;
the "All.gyp" solution doesn't work on windows.
- gyp_webkit:
Tools:
This change sets build_webkit_exes_from_webkit_gyp back to 1;
the "All.gyp" solution doesn't work on windows.
- Scripts/webkitdirs.pm:
(buildChromium):
- 4:09 PM Changeset in webkit [102489] by
-
- 8 edits in trunk/Source/JavaScriptCore
DFG's interpretation of rare case profiles should be frequency-based not count-based
https://bugs.webkit.org/show_bug.cgi?id=74170
Reviewed by Geoff Garen.
DFG optimizes for rare cases only when the rare case counter is above some threshold
and it also constitutes a large enough fraction of total function executions. Also
added some minor debug logic.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
(JSC::CodeBlock::executionEntryCount):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
- runtime/Heuristics.h:
- 3:53 PM Changeset in webkit [102488] by
-
- 8 edits in trunk
[Qt] Click's count is limited to three continuous clicks.
https://bugs.webkit.org/show_bug.cgi?id=45666
Patch by Hugo Parente Lima <Hugo Parente Lima> on 2011-12-09
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Make Qt recognize "infinite" continuous mouse clicks.
handleMouseDoubleClickEvent merged into handleMousePressEvent.
- UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::QtWebPageEventHandler):
(QtWebPageEventHandler::handleEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::timerEvent):
- UIProcess/qt/QtWebPageEventHandler.h:
Tools:
Update m_time at every call to leapForward, so double clicks
event are correctly sent by EventSender.
- WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::updateClickCountForButton):
(WTR::EventSenderProxy::leapForward):
LayoutTests:
Enable fast/events/click-count.html for qt and disable for qt-wk1.
- platform/qt-wk1/Skipped:
- platform/qt/Skipped:
- 3:50 PM Changeset in webkit [102487] by
-
- 2 edits in trunk/Tools
[Refactoring] Reduce top-level code in prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=74172
Reviewed by Ryosuke Niwa.
The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
This requires to remove top-level code. This patch is one of the incremental refactorings
for that.
- Scripts/prepare-ChangeLog: Moved some top-level code into generateFunctionLists().
(generateFunctionLists):
- 3:50 PM Changeset in webkit [102486] by
-
- 13 edits in trunk
add css parsing for flex-flow: wrap and wrap-reverse
https://bugs.webkit.org/show_bug.cgi?id=74008
Patch by Tony Chang <tony@chromium.org> on 2011-12-09
Reviewed by Ojan Vafai.
Source/WebCore:
Also save 2 bits in StyleFlexibleBoxData by changing the size of m_flexFlow (there are only 4 enum values).
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Print the wrap value if it exists.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Parse a second token and put the values into a CSSValueList.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexWrap):
- css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyFlexFlow::applyInheritValue): Does not inherit.
(WebCore::ApplyPropertyFlexFlow::applyInitialValue):
(WebCore::ApplyPropertyFlexFlow::applyValue): Special handler for setting two render style values from one
CSS property.
(WebCore::ApplyPropertyFlexFlow::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSValueKeywords.in:
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::flexWrap):
(WebCore::InheritedFlags::setFlexWrap):
(WebCore::InheritedFlags::initialFlexWrap):
- rendering/style/RenderStyleConstants.h: EFlexWrap to hold flex wrap values.
- rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
- rendering/style/StyleFlexibleBoxData.h: 2 bits is enough to hold the 4 flexFlow values.
LayoutTests:
- css3/flexbox/css-properties-expected.txt:
- css3/flexbox/script-tests/css-properties.js: Test call combinations of flex-flow values.
- 3:47 PM Changeset in webkit [102485] by
-
- 2 edits in trunk/Source/JavaScriptCore
PutByValAlias unnecessarily clobbers GetIndexedPropertyStorage
https://bugs.webkit.org/show_bug.cgi?id=74223
Reviewed by Geoffrey Garen.
Don't clobber GetIndexedPropertyStorage when we see PutByValAlias
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::getIndexedPropertyStorageLoadElimination):
- 3:45 PM Changeset in webkit [102484] by
-
- 13 edits2 adds in trunk
Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
https://bugs.webkit.org/show_bug.cgi?id=74218
Reviewed by Anders Carlsson.
Source/WebKit2:
Test: WebKit2.WKConnectionTest in TestWebKitAPI
- Shared/WebConnection.cpp:
(WebKit::WebConnection::forwardDidReceiveMessageToClient):
- Shared/WebConnection.h:
Add helper for connection subclasses to dispatch to the client.
- UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::didReceiveMessage):
Handle postMessage messages from the WebProcess.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::processDidFinishLaunching):
Dispatch the notification that a connection to the WebProcess has
been established.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleGetApplicationConnection):
- WebProcess/InjectedBundle/API/c/WKBundle.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::webConnectionToUIProcess):
- WebProcess/InjectedBundle/InjectedBundle.h:
(WebKit::WebProcess::webConnectionToUIProcess):
Add accessor to get the connection to the UIProcess from
the bundle.
- WebProcess/WebConnectionToUIProcess.cpp:
(WebKit::WebConnectionToUIProcess::didReceiveMessage):
Handle postMessage messages from the UIProcess.
- WebProcess/WebProcess.h:
Tools:
Add a test of the WKConnectionRef API.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Added.
(TestWebKitAPI::didCreateConnection):
(TestWebKitAPI::connectionDidReceiveMessage):
(TestWebKitAPI::connectionDidClose):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Added.
(TestWebKitAPI::connectionDidReceiveMessage):
(TestWebKitAPI::WKConnectionTest::WKConnectionTest):
(TestWebKitAPI::WKConnectionTest::initialize):
- 3:43 PM Changeset in webkit [102483] by
-
- 6 edits1 add in trunk
Hash* iterators should allow comparison between const and const versions.
https://bugs.webkit.org/show_bug.cgi?id=73370
Reviewed by Darin Adler.
Source/JavaScriptCore:
- wtf/HashTable.h: Add the operators needed to do this.
(WTF::HashTableConstIterator::operator==):
(WTF::HashTableConstIterator::operator!=):
(WTF::HashTableIterator::operator==):
(WTF::HashTableIterator::operator!=):
(WTF::operator==):
(WTF::operator!=):
Tools:
- TestWebKitAPI/TestWebKitAPI.gypi: Add the new test file to the build.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
- TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
- TestWebKitAPI/Tests/WTF/HashMap.cpp: Added.
(TestWebKitAPI::TEST): Add a test for the new functionality.
- 3:39 PM Changeset in webkit [102482] by
-
- 3 edits1 move in trunk
chromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
https://bugs.webkit.org/show_bug.cgi?id=74212
Reviewed by Tony Chang.
The change introduced in r102201 to split the executables out of
WebKit.gyp apparently doesn't work right on Windows, since
WebKit.gyp and Tools.gyp refer to dependent projects by
different relative paths (it appears gyp doesn't normalize the
paths). This change moves Tools.gyp to be in the same directory
as WebKit.gyp (and All.gyp), which should fix this and
conveniently will also solve the problem of how to add Tools.gyp
to the chromium DEPS file.
Source/WebKit/chromium:
- All.gyp:
- Tools.gyp: Renamed from ../../../Tools/Tools.gyp.
Tools:
- Tools.gyp: Renamed to ../Source/WebKit/chromium/Tools.gyp
- 3:26 PM Changeset in webkit [102481] by
-
- 2 edits in trunk/Tools
[Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description from URL into a method
https://bugs.webkit.org/show_bug.cgi?id=74173
Reviewed by Ryosuke Niwa.
The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
This requires to remove top-level code. This patch is one of the incremental refactorings
for that.
- Scripts/prepare-ChangeLog: Moved top-level code to fetch a bug description from URL into fetchBugDescriptionFromURL().
(fetchBugDescriptionFromURL):
- 3:26 PM Changeset in webkit [102480] by
-
- 2 edits2 adds in trunk/Source/WebCore
[EFL] Add RefPtrEfl specialization for evas_object.
https://bugs.webkit.org/show_bug.cgi?id=73790
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-12-09
Reviewed by Ryosuke Niwa.
As evas_object is also based on reference count, RefPtr is applied for evas_object.
- PlatformEfl.cmake:
- platform/efl/RefPtrEfl.cpp: Added.
(WTF::refIfNotNull):
(WTF::derefIfNotNull):
- platform/efl/RefPtrEfl.h: Added.
- 3:23 PM Changeset in webkit [102479] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(102234): 2-3% layout regression
https://bugs.webkit.org/show_bug.cgi?id=74141
Reviewed by David Hyatt.
Don't allocate a RuleSet when there are no regions.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initForRegionStyling):
- 3:21 PM Changeset in webkit [102478] by
-
- 2 edits in trunk/Source/WebCore
Fix assertion failure in ScrollAnimatorMac
https://bugs.webkit.org/show_bug.cgi?id=74222
Reviewed by Andreas Kling.
- platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
This can be called with a nil scrollerImp, just return NSZeroPoint when that happens.
- 2:48 PM Changeset in webkit [102477] by
-
- 1 edit2 adds in trunk/LayoutTests
[MutationObservers] Add test for deliver-at-end-of-task semantics
https://bugs.webkit.org/show_bug.cgi?id=74190
Reviewed by Ojan Vafai.
The addition of eventSender.scheduleAsynchronousKeyDown in r102424
allows testing the code added in r101842 and http://crrev.com/113010.
Added a test using a contentEditable element and an onblur event
handler that asserts it fires after mutations due to editing have been
delivered.
- fast/mutation/end-of-task-delivery-expected.txt: Added.
- fast/mutation/end-of-task-delivery.html: Added.
- 2:48 PM Changeset in webkit [102476] by
-
- 5 edits in trunk/Source/WebCore
Move the "is currently drawing into layer" flag out into ScrollbarThemeMac
https://bugs.webkit.org/show_bug.cgi?id=74217
Reviewed by Beth Dakin.
There's no need to store this flag inside ScrollAnimatorMac, just make it a global and put it in ScrollbarThemeMac instead.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate layer]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
- platform/mac/ScrollbarThemeMac.h:
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::isCurrentlyDrawingIntoLayer):
(WebCore::ScrollbarThemeMac::paint):
- 2:42 PM Changeset in webkit [102475] by
-
- 2 edits in trunk/Source/JavaScriptCore
YARR: Multi-character read optimization for 8bit strings
https://bugs.webkit.org/show_bug.cgi?id=74191
Reviewed by Oliver Hunt.
Changed generatePatternCharacterOnce to generate
code for 1 to 4 characters in the 8 bit case.
This is worth 29% improvement on SunSpider regexp-dna test.
It provides no benefit to v8-regexp.
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generate): Spelling fix in comment.
- 2:07 PM Changeset in webkit [102474] by
-
- 2 edits in trunk/Source/WebCore
Minor cleanup in ScrollAnimatorMac.mm
https://bugs.webkit.org/show_bug.cgi?id=74211
Reviewed by Andreas Kling.
- platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
No need to get the scrollbar from the scroll animator anymore.
(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
Try to get data from the scrollbar and/or the scrollable area instead of the scrollbar painter.
- 2:05 PM Changeset in webkit [102473] by
-
- 8 edits1 add in trunk
Regression(r53595): Sync xhr requests in workers aren't terminated on worker close.
https://bugs.webkit.org/show_bug.cgi?id=71695
Reviewed by Zoltan Herczeg.
Source/JavaScriptCore:
- wtf/MessageQueue.h:
(WTF::MessageQueue::tryGetMessageIgnoringKilled): Added a way to get messages
even after the queue has been killed. This is useful when one wants to
kill a queue but then go through it to run clean up tasks from it.
Source/WebCore:
Overview: Message loops rely on the message queue being killed in order
to exit. r53595 stopped this from happening because killing a message loop
would also stop it from doing database clean up tasks. The database clean up
tasks needed to be tasks due to ordering issues. (They wanted to run after
certain order tasks were run.) This was solved by once again terminating
the message queue but then still runnning clean-up tasks from the killed
message queue.
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::run): Added the call to run clean-up tasks.
(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::runCleanupTasks): Loop to simply clear out all clean up tasks.
(WebCore::WorkerRunLoop::Task::performTask): Stop non-clean up tasks
from running after the loop has been terminated.
- workers/WorkerRunLoop.h:
(WebCore::WorkerRunLoop::terminated): Just made it const.
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownFinishTask::performTask): Removed
the terminate clause since it was put back in stop.
(WebCore::WorkerThread::stop): Terminate the run loop so
that all loops will exit and clean up tasks will run. Also removed a comment
about nested workers because nested workers are no longer imminent and the
issue mentioned is one of many that should logically be investigated -- behavior correctness
in the face of different orderings of shutdown between the document and each worker --
when implementing them.
LayoutTests:
- http/tests/workers/resources/worker-util.js: Added.
Copied from fast/workers/resources/worker-util.js
- http/tests/xmlhttprequest/workers/abort-exception-assert.html:
Make the test wait for all workers to exit before finishing.
- 1:41 PM Changeset in webkit [102472] by
-
- 6 edits1 delete in trunk/Source/WebCore
Unreviewed, rolling out r102416.
http://trac.webkit.org/changeset/102416
https://bugs.webkit.org/show_bug.cgi?id=73394
Chromium Win clobber builds are failing.
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/scripts/action_derivedsourcesallinone.py:
(main):
- WebCore.gypi:
- bindings/scripts/generate-bindings.pl:
- page/DOMWindow.idl:
- webaudio/DOMWindowWebAudio.idl: Removed.
- 1:32 PM Changeset in webkit [102471] by
-
- 18 edits7 adds in trunk
JSC wrappers for TextTrack and TextTrackCue should not be collected during event dispatch or when owner is reachable
https://bugs.webkit.org/show_bug.cgi?id=72179
Reviewed by Geoff Garen.
Source/WebCore:
Tests: media/track/text-track-cue-is-reachable.html
media/track/text-track-is-reachable.html
- GNUmakefile.list.am: Add JSTextTrackCueCustom.cpp and JSTextTrackCustom.cpp.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto
- bindings/js/JSBindingsAllInOne.cpp: Ditto.
- bindings/js/JSTextTrackCueCustom.cpp: Added.
(WebCore::JSTextTrackCueOwner::isReachableFromOpaqueRoots): New.
(WebCore::JSTextTrackCueOwner::visitChildren): New.
- bindings/js/JSTextTrackCustom.cpp: Added.
(WebCore::JSTextTrackOwner::isReachableFromOpaqueRoots): New.
(WebCore::JSTextTrack::visitChildren): New, mark all cues.
- bindings/js/JSTextTrackCustom.h: Added.
(WebCore::root): New.
- bindings/js/JSTextTrackListCustom.cpp:
(WebCore::JSTextTrackList::visitChildren): New, mark all tracks.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::trackWillBeRemoved): TextTracks::remove now takes a TextTrack*.
- html/LoadableTextTrack.h:
(WebCore::LoadableTextTrack::trackElement): New, return the <track>.
- html/TextTrack.cpp:
(WebCore::TextTrack::TextTrack): Initialize m_mediaElement.
- html/TextTrack.h:
(WebCore::TextTrack::setMediaElement): New.
(WebCore::TextTrack::mediaElement): Ditto.
- html/TextTrack.idl: Add CustomIsReachable and CustomMarkFunction.
- html/TextTrackCue.idl: Add CustomIsReachable.
- html/track/TextTrackList.cpp:
(TextTrackList::append): Set track's media element.
(TextTrackList::remove): Clear track's media element. Take a raw ptr, not a PassRefPtr.
- html/track/TextTrackList.h:
- html/track/TextTrackList.idl: Add CustomMarkFunction
LayoutTests:
- media/track/text-track-cue-is-reachable-expected.txt: Added.
- media/track/text-track-cue-is-reachable.html: Added.
- media/track/text-track-is-reachable-expected.txt: Added.
- media/track/text-track-is-reachable.html: Added.
- platform/chromium/test_expectations.txt:
- 1:25 PM Changeset in webkit [102470] by
-
- 3 edits2 adds in trunk
WebKit should ignore images with @alt matching only whitespace
https://bugs.webkit.org/show_bug.cgi?id=74189
Reviewed by Darin Adler.
Source/WebCore:
Test: accessibility/img-alt-tag-only-whitespace.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
LayoutTests:
- accessibility/img-alt-tag-only-whitespace.html: Added.
- platform/mac/accessibility/img-alt-tag-only-whitespace-expected.txt: Added.
- 1:25 PM Changeset in webkit [102469] by
-
- 2 edits in trunk/Source/WebCore
Remove NSAnimationContext calls
https://bugs.webkit.org/show_bug.cgi?id=74207
Reviewed by Sam Weinig.
NSAnimationContext is not used for NSAnimation subclasses, so the calls to beginGrouping/endGrouping and setDuration:
are essentially no-ops. Remove them.
- platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
- 1:16 PM Changeset in webkit [102468] by
-
- 2 edits in trunk/Source/WebCore
Rename scrollAnimatorDestroyed to invalidate
https://bugs.webkit.org/show_bug.cgi?id=74206
Reviewed by Sam Weinig.
Since these methods can be called when both scrollbars are destroyed and the scroll animator itself is
destroyed, rename it to something more neutral.
- platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollAnimationHelperDelegate invalidate]):
(-[WebScrollbarPartAnimation invalidate]):
(-[WebScrollbarPainterDelegate invalidate]):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
- 1:08 PM Changeset in webkit [102467] by
-
- 2 edits in trunk/Source/WebCore
WebScrollbarPainterControllerDelegate should know about the ScrollableArea, not the ScrollAnimatorMac
https://bugs.webkit.org/show_bug.cgi?id=74204
Reviewed by Sam Weinig.
It makes more logical sense to associate the WebScrollbarPainterControllerDelegate object with its ScrollableArea, since
painting has nothing to do with animation.
- platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterControllerDelegate initWithScrollableArea:]):
(-[WebScrollbarPainterControllerDelegate invalidate]):
(-[WebScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
(-[WebScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
(-[WebScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
(-[WebScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[WebScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
- 12:52 PM Changeset in webkit [102466] by
-
- 2 edits in trunk/Source/WebCore
[JSC] Allow cached attributes in bindings that declare a custom mark function
https://bugs.webkit.org/show_bug.cgi?id=74187
Reviewed by Oliver Hunt.
No new tests, current binding tests are sufficient.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- 12:36 PM Changeset in webkit [102465] by
-
- 3 edits in trunk/Tools
Switch the chromium mac bots to using skia test results
https://bugs.webkit.org/show_bug.cgi?id=74201
Reviewed by Ryosuke Niwa.
This is reverting http://trac.webkit.org/changeset/97781 and changing
the name in master.cfg to no longer have cg in the name.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(appendCustomBuildFlags):
(RunWebKitTests.start):
- 12:35 PM Changeset in webkit [102464] by
-
- 7 edits2 copies in branches/chromium/963
Merge 102405 - Source/WebCore: Improve handling of frame removal during requestAnimationFrame callback invocation
https://bugs.webkit.org/show_bug.cgi?id=74036
Reviewed by Adam Barth.
See bug for details.
Test: fast/animation/request-animation-frame-detach-element.html
- dom/Document.cpp:
(WebCore::Document::removedLastRef):
(WebCore::Document::detach):
- dom/Document.h:
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::~ScriptedAnimationController):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::scheduleAnimation):
- dom/ScriptedAnimationController.h:
(WebCore::ScriptedAnimationController::create):
(WebCore::ScriptedAnimationController::clearDocumentPointer):
- page/FrameView.cpp:
(WebCore::FrameView::serviceScriptedAnimations):
LayoutTests: Add some tests for removing frames from the document while servicing requestAnimationFrame callbacks
https://bugs.webkit.org/show_bug.cgi?id=74036
Reviewed by Adam Barth.
- fast/animation/request-animation-frame-detach-element-expected.txt: Added.
- fast/animation/request-animation-frame-detach-element.html: Added.
BUG=106672
TBR=jamesr@google.com
Review URL: http://codereview.chromium.org/8899006
- 12:33 PM Changeset in webkit [102463] by
-
- 7 edits2 copies in branches/chromium/912
Merge 102405 - Source/WebCore: Improve handling of frame removal during requestAnimationFrame callback invocation
https://bugs.webkit.org/show_bug.cgi?id=74036
Reviewed by Adam Barth.
See bug for details.
Test: fast/animation/request-animation-frame-detach-element.html
- dom/Document.cpp:
(WebCore::Document::removedLastRef):
(WebCore::Document::detach):
- dom/Document.h:
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::~ScriptedAnimationController):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::scheduleAnimation):
- dom/ScriptedAnimationController.h:
(WebCore::ScriptedAnimationController::create):
(WebCore::ScriptedAnimationController::clearDocumentPointer):
- page/FrameView.cpp:
(WebCore::FrameView::serviceScriptedAnimations):
LayoutTests: Add some tests for removing frames from the document while servicing requestAnimationFrame callbacks
https://bugs.webkit.org/show_bug.cgi?id=74036
Reviewed by Adam Barth.
- fast/animation/request-animation-frame-detach-element-expected.txt: Added.
- fast/animation/request-animation-frame-detach-element.html: Added.
BUG=106672
TBR=jamesr@google.com
Review URL: http://codereview.chromium.org/8894015
- 12:15 PM Changeset in webkit [102462] by
-
- 2 edits in trunk/Source/WebCore
Remove duplicate animation ivars
https://bugs.webkit.org/show_bug.cgi?id=74194
Reviewed by Sam Weinig.
Since we now have one WebScrollbarPainterDelegate for each scrollbar, we no longer need separate
vertical/horizontal animation objects, so get rid of them.
- platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate cancelAnimations]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):
- 11:48 AM Changeset in webkit [102461] by
-
- 2 edits in trunk/LayoutTests
Try to deflake a repaint test on Chromium. It looks like we're
calling lTC.display() before the inital layout. Force a layout
before calling lTC.display().
Reviewed by Ojan Vafai.
- fast/replaced/width100percent-textarea.html:
- 11:34 AM Changeset in webkit [102460] by
-
- 2 edits in trunk/Source/WebCore
WebScrollbarPartAnimation should only know about the scrollbar it's animating
https://bugs.webkit.org/show_bug.cgi?id=74192
Reviewed by Sam Weinig.
- platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPartAnimation initWithScrollbar:featureToAnimate:animateFrom:animateTo:duration:]):
Change the designated initializer to just take the scrollbar. Also, make the animation non-blocking here
so we don't have to do it in all the call sites.
(-[WebScrollbarPartAnimation startAnimation]):
Update the scrollbar painter.
(-[WebScrollbarPartAnimation setCurrentProgress:]):
Just invalidate the scrollbar we're animating.
(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
Update call sites to use the new designated initializer.
- 10:59 AM Changeset in webkit [102459] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix HashMap<..., OwnPtr<...> >::add compilation errors
https://bugs.webkit.org/show_bug.cgi?id=74159
Reviewed by Darin Adler.
Add a constructor to OwnPtr that takes the empty value (nullptr_t)
from HashTraits so that this function can compile.
- wtf/OwnPtr.h:
(WTF::OwnPtr::OwnPtr):
- 9:52 AM Changeset in webkit [102458] by
-
- 2 edits in trunk/LayoutTests
[chromium] Update test_expectations.txt to match the bots.
- platform/chromium/test_expectations.txt:
- 9:40 AM Changeset in webkit [102457] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Update WebGraphicLayer's child content scale in all child binding method.
https://bugs.webkit.org/show_bug.cgi?id=74101
Reviewed by Noam Rosenthal.
setChildren is currently the only method propagating the parent layer's content
scale to its children. This need to be done for addChild* as well.
This fixes the overlay layer not being rendered with the right scale when created
until the contents scale is modified again.
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
- 9:38 AM Changeset in webkit [102456] by
-
- 2 edits in trunk/Source/WebCore
Inspector: Don't translate the context when rendering the highlights on a tiled layer.
https://bugs.webkit.org/show_bug.cgi?id=74085
Reviewed by Kenneth Rohde Christiansen.
When the frame view is using fixed layouting, the page overlay is the size of the whole
page and the context shouldn't be translated. The visible rect is still used in that
case to display element titles within the visible rect.
Also:
- Rename overlayRect to visibleRect to reduce confusion in this case.
- Remove the superfluous boundingBox check.
- inspector/DOMNodeHighlighter.cpp:
- 9:35 AM Changeset in webkit [102455] by
-
- 2 edits in trunk/Tools
[Qt] Remove a wrongly placed ASSERT.
Reviewed by Tor Arne Vestbø.
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify):
- 8:50 AM BuildingQt5OnHarmattan edited by
- Write down some way that works with current qt5 master. (diff)
- 8:18 AM Changeset in webkit [102454] by
-
- 6 edits in trunk
Source/WebKit/chromium: Chromium DEPS roll to pick up new use_skia=1 default on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=74118
Reviewed by Adam Barth.
- DEPS:
Tools: layout_test update to accommodate new use_skia=1 default on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=74118
Reviewed by Adam Barth.
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
(get):
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort.init):
- Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.test_versions):
(ChromiumMacPortTest.test_graphics_type):
- 7:19 AM Changeset in webkit [102453] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] Fix tst_QQuickWebView::scrollRequest() API test
https://bugs.webkit.org/show_bug.cgi?id=73994
Patch by Michael Brüning <michael.bruning@nokia.com> on 2011-12-09
Reviewed by Kenneth Rohde Christiansen.
- UIProcess/API/qt/tests/html/scroll.html: Corrected html and
added some coloring.
- UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::scrollRequest): Corrected calculation
of expected value.
- 6:48 AM Changeset in webkit [102452] by
-
- 2 edits in trunk/Tools
[Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake
The GNUmake + gcc_MD_depends options together produce .d files using GCC, but
this failed when moving files in the source tree, as the .d file would contain
stale dependencies on the old source file location. By keeping the object files
(and hence the depdendency files) in a proper tree structure inside the objects
directory we can prevent this failure.
A side benefit is that we can also have objects with the same name inside the
same project.
Reviewed by Simon Hausmann.
- 6:01 AM Changeset in webkit [102451] by
-
- 2 edits in trunk/Tools
Unreviewed. Update unit test after r102412.
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_whois):
- 3:59 AM QtWebKitBuildBots edited by
- Update Qt5 revision (diff)
- 3:49 AM Changeset in webkit [102450] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed inspector utilities syntax fix.
- inspector/front-end/utilities.js:
():
- 2:56 AM WebKit Team edited by
- (diff)
- 2:23 AM Changeset in webkit [102449] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, chromium test expectation update.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-09
- platform/chromium/test_expectations.txt:
- 1:40 AM Changeset in webkit [102448] by
-
- 15 edits3 adds in trunk
[GTK] Initial implementation of Accelerated Compositing using Clutter
https://bugs.webkit.org/show_bug.cgi?id=73319
.:
Reviewed by Gustavo Noronha Silva.
- GNUmakefile.am: Export new compilation macros.
- configure.ac: Add clutter backend for Accelerated Compositing.
Source/WebCore:
Reviewed by Gustavo Noronha Silva.
No new tests added as this feature will be able to reuse the existing
CSS3 transforms layout tests.
- GNUmakefile.am: Include WebCore/platform/graphics/clutter path.
- GNUmakefile.list.am: Add GraphicsLayerClutter.
- platform/clutter/GRefPtrClutter.cpp: Added.
(WTF::adoptGRef):
(WTF::ClutterActor):
- platform/clutter/GRefPtrClutter.h: Added.
- platform/graphics/GraphicsLayer.h: Define PlatformLayer type, which represents ClutterActor.
- platform/graphics/clutter/GraphicsLayerClutter.cpp: Boilerplate implementation.
(WebCore::GraphicsLayerClutter::GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::platformLayer):
- platform/graphics/clutter/GraphicsLayerClutter.h: Boilerplate implementation.
Source/WebKit/gtk:
This patch allows to add a GtkClutterEmbed to embed Clutter Actors in WebKitWebView and
set the root GraphicsLayer to WebKitWebView when Accelerated Compositing needs to be enabled.
Reviewed by Gustavo Noronha Silva.
- GNUmakefile.am:
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::attachRootGraphicsLayer): Set the root GraphicsLayer to WebKitWebView.
(WebKit::ChromeClient::allowedCompositingTriggers): Allow to support CSS 3D Transforms only.
- webkit/webkitglobals.cpp:
(webkitInit): Call gtk_clutter_init().
- webkit/webkitwebview.cpp:
(webkit_web_view_size_allocate): Set the size of GtkClutterEmbed when the view is changed.
(webkit_web_view_init)
(webViewSetRootGraphicsLayer): Add the GtkClutterEmbed to the WebKitWebView as a child.
(webViewDetachRootGraphicsLayer): Remove the GtkClutterEmbed from the WebKitWebView.
(webViewSyncLayers): Commit layer changes.
(webViewMarkForSync): Set to call webViewSyncLayers using g_timeout_add.
- webkit/webkitwebviewprivate.h:
- 1:25 AM Changeset in webkit [102447] by
-
- 4 edits2 adds in trunk
Web Inspector: Introduce a Map class allowing to store values indexed by arbitrary objects.
https://bugs.webkit.org/show_bug.cgi?id=74084
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/map.html
- inspector/front-end/treeoutline.js:
(TreeOutline):
():
(TreeElement.prototype.collapse):
(TreeElement.prototype.expand):
- inspector/front-end/utilities.js:
():
LayoutTests:
- inspector/map-expected.txt: Added.
- inspector/map.html: Added.
- 1:15 AM Changeset in webkit [102446] by
-
- 2 edits in trunk/Tools
REGRESSION(r102105): run-bindings-tests should output full diff results
https://bugs.webkit.org/show_bug.cgi?id=74166
Reviewed by Adam Barth.
Since r102105, the output of run-bindings-tests is truncated to 500 characters.
run-bindings-tests should output full diff results.
- Scripts/webkitpy/bindings/main.py: Replaced e.message_with_output() with e.output.
(BindingsTests.generate_from_idl):
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.detect_changes):
- 1:11 AM Changeset in webkit [102445] by
-
- 16 edits in trunk
[Qt] Fix compilation with newly separated Qt 5 QtQuick module
https://bugs.webkit.org/show_bug.cgi?id=73990
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2011-12-09
Reviewed by Kenneth Rohde Christiansen, tweaked by Csaba Osztrogonác.
Fix QtQuick includes after move from QtDeclarative to QtQuick.
Source/WebKit2:
- UIProcess/API/qt/qquickwebpage.cpp:
- UIProcess/API/qt/qquickwebpage_p.h:
- UIProcess/API/qt/qquickwebview.cpp:
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/tests/tests.pri: Tests need symbols from QtQuick, so link library.
- UIProcess/API/qt/tests/testwindow.h:
- UIProcess/qt/QtDialogRunner.cpp:
- UIProcess/qt/QtSGTileNode.cpp:
- UIProcess/qt/QtSGTileNode.h:
- UIProcess/qt/QtSGUpdateQueue.cpp:
- UIProcess/qt/QtViewportInteractionEngine.cpp:
- UIProcess/qt/QtWebPageProxy.cpp:
- UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:
Tools:
- MiniBrowser/qt/BrowserWindow.h:
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
- 1:02 AM Changeset in webkit [102444] by
-
- 2 edits in trunk/Source/WebKit2
[WebKit2][gtk] Re-enable running TestWebKitSettings
https://bugs.webkit.org/show_bug.cgi?id=70135
Reviewed by Martin Robinson.
Re-enable running TestWebKitSettings which was skipped as part
of https://bugs.webkit.org/show_bug.cgi?id=70129 due to the
bug https://bugs.webkit.org/show_bug.cgi?id=70127.
- UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings): Run testWebKitSettings.
(testWebKitSettingsNewWithSettings): Run testWebKitSettingsNewWithSettings.
- 12:53 AM Changeset in webkit [102443] by
-
- 1 edit14 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Add Qt specific expected results.
- platform/qt/animations/cross-fade-background-image-expected.png: Added.
- platform/qt/animations/cross-fade-background-image-expected.txt: Added.
- platform/qt/animations/cross-fade-border-image-source-expected.png: Added.
- platform/qt/animations/cross-fade-border-image-source-expected.txt: Added.
- platform/qt/animations/cross-fade-list-style-image-expected.png: Added.
- platform/qt/animations/cross-fade-list-style-image-expected.txt: Added.
- platform/qt/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
- platform/qt/animations/cross-fade-webkit-mask-box-image-expected.txt: Added.
- platform/qt/animations/cross-fade-webkit-mask-image-expected.png: Added.
- platform/qt/animations/cross-fade-webkit-mask-image-expected.txt: Added.
- platform/qt/transitions/cross-fade-background-image-expected.png: Added.
- platform/qt/transitions/cross-fade-background-image-expected.txt: Added.
- platform/qt/transitions/cross-fade-border-image-expected.png: Added.
- platform/qt/transitions/cross-fade-border-image-expected.txt: Added.
- 12:45 AM Changeset in webkit [102442] by
-
- 10 edits in trunk/Source/JavaScriptCore
Avoid reloading storage pointer for indexed properties unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=74136
Reviewed by Filip Pizlo.
Add a node to represent loading property storage for indexed properties.
This allows us to reduce code generated for sequential access of arrays,
strings, etc. This results in up to 5% improvement in code that is
very heavy on indexed reads, such as matrix operations in typed arrays
and 20% faster on microbenchmarks.
Currently this is only supported by GetByVal and other similar indexed reads.
- bytecode/PredictedType.h:
(JSC::isFixedIndexedStorageObjectPrediction):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGNode.h:
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compileGetByValOnByteArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 12:43 AM Changeset in webkit [102441] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Fixed reviewer name in r102432 changelog entry.
- 12:33 AM Changeset in webkit [102440] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [protocol] generate C++ classes for protocol JSON named types
https://bugs.webkit.org/show_bug.cgi?id=72835
Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-12-09
Reviewed by NOBODY.
Extends python generator functionality.
Makes constructor in InspectorObject public.
- inspector/CodeGeneratorInspector.py:
- inspector/InspectorValues.h:
- 12:12 AM Changeset in webkit [102439] by
-
- 3 edits in branches/chromium/963/Source/WebCore
Merge 102140 - [Chromium] Web Inspector: getFunctionLocation should return scriptId as String not as int
https://bugs.webkit.org/show_bug.cgi?id=73892
Reviewed by Pavel Feldman.
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::functionLocationCallback): scriptId should be a string not a number
- inspector/Inspector.json: removed unused parameter
TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/8872059
Dec 8, 2011:
- 11:26 PM Changeset in webkit [102438] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rebaseline fast/forms/select-listbox-multiple-no-focusring.html
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08
- platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.png:
- 11:01 PM Changeset in webkit [102437] by
-
- 5 edits in trunk/Source
Versioning.
- 10:59 PM Changeset in webkit [102436] by
-
- 1 copy in tags/Safari-535.12
New Tag.
- 10:54 PM Changeset in webkit [102435] by
-
- 18 edits3 adds in trunk/Source
[Qt] [WK2] Webkit should release TextureMapper GL objects if page paint node is deallocated.
https://bugs.webkit.org/show_bug.cgi?id=73591
Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-12-08
Reviewed by Noam Rosenthal.
Source/WebCore:
Implementation of helper function to remove all GL allocated tiles
when QQuickWebView gets removed from canvas.
Tested by new API test in WK2 (tst_QQuickWebView::removeFromCanvas).
- platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::purgeNodeTexturesRecursive):
- platform/graphics/texmap/TextureMapperNode.h:
Source/WebKit2:
Implement deallocation of TextureMapper GL objects when QQuickWebPage paint node deallocated.
Also adds purging GraphicsLayer backing stores on WebProcess side in order to force repainting
when page becomes visible and painting resumes and fixes incorrect initialization of view
visibility state.
- UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::resetPaintNode):
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
- UIProcess/API/qt/tests/html/direct-image-compositing.html: Added.
- UIProcess/API/qt/tests/html/resources/simple_image.png: Added.
- UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::showWebView):
(tst_QQuickWebView::removeFromCanvas):
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::layerTreeHostProxy):
- UIProcess/LayerTreeHostProxy.h:
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::purgeGLResources):
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::purgeGLResources):
- UIProcess/qt/QtWebPageProxy.h:
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::purgeBackingStores):
(WebCore::WebGraphicsLayer::recreateBackingStoreIfNeeded):
- WebProcess/WebCoreSupport/WebGraphicsLayer.h:
- WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::purgeBackingStores):
- WebProcess/WebPage/LayerTreeHost.messages.in:
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::flushPendingLayerChanges):
(WebKit::LayerTreeHostQt::purgeBackingStores):
(WebKit::LayerTreeHostQt::recreateBackingStoreIfNeeded):
- WebProcess/WebPage/qt/LayerTreeHostQt.h:
- 10:53 PM Changeset in webkit [102434] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, chromium test expectation update.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08
- platform/chromium/test_expectations.txt:
- 10:43 PM Changeset in webkit [102433] by
-
- 1 edit6 adds in trunk/Source/WebCore
Upstream platform/network/blackberry/DeferredData.{h, cpp}, NetworkJob.{h, cpp} and NetworkManager.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=73791
Reviewed by Rob Buis.
Other main contributors:
Joe Mason <jmason@rim.com>
Lianghui Chen <liachen@rim.com>
Charles Wei <charles.wei@torchmobile.com.cn>
Initial upstream, can't be built yet, no new tests.
- platform/network/blackberry/DeferredData.cpp: Added.
- platform/network/blackberry/DeferredData.h: Added.
- platform/network/blackberry/NetworkJob.cpp: Added.
- platform/network/blackberry/NetworkJob.h: Added.
- platform/network/blackberry/NetworkManager.cpp: Added.
- platform/network/blackberry/NetworkManager.h: Added.
- 9:36 PM Changeset in webkit [102432] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed, rebaseline fast/repaint/textarea-set-disabled.html for
Chromium Linux.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08
- platform/chromium-linux/fast/repaint/textarea-set-disabled-expected.png: Added.
- 9:26 PM Changeset in webkit [102431] by
-
- 10 edits in trunk/Source/WebCore
It's semantically incorrect to call notifyNodeListsAttributeChanged in dispatchSubtreeModifiedEvent
https://bugs.webkit.org/show_bug.cgi?id=74028
Reviewed by Darin Adler.
Remove a call to notifyNodeListsAttributeChanged in dispatchSubtreeModified and add explicit calls
to notifyNodeListsAttributeChanged at appropriate places.
Also merge notifyNodeListsChildrenChanged with notifyLocalNodeListsChildrenChanged, and
notifyNodeListsAttributeChanged with notifyLocalNodeListsAttributeChanged, and rename them to
invalidateNodeListsCacheAfterAttributeChanges and invalidateNodeListsCacheAfterNodeChanges respectively.
- dom/Attr.cpp:
(WebCore::Attr::childrenChanged):
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::childrenChanged):
- dom/Document.cpp:
(WebCore::Document::updateRangesAfterNodeChanges):
- dom/Document.h:
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::addAttribute):
(WebCore::NamedNodeMap::removeAttribute):
- dom/Node.cpp:
(WebCore::removeNodeListCacheIfPossible):
(WebCore::Node::unregisterDynamicNodeList):
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanges):
(WebCore::Node::invalidateNodeListsCacheAfterNodeChanges):
(WebCore::Node::dispatchSubtreeModifiedEvent):
- dom/Node.h:
- dom/NodeRareData.h:
- dom/StyledElement.cpp:
(WebCore::StyledElement::classAttributeChanged):
- 9:23 PM Changeset in webkit [102430] by
-
- 19 edits3 moves in trunk
Unreviewed, rolling out r102418.
http://trac.webkit.org/changeset/102418
https://bugs.webkit.org/show_bug.cgi?id=71870
Caused Chromium build failure.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08
Source/WebCore:
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::maybeRestoreContext):
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebKitLoseContext.cpp: Renamed from Source/WebCore/html/canvas/WebGLLoseContext.cpp.
(WebCore::WebKitLoseContext::WebKitLoseContext):
(WebCore::WebKitLoseContext::~WebKitLoseContext):
(WebCore::WebKitLoseContext::getName):
(WebCore::WebKitLoseContext::create):
(WebCore::WebKitLoseContext::loseContext):
(WebCore::WebKitLoseContext::restoreContext):
- html/canvas/WebKitLoseContext.h: Renamed from Source/WebCore/html/canvas/WebGLLoseContext.h.
- html/canvas/WebKitLoseContext.idl: Renamed from Source/WebCore/html/canvas/WebGLLoseContext.idl.
LayoutTests:
- fast/canvas/webgl/WebGLContextEvent.html:
- fast/canvas/webgl/context-destroyed-crash.html:
- fast/canvas/webgl/context-lost-expected.txt:
- fast/canvas/webgl/context-lost-restored.html:
- fast/canvas/webgl/context-lost.html:
- 9:15 PM Changeset in webkit [102429] by
-
- 12 edits in trunk/Source
[Chromium] Enable viewport metatag
https://bugs.webkit.org/show_bug.cgi?id=73495
Reviewed by Darin Fisher.
Source/JavaScriptCore:
- wtf/Platform.h: Added ENABLE(VIEWPORT) tag.
Source/WebCore:
Recompute viewpot parameters on frame rect resize.
- page/FrameView.cpp:
(WebCore::FrameView::setFrameRect):
Source/WebKit/chromium:
Compute the appropriate fixed layout size, page, and device scale factors,
based on the viewport meta tag parameters.
See http://developer.android.com/guide/webapps/targeting.html for more information.
- features.gypi:
- public/WebView.h:
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::layoutUpdated):
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
- src/ChromeClientImpl.h:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::isPageScaleFactorSet):
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::observeNewNavigation):
- src/WebViewImpl.h:
- 9:00 PM WebKit Team edited by
- Updated my (very outdated) entry (diff)
- 9:00 PM Changeset in webkit [102428] by
-
- 2 edits in trunk/Source/WebCore
Build fix for r102419.
https://bugs.webkit.org/show_bug.cgi?id=73916
- platform/PopupMenuClient.h:
(WebCore::PopupMenuClient::listBoxSelectItem):
Remove unused argument names.
- 8:51 PM Changeset in webkit [102427] by
-
- 8 edits in trunk/Source/WebCore
Unreviewed. Rebaselined run-bindings-tests results.
- bindings/scripts/test/JS/JSFloat64Array.cpp:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- 8:37 PM Changeset in webkit [102426] by
-
- 1 edit2 adds in trunk/Source/WebCore
Upstream BlackBerry porting of MIMETypeRegistry/KeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=73534
Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-08
Reviewed by Rob Buis.
Other main contributors:
Mike Fenton <mifenton@rim.com>
Joe Mason <jmason@rim.com>
Max Feil <mfeil@qnx.com>
Lukas Sydorowski <lsydorowski@rim.com>
Crystal Zhang <haizhang@rim.com>
Initial upstream, no new tests.
- platform/blackberry/MIMETypeRegistryBlackBerry.cpp: Added.
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
(WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
- platform/blackberry/PlatformKeyboardEventBlackBerry.cpp: Added.
(WebCore::keyIdentifierForBlackBerryCharacter):
(WebCore::windowsKeyCodeForBlackBerryCharacter):
(WebCore::adjustCharacterFromOS):
(WebCore::toWebCorePlatformKeyboardEventType):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
(WebCore::PlatformKeyboardEvent::currentCapsLockState):
(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
(WebCore::PlatformKeyboardEvent::getCurrentModifierState):
- 8:22 PM Changeset in webkit [102425] by
-
- 4 edits2 deletes in trunk
Unreviewed, rolling out r101619.
http://trac.webkit.org/changeset/101619
https://bugs.webkit.org/show_bug.cgi?id=74158
this patch produces bad behaviour on mac (Requested by
jeremya_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-08
Source/WebCore:
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::dragSourceEndedAt):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateHoverActiveState):
LayoutTests:
- fast/css/hover-active-drag-expected.txt: Removed.
- fast/css/hover-active-drag.html: Removed.
- 8:19 PM Changeset in webkit [102424] by
-
- 6 edits2 adds in trunk
[MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
https://bugs.webkit.org/show_bug.cgi?id=73492
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/mutation/inline-event-listener.html
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject): Call v8::Script::Run directly instead of going through V8Proxy.
Tools:
Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
keypress event without any script on the stack.
- DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
(EventSender::keyDown):
(KeyDownTask::KeyDownTask):
(KeyDownTask::runIfValid):
(EventSender::scheduleAsynchronousKeyDown):
- DumpRenderTree/chromium/EventSender.h:
LayoutTests:
- fast/mutation/inline-event-listener-expected.txt: Added.
- fast/mutation/inline-event-listener.html: Added.
- 8:16 PM Changeset in webkit [102423] by
-
- 3 edits2 adds in trunk
Suppress rendering of light children when ShadowRoot is dynamically created.
https://bugs.webkit.org/show_bug.cgi?id=72441
Reviewed by Ryosuke Niwa.
Source/WebCore:
Tests: fast/dom/shadow/dynamically-created-shadow-root-expected.html
fast/dom/shadow/dynamically-created-shadow-root.html
- dom/Element.cpp:
(WebCore::Element::setShadowRoot):
LayoutTests:
- fast/dom/shadow/dynamically-created-shadow-root-expected.html: Added.
- fast/dom/shadow/dynamically-created-shadow-root.html: Added.
- 8:12 PM Changeset in webkit [102422] by
-
- 2 edits43 adds in trunk/LayoutTests
Unreviewed, chromium test rebaseline tests added in r102388. Updates expectations.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08
- platform/chromium-cg-mac-leopard/transitions/cross-fade-background-image-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/animations/cross-fade-background-image-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/animations/cross-fade-border-image-source-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/animations/cross-fade-border-image-source-expected.txt: Added.
- platform/chromium-cg-mac-snowleopard/animations/cross-fade-list-style-image-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/animations/cross-fade-webkit-mask-image-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/transitions/cross-fade-background-image-expected.png: Added.
- platform/chromium-linux/animations/cross-fade-background-image-expected.png: Added.
- platform/chromium-linux/animations/cross-fade-border-image-source-expected.png: Added.
- platform/chromium-linux/animations/cross-fade-list-style-image-expected.png: Added.
- platform/chromium-linux/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
- platform/chromium-linux/animations/cross-fade-webkit-mask-image-expected.png: Added.
- platform/chromium-linux/transitions/cross-fade-background-image-expected.png: Added.
- platform/chromium-linux/transitions/cross-fade-border-image-expected.png: Added.
- platform/chromium-mac-leopard/animations/cross-fade-background-image-expected.png: Added.
- platform/chromium-mac-leopard/animations/cross-fade-border-image-source-expected.png: Added.
- platform/chromium-mac-leopard/animations/cross-fade-list-style-image-expected.png: Added.
- platform/chromium-mac-leopard/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
- platform/chromium-mac-leopard/animations/cross-fade-webkit-mask-image-expected.png: Added.
- platform/chromium-mac-leopard/transitions/cross-fade-background-image-expected.png: Added.
- platform/chromium-mac-leopard/transitions/cross-fade-border-image-expected.png: Added.
- platform/chromium-mac-snowleopard/animations/cross-fade-background-image-expected.png: Added.
- platform/chromium-mac-snowleopard/animations/cross-fade-list-style-image-expected.png: Added.
- platform/chromium-mac-snowleopard/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
- platform/chromium-mac-snowleopard/animations/cross-fade-webkit-mask-image-expected.png: Added.
- platform/chromium-mac-snowleopard/transitions/cross-fade-background-image-expected.png: Added.
- platform/chromium-win/animations/cross-fade-background-image-expected.png: Added.
- platform/chromium-win/animations/cross-fade-background-image-expected.txt: Added.
- platform/chromium-win/animations/cross-fade-border-image-source-expected.png: Added.
- platform/chromium-win/animations/cross-fade-border-image-source-expected.txt: Added.
- platform/chromium-win/animations/cross-fade-list-style-image-expected.png: Added.
- platform/chromium-win/animations/cross-fade-list-style-image-expected.txt: Added.
- platform/chromium-win/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
- platform/chromium-win/animations/cross-fade-webkit-mask-box-image-expected.txt: Added.
- platform/chromium-win/animations/cross-fade-webkit-mask-image-expected.png: Added.
- platform/chromium-win/animations/cross-fade-webkit-mask-image-expected.txt: Added.
- platform/chromium-win/transitions/cross-fade-background-image-expected.png: Added.
- platform/chromium-win/transitions/cross-fade-background-image-expected.txt: Added.
- platform/chromium-win/transitions/cross-fade-border-image-expected.png: Added.
- platform/chromium-win/transitions/cross-fade-border-image-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 7:28 PM Changeset in webkit [102421] by
-
- 3 edits in trunk/LayoutTests
Accessibility object searching layout tests are incomplete.
https://bugs.webkit.org/show_bug.cgi?id=74130
Patch by Sam White <samuel.white@rochester.edu> on 2011-12-08
Reviewed by Chris Fleizach.
Added a layout test to support visited link searching and removed frame searching
(which was unimplemented) as it's fully covered by the tests in:
platform/mac/accessibility/search-with-frames.html
- platform/mac/accessibility/search-predicate-expected.txt:
- platform/mac/accessibility/search-predicate.html:
- 7:24 PM Changeset in webkit [102420] by
-
- 2 edits in trunk/Tools
[gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
https://bugs.webkit.org/show_bug.cgi?id=73980
Reviewed by Tony Chang.
- gdb/webkit.py:
(guess_string_length):
(ustring_to_string):
(lstring_to_string):
(LCharStringPrinter):
(LCharStringPrinter.to_string):
(WTFStringImplPrinter.get_length):
(WTFStringImplPrinter.to_string):
(WTFStringImplPrinter.is_8bit):
(WTFStringPrinter.stringimpl_ptr):
(WTFStringPrinter.get_length):
(WTFStringPrinter.to_string):
(add_pretty_printers.lookup_function):
- 7:22 PM Changeset in webkit [102419] by
-
- 14 edits in trunk
Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
https://bugs.webkit.org/show_bug.cgi?id=73916
Source/WebCore:
This was needed for Qt since the mobile theme, which can be picked
up at runtime, delegates the rendering of list boxes.
Reviewed by Kent Tamura.
No new tests, there's no functional change.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::usesMenuList):
- html/HTMLSelectElement.h:
- platform/PopupMenuClient.h:
(WebCore::PopupMenuClient::listBoxSelectItem):
(WebCore::PopupMenuClient::multiple):
- platform/qt/RenderThemeQtMobile.h:
(WebCore::RenderThemeQtMobile::delegatesMenuListRendering):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::multiple):
- rendering/RenderMenuList.h:
- rendering/RenderTheme.h:
(WebCore::RenderTheme::delegatesMenuListRendering):
Source/WebKit/chromium:
Reviewed by Kent Tamura.
- src/ExternalPopupMenu.cpp:
(WebKit::ExternalPopupMenu::didAcceptIndices):
(WebKit::ExternalPopupMenu::getPopupMenuInfo):
Source/WebKit/qt:
Reviewed by Kent Tamura.
- WebCoreSupport/PopupMenuQt.cpp:
(SelectData::multiple):
(WebCore::PopupMenuQt::selectItem):
Tools:
Reviewed by Kent Tamura.
- qmake/mkspecs/features/features.prf:
- 7:07 PM Changeset in webkit [102418] by
-
- 19 edits3 moves in trunk
Rename WEBKIT_lose_context to WEBKIT_WEBGL_lose_context
https://bugs.webkit.org/show_bug.cgi?id=71870
Source/WebCore:
Reviewed by James Robinson.
Rename largely done with do-webcore-rename with a couple of
necessary manual fixups. Ran WebGL layout tests.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLLoseContext.cpp: Copied from Source/WebCore/html/canvas/WebKitLoseContext.cpp.
(WebCore::WebGLLoseContext::WebGLLoseContext):
(WebCore::WebGLLoseContext::~WebGLLoseContext):
(WebCore::WebGLLoseContext::getName):
(WebCore::WebGLLoseContext::create):
(WebCore::WebGLLoseContext::loseContext):
(WebCore::WebGLLoseContext::restoreContext):
- html/canvas/WebGLLoseContext.h: Copied from Source/WebCore/html/canvas/WebKitLoseContext.h.
- html/canvas/WebGLLoseContext.idl: Copied from Source/WebCore/html/canvas/WebKitLoseContext.idl.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::maybeRestoreContext):
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebKitLoseContext.cpp: Removed.
- html/canvas/WebKitLoseContext.h: Removed.
- html/canvas/WebKitLoseContext.idl: Removed.
LayoutTests:
Synchronized context-lost-restored.html and context-lost.html with
Khronos repository; upstream tests must check for multiple vendor
prefixes.
Reviewed by James Robinson.
- fast/canvas/webgl/WebGLContextEvent.html:
- fast/canvas/webgl/context-destroyed-crash.html:
- fast/canvas/webgl/context-lost-expected.txt:
- fast/canvas/webgl/context-lost-restored.html:
- fast/canvas/webgl/context-lost.html:
- 6:59 PM Changeset in webkit [102417] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed chromium rebaseline fast/repaint/textarea-set-disabled.html.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08
- platform/chromium-win/fast/repaint/textarea-set-disabled-expected.png: Added.
- platform/chromium/fast/repaint/textarea-set-disabled-expected.png: Added.
- 6:49 PM Changeset in webkit [102416] by
-
- 6 edits1 add in trunk/Source/WebCore
Use the [Supplemental] IDL for webaudio attributes in Chromium
https://bugs.webkit.org/show_bug.cgi?id=73394
Reviewed by Adam Barth.
- Overview: Using the [Supplemental] IDL, this patch moves the attribute
declarations of webaudio from DOMWindow.idl into a new IDL file
webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained
feature (aka a module).
- This patch changes the build flow of WebCore.gyp as follows:
Previous build flow:
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;
}
New build flow (See the discussions in bug 72138 for more details):
resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl;
}
- This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL
will be removed after build scripts for all platforms support the [Supplemental] IDL.
The motivation for the [Supplemented] IDL is as follows:
In order to support the [Supplemental] IDL, we need to
(1) run resolve-supplemental.pl and generate supplemental_dependency.tmp
(2) and run generate-bindings.pl with the supplemental_dependency.tmp.
This build flow requires a change on the following build scripts,
but changing all the build scripts all at once without any regression is too difficult:
- DerivedSources.make
- DerivedSources.pri
- GNUmakefile.am
- PlatformBlackBerry.cmake
- UseJSC.cmake
- UseV8.cmake
- WebCore.vcproj/MigrateScripts
- WebCore.vcproj/WebCore.vcproj
- bindings/gobject/GNUmakefile.am
- WebCore.gyp/WebCore.gyp
Thus, we are planning to change the build scripts one by one, which implies that
we need to allow the temporary state in which some build scripts support [Supplemental] IDL
but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented].
The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental]
in another IDL file somewhere, like this:
DOMWindowWebAudio.idl:
interface [
Supplemental=DOMWindow
] DOMWindowWebAudio {
attribute attr1;
attribute attr2;
};
DOMWindow.idl:
interface [
] DOMWindow {
attribute [Supplemented] attr1; This line will be removed after all build scripts support the [Su IDL
attribute [Supplemented] attr2; This line will be removed after all build scripts support the [Su IDL.
attribute attr3;
attribute attr4;
};
Assuming these IDL files, this patch implements the following logic in generate-bindings.pl:
- If a given build script supports the [Supplemental] IDL, generate-bindings.pl ignores all attributes with the [Supplemented] IDL.
- Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL as normal attributes and instead ignores all attributes with the [Supplemental] IDL (i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL).
Tests: webaudio/*
- WebCore.gyp/WebCore.gyp: Describes the build flow that I described above.
- WebCore.gyp/scripts/action_derivedsourcesallinone.py:
(main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file. If the file name is a "/cygdrive/c/..."-style path, it is converted to a "C:\cygwin\..."-style path by the cygpath command.
- WebCore.gypi: Added DOMWindowWebAudio.idl.
- bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL.
- page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL.
- webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in DOMWindow.idl.
- 6:38 PM Changeset in webkit [102415] by
-
- 1 edit2 adds in trunk/LayoutTests
Add test for inline style block in HTML tag
https://bugs.webkit.org/show_bug.cgi?id=72360
Patch by Szilard Ledan <Ledan-Muntean.Szilard@stud.u-szeged.hu> on 2011-12-08
Reviewed by Darin Adler.
- fast/css/parsing-css-block-expected.txt: Added.
- fast/css/parsing-css-block.html: Added.
- 6:32 PM Changeset in webkit [102414] by
-
- 2 edits2 adds in trunk/LayoutTests
Unreviewed, rolling out r102396.
http://trac.webkit.org/changeset/102396
https://bugs.webkit.org/show_bug.cgi?id=74153
over-active-drag test still failing. (Requested by macpherson
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-08
- fast/css/hover-active-drag.html:
- platform/chromium/fast/css/hover-active-drag-expected.txt: Added.
- platform/mac/fast/css/hover-active-drag-expected.txt: Added.
- 6:28 PM Changeset in webkit [102413] by
-
- 4 edits in trunk/Source/WebCore
Caret keeps blinking during forward-delete
https://bugs.webkit.org/show_bug.cgi?id=38564
Patch by Van Lam <vanlam@google.com> on 2011-12-08
Reviewed by Darin Adler.
Currently updateAppearance determines if the caret should stop blinking
based on whether or not the editing operation changed the position of
the caret; so the caret stops blinking in case of typing text and
backwards delete (which always displace the caret) but does not stop
blinking in the case of forward delete (which does not displace the
caret).
Added a boolean member function shouldStopCaretBlinking in EditCommand
which will return true if the object is a TypingCommand (my
understanding here is that all TypingCommands should stop the caret
from blinking for a cycle, currently 0.5 seconds). Then used this
function to stop the caret from blinking if the last editing command
is a TypingCommand.
- editing/EditCommand.h:
(WebCore::EditCommand::shouldStopCaretBlinking):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::updateAppearance):
- editing/TypingCommand.h:
(WebCore::TypingCommand::shouldStopCaretBlinking):
- 6:00 PM Changeset in webkit [102412] by
-
- 2 edits in trunk/Tools
Unreviewed contributor additions to committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 5:59 PM Changeset in webkit [102411] by
-
- 21 edits3 copies4 moves29 adds1 delete in trunk/LayoutTests
[Chromium] Rebaseline for r102320.
- platform/chromium-cg-mac-leopard/fast/forms/basic-inputs-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/forms/file/file-input-disabled-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/forms/file/file-input-disabled-expected.txt: Added.
- platform/chromium-cg-mac-leopard/fast/forms/input-disabled-color-expected.png:
- platform/chromium-cg-mac-snowleopard/fast/forms/basic-inputs-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/file/file-input-disabled-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/file/file-input-disabled-expected.txt: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
- platform/chromium-cg-mac/fast/forms/file/file-input-disabled-expected.png: Removed.
- platform/chromium-linux-x86/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/file/file-input-disabled-expected.txt.
- platform/chromium-linux/fast/forms/file/file-input-disabled-expected.png:
- platform/chromium-linux/fast/forms/file/file-input-disabled-expected.txt:
- platform/chromium-linux/fast/forms/input-disabled-color-expected.png:
- platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
- platform/chromium-mac-leopard/fast/forms/basic-inputs-expected.png: Added.
- platform/chromium-mac-leopard/fast/forms/file/file-input-disabled-expected.png: Added.
- platform/chromium-mac-leopard/fast/forms/file/file-input-disabled-expected.txt: Added.
- platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/basic-textareas-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/basic-textareas-quirks-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/file/file-input-disabled-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/file/file-input-disabled-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/input-appearance-disabled-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
- platform/chromium-win-vista/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/file/file-input-disabled-expected.txt.
- platform/chromium-win-xp/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/file/file-input-disabled-expected.txt.
- platform/chromium-win/fast/forms/basic-inputs-expected.txt:
- platform/chromium-win/fast/forms/basic-textareas-expected.txt:
- platform/chromium-win/fast/forms/basic-textareas-quirks-expected.txt:
- platform/chromium-win/fast/forms/file/file-input-disabled-expected.png:
- platform/chromium-win/fast/forms/file/file-input-disabled-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-disabled-expected.txt:
- platform/chromium-win/fast/forms/input-disabled-color-expected.png:
- platform/chromium-win/fast/forms/input-disabled-color-expected.txt:
- platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
- platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
- platform/chromium/fast/forms/basic-inputs-expected.txt: Added.
- platform/chromium/fast/forms/basic-textareas-expected.txt: Added.
- platform/chromium/fast/forms/basic-textareas-quirks-expected.txt: Added.
- platform/chromium/fast/forms/input-appearance-disabled-expected.txt: Added.
- platform/chromium/fast/forms/input-disabled-color-expected.txt: Added.
- platform/chromium/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.
- platform/chromium/fast/forms/placeholder-pseudo-style-expected.txt: Added.
- platform/chromium/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 5:56 PM Changeset in webkit [102410] by
-
- 4 edits in trunk/Source
Use HashMap<Node*, OwnPtr<...>> in ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=73964
Reviewed by Darin Adler.
Source/JavaScriptCore:
- wtf/HashTraits.h: Add passOut(std::nullptr_t) to allow callers to use HashMap::take on a HashMap of OwnPtrs.
Source/WebCore:
Re-landing r102267 with a fix for the clang build.
No new tests, refactoring only.
- dom/ChildListMutationScope.cpp:
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::childAdded):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::willRemoveChild):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::incrementScopingLevel):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::decrementScopingLevel):
- 5:54 PM Changeset in webkit [102409] by
-
- 2 edits in trunk/Source/WebCore
WebScrollbarPainterDelegate should have a pointer to its Scrollbar
https://bugs.webkit.org/show_bug.cgi?id=74149
Reviewed by Darin Adler.
This is another step towards making the scroll animation code more robust.
- platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate initWithScrollbar:WebCore::]):
(-[WebScrollbarPainterDelegate scrollAnimator]):
(-[WebScrollbarPainterDelegate layer]):
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
- 5:46 PM Changeset in webkit [102408] by
-
- 3 edits2 adds in trunk
keyboard event doesn't fire while moving mouse with button pressed
https://bugs.webkit.org/show_bug.cgi?id=73821
Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-12-08
Reviewed by Alexey Proskuryakov.
Autoscroll should not stop on key press.
Source/WebCore:
Test: fast/events/autoscroll-should-not-stop-on-keypress.html
- page/EventHandler.cpp:
(WebCore::EventHandler::keyEvent):
Removed the check for autoscroll so that autoscroll is not stopped on
key press and key event is processed.
LayoutTests:
- fast/events/autoscroll-should-not-stop-on-keypress-expected.txt: Added.
- fast/events/autoscroll-should-not-stop-on-keypress.html: Added.
- 5:46 PM Changeset in webkit [102407] by
-
- 9 edits in trunk/Source/WebKit2
Forced compositing mode breaks display of full-page PDFs in WK2
https://bugs.webkit.org/show_bug.cgi?id=74122
<rdar://problem/9550059>
Reviewed by Dan Bernstein.
Full page PDFs are displayed in WK2 in a subview of the WKView. However,
when the WKView is forced to use accelerated compositing, the layer obscures
the PDF subview.
To fix this we have to drop out of compositing mode when the WKView is showing
a custom representation.
- UIProcess/API/mac/WKView.mm:
(-[WKView _setPageHasCustomRepresentation:]): Tell the drawing area that the view
gained or lost a custom representation.
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::pageCustomRepresentationChanged):
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::pageCustomRepresentationChanged): Send a messgae to the web process
to indicate that the custom representation changed.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::pageCustomRepresentationChanged):
- WebProcess/WebPage/DrawingArea.messages.in:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::pageCustomRepresentationChanged): Enter or exit compositing mode
as appropriate when we gain or lost a custom represenetation.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
- WebProcess/WebPage/DrawingAreaImpl.h:
- 5:35 PM Changeset in webkit [102406] by
-
- 2 edits in trunk/Source/WebCore
Add scrollAnimator getter method to WebScrollbarPainterDelegate
https://bugs.webkit.org/show_bug.cgi?id=74146
Reviewed by Beth Dakin.
- platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate scrollAnimator]):
(-[WebScrollbarPainterDelegate layer]):
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
- 5:33 PM Changeset in webkit [102405] by
-
- 7 edits2 adds in trunk
Source/WebCore: Improve handling of frame removal during requestAnimationFrame callback invocation
https://bugs.webkit.org/show_bug.cgi?id=74036
Reviewed by Adam Barth.
See bug for details.
Test: fast/animation/request-animation-frame-detach-element.html
- dom/Document.cpp:
(WebCore::Document::removedLastRef):
(WebCore::Document::detach):
- dom/Document.h:
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::~ScriptedAnimationController):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::scheduleAnimation):
- dom/ScriptedAnimationController.h:
(WebCore::ScriptedAnimationController::create):
(WebCore::ScriptedAnimationController::clearDocumentPointer):
- page/FrameView.cpp:
(WebCore::FrameView::serviceScriptedAnimations):
LayoutTests: Add some tests for removing frames from the document while servicing requestAnimationFrame callbacks
https://bugs.webkit.org/show_bug.cgi?id=74036
Reviewed by Adam Barth.
- fast/animation/request-animation-frame-detach-element-expected.txt: Added.
- fast/animation/request-animation-frame-detach-element.html: Added.
- 5:31 PM Changeset in webkit [102404] by
-
- 7 edits in trunk/Source/WebCore
Use bitfield for bool data members in BitmapImage.
https://bugs.webkit.org/show_bug.cgi?id=74102
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2011-12-08
Reviewed by Darin Adler.
Class BitmapImage and FrameData has bool data members, we can use bitfield for those data
members to reduce the BitmapImage's memory footprint.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage):
- platform/graphics/BitmapImage.h:
(WebCore::FrameData::FrameData):
- platform/graphics/cairo/ImageCairo.cpp:
(WebCore::BitmapImage::BitmapImage):
- platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::BitmapImage):
- platform/graphics/openvg/ImageOpenVG.cpp:
(WebCore::BitmapImage::BitmapImage):
- platform/graphics/qt/ImageQt.cpp:
(WebCore::BitmapImage::BitmapImage):
- 5:16 PM Changeset in webkit [102403] by
-
- 2 edits in trunk/Source/WebCore
Fix a paste-o in ScrollAnimatorMac::updateScrollerStyle
https://bugs.webkit.org/show_bug.cgi?id=74145
Reviewed by Sam Weinig.
Call setHorizontalScrollerImp to set the horizontal scrollbar painter.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
- 5:13 PM Changeset in webkit [102402] by
-
- 1 edit3 adds12 deletes in trunk/LayoutTests
Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=74116
Patch by Jacob Goldstein <jacobg@adobe.com> on 2011-12-08
Reviewed by Darin Adler.
- fast/regions/webkit-flow-renderer-expected.html: Added.
- fast/regions/webkit-flow-renderer-layer-expected.html: Added.
- fast/regions/webkit-flow-renderer-nested-expected.html: Added.
- platform/efl/fast/regions/webkit-flow-renderer-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-renderer-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-renderer-layer-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-renderer-layer-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-renderer-nested-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-renderer-nested-expected.txt: Removed.
- platform/mac/fast/regions/webkit-flow-renderer-expected.png: Removed.
- platform/mac/fast/regions/webkit-flow-renderer-expected.txt: Removed.
- platform/mac/fast/regions/webkit-flow-renderer-layer-expected.png: Removed.
- platform/mac/fast/regions/webkit-flow-renderer-layer-expected.txt: Removed.
- platform/mac/fast/regions/webkit-flow-renderer-nested-expected.png: Removed.
- platform/mac/fast/regions/webkit-flow-renderer-nested-expected.txt: Removed.
- 5:11 PM Changeset in webkit [102401] by
-
- 3 edits in trunk/Source/WebCore
Create one WebScrollbarPainterDelegate for each scrollbar
https://bugs.webkit.org/show_bug.cgi?id=74142
Reviewed by Sam Weinig.
Create and destroy WebScrollbarPainterDelegate objects as scrollbars come and go.
This is a step towards simplifying the WebScrollbarPainterDelegate object.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::cancelAnimations):
- 5:04 PM Changeset in webkit [102400] by
-
- 17 edits in trunk
[Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
https://bugs.webkit.org/show_bug.cgi?id=74017
Source/WebCore:
Patch by David Reveman <reveman@chromium.org> on 2011-12-08
Reviewed by James Robinson.
Add per-tile drawing to page settings.
No new tests.
- page/Settings.h:
(WebCore::Settings::setPerTileDrawingEnabled):
(WebCore::Settings::perTileDrawingEnabled):
- testing/Internals.cpp:
(WebCore::Internals::setPerTileDrawingEnabled):
- testing/Internals.h:
Source/WebKit/chromium:
Patch by David Reveman <reveman@chromium.org> on 2011-12-08
Reviewed by James Robinson.
Add WebSettings::setAcceleratedPaintingEnabled to public API.
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setAcceleratedPaintingEnabled):
(WebKit::WebSettingsImpl::setPerTilePaintingEnabled):
- src/WebSettingsImpl.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
Tools:
Patch by David Reveman <reveman@chromium.org> on 2011-12-08
Reviewed by James Robinson.
Add support for command line flag enable-per-tile-painting in DumpRenderTree.
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
- DumpRenderTree/chromium/TestShell.h:
(TestShell::setAcceleratedPaintingEnabled):
(TestShell::setPerTilePaintingEnabled):
- DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
- DumpRenderTree/chromium/WebPreferences.h:
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver._wrapper_options):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 4:58 PM Changeset in webkit [102399] by
-
- 1 edit3 adds in trunk/LayoutTests
REGRESSION: Changing disabled state of a textarea does not do a repaint
https://bugs.webkit.org/show_bug.cgi?id=23789
Reviewed by Darin Adler.
The bug got fixed (I did not bisect to find out when) thus landing
the test case converted to a repaint test and made cross-platform.
- fast/repaint/textarea-set-disabled-expected.png: Added.
- fast/repaint/textarea-set-disabled-expected.txt: Added.
- fast/repaint/textarea-set-disabled.html: Added.
- 4:52 PM Changeset in webkit [102398] by
-
- 2 edits in trunk/Source/WebCore
Add a scrollbarPainterForScrollbar helper function
https://bugs.webkit.org/show_bug.cgi?id=74139
Reviewed by Sam Weinig.
- platform/mac/ScrollAnimatorMac.mm:
(macScrollbarTheme):
(scrollbarPainterForScrollbar):
(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
- 4:42 PM Changeset in webkit [102397] by
-
- 9 edits2 moves in trunk/Source
[chromium] Move NonCompositedContentHost to WebKit
https://bugs.webkit.org/show_bug.cgi?id=74047
Patch by James Robinson <jamesr@chromium.org> on 2011-12-08
Reviewed by Kenneth Russell.
Source/WebCore:
Updates WebCore.gypi to remove files no longer within WebCore and removes unused forward declaration and include
from LayerRendererChromium.
- WebCore.gypi:
- platform/graphics/chromium/LayerRendererChromium.cpp:
- platform/graphics/chromium/LayerRendererChromium.h:
Source/WebKit/chromium:
Moves NonCompositedContentHost into WebKit/chromium/src. This class is a helper class designed to make it easier
for WebViewImpl to interface with the compositor. The compositor proper should not depend on this class, and
other clients of the compositor do not need this functionality.
Follow-up patches will transition this code from using compositor-internal interfaces directly to using
higher-level interfaces like the WebKit platform APIs. This patch simply does a file mv and updates namespaces
to keep things simpler.
Refactor only and covered by several unit tests.
- WebKit.gyp:
- src/NonCompositedContentHost.cpp: Renamed from Source/WebCore/platform/graphics/chromium/NonCompositedContentHost.cpp.
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::~NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setBackgroundColor):
(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::scrollLayer):
(WebKit::NonCompositedContentHost::protectVisibleTileTextures):
(WebKit::NonCompositedContentHost::invalidateRect):
(WebKit::NonCompositedContentHost::notifyAnimationStarted):
(WebKit::NonCompositedContentHost::notifySyncRequired):
(WebKit::NonCompositedContentHost::paintContents):
(WebKit::NonCompositedContentHost::showDebugBorders):
(WebKit::NonCompositedContentHost::showRepaintCounter):
- src/NonCompositedContentHost.h: Renamed from Source/WebCore/platform/graphics/chromium/NonCompositedContentHost.h.
(WebKit::NonCompositedContentHost::create):
(WebKit::NonCompositedContentHost::topLevelRootLayer):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::nonCompositedContentHost):
- src/WebViewImpl.h:
- tests/LayerChromiumTest.cpp:
- 4:41 PM Changeset in webkit [102396] by
-
- 2 edits2 deletes in trunk/LayoutTests
Fix fast/css/hover-active-drag.html on Mac
https://bugs.webkit.org/show_bug.cgi?id=74046
Patch by Jeremy Apthorp <jeremya@chromium.org> on 2011-12-08
Reviewed by Darin Adler.
- fast/css/hover-active-drag.html:
- platform/chromium/fast/css/hover-active-drag-expected.txt: Removed.
- platform/mac/fast/css/hover-active-drag-expected.txt: Removed.
- 4:37 PM Changeset in webkit [102395] by
-
- 4 edits in trunk/Source
[chromium] Layer contents scale change should trigger invalidation
https://bugs.webkit.org/show_bug.cgi?id=74086
When the contents scale of a layer is changed, the entire contents of
the layer should be marked dirty.
Patch by Sami Kyostila <skyostil@google.com> on 2011-12-08
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setContentsScale):
Source/WebKit/chromium:
- tests/LayerChromiumTest.cpp:
- 4:22 PM Changeset in webkit [102394] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Add CSS_FILTERS custom binding file to WebCore.gypi.
https://bugs.webkit.org/show_bug.cgi?id=74091
Reviewed by Adam Barth.
If it builds, you're happy.
- WebCore.gypi:
- 4:20 PM Changeset in webkit [102393] by
-
- 3 edits2 adds in trunk/Tools
create a "SystemHost" object for webkitpy to slim down the Host object
https://bugs.webkit.org/show_bug.cgi?id=72680
Reviewed by Eric Siedel.
This creates a SystemHost object that other objects that should
only have dependencies on functionality in webkitpy.common.system
can use; this will allow them to not require a full Host.
- Scripts/webkitpy/common/host.py:
- Scripts/webkitpy/common/host_mock.py:
- Scripts/webkitpy/common/system/systemhost.py: Added.
- Scripts/webkitpy/common/system/systemhost_mock.py: Added.
- 4:15 PM Changeset in webkit [102392] by
-
- 2 edits2 adds in trunk
Line breaks are lost when pasted into textarea text starting with a blank line set while textarea is hidden
https://bugs.webkit.org/show_bug.cgi?id=74126
Reviewed by Tony Chang.
The bug was caused by the code that generated text out of pre-rendered text was generating div's inside the fragment
pasted into textarea even though serialization algorithm in textarea doesn't handle block elements.
Fixed the bug by special-casing this in createFragmentFromText. In the long run, we should really get rid of this
whole pre-rendering trick.
- editing/markup.cpp:
(WebCore::createFragmentFromText):
- 4:07 PM Changeset in webkit [102391] by
-
- 3 edits3 adds in trunk
Moving SVG elements on the page doesn't always erase element at the old position
https://bugs.webkit.org/show_bug.cgi?id=74002
Patch by Florin Malita <fmalita@google.com> on 2011-12-08
Reviewed by Darin Adler.
Source/WebCore:
Test: svg/repaint/container-repaint.svg
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layout):
Save the old repaint bounds before updating the viewport.
LayoutTests:
- svg/repaint/container-repaint-expected.png: Added.
- svg/repaint/container-repaint-expected.txt: Added.
- svg/repaint/container-repaint.svg: Added.
- 3:38 PM Changeset in webkit [102390] by
-
- 3 edits in trunk/LayoutTests
Mark tests added in r102388 as failing on Chromium. Fix the cross platform
expected results for transitions/svg-transitions.html (the line number changed).
- platform/chromium/test_expectations.txt:
- transitions/svg-transitions-expected.txt:
- 3:16 PM Changeset in webkit [102389] by
-
- 7 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=74005
fix unaligned access memory in generatePatternCharacterOnce function
for SH4 platforms.
Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2011-12-08
Reviewed by Gavin Barraclough.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::load16Unaligned):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load16Unaligned):
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::load16Unaligned):
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::lshift32):
(JSC::MacroAssemblerSH4::load8):
(JSC::MacroAssemblerSH4::load16):
(JSC::MacroAssemblerSH4::load16Unaligned):
(JSC::MacroAssemblerSH4::branch8):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::load16Unaligned):
- jit/JIT.h:
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
- 3:06 PM Changeset in webkit [102388] by
-
- 11 edits24 adds in trunk
Enable animations of CSS images using -webkit-cross-fade
https://bugs.webkit.org/show_bug.cgi?id=74049
<rdar://problem/10209303>
Reviewed by Simon Fraser.
Add support for animating CSS images in the following properties:
- background(-image)
- border-image(-source)
- list-style(-image)
- -webkit-mask-box-image(-source)
- -webkit-mask-image(-source)
This patch only adds support for transitioning between NinePieceImages
where all of the properties except the image itself are equal, and the
size of the images are equal. Other cases will not animate.
Add animation blend functions for StyleImage and NinePieceImage.
Apply the proper compositing operation to -webkit-cross-fade, and
fix handling of the destination and source areas to support scaling.
Tests: animations/cross-fade-background-image.html
animations/cross-fade-border-image-source.html
animations/cross-fade-list-style-image.html
animations/cross-fade-webkit-mask-box-image.html
animations/cross-fade-webkit-mask-image.html
- css/CSSCrossfadeValue.cpp:
(WebCore::cachedImageForCSSValue):
(WebCore::CSSCrossfadeValue::fixedSize):
(WebCore::CSSCrossfadeValue::image):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::CSSImageValue):
- css/CSSImageValue.h:
(WebCore::CSSImageValue::create):
- page/animation/AnimationBase.cpp:
(WebCore::crossfadeBlend):
(WebCore::blendFunc):
(WebCore::RefCountedPropertyWrapper::RefCountedPropertyWrapper):
(WebCore::RefCountedPropertyWrapper::blend):
(WebCore::FillLayerRefCountedPropertyWrapper::FillLayerRefCountedPropertyWrapper):
(WebCore::FillLayerRefCountedPropertyWrapper::blend):
(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
(WebCore::AnimationBase::ensurePropertyMap):
(WebCore::addShorthandProperties):
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::drawCrossfade):
(WebCore::CrossfadeGeneratedImage::draw):
(WebCore::CrossfadeGeneratedImage::drawPattern):
- platform/graphics/CrossfadeGeneratedImage.h:
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setMaskImage):
Add tests of -webkit-animation (using -webkit-cross-fade) between:
- background-image
- border-image
- list-style-image
- -webkit-mask-box-image
- -webkit-mask-image
Add the ability for animation tests to compare an animated element to a static element.
Add tests of -webkit-transition (using -webkit-cross-fade) between:
- background-image
- border-image
- animations/cross-fade-background-image-expected.txt: Added.
- animations/cross-fade-background-image.html: Added.
- animations/cross-fade-border-image-source-expected.txt: Added.
- animations/cross-fade-border-image-source.html: Added.
- animations/cross-fade-list-style-image-expected.txt: Added.
- animations/cross-fade-list-style-image.html: Added.
- animations/cross-fade-webkit-mask-box-image-expected.txt: Added.
- animations/cross-fade-webkit-mask-box-image.html: Added.
- animations/cross-fade-webkit-mask-image-expected.txt: Added.
- animations/cross-fade-webkit-mask-image.html: Added.
- animations/resources/animation-test-helpers.js:
(parseCrossFade):
(checkExpectedValue):
- animations/resources/blue-100.png: Added.
- animations/resources/green-100.png: Added.
- animations/resources/stripes-100.png: Added.
- platform/mac/animations/cross-fade-background-image-expected.png: Added.
- platform/mac/animations/cross-fade-border-image-source-expected.png: Added.
- platform/mac/animations/cross-fade-list-style-image-expected.png: Added.
- platform/mac/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
- platform/mac/animations/cross-fade-webkit-mask-image-expected.png: Added.
- platform/mac/transitions/cross-fade-background-image-expected.png: Added.
- platform/mac/transitions/cross-fade-border-image-expected.png: Added.
- transitions/cross-fade-background-image-expected.txt: Added.
- transitions/cross-fade-background-image.html: Added.
- transitions/cross-fade-border-image-expected.txt: Added.
- transitions/cross-fade-border-image.html: Added.
- transitions/resources/transition-test-helpers.js:
(expected):
- 3:00 PM Changeset in webkit [102387] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Set opaque() for VideoLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=73858
Patch by Dana Jansens <danakj@chromium.org> on 2011-12-08
Reviewed by James Robinson.
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::isVideoFrameFormatOpaque):
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
- 2:38 PM Changeset in webkit [102386] by
-
- 6 edits in branches/chromium/963
Merge 102317 - https://bugs.webkit.org/show_bug.cgi?id=74038
[V8][Chromium] Support legacy argument order in window.postMessage/window.webkitPostMessage.
Reviewed by David Levin.
Source/WebCore:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::isLegacyTargetOriginDesignation):
(WebCore::handlePostMessageCallback):
LayoutTests:
- fast/dom/Window/window-postmessage-args-expected.txt:
- fast/dom/Window/window-postmessage-args.html: New tests for legacy argument order.
- platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
TBR=caseq@chromium.org
ISSUE=http://code.google.com/p/chromium/issues/detail?id=106797
Review URL: http://codereview.chromium.org/8883032
- 2:29 PM Changeset in webkit [102385] by
-
- 5 edits2 adds in trunk/Source/WebCore
Use Skia's implementation of Gaussian blur when accelerated filters
are enabled.
https://bugs.webkit.org/show_bug.cgi?id=73949
Reviewed by Zoltan Herczeg.
In the future, this will be covered by the SVG tests run in GPU mode.
- WebCore.gypi:
Add FEGaussianBlurSkia.cpp to the build.
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplySoftware):
Call out to platformApplySkia() when USE_SKIA is enabled.
- platform/graphics/filters/FEGaussianBlur.h:
platformApplySkia() declaration.
- platform/graphics/filters/skia: Added.
- platform/graphics/filters/skia/FEGaussianBlurSkia.cpp: Added.
(WebCore::FEGaussianBlur::platformApplySkia):
On the Skia port, use SkBlurImageFilter for drawing
Gaussian blurs in accelerated mode.
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::copyImage):
Implement ImageBuffer::copyImage() with DontCopyBackingStore semantics.
- 2:20 PM Changeset in webkit [102384] by
-
- 5 edits in branches/safari-534.53-branch/Source
Versioning.
- 2:15 PM Changeset in webkit [102383] by
-
- 1 copy in tags/Safari-534.53.7
New tag.
- 2:11 PM Changeset in webkit [102382] by
-
- 6 edits in trunk
Tools: AX: platform/mac/accessibility/search-with-frames.html crashes
https://bugs.webkit.org/show_bug.cgi?id=74093
Reviewed by Darin Adler.
Take care of the case when an incoming element is null.
- DumpRenderTree/AccessibilityUIElement.cpp:
(uiElementForSearchPredicateCallback):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::uiElementForSearchPredicate):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
LayoutTests: platform/mac/accessibility/search-with-frames.html crashes
https://bugs.webkit.org/show_bug.cgi?id=74093
Reviewed by Darin Adler.
Unskip the crashing test.
- platform/mac/Skipped:
- 2:08 PM Changeset in webkit [102381] by
-
- 3 edits in trunk/Tools
[Qt] Visualize mock point ID's in the MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=74098
Patch by Alexander Færøy <ahf@0x90.dk> on 2011-12-08
Reviewed by Tor Arne Vestbø.
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
- MiniBrowser/qt/qml/MockTouchPoint.qml:
- 2:02 PM WebKit Team edited by
- (diff)
- 1:47 PM Changeset in webkit [102380] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add 8 bit paths for StringTypeAdapter classes
https://bugs.webkit.org/show_bug.cgi?id=73882
Reviewed by Darin Adler.
Added is8Bit() method and writeTo(LChar*) methods
to StringTypeAdapter<> classes. The writeTo(LChar*)
method can be used if is8Bit() returns true. The
non-native 8 bit classes contain ASSERT(is8Bit())
in their writeTo(LChar*).
Updated all of the various versions of tryMakeString() to
use 8 bit processing in the updated StringTypeAdapter<>
classes.
This has slight if any performance improvement on kraken.
- runtime/UStringConcatenate.h:
- wtf/text/StringConcatenate.h:
(WTF::tryMakeString):
- wtf/text/StringOperators.h:
(WTF::StringAppend::is8Bit):
(WTF::StringAppend::writeTo):
- 1:29 PM Changeset in webkit [102379] by
-
- 3 edits in trunk/Source/WebCore
CodeGeneratorV8: Fix issue with overloaded static conditional methods
https://bugs.webkit.org/show_bug.cgi?id=74114
Reviewed by Adam Barth.
The code generator was missing checks for Conditional for overloaded methods.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateOverloadedFunctionCallback): Generate needed #ifdefs.
(GenerateFunctionCallback): Ditto.
- bindings/scripts/test/V8/V8TestObj.cpp: Wrap conditional methods with #ifdefs.
(WebCore::ConfigureV8TestObjTemplate):
- 1:27 PM Changeset in webkit [102378] by
-
- 24 edits3 copies5 adds in trunk
Source/WebCore: AccessibilityController should support listening to notifications on all elements.
https://bugs.webkit.org/show_bug.cgi?id=72866
Changes accessibilitySetShouldRepostNotifications from an instance method
into a class method so that it can be used for global notification listeners,
not just for listeners on a particular object.
Reviewed by Chris Fleizach.
Test: accessibility/notification-listeners.html
- accessibility/mac/WebAccessibilityObjectWrapper.h:
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(+[WebAccessibilityObjectWrapper accessibilitySetShouldRepostNotifications:]):
(-[WebAccessibilityObjectWrapper accessibilityPostedNotification:]):
Tools: Accessibility: AccessibilityController should support listening to notifications on all elements.
https://bugs.webkit.org/show_bug.cgi?id=72866
Adds addNotificationListener and removeNotificationListener methods
to AccessibilityController, to listen to notifications on any element
rather than a specific element. Mac (DRT and WKTR) and Chromium (DRT)
implementations are all contained in this change.
On Mac, refactors AccessibilityNotificationHandler into its own
source file that can be used by both AccessibilityController and
AccessibilityUIElement. (Both DRT and WKTR.)
Reviewed by Chris Fleizach.
- DumpRenderTree/AccessibilityController.cpp:
(addNotificationListenerCallback):
(removeNotificationListenerCallback):
(AccessibilityController::getJSClass):
- DumpRenderTree/AccessibilityController.h:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/chromium/AccessibilityController.cpp:
(AccessibilityController::AccessibilityController):
(AccessibilityController::notificationReceived):
(AccessibilityController::addNotificationListenerCallback):
(AccessibilityController::removeNotificationListenerCallback):
- DumpRenderTree/chromium/AccessibilityController.h:
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::addNotificationListener):
(AccessibilityController::removeNotificationListener):
- DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::~AccessibilityController):
(AccessibilityController::addNotificationListener):
(AccessibilityController::removeNotificationListener):
- DumpRenderTree/mac/AccessibilityNotificationHandler.h: Added.
- DumpRenderTree/mac/AccessibilityNotificationHandler.mm: Added.
(-[NSString createJSStringRef]):
(-[AccessibilityNotificationHandler init]):
(-[AccessibilityNotificationHandler setPlatformElement:]):
(-[AccessibilityNotificationHandler dealloc]):
(-[AccessibilityNotificationHandler setCallback:]):
(-[AccessibilityNotificationHandler startObserving]):
(-[AccessibilityNotificationHandler _notificationReceived:]):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::addNotificationListener):
- DumpRenderTree/win/AccessibilityControllerWin.cpp:
(notificationListenerProc):
(AccessibilityController::addNotificationListener):
(AccessibilityController::removeNotificationListener):
(AccessibilityController::winNotificationReceived):
(AccessibilityController::winAddNotificationListener):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::addNotificationListener):
- WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR::AccessibilityController::addNotificationListener):
(WTR::AccessibilityController::removeNotificationListener):
- WebKitTestRunner/InjectedBundle/AccessibilityController.h:
(WTR::AccessibilityController::logAccessibilityEvents):
- WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
(WTR::AccessibilityTextMarker::AccessibilityTextMarker):
- WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
(WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: Added.
(WTR::AccessibilityController::addNotificationListener):
(WTR::AccessibilityController::removeNotificationListener):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h: Added.
- WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: Added.
(-[NSString createJSStringRef]):
(-[AccessibilityNotificationHandler init]):
(-[AccessibilityNotificationHandler setPlatformElement:]):
(-[AccessibilityNotificationHandler dealloc]):
(-[AccessibilityNotificationHandler setCallback:]):
(-[AccessibilityNotificationHandler startObserving]):
(-[AccessibilityNotificationHandler _notificationReceived:]):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::verticalScrollbar):
(WTR::AccessibilityUIElement::addNotificationListener):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
LayoutTests: Accessibility: AccessibilityController should support listening to notifications on all elements.
https://bugs.webkit.org/show_bug.cgi?id=72866
Previously, the Mac implementation of AccessibilityUIElement.addNotificationListener
incorrectly triggered on notifications from all elements. Now it only triggers on
notifications from the correct element, and a new addNotificationListener method
in AccessibilityController can be used to trigger on notifications from all elements.
Updates 2 tests that depended on the old incorrect behavior.
Reviewed by Chris Fleizach.
- accessibility/notification-listeners.html: Added.
- platform/chromium/accessibility/notification-listeners-expected.txt: Added.
- platform/gtk/Skipped:
- platform/mac/accessibility/aria-expanded-notifications.html:
- platform/mac/accessibility/aria-listbox-selectedchildren-change.html:
- platform/mac/accessibility/notification-listeners-expected.txt: Added.
- platform/win/Skipped:
- 1:23 PM Changeset in webkit [102377] by
-
- 2 edits in trunk/Source/WebKit2
HiDPI: Switching a video element to full screen in HiDPI mode doesn't fit the screen correctly
https://bugs.webkit.org/show_bug.cgi?id=74119
rdar://problem/10356869
Reviewed by Darin Adler.
Use the Lion-only -[NSWindow convertRectToScreen:] function to convert between window
coordinates and screen coordinates.
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController enterFullScreen:]):
- 1:21 PM Changeset in webkit [102376] by
-
- 2 edits in branches/safari-534.53-branch/Source/WebCore
Merged r96777.
- 1:15 PM Changeset in webkit [102375] by
-
- 9 edits in trunk/Source/WebCore
Web Inspector: Rename createScriptCallStack() without parameters to createScriptCallStackForInspector().
https://bugs.webkit.org/show_bug.cgi?id=74120
Reviewed by Pavel Feldman.
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackForInspector):
- bindings/js/ScriptCallStackFactory.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
- bindings/v8/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackForInspector):
- bindings/v8/ScriptCallStackFactory.h:
- 1:11 PM Changeset in webkit [102374] by
-
- 2 edits in branches/safari-534.53-branch/Source/WebKit2
Merged r101719.
- 1:07 PM Changeset in webkit [102373] by
-
- 4 edits in trunk/Source/WebCore
[chromium] Remove dead code in compositor
https://bugs.webkit.org/show_bug.cgi?id=74103
Reviewed by James Robinson.
Tested via the compiler.
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
- platform/graphics/chromium/LayerRendererChromium.h:
- 1:06 PM Changeset in webkit [102372] by
-
- 4 edits in branches/safari-534.53-branch
Merged r101532.
- 1:05 PM Changeset in webkit [102371] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Need to adjust memory limit and viewport multipliers.
https://bugs.webkit.org/show_bug.cgi?id=74022
Patch by Eric Penner <epenner@google.com> on 2011-12-08
Reviewed by James Robinson.
- platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::highLimitBytes): Changing constants
(WebCore::TextureManager::reclaimLimitBytes): ditto
- 1:03 PM Changeset in webkit [102370] by
-
- 19 edits in branches/safari-534.53-branch/Source
Merged r101290.
- 12:59 PM Changeset in webkit [102369] by
-
- 2 edits in trunk/Source/WebKit/chromium
Chromium DEPS roll 112974 -> 113603
https://bugs.webkit.org/show_bug.cgi?id=74105
Patch by Elliot Poger <epoger@google.com> on 2011-12-08
Reviewed by Adam Barth.
- DEPS:
- 12:53 PM Changeset in webkit [102368] by
-
- 2 edits1 add in trunk/Source/WebCore
Add a platform EventLoop for iOS
https://bugs.webkit.org/show_bug.cgi?id=74043
Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-08
Reviewed by David Kilzer.
- WebCore.xcodeproj/project.pbxproj:
- platform/ios/EventLoopIOS.mm: Added.
(WebCore::EventLoop::cycle):
- 12:47 PM Changeset in webkit [102367] by
-
- 9 edits in branches/safari-534.53-branch/Source
Merged r100483.
- 12:41 PM Changeset in webkit [102366] by
-
- 9 edits in trunk/Source/WebCore
Web Inspector: return node counts on the document / detached root basis
https://bugs.webkit.org/show_bug.cgi?id=74104
Reviewed by Yury Semikhatsky.
- bindings/js/ScriptProfiler.h:
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::domNodeCount):
- bindings/v8/ScriptProfiler.h:
- inspector/Inspector.json:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getDOMNodeCount):
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
- inspector/InspectorMemoryAgent.h:
(WebCore::InspectorMemoryAgent::create):
- 12:34 PM Changeset in webkit [102365] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] remove headers from WebKit.gyp that moved into WebKit/chromium/public/platform
https://bugs.webkit.org/show_bug.cgi?id=74106
Reviewed by Darin Fisher.
- WebKit.gyp:
- 12:29 PM Changeset in webkit [102364] by
-
- 4 edits in trunk/Source/WebCore
RenderObject: Rename styleSlowCase() to styleInRegion().
Rubber-stamped by David Hyatt.
- WebCore.exp.in:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleInRegion):
- rendering/RenderObject.h:
(WebCore::RenderObject::style):
- 12:21 PM Changeset in webkit [102363] by
-
- 4 edits in trunk
[Qt][WK2] Unreviewed buildfix after r102352.
Source/WebKit2:
- DerivedSources.pri:
Tools:
- qmake/mkspecs/features/webkit2.prf:
- 12:16 PM Changeset in webkit [102362] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Exclude the four RenderTableCellDeathTest death tests for Android
https://bugs.webkit.org/show_bug.cgi?id=73997
The ASSERT_DEATH macro is not yet available in Google Test when
building for Android, which causes compilation errors. This code
will be removed once support lands in the GTest version Chromium
uses. See https://bugs.webkit.org/show_bug.cgi?id=74089.
Reviewed by Julien Chaffraix.
- tests/RenderTableCellTest.cpp:
- 12:11 PM Changeset in webkit [102361] by
-
- 3 edits in trunk/Source/WebKit/chromium
IndexedDB: WebKit API addition of IDBObjectStore.count() and IDBIndex.count()
https://bugs.webkit.org/show_bug.cgi?id=73685
Patch by Joshua Bell <jsbell@chromium.org> on 2011-12-08
Reviewed by Darin Fisher.
Implementation to follow - this just extends the WebKit API.
- public/WebIDBIndex.h:
(WebKit::WebIDBIndex::count):
- public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::count):
- 12:01 PM Changeset in webkit [102360] by
-
- 2 edits in trunk/Source/WebCore
Optimize RenderObject::containingBlock().
<http://webkit.org/b/74109>
Reviewed by David Hyatt.
When climbing the parent chain to locate the containing block-level element,
use !isRenderBlock() to reject renderers rather than checking against an arbitrary
list of non-block renderers and then rejecting anything that isn't a block anyway.
RenderObject::containingBlock() was very hot (2.0%) when scrolling on youtube.com.
This change takes it down to 1.0% (60% of which is RenderObject::isRenderBlock().)
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
- 11:39 AM Changeset in webkit [102359] by
-
- 2 edits in trunk/Source/WebCore
Define DEBUG_GL_COMMANDS only in debug builds.
https://bugs.webkit.org/show_bug.cgi?id=74083
Reviewed by Noam Rosenthal.
No tests added as this change does not affect functionality.
- platform/graphics/opengl/TextureMapperGL.cpp:
- 11:35 AM Changeset in webkit [102358] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Removed suppressions for inspector extensions tests following a fix in r10231.
- platform/chromium/test_expectations.txt:
- 11:32 AM Changeset in webkit [102357] by
-
- 8 edits in trunk/Source/WebCore
CompositeEditCommand should not be kept alive for undo and redo
https://bugs.webkit.org/show_bug.cgi?id=64414
Reviewed by Enrica Casucci.
This patch introduces EditCommandComposition that replaces CompositeEditCommand for
undo and redo purposes. Furthermore, we now keep a list of commands instead of a tree of commands
to unapply and reapply edit commands that composes an undoable action.
Each top-level CompositeEditCommand holds a ref-pointer to EditCommandComposition,
and applyCommandToComposite adds new SimpleEditCommands to the list.
- editing/CompositeEditCommand.cpp:
(WebCore::EditCommandComposition::create):
(WebCore::EditCommandComposition::doApply): Never used.
(WebCore::EditCommandComposition::doUnapply):
(WebCore::EditCommandComposition::doReapply):
(WebCore::EditCommandComposition::append):
(WebCore::CompositeEditCommand::~CompositeEditCommand): Add an assertion to ensure we didn't create
a composition for CompositeEditCommands that have parents.
(WebCore::CompositeEditCommand::doUnapply): Never used.
(WebCore::CompositeEditCommand::doReapply): Never used.
(WebCore::CompositeEditCommand::ensureComposition): Creates and attaches a EditCommandComposition.
(WebCore::CompositeEditCommand::applyCommandToComposite): Append a SimpleEditCommand to the composition.
- editing/CompositeEditCommand.h:
(WebCore::EditCommandComposition::EditCommandComposition):
(WebCore::CompositeEditCommand::composition):
(WebCore::toEditCommandComposition):
(WebCore::toCompositeEditCommand):
- editing/DeleteButtonController.cpp: Wrap RemoveNodeCommand in RemoveTargetCommand since top level
commands are now required to be a CompositeEditCommand.
(WebCore::RemoveTargetCommand::create):
(WebCore::RemoveTargetCommand::RemoveTargetCommand):
(WebCore::RemoveTargetCommand::doApply):
(WebCore::DeleteButtonController::deleteTarget):
- editing/EditCommand.cpp:
(WebCore::EditCommand::EditCommand): New constructor; used by EditCommandComposition.
(WebCore::EditCommand::apply): Create a composition for a top-level command.
(WebCore::EditCommand::unapply): Since we clear m_parent of SimpleEditCommand as soon as they are
added to EditCommandComposition, we can't use isTopLevelCommand() to differentiate EditCommandComposition
from SimpleEditCommand. Use isEditCommandComposition() instead.
(WebCore::EditCommand::reapply): Ditto.
(WebCore::compositionIfPossible):
(WebCore::EditCommand::setStartingSelection): Update the starting selection of EditCommandComposition.
(WebCore::EditCommand::setEndingSelection): Ditto.
(WebCore::EditCommand::setParent): Accepts a null pointer in order to avoid keeping a stale pointer in
m_parent inside SimpleEditCommand when CompositeEditCommand goes away.
- editing/EditCommand.h:
(WebCore::EditCommand::isSimpleEditCommand):
(WebCore::EditCommand::isCompositeEditCommand):
(WebCore::EditCommand::isEditCommandComposition):
(WebCore::EditCommand::parent):
(WebCore::toSimpleEditCommand):
- editing/Editor.cpp:
(WebCore::Editor::appliedEditing): Register a EditCommandComposition, instead of a CompositeEditCommand
to the undo stack.
(WebCore::Editor::unappliedEditing): Unapplied or reapplied commands are now always EditCommandComposition.
(WebCore::Editor::reappliedEditing):
- editing/Editor.h:
- 11:25 AM Changeset in webkit [102356] by
-
- 1 edit1 add in trunk/Source/WebCore
Add missing V8 bindings to get CSS_FILTERS to compile in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=74091
Reviewed by Kenneth Russell.
Will be covered by tests in css3/filters (when enabled).
- bindings/v8/custom/V8WebKitCSSFilterValueCustom.cpp: Added.
(WebCore::V8WebKitCSSFilterValue::indexedPropertyGetter):
- 11:19 AM Changeset in webkit [102355] by
-
- 3 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=73348
REGRESSION: Assertion when loading a page with a scrollable RenderLayer
-and corresponding-
<rdar://problem/10518918>
Reviewed by Darin Adler.
The main problem here is that certain delegate calls into AppKit for overlay
scrollbars can cause AppKit to call back into WebKit looking for more information.
The assertion happens when WebKit tells AppKit that the scroll position has
changed during a layout, and AppKit immediately asks WebKit to convert some
coordinates, and WebKit asserts that you shouldn't do that while a layout is still
happening. It's still possible for AppKit to call this delegate method while a
layout is happening, and we should guard against that. This patch, however, does
not do that.
This change instead addresses the reason this assertion started happening much
more frequently recently, which is that it recently became true that
notifyPositionChanged() can be called when the position has not changed. To fix
the assertion AND the bug that that change was intended to fix, we can just make
sure that either the position OR the scroll origin has changed before calling
notifyPositionChanged().
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
Call resetScrollOriginChanged() after the scroll instead of before so that we know
whether or not to call notifyPositionChanged().
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
- 11:16 AM Changeset in webkit [102354] by
-
- 6 edits in trunk/Tools
Make finding crash logs by PID work on Snow Leopard
Crash Reporter on Snow Leopard doesn't set the "app_description" extended attribute that we
were using to check the PID of the crashed process. (Crash Reporter on Lion does.) Now we
read the first line of the crash log and pull the PID out of there.
Fixes <http://webkit.org/b/74094> "webkit-patch crash-log <process> <PID>" doesn't work on
Snow Leopard
Reviewed by Darin Adler.
- Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs._find_newest_log_darwin): Read the first line of the crash log to get the process
name and PID for the log, rather than checking the Lion-only app_description extended
attribute. We now also reject the log if the process name doesn't match what we expect.
- Scripts/webkitpy/common/system/crashlogs_unittest.py:
(make_mock_crash_report_darwin): Added. Returns a mock crash report given a process name and
PID.
(CrashLogsTest.assertLinesEqual): Added. This is a compatibility shim around
unittest.TestCase.assertMultiLineEqual, which didn't exist before Python 2.7.
(CrashLogsTest.test_find_log_darwin): Made the mock crash reports more believable by using
the new make_mock_crash_report_darwin function. Also added tests for files that can't be
read, files that actually contain a crash log for some other process, and files that are
misformatted.
- Scripts/webkitpy/common/system/filesystem.py: Removed FileSystem.getxattr, which is now
unused.
- Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.init): Removed xattr support, which is now unused.
(MockFileSystem.open_text_file_for_reading): Changed to actually pass the file's data to
ReadableTextFileObject. This function was completely broken before!
(ReadableBinaryFileObject.init): Made the data parameter non-optional to try to prevent
bugs like the above.
(ReadableTextFileObject.init): Added. Wraps the data in a StringIO object so we can do
things like readline() and seek().
(ReadableTextFileObject.close):
(ReadableTextFileObject.read):
Added. We override the superclass implementation to account for using a StringIO object.
(ReadableTextFileObject.readline):
(ReadableTextFileObject.seek):
Added. These just call through to StringIO.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_crash_log):
(MainTest.test_web_process_crash_log):
Changed to use make_mock_crash_report_darwin.
- 11:12 AM Changeset in webkit [102353] by
-
- 1 edit4 adds16 deletes in trunk/LayoutTests
Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=73866
Patch by Jacob Goldstein <jacobg@adobe.com> on 2011-12-08
Reviewed by Darin Adler.
- fast/regions/positioned-objects-block-static-in-regions-expected.html: Added.
- fast/regions/positioned-objects-block-static-in-rtl-regions-expected.html: Added.
- fast/regions/positioned-objects-block-static-spanning-regions-expected.html: Added.
- fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.html: Added.
- platform/efl/fast/regions/positioned-objects-block-static-in-regions-expected.png: Removed.
- platform/efl/fast/regions/positioned-objects-block-static-in-regions-expected.txt: Removed.
- platform/efl/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.png: Removed.
- platform/efl/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.txt: Removed.
- platform/efl/fast/regions/positioned-objects-block-static-spanning-regions-expected.png: Removed.
- platform/efl/fast/regions/positioned-objects-block-static-spanning-regions-expected.txt: Removed.
- platform/efl/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.png: Removed.
- platform/efl/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.txt: Removed.
- platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.png: Removed.
- platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.txt: Removed.
- platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.png: Removed.
- platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.txt: Removed.
- platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-expected.png: Removed.
- platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-expected.txt: Removed.
- platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.png: Removed.
- platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.txt: Removed.
- 11:06 AM Changeset in webkit [102352] by
-
- 26 edits7 copies7 moves2 adds in trunk
[WK2] Add permissions support (73960)
https://bugs.webkit.org/show_bug.cgi?id=73960
<rdar://problem/10357008>
Reviewed by Darin Adler.
Source/WebKit2:
- DerivedSources.make: Moved notification files to its own directory. Need to add that path.
- WebKit2.xcodeproj/project.pbxproj: New header and impl files.
- Target.pri: Ditto.
- GNUmakefile.am: Ditto.
- win/WebKit2.vcproj: Ditto.
- win/WebKit2Common.vsprops: Add path to Notifications directory.
Implement permission functions, which go through permission request manager.
- WebProcess/WebCoreSupport/WebNotificationClient.cpp:
(WebKit::WebNotificationClient::requestPermission):
(WebKit::WebNotificationClient::cancelRequestsForPermission):
(WebKit::WebNotificationClient::checkPermission):
New NotificationPermissionRequestManager to make and cancel permission requests, and to retrieve current
policy.
- WebProcess/Notifications/NotificationPermissionRequestManager.cpp: Added.
(WebKit::generateRequestID):
(WebKit::NotificationPermissionRequestManager::create):
(WebKit::NotificationPermissionRequestManager::NotificationPermissionRequestManager):
(WebKit::NotificationPermissionRequestManager::startRequest): Keep track of the provided callback once
policy decision is made.
(WebKit::NotificationPermissionRequestManager::cancelRequest):
(WebKit::NotificationPermissionRequestManager::permissionLevel): Retrieve level through a synchronous
message to the proxy.
(WebKit::NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision): Invoke the callback.
- WebProcess/Notifications/NotificationPermissionRequestManager.h: Added.
(WebKit::isRequestIDValid): Make sure any provided request IDs are valid.
Added new NotificationPermissionRequest class.
- UIProcess/Notifications/NotificationPermissionRequest.cpp: Added.
(WebKit::NotificationPermissionRequest::create):
(WebKit::NotificationPermissionRequest::NotificationPermissionRequest):
(WebKit::NotificationPermissionRequest::allow): Notify manager of decision.
(WebKit::NotificationPermissionRequest::deny): Ditto.
(WebKit::NotificationPermissionRequest::invalidate): Disassociate with manager.
(WebKit::NotificationPermissionRequest::type):
- UIProcess/Notifications/NotificationPermissionRequest.h: Added.
WKAPI support for NotificationPermissionRequest:
- Shared/API/c/WKBase.h:
- Shared/APIObject.h:
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKNotificationPermissionRequest.cpp: Added.
(WKNotificationPermissionRequestGetTypeID):
(WKNotificationPermissionRequestAllow):
(WKNotificationPermissionRequestDeny):
- UIProcess/API/C/WKNotificationPermissionRequest.h: Added.
Other additions to WK API:
- UIProcess/API/C/WKNotificationProvider.h: Added new callback for WKNotificationProviders, to return policy
for a given security origin.
- UIProcess/API/C/WKPage.h: Added new callback to WKPageUIClient to ask user to decide on policy.
New NotificationPermissionRequestManagerProxy to create requests.
- UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp: Added.
(WebKit::NotificationPermissionRequestManagerProxy::NotificationPermissionRequestManagerProxy):
(WebKit::NotificationPermissionRequestManagerProxy::invalidateRequests):
(WebKit::NotificationPermissionRequestManagerProxy::createRequest):
(WebKit::NotificationPermissionRequestManagerProxy::didReceiveNotificationPermissionDecision):
- UIProcess/Notifications/NotificationPermissionRequestManagerProxy.h: Added.
Added new message to notification manager: NotificationPermissionLevel, to retrieve policy. The current
JS API retrieves the permission synchronously, so the message needs to be sent synchronously also.
- UIProcess/Notifications/WebNotificationManagerProxy.messages.in: Moved from Source/WebKit2/UIProcess/WebNotificationManagerProxy.messages.in.
- UIProcess/Notifications/WebNotificationProvider.cpp: Moved from Source/WebKit2/UIProcess/WebNotificationProvider.cpp.
(WebKit::WebNotificationProvider::policyForNotificationPermissionAtOrigin): Added.
- UIProcess/Notifications/WebNotificationProvider.h: Moved from Source/WebKit2/UIProcess/WebNotificationProvider.h.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveSyncMessage): Boilerplate to forward messages to notification manager.
- UIProcess/Notifications/WebNotificationManagerProxy.cpp: Moved from Source/WebKit2/UIProcess/WebNotificationManagerProxy.cpp.
(WebKit::WebNotificationManagerProxy::create):
(WebKit::WebNotificationManagerProxy::WebNotificationManagerProxy):
(WebKit::WebNotificationManagerProxy::invalidate):
(WebKit::WebNotificationManagerProxy::initializeProvider):
(WebKit::WebNotificationManagerProxy::didReceiveMessage):
(WebKit::WebNotificationManagerProxy::didReceiveSyncMessage):
(WebKit::WebNotificationManagerProxy::show):
(WebKit::WebNotificationManagerProxy::cancel):
(WebKit::WebNotificationManagerProxy::didDestroyNotification):
(WebKit::WebNotificationManagerProxy::notificationPermissionLevel): Retrieve the policy from the provider.
(WebKit::WebNotificationManagerProxy::providerDidShowNotification):
(WebKit::WebNotificationManagerProxy::providerDidClickNotification):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):
- UIProcess/Notifications/WebNotificationManagerProxy.h: Moved from Source/WebKit2/UIProcess/WebNotificationManagerProxy.h.
(WebKit::WebNotificationManagerProxy::clearContext):
(WebKit::WebNotificationManagerProxy::type):
Added NotificationPermissionRequestManagerProxy to WebPageProxy, to allow a request for permission to
go through to the UI client. Added new message to WebPageProxy, RequestNotificationPermission.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close): Invalidate pending requests.
(WebKit::WebPageProxy::processDidCrash): Ditto.
(WebKit::WebPageProxy::requestNotificationPermission): Forward request to UI client.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::decidePolicyForNotificationPermissionRequest):
- UIProcess/WebUIClient.h:
Added new message DidReceiveNotificationPermissionDecision. The WebPage forwards the message to the
permission request manager.
- WebProcess/WebPage/WebPage.messages.in: Added new message DidReceiveNotificationPermissionDecision
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::notificationPermissionRequestManager): Create manager on request.
(WebKit::WebPage::didReceiveNotificationPermissionDecision):
- WebProcess/WebPage/WebPage.h:
Moving files to Notifications/ subdirectory.
- UIProcess/Notifications/WebNotification.cpp: Moved from Source/WebKit2/UIProcess/WebNotification.cpp.
- UIProcess/Notifications/WebNotification.h: Moved from Source/WebKit2/UIProcess/WebNotification.h.
Tools:
Add null function item to comply with added callback to WKPageUIClient.
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
- 10:55 AM Changeset in webkit [102351] by
-
- 12 edits in trunk/Source/WebCore
Fixing support for static conditional overloaded functions.
https://bugs.webkit.org/show_bug.cgi?id=74068
Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-12-08
Reviewed by Adam Barth.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation): Pushing "static" keyword after condition "#if".
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::overloadedMethod1): Added newly generated bindings.
- bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
(webkit_dom_test_obj_overloaded_method1):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
- bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod1):
- bindings/scripts/test/JS/JSTestObj.h: Ditto.
- bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
- bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
(-[DOMTestObj overloadedMethod1:]):
- bindings/scripts/test/TestObj.idl: Ditto.
- bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
(WebCore::TestObjInternal::overloadedMethod11Callback):
(WebCore::TestObjInternal::overloadedMethod12Callback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::ConfigureV8TestObjTemplate):
- 10:53 AM Changeset in webkit [102350] by
-
- 1 edit2 adds in trunk/LayoutTests
Added a test for css number types problem.
It's testing the css number types parser, where 'px' defined like escape sequences (\70\78) or uppercase / lowercase.
https://bugs.webkit.org/show_bug.cgi?id=72007
Patch by Szilard Ledan <Ledan-Muntean.Szilard@stud.u-szeged.hu> on 2011-12-08
Reviewed by Darin Adler.
- fast/css/parsing-css-number-types-expected.txt: Added.
- fast/css/parsing-css-number-types.html: Added.
- 10:50 AM Changeset in webkit [102349] by
-
- 3 edits in trunk/Source/WebCore
Remove EventListenerMap destructor.
<http://webkit.org/b/74096>
Reviewed by Darin Adler.
Let the compiler generate ~EventListenerMap(). We only needed it when the hash map
was managing raw pointers.
We're losing the no-iterators assertion from clear() by doing this, but that was
superfluous to begin with - we were just using it to avoid duplicating code.
- dom/EventListenerMap.cpp:
- dom/EventListenerMap.h:
- 10:38 AM Changeset in webkit [102348] by
-
- 6 edits1 copy1 add in trunk/Tools
[Qt] Visualize mock points in the Qt MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=74074
Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-12-08
Reviewed by Tor Arne Vestbø.
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
- MiniBrowser/qt/BrowserWindow.h:
- MiniBrowser/qt/MiniBrowser.qrc:
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify):
(MiniBrowserApplication::sendTouchEvent):
- MiniBrowser/qt/MiniBrowserApplication.h:
- MiniBrowser/qt/icons/touchpoint.png: Added.
- MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
- 10:23 AM Changeset in webkit [102347] by
-
- 1 edit2 moves1 add2 deletes in trunk/LayoutTests
[chromium] Rebaseline printing/width-overflow.html on Chromium Mac Leopard.
- platform/chromium-cg-mac-snowleopard/printing/width-overflow-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/printing/width-overflow-expected.png.
- platform/chromium-linux/printing/width-overflow-expected.txt: Removed.
- platform/chromium-mac-leopard/printing/width-overflow-expected.png: Added.
- platform/chromium-mac-snowleopard/printing/width-overflow-expected.txt: Removed.
- platform/chromium/printing/width-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/printing/width-overflow-expected.txt.
- 9:57 AM Changeset in webkit [102346] by
-
- 7 edits1 add in trunk/Source/WebKit2
[WebKit2] Initialize threading in UI process.
https://bugs.webkit.org/show_bug.cgi?id=70127
Reviewed by Anders Carlsson.
- CMakeLists.txt:
- GNUmakefile.am:
- Shared/APIObject.cpp: Added.
(WebKit::APIObject::APIObject):
- Shared/APIObject.h:
- Target.pri:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- 9:25 AM Changeset in webkit [102345] by
-
- 3 edits in branches/safari-534.53-branch/Source/WebKit2
Merged r99912.
- 9:23 AM Changeset in webkit [102344] by
-
- 14 edits in branches/safari-534.53-branch/Source/WebKit2
Merged r99911.
- 8:36 AM Changeset in webkit [102343] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skipping failing test platform/mac/accessibility/search-with-frames.html
- 8:16 AM Changeset in webkit [102342] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] [WK2] Directly composited images doesn't render
https://bugs.webkit.org/show_bug.cgi?id=74058
Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-12-08
Reviewed by Noam Rosenthal.
Attach image to WebGraphicsLayer even if layerTreeTileClient is not set
and create/assign remote image tiles later during sync.
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
- 8:06 AM Changeset in webkit [102341] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r102334): Various Qt WK2 layout tests crash
Reviewed by Tor Arne Vestbø.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState): Add missing null pointer check for the editable
element (scope) before calling innerText.
- 7:46 AM Changeset in webkit [102340] by
-
- 5 edits in trunk
[Qt] WebKitTestRunner crashes with debug builds https://bugs.webkit.org/show_bug.cgi?id=74090
Reviewed by Tor Arne Vestbø.
Source/WebKit2:
Export private C++ API style platformInitialize function needed
by low-level WTR.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::platformInitialize):
- UIProcess/API/qt/qquickwebview_p.h:
Tools:
- WebKitTestRunner/qt/TestControllerQt.cpp:
(WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
to ensure WTF/JSC threading is initialized.
- 7:45 AM Changeset in webkit [102339] by
-
- 3 edits in trunk/Source/WebCore
Provide more specific error description for SocketStreamError.
https://bugs.webkit.org/show_bug.cgi?id=74066
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-12-08
Reviewed by Martin Robinson.
No new tests because this change just improve error messages for unexpected failures.
- platform/network/soup/SocketStreamError.h: Add an argument for passing error description.
(WebCore::SocketStreamError::SocketStreamError):
- platform/network/soup/SocketStreamHandleSoup.cpp: Add error description for SocketStreamError.
(WebCore::SocketStreamHandle::connected):
(WebCore::SocketStreamHandle::readBytes):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
- 7:32 AM Changeset in webkit [102338] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Fix non-animated pinch-zoom scale commit.
https://bugs.webkit.org/show_bug.cgi?id=74007
Reviewed by Kenneth Rohde Christiansen.
The update deferrer object was only destroyed at the end of the animation
and wouldn't be if the pinch-zoom was ended within legal bounds.
This patch also makes sure that the deferrer isn't destroyed and re-created
once the animation is started if it was already there.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
- UIProcess/qt/QtViewportInteractionEngine.h:
- 7:30 AM Changeset in webkit [102337] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r101683): QQuickWebView doesn't work with OpenGL/ES 2.0
https://bugs.webkit.org/show_bug.cgi?id=74077
Reviewed by Kenneth Rohde Christiansen.
Replace Desktop OpenGL idiom of using gl_Vertex with a simple vertex attribute
that's tied to the same register 0 (by being the first in the array).
- UIProcess/API/qt/qquickwebpage.cpp:
(PageProxyMaterialShader::attributeNames): Define "vertex" attribute, which is
bound to register 0, which is the current vertex.
(PageProxyMaterialShader::vertexShader): Use the vertex attribute instead of the
built-in gl_Vertex, which is only present in Desktop GL.
- 7:29 AM Changeset in webkit [102336] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Fix the memory leak of AC layer update message contents on the UI process.
https://bugs.webkit.org/show_bug.cgi?id=74012
Reviewed by Noam Rosenthal.
Since the messages didn't have a virtual destructor, the destructor
of child class members wouldn't be called and would cause the all tile
update buffers, contained in a QImage, to be leaked as well.
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeMessageToRenderer::~LayerTreeMessageToRenderer):
- 6:50 AM Changeset in webkit [102335] by
-
- 2 edits in trunk/Tools
fix build-webkit --chromium after breakage in r102201
https://bugs.webkit.org/show_bug.cgi?id=74031
Reviewed by Tony Chang.
- Scripts/webkitdirs.pm:
(buildChromium):
- 6:27 AM Changeset in webkit [102334] by
-
- 8 edits1 add in trunk/Source/WebKit2
Upsteam the Qt changes to the EditorState https://bugs.webkit.org/show_bug.cgi?id=74080
Reviewed by Simon Hausmann.
We are not doing the serialization manually due to it not being a POD
structure anymore in the case of Qt.
- GNUmakefile.am:
- Shared/EditorState.h:
(WebKit::EditorState::EditorState):
- Target.pri:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):
- win/WebKit2.vcproj:
- 6:23 AM Changeset in webkit [102333] by
-
- 28 edits15 adds in trunk
[CSSRegions][CSSOM] Implement NamedFlow interface
https://bugs.webkit.org/show_bug.cgi?id=66642
Reviewed by David Hyatt.
Add WebKitNamedFlow to support the NamedFlow interface. No methods are
yet implemented on this interface. The NamedFlow object is a live object.
The first time user asks for it, it gets a valid JS object whose properties
will reflect the changes to the flow thread.
Source/WebCore:
Tests: fast/regions/webkit-named-flow-existing-flow.html
fast/regions/webkit-named-flow-flow-added.html
fast/regions/webkit-named-flow-modified-flow.html
fast/regions/webkit-named-flow-non-existing-flow.html
fast/regions/webkit-named-flow-removed-flow.html
fast/regions/webkit-named-flow-same-object.html
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/gobject/GNUmakefile.am:
- dom/DOMAllInOne.cpp:
- dom/Document.cpp:
(WebCore::Document::webkitGetFlowByName):
- dom/Document.h:
- dom/Document.idl:
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
- dom/WebKitNamedFlow.cpp: Added.
(WebCore::WebKitNamedFlow::WebKitNamedFlow):
(WebCore::WebKitNamedFlow::~WebKitNamedFlow):
- dom/WebKitNamedFlow.h: Added.
(WebCore::WebKitNamedFlow::create):
- dom/WebKitNamedFlow.idl: Added.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::ensureNamedFlow):
- rendering/RenderFlowThread.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
- rendering/RenderView.cpp:
(WebCore::RenderView::ensureRenderFlowThreadWithName):
- rendering/RenderView.h:
LayoutTests:
- fast/dom/Window/window-properties-expected.txt:
- fast/regions/webkit-named-flow-existing-flow-expected.txt: Added.
- fast/regions/webkit-named-flow-existing-flow.html: Added.
- fast/regions/webkit-named-flow-flow-added-expected.txt: Added.
- fast/regions/webkit-named-flow-flow-added.html: Added.
- fast/regions/webkit-named-flow-modified-flow-expected.txt: Added.
- fast/regions/webkit-named-flow-modified-flow.html: Added.
- fast/regions/webkit-named-flow-non-existing-flow-expected.txt: Added.
- fast/regions/webkit-named-flow-non-existing-flow.html: Added.
- fast/regions/webkit-named-flow-removed-flow-expected.txt: Added.
- fast/regions/webkit-named-flow-removed-flow.html: Added.
- fast/regions/webkit-named-flow-same-object-expected.txt: Added.
- fast/regions/webkit-named-flow-same-object.html: Added.
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/mac/fast/dom/Window/window-properties-expected.txt:
- platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/win/fast/dom/Window/window-properties-expected.txt:
- 5:04 AM Changeset in webkit [102332] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r102280.
http://trac.webkit.org/changeset/102280
https://bugs.webkit.org/show_bug.cgi?id=74031
Chromium/Windows build is broken
- Scripts/webkitdirs.pm:
(buildChromium):
- 3:52 AM Changeset in webkit [102331] by
-
- 1 edit1 delete in trunk/Source/WebKit2
2011-12-08 Gopal Raghavan <gopal.1.raghavan@nokia.com>
[Qt] cleanup qmlplugin
https://bugs.webkit.org/show_bug.cgi?id=73834
Reviewed by Tor Arne Vestbø.
Removed empty folder qmlplugin.
- 3:24 AM Changeset in webkit [102330] by
-
- 6 edits1 delete in trunk/Source/WebCore
Unreviewed, rolling out r102321.
http://trac.webkit.org/changeset/102321
https://bugs.webkit.org/show_bug.cgi?id=74072
"Breaks all Chromium clobbered builds" (Requested by apavlov_
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-08
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/scripts/action_derivedsourcesallinone.py:
(main):
- WebCore.gypi:
- bindings/scripts/generate-bindings.pl:
- page/DOMWindow.idl:
- webaudio/DOMWindowWebAudio.idl: Removed.
- 3:09 AM Changeset in webkit [102329] by
-
- 2 edits in trunk/Tools
Adding myself to committers list.
Unreviewed.
- Scripts/webkitpy/common/config/committers.py:
- 2:46 AM Changeset in webkit [102328] by
-
- 4 edits in trunk/Source/WebCore
Refactoring: Editor::requestCheckingFor should take SpellCheckRequest object.
https://bugs.webkit.org/show_bug.cgi?id=74033
Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-08
Reviewed by Hajime Morita.
SpellChecker::requestCheckingFor takes SpellCheckRequest object in order to make it easy to
pass necessary information to requestCheckingFor.
No new tests. Covered by existing tests.
- editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment):
Uses the new interface.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): ditto.
- editing/SpellChecker.cpp:
(WebCore::SpellCheckRequest::SpellCheckRequest):
(WebCore::SpellCheckRequest::~SpellCheckRequest):
(WebCore::SpellCheckRequest::create):
Creates a new SpellCheckRequest object.
(WebCore::SpellChecker::requestCheckingFor):
Uses the new interface.
(WebCore::SpellChecker::didCheck):
- editing/SpellChecker.h:
(WebCore::SpellCheckRequest::setSequence):
(WebCore::SpellCheckRequest::sequence):
(WebCore::SpellCheckRequest::checkingRange):
(WebCore::SpellCheckRequest::paragraphRange):
(WebCore::SpellCheckRequest::text):
(WebCore::SpellCheckRequest::mask):
(WebCore::SpellCheckRequest::rootEditableElement):
- 2:44 AM Changeset in webkit [102327] by
-
- 3 edits in trunk/LayoutTests
Fix failed layout test, bufferedAmount-after-close-in-busy.html
https://bugs.webkit.org/show_bug.cgi?id=73666
Originally the failed layout test use simple_wsh server side WebSocket
handler. But this handler starts closing handshake after a while and
it bring flakiness on the test.
Now the test use echo_wsh instead of simple_wsh. It never perform
server initiated closing handshake.
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-12-08
Reviewed by Kent Tamura.
- http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html:
- platform/gtk/Skipped:
- 2:37 AM Changeset in webkit [102326] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Remove duplicated entries from skipped list.
- platform/qt-5.0/Skipped:
- 2:26 AM Changeset in webkit [102325] by
-
- 2 edits in trunk/LayoutTests
[WK2] Unreviewed gardening.
WebKitTestRunner needs layoutTestController.setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=42689
- platform/wk2/Skipped: Skip new failing tests.
- 2:12 AM Changeset in webkit [102324] by
-
- 35 edits in trunk
Unreviewed, rolling out r102323.
http://trac.webkit.org/changeset/102323
https://bugs.webkit.org/show_bug.cgi?id=74069
Caused Chromium and GTK build failure (Requested by bashi on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-08
.:
- Source/autotools/symbols.filter:
Source/WebCore:
- testing/Internals.cpp:
(WebCore::Internals::getPageScaleFactor):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
- compositing/geometry/fixed-position-composited-page-scale-down.html:
- compositing/geometry/fixed-position-composited-page-scale.html:
- compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
- compositing/geometry/fixed-position-iframe-composited-page-scale.html:
- compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
- compositing/geometry/fixed-position-transform-composited-page-scale.html:
- compositing/scaling/tiled-layer-recursion.html:
- fast/dom/Element/scale-page-bounding-client-rect.html:
- fast/dom/Element/scale-page-client-rects.html:
- fast/dom/Range/scale-page-bounding-client-rect.html:
- fast/dom/Range/scale-page-client-rects.html:
- fast/events/scale-and-scroll-body.html:
- fast/events/scale-and-scroll-iframe-body.html:
- fast/events/scale-and-scroll-iframe-window.html:
- fast/events/scale-and-scroll-window.html:
- fast/events/script-tests/page-scaled-mouse-click-iframe.js:
(iframeLoaded):
- fast/events/script-tests/page-scaled-mouse-click.js:
- fast/events/scroll-in-scaled-page-with-overflow-hidden.html:
- fast/events/touch/page-scaled-touch-gesture-click.html:
- fast/frames/frame-set-rotation-hit.html:
- fast/frames/frame-set-scaling-hit.html:
- fast/frames/iframe-double-scale-contents.html:
- fast/repaint/background-scaling.html:
- fast/repaint/scale-page-shrink.html:
- fast/transforms/selection-bounds-in-transformed-view.html:
- 1:18 AM Changeset in webkit [102323] by
-
- 35 edits in trunk
Move scalePageBy from eventSender to window.internals
https://bugs.webkit.org/show_bug.cgi?id=64512
Reviewed by Simon Fraser.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
Added setPageScaleFactor to window.internals.
Renamed window.internals.getPageScaleFactor to window.internals.pageScaleFactor
to match the webkit style.
- testing/Internals.cpp:
(WebCore::Internals::pageScaleFactor):
(WebCore::Internals::setPageScaleFactor):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
Updated layout tests to use window.internals.setPageScaleFactor.
- compositing/geometry/fixed-position-composited-page-scale-down.html:
- compositing/geometry/fixed-position-composited-page-scale.html:
- compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
- compositing/geometry/fixed-position-iframe-composited-page-scale.html:
- compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
- compositing/geometry/fixed-position-transform-composited-page-scale.html:
- compositing/scaling/tiled-layer-recursion.html:
- fast/dom/Element/scale-page-bounding-client-rect.html:
- fast/dom/Element/scale-page-client-rects.html:
- fast/dom/Range/scale-page-bounding-client-rect.html:
- fast/dom/Range/scale-page-client-rects.html:
- fast/events/scale-and-scroll-body.html:
- fast/events/scale-and-scroll-iframe-body.html:
- fast/events/scale-and-scroll-iframe-window.html:
- fast/events/scale-and-scroll-window.html:
- fast/events/script-tests/page-scaled-mouse-click-iframe.js:
(iframeLoaded):
- fast/events/script-tests/page-scaled-mouse-click.js:
- fast/events/scroll-in-scaled-page-with-overflow-hidden.html:
- fast/events/touch/page-scaled-touch-gesture-click.html:
- fast/frames/frame-set-rotation-hit.html:
- fast/frames/frame-set-scaling-hit.html:
- fast/frames/iframe-double-scale-contents.html:
- fast/repaint/background-scaling.html:
- fast/repaint/scale-page-shrink.html:
- fast/transforms/selection-bounds-in-transformed-view.html:
- 1:01 AM Writing Layout Tests for DumpRenderTree edited by
- (diff)
- 12:48 AM Changeset in webkit [102322] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, remove duplicate test expectations.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08
- platform/chromium/test_expectations.txt:
- 12:20 AM Changeset in webkit [102321] by
-
- 6 edits1 add in trunk/Source/WebCore
Use the [Supplemental] IDL for webaudio attributes in Chromium
https://bugs.webkit.org/show_bug.cgi?id=73394
Reviewed by Adam Barth.
- Overview: Using the [Supplemental] IDL, this patch moves the attribute
declarations of webaudio from DOMWindow.idl into a new IDL file
webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained
feature (aka a module).
- This patch changes the build flow of WebCore.gyp as follows:
Previous build flow:
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;
}
New build flow (See the discussions in bug 72138 for more details):
resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl;
}
- This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL
will be removed after build scripts for all platforms support the [Supplemental] IDL.
The motivation for the [Supplemented] IDL is as follows:
In order to support the [Supplemental] IDL, we need to
(1) run resolve-supplemental.pl and generate supplemental_dependency.tmp
(2) and run generate-bindings.pl with the supplemental_dependency.tmp.
This build flow requires a change on the following build scripts,
but changing all the build scripts all at once without any regression is too difficult:
- DerivedSources.make
- DerivedSources.pri
- GNUmakefile.am
- PlatformBlackBerry.cmake
- UseJSC.cmake
- UseV8.cmake
- WebCore.vcproj/MigrateScripts
- WebCore.vcproj/WebCore.vcproj
- bindings/gobject/GNUmakefile.am
- WebCore.gyp/WebCore.gyp
Thus, we are planning to change the build scripts one by one, which implies that
we need to allow the temporary state in which some build scripts support [Supplemental] IDL
but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented].
The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental]
in another IDL file somewhere, like this:
DOMWindowWebAudio.idl:
interface [
Supplemental=DOMWindow
] DOMWindowWebAudio {
attribute attr1;
attribute attr2;
};
DOMWindow.idl:
interface [
] DOMWindow {
attribute [Supplemented] attr1; This line will be removed after all build scripts support the [Su IDL
attribute [Supplemented] attr2; This line will be removed after all build scripts support the [Su IDL.
attribute attr3;
attribute attr4;
};
Assuming these IDL files, this patch implements the following logic in generate-bindings.pl:
- If a given build script supports the [Supplemental] IDL, generate-bindings.pl ignores all attributes with the [Supplemented] IDL.
- Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL as normal attributes and instead ignores all attributes with the [Supplemental] IDL (i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL).
Tests: webaudio/*
- WebCore.gyp/WebCore.gyp: Describes the build flow that I described above.
- WebCore.gyp/scripts/action_derivedsourcesallinone.py:
(main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file. If the file name is a "/cygdrive/c/..."-style path, it is converted to a "C:\cygwin\..."-style path by the cygpath command.
- WebCore.gypi: Added DOMWindowWebAudio.idl.
- bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL.
- page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL.
- webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in DOMWindow.idl.
