Context Navigation

← Previous Period
Next Period →

Timeline

Dec 15, 2011:

11:59 PM Changeset in webkit [103034] by Martin Robinson

6 edits in trunk/Source

Fix 'make dist' in preparation for the GTK+ release.

Source/JavaScriptCore:

GNUmakefile.list.am: Add missing header.

Source/WebCore:

GNUmakefile.list.am: Add missing header.

Source/WebKit2:

GNUmakefile.am: Add missing header.

11:55 PM Changeset in webkit [103033] by morrita@google.com

2 edits in trunk/LayoutTests

Unreviewed expectations update.

html5lib/webkit-resumer-expected.txt:

11:26 PM Changeset in webkit [103032] by morrita@google.com

2 edits in trunk/LayoutTests

Unreviewed test_expectations.txt update.

platform/chromium/test_expectations.txt:

11:18 PM Changeset in webkit [103031] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Don't create empty files on error.
https://bugs.webkit.org/show_bug.cgi?id=74373

Patch by Rafael Ávila de Espíndola <rafael.espindola@gmail.com> on 2011-12-15
Reviewed by Ryosuke Niwa.

css/makeprop.pl:
css/makevalues.pl:
make-hash-tools.pl:

11:14 PM Changeset in webkit [103030] by commit-queue@webkit.org

10 edits
1 add in trunk/Source

PODIntervalTree takes 1.7MB memory on www.nytimes.com.
https://bugs.webkit.org/show_bug.cgi?id=73712

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2011-12-15
Reviewed by Kenneth Russell.

Source/WebCore:

For a RenderBlock which has floating objects inside, we will create a PODIntervalTree and a PODArena with
at least one 16KB chunk. A page could have a large number of such RenderBlocks and they could take huge
amount of memory. To fix that, we can create a shared PODArena in the root RenderView. Instead of having
their own PODArena, each RenderBlock with floating objects could share this PODArena to reduce memory consumption.

The shared PODArena could grow unboundedly if we keep removing and adding floating objects. We can fix that
by reusing the freed memory in each chunk. However, a PODArena could allocate objects of different sizes and
it would be complex to keep track of the size for each allocation in PODArena. To address that, this patch
added class PODFreeListArena<T> which only allocates objects of type T (hence the same size). We can then use a
free list to track freed nodes inside the chunk and reuse the free nodes in future allocations.

Manually tested on nytimes.com and the heap consumption of PODIntervalTree reduced from 1.7MB to 16KB. Performance
doesn't regress on test PerformanceTests/Layout/floats.html.

WebCore.xcodeproj/project.pbxproj: add new header file PODFreeListArena.h.
platform/PODArena.h:

(WebCore::PODArena::~PODArena): change dtor to virtual.
(WebCore::PODArena::Chunk::~Chunk): ditto.

platform/PODFreeListArena.h: Added.

(WebCore::PODFreeListArena::create):
(WebCore::PODFreeListArena::allocateObject): allocate an object.
(WebCore::PODFreeListArena::freeObject): free an object, find the right chunk and update its free list.
(WebCore::PODFreeListArena::allocate): allocate memory from the free list or current chunk.
(WebCore::PODFreeListArena::FreeListChunk::FreeListChunk): add m_freeList to track freed cells.
(WebCore::PODFreeListArena::FreeListChunk::allocate): reuse a free cell if there is one.
(WebCore::PODFreeListArena::FreeListChunk::free): make the memory taken by this object is free, and link it to m_freeList.
(WebCore::PODFreeListArena::FreeListChunk::contains): check if a pointer is inside this chunk.
(WebCore::PODFreeListArena::FreeListChunk::hasFreeList): check if this chunk has free cells.

platform/PODRedBlackTree.h:

(WebCore::PODRedBlackTree::PODRedBlackTree): take PODFreeListArena instead of PODArena, since nodes of a particular PODRedBlackTree

is always of the same size.

(WebCore::PODRedBlackTree::clear): mark all nodes before clearing the tree.
(WebCore::PODRedBlackTree::initIfNeeded): add initIfNeeded to take an external PODFreeListArena.
(WebCore::PODRedBlackTree::add):
(WebCore::PODRedBlackTree::deleteNode): mark the node free in arena after it is removed from the tree.
(WebCore::PODRedBlackTree::markFree): mark all node free in the tree.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::FloatingObjects::computePlacedFloatsTree): passing the shared PODFreeListArena to m_placedFloatsTree.

rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObjects::FloatingObjects):

rendering/RenderView.cpp:

(WebCore::RenderView::intervalArena): create the shared PODFreeListArena lazily.

rendering/RenderView.h:

Source/WebKit/chromium:

Change the test code in chromium port since PODRedBlackTree now takes PODFreeListArena<T>
in its constructor.

tests/PODRedBlackTreeTest.cpp:

(WebCore::TEST):

11:02 PM Changeset in webkit [103029] by dmazzoni@google.com

26 edits in trunk/LayoutTests

Unreviewed; rebaseline Chromium speech input image tests.

10:46 PM Changeset in webkit [103028] by weinig@apple.com

2 edits in trunk/Source/JavaScriptCore

<rdar://problem/10552550> JavaScriptCore uses obsolete 'cpy' mnemonic in ARM assembly

Reviewed by Gavin Barraclough.

Original patch by Jim Grosbach.

jit/JITStubs.cpp:

(JSC::ctiTrampoline):
(JSC::ctiVMThrowTrampoline):
Replace uses of the 'cpy' mnemonic with 'mov'.

10:40 PM Changeset in webkit [103027] by tony@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed, rollout r102825 because it didn't improve performance.
https://bugs.webkit.org/show_bug.cgi?id=74622

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):

10:02 PM Changeset in webkit [103026] by eric@webkit.org

4 edits in trunk/Tools

NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process)
https://bugs.webkit.org/show_bug.cgi?id=74650

Reviewed by Adam Barth.

Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo._compute_bytes_from_vm_stat_output):

Scripts/webkitpy/layout_tests/port/base.py:

(Port.default_child_processes):

Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_default_child_processes):

10:00 PM Changeset in webkit [103025] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

IndexedDB: Clean up WebIDBObjectStore createIndex temp code
https://bugs.webkit.org/show_bug.cgi?id=74205

Patch by Joshua Bell <jsbell@chromium.org> on 2011-12-15
Reviewed by Darin Fisher.

Remove a method and an implementation that only needed for
older Chromium revisions.

public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::createIndex):

9:56 PM Changeset in webkit [103024] by fpizlo@apple.com

2 edits in trunk/Tools

bencher script should support remote benchmarking on platforms that don't have ruby
https://bugs.webkit.org/show_bug.cgi?id=74659

Rubber-stamped by Sam Weinig.

Added the ability to have bencher generate a benchmarking playload that consists of
copies of all of the benchmarks, optionally copies of all of the frameworks and
binaries to run all of the VMs, and a sh script that runs the benchmarks in random
order, which then spits out a raw results file that bencher can parse.

In normal operating mode, you never see this, as it just generates the payload and
script internally, runs it, parses the results, and spits them out.

The --remote mode has been changed to use this style, so any remote host that has
sshd, passwordless login support, a ~/.bencher file that points to a "tempPath", and
a sh-compatible shell can be used for remote benchmarking.

The feature to include VMs in the benchmarking payload is by default only activated
when using --remote, but it can also be activated when doing local benchmarking; the
benefit is that you remove any pathname-related performance pathologies. All VMs
become equal because they are all located in
/path/to/bencher/directory/temp/benchdata/vmN where N is the configuration number
(usually 0 or 1).

Also fixed bugs in the DumpRenderTree support. It's now possible to run all benchmarks
through DumpRenderTree. This is only a bit slower than running in jsc.

Scripts/bencher:

9:32 PM Changeset in webkit [103023] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

Value profiling should distinguished between NaN and non-NaN doubles
https://bugs.webkit.org/show_bug.cgi?id=74682

Reviewed by Gavin Barraclough.

Added PredictDoubleReal and PredictDoubleNaN. PredictDouble is now the union
of the two.

bytecode/PredictedType.cpp:

(JSC::predictionToString):
(JSC::predictionFromValue):

bytecode/PredictedType.h:

(JSC::isDoubleRealPrediction):
(JSC::isDoublePrediction):

9:22 PM Changeset in webkit [103022] by commit-queue@webkit.org

1 edit
4 adds in trunk/Source/WebKit

[BlackBerry] Upstream BlackBerry WebCoreSupport drag client and context menu client
https://bugs.webkit.org/show_bug.cgi?id=74643

Patch by Jacky Jiang <zhajiang@rim.com> on 2011-12-15
Reviewed by Rob Buis.

Initial upstream, no new tests.

blackberry/WebCoreSupport/ContextMenuClientBlackBerry.cpp: Added.
blackberry/WebCoreSupport/ContextMenuClientBlackBerry.h: Added.
blackberry/WebCoreSupport/DragClientBlackBerry.cpp: Added.
blackberry/WebCoreSupport/DragClientBlackBerry.h: Added.

9:21 PM Changeset in webkit [103021] by tony@chromium.org

2 edits in trunk/Source/WebKit/chromium

Chromium Windows (Tests) is failing to build
https://bugs.webkit.org/show_bug.cgi?id=74320

Reviewed by Kenneth Russell.

Roll chromium deps to r114686 to pull in a change to how generated
headers include files from third_party/WebKit. This should make the
file path shorter, reducing the chance of hitting the 260 char path
limit on Windows.

DEPS: roll to r114686

9:09 PM Changeset in webkit [103020] by rniwa@webkit.org

7 edits in trunk/Source/WebCore

sizeof(RenderObject) is 32 instead of 24 on Windows
https://bugs.webkit.org/show_bug.cgi?id=74646

Reviewed by Darin Adler.

Make all bitfields in RenderObject to unsigned and wrap them around by RenderObjectBitfields.
Also add a compilation time assertion to make sure we won't grow RenderObject's size unintentionally.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlock::layoutColumns):

rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatWithRect::FloatWithRect):

rendering/RenderObject.cpp:

(WebCore::SameSizeAsRenderObject::~SameSizeAsRenderObject):
(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::markContainingBlocksForLayout):
(WebCore::RenderObject::setPreferredLogicalWidthsDirty):
(WebCore::RenderObject::invalidateContainerPreferredLogicalWidths):
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::styleDidChange):
(WebCore::RenderObject::willBeDestroyed):
(WebCore::RenderObject::updateDragState):

rendering/RenderObject.h:

(WebCore::RenderObject::hasCounterNodeMap):
(WebCore::RenderObject::setHasCounterNodeMap):
(WebCore::RenderObject::childrenInline):
(WebCore::RenderObject::setChildrenInline):
(WebCore::RenderObject::hasColumns):
(WebCore::RenderObject::setHasColumns):
(WebCore::RenderObject::inRenderFlowThread):
(WebCore::RenderObject::setInRenderFlowThread):
(WebCore::RenderObject::isAnonymous):
(WebCore::RenderObject::setIsAnonymous):
(WebCore::RenderObject::isAnonymousBlock):
(WebCore::RenderObject::isFloating):
(WebCore::RenderObject::isPositioned):
(WebCore::RenderObject::isRelPositioned):
(WebCore::RenderObject::isText):
(WebCore::RenderObject::isBox):
(WebCore::RenderObject::isInline):
(WebCore::RenderObject::isDragging):
(WebCore::RenderObject::isReplaced):
(WebCore::RenderObject::isHorizontalWritingMode):
(WebCore::RenderObject::hasLayer):
(WebCore::RenderObject::hasBoxDecorations):
(WebCore::RenderObject::needsLayout):
(WebCore::RenderObject::selfNeedsLayout):
(WebCore::RenderObject::needsPositionedMovementLayout):
(WebCore::RenderObject::needsPositionedMovementLayoutOnly):
(WebCore::RenderObject::posChildNeedsLayout):
(WebCore::RenderObject::needsSimplifiedNormalFlowLayout):
(WebCore::RenderObject::normalChildNeedsLayout):
(WebCore::RenderObject::preferredLogicalWidthsDirty):
(WebCore::RenderObject::hasOverflowClip):
(WebCore::RenderObject::hasTransform):
(WebCore::RenderObject::node):
(WebCore::RenderObject::setPositioned):
(WebCore::RenderObject::setRelPositioned):
(WebCore::RenderObject::setFloating):
(WebCore::RenderObject::setInline):
(WebCore::RenderObject::setHasBoxDecorations):
(WebCore::RenderObject::setIsText):
(WebCore::RenderObject::setIsBox):
(WebCore::RenderObject::setReplaced):
(WebCore::RenderObject::setHorizontalWritingMode):
(WebCore::RenderObject::setHasOverflowClip):
(WebCore::RenderObject::setHasLayer):
(WebCore::RenderObject::setHasTransform):
(WebCore::RenderObject::setHasReflection):
(WebCore::RenderObject::hasReflection):
(WebCore::RenderObject::setHasMarkupTruncation):
(WebCore::RenderObject::hasMarkupTruncation):
(WebCore::RenderObject::selectionState):
(WebCore::RenderObject::setSelectionState):
(WebCore::RenderObject::hasSelectedChildren):
(WebCore::RenderObject::isMarginBeforeQuirk):
(WebCore::RenderObject::isMarginAfterQuirk):
(WebCore::RenderObject::setMarginBeforeQuirk):
(WebCore::RenderObject::setMarginAfterQuirk):
(WebCore::RenderObject::everHadLayout):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(WebCore::RenderObject::RenderObjectBitfields::selectionState):
(WebCore::RenderObject::RenderObjectBitfields::setSelectionState):
(WebCore::RenderObject::setNeedsPositionedMovementLayout):
(WebCore::RenderObject::setNormalChildNeedsLayout):
(WebCore::RenderObject::setPosChildNeedsLayout):
(WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
(WebCore::RenderObject::setPaintBackground):
(WebCore::RenderObject::setIsDragging):
(WebCore::RenderObject::setEverHadLayout):
(WebCore::RenderObject::setNeedsLayout):
(WebCore::RenderObject::setChildNeedsLayout):

rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):

rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::layout):

8:41 PM Changeset in webkit [103019] by leo.yang@torchmobile.com.cn

1 edit
1 add in trunk/Source/WebCore

[BlackBerry] Upstream BlackBerry porting of pluginView
https://bugs.webkit.org/show_bug.cgi?id=73397

Patch by Wei Charles <charles.wei@torchmobile.com.cn> on 2011-12-15
Reviewed by Daniel Bates.

No new tests for now.

plugins/blackberry/PluginViewBlackBerry.cpp: Added.

8:23 PM Changeset in webkit [103018] by commit-queue@webkit.org

5 edits in trunk

IndexedDB: Can't pass DOMStringList to IDBDatabase.transaction()
https://bugs.webkit.org/show_bug.cgi?id=74452

Patch by Joshua Bell <jsbell@chromium.org> on 2011-12-15
Reviewed by Adam Barth.

Source/WebCore:

V8 code generator generated checks for DOMStringList arguments, then
deferred to a function that only handled array inputs. This previously
worked for IndexedDB because it would fall into a now-removed default
handler.

Modified storage/indexeddb/transaction-basics.html to test this.

bindings/v8/V8Binding.cpp:

(WebCore::v8ValueToWebCoreDOMStringList):

LayoutTests:

storage/indexeddb/transaction-basics-expected.txt:
storage/indexeddb/transaction-basics.html:

8:19 PM Changeset in webkit [103017] by adamk@chromium.org

2 edits in trunk/Source/WebCore

Make Element::setAttributeInternal inline in an attempt to avoid function call overhead
https://bugs.webkit.org/show_bug.cgi?id=74638

Reviewed by Andreas Kling.

In r102695, I factored common code in setAttribute into
Element::setAttributeInternal. This may have caused a perf regression
due to the extra function call, which inlining should eliminate.

Running Dromaeo locally suggests that this will improve performance
by ~9% on the "dom-attr element.property = value" test (which assigns
a value to an element's id).

dom/Element.cpp:

(WebCore::Element::setAttributeInternal):

8:03 PM Changeset in webkit [103016] by commit-queue@webkit.org

1 edit
1 add in trunk/Source/WebCore

Upstream FileSystemBlackBerry.cpp into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=74491

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-15
Reviewed by Rob Buis.

We are using POSIX porting of FileSystem, so here only implement other
necessary functions.

Initial upstream, no new tests.

platform/blackberry/FileSystemBlackBerry.cpp: Added.

(WebCore::homeDirectoryPath):
(WebCore::fileSystemRepresentation):
(WebCore::unloadModule):
(WebCore::openTemporaryFile):

7:43 PM Changeset in webkit [103015] by enne@google.com

3 edits in trunk/Source/WebCore

[chromium] Clean up unnecessary leaf functions in GraphicsLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=74140

Reviewed by James Robinson.

Tested by existing compositor layout tests.

This is a follow-on cleanup to r102196, which made some of these
functions less useful than they had been in the past.

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):

platform/graphics/chromium/GraphicsLayerChromium.h:

7:41 PM Changeset in webkit [103014] by dpranke@chromium.org

3 edits in trunk/Tools

webkitpy: clean up TestPort to (mostly) not create a new filesystem
https://bugs.webkit.org/show_bug.cgi?id=74556

This change modifies the TestPort to be ready to add tests to an
existing filesystem instead of creating a new filesystem; we
leave unit_test_filesystem() in for now for compatibility.

Scripts/webkitpy/common/host_mock.py:

(MockHost.init):

call add_unit_tests_to_mock_filesystem by default to make the MockHost more generally useful for layout_test unit tests.

Scripts/webkitpy/layout_tests/port/test.py:

(TestInstance.init):
(add_unit_tests_to_mock_filesystem):
(add_file):
(unit_test_filesystem):
(TestPort.init):
(TestPort._set_default_overriding_none):

7:05 PM Changeset in webkit [103013] by kbr@google.com

9 edits in trunk

Unreviewed, rolling out r103000.
http://trac.webkit.org/changeset/103000
https://bugs.webkit.org/show_bug.cgi?id=74658

Does not handle text/plain documents correctly.

Source/WebCore:

html/parser/HTMLTokenizer.cpp:
html/parser/HTMLTokenizer.h:
html/parser/HTMLTreeBuilder.cpp:
html/parser/HTMLTreeBuilder.h:
xml/parser/MarkupTokenizerBase.h:

LayoutTests:

html5lib/runner-expected.txt:
platform/chromium/html5lib/runner-expected.txt:

7:02 PM Changeset in webkit [103012] by dpranke@chromium.org

5 edits in trunk/Tools

webkitpy: cleanup prior to systemhostifying the layout_test/port* classes
https://bugs.webkit.org/show_bug.cgi?id=74551

This is some minor cleanup prior to making all of the host/port
changes described in bug 74138.

Scripts/webkitpy/common/host_mock.py:

(MockHost.init):

make sure the scm object is initialized with the same mock executive and filesystem objects.

Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.clear_written_files):

add a routine that will be useful in testing.

(MockFileSystem.maybe_make_directory):
(MockFileSystem.write_binary_file):

fix bugs to make sure directories are created properly.

Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(_Process.run):

add clarifying comments.

Scripts/webkitpy/layout_tests/port/mock_drt.py:

(MockDRTPort.init):
(MockDRT.init):

add clarifying comments.

6:32 PM Changeset in webkit [103011] by jamesr@google.com

13 edits in trunk

[chromium] Set the CCLayerTreeHost pointer on LayerChromium instances eagerly
https://bugs.webkit.org/show_bug.cgi?id=74477

Reviewed by Kenneth Russell.

Source/WebCore:

This enforces that the m_layerTreeHost pointer on LayerChromium instances is always up to date, instead of
lazily setting it in the paintContents loop. There are two invariants:
1.) If a LayerChromium is the root layer of a CCLayerTreeHost, or is reachable via the children, mask, or
replica pointers from the root layer of a CCLayerTreeHost, then that LayerChromium's m_layerTreeHost pointer
refers to that CCLayerTreeHost
2.) If a LayerChromium is not a root layer or reachable from a root layer of any CCLayerTreeHost, its
CCLayerTreeHost pointer is nil.

Covered by several new layout tests in LayerChromiumTest

platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setLayerTreeHost):
(WebCore::LayerChromium::setParent):
(WebCore::LayerChromium::setMaskLayer):
(WebCore::LayerChromium::setReplicaLayer):

platform/graphics/chromium/LayerChromium.h:
platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::createTile):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

Add some new tests for LayerChromium::m_layerTreeHost behavior.

tests/CCLayerTreeHostTest.cpp:

(::MockLayerTreeHost::create):
(::MockLayerTreeHost::MockLayerTreeHost):
(::CCLayerTreeHostTestShortlived1::beginTest):
(::CCLayerTreeHostTestShortlived2::beginTest):
(::CCLayerTreeHostTestShortlived3::beginTest):

tests/LayerChromiumTest.cpp:

LayoutTests:

platform/chromium/test_expectations.txt:

6:32 PM Changeset in webkit [103010] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Add support for accelerated compositing to the tiled Core Animation drawing area
https://bugs.webkit.org/show_bug.cgi?id=74675

Reviewed by Andreas Kling.

Add a layer flush scheduler and get rid of the content layer since WebCore will manage that for us.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::setNeedsDisplay):
(WebKit::TiledCoreAnimationDrawingArea::scroll):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerSync):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):

6:15 PM Changeset in webkit [103009] by commit-queue@webkit.org

13 edits in trunk/Source

Unreviewed, rolling out r102652 and r102717.
http://trac.webkit.org/changeset/102652
http://trac.webkit.org/changeset/102717
https://bugs.webkit.org/show_bug.cgi?id=74674

Broke too many webs. (Requested by kling on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-15

Source/WebCore:

WebCore.exp.in:

Source/WebKit2:

UIProcess/API/mac/WKView.mm:

(-[WKView _updateWindowAndViewFrames]):

UIProcess/WebPageProxy.h:
UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::windowAndViewFramesChanged):

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::windowAndViewFramesChanged):

WebProcess/Plugins/PluginView.h:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::windowRect):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowAndViewFramesChanged):

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::windowFrameInScreenCoordinates):
(WebKit::WebPage::viewFrameInWindowCoordinates):
(WebKit::WebPage::accessibilityPosition):

WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:

(-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):

6:00 PM Changeset in webkit [103008] by andersca@apple.com

4 edits in trunk

Source/JavaScriptCore: Regression (r102866): Navigating away from or closing a page with a plugin crashes
https://bugs.webkit.org/show_bug.cgi?id=74655
<rdar://problem/10590024>

Reviewed by Sam Weinig.

Rewrite HasRefAndDeref to work if ref and deref are implemented in base classes,
using a modified version of the technique described here:
http://groups.google.com/group/comp.lang.c++.moderated/msg/e5fbc9305539f699

wtf/Functional.h:

Tools: Regression (r102866): Navigating away from or closing a page with a plugin crashes
https://bugs.webkit.org/show_bug.cgi?id=74655

Reviewed by Sam Weinig.

Add a bunch of tests.

TestWebKitAPI/Tests/WTF/Functional.cpp:

5:50 PM Changeset in webkit [103007] by andersca@apple.com

7 edits in trunk/Source/WebCore

Lazily create the scrolling coordinator and add a setting for enabling it
https://bugs.webkit.org/show_bug.cgi?id=74667

Reviewed by Darin Adler.

WebCore.xcodeproj/project.pbxproj:

Make ScrollingCoordinator.h a private header so it can be used in WebKit.

page/Page.cpp:

(WebCore::Page::Page):
Don't create the scrolling coordinator.

(WebCore::Page::~Page):
Check for a null scrolling coordinator.

(WebCore::Page::scrollingCoordinator):
Create the scrolling coordinator lazily.

page/Settings.cpp:

(WebCore::Settings::Settings):

page/Settings.h:

(WebCore::Settings::setScrollingCoordinatorEnabled):
(WebCore::Settings::scrollingCoordinatorEnabled):
Add a setting for enabling the scrolling coordinator.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):
Use a tile cache layer for the main frame when the scrolling coordinator is neabled.

5:33 PM Changeset in webkit [103006] by gyuyoung.kim@samsung.com

3 edits in trunk/Source/WebCore

Unreviewed. Fix build break when data-transfer-items is enabled.

platform/efl/ClipboardEfl.cpp:

(WebCore::ClipboardEfl::items):

platform/efl/ClipboardEfl.h:

5:19 PM Changeset in webkit [103005] by abarth@webkit.org

5 edits in trunk

<ruby><div><p><rp> parses incorrectly
https://bugs.webkit.org/show_bug.cgi?id=74668

Reviewed by Darin Adler.

Source/WebCore:

This patch updates our implementation to match a change to the HTML5
specification regarding how <ruby> elements parse. Previously, <rp>
and similar tags used to pop the stack up to the <ruby> element. Now
the popping does not occur.

Tests: html5lib/runner.html

html/parser/HTMLTreeBuilder.cpp:

LayoutTests:

Update test results to show progression.

html5lib/runner-expected.txt:
platform/chromium/html5lib/runner-expected.txt:

5:17 PM Changeset in webkit [103004] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Chromium] Avoid strdup() for extra argument when tracing is disabled.
https://bugs.webkit.org/show_bug.cgi?id=74637

Patch by Daniel Sievers <sievers@chromium.org> on 2011-12-15
Reviewed by James Robinson.

platform/chromium/TraceEvent.h:

(WebCore::internal::ScopeTracer::ScopeTracer):

5:12 PM Changeset in webkit [103003] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

Warnings fixes in Interpreter.cpp and PrivateExecute.cpp
https://bugs.webkit.org/show_bug.cgi?id=74624

Patch by Andy Wingo <wingo@igalia.com> on 2011-12-15
Reviewed by Darin Adler.

interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute): Fix variables unused in
release mode.

wtf/ParallelJobsGeneric.cpp:

(WTF::ParallelEnvironment::ParallelEnvironment): Fix
signed/unsigned comparison warning, with a cast.

5:08 PM Changeset in webkit [103002] by Stephanie Lewis

7 edits in trunk/Tools

https://bugs.webkit.org/show_bug.cgi?id=74469
Escape paths to svn commands so our tools can handle filenames with @ symbols.

Reviewed by Adam Roben.

Scripts/VCSUtils.pm:

(scmMoveOrRenameFile):
(scmAddExecutableBit):
(scmRemoveExecutableBit):
(determineSVNRoot):
(svnRevisionForDirectory):
(pathRelativeToSVNRepositoryRootForPath):
(svnStatus):
(escapeSubversionPath):

Scripts/parse-malloc-history:

(main):

Scripts/prepare-ChangeLog:

(diffCommand):
(statusCommand):
(findOriginalFileFromSvn):
(determinePropertyChanges):

Scripts/resolve-ChangeLogs:

(conflictFiles):
(resolveConflict):
(showStatus):

Scripts/svn-apply:

(patch):
(scmCopy):
(scmAdd):
(scmRemove):

Scripts/svn-create-patch:

(findBaseUrl):
(findMimeType):
(findSourceFileAndRevision):
(generateDiff):
(generateFileList):
(manufacturePatchForAdditionWithHistory):

Scripts/svn-unapply:

(patch):
(revertDirectories):

4:59 PM Changeset in webkit [103001] by adamk@chromium.org

17 edits
1 copy
1 add in trunk/Source/WebCore

[MutationObservers] Add a document-level flag that can trivially be checked to avoid doing unnessary work if mutation observers absent
https://bugs.webkit.org/show_bug.cgi?id=74641

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-12-15
Reviewed by Ojan Vafai.

This patch adds a byte of flags to Document, of which three bits are used to signal if any
node owned by the document has a Mutation Observer of the given type. This is used to
reduce the cost of discovering there are none to a single (inlined) method call and bit-check.
Also, a similar byte of flags which was used to optimize a particular case when mutation observers
are present has been removed, with the reasoning that we should first focus on minimizing impact on
the null-case before optimizing particular in-use cases.

Also, MutationObserverInterestGroup is broken out into its own file (which probably should have happened
earlier, but now avoids a circular header dependency).

No tests needed. This patch is just a refactor.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSMutableStyleDeclaration.cpp:
dom/CharacterData.cpp:
dom/ChildListMutationScope.cpp:
dom/Document.cpp:

(WebCore::Document::Document):

dom/Document.h:

(WebCore::Document::hasMutationObserversOfType):
(WebCore::Document::hasMutationObservers):
(WebCore::Document::addMutationObserverTypes):

dom/Element.cpp:
dom/MutationObserverInterestGroup.cpp: Added.

(WebCore::MutationObserverInterestGroup::createIfNeeded):
(WebCore::MutationObserverInterestGroup::MutationObserverInterestGroup):
(WebCore::MutationObserverInterestGroup::isOldValueRequested):
(WebCore::MutationObserverInterestGroup::enqueueMutationRecord):

dom/MutationObserverInterestGroup.h: Copied from Source/WebCore/dom/WebKitMutationObserver.h.

(WebCore::MutationObserverInterestGroup::createForChildListMutation):
(WebCore::MutationObserverInterestGroup::createForCharacterDataMutation):
(WebCore::MutationObserverInterestGroup::createForAttributesMutation):
(WebCore::MutationObserverInterestGroup::hasOldValue):

dom/Node.cpp:

(WebCore::Node::didMoveToNewOwnerDocument):
(WebCore::Node::getRegisteredMutationObserversOfType):
(WebCore::Node::notifyMutationObserversNodeWillDetach):

dom/Node.h:
dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::observe):

dom/WebKitMutationObserver.h:

4:51 PM Changeset in webkit [103000] by abarth@webkit.org

9 edits in trunk

<!DOCTYPE html><pre>

A</pre> doesn't parse correctly
https://bugs.webkit.org/show_bug.cgi?id=74658

Reviewed by Darin Adler.

Source/WebCore:

Previously, we handled skipping newlines after <pre> in the tokenizer,
which isn't how the spec handles them. Instead, the spec skips them in
the tree builder. This isn't usually observable, except in the case of
an HTML entity. In that case, the tokenzier sees '&' (because the
entity hasn't been decoded yet), but the tree builder sees '\n' (the
decoded entity). This patch fixes the bug by more closely aligning our
implementation with the spec.

Test: html5lib/runner.html

html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::reset):
(WebCore::HTMLTokenizer::nextToken):

html/parser/HTMLTokenizer.h:
html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipAtMostOneLeadingNewline):
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):

html/parser/HTMLTreeBuilder.h:
xml/parser/MarkupTokenizerBase.h:

LayoutTests:

Shows test progression.

html5lib/runner-expected.txt:

4:44 PM Changeset in webkit [102999] by kbr@google.com

9 edits in trunk/Source/WebCore

Unreviewed, rolling out r102989.
http://trac.webkit.org/changeset/102989
https://bugs.webkit.org/show_bug.cgi?id=74580

Caused SHOULD NOT BE REACHED assertions in debug builds.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EBoxAlignment):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):

rendering/RenderFullScreen.cpp:

(createFullScreenStyle):

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::boxPack):
(WebCore::InheritedFlags::setBoxAlign):
(WebCore::InheritedFlags::setBoxPack):
(WebCore::InheritedFlags::initialBoxPack):

rendering/style/RenderStyleConstants.h:
rendering/style/StyleDeprecatedFlexibleBoxData.h:

4:41 PM Changeset in webkit [102998] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit

[BlackBerry] Regression: lots of checkerboarding
https://bugs.webkit.org/show_bug.cgi?id=74611

Patch by Jacky Jiang <zhajiang@rim.com> on 2011-12-15
Reviewed by Daniel Bates.

Fix a regression caused by r102843 which introduced a lot of unnecessary
checkerboarding. R102843 changed behavior by removing a check for blit
based on whether the render actually took place and whether the
backingstore was in the midst of suspended updates.
The initial anthor is Adam Treat <atreat@rim.com>.

blackberry/Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::slowScroll):
(BlackBerry::WebKit::BackingStorePrivate::renderVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::renderBackingStore):

blackberry/Api/BackingStore_p.h:

(BlackBerry::WebKit::BackingStorePrivate::isSuspended):

4:37 PM Changeset in webkit [102997] by commit-queue@webkit.org

2 edits
1 add
4 deletes in trunk/LayoutTests

Create reftest for render-region-renderer
https://bugs.webkit.org/show_bug.cgi?id=74518

Patch by Larry McLister <lmcliste@adobe.com> on 2011-12-15
Reviewed by Tony Chang.

fast/regions/render-region-renderer-expected.html: Added.
platform/chromium/test_expectations.txt:
platform/efl/fast/regions/render-region-renderer-expected.png: Removed.
platform/efl/fast/regions/render-region-renderer-expected.txt: Removed.
platform/mac/fast/regions/render-region-renderer-expected.png: Removed.
platform/mac/fast/regions/render-region-renderer-expected.txt: Removed.

4:32 PM Changeset in webkit [102996] by commit-queue@webkit.org

2 edits in trunk/Tools

[qt][wk2] MiniBrowser: Add pressed state for viewport info button.
https://bugs.webkit.org/show_bug.cgi?id=74617

Patch by Michael Bruning <michael.bruning@nokia.com> on 2011-12-15
Reviewed by Kenneth Rohde Christiansen.

MiniBrowser/qt/qml/BrowserWindow.qml: Added state dependent coloring

for viewport info button, adjusted height and added rounded corners.

4:25 PM Changeset in webkit [102995] by bashi@chromium.org

2 edits
10 adds in trunk/LayoutTests

Unreviewed Chromium test expectations update.
Rebaseline fast/text/unicode-variation-selector.html.

platform/chromium-cg-mac-leopard/fast/text/unicode-variation-selector-expected.png: Added.
platform/chromium-cg-mac-snowleopard/fast/text/unicode-variation-selector-expected.png: Added.
platform/chromium-linux/fast/text/unicode-variation-selector-expected.png: Added.
platform/chromium-linux/fast/text/unicode-variation-selector-expected.txt: Added.
platform/chromium-mac-leopard/fast/text/unicode-variation-selector-expected.png: Added.
platform/chromium-mac-snowleopard/fast/text/unicode-variation-selector-expected.png: Added.
platform/chromium-win/fast/text/unicode-variation-selector-expected.png: Added.
platform/chromium-win/fast/text/unicode-variation-selector-expected.txt: Added.
platform/chromium/fast/text/unicode-variation-selector-expected.txt: Added.
platform/chromium/test_expectations.txt:

4:18 PM Changeset in webkit [102994] by aestes@apple.com

2 edits in trunk/Tools

TestFailures: store the name of the buildbot results directory in a property
https://bugs.webkit.org/show_bug.cgi?id=74663

Reviewed by Adam Barth.

Store the name of the results directory as a property on Buildbot's
prototype. This allows subclasses of Buildbot to customize the results
directory.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js:

(Buildbot.prototype.resultsDirectoryURL):

4:02 PM Changeset in webkit [102993] by kubo@profusion.mobi

5 edits in trunk

[CMake] Remove ENABLE_DATAGRID from the buildsystem.
https://bugs.webkit.org/show_bug.cgi?id=74640

Reviewed by Antonio Gomes.

r84991 removed Datagrid from the tree, but the options in CMake were
kept.

Source/cmake/OptionsBlackBerry.cmake:
Source/cmake/OptionsEfl.cmake:
Source/cmake/OptionsWinCE.cmake:
Source/cmakeconfig.h.cmake:

3:50 PM Changeset in webkit [102992] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Touch make_name.pl in an attempt to make Qt bots happy.

dom/make_names.pl:

(printNamesHeaderFile):

3:48 PM Changeset in webkit [102991] by haraken@chromium.org

4 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

bindings/scripts/test/JS/JSFloat64Array.cpp:
bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
bindings/scripts/test/JS/JSTestObj.cpp:

3:46 PM Changeset in webkit [102990] by tony@chromium.org

2 edits in trunk/Tools

[chromium] pass --delete_unversioned_trees to gclient on the bots
https://bugs.webkit.org/show_bug.cgi?id=74565

Reviewed by Kenneth Russell.

It was temporarily removed in r102891 to keep the bots green. Now
that the bots have cycled, we can add it back.

Scripts/update-webkit-chromium:

3:44 PM Changeset in webkit [102989] by macpherson@chromium.org

9 edits in trunk/Source/WebCore

Separate box alignment and box pack values into separate enums.
https://bugs.webkit.org/show_bug.cgi?id=74580

Reviewed by Darin Adler.

No new tests / refactoring only.

Separating these types cleans up the code by removing several assertions that
values are in the correct ranges, as this is ensured by the type system.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EBoxPack):
(WebCore::CSSPrimitiveValue::operator EBoxAlignment):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):

rendering/RenderFullScreen.cpp:

(createFullScreenStyle):

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::boxPack):
(WebCore::InheritedFlags::setBoxAlign):
(WebCore::InheritedFlags::setBoxPack):
(WebCore::InheritedFlags::initialBoxPack):

rendering/style/RenderStyleConstants.h:
rendering/style/StyleDeprecatedFlexibleBoxData.h:

3:13 PM Changeset in webkit [102988] by haraken@chromium.org

2 edits in trunk/Tools

[Refactoring] In prepare-ChangeLog, make several global variables be used only through parameter passing
https://bugs.webkit.org/show_bug.cgi?id=74497

Reviewed by Ryosuke Niwa.

$bugDescription
$bugNumber
$name
$emailAddress
$gitReviewer
$writeChangeLogs

Scripts/prepare-ChangeLog:

(fetchBugDescriptionFromURL):
(generateNewChangeLogs):
(reviewerAndDescriptionForGitCommit):

3:10 PM Changeset in webkit [102987] by haraken@chromium.org

2 edits
10 adds in trunk/Source/WebCore

REGRESSION(r102663): generate-bindings.pl runs every time
https://bugs.webkit.org/show_bug.cgi?id=74481

Reviewed by Adam Barth.

See the comment #1 of bug 74481 for the cause of this bug.

This patch fixes generate-bindings.pl so that it generates .h and .cpp files
even for IDL files that do not need .h and .cpp files. This is just to prevent
build scripts from trying to generate .h and .cpp files at every build.

No new tests. No change in behavior.

bindings/scripts/generate-bindings.pl:

(generateEmptyHeaderAndCpp): Generates .h and .cpp files for IDL files
that do not need .h and .cpp files.

bindings/scripts/test/CPP/CPPTestSupplemental.cpp: Added.
bindings/scripts/test/CPP/CPPTestSupplemental.h: Added.
bindings/scripts/test/GObject/GObjectTestSupplemental.cpp: Added.
bindings/scripts/test/GObject/GObjectTestSupplemental.h: Added.
bindings/scripts/test/JS/JSTestSupplemental.cpp: Added.
bindings/scripts/test/JS/JSTestSupplemental.h: Added.
bindings/scripts/test/ObjC/ObjCTestSupplemental.cpp: Added.
bindings/scripts/test/ObjC/ObjCTestSupplemental.h: Added.
bindings/scripts/test/V8/V8TestSupplemental.cpp: Added.
bindings/scripts/test/V8/V8TestSupplemental.h: Added.

2:53 PM Changeset in webkit [102986] by Lucas Forschler

1 copy in tags/Safari-534.53.11

New tag.

2:19 PM Changeset in webkit [102985] by kbr@google.com

2 edits in trunk/LayoutTests

Unreviewed Chromium test expectations update; pull up some
downstream suppressions.

platform/chromium/test_expectations.txt:

2:17 PM Changeset in webkit [102984] by jarred@sencha.com

2 edits in trunk/Source/WebCore

Unreviewed build fix. Mac build broken when CSS Filters enabled.
Needed to move Filter headers out as private headers in WebCore.framework.

WebCore.xcodeproj/project.pbxproj:

2:00 PM Changeset in webkit [102983] by eric@webkit.org

5 edits in trunk/Source/WebCore

WebCore has two (disconnected) ways to keep track of updated widgets, should be unified
https://bugs.webkit.org/show_bug.cgi?id=74367

Reviewed by Adam Barth.

It seems the FrameView updateWidgets set is needed for now,
so just making FrameView::addWidgetToUpdate mark the DOM node
as needing a widget update and later when it goes to call
updateWidget() checking first if it needs an update.

No new tests, just adding an assert.

html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget):

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget):

html/HTMLPlugInImageElement.h:

(WebCore::HTMLPlugInImageElement::needsWidgetUpdate):
(WebCore::HTMLPlugInImageElement::setNeedsWidgetUpdate):

page/FrameView.cpp:

(WebCore::FrameView::addWidgetToUpdate):
(WebCore::FrameView::updateWidget):

1:56 PM Changeset in webkit [102982] by Alexandru Chiculita

2 edits in trunk/Source/WebCore

Windows project file is broken. It has a missing </File> enclosing tag
https://bugs.webkit.org/show_bug.cgi?id=74632

Reviewed by Anders Carlsson.

No new tests, just fixing the project file.

WebCore.vcproj/WebCore.vcproj:

1:35 PM Changeset in webkit [102981] by abarth@webkit.org

11 edits in trunk

<table><tr><td><svg><desc><td> parses incorrectly
https://bugs.webkit.org/show_bug.cgi?id=68106

Reviewed by Eric Seidel.

Source/WebCore:

This patch updates our implementation of the HTML5 parser to account
for recent changes in the spec. The main change in this patch is to
remove the "in foreign content" state from the tree builder. Rather
than maintaining this as a separate state, the parser now introspects
on the stack of open elements to determine whether the parser is in
foriegn content. In the process, I've deleted some now-unused
machinery in the tree builder.

Tested by the html5lib LayoutTests. These tests show the progression
in our spec compliance.

html/parser/HTMLElementStack.cpp:
html/parser/HTMLElementStack.h:
html/parser/HTMLTreeBuilder.cpp:
html/parser/HTMLTreeBuilder.h:
mathml/mathattrs.in:

LayoutTests:

html5lib/resources/webkit01.dat:
- This test had an incorrect expectation that matched our previous behavior. The new expected result matches Firefox's implemenation as well.
html5lib/runner-expected.txt:
platform/chromium/html5lib/runner-expected.txt:
- Updated to show test progressions. The one non-monotonic improvement is some churn in which of the unsafe-text tests we pass. I'll look into this issue in a future patch.

1:34 PM Changeset in webkit [102980] by nduca@chromium.org

3 edits in trunk/Source/WebKit/chromium

[chromium] Add forUseOnAnotherThread to WebGraphicsContext3D::Attributes
https://bugs.webkit.org/show_bug.cgi?id=74557

Reviewed by Kenneth Russell.

public/platform/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::Attributes::Attributes):

src/GraphicsContext3DChromium.cpp:

1:30 PM Changeset in webkit [102979] by rniwa@webkit.org

11 edits in trunk/Source/WebCore

m_hasCounterNodeMap and m_everHadLayout should be private to RenderObject
https://bugs.webkit.org/show_bug.cgi?id=74645

Reviewed by Eric Seidel.

Made them private and added getters and setters as needed.

rendering/RenderCounter.cpp:

(WebCore::makeCounterNode):
(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::updateCounters):
(WebCore::RenderCounter::rendererStyleChanged):
(showCounterRendererTree):

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::layout):

rendering/RenderObject.h:

(WebCore::RenderObject::hasCounterNodeMap):
(WebCore::RenderObject::setHasCounterNodeMap):
(WebCore::RenderObject::everHadLayout):

rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::layout):

rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::layout):

rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::layout):

rendering/svg/RenderSVGResourceMarker.cpp:

(WebCore::RenderSVGResourceMarker::layout):

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::layout):

rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::layout):

rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::layout):

1:29 PM Changeset in webkit [102978] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

Use more macrology in JSC::Options
https://bugs.webkit.org/show_bug.cgi?id=72938

Patch by Andy Wingo <wingo@igalia.com> on 2011-12-15
Reviewed by Filip Pizlo.

runtime/Options.cpp:

(JSC::Options::initializeOptions):

runtime/Options.h: Use macros to ensure that all heuristics are

declared and have initializers.

1:07 PM Changeset in webkit [102977] by vsevik@chromium.org

3 edits in trunk/Source/WebCore

Not able to navigate the Resource tab options properly with arrow keys after adding the sticky-notes.
https://bugs.webkit.org/show_bug.cgi?id=72013

Reviewed by Pavel Feldman.

inspector/front-end/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView):
(WebInspector.DatabaseQueryView.prototype._messagesClicked):

inspector/front-end/ResourcesPanel.js:

(WebInspector.DatabaseTreeElement.prototype.onexpand):

12:46 PM Changeset in webkit [102976] by leviw@chromium.org

345 edits in branches/subpixellayout/LayoutTests

Checking in updated 'fast' test expectations for sub-pixel positioning.

12:44 PM Changeset in webkit [102975] by andersca@apple.com

6 edits
2 adds in trunk/Source

Add ScrollingCoordinator class and ENABLE_THREADED_SCROLLING define
https://bugs.webkit.org/show_bug.cgi?id=74639

Reviewed by Andreas Kling.

Source/JavaScriptCore:

Add ENABLE_THREADED_SCROLLING #define.

wtf/Platform.h:

Source/WebCore:

Add a ScrollingCoordinator class and make it a member of Page. Tear it down
when the page goes away.

WebCore.xcodeproj/project.pbxproj:
page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::~Page):

page/Page.h:

(WebCore::Page::scrollingCoordinator):

page/ScrollingCoordinator.cpp: Added.

(WebCore::ScrollingCoordinator::create):
(WebCore::ScrollingCoordinator::ScrollingCoordinator):
(WebCore::ScrollingCoordinator::~ScrollingCoordinator):
(WebCore::ScrollingCoordinator::pageDestroyed):

page/ScrollingCoordinator.h: Added.

12:32 PM Changeset in webkit [102974] by tommyw@google.com

3 edits
1 delete in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Fixing #include statements and removing forwarding header file
https://bugs.webkit.org/show_bug.cgi?id=74598

Reviewed by Darin Fisher.

WebMediaStreamSource.h had some issues when accessed from chromium. Also cleaned up the forwarding header.

WebKit.gyp:
public/WebMediaStreamSource.h: Removed.
public/platform/WebMediaStreamSource.h:

12:06 PM BuildingGtk edited by Martin Robinson

(diff)

11:54 AM Changeset in webkit [102973] by kbr@google.com

19 edits
3 moves in trunk

Rename WEBKIT_lose_context to WEBKIT_WEBGL_lose_context
https://bugs.webkit.org/show_bug.cgi?id=71870

Reviewed by James Robinson.

Re-landing after original commit was rolled out.

Source/WebCore:

Rename largely done with do-webcore-rename with a couple of
necessary manual fixups. Ran WebGL layout tests.

CMakeLists.txt:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

html/canvas/WebGLExtension.h:
html/canvas/WebGLLoseContext.cpp: Copied from Source/WebCore/html/canvas/WebKitLoseContext.cpp.

(WebCore::WebGLLoseContext::WebGLLoseContext):
(WebCore::WebGLLoseContext::~WebGLLoseContext):
(WebCore::WebGLLoseContext::getName):
(WebCore::WebGLLoseContext::create):
(WebCore::WebGLLoseContext::loseContext):
(WebCore::WebGLLoseContext::restoreContext):

html/canvas/WebGLLoseContext.h: Copied from Source/WebCore/html/canvas/WebKitLoseContext.h.
html/canvas/WebGLLoseContext.idl: Copied from Source/WebCore/html/canvas/WebKitLoseContext.idl.
html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

html/canvas/WebGLRenderingContext.h:
html/canvas/WebKitLoseContext.cpp: Removed.
html/canvas/WebKitLoseContext.h: Removed.
html/canvas/WebKitLoseContext.idl: Removed.

LayoutTests:

Synchronized context-lost-restored.html and context-lost.html with
Khronos repository; upstream tests must check for multiple vendor
prefixes.

fast/canvas/webgl/WebGLContextEvent.html:
fast/canvas/webgl/context-destroyed-crash.html:
fast/canvas/webgl/context-lost-expected.txt:
fast/canvas/webgl/context-lost-restored.html:
fast/canvas/webgl/context-lost.html:

11:47 AM Changeset in webkit [102972] by senorblanco@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r102956.
http://trac.webkit.org/changeset/102956
https://bugs.webkit.org/show_bug.cgi?id=74334

Broke Chromium/Win build.

features.gypi:

11:45 AM Changeset in webkit [102971] by kubo@profusion.mobi

3 edits in trunk/Source/WebKit/efl

[EFL] Clean up and refactor the memory cache functions in ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72140

Reviewed by Antonio Gomes.

Use a better naming prefix, as "ewk_settings_cache" was too general,
and make it possible to pass all parameters to
MemoryCache::setCapacities().

ewk/ewk_settings.cpp:

(ewk_settings_object_cache_capacity_set):
(ewk_settings_object_cache_enable_get):
(ewk_settings_object_cache_enable_set):

ewk/ewk_settings.h:

11:34 AM Changeset in webkit [102970] by kbr@google.com

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Disable flaky tests. Built and tested on Linux.
https://bugs.webkit.org/show_bug.cgi?id=74623

tests/CCLayerTreeHostTest.cpp:

(WTF::TEST_F):

11:28 AM Changeset in webkit [102969] by beidson@apple.com

2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=74631
HTMLMediaElement should not register for document activation callbacks as it doesn't use them

Reviewed by Eric Carlson.

No new tests. (No behavior change, pruning useless code)

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::willMoveToNewOwnerDocument):
(WebCore::HTMLMediaElement::didMoveToNewOwnerDocument):

11:18 AM Changeset in webkit [102968] by eric.carlson@apple.com

14 edits
7 adds in trunk

Text tracks should be treated differently according to their kind
https://bugs.webkit.org/show_bug.cgi?id=72547

Reviewed by Sam Weinig.

Source/WebCore:

Tests: media/track/track-default-attribute.html

media/track/track-mode-not-changed-by-new-track.html
media/track/track-mode-triggers-loading.html

html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::HTMLAudioElement): Add "createdByParser" parameter.
(WebCore::HTMLAudioElement::create): Ditto.
(WebCore::HTMLAudioElement::createForJSConstructor): Deal with constructor change.

html/HTMLAudioElement.h:

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Add "createdByParser" parameter. Initialize m_parsingInProgress.
(WebCore::HTMLMediaElement::finishParsingChildren): Clear m_parsingInProgress. Schedule track

loading if necessary.

(WebCore::HTMLMediaElement::loadTimerFired): Call configureTextTracks not call scheduleLoad,

it just schedules the load timer again.

(WebCore::HTMLMediaElement::prepareForLoad): Add all non-disabled track elements to a vector

so we can prevent the media element's readyState from reaching HAVE_METADATA until the
tracks are ready.

(WebCore::HTMLMediaElement::textTracksAreReady): New. Return false unless all tracks that were

not disabled when loading started have loaded or failed.

(WebCore::HTMLMediaElement::textTrackReadyStateChanged): Call setReadyState when a track is

stops loading.

(WebCore::HTMLMediaElement::textTrackModeChanged): Trigger <track> loading when the mode

changes to hidden or showing for the first time.

(WebCore::HTMLMediaElement::setReadyState): Do not advance to HAVE_METADATA or higher while

track elements are loading.

(WebCore::HTMLMediaElement::addTrack): Removed.
(WebCore::HTMLMediaElement::showingTrackWithSameKind): New.
(WebCore::HTMLMediaElement::trackWasAdded):
(WebCore::HTMLMediaElement::trackWillBeRemoved): Flag a track as unconfigured so it will be

reconfigured if it is added to another element.

(WebCore::HTMLMediaElement::userIsInterestedInThisLanguage): New.
(WebCore::HTMLMediaElement::userIsInterestedInThisTrack): New. Consider user preferences.
(WebCore::HTMLMediaElement::configureTextTrack): New. Configure a track as per the user's preferences.
(WebCore::HTMLMediaElement::configureTextTracks): New. Configure all track elements.

html/HTMLMediaElement.h:
html/HTMLMediaElement.h:

html/HTMLTagNames.in: Add constructorNeedsCreatedByParser to audio and video.

html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::HTMLTrackElement): Initialize m_hasBeenConfigured.

html/HTMLTrackElement.h:

(WebCore::HTMLTrackElement::hasBeenConfigured):
(WebCore::HTMLTrackElement::setHasBeenConfigured):

html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::HTMLVideoElement): Add "createdByParser" parameter.
(WebCore::HTMLVideoElement::create): Ditto.

html/HTMLVideoElement.h:

html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Initialize m_mode to DISABLED, not HIDDEN. Initialize m_showingByDefault.
(WebCore::TextTrack::setMode): Clear the "showing by default" flag when a track's mode is

explicitly set to SHOWING.

(WebCore::TextTrack::mode): Return SHOWING whenever the "showing by default" flag is set.

html/TextTrack.h:

(WebCore::TextTrack::showingByDefault):
(WebCore::TextTrack::setShowingByDefault):

html/TextTrackCue.cpp:

(WebCore::TextTrackCue::isActive): Return false if a cue has no track, or if its track is disabled.
(WebCore::TextTrackCue::setIsActive): Don't enable a cue if it has no track, or if its track

is disabled.

LayoutTests:

media/track/captions-webvtt/metadata.vtt: Added.
media/track/track-default-attribute-expected.txt: Added.
media/track/track-default-attribute.html: Added.
media/track/track-mode-not-changed-by-new-track-expected.txt: Added.
media/track/track-mode-not-changed-by-new-track.html: Added.
media/track/track-mode-triggers-loading-expected.txt: Added.
media/track/track-mode-triggers-loading.html: Added.

11:13 AM Changeset in webkit [102967] by kbr@google.com

2 edits in trunk/LayoutTests

Unreviewed Chromium test expectations update; add suppression.
https://bugs.webkit.org/show_bug.cgi?id=74634

platform/chromium/test_expectations.txt:

11:11 AM Changeset in webkit [102966] by kubo@profusion.mobi

7 edits in trunk

[EFL] Add a few more web database functions to ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72148

Reviewed by Antonio Gomes.

Source/WebKit/efl:

Add code to change the default quota (there as only a getter so far)
and one to clear the databases.

ewk/ewk_settings.cpp:

(ewk_settings_web_database_default_quota_set):
(ewk_settings_web_database_clear):

ewk/ewk_settings.h:

Tools:

DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::clearAllDatabases):
(LayoutTestController::setDatabaseQuota):

LayoutTests:

LayoutTestController::setDatabaseQuota is implemented now.

platform/efl/Skipped:

11:07 AM Changeset in webkit [102965] by kov@webkit.org

2 edits in trunk/Source/WebKit2

[GTK] New API test for WindowProperties fails
https://bugs.webkit.org/show_bug.cgi?id=74630

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-12-15
Reviewed by Martin Robinson.

UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(WindowProperties::viewReadyToShow): assert each member to make
assertion error messages more useful, and avoid asserting x and y,
since we are getting bad values from WebCore, for some reason.
(testWebViewWindowProperties): use smaller values that fit inside the
800x600 screen used by the bots.

11:04 AM Changeset in webkit [102964] by beidson@apple.com

2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=74607
Removed a skipped test after rolling out r102829

Unreviewed.

platform/qt/Skipped:

10:56 AM Changeset in webkit [102963] by andersca@apple.com

9 edits in trunk/Source

EventDispatcher should handle wheel events on the connection queue
https://bugs.webkit.org/show_bug.cgi?id=74627

Reviewed by Andreas Kling.

Source/JavaScriptCore:

Add a BoundFunctionImpl specialization that takes three parameters.

wtf/Functional.h:

(WTF::C::):
(WTF::R):
(WTF::bind):

Source/WebKit2:

Send wheel events to the EventDispatcher, which handles them on the connection work queue, and
immediately bounces them to the main thread (for now).

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleWheelEvent):
(WebKit::WebPageProxy::didReceiveEvent):

WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::dispatchWheelEvent):

WebProcess/WebPage/EventDispatcher.h:
WebProcess/WebPage/EventDispatcher.messages.in:
WebProcess/WebPage/WebPage.h:

10:50 AM Changeset in webkit [102962] by beidson@apple.com

4 edits
3 deletes in trunk

Unreviewed, rolling out r102829.
http://trac.webkit.org/changeset/102829
https://bugs.webkit.org/show_bug.cgi?id=74533

Caused https://bugs.webkit.org/show_bug.cgi?id=74555

Source/WebCore:

html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::willMoveToNewOwnerDocument):
(WebCore::HTMLPlugInImageElement::didMoveToNewOwnerDocument):
(WebCore::HTMLPlugInImageElement::documentWillBecomeInactive):
(WebCore::HTMLPlugInImageElement::documentDidBecomeActive):

html/HTMLPlugInImageElement.h:

LayoutTests:

media/crash-closing-page-with-media-as-plugin-fallback-expected.txt: Removed.
media/crash-closing-page-with-media-as-plugin-fallback.html: Removed.
media/resources/video-with-poster-as-object-fallback.html: Removed.

10:45 AM Changeset in webkit [102961] by simonjam@chromium.org

21 edits
1 copy
1 add in trunk

[Navigation Timing] Use monotonicallyIncreasingTime() instead of currentTime()
https://bugs.webkit.org/show_bug.cgi?id=58354

Reviewed by Pavel Feldman.

Source/WebCore:

No new tests. Relies on existing webtiming-* tests.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp: Use monotonic times.

(WebCore::Document::setReadyState):
(WebCore::Document::finishedParsing):

inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didFinishLoadingImpl): Convert monotonicFinishTime to wall time if needed.

inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForTiming): Convert monotonic requestTime to wall time.
(WebCore::buildObjectForResourceResponse): Plumbing for above.
(WebCore::buildObjectForCachedResource): Ditto.
(WebCore::InspectorResourceAgent::willSendRequest): Ditto.
(WebCore::InspectorResourceAgent::didReceiveResponse): Ditto.
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache): Ditto.

loader/DocumentLoadTiming.cpp: Added.

(WebCore::DocumentLoadTiming::DocumentLoadTiming):
(WebCore::DocumentLoadTiming::setNavigationStart): Determine reference time and root reference time.
(WebCore::DocumentLoadTiming::addRedirect): Moved logic from MainResourceLoader.
(WebCore::DocumentLoadTiming::convertMonotonicTimeToDocumentTime): Helper to compute wall time from monotonic time.

loader/DocumentLoadTiming.h: Turned into class. Made times monotonic.

(WebCore::DocumentLoadTiming::setUnloadEventStart):
(WebCore::DocumentLoadTiming::setUnloadEventEnd):
(WebCore::DocumentLoadTiming::setRedirectStart):
(WebCore::DocumentLoadTiming::setRedirectEnd):
(WebCore::DocumentLoadTiming::setFetchStart):
(WebCore::DocumentLoadTiming::setResponseEnd):
(WebCore::DocumentLoadTiming::setLoadEventStart):
(WebCore::DocumentLoadTiming::setLoadEventEnd):
(WebCore::DocumentLoadTiming::setHasSameOriginAsPreviousDocument):
(WebCore::DocumentLoadTiming::navigationStart):
(WebCore::DocumentLoadTiming::unloadEventStart):
(WebCore::DocumentLoadTiming::unloadEventEnd):
(WebCore::DocumentLoadTiming::redirectStart):
(WebCore::DocumentLoadTiming::redirectEnd):
(WebCore::DocumentLoadTiming::redirectCount):
(WebCore::DocumentLoadTiming::fetchStart):
(WebCore::DocumentLoadTiming::responseEnd):
(WebCore::DocumentLoadTiming::loadEventStart):
(WebCore::DocumentLoadTiming::loadEventEnd):
(WebCore::DocumentLoadTiming::hasCrossOriginRedirect):
(WebCore::DocumentLoadTiming::hasSameOriginAsPreviousDocument):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):

loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::continueAfterNavigationPolicy):
(WebCore::MainResourceLoader::willSendRequest): Moved logic to DocumentLoadTiming.
(WebCore::MainResourceLoader::didReceiveData): Use monotonic time.
(WebCore::MainResourceLoader::didFinishLoading): Ditto.
(WebCore::MainResourceLoader::load):

page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchLoadEvent):

page/DOMWindow.h: Removed dispatchTimedEvent. It doesn't really help in the new model.
page/PerformanceNavigation.cpp:

(WebCore::PerformanceNavigation::redirectCount):

page/PerformanceTiming.cpp: Removed skew correction code. This should never happen now.

(WebCore::PerformanceTiming::navigationStart):
(WebCore::PerformanceTiming::unloadEventStart):
(WebCore::PerformanceTiming::unloadEventEnd):
(WebCore::PerformanceTiming::redirectStart):
(WebCore::PerformanceTiming::redirectEnd):
(WebCore::PerformanceTiming::fetchStart):
(WebCore::PerformanceTiming::responseEnd):
(WebCore::PerformanceTiming::domLoading):
(WebCore::PerformanceTiming::domInteractive):
(WebCore::PerformanceTiming::domContentLoadedEventStart):
(WebCore::PerformanceTiming::domContentLoadedEventEnd):
(WebCore::PerformanceTiming::domComplete):
(WebCore::PerformanceTiming::loadEventStart):
(WebCore::PerformanceTiming::loadEventEnd):
(WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute): Used for ResourceLoadTiming.
(WebCore::PerformanceTiming::monotonicTimeToIntegerMilliseconds): Used for DocumentTiming and DocumentLoadTiming.

page/PerformanceTiming.h:
platform/network/ResourceLoadTiming.cpp:

(WebCore::ResourceLoadTiming::convertResourceLoadTimeToDocumentTime):

platform/network/ResourceLoadTiming.h: Added helper function to convert to wall times. Added instructions for use.

LayoutTests:

fast/dom/script-tests/webtiming.js: Current monotonic time is unknown until performance.now() is available. Use 0 until then.

10:44 AM Changeset in webkit [102960] by jonlee@apple.com

11 edits in trunk/Source/WebKit2

[WK2] Extend WebNotification to include its origin https://bugs.webkit.org/show_bug.cgi?id=74615 <rdar://problem/10587164>

Reviewed by Sam Weinig.

Shared/API/c/WKSecurityOrigin.h: Expose API that converts the security origin to database

identifier.

Shared/API/c/WKSecurityOrigin.cpp:

(WKSecurityOriginCopyDatabaseIdentifier):

UIProcess/Notifications/WebNotification.h: Extend WebNotification to include the origin.

(WebKit::WebNotification::create):
(WebKit::WebNotification::origin):

UIProcess/Notifications/WebNotification.cpp: Remove unneeded encode() and decode() functions.

(WebKit::WebNotification::WebNotification):

UIProcess/API/C/WKNotification.h: Expose WebNotification's origin().
UIProcess/API/C/WKNotification.cpp:

(WKNotificationGetSecurityOrigin):

UIProcess/Notifications/WebNotificationManagerProxy.messages.in: Update show() to include the

origin of the notification.

UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::show):

UIProcess/Notifications/WebNotificationManagerProxy.h:
WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show): Pass the notification's exec context's origin as
identifier.

10:39 AM Changeset in webkit [102959] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[Qt][WK2] Add test for download policy on navigation request
https://bugs.webkit.org/show_bug.cgi?id=74541

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2011-12-15
Reviewed by Tor Arne Vestbø.

UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml: Make it wait for a

downloadFinished signal to finish the test.

10:28 AM Changeset in webkit [102958] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

plugin crash

[GTK] Plugins sometimes crash WebKitGTK+ with Gdk-CRITICAL : gdk_window_get_toplevel: assertion `GDK_IS_WINDOW (window)' failed
https://bugs.webkit.org/show_bug.cgi?id=73719

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-12-15
Reviewed by Philippe Normand.

No new tests. It's difficult to test or reproduce this exact situation
as it only occurs when running plugins under nspluginwrapper.

plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::platformGetValue): Properly handle when the plugin tries to
get the window value when the GtkSocket is no longer realized.

10:21 AM Changeset in webkit [102957] by kbr@google.com

2 edits in trunk/LayoutTests

Unreviewed Chromium expectations update. Mark another flaky compositing test.

platform/chromium/test_expectations.txt:

10:20 AM Changeset in webkit [102956] by senorblanco@chromium.org

2 edits in trunk/Source/WebKit/chromium

Enable CSS_FILTERS in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=74334

Reviewed by Kenneth Russell.

features.gypi:

10:17 AM Changeset in webkit [102955] by commit-queue@webkit.org

19 edits
2 adds in trunk

Fix find on web pages with -webkit-user-select: none for Chromium
https://bugs.webkit.org/show_bug.cgi?id=72281

Patch by Martin Kosiba <mkosiba@google.com> on 2011-12-15
Reviewed by Ryosuke Niwa.

Source/WebCore:

Adding findStringAndScrollToVisible to Editor. This new method returns
the new match as a range rather than modify the active selection.

Test: editing/text-iterator/findString-selection-disabled.html

editing/Editor.cpp:

(WebCore::Editor::findStringAndScrollToVisible):

editing/Editor.h:

Source/WebKit/chromium:

This will make it possible to search for text that has
selection disabled (via the webkit-user-select attribute).

WebFrameImpl::find will use findStringAndScrollToVisible, which is
similar to findString except that it uses Range directly rather
than passing the find result in the active selection.

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::find):

Tools:

Provided a partial findString implementation. This doesn't support
all of the FindOptions since they're not exposed via WebFindOptions.

DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::findString):

DumpRenderTree/chromium/LayoutTestController.h:

LayoutTests:

Adding a layout test to verify that find works correctly on pages
that prevent text selection.

editing/text-iterator/findString-selection-disabled-expected.txt: Added.
editing/text-iterator/findString-selection-disabled.html: Added.
platform/efl/Skipped:
platform/gtk-wk2/Skipped:
platform/mac-lion/Skipped:
platform/mac-snowleopard/Skipped:
platform/mac/Skipped:
platform/qt-5.0/Skipped:
platform/qt-mac/Skipped:
platform/qt-wk2/Skipped:
platform/wk2/Skipped:

10:15 AM Changeset in webkit [102954] by andersca@apple.com

4 edits in trunk/Source/WebKit2

Move WorkQueue Mach handlers over to WTF::Function
https://bugs.webkit.org/show_bug.cgi?id=74620

Reviewed by Sam Weinig.

Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::open):
(CoreIPC::Connection::initializeDeadNameSource):

Platform/WorkQueue.h:
Platform/mac/WorkQueueMac.cpp:

(WorkQueue::EventSource::EventSource):
(WorkQueue::EventSource::eventHandler):
(WorkQueue::registerMachPortEventHandler):

10:05 AM Changeset in webkit [102953] by andersca@apple.com

8 edits in trunk/Source

Add WTF::Function to wtf/Forward.h
https://bugs.webkit.org/show_bug.cgi?id=74576

Reviewed by Adam Roben.

Source/JavaScriptCore:

jsc.cpp:

Work around a name conflict in the readline library.

wtf/Forward.h:

Add Function.

Source/WebCore:

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
Add a JSC:: qualifier to the Function flags to avoid ambiguities.

Source/WebKit2:

Platform/RunLoop.h:
Platform/WorkQueue.h:

Remove forward declarations and just include wtf/Forward.h.

9:55 AM Changeset in webkit [102952] by jchaffraix@webkit.org

7 edits
12 adds in trunk

Hardware-backed renderLayer could avoid repainting during a positioned movement layout
https://bugs.webkit.org/show_bug.cgi?id=74370

Reviewed by Simon Fraser.

Source/WebCore:

Tests: compositing/absolute-position-changed-in-composited-layer.html

compositing/absolute-position-changed-with-composited-parent-layer.html
compositing/fixed-position-changed-in-composited-layer.html
compositing/fixed-position-changed-within-composited-parent-layer.html

To be able to properly skip repainting after a positioned movement layout only, we
needed to add more state to the current |setNeedsFullRepaint| method. As part of that
we refactored the callers and internal fields to better match the new meaning.

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleDidChange):
Explicitely gave the RepaintStatus to setRepaintStatus.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::removeOnlyThisLayer):
Updated those function after the renamings.

(WebCore::RenderLayer::updateLayerPositions):
Ditto. Also added a sholdRepaintAfterLayout check.

(WebCore::RenderLayer::shouldRepaintAfterLayout):
Heart of the optimization, if we just did a positioned movement layout of composited RenderLayer,
then don't repaint. All the other cases should still trigger a repaint.

rendering/RenderLayer.h:

(WebCore::RenderLayer::setRepaintStatus):
Renamed setNeedsFullRepaint to setRepaintStatus. Also added a new enum RepaintStatus.

rendering/RenderObject.cpp:

(WebCore::RenderObject::setLayerNeedsFullRepaint):
Updated after the renamings.

(WebCore::RenderObject::setLayerNeedsFullRepaintForPositionedMovementLayout):
New method that pass a new value to the RenderLayer.

rendering/RenderObject.h:

(WebCore::RenderObject::setNeedsPositionedMovementLayout):
Switched the call to the dedicated method.

LayoutTests:

I did not find any test covering positioned movement layout with composited layers
so I added some testing.

compositing/absolute-position-changed-in-composited-layer-expected.png: Added.
compositing/absolute-position-changed-in-composited-layer-expected.txt: Added.
compositing/absolute-position-changed-in-composited-layer.html: Added.
compositing/absolute-position-changed-with-composited-parent-layer-expected.png: Added.
compositing/absolute-position-changed-with-composited-parent-layer-expected.txt: Added.
compositing/absolute-position-changed-with-composited-parent-layer.html: Added.
compositing/fixed-position-changed-in-composited-layer-expected.png: Added.
compositing/fixed-position-changed-in-composited-layer-expected.txt: Added.
compositing/fixed-position-changed-in-composited-layer.html: Added.
compositing/fixed-position-changed-within-composited-parent-layer-expected.png: Added.
compositing/fixed-position-changed-within-composited-parent-layer-expected.txt: Added.
compositing/fixed-position-changed-within-composited-parent-layer.html: Added.

9:53 AM Changeset in webkit [102951] by Antti Koivisto

2 edits in trunk/Source/WebCore

Don't invoke CSSStyleSelector::pushParent before Text::recalcTextStyle
https://bugs.webkit.org/show_bug.cgi?id=74575

Reviewed by Darin Adler.

Text::recalcTextStyle never enters the style selector so pushing the state is not necessary

dom/Element.cpp:

(WebCore::Element::recalcStyle):

9:50 AM Changeset in webkit [102950] by kbr@google.com

10 edits in trunk

[chromium] Add DRT support for WebKitPageCacheSupportsPluginsPreferenceKey
https://bugs.webkit.org/show_bug.cgi?id=74581

Reviewed by Darin Fisher.

Source/WebKit/chromium:

public/WebSettings.h:
src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setPageCacheSupportsPlugins):

src/WebSettingsImpl.h:

Tools:

DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::overridePreference):

DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

DumpRenderTree/chromium/WebPreferences.h:

LayoutTests:

Unskip one test which now passes. The other one will continue to
be covered under the other bug.

platform/chromium/test_expectations.txt:

9:49 AM WebKitGTK/1.6.x edited by Martin Robinson

(diff)

9:33 AM Changeset in webkit [102949] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

Patch by Adam Treat <atreat@rim.com> on 2011-12-15
Reviewed by Rob Buis.

https://bugs.webkit.org/show_bug.cgi?id=74609
PR 122703

For certain configurations of webpage content and zoom level we were
failing to produce a valid backingstore matrix by being to strict on
whether a given matrix fits the preferred matrix orientation.
This patch fixes this by insisting on storing a candidate divisor
whether or not it agrees with the preferred matrix orientation and then
comparing all subsequent divisors.

blackberry/Api/BackingStore.cpp:

(BlackBerry::WebKit::divisorIsPerfectWidth):
(BlackBerry::WebKit::divisorIsPerfectHeight):
(BlackBerry::WebKit::divisorIsPreferredDirection):
(BlackBerry::WebKit::bestDivisor):

9:21 AM Changeset in webkit [102948] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit2

[Qt][WK2] Move WebPreferences into experimental
https://bugs.webkit.org/show_bug.cgi?id=74404

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2011-12-15
Reviewed by Tor Arne Vestbø.

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewExperimental::preferences):

UIProcess/API/qt/qquickwebview_p.h:
UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:

9:09 AM Changeset in webkit [102947] by cmarrin@apple.com

1 edit in trunk/Source/WebCore/ChangeLog

Fixed error in Target.pri.

Unreviewed.

Target.pri:

9:09 AM Changeset in webkit [102946] by cmarrin@apple.com

2 edits in trunk/Source/WebCore

Fixed error in Target.pri.

Unreviewed.

Target.pri:

8:58 AM Changeset in webkit [102945] by leviw@chromium.org

1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp

Correcting positioning of scrollbars to use pixelSnapped logic instead of enclosingIntRect

8:55 AM Changeset in webkit [102944] by leviw@chromium.org

23 edits in branches/subpixellayout/Source/WebCore

Changing Renderer offsetLeft/Top/Width/Height to be LayoutUnits. Adding pixelSnapped versions as well.
Changing AppUnit version of adjustForAbsoluteZoom to return an int and behave like the int version. This is needed to get zoomed values to read back properly.
Moved snapSizeToPixel to AppUnit.h.

8:46 AM Changeset in webkit [102943] by apavlov@chromium.org

7 edits in trunk

Web Inspector: #hex colors are not highlighted in CSS files
https://bugs.webkit.org/show_bug.cgi?id=74570

Reviewed by Pavel Feldman.

Source/WebCore:

Drive by: highlight color keywords as colors, not as keywords.

inspector/front-end/CSSKeywordCompletions.js:

(WebInspector.CSSKeywordCompletions.colors):

inspector/front-end/SourceCSSTokenizer.js:

(WebInspector.SourceCSSTokenizer):
(WebInspector.SourceCSSTokenizer.prototype.nextToken):

inspector/front-end/SourceCSSTokenizer.re2js:

LayoutTests:

inspector/syntax-highlight-css-expected.txt:
inspector/syntax-highlight-css.html:

8:42 AM Changeset in webkit [102942] by cmarrin@apple.com

7 edits
4 moves in trunk/Source/WebCore

Hardware acceleration of W3C Filter Effects
https://bugs.webkit.org/show_bug.cgi?id=68479

Reviewed by Simon Fraser.

Move FilterOperation(s) to platform/graphics/filters so it can be used to pass filter information
down to GraphicsLayer for hardware acceleration. This leaves the CustomFilterOperation subclass in
rendering/style since it has dependencies outside platform. Some part of that class will
eventually need to be down in platform.

8:40 AM Changeset in webkit [102941] by kenneth@webkit.org

2 edits in trunk/Tools

[Qt] Improve the look of the viewport info overlay

Reviewed by Tor Arne Vestbø.

MiniBrowser/qt/qml/ViewportInfoItem.qml:

8:40 AM Changeset in webkit [102940] by vsevik@chromium.org

4 edits
1 copy in trunk/LayoutTests

Unreviewed test expectations fix.

http/tests/inspector/console-resource-errors-expected.txt:
http/tests/inspector/console-xhr-logging-expected.txt:
platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt: Copied from LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt.
platform/qt/Skipped:

8:27 AM Changeset in webkit [102939] by igor.oliveira@openbossa.org

8 edits in trunk

[Qt] Support requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=74528

Source/JavaScriptCore:

Let Qt port use REQUEST_ANIMATION_FRAME_TIMER.

Reviewed by Kenneth Rohde Christiansen.

wtf/Platform.h:

Source/WebCore:

Add necessary files to Target.pri when enabling requestAnimationFrame option.

Reviewed by Kenneth Rohde Christiansen.

Target.pri:

Tools:

Add build-option for requestAnimationFrame feature.

Reviewed by Kenneth Rohde Christiansen.

qmake/mkspecs/features/features.prf:

LayoutTests:

Enable requestAnimationFrame tests.

Reviewed by Kenneth Rohde Christiansen.

platform/qt/Skipped:

8:21 AM Changeset in webkit [102938] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

platform/qt/Skipped: Skip new failing tests (regressions).
platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated after r102918.

7:53 AM Changeset in webkit [102937] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Removing BlackBerryCookieCache from the build system
https://bugs.webkit.org/show_bug.cgi?id=74318

Patch by Otto Cheung <ocheung@rim.com> on 2011-12-15
Reviewed by Rob Buis.

Removing any references to BlackBerryCookieCache in files that are upstreamed.

We are removing the BlackBerryCookieCache because the CookieManager cookie structure has been
refactored to have a similar structure to the cache. Since the read speeds in both structures
are similar, we no longer need the cache to speed up read performance.

No new tests, this patch by itself will not work. This patch is only removing
the references to BlackBerryCookieCache in files that are upstreamed.

PlatformBlackBerry.cmake:
platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyHeaderReceived):

7:36 AM Changeset in webkit [102936] by commit-queue@webkit.org

2 edits in trunk

Web Inspector: [Chromium] Call LowMemoryNotification instead of IdleNotification
https://bugs.webkit.org/show_bug.cgi?id=71821

Patch by Ulan Degenbaev <ulan@chromium.org> on 2011-12-15
Reviewed by Yury Semikhatsky.

Source/WebCore/bindings/v8/ScriptProfiler.cpp:

7:11 AM Changeset in webkit [102935] by Carlos Garcia Campos

12 edits
1 copy
2 adds in trunk/Source/WebKit2

[GTK] Add WebKitWindowProperties to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=74595

Reviewed by Gustavo Noronha Silva.

GNUmakefile.am: Add new files to compilation.
UIProcess/API/gtk/WebKitUIClient.cpp:

(createNewPage): Pass the dictionary containing the window
features to webkitWebViewCreateNewPage().
(toolbarsAreVisible): Return
WebKitWindowProperties:toolbar-visible.
(setToolbarsAreVisible): Set
WebKitWindowProperties:toolbar-visible.
(menuBarIsVisible): Return WebKitWindowProperties:menu-visible.
(setMenuBarIsVisible): Set WebKitWindowProperties:menu-visible.
(statusBarIsVisible): Return
WebKitWindowProperties:status-visible.
(setStatusBarIsVisible): Set
WebKitWindowProperties:status-visible.
(isResizable): Return WebKitWindowProperties:resizable.
(setIsResizable): Set WebKitWindowProperties:resizable.
(getWindowFrame): Return WebKitWindowProperties:geometry.
(setWindowFrame): Set WebKitWindowProperties:geometry.
(webkitUIClientAttachUIClientToPage): Initialize the UI client for
the given page.

UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_init): Create a WebKitWindowProperties object for
the view.
(webkit_web_view_class_init):
(webkitWebViewCreateNewPage): Update the WebKitWindowProperties
object using the window features dictionary.
(webkit_web_view_get_window_properties): Return the
WebKitWindowProperties object of the view.

UIProcess/API/gtk/WebKitWebView.h:
UIProcess/API/gtk/WebKitWebViewPrivate.h:
UIProcess/API/gtk/WebKitWindowProperties.cpp: Added.

(webkitWindowPropertiesFinalize):
(webkitWindowPropertiesGetProperty):
(webkitWindowPropertiesSetProperty):
(webkit_window_properties_class_init):
(webkit_window_properties_init):
(webkitWindowPropertiesCreate): Create a new
WebKitWindowProperties object.
(webkitWindowPropertiesSetGeometry):
(webkitWindowPropertiesSetToolbarVisible):
(webkitWindowPropertiesSetMenubarVisible):
(webkitWindowPropertiesSetStatusbarVisible):
(webkitWindowPropertiesSetLocationbarVisible):
(webkitWindowPropertiesSetScrollbarsVisible):
(webkitWindowPropertiesSetResizable):
(webkitWindowPropertiesSetFullscreen):
(webkitWindowPropertiesUpdateFromWKWindowFeatures): Parse the
window features dictionary and update the WebKitWindowProperties
object accordingly.
(webkit_window_properties_get_geometry):
(webkit_window_properties_get_toolbar_visible):
(webkit_window_properties_get_statusbar_visible):
(webkit_window_properties_get_scrollbars_visible):
(webkit_window_properties_get_menubar_visible):
(webkit_window_properties_get_locationbar_visible):
(webkit_window_properties_get_resizable):
(webkit_window_properties_get_fullscreen):

UIProcess/API/gtk/WebKitWindowProperties.h: Added.
UIProcess/API/gtk/WebKitWindowPropertiesPrivate.h: Copied from Source/WebKit2/UIProcess/API/gtk/WebKitWebViewPrivate.h.
UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for

WebKitWindowProperties.

UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
UIProcess/API/gtk/docs/webkit2gtk.types: Add

webkit_window_properties_get_type.

UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(WindowProperties::windowPropertiesNotifyCallback):
(WindowProperties::viewReadyToShow):
(WindowProperties::viewCreate):
(WindowProperties::setExpectedWindowProperties):
(testWebViewWindowProperties):
(beforeAll):

UIProcess/API/gtk/webkit2.h: Include WebKitWindowProperties.h.
UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::createNewPage): Add also "locationBarVisible"
to the window features dictionary.

6:59 AM Changeset in webkit [102934] by kenneth@webkit.org

2 edits in trunk/Source/WebCore

[Qt] Mobile theme improvements

Rubberstamped by Simon Hausmann.

Invert the gradient on the checkboxes
Make the buttons on the multi select combobox work on floats
Mini cleanups

platform/qt/RenderThemeQtMobile.cpp:

(WebCore::StylePainterMobile::drawCheckableBackground):
(WebCore::StylePainterMobile::drawMultipleComboButton):
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::drawComboBox):

6:19 AM Changeset in webkit [102933] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py convert script conditions to precompiler #ifs
https://bugs.webkit.org/show_bug.cgi?id=74534

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-12-15
Reviewed by Pavel Feldman.

Generator is rewritten to add #if's to output.

inspector/CodeGeneratorInspector.py:

(DomainNameFixes.get_fixed_data.Res.get_guard.Guard.generate_open):
(DomainNameFixes.get_fixed_data.Res.get_guard.Guard):
(DomainNameFixes.get_fixed_data.Res.get_guard.Guard.generate_close):
(DomainNameFixes.get_fixed_data.Res):
(DomainNameFixes.get_fixed_data.Res.get_guard):
(Generator.go):
(Generator.process_event):
(Generator.process_command):
(Generator.process_types):

6:09 AM Changeset in webkit [102932] by caio.oliveira@openbossa.org

14 edits
2 deletes in trunk/Source/WebKit2

[Qt] [WK2] Remove QtWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=74540

Reviewed by Kenneth Rohde Christiansen.

Move WebPageProxy* to QQuickWebViewPrivate. The remaining functions in
QtWebPageProxy were simple wrappers to WebKit functionality (text zoom, page zoom
and user agent setting). Since those wrappers are unused, they were removed. The
signal in the class was also unused.

This patch also remove the code from WebContextMenuProxyQt, it was remains of a
previous QMenu-based implementation. We want to rewrite this code for QML anyway,
so I reverted to an empty state.

Farewell, QtWebPageProxy!

Target.pri:
UIProcess/API/qt/qquickwebpage.cpp:
UIProcess/API/qt/qquickwebpage_p.h:
UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::~QQuickWebViewPrivate):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebViewPrivate::createDrawingAreaProxy):
(QQuickWebViewPrivate::updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::_q_viewportTrajectoryVectorChanged):
(QQuickWebViewPrivate::_q_onVisibleChanged):
(QQuickWebViewPrivate::updateViewportSize):
(QQuickWebViewPrivate::computeViewportConstraints):
(QQuickWebViewPrivate::setUseTraditionalDesktopBehaviour):
(QQuickWebViewPrivate::setNavigatorQtObjectEnabled):
(QQuickWebViewExperimental::postMessage):
(QQuickWebView::load):
(QQuickWebView::goBack):
(QQuickWebView::goForward):
(QQuickWebView::stop):
(QQuickWebView::reload):
(QQuickWebView::url):
(QQuickWebView::canGoBack):
(QQuickWebView::canGoForward):
(QQuickWebView::loading):
(QQuickWebView::canReload):
(QQuickWebView::title):
(QQuickWebView::pageRef):
(QQuickWebView::loadHtml):

UIProcess/API/qt/qquickwebview_p.h:
UIProcess/API/qt/qquickwebview_p_p.h:
UIProcess/API/qt/qwebnavigationhistory_p_p.h:
UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::preferencesRef):

UIProcess/PageClient.h:
UIProcess/qt/QtPageClient.cpp:

(QtPageClient::QtPageClient):
(QtPageClient::initialize):
(QtPageClient::createPopupMenuProxy):
(QtPageClient::createContextMenuProxy):

UIProcess/qt/QtPageClient.h:
UIProcess/qt/QtWebPageProxy.cpp: Removed.
UIProcess/qt/QtWebPageProxy.h: Removed.
UIProcess/qt/WebContextMenuProxyQt.cpp:

(WebKit::WebContextMenuProxyQt::WebContextMenuProxyQt):
(WebKit::WebContextMenuProxyQt::create):
(WebKit::WebContextMenuProxyQt::showContextMenu):
(WebKit::WebContextMenuProxyQt::hideContextMenu):

UIProcess/qt/WebContextMenuProxyQt.h:

5:45 AM Changeset in webkit [102931] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Minor refactor to Parser::parseTryStatement
https://bugs.webkit.org/show_bug.cgi?id=74507

Patch by Andy Wingo <wingo@igalia.com> on 2011-12-15
Reviewed by Geoffrey Garen.

parser/Parser.cpp (JSC::Parser::parseTryStatement): Use the

Parser's declareVariable instead of going directly to the scope.
This will facilitate future checks related to harmony block
scoping.

5:36 AM Changeset in webkit [102930] by vsevik@chromium.org

1 edit
1 add in trunk/LayoutTests

Unreviewed chromium test rebaseline.

platform/chromium/http/tests/inspector/network/script-as-text-loading-expected.txt: Added.

5:32 AM Changeset in webkit [102929] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline.

platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:

5:26 AM Changeset in webkit [102928] by caseq@chromium.org

2 edits in trunk/Source/WebKit/chromium

Web Inspector: [Chromium] add support to inspector test suite to fetch test execution results from console
https://bugs.webkit.org/show_bug.cgi?id=74208

Reviewed by Yury Semikhatsky.

This adds waitForTestResultsInConsole, a test suite method that monitors console for a message containing
either PASS or FAIL and sets result accordingly. This is used by tests running in the extension context to
communicate test results to the test driver (see devtools_sanity_unittest.cc for an example).

src/js/Tests.js:

(.TestSuite.prototype.testWaitForResultsInConsole.onConsoleMessage):
(.TestSuite.prototype.testWaitForResultsInConsole):

5:19 AM Changeset in webkit [102927] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[WK2] Eliminate unnecessary GTK/QT ifdefs for shared memory implementation
https://bugs.webkit.org/show_bug.cgi?id=74602

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2011-12-15
Reviewed by Kenneth Rohde Christiansen.

For shared memory Qt was using shm_open, Gtk was using files in /tmp. There
is no reason to obfuscate the code with #ifdefs or let Gtk use an inferior
method of opening shared memory. So this patch makes SharedMemoryUnix.cpp
truly Qt and Gtk independent.

Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::create):

5:18 AM Changeset in webkit [102926] by jesus@webkit.org

2 edits in trunk/Source/WebCore

[Qt][WK2] Setting Download as action for navigation request crashes WebProcess
https://bugs.webkit.org/show_bug.cgi?id=74526

Reviewed by Simon Hausmann.

Adding checks for networkcontext and networkAccessManager
and return true in case they don't exist, following the same
logic as if the CookieJar doesn't exist.

platform/qt/ThirdPartyCookiesQt.cpp:

(WebCore::thirdPartyCookiePolicyPermits):

5:16 AM Changeset in webkit [102925] by vestbo@webkit.org

4 edits in trunk

[Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path

Reviewed Simon Hausmann.

5:04 AM Changeset in webkit [102924] by Simon Hausmann

2 edits in trunk/Source/WebKit2

[Qt] Cleanup: Remove unnecessary const_cast

Reviewed by Kenneth Christiansen.

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::preferences):

4:40 AM Changeset in webkit [102923] by vestbo@webkit.org

5 edits in trunk/Source

[Qt] Get rid of layering violation in PluginViewQt

PluginViewQt has a layering violation in relying on QWebPagePrivate for
the check if running under DRT. We remove this and add a specific flag
in the PluginView for this check, enabled from DRTSupport. This isn't
pretty, but an improvement over what's currently there.

Reviewed by Simon Hausmann.

4:38 AM Changeset in webkit [102922] by commit-queue@webkit.org

14 edits
4 adds in trunk

[QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.
https://bugs.webkit.org/show_bug.cgi?id=72893

Patch by Michael Brüning <michael.bruning@nokia.com> on 2011-12-15
Reviewed by Kenneth Rohde Christiansen.

This patch extends QQuickWebViewExperimental by a property named
viewportInfo, which contains the viewport scalability and
layout and contents size information. This property is exposed to
QML through the experimental extension for QQuickWebView.

Source/qtwebkit-export.map:

Source/WebKit/qt:

declarative/experimental/plugin.cpp:

Source/WebKit2:

Target.pri:
UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewPrivate::computeViewportConstraints):
(QQuickWebViewPrivate::PostTransitionState::apply): Added applying
contentsSize to viewportInfo.
(QQuickWebViewExperimental::QQuickWebViewExperimental):
(QQuickWebViewExperimental::viewportInfo):

UIProcess/API/qt/qquickwebview_p.h:
UIProcess/API/qt/qquickwebview_p_p.h: Moved PostTransitionState::apply

to qquickwebview.cpp. Added friend QWebViewportInfo.

UIProcess/API/qt/qwebviewportinfo.cpp: Added.

(QWebViewportInfo::QWebViewportInfo):
(QWebViewportInfo::~QWebViewportInfo):
(QWebViewportInfo::contentsSize):
(QWebViewportInfo::currentScale):
(QWebViewportInfo::devicePixelRatio):
(QWebViewportInfo::initialScale):
(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):
(QWebViewportInfo::isScalable):
(QWebViewportInfo::layoutSize):
(QWebViewportInfo::didUpdateContentsSize):
(QWebViewportInfo::didUpdateCurrentScale):
(QWebViewportInfo::didUpdateViewportConstraints):

UIProcess/API/qt/qwebviewportinfo_p.h: Added.
UIProcess/qt/QtViewportInteractionEngine.h:

(WebKit::QtViewportInteractionEngine::Constraints::Constraints): Added layoutSize.
(WebKit::QtViewportInteractionEngine::constraints): Added property to access m_contraints.

Tools:

MiniBrowser/qt/MiniBrowser.pro:
MiniBrowser/qt/MiniBrowser.qrc:
MiniBrowser/qt/icons/info.png: Added.
MiniBrowser/qt/qml/BrowserWindow.qml:
MiniBrowser/qt/qml/ViewportInfoItem.qml: Added.

4:35 AM Changeset in webkit [102921] by peter@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Enable TestNetscapePlugIn to link for Android
https://bugs.webkit.org/show_bug.cgi?id=74597

Reviewed by Tony Gentilcore.

The -nostdlib linker flag is being passed to all targets being build
for Android, which conflicts with the shared library the
TestNetscapePlugIn target created. Explicitly exclude the flag.

WebKit.gyp:

4:31 AM Changeset in webkit [102920] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[WK2] WebPage::m_useFixedLayout variable unininitialized
https://bugs.webkit.org/show_bug.cgi?id=74596

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2011-12-15
Reviewed by Kenneth Rohde Christiansen.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Avoid uninitialized use through
initialization in the constructor.

4:16 AM Changeset in webkit [102919] by vsevik@chromium.org

6 edits in trunk

Web Inspector: Console should show network messages origins.
https://bugs.webkit.org/show_bug.cgi?id=74521

Reviewed by Pavel Feldman.

Source/WebCore:

inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage):

LayoutTests:

http/tests/inspector/console-resource-errors-expected.txt:
http/tests/inspector/console-xhr-logging-expected.txt:
platform/chromium/http/tests/inspector/console-resource-errors-expected.txt:

4:02 AM Changeset in webkit [102918] by commit-queue@webkit.org

4 edits
2 adds in trunk

"user-select none" causes selection to incorrectly escape from clicked container
https://bugs.webkit.org/show_bug.cgi?id=57289

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-12-15
Reviewed by Ryosuke Niwa.

Source/WebCore:

Not selecting the nearest word from the target node if target node has -webkit-user-select:none

Test: fast/events/mouse-double-triple-click-should-not-select-next-node-for-user-select-none.html

page/EventHandler.cpp:

(WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart):
If target node has webkit-user-select:none style then do not update the selection.

LayoutTests:

fast/events/mouse-double-triple-click-should-not-select-next-node-for-user-select-none-expected.txt: Added.
fast/events/mouse-double-triple-click-should-not-select-next-node-for-user-select-none.html: Added.
fast/js/resources/js-test-pre.js:

(shouldNotBe):
Added new helper function to check for inequality.

4:01 AM Changeset in webkit [102917] by commit-queue@webkit.org

22 edits
2 moves in trunk/Source/JavaScriptCore

Rename JSC::Heuristics to JSC::Options
https://bugs.webkit.org/show_bug.cgi?id=72889

Patch by Andy Wingo <wingo@igalia.com> on 2011-12-15
Reviewed by Filip Pizlo.

runtime/Options.cpp: Renamed from Source/JavaScriptCore/runtime/Heuristics.cpp.
runtime/Options.h: Renamed from Source/JavaScriptCore/runtime/Heuristics.h.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
bytecode/CodeBlock.cpp:

(JSC::CodeBlock::shouldOptimizeNow):

bytecode/CodeBlock.h:

(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
(JSC::CodeBlock::reoptimizationRetryCounter):
(JSC::CodeBlock::countReoptimization):
(JSC::CodeBlock::counterValueForOptimizeAfterWarmUp):
(JSC::CodeBlock::counterValueForOptimizeAfterLongWarmUp):
(JSC::CodeBlock::optimizeNextInvocation):
(JSC::CodeBlock::dontOptimizeAnytimeSoon):
(JSC::CodeBlock::optimizeSoon):
(JSC::CodeBlock::largeFailCountThreshold):
(JSC::CodeBlock::largeFailCountThresholdForLoop):
(JSC::CodeBlock::shouldReoptimizeNow):
(JSC::CodeBlock::shouldReoptimizeFromLoopNow):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):

dfg/DFGCapabilities.h:

(JSC::DFG::mightCompileEval):
(JSC::DFG::mightCompileProgram):
(JSC::DFG::mightCompileFunctionForCall):
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForConstruct):

dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):

dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):

heap/MarkStack.cpp:

(JSC::MarkStackSegmentAllocator::allocate):
(JSC::MarkStackSegmentAllocator::shrinkReserve):
(JSC::MarkStackArray::MarkStackArray):
(JSC::MarkStackArray::donateSomeCellsTo):
(JSC::MarkStackArray::stealSomeCellsFrom):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::SlotVisitor::donateSlow):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):

heap/MarkStack.h:

(JSC::MarkStack::mergeOpaqueRootsIfProfitable):
(JSC::MarkStack::addOpaqueRoot):
(JSC::MarkStackArray::canDonateSomeCells):

heap/SlotVisitor.h:

(JSC::SlotVisitor::donate):

jit/JIT.cpp:

(JSC::JIT::emitOptimizationCheck):

runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce): Adapt callers and build systems.

testRegExp.cpp:

(CommandLine::CommandLine):

jsc.cpp:

(CommandLine::CommandLine):
Rename from Options, to avoid name conflict.

3:58 AM Changeset in webkit [102916] by caseq@chromium.org

17 edits in trunk

Web Inspector: Generated HAR is missing pages.startedDateTime
https://bugs.webkit.org/show_bug.cgi?id=74188

Reviewed by Pavel Feldman.

Source/WebCore:

inspector/front-end/HAREntry.js:

(WebInspector.HARLog.prototype._buildPages):

inspector/front-end/NetworkLog.js:

(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype.get mainResourceStartTime):
(WebInspector.NetworkLog.prototype._mainFrameNavigated):

inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._updateSummaryBar):

LayoutTests:

http/tests/inspector/inspector-test.js:

(initialize_InspectorTest.InspectorTest.formatRecentTime):
(initialize_InspectorTest.InspectorTest.addObject):

http/tests/inspector/resource-har-conversion-expected.txt:
http/tests/inspector/resource-parameters-expected.txt:
http/tests/inspector/resources-test.js:
platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt:
platform/mac-snowleopard/http/tests/inspector/resource-har-conversion-expected.txt:

3:57 AM Changeset in webkit [102915] by bashi@chromium.org

16 edits
3 adds in trunk

Supports Unicode variation selector
https://bugs.webkit.org/show_bug.cgi?id=50999

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Adds SimpleFontData::updateGlyphWithVariationSelector() which substitutes the
glyph in question based on the selector. WidthIterator::advance() calls it
when an unicode variation selector follows the character.

Test: fast/text/unicode-variation-selector.html

platform/graphics/SimpleFontData.h: Added updateGlyphWithVariationSelector().
platform/graphics/SurrogatePairAwareTextIterator.cpp:

(WebCore::isUnicodeBMPVariationSelector): Added.
(WebCore::isUnicodeSupplementaryVariationSelector): Added.
(WebCore::SurrogatePairAwareTextIterator::hasTrailingVariationSelector): Added.

platform/graphics/SurrogatePairAwareTextIterator.h:
platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance): Changed to detect variation selectors.

platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::updateGlyphWithVariationSelector): Added.

platform/graphics/chromium/SimpleFontDataLinux.cpp:

(WebCore::SimpleFontData::updateGlyphWithVariationSelector): Ditto.

platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::SimpleFontData::updateGlyphWithVariationSelector): Ditto.

platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::decomposeToUTF16): Ditto.
(WebCore::SimpleFontData::updateGlyphWithVariationSelector): Ditto.

platform/graphics/pango/SimpleFontDataPango.cpp:

(WebCore::SimpleFontData::updateGlyphWithVariationSelector): Ditto.

platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::updateGlyphWithVariationSelector): Ditto.

platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::updateGlyphWithVariationSelector): Ditto.

platform/graphics/wince/SimpleFontDataWinCE.cpp:

(WebCore::SimpleFontData::updateGlyphWithVariationSelector): Ditto.

platform/graphics/wx/SimpleFontDataWx.cpp:

(WebCore::SimpleFontData::updateGlyphWithVariationSelector): Ditto.

LayoutTests:

Add test for unicode variation selector support.
A tiny font (gw432047.ttf), which comes from glyphwiki.org and is used by Mozilla, is added for the test.

fast/text/resources/gw432047-license.txt: Added.
fast/text/resources/gw432047.ttf: Added.
fast/text/unicode-variation-selector.html: Added.
platform/chromium/test_expectations.txt: Added fast/text/unicode-variation-selector.html. This test need rebaseline.

3:44 AM Changeset in webkit [102914] by commit-queue@webkit.org

2 edits in trunk/Tools

[chromium] WebViewHost::requestCheckingOfText should return immediately if text is empty.
https://bugs.webkit.org/show_bug.cgi?id=74586

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-15
Reviewed by Hajime Morita.

No new tests. Covered by existing tests.

DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::requestCheckingOfText):

Returns immediately if text is empty.

3:21 AM Changeset in webkit [102913] by apavlov@chromium.org

3 edits
2 adds in trunk

[v8] Expose the "filter" property in V8CSSStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=73426

Source/WebCore:

Reviewed by Adam Barth.

Test: fast/css/style-enumerate-properties.html

The "filter" CSS property used to be masked to be compliant with JSC, but JSC has supported
this property for quite a while.

bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(WebCore::hasCSSPropertyNamePrefix): clean up WTF prefixes
(WebCore::cssPropertyInfo): remove the "wasFilter" flag
(WebCore::V8CSSStyleDeclaration::namedPropertyEnumerator): remove the "filter" check
(WebCore::V8CSSStyleDeclaration::namedPropertyGetter): return the "filter" value as v8String

LayoutTests:

The original version of this test should have landed in r102578 but was lost
during the "revert-reland" cycle.

Reviewed by Adam Barth.

fast/css/style-enumerate-properties-expected.txt: Added.
fast/css/style-enumerate-properties.html: Added.

2:58 AM Changeset in webkit [102912] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/qt

[Qt] Remove unnecessary methods and members from DeviceOrientationClientQt
https://bugs.webkit.org/show_bug.cgi?id=74588

Patch by Alexander Færøy <ahf@0x90.dk> on 2011-12-15
Reviewed by Simon Hausmann.

Remove the unused method changeDeviceOrientation() from
DeviceOrientationClientQt and remove the DeviceOrientationController
member since it is unused.

WebCoreSupport/DeviceOrientationClientQt.cpp:

(WebCore::DeviceOrientationClientQt::DeviceOrientationClientQt):
(WebCore::DeviceOrientationClientQt::setController):

WebCoreSupport/DeviceOrientationClientQt.h:

2:58 AM Changeset in webkit [102911] by morrita@google.com

2 edits in trunk/Source/WebCore

Unreviewed build fix attempt for Chromium Mac.

page/PerformanceTiming.h:

2:09 AM Changeset in webkit [102910] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed, build fix after r102906 (poor merge).

inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileType.prototype.buttonClicked):

2:06 AM Changeset in webkit [102909] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[Qt] r102849 broke the Qt build on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=74594

Patch by Alexander Færøy <ahf@0x90.dk> on 2011-12-15
Reviewed by Simon Hausmann.

The APPLE macro is defined on all standard OS X compilers, which
leads to various CoreGraphics headers to be included in the Qt build.

config.h:

1:59 AM Changeset in webkit [102908] by vsevik@chromium.org

21 edits
2 deletes in trunk

Unreviewed revert of r102696 ([Navigation Timing] Use monotonicallyIncreasingTime() instead of currentTime()).
Breaks inspector's network panel timeline on chromium.

Source/WebCore:

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp:

(WebCore::Document::setReadyState):
(WebCore::Document::finishedParsing):

inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didFinishLoadingImpl):

inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForTiming):
(WebCore::buildObjectForResourceResponse):
(WebCore::buildObjectForCachedResource):
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):

loader/DocumentLoadTiming.cpp: Removed.
loader/DocumentLoadTiming.h:

(WebCore::DocumentLoadTiming::DocumentLoadTiming):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):

loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::continueAfterNavigationPolicy):
(WebCore::MainResourceLoader::willSendRequest):
(WebCore::MainResourceLoader::didReceiveData):
(WebCore::MainResourceLoader::didFinishLoading):
(WebCore::MainResourceLoader::load):

page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchLoadEvent):
(WebCore::DOMWindow::dispatchTimedEvent):

page/DOMWindow.h:
page/PerformanceNavigation.cpp:

(WebCore::PerformanceNavigation::redirectCount):

page/PerformanceTiming.cpp:

(WebCore::getPossiblySkewedTimeInKnownRange):
(WebCore::PerformanceTiming::navigationStart):
(WebCore::PerformanceTiming::unloadEventStart):
(WebCore::PerformanceTiming::unloadEventEnd):
(WebCore::PerformanceTiming::redirectStart):
(WebCore::PerformanceTiming::redirectEnd):
(WebCore::PerformanceTiming::fetchStart):
(WebCore::PerformanceTiming::responseEnd):
(WebCore::PerformanceTiming::domLoading):
(WebCore::PerformanceTiming::domInteractive):
(WebCore::PerformanceTiming::domContentLoadedEventStart):
(WebCore::PerformanceTiming::domContentLoadedEventEnd):
(WebCore::PerformanceTiming::domComplete):
(WebCore::PerformanceTiming::loadEventStart):
(WebCore::PerformanceTiming::loadEventEnd):
(WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute):

page/PerformanceTiming.h:
platform/network/ResourceLoadTiming.cpp: Removed.
platform/network/ResourceLoadTiming.h:

LayoutTests:

fast/dom/script-tests/webtiming.js:

1:45 AM Changeset in webkit [102907] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed, fix Closure compiler warnings after r102905.

inspector/front-end/CSSStyleModel.js: Add JSDoc annotations

1:37 AM Changeset in webkit [102906] by apavlov@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: make ProfilesPanel scale as the number of ProfileTypes grows
https://bugs.webkit.org/show_bug.cgi?id=74391

Reviewed by Pavel Feldman.

Whenever a profile is started, this change disables all profile recording buttons, except the one
that correponds to the running profile. Once the profiling is finished, all buttons get enabled back again.

English.lproj/localizedStrings.js:
inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileView.profileCallback):
(WebInspector.CPUProfileType.prototype.get buttonTooltip):
(WebInspector.CPUProfileType.prototype.get buttonStyle):
(WebInspector.CPUProfileType.prototype.buttonClicked):

inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.get statusBarItems.clickHandler):
(WebInspector.ProfilesPanel.prototype.get statusBarItems):
(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype.updateProfileTypeButtons):
(WebInspector.ProfilesPanel.prototype._updateInterface):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
(WebInspector.ProfilerDispatcher.prototype.setRecordingProfile):

inspector/front-end/inspector.css:

(.record-cpu-profile-status-bar-item .glyph):
(.record-cpu-profile-status-bar-item.toggled-on .glyph):

1:33 AM Changeset in webkit [102905] by commit-queue@webkit.org

2 edits in trunk/Tools

[Qt] QtWebKit fails to build on Mac OS X after r102776
https://bugs.webkit.org/show_bug.cgi?id=74593

Patch by Alexander Færøy <ahf@0x90.dk> on 2011-12-15
Reviewed by Simon Hausmann.

CONFIG =+ link_pkgconfig is needed such that the correct parameters
are passed to the compiler.

DumpRenderTree/qt/DumpRenderTree.pro:

1:29 AM Changeset in webkit [102904] by zherczeg@webkit.org

3 edits
1 add in trunk/LayoutTests

Unreviewed, Qt rebaseline after r102149 and r102846.

platform/qt/editing/pasteboard/paste-text-013-expected.txt:
platform/qt/editing/pasteboard/paste-text-014-expected.txt:
platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.

1:23 AM Changeset in webkit [102903] by apavlov@chromium.org

11 edits in trunk/Source/WebCore

Web Inspector: [Styles] Update selected DOM element styles whenever applicable media queries change
https://bugs.webkit.org/show_bug.cgi?id=74292

The change introduces and handles in the frontend a new event type for the CSS domain,
"mediaQueryResultChanged", which gets fired every time a viewport-dependent media feature
changes its value. This allows users to see live changes of the (media-dependent) matched
rules for inspected elements.

Reviewed by Pavel Feldman.

inspector/CodeGeneratorInspector.py:

(DomainNameFixes):

inspector/Inspector.json:
inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::setFrontend):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::restore):
(WebCore::InspectorCSSAgent::enable):
(WebCore::InspectorCSSAgent::disable):
(WebCore::InspectorCSSAgent::mediaQueryResultChanged):

inspector/InspectorCSSAgent.h:
inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::mediaQueryResultChangedImpl):

inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::mediaQueryResultChanged):

inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.mediaQueryResultChanged):
(WebInspector.CSSDispatcher):
(WebInspector.CSSDispatcher.prototype.mediaQueryResultChanged):

inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane):
(WebInspector.MetricsSidebarPane.prototype._styleSheetOrMediaQueryResultChanged):

inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype._styleSheetOrMediaQueryResultChanged):

page/FrameView.cpp:

(WebCore::FrameView::layout):

1:21 AM Changeset in webkit [102902] by morrita@google.com

1 edit
5 deletes in trunk/LayoutTests

Unreviewed, removing incorrect expectaions.

platform/chromium-cg-mac-leopard/media/video-poster-blocked-by-willsendrequest-expected.txt: Removed.
platform/chromium-cg-mac-snowleopard/media/video-poster-blocked-by-willsendrequest-expected.txt: Removed.
platform/chromium-mac-leopard/media/video-poster-blocked-by-willsendrequest-expected.txt: Removed.
platform/chromium-mac-snowleopard/media/video-poster-blocked-by-willsendrequest-expected.txt: Removed.
platform/chromium-win-xp/media/video-poster-blocked-by-willsendrequest-expected.txt: Removed.

1:12 AM Changeset in webkit [102901] by vsevik@chromium.org

2 edits in branches/chromium/963/Source/WebCore/inspector/front-end

Merge 102756 - Web Inspector: [Regression] Scripts panel debug sidebar toolbar should not be scrolled out of the screen.
https://bugs.webkit.org/show_bug.cgi?id=74447

Reviewed by Pavel Feldman.

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.wasShown):

inspector/front-end/scriptsPanel.css:

(#scripts-debug-toolbar):
(#scripts-debug-sidebar-contents):

TBR=vsevik@chromium.org
BUG=107420
Review URL: http://codereview.chromium.org/8949013

1:09 AM Changeset in webkit [102900] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, add fast/images/move-image-to-new-document.html in GTK
test_expectations.

platform/gtk/test_expectations.txt:

1:08 AM Changeset in webkit [102899] by vsevik@chromium.org

1 edit in branches/chromium/963/Source/WebCore/inspector/front-end/treeoutline.js

Merge 102757 - Web Inspector: TreeOutline's is broken when li elements have padding-left different from 14px.
https://bugs.webkit.org/show_bug.cgi?id=74445

Reviewed by Pavel Feldman.

inspector/front-end/treeoutline.js:

(TreeElement.prototype.isEventWithinDisclosureTriangle):

TBR=vsevik@chromium.org
BUG=107418
Review URL: http://codereview.chromium.org/8952012

12:52 AM Changeset in webkit [102898] by vsevik@chromium.org

4 edits
3 adds in trunk

Web Inspector: [Regression] Network manager fails to show resource type and MIME type in incorrect MIME type console message.
https://bugs.webkit.org/show_bug.cgi?id=74516

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/network/script-as-text-loading.html

inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage):

inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):

LayoutTests:

http/tests/inspector/network/resources/script-as-text.php: Added.
http/tests/inspector/network/script-as-text-loading-expected.txt: Added.
http/tests/inspector/network/script-as-text-loading.html: Added.

12:10 AM Changeset in webkit [102897] by Philippe Normand

3 edits
1 add in trunk/LayoutTests

Unreviewed, GTK rebaseline after r102149 and r102846.

platform/gtk/editing/pasteboard/paste-text-013-expected.txt:
platform/gtk/editing/pasteboard/paste-text-014-expected.txt:
platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.

Dec 14, 2011:

11:00 PM Changeset in webkit [102896] by tkent@chromium.org

5 edits
2 adds in trunk

A spin button changes the value incorrectly if it is clicked after touch events.
https://bugs.webkit.org/show_bug.cgi?id=71181

Reviewed by Ryosuke Niwa.

Source/WebCore:

SpinButtonElement assumed setHovered(true) was always called before a
mousemove event in the element. It is not true for touch events.

We should not reset m_upDownState to Indetermiante in setHovered(true),
and should reset it when the mouse pointer moves out.

This change fixes the flakiness of fast/forms/input-step-as-double.html.

Test: fast/events/touch/touch-before-pressing-spin-button.html

html/shadow/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::defaultEventHandler):
Add an assertion that m_upDownState should not be Indetermiante.
Reset m_upDownState to Indeterminate when the mouse pointer moves out
from the element.
(WebCore::SpinButtonElement::setHovered):
Reset m_upDownState to Indeterminate when the element becomes unhovered.

LayoutTests:

fast/events/touch/touch-before-pressing-spin-button-expected.txt: Added.
fast/events/touch/touch-before-pressing-spin-button.html: Added.
platform/chromium/test_expectations.txt: Remove the flakiness of fast/forms/input-step-as-double.html.
platform/qt/Skipped: ditto.

10:57 PM Changeset in webkit [102895] by Lucas Forschler

2 edits
1 add in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=74543
Add CSS*.cpp to a new CSSAllInOne.cpp file with two exceptions:

CSSProperty.cpp
CSSPrimitiveValue.cpp

Adding these two broke things with a templates problem that was not easily fixable.

Reviewed by Steve Falkenburg.

WebCore.vcproj/WebCore.vcproj:
css/CSSAllInOne.cpp: Added.

10:51 PM Changeset in webkit [102894] by levin@chromium.org

3 edits
2 adds in trunk

[chromium] DatabaseObserver needs threadsafe fixes and other clean-up.
https://bugs.webkit.org/show_bug.cgi?id=74558

Reviewed by Dmitry Titov.

Source/WebKit/chromium:

The important part of this fix is the removal of AllowCrossThreadAccess so
that ref counting happens appropriately.

Minor clean up throughout: Removed unnecessary WTF prefix in many
of these places and unnecessary String().

src/DatabaseObserver.cpp:

(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::signalCompleted): Get rid of
AllowCrossThreadAccess so that "this" get ref counted and remove mode from being
a member variable since a String in a ThreadSafeRefCounted class is bad.
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge): Ditto.
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask): Pass through mode
and minor code cleaning to do only one call to signalCompleted.
(WebKit::allowDatabaseForWorker): Just removed unnecessary String()'s.

LayoutTests:

Added a test which would fail without some of these fixes.

http/tests/workers/interrupt-database-sync-open-crash.html: Added.
http/tests/workers/resources/open-database-sync.js: Added.

(onmessage):

10:48 PM Changeset in webkit [102893] by timothy_horton@apple.com

3 edits in trunk/Source/WebCore

Generated images should respect the accelerated state of the context they're going to be drawn into
https://bugs.webkit.org/show_bug.cgi?id=74577
<rdar://problem/10584392>

Reviewed by Simon Fraser.

The tiled code path for GeneratorGeneratedImage and CrossfadeGeneratedImage blindly creates
an unaccelerated ImageBuffer. Instead, take into account the accelerated state of the destination context.

No new tests, as this is a simple performance improvement.

platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::drawPattern):

platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::drawPattern):

10:36 PM Changeset in webkit [102892] by gyuyoung.kim@samsung.com

3 edits in trunk/Source/WebKit/efl

[EFL] Change efl style variable name with WebKit style for internal functions.
https://bugs.webkit.org/show_bug.cgi?id=74474

Reviewed by Ryosuke Niwa.

In order to be more compliant with WebKit coding style, variable names of internal functions
should be changed with WebKit coding style.

ewk/ewk_private.h:
ewk/ewk_view.cpp:

(ewk_view_scroll):

10:34 PM Changeset in webkit [102891] by tony@chromium.org

4 edits in trunk

[chromium] Remove redundant third_party entries from chromium DEPS
https://bugs.webkit.org/show_bug.cgi?id=74472

Reviewed by Kenneth Russell.

Source/WebKit/chromium:

Removed redundant DEPS entries for third_party subdirectories
coming from chromium_svn, which were causing intermittent gclient
failures on the bots.

DEPS:

Tools:

Scripts/update-webkit-chromium: Temporarily keep unversioned trees.

10:32 PM Changeset in webkit [102890] by haraken@chromium.org

2 edits in trunk/Tools

[Refactoring] In prepare-ChangeLog, replace $isGit and $isSVN with
VCSUtils::isGit() and VCSUtils::isSVN().
https://bugs.webkit.org/show_bug.cgi?id=74485

Reviewed by David Kilzer.

We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
manner. This bug is one of the incremental refactorings to remove all top-level
code and global variables from prepare-ChangeLog. This patch replaces $isGit and $isSVN
with VCSUtils::isGit() and VCSUtils::isSVN(). This patch also removes firstDirectoryOrCwd(),
assuming that no user will mix Git/SVN checkouts and thus we can judge SVN or Git
just by looking at the current working directory.

Scripts/prepare-ChangeLog: Removed firstDirectoryOrCwd().

(diffFromToString):
(diffCommand):
(statusCommand):
(createPatchCommand):
(diffHeaderFormat):
(generateFileList):
(isAddedStatus):
(isConflictStatus):
(statusDescription):
(extractLineRange):

10:25 PM Changeset in webkit [102889] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: cleanup unused variable introduced at r102803

inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.prototype.enableResourceTracking):
(WebInspector.NetworkManager.prototype.disableResourceTracking):

10:14 PM Changeset in webkit [102888] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

fast path to accelerate processing in AudioBus::processWithGainFromMonoStereo
https://bugs.webkit.org/show_bug.cgi?id=74054

Patch by Wei James <james.wei@intel.com> on 2011-12-14
Reviewed by Kenneth Russell.

Avoid de-zippering when the gain has converged on the targetGain.
It can get about 75% performance gain at most when all frames don't need
de-zippering.

platform/audio/AudioBus.cpp:

(WebCore::AudioBus::processWithGainFromMonoStereo):

10:14 PM Changeset in webkit [102887] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Increase maximum number of gamepad buttons in Chromium port interface
https://bugs.webkit.org/show_bug.cgi?id=74559

Patch by Scott Graham <scottmg@chromium.org> on 2011-12-14
Reviewed by Darin Fisher.

public/platform/WebGamepad.h:

9:55 PM Changeset in webkit [102886] by tkent@chromium.org

7 edits
3 copies
7 adds
2 deletes in trunk/LayoutTests

[Chromium] Test expectatino update.

Rebaseline for basic-selects.html.
Move menulist-onchange-fired-with-key-up-down.html to the WONTFIX section.
Remove a duplicated entry.

platform/chromium-cg-mac-leopard/fast/forms/basic-selects-expected.png:
platform/chromium-cg-mac-leopard/fast/forms/basic-selects-expected.txt: Added.
platform/chromium-cg-mac-snowleopard/fast/forms/basic-selects-expected.png: Added.
platform/chromium-cg-mac-snowleopard/fast/forms/basic-selects-expected.txt: Added.
platform/chromium-cg-mac/fast/forms/basic-selects-expected.png: Removed.
platform/chromium-linux-x86/fast/forms/basic-selects-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/basic-selects-expected.txt.
platform/chromium-linux/fast/forms/basic-selects-expected.png:
platform/chromium-linux/fast/forms/basic-selects-expected.txt:
platform/chromium-mac-leopard/fast/forms/basic-selects-expected.png: Added.
platform/chromium-mac-leopard/fast/forms/basic-selects-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/forms/basic-selects-expected.png: Added.
platform/chromium-mac-snowleopard/fast/forms/basic-selects-expected.txt: Added.
platform/chromium-mac/fast/forms/basic-selects-expected.png: Removed.
platform/chromium-win-vista/fast/forms/basic-selects-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/basic-selects-expected.txt.
platform/chromium-win-xp/fast/forms/basic-selects-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/basic-selects-expected.txt.
platform/chromium-win/fast/forms/basic-selects-expected.png:
platform/chromium-win/fast/forms/basic-selects-expected.txt:
platform/chromium/test_expectations.txt:

9:48 PM Changeset in webkit [102885] by weinig@apple.com

2 edits in trunk/Source/JavaScriptCore

Revert unintentional change to JavaScriptCore.def

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

9:47 PM Changeset in webkit [102884] by tkent@chromium.org

2 edits in trunk/LayoutTests

[Mac] Skip menulist-popup-crash.html because of timeout.
https://bugs.webkit.org/show_bug.cgi?id=73304

platform/mac/Skipped:

9:40 PM Changeset in webkit [102883] by tkent@chromium.org

3 edits in trunk/Source/WebKit/wince

Opening two popup menus by dispatchEvent() makes problems.
https://bugs.webkit.org/show_bug.cgi?id=73304

Patch by Jing Zhao <jingzhao@chromium.org> on 2011-12-14
Reviewed by Ryosuke Niwa.

WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::hasOpenedPopup): Not implemented.

WebCoreSupport/ChromeClientWinCE.h: Overrides hasOpenedPopup().

9:26 PM Changeset in webkit [102882] by adamk@chromium.org

3 edits in trunk/Source/WebCore

Optimize MutationObserverInterestGroup construction
https://bugs.webkit.org/show_bug.cgi?id=74563

Reviewed by Ojan Vafai.

Inline MutationObserverInterestGroup's creation methods and fix an
accidental pass-by-value in an attempt to further reduce the CPU
footprint of MutationObservers.

No new tests, refactor only.

dom/WebKitMutationObserver.cpp:

(WebCore::MutationObserverInterestGroup::MutationObserverInterestGroup): Pass observers HashMap by reference.

dom/WebKitMutationObserver.h:

(WebCore::MutationObserverInterestGroup::createForChildListMutation): Inline.
(WebCore::MutationObserverInterestGroup::createForCharacterDataMutation): Inline.
(WebCore::MutationObserverInterestGroup::createForAttributesMutation): Inline.
(WebCore::MutationObserverInterestGroup::hasOldValue): Remove spurious inline keyword.

9:22 PM Changeset in webkit [102881] by bashi@chromium.org

4 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r102873.
http://trac.webkit.org/changeset/102873
https://bugs.webkit.org/show_bug.cgi?id=64434

Break the build

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-14

public/WebPlugin.h:
src/WebPluginContainerImpl.cpp:
src/WebPluginContainerImpl.h:

9:20 PM Changeset in webkit [102880] by morrita@google.com

2 edits in trunk/LayoutTests

Unreviewed test_expectations.txt update.

platform/chromium/test_expectations.txt:

9:08 PM Changeset in webkit [102879] by rniwa@webkit.org

2 edits in trunk/Source/WebKit/mac

Mac build fix after r102874.

WebCoreSupport/WebChromeClient.mm:

8:52 PM Changeset in webkit [102878] by morrita@google.com

1 edit
1 delete in trunk/LayoutTests

Unreviewed expectation update.

platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt: Removed.

8:40 PM Changeset in webkit [102877] by dmazzoni@google.com

8 edits
1 add
2 deletes in trunk

Seeing crash in DRT after loading-iframe-sends-notification.html land
https://bugs.webkit.org/show_bug.cgi?id=72624

Source/WebCore:

When an iframe finishes loading, send an accessibility notification
on the renderer, rather than on a parent node. The only reason it was
being posted on a parent before was because there was no way to detect
that in a test. This is simpler and now covered by the test.

Reviewed by Chris Fleizach.

Updates existing test:
accessibility/loading-iframe-sends-notification.html

dom/Document.cpp:

(WebCore::Document::implicitClose):

LayoutTests:

Rewrite test to use a global addNotificationListener, which makes it
more robust and cross-platform.

Reviewed by Chris Fleizach.

accessibility/loading-iframe-sends-notification-expected.txt: Added.
accessibility/loading-iframe-sends-notification.html:
platform/chromium/accessibility/loading-iframe-sends-notification-expected.txt: Removed.
platform/chromium/test_expectations.txt:
platform/gtk/Skipped:
platform/gtk/accessibility/loading-iframe-sends-notification-expected.txt: Removed.
platform/mac/Skipped:
platform/win/Skipped:

8:37 PM Changeset in webkit [102876] by nduca@chromium.org

14 edits in trunk/Source

[chromium] Add inhibitDraw to CCScheduler and drop root impl to prevent background flash on tab restore
https://bugs.webkit.org/show_bug.cgi?id=74351

Reviewed by James Robinson.

Source/WebCore:

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setNeedsCommit):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):

platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::getNextAction):
(WebCore::CCScheduler::processScheduledActions):

platform/graphics/chromium/cc/CCScheduler.h:
platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):

platform/graphics/chromium/cc/CCSchedulerStateMachine.h:

(WebCore::CCSchedulerStateMachine::setInhibitDraw):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setVisibleOnImplThread):
(WebCore::CCThreadProxy::inhibitDraw):

platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

tests/CCSchedulerStateMachineTest.cpp:

(WebCore::StateMachine::inhibitDraw):
(WebCore::TEST):

tests/CCSchedulerTest.cpp:

(WebKitTests::FakeCCSchedulerClient::setInhibitDraw):
(WebKitTests::FakeCCSchedulerClient::inhibitDraw):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::inhibitDraw):
(WebKitTests::SchedulerClientThatSetNeedsCommitInsideDraw::inhibitDraw):

8:19 PM Changeset in webkit [102875] by commit-queue@webkit.org

6 edits
2 adds in trunk

Crash due to incorrect parsing of isolates
https://bugs.webkit.org/show_bug.cgi?id=74311
When <bdi> content is wrapped, all hell breaks loose
https://bugs.webkit.org/show_bug.cgi?id=74396

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-12-14
Reviewed by Eric Seidel.

Source/WebCore:

When an isolate was encountered during run layout, the entire isolate
would be parsed, even if the run started in the middle of the isolate.
This would sometimes cause parts of the isolate to be added multiple
times as runs. This patch marks the starting position within the
isolate so nothing is parsed twice.

This patch changes appendRun() so that when a run is added that is
inside an isolate, it saves the start position of the run rather than
the root. This allows constructBidiRuns() to resume parsing the
isolate from the correct position.

The change to RenderBox partially reverts a previous change I had
done. It makes sense to screen for the condition, as was previously
the case.

This patch does not add the test case from 74396 because a separate
bug is preventing it from rendering correctly.

rendering/InlineIterator.h:

(WebCore::addPlaceholderRunForIsolatedInline)
(WebCore::IsolateTracker::addFakeRunIfNecessary)
(WebCore::InlineBidiResolver::appendRun)

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockLineLayout::constructBidiRuns)

rendering/RenderBox.cpp:

(WebCore::RenderBox::positionLineBox)

LayoutTests:

Layout test has multiple lines inside an isolate to ensure each run
is created only once.

The test that is in bug 74396 will have to be added once bug 74489 is
fixed.

LayoutTests/fast/text/international/multiline-and-object-inside-isolate-crash-expected.txt: Added
LayoutTests/fast/text/international/multiline-and-object-inside-isolate-crash.html: Added

8:16 PM Changeset in webkit [102874] by commit-queue@webkit.org

28 edits
2 adds in trunk

Opening two popup menus by dispatchEvent() makes problems.
https://bugs.webkit.org/show_bug.cgi?id=73304

Patch by Jing Zhao <jingzhao@chromium.org> on 2011-12-14
Reviewed by Kent Tamura.

Source/WebCore:

By using element.dispatchEvent(), a user written script can open two
popup menus, which causes various problems in different platforms.

Add a hasOpenedPopup() method in ChromeClient and a wrapper in Chrome.
In RenderMenuList::showPopup(), check if there is an opened popup menu
before opening a new popup menu.

Test: fast/forms/select-popup-crash.html

loader/EmptyClients.h: Overrides hasOpenedPopup().

(WebCore::EmptyChromeClient::hasOpenedPopup): Returns false as a default case.

page/Chrome.cpp:

(WebCore::Chrome::hasOpenedPopup): Calls ChromeClient::hasOpenedPopup().

page/Chrome.h: Declares hasOpenedPopup().
page/ChromeClient.h: Declares hasOpenedPopup() as a pure virtual function.
rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::showPopup): Calls Chrome::hasOpenedPopup() before opening a new popup menu.

Source/WebKit/chromium:

By using element.dispatchEvent(), a user written script can open two
popup menus, which causes the assertion in WebViewImpl::popupOpened()
fail.

ChromeClientImpl::hasOpenedPopup() is called by Chrome::hasOpenedPopup()
in RenderMenuList::showPopup(), to check if there is an opened popup
menu before opening a new popup menu.

src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::hasOpenedPopup): Checks the popup in WebViewImpl.

src/ChromeClientImpl.h: Overrides hasOpenedPopup().

Source/WebKit/efl:

WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::hasOpenedPopup): Not implemented.

WebCoreSupport/ChromeClientEfl.h: Overrides hasOpenedPopup().

Source/WebKit/gtk:

WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::hasOpenedPopup): Not implemented.

WebCoreSupport/ChromeClientGtk.h: Overrides hasOpenedPopup().

Source/WebKit/mac:

WebCoreSupport/WebChromeClient.h: Overrides hasOpenedPopup().
WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::hasOpenedPopup): Not implemented.

Source/WebKit/qt:

WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::hasOpenedPopup): Not implemented.

WebCoreSupport/ChromeClientQt.h: Overrides hasOpenedPopup().

Source/WebKit/win:

WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::hasOpenedPopup): Not implemented.

WebCoreSupport/WebChromeClient.h: Overrides hasOpenedPopup().

Source/WebKit2:

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::hasOpenedPopup): Not implemented.

WebProcess/WebCoreSupport/WebChromeClient.h: Overrides hasOpenedPopup().

LayoutTests:

fast/forms/select/menulist-popup-crash-expected.txt: Added.
fast/forms/select/menulist-popup-crash.html: Added.

7:39 PM Changeset in webkit [102873] by bashi@chromium.org

4 edits in trunk/Source/WebKit/chromium

[Chromium] Implement PluginViewBase::getFormValue
https://bugs.webkit.org/show_bug.cgi?id=64434

Adds getFormValue() to WebPluginContainerImpl as an implementation of PluginViewBase::getFormValue().

Reviewed by Darin Fisher.

No new tests. No behavior change at this time. We should add a test for PPAPI after chromium supports the feature.

public/WebPlugin.h: Added getFormValue().
src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::getFormValue): Added.

src/WebPluginContainerImpl.h: Added getFormValue().

7:24 PM Changeset in webkit [102872] by tony@chromium.org

2 edits in trunk/Source/WebCore

Clean up style in CSSStyleSelector.cpp
https://bugs.webkit.org/show_bug.cgi?id=74548

Reviewed by Ojan Vafai.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):

7:22 PM Changeset in webkit [102871] by kbr@google.com

4 edits in trunk/Source/WebCore

Unreviewed, rolling out r102794.
http://trac.webkit.org/changeset/102794
https://bugs.webkit.org/show_bug.cgi?id=74220

Reapplying patch since it is not the cause of the problems
described in bug 74220.

bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::reportUnsafeAccessTo):

bindings/v8/V8Proxy.h:
bindings/v8/custom/V8CustomXPathNSResolver.cpp:

(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):

6:30 PM Changeset in webkit [102870] by morrita@google.com

6 edits
1 copy
1 move
5 adds
2 deletes in trunk/LayoutTests

Unreviewed expectation update.

fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-cg-mac-leopard/media/video-poster-blocked-by-willsendrequest-expected.txt: Added.
platform/chromium-cg-mac-snowleopard/media/video-poster-blocked-by-willsendrequest-expected.txt: Added.
platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png:
platform/chromium-mac-leopard/media/video-poster-blocked-by-willsendrequest-expected.txt: Added.
platform/chromium-mac-snowleopard/media/video-poster-blocked-by-willsendrequest-expected.txt: Added.
platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt: Renamed from LayoutTests/platform/chromium/svg/css/getComputedStyle-basic-expected.txt.
platform/chromium-win-xp/media/video-poster-blocked-by-willsendrequest-expected.txt: Added.
platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.

6:28 PM Changeset in webkit [102869] by mrowe@apple.com

21 edits in trunk/Source

Build fix.

Clear the executable bit from header files. They don't need it.

6:20 PM Changeset in webkit [102868] by Lucas Forschler

12 edits
3 copies in tags/Safari-535.13.1/Source/WebKit2

Merged r102640.

6:14 PM Changeset in webkit [102867] by weinig@apple.com

89 edits in trunk/Source

Remove whitespace from InheritedPropertySheets attributes in
vsprops files to appease the Visual Studio project migrator.

Patch by Sam Weinig <weinig@apple.com> on 2011-12-14
Reviewed by Adam Roben.

Source/JavaScriptCore:

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreDebug.vsprops:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreDebugAll.vsprops:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreDebugCairoCFLite.vsprops:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebug.vsprops:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugAll.vsprops:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugCairoCFLite.vsprops:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedProduction.vsprops:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedRelease.vsprops:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedReleaseCairoCFLite.vsprops:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedReleasePGO.vsprops:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreProduction.vsprops:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreRelease.vsprops:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleaseCairoCFLite.vsprops:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGO.vsprops:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGOOptimize.vsprops:
JavaScriptCore.vcproj/WTF/WTFDebug.vsprops:
JavaScriptCore.vcproj/WTF/WTFDebugAll.vsprops:
JavaScriptCore.vcproj/WTF/WTFDebugCairoCFLite.vsprops:
JavaScriptCore.vcproj/WTF/WTFProduction.vsprops:
JavaScriptCore.vcproj/WTF/WTFRelease.vsprops:
JavaScriptCore.vcproj/WTF/WTFReleaseCairoCFLite.vsprops:
JavaScriptCore.vcproj/WTF/WTFReleasePGO.vsprops:
JavaScriptCore.vcproj/jsc/jscDebug.vsprops:
JavaScriptCore.vcproj/jsc/jscDebugAll.vsprops:
JavaScriptCore.vcproj/jsc/jscDebugCairoCFLite.vsprops:
JavaScriptCore.vcproj/jsc/jscProduction.vsprops:
JavaScriptCore.vcproj/jsc/jscRelease.vsprops:
JavaScriptCore.vcproj/jsc/jscReleaseCairoCFLite.vsprops:
JavaScriptCore.vcproj/jsc/jscReleasePGO.vsprops:
JavaScriptCore.vcproj/testRegExp/testRegExpDebug.vsprops:
JavaScriptCore.vcproj/testRegExp/testRegExpDebugAll.vsprops:
JavaScriptCore.vcproj/testRegExp/testRegExpDebugCairoCFLite.vsprops:
JavaScriptCore.vcproj/testRegExp/testRegExpProduction.vsprops:
JavaScriptCore.vcproj/testRegExp/testRegExpRelease.vsprops:
JavaScriptCore.vcproj/testRegExp/testRegExpReleaseCairoCFLite.vsprops:
JavaScriptCore.vcproj/testRegExp/testRegExpReleasePGO.vsprops:
JavaScriptCore.vcproj/testapi/testapiDebug.vsprops:
JavaScriptCore.vcproj/testapi/testapiDebugAll.vsprops:
JavaScriptCore.vcproj/testapi/testapiDebugCairoCFLite.vsprops:
JavaScriptCore.vcproj/testapi/testapiProduction.vsprops:
JavaScriptCore.vcproj/testapi/testapiRelease.vsprops:
JavaScriptCore.vcproj/testapi/testapiReleaseCairoCFLite.vsprops:

Source/WebCore:

WebCore.vcproj/QTMovieWinDebug.vsprops:
WebCore.vcproj/QTMovieWinDebugAll.vsprops:
WebCore.vcproj/QTMovieWinDebugCairoCFLite.vsprops:
WebCore.vcproj/QTMovieWinProduction.vsprops:
WebCore.vcproj/QTMovieWinRelease.vsprops:
WebCore.vcproj/QTMovieWinReleaseCairoCFLite.vsprops:
WebCore.vcproj/WebCoreDebug.vsprops:
WebCore.vcproj/WebCoreDebugAll.vsprops:
WebCore.vcproj/WebCoreDebugCairoCFLite.vsprops:
WebCore.vcproj/WebCoreProduction.vsprops:
WebCore.vcproj/WebCoreRelease.vsprops:
WebCore.vcproj/WebCoreReleaseCairoCFLite.vsprops:

Source/WebKit/win:

WebKit.vcproj/InterfacesDebug.vsprops:
WebKit.vcproj/InterfacesDebugAll.vsprops:
WebKit.vcproj/InterfacesDebugCairoCFLite.vsprops:
WebKit.vcproj/InterfacesProduction.vsprops:
WebKit.vcproj/InterfacesRelease.vsprops:
WebKit.vcproj/InterfacesReleaseCairoCFLite.vsprops:
WebKit.vcproj/WebKitGUIDDebug.vsprops:
WebKit.vcproj/WebKitGUIDDebugAll.vsprops:
WebKit.vcproj/WebKitGUIDDebugCairoCFLite.vsprops:
WebKit.vcproj/WebKitGUIDProduction.vsprops:
WebKit.vcproj/WebKitGUIDRelease.vsprops:
WebKit.vcproj/WebKitGUIDReleaseCairoCFLite.vsprops:
WebKit.vcproj/WebKitLibDebug.vsprops:
WebKit.vcproj/WebKitLibDebugAll.vsprops:
WebKit.vcproj/WebKitLibDebugCairoCFLite.vsprops:
WebKit.vcproj/WebKitLibProduction.vsprops:
WebKit.vcproj/WebKitLibRelease.vsprops:
WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops:

Source/WebKit2:

win/WebKit2Debug.vsprops:
win/WebKit2DebugAll.vsprops:
win/WebKit2DebugCairoCFLite.vsprops:
win/WebKit2Production.vsprops:
win/WebKit2Release.vsprops:
win/WebKit2ReleaseCairoCFLite.vsprops:
win/WebKit2WebProcessDebug.vsprops:
win/WebKit2WebProcessDebugAll.vsprops:
win/WebKit2WebProcessDebugCairoCFLite.vsprops:
win/WebKit2WebProcessProduction.vsprops:
win/WebKit2WebProcessRelease.vsprops:
win/WebKit2WebProcessReleaseCairoCFLite.vsprops:

6:10 PM Changeset in webkit [102866] by andersca@apple.com

8 edits in trunk/Source/WebKit2

Add WorkQueue::dispatch and RunLoop::dispatch which both take WTF::Function objects
https://bugs.webkit.org/show_bug.cgi?id=74574

Reviewed by Sam Weinig.

Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
(CoreIPC::Connection::addQueueClient):
(CoreIPC::Connection::removeQueueClient):
(CoreIPC::Connection::invalidate):
(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::postConnectionDidCloseOnConnectionWorkQueue):
(CoreIPC::Connection::connectionDidClose):
(CoreIPC::Connection::enqueueIncomingMessage):
Switch over to dispatch.

Platform/RunLoop.cpp:

(RunLoop::dispatch):
Create a FunctionWorkItem and call scheduleWork.

Platform/RunLoop.h:

Add dispatch.

Platform/WorkItem.h:

(FunctionWorkItem::FunctionWorkItem):
(FunctionWorkItem::execute):
(WorkItem::create):
Add a helper work item that wraps a WTF::Function.

Platform/WorkQueue.cpp:

(WorkQueue::dispatch):
Create a FunctionWorkItem and call scheduleWork.

Platform/WorkQueue.h:

Add dispatch.

UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::ProcessLauncher::ProcessLauncher):
Switch over to dispatch.

6:05 PM Changeset in webkit [102865] by Lucas Forschler

2 edits in tags/Safari-535.13.1/Source/WebKit/mac

Merged r102856.

6:04 PM Changeset in webkit [102864] by enrica@apple.com

2 edits in trunk/Source/WebCore

One more attempt to fix the release build (hopefully the last)

Unreviewed.

editing/ReplaceSelectionCommand.cpp: Added NodeRenderStyle.h

6:02 PM Changeset in webkit [102863] by commit-queue@webkit.org

2 edits in trunk/Source

[chromium] Fix CCLayerTreeHostTest shutdown race
https://bugs.webkit.org/show_bug.cgi?id=73926

This patch fixes a shutdown race condition in CCLayerTreeHostTest which
may happen if endTest() is called from within the drawLayersOnCCThread()
test hook. The sequence of events leading to the problem is:

CCThreadProxy::scheduledActionDrawAndSwap() is called when a frame begins.
CCThreadProxy calls drawLayersOnCCThread(), which in turn calls endTest().
Seeing it's not running in the main thread, endTest() posts a task calling itself in the main thread.
CCThreadProxy posts a task for calling didCommitAndDrawFrame() in the main thread.

The race is between the task posted in step #3 and the CC thread running
in scheduledActionDrawAndSwap(). If the endTask() task is scheduled
before the CC thread reaches step #4, it drains the pending message
queue (CCLayerTreeHostTest.cpp:369) before the task in step #4 is
posted.

The result is that the didCommitAndDrawFrame() task is executed after
the test fixture has been torn down, causing a read of unallocated
memory in CCScopedThreadProxy::runTaskIfNotShutdown (as m_targetThread
is no longer valid).

The fix is check m_shutdown before touching m_targetThread in
CCScopedThreadProxy. That is, events will still be queued after shutdown
but they will not be processed.

Patch by Sami Kyostila <skyostil@chromium.org> on 2011-12-14
Reviewed by James Robinson.

6:01 PM Changeset in webkit [102862] by weinig@apple.com

57 edits in trunk/Tools

Remove whitespace from InheritedPropertySheets attributes in
vsprops files to appease the Visual Studio project migrator.

Patch by Sam Weinig <weinig@apple.com> on 2011-12-14
Reviewed by Adam Roben.

DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops:
DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops:
DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops:
DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
DumpRenderTree/win/DumpRenderTreeDebug.vsprops:
DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops:
DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops:
DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
DumpRenderTree/win/ImageDiffDebug.vsprops:
DumpRenderTree/win/ImageDiffDebugAll.vsprops:
DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops:
DumpRenderTree/win/ImageDiffProduction.vsprops:
DumpRenderTree/win/ImageDiffRelease.vsprops:
DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
MiniBrowser/Configurations/MiniBrowserDebug.vsprops:
MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops:
MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops:
MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
WebKitLauncherWin/WebKitLauncherWinDebug.vsprops:
WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops:
WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops:
WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
WebKitTestRunner/win/InjectedBundleDebug.vsprops:
WebKitTestRunner/win/InjectedBundleDebugAll.vsprops:
WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops:
WebKitTestRunner/win/InjectedBundleProduction.vsprops:
WebKitTestRunner/win/InjectedBundleRelease.vsprops:
WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops:
WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops:
WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops:
WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
WinLauncher/WinLauncherDebug.vsprops:
WinLauncher/WinLauncherDebugAll.vsprops:
WinLauncher/WinLauncherDebugCairoCFLite.vsprops:
WinLauncher/WinLauncherProduction.vsprops:
WinLauncher/WinLauncherRelease.vsprops:
WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
record-memory-win/record-memory-winDebug.vsprops:
record-memory-win/record-memory-winDebugAll.vsprops:
record-memory-win/record-memory-winDebugCairoCFLite.vsprops:
record-memory-win/record-memory-winProduction.vsprops:
record-memory-win/record-memory-winRelease.vsprops:
record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:

5:59 PM Changeset in webkit [102861] by Lucas Forschler

3 edits in tags/Safari-535.13.1/Source/JavaScriptCore

Merged r102728.

5:57 PM Changeset in webkit [102860] by andersca@apple.com

2 edits in trunk/Tools

Windows build fix.

Move CHECKs out of the destructor.

TestWebKitAPI/Tests/WTF/Functional.cpp:

(TestWebKitAPI::B::~B):
(TestWebKitAPI::TEST):

5:51 PM Changeset in webkit [102859] by Lucas Forschler

6 edits in tags/Safari-535.13.1

Merged r102709.

5:38 PM Changeset in webkit [102858] by kbr@google.com

6 edits in trunk/Source/WebCore

Unreviewed, rolling out r102816.
http://trac.webkit.org/changeset/102816
https://bugs.webkit.org/show_bug.cgi?id=74415

Implicated in font-related crashes on Chromium canaries.

platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::Font::drawGlyphs):

platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::~FontPlatformData):

platform/graphics/chromium/FontPlatformDataChromiumWin.h:

(WebCore::FontPlatformData::size):
(WebCore::FontPlatformData::hash):

platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::setupPaintForFont):
(WebCore::paintSkiaText):

platform/graphics/skia/SkiaFontWin.h:

5:37 PM Changeset in webkit [102857] by andersca@apple.com

4 edits in trunk

binding a member function should ref/deref the object pointer if needed
https://bugs.webkit.org/show_bug.cgi?id=74552

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Add a HasRefAndDeref helper class template which checks if a given class type has ref and deref
member functions which the right type. Use this to determine if we should ref/deref the first parameter.

wtf/Functional.h:

(WTF::R):
(WTF::C::):
(WTF::RefAndDeref::ref):
(WTF::RefAndDeref::deref):

Tools:

Add new tests.

TestWebKitAPI/Tests/WTF/Functional.cpp:

(TestWebKitAPI::B::B):
(TestWebKitAPI::B::~B):
(TestWebKitAPI::B::ref):
(TestWebKitAPI::B::deref):
(TestWebKitAPI::B::f):
(TestWebKitAPI::B::g):
(TestWebKitAPI::TEST):

5:30 PM Changeset in webkit [102856] by msaboff@apple.com

2 edits in trunk/Source/WebKit/mac

5:30 PM Changeset in webkit [102855] by Simon Fraser

9 edits in trunk

Filter amounts should accept percentages
https://bugs.webkit.org/show_bug.cgi?id=74531

Source/WebCore:

Reviewed by Chris Marrin.

Support percentage arguments for some filter functions, using the FPercent flag
to validUnit(). Fix CSSStyleSelector::createFilterOperations() to do the divide by 100
for percentages.

Replaced isValidFilterArgument(), which just tested arguments one by one for validity, with
parseBuiltinFilterArguments() which tests and creates the CSSValues at the same time, which
is a little more efficient. It also allows filter-specific behavior to be more localized in this
method.

Covered by existing tests.

css/CSSParser.cpp:

(WebCore::CSSParser::parseBuiltinFilterArguments):
(WebCore::CSSParser::parseFilter):

css/CSSParser.h:
css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::createFilterOperations):

LayoutTests:

Reviewed by Chris Marrin.

Adjust test results now that percentages are allowed for some
filter arguments, and add testing of percentage arguments to filter-property-computed-style.js

css3/filters/filter-property-computed-style-expected.txt:
css3/filters/filter-property-parsing-invalid-expected.txt:
css3/filters/script-tests/filter-property-computed-style.js:
css3/filters/script-tests/filter-property-parsing-invalid.js:

5:24 PM Changeset in webkit [102854] by enrica@apple.com

2 edits in trunk/Source/WebCore

Build fix.

Unreviewed.

editing/ReplaceSelectionCommand.cpp: Added include RenderStyle.h

5:17 PM Changeset in webkit [102853] by enrica@apple.com

3 edits in trunk/LayoutTests

Updating test results after r102846

Unreviewed.

platform/chromium-win/editing/pasteboard/paste-text-013-expected.txt:
platform/chromium-win/editing/pasteboard/paste-text-014-expected.txt:

5:15 PM Changeset in webkit [102852] by Lucas Forschler

3 edits in tags/Safari-535.13.1/Source/WebCore

Merge 102691.

5:08 PM Changeset in webkit [102851] by Lucas Forschler

2 edits in branches/safari-534.53-branch/LayoutTests

Merged r97524.

5:07 PM Changeset in webkit [102850] by Lucas Forschler

4 edits
2 copies in branches/safari-534.53-branch

Merged r97502.

4:51 PM Changeset in webkit [102849] by commit-queue@webkit.org

28 edits
2 copies
7 adds in trunk

JS_INLINE and WTF_INLINE should be visible from WebCore
https://bugs.webkit.org/show_bug.cgi?id=73191

Source/JavaScriptCore:

Moved Export related macro definitions from config.h to ExportMacros.h and JSExportMacros.h.
Moved WTF_USE_JSC and WTF_USE_V8 from various config.h family to Platform.h.
Replaced JS_EXPORTDATA in wtf moudule with newly introduced WTF_EXPORTDATA.