⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 21, 2011:

11:46 PM Changeset in webkit [103499] by abarth@webkit.org
  • 3 edits
    54 adds
    1 delete in trunk/LayoutTests

Shard html5lib/runner.html into many separate tests
​https://bugs.webkit.org/show_bug.cgi?id=74968

Reviewed by Eric Seidel.

runner.html is something of an uber test that runs many, many sub
tests. It's slow and times out in some configurations. This patch
breaks it up into a number of different subtests, along the same lines
that the upstream html5lib test suite is sharded.

  • html5lib/resources/runner.js: Added.

(window.onload):
(run.xhr.onreadystatechange):
(run):
(test.else.overview.onclick):
(test):
(run_test.else.iframe.onload):
(run_test):
(process_result.get if):
(process_result):

  • html5lib/run-test1-expected.txt: Added.
  • html5lib/run-test1.html: Added.
  • html5lib/run-test10-expected.txt: Added.
  • html5lib/run-test10.html: Added.
  • html5lib/run-test11-expected.txt: Added.
  • html5lib/run-test11.html: Added.
  • html5lib/run-test12-expected.txt: Added.
  • html5lib/run-test12.html: Added.
  • html5lib/run-test14-expected.txt: Added.
  • html5lib/run-test14.html: Added.
  • html5lib/run-test15-expected.txt: Added.
  • html5lib/run-test15.html: Added.
  • html5lib/run-test16-expected.txt: Added.
  • html5lib/run-test16.html: Added.
  • html5lib/run-test17-expected.txt: Added.
  • html5lib/run-test17.html: Added.
  • html5lib/run-test18-expected.txt: Added.
  • html5lib/run-test18.html: Added.
  • html5lib/run-test19-expected.txt: Added.
  • html5lib/run-test19.html: Added.
  • html5lib/run-test2-expected.txt: Added.
  • html5lib/run-test2.html: Added.
  • html5lib/run-test20-expected.txt: Added.
  • html5lib/run-test20.html: Added.
  • html5lib/run-test21-expected.txt: Added.
  • html5lib/run-test21.html: Added.
  • html5lib/run-test22-expected.txt: Added.
  • html5lib/run-test22.html: Added.
  • html5lib/run-test23-expected.txt: Added.
  • html5lib/run-test23.html: Added.
  • html5lib/run-test24-expected.txt: Added.
  • html5lib/run-test24.html: Added.
  • html5lib/run-test25-expected.txt: Added.
  • html5lib/run-test25.html: Added.
  • html5lib/run-test26-expected.txt: Added.
  • html5lib/run-test26.html: Added.
  • html5lib/run-test3-expected.txt: Added.
  • html5lib/run-test3.html: Added.
  • html5lib/run-test4-expected.txt: Added.
  • html5lib/run-test4.html: Added.
  • html5lib/run-test5-expected.txt: Added.
  • html5lib/run-test5.html: Added.
  • html5lib/run-test6-expected.txt: Added.
  • html5lib/run-test6.html: Added.
  • html5lib/run-test7-expected.txt: Added.
  • html5lib/run-test7.html: Added.
  • html5lib/run-test8-expected.txt: Added.
  • html5lib/run-test8.html: Added.
  • html5lib/run-test9-expected.txt: Added.
  • html5lib/run-test9.html: Added.
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
  • platform/chromium/html5lib/runner-expected.txt: Removed.
11:41 PM Changeset in webkit [103498] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Make ~CSSParserSelector use Vector<OwnPtr>
​https://bugs.webkit.org/show_bug.cgi?id=73782

Reviewed by Alexey Proskuryakov.

  • css/CSSParserValues.cpp:

(WebCore::CSSParserSelector::~CSSParserSelector): Use Vector<OwnPtr>
so we don't have to call leakPtr or deleteAllValues.

11:17 PM Changeset in webkit [103497] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[Forms] Selection change by type-ahead doesn't fire 'change' event
​https://bugs.webkit.org/show_bug.cgi?id=74590

Patch by Yosifumi Inoue <​yosin@chromium.org> on 2011-12-21
Reviewed by Kent Tamura.

Source/WebCore:

This patch changes when onchange event fired in select element for:
1 Fire onchange event for type ahead selection.
2 Don't fire onchange event for Enter key. We've already fired onchange event for cursor key

and type ahead selection. So, onchange for Enter key is redundant. This behavior is
compatible to IE(9.0.8112.16421) and Opera(9.80) on Windows. FF(8.01) doesn't fire onchange
by cursor key selection change and type ahead. FF requires Enter key press to fire onchange
event.

Test: fast/forms/select/menulist-type-ahead-find.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Don't fire onchange event for Entry key.
(WebCore::HTMLSelectElement::typeAheadFind): Add DispatchChangeEvent when
calling selectOption method.

LayoutTests:

  • fast/events/onchange-select-popup-expected.txt: Change for onchange event by type ahead.
  • fast/forms/select/menulist-type-ahead-find-expected.txt: Added.
  • fast/forms/select/menulist-type-ahead-find.html: Added.
  • platform/chromium/test_expectations.txt: Enable fast/forms/{select-double-onchange,select-script-onchange}.html for Chrome/Linux.
11:00 PM Changeset in webkit [103496] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Plumbs refresh rate through WebLayerTreeView::Settings
​https://bugs.webkit.org/show_bug.cgi?id=74884

Patch by Peter Kotwicz <​pkotwicz@google.com> on 2011-12-21
Reviewed by James Robinson.

  • public/platform/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

10:20 PM Changeset in webkit [103495] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[Chromium] Layout Test media/media-element-play-after-eos.html is flaky
De-flakify the test by adding listeners before playback starts, so that
events are guaranteed to be received (as opposed to playback finishing
before listeners are even registered on overloaded machines).
​https://bugs.webkit.org/show_bug.cgi?id=71543

Patch by Ami Fischman <​fischman@chromium.org> on 2011-12-21
Reviewed by Eric Seidel.

  • media/media-element-play-after-eos.html:
  • platform/chromium/test_expectations.txt:
9:39 PM Changeset in webkit [103494] by Darin Adler
  • 4 edits in trunk/Source/WebCore

Tweak and comment some transform-related code
​https://bugs.webkit.org/show_bug.cgi?id=68670

Reviewed by Daniel Bates.

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint): Added a FIXME about additional overhead paid here
when the scale factor is 2x.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBoxShadow): Added a FIXME about this check possibly
being wrong, and also changed the local vairable name so the check need not stretch over
multiple lines.

9:22 PM Changeset in webkit [103493] by mitz@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

OS X build fix after r103488.

9:12 PM Changeset in webkit [103492] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebKit2

[EFL][WK2] Add efl port's ewk_view files
​https://bugs.webkit.org/show_bug.cgi?id=61915

Patch by Eunmi Lee <​eunmi15.lee@samsung.com> on 2011-12-21
Reviewed by Eric Seidel.

This is the initial version of WebKit2 EFL port's ewk_view.
The ewk_view is Evas_Object to show the rendered web contents.

  • UIProcess/API/efl/ewk_view.cpp: Added.

(_ewk_view_smart_changed):
(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_on_focus_in):
(_ewk_view_on_focus_out):
(_ewk_view_on_mouse_wheel):
(_ewk_view_on_mouse_down):
(_ewk_view_on_mouse_up):
(_ewk_view_on_mouse_move):
(_ewk_view_on_key_down):
(_ewk_view_on_key_up):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(_ewk_view_smart_add):
(_ewk_view_smart_del):
(_ewk_view_smart_resize):
(_ewk_view_smart_move):
(_ewk_view_smart_calculate):
(_ewk_view_smart_show):
(_ewk_view_smart_hide):
(ewk_view_smart_class_init):
(_ewk_view_smart_class_new):
(ewk_view_add):
(ewk_view_page_get):

  • UIProcess/API/efl/ewk_view.h: Added.
8:57 PM Changeset in webkit [103491] by tkent@chromium.org
  • 6 edits in trunk/Source/WebCore

Change the item type of Document::m_formElementsWithState from Element*
to HTMLFormControlElementWithState*.
​https://bugs.webkit.org/show_bug.cgi?id=74998

Reviewed by Andreas Kling.

No new tests. Just refactoring.

  • dom/Document.cpp:

(WebCore::Document::formElementsState): Use HTMLFormControlElementWithState*.

  • dom/Document.h:

(WebCore::Document::registerFormElementWithState): Change the argument type.
(WebCore::Document::unregisterFormElementWithState): ditto.
(WebCore::Document::formElements): Renamed from getFormElements().

  • dom/Element.h:

Removed shouldSaveAndRestoreFormControlState(), saveFormControlState(),
and restoreFormControlState() because they are not called for Element
anymore.

  • html/HTMLFormControlElement.h:
  • Make formControlName() and formControlType() public. They are called from Document class.
  • Make shouldSaveAndRestoreFormControlState() public, and non-virtual. This is called from Document class, and no other classes override this.

(WebCore::HTMLFormControlElementWithState::saveFormControlState):
Moved from Element.
(WebCore::HTMLFormControlElementWithState::restoreFormControlState): ditto.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateCheckedRadioButtons):
Use HTMLFormControlElementWithState* instead of Element*.

8:56 PM Changeset in webkit [103490] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Always use border texels on platforms using pageScaleDelta
​https://bugs.webkit.org/show_bug.cgi?id=74226

Patch by Alexandre Elias <​aelias@google.com> on 2011-12-21
Reviewed by James Robinson.

On platforms where the root layer can be zoomed in at draw time
(pageScaleDelta), we want to turn on border texels in order for
scaling to use GL_LINEAR instead of GL_NEAREST.

No new tests. (Flag flip.)

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdate):

8:41 PM Changeset in webkit [103489] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[chromium] Scale audio, video tags in MediaDocument to fit in window.
​https://bugs.webkit.org/show_bug.cgi?id=73948

Source/WebCore:

Add CSS max-height: 100%, max-width: 100% settings to the audio and
video tags when in MediaDocuments.

Patch by Dale Curtis <​dalecurtis@chromium.org> on 2011-12-21
Reviewed by Eric Seidel.

Test: media/video-scales-in-media-document.html

  • css/mediaControlsChromium.css:

(audio:-webkit-full-page-media, video:-webkit-full-page-media):

LayoutTests:

Added new layout test to verify audio, video tags scale to fit
undersized containers.

Patch by Dale Curtis <​dalecurtis@chromium.org> on 2011-12-21
Reviewed by Eric Seidel.

  • media/video-scales-in-media-document-expected.txt: Added.
  • media/video-scales-in-media-document.html: Added.
8:39 PM Changeset in webkit [103488] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source

Implement the JavaScriptCore bindings for eventListenerHandlerLocation
​https://bugs.webkit.org/show_bug.cgi?id=74313

Patch by Konrad Piascik <​kpiascik@rim.com> on 2011-12-21
Reviewed by Eric Seidel.

Source/JavaScriptCore:

Updated project files to get Windows and Mac builds working.

Source/WebCore:

Implemented the JavaScriptCore binding to allow Web Inspector to
show the function name and line number for an event listener in
the Elements panel.

Tested by opening up a page which has a registered event listener in Safari
and checking if the Elements panel script name and line number are present
and clickable.

  • ForwardingHeaders/runtime/Executable.h: Added.
  • ForwardingHeaders/wtf/SegmentedVector.h: Added.
  • bindings/js/ScriptEventListener.cpp:

(WebCore::eventListenerHandlerLocation):

6:50 PM Changeset in webkit [103487] by leo.yang@torchmobile.com.cn
  • 5 edits in trunk/Source/WebCore

Upstream the Multipart feature in Blackberry port
​https://bugs.webkit.org/show_bug.cgi?id=73533

Patch by Chris Guan <​chris.guan@torchmobile.com.cn> on 2011-12-21
Reviewed by Rob Buis.

I refactored Multipart code of Blackberry port. Moved Multipart into
Blackerry network layer and removed the dependence of std::string.

Initial upstream, no new test cases.

  • platform/network/blackberry/DeferredData.cpp:

(WebCore::DeferredData::deferMultipartHeaderReceived):
(WebCore::DeferredData::processHeaders):
(WebCore::DeferredData::processDeferredData):

  • platform/network/blackberry/DeferredData.h:

(WebCore::DeferredData::hasDeferredData):

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::notifyMultipartHeaderReceived):
(WebCore::NetworkJob::handleNotifyMultipartHeaderReceived):
(WebCore::NetworkJob::handleNotifyDataReceived):
(WebCore::NetworkJob::handleNotifyClose):
(WebCore::NetworkJob::startNewJobWithRequest):
(WebCore::NetworkJob::sendResponseIfNeeded):
(WebCore::NetworkJob::sendMultipartResponseIfNeeded):

  • platform/network/blackberry/NetworkJob.h:
6:45 PM Changeset in webkit [103486] by eric.carlson@apple.com
  • 6 edits in trunk

Fix text track cue font size and colors
​https://bugs.webkit.org/show_bug.cgi?id=75051

Reviewed by Darin Adler.

Source/WebCore:

No new tests, updated media/track/track-cue-rendering.html for the changes.

  • css/mediaControls.css:

(video::-webkit-media-text-track-container): Match WebVTT spec.
(video::-webkit-media-text-track-display): Ditto.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateSizes): Change font size from 4% of the

video height to 5% as per the spec. Don't enforce a minimum size.

LayoutTests:

  • media/track/track-cue-rendering-expected.txt:
  • media/track/track-cue-rendering.html:
6:36 PM Changeset in webkit [103485] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, updating expectations file for fast/js/global-constructors.

  • platform/mac/fast/js/global-constructors-expected.txt:
6:34 PM Changeset in webkit [103484] by Lucas Forschler
  • 1 copy in tags/Safari-534.54.1

New tag.

6:33 PM Changeset in webkit [103483] by Lucas Forschler
  • 1 delete in tags/Safari-534.54.1

Remove incorrect tag

6:23 PM Changeset in webkit [103482] by fpizlo@apple.com
  • 6 edits
    3 adds in trunk

Source/JavaScriptCore: DFG ConvertThis optimizations do not honor the distinction between the global object and the global this object
​https://bugs.webkit.org/show_bug.cgi?id=75058
<rdar://problem/10616612>
<rdar://problem/10617500>

Reviewed by Oliver Hunt.

Added a call to toThisObject() in the DFG when planting a direct reference to the global this object.
Instead of adding a separate toThisObject() method on JSCell which does not take ExecState*, I reascribed
a new contract: if you're calling toThisObject() on JSObject or one of its subtypes, then the ExecState*
is optional.

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::globalThisObjectFor):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/JSObject.h:

LayoutTests: DFG ConvertThis optimizations do not honor the distinction between the global object and the global this object
​https://bugs.webkit.org/show_bug.cgi?id=75058
<rdar://problem/10616612>

Reviewed by Oliver Hunt.

  • fast/js/dfg-convert-this-dom-window-expected.txt: Added.
  • fast/js/dfg-convert-this-dom-window.html: Added.
  • fast/js/script-tests/dfg-convert-this-dom-window.js: Added.

(myObject.call):
(myFunction):
(myFunctionWithCall):
(myFunctionWithCall.call):

6:22 PM Changeset in webkit [103481] by Lucas Forschler
  • 1 copy in tags/Safari-534.54.1/safari-534.54-branch

New tag.

6:21 PM Changeset in webkit [103480] by Lucas Forschler
  • 1 copy in tags/Safari-534.54.1

New tag.

5:42 PM Changeset in webkit [103479] by jberlin@webkit.org
  • 3 edits in trunk/Source/WebKit/win

Expose to Windows the way to allow a scheme access to Local Storage and Databases while
Private Browsing is enabled.
​https://bugs.webkit.org/show_bug.cgi?id=75056

Reviewed by Sam Weinig.

Add the Windows WebKit API that corresponds to the Mac one added in r99439.

  • WebView.cpp:

(WebView::registerURLSchemeAsSecure):
(WebView::registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing):
(WebView::registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing):

  • WebView.h:
5:36 PM Changeset in webkit [103478] by kling@webkit.org
  • 16 edits in trunk/Source/WebCore

Unreviewed, rolling out r103473.
​http://trac.webkit.org/changeset/103473
​https://bugs.webkit.org/show_bug.cgi?id=74991

Overestimated my superpowers a bit here.

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):
(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):

  • dom/Element.h:

(WebCore::Element::updateId):
(WebCore::Element::willModifyAttribute):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setAttributes):

  • dom/Node.h:
  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::parseMappedAttribute):
(WebCore::HTMLAppletElement::insertedIntoDocument):
(WebCore::HTMLAppletElement::removedFromDocument):

  • html/HTMLAppletElement.h:
  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::parseMappedAttribute):
(WebCore::HTMLEmbedElement::insertedIntoDocument):
(WebCore::HTMLEmbedElement::removedFromDocument):

  • html/HTMLEmbedElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::insertedIntoDocument):
(WebCore::HTMLFormElement::removedFromDocument):
(WebCore::HTMLFormElement::parseMappedAttribute):

  • html/HTMLFormElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseMappedAttribute):
(WebCore::HTMLImageElement::insertedIntoDocument):
(WebCore::HTMLImageElement::removedFromDocument):

  • html/HTMLImageElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute):
(WebCore::HTMLObjectElement::insertedIntoDocument):
(WebCore::HTMLObjectElement::removedFromDocument):
(WebCore::HTMLObjectElement::updateDocNamedItem):
(WebCore::HTMLObjectElement::formControlName):

  • html/HTMLObjectElement.h:
  • html/HTMLPlugInElement.h:
5:29 PM Changeset in webkit [103477] by commit-queue@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

Video format yuv422p doesn't show properly.
​https://bugs.webkit.org/show_bug.cgi?id=69113

Patch by Shadi Khalek <​shadi@chromium.org> on 2011-12-21
Reviewed by Eric Seidel.

  • media/video-colorspace-yuv420.html: Added.
  • media/video-colorspace-yuv422.html: Added.
5:12 PM Changeset in webkit [103476] by Simon Fraser
  • 5 edits
    6 adds in trunk

Source/WebCore: Clean up RenderLayer code that applies filters and transforms
​https://bugs.webkit.org/show_bug.cgi?id=75032

This also fixes:

Nested filters not working as expected
​https://bugs.webkit.org/show_bug.cgi?id=75029

Filter region is computed incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=74889

Reviewed by James Robinson.

RenderLayer::paintLayer() had this confusing behavior where,
for transforms, it would change the CTM and then re-enter
the method with a bit set. This was partially, but incorrectly
copied for filters, so things like nested filters didn't work,
and the case of a filter + transform was confused.

Clean up by making RenderLayer::paintLayer() be a fairly simple
method that handles the re-entering with bit set, for both
transforms and filters. The bulk of the code in RenderLayer::paintLayer()
is now in RenderLayer::paintLayerContents(). There is no
behavior change for transforms.

There are two fixes for filters. First, instead of just using
the layer size to compute the bounds of the filtered region,
use transparencyClipBox() which already takes descendents, box
decorations etc into account (it's what we use for opacity).
Some cleanup of the coordinate math, and separation from transforms
code was also achieved.

Second, make sure we toggle off the PaintLayerAppliedFilters bit
(which was renamed for clarity) for sublayers, so that sublayers
paint their filters correctly.

Tests: css3/filters/filter-region.html

css3/filters/nested-filters.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::updateFilterBackingStore):

  • rendering/RenderLayer.h:

LayoutTests: Clean up RenderLayer code that applies filters and transforms
​https://bugs.webkit.org/show_bug.cgi?id=75032

Reviewed by James Robinson.

New tests for nested filters, and filtering an element
whose content is larger than its layer size.

  • css3/filters/filter-region-expected.png: Added.
  • css3/filters/filter-region-expected.txt: Added.
  • css3/filters/filter-region.html: Added.
  • css3/filters/nested-filter-expected.png:
  • css3/filters/nested-filters-expected.png: Added.
  • css3/filters/nested-filters-expected.txt: Added.
  • css3/filters/nested-filters.html: Added.
5:08 PM Changeset in webkit [103475] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] fast/html/font-weight-bold-for-b-and-strong.html needs baselines
​https://bugs.webkit.org/show_bug.cgi?id=75055

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
4:37 PM Changeset in webkit [103474] by commit-queue@webkit.org
  • 9 edits
    3 adds in trunk

Discard event data not followed by an empty line before eof when parsing an event-stream
​https://bugs.webkit.org/show_bug.cgi?id=68833

Patch by Per-Erik Brodin <​per-erik.brodin@ericsson.com> on 2011-12-21
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/eventsource/eventsource-eof.html

  • page/EventSource.cpp:

(WebCore::EventSource::didFinishLoading):
(WebCore::EventSource::parseEventStreamLine):

  • page/EventSource.h:

LayoutTests:

  • http/tests/eventsource/eventsource-eof-expected.txt: Added.
  • http/tests/eventsource/eventsource-eof.html: Added.
  • http/tests/eventsource/eventsource-reconnect-expected.txt: Updated.
  • http/tests/eventsource/eventsource-reconnect.html: Added lastEventId check.
  • http/tests/eventsource/resources/es-eof.php: Added.
  • http/tests/eventsource/resources/reconnect.php: Added data to be discarded.
  • http/tests/eventsource/resources/response-content-type-charset.php: Added empty line before eof.
  • http/tests/eventsource/resources/simple-event-stream.asis: Added empty line before eof.
4:25 PM Changeset in webkit [103473] by kling@webkit.org
  • 16 edits in trunk/Source/WebCore

Automate elements' registration as document namedItem/extraNamedItem.
<​http://webkit.org/b/74991>

Reviewed by Antti Koivisto.

Remove caching of the "id" and "name" attributes on applet, embed, form,
image and object elements. We were caching them to keep the document's
map of named and "extra named" (named by id) item counts in sync.

Instead, add a hook to Element::willModifyAttribute() that detects when
the attributes are being changed and handle the registration/unregistration
automatically if the element returns true for shouldRegisterAsNamedItem()
or shouldRegisterAsExtraNamedItem() respectively.

This shrinks the elements by two AtomicStrings (8 or 16 bytes) each.

IFrame elements retain the old mechanism for now, as there are some subtle
differences to how that's handled.

  • dom/Node.h:

(WebCore::Node::hasName):
(WebCore::Node::setHasName):

Cache whether we have a "name" attribute or not (1 bit on Node.)
This is done in order to minimize the overhead added to Element's
insertedIntoDocument() and removeFromDocument().

  • dom/Element.cpp:

(WebCore::Element::updateNamedItemRegistration):
(WebCore::Element::updateExtraNamedItemRegistration):

Added. Called when the "name" and "id" attributes are changed.
Updates the document's named item maps accordingly.

(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):

Make sure updateName() is called in addition to updateId() when applicable.

(WebCore::Element::attributeChanged):

Update the Node's has-name flag as appropriate.

  • dom/Element.h:

(WebCore::Element::shouldRegisterAsNamedItem):
(WebCore::Element::shouldRegisterAsExtraNamedItem):

Added. If an element returns true for these, it will be automatically
registered with the document when the name/id attribute changes.

(WebCore::Element::updateId):
(WebCore::Element::updateName):

Register/unregister from the document's named item maps as appropriate.

(WebCore::Element::willModifyAttribute):

Add updateName() hook in addition to the existing updateId() hook.

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setAttributes):

Make sure updateName() is called when we're cloning the attributes
from another element.

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::parseMappedAttribute):

  • html/HTMLAppletElement.h:
  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::parseMappedAttribute):
(WebCore::HTMLEmbedElement::insertedIntoDocument):

  • html/HTMLEmbedElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::insertedIntoDocument):
(WebCore::HTMLFormElement::removedFromDocument):
(WebCore::HTMLFormElement::parseMappedAttribute):

  • html/HTMLFormElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseMappedAttribute):
(WebCore::HTMLImageElement::insertedIntoDocument):

  • html/HTMLImageElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute):
(WebCore::HTMLObjectElement::insertedIntoDocument):
(WebCore::HTMLObjectElement::removedFromDocument):

  • html/HTMLObjectElement.h:
  • html/HTMLPlugInElement.h:

Remove duplicated code that is now handled by Element.

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem):
(WebCore::HTMLObjectElement::formControlName):

Use fastGetAttribute() since we no longer cache the name.

4:25 PM Changeset in webkit [103472] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Patch by Scott Franklin <​scottfr@google.com> on 2011-12-21
Reviewed by Eric Carlson.

Update LayoutTests/media/broken-video to test for correct error codes
​https://bugs.webkit.org/show_bug.cgi?id=61573

  • media/broken-video-expected.txt:
  • media/broken-video.html:
4:23 PM Changeset in webkit [103471] by eric@webkit.org
  • 2 edits in trunk/Tools

Add ​webkit.review.bot@gmail.com and ​commit-queue@webkit.org as "contributors"
so that they appear in the bugzilla autocomplete CC list.
I also removed the "radar" irc nick (which I believe does not exist)
and removed the uneeded [] around the radar bugzilla email.

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
4:10 PM Changeset in webkit [103470] by commit-queue@webkit.org
  • 1 edit
    286 adds in trunk/LayoutTests

Patch by Mark Pilgrim <​pilgrim@chromium.org> on 2011-12-21
Reviewed by Eric Seidel.

Port W3C audio and video tests
​https://bugs.webkit.org/show_bug.cgi?id=61541

  • media/W3C: Added.
  • media/W3C/audio: Added.
  • media/W3C/audio/canPlayType: Added.
  • media/W3C/audio/canPlayType/canPlayType_application_octet_stream-expected.txt: Added.
  • media/W3C/audio/canPlayType/canPlayType_application_octet_stream.html: Added.
  • media/W3C/audio/canPlayType/canPlayType_application_octet_stream_with_codecs_1-expected.txt: Added.
  • media/W3C/audio/canPlayType/canPlayType_application_octet_stream_with_codecs_1.html: Added.
  • media/W3C/audio/canPlayType/canPlayType_application_octet_stream_with_codecs_2-expected.txt: Added.
  • media/W3C/audio/canPlayType/canPlayType_application_octet_stream_with_codecs_2.html: Added.
  • media/W3C/audio/canPlayType/canPlayType_bogus_type-expected.txt: Added.
  • media/W3C/audio/canPlayType/canPlayType_bogus_type.html: Added.
  • media/W3C/audio/canPlayType/canPlayType_method_exists-expected.txt: Added.
  • media/W3C/audio/canPlayType/canPlayType_method_exists.html: Added.
  • media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
  • media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_1.html: Added.
  • media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
  • media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2.html: Added.
  • media/W3C/audio/currentSrc: Added.
  • media/W3C/audio/currentSrc/currentSrc_empty_if_no_src-expected.txt: Added.
  • media/W3C/audio/currentSrc/currentSrc_empty_if_no_src.html: Added.
  • media/W3C/audio/currentSrc/currentSrc_nonempty_after_adding_source_child-expected.txt: Added.
  • media/W3C/audio/currentSrc/currentSrc_nonempty_after_adding_source_child.html: Added.
  • media/W3C/audio/currentSrc/currentSrc_nonempty_after_setting_src-expected.txt: Added.
  • media/W3C/audio/currentSrc/currentSrc_nonempty_after_setting_src.html: Added.
  • media/W3C/audio/currentSrc/currentSrc_property_exists-expected.txt: Added.
  • media/W3C/audio/currentSrc/currentSrc_property_exists.html: Added.
  • media/W3C/audio/error: Added.
  • media/W3C/audio/error/error_null-expected.txt: Added.
  • media/W3C/audio/error/error_null.html: Added.
  • media/W3C/audio/error/error_onerror_called_on_bogus_source-expected.txt: Added.
  • media/W3C/audio/error/error_onerror_called_on_bogus_source.html: Added.
  • media/W3C/audio/error/error_property_exists-expected.txt: Added.
  • media/W3C/audio/error/error_property_exists.html: Added.
  • media/W3C/audio/events: Added.
  • media/W3C/audio/events/event_canplay-expected.txt: Added.
  • media/W3C/audio/events/event_canplay.html: Added.
  • media/W3C/audio/events/event_canplay_manual-expected.txt: Added.
  • media/W3C/audio/events/event_canplay_manual.html: Added.
  • media/W3C/audio/events/event_canplaythrough-expected.txt: Added.
  • media/W3C/audio/events/event_canplaythrough.html: Added.
  • media/W3C/audio/events/event_canplaythrough_manual-expected.txt: Added.
  • media/W3C/audio/events/event_canplaythrough_manual.html: Added.
  • media/W3C/audio/events/event_loadeddata-expected.txt: Added.
  • media/W3C/audio/events/event_loadeddata.html: Added.
  • media/W3C/audio/events/event_loadeddata_manual-expected.txt: Added.
  • media/W3C/audio/events/event_loadeddata_manual.html: Added.
  • media/W3C/audio/events/event_loadedmetadata-expected.txt: Added.
  • media/W3C/audio/events/event_loadedmetadata.html: Added.
  • media/W3C/audio/events/event_loadedmetadata_manual-expected.txt: Added.
  • media/W3C/audio/events/event_loadedmetadata_manual.html: Added.
  • media/W3C/audio/events/event_loadstart-expected.txt: Added.
  • media/W3C/audio/events/event_loadstart.html: Added.
  • media/W3C/audio/events/event_loadstart_manual-expected.txt: Added.
  • media/W3C/audio/events/event_loadstart_manual.html: Added.
  • media/W3C/audio/events/event_order_canplay_canplaythrough-expected.txt: Added.
  • media/W3C/audio/events/event_order_canplay_canplaythrough.html: Added.
  • media/W3C/audio/events/event_order_canplay_playing-expected.txt: Added.
  • media/W3C/audio/events/event_order_canplay_playing.html: Added.
  • media/W3C/audio/events/event_order_loadedmetadata_loadeddata-expected.txt: Added.
  • media/W3C/audio/events/event_order_loadedmetadata_loadeddata.html: Added.
  • media/W3C/audio/events/event_order_loadstart_progress-expected.txt: Added.
  • media/W3C/audio/events/event_order_loadstart_progress.html: Added.
  • media/W3C/audio/events/event_pause_manual-expected.txt: Added.
  • media/W3C/audio/events/event_pause_manual.html: Added.
  • media/W3C/audio/events/event_play-expected.txt: Added.
  • media/W3C/audio/events/event_play.html: Added.
  • media/W3C/audio/events/event_play_manual-expected.txt: Added.
  • media/W3C/audio/events/event_play_manual.html: Added.
  • media/W3C/audio/events/event_playing-expected.txt: Added.
  • media/W3C/audio/events/event_playing.html: Added.
  • media/W3C/audio/events/event_playing_manual-expected.txt: Added.
  • media/W3C/audio/events/event_playing_manual.html: Added.
  • media/W3C/audio/events/event_progress-expected.txt: Added.
  • media/W3C/audio/events/event_progress.html: Added.
  • media/W3C/audio/events/event_progress_manual-expected.txt: Added.
  • media/W3C/audio/events/event_progress_manual.html: Added.
  • media/W3C/audio/events/event_timeupdate-expected.txt: Added.
  • media/W3C/audio/events/event_timeupdate.html: Added.
  • media/W3C/audio/events/event_timeupdate_manual-expected.txt: Added.
  • media/W3C/audio/events/event_timeupdate_manual.html: Added.
  • media/W3C/audio/networkState: Added.
  • media/W3C/audio/networkState/networkState_during_loadstart-expected.txt: Added.
  • media/W3C/audio/networkState/networkState_during_loadstart.html: Added.
  • media/W3C/audio/networkState/networkState_initial-expected.txt: Added.
  • media/W3C/audio/networkState/networkState_initial.html: Added.
  • media/W3C/audio/networkState/networkState_property_exists-expected.txt: Added.
  • media/W3C/audio/networkState/networkState_property_exists.html: Added.
  • media/W3C/audio/paused: Added.
  • media/W3C/audio/paused/paused_false_during_play-expected.txt: Added.
  • media/W3C/audio/paused/paused_false_during_play.html: Added.
  • media/W3C/audio/paused/paused_true_during_pause-expected.txt: Added.
  • media/W3C/audio/paused/paused_true_during_pause.html: Added.
  • media/W3C/audio/preload: Added.
  • media/W3C/audio/preload/preload_property_exists-expected.txt: Added.
  • media/W3C/audio/preload/preload_property_exists.html: Added.
  • media/W3C/audio/preload/preload_reflects_auto_value-expected.txt: Added.
  • media/W3C/audio/preload/preload_reflects_auto_value.html: Added.
  • media/W3C/audio/preload/preload_reflects_bogus_value-expected.txt: Added.
  • media/W3C/audio/preload/preload_reflects_bogus_value.html: Added.
  • media/W3C/audio/preload/preload_reflects_empty-expected.txt: Added.
  • media/W3C/audio/preload/preload_reflects_empty.html: Added.
  • media/W3C/audio/preload/preload_reflects_metadata-expected.txt: Added.
  • media/W3C/audio/preload/preload_reflects_metadata.html: Added.
  • media/W3C/audio/preload/preload_reflects_no_value-expected.txt: Added.
  • media/W3C/audio/preload/preload_reflects_no_value.html: Added.
  • media/W3C/audio/preload/preload_reflects_none-expected.txt: Added.
  • media/W3C/audio/preload/preload_reflects_none.html: Added.
  • media/W3C/audio/preload/preload_reflects_none_autoplay-expected.txt: Added.
  • media/W3C/audio/preload/preload_reflects_none_autoplay.html: Added.
  • media/W3C/audio/readyState: Added.
  • media/W3C/audio/readyState/readyState_during_canplay-expected.txt: Added.
  • media/W3C/audio/readyState/readyState_during_canplay.html: Added.
  • media/W3C/audio/readyState/readyState_during_canplaythrough-expected.txt: Added.
  • media/W3C/audio/readyState/readyState_during_canplaythrough.html: Added.
  • media/W3C/audio/readyState/readyState_during_loadeddata-expected.txt: Added.
  • media/W3C/audio/readyState/readyState_during_loadeddata.html: Added.
  • media/W3C/audio/readyState/readyState_during_loadedmetadata-expected.txt: Added.
  • media/W3C/audio/readyState/readyState_during_loadedmetadata.html: Added.
  • media/W3C/audio/readyState/readyState_during_playing-expected.txt: Added.
  • media/W3C/audio/readyState/readyState_during_playing.html: Added.
  • media/W3C/audio/readyState/readyState_initial-expected.txt: Added.
  • media/W3C/audio/readyState/readyState_initial.html: Added.
  • media/W3C/audio/readyState/readyState_property_exists-expected.txt: Added.
  • media/W3C/audio/readyState/readyState_property_exists.html: Added.
  • media/W3C/audio/src: Added.
  • media/W3C/audio/src/src_reflects_attribute_not_source_elements-expected.txt: Added.
  • media/W3C/audio/src/src_reflects_attribute_not_source_elements.html: Added.
  • media/W3C/audio/src/src_reflects_no_value-expected.txt: Added.
  • media/W3C/audio/src/src_reflects_no_value.html: Added.
  • media/W3C/audio/src/src_removal_does_not_trigger_loadstart-expected.txt: Added.
  • media/W3C/audio/src/src_removal_does_not_trigger_loadstart.html: Added.
  • media/W3C/video: Added.
  • media/W3C/video/canPlayType: Added.
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream.html: Added.
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_1-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_1.html: Added.
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_2-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_2.html: Added.
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_3-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_3.html: Added.
  • media/W3C/video/canPlayType/canPlayType_bogus_type-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_bogus_type.html: Added.
  • media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_codecs_order_1.html: Added.
  • media/W3C/video/canPlayType/canPlayType_codecs_order_2-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_codecs_order_2.html: Added.
  • media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_codecs_order_3.html: Added.
  • media/W3C/video/canPlayType/canPlayType_method_exists-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_method_exists.html: Added.
  • media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1.html: Added.
  • media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2.html: Added.
  • media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3.html: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_1.html: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_2.html: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_3-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_3.html: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_4-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_4.html: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_5.html: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Added.
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_6.html: Added.
  • media/W3C/video/currentSrc: Added.
  • media/W3C/video/currentSrc/currentSrc_empty_if_no_src-expected.txt: Added.
  • media/W3C/video/currentSrc/currentSrc_empty_if_no_src.html: Added.
  • media/W3C/video/currentSrc/currentSrc_nonempty_after_adding_source_child-expected.txt: Added.
  • media/W3C/video/currentSrc/currentSrc_nonempty_after_adding_source_child.html: Added.
  • media/W3C/video/currentSrc/currentSrc_nonempty_after_setting_src-expected.txt: Added.
  • media/W3C/video/currentSrc/currentSrc_nonempty_after_setting_src.html: Added.
  • media/W3C/video/currentSrc/currentSrc_property_exists-expected.txt: Added.
  • media/W3C/video/currentSrc/currentSrc_property_exists.html: Added.
  • media/W3C/video/error: Added.
  • media/W3C/video/error/error_null-expected.txt: Added.
  • media/W3C/video/error/error_null.html: Added.
  • media/W3C/video/error/error_onerror_called_on_bogus_source-expected.txt: Added.
  • media/W3C/video/error/error_onerror_called_on_bogus_source.html: Added.
  • media/W3C/video/error/error_property_exists-expected.txt: Added.
  • media/W3C/video/error/error_property_exists.html: Added.
  • media/W3C/video/events: Added.
  • media/W3C/video/events/event_canplay-expected.txt: Added.
  • media/W3C/video/events/event_canplay.html: Added.
  • media/W3C/video/events/event_canplay_manual-expected.txt: Added.
  • media/W3C/video/events/event_canplay_manual.html: Added.
  • media/W3C/video/events/event_canplaythrough-expected.txt: Added.
  • media/W3C/video/events/event_canplaythrough.html: Added.
  • media/W3C/video/events/event_canplaythrough_manual-expected.txt: Added.
  • media/W3C/video/events/event_canplaythrough_manual.html: Added.
  • media/W3C/video/events/event_loadeddata-expected.txt: Added.
  • media/W3C/video/events/event_loadeddata.html: Added.
  • media/W3C/video/events/event_loadeddata_manual-expected.txt: Added.
  • media/W3C/video/events/event_loadeddata_manual.html: Added.
  • media/W3C/video/events/event_loadedmetadata-expected.txt: Added.
  • media/W3C/video/events/event_loadedmetadata.html: Added.
  • media/W3C/video/events/event_loadedmetadata_manual-expected.txt: Added.
  • media/W3C/video/events/event_loadedmetadata_manual.html: Added.
  • media/W3C/video/events/event_loadstart-expected.txt: Added.
  • media/W3C/video/events/event_loadstart.html: Added.
  • media/W3C/video/events/event_loadstart_manual-expected.txt: Added.
  • media/W3C/video/events/event_loadstart_manual.html: Added.
  • media/W3C/video/events/event_order_canplay_canplaythrough-expected.txt: Added.
  • media/W3C/video/events/event_order_canplay_canplaythrough.html: Added.
  • media/W3C/video/events/event_order_canplay_playing-expected.txt: Added.
  • media/W3C/video/events/event_order_canplay_playing.html: Added.
  • media/W3C/video/events/event_order_loadedmetadata_loadeddata-expected.txt: Added.
  • media/W3C/video/events/event_order_loadedmetadata_loadeddata.html: Added.
  • media/W3C/video/events/event_order_loadstart_progress-expected.txt: Added.
  • media/W3C/video/events/event_order_loadstart_progress.html: Added.
  • media/W3C/video/events/event_pause_manual-expected.txt: Added.
  • media/W3C/video/events/event_pause_manual.html: Added.
  • media/W3C/video/events/event_play-expected.txt: Added.
  • media/W3C/video/events/event_play.html: Added.
  • media/W3C/video/events/event_play_manual-expected.txt: Added.
  • media/W3C/video/events/event_play_manual.html: Added.
  • media/W3C/video/events/event_playing-expected.txt: Added.
  • media/W3C/video/events/event_playing.html: Added.
  • media/W3C/video/events/event_playing_manual-expected.txt: Added.
  • media/W3C/video/events/event_playing_manual.html: Added.
  • media/W3C/video/events/event_progress-expected.txt: Added.
  • media/W3C/video/events/event_progress.html: Added.
  • media/W3C/video/events/event_progress_manual-expected.txt: Added.
  • media/W3C/video/events/event_progress_manual.html: Added.
  • media/W3C/video/events/event_timeupdate-expected.txt: Added.
  • media/W3C/video/events/event_timeupdate.html: Added.
  • media/W3C/video/events/event_timeupdate_manual-expected.txt: Added.
  • media/W3C/video/events/event_timeupdate_manual.html: Added.
  • media/W3C/video/networkState: Added.
  • media/W3C/video/networkState/networkState_during_loadstart-expected.txt: Added.
  • media/W3C/video/networkState/networkState_during_loadstart.html: Added.
  • media/W3C/video/networkState/networkState_during_progress-expected.txt: Added.
  • media/W3C/video/networkState/networkState_during_progress.html: Added.
  • media/W3C/video/networkState/networkState_initial-expected.txt: Added.
  • media/W3C/video/networkState/networkState_initial.html: Added.
  • media/W3C/video/networkState/networkState_property_exists-expected.txt: Added.
  • media/W3C/video/networkState/networkState_property_exists.html: Added.
  • media/W3C/video/paused: Added.
  • media/W3C/video/paused/paused_false_during_play-expected.txt: Added.
  • media/W3C/video/paused/paused_false_during_play.html: Added.
  • media/W3C/video/paused/paused_true_during_pause-expected.txt: Added.
  • media/W3C/video/paused/paused_true_during_pause.html: Added.
  • media/W3C/video/preload: Added.
  • media/W3C/video/preload/preload_property_exists-expected.txt: Added.
  • media/W3C/video/preload/preload_property_exists.html: Added.
  • media/W3C/video/preload/preload_reflects_auto_value-expected.txt: Added.
  • media/W3C/video/preload/preload_reflects_auto_value.html: Added.
  • media/W3C/video/preload/preload_reflects_bogus_value-expected.txt: Added.
  • media/W3C/video/preload/preload_reflects_bogus_value.html: Added.
  • media/W3C/video/preload/preload_reflects_empty-expected.txt: Added.
  • media/W3C/video/preload/preload_reflects_empty.html: Added.
  • media/W3C/video/preload/preload_reflects_metadata-expected.txt: Added.
  • media/W3C/video/preload/preload_reflects_metadata.html: Added.
  • media/W3C/video/preload/preload_reflects_no_value-expected.txt: Added.
  • media/W3C/video/preload/preload_reflects_no_value.html: Added.
  • media/W3C/video/preload/preload_reflects_none-expected.txt: Added.
  • media/W3C/video/preload/preload_reflects_none.html: Added.
  • media/W3C/video/preload/preload_reflects_none_autoplay-expected.txt: Added.
  • media/W3C/video/preload/preload_reflects_none_autoplay.html: Added.
  • media/W3C/video/readyState: Added.
  • media/W3C/video/readyState/readyState_during_canplay-expected.txt: Added.
  • media/W3C/video/readyState/readyState_during_canplay.html: Added.
  • media/W3C/video/readyState/readyState_during_canplaythrough-expected.txt: Added.
  • media/W3C/video/readyState/readyState_during_canplaythrough.html: Added.
  • media/W3C/video/readyState/readyState_during_loadeddata-expected.txt: Added.
  • media/W3C/video/readyState/readyState_during_loadeddata.html: Added.
  • media/W3C/video/readyState/readyState_during_loadedmetadata-expected.txt: Added.
  • media/W3C/video/readyState/readyState_during_loadedmetadata.html: Added.
  • media/W3C/video/readyState/readyState_during_playing-expected.txt: Added.
  • media/W3C/video/readyState/readyState_during_playing.html: Added.
  • media/W3C/video/readyState/readyState_initial-expected.txt: Added.
  • media/W3C/video/readyState/readyState_initial.html: Added.
  • media/W3C/video/readyState/readyState_property_exists-expected.txt: Added.
  • media/W3C/video/readyState/readyState_property_exists.html: Added.
  • media/W3C/video/src: Added.
  • media/W3C/video/src/src_reflects_attribute_not_source_elements-expected.txt: Added.
  • media/W3C/video/src/src_reflects_attribute_not_source_elements.html: Added.
  • media/W3C/video/src/src_reflects_no_value-expected.txt: Added.
  • media/W3C/video/src/src_reflects_no_value.html: Added.
  • media/W3C/video/src/src_removal_does_not_trigger_loadstart-expected.txt: Added.
  • media/W3C/video/src/src_removal_does_not_trigger_loadstart.html: Added.
  • media/W3C/w3cwrapper.js: Added.

(getVideoURI.bool):
(getVideoURI):
():
(test):
(async_test.t.step):
(async_test.t.done):
(async_test):
(assert_equals):
(assert_true):
(assert_false):

4:00 PM Changeset in webkit [103469] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r99097.

3:58 PM Changeset in webkit [103468] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Patch by Wyatt Carss <​wcarss@chromium.org> on 2011-12-21
Reviewed by Ryosuke Niwa.

strong and b should be font-weight: bold, not bolder
​https://bugs.webkit.org/show_bug.cgi?id=56400

Source/WebCore:

Test: fast/html/font-weight-bold-for-b-and-strong.html

  • css/html.css:

(strong, b):

LayoutTests:

Changed html.css to specify that strong and b are font-weight: bold,
not font-weight: bolder. Test added to confirm.

  • fast/html/font-weight-bold-for-b-and-strong-expected.png: Added.
  • fast/html/font-weight-bold-for-b-and-strong-expected.txt: Added.
  • fast/html/font-weight-bold-for-b-and-strong.html: Added.
  • WebCore/css/html.css:
3:39 PM Changeset in webkit [103467] by pierre.rossi@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

Implement montonicallyIncreasingClock() on Qt
​https://bugs.webkit.org/show_bug.cgi?id=62159

Reviewed by Darin Adler.

  • wtf/CurrentTime.cpp:

(WTF::monotonicallyIncreasingTime):

3:38 PM Changeset in webkit [103466] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark use-same-database-in-page-and-workers.html as crashing
​https://bugs.webkit.org/show_bug.cgi?id=75048

Unreviewed gardening.

Also, fix lint issues.

  • platform/chromium/test_expectations.txt:
3:26 PM Changeset in webkit [103465] by commit-queue@webkit.org
  • 42 edits
    2 adds in trunk

Improper handling of foreignobjects nested in svg groups
​https://bugs.webkit.org/show_bug.cgi?id=69762

Patch by Florin Malita <​fmalita@google.com> on 2011-12-21
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Tests: svg/foreignObject/repaint-rect-coordinates-expected.html

svg/foreignObject/repaint-rect-coordinates.html

  • rendering/svg/RenderSVGForeignObject.h:

(WebCore::RenderSVGForeignObject::objectBoundingBox):
(WebCore::RenderSVGForeignObject::strokeBoundingBox):
(WebCore::RenderSVGForeignObject::repaintRectInLocalCoordinates):
Return local coordinates.

LayoutTests:

Rebaseline after changing
RenderSVGForeignObject::{objectBoundingBox,strokeBoundingBox,repaintRectInLocalCoordinates}
to return local coordinates.

  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/chromium-win/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
  • platform/chromium-win/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/gtk/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt:
  • platform/gtk/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
  • platform/gtk/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt:
  • platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
  • platform/mac/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/mac/svg/overflow/overflow-on-foreignObject-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/qt/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt:
  • platform/qt/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
  • platform/qt/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt:
  • svg/foreignObject/multiple-foreign-objects-expected.txt:
  • svg/foreignObject/repaint-rect-coordinates-expected.html: Added.
  • svg/foreignObject/repaint-rect-coordinates.html: Added.
3:22 PM Changeset in webkit [103464] by dbates@webkit.org
  • 3 edits in trunk/Tools

Teach build-jsc how to build JavaScriptCore for the EFL, BlackBerry, and WinCE ports
​https://bugs.webkit.org/show_bug.cgi?id=74985

Patch by Daniel Bates <​dbates@rim.com> on 2011-12-21
Reviewed by Eric Seidel.

  • Scripts/build-jsc:
  • Scripts/webkitdirs.pm:

(cmakeBasedPortName): Added.

3:12 PM Changeset in webkit [103463] by Simon Fraser
  • 13 edits in trunk/LayoutTests

Update pixel results for CSS filters
​https://bugs.webkit.org/show_bug.cgi?id=75045

Reviewed by Sam Weinig.

Update some pixel results for CSS filter tests after r103125.

  • css3/filters/effect-blur-hw-expected.png:
  • css3/filters/effect-combined-hw-expected.png:
  • css3/filters/effect-custom-expected.png:
  • css3/filters/effect-drop-shadow-hw-expected.png:
  • css3/filters/effect-grayscale-hw-expected.png:
  • css3/filters/effect-hue-rotate-hw-expected.png:
  • css3/filters/effect-invert-hw-expected.png:
  • css3/filters/effect-opacity-hw-expected.png:
  • css3/filters/effect-saturate-hw-expected.png:
  • css3/filters/effect-sepia-hw-expected.png:
  • css3/filters/filter-with-transform-expected.png:
  • css3/filters/nested-filter-expected.png:
3:02 PM Changeset in webkit [103462] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Make it possible to use contents layers in scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=75044

Reviewed by Simon Fraser.

  • page/ScrollingCoordinator.h:
  • page/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
Don't pass const GraphicsLayers to these member functions; we need to be able to mutate them.

  • platform/ScrollView.cpp:

(positionScrollbarLayer):
If the scrollbar layer has a contents layer, just update its contents rect. Otherwise,
invalidate the scrollbar layer.

2:56 PM Changeset in webkit [103461] by dbates@webkit.org
  • 3 edits in trunk/Tools

Extract BlackBerry CMake arguments from build-webkit into separate function
​https://bugs.webkit.org/show_bug.cgi?id=74981

Patch by Daniel Bates <​dbates@rim.com> on 2011-12-21
Reviewed by Rob Buis.

Towards adding support for using Tools/Scripts/build-jsc for the BlackBerry port, move
the CMake argument logic from Tools/Scripts/build-webkit to function webkitdirs::blackberryCMakeArguments()
and have cmakeBasedPortArguments() call this function for the BlackBerry CMake argument list.
This will allow us to get the BlackBerry CMake arguments in Tools/Scripts/build-jsc so
that we can pass them to the CMake build system when building JavaScriptCore.

  • Scripts/build-webkit: Move construction of CMake argument list from here to

webkitdirs::blackberryCMakeArguments(). Also, remove exported function blackberryTargetArchitecture()
since it's only called within webkitdirs.pm now. Formerly we exported this function so that we could
call it from build-webkit.

  • Scripts/webkitdirs.pm:

(blackberryCMakeArguments): Added.
(cmakeBasedPortArguments): Modified to call blackberryCMakeArguments() when building the
BlackBerry port.

2:50 PM Changeset in webkit [103460] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

2:48 PM Changeset in webkit [103459] by Lucas Forschler
  • 1 copy in tags/Safari-535.14

New Tag.

2:47 PM Changeset in webkit [103458] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark color-prop-05-t.svg as failing after r103427
​https://bugs.webkit.org/show_bug.cgi?id=75042

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
2:46 PM Changeset in webkit [103457] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Always reposition the scrollbar layers when the frame view size changes
​https://bugs.webkit.org/show_bug.cgi?id=75035

Reviewed by Darin Adler.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
Remove the layersChanged check and unconditionally call positionScrollbarLayers(). This only
worked by accident before because we were recreating horizontal and vertical scrollbars on every call.

2:45 PM Changeset in webkit [103456] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r95054.

2:43 PM Changeset in webkit [103455] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[EFL] Add 'Select All' option to context menus in WebKit-EFL.
​https://bugs.webkit.org/show_bug.cgi?id=74920

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2011-12-21
Reviewed by Eric Seidel.

Enable 'Select All' option to context menus called on input fields in WebKit-EFL
as it is enabled in GTK and QT ports.

Source/WebCore:

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected): Add 'Select All' option.
(WebCore::ContextMenuController::populate): Append 'Select All' item.
(WebCore::ContextMenuController::checkOrEnableIfNeeded): Enable 'Select All' option.

  • platform/ContextMenuItem.h: Add 'Select All' option.
  • platform/LocalizationStrategy.h: Add constructor for 'Select All' option.
  • platform/LocalizedStrings.h: Add constructor for 'Select All' option.

Source/WebKit/efl:

  • ewk/ewk_contextmenu.h: Add new context menu option 'Select All'.
2:38 PM Changeset in webkit [103454] by Lucas Forschler
  • 2 edits
    3 copies in branches/safari-534.54-branch

Merged r95028.

2:35 PM Changeset in webkit [103453] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r95010.

2:34 PM Changeset in webkit [103452] by adamk@chromium.org
  • 6 edits in trunk/Source/WebCore

Make calls to willModifyAttribute and attributeChanged symmetrical
​https://bugs.webkit.org/show_bug.cgi?id=74987

Reviewed by Ryosuke Niwa.

Previously, calls to Element::willModifyAttribute sometimes happened
in one method while calls to Element::attributeChanged happened in
another. This change makes them symmetrical for all the cases I know
about: setAttribute, removeAttribute, setNamedItem, removeNamedItem.

To accomplish this, NamedNodeMap::addAttribute, removeAttribute, and
replaceAttribute have been reduced to their pure functionality of
manipulating m_attributes, and their callers are left responsible for
properly notifying the Element of the underlying changes.

One other bit of refactoring was done: to simplify
Element::setAttribute, it now dispatches to
Element::removeAttributeInternal if the incoming value is null.

No new tests, no change in behavior.

  • dom/Attribute.h:
  • dom/Element.cpp:

(WebCore::Element::removeAttribute):
(WebCore::Element::removeAttributeInternal): Added, sharing code
between the two removeAttribute overloads.
(WebCore::Element::setAttributeInternal):

  • dom/Element.h:
  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::addAttribute):
(WebCore::NamedNodeMap::removeAttribute):
(WebCore::NamedNodeMap::replaceAttribute):

  • svg/properties/SVGAnimatedPropertySynchronizer.h:

Call Element::setAttribute unless the attribute is already present,
and add a comment explaining why the code looks the way it does.

2:31 PM Changeset in webkit [103451] by Lucas Forschler
  • 4 edits
    3 copies in branches/safari-534.54-branch

Merged r94991.

2:29 PM Changeset in webkit [103450] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark more Mac compositing tests as flaky
​https://bugs.webkit.org/show_bug.cgi?id=47949

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
2:28 PM Changeset in webkit [103449] by Lucas Forschler
  • 8 edits
    3 copies in branches/safari-534.54-branch

Merged r94905.

2:24 PM Changeset in webkit [103448] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r94892.

2:21 PM Changeset in webkit [103447] by Lucas Forschler
  • 3 edits
    6 copies in branches/safari-534.54-branch

Merged r94857.

2:12 PM Changeset in webkit [103446] by Lucas Forschler
  • 14 edits in branches/safari-534.54-branch

Merged r94582.

2:08 PM Changeset in webkit [103445] by enne@google.com
  • 7 edits in trunk

Unreviewed, rolling out r103408.
​http://trac.webkit.org/changeset/103408
​https://bugs.webkit.org/show_bug.cgi?id=75017

WorkerDevToolsSanityTest.InspectSharedWorker is failing
(Requested by loislo_ on #webkit).

Source/WebCore:

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.sources):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMap):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.setCompilerSourceMapping):

  • inspector/front-end/utilities.js:

(String.prototype.asParsedURL):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping-expected.txt:
  • http/tests/inspector/compiler-source-mapping.html:
2:07 PM Changeset in webkit [103444] by Lucas Forschler
  • 20 edits
    24 copies in branches/safari-534.54-branch

Merged r94543.

1:58 PM Changeset in webkit [103443] by Lucas Forschler
  • 6 edits
    2 copies in branches/safari-534.54-branch

Merged r94541.

1:51 PM Changeset in webkit [103442] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r94512.

1:49 PM Changeset in webkit [103441] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r94511.

1:45 PM Changeset in webkit [103440] by Lucas Forschler
  • 10 edits
    2 copies in branches/safari-534.54-branch

Merged r94508.

1:40 PM Changeset in webkit [103439] by senorblanco@chromium.org
  • 4 edits
    2 adds in trunk

Source/WebCore: Fix CSS filters crash on zero-sized elements.
​https://bugs.webkit.org/show_bug.cgi?id=75020

Reviewed by Dean Jackson.

Test: css3/filters/filter-empty-element-crash.html

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::inputContext):
Protect against null ImageBuffer.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):
Protect against null GraphicsContext.

LayoutTests: Test for CSS filters crash on zero-sized element
​https://bugs.webkit.org/show_bug.cgi?id=75020

Reviewed by Dean Jackson.

  • css3/filters/filter-empty-element-crash-expected.txt: Added.
  • css3/filters/filter-empty-element-crash.html: Added.
1:21 PM Changeset in webkit [103438] by timothy@apple.com
  • 4 edits in trunk/Source

Web Inspector: suppress incremental rendering and use application chrome mode

​https://webkit.org/b/75026

Reviewed by Joseph Pecoraro.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController init]): Sort the preferences, remove the Leopard font family setting,
set suppress incremental rendering and use application chrome mode.

Source/WebKit2:

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::createInspectorPageGroup): Set suppress incremental rendering and use application chrome mode.

1:08 PM Changeset in webkit [103437] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r94455.

1:04 PM Changeset in webkit [103436] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r94112.

1:01 PM Changeset in webkit [103435] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Inform the scrolling coordinator when scrollbar layers come and go
​https://bugs.webkit.org/show_bug.cgi?id=75028

Reviewed by Andreas Kling and Simon Fraser.

  • page/ScrollingCoordinator.h:
  • page/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::setFrameViewHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinator::setFrameViewVerticalScrollbarLayer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):

1:01 PM Changeset in webkit [103434] by Lucas Forschler
  • 11 edits
    6 copies in branches/safari-534.54-branch

Merged r94109.

12:44 PM Changeset in webkit [103433] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/LayoutTests

Merged r94099.

12:39 PM Changeset in webkit [103432] by Lucas Forschler
  • 5 edits in branches/safari-534.54-branch

Merged r94095.

12:35 PM Changeset in webkit [103431] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r94001.

12:31 PM Changeset in webkit [103430] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-534.54-branch

Merged r93943.

12:27 PM Changeset in webkit [103429] by dslomov@google.com
  • 5 edits in trunk

Source/WebCore: [Chromium] DatabaseTrackerChromium: iterating DatabaseSet races with Database disposal on worker thread
​https://bugs.webkit.org/show_bug.cgi?id=74554

Reviewed by David Levin.

Covered by existing tests in fast/workers/storage.

  • storage/chromium/DatabaseTrackerChromium.cpp:

(WebCore::NotifyDatabaseObserverOnCloseTask::create):
(WebCore::NotifyDatabaseObserverOnCloseTask::performTask):
(WebCore::NotifyDatabaseObserverOnCloseTask::isCleanupTask):
(WebCore::NotifyDatabaseObserverOnCloseTask::NotifyDatabaseObserverOnCloseTask):
(WebCore::DatabaseTracker::removeOpenDatabase):

LayoutTests: [Chromium] DatabaseTrackerChromium: iterating DatabaseSet races with Database disposal on worker thread.
​https://bugs.webkit.org/show_bug.cgi?id=74554

Reviewed by David Levin.

  • platform/chromium/test_expectations.txt:
12:09 PM Changeset in webkit [103428] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

HTMLMediaElement::configureTextTrackDisplay is unnecessary
​https://bugs.webkit.org/show_bug.cgi?id=74945

Reviewed by Darin Adler.

Nothing to test, just removing redundant code. Correct behavior tested by
media/track/track-cue-rendering.html and media/track/track-cue-nothing-to-render.html.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::configureTextTrackDisplay): Don't show and hide track, just call

updateTextTrackDisplay and it will do the right thing.

12:09 PM Changeset in webkit [103427] by Nikolas Zimmermann
  • 252 edits
    1 move in trunk/LayoutTests

2011-12-21 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Rebaseline pixel test results, which have < 0.011 diffs on my 64bit SL machine.
This is a preparation, to build a new baseline with Lion.

  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/interact-order-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/interact-order-02-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-15-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
  • platform/mac-snowleopard/svg/carto.net/selectionlist-expected.png:
  • platform/mac-snowleopard/svg/css/composite-shadow-example-expected.png:
  • platform/mac-snowleopard/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGStringList-basics-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac-snowleopard/svg/filters/feLighting-crash-expected.png:
  • platform/mac-snowleopard/svg/filters/feOffset-expected.png:
  • platform/mac-snowleopard/svg/filters/filter-on-tspan-expected.png:
  • platform/mac-snowleopard/svg/wicd/rightsizing-grid-expected.png:
  • platform/mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
  • platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/mac/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/mac/svg/as-background-image/svg-as-background-3-expected.png:
  • platform/mac/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/mac/svg/as-background-image/svg-as-background-6-expected.png:
  • platform/mac/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
  • platform/mac/svg/as-image/animated-svg-as-image-expected.png:
  • platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/mac/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
  • platform/mac/svg/as-image/same-image-two-instances-expected.png:
  • platform/mac/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/mac/svg/as-object/object-box-sizing-no-width-height-expected.png:
  • platform/mac/svg/batik/filters/filterRegions-expected.png:
  • platform/mac/svg/batik/masking/maskRegions-expected.png:
  • platform/mac/svg/batik/text/textOnPath2-expected.png:
  • platform/mac/svg/batik/text/textOnPath3-expected.png:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/mac/svg/carto.net/button-expected.png:
  • platform/mac/svg/carto.net/colourpicker-expected.png:
  • platform/mac/svg/carto.net/scrollbar-expected.png:
  • platform/mac/svg/carto.net/slider-expected.png:
  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.png:
  • platform/mac/svg/clip-path/clip-path-childs-clipped-expected.png:
  • platform/mac/svg/clip-path/clip-path-clipped-expected.png:
  • platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-g-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-svg-expected.png:
  • platform/mac/svg/clip-path/clip-path-use-as-child-expected.png:
  • platform/mac/svg/clip-path/clip-path-use-as-child2-expected.png:
  • platform/mac/svg/clip-path/clip-path-use-as-child3-expected.png:
  • platform/mac/svg/clip-path/clip-path-use-as-child4-expected.png:
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/mac/svg/css/composite-shadow-text-expected.png:
  • platform/mac/svg/css/mask-with-shadow-expected.png:
  • platform/mac/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/mac/svg/custom/dasharrayOrigin-expected.png:
  • platform/mac/svg/custom/embedding-external-svgs-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/mac/svg/custom/fill-opacity-update-expected.png:
  • platform/mac/svg/custom/fractional-rects-expected.png:
  • platform/mac/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/mac/svg/custom/grayscale-gradient-mask-2-expected.png:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
  • platform/mac/svg/custom/invalid-css-expected.png:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-clipPath-creation-expected.png:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-pattern-creation-expected.png:
  • platform/mac/svg/custom/linking-uri-01-b-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/mac/svg/custom/nested-pattern-boundingBoxModeContent-expected.png:
  • platform/mac/svg/custom/non-scaling-stroke-expected.png:
  • platform/mac/svg/custom/pattern-in-defs-expected.png:
  • platform/mac/svg/custom/pattern-rotate-expected.png:
  • platform/mac/svg/custom/pattern-rotate-gaps-expected.png:
  • platform/mac/svg/custom/pattern-skew-transformed-expected.png:
  • platform/mac/svg/custom/pattern-with-transformation-expected.png:
  • platform/mac/svg/custom/rounded-rects-expected.png:
  • platform/mac/svg/custom/simple-text-double-shadow-expected.png:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/mac/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Copied from svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png.
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png:
  • platform/mac/svg/filters/filter-rounding-issues-expected.png:
  • platform/mac/svg/hixie/cascade/002-expected.png:
  • platform/mac/svg/hixie/perf/001-expected.png:
  • platform/mac/svg/hixie/perf/002-expected.png:
  • platform/mac/svg/hixie/perf/007-expected.png:
  • platform/mac/svg/hixie/transform/001-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
  • platform/mac/svg/text/selection-styles-expected.png:
  • platform/mac/svg/text/small-fonts-3-expected.png:
  • platform/mac/svg/text/text-align-03-b-expected.png:
  • platform/mac/svg/text/text-path-01-b-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.png:
  • platform/mac/svg/text/textPathBoundsBug-expected.png:
  • platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.png:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/mac/svg/webarchive/svg-feimage-subresources-expected.png:
  • platform/mac/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Removed.
11:52 AM Changeset in webkit [103426] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

ScrollingCoordinator functions should take FrameView objects
​https://bugs.webkit.org/show_bug.cgi?id=75023

Reviewed by Sam Weinig.

  • page/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::syncFrameViewGeometry):

  • page/ScrollingCoordinator.h:
  • page/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::setFrameViewScrollLayer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
(WebCore::RenderLayerCompositor::ensureRootLayer):

11:52 AM Changeset in webkit [103425] by Lucas Forschler
  • 5 edits
    30 copies in branches/safari-534.54-branch

Merged r93794.

11:48 AM Changeset in webkit [103424] by Lucas Forschler
  • 3 edits in branches/safari-534.54-branch/Source/WebKit/mac

Merged r93732.

11:45 AM Changeset in webkit [103423] by Lucas Forschler
  • 3 edits
    4 copies in branches/safari-534.54-branch

Merged r93521.

11:42 AM Changeset in webkit [103422] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r93514.

11:41 AM Changeset in webkit [103421] by andersca@apple.com
  • 9 edits
    1 delete in trunk/Source/WebCore

Get rid of ScrollableAreaClient
​https://bugs.webkit.org/show_bug.cgi?id=75021

Reviewed by Sam Weinig.

The ScrollableAreaClient interface will just add an extra level of indirection between ScrollableArea and
ScrollAnimator, which is unnecessary. Eventually I'd like to rename ScrollAnimator to something that better reflects
all the different responsibilities it currently has.

  • WebCore.exp.in:
  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):

  • page/ScrollingCoordinator.cpp:
  • page/ScrollingCoordinator.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::ScrollView):

  • platform/ScrollView.h:
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::ScrollableArea):

  • platform/ScrollableArea.h:
  • platform/ScrollableAreaClient.h: Removed.
11:32 AM Changeset in webkit [103420] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderBoxModelObject.cpp

Fixing a sub-pixel fillRect call with pixelSnappedIntRect

11:28 AM Changeset in webkit [103419] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Don't recreate scrollbar layers whenever the frame view size changes
​https://bugs.webkit.org/show_bug.cgi?id=75018

Reviewed by Darin Adler and Simon Fraser.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):

11:09 AM Changeset in webkit [103418] by dbates@webkit.org
  • 3 edits in trunk/Tools

Extract WinCE CMake arguments from build-webkit into separate function
​https://bugs.webkit.org/show_bug.cgi?id=74983

Reviewed by Rob Buis.

Towards adding support for using Tools/Scripts/build-jsc for the WinCE port, extract the
WinCE-specific CMake argument from Tools/Scripts/build-webkit into webkitdirs::cmakeBasedPortArguments().
This will allow us to get the WinCE-specific CMake argument in Tools/Scripts/build-jsc so
that we can pass it to the CMake build system when building JavaScriptCore.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(cmakeBasedPortArguments): Added.

11:05 AM Changeset in webkit [103417] by dbates@webkit.org
  • 4 edits in trunk

Add CMake option to only build JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=74979

Reviewed by Rob Buis.

Towards adding CMake support to script Tools/Scripts/build-jsc, add a CMake
option to only build JavaScriptCore.

  • CMakeLists.txt: Defined ENABLE_WEBCORE to build WebCore. If the option

ONLY_BUILD_JAVASCRIPTCORE is specified then don't build WebCore, WebKit, or WebKit2.

  • Source/CMakeLists.txt:
  • Source/cmake/WebKitFS.cmake:
10:56 AM Changeset in webkit [103416] by Lucas Forschler
  • 6 edits
    2 copies in branches/safari-534.54-branch

Merged r93347.

10:49 AM Changeset in webkit [103415] by Lucas Forschler
  • 8 edits
    3 copies in branches/safari-534.54-branch

Merged r93227.

10:43 AM Changeset in webkit [103414] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Cleanup up clients when deallocating WebKit2 API objects
​https://bugs.webkit.org/show_bug.cgi?id=75014

Reviewed by Adam Roben.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController dealloc]):

  • UIProcess/API/mac/WKConnection.mm:

(-[WKConnection dealloc]):
Clear clients on dealloc.

10:21 AM Changeset in webkit [103413] by commit-queue@webkit.org
  • 3 edits
    5 adds in trunk/Source/WebKit2

[Qt][WK2] Add tests for favicon and fix icon url decoding issue
​https://bugs.webkit.org/show_bug.cgi?id=74967

Patch by Rafael Brandao <​rafael.lobo@openbossa.org> on 2011-12-21
Reviewed by Simon Hausmann.

  • UIProcess/API/qt/qwebiconimageprovider.cpp: We already receive the url

without the percent encoding and we should access WebIconDatabase with
an encoded url. Added a test to cover this behavior.
(QWebIconImageProvider::requestImage):

  • UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/favicon.html: Added.
  • UIProcess/API/qt/tests/qmltests/common/favicon.png: Added.
  • UIProcess/API/qt/tests/qmltests/common/favicon2.html: Added.
  • UIProcess/API/qt/tests/qmltests/common/small-favicon.png: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
10:19 AM Changeset in webkit [103412] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Exception thrown when running WKBrowsingContextLoadDelegateTest.SimpleLoad test
​https://bugs.webkit.org/show_bug.cgi?id=75012

Reviewed by Adam Roben.

  • UIProcess/API/mac/WKProcessGroup.mm:

(-[WKProcessGroup dealloc]):
Clear the WKContext's connection client.

9:20 AM Changeset in webkit [103411] by caseq@chromium.org
  • 12 edits
    1 add
    1 delete in trunk

Web Inspector: [Extension API] refactor extension API build code, expose experimental APIs conditionally in chromium
​https://bugs.webkit.org/show_bug.cgi?id=74941

Reviewed by Pavel Feldman.

Source/WebCore:

  • WebCore.gypi:
  • inspector/front-end/ExtensionAPI.js:

(buildPlatformExtensionAPI.platformExtensionAPI):
(buildPlatformExtensionAPI):
(buildExtensionAPIInjectedScript):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._addExtensions):
(WebInspector.ExtensionServer.prototype._addExtension):
(window.addExtension):

Source/WebKit/chromium:

  • WebKit.gyp:
  • WebKit.gypi:
  • scripts/concatenate_js_files.py:

(main):

  • scripts/generate_devtools_extension_api.py:

(write_devtools_extension_api):

  • src/js/DevTools.js:

():

LayoutTests:

  • http/tests/inspector/extensions-test.js:

(initialize_ExtensionsTest.InspectorTest.runExtensionTests):
(initialize_ExtensionsTest):

  • platform/chromium/inspector/extensions/extensions-api-expected.txt: Removed.
9:03 AM Changeset in webkit [103410] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Fix tst_QQuickWebView::scrollRequest() API test
​https://bugs.webkit.org/show_bug.cgi?id=73994

Patch by Michael Brüning <​michael.bruning@nokia.com> on 2011-12-21
Reviewed by Kenneth Rohde Christiansen.

Added a viewport meta tag so that the view is actually scrollable and
does not get scaled to not be scrollable. Corrected the style
definition for the <div> tag. Removed unneeded text in div

Rolled back changes some of the changes from the previous patch
(r102453) because they weren't necessary.

  • UIProcess/API/qt/tests/html/scroll.html:
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::scrollRequest): Partially rolled back changes.

8:24 AM Changeset in webkit [103409] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Windows build fix.

Replace all instances of "WebPropupMenuProxy" with "WebPopupMenuProxy".

  • UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::showPopupMenu):
(WebKit::WebPopupMenuProxyWin::setFocusedIndex):

7:48 AM Changeset in webkit [103408] by podivilov@chromium.org
  • 7 edits in trunk

Web Inspector: fix source map url resolving.
​https://bugs.webkit.org/show_bug.cgi?id=74305

Reviewed by Pavel Feldman.

Source/WebCore:

Also fix the bug with repeated source urls in mapping sections.

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.sources):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMap):
(WebInspector.ClosureCompilerSourceMapping.prototype._resolveSourceMapURL):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.installCompilerSourceMapping):

  • inspector/front-end/utilities.js:

(String.prototype.asParsedURL):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping-expected.txt:
  • http/tests/inspector/compiler-source-mapping.html:
7:28 AM Changeset in webkit [103407] by reni@webkit.org
  • 3729 edits in trunk

New renderer for SVGRectElement
​https://bugs.webkit.org/show_bug.cgi?id=65769

Source/WebCore:

Rubber-stamped by Zoltan Herczeg.

Change the return value of RenderSVGRect::renderName() from RenderSVGPath to RenderSVGRect.
This is a follow-up patch of r101517 to correct the DRT output.

  • rendering/svg/RenderSVGRect.h:

(WebCore::RenderSVGRect::renderName):

LayoutTests:

Rubber stamped by Zoltan Herczeg.

Rename the renderer of SVGRects from RenderSVGPath to RenderSVGRect.

6:38 AM Changeset in webkit [103406] by vsevik@chromium.org
  • 6 edits
    2 adds in trunk

Web Inspector: TabbedPane should use tabElement width measuring to layout tab elements when width is too small to fit them.
​https://bugs.webkit.org/show_bug.cgi?id=75005

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/tabbed-pane-max-tab-width-calculation.html

  • inspector/front-end/NetworkItemView.js:

(WebInspector.NetworkItemView.prototype.wasShown):

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane):
(WebInspector.TabbedPane.prototype.appendTab):
(WebInspector.TabbedPane.prototype._createTabElement):
(WebInspector.TabbedPane.prototype.onResize):
(WebInspector.TabbedPane.prototype._maybeMeasureAndUpdate):
(WebInspector.TabbedPane.prototype._measureTab):
(WebInspector.TabbedPane.prototype._updateWidths):
(WebInspector.TabbedPane.prototype._calculateMaxWidth):
(WebInspector.TabbedPaneTab):

  • inspector/front-end/inspector.css:

(.tabbed-pane-header):
(.tabbed-pane-header-tabs):
(.tabbed-pane-header-tab):
(.tabbed-pane-header-tab.measuring):
(.tabbed-pane-header-tab.selected):

  • inspector/front-end/scriptsPanel.css:

(#scripts-navigator-tabbed-pane .tabbed-pane-header-tabs):

LayoutTests:

  • inspector/tabbed-pane-max-tab-width-calculation-expected.txt: Added.
  • inspector/tabbed-pane-max-tab-width-calculation.html: Added.
5:52 AM Changeset in webkit [103405] by podivilov@chromium.org
  • 8 edits in trunk

Web Inspector: auto detect source map url.
​https://bugs.webkit.org/show_bug.cgi?id=74088

Reviewed by Pavel Feldman.

Source/WebCore:

Check to see if "X-SourceMap" HTTP response header was sent with script resource.
Header value will be used as auto suggestion for source map url in UI.

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::sourceMapURLForScript):
(WebCore::InspectorDebuggerAgent::didParseSource):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerDispatcher.prototype.scriptParsed):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):

  • inspector/front-end/Script.js:

(WebInspector.Script):

LayoutTests:

  • inspector/debugger/raw-source-code.html:
5:48 AM Changeset in webkit [103404] by pierre.rossi@gmail.com
  • 3 edits in trunk/Source/WebCore

[Qt] Mobile theme refinements
​https://bugs.webkit.org/show_bug.cgi?id=74727

Mostly to replace most of the rounded-rect-shaped
controls with squircle-shaped ones.

Reviewed by Kenneth Rohde Christiansen.

No new tests needed.

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::drawControlBackground):
(WebCore::painterScale):
(WebCore::borderPen):
(WebCore::StylePainterMobile::drawCheckableBackground): Toned down the gradient a bit.
(WebCore::StylePainterMobile::findCheckBox):
(WebCore::StylePainterMobile::drawRadio):
(WebCore::StylePainterMobile::findRadio):
(WebCore::StylePainterMobile::drawMultipleComboButton): increase spacing between the dots.
(WebCore::StylePainterMobile::drawSimpleComboButton): attempt to improve readability.
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::findComboButton):
(WebCore::StylePainterMobile::drawLineEdit):
(WebCore::StylePainterMobile::findLineEdit):
(WebCore::StylePainterMobile::drawPushButton):
(WebCore::StylePainterMobile::findPushButton):
(WebCore::StylePainterMobile::drawComboBox):
(WebCore::StylePainterMobile::drawProgress):
(WebCore::StylePainterMobile::drawSliderThumb):
(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):
(WebCore::RenderThemeQtMobile::paintTextField):

  • platform/qt/RenderThemeQtMobile.h:
5:45 AM Changeset in webkit [103403] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CSSStyleSheet::cssRules can return 0 and InspectorStyleSheet dosen't check
​https://bugs.webkit.org/show_bug.cgi?id=74938

Prevent security checks when retrieving a just-added CSS rule from the "inspector stylesheet".

Reviewed by Pavel Feldman.

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::addRule):

2:38 AM Changeset in webkit [103402] by Csaba Osztrogonác
  • 39 edits
    10 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Update Qt specific expected results.

  • platform/qt/Skipped: Skip fast/text/international/bdi-neutral-wrapped.html because of missing test font.
  • platform/qt/css2.1/20110323/border-conflict-style-079-expected.png: Added.
  • platform/qt/css2.1/20110323/floating-replaced-height-008-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-05-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-07-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-08-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-15-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-17-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-18-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/qt/test_expectations.txt: Unskip passing tests.
2:20 AM Changeset in webkit [103401] by reni@webkit.org
  • 4 edits in trunk/Source/WebCore

Fulfill FIXME in HTMLLinkElement.h.
​https://bugs.webkit.org/show_bug.cgi?id=74278

Rename isStyleSheetLoading() method to styleSheetIsLoading().
This new one has the correct grammar.

Reviewed by Darin Adler.

No new tests because the functionality remains the same.

  • dom/Document.cpp:

(WebCore::Document::recalcStyleSelector):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setDisabledState):
(WebCore::HTMLLinkElement::styleSheetIsLoading):
(WebCore::HTMLLinkElement::sheetLoaded):

  • html/HTMLLinkElement.h:
1:47 AM Changeset in webkit [103400] by commit-queue@webkit.org
  • 30 edits in trunk/Source/WebCore

[Forms] Add OVERRIDE to WebCore/html/*InputType.h
​https://bugs.webkit.org/show_bug.cgi?id=74996

Patch by Yosifumi Inoue <​yosin@chromium.org> on 2011-12-21
Reviewed by Kent Tamura.

No new tests. Changes are just for compilation.

  • html/BaseButtonInputType.h: Add OVERRIDE.
  • html/BaseCheckableInputType.h: Add OVERRIDE.
  • html/BaseDateAndTimeInputType.h: Add OVERRIDE.
  • html/BaseTextInputType.h: Add OVERRIDE.
  • html/ButtonInputType.h: Add OVERRIDE.
  • html/CheckboxInputType.h: Add OVERRIDE.
  • html/ColorInputType.h: Add OVERRIDE.
  • html/DateInputType.h: Add OVERRIDE.
  • html/DateTimeInputType.h: Add OVERRIDE.
  • html/DateTimeLocalInputType.h: Add OVERRIDE.
  • html/EmailInputType.h: Add OVERRIDE.
  • html/FileInputType.h: Add OVERRIDE.
  • html/HiddenInputType.h: Add OVERRIDE.
  • html/ImageInputType.h: Add OVERRIDE.
  • html/IsIndexInputType.h: Add OVERRIDE.
  • html/MonthInputType.h: Add OVERRIDE.
  • html/NumberInputType.h: Add OVERRIDE.
  • html/PasswordInputType.h: Add OVERRIDE.
  • html/RadioInputType.h: Add OVERRIDE.
  • html/RangeInputType.h: Add OVERRIDE.
  • html/ResetInputType.h: Add OVERRIDE.
  • html/SearchInputType.h: Add OVERRIDE.
  • html/SubmitInputType.h: Add OVERRIDE.
  • html/TelephoneInputType.h: Add OVERRIDE.
  • html/TextFieldInputType.h: Add OVERRIDE.
  • html/TextInputType.h: Add OVERRIDE.
  • html/TimeInputType.h: Add OVERRIDE.
  • html/URLInputType.h: Add OVERRIDE.
  • html/WeekInputType.h: Add OVERRIDE.
12:54 AM Changeset in webkit [103399] by haraken@chromium.org
  • 2 edits in trunk/Tools

In prepare-ChangeLog, replace constant global variables with "use constant"
​https://bugs.webkit.org/show_bug.cgi?id=74992

Reviewed by Ryosuke Niwa.

This patch replaces the following constant global variables with "use constant"s.

  • $changeLogTimeZone
  • $SVN
  • $GIT
  • %supportedTestExtensions
  • Scripts/prepare-ChangeLog:

(changeLogNameFromArgs):
(changeLogEmailAddressFromArgs):
(resolveConflictedChangeLogs):
(generateNewChangeLogs):
(diffCommand):
(statusCommand):
(createPatchCommand):
(findOriginalFileFromSvn):
(determinePropertyChanges):
(generateFileList):
(reviewerAndDescriptionForGitCommit):

12:33 AM Changeset in webkit [103398] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed update test expectation for svg/custom/linking-uri-01-b.svg

  • platform/chromium/test_expectations.txt:
12:19 AM Changeset in webkit [103397] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Add all ICU languages to LocaleToScriptMappingDefault.cpp
​https://bugs.webkit.org/show_bug.cgi?id=67274

Patch by Matt Falkenhagen <​falken@chromium.org> on 2011-12-21
Reviewed by Kent Tamura.

This better mimics the behavior of LocaleToScriptMappingICU.cpp. ICU
languages from ICU 3.6 are added. Also, script suffix in locale is
handled, so for example "fa_Latn" is mapped to Latin while "fa" is mapped to
Arabic.

No new tests, there is no visible effect until default per-script fonts
are added to non-ICU ports (alternatively, we could extend DumpRenderTree
to support overridePreference for per-script fonts as in bug 71110).

  • platform/text/LocaleToScriptMappingDefault.cpp:

(WebCore::getScriptCode): add script name to script code mapping
(WebCore::localeToScriptCodeForFontSelection): add ICU languages to map

12:11 AM Changeset in webkit [103396] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed update test expectations for inspector's tests.

  • platform/chromium/test_expectations.txt:
12:09 AM Changeset in webkit [103395] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] [Gardening] Move tests to the right skip list.
​https://bugs.webkit.org/show_bug.cgi?id=74958

These tests pass on Qt-5.0 both with WK1 and WK2 but fail on Qt-4.8.
Also removes comment refering to Qt-4.7 since the test fails on all
versions at the moment.

Patch by João Paulo Rechi Vita <​jprvita@openbossa.org> on 2011-12-21
Reviewed by Csaba Osztrogonác.

  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
12:03 AM Changeset in webkit [103394] by levin@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

Disable a test without a result while I figure out
how to make the results consistent for each run.
Bug 74666 basically tracks re-enabling this test
since it contains an enhanced version of it.

  • http/tests/workers/interrupt-database-sync-open-crash.html-skipped: Renamed from LayoutTests/http/tests/workers/interrupt-database-sync-open-crash.html.

Dec 20, 2011:

11:44 PM Changeset in webkit [103393] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/WebCore

Upstream PageClientBlackBerry.h into WebCore/platform/blackberry
​https://bugs.webkit.org/show_bug.cgi?id=74169

Patch by Mary Wu <​mary.wu@torchmobile.com.cn> on 2011-12-20
Reviewed by Daniel Bates.

Initial upstream, no new tests.

  • platform/blackberry/PageClientBlackBerry.h: Added.
11:40 PM Changeset in webkit [103392] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

32_64 baseline JIT should attempt to convert division results to integers, and record when that fails
​https://bugs.webkit.org/show_bug.cgi?id=74997
<rdar://problem/10612389>

Reviewed by Gavin Barraclough.

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_div):

11:36 PM Changeset in webkit [103391] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebCore

Upstream PlatformMouseEvent and LocalizedStrings into WebCore/platform/blackberry
​https://bugs.webkit.org/show_bug.cgi?id=74383

Patch by Mary Wu <​mary.wu@torchmobile.com.cn> on 2011-12-20
Reviewed by Daniel Bates.

Other Main Contributors:
Rob Buis <​rbuis@rim.com>
Mike Fenton <​mifenton@rim.com>

Initial upstream, no new tests.

  • PlatformBlackBerry.cmake: Modified to rename Localizations.cpp to LocalizedStringsBlackBerry.cpp
  • platform/blackberry/LocalizedStringsBlackBerry.cpp: Added.
  • platform/blackberry/PlatformMouseEventBlackBerry.cpp: Added.
10:01 PM Changeset in webkit [103390] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

JavaScriptCore should be consistent about how it reads and writes ArgumentCount
​https://bugs.webkit.org/show_bug.cgi?id=74989
<rdar://problem/10612006>

Reviewed by Gavin Barraclough.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileLoadVarargs):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_get_arguments_length):
(JSC::JIT::emit_op_get_argument_by_val):

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::SpecializedThunkJIT):

9:51 PM Changeset in webkit [103389] by loislo@chromium.org
  • 22 edits in trunk/Source/WebCore

Web Inspector: CodeGenerator should not use pointers for out params of RefPtr type.
​https://bugs.webkit.org/show_bug.cgi?id=69366

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2011-12-20
Reviewed by Pavel Feldman.

Generator fixed and all usages are changed manually.

  • inspector/CodeGeneratorInspector.py:

(RawTypes.BaseType):
(RawTypes.BaseType.get_output_argument_prefix):
(RawTypes.Object.get_output_argument_prefix):
(RawTypes.Array.get_output_argument_prefix):
(RawTypes):
(Generator.process_command):

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::getApplicationCacheForFrame):

  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getStyleSheet):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
(WebCore::InspectorCSSAgent::stopSelectorProfiler):
(WebCore::InspectorCSSAgent::stopSelectorProfilerImpl):

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::getAttributes):

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):

  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):

  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionLocation):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getDOMNodeCount):

  • inspector/InspectorMemoryAgent.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore::InspectorProfilerAgent::getProfile):
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):

  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):

  • inspector/InspectorRuntimeAgent.h:
8:36 PM Changeset in webkit [103388] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] m_triggerIdlePaints not reset after a compositeAndReadback
​https://bugs.webkit.org/show_bug.cgi?id=74974

Patch by Eric Penner <​epenner@google.com> on 2011-12-20
Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::compositeAndReadback):

7:26 PM Changeset in webkit [103387] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Move misplaced assert in SQLiteStatement.cpp
​https://bugs.webkit.org/show_bug.cgi?id=74975

Reviewed by Dmitry Titov.

The test is coming with bug 74666.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::step): If a database was interrupted
before the prepare method was called, then m_isPrepared will be
false, so I moved the assert to be after the check for interrupted.

6:37 PM Changeset in webkit [103386] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

WebVTT cues sometimes render when they should not
​https://bugs.webkit.org/show_bug.cgi?id=74873

Not reviewed: update Chromium to pass new test added in r103371.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::updateTextTrackDisplay):

6:33 PM Changeset in webkit [103385] by Lucas Forschler
  • 14 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r99093.

6:29 PM Changeset in webkit [103384] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Value Profiles for arguments should be more easily accessible to the interpreter
​https://bugs.webkit.org/show_bug.cgi?id=74984
<rdar://problem/10611364>

Reviewed by Gavin Barraclough.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::dumpValueProfiles):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::setArgumentValueProfileSize):
(JSC::CodeBlock::numberOfArgumentValueProfiles):
(JSC::CodeBlock::valueProfileForArgument):
(JSC::CodeBlock::addValueProfile):
(JSC::CodeBlock::valueProfile):
(JSC::CodeBlock::valueProfileForBytecodeOffset):
(JSC::CodeBlock::totalNumberOfValueProfiles):
(JSC::CodeBlock::getFromAllValueProfiles):

  • bytecode/ValueProfile.h:

(JSC::ValueProfile::ValueProfile):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitValueProfilingSite):

6:02 PM Changeset in webkit [103383] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLOptionsCollection: Remove incorrect FIXME about having a base class.
<​http://webkit.org/b/74973>

Reviewed by Alexey Proskuryakov.

HTMLOptionsCollection should indeed inherit from HTMLCollection according to
current HTML5, so remove the comment saying we should change that.

Spec: ​http://www.whatwg.org/specs/web-apps/current-work/#htmloptionscollection

  • html/HTMLOptionsCollection.idl:
5:57 PM Changeset in webkit [103382] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r93032.

5:52 PM Changeset in webkit [103381] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r92966.

5:50 PM Changeset in webkit [103380] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSC shell should accept utf8 input.

Reviewed by Filip Pizlo.

  • jsc.cpp:

(jscSource):
(functionRun):
(functionLoad):
(functionCheckSyntax):
(runWithScripts):
(runInteractive):

5:49 PM Changeset in webkit [103379] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r92798.

5:46 PM Changeset in webkit [103378] by Lucas Forschler
  • 5 edits in branches/safari-534.54-branch

Merged r92744.

5:41 PM Changeset in webkit [103377] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

td element ignores zero width/height input element
​https://bugs.webkit.org/show_bug.cgi?id=74636

Patch by Florin Malita <​fmalita@google.com> on 2011-12-20
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/input-zero-width.html

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computePreferredLogicalWidths):
Relax the attribute test to allow setting widths == 0.

LayoutTests:

  • fast/forms/input-zero-width-expected.html: Added.
  • fast/forms/input-zero-width.html: Added.
5:40 PM Changeset in webkit [103376] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r92630.

5:37 PM Changeset in webkit [103375] by Lucas Forschler
  • 13 edits in branches/safari-534.54-branch/Source

Merged r92347.

5:33 PM Changeset in webkit [103374] by Lucas Forschler
  • 5 edits
    7 copies in branches/safari-534.54-branch

Merged r92142.

5:32 PM Changeset in webkit [103373] by adamk@chromium.org
  • 16 edits in trunk/Source

Avoid unnecessary work when removing attributes from an element
​https://bugs.webkit.org/show_bug.cgi?id=74953

Reviewed by Ryosuke Niwa.

Source/WebCore:

Various codepaths in Element and NamedNodeMap repeatedly search
through the list of attributes during a single operation. To avoid
this, I've added new getters to NamedNodeMap that return indices
rather than Attribute*s (they return WTF::notFound if no match is
found). These new methods are now used during removeAttribute
operations, as well as setAttribute and NamedNodeMap::setNamedItem
(along with a new replaceAttribute helper method).

The other optimization here involves the creation/destruction
of never-references Attr nodes. This is now avoided by calling
NamedNodeMap::removeAttribute directly instead of going through
NamedNodeMap::removeNamedItem.

As a cleanup after the above changes, the ExceptionCode argument is
gone from Element::removeAttribute and friends (it was never set
previously). The bulk of the files mentioned below are simply updating
callers to these methods.

No new tests, no change in behavior expected.

  • dom/DatasetDOMStringMap.cpp:

(WebCore::DatasetDOMStringMap::deleteItem):

  • dom/Element.cpp:

(WebCore::Element::removeAttribute):
(WebCore::Element::setBooleanAttribute):
(WebCore::Element::removeAttributeNS):
(WebCore::Element::setAttribute):
(WebCore::Element::setAttributeInternal):

  • dom/Element.h:
  • dom/Element.idl:
  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::getAttributeItemIndexSlowCase):
(WebCore::NamedNodeMap::replaceAttribute):
(WebCore::NamedNodeMap::removeAttribute):

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::getAttributeItem):
(WebCore::NamedNodeMap::getAttributeItemIndex):
(WebCore::NamedNodeMap::removeAttribute):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock):

  • editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::executeApply):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::setContentEditable):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setType):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::transferUseAttributesToReplacedElement):

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(QWebElement::removeAttribute): Updated a caller of
WebCore::Element::removeAttribute to remove ExceptionCode argument.

5:24 PM Changeset in webkit [103372] by Lucas Forschler
  • 4 edits
    4 copies in branches/safari-534.54-branch

Merged r91957.

5:14 PM Changeset in webkit [103371] by eric.carlson@apple.com
  • 3 edits
    3 adds in trunk

WebVTT cues sometimes render when they should not
​https://bugs.webkit.org/show_bug.cgi?id=74873

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-cue-nothing-to-render.html

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::updateTextTrackDisplay): Don't return early if the current

cue is empty so the previous cue is removed.

LayoutTests:

  • media/track/captions-webvtt/captions-gaps.vtt: Added.
  • media/track/track-cue-nothing-to-render-expected.txt: Added.
  • media/track/track-cue-nothing-to-render.html: Added.
5:09 PM Changeset in webkit [103370] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Don't crash on the second time VideoLayerChromium::createCCVideoLayer() is called
​https://bugs.webkit.org/show_bug.cgi?id=74963

Patch by Ami Fischman <​fischman@chromium.org> on 2011-12-20
Reviewed by James Robinson.

Manually tested by force-dropping the layer tree in CCLayerTreeHost::didBecomeInvisibleOnImplThread().
Crashed before the fix, doesn't crash after.

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::~VideoLayerChromium):
(WebCore::VideoLayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/VideoLayerChromium.h:
4:51 PM Changeset in webkit [103369] by Lucas Forschler
  • 5 edits in branches/safari-534.54-branch

Merged r90980.

4:48 PM Changeset in webkit [103368] by Lucas Forschler
  • 14 edits
    16 copies in branches/safari-534.54-branch

Merged r90164.

4:44 PM Changeset in webkit [103367] by Lucas Forschler
  • 3 edits
    6 copies in branches/safari-534.54-branch

Merged r89982.

4:39 PM Changeset in webkit [103366] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

wouldTaintOrigin m_cleanURLs cache grows very large when data urls used
​https://bugs.webkit.org/show_bug.cgi?id=74957

Patch by Scott Graham <​scottmg@chromium.org> on 2011-12-20
Reviewed by Kenneth Russell.

No new tests, but memory usage of CanvasRenderingContext::m_cleanURLs
is reduced.

  • html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::wouldTaintOrigin):

4:23 PM Changeset in webkit [103365] by commit-queue@webkit.org
  • 32 edits in trunk/Source/WebCore

Change adoptPtr(new ...) to ...::create in Page.cpp
​https://bugs.webkit.org/show_bug.cgi?id=74457

Patch by Greg Billock <​gbillock@google.com> on 2011-12-20
Reviewed by Darin Adler.

  • dom/DeviceMotionController.cpp:

(WebCore::DeviceMotionController::create):

  • dom/DeviceMotionController.h:
  • dom/DeviceOrientationController.cpp:

(WebCore::DeviceOrientationController::create):

  • dom/DeviceOrientationController.h:
  • editing/FrameSelection.cpp:

(WebCore::DragCaretController::create):

  • editing/FrameSelection.h:
  • history/BackForwardController.cpp:

(WebCore::BackForwardController::create):

  • history/BackForwardController.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::create):

  • inspector/InspectorController.h:
  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::create):

  • loader/ProgressTracker.h:
  • notifications/NotificationController.cpp:

(WebCore::NotificationController::create):

  • notifications/NotificationController.h:
  • page/Chrome.cpp:

(WebCore::Chrome::create):

  • page/Chrome.h:
  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::create):

  • page/ContextMenuController.h:
  • page/DragController.cpp:

(WebCore::DragController::create):

  • page/DragController.h:
  • page/FocusController.cpp:

(WebCore::FocusController::create):

  • page/FocusController.h:
  • page/GeolocationController.cpp:

(WebCore::GeolocationController::create):

  • page/GeolocationController.h:
  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::initGroup):
(WebCore::Page::speechInput):

  • page/PageGroup.cpp:

(WebCore::PageGroup::create):

  • page/PageGroup.h:
  • page/Settings.cpp:

(WebCore::Settings::create):

  • page/Settings.h:
  • page/SpeechInput.cpp:

(WebCore::SpeechInput::create):

  • page/SpeechInput.h:
4:10 PM Changeset in webkit [103364] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Rubber Stamped by Sam Weinig

  • runtime/JSGlobalData.cpp:
    • removed some dead code.
4:04 PM Changeset in webkit [103363] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Mac build fix after r103354.

  • platform/mac/ScrollAnimatorMac.mm:

(systemUptime):

3:58 PM Changeset in webkit [103362] by andersca@apple.com
  • 9 edits in trunk/Source

Add ScrollableArea::contentsResized and have it call the scroll animator
​https://bugs.webkit.org/show_bug.cgi?id=74966

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.exp.in:
  • page/FrameView.cpp:

(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::contentsResized):

  • page/FrameView.h:
  • platform/ScrollView.h:
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::contentsResized):

  • platform/ScrollableArea.h:

Source/WebKit2:

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::scrollbarStyleChanged):

3:55 PM Changeset in webkit [103361] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

requestAnimationFrame on Mac fires at 60fps even when drawing is much slower
​https://bugs.webkit.org/show_bug.cgi?id=74964

Reviewed by Chris Marrin.

On Mac requestAnimationFrame uses a CVDisplayLink, sending notifications
from the display link thread to the main thread that the display link fired.
However, there was no throttling on these notifications; if processing an event
took a long time, notifications would pile up, and then get handled after
the slow event completed.

This would cause JS animations which animate by changing style to report
60fps when their display framerate was much lower.

Fix by throttling notifications from the display link thread to the web
thread; if the previous event hasn't completed yet, don't send any new ones.

No new tests, since testing this runtime behavior is hard.

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::refreshDisplayOnMainThread):
(WebCore::DisplayRefreshMonitor::notifyClients): Factored out of the
static refreshDisplayOnMainThread method so we can use 'this'.

  • platform/graphics/DisplayRefreshMonitor.h:
  • platform/graphics/mac/DisplayRefreshMonitorMac.cpp:

(WebCore::DisplayRefreshMonitor::displayLinkFired):

3:50 PM Changeset in webkit [103360] by Lucas Forschler
  • 3 edits in branches/safari-534.54-branch/Source/WebCore

Merged r88398.

3:46 PM Changeset in webkit [103359] by Lucas Forschler
  • 8 edits in branches/safari-534.54-branch

Merged r88316.

3:46 PM Changeset in webkit [103358] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Coverity] Fix leak in V8HTMLDocument
​https://bugs.webkit.org/show_bug.cgi?id=74943

Patch by Greg Billock <​gbillock@google.com> on 2011-12-20
Reviewed by Adam Barth.

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::openCallback):

3:39 PM Changeset in webkit [103357] by dpranke@chromium.org
  • 5 edits in trunk/Tools

nrwt: rename field references from _fs to _filesystem
​https://bugs.webkit.org/show_bug.cgi?id=74898

Reviewed by Adam Barth.

This is a simple cleanup; most of the code uses
self._filesystem, but some used self._fs; this change renames
the latter to the former to be more consistent.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.init):
(Manager.collect_tests):
(Manager._strip_test_dir_prefix):
(Manager._split_into_chunks_if_necessary):
(Manager.results_directory):
(Manager._clobber_old_results):
(Manager._upload_json_files):
(Manager.print_config):
(Manager._copy_results_html_file):
(Manager._show_results_html_file):
(Manager._log_worker_stack):

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:

(JSONLayoutResultsGenerator._normalize_results_json):

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase.init):
(JSONResultsGeneratorBase.generate_json_output):
(JSONResultsGeneratorBase.generate_times_ms_file):
(JSONResultsGeneratorBase.upload_json_files):
(JSONResultsGeneratorBase._get_svn_revision):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(Base.init):

3:30 PM Changeset in webkit [103356] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Tightened up Vector<T>::append
​https://bugs.webkit.org/show_bug.cgi?id=74906

Reviewed by Sam Weinig.

Not a measurable speedup, but code inspection shows better code generated,
and I believe this is a step toward turning off -fomit-frame-pointer.

  • wtf/Vector.h:

(WTF::::append):
(WTF::::appendSlowCase): Split out the slow case into a separate function
to keep unnecessary instructions off the hot path. This means the hot
path can now be inlined more often.

Removed some old MSVC7 cruft. Hopefully, we don't need to hang on to a
compiler work-around from 2007.

3:28 PM Changeset in webkit [103355] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the Windows build.

  • UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::showPopupMenu):
(WebKit::WebPopupMenuProxyWin::setFocusedIndex):

3:13 PM Changeset in webkit [103354] by commit-queue@webkit.org
  • 13 edits
    1 copy
    4 deletes in trunk/Source/WebCore

Merge ScrollAnimatorChromiumMac.mm back to ScrollAnimatorMac
​https://bugs.webkit.org/show_bug.cgi?id=61144

Patch by Sailesh Agrawal <​sail@chromium.org> on 2011-12-20
Reviewed by Beth Dakin.

At a high level the main changes are:

  • replace #ifdefs in ScrollAnimatorMac and ScrollbarThemeMac with run time checks
  • delete duplicate code in ScrollbarThemeChromiumMac. Keep the paint code since it does tickmarks and SKIA stuff.
  • delete ScrollAnimatorChromiumMac since ScrollAnimatorMac does the exact same thing
  • delete ScrollbarOverlayUtilitiesChromiumMac since NSScrollerImpDetails does the same thing

No new tests. Just refactoring.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/chromium/ScrollAnimatorChromiumMac.h: Removed.
  • platform/chromium/ScrollAnimatorChromiumMac.mm: Removed.
  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h: Removed.
  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm: Removed.
  • platform/chromium/ScrollbarThemeChromiumMac.h:
  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarPainterPaintTrack):
(WebCore::ScrollbarThemeChromiumMac::paint):

  • platform/mac/EmptyProtocolDefinitions.h:
  • platform/mac/NSScrollerImpDetails.h:

(WebCore::isScrollbarOverlayAPIAvailable):

  • platform/mac/NSScrollerImpDetails.mm: Added.

(WebCore::isScrollbarOverlayAPIAvailable):
(WebCore::recommendedScrollerStyle):

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(scrollbarPainterForScrollbar):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::cancelAnimations):
(WebCore::ScrollAnimatorMac::setIsActive):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):

  • platform/mac/ScrollElasticityController.h:
  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

(+[WebScrollbarPrefsObserver appearancePrefsChanged:]):
(+[WebScrollbarPrefsObserver behaviorPrefsChanged:]):
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::setIsCurrentlyDrawingIntoLayer):
(WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeMac::hasButtons):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::scrollbarPartToHIPressedState):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::scrollbarPainterPaint):
(WebCore::ScrollbarThemeMac::paint):

2:37 PM Changeset in webkit [103353] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

sizeof(RenderStyle) is 64 instead of 56 on Windows (x86)
​https://bugs.webkit.org/show_bug.cgi?id=74876

Reviewed by Ryosuke Niwa.

Move bit fields into a new class and use unsigned for all types so we
align at 4 byte bounds. Also move the initializers into the header
file (has the side benefit of not needing to duplicate the initializers
in 3 places).

Enable the compile assert on Windows.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::affectedByUncommonAttributeSelectors):
(WebCore::RenderStyleBitfields::setAffectedByUncommonAttributeSelectors):
(WebCore::RenderStyleBitfields::unique):
(WebCore::RenderStyleBitfields::setUnique):
(WebCore::RenderStyleBitfields::affectedByEmpty):
(WebCore::RenderStyleBitfields::emptyState):
(WebCore::RenderStyleBitfields::setEmptyState):
(WebCore::RenderStyleBitfields::childrenAffectedByFirstChildRules):
(WebCore::RenderStyleBitfields::setChildrenAffectedByFirstChildRules):
(WebCore::RenderStyleBitfields::childrenAffectedByLastChildRules):
(WebCore::RenderStyleBitfields::setChildrenAffectedByLastChildRules):
(WebCore::RenderStyleBitfields::childrenAffectedByDirectAdjacentRules):
(WebCore::RenderStyleBitfields::setChildrenAffectedByDirectAdjacentRules):
(WebCore::RenderStyleBitfields::childrenAffectedByForwardPositionalRules):
(WebCore::RenderStyleBitfields::setChildrenAffectedByForwardPositionalRules):
(WebCore::RenderStyleBitfields::childrenAffectedByBackwardPositionalRules):
(WebCore::RenderStyleBitfields::setChildrenAffectedByBackwardPositionalRules):
(WebCore::RenderStyleBitfields::firstChildState):
(WebCore::RenderStyleBitfields::setFirstChildState):
(WebCore::RenderStyleBitfields::lastChildState):
(WebCore::RenderStyleBitfields::setLastChildState):
(WebCore::RenderStyleBitfields::childIndex):
(WebCore::RenderStyleBitfields::setChildIndex):
(WebCore::RenderStyleBitfields::setHasExplicitlyInheritedProperties):
(WebCore::RenderStyleBitfields::hasExplicitlyInheritedProperties):

2:33 PM Changeset in webkit [103352] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, according to the flakiness dashboard,
http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html
is consistently passing.

  • platform/chromium/test_expectations.txt:
2:17 PM Changeset in webkit [103351] by Nate Chapin
  • 2 edits in trunk/Source/WebKit/chromium

Revert code for r96912 and r101905, since they cause
regressions in mac scrollbars, caret display in
form fields, etc.
​https://bugs.webkit.org/show_bug.cgi?id=74939

Reviewed by Eric Seidel.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setFocus):

2:13 PM Changeset in webkit [103350] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, according to the flakiness dashboard,
svg/css/glyph-orientation-rounding-test.xhtml is consistently passing
on all platforms.

  • platform/chromium/test_expectations.txt:
2:05 PM Changeset in webkit [103349] by reed@google.com
  • 2 edits in trunk/Source/WebKit/chromium

enable USE_SKIA_TEXT by default, replacing GDI for all text drawing
​https://bugs.webkit.org/show_bug.cgi?id=74928

Reviewed by Stephen White.

  • features.gypi:
1:45 PM Changeset in webkit [103348] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] enable WPO for WebCore libs in official builds
​https://bugs.webkit.org/show_bug.cgi?id=74947

Reviewed by James Robinson.

Also move enable_wexit_time_destructors to the top level variables
so we don't have to add it to all targets.

  • WebCore.gyp/WebCore.gyp:
1:44 PM AdvantagesOfJenkinsOverBuildbot edited by Adam Roben
(diff)
1:43 PM AdvantagesOfJenkinsOverBuildbot edited by Adam Roben
(diff)
1:40 PM Changeset in webkit [103347] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] Remove statusBarMessageChanged
​https://bugs.webkit.org/show_bug.cgi?id=74405

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2011-12-20
Reviewed by Tor Arne Vestbø.

Removing support for window.status updates from the public
QML API. See bug for details.

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/qt/QtWebPageUIClient.cpp:

(QtWebPageUIClient::QtWebPageUIClient):

  • UIProcess/qt/QtWebPageUIClient.h:
1:21 PM Changeset in webkit [103346] by andersca@apple.com
  • 11 edits in trunk/Source

Add ScrollableArea wrappers for a bunch of ScrollAnimator member functions
​https://bugs.webkit.org/show_bug.cgi?id=74951

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.exp.in:
  • page/EventHandler.cpp:

(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::updateMouseEventTargetNode):

  • page/FocusController.cpp:

(WebCore::FocusController::setActive):

  • page/FrameView.cpp:

(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
(WebCore::FrameView::notifyPageThatContentAreaWillPaint):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::contentAreaWillPaint):
(WebCore::ScrollableArea::mouseEnteredContentArea):
(WebCore::ScrollableArea::mouseExitedContentArea):
(WebCore::ScrollableArea::mouseMovedInContentArea):
(WebCore::ScrollableArea::mouseEnteredScrollbar):
(WebCore::ScrollableArea::mouseExitedScrollbar):
(WebCore::ScrollableArea::contentAreaDidShow):
(WebCore::ScrollableArea::contentAreaDidHide):

  • platform/ScrollableArea.h:
  • platform/ScrollableAreaClient.h:
  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::mouseEntered):
(WebCore::Scrollbar::mouseExited):
(WebCore::Scrollbar::mouseUp):

Source/WebKit2:

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::paint):
(WebKit::BuiltInPDFView::handleMouseEvent):
(WebKit::BuiltInPDFView::handleMouseEnterEvent):
(WebKit::BuiltInPDFView::handleMouseLeaveEvent):

1:11 PM Changeset in webkit [103345] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

When <bdi> content is wrapped, all hell breaks loose
​https://bugs.webkit.org/show_bug.cgi?id=74396

New test case by Aharon Lanin for multi-line bidi.

Patch by Ken Buchanan <​kenrb@chromium.org> on 2011-12-20
Reviewed by Ryosuke Niwa.

  • fast/text/international/bidi-neutral-wrapped.html: Added.
  • fast/text/international/bidi-neutral-wrapped-expected.html: Added.
1:06 PM Changeset in webkit [103344] by jarred@sencha.com
  • 3 edits
    5 adds in trunk

Perform case insensitive matching on MIME types in XHR
​https://bugs.webkit.org/show_bug.cgi?id=74800

Source/WebCore:

Perform case insensitive matching on responseMIMEType() in didReceiveData().
Workaround case sensitive matching by DOMImplementation::isXMLMIMEType() in responseIsXML().

Reviewed by Darin Adler.

Tests: http/tests/xmlhttprequest/xmlhttprequest-mimetype-mixed-case.html

http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-mixed-case.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::didReceiveData):
(WebCore::XMLHttpRequest::responseIsXML):

LayoutTests:

New tests that verify mixed case MIME types are properly handled in XHR for

  • user provided types via overrideMimeType()
  • server-sent Content-Type headers

Reviewed by Darin Adler.

  • http/tests/xmlhttprequest/resources/xmlhttprequest-mimetype-mixed-case.php: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-mimetype-mixed-case.html: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-mimetype-mixed-case-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-mixed-case.html: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-mixed-case-expected.txt: Added.
1:02 PM Changeset in webkit [103343] by adamk@chromium.org
  • 4 edits in trunk/Source/WebCore

Remove no-op DOMAttr* event dispatch methods from Element
​https://bugs.webkit.org/show_bug.cgi?id=74946

Reviewed by Darin Adler.

The removed methods had their bodies #if 0'd out, so this should have
no effect on anything.

  • dom/Element.cpp:
  • dom/Element.h:
  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::addAttribute):
(WebCore::NamedNodeMap::removeAttribute):

12:45 PM AdvantagesOfJenkinsOverBuildbot edited by Adam Roben
(diff)
12:43 PM AdvantagesOfJenkinsOverBuildbot edited by Adam Roben
(diff)
12:42 PM AdvantagesOfJenkinsOverBuildbot edited by Adam Roben
(diff)
12:41 PM AdvantagesOfJenkinsOverBuildbot edited by Adam Roben
(diff)
12:40 PM AdvantagesOfJenkinsOverBuildbot edited by Adam Roben
(diff)
12:34 PM AdvantagesOfJenkinsOverBuildbot edited by Adam Roben
(diff)
12:33 PM Changeset in webkit [103342] by andersca@apple.com
  • 10 edits
    1 add in trunk/Source/WebCore

ScrollableArea should have an optional ScrollableAreaClient
​https://bugs.webkit.org/show_bug.cgi?id=74949

Reviewed by Sam Weinig.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • page/FrameView.cpp:

(WebCore::scrollableAreaClient):
(WebCore::FrameView::FrameView):

  • page/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::scrollableAreaClientForFrame):

  • page/ScrollingCoordinator.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::ScrollView):

  • platform/ScrollView.h:
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::ScrollableArea):

  • platform/ScrollableArea.h:
  • platform/ScrollableAreaClient.h: Added.

(WebCore::ScrollableAreaClient::~ScrollableAreaClient):
(WebCore::ScrollableAreaClient::ScrollableAreaClient):

12:30 PM AdvantagesOfJenkinsOverBuildbot edited by Adam Roben
(diff)
12:29 PM Changeset in webkit [103341] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WinCairo] Unreviewed build fix.

  • win/WebKit2CFLite.def: Add missing export declaration.
12:28 PM AdvantagesOfJenkinsOverBuildbot edited by Adam Roben
(diff)
12:26 PM AdvantagesOfJenkinsOverBuildbot created by Adam Roben
12:24 PM WikiStart edited by Adam Roben
(diff)
11:40 AM Changeset in webkit [103340] by adamk@chromium.org
  • 6 edits in trunk/Source/WebCore

Rename Element::setAttributeMap to parserSetAttributeMap and limit its use to the parser
​https://bugs.webkit.org/show_bug.cgi?id=74885

Reviewed by Ryosuke Niwa.

Element::setAttributeMap is currently used by the parser in cases
where a NamedNodeMap of attributes has already been allocated and
transfers ownership to the Element. Other uses in WebCore don't have
this ownership-transfer requirement, and so are more clearly expressed
with normal setAttribute calls.

Eliminating non-parser callers allows the code to make safe
assumptions about the state of the Element it's called on: no need to
worry about, e.g., updating the id in the document's cache or
enqueueing mutation records.

No new tests, no change in behavior expected.

  • dom/Element.cpp:

(WebCore::Element::parserSetAttributeMap): Renamed, added assertions
to make sure it's not called unexpectedly, update comments.

  • dom/Element.h:
  • html/HTMLViewSourceDocument.cpp: Use setAttribute instead of setAttributeMap.

(WebCore::HTMLViewSourceDocument::createContainingTable):
(WebCore::HTMLViewSourceDocument::addSpanWithClassName):
(WebCore::HTMLViewSourceDocument::addLine):
(WebCore::HTMLViewSourceDocument::addBase):
(WebCore::HTMLViewSourceDocument::addLink):

  • html/parser/HTMLConstructionSite.cpp: Reference new name.

(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::constructTreeFromToken): Use setAttribute instead of setAttributeMap.
Also get rid of an unnecessary String -> AtomicString conversion.

10:12 AM Changeset in webkit [103339] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove unused parameter from RenderLayerCompositor::rebuildCompositingLayerTree
​https://bugs.webkit.org/show_bug.cgi?id=74936

Patch by Iain Merrick <​husky@google.com> on 2011-12-20
Reviewed by Simon Fraser.

Pure refactoring, no change in functionality.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):

  • rendering/RenderLayerCompositor.h:
9:40 AM Changeset in webkit [103338] by haraken@chromium.org
  • 4 edits
    1 move in trunk/Tools

Replace webkitperl/run-leaks_unittest/RunLeaks.pm with webkitperl/LoadAsModule.pm
​https://bugs.webkit.org/show_bug.cgi?id=74836

Reviewed by David Kilzer.

webkitperl/run-leaks_unittest/RunLeaks.pm can be used for unit-testing of run-leaks only.
This patch creates more generalized webkitperl/LoadAsModule.pm, which can be also used
for unit-testing of other Perl scripts. We are planning to use it for unit-testing
of prepare-ChangeLog.

Using LoadAsModule.pm, you can load a Perl script as follows.
The first argument is the arbitrary package name you want to use, and the second argument
is the name of the Perl script you want to load.

use LoadAsModule qw(RunLeaks run-leaks);
RunLeaks::someFunctionDefinedInRunLeaks(...);

Tests: Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl

Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl
Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl

  • Scripts/webkitperl/LoadAsModule.pm: Added.
  • Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Removed.

(import):
(readFile):

  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Used LoadAsModule instead of RunLeaks.
  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
9:31 AM Changeset in webkit [103337] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

RenderStyle::InheritedFlags and RenderStyle::NonInheritedFlags members should be 4 byte aligned
​https://bugs.webkit.org/show_bug.cgi?id=74880

Reviewed by Ryosuke Niwa.

Use unsigned for all types so we get 4 byte boundaries (unsigned char
means we try to align to 1 byte boundaries) and add setters and
getters for bool members.

Move some members around to make sure we're aligned to 4 byte boundaries.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::copyNonInheritedFrom):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::NonInheritedFlags::affectedByHover):
(WebCore::InheritedFlags::NonInheritedFlags::setAffectedByHover):
(WebCore::InheritedFlags::NonInheritedFlags::affectedByActive):
(WebCore::InheritedFlags::NonInheritedFlags::setAffectedByActive):
(WebCore::InheritedFlags::NonInheritedFlags::affectedByDrag):
(WebCore::InheritedFlags::NonInheritedFlags::setAffectedByDrag):
(WebCore::InheritedFlags::NonInheritedFlags::isLink):
(WebCore::InheritedFlags::NonInheritedFlags::setIsLink):
(WebCore::InheritedFlags::setBitDefaults):
(WebCore::InheritedFlags::affectedByHoverRules):
(WebCore::InheritedFlags::affectedByActiveRules):
(WebCore::InheritedFlags::affectedByDragRules):
(WebCore::InheritedFlags::setAffectedByHoverRules):
(WebCore::InheritedFlags::setAffectedByActiveRules):
(WebCore::InheritedFlags::setAffectedByDragRules):
(WebCore::InheritedFlags::isLink):
(WebCore::InheritedFlags::setIsLink):

9:26 AM Changeset in webkit [103336] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] 2 editing tests introduced in r103073 fails
​https://bugs.webkit.org/show_bug.cgi?id=74937

Unreviewed gardening, skip failing tests.

  • platform/qt-wk2/Skipped:
9:23 AM Changeset in webkit [103335] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Assertion hit and crash with fast/multicol/pagination-* tests
​https://bugs.webkit.org/show_bug.cgi?id=74511

Unreviewed gardening, skip failing tests.

  • platform/qt-wk2/Skipped:
9:21 AM UsingGitWithWebKit edited by Adam Roben
(diff)
9:09 AM Changeset in webkit [103334] by loislo@chromium.org
  • 2 edits in trunk

emacs: unreviewed. add settings for editing js files.

  • .dir-locals.el:
8:32 AM Changeset in webkit [103333] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r103325) - injected-script-for-origin.html crashing in Chromium Linux debug
​https://bugs.webkit.org/show_bug.cgi?id=74934

Unreviewed test fix.

  • http/tests/inspector/injected-script-for-origin.html:
8:27 AM Changeset in webkit [103332] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

chromium: unreviewed. Clean out passing tests from test_expectations.txt.

  • platform/chromium/test_expectations.txt: plugins/form-value.html: was fixed at r103147. fast/images/move-image-to-new-document.html: was fixed somewhere between r102959 and r102965. media/media-controller-playback.html: rebaselined at r103285.
7:42 AM Changeset in webkit [103331] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

[Qt] Build fix for gcc used on WK2 build bot.

  • UIProcess/qt/QtWebPagePolicyClient.cpp:

(QtWebPagePolicyClient::decidePolicyForNavigationAction): Don't do case:
with values outside the range of the type. Instead switch() on the int instead.

7:35 AM Changeset in webkit [103330] by Simon Hausmann
  • 9 edits in trunk/Source

[Qt] Extend QQuickWebview::navigationRequested API
​https://bugs.webkit.org/show_bug.cgi?id=73818

Patch by Rafael Brandao <​rafael.lobo@openbossa.org> on 2011-12-20
Reviewed by Simon Hausmann.

Source/WebKit/qt:

  • declarative/experimental/plugin.cpp:

Source/WebKit2:

Added url of the originating frame on QWebNavigationRequest,
accessible via 'request.originatingUrl' on QML. Download action
was moved to experimental, so in order to use it you should set
'request.action = WebViewExperimental.DownloadRequest' on QML.

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qwebnavigationrequest.cpp:

(QWebNavigationRequestPrivate::QWebNavigationRequestPrivate):
(QWebNavigationRequest::QWebNavigationRequest):
(QWebNavigationRequest::originatingUrl):

  • UIProcess/API/qt/qwebnavigationrequest_p.h:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:

Tests were modified a bit to reuse urls and also added a test case to check
originating url once a request is done.

  • UIProcess/qt/QtWebPagePolicyClient.cpp:

(QtWebPagePolicyClient::decidePolicyForNavigationAction):

  • UIProcess/qt/QtWebPagePolicyClient.h:
7:21 AM Changeset in webkit [103329] by kbalazs@webkit.org
  • 7 edits in trunk

[Qt] WK2 Debugging quirks need some improvement
​https://bugs.webkit.org/show_bug.cgi?id=74859

Reviewed by Simon Hausmann.

Improvements added to make debugging WebKit2 more
confortable and efficient:

  1. Unify debugging quirks. From now all of them are controlled

by the QT_WEBKIT2_DEBUG environment variable.

  1. Disable crash handlers for WebKitTestRunner if debugging quirks

are used to make it possible to use postmortem debugging via core dumps
which is extremely useful for debugging bugs triggered by layout tests.

  1. Disable test timeout for WebKitTestRunner if debugging quirks

are used because that makes debugging impossible.

Source/WebKit2:

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::QtWebProcess::setupChildProcess):

  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt):

Tools:

  • WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:

(WTR::InjectedBundle::platformInitialize):

  • WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:

(WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):

  • WebKitTestRunner/qt/TestControllerQt.cpp:

(WTR::TestController::platformRunUntil):

7:07 AM Changeset in webkit [103328] by loislo@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

[Chromium] Rebaseline fast/js/mozilla/strict/15.4.5.1.html
​https://bugs.webkit.org/show_bug.cgi?id=74918

Unreviewed expectation fix.

Patch by Michael Starzinger <​mstarzinger@chromium.org> on 2011-12-20

  • platform/chromium/fast/js/mozilla/strict/15.4.5.1-expected.txt: Added.
  • platform/chromium/test_
6:08 AM Changeset in webkit [103327] by jchaffraix@webkit.org
  • 3 edits
    6 adds in trunk

Regression(99212): table rows get incorrect height after changing some cells' height
​https://bugs.webkit.org/show_bug.cgi?id=74303

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/table/resize-table-binding-cell.html

fast/table/resize-table-cell.html
fast/table/resize-table-row.html

r99212 wrongly implemented the row's logicalHeight recalculation.
The original code would use recalcCells which would properly recalculate a
row logicalHeight by iterating over the table's cells but throwing out the
existing result.

Our approach is just to recompute our row's logicalHeight and leave the
rest of the section untouched.

  • rendering/RenderTableSection.cpp:

(WebCore::updateLogicalHeightForCell):
Added this new helper function to update the RowStruct logicalHeight during
|addCell| and |rowLogicalHeightChanged|.

(WebCore::RenderTableSection::addCell):
Replaced the old code with a call to updateLogicalHeightForCell.
(WebCore::RenderTableSection::rowLogicalHeightChanged):
Added a call to updateLogicalHeightForCell for each cells.

LayoutTests:

Added some tests that resize a cell or a row and check that we properly recompute the height.

  • fast/table/resize-table-binding-cell-expected.txt: Added.
  • fast/table/resize-table-binding-cell.html: Added.
  • fast/table/resize-table-cell-expected.txt: Added.
  • fast/table/resize-table-cell.html: Added.
  • fast/table/resize-table-row-expected.txt: Added.
  • fast/table/resize-table-row.html: Added.
6:04 AM Changeset in webkit [103326] by loislo@chromium.org
  • 22 edits in trunk/Source/WebCore

Unreviewed, rolling out r103322.
​http://trac.webkit.org/changeset/103322
​https://bugs.webkit.org/show_bug.cgi?id=74927

seven inspector's tests are crashing on qt (Requested by
loislo on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-20

  • inspector/CodeGeneratorInspector.py:

(RawTypes.BaseType.is_event_param_check_optional):
(RawTypes.Object.is_event_param_check_optional):
(RawTypes.Array.is_event_param_check_optional):
(RawTypes):
(Generator.process_command):

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::getApplicationCacheForFrame):

  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getStyleSheet):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
(WebCore::InspectorCSSAgent::stopSelectorProfiler):

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::getAttributes):

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):

  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):

  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionLocation):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getDOMNodeCount):

  • inspector/InspectorMemoryAgent.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore::InspectorProfilerAgent::getProfile):
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):

  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):

  • inspector/InspectorRuntimeAgent.h:
5:42 AM Changeset in webkit [103325] by caseq@chromium.org
  • 10 edits
    3 adds
    1 delete in trunk

Web Inspector: [Extensions API] allow setting extension API per extension security origin
​https://bugs.webkit.org/show_bug.cgi?id=74868

Reviewed by Pavel Feldman.

This replaces InspectorExtensionAPI string within InspectorFrontendHost with a map by extension
security origin, so that we can have APIs customized by extension (in particular, this is needed
to expose experimental APIs only to certain extensions).

  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::didClearWindowObjectInWorld):
(WebCore::InspectorAgent::setInjectedScriptForOrigin):

  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::setInjectedScriptForOrigin):

  • inspector/InspectorController.h:
  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::setInjectedScriptForOrigin):

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._addExtensions):
(WebInspector.ExtensionServer.prototype._addExtension):

5:36 AM Changeset in webkit [103324] by jesus@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2]REGRESSION(r103310): It broke tst_QQuickWebView::loadNonexistentFileUrl() API test
​https://bugs.webkit.org/show_bug.cgi?id=74923

Rubber-stamped by Csaba Osztrogonác.

Fixing API usage after ​http://trac.webkit.org/changeset/103310.

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::loadNonexistentFileUrl):

5:31 AM Changeset in webkit [103323] by Simon Hausmann
  • 7 edits in trunk/Source/WebKit2

[Qt] Favicon support should work with multiple web contexts
​https://bugs.webkit.org/show_bug.cgi?id=74922

Reviewed by Tor Arne Vestbø.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize): Remove unnecessary use of QtWebContext::defaultContext(). There is
already a member variable "context" which is the correct one.
(QQuickWebViewPrivate::setIcon): Ditto.

  • UIProcess/API/qt/qwebiconimageprovider.cpp:

(QWebIconImageProvider::requestImage): Extract the context id from the image id and use it to
query the correct icon database.

  • UIProcess/qt/QtWebContext.cpp: Provide a mapping from id to qtwebcontext.

(WebKit::generateContextID):
(WebKit::QtWebContext::QtWebContext):
(WebKit::QtWebContext::~QtWebContext):
(WebKit::QtWebContext::contextByID):
(WebKit::QtWebContext::initialize):

  • UIProcess/qt/QtWebContext.h:

(WebKit::QtWebContext::context):
(WebKit::QtWebContext::contextID):

  • UIProcess/qt/QtWebIconDatabaseClient.cpp:

(QtWebIconDatabaseClient::QtWebIconDatabaseClient):
(QtWebIconDatabaseClient::requestIconForPageURL): Store the context id in the icon url.

  • UIProcess/qt/QtWebIconDatabaseClient.h:
5:20 AM Changeset in webkit [103322] by loislo@chromium.org
  • 22 edits in trunk/Source/WebCore

Web Inspector: CodeGenerator should not use pointers for out params of RefPtr type.
​https://bugs.webkit.org/show_bug.cgi?id=69366

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2011-12-20
Reviewed by Pavel Feldman.

Generator fixed and all usages are changed manually.

  • inspector/CodeGeneratorInspector.py:

(RawTypes.BaseType.is_event_param_check_optional):
(RawTypes.BaseType):
(RawTypes.BaseType.get_output_argument_prefix):
(RawTypes.Object.get_output_argument_prefix):
(RawTypes.Array.get_output_argument_prefix):
(RawTypes):
(Generator.process_command):

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::getApplicationCacheForFrame):

  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getStyleSheet):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
(WebCore::InspectorCSSAgent::stopSelectorProfiler):
(WebCore::InspectorCSSAgent::stopSelectorProfilerImpl):

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::getAttributes):

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):

  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):

  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionLocation):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getDOMNodeCount):

  • inspector/InspectorMemoryAgent.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore::InspectorProfilerAgent::getProfile):
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):

  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):

  • inspector/InspectorRuntimeAgent.h:
5:17 AM Changeset in webkit [103321] by yutak@chromium.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Change default WebSocket protocol to the latest one
​https://bugs.webkit.org/show_bug.cgi?id=74064

Reviewed by Martin Robinson.

  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
Use hybi WebSocket protocol by default.

4:56 AM Changeset in webkit [103320] by jarred@sencha.com
  • 3 edits in trunk/Source/WebKit/qt

[Qt] HTTP header injection via QWebPage::userAgentForUrl()
​https://bugs.webkit.org/show_bug.cgi?id=68560

Strip out newline characters from the result of userAgentForUrl() to prevent additional
HTTP headers in HTTP requests.

New QtTest case that validates the user agent, as returned by navigator.userAgent, does not
contain any newline characters.

Reviewed by Simon Hausmann.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::userAgent):

  • tests/qwebpage/tst_qwebpage.cpp:

(CustomUserAgentWebPage::userAgentForUrl):
(tst_QWebPage::userAgentNewlineStripping):

4:49 AM Changeset in webkit [103319] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-mac/Skipped: Skip failing and crashing tests to try to paint the bot green.
4:40 AM Changeset in webkit [103318] by jchaffraix@webkit.org
  • 3 edits
    2 adds in trunk

Crash in RenderTable::outerBorderAfter
​http://webkit.org/b/74026
<rdar://problem/10552313>

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/table/computeLogicalWidth-table-needsSectionRecalc.html

RenderBlock can call computeLogicalWidth() before calling layout(). The code in
RenderTable::computeLogicalWidth would make the assumption that layout() was called
as layout() is responsible for recomputing our sections.

To prevent the issue, let's just recompute the section if it's needed as this situation
shouldn't be an error. Also adding more knowledge of table in RenderBlock seems bad.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):
Make sure we recalculate our section if it's needed.

LayoutTests:

  • fast/table/computeLogicalWidth-table-needsSectionRecalc-expected.txt: Added.
  • fast/table/computeLogicalWidth-table-needsSectionRecalc.html: Added.
3:53 AM Changeset in webkit [103317] by jchaffraix@webkit.org
  • 7 edits in branches/chromium/963

Revert 99212 - Stop abusing RenderTableSection::needsRecalcCells logic
​https://bugs.webkit.org/show_bug.cgi?id=71420

Reviewed by Darin Adler.

Source/WebCore:

Change covered by existing tests like fast/repaint/table-extra-bottom-grow.html
and fast/table/row-height-recalc* (among others).

Cell recalculation is very expensive and should only be called when the section's structure
changed in a way that requires a safe update to its structure (like removing a row as our
column split may not be appropriate anymore).

The current code would abuse cell recalculation to actually reset the logical height on the
RowStruct. This change makes it do the right thing.

  • rendering/RenderTableCell.h:
  • rendering/RenderTableRow.h:

Removed styleWillChange override as it was unneeded.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleDidChange):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleDidChange):
Move the code from styleWillChange to styleDidChange.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::rowLogicalHeightChanged):
This function just reset the height on the |RowStruct| which is the
only part of recalcCells that we would need.

(WebCore::RenderTableSection::rowIndexForRenderer):
Added this function to find out which index a column has (strangely
RenderTableRow does not have this information).

  • rendering/RenderTableSection.h: Added the 2 previous functions.

LayoutTests:

  • platform/chromium-linux/fast/repaint/table-extra-bottom-grow-expected.png:

Update this test as this is a progression: we are not over-repainting the table
anymore.

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/qt/test_expectations.txt:

Skipped the test here as it needs a rebaseline.

TBR=​jchaffraix@webkit.org
Review URL: ​http://codereview.chromium.org/8989014

3:52 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Update Qt versions on the bots (diff)
3:49 AM Changeset in webkit [103316] by Simon Hausmann
  • 18 edits
    5 adds in trunk

[Qt][WK2] Implement favicon support
​https://bugs.webkit.org/show_bug.cgi?id=71082

Patch by Rafael Brandao <​rafael.lobo@openbossa.org> on 2011-12-20
Reviewed by Simon Hausmann.

.:

  • Source/qtwebkit-export.map: Added new classes.

Source/WebKit/qt:

  • declarative/plugin.cpp:

(WebKitQmlPlugin::initializeEngine): Setup for the QDeclarativeImageProvider to display favicons.
Its handles the following url format: "image://webicon/<iconID>#<pageURL>".

Source/WebKit2:

Added attribute to QQuickWebView named "icon" that should be used
as source for QQuickImage in order to display it. All images
pointing to it will refresh when the icon is ready. We also use IDs
to make it possible to handle different icons for the same page URL
at different times (i.e. dynamically changing favicon).

IconDatabase storage lies on UIProcess and the synchronous call for
the icon that happens on WebIconDatabase won't need to send any message
to WebProcess. The part of IconDatabase on WebProcess handles the download
of the resource whenever it is needed. Then the content downloaded is sent
through IPC to the actual database, on UIProcess.

  • Target.pri:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::_q_onIconChangedForPageURL):
(QQuickWebViewPrivate::setIcon):
(QQuickWebView::icon):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/API/qt/qwebiconimageprovider.cpp: Added.

(QWebIconImageProvider::QWebIconImageProvider):
(QWebIconImageProvider::~QWebIconImageProvider):
(QWebIconImageProvider::requestImage):

  • UIProcess/API/qt/qwebiconimageprovider_p.h: Added.
  • UIProcess/WebContext.h:
  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::synchronousIconURLForPageURL):
(WebKit::WebIconDatabase::imageForPageURL): Added iconSize parameter
and a default value for it to not break the old usage. The support for
multiple sizes of favicons is still missing on WebCore.

  • UIProcess/WebIconDatabase.h:
  • UIProcess/qt/QtWebContext.cpp:

(WebKit::QtWebContext::initialize):

  • UIProcess/qt/QtWebContext.h:

(WebKit::QtWebContext::iconDatabase):

  • UIProcess/qt/QtWebIconDatabaseClient.cpp: Added.

(toQtWebIconDatabaseClient):
(QtWebIconDatabaseClient::QtWebIconDatabaseClient):
(QtWebIconDatabaseClient::~QtWebIconDatabaseClient):
(QtWebIconDatabaseClient::didChangeIconForPageURL):
(QtWebIconDatabaseClient::iconImageForPageURL):
(QtWebIconDatabaseClient::iconURLHashForPageURL):
(QtWebIconDatabaseClient::requestIconForPageURL):
(QtWebIconDatabaseClient::retainIconForPageURL):
(QtWebIconDatabaseClient::releaseIconForPageURL):

  • UIProcess/qt/QtWebIconDatabaseClient.h: Added.
  • UIProcess/qt/QtWebPageLoadClient.cpp:

(QtWebPageLoadClient::didStartProgress):

Tools:

A favorite icon was added on MiniBrowser's url bar as example.
We display a default icon when the page doesn't have an icon ready.

  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/icons/favicon.png: Added.
  • MiniBrowser/qt/qml/BrowserWindow.qml:
3:48 AM clutter edited by kov@webkit.org
(diff)
3:44 AM Changeset in webkit [103315] by haraken@chromium.org
  • 8 edits in trunk/Source/WebCore

[Refactoring] Replace imp with impl in CodeGeneratorJS.pm
​https://bugs.webkit.org/show_bug.cgi?id=74901

Reviewed by Adam Barth.

As pointed out in bug 74837, the generated code by CodeGeneratorJS.pm includes
both 'imp' and 'impl'. This patch unifies them into 'impl'.
I confirmed that "perl -lne 'print if /imp[a-z]/' CodeGeneratorJS.pm" outputs nothing.

No new tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributeEventListenerCall):
(GenerateEventListenerCall):
(GenerateImplementation):
(GenerateParametersCheck):
(GenerateImplementationFunctionCall):
(NativeToJSValue):

  • bindings/scripts/test/JS/JSFloat64Array.cpp: Updated run-bindings-tests results.

(WebCore::jsFloat64ArrayPrototypeFunctionFoo):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::jsTestEventConstructorAttr1):
(WebCore::jsTestEventConstructorAttr2):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::jsTestInterfaceStr1):
(WebCore::jsTestInterfaceStr2):
(WebCore::jsTestInterfaceStr3):
(WebCore::setJSTestInterfaceStr2):
(WebCore::setJSTestInterfaceStr3):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjReadOnlyIntAttr):
(WebCore::jsTestObjReadOnlyStringAttr):
(WebCore::jsTestObjReadOnlyTestObjAttr):
(WebCore::jsTestObjShortAttr):
(WebCore::jsTestObjUnsignedShortAttr):
(WebCore::jsTestObjIntAttr):
(WebCore::jsTestObjLongLongAttr):
(WebCore::jsTestObjUnsignedLongLongAttr):
(WebCore::jsTestObjStringAttr):
(WebCore::jsTestObjTestObjAttr):
(WebCore::jsTestObjXMLObjAttr):
(WebCore::jsTestObjCreate):
(WebCore::jsTestObjReflectedStringAttr):
(WebCore::jsTestObjReflectedIntegralAttr):
(WebCore::jsTestObjReflectedUnsignedIntegralAttr):
(WebCore::jsTestObjReflectedBooleanAttr):
(WebCore::jsTestObjReflectedURLAttr):
(WebCore::jsTestObjReflectedNonEmptyURLAttr):
(WebCore::jsTestObjReflectedCustomIntegralAttr):
(WebCore::jsTestObjReflectedCustomBooleanAttr):
(WebCore::jsTestObjReflectedCustomURLAttr):
(WebCore::jsTestObjReflectedCustomNonEmptyURLAttr):
(WebCore::jsTestObjAttrWithGetterException):
(WebCore::jsTestObjAttrWithSetterException):
(WebCore::jsTestObjStringAttrWithGetterException):
(WebCore::jsTestObjStringAttrWithSetterException):
(WebCore::jsTestObjScriptStringAttr):
(WebCore::jsTestObjConditionalAttr1):
(WebCore::jsTestObjConditionalAttr2):
(WebCore::jsTestObjConditionalAttr3):
(WebCore::jsTestObjCachedAttribute1):
(WebCore::jsTestObjCachedAttribute2):
(WebCore::jsTestObjDescription):
(WebCore::jsTestObjId):
(WebCore::jsTestObjHash):
(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
(WebCore::setJSTestObjIntAttr):
(WebCore::setJSTestObjLongLongAttr):
(WebCore::setJSTestObjUnsignedLongLongAttr):
(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjTestObjAttr):
(WebCore::setJSTestObjXMLObjAttr):
(WebCore::setJSTestObjCreate):
(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedIntegralAttr):
(WebCore::setJSTestObjReflectedUnsignedIntegralAttr):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedNonEmptyURLAttr):
(WebCore::setJSTestObjReflectedCustomIntegralAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):
(WebCore::setJSTestObjReflectedCustomNonEmptyURLAttr):
(WebCore::setJSTestObjAttrWithGetterException):
(WebCore::setJSTestObjAttrWithSetterException):
(WebCore::setJSTestObjStringAttrWithGetterException):
(WebCore::setJSTestObjStringAttrWithSetterException):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):
(WebCore::setJSTestObjId):
(WebCore::jsTestObjPrototypeFunctionVoidMethod):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethod):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethod):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionMethodWithException):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrame):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoid):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObj):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContext):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod1):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod2):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::jsTestSerializedScriptValueInterfaceValue):

2:02 AM Changeset in webkit [103314] by pfeldman@chromium.org
  • 8 edits in trunk/Source/WebKit

Web Inspector: reproducible crash after closing web inspector and browser window (iCab)
​https://bugs.webkit.org/show_bug.cgi?id=74255

Patch by Pavel Feldman <​pavel.feldman@gmail.com> on 2011-12-20
Reviewed by Yury Semikhatsky.

Source/WebKit/cf:

  • WebCoreSupport/WebInspectorClientCF.cpp:

(WebInspectorClient::releaseFrontend):

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::bringFrontendToFront):
(-[WebInspectorWindowController destroyInspectorView:]):

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::~WebInspectorClient):
(WebInspectorFrontendClient::destroyInspectorView):

  • WebCoreSupport/WebInspectorClient.h:
1:45 AM Changeset in webkit [103313] by vsevik@chromium.org
  • 1 copy in branches/chromium/963/LayoutTests/platform/chromium/http/tests/inspector/network/script-as-text-loading-expected.txt

Merge 102930 - Unreviewed chromium test rebaseline.

  • platform/chromium/http/tests/inspector/network/script-as-text-loading-expected.txt: Added.

TBR=​vsevik@chromium.org
BUG=106164
Review URL: ​http://codereview.chromium.org/9006005

1:45 AM Changeset in webkit [103312] by vsevik@chromium.org
  • 2 edits
    3 copies in branches/chromium/963

Merge 102898 - Web Inspector: [Regression] Network manager fails to show resource type and MIME type in incorrect MIME type console message.
​https://bugs.webkit.org/show_bug.cgi?id=74516

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/network/script-as-text-loading.html

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):

LayoutTests:

  • http/tests/inspector/network/resources/script-as-text.php: Added.
  • http/tests/inspector/network/script-as-text-loading-expected.txt: Added.
  • http/tests/inspector/network/script-as-text-loading.html: Added.

TBR=​vsevik@chromium.org
BUG=106164
Review URL: ​http://codereview.chromium.org/9008007

1:41 AM Changeset in webkit [103311] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Make WebIntentServiceInfo constructor public for testing.
​https://bugs.webkit.org/show_bug.cgi?id=74764

Patch by Greg Billock <​gbillock@google.com> on 2011-12-20
Reviewed by Darin Fisher.

  • public/WebIntentServiceInfo.h:
12:56 AM Changeset in webkit [103310] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Qt] Improve QQuickWebView error handling API
​https://bugs.webkit.org/show_bug.cgi?id=73815

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2011-12-20
Reviewed by Simon Hausmann.

Modifying loadFail signal to include the error description
and changing the ErrorType enum to ErrorDomain, to stay aligned
with ResourceError API itself.

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml:
  • UIProcess/qt/QtWebPageLoadClient.cpp:

(QtWebPageLoadClient::dispatchLoadFailed):

12:39 AM Changeset in webkit [103309] by alokp@chromium.org
  • 4 edits in trunk/Source/WebCore

[chromium] compositing/shadows tests fail with accelerated painting
​https://bugs.webkit.org/show_bug.cgi?id=74871

Reviewed by James Robinson.

Switched over to new API for creating accelerated canvas GrContext::createPlatformTexture.
It correctly binds the stencil buffer to the FBO.

Test: compositing/shadows/shadow-drawing.html (existing)

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::createAcceleratedCanvas):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::allocate):
(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):

  • platform/graphics/chromium/ManagedTexture.h:
12:00 AM Changeset in webkit [103308] by loislo@chromium.org
  • 13 edits
    1 copy
    3 adds
    1 delete in trunk/Source/WebCore

Unreviewed, rolling out r103291.
​http://trac.webkit.org/changeset/103291
​https://bugs.webkit.org/show_bug.cgi?id=74915

Looks like it broke fast/events/touch and
fast/events/touch/gesture/gesture-scroll.html
​http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5/builds/7010
(Requested by loislo on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-20

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/chromium/ScrollAnimatorChromiumMac.h: Copied from Source/WebCore/platform/mac/ScrollAnimatorMac.h.

(WebCore::ScrollAnimatorChromiumMac::setIsDrawingIntoLayer):
(WebCore::ScrollAnimatorChromiumMac::isDrawingIntoLayer):
(WebCore::ScrollAnimatorChromiumMac::haveScrolledSincePageLoad):
(WebCore::ScrollAnimatorChromiumMac::setNeedsScrollerStyleUpdate):
(WebCore::ScrollAnimatorChromiumMac::needsScrollerStyleUpdate):

  • platform/chromium/ScrollAnimatorChromiumMac.mm: Added.

(-[NSProcessInfo systemUptime]):
(abs):
(-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollAnimationHelperDelegate scrollAnimatorDestroyed]):
(-[ScrollAnimationHelperDelegate bounds]):
(-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]):
(-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]):
(-[ScrollAnimationHelperDelegate convertSizeToBase:]):
(-[ScrollAnimationHelperDelegate convertSizeFromBase:]):
(-[ScrollAnimationHelperDelegate convertSizeToBacking:]):
(-[ScrollAnimationHelperDelegate convertSizeFromBacking:]):
(-[ScrollAnimationHelperDelegate superview]):
(-[ScrollAnimationHelperDelegate documentView]):
(-[ScrollAnimationHelperDelegate window]):
(-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]):
(-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]):
(-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPartAnimation setCurrentProgress:]):
(-[ScrollbarPartAnimation scrollAnimatorDestroyed]):
(-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollbarPainterDelegate cancelAnimations]):
(-[ScrollbarPainterDelegate convertRectToBacking:]):
(-[ScrollbarPainterDelegate convertRectFromBacking:]):
(-[ScrollbarPainterDelegate layer]):
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
(-[ScrollbarPainterDelegate scrollAnimatorDestroyed]):
(WebCore::ScrollAnimator::create):
(WebCore::chromiumScrollbarTheme):
(WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac):
(WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac):
(WebCore::ScrollAnimatorChromiumMac::scroll):
(WebCore::ScrollAnimatorChromiumMac::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorChromiumMac::adjustScrollXPositionIfNecessary):
(WebCore::ScrollAnimatorChromiumMac::adjustScrollYPositionIfNecessary):
(WebCore::ScrollAnimatorChromiumMac::adjustScrollPositionIfNecessary):
(WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY):
(WebCore::ScrollAnimatorChromiumMac::immediateScrollToPointForScrollAnimation):
(WebCore::ScrollAnimatorChromiumMac::notifyPositionChanged):
(WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorChromiumMac::willStartLiveResize):
(WebCore::ScrollAnimatorChromiumMac::contentsResized):
(WebCore::ScrollAnimatorChromiumMac::willEndLiveResize):
(WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow):
(WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide):
(WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture):
(WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorChromiumMac::cancelAnimations):
(WebCore::elasticDeltaForTimeDelta):
(WebCore::elasticDeltaForReboundDelta):
(WebCore::reboundDeltaForElasticDelta):
(WebCore::scrollWheelMultiplier):
(WebCore::isScrollingLeftAndShouldNotRubberBand):
(WebCore::isScrollingRightAndShouldNotRubberBand):
(WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
(WebCore::ScrollAnimatorChromiumMac::handleGestureEvent):
(WebCore::ScrollAnimatorChromiumMac::pinnedInDirection):
(WebCore::ScrollAnimatorChromiumMac::allowsVerticalStretching):
(WebCore::ScrollAnimatorChromiumMac::allowsHorizontalStretching):
(WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorChromiumMac::beginScrollGesture):
(WebCore::ScrollAnimatorChromiumMac::endScrollGesture):
(WebCore::ScrollAnimatorChromiumMac::snapRubberBand):
(WebCore::roundTowardZero):
(WebCore::roundToDevicePixelTowardZero):
(WebCore::ScrollAnimatorChromiumMac::snapRubberBandTimerFired):
(WebCore::ScrollAnimatorChromiumMac::setIsActive):
(WebCore::ScrollAnimatorChromiumMac::updateScrollerStyle):
(WebCore::ScrollAnimatorChromiumMac::startScrollbarPaintTimer):
(WebCore::ScrollAnimatorChromiumMac::scrollbarPaintTimerIsActive):
(WebCore::ScrollAnimatorChromiumMac::stopScrollbarPaintTimer):
(WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):
(WebCore::ScrollAnimatorChromiumMac::setVisibleScrollerThumbRect):

  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h: Added.
  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm: Added.

(lookUpNSScrollerImpClass):
(lookUpNSScrollerImpPairClass):
(scrollbarControlSizeToNSControlSize):
(preferredScrollerStyle):
(wkScrollbarPainterUsesOverlayScrollers):
(wkScrollbarPainterIsHorizontal):
(wkScrollbarPainterKnobAlpha):
(wkScrollbarPainterSetOverlayState):
(wkScrollbarPainterPaint):
(wkScrollbarPainterPaintTrack):
(wkScrollbarPainterPaintKnob):
(wkScrollbarMinimumThumbLength):
(wkScrollbarPainterSetDelegate):
(wkScrollbarPainterSetEnabled):
(wkScrollbarPainterTrackAlpha):
(wkMakeScrollbarPainter):
(wkScrollbarThickness):
(wkScrollbarMinimumTotalLengthNeededForThumb):
(wkVerticalScrollbarPainterForController):
(wkHorizontalScrollbarPainterForController):
(wkScrollbarPainterControllerStyle):
(wkMakeScrollbarReplacementPainter):
(wkSetPainterForPainterController):
(wkSetScrollbarPainterControllerStyle):
(wkScrollbarPainterKnobRect):
(wkSetScrollbarPainterKnobAlpha):
(wkSetScrollbarPainterTrackAlpha):
(wkSetScrollbarPainterKnobStyle):
(wkMakeScrollbarPainterController):
(wkContentAreaScrolled):
(wkContentAreaWillPaint):
(wkMouseEnteredContentArea):
(wkMouseExitedContentArea):
(wkMouseMovedInContentArea):
(wkWillStartLiveResize):
(wkContentAreaResized):
(wkWillEndLiveResize):
(wkContentAreaDidShow):
(wkContentAreaDidHide):
(wkDidBeginScrollGesture):
(wkDidEndScrollGesture):
(wkScrollbarPainterForceFlashScrollers):
(isScrollbarOverlayAPIAvailable):

  • platform/chromium/ScrollbarThemeChromiumMac.h:

(WebCore::ScrollbarThemeChromiumMac::supportsControlTints):
(WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::scrollbarMap):
(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(+[ScrollbarPrefsObserver behaviorPrefsChanged:]):
(+[ScrollbarPrefsObserver registerAsObserver]):
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
(WebCore::ScrollbarThemeChromiumMac::unregisterScrollbar):
(WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
(WebCore::ScrollbarThemeChromiumMac::painterForScrollbar):
(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::ScrollbarThemeChromiumMac::preferencesChanged):
(WebCore::ScrollbarThemeChromiumMac::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumMac::usesOverlayScrollbars):
(WebCore::toScrollbarPainterKnobStyle):
(WebCore::ScrollbarThemeChromiumMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeChromiumMac::initialAutoscrollTimerDelay):
(WebCore::ScrollbarThemeChromiumMac::autoscrollTimerDelay):
(WebCore::ScrollbarThemeChromiumMac::buttonsPlacement):
(WebCore::ScrollbarThemeChromiumMac::hasButtons):
(WebCore::ScrollbarThemeChromiumMac::hasThumb):
(WebCore::buttonRepaintRect):
(WebCore::ScrollbarThemeChromiumMac::backButtonRect):
(WebCore::ScrollbarThemeChromiumMac::forwardButtonRect):
(WebCore::ScrollbarThemeChromiumMac::trackRect):
(WebCore::ScrollbarThemeChromiumMac::minimumThumbLength):
(WebCore::ScrollbarThemeChromiumMac::shouldCenterOnThumb):
(WebCore::ScrollbarThemeChromiumMac::shouldDragDocumentInsteadOfThumb):
(WebCore::scrollbarPartToHIPressedState):
(WebCore::ScrollbarThemeChromiumMac::updateEnabledState):
(WebCore::ScrollbarThemeChromiumMac::paint):

  • platform/mac/EmptyProtocolDefinitions.h:
  • platform/mac/NSScrollerImpDetails.h:
  • platform/mac/NSScrollerImpDetails.mm: Removed.
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate layer]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::cancelAnimations):
(WebCore::ScrollAnimatorMac::setIsActive):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):

  • platform/mac/ScrollElasticityController.h:
  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

(+[WebScrollbarPrefsObserver appearancePrefsChanged:]):
(+[WebScrollbarPrefsObserver behaviorPrefsChanged:]):
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeMac::hasButtons):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::scrollbarPartToHIPressedState):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::ScrollbarThemeMac::paint):

Note: See TracTimeline for information about the timeline view.