⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 24, 2011:

5:09 PM Changeset in webkit [103666] by mitz@apple.com
  • 1355 edits in trunk/LayoutTests/platform

Set the svn:mime-type property of some PNG files to image/png

2:49 PM Changeset in webkit [103665] by Darin Adler
  • 2 edits in trunk/Source/JavaScriptCore

Specialize HashTraits for RefPtr to use PassRefPtr as "pass type" to reduce reference count churn
​https://bugs.webkit.org/show_bug.cgi?id=72476

Reviewed by Sam Weinig.

  • wtf/HashTraits.h: Defined PassInType and store function in HashTraits<RefPtr>.
2:08 PM Changeset in webkit [103664] by kling@webkit.org
  • 5 edits in trunk/Source/WebCore

CSSElementStyleDeclarations should never move between elements.
<​http://webkit.org/b/75198>

Reviewed by Anders Carlsson.

Have the CSSElementStyleDeclaration subclasses take a StyledElement* in
the constructor and replace setElement(StyledElement*) by clearElement().

No behavior change, just enforcing the current behavior at compile-time.

  • css/CSSElementStyleDeclaration.h:

(WebCore::CSSElementStyleDeclaration::clearElement):
(WebCore::CSSElementStyleDeclaration::CSSElementStyleDeclaration):

  • css/CSSInlineStyleDeclaration.h:

(WebCore::CSSInlineStyleDeclaration::create):
(WebCore::CSSInlineStyleDeclaration::CSSInlineStyleDeclaration):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):

  • svg/SVGFontFaceElement.cpp:

(WebCore::FontFaceStyleDeclaration::FontFaceStyleDeclaration):

1:24 PM Changeset in webkit [103663] by kling@webkit.org
  • 12 edits in trunk/Source/WebCore

Decouple CSSMappedAttributeDeclaration from element completely.
<​http://webkit.org/b/75187>

Reviewed by Darin Adler.

Let CSSMappedAttributeDeclaration inherit from CSSMutableDeclaration instead
of CSSElementStyleDeclaration. Add methods to CSSMappedAttributeDeclaration
for setting properties that also take a StyledElement* and use that mechanism
instead of temporarily associating an element with the declaration.

This reduces the size of mapped attributes by 4/8 bytes, but more importantly
opens a number of ways to simplify style declarations in future patches.

  • css/CSSMutableStyleDeclaration.h:
  • dom/CSSMappedAttributeDeclaration.cpp:

(WebCore::CSSMappedAttributeDeclaration::setNeedsStyleRecalc):
(WebCore::CSSMappedAttributeDeclaration::setMappedImageProperty):
(WebCore::CSSMappedAttributeDeclaration::setMappedLengthProperty):
(WebCore::CSSMappedAttributeDeclaration::setMappedProperty):
(WebCore::CSSMappedAttributeDeclaration::removeMappedProperty):

  • dom/CSSMappedAttributeDeclaration.h:

(WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):

Add/move methods to CSSMappedAttributeDeclaration for setting/removing
properties that also take a StyledElement*. That element is used for
scheduling style recalc and passing the right document to CSSParser.

  • css/CSSParser.h:
  • css/CSSParser.cpp:

(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseMappedAttributeValue):

Added a parsedMappedAttributeValue() alternative to parseValue() that
takes a StyledElement*.

  • dom/StyledElement.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::setContentEditable):

Add (and use) a StyledElement::removeCSSProperty() complement to the
addCSS*() functions.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::removeCSSProperty):
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):
(WebCore::StyledElement::addCSSLength):
(WebCore::StyledElement::addCSSColor):
(WebCore::StyledElement::createMappedDecl):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedCellPaddingDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):

Use the setMapped*Property() functions to plumb the element through.

  • css/CSSElementStyleDeclaration.h:

Update comment about CSSElementStyleDeclaration's subclasses.

1:01 PM Changeset in webkit [103662] by mitz@apple.com
  • 2 edits in trunk/Tools

Set SHARED_PRECOMPS_DIR when Xcode is set to use a custom build product path.

Reviewed by Anders Carlsson.

  • Scripts/webkitdirs.pm:

(determineBaseProductDir):

12:29 PM Changeset in webkit [103661] by jarred@sencha.com
  • 3 edits
    2 adds in trunk

Allow XMLHttpRequest withCredentials to be set prior to a call to open()
​https://bugs.webkit.org/show_bug.cgi?id=75194

Source/WebCore:

XMLHttpRequest.withCredentials attribute should be modifiable prior to the OPENED state per
the W3C spec. See ​http://dvcs.w3.org/hg/xhr/raw-file/tip/Overview.html#the-withcredentials-attribute

Reviewed by Alexey Proskuryakov.

Test: fast/xmlhttprequest/xmlhttprequest-withcredentials-before-open.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::setWithCredentials):
Prevent setting the value only after the OPENED state.

LayoutTests:

Reviewed by Alexey Proskuryakov.

  • fast/xmlhttprequest/xmlhttprequest-withcredentials-before-open-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-withcredentials-before-open.html: Added.

Validate that XMLHttpRequest.withCredentials can be set prior to a call to open().

12:15 PM Changeset in webkit [103660] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove empty inline RenderStyle destructor.
<​http://webkit.org/b/75188>

Rubber-stamped by Anders "Ordvits" Carlsson.

  • rendering/style/RenderStyle.h:
11:30 AM Changeset in webkit [103659] by mitz@apple.com
  • 2 edits in trunk/Tools

Make build-webkit aware of additional Xcode build location defaults.

Reviewed by Anders Carlsson.

  • Scripts/webkitdirs.pm:

(determineXcodeVersion): Added. This was previously in determineBaseProductDir().
(readXcodeUserDefault): Added. Factored out from determineBaseProductDir().
(determineBaseProductDir): Changed to check for a custom build location
style specified as an absolute location.

11:26 AM Changeset in webkit [103658] by rniwa@webkit.org
  • 20 edits
    1 copy
    1 add
    1 delete in trunk

Unreviewed, rolling out r103619.
​http://trac.webkit.org/changeset/103619
​https://bugs.webkit.org/show_bug.cgi?id=66509

Broke chromium clang build

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebCommonWorkerClient.h:

(WebKit::WebCommonWorkerClient::postConsoleMessageToWorkerObject):
(WebKit::WebCommonWorkerClient::allowFileSystem):
(WebKit::WebCommonWorkerClient::openFileSystem):
(WebKit::WebCommonWorkerClient::dispatchDevToolsMessage):
(WebKit::WebCommonWorkerClient::saveDevToolsAgentState):
(WebKit::WebCommonWorkerClient::~WebCommonWorkerClient):

  • public/WebSharedWorker.h:
  • public/WebSharedWorkerClient.h: Removed.
  • public/WebWorkerClient.h:

(WebKit::WebWorkerClient::~WebWorkerClient):

  • src/DatabaseObserver.cpp:

(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::openFromWorker):

  • src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::client):
(WebKit::WebSharedWorker::create):

  • src/WebSharedWorkerImpl.h:

(WebKit::WebSharedWorkerImpl::commonClient):
(WebKit::WebSharedWorkerImpl::newCommonClient):

  • src/WebWorkerBase.cpp:

(WebKit::initializeWebKitStaticValues):
(WebKit::WebWorkerBase::WebWorkerBase):
(WebKit::WebWorkerBase::~WebWorkerBase):
(WebKit::WebWorkerBase::stopWorkerThread):
(WebKit::WebWorkerBase::initializeLoader):
(WebKit::WebWorkerBase::dispatchTaskToMainThread):
(WebKit::WebWorkerBase::invokeTaskMethod):
(WebKit::WebWorkerBase::didCreateDataSource):
(WebKit::WebWorkerBase::createApplicationCacheHost):
(WebKit::WebWorkerBase::postMessageToWorkerObject):
(WebKit::WebWorkerBase::postMessageTask):
(WebKit::WebWorkerBase::postExceptionToWorkerObject):
(WebKit::WebWorkerBase::postExceptionTask):
(WebKit::WebWorkerBase::postConsoleMessageToWorkerObject):
(WebKit::WebWorkerBase::postConsoleMessageTask):
(WebKit::WebWorkerBase::postMessageToPageInspector):
(WebKit::WebWorkerBase::postMessageToPageInspectorTask):
(WebKit::WebWorkerBase::updateInspectorStateCookie):
(WebKit::WebWorkerBase::updateInspectorStateCookieTask):
(WebKit::WebWorkerBase::confirmMessageFromWorkerObject):
(WebKit::WebWorkerBase::confirmMessageTask):
(WebKit::WebWorkerBase::reportPendingActivity):
(WebKit::WebWorkerBase::reportPendingActivityTask):
(WebKit::WebWorkerBase::workerContextClosed):
(WebKit::WebWorkerBase::workerContextClosedTask):
(WebKit::WebWorkerBase::workerContextDestroyed):
(WebKit::WebWorkerBase::workerContextDestroyedTask):
(WebKit::WebWorkerBase::postTaskToLoader):
(WebKit::WebWorkerBase::postTaskForModeToWorkerContext):

  • src/WebWorkerBase.h:

(WebKit::WebWorkerBase::view):
(WebKit::WebWorkerBase::setWorkerThread):
(WebKit::WebWorkerBase::workerThread):

  • src/WebWorkerClientImpl.cpp:
  • src/WebWorkerClientImpl.h:

(WebKit::WebWorkerClientImpl::newCommonClient):

  • src/WebWorkerImpl.cpp: Added.

(WebKit::WebWorker::create):
(WebKit::WebWorkerImpl::WebWorkerImpl):
(WebKit::WebWorkerImpl::~WebWorkerImpl):
(WebKit::WebWorkerImpl::newCommonClient):
(WebKit::WebWorkerImpl::commonClient):
(WebKit::WebWorkerImpl::postMessageToWorkerContextTask):
(WebKit::WebWorkerImpl::startWorkerContext):
(WebKit::WebWorkerImpl::terminateWorkerContext):
(WebKit::WebWorkerImpl::postMessageToWorkerContext):
(WebKit::WebWorkerImpl::workerObjectDestroyed):
(WebKit::WebWorkerImpl::clientDestroyed):

  • src/WebWorkerImpl.h: Copied from Source/WebKit/chromium/src/WebWorkerBase.cpp.

(WebKit::WebWorkerImpl::client):

  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):

  • src/WorkerFileSystemCallbacksBridge.h:

Tools:

  • DumpRenderTree/chromium/TestWebWorker.h:

(TestWebWorker::createWorker):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createWorker):

  • DumpRenderTree/chromium/WebViewHost.h:
10:53 AM Changeset in webkit [103657] by rniwa@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Chromium CG Mac rebaseline after r103651.

  • platform/chromium-cg-mac-snowleopard/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Added.
  • platform/chromium/test_expectations.txt:
10:32 AM Changeset in webkit [103656] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

RenderStyle: Inline the destructor.
<​http://webkit.org/b/75188>

Reviewed by Kenneth Rohde Christiansen.

The (empty) RenderStyle destructor gets a little hot sometimes, reaching up
to 0.4% when loading the full HTML5 spec. Inline it to remove the pointless
function call.

  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::~RenderStyle):

7:52 AM Changeset in webkit [103655] by jarred@sencha.com
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed test result gardening.

  • platform/chromium/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt: Removed.

Identical to the expected result shared by all ports.

1:07 AM Changeset in webkit [103654] by rniwa@webkit.org
  • 2 edits
    1 add
    2 deletes in trunk/LayoutTests

Another rebaseline for font-weight-bold-for-b-and-strong.html.
Also revert a part of r103645.

  • platform/chromium-linux-x86/fast/html: Removed.
  • platform/chromium-linux/fast/html/font-weight-bold-for-b-and-strong-expected.png: Added.
  • platform/chromium/fast/html: Removed.
  • platform/chromium/fast/html/font-weight-bold-for-b-and-strong-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:

Dec 23, 2011:

11:06 PM Changeset in webkit [103653] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add image test expectation for fast/images/ycbcr-with-cmyk-color-profile.html on Chromium.
The test started failing since r103651.

  • platform/chromium/test_expectations.txt:
10:12 PM Changeset in webkit [103652] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

Chromium Mac build fix.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

9:45 PM Changeset in webkit [103651] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

JPEG decoders should only save color profile markers if color management is enabled
​https://bugs.webkit.org/show_bug.cgi?id=75182

Reviewed by Adam Barth.

No new tests. Covered by existing tests.

fast/images/ycbcr-with-cmyk-color-profile.html
fast/images/gray-scale-jpeg-with-color-profile.html
fast/images/cmyk-jpeg-with-color-profile.html
fast/images/color-jpeg-with-color-profile.html

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageReader::JPEGImageReader): Store color profile (JPEG_APP0 + 2) markers
using the iccjpeg helper setup_read_icc_profile() if color management is enabled.

9:41 PM Changeset in webkit [103650] by aboxhall@chromium.org
  • 3 edits
    2 adds in trunk

Fix crash when adding paragraph in contenteditable with role=textbox.
​https://bugs.webkit.org/show_bug.cgi?id=75159

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: accessibility/textbox-role-on-contenteditable-crash.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::childrenChanged): Use rendererIsEditable() rather than isContentEditable()
as this method is called during render layouts, and isContentEditable() triggers a layout update, which crashes.

LayoutTests:

  • accessibility/textbox-role-on-contenteditable-crash-expected.txt: Added.
  • accessibility/textbox-role-on-contenteditable-crash.html: Added.
9:35 PM Changeset in webkit [103649] by rniwa@webkit.org
  • 2 edits
    1 copy in trunk/LayoutTests

Mac rebaseline after r103468.

  • platform/mac/fast/html/font-weight-bold-for-b-and-strong-expected.png:
  • platform/mac/fast/html/font-weight-bold-for-b-and-strong-expected.txt:
9:08 PM Changeset in webkit [103648] by noel.gordon@gmail.com
  • 3 edits
    5 adds in trunk

[chromium] JPEG image with CMYK ICC color profile renders color-inverted and squashed
​https://bugs.webkit.org/show_bug.cgi?id=74400

Reviewed by Adam Barth.

Source/WebCore:

Use color profiles for GRAYSCALE, RGB, YCbCr, CMYK and YCCK jpeg images only if their
embedded color profile is from an RGB color space input device.

Test:

fast/images/ycbcr-with-cmyk-color-profile.html

  • YCbCr image, with CMYK output device color profile.

Existing Tests:

fast/images/gray-scale-jpeg-with-color-profile.html

  • YCbCr image, with GRAY input device color profile.

fast/images/cmyk-jpeg-with-color-profile.html

  • YCCK image, with CMYK output device color profile.

fast/images/color-jpeg-with-color-profile.html

  • YCbCr image, with RGB input device color profile.
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::rgbColorProfile): Return true if the profile has an RGB color space.
(WebCore::inputDeviceColorProfile): Return true if the profile is from an input device.
(WebCore::readColorProfile): Ignore the embedded color profile unless if it is from
an RGB color space input device.
(WebCore::JPEGImageReader::decode):

LayoutTests:

  • fast/images/resources/ycbcr-with-cmyk-color-profile.jpg: Added.
  • fast/images/resources/ycbcr-with-no-color-profile.jpg: Added.
  • fast/images/ycbcr-with-cmyk-color-profile-expected.txt: Added.
  • fast/images/ycbcr-with-cmyk-color-profile.html: Added.
  • platform/mac/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Added.
8:35 PM Changeset in webkit [103647] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Print dlerror() when dyld functions fail unexpectedly
​https://bugs.webkit.org/show_bug.cgi?id=75185

Reviewed by Sam Weinig.

  • platform/mac/SoftLinking.h:
8:11 PM Changeset in webkit [103646] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Skip 10 CanPlayType W3C audio / video tests imported in r103470.
The failure is tracked by the bug 75184.

  • platform/mac/Skipped:
7:59 PM Changeset in webkit [103645] by rniwa@webkit.org
  • 2 edits
    11 adds
    2 deletes in trunk/LayoutTests

Chromium rebaseline for font-weight-bold-for-b-and-strong.html.

Also remove crash expectations for the bug 74788 since these tests are no longer asserting.

  • fast/html/font-weight-bold-for-b-and-strong-expected.txt: Removed.
  • platform/chromium-cg-mac-leopard/fast/html/font-weight-bold-for-b-and-strong-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/html: Added.
  • platform/chromium-cg-mac-snowleopard/fast/html/font-weight-bold-for-b-and-strong-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/font-weight-bold-for-b-and-strong-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/html: Added.
  • platform/chromium-mac-snowleopard/fast/html/font-weight-bold-for-b-and-strong-expected.png: Added.
  • platform/chromium-win-vista/fast/html: Removed.
  • platform/chromium-win/fast/html/font-weight-bold-for-b-and-strong-expected.png: Added.
  • platform/chromium-win/fast/html/font-weight-bold-for-b-and-strong-expected.txt: Added.
  • platform/chromium/fast/html: Added.
  • platform/chromium/fast/html/font-weight-bold-for-b-and-strong-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/html/font-weight-bold-for-b-and-strong-expected.txt: Added.
7:48 PM Changeset in webkit [103644] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

Mac rebaselines after r102471 and r102968.

  • fast/dom/constructed-objects-prototypes-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
7:45 PM Changeset in webkit [103643] by weinig@apple.com
  • 32 edits
    2 adds
    2 deletes in trunk/Source

Start extracting platform specific bits out of PlatformEvents
​https://bugs.webkit.org/show_bug.cgi?id=75063

Reviewed by Anders Carlsson.

Source/WebCore:

  • WebCore.exp.in:

Update exports.

  • WebCore.xcodeproj/project.pbxproj:

Add factory, remove implementation files for mac PlatformWheelEvent
and PlatformMouseEvent.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::wheelEvent):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::currentPlatformMouseEvent):
Switch to use the factory.

  • platform/PlatformEvent.h:

(WebCore::PlatformEvent::shiftKey):
(WebCore::PlatformEvent::ctrlKey):
(WebCore::PlatformEvent::altKey):
(WebCore::PlatformEvent::metaKey):
(WebCore::PlatformEvent::modifiers):
(WebCore::PlatformEvent::PlatformEvent):
Switch to storing the modifiers as bits on an unsigned
instead of as individual bools.

  • platform/PlatformGestureEvent.h:

Remove unused timestamp member.

  • platform/PlatformKeyboardEvent.h:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
(WebCore::PlatformKeyboardEvent::keyIdentifier):
(WebCore::PlatformKeyboardEvent::macCharCode):
(WebCore::PlatformKeyboardEvent::isSystemKey):
Give this class a more consistent interface across platforms,
and remove constructor that took an NSEvent.

  • platform/PlatformMouseEvent.h:

Remove constructor that took an NSEvent (and an unused constructor that took
many arguments) as well as some free functions for point conversion.

  • platform/PlatformWheelEvent.h:

Remove constructor that took an NSEvent and an unnecessary override of the timestamp()
function.

  • platform/mac/KeyEventMac.mm:

Removed constructor and moved helpers to PlatformEventFactory.

  • platform/mac/PlatformEventFactory.h: Added.
  • platform/mac/PlatformEventFactory.mm: Added.

(WebCore::globalPoint):
(WebCore::globalPointForEvent):
(WebCore::pointForEvent):
(WebCore::mouseButtonForEvent):
(WebCore::mouseEventTypeForEvent):
(WebCore::clickCountForEvent):
(WebCore::momentumPhaseForEvent):
(WebCore::phaseForEvent):
(WebCore::gestureEventTypeForEvent):
(WebCore::textFromEvent):
(WebCore::unmodifiedTextFromEvent):
(WebCore::keyIdentifierForKeyEvent):
(WebCore::isKeypadEvent):
(WebCore::windowsKeyCodeForKeyEvent):
(WebCore::isKeyUpEvent):
(WebCore::modifiersForEvent):
(WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
(WebCore::PlatformEventFactory::createPlatformMouseEvent):
(WebCore::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebCore::PlatformEventFactory::createPlatformWheelEvent):
(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
(WebCore::PlatformEventFactory::createPlatformKeyboardEvent):
(WebCore::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
(WebCore::PlatformEventFactory::createPlatformGestureEvent):
Consolidate platform event creation logic and add factory functions.

  • platform/mac/PlatformMouseEventMac.mm: Removed.
  • platform/mac/WheelEventMac.mm: Removed.
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Expose wkGetNSEventKeyChar in WebCore.

  • platform/gtk/PlatformKeyboardEventGtk.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

  • platform/gtk/PlatformMouseEventGtk.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

  • platform/gtk/PlatformWheelEventGtk.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

  • platform/qt/PlatformKeyboardEventQt.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

  • platform/qt/PlatformMouseEventQt.cpp:

(WebCore::mouseEventModifiersFromQtKeyboardModifiers):
(WebCore::PlatformMouseEvent::PlatformMouseEvent):

  • platform/qt/PlatformTouchEventQt.cpp:

(WebCore::PlatformTouchEvent::PlatformTouchEvent):

  • platform/win/KeyEventWin.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

  • platform/win/WheelEventWin.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):
Update for new variables/names.

Source/WebKit/chromium:

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
(WebKit::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
(WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

  • WebView/WebFrame.mm:
  • WebView/WebHTMLView.mm:

(-[WebHTMLView menuForEvent:]):
(-[WebHTMLView acceptsFirstMouse:]):
(-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
(currentKeyboardEvent):
(-[WebHTMLView flagsChanged:]):

  • WebView/WebPDFView.mm:

(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

  • WebView/WebView.mm:

Source/WebKit2:

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):
(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
(WebKit::WebKit2PlatformKeyboardEvent::WebKit2PlatformKeyboardEvent):
(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent):
(WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent):

  • UIProcess/API/mac/WKView.mm:
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

7:33 PM Changeset in webkit [103642] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Chromium Chromium DEPS from 115012 to 115743.

  • DEPS:
4:04 PM Changeset in webkit [103641] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Inlined Yarr::execute
​https://bugs.webkit.org/show_bug.cgi?id=75180

Reviewed reluctantly by Beth Dakin.

Tiny speedup on SunSpider string tests. Removes some samples from
Instruments. A step toward removing -fomit-frame-pointer.

  • yarr/YarrJIT.cpp:
  • yarr/YarrJIT.h:

(JSC::Yarr::execute): ONE LINE FUNCTION, Y U NOT INLINED?!

3:47 PM Changeset in webkit [103640] by dbates@webkit.org
  • 10 edits in trunk/Tools

Provide option to disable Mac OS 10.7 application resume when using
{debug, run}-{safari, minibrowser, test-runner, test-webkit-api}, and run-webkit-app
​https://bugs.webkit.org/show_bug.cgi?id=66902

Reviewed by David Kilzer.

Add an optional command line argument --no-saved-state to disable
application resume (state restoration) for the session on Mac OS 10.7.

For instance, when debugging an issue in Safari it is useful to be able
to temporarily disable application resume. Currently you can disable
application resume when launching Safari from within Xcode. We should
expose a similar option in our command line tools.

  • Scripts/debug-minibrowser: Call printHelpAndExitForRunAndDebugWebKitAppIfNeeded()

to print a help message and exit() if the command line argument --help was given.

  • Scripts/debug-safari: Ditto.
  • Scripts/debug-test-runner: Ditto.
  • Scripts/run-minibrowser: Ditto.
  • Scripts/run-safari: Ditto.
  • Scripts/run-test-runner: Ditto.
  • Scripts/run-test-webkit-api: Ditto.
  • Scripts/run-webkit-app: Ditto.
  • Scripts/webkitdirs.pm:

(printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Added.
(argumentsForRunAndDebugMacWebKitApp): Added.
(runMacWebKitApp): If the --no-saved-state command line argument was given then
disable application resume for the session.
(execMacWebKitAppForDebugging): Ditto.

2:33 PM Changeset in webkit [103639] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

CSSParser: Avoid creating dummy declaration in parseColor() slow path.
<​http://webkit.org/b/75104>

Patch by Andreas Kling <​kling@webkit.org> on 2011-12-22
Reviewed by Darin Adler.

We only needed the dummy declaration to trigger the instantiation of
a CSSValuePool. Added an ensureCSSValuePool() method and have parseColor()
call that instead.

Also renamed the fast-path parseColor() to fastParseColor() and reordered
the arguments for consistency with the slow-path parseColor().

  • css/CSSParser.cpp:

(WebCore::parseColorValue):
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::ensureCSSValuePool):
(WebCore::CSSParser::fastParseColor):
(WebCore::CSSParser::parseColorFromValue):

  • css/CSSParser.h:
1:36 PM Changeset in webkit [103638] by kling@webkit.org
  • 17 edits in trunk/Source/WebCore

Automate elements' registration as document namedItem/extraNamedItem.
<​http://webkit.org/b/74991>

Patch by Andreas Kling <​kling@webkit.org> on 2011-12-21
Reviewed by Antti Koivisto.

Remove caching of the "id" and "name" attributes on applet, embed, form,
image and object elements. We were caching them to keep the document's
map of named and "extra named" (named by id) item counts in sync.

Instead, add a hook to Element::willModifyAttribute() that detects when
the attributes are being changed and handle the registration/unregistration
automatically if the element returns true for shouldRegisterAsNamedItem()
or shouldRegisterAsExtraNamedItem() respectively.

This shrinks the elements by two AtomicStrings (8 or 16 bytes) each.

IFrame elements retain the old mechanism for now, as there are some subtle
differences to how that's handled.

  • dom/Node.h:

(WebCore::Node::hasName):
(WebCore::Node::setHasName):

Cache whether we have a "name" attribute or not (1 bit on Node.)
This is done in order to minimize the overhead added to Element's
insertedIntoDocument() and removeFromDocument().

  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):

Update the Node's has-name flag as appropriate.

  • dom/Element.cpp:

(WebCore::Element::updateNamedItemRegistration):
(WebCore::Element::updateExtraNamedItemRegistration):

Added. Called when the "name" and "id" attributes are changed.
Updates the document's named item maps accordingly.

(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):

Make sure updateName() is called in addition to updateId() when applicable.

  • dom/Element.h:

(WebCore::Element::shouldRegisterAsNamedItem):
(WebCore::Element::shouldRegisterAsExtraNamedItem):

Added. If an element returns true for these, it will be automatically
registered with the document when the name/id attribute changes.

(WebCore::Element::updateId):
(WebCore::Element::updateName):

Register/unregister from the document's named item maps as appropriate.

(WebCore::Element::willModifyAttribute):

Add updateName() hook in addition to the existing updateId() hook.

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setAttributes):

Make sure updateName() is called when we're cloning the attributes
from another element.

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::parseMappedAttribute):

  • html/HTMLAppletElement.h:
  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::parseMappedAttribute):
(WebCore::HTMLEmbedElement::insertedIntoDocument):

  • html/HTMLEmbedElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::insertedIntoDocument):
(WebCore::HTMLFormElement::removedFromDocument):
(WebCore::HTMLFormElement::parseMappedAttribute):

  • html/HTMLFormElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseMappedAttribute):
(WebCore::HTMLImageElement::insertedIntoDocument):

  • html/HTMLImageElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute):
(WebCore::HTMLObjectElement::insertedIntoDocument):
(WebCore::HTMLObjectElement::removedFromDocument):

  • html/HTMLObjectElement.h:
  • html/HTMLPlugInElement.h:

Remove duplicated code that is now handled by Element.

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem):
(WebCore::HTMLObjectElement::formControlName):

Use fastGetAttribute() since we no longer cache the name.

1:08 PM Changeset in webkit [103637] by fpizlo@apple.com
  • 9 edits
    2 copies
    4 adds in trunk

DFG loads from signed 8-bit and 16-bit typed arrays are broken
​https://bugs.webkit.org/show_bug.cgi?id=75163

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Added 8-bit and 16-bit signed loads. Because doing so on ARM is less trivial, I'm
currently disabling Int8Array and Int16Array optimizations on ARM.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::load8Signed):
(JSC::MacroAssemblerX86Common::load16Signed):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::movswl_mr):
(JSC::X86Assembler::movsbl_mr):

  • bytecode/PredictedType.h:

(JSC::isActionableMutableArrayPrediction):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateInt8Array):
(JSC::DFG::Node::shouldSpeculateInt16Array):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):

LayoutTests:

Reviewed by Geoffrey Garen.

Fixed some minor goofs in the previously comitted typed array tests, and added
new ones to cover this bug.

  • fast/js/dfg-int16array-expected.txt: Added.
  • fast/js/dfg-int16array.html: Added.
  • fast/js/dfg-int8array-expected.txt: Added.
  • fast/js/dfg-int8array.html: Added.
  • fast/js/script-tests/dfg-float32array.js:

(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):

  • fast/js/script-tests/dfg-int16array.js: Added.

(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):

  • fast/js/script-tests/dfg-int32array.js:

(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):

  • fast/js/script-tests/dfg-int8array.js: Added.

(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):

1:05 PM Changeset in webkit [103636] by fpizlo@apple.com
  • 5 edits
    6 adds in trunk

DFG does double-to-int conversion incorrectly when storing into int typed arrays
​https://bugs.webkit.org/show_bug.cgi?id=75164
<rdar://problem/10557547>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::branchTruncateDoubleToUint32):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branchTruncateDoubleToUint32):
(JSC::MacroAssemblerX86Common::truncateDoubleToUint32):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

LayoutTests:

  • fast/js/dfg-int32array-overflow-values-expected.txt: Added.
  • fast/js/dfg-int32array-overflow-values.html: Added.
  • fast/js/dfg-uint32array-overflow-values-expected.txt: Added.
  • fast/js/dfg-uint32array-overflow-values.html: Added.
  • fast/js/script-tests/dfg-int32array-overflow-values.js: Added.

(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):

  • fast/js/script-tests/dfg-uint32array-overflow-values.js: Added.

(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):

11:01 AM Changeset in webkit [103635] by kubo@profusion.mobi
  • 2 edits in trunk/Source/WebKit/efl

Unreviewed; fix build with ENABLE(NETSCAPE_PLUGIN_API).

  • ewk/ewk_js.cpp: Include ewk_logging.h for ERR().
10:18 AM Changeset in webkit [103634] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Add two (currently unused) new member functions to ScrollElasticityControllerClient
​https://bugs.webkit.org/show_bug.cgi?id=75179

Reviewed by Dan Bernstein.

This is so we'll be able to move more code to ScrollElasticityController.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::pinnedInDirection):
(WebCore::ScrollAnimatorMac::immediateScrollByWithoutContentEdgeConstraints):

  • platform/mac/ScrollElasticityController.h:
9:34 AM Changeset in webkit [103633] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[Mac] fast/events/autoscroll-should-not-stop-on-keypress.html fails
​https://bugs.webkit.org/show_bug.cgi?id=74538

Patch by Rakesh KN <​rakesh.kn@motorola.com> on 2011-12-23
Reviewed by Alexey Proskuryakov.

  • fast/events/autoscroll-should-not-stop-on-keypress-expected.txt:
  • fast/events/autoscroll-should-not-stop-on-keypress.html:

Modified test to use iframe for testing autoscroll.

  • platform/mac/Skipped:

Removed this test entry.

9:18 AM Changeset in webkit [103632] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Update the test result (whitespace difference).

  • css3/filters/custom-filter-property-parsing-invalid-expected.txt:
9:01 AM Changeset in webkit [103631] by Simon Fraser
  • 4 edits
    3 adds in trunk

Blur filter doesn't invalidate enough
​https://bugs.webkit.org/show_bug.cgi?id=74891

Source/WebCore:

Reviewed by Darin Adler.

Take the effects of filters into account for repainting; we need
to inflate the repaint rect by the outsets provided by the filter.

Test: css3/filters/filter-repaint.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::computeRectForRepaint):

LayoutTests:

Reviewed by Darin Adler.

Repaint test for the effects of a blur filter.

  • css3/filters/filter-repaint-expected.txt: Added.
  • css3/filters/filter-repaint-expected.png: Added.
  • css3/filters/filter-repaint.html: Added.
8:56 AM Changeset in webkit [103630] by Simon Fraser
  • 4 edits
    3 adds in trunk

Filters should apply to inline elements
​https://bugs.webkit.org/show_bug.cgi?id=75152

Source/WebCore:

Reviewed by Darin Adler.

Filters need to cause creation of RenderLayers for inlines, just like
opacity and masks do.

Test: css3/filters/filtered-inline.html

  • rendering/RenderInline.h:

(WebCore::RenderInline::requiresLayer):

  • rendering/RenderTableRow.h: Remove an obviously incorrect comment.

LayoutTests:

Reviewed by Darin Adler.

Test for filter on an inline.

  • css3/filters/filtered-inline-expected.png: Added.
  • css3/filters/filtered-inline-expected.txt: Added.
  • css3/filters/filtered-inline.html: Added.
8:36 AM Changeset in webkit [103629] by jarred@sencha.com
  • 3 edits
    2 adds in trunk

Synchronous XHR in window context should not support new XHR responseTypes for HTTP(S) requests
​https://bugs.webkit.org/show_bug.cgi?id=72154

Source/WebCore:

Per the latest W3C editor draft: ​http://dvcs.w3.org/hg/xhr/raw-file/tip/Overview.html
This is a spec-mandated attempt to thwart and otherwise discourage the use of synchronous XHR
in the window context by deliberately not exposing newer functionality. Here we are disabling
the use of responseType in synchronous HTTP(S) XHR requests from the window context.

When a user attempts this action, an InvalidAccessError exception is thrown and a message is
printed to the console to further explain.

Renamed reportUnsafeUsage to a more generic name, and hoisted it up so it would be defined
earlier and thus referenceable by setResponseType.

Reviewed by Alexey Proskuryakov.

Test: fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request.html

  • xml/XMLHttpRequest.cpp:

(WebCore::logConsoleError):
reportUnsafeUsage -> logConsoleError
(WebCore::XMLHttpRequest::setResponseType):
(WebCore::XMLHttpRequest::setRequestHeader):
reportUnsafeUsage -> logConsoleError
(WebCore::XMLHttpRequest::getResponseHeader):
reportUnsafeUsage -> logConsoleError
(WebCore::XMLHttpRequest::didFail):
reportUnsafeUsage -> logConsoleError

LayoutTests:

New tests that validate synchronous HTTP(S) XHR requests from the window context
cannot use responseType, while other protocols continue to work.

Reviewed by Alexey Proskuryakov.

  • fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request.html: Added.
7:53 AM Changeset in webkit [103628] by loislo@chromium.org
  • 2 edits
    2 moves in trunk/LayoutTests

Unreviewed rebaseline.

  • platform/chromium-gpu/media/video-colorspace-yuv420-expected.png: Renamed from LayoutTests/platform/chromium-gpu-mac/media/video-colorspace-yuv420-expected.png.
  • platform/chromium-gpu/media/video-colorspace-yuv422-expected.png: Renamed from LayoutTests/platform/chromium-gpu-mac/media/video-colorspace-yuv422-expected.png.
  • platform/chromium/test_expectations.txt:
7:40 AM Changeset in webkit [103627] by apavlov@chromium.org
  • 5 edits
    2 adds in trunk

Web Inspector: Implement a worker for parsing out JavaScript function data
​https://bugs.webkit.org/show_bug.cgi?id=75166

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/script-extract-outline.html

  • inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.prototype.formatContent):

  • inspector/front-end/ScriptFormatterWorker.js:

(onmessage):
(format):
(getChunkCount):
():
(Array.prototype.keySet):

LayoutTests:

  • inspector/debugger/script-extract-outline-expected.txt: Added.
  • inspector/debugger/script-extract-outline.html: Added.
  • inspector/debugger/script-formatter.html:
7:38 AM Changeset in webkit [103626] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Refactored String.prototype.replace
​https://bugs.webkit.org/show_bug.cgi?id=75114

Reviewed by Darin Adler.

No performance difference.

I think this is a step toward removing -fomit-frame-pointer.

  • runtime/JSString.cpp:
  • runtime/JSString.h: Removed the test and special case for a single-character

search string because the standard path does this test and special case
for us. (As an aside, if we do come up with a unique single-character
replace optimization in future, it probably belongs in the replace function,
and not in JSString.)

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace): Split this mega-sized function into:
(JSC::replaceUsingStringSearch): - This reasonably sized function, and
(JSC::replaceUsingRegExpSearch): - This still mega-sized function.

7:35 AM Changeset in webkit [103625] by loislo@chromium.org
  • 16 edits
    1 add in trunk

Unreviewed, rolling out r103624.
​http://trac.webkit.org/changeset/103624
​https://bugs.webkit.org/show_bug.cgi?id=68916

Broke Snow Leopard builders

Source/WebCore:

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDirectoryEntryCustom.cpp:

(WebCore::JSDirectoryEntry::getFile):
(WebCore::JSDirectoryEntry::getDirectory):

  • bindings/js/JSDirectoryEntrySyncCustom.cpp:

(WebCore::getFlags):

  • bindings/v8/custom/V8DirectoryEntryCustom.cpp:

(WebCore::V8DirectoryEntry::getDirectoryCallback):
(WebCore::V8DirectoryEntry::getFileCallback):

  • bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:

(WebCore::getFlags):

  • fileapi/WebKitFlags.idl: Added.
  • page/DOMWindow.idl:
  • workers/WorkerContext.idl:

LayoutTests:

  • fast/filesystem/flags-passing-expected.txt:
  • fast/filesystem/script-tests/flags-passing.js:

(runNextTest):
(runObjectTest):
(runObjectTestWithExclusive):

5:23 AM Changeset in webkit [103624] by ericu@chromium.org
  • 16 edits
    1 delete in trunk

[fileapi] WebKitFlags should not be constructable per Directories & System spec
​https://bugs.webkit.org/show_bug.cgi?id=68916

Reviewed by Eric Seidel.

Source/WebCore:

Remove IDL for the object and all DOM references to it.

  • fileapi/WebKitFlags.idl: Removed.
  • page/DOMWindow.idl:
  • workers/WorkerContext.idl: Remove references to the JSC/V8 objects compiled from the IDL.
  • bindings/js/JSDirectoryEntryCustom.cpp: (WebCore::JSDirectoryEntry::getFile): (WebCore::JSDirectoryEntry::getDirectory):
  • bindings/js/JSDirectoryEntrySyncCustom.cpp: (WebCore::getFlags):
  • bindings/v8/custom/V8DirectoryEntryCustom.cpp: (WebCore::V8DirectoryEntry::getDirectoryCallback): (WebCore::V8DirectoryEntry::getFileCallback):
  • bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp: (WebCore::getFlags): Fix up build files.
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCore/CMakeLists.txt:
  • WebCore/CodeGenerators.pri:
  • WebCore/DerivedSources.cpp:
  • WebCore/GNUmakefile.list.am:

LayoutTests:

Remove a test that constructed the object; add one that tests error-handling for non-object parameters while I'm in there.

  • fast/filesystem/flags-passing-expected.txt:
  • fast/filesystem/script-tests/flags-passing.js:
5:16 AM Changeset in webkit [103623] by pfeldman@chromium.org
  • 16 edits in trunk/Source/WebCore

Web Inspector: Migrate to native Function.prototype.bind; fix front-end compilation with the
version of compiler that respects Function.prototype.bind.
​https://bugs.webkit.org/show_bug.cgi?id=75170

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ApplicationCacheModel.js:
  • inspector/front-end/CSSKeywordCompletions.js:

(WebInspector.CSSKeywordCompletions.colors):

  • inspector/front-end/CSSStyleModel.js:
  • inspector/front-end/CompilerSourceMapping.js:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype.pushNodeToFrontend):
(WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
(WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable.onDocumentAvailable):
(WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable):
(WebInspector.DOMAgent.prototype._loadNodeAttributes):
(WebInspector.DOMAgent.prototype.querySelector):
(WebInspector.DOMAgent.prototype.querySelectorAll):

  • inspector/front-end/DebuggerModel.js:
  • inspector/front-end/DebuggerPresentationModel.js:
  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.InspectorExtensionAPI):
(injectedExtensionAPI):

  • inspector/front-end/ExtensionPanel.js:
  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.prototype.enableResourceTracking):
(WebInspector.NetworkManager.prototype.disableResourceTracking):

  • inspector/front-end/Script.js:
  • inspector/front-end/Settings.js:
  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.complete):

  • inspector/front-end/utilities.js:
4:49 AM Changeset in webkit [103622] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Add the BlackBerry specific pauseLoad(bool) to ResourceHandle
​https://bugs.webkit.org/show_bug.cgi?id=75162

Reviewed by George Staikos.

The porting can be built now, no new tests so far.

  • platform/network/ResourceHandle.h:
4:05 AM Changeset in webkit [103621] by noel.gordon@gmail.com
  • 2 edits
    5 adds in trunk/LayoutTests

[chromium] MAC: should pass CSS3 elliptical gradient tests
​https://bugs.webkit.org/show_bug.cgi?id=56736

Reviewed by Stephen White.

Skia on mac draws ellipsoids on OSX 10.5 and 10.6 making these tests pass. Rebaseline
the results, restrict the test failures to the Chromium CG port (CPU-CG).

  • platform/chromium-mac-snowleopard/fast/gradients/css3-radial-gradients-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-radial-gradients2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-radial-gradients3-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-repeating-radial-gradients-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:45 AM Changeset in webkit [103620] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk

Give embedders a chance to handle postMessage calls
​https://bugs.webkit.org/show_bug.cgi?id=73883

Source/WebCore:

To support cross-process postMessage calls in Chromium (bug 73337), we need to intercept
postMessage calls to proxy windows. Originally we were just going to add a native event
listener on the Chromium side, but that required more changes to WebKit and was a bit of
a hack. See bug 73359 for a discuss about moving to this approach.

Patch by Karl Koscher <​supersat@chromium.org> on 2011-12-23
Reviewed by Adam Barth.

Test: platform/chromium/fast/events/intercept-postmessage.html

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::willCheckAndDispatchPostMessage): new method to allow the

embedder to intercept postMessage calls

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessageTimerFired): add a call to

FrameLoaderClient::willCheckAndDispatchPostMessage

Source/WebKit/chromium:

Patch by Karl Koscher <​supersat@chromium.org> on 2011-12-23
Reviewed by Adam Barth.

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::willCheckAndDispatchMessageEvent):

interface to give the embedder a chance to handle this postMessage call

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::willCheckAndDispatchMessageEvent): Call

willCheckAndDispatchMessageEvent on WebFrameClient

  • src/FrameLoaderClientImpl.h:
2:59 AM Changeset in webkit [103619] by dslomov@google.com
  • 20 edits
    1 copy
    2 deletes in trunk

Source/WebKit/chromium: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
​https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:

  • WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  • NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  • WebWorkerBase merged into WebSharedWorkerImpl
  • NewWebWorkerBase renamed into WebWorkerBase

WebWorkerClient.h has a "#define WebWorkerClient WebSharedWorkerClient" to keep chromium building.
Will be removed after coordinated patch in chromium.

Reviewed by David Levin.

  • WebKit.gyp:
  • public/WebCommonWorkerClient.h:
  • public/WebSharedWorker.h:
  • public/WebSharedWorkerClient.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.

(WebKit::WebSharedWorkerClient::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerClient::allowFileSystem):
(WebKit::WebSharedWorkerClient::openFileSystem):
(WebKit::WebSharedWorkerClient::dispatchDevToolsMessage):
(WebKit::WebSharedWorkerClient::saveDevToolsAgentState):
(WebKit::WebSharedWorkerClient::~WebSharedWorkerClient):

  • public/WebWorkerClient.h:
  • src/DatabaseObserver.cpp:

(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::openFromWorker):

  • src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::initializeWebKitStaticValues):
(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::stopWorkerThread):
(WebKit::WebSharedWorkerImpl::initializeLoader):
(WebKit::WebSharedWorkerImpl::didCreateDataSource):
(WebKit::WebSharedWorkerImpl::createApplicationCacheHost):
(WebKit::WebSharedWorkerImpl::postMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postMessageTask):
(WebKit::WebSharedWorkerImpl::postExceptionToWorkerObject):
(WebKit::WebSharedWorkerImpl::postExceptionTask):
(WebKit::WebSharedWorkerImpl::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postConsoleMessageTask):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspector):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspectorTask):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookie):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookieTask):
(WebKit::WebSharedWorkerImpl::confirmMessageFromWorkerObject):
(WebKit::WebSharedWorkerImpl::confirmMessageTask):
(WebKit::WebSharedWorkerImpl::reportPendingActivity):
(WebKit::WebSharedWorkerImpl::reportPendingActivityTask):
(WebKit::WebSharedWorkerImpl::workerContextClosed):
(WebKit::WebSharedWorkerImpl::workerContextClosedTask):
(WebKit::WebSharedWorkerImpl::workerContextDestroyed):
(WebKit::WebSharedWorkerImpl::workerContextDestroyedTask):
(WebKit::WebSharedWorkerImpl::postTaskToLoader):
(WebKit::WebSharedWorkerImpl::postTaskForModeToWorkerContext):
(WebKit::WebSharedWorker::create):

  • src/WebSharedWorkerImpl.h:

(WebKit::WebSharedWorkerImpl::view):
(WebKit::WebSharedWorkerImpl::commonClient):
(WebKit::WebSharedWorkerImpl::client):
(WebKit::WebSharedWorkerImpl::setWorkerThread):
(WebKit::WebSharedWorkerImpl::workerThread):

  • src/WebWorkerBase.cpp:

(WebKit::invokeTaskMethod):
(WebKit::WebWorkerBase::dispatchTaskToMainThread):

  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.cpp:
  • src/WebWorkerClientImpl.h:

(WebKit::WebWorkerClientImpl::commonClient):

  • src/WebWorkerImpl.cpp: Removed.
  • src/WebWorkerImpl.h: Removed.
  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):

  • src/WorkerFileSystemCallbacksBridge.h:

Tools: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
​https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:

  • WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  • NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  • WebWorkerBase merged into WebSharedWorkerImpl
  • NewWebWorkerBase renamed into WebWorkerBase

Reviewed by David Levin.

  • DumpRenderTree/chromium/TestWebWorker.h:

(TestWebWorker::createWorker):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createWorker):

  • DumpRenderTree/chromium/WebViewHost.h:
2:54 AM Changeset in webkit [103618] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] fast/canvas/canvas-largedraws.html crashes with newer Qt5
​https://bugs.webkit.org/show_bug.cgi?id=75167

  • platform/qt-5.0/Skipped: Skip the crashing test to paint the bots green.
2:40 AM Changeset in webkit [103617] by tsepez@chromium.org
  • 5 edits
    3 adds in trunk

XSLT-created HTML documents do not inherit content-security-policy from originally loaded XML.
​https://bugs.webkit.org/show_bug.cgi?id=75043

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/contentSecurityPolicy/xsl-img-blocked.php

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::copyStateFrom):
(WebCore::ContentSecurityPolicy::didReceiveHeader):

  • page/ContentSecurityPolicy.h:
  • xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::createDocumentFromSource):

LayoutTests:

  • http/tests/security/contentSecurityPolicy/resources/transform-to-img.xsl: Added.
  • http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/xsl-img-blocked.php: Added.
2:20 AM Changeset in webkit [103616] by Darin Adler
  • 2 edits in trunk/Source/WebCore

REGRESSION (r97533): Optgroup label is not disabled
​https://bugs.webkit.org/show_bug.cgi?id=74869

Reviewed by Alexey Proskuryakov.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::itemIsEnabled): Added back a line of code that was
accidentally deleted as part of the refactoring in r97533. This line of code
ensures that any items that are not option elements are disabled.

2:06 AM Changeset in webkit [103615] by apavlov@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Add CSSStyleSelector instrumentation calls towards implementing a CSS selector profiler
​https://bugs.webkit.org/show_bug.cgi?id=74863

Performance checks run on PerformanceTest/Parser/html5-full-render.html did not result in any noticeable
perf regression, as the instrumentation calls are inline and bail out early if there are no
Web Inspector frontends open.

Reviewed by Antti Koivisto.

No new tests, as the functionality is not bound to any user-visible outputs.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::CSSStyleSelector::applyDeclaration):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willMatchRuleImpl):
(WebCore::InspectorInstrumentation::didMatchRuleImpl):
(WebCore::InspectorInstrumentation::willProcessRuleImpl):
(WebCore::InspectorInstrumentation::didProcessRuleImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willMatchRule):
(WebCore::InspectorInstrumentation::didMatchRule):
(WebCore::InspectorInstrumentation::willProcessRule):
(WebCore::InspectorInstrumentation::didProcessRule):

2:05 AM Changeset in webkit [103614] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Fix building with Glib support disabled
​https://bugs.webkit.org/show_bug.cgi?id=70990

Patch by Ivan Briano <​ivan@profusion.mobi> on 2011-12-23
Reviewed by Martin Robinson.

Add forward declaration for cairo_surface_t, missing when building
the EFL port with Glib disabled.

  • platform/cairo/WidgetBackingStore.h:
1:58 AM Changeset in webkit [103613] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed upstream expectations.

  • platform/chromium/test_expectations.txt:

BUGRNIWA GPU-CG : media/video-colorspace-yuv420.html = IMAGE
BUGRNIWA GPU-CG : media/video-colorspace-yuv422.html = IMAGE

1:52 AM Changeset in webkit [103612] by bbudge@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Add unit tests for AssociatedURLLoader to check redirect handling and
cross-origin access control.
​https://bugs.webkit.org/show_bug.cgi?id=74952

Reviewed by Adam Barth.

  • tests/AssociatedURLLoaderTest.cpp:
1:12 AM Changeset in webkit [103611] by adamk@chromium.org
  • 9 edits in trunk

Minimize callsites and duplication of before/after advice for attribute mutations
​https://bugs.webkit.org/show_bug.cgi?id=75054

Reviewed by Ryosuke Niwa.

Source/WebCore:

r103452 helpfully made before and after advice regarding attribute
changes symmetrical. This change finishes that work, by pulling
together all the before/after work, not just the crumbs previously
covered. This includes incrementing Document::domTreeVersion()
when an attribute is about to be changed, Inspector instrumentation,
and MutationEvent dispatch. This is in addition to the previous code,
which handled enqueueing MutationRecords for MutationObservers and
updating the Document's list of IDs.

The only change in behavior should be in InspectorInstrumentation,
which causes DOM breakpoints to occur for more cases of Attribute
mutation. This seems like more correct behavior, and a test has
been included to exercise it.

Hopefully the last Attribute-related refactor for awhile.

  • dom/Attr.cpp:

(WebCore::Attr::setValue): Update to call didModifyAttribute instead
of attributeChanged.

  • dom/Element.cpp:

(WebCore::Element::removeAttribute): Got rid of
removeAttributeInternal as most of that logic moved back into
NamedNodeMap::removeAttribute.
(WebCore::Element::setAttributeInternal): Reorganized to read better
now that only some cases result in calls to will/didModifyAttribute.
(WebCore::Element::willModifyAttribute): Un-inlined and added
incDOMTreeVersion and InspectorInstrumentation calls.
(WebCore::Element::didModifyAttribute): New method which encapsulates
calling attributeChanged, InspectorInstrumentation, and MutationEvents.
(WebCore::Element::didRemoveAttribute): New method which encapsulates
calling attributeChanged, InspectorInstrumentation, and MutationEvents.
Separate from didModifyAttribute because it has special handling of
the removed Attribute's value.

  • dom/Element.h:

(WebCore::Element::willRemoveAttribute): New method which delegates to
willModifyAttribute as appropriate.

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setNamedItem): Simplified.
(WebCore::NamedNodeMap::removeNamedItem): Simplified.
(WebCore::NamedNodeMap::addAttribute): Added calls to will/didModifyAttribute.
(WebCore::NamedNodeMap::removeAttribute): ditto.
(WebCore::NamedNodeMap::replaceAttribute): ditto.

  • svg/properties/SVGAnimatedPropertySynchronizer.h: Reverted changes

made in r103452 now that addAttribute/removeAttribute once again
call attributeChanged appropriately.

LayoutTests:

  • inspector/debugger/dom-breakpoints.html: Add tests for breakpoints

due to mutation of Attr nodes/NamedNodeLists.

  • platform/chromium/inspector/debugger/dom-breakpoints-expected.txt:
12:32 AM Changeset in webkit [103610] by pierre.rossi@gmail.com
  • 4 edits in trunk

[Qt] REGRESSION(r103467): It broke fast/images/animated-gif-restored-from-bfcache.html
​https://bugs.webkit.org/show_bug.cgi?id=75087

Source/JavaScriptCore:

monotonicallyIncreasingTime needs to hava a higher resolution than milliseconds.

Reviewed by Darin Adler.

  • wtf/CurrentTime.cpp:

(WTF::monotonicallyIncreasingTime):

LayoutTests:

Unskipping the offending test.

Reviewed by Darin Adler.

  • platform/qt/Skipped:
12:18 AM Changeset in webkit [103609] by haraken@chromium.org
  • 2 edits in trunk/Tools

Let parser_unittests.pl call different language parsers
​https://bugs.webkit.org/show_bug.cgi?id=75081

Reviewed by David Kilzer.

We introduced parser_unittests.pl in bug 74994 , but it is implemented
to always call get_function_line_ranges_for_perl(). In order to enable unittests
for other languages, this patch lets parser_unittests.pl call different language
parsers depending on the languages.

Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl

  • Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
Note: See TracTimeline for information about the timeline view.