Timeline
Dec 26, 2011:
- 11:30 PM Changeset in webkit [103702] by
-
- 6 edits in trunk/Source/WebCore
[EFL][WK2] Implement context menu for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=74995
Reviewed by Anders Carlsson.
Implement missing ContextMenuEfl class in order to support WK2's context menu.
Because WK2's context menu still needs WebCore's context menu implementation.
And of course, this patch also can be used for WK1 without CROSS_PLATFORM_CONTEXT_MENU
option.
- platform/ContextMenu.h:
- platform/ContextMenuItem.h:
- platform/PlatformMenuDescription.h:
- platform/efl/ContextMenuEfl.cpp:
(WebCore::ContextMenu::~ContextMenu):
(WebCore::ContextMenu::appendItem):
(WebCore::ContextMenu::insertItem):
(WebCore::ContextMenu::itemCount):
(WebCore::ContextMenu::setPlatformDescription):
(WebCore::ContextMenu::platformDescription):
(WebCore::ContextMenu::releasePlatformDescription):
(WebCore::platformMenuDescription):
(WebCore::contextMenuItemVector):
- platform/efl/ContextMenuItemEfl.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::~ContextMenuItem):
(WebCore::ContextMenuItem::setType):
(WebCore::ContextMenuItem::type):
(WebCore::ContextMenuItem::setAction):
(WebCore::ContextMenuItem::action):
(WebCore::ContextMenuItem::setTitle):
(WebCore::ContextMenuItem::title):
(WebCore::ContextMenuItem::setChecked):
(WebCore::ContextMenuItem::checked):
(WebCore::ContextMenuItem::setEnabled):
(WebCore::ContextMenuItem::enabled):
- 11:12 PM Changeset in webkit [103701] by
-
- 3 edits in trunk/Source/WebCore
[Refactoring] Node::setTreeScopeRecursively() doesn't need includeRoot parameter
https://bugs.webkit.org/show_bug.cgi?id=75240
Reviewed by Anders Carlsson.
No new tests. No behavior change.
- dom/Node.cpp:
(WebCore::Node::setTreeScopeRecursively):
- dom/Node.h:
- 10:27 PM Changeset in webkit [103700] by
-
- 2 edits in trunk/Source/WebKit2
<http://webkit.org/b/75196> REGRESSION(r103643): Command-clicking a link no longer opens a new tab.
r103643 contained some botched copy-paste code that caused the state of the Command key
to be lost when translating from a WebKit2 event to a WebCore event.
Reviewed by Dan Bernstein.
- Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent): Test for the correct modifier.
(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent): Ditto.
(WebKit::WebKit2PlatformKeyboardEvent::WebKit2PlatformKeyboardEvent): Ditto.
(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent): Ditto.
(WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent): Ditto.
- 10:14 PM Changeset in webkit [103699] by
-
- 2 edits in trunk/Source/JavaScriptCore
Errk! OS X build fix.
- JavaScriptCore.exp:
- 9:09 PM Changeset in webkit [103698] by
-
- 3 edits in trunk/Source/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- runtime/JSObject.h:
- 8:56 PM Changeset in webkit [103697] by
-
- 11 edits3 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=75231
Fail to throw in strict mode on assign to read only static properties
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
There are three bugs here:
- symbolTablePut should throw for strict mode accesses.
- lookupPut should throw for strict mode accesses.
- NumberConstructor should override put to call lookupPut, to trap assignment to readonly properties.
- runtime/JSActivation.cpp:
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::put):
- runtime/JSActivation.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::put):
- runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::put):
- runtime/JSVariableObject.h:
(JSC::JSVariableObject::symbolTablePut):
- runtime/Lookup.h:
(JSC::lookupPut):
- runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::put):
- runtime/NumberConstructor.h:
LayoutTests:
Added test cases / updated now-passing results.
- fast/js/mozilla/strict/15.10.7-expected.txt:
- fast/js/script-tests/strict-readonly-statics.js: Added.
(testWindowUndefined):
(testNumberMAX_VALUE):
- fast/js/strict-readonly-statics-expected.txt: Added.
- fast/js/strict-readonly-statics.html: Added.
- 8:38 PM Changeset in webkit [103696] by
-
- 6 edits in trunk/Source/WebKit/efl
[EFL] Last parameter of ewk_view_scroll is always true.
https://bugs.webkit.org/show_bug.cgi?id=75157
Reviewed by Andreas Kling.
Remove unnecessary parameter in ewk_view_scroll and related code, because
it's always true and ewk_view_tile can scroll when it is only true.
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::scroll):
- ewk/ewk_private.h:
- ewk/ewk_view.cpp:
(_ewk_view_scroll_add):
(ewk_view_scroll):
- ewk/ewk_view.h:
- ewk/ewk_view_tiled.cpp:
(_ewk_view_tiled_smart_scrolls_process):
- 7:39 PM Changeset in webkit [103695] by
-
- 2 edits in trunk/LayoutTests
Update Chromium test expectations.
- platform/chromium/test_expectations.txt:
- 7:15 PM Changeset in webkit [103694] by
-
- 2 edits in trunk/LayoutTests
Unreviewed mac/test_expectations.txt update.
- bidi-override-in-anonymous-block.html
- platform/mac/test_expectations.txt:
- 7:07 PM Changeset in webkit [103693] by
-
- 2 edits in trunk/LayoutTests
Unreviewed mac/test_expectations.txt update.
- platform/mac/test_expectations.txt:
- 1:45 PM Changeset in webkit [103692] by
-
- 10 edits in trunk/Source/WebCore
Use OwnPtr and OwnArrayPtr in a couple more places
https://bugs.webkit.org/show_bug.cgi?id=75211
Reviewed by Andreas Kling.
I had a patch with some changes from a while back from going through all sorts of
classes and changing code to use adoptPtr. Most were landed long ago, these are the
ones that still apply.
There are six pieces here that could each be landed separately.
The big one is CSSParser.
- css/CSSGrammar.y: Update for members and functions that now
return PassOwnPtr instead of raw pointers.
- css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser): Remove explicit construction
for m_valueList and m_data since OwnPtr and OwnArrayPtr initialize
to zero without it.
(WebCore::CSSParser::~CSSParser): Removed delete m_valueList and
fastFree(m_data) since OwnPtr and OwnArrayPtr handle that.
(WebCore::CSSParser::setupParser): Use adoptArrayPtr and new for
the character array instead of fastFree/fastMalloc. Added get
function calls as needed.
(WebCore::CSSParser::parseValue): Added get function calls as needed.
(WebCore::CSSParser::parseContent): Ditto.
(WebCore::CSSParser::parseFillProperty): Ditto.
(WebCore::CSSParser::parseTransformOriginShorthand): Ditto.
(WebCore::CSSParser::parseBorderImage): Ditto.
(WebCore::CSSParser::parseTransformOrigin): Ditto.
(WebCore::CSSParser::parsePerspectiveOrigin): Ditto.
(WebCore::CSSParser::sinkFloatingValueList): Changed to return PassOwnPtr.
The adoptPtr call is here.
(WebCore::CSSParser::sinkFloatingFunction): Ditto.
(WebCore::CSSParser::markSelectorListStart): Added get function calls as needed.
(WebCore::CSSParser::markSelectorListEnd): Ditto.
(WebCore::CSSParser::markRuleBodyStart): Ditto.
(WebCore::CSSParser::markRuleBodyEnd): Ditto.
(WebCore::CSSParser::markPropertyStart): Ditto.
(WebCore::CSSParser::markPropertyEnd): Ditto.
- css/CSSParser.h: Moved conditional includes to their own paragraph.
Made sinkFloatingValueList and sinkFloatingFunction return PassOwnPtr.
Made m_valueList an OwnPtr and m_data an OwnArrayPtr.
- css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue): Added a call to the get function.
- html/PluginDocument.h: Made isPluginDocument private. Also marked all the
functions that are overriding here as OVERRIDE since I was touching the header.
- html/parser/HTMLToken.h:
(WebCore::HTMLTokenTypes::DoctypeData::DoctypeData): Removed an unneeded line
explicitly initializing the base class.
- page/animation/AnimationBase.cpp:
(WebCore::RefCountedPropertyWrapper::RefCountedPropertyWrapper): Fixed indent.
- rendering/style/RenderStyle.h: Moved conditional includes to their own paragraph.
- xml/parser/MarkupTokenBase.h:
(WebCore::MarkupTokenBase::beginDOCTYPE): Removed unneeded parentheses.
- 11:55 AM Changeset in webkit [103691] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix miss-commit of utf8 change.
Reviewed by Filip Pizlo
Eeep, patch as landed a while ago had no effect! - acidentally landed
modified version of patch used for performance testing.
(This isn't covered by layout tests because layour tests don't use jsc,
and the tests/mozilla tests use latin1, which was already supported!)
Landing changes as intended (and as originally reviewed).
- jsc.cpp:
(jscSource):
- 11:47 AM Changeset in webkit [103690] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Extract FileEditor from ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=75229
Reviewed by Pavel Feldman.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.suggestedFileName):
- inspector/front-end/ScriptsNavigator.js:
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype.get visibleView):
(WebInspector.ScriptsPanel.prototype._updateScriptViewStatusBarItems):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced.get if):
(WebInspector.ScriptsPanel.EditorContainer):
(WebInspector.ScriptsPanel.EditorContainer.prototype.get currentSourceFrame):
(WebInspector.ScriptsPanel.EditorContainer.prototype.show):
(WebInspector.ScriptsPanel.EditorContainer.prototype.showSourceFrame):
(WebInspector.ScriptsPanel.EditorContainer.prototype.isSourceFrameOpen):
(WebInspector.ScriptsPanel.EditorContainer.prototype.replaceSourceFrames):
(WebInspector.ScriptsPanel.EditorContainer.prototype.setSourceFrameIsDirty):
(WebInspector.ScriptsPanel.EditorContainer.prototype.reset):
(WebInspector.ScriptsPanel.SingleFileEditorContainer):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.get currentSourceFrame):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.show):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.showSourceFrame):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.isSourceFrameOpen):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.replaceSourceFrames):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.setSourceFrameIsDirty):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.reset):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.get domain):
(WebInspector.UISourceCode.prototype.get folderName):
(WebInspector.UISourceCode.prototype.get fileName):
(WebInspector.UISourceCode.prototype.get displayName):
(WebInspector.UISourceCode.prototype._parseURL):
- 10:13 AM Changeset in webkit [103689] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix for ARMv7.
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load16Signed):
(JSC::MacroAssemblerARMv7::load8Signed):
- 8:40 AM Changeset in webkit [103688] by
-
- 3 edits in trunk/Source/JavaScriptCore
Rename WTF_INLINE, JS_INLINE to HIDDEN_INLINE
https://bugs.webkit.org/show_bug.cgi?id=74990
Reviewed by Kevin Ollivier.
- runtime/JSExportMacros.h: Removed JS_INLINE
- wtf/ExportMacros.h: Renamed WTF_INLINE to HIDDEN_INLINE
- 8:34 AM Changeset in webkit [103687] by
-
- 1 edit2 adds in trunk/LayoutTests
Check in expected failures for a couple of tests.
- platform/mac/media/video-colorspace-yuv420-expected.txt: Added.
- platform/mac/media/video-colorspace-yuv422-expected.txt: Added.
- 7:58 AM Changeset in webkit [103686] by
-
- 2 edits in trunk/Source/WebKit2
Fix a crash in WebProcess when starting a download not initiated by a WebPage
https://bugs.webkit.org/show_bug.cgi?id=75225
Reviewed by Darin Adler.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::downloadRequest): Check initiatingPage is not
NULL before using it.
- 7:21 AM Changeset in webkit [103685] by
-
- 2 edits in trunk/Source/WebCore
Fix mutation observer build after didMoveToNewDocument change
https://bugs.webkit.org/show_bug.cgi?id=75224
Reviewed by Hajime Morita.
- dom/Node.cpp:
(WebCore::willCallDidMoveToNewDocument): Added.
(WebCore::didMoveToNewDocumentWasCalled): Added.
(WebCore::Node::setDocument): Call new debugging function.
(WebCore::Node::didMoveToNewDocument): Ditto. Also use ASSERT_UNUSED
unconditionally rather than UNUSED_PARAM inside and #if. Also added
a new assertion that checks that hte old document was passed through
properly.
- 6:59 AM Changeset in webkit [103684] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Scripts] Implement iterative match highlighting in the "Go to Function" dialog item list
https://bugs.webkit.org/show_bug.cgi?id=75226
Reviewed by Pavel Feldman.
- inspector/front-end/JavaScriptOutlineDialog.js:
(WebInspector.JavaScriptOutlineDialog):
(WebInspector.JavaScriptOutlineDialog.prototype._createSearchRegExp):
(WebInspector.JavaScriptOutlineDialog.prototype._filterFunctions):
(WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown.previousItem):
(WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown.nextItem):
(WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown):
(WebInspector.JavaScriptOutlineDialog.prototype._updateSelection):
(WebInspector.JavaScriptOutlineDialog.prototype._onScroll):
(WebInspector.JavaScriptOutlineDialog.MatchHighlighter):
(WebInspector.JavaScriptOutlineDialog.MatchHighlighter.prototype.highlightViewportItems):
(WebInspector.JavaScriptOutlineDialog.MatchHighlighter.prototype.clearHighlight):
(WebInspector.JavaScriptOutlineDialog.MatchHighlighter.prototype._highlightItem):
(WebInspector.JavaScriptOutlineDialog.MatchHighlighter.prototype._viewportRowRange):
- inspector/front-end/javaScriptOutlineDialog.css:
(.js-outline-dialog > .container > div.item > span.highlight):
- 6:30 AM Changeset in webkit [103683] by
-
- 10 edits in trunk
Web Inspector: Extract FileSelector from ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=75173
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype.get defaultFocusedElement):
(WebInspector.ScriptsNavigator.prototype.show):
(WebInspector.ScriptsNavigator.prototype.setScriptSourceIsDirty):
(WebInspector.ScriptsNavigator.prototype.replaceUISourceCodes):
(WebInspector.ScriptsNavigator.prototype.scriptSelected):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.get defaultFocusedElement):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded.get if):
(WebInspector.ScriptsPanel.prototype.setScriptSourceIsBeingEdited):
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype._showSourceLine):
(WebInspector.ScriptsPanel.prototype._showAndRevealInFileSelector):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):
(WebInspector.ScriptsPanel.prototype._scriptSelected):
(WebInspector.ScriptsPanel.FileSelector):
(WebInspector.ScriptsPanel.FileSelector.prototype.get defaultFocusedElement):
(WebInspector.ScriptsPanel.FileSelector.prototype.show):
(WebInspector.ScriptsPanel.FileSelector.prototype.addUISourceCode):
(WebInspector.ScriptsPanel.FileSelector.prototype.isScriptSourceAdded):
(WebInspector.ScriptsPanel.FileSelector.prototype.revealUISourceCode):
(WebInspector.ScriptsPanel.FileSelector.prototype.setScriptSourceIsDirty):
(WebInspector.ScriptsPanel.FileSelector.prototype.replaceUISourceCodes):
(WebInspector.ScriptsPanel.ComboBoxFileSelector):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.get defaultFocusedElement):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.show):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.showDebugSidebarResizeWidget):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.addUISourceCode):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.isScriptSourceAdded):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.revealUISourceCode):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._innerRevealUISourceCode):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addToHistory):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.replaceUISourceCodes):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._reset):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.setScriptSourceIsDirty):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._createEditorToolbar):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addOptionToFilesSelect.get var):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addOptionToFilesSelect.insertOrdered):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._resetFilesSelect):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._updateBackAndForwardButtons):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._goBack):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._goForward):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._filesSelectChanged):
- inspector/front-end/inspector.html:
- inspector/front-end/utilities.js:
():
LayoutTests:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
- inspector/debugger/scripts-panel.html:
- inspector/debugger/scripts-sorting.html:
- inspector/debugger/source-frame-count.html:
- 4:39 AM Changeset in webkit [103682] by
-
- 9 edits2 adds in trunk/Source/WebCore
Web Inspector: Implement "Go to Function" dialog for JavaScript
https://bugs.webkit.org/show_bug.cgi?id=75092
Reviewed by Pavel Feldman.
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.sh:
- inspector/front-end/JavaScriptOutlineDialog.js: Added.
(WebInspector.JavaScriptOutlineDialog.onMouseDown):
(WebInspector.JavaScriptOutlineDialog):
(WebInspector.JavaScriptOutlineDialog.didAddChunk):
(WebInspector.JavaScriptOutlineDialog.install):
(WebInspector.JavaScriptOutlineDialog._show):
(WebInspector.JavaScriptOutlineDialog.createShortcut):
(WebInspector.JavaScriptOutlineDialog.prototype._resizeWindow):
(WebInspector.JavaScriptOutlineDialog.prototype._appendItemElements):
(WebInspector.JavaScriptOutlineDialog.prototype._createSearchRegExp):
(WebInspector.JavaScriptOutlineDialog.prototype._filterFunctions):
(WebInspector.JavaScriptOutlineDialog.prototype._selectFirstItem):
(WebInspector.JavaScriptOutlineDialog.prototype._hide):
(WebInspector.JavaScriptOutlineDialog.prototype._onBlur):
(WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown.previousItem):
(WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown.nextItem):
(WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown):
(WebInspector.JavaScriptOutlineDialog.prototype._scheduleFilter):
(WebInspector.JavaScriptOutlineDialog.prototype._updateSelection):
(WebInspector.JavaScriptOutlineDialog.prototype._onClick):
(WebInspector.JavaScriptOutlineDialog.prototype._onMouseMove):
(WebInspector.JavaScriptOutlineDialog.prototype._highlightFunctionLine):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.get uiSourceCode):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._didBuildOutlineChunk):
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype.requestVisibleScriptOutline):
(WebInspector.ScriptsPanel.prototype._createEditorToolbar):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/javaScriptOutlineDialog.css: Added.
(.js-outline-dialog):
(.js-outline-dialog > input):
(.js-outline-dialog > div.progress):
(.js-outline-dialog > div.container):
(.js-outline-dialog > .container > div.item):
(.js-outline-dialog > .container > div.item.selected):
- 4:27 AM Changeset in webkit [103681] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: make SDK compilation component self-contained.
https://bugs.webkit.org/show_bug.cgi?id=75172
Reviewed by Yury Semikhatsky.
- inspector/compile-front-end.sh:
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl):
(WebInspector.ConsoleMessageImpl.prototype.get stackTrace):
(WebInspector.ConsoleMessageImpl.prototype.clone):
- inspector/front-end/ConsoleModel.js:
(WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated):
(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.prototype.isErrorOrWarning):
(WebInspector.ConsoleMessage.prototype.updateRepeatCount):
(WebInspector.ConsoleMessage.prototype.clone):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
- inspector/front-end/ResourceUtils.js:
- inspector/front-end/UIUtils.js:
(WebInspector.resetToolbarColors):
(WebInspector.populateHrefContextMenu):
- 2:41 AM Changeset in webkit [103680] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed bad merge fix.
Patch by Hajime Morrita <morrita@google.com> on 2011-12-26
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::didMoveToNewDocument):
Dec 25, 2011:
- 11:05 PM Changeset in webkit [103679] by
-
- 30 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=74067
Refactoring: Unitfy willMoveToNewDocument() and didMoveToNewDocument()
Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-25
Reviewed by Darin Adler.
No new tests. No behavior change.
This change combines two method Node::willMoveToNewOwnerDocument() and Node::didMoveToNewOwnerDocument()
into Node::didMoveToNewDocument(Document* oldDocument).
The intention of this change is:
- Making upcoming refactoring (Bug 59816) possible. The refactoring will turn Node::m_document into Node::m_treeScope, and we will no longer have Node::setDocument() where we can invoke both willMoveToNewDocument() and didMoveToNewDocument() at once.
- Killing one extra virtual method call.
- Making the concept of "move" clearer by keeping such an operation into the single method.
- dom/Node.cpp:
(WebCore::setWillMoveToNewDocumentWasCalled):
(WebCore::setDidMoveToNewDocumentWasCalled):
(WebCore::Node::setDocument):
(WebCore::Node::didMoveToNewDocument):
- dom/Node.h:
- dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):
- html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::didMoveToNewDocument):
- html/FormAssociatedElement.h:
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::didMoveToNewDocument):
(WebCore::HTMLFormControlElementWithState::didMoveToNewDocument):
- html/HTMLFormControlElement.h:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::didMoveToNewDocument):
- html/HTMLFormElement.h:
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::didMoveToNewDocument):
- html/HTMLImageElement.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::didMoveToNewDocument):
- html/HTMLInputElement.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::didMoveToNewDocument):
- html/HTMLMediaElement.h:
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::didMoveToNewDocument):
- html/HTMLObjectElement.h:
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::didMoveToNewDocument):
- html/HTMLPlugInImageElement.h:
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::didMoveToNewDocument):
- html/HTMLVideoElement.h:
- html/ImageDocument.cpp:
(WebCore::ImageDocumentElement::didMoveToNewDocument):
- html/ImageInputType.cpp:
(WebCore::ImageInputType::willMoveToNewDocument):
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::elementDidMoveToNewDocument):
- loader/ImageLoader.h:
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::didMoveToNewDocument):
- svg/SVGImageElement.h:
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::didMoveToNewDocument):
- svg/SVGSVGElement.h:
- 10:16 PM Changeset in webkit [103678] by
-
- 8 edits in trunk/Source/WebCore
REGRESSION(r102987): Fix the filename prefix of the generated empty .h
and .cpp files for [Supplemental] IDLs
https://bugs.webkit.org/show_bug.cgi?id=75082
Reviewed by Darin Adler.
In bug 74481, we changed generate-bindings.pl so that it generates empty .h
and .cpp files for the [Supplemental] IDLs. However, the filename prefixes of
those .h and .cpp files are wrong. This patch fixes the prefixes as follows:
generator=JS => JS*.h, JS*.cpp
generator=V8 => V8*.h, V8*.cpp
generator=ObjC => DOM*.h, DOM*.cpp
generator=GObject => WebKitDOM*.h, WebKitDOM*.cpp
generator=CPP => WebDOM*.h, WebDOM*.cpp
No new tests. No change in behavior.
I confirmed that the names of generated .h and .cpp files are correct.
- bindings/scripts/CodeGenerator.pm:
(FileNamePrefix): Returns the prefix of file names.
- bindings/scripts/CodeGeneratorCPP.pm:
(GenerateInterface): Uses CodeGenerator::FileNamePrefix.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateInterface): Ditto.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateInterface): Ditto.
- bindings/scripts/CodeGeneratorObjC.pm:
(GenerateInterface): Ditto.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateInterface): Ditto.
- bindings/scripts/generate-bindings.pl:
(generateEmptyHeaderAndCpp): Ditto.
- 9:20 PM Changeset in webkit [103677] by
-
- 7 edits in trunk/Source
../WebCore: WebCore changes for: Find indicators overlap when a match spans multiple text boxes
https://bugs.webkit.org/show_bug.cgi?id=75220
Reviewed by Darin Adler.
- WebCore.exp.in: Exported new unionRect(const Vector<FloatRect>&) and existing
FloatRect::intersects().
- platform/graphics/FloatRect.cpp:
(WebCore::unionRect): Added.
- platform/graphics/FloatRect.h:
../WebKit2: Find indicators overlap when a match spans multiple text boxes
https://bugs.webkit.org/show_bug.cgi?id=75220
Reviewed by Darin Adler.
- UIProcess/FindIndicator.cpp:
(WebKit::findIndicatorsForTextRectsOverlap): Added this helper function that checks for
pairwise intersections between all indicator rects.
(WebKit::FindIndicator::FindIndicator): Changed to use a single rect (the union of all text
rects) if any two indicator rects would otherwise overlap. This is similar to what Safari
does, and it eliminates overlapping rects for adjacent text boxes. In rare cases (such as when
a match spans two lines and adjacent text boxes on one of those lines) it results in a find
indicator that is too large and obscures some non-match text.
- UIProcess/FindIndicator.h:
- 8:46 PM Changeset in webkit [103676] by
-
- 6 edits in trunk/Source/WebCore
Use OwnPtr for CSSFontFace::m_sources
https://bugs.webkit.org/show_bug.cgi?id=75219
Reviewed by Dan Bernstein.
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::isLoaded): Use the same size_t idiom here as in the rest
of the functions.
(WebCore::CSSFontFace::isValid): Ditto. Also removed unneeded empty special casing.
(WebCore::CSSFontFace::addSource): Changed to take a PassOwnPtr. Reordered so the
PassOwnPtr zeroing does not cause trouble.
(WebCore::CSSFontFace::getFontData): Added call to get.
(WebCore::CSSFontFace::hasSVGFontFaceSource): Use the same size_t idiom here as in
the rest of the functions.
- css/CSSFontFace.h: Use PassOwnPtr for addSource argument, and Vector<OwnPtr> for
the m_sources vector.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule): Use OwnPtr and PassOwnPtr for font face
sources that are passed to addSource.
- css/CSSSegmentedFontFace.cpp: Added a now-needed include.
- 8:02 PM Changeset in webkit [103675] by
-
- 3 edits6 adds in trunk
Allow XMLHttpRequest responseType to be set at any state up to and including HEADERS_RECEIVED
https://bugs.webkit.org/show_bug.cgi?id=75190
Source/WebCore:
XMLHttpRequest.responseType should be modifiable at any state up to and including the
HEADERS_RECEIVED state. Therefore, subsequent calls to open() should not reset responseType
to its default value, and calls to open() must follow the same spec mandate set forth in
setResponseType() for synchronous HTTP(S) requests made from the window context.
Reviewed by Alexey Proskuryakov.
Tests: fast/xmlhttprequest/xmlhttprequest-responsetype-before-open-sync-request.html
fast/xmlhttprequest/xmlhttprequest-responsetype-before-open.html
fast/xmlhttprequest/xmlhttprequest-responsetype-set-at-headers-received.html
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::setResponseType):
Prevent setting the value only when in LOADING and DONE states. No longer check if
m_loader is present, which is instantiated on a call to send(), because responseType
can be safely changed after a request is sent.
(WebCore::XMLHttpRequest::open):
Do not reset m_responseTypeCode to the default value, and prevent calls to open()
for synchronous HTTP(S) requests made from the window context when m_responseTypeCode
is not the default value.
LayoutTests:
Reviewed by Alexey Proskuryakov.
- fast/xmlhttprequest/xmlhttprequest-responsetype-before-open-expected.txt: Added.
- fast/xmlhttprequest/xmlhttprequest-responsetype-before-open-sync-request-expected.txt: Added.
- fast/xmlhttprequest/xmlhttprequest-responsetype-before-open-sync-request.html: Added.
Validate that calls to open() for synchronous HTTP(S) requests from the window context will
properly fail when responseType has been previously set to a non-default value.
- fast/xmlhttprequest/xmlhttprequest-responsetype-before-open.html: Added.
Validate that XMLHttpRequest.responseType can be set prior to a call to open().
- fast/xmlhttprequest/xmlhttprequest-responsetype-set-at-headers-received-expected.txt: Added.
- fast/xmlhttprequest/xmlhttprequest-responsetype-set-at-headers-received.html: Added.
Validate that XMLHttpRequest.responseType can be set at the HEADERS_RECEIVED state, but
no state later than that.
- 6:16 PM Changeset in webkit [103674] by
-
- 10 edits in trunk/Source/JavaScriptCore
The ArgumentCount field in the CallFrame should have its tag left blank for other uses
https://bugs.webkit.org/show_bug.cgi?id=75199
<rdar://problem/10625105>
<rdar://problem/10625106>
Reviewed by Oliver Hunt.
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::argumentPayloadSlot):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- interpreter/CallFrame.h:
(JSC::ExecState::argumentCountIncludingThis):
(JSC::ExecState::setArgumentCountIncludingThis):
- interpreter/Register.h:
(JSC::Register::unboxedInt32):
(JSC::Register::unboxedBoolean):
(JSC::Register::unboxedCell):
(JSC::Register::payload):
(JSC::Register::tag):
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileOpCall):
- 1:32 PM Changeset in webkit [103673] by
-
- 2 edits in trunk/Source/WebCore
Fix tests failing as a result of r103643
https://bugs.webkit.org/show_bug.cgi?id=75209
Reviewed by Dan Bernstein.
Switch accidental switch of default scroll granularity from
ScrollByPageWheelEvent back to ScrollByPixelWheelEvent.
- platform/mac/PlatformEventFactory.mm:
(WebCore::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
- 1:21 PM Changeset in webkit [103672] by
-
- 2 edits in trunk/Source/JavaScriptCore
Yarr: Avoid copying vectors in CharacterClassConstructor.
<http://webkit.org/b/75206>
Reviewed by Darin Adler.
Yarr::CharacterClassConstructor::charClass() was hot when loading twitter
feeds (1.2%), replace the usage of Vector::append() by swap() since we're
always clearing the source vector afterwards anyway.
- yarr/YarrPattern.cpp:
(JSC::Yarr::CharacterClassConstructor::charClass):
- 11:03 AM Changeset in webkit [103671] by
-
- 2 edits in trunk/Source/WebCore
Change CSS canvas code that does HashMap get/set to use the more efficient add idiom
https://bugs.webkit.org/show_bug.cgi?id=75204
Reviewed by Dan Bernstein.
- dom/Document.cpp:
(WebCore::Document::getCSSCanvasContext): Change local variable name of element to
element; it's not the function result, so not good to name it result.
(WebCore::Document::getCSSCanvasElement): Use add instead of get/set so we only do
one hash table lookup.
- 9:08 AM Changeset in webkit [103670] by
-
- 2 edits in trunk/Source/ThirdParty
- gtest/xcode/gtest.xcodeproj: Added property svn:ignore.
- 12:24 AM Changeset in webkit [103669] by
-
- 3 edits2 adds in trunk/Tools
Add unittests for the C++ parser of prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=75191
Reviewed by Ryosuke Niwa.
cpp_unittests.cpp is the unittests for get_function_line_ranges_for_cpp()
of prepare-ChangeLog.
- Scripts/prepare-ChangeLog:
(get_function_line_ranges): Renames get_function_line_ranges_for_c()
to get_function_line_ranges_for_cpp().
- Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Added.
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added.
(func1):
(func2):
(func3):
(func4):
(func5):
(func6):
(func7):
(func8):
(func9):
(func10):
(func11):
(func12):
(func13):
(func14):
(func15):
(funcOverloaded):
(Class::func16):
(Class1::Class2::func17):
(Class2::func18):
(Class2::func19):
(Class2::func20):
(Class2::func21):
(Class2::func22):
(func23):
(func24):
(Class2::func25):
(Class1::func26):
(Class2::func27):
(Class3::func28):
(Class7::operator+):
(Class100::Class100):
(Class101::~Class101):
(Class102::Class102):
(Class103::Class103):
(Struct1::func29):
(Struct2::func30):
(NameSpace1::func30):
(NameSpace1::NameSpace2::func31):
- 12:15 AM Changeset in webkit [103668] by
-
- 3 edits2 adds in trunk/Tools
Add unittests for the Java parser of prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=75195
Reviewed by Ryosuke Niwa.
java_unittests.java is unittest cases for get_function_line_ranges_for_java()
of prepare-ChangeLog.
- Scripts/prepare-ChangeLog:
(get_function_line_ranges_for_java): Fixed a parser bug.
interface I
{
void f()
{
}
}
should be recognized as "I.f", and
class C interface I
{
void f()
{
}
}
should be recognized as "C.f".
Without this patch, both are recognized as "I.f".
- Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Added.
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests.java: Added.
(Simple):
(Simple.func1):
(Simple.func2):
(Simple.func3):
(Simple.func4):
(Simple.func5):
(Simple.func6):
(Simple.func7):
(Simple.func8):
(Simple.func9):
(Simple.func10):
(Simple.funcOverloaded):
(Simple.func11):
(Simple.func12):
(Simple.func13):
(Simple.func14):
(Simple.func15):
(Simple.func16):
(Simple.func17):
(Simple.func18):
(Simple.func19):
(Simple.func20):
(Simple.func21):
(Derived1):
(Derived1.Derived1):
(Derived1.func22):
(Interface1):
(Interface2):
(Interface2.func23):
(Derived2):
(Derived2.Derived2):
(Derived2.func23):
- 12:09 AM Changeset in webkit [103667] by
-
- 3 edits2 adds in trunk/Tools
Add unittests for the Python parser of prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=75197
Reviewed by Ryosuke Niwa.
python_unittests.py is the unittest for get_function_line_ranges_for_python()
of prepare-ChangeLog. The unittest just contains classes and defs that are not nested.
This is because the current python parser is wrong, and it cannot correctly parse nested
classes and defs (even one def in a class), nor class inheritance.
We will fix it in another patch.
- Scripts/prepare-ChangeLog:
(get_function_line_ranges_for_python): Ignores comment lines that starts from #.
- Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Added.
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py: Added.
(func1):
(func2):
(func3):
(funcInsideComment):
(func4):
(func5):
(func6):
(funcOverloaded):
(Class1):
