⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 27, 2011:

10:07 PM Changeset in webkit [103758] by weinig@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Continue moving compiler feature checks to use the COMPILER_SUPPORTS() macro
​https://bugs.webkit.org/show_bug.cgi?id=75268

Reviewed by Anders Carlsson.

  • wtf/Compiler.h:

Add support for COMPILER_SUPPORTS(CXX_NULLPTR) and COMPILER_SUPPORTS(CXX_DELETED_FUNCTIONS).

  • wtf/Noncopyable.h:

Use COMPILER_SUPPORTS(CXX_DELETED_FUNCTIONS).

  • wtf/NullPtr.cpp:
  • wtf/NullPtr.h:

Use COMPILER_SUPPORTS(CXX_NULLPTR). Remove support for HAVE(NULLPTR).

  • wtf/RefPtr.h:
  • wtf/RetainPtr.h:

Switch from HAVE(NULLPTR) to COMPILER_SUPPORTS(CXX_NULLPTR).

9:29 PM Changeset in webkit [103757] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Crash in the WebKit accessibility code while attempting to retrieve the title UI element.
​https://bugs.webkit.org/show_bug.cgi?id=75279

Patch by Anantanarayanan G Iyengar <​ananta@chromium.org> on 2011-12-27
Reviewed by Ryosuke Niwa.

Fix a crash in the the WebKit accessibility code which occurs while retrieving
the title UI clement. The fix is to NULL check the RenderObject::node return value.

No test added as there is no reduction.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::titleUIElement):

9:13 PM Changeset in webkit [103756] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Remove duplicate code and remove entry after freeing the matrix.
​https://bugs.webkit.org/show_bug.cgi?id=75073

Patch by JungJik Lee <​jungjik.lee@samsung.com> on 2011-12-27
Reviewed by Ryosuke Niwa.

Remove duplicate ewk_tile_unused_cache_freeze code.
Entry matrix should free first before removing entry in inlist,
because in eina_matrixsparce_free callback entry pointer is referenced to decrease the reference count.

  • ewk/ewk_tiled_matrix.cpp:

(ewk_tile_matrix_free):

8:08 PM Changeset in webkit [103755] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

[mac] Stop using bootstrap_look_up2
​https://bugs.webkit.org/show_bug.cgi?id=75280

Reviewed by Mark Rowe.

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain): Changed to use bootstrap_look_up() instead of
bootstrap_look_up2().

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): Ditto.

7:27 PM Changeset in webkit [103754] by eae@chromium.org
  • 16182 edits
    1921 copies
    1612 deletes in branches/subpixellayout

Merging trunk changes up until 103725 into subpixel branch.

7:16 PM Changeset in webkit [103753] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Make the inputMethodEvent set or confirm the composition
​https://bugs.webkit.org/show_bug.cgi?id=75256

Reviewed by Chang Shu.

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::inputMethodEvent):

6:54 PM Changeset in webkit [103752] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add pass/crash expectation for svg/W3C-SVG-1.1/animate-elem-52-t.svg
on Chromium Mac and Linux debug bots per the WebKit bug 74788.

  • platform/chromium/test_expectations.txt:
6:47 PM Changeset in webkit [103751] by dominicc@chromium.org
  • 7 edits in trunk

Remove initWebKitAnimationEvent method
​https://bugs.webkit.org/show_bug.cgi?id=71698

Reviewed by Ojan Vafai.

Source/WebCore:

Now that WebKitAnimationEvent has a constructor, we don't need
this
method. <​https://www.w3.org/Bugs/Public/show_bug.cgi?id=15338> is
tracking the change to the CSS Animations spec.

  • dom/WebKitAnimationEvent.cpp:
  • dom/WebKitAnimationEvent.h:
  • dom/WebKitAnimationEvent.idl:

LayoutTests:

  • fast/events/init-events-expected.txt:
  • fast/events/script-tests/init-events.js:
6:43 PM Changeset in webkit [103750] by rniwa@webkit.org
  • 20 edits
    4 adds
    1 delete in trunk/LayoutTests

Chromium rebaselines for ​http://crbug.com/9768. It's hard to make sense of these failures at this point
but actual results appear to be correct.

  • platform/chromium-linux/fast/forms/select-initial-position-expected.png:
  • platform/chromium-linux/fast/forms/select-initial-position-expected.txt: Added.
  • platform/chromium-linux/fast/forms/select-visual-hebrew-expected.png:
  • platform/chromium-linux/fast/forms/select-visual-hebrew-expected.txt:
  • platform/chromium-linux/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-linux/fast/forms/visual-hebrew-text-field-expected.txt: Removed.
  • platform/chromium-win-xp/fast/text/international/001-expected.png: Added.
  • platform/chromium-win-xp/fast/text/international/002-expected.png: Added.
  • platform/chromium-win-xp/fast/text/international/wrap-CJK-001-expected.png: Added.
  • platform/chromium-win/fast/forms/select-initial-position-expected.png:
  • platform/chromium-win/fast/forms/select-initial-position-expected.txt:
  • platform/chromium-win/fast/forms/select-visual-hebrew-expected.png:
  • platform/chromium-win/fast/forms/select-visual-hebrew-expected.txt:
  • platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/chromium-win/fast/text/cg-fallback-bolding-expected.png:
  • platform/chromium-win/fast/text/cg-fallback-bolding-expected.txt:
  • platform/chromium-win/fast/text/international/001-expected.png:
  • platform/chromium-win/fast/text/international/001-expected.txt:
  • platform/chromium-win/fast/text/international/002-expected.png:
  • platform/chromium-win/fast/text/international/002-expected.txt:
  • platform/chromium-win/fast/text/international/wrap-CJK-001-expected.png:
  • platform/chromium-win/fast/text/international/wrap-CJK-001-expected.txt:
  • platform/chromium/test_expectations.txt:
6:33 PM Changeset in webkit [103749] by rniwa@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

Chromium Linux rebaseline. The difference is negligible for the purpose of this test.

  • platform/chromium-linux/fast/forms/textarea-width-expected.png:
  • platform/chromium-linux/fast/forms/textarea-width-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
6:27 PM Changeset in webkit [103748] by rniwa@webkit.org
  • 7 edits
    2 adds
    1 delete in trunk/LayoutTests

Chromium Linux rebsaeline for ​http://crbug.com/10430. Glyphs look correct.

  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
  • platform/chromium/test_expectations.txt:
6:16 PM Changeset in webkit [103747] by rniwa@webkit.org
  • 3 edits
    1 delete in trunk/LayoutTests

Chromium rebaseline after Skia revision 105271.
fast/css/shadow-multiple.html appears to have regressed; the failure is tracked by ​http://crbug.com/105271.

  • platform/chromium-win-xp/fast/multicol: Removed.
  • platform/chromium-win-xp/fast/multicol/shadow-breaking-expected.png: Removed.
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium/test_expectations.txt:
6:07 PM Changeset in webkit [103746] by dominicc@chromium.org
  • 7 edits in trunk

Remove initWebKitTransitionEvent method
​https://bugs.webkit.org/show_bug.cgi?id=71701

Reviewed by Ojan Vafai.

Source/WebCore:

Now that WebKitTransitionEvent has a constructor, we don't need
this
method. <​https://www.w3.org/Bugs/Public/show_bug.cgi?id=15339> is
tracking the change to the CSS Transitions spec.

  • dom/WebKitTransitionEvent.cpp:
  • dom/WebKitTransitionEvent.h:
  • dom/WebKitTransitionEvent.idl:

LayoutTests:

Now that WebKitTransitionEvent has a constructor, we don't need
this method.

  • fast/events/init-events-expected.txt:
  • fast/events/script-tests/init-events.js:
5:31 PM Changeset in webkit [103745] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Misc fixes and cleanups in Functional.h
​https://bugs.webkit.org/show_bug.cgi?id=75281

Reviewed by Andreas Kling.

  • Reformat template declarations so that the class begins on a new line.
  • Change the parameter template parameters to start at P1 instead of P0.
  • Add function wrappers and bind overloads for 4 and 5 parameter functions.
  • Change the Function call operator to be const so const functions can be called.
  • wtf/Functional.h:
5:13 PM Changeset in webkit [103744] by rniwa@webkit.org
  • 5 edits
    1 delete in trunk/LayoutTests

Chromium Linux CPU rebaseline after r103723.

  • platform/chromium-gpu-linux/media/video-layer-crash-expected.png:
  • platform/chromium-gpu-linux/media/video-transformed-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-win/media/video-transformed-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
4:57 PM Changeset in webkit [103743] by rniwa@webkit.org
  • 34 edits
    37 adds
    67 deletes in trunk/LayoutTests

Chromium rebaseline after r98596 part 6.

  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-clipped-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-clipped-nonzero-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-objectBoundingBox-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-on-clipped-use-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-on-g-and-child-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-on-g-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-on-svg-and-child-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-on-svg-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-transform-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-use-as-child-expected.png: Added.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-clipped-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-clipped-nonzero-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-objectBoundingBox-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-on-clipped-use-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-on-g-and-child-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-on-g-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-on-svg-and-child-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-on-svg-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-transform-2-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-use-as-child-expected.png: Removed.
  • platform/chromium-linux/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-clipped-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-clipped-nonzero-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-objectBoundingBox-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-on-clipped-use-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-on-g-and-child-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-on-g-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-on-svg-and-child-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-on-svg-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-transform-2-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-use-as-child-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-userSpaceOnUse-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-with-text-clipped-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/masking-path-05-f-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png:
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png:
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-clipped-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-clipped-nonzero-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-objectBoundingBox-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-on-clipped-use-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-on-g-and-child-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-on-g-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-on-svg-and-child-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-on-svg-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-transform-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-use-as-child-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-with-text-clipped-expected.png: Added.
  • platform/chromium-mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-clipped-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-clipped-nonzero-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-objectBoundingBox-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-on-clipped-use-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-on-g-and-child-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-on-g-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-on-svg-and-child-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-on-svg-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-transform-2-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-use-as-child-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-with-text-clipped-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path: Removed.
  • platform/chromium-win/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png:
  • platform/chromium-win/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-clipped-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-clipped-nonzero-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-objectBoundingBox-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-on-clipped-use-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-on-g-and-child-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-on-g-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-on-svg-and-child-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-on-svg-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-transform-2-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-use-as-child-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-userSpaceOnUse-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-with-text-clipped-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-clipped-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-clipped-nonzero-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-objectBoundingBox-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-clipped-use-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-g-and-child-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-g-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-svg-and-child-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-svg-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-transform-2-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-userSpaceOnUse-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-clipped-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-objectBoundingBox-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-on-g-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-on-svg-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-transform-2-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-use-as-child-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-userSpaceOnUse-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-clipped-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-clipped-nonzero-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-objectBoundingBox-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-on-clipped-use-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-on-g-and-child-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-on-g-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-on-svg-and-child-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-on-svg-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-transform-2-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-use-as-child-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-userSpaceOnUse-expected.txt: Removed.
  • svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt: Added.
  • svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt: Added.
  • svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt: Added.
  • svg/clip-path/clip-path-clipped-expected.txt: Added.
  • svg/clip-path/clip-path-clipped-nonzero-expected.txt: Added.
  • svg/clip-path/clip-path-objectBoundingBox-expected.txt: Added.
  • svg/clip-path/clip-path-on-clipped-use-expected.txt: Added.
  • svg/clip-path/clip-path-on-g-and-child-expected.txt: Added.
  • svg/clip-path/clip-path-on-g-expected.txt: Added.
  • svg/clip-path/clip-path-on-svg-and-child-expected.txt: Added.
  • svg/clip-path/clip-path-on-svg-expected.txt: Added.
  • svg/clip-path/clip-path-transform-2-expected.txt: Added.
  • svg/clip-path/clip-path-use-as-child-expected.txt: Added.
  • svg/clip-path/clip-path-userSpaceOnUse-expected.txt: Added.
4:49 PM Changeset in webkit [103742] by tony@chromium.org
  • 6 edits
    9 moves
    1 add in trunk/Source/WebCore

Move HarfBuzz files into their own directory
​https://bugs.webkit.org/show_bug.cgi?id=72780

Reviewed by Daniel Bates.

FontCacheLinux.cpp got moved to platform/graphics/skia/FontCacheSkia.cpp since it wasn't HarfBuzz specific.

I used HarfBuzz in filenames since that seems to be how the name is capitalized on the project home page.

Fixed some style errors caught by the style checker.

  • PlatformBlackBerry.cmake:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/graphics/chromium/FontPlatformData.h:
  • platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp: Renamed from Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp.
  • platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.h: Renamed from Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.h.
  • platform/graphics/harfbuzz/FontHarfBuzz.cpp: Renamed from Source/WebCore/platform/graphics/chromium/FontLinux.cpp.
  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp: Renamed from Source/WebCore/platform/graphics/chromium/FontPlatformDataLinux.cpp.
  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h: Renamed from Source/WebCore/platform/graphics/chromium/FontPlatformDataLinux.h.
  • platform/graphics/harfbuzz/HarfBuzzSkia.cpp: Renamed from Source/WebCore/platform/graphics/chromium/HarfbuzzSkia.cpp.
  • platform/graphics/harfbuzz/HarfBuzzSkia.h: Renamed from Source/WebCore/platform/graphics/chromium/HarfbuzzSkia.h.
  • platform/graphics/harfbuzz/SimpleFontDataSkia.cpp: Renamed from Source/WebCore/platform/graphics/chromium/SimpleFontDataLinux.cpp.
  • platform/graphics/skia/FontCacheSkia.cpp: Renamed from Source/WebCore/platform/graphics/chromium/FontCacheLinux.cpp.
  • platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
4:33 PM Changeset in webkit [103741] by commit-queue@webkit.org
  • 21 edits
    1 copy
    1 add
    1 delete in trunk

Unreviewed, rolling out r103734.
​http://trac.webkit.org/changeset/103734
​https://bugs.webkit.org/show_bug.cgi?id=75278

Broke cr-mac (Requested by dslomov on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-27

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebCommonWorkerClient.h:

(WebKit::WebCommonWorkerClient::postConsoleMessageToWorkerObject):
(WebKit::WebCommonWorkerClient::allowFileSystem):
(WebKit::WebCommonWorkerClient::openFileSystem):
(WebKit::WebCommonWorkerClient::dispatchDevToolsMessage):
(WebKit::WebCommonWorkerClient::saveDevToolsAgentState):
(WebKit::WebCommonWorkerClient::~WebCommonWorkerClient):

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::createWorker):

  • public/WebSharedWorker.h:
  • public/WebSharedWorkerClient.h: Removed.
  • public/WebWorkerClient.h:

(WebKit::WebWorkerClient::~WebWorkerClient):

  • src/DatabaseObserver.cpp:

(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::openFromWorker):

  • src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::client):
(WebKit::WebSharedWorker::create):

  • src/WebSharedWorkerImpl.h:

(WebKit::WebSharedWorkerImpl::commonClient):
(WebKit::WebSharedWorkerImpl::newCommonClient):

  • src/WebWorkerBase.cpp:

(WebKit::initializeWebKitStaticValues):
(WebKit::WebWorkerBase::WebWorkerBase):
(WebKit::WebWorkerBase::~WebWorkerBase):
(WebKit::WebWorkerBase::stopWorkerThread):
(WebKit::WebWorkerBase::initializeLoader):
(WebKit::WebWorkerBase::dispatchTaskToMainThread):
(WebKit::WebWorkerBase::invokeTaskMethod):
(WebKit::WebWorkerBase::didCreateDataSource):
(WebKit::WebWorkerBase::createApplicationCacheHost):
(WebKit::WebWorkerBase::postMessageToWorkerObject):
(WebKit::WebWorkerBase::postMessageTask):
(WebKit::WebWorkerBase::postExceptionToWorkerObject):
(WebKit::WebWorkerBase::postExceptionTask):
(WebKit::WebWorkerBase::postConsoleMessageToWorkerObject):
(WebKit::WebWorkerBase::postConsoleMessageTask):
(WebKit::WebWorkerBase::postMessageToPageInspector):
(WebKit::WebWorkerBase::postMessageToPageInspectorTask):
(WebKit::WebWorkerBase::updateInspectorStateCookie):
(WebKit::WebWorkerBase::updateInspectorStateCookieTask):
(WebKit::WebWorkerBase::confirmMessageFromWorkerObject):
(WebKit::WebWorkerBase::confirmMessageTask):
(WebKit::WebWorkerBase::reportPendingActivity):
(WebKit::WebWorkerBase::reportPendingActivityTask):
(WebKit::WebWorkerBase::workerContextClosed):
(WebKit::WebWorkerBase::workerContextClosedTask):
(WebKit::WebWorkerBase::workerContextDestroyed):
(WebKit::WebWorkerBase::workerContextDestroyedTask):
(WebKit::WebWorkerBase::postTaskToLoader):
(WebKit::WebWorkerBase::postTaskForModeToWorkerContext):

  • src/WebWorkerBase.h:

(WebKit::WebWorkerBase::view):
(WebKit::WebWorkerBase::setWorkerThread):
(WebKit::WebWorkerBase::workerThread):

  • src/WebWorkerClientImpl.cpp:
  • src/WebWorkerClientImpl.h:

(WebKit::WebWorkerClientImpl::newCommonClient):

  • src/WebWorkerImpl.cpp: Added.

(WebKit::WebWorker::create):
(WebKit::WebWorkerImpl::WebWorkerImpl):
(WebKit::WebWorkerImpl::~WebWorkerImpl):
(WebKit::WebWorkerImpl::newCommonClient):
(WebKit::WebWorkerImpl::commonClient):
(WebKit::WebWorkerImpl::postMessageToWorkerContextTask):
(WebKit::WebWorkerImpl::startWorkerContext):
(WebKit::WebWorkerImpl::terminateWorkerContext):
(WebKit::WebWorkerImpl::postMessageToWorkerContext):
(WebKit::WebWorkerImpl::workerObjectDestroyed):
(WebKit::WebWorkerImpl::clientDestroyed):

  • src/WebWorkerImpl.h: Copied from Source/WebKit/chromium/src/WebWorkerBase.cpp.

(WebKit::WebWorkerImpl::client):

  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):

  • src/WorkerFileSystemCallbacksBridge.h:

Tools:

  • DumpRenderTree/chromium/TestWebWorker.h:

(TestWebWorker::createWorker):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createWorker):

  • DumpRenderTree/chromium/WebViewHost.h:
4:26 PM Changeset in webkit [103740] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. According to the flakiness dashboard,
fast/forms/input-text-paste-maxlength.html,
fast/filesystem/filesystem-reference.html,
fast/filesystem/filesystem-uri-origin.html, and
fast/canvas/canvas-putImageData.html are no longer flaky.

  • platform/chromium/test_expectations.txt:
4:12 PM Changeset in webkit [103739] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, clean up some obsolete expecatations.

  • platform/chromium/test_expectations.txt:

svg/dom/SVGRectElement/rect-modify-rx.svg is passing according to the flakiness dashboard
and storage/close-during-stress-test.html is flaky in non-debug (very rare, less than 1% of the time).

4:11 PM Changeset in webkit [103738] by leviw@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/rendering

Fixing incorrectly overloaded layoutBlock method in RenderFlexibleBox

4:03 PM Changeset in webkit [103737] by rniwa@webkit.org
  • 28 edits
    13 adds
    16 deletes in trunk/LayoutTests

Chromium rebaseline after r98596 part 5.

  • platform/chromium-cg-mac-snowleopard/fast/transforms: Added.
  • platform/chromium-cg-mac-snowleopard/fast/transforms/shadows-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/writing-mode/border-styles-vertical-lr-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/writing-mode/border-styles-vertical-rl-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/custom/use-on-clip-path-with-transformation-expected.png: Added.
  • platform/chromium-cg-mac/fast/transforms/shadows-expected.png: Removed.
  • platform/chromium-cg-mac/fast/writing-mode/border-styles-vertical-lr-expected.png: Removed.
  • platform/chromium-cg-mac/fast/writing-mode/border-styles-vertical-rl-expected.png: Removed.
  • platform/chromium-cg-mac/svg/custom/use-on-clip-path-with-transformation-expected.png: Removed.
  • platform/chromium-linux-x86/fast/transforms: Removed.
  • platform/chromium-linux-x86/fullscreen: Removed.
  • platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-linux/fast/transforms/shadows-expected.png:
  • platform/chromium-linux/fast/writing-mode/border-styles-vertical-lr-expected.png:
  • platform/chromium-linux/fast/writing-mode/border-styles-vertical-rl-expected.png:
  • platform/chromium-linux/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-linux/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/chromium-linux/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-linux/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac-leopard/fast/transforms/shadows-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac-snowleopard/fast/transforms: Added.
  • platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/writing-mode/border-styles-vertical-lr-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/writing-mode/border-styles-vertical-rl-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/use-on-clip-path-with-transformation-expected.png: Added.
  • platform/chromium-mac/fast/transforms/shadows-expected.png: Removed.
  • platform/chromium-mac/fast/writing-mode/border-styles-vertical-lr-expected.png: Removed.
  • platform/chromium-mac/fast/writing-mode/border-styles-vertical-rl-expected.png: Removed.
  • platform/chromium-mac/svg/custom/use-on-clip-path-with-transformation-expected.png: Removed.
  • platform/chromium-win-vista/fullscreen: Removed.
  • platform/chromium-win-xp/fast/transforms: Removed.
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/fast/writing-mode/border-styles-vertical-lr-expected.png:
  • platform/chromium-win/fast/writing-mode/border-styles-vertical-rl-expected.png:
  • platform/chromium-win/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-win/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/chromium-win/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/chromium-win/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/chromium-win/svg/custom/use-on-clip-path-with-transformation-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/svg/custom/resource-invalidate-on-target-update-expected.txt: Removed.
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt: Removed.
  • platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.txt: Removed.
  • platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.txt: Removed.
  • svg/custom/resource-invalidate-on-target-update-expected.txt: Added.
  • svg/custom/use-on-clip-path-with-transformation-expected.txt: Added.
3:46 PM Changeset in webkit [103736] by rniwa@webkit.org
  • 34 edits
    25 adds
    18 deletes in trunk/LayoutTests

Chromium rebaseline after r98596 part 4.

  • platform/chromium-cg-mac-snowleopard/fast/box-shadow/border-radius-big-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/box-shadow/spread-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/box-shadow/spread-multiple-inset-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/box-shadow/spread-multiple-normal-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/clip: Added.
  • platform/chromium-cg-mac-snowleopard/fast/clip/overflow-border-radius-clip-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/nested-rounded-corners-expected.png: Added.
  • platform/chromium-cg-mac/fast/box-shadow/border-radius-big-expected.png: Removed.
  • platform/chromium-cg-mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Removed.
  • platform/chromium-cg-mac/fast/box-shadow/spread-expected.png: Removed.
  • platform/chromium-cg-mac/fast/box-shadow/spread-multiple-inset-expected.png: Removed.
  • platform/chromium-cg-mac/fast/box-shadow/spread-multiple-normal-expected.png: Removed.
  • platform/chromium-cg-mac/fast/clip/overflow-border-radius-clip-expected.png: Removed.
  • platform/chromium-cg-mac/fast/css/nested-rounded-corners-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/validation-message-appearance-expected.txt: Removed.
  • platform/chromium-linux-x86/fast/box-shadow: Removed.
  • platform/chromium-linux-x86/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.png:
  • platform/chromium-linux/fast/clip/overflow-border-radius-clip-expected.png:
  • platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-linux/fast/css/nested-rounded-corners-expected.png:
  • platform/chromium-linux/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-leopard/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac-leopard/fast/box-shadow/spread-multiple-inset-expected.png:
  • platform/chromium-mac-leopard/fast/clip/overflow-border-radius-clip-expected.png:
  • platform/chromium-mac-leopard/fast/css/box-shadow-and-border-radius-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/text-input-with-webkit-border-radius-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/basic-shadows-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/border-radius-big-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/inset-box-shadows-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/inset-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/spread-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/spread-multiple-inset-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/spread-multiple-normal-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/clip: Added.
  • platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-clip-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/box-shadow-and-border-radius-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/nested-rounded-corners-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/text-input-with-webkit-border-radius-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/box-shadow/border-radius-big-expected.png: Removed.
  • platform/chromium-mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Removed.
  • platform/chromium-mac/fast/box-shadow/spread-expected.png: Removed.
  • platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png: Removed.
  • platform/chromium-mac/fast/box-shadow/spread-multiple-normal-expected.png: Removed.
  • platform/chromium-mac/fast/clip/overflow-border-radius-clip-expected.png: Removed.
  • platform/chromium-mac/fast/css/nested-rounded-corners-expected.png: Removed.
  • platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.png: Removed.
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt: Removed.
  • platform/chromium-win-vista/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-win-xp/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.png:
  • platform/chromium-win/fast/clip/overflow-border-radius-clip-expected.png:
  • platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-win/fast/css/nested-rounded-corners-expected.png:
  • platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium/fast/forms/validation-message-appearance-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:37 PM Changeset in webkit [103735] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[TexMap][QT] The fragment shader in OpenGL ES2 requires the default precision
qualifier.
​https://bugs.webkit.org/show_bug.cgi?id=75168

Patch by Huang Dongsung <​luxtella@company100.net> on 2011-12-27
Reviewed by Noam Rosenthal.

No new functionality so no new tests.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::initializeShaders):

3:34 PM Changeset in webkit [103734] by dslomov@google.com
  • 21 edits
    1 copy
    2 deletes in trunk

Source/WebKit/chromium: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
​https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:

  • WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  • NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  • WebWorkerBase merged into WebSharedWorkerImpl
  • NewWebWorkerBase renamed into WebWorkerBase

WebWorkerClient.h has a "#define WebWorkerClient WebSharedWorkerClient" to keep chromium building.
Will be removed after coordinated patch in chromium.

Reviewed by David Levin.

  • WebKit.gyp:
  • public/WebCommonWorkerClient.h:
  • public/WebSharedWorker.h:
  • public/WebSharedWorkerClient.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.

(WebKit::WebSharedWorkerClient::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerClient::allowFileSystem):
(WebKit::WebSharedWorkerClient::openFileSystem):
(WebKit::WebSharedWorkerClient::dispatchDevToolsMessage):
(WebKit::WebSharedWorkerClient::saveDevToolsAgentState):
(WebKit::WebSharedWorkerClient::~WebSharedWorkerClient):

  • public/WebWorkerClient.h:
  • src/DatabaseObserver.cpp:

(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::openFromWorker):

  • src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::initializeWebKitStaticValues):
(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::stopWorkerThread):
(WebKit::WebSharedWorkerImpl::initializeLoader):
(WebKit::WebSharedWorkerImpl::didCreateDataSource):
(WebKit::WebSharedWorkerImpl::createApplicationCacheHost):
(WebKit::WebSharedWorkerImpl::postMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postMessageTask):
(WebKit::WebSharedWorkerImpl::postExceptionToWorkerObject):
(WebKit::WebSharedWorkerImpl::postExceptionTask):
(WebKit::WebSharedWorkerImpl::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postConsoleMessageTask):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspector):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspectorTask):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookie):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookieTask):
(WebKit::WebSharedWorkerImpl::confirmMessageFromWorkerObject):
(WebKit::WebSharedWorkerImpl::confirmMessageTask):
(WebKit::WebSharedWorkerImpl::reportPendingActivity):
(WebKit::WebSharedWorkerImpl::reportPendingActivityTask):
(WebKit::WebSharedWorkerImpl::workerContextClosed):
(WebKit::WebSharedWorkerImpl::workerContextClosedTask):
(WebKit::WebSharedWorkerImpl::workerContextDestroyed):
(WebKit::WebSharedWorkerImpl::workerContextDestroyedTask):
(WebKit::WebSharedWorkerImpl::postTaskToLoader):
(WebKit::WebSharedWorkerImpl::postTaskForModeToWorkerContext):
(WebKit::WebSharedWorker::create):

  • src/WebSharedWorkerImpl.h:

(WebKit::WebSharedWorkerImpl::view):
(WebKit::WebSharedWorkerImpl::commonClient):
(WebKit::WebSharedWorkerImpl::client):
(WebKit::WebSharedWorkerImpl::setWorkerThread):
(WebKit::WebSharedWorkerImpl::workerThread):

  • src/WebWorkerBase.cpp:

(WebKit::invokeTaskMethod):
(WebKit::WebWorkerBase::dispatchTaskToMainThread):

  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.cpp:
  • src/WebWorkerClientImpl.h:

(WebKit::WebWorkerClientImpl::commonClient):

  • src/WebWorkerImpl.cpp: Removed.
  • src/WebWorkerImpl.h: Removed.
  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):

  • src/WorkerFileSystemCallbacksBridge.h:

Tools: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
​https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:

  • WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  • NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  • WebWorkerBase merged into WebSharedWorkerImpl
  • NewWebWorkerBase renamed into WebWorkerBase

Reviewed by David Levin.

  • DumpRenderTree/chromium/TestWebWorker.h:

(TestWebWorker::createWorker):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createWorker):

  • DumpRenderTree/chromium/WebViewHost.h:
3:32 PM Changeset in webkit [103733] by rniwa@webkit.org
  • 42 edits
    37 adds
    41 deletes in trunk/LayoutTests

Chromium rebaseline after r98596 part 3.

  • fast/borders/borderRadiusGroove01-expected.txt: Removed.
  • fast/borders/borderRadiusGroove02-expected.txt: Removed.
  • fast/borders/borderRadiusInset01-expected.txt: Removed.
  • fast/borders/borderRadiusOutset01-expected.txt: Removed.
  • fast/borders/borderRadiusRidge01-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-groove-01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-groove-02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-groove-03-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-inset-outset-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-split-inline-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-wide-border-01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-wide-border-02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-wide-border-03-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-wide-border-04-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-styles-split-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusGroove01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusGroove02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusInset01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusOutset01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusRidge01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/different-color-borders-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/fieldsetBorderRadius-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/mixed-border-styles-radius2-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/border-radius-groove-01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-groove-02-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-groove-03-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-inset-outset-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-split-inline-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-wide-border-01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-wide-border-02-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-wide-border-03-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-wide-border-04-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-styles-split-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusGroove01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusGroove02-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusInset01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusOutset01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusRidge01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/different-color-borders-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/fieldsetBorderRadius-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/mixed-border-styles-radius2-expected.png: Removed.
  • platform/chromium-linux/fast/borders/border-radius-groove-01-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-groove-02-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-groove-03-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-inset-outset-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-wide-border-01-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-wide-border-02-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-wide-border-03-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-wide-border-04-expected.png:
  • platform/chromium-linux/fast/borders/border-styles-split-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-linux/fast/borders/different-color-borders-expected.png:
  • platform/chromium-linux/fast/borders/fieldsetBorderRadius-expected.png:
  • platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-linux/fast/borders/mixed-border-styles-radius2-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-radius-split-inline-expected.png: Added.
  • platform/chromium-mac-leopard/fast/borders/different-color-borders-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-groove-01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-groove-02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-groove-03-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-inset-outset-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-split-inline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-wide-border-01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-wide-border-02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-wide-border-03-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-wide-border-04-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-styles-split-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusGroove01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusGroove02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusInset01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusOutset01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusRidge01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/different-color-borders-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/fieldsetBorderRadius-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/mixed-border-styles-radius2-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-groove-01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-groove-02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-groove-03-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-inset-outset-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-wide-border-01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-wide-border-02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-wide-border-03-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-wide-border-04-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-styles-split-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusGroove01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusOutset01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/different-color-borders-expected.png: Removed.
  • platform/chromium-mac/fast/borders/fieldsetBorderRadius-expected.png: Removed.
  • platform/chromium-mac/fast/borders/mixed-border-styles-radius2-expected.png: Removed.
  • platform/chromium-win/fast/borders/border-radius-groove-01-expected.png:
  • platform/chromium-win/fast/borders/border-radius-groove-02-expected.png:
  • platform/chromium-win/fast/borders/border-radius-groove-03-expected.png:
  • platform/chromium-win/fast/borders/border-radius-inset-outset-expected.png:
  • platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-win/fast/borders/border-radius-wide-border-01-expected.png:
  • platform/chromium-win/fast/borders/border-radius-wide-border-02-expected.png:
  • platform/chromium-win/fast/borders/border-radius-wide-border-03-expected.png:
  • platform/chromium-win/fast/borders/border-radius-wide-border-04-expected.png:
  • platform/chromium-win/fast/borders/border-styles-split-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-win/fast/borders/different-color-borders-expected.png:
  • platform/chromium-win/fast/borders/fieldsetBorderRadius-expected.png:
  • platform/chromium-win/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-win/fast/borders/mixed-border-styles-radius2-expected.png:
  • platform/chromium/test_expectations.txt:
3:24 PM Changeset in webkit [103732] by tony@chromium.org
  • 4 edits in trunk/Source

[chromium] Minor cleanup of gyp files.
​https://bugs.webkit.org/show_bug.cgi?id=75269

Reviewed by Adam Barth.

Source/JavaScriptCore:

and vim/emacs specific hooks should be added by the user.

Source/WebKit/chromium:

  • WebKit.gyp: msvs_guid is no longer needed.
3:04 PM Changeset in webkit [103731] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add an expected result meant to be added in r103723.

  • platform/chromium/compositing/scaling: Added.
  • platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png: Added.
2:49 PM Changeset in webkit [103730] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] uninitialized variable in fakeMouseMoveEventTimerFired
​https://bugs.webkit.org/show_bug.cgi?id=75263

Reviewed by Tony Chang.

The failure was caused by PlatformKeyboardEvent::getCurrentModifierState in PlatformKeyboardEventChromium.cpp
not initializing arguments on Linux. Fixed the failure by always assigning false to the arguments.

But we should really fix this function for Linux. Not recognizing any modifier isn't great.

  • platform/chromium/PlatformKeyboardEventChromium.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState):

2:31 PM Changeset in webkit [103729] by haraken@chromium.org
  • 5 edits in trunk

WIP: Enable the [Supplemental] IDL on Gtk
​https://bugs.webkit.org/show_bug.cgi?id=74972

Reviewed by Adam Barth.

.:

This patch adds dom_binding_idls, which is used in Source/WebCore/GNUmakefile.list.am.

  • GNUmakefile.am:

Source/WebCore:

This patch enables the [Supplemental] IDL on Gtk by changing the build
flow of Gtk as follows.

  • Previous build flow:

foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;

}

  • New build flow (See the discussions in bug 72138 for more details):

resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl,

including all attributes in the IDL files that are implementing $idl;

}

Tests: Confirm that build succeeds.

http/tests/websocket/tests/*

  • GNUmakefile.am: Described the above build flow.
  • GNUmakefile.list.am: Added a list of IDL files. Instead, removed a list of JS*.h and JS*.cpp

that are generated by the IDL files.

2:09 PM Changeset in webkit [103728] by barraclough@apple.com
  • 5 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=75260
Null name for host function can result in dereference of uninitialize memory

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This is a recent regression in ToT, if the name passed to finishCreation of a host function is null,
we are currently skipping the putDirect, which leaves memory uninitialized. This patch reverts the
aspect of the change that introduced the issue. It might be better if functions that don't have a
name don't have this property at all, but that's change should be separate from fixing the bug.

  • runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation):

  • Always initialize the name property.

LayoutTests:

Added a test for String applies to the ThrowTypeError function object -
if this does not crash, it passes!

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:
2:04 PM Changeset in webkit [103727] by tony@chromium.org
  • 4 edits in trunk/Source

[chromium] When building with clang, enable -Wglobal-constructors
​https://bugs.webkit.org/show_bug.cgi?id=74365

Reviewed by Adam Barth.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • WebKit.gyp: Only add it to the webkit target. I got errors when

trying to compile webkit_unit_tests.

1:39 PM Changeset in webkit [103726] by andersca@apple.com
  • 4 edits in trunk

Function should handle wrapping/unwrapping RefPtr and PassRefPtr
​https://bugs.webkit.org/show_bug.cgi?id=75266

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Add ParamStorageTraits that can be used for deciding how bound parameters should be stored
and peeked at. For RefPtr we want to use the raw pointer when "peeking" to avoid ref-churn.
For PassRefPtr, we want to use RefPtr for storage but still use the raw pointer when peeking.

  • wtf/Functional.h:

(WTF::ParamStorageTraits::wrap):
(WTF::ParamStorageTraits::unwrap):

Tools:

  • TestWebKitAPI/Tests/WTF/Functional.cpp:

(TestWebKitAPI::Number::create):
(TestWebKitAPI::Number::~Number):
(TestWebKitAPI::Number::value):
(TestWebKitAPI::Number::Number):
(TestWebKitAPI::multiplyNumberByTwo):
(TestWebKitAPI::TEST):

1:04 PM Changeset in webkit [103725] by rniwa@webkit.org
  • 32 edits
    32 adds
    35 deletes in trunk/LayoutTests

Chromium rebaseline after r98596 part 2.

  • fast/borders/borderRadiusDotted02-expected.txt: Added.
  • fast/borders/borderRadiusDotted03-expected.txt: Added.
  • fast/borders/borderRadiusDouble01-expected.txt: Removed.
  • fast/borders/borderRadiusDouble02-expected.txt: Removed.
  • fast/borders/borderRadiusDouble03-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDotted01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDotted02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDotted03-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDotted04-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDotted05-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDotted06-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble03-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble04-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble05-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble06-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble07-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble08-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble09-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDotted01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDotted02-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDotted03-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDotted04-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDotted05-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDotted06-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble02-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble03-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble04-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble05-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble06-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble07-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble08-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble09-expected.png: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted04-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted05-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted06-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble04-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble05-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble06-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble07-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble08-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble09-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDotted01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDotted02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDotted03-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDotted04-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDotted05-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDotted06-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble03-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble04-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble05-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble06-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble07-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble08-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble09-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDotted01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDotted02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDotted03-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDotted04-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDotted05-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble04-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble05-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble06-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble07-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble08-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble09-expected.png: Removed.
  • platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted04-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted05-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted06-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble04-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble05-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble06-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble07-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble08-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble09-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/qt/fast/borders/borderRadiusDotted02-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusDotted03-expected.txt: Removed.
12:49 PM Changeset in webkit [103724] by rniwa@webkit.org
  • 29 edits
    23 adds
    30 deletes in trunk/LayoutTests

Chromium rebaseline after r98596 part 1.

  • fast/borders/border-radius-complex-inner-expected.txt: Added.
  • fast/borders/borderRadiusArcs01-expected.txt: Removed.
  • fast/borders/borderRadiusDashed01-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t0805-c5517-brdr-s-00-c-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/border-radius-split-background-image-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusAllStylesAllCorners-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusArcs01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDashed01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDashed02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDashed03-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDashed04-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDashed05-expected.png: Added.
  • platform/chromium-cg-mac/css2.1/t0805-c5517-brdr-s-00-c-expected.png: Removed.
  • platform/chromium-cg-mac/fast/backgrounds/border-radius-split-background-image-expected.png: Removed.
  • platform/chromium-cg-mac/fast/backgrounds/gradient-background-leakage-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusArcs01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDashed01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDashed02-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDashed03-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDashed04-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDashed05-expected.png: Removed.
  • platform/chromium-linux-x86/fast/backgrounds: Removed.
  • platform/chromium-linux-x86/fast/borders: Removed.
  • platform/chromium-linux/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-linux/fast/backgrounds/border-radius-split-background-image-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-complex-inner-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-different-width-001-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed04-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed05-expected.png:
  • platform/chromium-linux/svg/batik/text/textLength-expected.png: Added.
  • platform/chromium-linux/svg/batik/text/textLength-expected.txt: Removed.
  • platform/chromium-mac-leopard/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-mac-leopard/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0805-c5517-brdr-s-00-c-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/border-radius-split-background-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-complex-inner-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-different-width-001-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusAllStylesAllCorners-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusArcs01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed03-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed04-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed05-expected.png: Added.
  • platform/chromium-mac/css2.1/t0805-c5517-brdr-s-00-c-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/border-radius-split-background-image-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/gradient-background-leakage-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDashed02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDashed03-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDashed04-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDashed05-expected.png: Removed.
  • platform/chromium-win-vista/fast/borders: Removed.
  • platform/chromium-win-xp/fast/borders: Removed.
  • platform/chromium-win/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-win/fast/backgrounds/border-radius-split-background-image-expected.png:
  • platform/chromium-win/fast/backgrounds/gradient-background-leakage-expected.png:
  • platform/chromium-win/fast/borders/border-radius-complex-inner-expected.png:
  • platform/chromium-win/fast/borders/border-radius-different-width-001-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed04-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed05-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/borders/border-radius-complex-inner-expected.txt: Removed.
  • platform/mac/fast/borders/border-radius-complex-inner-expected.txt: Removed.
  • platform/qt/fast/borders/border-radius-complex-inner-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusDashed01-expected.txt: Removed.
12:27 PM Changeset in webkit [103723] by rniwa@webkit.org
  • 15 edits
    2 adds
    2 deletes in trunk/LayoutTests

[Chromium] media/video-layer-crash.html media/video-transformed.html media/video-zoom-controls.html are failing on linux and win gpu.
​https://bugs.webkit.org/show_bug.cgi?id=73905

Unreviewed rebaseline.

Also rebaselined compositing/color-matching/image-color-matching.html, compositing/geometry/vertical-scroll-composited.html
and compositing/scaling/tiled-layer-recursion.html.

  • platform/chromium-cg-mac-leopard/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-cg-mac-snowleopard/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-cg-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-win/media/video-layer-crash-expected.txt: Removed.
  • platform/chromium-gpu-win/media/video-transformed-expected.png:
  • platform/chromium-gpu-win/media/video-transformed-expected.txt: Added.
  • platform/chromium-linux/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png:
  • platform/chromium-mac-leopard/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-mac-snowleopard/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-win/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-win/compositing/scaling/tiled-layer-recursion-expected.png:
  • platform/chromium/compositing/geometry/vertical-scroll-composited-expected.png: Replaced.
  • platform/chromium/compositing/scaling: Removed.
  • platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
12:13 PM Changeset in webkit [103722] by tony@chromium.org
  • 4 edits in trunk/Source

[chromium] really enable wpo for WebCore libs and for WTF
​https://bugs.webkit.org/show_bug.cgi?id=75264

Reviewed by Adam Barth.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.gyp/WebCore.gyp: The variable was getting clobbered by the

value set in common.gypi. Use a target_defaults instead to set the
variable. I tested manually on my Windows machine and
WholeProgramOptimization is getting set when buildtype is Official.

11:53 AM Changeset in webkit [103721] by rniwa@webkit.org
  • 3 edits
    2 adds
    2 deletes in trunk/LayoutTests

bidi-override-in-anonymous-block.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=74688

Chromium rebaseline after r103719.

  • platform/chromium-cg-mac/fast/css/bidi-override-in-anonymous-block-expected.png: Removed.
  • platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.png: Removed.
  • platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/chromium/fast/css/bidi-override-in-anonymous-block-expected.png: Added.
  • platform/chromium/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:43 AM Changeset in webkit [103720] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] remove references to files no longer in the tree
​https://bugs.webkit.org/show_bug.cgi?id=75262

Reviewed by Adam Barth.

  • WebCore.gypi: platform/mac/PlatformMouseEventMac.mm and platform/mac/WheelEventMac.mm

were removed in r103652.

11:36 AM Changeset in webkit [103719] by abarth@webkit.org
  • 4 edits in trunk/LayoutTests

bidi-override-in-anonymous-block.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=74688

Unreviewed.

This test just needs an updated expectation. The case that changed is
the last (in the HTML) Ruby case. That tests an <rt> element nested
inside an <rb> element. Previously, the <rt> element closed the <rb>
element, but the HTML5 spec changed the parser so that the <rt> does
not close the <rb>. I don't fully understand the issues, but the
discussion on the mailing list makes it sound like this is the better
way to parse Ruby.

In any case, the change in parsing behavior changed how we render this
test case. The bidi aspect are still functioning correctly.

  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/mac/test_expectations.txt:
11:12 AM Changeset in webkit [103718] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed web inspector localizedStrings.js fix.

  • English.lproj/localizedStrings.js:
11:07 AM Changeset in webkit [103717] by leviw@chromium.org
  • 521 edits in branches/subpixellayout/LayoutTests

Adding updated test expectations for Mac for numerous LayoutTests.

11:01 AM Changeset in webkit [103716] by leviw@chromium.org
  • 10 edits in branches/subpixellayout/Source/WebCore

Adding an AppUnit calcValue to length, and propagating LayoutUnits to various methods still on ints.

10:35 AM Changeset in webkit [103715] by rniwa@webkit.org
  • 102 edits
    110 adds
    22 deletes in trunk/LayoutTests

Chromium rebaseline after r103251.

Also remove failing expectations from tables/mozilla/bugs/bug9024.html on Snow Leopard
and svg/clip-path/clip-path-text-and-stroke.svg on all but Leopard.

  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-cg-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-05-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-07-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-08-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-15-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-17-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-18-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-51-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-52-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-55-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-57-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-58-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-59-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-71-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-72-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-75-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-77-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-78-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-79-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-81-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-82-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-85-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-87-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-88-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-89-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-antialiasing-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/20110323: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-win/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/chromium/css2.1/t170602-bdr-conflct-w-05-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-07-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-08-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-15-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-17-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-18-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-51-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-52-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-55-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-57-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-58-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-59-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-71-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-72-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-75-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-77-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-78-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-79-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-81-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-82-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-85-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-87-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-88-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-89-d-expected.png: Added.
  • platform/chromium/test_expectations.txt:
10:23 AM Changeset in webkit [103714] by vsevik@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Introduce support for experimental settings.
​https://bugs.webkit.org/show_bug.cgi?id=75250

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):
(WebInspector.ExperimentsSettings.prototype.get experiments):
(WebInspector.ExperimentsSettings.prototype.get experimentsEnabled):
(WebInspector.ExperimentsSettings.prototype._createExperiment):
(WebInspector.ExperimentsSettings.prototype.set _cleanUpSetting.get var):
(WebInspector.ExperimentsSettings.prototype.set _cleanUpSetting):
(set WebInspector.Experiment):
(WebInspector.Experiment.prototype.get name):
(WebInspector.Experiment.prototype.get title):
(WebInspector.Experiment.prototype.isEnabled):
(WebInspector.Experiment.prototype.setEnabled):
(set WebInspector):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype._createExperimentsWarningSubsection):
(WebInspector.SettingsScreen.prototype._createExperimentCheckbox.listener):
(WebInspector.SettingsScreen.prototype._createExperimentCheckbox):

  • inspector/front-end/helpScreen.css:

(.settings-experiments-warning-subsection-warning):
(.settings-experiments-warning-subsection-message):

9:47 AM Changeset in webkit [103713] by yurys@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

Web Inspector: inspector/dom-statistics.html test fails on Chromium
​https://bugs.webkit.org/show_bug.cgi?id=75258

Disable inspector/dom-statistics.html for now until we finalize MemoryAgent functionality.

Reviewed by Pavel Feldman.

  • inspector/dom-statistics.html-disabled: Renamed from LayoutTests/inspector/dom-statistics.html.
9:46 AM Changeset in webkit [103712] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: exception when scrolling in JavaScriptOutline dialog with empty query
​https://bugs.webkit.org/show_bug.cgi?id=75255

Reviewed by Pavel Feldman.

  • inspector/front-end/JavaScriptOutlineDialog.js:

(WebInspector.JavaScriptOutlineDialog.prototype._onScroll):

9:03 AM EFLWebKit edited by kubo@profusion.mobi
gtk is not needed to build the port (diff)
8:26 AM Changeset in webkit [103711] by pfeldman@chromium.org
  • 31 edits in trunk

Web Inspector: add more annotations on SDK classes.
​https://bugs.webkit.org/show_bug.cgi?id=75247

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/compile-front-end.sh:
  • inspector/front-end/ApplicationCacheModel.js:

(WebInspector.ApplicationCacheDispatcher.prototype.networkStateUpdated):

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._breakpoint):

  • inspector/front-end/Color.js:

(WebInspector.Color.prototype.get shorthex):
(WebInspector.Color.prototype.get hex):
(WebInspector.Color.prototype.get rgb):
(WebInspector.Color.prototype.get hsl):
(WebInspector.Color.prototype.get nickname):
(WebInspector.Color.prototype.hasShortHex):
(WebInspector.Color.prototype._individualRGBValueToFloatValue):
(WebInspector.Color.prototype._rgbStringsToHex):
(WebInspector.Color.prototype._parse.this.nickname.set 2):
(WebInspector.Color.prototype._parse.this.hsla.set 1):
(WebInspector.Color.prototype._parse.this.rgba.set 0):
(WebInspector.Color.prototype._parse.set WebInspector):
(WebInspector.Color.prototype._parse):

  • inspector/front-end/CompilerSourceMapping.js:
  • inspector/front-end/ConsoleModel.js:
  • inspector/front-end/ContentProviders.js:

(WebInspector.ScriptContentProvider):
(WebInspector.ConcatenatedScriptsContentProvider):
(WebInspector.CompilerSourceMappingContentProvider):
(WebInspector.StaticContentProvider):

  • inspector/front-end/CookieParser.js:

(WebInspector.CookieParser.KeyValue):
(WebInspector.CookieParser.prototype.parseCookie):
(WebInspector.CookieParser.prototype.parseSetCookie):
(WebInspector.CookieParser.prototype._extractKeyValue):

  • inspector/front-end/DOMStorage.js:
  • inspector/front-end/Database.js:

(WebInspector.DatabaseDispatcher.prototype.sqlTransactionSucceeded):
(WebInspector.DatabaseDispatcher.prototype.sqlTransactionFailed):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.Location):
(WebInspector.DebuggerModel.prototype._failedToParseScriptSource):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModelResourceBinding.prototype._setContentWithInitialContent):

  • inspector/front-end/ElementsTreeOutline.js:
  • inspector/front-end/HAREntry.js:
  • inspector/front-end/NetworkLog.js:

(WebInspector.NetworkLog.prototype._mainFrameNavigated):

  • inspector/front-end/Placard.js:
  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.fromPrimitiveValue):
(WebInspector.RemoteObject.prototype.setPropertyValue.propertySetCallback):
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.LocalJSONObject.prototype.get hasChildren):
(WebInspector.LocalJSONObject.prototype._children):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.restoreRevisions):
(WebInspector.Resource.prototype.get queryParameters):
(WebInspector.Resource.prototype.get formParameters):
(WebInspector.Resource.prototype.isHttpFamily):

  • inspector/front-end/ResourceCategory.js:
  • inspector/front-end/ResourceUtils.js:
  • inspector/front-end/ScopeChainSidebarPane.js:

(WebInspector.ScopeChainSidebarPane.prototype.update):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.isInlineScript):

  • inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.positionToLocation):

  • inspector/front-end/WelcomeView.js:

(WebInspector.WelcomeView.prototype.addMessage):

  • inspector/front-end/externs.js:

(Array.prototype.upperBound):

LayoutTests:

  • inspector/runtime/runtime-setPropertyValue-expected.txt:
  • inspector/runtime/runtime-setPropertyValue.html:
8:23 AM Changeset in webkit [103710] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Scripts panel tabbed editor does not reopen closed tabs.
​https://bugs.webkit.org/show_bug.cgi?id=75245

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkItemView.js:

(WebInspector.NetworkItemView):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype.closeTab):
(WebInspector.TabbedPane.prototype.selectTab):

8:21 AM Changeset in webkit [103709] by yurys@chromium.org
  • 4 edits
    3 adds in trunk

Web Inspector: report per document JS event listener count
​https://bugs.webkit.org/show_bug.cgi?id=74298

Source/WebCore:

This patch adds JS event listener count to the memory agent
report.

Reviewed by Pavel Feldman.

Test: inspector/dom-statistics.html

  • inspector/Inspector.json:
  • inspector/InspectorMemoryAgent.cpp:

LayoutTests:

Added a test for basic functionality of MemoryAgent.

Reviewed by Pavel Feldman.

  • inspector/dom-statistics-expected.txt: Added.
  • inspector/dom-statistics.html: Added.
  • platform/chromium/inspector/dom-statistics-expected.txt: Added.
7:29 AM Changeset in webkit [103708] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] Go to Function dialog always has a minimal height
​https://bugs.webkit.org/show_bug.cgi?id=75254

Reviewed by Yury Semikhatsky.

  • inspector/front-end/scriptsPanel.css:

(.script-view):

2:26 AM Changeset in webkit [103707] by vsevik@chromium.org
  • 10 edits
    1 add in trunk/Source/WebCore

Web Inspector: Create tabbed editor for scripts panel.
​https://bugs.webkit.org/show_bug.cgi?id=75230

Reviewed by Pavel Feldman.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype.replaceUISourceCodes.get if):
(WebInspector.ScriptsNavigator.prototype.replaceUISourceCodes):
(WebInspector.NavigatorScriptTreeElement.prototype.ondblclick):
(WebInspector.NavigatorScriptTreeElement.prototype.onenter):

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/TabbedEditorContainer.js: Added.
  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype.get visibleView):
(WebInspector.TabbedPane.prototype.get selectedTabId):
(WebInspector.TabbedPane.prototype.closeAllTabs):
(WebInspector.TabbedPane.prototype.changeTabTitle):
(WebInspector.TabbedPane.prototype.changeTabView):
(WebInspector.TabbedPaneTab):
(WebInspector.TabbedPaneTab.prototype.get title):
(WebInspector.TabbedPaneTab.prototype.set title):
(WebInspector.TabbedPaneTab.prototype.get view):
(WebInspector.TabbedPaneTab.prototype.set view):
(WebInspector.TabbedPaneTab.prototype._createTabElement):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/scriptsPanel.css:

(.scripts-views-container):
(.script-view):
(#scripts-editor-container-tabbed-pane .tabbed-pane-header):
(#scripts-editor-container-tabbed-pane .tabbed-pane-header-contents):
(#scripts-editor-container-tabbed-pane .tabbed-pane-content):

2:21 AM Changeset in webkit [103706] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Not reviewed: Rolling out r103703 for breaking Canvas2DLayerChromiumTest.testFullLifecycle.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
(WebCore::Canvas2DLayerChromium::setTextureManager):
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
(WebCore::Canvas2DLayerChromium::pushPropertiesTo):
(WebCore::Canvas2DLayerChromium::unreserveContentsTexture):
(WebCore::Canvas2DLayerChromium::cleanupResources):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:
2:16 AM Changeset in webkit [103705] by Csaba Osztrogonác
  • 1 edit
    1 add in trunk/LayoutTests

[Qt] Unreviewed Xmas gardening after r103617, add additional console message:
CONSOLE MESSAGE: line 2: <html xmlns='​http://www.w3.org/1999/xhtml/'><body><p>Running an XSL-T 1.0 stylesheet with a 2.0 processor.</p></body></html>

  • platform/qt/http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt: Added.
1:01 AM Changeset in webkit [103704] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

WK2: AX: platform/mac/accessibility/search-predicate.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=75039

Patch by Sam White <​samuel.white@rochester.edu> on 2011-12-27
Reviewed by Chris Fleizach.

This test is failing in WK2 because WK2 isn't correctly reporting
visited links as visited. This issue has been reported before as
bug ​https://bugs.webkit.org/show_bug.cgi?id=58334.

I think the most appropriate first action is to add this test to
platform/wk2/Skipped under the existing bug and note the addition
in the existing bugs comments.

WebKitTestRunner has several known bugs

  • platform/wk2/Skipped:
12:25 AM Changeset in webkit [103703] by vangelis@chromium.org
  • 3 edits in trunk/Source/WebCore

[chromium] Bypass the shadow texture copy for accelerated
canvas when running the compositor in single threaded mode.
​https://bugs.webkit.org/show_bug.cgi?id=75146

The texture copy fails on Windows as glCopyTexImage2D() doesn't
support BGRA source textures.
This change also modified Canvas2DLayerChromium::updateCompositorResources
to call glCopyTexSubImage2D() instead of glCopyTexImage2D() so that
the copy can work with texture allocated via the glTexStorage2D
extension.

Reviewed by James Robinson.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
(WebCore::Canvas2DLayerChromium::setTextureManager):
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
(WebCore::Canvas2DLayerChromium::pushPropertiesTo):
(WebCore::Canvas2DLayerChromium::unreserveContentsTexture):
(WebCore::Canvas2DLayerChromium::cleanupResources):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

Dec 26, 2011:

11:30 PM Changeset in webkit [103702] by gyuyoung.kim@samsung.com
  • 6 edits in trunk/Source/WebCore

[EFL][WK2] Implement context menu for EFL port.
​https://bugs.webkit.org/show_bug.cgi?id=74995

Reviewed by Anders Carlsson.

Implement missing ContextMenuEfl class in order to support WK2's context menu.
Because WK2's context menu still needs WebCore's context menu implementation.
And of course, this patch also can be used for WK1 without CROSS_PLATFORM_CONTEXT_MENU
option.

  • platform/ContextMenu.h:
  • platform/ContextMenuItem.h:
  • platform/PlatformMenuDescription.h:
  • platform/efl/ContextMenuEfl.cpp:

(WebCore::ContextMenu::~ContextMenu):
(WebCore::ContextMenu::appendItem):
(WebCore::ContextMenu::insertItem):
(WebCore::ContextMenu::itemCount):
(WebCore::ContextMenu::setPlatformDescription):
(WebCore::ContextMenu::platformDescription):
(WebCore::ContextMenu::releasePlatformDescription):
(WebCore::platformMenuDescription):
(WebCore::contextMenuItemVector):

  • platform/efl/ContextMenuItemEfl.cpp:

(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::~ContextMenuItem):
(WebCore::ContextMenuItem::setType):
(WebCore::ContextMenuItem::type):
(WebCore::ContextMenuItem::setAction):
(WebCore::ContextMenuItem::action):
(WebCore::ContextMenuItem::setTitle):
(WebCore::ContextMenuItem::title):
(WebCore::ContextMenuItem::setChecked):
(WebCore::ContextMenuItem::checked):
(WebCore::ContextMenuItem::setEnabled):
(WebCore::ContextMenuItem::enabled):

11:12 PM Changeset in webkit [103701] by morrita@google.com
  • 3 edits in trunk/Source/WebCore

[Refactoring] Node::setTreeScopeRecursively() doesn't need includeRoot parameter
​https://bugs.webkit.org/show_bug.cgi?id=75240

Reviewed by Anders Carlsson.

No new tests. No behavior change.

  • dom/Node.cpp:

(WebCore::Node::setTreeScopeRecursively):

  • dom/Node.h:
10:27 PM Changeset in webkit [103700] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

<​http://webkit.org/b/75196> REGRESSION(r103643): Command-clicking a link no longer opens a new tab.

r103643 contained some botched copy-paste code that caused the state of the Command key
to be lost when translating from a WebKit2 event to a WebCore event.

Reviewed by Dan Bernstein.

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent): Test for the correct modifier.
(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent): Ditto.
(WebKit::WebKit2PlatformKeyboardEvent::WebKit2PlatformKeyboardEvent): Ditto.
(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent): Ditto.
(WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent): Ditto.

10:14 PM Changeset in webkit [103699] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Errk! OS X build fix.

9:09 PM Changeset in webkit [103698] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Windows build fix.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/JSObject.h:
8:56 PM Changeset in webkit [103697] by barraclough@apple.com
  • 11 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=75231
Fail to throw in strict mode on assign to read only static properties

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

There are three bugs here:

  • symbolTablePut should throw for strict mode accesses.
  • lookupPut should throw for strict mode accesses.
  • NumberConstructor should override put to call lookupPut, to trap assignment to readonly properties.
  • runtime/JSActivation.cpp:

(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::put):

  • runtime/JSActivation.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::put):

  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::put):

  • runtime/JSVariableObject.h:

(JSC::JSVariableObject::symbolTablePut):

  • runtime/Lookup.h:

(JSC::lookupPut):

  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::put):

  • runtime/NumberConstructor.h:

LayoutTests:

Added test cases / updated now-passing results.

  • fast/js/mozilla/strict/15.10.7-expected.txt:
  • fast/js/script-tests/strict-readonly-statics.js: Added.

(testWindowUndefined):
(testNumberMAX_VALUE):

  • fast/js/strict-readonly-statics-expected.txt: Added.
  • fast/js/strict-readonly-statics.html: Added.
8:38 PM Changeset in webkit [103696] by ryuan.choi@samsung.com
  • 6 edits in trunk/Source/WebKit/efl

[EFL] Last parameter of ewk_view_scroll is always true.
​https://bugs.webkit.org/show_bug.cgi?id=75157

Reviewed by Andreas Kling.

Remove unnecessary parameter in ewk_view_scroll and related code, because
it's always true and ewk_view_tile can scroll when it is only true.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::scroll):

  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp:

(_ewk_view_scroll_add):
(ewk_view_scroll):

  • ewk/ewk_view.h:
  • ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_smart_scrolls_process):

7:39 PM Changeset in webkit [103695] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
7:15 PM Changeset in webkit [103694] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed mac/test_expectations.txt update.

  • bidi-override-in-anonymous-block.html
  • platform/mac/test_expectations.txt:
7:07 PM Changeset in webkit [103693] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed mac/test_expectations.txt update.

  • platform/mac/test_expectations.txt:
1:45 PM Changeset in webkit [103692] by Darin Adler
  • 10 edits in trunk/Source/WebCore

Use OwnPtr and OwnArrayPtr in a couple more places
​https://bugs.webkit.org/show_bug.cgi?id=75211

Reviewed by Andreas Kling.

I had a patch with some changes from a while back from going through all sorts of
classes and changing code to use adoptPtr. Most were landed long ago, these are the
ones that still apply.

There are six pieces here that could each be landed separately.
The big one is CSSParser.

  • css/CSSGrammar.y: Update for members and functions that now

return PassOwnPtr instead of raw pointers.

  • css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser): Remove explicit construction
for m_valueList and m_data since OwnPtr and OwnArrayPtr initialize
to zero without it.
(WebCore::CSSParser::~CSSParser): Removed delete m_valueList and
fastFree(m_data) since OwnPtr and OwnArrayPtr handle that.
(WebCore::CSSParser::setupParser): Use adoptArrayPtr and new for
the character array instead of fastFree/fastMalloc. Added get
function calls as needed.
(WebCore::CSSParser::parseValue): Added get function calls as needed.
(WebCore::CSSParser::parseContent): Ditto.
(WebCore::CSSParser::parseFillProperty): Ditto.
(WebCore::CSSParser::parseTransformOriginShorthand): Ditto.
(WebCore::CSSParser::parseBorderImage): Ditto.
(WebCore::CSSParser::parseTransformOrigin): Ditto.
(WebCore::CSSParser::parsePerspectiveOrigin): Ditto.
(WebCore::CSSParser::sinkFloatingValueList): Changed to return PassOwnPtr.
The adoptPtr call is here.
(WebCore::CSSParser::sinkFloatingFunction): Ditto.
(WebCore::CSSParser::markSelectorListStart): Added get function calls as needed.
(WebCore::CSSParser::markSelectorListEnd): Ditto.
(WebCore::CSSParser::markRuleBodyStart): Ditto.
(WebCore::CSSParser::markRuleBodyEnd): Ditto.
(WebCore::CSSParser::markPropertyStart): Ditto.
(WebCore::CSSParser::markPropertyEnd): Ditto.

  • css/CSSParser.h: Moved conditional includes to their own paragraph.

Made sinkFloatingValueList and sinkFloatingFunction return PassOwnPtr.
Made m_valueList an OwnPtr and m_data an OwnArrayPtr.

  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue): Added a call to the get function.

  • html/PluginDocument.h: Made isPluginDocument private. Also marked all the

functions that are overriding here as OVERRIDE since I was touching the header.

  • html/parser/HTMLToken.h:

(WebCore::HTMLTokenTypes::DoctypeData::DoctypeData): Removed an unneeded line
explicitly initializing the base class.

  • page/animation/AnimationBase.cpp:

(WebCore::RefCountedPropertyWrapper::RefCountedPropertyWrapper): Fixed indent.

  • rendering/style/RenderStyle.h: Moved conditional includes to their own paragraph.
  • xml/parser/MarkupTokenBase.h:

(WebCore::MarkupTokenBase::beginDOCTYPE): Removed unneeded parentheses.

11:55 AM Changeset in webkit [103691] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix miss-commit of utf8 change.

Reviewed by Filip Pizlo

Eeep, patch as landed a while ago had no effect! - acidentally landed
modified version of patch used for performance testing.

(This isn't covered by layout tests because layour tests don't use jsc,
and the tests/mozilla tests use latin1, which was already supported!)

Landing changes as intended (and as originally reviewed).

  • jsc.cpp:

(jscSource):

11:47 AM Changeset in webkit [103690] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Extract FileEditor from ScriptsPanel.
​https://bugs.webkit.org/show_bug.cgi?id=75229

Reviewed by Pavel Feldman.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.suggestedFileName):

  • inspector/front-end/ScriptsNavigator.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype.get visibleView):
(WebInspector.ScriptsPanel.prototype._updateScriptViewStatusBarItems):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced.get if):
(WebInspector.ScriptsPanel.EditorContainer):
(WebInspector.ScriptsPanel.EditorContainer.prototype.get currentSourceFrame):
(WebInspector.ScriptsPanel.EditorContainer.prototype.show):
(WebInspector.ScriptsPanel.EditorContainer.prototype.showSourceFrame):
(WebInspector.ScriptsPanel.EditorContainer.prototype.isSourceFrameOpen):
(WebInspector.ScriptsPanel.EditorContainer.prototype.replaceSourceFrames):
(WebInspector.ScriptsPanel.EditorContainer.prototype.setSourceFrameIsDirty):
(WebInspector.ScriptsPanel.EditorContainer.prototype.reset):
(WebInspector.ScriptsPanel.SingleFileEditorContainer):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.get currentSourceFrame):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.show):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.showSourceFrame):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.isSourceFrameOpen):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.replaceSourceFrames):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.setSourceFrameIsDirty):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.reset):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.get domain):
(WebInspector.UISourceCode.prototype.get folderName):
(WebInspector.UISourceCode.prototype.get fileName):
(WebInspector.UISourceCode.prototype.get displayName):
(WebInspector.UISourceCode.prototype._parseURL):

10:13 AM Changeset in webkit [103689] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for ARMv7.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::load16Signed):
(JSC::MacroAssemblerARMv7::load8Signed):

8:40 AM Changeset in webkit [103688] by morrita@google.com
  • 3 edits in trunk/Source/JavaScriptCore

Rename WTF_INLINE, JS_INLINE to HIDDEN_INLINE
​https://bugs.webkit.org/show_bug.cgi?id=74990

Reviewed by Kevin Ollivier.

  • runtime/JSExportMacros.h: Removed JS_INLINE
  • wtf/ExportMacros.h: Renamed WTF_INLINE to HIDDEN_INLINE
8:34 AM Changeset in webkit [103687] by Darin Adler
  • 1 edit
    2 adds in trunk/LayoutTests

Check in expected failures for a couple of tests.

  • platform/mac/media/video-colorspace-yuv420-expected.txt: Added.
  • platform/mac/media/video-colorspace-yuv422-expected.txt: Added.
7:58 AM Changeset in webkit [103686] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Fix a crash in WebProcess when starting a download not initiated by a WebPage
​https://bugs.webkit.org/show_bug.cgi?id=75225

Reviewed by Darin Adler.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::downloadRequest): Check initiatingPage is not
NULL before using it.

7:21 AM Changeset in webkit [103685] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Fix mutation observer build after didMoveToNewDocument change
​https://bugs.webkit.org/show_bug.cgi?id=75224

Reviewed by Hajime Morita.

  • dom/Node.cpp:

(WebCore::willCallDidMoveToNewDocument): Added.
(WebCore::didMoveToNewDocumentWasCalled): Added.
(WebCore::Node::setDocument): Call new debugging function.
(WebCore::Node::didMoveToNewDocument): Ditto. Also use ASSERT_UNUSED
unconditionally rather than UNUSED_PARAM inside and #if. Also added
a new assertion that checks that hte old document was passed through
properly.

6:59 AM Changeset in webkit [103684] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Scripts] Implement iterative match highlighting in the "Go to Function" dialog item list
​https://bugs.webkit.org/show_bug.cgi?id=75226

Reviewed by Pavel Feldman.

  • inspector/front-end/JavaScriptOutlineDialog.js:

(WebInspector.JavaScriptOutlineDialog):
(WebInspector.JavaScriptOutlineDialog.prototype._createSearchRegExp):
(WebInspector.JavaScriptOutlineDialog.prototype._filterFunctions):
(WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown.previousItem):
(WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown.nextItem):
(WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown):
(WebInspector.JavaScriptOutlineDialog.prototype._updateSelection):
(WebInspector.JavaScriptOutlineDialog.prototype._onScroll):
(WebInspector.JavaScriptOutlineDialog.MatchHighlighter):
(WebInspector.JavaScriptOutlineDialog.MatchHighlighter.prototype.highlightViewportItems):
(WebInspector.JavaScriptOutlineDialog.MatchHighlighter.prototype.clearHighlight):
(WebInspector.JavaScriptOutlineDialog.MatchHighlighter.prototype._highlightItem):
(WebInspector.JavaScriptOutlineDialog.MatchHighlighter.prototype._viewportRowRange):

  • inspector/front-end/javaScriptOutlineDialog.css:

(.js-outline-dialog > .container > div.item > span.highlight):

6:30 AM Changeset in webkit [103683] by vsevik@chromium.org
  • 10 edits in trunk

Web Inspector: Extract FileSelector from ScriptsPanel.
​https://bugs.webkit.org/show_bug.cgi?id=75173

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype.get defaultFocusedElement):
(WebInspector.ScriptsNavigator.prototype.show):
(WebInspector.ScriptsNavigator.prototype.setScriptSourceIsDirty):
(WebInspector.ScriptsNavigator.prototype.replaceUISourceCodes):
(WebInspector.ScriptsNavigator.prototype.scriptSelected):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.get defaultFocusedElement):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded.get if):
(WebInspector.ScriptsPanel.prototype.setScriptSourceIsBeingEdited):
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype._showSourceLine):
(WebInspector.ScriptsPanel.prototype._showAndRevealInFileSelector):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):
(WebInspector.ScriptsPanel.prototype._scriptSelected):
(WebInspector.ScriptsPanel.FileSelector):
(WebInspector.ScriptsPanel.FileSelector.prototype.get defaultFocusedElement):
(WebInspector.ScriptsPanel.FileSelector.prototype.show):
(WebInspector.ScriptsPanel.FileSelector.prototype.addUISourceCode):
(WebInspector.ScriptsPanel.FileSelector.prototype.isScriptSourceAdded):
(WebInspector.ScriptsPanel.FileSelector.prototype.revealUISourceCode):
(WebInspector.ScriptsPanel.FileSelector.prototype.setScriptSourceIsDirty):
(WebInspector.ScriptsPanel.FileSelector.prototype.replaceUISourceCodes):
(WebInspector.ScriptsPanel.ComboBoxFileSelector):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.get defaultFocusedElement):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.show):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.showDebugSidebarResizeWidget):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.addUISourceCode):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.isScriptSourceAdded):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.revealUISourceCode):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._innerRevealUISourceCode):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addToHistory):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.replaceUISourceCodes):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._reset):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.setScriptSourceIsDirty):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._createEditorToolbar):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addOptionToFilesSelect.get var):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addOptionToFilesSelect.insertOrdered):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._resetFilesSelect):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._updateBackAndForwardButtons):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._goBack):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._goForward):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._filesSelectChanged):

  • inspector/front-end/inspector.html:
  • inspector/front-end/utilities.js:

():

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting.html:
  • inspector/debugger/source-frame-count.html:
4:39 AM Changeset in webkit [103682] by apavlov@chromium.org
  • 9 edits
    2 adds in trunk/Source/WebCore

Web Inspector: Implement "Go to Function" dialog for JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=75092

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/JavaScriptOutlineDialog.js: Added.

(WebInspector.JavaScriptOutlineDialog.onMouseDown):
(WebInspector.JavaScriptOutlineDialog):
(WebInspector.JavaScriptOutlineDialog.didAddChunk):
(WebInspector.JavaScriptOutlineDialog.install):
(WebInspector.JavaScriptOutlineDialog._show):
(WebInspector.JavaScriptOutlineDialog.createShortcut):
(WebInspector.JavaScriptOutlineDialog.prototype._resizeWindow):
(WebInspector.JavaScriptOutlineDialog.prototype._appendItemElements):
(WebInspector.JavaScriptOutlineDialog.prototype._createSearchRegExp):
(WebInspector.JavaScriptOutlineDialog.prototype._filterFunctions):
(WebInspector.JavaScriptOutlineDialog.prototype._selectFirstItem):
(WebInspector.JavaScriptOutlineDialog.prototype._hide):
(WebInspector.JavaScriptOutlineDialog.prototype._onBlur):
(WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown.previousItem):
(WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown.nextItem):
(WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown):
(WebInspector.JavaScriptOutlineDialog.prototype._scheduleFilter):
(WebInspector.JavaScriptOutlineDialog.prototype._updateSelection):
(WebInspector.JavaScriptOutlineDialog.prototype._onClick):
(WebInspector.JavaScriptOutlineDialog.prototype._onMouseMove):
(WebInspector.JavaScriptOutlineDialog.prototype._highlightFunctionLine):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.get uiSourceCode):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._didBuildOutlineChunk):
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype.requestVisibleScriptOutline):
(WebInspector.ScriptsPanel.prototype._createEditorToolbar):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/javaScriptOutlineDialog.css: Added.

(.js-outline-dialog):
(.js-outline-dialog > input):
(.js-outline-dialog > div.progress):
(.js-outline-dialog > div.container):
(.js-outline-dialog > .container > div.item):
(.js-outline-dialog > .container > div.item.selected):

4:27 AM Changeset in webkit [103681] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: make SDK compilation component self-contained.
​https://bugs.webkit.org/show_bug.cgi?id=75172

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl):
(WebInspector.ConsoleMessageImpl.prototype.get stackTrace):
(WebInspector.ConsoleMessageImpl.prototype.clone):

  • inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated):
(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.prototype.isErrorOrWarning):
(WebInspector.ConsoleMessage.prototype.updateRepeatCount):
(WebInspector.ConsoleMessage.prototype.clone):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):

  • inspector/front-end/ResourceUtils.js:
  • inspector/front-end/UIUtils.js:

(WebInspector.resetToolbarColors):
(WebInspector.populateHrefContextMenu):

2:41 AM Changeset in webkit [103680] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed bad merge fix.

Patch by Hajime Morrita <​morrita@google.com> on 2011-12-26

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::didMoveToNewDocument):

Note: See TracTimeline for information about the timeline view.