⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 30, 2011:

10:02 PM Changeset in webkit [103857] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

Allow disabling accelerated compositing in WebMediaPlayerClient (so audio-only <video> isn't accelerated).
​https://bugs.webkit.org/show_bug.cgi?id=75261

Patch by Ami Fischman <​fischman@chromium.org> on 2011-12-30
Reviewed by Darin Fisher.

  • public/WebMediaPlayerClient.h:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::disableAcceleratedCompositing):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::setClient):

  • src/WebMediaPlayerClientImpl.h:
6:56 PM Changeset in webkit [103856] by kling@webkit.org
  • 8 edits
    2 adds in trunk

Cache and reuse the HTMLTableElement.rows collection.
<​http://webkit.org/b/75398>

Reviewed by Anders Carlsson.

Source/WebCore:

Let HTMLTableElement::rows() cache the returned collection and tie it to the
lifetime of the form.

Test: fast/dom/table-rows-collection-idempotence.html

fast/dom/gc-9.html

  • html/HTMLTableElement.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::rows):

Cache the HTMLTableRowsCollection returned by rows() on the HTMLTableElement.
Remove the per-table CollectionCache and let the collection manage that.

  • html/HTMLTableRowsCollection.h:
  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
(WebCore::HTMLTableRowsCollection::create):

Tell the base class constructor to not retain the back-pointer to the table.

LayoutTests:

  • Update gc-9.html to document the new lifetime characteristics of HTMLTableElement.rows.
  • Add a test to verify that HTMLTableElement.rows returns the same object when called repeatedly.
  • fast/dom/gc-9-expected.txt:
  • fast/dom/gc-9.html:
  • fast/dom/table-rows-collection-idempotence-expected.txt: Added.
  • fast/dom/table-rows-collection-idempotence.html: Added.
6:43 PM Changeset in webkit [103855] by kling@webkit.org
  • 8 edits
    2 adds in trunk

Cache and reuse the HTMLSelectElement.options collection.
<​http://webkit.org/b/75399>

Reviewed by Anders Carlsson.

Source/WebCore:

Let HTMLSelectElement::options() cache the returned collection and tie it to the
lifetime of the form. This shrinks HTMLSelectElement by sizeof(CollectionCache)
minus one pointer.

Test: fast/dom/select-options-collection-idempotence.html

fast/gc-9.html

  • html/HTMLSelectElement.h:
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::options):

Cache the HTMLOptionsCollection returned by options() on the HTMLSelectElement.
Remove the per-select CollectionCache and let the collection manage that.

  • html/HTMLOptionsCollection.h:
  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::create):
(WebCore::HTMLOptionsCollection::HTMLOptionsCollection):

Tell the base class constructor to not retain the back-pointer to the element.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setRecalcListItems):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::invalidateCache):

Added so HTMLSelectElement can invalidate the collection without triggering
unnecessary instantiation of a CollectionCache.

LayoutTests:

  • Update gc-9.html to document the new lifetime characteristics of HTMLSelectElement.options.
  • Add a test to verify that HTMLSelectElement.options returns the same object when called repeatedly.
  • fast/dom/gc-9-expected.txt:
  • fast/dom/gc-9.html:
  • fast/dom/select-options-collection-idempotence-expected.txt: Added.
  • fast/dom/select-options-collection-idempotence.html: Added.
5:10 PM Changeset in webkit [103854] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Enable the [Supplemental] IDL on CMake
​https://bugs.webkit.org/show_bug.cgi?id=75345

Reviewed by Daniel Bates.

This patch enables the [Supplemental] IDL on CMake by changing the build
flow of CMake as follows.

  • Previous build flow:

foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;

}

  • New build flow (See the discussions in bug 72138 for more details):

resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl,

including all attributes in the IDL files that are implementing $idl;

}

Tests: Confirm that build succeeds.

http/tests/websocket/tests/*

  • CMakeLists.txt:
  • UseJSC.cmake: Modified to reflect the new build flow as described above.
  • UseV8.cmake: Ditto.
4:20 PM Changeset in webkit [103853] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] fast/css/absolute-inline-alignment.html fails
​https://bugs.webkit.org/show_bug.cgi?id=75400

Unreviewed, skipping 2 new tests on Qt after r103851.

  • platform/qt/Skipped:
1:27 PM Changeset in webkit [103852] by eric.carlson@apple.com
  • 6 edits in trunk/LayoutTests

[chromium] media/track/track-cue-rendering.html fails
​https://bugs.webkit.org/show_bug.cgi?id=75098

Reviewed by Dan Bernstein.

  • media/media-controls.js:

(textTrackDisplayElement): Don't assume there is only one shadow DOM element used to

display captions.

  • media/track/track-cue-nothing-to-render-expected.txt: Updated.
  • media/track/track-cue-nothing-to-render.html: Fix the test so it checks the track

container and cue text pseudo element properties separately.

  • media/track/track-cue-rendering-expected.txt: Updated for textTrackDisplayElement change.
  • media/track/track-cue-rendering.html: Ditto.
12:58 PM Changeset in webkit [103851] by robert@webkit.org
  • 3 edits
    4 adds in trunk

REGRESSION (r94492): Text is shifted to the right in some buttons in the Mac App Store
​https://bugs.webkit.org/show_bug.cgi?id=74723

Reviewed by Dan Bernstein.

Source/WebCore:

Tests: fast/css/absolute-inline-alignment-2.html

fast/css/absolute-inline-alignment.html

Inline positioned elements in the leading spaces of an inline run need to align to
adjacent text, so add them to the run as they're encountered.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineInfo::LineInfo): Keep a count of positioned objects encountered when

skipping leading whitespace.

(WebCore::LineInfo::runsFromLeadingWhitespace):
(WebCore::LineInfo::resetRunsFromLeadingWhitespace):
(WebCore::LineInfo::incrementRunsFromLeadingWhitespace):
(WebCore::RenderBlock::constructLine): Leading positioned objects should not be considered

when deciding the number of runs in a line. Otherwise they would contribute towards line
height themselves and prevent a free-standing BR following the positioned object from providing a full
20px of height.

(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Since a run containing line-breaks will enter

skipLeadingWhitespace for each new line we reset the count every time so that the count of positioned
objects we encounter only affects the line they appear on. This case is covered by
fast/inline/styledEmptyInlinesWithBRs.html

(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace): Add a run for each inline positioned object

encountered in leading white space. Keep a count of them so that they can be excluded from
the total number of runs in constructLine.

LayoutTests:

  • fast/css/absolute-inline-alignment-2-expected.html: Added.
  • fast/css/absolute-inline-alignment-2.html: Added.
  • fast/css/absolute-inline-alignment-expected.html: Added.
  • fast/css/absolute-inline-alignment.html: Added.
12:53 PM Changeset in webkit [103850] by commit-queue@webkit.org
  • 2 edits
    2 moves in trunk/LayoutTests

media/video-scales-in-media-document.html is Chromium specific
​https://bugs.webkit.org/show_bug.cgi?id=75079

Moves the test into platform/chromium/media and removes the Skipped
entry for gtk.

Patch by Dale Curtis <​dalecurtis@chromium.org> on 2011-12-30
Reviewed by Eric Carlson.

  • platform/chromium/media/video-scales-in-media-document-expected.txt: Renamed from LayoutTests/media/video-scales-in-media-document-expected.txt.
  • platform/chromium/media/video-scales-in-media-document.html: Renamed from LayoutTests/media/video-scales-in-media-document.html.
  • platform/gtk/Skipped:
12:40 PM Changeset in webkit [103849] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove unnecessary [Custom] attribute in CanvasRenderingContext2D.idl
​https://bugs.webkit.org/show_bug.cgi?id=75376

Patch by Raymond Liu <​raymond.liu@intel.com> on 2011-12-30
Reviewed by Adam Barth.

No new tests required.

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:
12:15 PM Changeset in webkit [103848] by kling@webkit.org
  • 10 edits
    2 adds in trunk

Cache and reuse the HTMLFormElement.elements collection.
<​http://webkit.org/b/75375>

Reviewed by Anders Carlsson.

Source/WebCore:

Let HTMLFormElement::elements() cache the returned collection and tie it to the
lifetime of the form. This reduces memory consumption by ~70 kB (on 64-bit) when
viewing your average popular post on reddit.com.

Test: fast/dom/form-elements-collection-idempotence.html

fast/dom/gc-9.html

  • html/HTMLFormElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::elements):

Cache the HTMLFormCollection returned by elements() on the HTMLFormElement.
Remove the per-form CollectionCache and let the collection manage that.

  • html/HTMLCollection.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::create):

Have the HTMLCollection constructor take a bool argument that decides whether
we retain the base node pointer or not. This mechanism is a temporary measure
until all collection types are owned by their respective base nodes.

  • html/HTMLFormCollection.h:
  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::HTMLFormCollection):
(WebCore::HTMLFormCollection::create):

Tell the base class constructor to not retain the back-pointer to the form.

LayoutTests:

  • Update gc-9.html to document the new lifetime characteristics of HTMLFormElement.elements.
  • Add a test to verify that HTMLFormElement.elements returns the same object when called repeatedly.
  • fast/dom/form-elements-collection-idempotence-expected.txt: Added.
  • fast/dom/form-elements-collection-idempotence.html: Added.
  • fast/dom/gc-9-expected.txt:
  • fast/dom/gc-9.html:
11:08 AM Changeset in webkit [103847] by andersca@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add a ParamStorageTraits specialization for RetainPtr
​https://bugs.webkit.org/show_bug.cgi?id=75392

Reviewed by Daniel Bates.

  • wtf/Functional.h:

Add a partial specialization of ParamStorageTraits for RetainPtr<T>.

  • wtf/RetainPtr.h:

Bring in the retainPtr function template from WTF.

11:07 AM Changeset in webkit [103846] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed buildfix after r103841.

  • inspector/InspectorMemoryAgent.cpp:
10:35 AM Changeset in webkit [103845] by kling@webkit.org
  • 5 edits in trunk/Source/WebCore

CSSStyleDeclaration: Only allow setting parent rule at construction.
<​http://webkit.org/b/75391>

Reviewed by Dan Bernstein.

A CSSStyleDeclaration should only ever belong to one CSSRule. Enforce this
at compile-time by replacing setParentRule(CSSRule*) with clearParentRule().

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::~CSSFontFaceRule):

  • css/CSSStyleDeclaration.h:

(WebCore::CSSStyleDeclaration::clearParentRule):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::~CSSStyleRule):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::WebKitCSSKeyframeRule::~WebKitCSSKeyframeRule):

9:32 AM Changeset in webkit [103844] by kling@webkit.org
  • 5 edits
    2 adds in trunk

WebKitCSSKeyframeRule.style.parentRule should point to the keyframe rule.
<​http://webkit.org/b/75336>

Reviewed by Antti Koivisto.

Source/WebCore:

Let CSS animation keyframe rules .style.parentRule point back to the keyframe
board, rather than the keyframes rule containing it.

Test: fast/css/css-keyframe-style-parentRule.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::createKeyframeRule):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::WebKitCSSKeyframeRule::setDeclaration):

Set the CSSMutableStyleDeclaration's parent rule when creating it instead
of in WebKitCSSKeyframeRule::setDeclaration(). Add assertion to make sure
it's only called with declarations already parented to the keyframe rule.

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::append):
(WebCore::WebKitCSSKeyframesRule::deleteRule):

Stop reparenting keyframe rules' style declarations to the keyframes rule.

LayoutTests:

  • fast/css/css-keyframe-style-parentRule-expected.txt: Added.
  • fast/css/css-keyframe-style-parentRule.html: Added.
9:01 AM Changeset in webkit [103843] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

EnvironmentUtilities::stripValuesEndingWithString fails when the variable ends with the search value
​https://bugs.webkit.org/show_bug.cgi?id=75389

Reviewed by Anders Carlsson.

  • Platform/unix/EnvironmentUtilities.cpp:

(WebKit::EnvironmentUtilities::stripValuesEndingWithString): Fixed an off-by-1 error when
examining the character after the match.

5:11 AM Changeset in webkit [103842] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-30

  • DEPS:
2:30 AM Changeset in webkit [103841] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: use typed front-end API in the memory agent
​https://bugs.webkit.org/show_bug.cgi?id=75382

Memory agent now uses generate C++ API for communicating to the front-end.

Reviewed by Pavel Feldman.

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::DOMTreeStatistics::CounterVisitor::CounterVisitor):
(WebCore::DOMTreeStatistics::CounterVisitor::counters):
(WebCore::DOMTreeStatistics::CounterVisitor::visitNode):

2:29 AM Changeset in webkit [103840] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations change for nested-reflection tests.

  • platform/chromium/test_expectations.txt:
2:17 AM Changeset in webkit [103839] by pfeldman@chromium.org
  • 9 edits in trunk/Source

Web Inspector: migrate from "attached" to "compact" styles.
​https://bugs.webkit.org/show_bug.cgi?id=75381

Source/WebCore:

When front-end is docked to right, it should look like "detached", but is still "attached".
Use "compact" mode instead of "attached" mode in the styles to mitigate it.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype.updateSearchLabel):

  • inspector/front-end/Toolbar.js:

(WebInspector.Toolbar.prototype.set compact):
(WebInspector.Toolbar.prototype._toolbarDragStart):
(WebInspector.Toolbar.prototype._toolbarDrag):

  • inspector/front-end/helpScreen.css:

(body.compact .help-window-outer):
(body.compact .help-window-main):
(body.compact .help-window-caption):
(body.compact .help-close-button):
(body.compact .help-content):

  • inspector/front-end/inspector.css:

(body.compact #toolbar):
(body.compact.port-qt #toolbar):
(body.compact.inactive #toolbar):
(body.compact #search-toolbar-label):
(body.compact #toolbar-dropdown-arrow):
(body.compact #search):
(body.compact.port-qt .toolbar-item.close-left, body.compact.port-qt .toolbar-item.close-right):
(body.compact #main):

  • inspector/front-end/inspector.js:

(WebInspector.set attached):
(WebInspector.get isCompactMode):
(WebInspector.get _setCompactMode):
(WebInspector._installDockToRight.listener.get if):
(WebInspector._installDockToRight.listener):

  • inspector/front-end/inspectorCommon.css:

(body.dock-to-right):
(body.dock-to-right.inactive):

Source/WebKit/chromium:

Reviewed by Yury Semikhatsky.

When front-end is docked to right, it should look like "detached", but is still "attached".
Use "compact" mode instead of "attached" mode in the styles to mitigate it.

  • src/js/devTools.css:

(body.compact #toolbar):

1:20 AM Changeset in webkit [103838] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r103794.
​http://trac.webkit.org/changeset/103794
​https://bugs.webkit.org/show_bug.cgi?id=75379

the ASSERT is triggered by several tests (Requested by
jchaffraix on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-30

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::addChild):
(WebCore::RenderTable::layout):
(WebCore::RenderTable::recalcSections):
(WebCore::RenderTable::outerBorderAfter):
(WebCore::RenderTable::sectionAbove):
(WebCore::RenderTable::sectionBelow):

  • rendering/RenderTable.h:

(WebCore::RenderTable::header):
(WebCore::RenderTable::footer):
(WebCore::RenderTable::firstBody):
(WebCore::RenderTable::hasSections):
(WebCore::RenderTable::topSection):

12:43 AM Changeset in webkit [103837] by dslomov@google.com
  • 6 edits
    1 delete in trunk/Source/WebKit/chromium

​https://bugs.webkit.org/show_bug.cgi?id=75373
[Chromium] Remove WebWorkerClient.h
After coordinated patch in chromium, WebWorkerClient alias for WebSharedWorkerClient is no longer needed.

Reviewed by Adam Barth.

  • WebKit.gyp:
  • public/WebFrameClient.h:
  • public/WebWorkerClient.h: Removed.
  • src/WebSharedWorkerImpl.h:
  • src/WebWorkerBase.cpp:
  • src/WebWorkerClientImpl.h:

Dec 29, 2011:

10:24 PM Changeset in webkit [103836] by commit-queue@webkit.org
  • 6 edits
    1 copy in trunk/Source/WebKit/chromium

Unreviewed, rolling out r103831.
​http://trac.webkit.org/changeset/103831
​https://bugs.webkit.org/show_bug.cgi?id=75377

broke chromium build (Requested by dslomov_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-29

  • WebKit.gyp:
  • public/WebFrameClient.h:
  • public/WebWorkerClient.h: Copied from Source/WebKit/chromium/src/WebWorkerBase.cpp.
  • src/WebSharedWorkerImpl.h:
  • src/WebWorkerBase.cpp:
  • src/WebWorkerClientImpl.h:
10:01 PM Changeset in webkit [103835] by pfeldman@chromium.org
  • 7 edits in trunk/Source

Web Inspector: enable dock-to-right view (still need embedders to support it).
​https://bugs.webkit.org/show_bug.cgi?id=75360

Patch by Pavel Feldman <​pfeldman@google.com> on 2011-12-29
Reviewed by Yury Semikhatsky.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

  • inspector/front-end/inspector.js:

(WebInspector.set attached):
(WebInspector._renderAsAttached.get return):
(WebInspector._renderAsAttached):
(WebInspector._installDockToRight.updateToolbar):

Source/WebKit/chromium:

  • src/js/DevTools.js:
8:59 PM Changeset in webkit [103834] by mitz@apple.com
  • 2 edits in trunk/Tools

debug-safari --no-saved-state fails to start the debugger
​https://bugs.webkit.org/show_bug.cgi?id=75374

Reviewed by Sam Weinig.

  • Scripts/webkitdirs.pm:

(execMacWebKitAppForDebugging): Pass the --args option to gdb so that it passes arguments to
the executable being debugged.

8:50 PM Changeset in webkit [103833] by weinig@apple.com
  • 6 edits
    1 add in trunk

It should be easier to iterate a Vector backwards
​https://bugs.webkit.org/show_bug.cgi?id=75359

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

Adds Vector::rbegin(), Vector::rend(), and Vector::reversed(),
a new proxy driven way to access a vector backwards. One can use
reversed() in a range-based for loop like so:

for (auto val: myVector.reversed())

doSomething(val)

  • wtf/Vector.h:

(WTF::Vector::~Vector):
Fix style.

(WTF::Vector::rbegin):
(WTF::Vector::rend):
Added using standard adaptor std::reverse_iterator.

(WTF::Vector::reversed):
(WTF::Vector::VectorReverseProxy::begin):
(WTF::Vector::VectorReverseProxy::end):
Add proxy similar to one used in HashMap for keys() and values()
which allows access to a Vector backwards for use in range-based
for loops.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Add new Vector test.

  • TestWebKitAPI/Tests/Vector.cpp: Added.

(TestWebKitAPI::TEST):
Test Vector iterators, reverse_iterators and new reversed proxy.

6:28 PM Changeset in webkit [103832] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Use IDL overloads in AudioContext.idl for createBuffer
​https://bugs.webkit.org/show_bug.cgi?id=75293

Patch by Raymond Liu <​raymond.liu@intel.com> on 2011-12-29
Reviewed by Adam Barth.

No new tests required.

  • bindings/js/JSAudioContextCustom.cpp:
  • bindings/v8/custom/V8AudioContextCustom.cpp:
  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::createBuffer):

  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
6:13 PM Changeset in webkit [103831] by dslomov@google.com
  • 6 edits
    1 delete in trunk/Source/WebKit/chromium

​https://bugs.webkit.org/show_bug.cgi?id=75373
[Chromium] Remove WebWorkerClient.h
After coordinated patch in chromium, WebWorkerClient alias for WebSharedWorkerClient is no longer needed.

Reviewed by Adam Barth.

  • WebKit.gyp:
  • public/WebFrameClient.h:
  • public/WebWorkerClient.h: Removed.
  • src/WebSharedWorkerImpl.h:
  • src/WebWorkerBase.cpp:
  • src/WebWorkerClientImpl.h:
3:49 PM Changeset in webkit [103830] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, add a bug number to a failing test.

  • platform/chromium/test_expectations.txt:
3:40 PM Changeset in webkit [103829] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectation changes to skip array-splice.html.

  • platform/chromium/test_expectations.txt:
3:30 PM Changeset in webkit [103828] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLDivElement: Remove unnecessary variable in parseMappedAttribute().
<​http://webkit.org/b/75363>

Reviewed by Daniel Bates.

  • html/HTMLDivElement.cpp:

(WebCore::HTMLDivElement::parseMappedAttribute):

3:27 PM Changeset in webkit [103827] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLParagraphElement: Remove unnecessary variable in parseMappedAttribute().
<​http://webkit.org/b/75362>

Reviewed by Daniel Bates.

  • html/HTMLParagraphElement.cpp:

(WebCore::HTMLParagraphElement::parseMappedAttribute):

3:25 PM Changeset in webkit [103826] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> for Document's named item collection caches.
<​http://webkit.org/b/75335>

Reviewed by Daniel Bates.

  • dom/Document.cpp:

(WebCore::Document::~Document):

Remove now-unneeded deleteAllValues() loop.

(WebCore::Document::nameCollectionInfo):

Use add() instead of find()/add() to avoid one extra hash lookup.

  • dom/Document.h:

Switch the value type of m_nameCollectionInfo to use OwnPtr.

3:22 PM Changeset in webkit [103825] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/platform/AppUnit.h

Fixing round and ceil for negative numbers and removing an incorrect optimization from round due to the results of Emil's microbenchmark

2:49 PM Changeset in webkit [103824] by commit-queue@webkit.org
  • 6 edits in trunk

mfenced skips the first separator if the separators attribute contains multiple separators
​https://bugs.webkit.org/show_bug.cgi?id=57697

Patch by David Barton <Dave Barton> on 2011-12-29
Reviewed by Dan Bernstein.

Source/WebCore:

Added 2 test cases.

  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::addChild):

LayoutTests:

  • mathml/presentation/fenced-mi.xhtml:
    • Added 2 test cases.
  • platform/mac/mathml/presentation/fenced-mi-expected.png:
  • platform/mac/mathml/presentation/fenced-mi-expected.txt:
2:40 PM Changeset in webkit [103823] by barraclough@apple.com
  • 11 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=75140

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Start cleaning up JSArray construction. JSArray has a set of create methods,
one of which (currently) takes a 'creation mode' enum parameter. Based on that
parameter, the constructor does one of two completely different things. If the
parameter is 'CreateInitialized' it creates an array, setting the length, but
does not eagerly allocate a storage vector of the specified length. A small
(BASE_VECTOR_LEN sized) initial vector will be allocated, and cleared, property
access to the vector will read the hole value (return undefined). The alternate
usage of this method ('CreateCompact') does something very different. It tries
to create an array of the requested length, and also allocates a storage vector
large enough to hold all properties. It does not clear the storage vector,
leaving the memory uninitialized and requiring the user to call a method
'uncheckedSetIndex' to initialize values in the vector.

This patch factors out these two behaviours, moving the 'CreateCompact' mode
into its own method, 'tryCreateUninitialized' (matching the naming for this
functionality in the string classes). 'tryCreateUninitialized' may return 0 if
memory allocation fails during construction of the object. The construction
pattern changes such that values added during initialization will be marked if
a GC is triggered during array allocation. 'CreateInitialized' no longer need
be passed to create a normal, fully constructed array with a length, and this
method is merged with the version of 'create' that does not take an initial
length (length parameter defaults to 0).

(JSC::constructArrayWithSizeQuirk):

  • removed 'CreateInitialized' argument
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncSplice):

  • changed to call 'tryCreateUninitialized'
  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncBind):

  • changed to call 'tryCreateUninitialized'
  • runtime/JSArray.cpp:

(JSC::JSArray::JSArray):

  • initialize m_storage to null; if construction fails, make destruction safe

(JSC::JSArray::finishCreation):

  • merge versions of this method, takes an initialLength parameter defaulting to zero

(JSC::JSArray::tryFinishCreationUninitialized):

  • version of 'finishCreation' that tries to eagerly allocate storage; may fail & return 0

(JSC::JSArray::~JSArray):

  • check for null m_storage, in case array construction failed.

(JSC::JSArray::increaseVectorPrefixLength):

  • runtime/JSArray.h:

(JSC::JSArray::create):

  • merge versions of this method, takes an initialLength parameter defaulting to zero

(JSC::JSArray::tryCreateUninitialized):

  • version of 'create' that tries to eagerly allocate storage; may fail & return 0

(JSC::JSArray::initializeIndex):
(JSC::JSArray::completeInitialization):

  • used in conjunction with 'tryCreateUninitialized' to initialize the array
  • runtime/JSGlobalObject.h:

(JSC::constructEmptyArray):

  • removed 'CreateInitialized' argument
  • runtime/RegExpConstructor.cpp:

(JSC::RegExpMatchesArray::finishCreation):

  • removed 'CreateInitialized' argument

LayoutTests:

Added test case.

  • fast/js/script-tests/array-splice.js:
2:29 PM Changeset in webkit [103822] by tony@chromium.org
  • 2 edits
    1 move in trunk/LayoutTests

[chromium] Unreviewed, unskip http/tests/plugins/geturlnotify-from-npp-destroystream.html
since it passes on my Mac Chromium build. Move plugins/inner-html-display-none-expected.txt
from chromium-win to chromium-- it's a V8 specific result.

  • platform/chromium/plugins/inner-html-display-none-expected.txt: Renamed from LayoutTests/platform/chromium-win/plugins/inner-html-display-none-expected.txt.
  • platform/chromium/test_expectations.txt:
2:18 PM Changeset in webkit [103821] by commit-queue@webkit.org
  • 2 edits
    2 moves in trunk/LayoutTests

Unreviewed, rolling out r103808.
​http://trac.webkit.org/changeset/103808
​https://bugs.webkit.org/show_bug.cgi?id=75370

Tests failed on Chrome Canary bots. (Requested by atwilson on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-29

  • media/video-scales-in-media-document-expected.txt: Renamed from LayoutTests/platform/chromium/media/video-scales-in-media-document-expected.txt.
  • media/video-scales-in-media-document.html: Renamed from LayoutTests/platform/chromium/media/video-scales-in-media-document.html.
  • platform/gtk/Skipped:
2:02 PM Changeset in webkit [103820] by tony@chromium.org
  • 2 edits
    13 adds in trunk/LayoutTests

[chromium] Unreviewed, rebaseline new flexbox repaint tests on chromium mac
and remove http/tests/plugins/geturlnotify-from-npp-destroystream.html
from test_expectations.txt since it's passing on Win/Linux.

  • platform/chromium-cg-mac-leopard/css3/flexbox/repaint-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css3/flexbox/repaint-rtl-column-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css3/flexbox/repaint-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css3/flexbox/repaint-rtl-column-expected.png: Added.
  • platform/chromium-mac-leopard/css3/flexbox/repaint-expected.png: Added.
  • platform/chromium-mac-leopard/css3/flexbox/repaint-rtl-column-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/flexbox/repaint-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/flexbox/repaint-rtl-column-expected.png: Added.
  • platform/chromium/test_expectations.txt:
1:45 PM Changeset in webkit [103819] by tony@chromium.org
  • 2 edits
    1 copy
    2 moves
    4 deletes in trunk/LayoutTests

[chromium] Unreviewed, add a png baseline for
mouse-click-plugin-clears-selection on chromium-win and re-add 2 flaky svg tests.

  • platform/chromium-cg-mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Removed.
  • platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png: Removed.
  • platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Removed.
  • platform/chromium-win/plugins/mouse-click-plugin-clears-selection-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/plugins/mouse-click-plugin-clears-selection-expected.png.
  • platform/chromium-win/plugins/mouse-click-plugin-clears-selection-expected.txt: Renamed from LayoutTests/platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.txt.
  • platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/plugins/mouse-click-plugin-clears-selection-expected.png.
  • platform/chromium/test_expectations.txt:
1:27 PM Changeset in webkit [103818] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add a retainPtr function template
​https://bugs.webkit.org/show_bug.cgi?id=75365

Reviewed by Dan Bernstein.

This makes it easier to make a RetainPtr using template argument deduction, which
is useful when passing RetainPtr objects as function arguments.

  • wtf/RetainPtr.h:

(WTF::retainPtr):

12:34 PM Changeset in webkit [103817] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

Enable the [Supplemental] IDL on Qt.
​https://bugs.webkit.org/show_bug.cgi?id=75274

Reviewed by Andreas Kling.

​http://trac.webkit.org/changeset/103783 broke the Qt SL bot.
This patch fixes the problem by using 'tr' rather than 'sed' which
seems to be more consistent between Mac and Linux.

  • DerivedSources.pri:
12:18 PM Changeset in webkit [103816] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

animation-drt-api-multiple-keyframes.html cannot possibly fail
​https://bugs.webkit.org/show_bug.cgi?id=73112

Reviewed by Simon Fraser.

Output a FAIL message when we fail to pause the animation. This matches the
failure mode before <​https://trac.webkit.org/changeset/84873> (bug #59389).

Additionally, fixes an issue where we paused at a time after cessation of the
animation following <​https://trac.webkit.org/changeset/84873>. Instead, we
should pause at a time before cessation of the animation.

  • animations/animation-drt-api-multiple-keyframes.html:
11:41 AM Changeset in webkit [103815] by leviw@chromium.org
  • 132 edits in branches/subpixellayout/LayoutTests

More updated LayoutTest expectations for Mac

11:35 AM Changeset in webkit [103814] by leviw@chromium.org
  • 7 edits in branches/subpixellayout/Source/WebCore/rendering

Fixing two painting issues with composited widgets: properly aligning the GraphicsLayer to the renderer's pixel boundaries (when desireable) and using pixelSnappedIntRect instead of enclosingIntRect when setting the RenderWidget's frameRect.

11:08 AM Changeset in webkit [103813] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Scripts navigator should support incremental search by typing.
​https://bugs.webkit.org/show_bug.cgi?id=75349

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype.get defaultFocusedElement):
(WebInspector.ScriptsNavigator.prototype.show):
(WebInspector.ScriptsNavigator.prototype._reset):
(WebInspector.NavigatorTreeOutline):
(WebInspector.NavigatorTreeOutline.prototype.scriptTreeElements):
(WebInspector.NavigatorTreeOutline.prototype.searchStarted):
(WebInspector.NavigatorTreeOutline.prototype.searchFinished):
(WebInspector.BaseNavigatorTreeElement.prototype.onreveal):
(WebInspector.BaseNavigatorTreeElement.prototype.set titleText):
(WebInspector.BaseNavigatorTreeElement.prototype.matchesSearchText):

  • inspector/front-end/inspector.css:

(.outline-disclosure ol.search-match-not-found li.selected .selection):
(.outline-disclosure ol.search-match-found li.selected):
(.outline-disclosure ol.search-match-found li.selected *):
(.outline-disclosure ol.search-match-found li.parent.selected::before):
(.outline-disclosure ol.search-match-found li.parent.expanded.selected::before):

  • inspector/front-end/scriptsPanel.css:

(#scripts-navigator-tree-search-box):
(#scripts-navigator-tree-search-box.visible):
(#scripts-navigator-tree-search-box > input):
(.scripts.panel .navigator .search-match-found li.selected .selection):
(.scripts.panel .navigator .search-match-not-found li.selected .selection):
(.scripts.panel .navigator .searching li.selected .selection):

  • inspector/front-end/treeoutline.js:

(TreeOutline):
(TreeOutline.prototype._treeKeyPress):
(TreeOutline.prototype._startSearch.focusSearchInput):
(TreeOutline.prototype._startSearch):
(TreeOutline.prototype._searchTextChanged):
(TreeOutline.prototype._showSearchMatchElement):
(TreeOutline.prototype._searchInputKeyDown):
(TreeOutline.prototype._nextSearchMatch):
(TreeOutline.prototype._previousSearchMatch):
(TreeOutline.prototype._searchInputBlur):
(TreeOutline.prototype._searchFinished):
(TreeOutline.prototype.stopSearch):

10:56 AM Changeset in webkit [103812] by vsevik@chromium.org
  • 10 edits
    2 adds in trunk

Web Inspector: Scripts navigator should trim long file names and show full url in tooltip.
​https://bugs.webkit.org/show_bug.cgi?id=75343

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/ui-source-code-display-name.html

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype.setScriptSourceIsDirty):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.EditorContainer.prototype.showSourceFrame):
(WebInspector.ScriptsPanel.EditorContainer.prototype.replaceSourceFrames):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.showSourceFrame):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.replaceSourceFrames):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype._appendSourceFrameTab):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._replaceSourceFrameTab.get if):
(WebInspector.TabbedEditorContainer.prototype._replaceSourceFrameTab):
(WebInspector.TabbedEditorContainer.prototype.get replaceSourceFrames):
(WebInspector.TabbedEditorContainer.prototype.reset):

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype.appendTab):
(WebInspector.TabbedPane.prototype.changeTabTooltip):
(WebInspector.TabbedPaneTab):
(WebInspector.TabbedPaneTab.prototype.get tooltip):
(WebInspector.TabbedPaneTab.prototype.set tooltip):
(WebInspector.TabbedPaneTab.prototype._createTabElement):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype._parseURL):

  • inspector/front-end/utilities.js:

():

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/ui-source-code-display-name-expected.txt: Added.
  • inspector/debugger/ui-source-code-display-name.html: Added.
10:52 AM Changeset in webkit [103811] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

getComputedStyle for margin is not implemented.
​https://bugs.webkit.org/show_bug.cgi?id=75358

Reviewed by Andreas Kling.

Source/WebCore:

Implement getComputedStyle for margin.

Test: fast/css/getComputedStyle/getComputedStyle-margin-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add test to cover that we return correct values.

  • fast/css/getComputedStyle/getComputedStyle-margin-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-margin-shorthand.html: Added.
10:44 AM Changeset in webkit [103810] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> in RenderSVGResourcePattern
​https://bugs.webkit.org/show_bug.cgi?id=75361

Reviewed by Andreas Kling.

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::removeAllClientsFromCache):
(WebCore::RenderSVGResourcePattern::removeClientFromCache):
(WebCore::RenderSVGResourcePattern::applyResource): use HashMap::add() to avoid
looking up the hash twice.

  • rendering/svg/RenderSVGResourcePattern.h: rename m_pattern to m_patternMap to

improve readability a little bit.

10:36 AM Changeset in webkit [103809] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

getComputedStyle for padding is not implemented.
​https://bugs.webkit.org/show_bug.cgi?id=75352

Reviewed by Andreas Kling.

Source/WebCore:

Implement getComputedStyle for padding shorthand property.

Test: fast/css/getComputedStyle/getComputedStyle-padding-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add test to cover that we return correct values.

  • fast/css/getComputedStyle/getComputedStyle-padding-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-padding-shorthand.html: Added.
10:21 AM Changeset in webkit [103808] by commit-queue@webkit.org
  • 2 edits
    2 moves in trunk/LayoutTests

[GTK] media/video-scales-in-media-document.html fails
​https://bugs.webkit.org/show_bug.cgi?id=75079

Moves the test into platform/chromium/media and removes the Skipped
entry for gtk.

Patch by Dale Curtis <​dalecurtis@chromium.org> on 2011-12-29
Reviewed by Eric Carlson.

  • platform/chromium/media/video-scales-in-media-document-expected.txt: Renamed from LayoutTests/media/video-scales-in-media-document-expected.txt.
  • platform/chromium/media/video-scales-in-media-document.html: Renamed from LayoutTests/media/video-scales-in-media-document.html.
  • platform/gtk/Skipped:
9:52 AM Changeset in webkit [103807] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> in OriginAccessMap
​https://bugs.webkit.org/show_bug.cgi?id=75327

Reviewed by Andreas Kling.

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::resetOriginAccessWhitelists):

9:22 AM Changeset in webkit [103806] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Remove unused m_signalListeners from WorkQueue
​https://bugs.webkit.org/show_bug.cgi?id=75354

Reviewed by Andreas Kling.

This is unused since r76507.

  • Platform/WorkQueue.h:
  • Platform/qt/WorkQueueQt.cpp:

(WorkQueue::platformInvalidate):

9:12 AM Changeset in webkit [103805] by podivilov@chromium.org
  • 7 edits in trunk

Web Inspector: support sourceMappingURL magic comment.
​https://bugs.webkit.org/show_bug.cgi?id=75356

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::findSourceMapURL):

  • inspector/ContentSearchUtils.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::sourceMapURLForScript):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping-debug.html:
  • http/tests/inspector/resources/compiled.js:
9:08 AM Changeset in webkit [103804] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Suggest pop-over doesn't hide on tab switch
​https://bugs.webkit.org/show_bug.cgi?id=73611

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.willHide):

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.acceptSuggestion):
(WebInspector.TextPrompt.prototype.hideSuggestBox):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):

9:02 AM Changeset in webkit [103803] by apavlov@chromium.org
  • 14 edits
    1 add in trunk

Web Inspector: Implement CSS selector profiler
​https://bugs.webkit.org/show_bug.cgi?id=74004

Reviewed by Pavel Feldman.

Source/WebCore:

This implementation of CSS selector profiler measures the total time required to match a certain selector
against DOM nodes and apply the style declaration properties to the particular element,
as well as the number of selector matches (i.e. the number of nodes that matched the selector.)
The results are approximate due to internal matching algorithm optimizations (shared styles et al.)
Multiple selectors with the same selectorText are coalesced into a single record.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/CSSSelectorProfileView.js: Added.

(WebInspector.CSSSelectorDataGridNode):
(WebInspector.CSSSelectorDataGridNode.prototype.get rawData):
(WebInspector.CSSSelectorProfileView):
(WebInspector.CSSSelectorProfileView.prototype.get statusBarItems):
(WebInspector.CSSSelectorProfileView.prototype.get profile):
(WebInspector.CSSSelectorProfileView.prototype.set profile):
(WebInspector.CSSSelectorProfileView.prototype._createProfileNodes):
(WebInspector.CSSSelectorProfileView.prototype.rebuildGridItems):
(WebInspector.CSSSelectorProfileView.prototype.refreshData):
(WebInspector.CSSSelectorProfileView.prototype.refreshShowAsPercents):
(WebInspector.CSSSelectorProfileView.prototype._sortProfile.get selectorComparator):
(WebInspector.CSSSelectorProfileView.prototype._sortProfile.timeComparator):
(WebInspector.CSSSelectorProfileView.prototype._sortProfile.matchesComparator):
(WebInspector.CSSSelectorProfileView.prototype._sortProfile):
(WebInspector.CSSSelectorProfileType):
(WebInspector.CSSSelectorProfileType.prototype.get buttonTooltip):
(WebInspector.CSSSelectorProfileType.prototype.buttonClicked):
(WebInspector.CSSSelectorProfileType.prototype.get treeItemTitle):
(WebInspector.CSSSelectorProfileType.prototype.get description):
(WebInspector.CSSSelectorProfileType.prototype.reset):
(WebInspector.CSSSelectorProfileType.prototype.isRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype.setRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype.startRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype.stopRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype.createSidebarTreeElementForProfile):
(WebInspector.CSSSelectorProfileType.prototype.createView):

  • inspector/front-end/DetailedHeapshotView.js:
  • inspector/front-end/ProfileView.js:
  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileType.prototype.reset):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype._removeTemporaryProfile):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
(WebInspector.ProfilerDispatcher.prototype.addProfileHeader):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/profilesPanel.css:

LayoutTests:

  • inspector/profiler/detailed-heapshots-test.js:

(initialize_DetailedHeapshotTest):

  • inspector/profiler/profiler-test.js:

(initialize_ProfilerTest.InspectorTest.startProfilerTest.startTest):
(initialize_ProfilerTest.InspectorTest.startProfilerTest):

8:39 AM Changeset in webkit [103802] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] Context menu is hidden right after showing it when first menu item is not disabled
​https://bugs.webkit.org/show_bug.cgi?id=75357

Reviewed by Martin Robinson.

The problem is that we are passing GDK_CURRENT_TIME (which is 0)
to gtk_popup_menu, because the events are async and
gtk_get_current_event is NULL when calling gtk_menu_popup. GtkMenu
has a timeout to decide whether the press-release was fast enough
and ignore the button release event in that case. That way, a
normal right click shows the menu while a long press hides the
menu when the button is released. So, we need to know the real time
when the right button was pressed and pass it to gtk_popup_menu.

  • UIProcess/WebPageProxy.h: Make

currentlyProcessedMouseDownEvent() public.

  • UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::WebContextMenuProxyGtk::showContextMenu): Use
WebPageProxy::currentlyProcessedMouseDownEvent() to get the
current mouse event and pass its button number and time to
gtk_popup_menu.

8:33 AM Changeset in webkit [103801] by Carlos Garcia Campos
  • 6 edits in trunk/Source/WebKit2

[GTK] Fix several conding style issues in WebKit2 GTK+ code
​https://bugs.webkit.org/show_bug.cgi?id=75339

Reviewed by Martin Robinson.

In addition to the WebKit coding style, code in UIProcess/API/gtk
should follow style and conventions described here
​http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

  • UIProcess/API/gtk/WebKitSettings.cpp: Remove trailing whitespaces.

(webkit_settings_class_init): Remove trailing whitespaces, fix
indentation issues in API doc comments, add missing trailing to
some properties.
(webkit_settings_set_enable_fullscreen): Move the code after
get_enable_fullscreen() for consistency.

  • UIProcess/API/gtk/WebKitSettings.h: Remove trailing

whitespaces. Fix * placement and line up parameters.

  • UIProcess/API/gtk/WebKitWebView.cpp: Remove several empty lines.

(webkit_web_view_class_init): Mark property nicks and blurbs for translation.
(webkitWebViewSetTitle): Remove trailing whitespaces.

  • UIProcess/API/gtk/WebKitWebView.h: Line up parameters.
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: Use the angle-bracket

form for including file from WebCore and wtf. Use GRefPtr for
GtkIMContext and bool instead of gboolean. Use the placement new
syntax for private struct instead of new/delete.
(webkitWebViewBaseRealize):
(webkitWebViewBaseFinalize):
(webkit_web_view_base_init):
(webkitWebViewBaseFocusInEvent):
(webkitWebViewBaseFocusOutEvent):
(webkitWebViewBaseKeyPressEvent): Remove trailing whitespaces.
(webkitWebViewBaseKeyReleaseEvent):
(webkit_web_view_base_class_init):
(webkitWebViewBaseGetIMContext):

7:08 AM Changeset in webkit [103800] by commit-queue@webkit.org
  • 3 edits
    4 deletes in trunk

Unreviewed, rolling out r103798.
​http://trac.webkit.org/changeset/103798
​https://bugs.webkit.org/show_bug.cgi?id=75353

some small scrollbar differences are making the tests fail on
several platforms (Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-29

Source/WebCore:

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositionsAfterScroll):

LayoutTests:

  • fast/layers/scroll-with-transform-composited-layer-expected.html: Removed.
  • fast/layers/scroll-with-transform-composited-layer.html: Removed.
  • fast/layers/scroll-with-transform-layer-expected.html: Removed.
  • fast/layers/scroll-with-transform-layer.html: Removed.
6:58 AM Changeset in webkit [103799] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Focus of the DOM tree is not restored when switching to the Elements panel
​https://bugs.webkit.org/show_bug.cgi?id=75351

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.wasShown):

6:06 AM Changeset in webkit [103798] by jchaffraix@webkit.org
  • 3 edits
    4 adds in trunk

REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling
​https://bugs.webkit.org/show_bug.cgi?id=67100

Reviewed by Dan Bernstein.

Source/WebCore:

Tests: fast/layers/scroll-with-transform-composited-layer-expected.html

fast/layers/scroll-with-transform-composited-layer.html
fast/layers/scroll-with-transform-layer-expected.html
fast/layers/scroll-with-transform-layer.html

The regression came from a previous optimization that was wrongly kept after r93614.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
Remove the early return for transformed layer. This change worked as we used
to call updateLayerPositions from scrollTo which would call updateLayerPosition on
all our descendants. After r93614, this is no longer the case and we explicitely need
to call updateLayerPosition on our descendants from updateLayerPositionsAfterScroll.

LayoutTests:

Added 2 ref tests for scrolling inside a transformed layers (either composited
or not).

  • fast/layers/scroll-with-transform-composited-layer-expected.html: Added.
  • fast/layers/scroll-with-transform-composited-layer.html: Added.
  • fast/layers/scroll-with-transform-layer-expected.html: Added.
  • fast/layers/scroll-with-transform-layer.html: Added.
5:28 AM Changeset in webkit [103797] by apavlov@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Tree views can be collapsed/hidden using the keyboard arrows
​https://bugs.webkit.org/show_bug.cgi?id=46272

Reviewed by Yury Semikhatsky.

WebInspector.SidebarSectionTreeElement which is not selectable has also been made non-collapsible
and expanded by default.

  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._registerProfileType):

  • inspector/front-end/SidebarTreeElement.js:

(WebInspector.SidebarSectionTreeElement):
(WebInspector.SidebarSectionTreeElement.prototype.selectable.false.collapse):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):

5:10 AM Changeset in webkit [103796] by pfeldman@chromium.org
  • 11 edits in trunk/Source

Web Inspector: [chromium] pass dock to side request to the embedder.
​https://bugs.webkit.org/show_bug.cgi?id=75344

Reviewed by Yury Semikhatsky.

Source/WebCore:

I'd like to enable dock-to-right for the front-end window. This is a background work
to pass control flow from the front-end to the front-end host.

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.h:

(WebCore::InspectorFrontendClientLocal::requestSetDockSide):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::requestSetDockSide):

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.requestAttachWindow):
(.WebInspector.InspectorFrontendHostStub.prototype.requestDetachWindow):
(.WebInspector.InspectorFrontendHostStub.prototype.requestSetDockSide):

Source/WebKit/chromium:

  • public/WebDevToolsFrontendClient.h:

(WebKit::WebDevToolsFrontendClient::requestSetDockSide):

  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::requestSetDockSide):

  • src/InspectorFrontendClientImpl.h:
4:16 AM Changeset in webkit [103795] by podivilov@chromium.org
  • 13 edits in trunk

Web Inspector: add "enable source maps" checkbox setting.
​https://bugs.webkit.org/show_bug.cgi?id=75311

Reviewed by Pavel Feldman.

Source/WebCore:

When "enable source maps" is on, all auto detected source maps are silently applied.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DebuggerPresentationModel.js:
  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.setFormatted):
(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
(WebInspector.RawSourceCode.prototype._updateSourceMapping):
(WebInspector.RawSourceCode.prototype._createUISourceCode):

  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):

  • inspector/front-end/inspector.js:

(WebInspector._toolbarItemClicked):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping-debug-expected.txt:
  • http/tests/inspector/compiler-source-mapping-debug.html:
  • inspector/debugger/raw-source-code.html:
3:21 AM Changeset in webkit [103794] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Tighten our checks for needsSectionRecalc in RenderTable
​https://bugs.webkit.org/show_bug.cgi?id=73972

Reviewed by Adam Barth.

Refactoring covered under the new tests.

Now most of the functions use the header, first body and footer's
getters that checks if we need a section recalculation. The only
exceptions are addChild and recalcSections as they can be called
with the bit set.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):
(WebCore::RenderTable::outerBorderAfter):
(WebCore::RenderTable::sectionAbove):
(WebCore::RenderTable::sectionBelow):
Updated the previous functions to use the sections' getters.

(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::addChild):
(WebCore::RenderTable::recalcSections):
Update the previous functions after the 2 renames
(see below).

  • rendering/RenderTable.h:

(WebCore::RenderTable::header):
(WebCore::RenderTable::footer):
(WebCore::RenderTable::firstBody):
Added some ASSERT here. Also renamed m_head to m_header
and m_foot to m_footer to match the getter and to avoid
unneeded abbreviation.

(WebCore::RenderTable::hasSections):
(WebCore::RenderTable::topSection):
Updated the previous functions to use the section getters.

2:50 AM Changeset in webkit [103793] by caio.oliveira@openbossa.org
  • 5 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> for UserScriptMap and UserStyleSheetMap
​https://bugs.webkit.org/show_bug.cgi?id=75323

Reviewed by Darin Adler.

  • dom/Document.cpp:

(WebCore::Document::pageGroupUserSheets):

  • page/PageGroup.cpp:

(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld): fix a small mistake in
previous code. Now the entry for world is removed (and deleted) only if its
stylesheet vector is empty.
(WebCore::PageGroup::removeUserScriptsFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):
(WebCore::PageGroup::removeAllUserContent):

  • page/UserScriptTypes.h:
  • page/UserStyleSheetTypes.h:
Note: See TracTimeline for information about the timeline view.