Timeline



Jan 7, 2012:

7:59 PM Changeset in webkit [104397] by kling@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Windows build fix.

  • DOMHTMLClasses.cpp:

(DOMHTMLDocument::forms):
(DOMHTMLSelectElement::options):

7:47 PM Changeset in webkit [104396] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to regenerate bindings on the Windows bot.

  • html/HTMLCollection.h:
7:41 PM Changeset in webkit [104395] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Memory allocator mismatch; Use operator new[] with OwnArrayPtr instead of fastMalloc()

Rubber-stamped by Adam Barth.

Currently getProgramInfoLog() in GraphicsContext3DOpenGL.cpp assumes that operator new[]
and fastMalloc() are equivalent when it adopts a fastMalloc() allocated buffer. Notice,
OwnArrayPtr ultimately calls delete[] on destruction. When GLOBAL_FASTMALLOC_NEW is disabled,
it isn't true that operator new[], operator delete[] are equivalent to fastMalloc(), fastFree(),
respectively. Hence, there may be a mismatch between the allocation and deallocation
routines. Therefore, we should allocate the array to be adopted by OwnArrayPtr using
operator new[].

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::getProgramInfoLog):

4:45 PM Changeset in webkit [104394] by dslomov@google.com
  • 11 edits
    2 moves
    4 adds
    4 deletes in trunk/LayoutTests

Unreviewed; chromium tests rebaselined after r104240.

  • platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open2-expected.png.
  • platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open4-expected.png.
  • platform/chromium-mac/fast/forms/input-text-double-click-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-text-drag-down-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-text-option-delete-expected.png: Removed.
  • platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png: Removed.
4:09 PM Changeset in webkit [104393] by dslomov@google.com
  • 4 edits
    2 adds
    2 deletes in trunk/LayoutTests

Unreviewed: updating expectations and rebaselining.
svg/custom/inline-svg-in-xhtml rebaselined due to ​http://trac.webkit.org/changeset/104240/.

  • platform/chromium-cg-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Added.
  • platform/chromium-cg-mac/svg/custom/inline-svg-in-xhtml-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Added.
  • platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
3:51 PM Changeset in webkit [104392] by dslomov@google.com
  • 2 edits
    5 adds in trunk/LayoutTests

Unreviewed: updating expectations and rebaslining.
svg/custom/pattern-userSpaceOnUse-userToBaseTransform rebaselined due to ​http://trac.webkit.org/changeset/104356/.

  • platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
  • platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
  • platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added.
  • platform/chromium/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
  • platform/chromium/test_expectations.txt:
2:39 PM Changeset in webkit [104391] by Philippe Normand
  • 6 edits
    1 add in trunk/LayoutTests

Unreviewed, GTK rebaseline after r104386 and r104208.

  • platform/gtk/Skipped: Skip failing accessibility/textbox-role-reports-line-number.html
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/table/032-expected.txt:
  • platform/gtk/fast/writing-mode/table-percent-width-quirk-expected.txt: Added.
  • platform/gtk/tables/mozilla/bugs/bug55694-expected.txt:
2:12 PM Changeset in webkit [104390] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: test expectations and filed WK75784.

  • platform/chromium/test_expectations.txt:
1:50 PM Changeset in webkit [104389] by dslomov@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed: disabled CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers
and filed ​https://bugs.webkit.org/show_bug.cgi?id=75783.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

10:43 AM Changeset in webkit [104388] by cmarrin@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

2012-01-07 Chris Marrin <​cmarrin@apple.com>

Fixed a warning in GTK build of ANGLE

Unreviewed.

  • src/compiler/DetectRecursion.cpp: (DetectRecursion::~DetectRecursion):
9:46 AM Changeset in webkit [104387] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WK2][GTK] Each test takes roughly half a second to load
​https://bugs.webkit.org/show_bug.cgi?id=70699

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2012-01-07
Reviewed by Martin Robinson.

Set the XDG_CACHE_HOME environment variable when testing with
WebKitTestRunner. This way the testing is started with a non-existing
application cache. If the cache exists and is not empty, the emptying
and vacuuming that is performed before every test can consume a lot of
time.

This is just a temporary workaround until it becomes possible to set
a desired directory to be used as the application cache location through
WebKitWebContext.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.setup_environ_for_server):

9:18 AM Changeset in webkit [104386] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] Enable requestAnimationFrame in build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=75773

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2012-01-07
Reviewed by Martin Robinson.

Tools:

Enable requestAnimationFrame for the Gtk port.

  • Scripts/build-webkit:

LayoutTests:

Skip the passing requestAnimationFrame-related tests and put
the remaining failing one under the tests that require modal
dialog implementation.

  • platform/gtk/Skipped:
7:22 AM Changeset in webkit [104385] by cmarrin@apple.com
  • 3 edits in trunk/Source/WebCore

2012-01-07 Chris Marrin <​cmarrin@apple.com>

Fixed ANGLE build for GNU and QT broken in ​https://trac.webkit.org/changeset/104363

Unreviewed.

  • GNUmakefile.list.am:
  • Target.pri:
2:08 AM Changeset in webkit [104384] by kling@webkit.org
  • 9 edits in trunk/Source/WebCore

Unreviewed C++ bindings build fix after r104383.

Use WTF::getPtr() to grab at impl pointer since they could be either RefPtr or raw.

  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation):

  • bindings/scripts/test/CPP/WebDOMTestCallback.cpp:

(WebDOMTestCallback::impl):

  • bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp:

(WebDOMTestEventConstructor::impl):

  • bindings/scripts/test/CPP/WebDOMTestInterface.cpp:

(WebDOMTestInterface::impl):

  • bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp:

(WebDOMTestMediaQueryListListener::impl):

  • bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp:

(WebDOMTestNamedConstructor::impl):

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::impl):

  • bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:

(WebDOMTestSerializedScriptValueInterface::impl):

1:35 AM Changeset in webkit [104383] by kling@webkit.org
  • 43 edits
    2 adds
    2 deletes in trunk

Simplify HTMLCollection ownership model.
<​http://webkit.org/b/75437>

Reviewed by Sam Weinig.

Source/WebCore:

Remove HTMLCollection's inheritance from RefCounted and use OwnPtr to store it.
Added ref()/deref() methods that forward to the collection's base node, these
are only ever used by DOM wrappers.

This is a behavior change, HTMLCollection wrappers now keep the base node alive.

Test: fast/dom/htmlcollection-protects-base.html

  • html/HTMLCollection.h:

(WebCore::HTMLCollection::ref):
(WebCore::HTMLCollection::deref):

Removed inheritance from RefCounted. Added ref/deref that forward the refs
to the collection's base Node.

  • dom/Element.cpp:

(WebCore::Element::~Element):

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::Document::~Document):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::~HTMLFormElement):

  • html/HTMLSelectElement.h:
  • html/HTMLSelectElement.cpp:

Remove HTMLCollection::detachFromNode() and call sites.

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::namedItemWithIndex):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::invalidateCacheIfNeeded):
(WebCore::HTMLCollection::itemAfter):
(WebCore::HTMLCollection::calcLength):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::nextItem):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
(WebCore::HTMLCollection::hasNamedItem):
(WebCore::HTMLCollection::namedItems):
(WebCore::HTMLCollection::tags):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::calcLength):
(WebCore::HTMLFormCollection::item):
(WebCore::HTMLFormCollection::getNamedItem):
(WebCore::HTMLFormCollection::namedItem):
(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):
(WebCore::HTMLOptionsCollection::remove):
(WebCore::HTMLOptionsCollection::selectedIndex):
(WebCore::HTMLOptionsCollection::setSelectedIndex):
(WebCore::HTMLOptionsCollection::setLength):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::length):
(WebCore::HTMLPropertiesCollection::item):
(WebCore::HTMLPropertiesCollection::names):

Removed base node null-checks and assertions. Added one assertion to
the HTMLCollection constructor (that m_base is non-null.)

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::Document::openSearchDescriptionURL):
(WebCore::Document::cachedCollection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):
(WebCore::JSHTMLDocument::all):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::GetNamedProperty):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::ensureCachedHTMLCollection):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::properties):

  • html/HTMLAllCollection.h:
  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::create):

  • html/HTMLCollection.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::HTMLCollection):

  • html/HTMLDataListElement.cpp:

(WebCore::HTMLDataListElement::options):

  • html/HTMLDataListElement.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::children):

  • html/HTMLElement.h:
  • html/HTMLSelectElement.h:

(WebCore::HTMLSelectElement::options):

  • html/HTMLFormCollection.h:
  • html/HTMLFormElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::elements):

  • html/HTMLNameCollection.h:

(WebCore::HTMLNameCollection::create):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::create):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::areas):

  • html/HTMLMapElement.h:
  • html/HTMLPropertiesCollection.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::rows):
(WebCore::HTMLTableElement::tBodies):

  • html/HTMLTableElement.h:
  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::insertCell):
(WebCore::HTMLTableRowElement::deleteCell):
(WebCore::HTMLTableRowElement::cells):

  • html/HTMLTableRowElement.h:
  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::create):
(WebCore::HTMLTableRowsCollection::itemAfter):

  • html/HTMLTableRowsCollection.h:
  • html/HTMLTableSectionElement.h:
  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::insertRow):
(WebCore::HTMLTableSectionElement::deleteRow):
(WebCore::HTMLTableSectionElement::rows):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::selectedOption):

  • html/HTMLOptionsCollection.h:
  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::create):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::create):

  • Source/WebCore/accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::getDocumentLinks):

Store cached HTMLCollections in OwnPtrs. Methods that used to return
PassRefPtr<HTMLCollection> now simply return HTMLCollection*.
Updated call sites as appropriate.

LayoutTests:

  • Removed fast/dom/htmlcollection-zombies.html since it was testing bogus behavior.
  • Added a test to verify that HTMLCollection protects its base node from GC.
  • fast/dom/htmlcollection-protects-base-expected.txt: Added.
  • fast/dom/htmlcollection-protects-base.html: Added.
  • fast/dom/htmlcollection-zombies-expected.txt: Removed.
  • fast/dom/htmlcollection-zombies.html: Removed.
1:14 AM Changeset in webkit [104382] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to fix Qt build.

  • page/Geolocation.cpp:

(WebCore::Geolocation::Geolocation):

1:12 AM Changeset in webkit [104381] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

REGRESSION(r104210): Crash inside DynamicSubtreeNodeList::length
​https://bugs.webkit.org/show_bug.cgi?id=75731

Reviewed by Andreas Kling.

Source/WebCore:

The crash was caused by DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent
using m_cachedItem as a way to access the document. Changed SubtreeCaches to use
DynamicSubtreeNodeList's m_node instead.

Test: fast/dom/node-list-length-after-removing-node.html

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setItemCache):
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::item):

  • dom/DynamicNodeList.h:

(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isLengthCacheValid):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isItemCacheValid):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedItem):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent):

LayoutTests:

Add a regression test. It reproduces the crash with a very high probability.

  • fast/dom/node-list-length-after-removing-node-expected.txt: Added.
  • fast/dom/node-list-length-after-removing-node.html: Added.
12:46 AM Changeset in webkit [104380] by abarth@webkit.org
  • 41 edits
    2 copies in trunk/Source/WebCore

Disconnecting DOMWindow properties is fragile and overly complicated
​https://bugs.webkit.org/show_bug.cgi?id=75699

Reviewed by Alexey Proskuryakov.

Previously, we had to carefully check every object tree hanging off of
DOMWindow to make sure that every property correctly disconnected
itself and all its subobjects from the Frame when the DOMWindow
disconnected from the Frame.

This patch introduces DOMWindowProperty, which is a base class that
handles this work automagically, ensuring that we won't have any
dangling Frame pointers and removing a bunch of boilerplate code.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • css/StyleMedia.cpp:

(WebCore::StyleMedia::StyleMedia):

  • css/StyleMedia.h:

(WebCore::StyleMedia::create):

  • loader/appcache/DOMApplicationCache.cpp:

(WebCore::DOMApplicationCache::DOMApplicationCache):
(WebCore::DOMApplicationCache::disconnectFrame):

  • loader/appcache/DOMApplicationCache.h:
  • page/BarInfo.cpp:

(WebCore::BarInfo::BarInfo):

  • page/BarInfo.h:
  • page/Console.cpp:

(WebCore::Console::Console):
(WebCore::Console::memory):

  • page/Console.h:
  • page/DOMSelection.cpp:

(WebCore::DOMSelection::DOMSelection):

  • page/DOMSelection.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::registerProperty):
(WebCore::DOMWindow::unregisterProperty):
(WebCore::DOMWindow::clear):

  • page/DOMWindow.h:
  • page/Geolocation.cpp:

(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::disconnectFrame):

  • page/Geolocation.h:
  • page/History.cpp:

(WebCore::History::History):

  • page/History.h:
  • page/Location.cpp:

(WebCore::Location::Location):

  • page/Location.h:
  • page/Navigator.cpp:

(WebCore::Navigator::Navigator):
(WebCore::Navigator::~Navigator):

  • page/Navigator.h:
  • page/Performance.cpp:

(WebCore::Performance::Performance):
(WebCore::Performance::memory):

  • page/Performance.h:
  • page/PerformanceNavigation.cpp:

(WebCore::PerformanceNavigation::PerformanceNavigation):

  • page/PerformanceNavigation.h:
  • page/PerformanceTiming.cpp:

(WebCore::PerformanceTiming::PerformanceTiming):

  • page/PerformanceTiming.h:
  • page/Screen.cpp:

(WebCore::Screen::Screen):

  • page/Screen.h:
  • plugins/DOMMimeTypeArray.cpp:

(WebCore::DOMMimeTypeArray::DOMMimeTypeArray):

  • plugins/DOMMimeTypeArray.h:
  • plugins/DOMPluginArray.cpp:

(WebCore::DOMPluginArray::DOMPluginArray):

  • plugins/DOMPluginArray.h:
  • storage/Storage.cpp:

(WebCore::Storage::Storage):

  • storage/Storage.h:

Jan 6, 2012:

11:33 PM Changeset in webkit [104379] by mrowe@apple.com
  • 5 edits in trunk/Source/ThirdParty/ANGLE

Regenerate a few files with a more appropriate version of bison.

Rubber-stamped by Dan Bernstein.

  • src/compiler/glslang.l: Tweak the input so that it generates code that compiles without warnings.
  • src/compiler/glslang_lex.cpp:
  • src/compiler/glslang_tab.cpp:
  • src/compiler/glslang_tab.h:
10:57 PM Changeset in webkit [104378] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r83075): Save as PDF does not generate any links for webkit.org and others
<​http://webkit.org/b/75768> <rdar://problem/10659258>

Use RenderObject::hasOutline when determining whether to always create line boxes so that
we take in to consideration whether we'll be creating PDF link rects.

Reviewed by Dan Bernstein.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::styleDidChange):

10:57 PM Changeset in webkit [104377] by mrowe@apple.com
  • 4 edits in trunk/Source/WebKit2

REGRESSION (WebKit2): Save as PDF no longer generates links to URLs
<​http://webkit.org/b/65076> / <rdar://problem/9606246>

WebKit2 printing works by having the web process render the page content to a PDF. The PDF
data is then shipped to the UI process which will render it in to the printing graphics context.
Links were being lost because the API used to do the rendering of the PDF in to the printing
graphics context, CGContextDrawPDFPage, did not preserve the links that were present in the
PDF content received from the web process.

To fix this we switch to using PDFKit for drawing the PDF in to the printing graphics context.
PDFKit provides the ability for us to iterate over the links in the PDF content ourselves and
add links in to the printing graphics context.

Reviewed by Alexey Proskuryakov.

  • UIProcess/API/mac/WKPrintingView.h:
  • UIProcess/API/mac/WKPrintingView.mm:

(pdfAnnotationLinkClass): Look up the PDFAnnotationLink class from PDFKit as WebKit2 loads PDFKit lazily.
(pdfDocumentClass): Ditto.
(-[WKPrintingView _drawPDFDocument:page:atPoint:]): Switch to using the PDFKit equivalents of several types.
Iterate over the annotations present in the PDFPage, calling CGPDFContextSetURLForRect for each PDFAnnotationLink
that we find.
(-[WKPrintingView _drawPreview:]): Create an NSData to feed to PDFDocument.
(-[WKPrintingView drawRect:]): Ditto.

  • WebKit2Prefix.h: Add the usual workaround to make Objective-C exceptions compile when C++ exception handling is disabled.
10:46 PM Changeset in webkit [104376] by commit-queue@webkit.org
  • 35 edits
    2 adds
    2 deletes in trunk

Unreviewed, rolling out r104373 and r104374.
​http://trac.webkit.org/changeset/104373
​http://trac.webkit.org/changeset/104374
​https://bugs.webkit.org/show_bug.cgi?id=75769

Too many assertion failures. (Requested by kling on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-01-06

Source/WebCore:

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):
(WebCore::JSHTMLDocument::all):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::GetNamedProperty):

  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::openSearchDescriptionURL):
(WebCore::Document::cachedCollection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::~Element):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::cachedHTMLCollection):
(WebCore::ElementRareData::ensureCachedHTMLCollection):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::properties):

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::create):
(WebCore::HTMLAllCollection::namedItemWithIndex):

  • html/HTMLAllCollection.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::detachFromNode):
(WebCore::HTMLCollection::invalidateCacheIfNeeded):
(WebCore::HTMLCollection::itemAfter):
(WebCore::HTMLCollection::calcLength):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::nextItem):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
(WebCore::HTMLCollection::hasNamedItem):
(WebCore::HTMLCollection::namedItems):
(WebCore::HTMLCollection::tags):

  • html/HTMLCollection.h:
  • html/HTMLDataListElement.cpp:

(WebCore::HTMLDataListElement::options):

  • html/HTMLDataListElement.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::children):

  • html/HTMLElement.h:
  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::create):
(WebCore::HTMLFormCollection::calcLength):
(WebCore::HTMLFormCollection::item):
(WebCore::HTMLFormCollection::getNamedItem):
(WebCore::HTMLFormCollection::namedItem):
(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLFormCollection.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::~HTMLFormElement):
(WebCore::HTMLFormElement::elements):

  • html/HTMLFormElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::selectedOption):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::areas):

  • html/HTMLMapElement.h:
  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter):

  • html/HTMLNameCollection.h:

(WebCore::HTMLNameCollection::create):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::create):
(WebCore::HTMLOptionsCollection::add):
(WebCore::HTMLOptionsCollection::remove):
(WebCore::HTMLOptionsCollection::selectedIndex):
(WebCore::HTMLOptionsCollection::setSelectedIndex):
(WebCore::HTMLOptionsCollection::setLength):

  • html/HTMLOptionsCollection.h:
  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::create):
(WebCore::HTMLPropertiesCollection::length):
(WebCore::HTMLPropertiesCollection::item):
(WebCore::HTMLPropertiesCollection::names):

  • html/HTMLPropertiesCollection.h:
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::~HTMLSelectElement):
(WebCore::HTMLSelectElement::options):

  • html/HTMLSelectElement.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::~HTMLTableElement):

LayoutTests:

  • fast/dom/htmlcollection-protects-base-expected.txt: Removed.
  • fast/dom/htmlcollection-protects-base.html: Removed.
  • fast/dom/htmlcollection-zombies-expected.txt: Added.
  • fast/dom/htmlcollection-zombies.html: Added.
8:20 PM Changeset in webkit [104375] by jarred@sencha.com
  • 2 edits in trunk/Tools

Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.

  • Scripts/webkitdirs.pm:

(buildChromium):
Missing parentheses.

7:58 PM Changeset in webkit [104374] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r104373.

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::~HTMLTableElement):

7:30 PM Changeset in webkit [104373] by kling@webkit.org
  • 34 edits
    2 adds
    2 deletes in trunk

Simplify HTMLCollection ownership model.
<​http://webkit.org/b/75437>

Reviewed by Sam Weinig.

Source/WebCore:

Remove HTMLCollection's inheritance from RefCounted and use OwnPtr to store it.
Added ref()/deref() methods that forward to the collection's base node, these
are only ever used by DOM wrappers.

This is a behavior change, HTMLCollection wrappers now keep the base node alive.

Test: fast/dom/htmlcollection-protects-base.html

  • html/HTMLCollection.h:

(WebCore::HTMLCollection::ref):
(WebCore::HTMLCollection::deref):

Removed inheritance from RefCounted. Added ref/deref that forward the refs
to the collection's base Node.

  • dom/Element.cpp:

(WebCore::Element::~Element):

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::Document::~Document):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::~HTMLFormElement):

  • html/HTMLSelectElement.h:
  • html/HTMLSelectElement.cpp:

Remove HTMLCollection::detachFromNode() and call sites.

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::namedItemWithIndex):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::invalidateCacheIfNeeded):
(WebCore::HTMLCollection::itemAfter):
(WebCore::HTMLCollection::calcLength):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::nextItem):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
(WebCore::HTMLCollection::hasNamedItem):
(WebCore::HTMLCollection::namedItems):
(WebCore::HTMLCollection::tags):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::calcLength):
(WebCore::HTMLFormCollection::item):
(WebCore::HTMLFormCollection::getNamedItem):
(WebCore::HTMLFormCollection::namedItem):
(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):
(WebCore::HTMLOptionsCollection::remove):
(WebCore::HTMLOptionsCollection::selectedIndex):
(WebCore::HTMLOptionsCollection::setSelectedIndex):
(WebCore::HTMLOptionsCollection::setLength):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::length):
(WebCore::HTMLPropertiesCollection::item):
(WebCore::HTMLPropertiesCollection::names):

Removed base node null-checks and assertions. Added one assertion to
the HTMLCollection constructor (that m_base is non-null.)

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::Document::openSearchDescriptionURL):
(WebCore::Document::cachedCollection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):
(WebCore::JSHTMLDocument::all):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::GetNamedProperty):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::ensureCachedHTMLCollection):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::properties):

  • html/HTMLAllCollection.h:
  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::create):

  • html/HTMLCollection.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::HTMLCollection):

  • html/HTMLDataListElement.cpp:

(WebCore::HTMLDataListElement::options):

  • html/HTMLDataListElement.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::children):

  • html/HTMLElement.h:
  • html/HTMLSelectElement.h:

(WebCore::HTMLSelectElement::options):

  • html/HTMLFormCollection.h:
  • html/HTMLFormElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::elements):

  • html/HTMLNameCollection.h:

(WebCore::HTMLNameCollection::create):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::create):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::areas):

  • html/HTMLMapElement.h:
  • html/HTMLPropertiesCollection.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::rows):
(WebCore::HTMLTableElement::tBodies):

  • html/HTMLTableElement.h:
  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::insertCell):
(WebCore::HTMLTableRowElement::deleteCell):
(WebCore::HTMLTableRowElement::cells):

  • html/HTMLTableRowElement.h:
  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::create):
(WebCore::HTMLTableRowsCollection::itemAfter):

  • html/HTMLTableRowsCollection.h:
  • html/HTMLTableSectionElement.h:
  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::insertRow):
(WebCore::HTMLTableSectionElement::deleteRow):
(WebCore::HTMLTableSectionElement::rows):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::selectedOption):

  • html/HTMLOptionsCollection.h:
  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::create):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::create):

Store cached HTMLCollections in OwnPtrs. Methods that used to return
PassRefPtr<HTMLCollection> now simply return HTMLCollection*.
Updated call sites as appropriate.

LayoutTests:

  • Removed fast/dom/htmlcollection-zombies.html since it was testing bogus behavior.
  • Added a test to verify that HTMLCollection protects its base node from GC.
  • fast/dom/htmlcollection-protects-base-expected.txt: Added.
  • fast/dom/htmlcollection-protects-base.html: Added.
  • fast/dom/htmlcollection-zombies-expected.txt: Removed.
  • fast/dom/htmlcollection-zombies.html: Removed.
7:12 PM Changeset in webkit [104372] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

DOMWindow should be a FrameDestructionObserver
​https://bugs.webkit.org/show_bug.cgi?id=75697

Reviewed by Alexey Proskuryakov.

DOMWindow plays exactly the role of a FrameDestructionObserver, just
with special-case code. It should just use the general-case code.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::DOMWindow):
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::frameDestroyed):

  • page/DOMWindow.h:
  • page/Frame.cpp:

(WebCore::Frame::~Frame):
(WebCore::Frame::clearDOMWindow):
(WebCore::Frame::setDOMWindow):

  • page/Frame.h:
7:10 PM Changeset in webkit [104371] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Missing Implementation of Public InspectorDOMAgent Function
​https://bugs.webkit.org/show_bug.cgi?id=75759

Implement missing accessor and make setter public.

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2012-01-06
Reviewed by Timothy Hatcher.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::searchingForNodeInPage):

  • inspector/InspectorDOMAgent.h:
6:50 PM Changeset in webkit [104370] by ostapenko.viatcheslav@nokia.com
  • 4 edits in trunk/Source/WebKit2

[Qt] [WK2] Minibrowser leaks memory ~6-7Mb per reload
​https://bugs.webkit.org/show_bug.cgi?id=75746

Reset WebGraphicsLayer::m_layerTreeTileClient of all dependent
layers from ~LayerTreeHostQt(). This replaces r103760 which
causes leaks of GraphicsLayerTextureMapper objects on UI side.

Reviewed by Noam Rosenthal.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::setLayerTreeTileClient):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:
  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::~LayerTreeHostQt):

6:43 PM Changeset in webkit [104369] by mrowe@apple.com
  • 3 edits in trunk/Source/WebCore

Roll out r104362 since it broke the build.

6:39 PM Changeset in webkit [104368] by wjmaclean@chromium.org
  • 9 edits
    1 copy
    2 adds in trunk/Source

[Chromium] Cull occluded tiles in tiled layers
​https://bugs.webkit.org/show_bug.cgi?id=70533

Reviewed by James Robinson.

Source/WebCore:

Unit test provided, must pass all existing GPU layout tests.

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::appendQuads):
(WebCore::CCLayerImpl::quadTransform):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::optimizeRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCQuadCuller.cpp: Added.

(std::swap):
(WebCore::regionContainsRect):
(WebCore::CCQuadCuller::cullOccludedQuads):

  • platform/graphics/chromium/cc/CCQuadCuller.h: Added.

(WebCore::CCQuadCuller::CCQuadCuller):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::optimizeQuads):

  • platform/graphics/chromium/cc/CCRenderPass.h:

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCQuadCullerTest.cpp: Added.

(WebCore::TestDrawQuad::TestDrawQuad):
(WebCore::TestDrawQuad::create):
(WebCore::setQuads):
(WebCore::TEST):

5:59 PM Changeset in webkit [104367] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebKit/win

rollout uneeded windows build fix.

5:56 PM Changeset in webkit [104366] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Move more rubberbanding code into ScrollAnimatorMac::smoothScrollWithEvent
​https://bugs.webkit.org/show_bug.cgi?id=75750

Reviewed by Sam Weinig.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):
Move rubberbanding related code into smoothScrollWithEvent.

(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
Move code here from handleWheelEvent and made the function return a boolean.

(WebCore::ScrollAnimatorMac::snapRubberBand):
Call the client.

(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
Ditto.

5:55 PM Changeset in webkit [104365] by kbr@google.com
  • 10 edits
    8 deletes in branches/chromium/963

Revert 98735 - Source/WebCore: The HTML5 video element in Safari does not respect "visibility:hidden" CSS property (​http://crbug.com/107283)
​https://bugs.webkit.org/show_bug.cgi?id=38829

Reviewed by James Robinson.

Make compositing and CSS visibility play nicely together.

The main issue was that an old optimization (see bug 4377) caused
visibility:hidden layers to not appear in the z-order lists, but those
layers could still become composited, but would remain detached. In addition,
composited layers which were visibility:hidden would become visible sometimes.

With this fix, the z-order lists always contain all layers when the page
is in compositing mode. GraphicsLayer is changed to ensure that visibility:hidden
layers show no content, and visible descendants of hidden layers work correctly.

Tests: compositing/visibility/visibility-composited-transforms.html

compositing/visibility/visibility-composited.html
compositing/visibility/visibility-image-layers-dynamic.html
compositing/visibility/visibility-image-layers.html

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer): Init m_contentsVisible to true.
(WebCore::GraphicsLayer::dumpProperties): Dump m_contentsVisible if not true.

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::contentsAreVisible): Getter for m_contentsVisible.
(WebCore::GraphicsLayer::setContentsVisible): Setter for m_contentsVisible.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setContentsVisible): Override setContentsVisible.
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): Handle ContentsVisibilityChanged
flag
(WebCore::GraphicsLayerCA::updateSublayerList): Only parent the m_contentsLayer if the layer
has visible contents.
(WebCore::GraphicsLayerCA::updateContentsVisibility): For bits painted into the layer itself,
we hide it by clearing the backing store.

  • platform/graphics/ca/GraphicsLayerCA.h: Removed obsolete comment on the DrawsContentChanged flag,

added ContentsVisibilityChanged flag.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateZOrderLists): If we're in compositing mode, include all layers
in the z-order lists.
(WebCore::RenderLayer::collectLayers): New param to specify whether we need to collect all layers.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::hasVisibleDescendant): Add comment about the need for an assertion in hasVisibleContent()
, and assertion in hasVisibleDescendant().

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Call setContentsVisible() on the GraphicsLayer.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): We can use simple container layers in cases
where visibility:hidden causes layer content to not be drawn.
(WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendants): Renamed from hasNonCompositingDescendants()
because it now also looks at visibility to decide when things are visible.

  • rendering/RenderLayerBacking.h: hasNonCompositingDescendants() renamed to hasVisibleNonCompositingDescendants().

LayoutTests: The HTML5 video element in Safari does not respect "visibility:hidden" CSS property
​https://bugs.webkit.org/show_bug.cgi?id=38829

Test various configurations of compositing layers and visibility.

Reviewed by James Robinson.

  • compositing/visibility/visibility-composited-expected.png: Added.
  • compositing/visibility/visibility-composited-transforms-expected.png: Added.
  • compositing/visibility/visibility-composited-transforms.html: Added.
  • compositing/visibility/visibility-composited.html: Added.
  • compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
  • compositing/visibility/visibility-image-layers-dynamic.html: Added.
  • compositing/visibility/visibility-image-layers-expected.png: Added.
  • compositing/visibility/visibility-image-layers.html: Added.

TBR=Simon Fraser
Review URL: ​http://codereview.chromium.org/9120020

5:40 PM Changeset in webkit [104364] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebKit/win

Merged r91145.

5:40 PM Changeset in webkit [104363] by cmarrin@apple.com
  • 77 edits
    6 adds
    7 deletes in trunk/Source/ThirdParty/ANGLE

Update ANGLE in WebKit tree
​https://bugs.webkit.org/show_bug.cgi?id=75753

Reviewed by Simon Fraser.

Updated ANGLE to r939. Fixed a compiler error (missing case in switch statement)
and added 5 new files to xcodeproj. Other than that it is a straight copy of
the files from the ANGLE repository.

  • ANGLE.xcodeproj/project.pbxproj:
  • include/EGL/eglext.h:
  • include/EGL/eglplatform.h:
  • include/GLES2/gl2ext.h:
  • include/GLSLANG/ShaderLang.h:
  • src/common/debug.cpp:

(gl::output):
(gl::trace):
(gl::perfActive):
(gl::ScopedPerfEventHelper::ScopedPerfEventHelper):
(gl::ScopedPerfEventHelper::~ScopedPerfEventHelper):

  • src/common/version.h:
  • src/compiler/BaseTypes.h:

(getBasicString):

  • src/compiler/BuiltInFunctionEmulator.cpp: Added.

(BuiltInFunctionEmulator::BuiltInFunctionEmulator):
(BuiltInFunctionEmulator::SetFunctionCalled):
(BuiltInFunctionEmulator::OutputEmulatedFunctionDefinition):
(BuiltInFunctionEmulator::IdentifyFunction):
(BuiltInFunctionEmulator::MarkBuiltInFunctionsForEmulation):
(BuiltInFunctionEmulator::Cleanup):
(BuiltInFunctionEmulator::GetEmulatedFunctionName):

  • src/compiler/BuiltInFunctionEmulator.h: Added.
  • src/compiler/Compiler.cpp:

(TCompiler::TCompiler):
(TCompiler::compile):
(TCompiler::clearResults):
(TCompiler::detectRecursion):
(TCompiler::getMappedNameMaxLength):
(TCompiler::getBuiltInFunctionEmulator):

  • src/compiler/DetectRecursion.cpp: Added.

(DetectRecursion::FunctionNode::FunctionNode):
(DetectRecursion::FunctionNode::getName):
(DetectRecursion::FunctionNode::addCallee):
(DetectRecursion::FunctionNode::detectRecursion):
(DetectRecursion::DetectRecursion):
(DetectRecursion::~DetectRecursion):
(DetectRecursion::visitAggregate):
(DetectRecursion::detectRecursion):
(DetectRecursion::findFunctionByName):

  • src/compiler/DetectRecursion.h: Added.
  • src/compiler/ExtensionBehavior.h:
  • src/compiler/ForLoopUnroll.cpp:

(ForLoopUnroll::MarkForLoopsWithIntegerIndicesForUnrolling):

  • src/compiler/ForLoopUnroll.h:
  • src/compiler/Initialize.cpp:

(BuiltInFunctionsCommon):
(BuiltInFunctionsVertex):
(BuiltInFunctionsFragment):
(TBuiltIns::initialize):
(IdentifyBuiltIns):
(InitExtensionBehavior):

  • src/compiler/MapLongVariableNames.cpp:

(MapLongVariableNames::MapLongVariableNames):
(MapLongVariableNames::visitSymbol):
(MapLongVariableNames::mapVaryingLongName):

  • src/compiler/MapLongVariableNames.h:
  • src/compiler/OutputGLSLBase.cpp:

(TOutputGLSLBase::visitUnary):
(TOutputGLSLBase::visitAggregate):

  • src/compiler/OutputHLSL.cpp:

(sh::OutputHLSL::OutputHLSL):
(sh::OutputHLSL::header):
(sh::OutputHLSL::visitSymbol):
(sh::OutputHLSL::visitAggregate):
(sh::OutputHLSL::visitSelection):
(sh::OutputHLSL::visitLoop):
(sh::OutputHLSL::handleExcessiveLoop):
(sh::OutputHLSL::addConstructor):
(sh::OutputHLSL::decorate):
(sh::OutputHLSL::decorateUniform):

  • src/compiler/OutputHLSL.h:
  • src/compiler/ParseHelper.cpp:

(TParseContext::recover):
(TParseContext::reservedErrorCheck):
(TParseContext::constructorErrorCheck):
(TParseContext::extensionErrorCheck):
(TParseContext::supportsExtension):
(TParseContext::enterStructDeclaration):
(TParseContext::exitStructDeclaration):
(TParseContext::structNestingErrorCheck):

  • src/compiler/ParseHelper.h:

(TParseContext::TParseContext):

  • src/compiler/PoolAlloc.h:

(pool_allocator::pool_allocator):
(pool_allocator::operator=):
(pool_allocator::setAllocator):
(pool_allocator::getAllocator):

  • src/compiler/ShHandle.h:
  • src/compiler/ShaderLang.cpp:

(checkActiveUniformAndAttribMaxLengths):
(checkMappedNameMaxLength):
(getVariableInfo):
(ShInitBuiltInResources):
(ShGetInfo):

  • src/compiler/SymbolTable.cpp:

(TType::computeDeepestStructNesting):

  • src/compiler/TranslatorESSL.cpp:

(TranslatorESSL::translate):
(TranslatorESSL::writeExtensionBehavior):

  • src/compiler/TranslatorGLSL.cpp:

(TranslatorGLSL::translate):

  • src/compiler/Types.h:

(TType::TType):
(TType::copyType):
(TType::setStruct):
(TType::getDeepestStructNesting):

  • src/compiler/UnfoldSelect.cpp:

(sh::UnfoldSelect::traverse):
(sh::UnfoldSelect::visitSelection):
(sh::UnfoldSelect::visitLoop):
(sh::UnfoldSelect::getNextTemporaryIndex):

  • src/compiler/UnfoldSelect.h:
  • src/compiler/ValidateLimitations.cpp:
  • src/compiler/ValidateLimitations.h:
  • src/compiler/VariableInfo.cpp:

(getVariableDataType):

  • src/compiler/generate_glslang_lexer.sh: Removed.
  • src/compiler/generate_glslang_parser.sh: Removed.
  • src/compiler/generate_parser.sh: Added.
  • src/compiler/glslang.l:
  • src/compiler/glslang.y:
  • src/compiler/glslang_lex.cpp:

(yy_get_previous_state):
(yy_try_NUL_trans):

  • src/compiler/glslang_tab.cpp:
  • src/compiler/glslang_tab.h:
  • src/compiler/intermOut.cpp:

(TOutputTraverser::visitAggregate):

  • src/compiler/intermediate.h:

(TIntermUnary::TIntermUnary):
(TIntermUnary::setUseEmulatedFunction):
(TIntermUnary::getUseEmulatedFunction):
(TIntermAggregate::TIntermAggregate):
(TIntermAggregate::setUseEmulatedFunction):
(TIntermAggregate::getUseEmulatedFunction):

  • src/compiler/osinclude.h:
  • src/compiler/ossource_posix.cpp:

(OS_AllocTLSIndex):
(OS_SetTLSValue):
(OS_FreeTLSIndex):

  • src/compiler/preprocessor/atom.c:

(GrowAtomTable):

  • src/compiler/preprocessor/length_limits.h: Added.
  • src/compiler/preprocessor/scanner.h:
  • src/libEGL/Display.cpp:

(egl::Display::getDisplay):
(egl::Display::Display):
(egl::Display::~Display):
(egl::Display::initialize):
(egl::Display::terminate):
(egl::Display::startScene):
(egl::Display::endScene):
(egl::Display::createDevice):
(egl::Display::initializeDevice):
(egl::Display::resetDevice):
(egl::Display::createWindowSurface):
(egl::Display::createOffscreenSurface):
(egl::Display::createContext):
(egl::Display::restoreLostDevice):
(egl::Display::notifyDeviceLost):
(egl::Display::isDeviceLost):
(egl::Display::testDeviceLost):
(egl::Display::testDeviceResettable):
(egl::Display::getDXT1TextureSupport):
(egl::Display::getDXT3TextureSupport):
(egl::Display::getDXT5TextureSupport):
(egl::Display::getFloat32TextureSupport):
(egl::Display::getFloat16TextureSupport):
(egl::Display::getTexturePool):
(egl::Display::initExtensionString):

  • src/libEGL/Display.h:
  • src/libEGL/Surface.cpp:

(egl::Surface::Surface):
(egl::Surface::initialize):
(egl::Surface::resetSwapChain):
(egl::Surface::subclassWindow):
(egl::Surface::unsubclassWindow):
(egl::Surface::swap):
(egl::Surface::postSubBuffer):
(egl::Surface::isPostSubBufferSupported):

  • src/libEGL/Surface.h:
  • src/libEGL/libEGL.cpp:
  • src/libEGL/libEGL.rc:
  • src/libEGL/libEGL.vcproj:
  • src/libGLESv2/Buffer.cpp:

(gl::Buffer::bufferSubData):

  • src/libGLESv2/Context.cpp:

(gl::Context::Context):
(gl::Context::makeCurrent):
(gl::Context::markAllStateDirty):
(gl::Context::markContextLost):
(gl::Context::isContextLost):
(gl::Context::setPackReverseRowOrder):
(gl::Context::getPackReverseRowOrder):
(gl::Context::deleteProgram):
(gl::Context::getDrawFramebuffer):
(gl::Context::bindDrawFramebuffer):
(gl::Context::useProgram):
(gl::Context::setFramebufferZero):
(gl::Context::getCurrentProgram):
(gl::Context::getBooleanv):
(gl::Context::getIntegerv):
(gl::Context::getQueryParameterInfo):
(gl::Context::applyRenderTarget):
(gl::Context::applyState):
(gl::Context::applyVertexBuffer):
(gl::Context::applyIndexBuffer):
(gl::Context::applyShaders):
(gl::Context::applyTextures):
(gl::Context::readPixels):
(gl::Context::clear):
(gl::Context::drawArrays):
(gl::Context::drawElements):
(gl::Context::sync):
(gl::Context::drawClosingLine):
(gl::Context::getResetStatus):
(gl::Context::isResetNotificationEnabled):
(gl::Context::supportsDXT1Textures):
(gl::Context::supportsDXT3Textures):
(gl::Context::supportsDXT5Textures):
(gl::Context::supportsFloat32Textures):
(gl::Context::supportsFloat32LinearFilter):
(gl::Context::supportsFloat32RenderableTextures):
(gl::Context::supportsFloat16Textures):
(gl::Context::supportsFloat16LinearFilter):
(gl::Context::supportsFloat16RenderableTextures):
(gl::Context::initExtensionString):
(gl::Context::initRendererString):
(gl::Context::getRendererString):
(gl::Context::blitFramebuffer):
(gl::VertexDeclarationCache::applyDeclaration):
(gl::VertexDeclarationCache::markStateDirty):

  • src/libGLESv2/Context.h:
  • src/libGLESv2/Fence.cpp:

(gl::Fence::testFence):
(gl::Fence::getFenceiv):

  • src/libGLESv2/Framebuffer.cpp:

(gl::Framebuffer::setColorbuffer):
(gl::Framebuffer::setDepthbuffer):
(gl::Framebuffer::setStencilbuffer):
(gl::Framebuffer::getColorbuffer):
(gl::Framebuffer::getDepthbuffer):
(gl::Framebuffer::getStencilbuffer):
(gl::Framebuffer::hasStencil):
(gl::Framebuffer::completeness):
(gl::DefaultFramebuffer::DefaultFramebuffer):

  • src/libGLESv2/Framebuffer.h:
  • src/libGLESv2/IndexDataManager.cpp:

(gl::IndexDataManager::prepareIndexData):
(gl::IndexBuffer::IndexBuffer):
(gl::IndexBuffer::getSerial):
(gl::IndexBuffer::issueSerial):
(gl::StreamingIndexBuffer::reserveSpace):
(gl::StaticIndexBuffer::reserveSpace):
(gl::StaticIndexBuffer::lookupRange):
(gl::StaticIndexBuffer::addRange):

  • src/libGLESv2/IndexDataManager.h:

(gl::StaticIndexBuffer::IndexRange::operator<):

  • src/libGLESv2/Program.cpp:

(gl::Uniform::Uniform):
(gl::Uniform::isArray):
(gl::UniformLocation::UniformLocation):
(gl::Program::Program):
(gl::Program::detachShader):
(gl::Program::getUsedSamplerRange):
(gl::Program::getSamplerMapping):
(gl::Program::getUniformLocation):
(gl::Program::setUniform1fv):
(gl::Program::setUniform2fv):
(gl::Program::setUniform3fv):
(gl::transposeMatrix):
(gl::Program::setUniformMatrix2fv):
(gl::Program::setUniformMatrix3fv):
(gl::Program::setUniformMatrix4fv):
(gl::Program::getUniformfv):
(gl::Program::getUniformiv):
(gl::Program::applyUniforms):
(gl::Program::compileToBinary):
(gl::Program::linkVaryings):
(gl::Program::link):
(gl::Program::defineUniform):
(gl::Program::createUniform):
(gl::Program::decorateAttribute):
(gl::Program::undecorateUniform):
(gl::Program::applyUniformnbv):
(gl::Program::applyUniformnfv):
(gl::Program::applyUniform1iv):
(gl::Program::applyUniform2iv):
(gl::Program::applyUniform3iv):
(gl::Program::applyUniform4iv):
(gl::Program::applyUniformniv):
(gl::Program::appendToInfoLogSanitized):
(gl::Program::unlink):
(gl::Program::getActiveUniform):
(gl::Program::getActiveUniformCount):
(gl::Program::getActiveUniformMaxLength):
(gl::Program::validateSamplers):
(gl::Program::initializeConstantHandles):
(gl::Program::getDxCoordLocation):

  • src/libGLESv2/Program.h:
  • src/libGLESv2/Renderbuffer.cpp:

(gl::RenderbufferInterface::RenderbufferInterface):
(gl::RenderbufferInterface::getRedSize):
(gl::RenderbufferInterface::getGreenSize):
(gl::RenderbufferInterface::getBlueSize):
(gl::RenderbufferInterface::getAlphaSize):
(gl::RenderbufferInterface::getDepthSize):
(gl::RenderbufferInterface::getStencilSize):
(gl::RenderbufferTexture::RenderbufferTexture):
(gl::RenderbufferTexture::~RenderbufferTexture):
(gl::RenderbufferTexture::getRenderTarget):
(gl::RenderbufferTexture::getDepthStencil):
(gl::RenderbufferTexture::getWidth):
(gl::RenderbufferTexture::getHeight):
(gl::RenderbufferTexture::getInternalFormat):
(gl::RenderbufferTexture::getD3DFormat):
(gl::RenderbufferTexture::getSamples):
(gl::RenderbufferTexture::getSerial):
(gl::Renderbuffer::Renderbuffer):
(gl::Renderbuffer::~Renderbuffer):
(gl::Renderbuffer::getRenderTarget):
(gl::Renderbuffer::getDepthStencil):
(gl::Renderbuffer::getWidth):
(gl::Renderbuffer::getHeight):
(gl::Renderbuffer::getInternalFormat):
(gl::Renderbuffer::getD3DFormat):
(gl::Renderbuffer::getRedSize):
(gl::Renderbuffer::getGreenSize):
(gl::Renderbuffer::getBlueSize):
(gl::Renderbuffer::getAlphaSize):
(gl::Renderbuffer::getDepthSize):
(gl::Renderbuffer::getStencilSize):
(gl::Renderbuffer::getSamples):
(gl::Renderbuffer::getSerial):
(gl::Renderbuffer::setStorage):
(gl::RenderbufferStorage::getD3DFormat):
(gl::RenderbufferStorage::issueCubeSerials):
(gl::Colorbuffer::Colorbuffer):
(gl::Colorbuffer::getRenderTarget):
(gl::Depthbuffer::Depthbuffer):
(gl::Stencilbuffer::Stencilbuffer):

  • src/libGLESv2/Renderbuffer.h:

(gl::RenderbufferInterface::~RenderbufferInterface):

  • src/libGLESv2/Shader.cpp:

(gl::Shader::getTranslatedSourceLength):
(gl::Shader::getSourceImpl):
(gl::Shader::getSource):
(gl::Shader::getTranslatedSource):

  • src/libGLESv2/Shader.h:
  • src/libGLESv2/Texture.cpp:

(gl::ConvertTextureFormatType):
(gl::IsTextureFormatRenderable):
(gl::Image::Image):
(gl::Image::~Image):
(gl::Image::redefine):
(gl::Image::createSurface):
(gl::Image::lock):
(gl::Image::unlock):
(gl::Image::isRenderableFormat):
(gl::Image::getD3DFormat):
(gl::Image::getSurface):
(gl::Image::setManagedSurface):
(gl::Image::updateSurface):
(gl::Image::loadData):
(gl::Image::loadAlphaData):
(gl::Image::loadAlphaFloatData):
(gl::Image::loadAlphaHalfFloatData):
(gl::Image::loadLuminanceData):
(gl::Image::loadLuminanceFloatData):
(gl::Image::loadLuminanceHalfFloatData):
(gl::Image::loadLuminanceAlphaData):
(gl::Image::loadLuminanceAlphaFloatData):
(gl::Image::loadLuminanceAlphaHalfFloatData):
(gl::Image::loadRGBUByteData):
(gl::Image::loadRGB565Data):
(gl::Image::loadRGBFloatData):
(gl::Image::loadRGBHalfFloatData):
(gl::Image::loadRGBAUByteDataSSE2):
(gl::Image::loadRGBAUByteData):
(gl::Image::loadRGBA4444Data):
(gl::Image::loadRGBA5551Data):
(gl::Image::loadRGBAFloatData):
(gl::Image::loadRGBAHalfFloatData):
(gl::Image::loadBGRAData):
(gl::Image::loadCompressedData):
(gl::FlipCopyDXT1BlockFull):
(gl::FlipCopyDXT1BlockHalf):
(gl::FlipCopyDXT3BlockFull):
(gl::FlipCopyDXT3BlockHalf):
(gl::FlipCopyDXT5BlockFull):
(gl::FlipCopyDXT5BlockHalf):
(gl::Image::loadDXT1Data):
(gl::Image::loadDXT3Data):
(gl::Image::loadDXT5Data):
(gl::Image::copy):
(gl::TextureStorage::TextureStorage):
(gl::TextureStorage::~TextureStorage):
(gl::TextureStorage::isRenderTarget):
(gl::TextureStorage::isManaged):
(gl::TextureStorage::getPool):
(gl::TextureStorage::getTextureSerial):
(gl::TextureStorage::issueTextureSerial):
(gl::Texture::Texture):
(gl::Texture::~Texture):
(gl::Texture::setMinFilter):
(gl::Texture::setMagFilter):
(gl::Texture::setWrapS):
(gl::Texture::setWrapT):
(gl::Texture::setUsage):
(gl::Texture::getMinFilter):
(gl::Texture::getMagFilter):
(gl::Texture::getWrapS):
(gl::Texture::getWrapT):
(gl::Texture::getUsage):
(gl::Texture::setImage):
(gl::Texture::setCompressedImage):
(gl::Texture::subImage):
(gl::Texture::subImageCompressed):
(gl::Texture::getTexture):
(gl::Texture::hasDirtyParameters):
(gl::Texture::hasDirtyImages):
(gl::Texture::resetDirty):
(gl::Texture::getTextureSerial):
(gl::Texture::getRenderTargetSerial):
(gl::Texture::isImmutable):
(gl::Texture::creationLevels):
(gl::Texture::getBlitter):
(gl::Texture::copyToRenderTarget):
(gl::TextureStorage2D::TextureStorage2D):
(gl::TextureStorage2D::~TextureStorage2D):
(gl::TextureStorage2D::getSurfaceLevel):
(gl::TextureStorage2D::getBaseTexture):
(gl::TextureStorage2D::getRenderTargetSerial):
(gl::Texture2D::Texture2D):
(gl::Texture2D::~Texture2D):
(gl::Texture2D::getWidth):
(gl::Texture2D::getHeight):
(gl::Texture2D::getInternalFormat):
(gl::Texture2D::getType):
(gl::Texture2D::redefineImage):
(gl::Texture2D::setImage):
(gl::Texture2D::bindTexImage):
(gl::Texture2D::releaseTexImage):
(gl::Texture2D::setCompressedImage):
(gl::Texture2D::commitRect):
(gl::Texture2D::copyImage):
(gl::Texture2D::copySubImage):
(gl::Texture2D::storage):
(gl::Texture2D::isSamplerComplete):
(gl::Texture2D::isMipmapComplete):
(gl::Texture2D::getBaseTexture):
(gl::Texture2D::createTexture):
(gl::Texture2D::updateTexture):
(gl::Texture2D::convertToRenderTarget):
(gl::Texture2D::generateMipmaps):
(gl::Texture2D::getRenderbuffer):
(gl::Texture2D::getRenderTarget):
(gl::Texture2D::getStorage):
(gl::TextureStorageCubeMap::TextureStorageCubeMap):
(gl::TextureStorageCubeMap::~TextureStorageCubeMap):
(gl::TextureStorageCubeMap::getCubeMapSurface):
(gl::TextureStorageCubeMap::getBaseTexture):
(gl::TextureStorageCubeMap::getRenderTargetSerial):
(gl::TextureCubeMap::TextureCubeMap):
(gl::TextureCubeMap::~TextureCubeMap):
(gl::TextureCubeMap::getWidth):
(gl::TextureCubeMap::getHeight):
(gl::TextureCubeMap::getInternalFormat):
(gl::TextureCubeMap::getType):
(gl::TextureCubeMap::setCompressedImage):
(gl::TextureCubeMap::commitRect):
(gl::TextureCubeMap::subImage):
(gl::TextureCubeMap::subImageCompressed):
(gl::TextureCubeMap::isSamplerComplete):
(gl::TextureCubeMap::isCubeComplete):
(gl::TextureCubeMap::isMipmapCubeComplete):
(gl::TextureCubeMap::getBaseTexture):
(gl::TextureCubeMap::createTexture):
(gl::TextureCubeMap::updateTexture):
(gl::TextureCubeMap::convertToRenderTarget):
(gl::TextureCubeMap::setImage):
(gl::TextureCubeMap::redefineImage):
(gl::TextureCubeMap::copyImage):
(gl::TextureCubeMap::copySubImage):
(gl::TextureCubeMap::storage):
(gl::TextureCubeMap::generateMipmaps):
(gl::TextureCubeMap::getRenderbuffer):
(gl::TextureCubeMap::getRenderTarget):
(gl::TextureCubeMap::getStorage):

  • src/libGLESv2/Texture.h:

(gl::Image::markDirty):
(gl::Image::markClean):
(gl::Image::getWidth):
(gl::Image::getHeight):
(gl::Image::getFormat):
(gl::Image::getType):
(gl::Image::isDirty):

  • src/libGLESv2/VertexDataManager.cpp:

(gl::elementsInBuffer):
(gl::VertexDataManager::VertexDataManager):
(gl::VertexDataManager::writeAttributeData):
(gl::VertexDataManager::prepareVertexData):
(gl::VertexBuffer::VertexBuffer):
(gl::VertexBuffer::getSerial):
(gl::VertexBuffer::issueSerial):
(gl::StreamingVertexBuffer::reserveRequiredSpace):
(gl::StaticVertexBuffer::map):
(gl::StaticVertexBuffer::reserveRequiredSpace):
(gl::StaticVertexBuffer::lookupAttribute):

  • src/libGLESv2/VertexDataManager.h:

(gl::ArrayVertexBuffer::size):

  • src/libGLESv2/geometry/IndexDataManager.cpp: Removed.
  • src/libGLESv2/geometry/IndexDataManager.h: Removed.
  • src/libGLESv2/geometry/VertexDataManager.cpp: Removed.
  • src/libGLESv2/geometry/VertexDataManager.h: Removed.
  • src/libGLESv2/geometry/vertexconversion.h: Removed.
  • src/libGLESv2/libGLESv2.cpp:

(validateSubImageParams):
(validReadFormatType):
(Extension::glBindTexImage):

  • src/libGLESv2/libGLESv2.def:
  • src/libGLESv2/libGLESv2.rc:
  • src/libGLESv2/libGLESv2.vcproj:
  • src/libGLESv2/main.cpp:

(gl::getNonLostContext):
(gl::checkDeviceLost):

  • src/libGLESv2/main.h:
  • src/libGLESv2/utilities.cpp:

(gl::UniformExternalComponentCount):
(gl::UniformInternalComponentCount):
(gl::UniformComponentSize):
(gl::UniformInternalSize):
(gl::UniformExternalSize):
(gl::ComputeCompressedSize):
(gl::IsCompressed):
(gl::ExtractFormat):
(gl::ExtractType):
(dx2es::IsFloat32Format):
(dx2es::IsFloat16Format):

  • src/libGLESv2/utilities.h:

(isDeviceLostError):

5:23 PM Changeset in webkit [104362] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> in SVGAttributeToPropertyMap
​https://bugs.webkit.org/show_bug.cgi?id=75734

Reviewed by Daniel Bates.

  • svg/properties/SVGAttributeToPropertyMap.cpp:

(WebCore::SVGAttributeToPropertyMap::addProperties):
(WebCore::SVGAttributeToPropertyMap::addProperty): use HashMap::add() to avoid an
extra hash lookup to set a new PropertiesVector.
(WebCore::SVGAttributeToPropertyMap::synchronizeProperties):

  • svg/properties/SVGAttributeToPropertyMap.h:
5:22 PM Changeset in webkit [104361] by dslomov@google.com
  • 112 edits
    4 copies
    13 moves
    97 adds
    83 deletes in trunk/LayoutTests

Unreviewed: more rebaselines in chromium after r104240.

  • platform/chromium-cg-mac-leopard/fast/css/input-search-padding-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/events/context-no-deselect-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-click-inside-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug12384-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/textfield-overflow-expected.png.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug24200-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug4382-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug55545-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug59354-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug99948-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-focus-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-height-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-selection-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-click-inside-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-width-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/textfield-overflow-expected.png.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Added.
  • platform/chromium-cg-mac/editing/selection/3690703-2-expected.png: Removed.
  • platform/chromium-cg-mac/editing/selection/3690703-expected.png: Removed.
  • platform/chromium-cg-mac/editing/selection/3690719-expected.png: Removed.
  • platform/chromium-cg-mac/editing/selection/4975120-expected.png: Removed.
  • platform/chromium-cg-mac/fast/block/margin-collapse/103-expected.png: Removed.
  • platform/chromium-cg-mac/fast/dom/isindex-001-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/input-appearance-bkcolor-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/input-appearance-focus-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/input-appearance-height-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/input-appearance-readonly-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/input-double-click-selection-gap-bug-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/minWidthPercent-expected.png: Removed.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-leopard/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-leopard/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-leopard/editing/selection/4975120-expected.png:
  • platform/chromium-mac-leopard/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-leopard/fast/css/line-height-expected.png:
  • platform/chromium-mac-leopard/fast/dom/isindex-001-expected.png:
  • platform/chromium-mac-leopard/fast/dom/isindex-002-expected.png:
  • platform/chromium-mac-leopard/fast/events/autoscroll-expected.png:
  • platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.png:
  • platform/chromium-mac-leopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac-leopard/fast/forms/encoding-test-expected.png:
  • platform/chromium-mac-leopard/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac-leopard/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-baseline-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-spaces-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-table-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-mac-leopard/fast/forms/minWidthPercent-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-leopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac-leopard/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug55545-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/4975120-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/margin-collapse/103-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/input-search-padding-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/line-height-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/isindex-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/isindex-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/events/context-no-deselect-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/minWidthPercent-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-table-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/forms/minWidthPercent-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/tables/mozilla/bugs/bug12384-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png.
  • platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/forms/minWidthPercent-expected.png.
  • platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary4-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Added.
  • platform/chromium-mac/editing/inserting/before-after-input-element-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/4806874-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/input-field-1-expected.png: Removed.
  • platform/chromium-mac/editing/selection/3690703-2-expected.png: Removed.
  • platform/chromium-mac/editing/selection/3690703-expected.png: Removed.
  • platform/chromium-mac/editing/selection/3690719-expected.png: Removed.
  • platform/chromium-mac/editing/selection/4895428-3-expected.png: Removed.
  • platform/chromium-mac/editing/selection/4975120-expected.png: Removed.
  • platform/chromium-mac/editing/selection/drag-select-1-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.png: Removed.
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.png: Removed.
  • platform/chromium-mac/fast/css/input-search-padding-expected.png: Removed.
  • platform/chromium-mac/fast/css/line-height-expected.png: Removed.
  • platform/chromium-mac/fast/dom/isindex-001-expected.png: Removed.
  • platform/chromium-mac/fast/dom/isindex-002-expected.png: Removed.
  • platform/chromium-mac/fast/events/autoscroll-expected.png: Removed.
  • platform/chromium-mac/fast/events/context-no-deselect-expected.png: Removed.
  • platform/chromium-mac/fast/forms/encoding-test-expected.png: Removed.
  • platform/chromium-mac/fast/forms/fieldset-align-expected.png: Removed.
  • platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-focus-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-preventDefault-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-selection-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-visibility-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-width-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-baseline-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-field-text-truncated-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-readonly-empty-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-spaces-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-table-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-text-click-inside-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-text-click-outside-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-text-self-emptying-click-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-text-word-wrap-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-type-text-min-width-expected.png: Removed.
  • platform/chromium-mac/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
  • platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png: Removed.
  • platform/chromium-mac/fast/forms/text-style-color-expected.png: Removed.
  • platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png: Removed.
  • platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug4382-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug59354-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug99948-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium/fast/block/float/032-expected.png: Added.
  • platform/chromium/fast/forms/input-appearance-height-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/forms/input-appearance-height-expected.txt.
  • platform/chromium/fast/forms/input-width-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-width-expected.png.
  • platform/chromium/fast/forms/minWidthPercent-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/minWidthPercent-expected.png.
  • platform/chromium/tables/mozilla/bugs/bug24200-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/fast/forms/basic-inputs-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/fieldset-align-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/input-appearance-height-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/input-table-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/placeholder-position-expected.txt: Removed.
  • platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt: Renamed from LayoutTests/editing/input/caret-at-the-edge-of-input-expected.txt.
5:02 PM Changeset in webkit [104360] by Simon Fraser
  • 2 edits in trunk/Tools

Fix DRT build on case-sensitive file systems.

Fix case of include of WebDynamicScrollBarsView.h

  • DumpRenderTree/mac/DumpRenderTree.mm:
4:54 PM Changeset in webkit [104359] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=75296
JSString should not have JS_EXPORTCLASS annotation

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-01-06
Reviewed by Kevin Ollivier.

  • runtime/JSString.h: Removed JS_EXPORTCLASS annotation.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Added missing symbols which were hidden by JS_EXPORTCLASS.

4:53 PM Changeset in webkit [104358] by abarth@webkit.org
  • 13 edits
    7 adds in trunk

Source/WebCore: WebCore implementation of the Intent object
See ​http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html
for draft spec.

​https://bugs.webkit.org/show_bug.cgi?id=73051

Patch by Greg Billock <​gbillock@google.com> on 2012-01-06
Reviewed by Adam Barth.

Test: web-intents/web-intents-api.html

  • WebCore.gypi:
  • page/DOMWindow.idl:
  • Modules/intents/Intent.cpp: Added.

(WebCore::Intent::Intent):
(WebCore::Intent::action):
(WebCore::Intent::setAction):
(WebCore::Intent::type):
(WebCore::Intent::setType):
(WebCore::Intent::data):
(WebCore::Intent::setData):
(WebCore::Intent::create):

  • Modules/intents/Intent.h: Added.
  • Modules/intents/Intent.idl: Added.

Source/WebKit/chromium: [Web Intents] Flagged-off WebCore implementation of navigator.startActivity
​https://bugs.webkit.org/show_bug.cgi?id=73051

Patch by Greg Billock <​gbillock@google.com> on 2012-01-06
Reviewed by Adam Barth.

  • features.gypi:
4:49 PM Changeset in webkit [104357] by eae@chromium.org
  • 4 edits in branches/subpixellayout

Fix overflow in SpatialNavigation::distanceDataForNode.

4:29 PM Changeset in webkit [104356] by timothy_horton@apple.com
  • 5 edits
    3 adds in trunk

[cg] userSpaceOnUse SVG Patterns have the wrong origin
​https://bugs.webkit.org/show_bug.cgi?id=75741
<rdar://problem/9383222>

Reviewed by Simon Fraser.

The transformation from pattern space to user space should use the userToBase CTM,
not the current CTM.

Test: svg/custom/pattern-userSpaceOnUse-userToBaseTransform.xhtml

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
(WebCore::GraphicsContext::getCTM):

  • platform/graphics/cg/TransformationMatrixCG.cpp:

(WebCore::AffineTransform::AffineTransform): Add a AffineTransform(CGAffineTransform) constructor

  • platform/graphics/transforms/AffineTransform.h:

Add a test that ensures that userSpaceOnUse patterns are rendered in the
correct orientation and location in both the accelerated compositing and
regular cases, as well as with SVG translation.

  • platform/mac/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
  • platform/mac/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added.
  • svg/custom/pattern-userSpaceOnUse-userToBaseTransform.xhtml: Added.
4:27 PM Changeset in webkit [104355] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSArray::pop() should compare SparseArrayValueMap::find() to SparseArrayValueMap::notFound()
​https://bugs.webkit.org/show_bug.cgi?id=75757

Reviewed by Gavin Barraclough.

  • runtime/JSArray.cpp:

(JSC::JSArray::pop): Changed map->end() to map->notFound().

4:14 PM Changeset in webkit [104354] by commit-queue@webkit.org
  • 10 edits in trunk/LayoutTests

[chromium] Rebaseline media/media-document-audio-repaint after 74123 goes in.
​https://bugs.webkit.org/show_bug.cgi?id=75505

Patch by Dale Curtis <​dalecurtis@chromium.org> on 2012-01-06
Reviewed by Dimitri Glazkov.

  • platform/chromium-cg-mac-leopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-cg-mac-snowleopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-gpu-cg-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium/test_expectations.txt:
3:41 PM Changeset in webkit [104353] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

LayoutTests/platform/chromium/fast/events/intercept-postmessage.html failing
​https://bugs.webkit.org/show_bug.cgi?id=75718

Patch by Charlie Reis <​creis@chromium.org> on 2012-01-06
Reviewed by Adam Barth.

Removing unnecessary log messages.

  • platform/chromium/fast/events/intercept-postmessage-expected.txt:
  • platform/chromium/fast/events/intercept-postmessage.html:
3:39 PM Changeset in webkit [104352] by Simon Fraser
  • 3 edits
    2 adds in trunk

Avoid falling into tiled layers more often when the device scale factor is > 1
<rdar://problem/10588725>

Source/WebCore:

Reviewed by John Sullivan.

Stop taking the device scale factor into account when deciding to make
tiled layers.

Test: compositing/tiled-layers-hidpi.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::requiresTiledLayer):

LayoutTests:

Reviewed by John Sullivan.

Tests that a large layer with a device scale factor of 2 is not tiled.

  • compositing/tiled-layers-hidpi-expected.txt: Added.
  • compositing/tiled-layers-hidpi.html: Added.
3:34 PM Changeset in webkit [104351] by Simon Fraser
  • 6 edits in trunk/Tools

Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
​https://bugs.webkit.org/show_bug.cgi?id=75662

Reviewed by Dan Bernstein.

The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
of color profile issues. Fix by keeping everything in device RGB and ensuring that the
test window uses the main display's color space, so that the pixel values in the bitmap
that gets checksummed are identical to the CSS colors.

Removed the code that switches the display profile in DRT, since that is no longer required.

  • DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
  • DumpRenderTree/mac/DumpRenderTree.mm:

(crashHandler): Remove code that switches display profiles.
(prepareConsistentTestingEnvironment): Ditto.
(dumpRenderTree): Ditto.

  • DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.

(createBitmapContext): Use DeviceRGB for the bitmap colorspace.
(createBitmapContextFromWebView): Add comment about the colorspace handling.

  • WebKitTestRunner/cg/TestInvocationCG.cpp:

(WTR::createCGContextFromImage): Use a RetainPtr, add comment.
(WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
(WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.

3:28 PM Changeset in webkit [104350] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

Touch a bunch of files in an attempt to fix Mac release builds.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::get):

  • accessibility/AccessibilityAllInOne.cpp:
  • editing/visible_units.cpp:

(WebCore::previousBoundary):

3:20 PM Changeset in webkit [104349] by fpizlo@apple.com
  • 5 edits
    1 add in trunk/Source/JavaScriptCore

JIT stub slow paths that would be identical to that of an interpreter should be factored out
​https://bugs.webkit.org/show_bug.cgi?id=75743
<rdar://problem/10657024>

Reviewed by Geoff Garen.

  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/CommonSlowPaths.h: Added.

(JSC::CommonSlowPaths::opInstanceOfSlow):
(JSC::CommonSlowPaths::opIn):
(JSC::CommonSlowPaths::opResolve):
(JSC::CommonSlowPaths::opResolveSkip):
(JSC::CommonSlowPaths::opResolveWithBase):
(JSC::CommonSlowPaths::opResolveWithThis):

3:16 PM Changeset in webkit [104348] by eae@chromium.org
  • 21 edits in branches/subpixellayout

Fix scrollbar toggling to compare pixel snapped values and update relevant test expectations.

3:13 PM Changeset in webkit [104347] by noam.rosenthal@nokia.com
  • 4 edits in trunk/Source/WebCore

Enable a compositing trigger for filters
​https://bugs.webkit.org/show_bug.cgi?id=75658

This will enable forcing the compositing code path when filters exist for a RenderObject.

Reviewed by Simon Fraser.

No new functionality so no new tests.

  • page/ChromeClient.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresCompositingForFilters):

  • rendering/RenderLayerCompositor.h:
3:01 PM Changeset in webkit [104346] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

Rebaseline editing/input/caret-at-the-edge-of-input.html.

  • platform/chromium-mac-leopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
2:58 PM Changeset in webkit [104345] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Add and use ScrollElasticityControllerClient::absoluteScrollPosition
​https://bugs.webkit.org/show_bug.cgi?id=75744

Reviewed by Dan Bernstein.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::absoluteScrollPosition):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):

  • platform/mac/ScrollElasticityController.h:
2:54 PM Changeset in webkit [104344] by abarth@webkit.org
  • 11 edits
    2 adds in trunk/Source/WebCore

Move FrameDestructionObserver to its own file
​https://bugs.webkit.org/show_bug.cgi?id=75693

Reviewed by Eric Seidel.

We should have one class per file, on general principles. Also, this
make it possible to use this class in DOMWindow without introducing a
circular include dependency.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • page/Frame.cpp:
  • page/Frame.h:
  • page/FrameDestructionObserver.cpp: Added.

(WebCore::FrameDestructionObserver::FrameDestructionObserver):
(WebCore::FrameDestructionObserver::~FrameDestructionObserver):
(WebCore::FrameDestructionObserver::frameDestroyed):

  • page/FrameDestructionObserver.h: Added.

(WebCore::FrameDestructionObserver::frame):

  • plugins/DOMMimeType.h:
  • plugins/DOMPlugin.h:
2:46 PM Changeset in webkit [104343] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

run-api-tests: specify individual suites and tests on the command-line

Reviewed by Adam Roben.

Fixes: <​http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests

The run-api-tests script will now accept a list of arguments on
the command-line that are used as prefix filters. To run all
tests in a suite that starts with "WTF" (WTF and WTF_Vector)
use:

$ run-api-tests WTF

To run only the tests in the "WTF" suite, not the "WTF_Vector"
suite, use:

$ run-api-tests WTF.

  • Scripts/run-api-tests: Filter tests if any prefix arguments

are passed on the command-line.

2:46 PM Changeset in webkit [104342] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings

Reviewed by Adam Roben.

Part of: <​http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests

  • Scripts/run-api-tests:

(dumpTestsBySuite): Update to accept array of tests instead of
hash data structure.
(runTestsBySuite): Ditto.
(listAllTests): Rename from populateTests(). Update to return
an array of tests instad of the hash data structure.

2:27 PM Changeset in webkit [104341] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Snow Leopard build.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::immediateScrollBy):
Move the function definition inside #if ENABLE(RUBBER_BANDING).

2:27 PM Changeset in webkit [104340] by dpranke@chromium.org
  • 10 edits
    1 add in trunk/Tools

webkitpy: clean up test/uri conversion routines
​https://bugs.webkit.org/show_bug.cgi?id=75648

Reviewed by Eric Seidel.

This change moves test_to_uri and uri_to_test from the Port
class to the Driver class (the routines were only being
called by the drivers), and removes a bunch of stale and/or
busted logic.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/driver.py:

(is_http_test):
(test_to_uri):
(uri_to_test):

  • Scripts/webkitpy/layout_tests/port/mock_drt.py:

(run_one_test):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTTest.input_line):
(input_line):
(expected_output):

  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:

(_command_from_driver_input):

2:22 PM Changeset in webkit [104339] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix windows build.

  • wtf/TypeTraits.cpp:
2:15 PM Changeset in webkit [104338] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Default HashTraits for Opcode don't work for Opcode = 0
​https://bugs.webkit.org/show_bug.cgi?id=75595

Reviewed by Oliver Hunt.

Removed the populating of the m_opcodeIDTable table in the
case where the OpcodeID and Opcode are the same (m_enabled is false).
Instead we just cast the one type to the other.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):

  • interpreter/Interpreter.h:

(JSC::Interpreter::getOpcodeID):

2:14 PM Changeset in webkit [104337] by Lucas Forschler
  • 3 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merged r104330.

2:13 PM Changeset in webkit [104336] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: filed ​https://bugs.webkit.org/show_bug.cgi?id=75742
and updated chromium-mac expectations for fast/forms/input-disabled-color.html.

  • platform/chromium/test_expectations.txt:
2:08 PM Changeset in webkit [104335] by andersca@apple.com
  • 2 edits in trunk/Source/ThirdParty

Make JavaScriptCore.framework a reference and put it in a Frameworks group
​https://bugs.webkit.org/show_bug.cgi?id=75740

Reviewed by Mark Rowe.

  • gtest/xcode/gtest.xcodeproj/project.pbxproj:
2:01 PM Changeset in webkit [104334] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[Mac] Thread verifier assertions when printing
​https://bugs.webkit.org/show_bug.cgi?id=75738

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView dealloc]): Dealloc in main thread, so that WebFrameProxy doesn't get deref'ed from a secondary one. (-[WKPrintingView _adjustPrintingMarginsForHeaderAndFooter]): This method calls out to client, which only expects that on main thread. (-[WKPrintingView knowsPageRange:]): Call _adjustPrintingMarginsForHeaderAndFooter on main thread.
1:57 PM Changeset in webkit [104333] by weinig@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add a DecayArray type trait as a first step towards merging OwnPtr and OwnArrayPtr
​https://bugs.webkit.org/show_bug.cgi?id=75737

Reviewed by Anders Carlsson.

  • wtf/TypeTraits.cpp:
  • wtf/TypeTraits.h:

Added a DecayArray trait, that can convert T[] and T[3] -> T*. DecayArray
is composed of some helpers which are also exposed, Conditional<>, which
can provide one type or another based on a boolean predicate, IsArray<>
which can deduce array types, and RemoveExtent<>, which removes the extent
from an array type.

1:55 PM Changeset in webkit [104332] by jonlee@apple.com
  • 3 edits
    1 add in trunk

Clicking on the cancel button on readonly and disabled search fields darkens as if the search field was editable
​https://bugs.webkit.org/show_bug.cgi?id=69886
<rdar://problem/10070187>

Reviewed by Adele Peterson.

.:

  • ManualTests/search-cancel-button.html: Added.

Source/WebCore:

Tests: ManualTests/search-cancel-button.html

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchFieldCancelButton): If the input is readonly and/or disabled, force the cell to
render without highlight.

1:44 PM Changeset in webkit [104331] by Simon Fraser
  • 8 edits in trunk

Mitigate scrollbar differences when running pixel tests
​https://bugs.webkit.org/show_bug.cgi?id=67217

Source/WebCore:

Reviewed by Dan Bernstein.

Export WebCore::Settings::mockScrollbarsEnabled() for DRT.

  • WebCore.exp.in:

Source/WebKit/mac:

Reviewed by Dan Bernstein.

Make it possible to register a custom NSScroller class, which
the WebDynamicScrollBarsView will use when mock scrollbars are enabled.

Also ensure that the WebPreferences mock scrollbars preference is
migrated into Settings.

  • WebView/WebDynamicScrollBarsView.h:
  • WebView/WebDynamicScrollBarsView.mm:

(+[WebDynamicScrollBarsView _horizontalScrollerClass]):
(+[WebDynamicScrollBarsView _verticalScrollerClass]):
(+[WebDynamicScrollBarsView setCustomScrollerClass:]):

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Tools:

Reviewed by Dan Bernstein.

Add an NSScroller subclass that draws mock scrollbars identically
to the WebCore mock scrollbar theme, and register it with the
WebDynamicScrollbarsView.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(-[DRTMockScroller rectForPart:]):
(-[DRTMockScroller drawKnob]):
(-[DRTMockScroller drawRect:]):
(registerMockScrollbars):
(prepareConsistentTestingEnvironment):

1:19 PM Changeset in webkit [104330] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

GetByteArrayLength is incorrect
​https://bugs.webkit.org/show_bug.cgi?id=75735

Reviewed by Filip Pizlo.

Load the byte array length from the correct location.
This stops an existing test from hanging.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

1:18 PM Changeset in webkit [104329] by tsepez@chromium.org
  • 22 edits
    10 adds in trunk

Source/WebCore: Pass Content-Security-Policy directives to worker threads.
​https://bugs.webkit.org/show_bug.cgi?id=73242

Reviewed by David Levin.

Tests: http/tests/security/contentSecurityPolicy/shared-worker-connect-src-allowed.html

http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked.html
http/tests/security/contentSecurityPolicy/worker-connect-src-allowed.html
http/tests/security/contentSecurityPolicy/worker-connect-src-blocked.html

  • page/ContentSecurityPolicy.h:

(WebCore::ContentSecurityPolicy::policy):
(WebCore::ContentSecurityPolicy::headerType):

  • workers/DedicatedWorkerContext.cpp:

(WebCore::DedicatedWorkerContext::DedicatedWorkerContext):

  • workers/DedicatedWorkerContext.h:

(WebCore::DedicatedWorkerContext::create):

  • workers/DedicatedWorkerThread.cpp:

(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
(WebCore::DedicatedWorkerThread::createWorkerContext):

  • workers/DedicatedWorkerThread.h:
  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::notifyFinished):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):

  • workers/DefaultSharedWorkerRepository.h:
  • workers/SharedWorkerContext.cpp:

(WebCore::SharedWorkerContext::SharedWorkerContext):

  • workers/SharedWorkerContext.h:

(WebCore::SharedWorkerContext::create):

  • workers/SharedWorkerThread.cpp:

(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::SharedWorkerThread):
(WebCore::SharedWorkerThread::createWorkerContext):

  • workers/SharedWorkerThread.h:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::WorkerContext):

  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerContext):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadStartupData::create):
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::workerThread):

  • workers/WorkerThread.h:

Source/WebKit/chromium: Pass Content-security-policy directive to worker threads.
​https://bugs.webkit.org/show_bug.cgi?id=73242

Reviewed by David Levin.

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::startWorkerContext):

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::startWorkerContext):

LayoutTests: Pass Content-Security-Policy directives to worker threads.
​https://bugs.webkit.org/show_bug.cgi?id=73242

Reviewed by David Levin.

  • http/tests/security/contentSecurityPolicy/resources/shared-worker-make-xhr.js: Added.

(onconnect):

  • http/tests/security/contentSecurityPolicy/resources/worker-make-xhr.js: Added.
  • http/tests/security/contentSecurityPolicy/shared-worker-connect-src-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/shared-worker-connect-src-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/worker-connect-src-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/worker-connect-src-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/worker-connect-src-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/worker-connect-src-blocked.html: Added.
  • platform/chromium/test_expectations.txt:
1:15 PM Changeset in webkit [104328] by mihnea@adobe.com
  • 4 edits
    6 adds in trunk

[CSSRegions]Crash while collecting svg elements in render flow thread.
​https://bugs.webkit.org/show_bug.cgi?id=73735

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/regions/svg-doc-fragment-not-collected-expected.html

fast/regions/svg-doc-fragment-not-collected.html
fast/regions/svg-element-not-collected-expected.html
fast/regions/svg-element-not-collected.html
fast/regions/svg-root-element-collected.html

By allowing only svg root elements to be collected in a render flow thread,
the svg render tree is properly constructed, thus prevented a possible further crash.

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):

LayoutTests:

  • fast/regions/resources/region-style.css:
  • fast/regions/svg-doc-fragment-not-collected-expected.html: Added.
  • fast/regions/svg-doc-fragment-not-collected.html: Added.
  • fast/regions/svg-element-not-collected-expected.html: Added.
  • fast/regions/svg-element-not-collected.html: Added.
  • fast/regions/svg-root-element-collected-expected.txt: Added.
  • fast/regions/svg-root-element-collected.html: Added.
1:12 PM Changeset in webkit [104327] by eric.carlson@apple.com
  • 9 edits
    2 adds in trunk

Make TextTrackCue more mutable
​https://bugs.webkit.org/show_bug.cgi?id=72555

Reviewed by Anders Carlsson.

Source/WebCore:

Test: media/track/track-cue-mutable.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Do nothing if the "ignore cue updates"

flag is set

(WebCore::HTMLMediaElement::textTrackAddCues): Block cue updates until all of the new cues have

been added, then call updateActiveTextTrackCues so update the display if necessary.

(WebCore::HTMLMediaElement::textTrackRemoveCues): Block cue updates until all of the new cues have

been removed, then call updateActiveTextTrackCues so update the display if necessary.

(WebCore::HTMLMediaElement::textTrackAddCue): Call updateActiveTextTrackCues so update the display if necessary.
(WebCore::HTMLMediaElement::textTrackRemoveCue): Ditto.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::ignoreTrackDisplayUpdateRequests):
(WebCore::HTMLMediaElement::beginIgnoringTrackDisplayUpdateRequests):
(WebCore::HTMLMediaElement::endIgnoringTrackDisplayUpdateRequests):

  • html/TextTrack.cpp:

(WebCore::TextTrack::cueWillChange): New, remove the cue from the media element because its

position in the interval tree is based on start and end times.

(WebCore::TextTrack::cueDidChange): Add the cue to the media element.

  • html/TextTrack.h:
  • html/TextTrackCue.cpp:

(WebCore::startKeyword): New, use a static String for the constant.
(WebCore::middleKeyword): Ditto.
(WebCore::endKeyword): Ditto.
(WebCore::horizontalKeyword): Ditto.
(WebCore::verticalKeyword): Ditto.
(WebCore::verticallrKeyword): Ditto.
(WebCore::TextTrackCue::cueWillChange): New, tell the track the cue is about to change.
(WebCore::TextTrackCue::cueDidChange): New, tell the track the cue has changed.
(WebCore::TextTrackCue::setId): New, attribute is mutable.
(WebCore::TextTrackCue::setStartTime): Ditto.
(WebCore::TextTrackCue::setEndTime): Ditto.
(WebCore::TextTrackCue::setPauseOnExit): Ditto.
(WebCore::TextTrackCue::direction): Ditto.
(WebCore::TextTrackCue::setDirection): Ditto.
(WebCore::TextTrackCue::setSnapToLines): Ditto.
(WebCore::TextTrackCue::setLinePosition): Ditto.
(WebCore::TextTrackCue::setTextPosition): Ditto.
(WebCore::TextTrackCue::setSize): Ditto.
(WebCore::TextTrackCue::alignment): Ditto.
(WebCore::TextTrackCue::setAlignment): Ditto.
(WebCore::TextTrackCue::parseSettings): Use the static strings.

  • html/TextTrackCue.h:

(WebCore::TextTrackCue::id):
(WebCore::TextTrackCue::startTime):
(WebCore::TextTrackCue::endTime):
(WebCore::TextTrackCue::pauseOnExit):

  • html/TextTrackCue.idl:

LayoutTests:

  • media/track/track-cue-mutable-expected.txt: Added.
  • media/track/track-cue-mutable.html: Added.
12:44 PM Changeset in webkit [104326] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix build.

12:44 PM Changeset in webkit [104325] by eae@chromium.org
  • 23 edits in branches/subpixellayout/LayoutTests/platform/mac/tables

Update mac test expectations for table tests

12:38 PM Changeset in webkit [104324] by oliver@apple.com
  • 4 edits in trunk/Source

DFG no longer optimises CanvasPixelArray
​https://bugs.webkit.org/show_bug.cgi?id=75729

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Rename ByteArray (in its ClassInfo) to Uint8ClampedArray to match
the future name when we switch over to the new typed-array based
ImageData specification.

  • runtime/JSByteArray.cpp:

Source/WebCore:

Remove the custom ClassInfo for CanvasPixelArray as that is
defeating ByteArray optimisation, and is no longer needed
anyway as it was only there to change the visible name.

  • bindings/js/JSImageDataCustom.cpp:

(WebCore::toJS):

12:31 PM Changeset in webkit [104323] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

[Mac] Sort the resources of WTF.xcodeproj
​https://bugs.webkit.org/show_bug.cgi?id=75639

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-01-06
Reviewed by Andreas Kling.

  • WTF.xcodeproj/project.pbxproj:
12:30 PM Changeset in webkit [104322] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

ASSERT failure due to combine-text with preceding spaces
​https://bugs.webkit.org/show_bug.cgi?id=65147

Patch by Ken Buchanan <​kenrb@chromium.org> on 2012-01-06
Reviewed by David Hyatt.

Source/WebCore:

A couple of ASSERTs were failing due to a parsing problem when
advancing an inline iterator to the next linebreak in a
RenderCombineText. skipLeadingWhitespace advances the iterator
over leading whitespace but when searching for the line break
nextLineBreak would call RenderCombineText::combineText(),
collapsing the text so that the iterator is pointing past the
end of it.

This patch causes combineText() to be called during
skipLeadingWhiteSpace before iteration over the RenderCombineText
begins.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):
(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):

LayoutTests:

New test with combine-text that begins with mutiple spaces,
showing ASSERT failures in bug 65147.

  • fast/text/international/spaces-combined-in-vertical-text.html: Added
  • fast/text/international/spaces-combined-in-vertical-text-expected.txt: Added
12:25 PM Changeset in webkit [104321] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Make ScrollAnimatorMac::snapRubberBandTimerFired use m_scrollElasticityController in more places
​https://bugs.webkit.org/show_bug.cgi?id=75726

Reviewed by Sam Weinig.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::canScrollHorizontally):
(WebCore::ScrollAnimatorMac::canScrollVertically):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):

  • platform/mac/ScrollElasticityController.h:
12:22 PM Changeset in webkit [104320] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

WebKit1 fails to compile with USE(CFNETWORK) and HAVE(NETWORK_CFDATA_ARRAY_CALLBACK)
​https://bugs.webkit.org/show_bug.cgi?id=75675

Reviewed by Oliver Hunt.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willCacheResponse):

12:21 PM Changeset in webkit [104319] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Need to allow SCNetworkReachability service in sandbox profile
​https://bugs.webkit.org/show_bug.cgi?id=75724
<rdar://problem/10652415>

Reviewed by Mark Rowe.

  • WebProcess/com.apple.WebProcess.sb:
12:20 PM Changeset in webkit [104318] by caio.oliveira@openbossa.org
  • 4 edits in trunk/Source/JavaScriptCore

Use HashMap<OwnPtr> for SourceProviderCache items
​https://bugs.webkit.org/show_bug.cgi?id=75346

Reviewed by Daniel Bates.

  • parser/Parser.cpp:
  • parser/SourceProviderCache.cpp:

(JSC::SourceProviderCache::clear):
(JSC::SourceProviderCache::add):

  • parser/SourceProviderCache.h:
12:15 PM Changeset in webkit [104317] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash with range selection across different documents.
​https://bugs.webkit.org/show_bug.cgi?id=74285

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/dom/Range/range-selection-across-documents-crash.html

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::addRange):

LayoutTests:

  • fast/dom/Range/range-selection-across-documents-crash-expected.txt: Added.
  • fast/dom/Range/range-selection-across-documents-crash.html: Added.
12:12 PM Changeset in webkit [104316] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed; fixing expectation error.

  • platform/chromium/test_expectations.txt:
12:09 PM Changeset in webkit [104315] by weinig@apple.com
  • 11 edits
    3 deletes in trunk/Source

Remove unused OwnFastMallocPtr class.
​https://bugs.webkit.org/show_bug.cgi?id=75722

Reviewed by Geoffrey Garen.

../JavaScriptCore:

  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/OwnFastMallocPtr.h: Removed.
  • wtf/text/StringImpl.h:
  • wtf/wtf.pro:

../JavaScriptGlue:

  • ForwardingHeaders/wtf/OwnFastMallocPtr.h: Removed.

../WebCore:

  • ForwardingHeaders/wtf/OwnFastMallocPtr.h: Removed.
  • bindings/js/JSWebGLRenderingContextCustom.cpp:
12:07 PM Changeset in webkit [104314] by commit-queue@webkit.org
  • 2 edits
    1 add
    4 deletes in trunk/LayoutTests

Convert overflow-in-uniform-regions to a reftest
​https://bugs.webkit.org/show_bug.cgi?id=74765

Replaced the bitmap version of the test with a "reftest" version. Use of text
has been revised a little to mitigate the possibility that small differences in
the platform's default font will change the location of line breaks.

Patch by Hans Muller <​hmuller@adobe.com> on 2012-01-06
Reviewed by Anders Carlsson.

  • fast/regions/overflow-in-uniform-regions-expected.html: Added.
  • fast/regions/overflow-in-uniform-regions.html:
  • platform/efl/fast/regions/overflow-in-uniform-regions-expected.png: Removed.
  • platform/efl/fast/regions/overflow-in-uniform-regions-expected.txt: Removed.
  • platform/mac/fast/regions/overflow-in-uniform-regions-expected.png: Removed.
  • platform/mac/fast/regions/overflow-in-uniform-regions-expected.txt: Removed.
12:05 PM Changeset in webkit [104313] by tony@chromium.org
  • 3 edits
    2 adds in trunk

Need to relayout when stretching the height of a flex item
​https://bugs.webkit.org/show_bug.cgi?id=75661

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/flexbox/flex-align-stretch.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computePreferredMainAxisExtent): Always clear the override size since
it may be set when aligning.
(WebCore::RenderFlexibleBox::alignChildren): Only relayout if the height changed.

LayoutTests:

  • css3/flexbox/flex-align-stretch-expected.txt: Added.
  • css3/flexbox/flex-align-stretch.html: Added.
12:01 PM Changeset in webkit [104312] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Add ScrollElasticityControllerClient::immediateScrollBy
​https://bugs.webkit.org/show_bug.cgi?id=75720

Reviewed by Andreas Kling.

Add a new ScrollElasticityControllerClient::immediateScrollBy client member function.
Also, make ScrollAnimatorMac::smoothScrollWithEvent calls go through the ScrollElasticityController
in preparation for moving that function to ScrollElasticityController.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):

  • platform/mac/ScrollElasticityController.h:
12:00 PM Changeset in webkit [104311] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Mac] Sort the resources of WebKit2.xcodeproj
​https://bugs.webkit.org/show_bug.cgi?id=75636

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-01-06
Reviewed by Andreas Kling.

  • WebKit2.xcodeproj/project.pbxproj:
11:53 AM Changeset in webkit [104310] by dgrogan@chromium.org
  • 2 edits
    2 copies in branches/chromium/963

Merge 104252 - Source/WebCore: IndexedDB: fix cursor prefetch crash
​http://crbug.com/108071
​https://bugs.webkit.org/show_bug.cgi?id=75596

Reviewed by Tony Chang.

Test: storage/indexeddb/prefetch-bugfix-108071.html
Note: DumpRenderTree doesn't exercise the bug, it only occurs in
multi-process chromium. The layout test will soon be run as a
chromium ui test: ​http://codereview.chromium.org/9108004

  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::~IDBCursorBackendImpl): Destroy
cursors before their objectstores.
(WebCore::IDBCursorBackendImpl::prefetchReset): Don't run continue if
the cursor is closed.
(WebCore::IDBCursorBackendImpl::close): Set a closed flag.

  • storage/IDBCursorBackendImpl.h:

LayoutTests: IndexedDB: fix cursor prefetch crash
​https://bugs.webkit.org/show_bug.cgi?id=75596

Reviewed by Tony Chang.

  • storage/indexeddb/prefetch-bugfix-108071-expected.txt: Added.
  • storage/indexeddb/prefetch-bugfix-108071.html: Added.

TBR=​dgrogan@chromium.org
Review URL: ​http://codereview.chromium.org/9121008

11:52 AM Changeset in webkit [104309] by dslomov@google.com
  • 51 edits
    3 copies
    82 adds in trunk/LayoutTests

2012-01-06 Dmitry Lomov <​dslomov@google.com>

Unreviewed: [Chromium] rebaselining IMAGE expectations after ​http://trac.webkit.org/changeset/104240/

  • platform/chromium-cg-mac-leopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-cg-mac-leopard/editing/inserting/before-after-input-element-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/drop-text-without-selection-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/3690703-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/3690719-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/4895428-3-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/selection/4975120-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/drag-select-1-expected.png: Added.
  • platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-cg-mac-leopard/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-cg-mac-leopard/fast/css/input-search-padding-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/css/line-height-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/dom/isindex-001-expected.png:
  • platform/chromium-cg-mac-leopard/fast/dom/isindex-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/events/autoscroll-expected.png:
  • platform/chromium-cg-mac-leopard/fast/events/context-no-deselect-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/encoding-test-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/fieldset-align-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/floating-textfield-relayout-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-baseline-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-readonly-empty-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-spaces-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-table-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-click-outside-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-option-delete-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-text-self-emptying-click-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-type-text-min-width-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-width-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/minWidthPercent-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/text-style-color-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/textfield-overflow-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-cg-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-cg-mac-leopard/fast/frames/take-focus-from-iframe-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-cg-mac-leopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-cg-mac-leopard/fast/html/details-open2-expected.png:
  • platform/chromium-cg-mac-leopard/fast/html/details-open4-expected.png:
  • platform/chromium-cg-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/before-after-input-element-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/4806874-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/input-field-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/3690703-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/3690703-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/3690719-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/4895428-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/4975120-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/drag-select-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/block/margin-collapse/103-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/input-search-padding-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/line-height-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/dom/isindex-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/dom/isindex-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/events/autoscroll-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/events/context-no-deselect-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/encoding-test-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/fieldset-align-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-width-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-baseline-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-readonly-empty-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-spaces-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-table-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-click-outside-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-double-click-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-drag-down-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-option-delete-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-width-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/minWidthPercent-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/text-style-color-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/textfield-overflow-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/html/details-no-summary4-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/html/details-no-summary4-expected.png.
  • platform/chromium-cg-mac-snowleopard/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/html/details-open2-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/html/details-open2-expected.png.
  • platform/chromium-cg-mac-snowleopard/fast/html/details-open4-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/html/details-open4-expected.png.
11:51 AM Changeset in webkit [104308] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Use VectorMath lib when possible to optimize the processing in WebAudio AudioBus
​https://bugs.webkit.org/show_bug.cgi?id=75334

Patch by Wei James <​james.wei@intel.com> on 2012-01-06
Reviewed by Kenneth Russell.

  • platform/audio/AudioBus.cpp:

(WebCore::AudioBus::processWithGainFromMonoStereo):

11:47 AM Changeset in webkit [104307] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit

[Mac] Sort the resources of WebKit.xcodeproj
​https://bugs.webkit.org/show_bug.cgi?id=75634

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-01-06
Reviewed by Andreas Kling.

  • WebKit.xcodeproj/project.pbxproj:
11:38 AM Changeset in webkit [104306] by jer.noble@apple.com
  • 4 edits in trunk

Fullscreen video controller can't be dragged the first time I enter fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=75709

Reviewed by Eric Carlson.

Source/WebCore:

No new tests; updated video-controls-drag.html.

When the media controls are created, check to see if we are full screen, and pass
that information to the newly created controls.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::createMediaControls):

LayoutTests:

Update the test to cover the case where the controls do not yet exist when entering
fullscreen.

  • fullscreen/video-controls-drag.html:
11:30 AM Changeset in webkit [104305] by jonlee@apple.com
  • 2 edits in trunk/LayoutTests

Update test expectations with rebaseline of fast/forms/listbox-clip.html from r104299.

Unreviewed.

  • platform/mac/test_expectations.txt:
11:21 AM Changeset in webkit [104304] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Mac] Sort the resources of JavaScriptCore.xcodeproj and remove duplicates
​https://bugs.webkit.org/show_bug.cgi?id=75631

Patch by Benjamin Poulain <​bpoulain@webkit.org> on 2012-01-06
Reviewed by Andreas Kling.

11:13 AM Changeset in webkit [104303] by jer.noble@apple.com
  • 3 edits
    2 adds in trunk

Media Element: scrubbing in full-screen mode breaks playback.
​https://bugs.webkit.org/show_bug.cgi?id=75650

Reviewed by John Sullivan.

Source/WebCore:

Test: fullscreen/video-controls-timeline.html

Only begin scrubbing if the panel itself is the mousedown event target.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::defaultEventHandler):

LayoutTests:

  • fullscreen/video-controls-timeline-expected.txt: Added.
  • fullscreen/video-controls-timeline.html: Added.
11:03 AM Changeset in webkit [104302] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Add new (failing) test to Chromium test_expectations. Fix tracked by
​https://bugs.webkit.org/show_bug.cgi?id=75716

Unreviewed; test expectations update.

  • platform/chromium/test_expectations.txt:
10:28 AM Changeset in webkit [104301] by jer.noble@apple.com
  • 4 edits
    2 adds in trunk

REGRESSION (r90797): Full screen video HUD cannot be dragged horizontally
​https://bugs.webkit.org/show_bug.cgi?id=75200

Reviewed by Eric Carlson.

Source/WebCore:

Test: fullscreen/video-controls-drag.html

The !important rules in fullscreenQuickTime.css are overriding the styles added by the
drag operation in MediaControlElements.cpp. Give the panel a "dragged" class in setPosition
(clearing it in resetPosition) that allows the !important rules to apply only when the
panel is not dragged.

  • css/fullscreenQuickTime.css:

(video:-webkit-full-screen::-webkit-media-controls-panel):
(video:-webkit-full-screen::-webkit-media-controls-panel:not(.dragged)):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):

LayoutTests:

  • fullscreen/video-controls-drag-expected.txt: Added.
  • fullscreen/video-controls-drag.html: Added.
10:06 AM Changeset in webkit [104300] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Remove fast/files/domurl-script-execution-context-crash.html
from test_expectations (no longer crashing).

Unreviewed; test expectations update.

  • platform/chromium/test_expectations.txt:
9:50 AM Changeset in webkit [104299] by jonlee@apple.com
  • 54 edits
    45 copies
    47 adds in trunk

Tools: Update DRT on Mac to draw resize handles on text areas.

Reviewed by John Sullivan.

Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
between WK1 and WK2. This will require rebaselining existing textarea pixel tests.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

LayoutTests: Rebaseline fast/forms
Rebaseline pixel tests involving textarea.

Reviewed by John Sullivan.

Moved from mac to mac-snowleopard:

  • platform/mac-snowleopard/fast/forms/001
  • platform/mac-snowleopard/fast/forms/HTMLOptionElement_label02
  • platform/mac-snowleopard/fast/forms/HTMLOptionElement_label03
  • platform/mac-snowleopard/fast/forms/HTMLOptionElement_label04
  • platform/mac-snowleopard/fast/forms/basic-buttons-expected
  • platform/mac-snowleopard/fast/forms/basic-inputs-expected
  • platform/mac-snowleopard/fast/forms/basic-selects-expected
  • platform/mac-snowleopard/fast/forms/basic-textareas-expected
  • platform/mac-snowleopard/fast/forms/basic-textareas-quirks-expected
  • platform/mac-snowleopard/fast/forms/box-shadow-override
  • platform/mac-snowleopard/fast/forms/button-align
  • platform/mac-snowleopard/fast/forms/button-generated-content
  • platform/mac-snowleopard/fast/forms/button-sizes
  • platform/mac-snowleopard/fast/forms/button-style-color
  • platform/mac-snowleopard/fast/forms/button-table-styles
  • platform/mac-snowleopard/fast/forms/button-text-transform
  • platform/mac-snowleopard/fast/forms/button-white-space
  • platform/mac-snowleopard/fast/forms/control-restrict-line-height
  • platform/mac-snowleopard/fast/forms/disabled-select-change-index
  • platform/mac-snowleopard/fast/forms/fieldset-align
  • platform/mac-snowleopard/fast/forms/file/file-input-direction
  • platform/mac-snowleopard/fast/forms/form-element-geometry
  • platform/mac-snowleopard/fast/forms/form-hides-table
  • platform/mac-snowleopard/fast/forms/input-appearance-height
  • platform/mac-snowleopard/fast/forms/input-button-sizes
  • platform/mac-snowleopard/fast/forms/input-table
  • platform/mac-snowleopard/fast/forms/input-value
  • platform/mac-snowleopard/fast/forms/menulist-style-color
  • platform/mac-snowleopard/fast/forms/option-strip-whitespace
  • platform/mac-snowleopard/fast/forms/placeholder-position
  • platform/mac-snowleopard/fast/forms/radio_checked
  • platform/mac-snowleopard/fast/forms/radio_checked_dynamic
  • platform/mac-snowleopard/fast/forms/range/slider-padding
  • platform/mac-snowleopard/fast/forms/select-align
  • platform/mac-snowleopard/fast/forms/select-baseline-expected
  • platform/mac-snowleopard/fast/forms/select-disabled-appearance
  • platform/mac-snowleopard/fast/forms/select-initial-position
  • platform/mac-snowleopard/fast/forms/select-style
  • platform/mac-snowleopard/fast/forms/select-writing-direction-natural-expected
  • platform/mac-snowleopard/fast/forms/textAreaLineHeight
  • platform/mac-snowleopard/fast/forms/textarea-align
  • platform/mac-snowleopard/fast/forms/textarea-scroll-height
  • platform/mac-snowleopard/fast/forms/textarea-width
  • platform/mac-snowleopard/fast/overflow/overflow-x-y

New pixel test results:

  • platform/mac/fast/forms/001-expected.png:
  • platform/mac/fast/forms/HTMLOptionElement_label02-expected.png:
  • platform/mac/fast/forms/HTMLOptionElement_label03-expected.png:
  • platform/mac/fast/forms/HTMLOptionElement_label04-expected.png:
  • platform/mac/fast/forms/basic-buttons-expected.png:
  • platform/mac/fast/forms/basic-inputs-expected.png:
  • platform/mac/fast/forms/basic-selects-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.png:
  • platform/mac/fast/forms/box-shadow-override-expected.png:
  • platform/mac/fast/forms/button-align-expected.png:
  • platform/mac/fast/forms/button-generated-content-expected.png:
  • platform/mac/fast/forms/button-sizes-expected.png:
  • platform/mac/fast/forms/button-style-color-expected.png:
  • platform/mac/fast/forms/button-table-styles-expected.png:
  • platform/mac/fast/forms/button-text-transform-expected.png:
  • platform/mac/fast/forms/button-white-space-expected.png:
  • platform/mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/mac/fast/forms/disabled-select-change-index-expected.png:
  • platform/mac/fast/forms/fieldset-align-expected.png:
  • platform/mac/fast/forms/file/file-input-direction-expected.png:
  • platform/mac/fast/forms/form-element-geometry-expected.png:
  • platform/mac/fast/forms/form-hides-table-expected.png:
  • platform/mac/fast/forms/input-appearance-height-expected.png:
  • platform/mac/fast/forms/input-button-sizes-expected.png:
  • platform/mac/fast/forms/input-table-expected.png:
  • platform/mac/fast/forms/input-value-expected.png:
  • platform/mac/fast/forms/menulist-style-color-expected.png:
  • platform/mac/fast/forms/option-strip-whitespace-expected.png:
  • platform/mac/fast/forms/placeholder-position-expected.png:
  • platform/mac/fast/forms/radio_checked-expected.png:
  • platform/mac/fast/forms/radio_checked_dynamic-expected.png:
  • platform/mac/fast/forms/range/slider-padding-expected.png:
  • platform/mac/fast/forms/select-align-expected.png:
  • platform/mac/fast/forms/select-baseline-expected.png:
  • platform/mac/fast/forms/select-disabled-appearance-expected.png:
  • platform/mac/fast/forms/select-initial-position-expected.png:
  • platform/mac/fast/forms/select-style-expected.png:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.png:
  • platform/mac/fast/forms/textAreaLineHeight-expected.png:
  • platform/mac/fast/forms/textarea-align-expected.png:
  • platform/mac/fast/forms/textarea-scroll-height-expected.png:
  • platform/mac/fast/forms/textarea-width-expected.png:
  • platform/mac/fast/overflow/overflow-x-y-expected.png:

Added new results:

  • platform/mac/fast/forms/selectlist-minsize-expected.png: Added. Needs Snow Leopard baseline.
  • platform/mac/fast/forms/basic-selects-expected.txt: Rebaseline since fix of bug 74270.
  • platform/mac/fast/forms/listbox-clip-expected.png: Fix was made to have default # of options in list box to 4, instead of 5. Needed

brand new baseline, and so does Snow Leopard.

  • platform/mac/fast/forms/listbox-clip-expected.txt:
  • platform/mac/test_expectations.txt: New expectations for basic-selects.html, since the fix of bug 74270.

New baselines that were not moved to mac-snowleopard because the difference was just the resize handle.

  • platform/mac/fast/table/003-expected.png:
  • platform/mac/tables/mozilla/bugs/bug194024-expected.png:
  • platform/mac/tables/mozilla/bugs/bug30692-expected.png:
9:34 AM Changeset in webkit [104298] by tony@chromium.org
  • 4 edits in branches/chromium/wpotest/Source

Merge 103722 - [chromium] really enable wpo for WebCore libs and for WTF
​https://bugs.webkit.org/show_bug.cgi?id=75264

Reviewed by Adam Barth.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.gyp/WebCore.gyp: The variable was getting clobbered by the

value set in common.gypi. Use a target_defaults instead to set the
variable. I tested manually on my Windows machine and
WholeProgramOptimization is getting set when buildtype is Official.

TBR=​tony@chromium.org

9:33 AM Changeset in webkit [104297] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebKit/win

Merged r104296.

9:19 AM Changeset in webkit [104296] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Windows build fix.

  • Interfaces/IWebViewPrivate.idl:
9:13 AM Changeset in webkit [104295] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Expectations for svg/carto.net/button.svg can be updated
​https://bugs.webkit.org/show_bug.cgi?id=75621

Unreviewed update to Chromium test_expectations

Patch by Stephen Chenney <​schenney@chromium.org> on 2012-01-06

  • platform/chromium/test_expectations.txt: Removed flakiness line for carto.net/button.svg
9:03 AM Changeset in webkit [104294] by jknotten@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Set baseline for new test plugins/npruntime/object-from-destroyed-plugin-in-subframe.html
​https://bugs.webkit.org/show_bug.cgi?id=75706

Unreviewed.

  • platform/chromium/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Added.
7:42 AM Changeset in webkit [104293] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

make canvas-lineWidth test pass even if pixel values vary a tiny bit
​https://bugs.webkit.org/show_bug.cgi?id=75627

Patch by Elliot Poger <​epoger@google.com> on 2012-01-06
Reviewed by Stephen White.

  • fast/canvas/canvas-lineWidth.js:

(compareRows):

7:37 AM Changeset in webkit [104292] by jknotten@chromium.org
  • 38 edits
    3 copies
    6 moves
    43 adds
    17 deletes in trunk/LayoutTests

Rebaseline mac results after r104240.

​https://bugs.webkit.org/show_bug.cgi?id=75654 changed the way
text fields are drawn on Mac.

Unreviewed.

  • platform/chromium-cg-mac-leopard/fast/forms/input-align-expected.png:
  • platform/chromium-cg-mac-leopard/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-cg-mac-leopard/fast/replaced/replaced-breaking-mixture-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-cg-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-cg-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-cg-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-cg-mac-leopard/fast/table/003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/text-field-baseline-expected.png: Added.
  • platform/chromium-cg-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-cg-mac-leopard/svg/hixie/mixed/003-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/45621-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-align-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-align-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Copied from LayoutTests/platform/chromium-cg-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
  • platform/chromium-cg-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/table/003-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/spanOverlapRepaint-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
  • platform/chromium-cg-mac-snowleopard/fast/table/text-field-baseline-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/hixie/mixed/003-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/45621-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/other/move_row-expected.png: Added.
  • platform/chromium-cg-mac/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
  • platform/chromium-cg-mac/svg/hixie/mixed/003-expected.png: Removed.
  • platform/chromium-cg-mac/tables/mozilla/bugs/bug1188-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/input-align-expected.png:
  • platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-leopard/fast/table/003-expected.png:
  • platform/chromium-mac-leopard/fast/table/text-field-baseline-expected.png:
  • platform/chromium-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/45621-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png.
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/003-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/spanOverlapRepaint-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
  • platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png: Added.
  • platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/45621-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-align-expected.png: Removed.
  • platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.png: Removed.
  • platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.png: Removed.
  • platform/chromium-mac/fast/replaced/width100percent-textfield-expected.png: Removed.
  • platform/chromium-mac/fast/table/003-expected.png: Removed.
  • platform/chromium-mac/fast/table/text-field-baseline-expected.png: Removed.
  • platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png: Removed.
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
  • platform/chromium-mac/svg/hixie/mixed/003-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/45621-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/other/move_row-expected.png: Removed.
  • platform/chromium-win-vista/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
  • platform/chromium-win/http/tests/inspector/network/download-expected.txt: Added.
  • platform/chromium/fast/replaced/width100percent-textfield-expected.png: Added.
  • platform/chromium/fast/table/colspanMinWidth-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png.
  • platform/chromium/fast/table/colspanMinWidth-vertical-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png.
  • platform/chromium/http/tests/inspector/network/download-expected.txt: Added.
  • platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.png:
  • platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Renamed from LayoutTests/plugins/mouse-click-plugin-clears-selection-expected.txt.
7:28 AM Changeset in webkit [104291] by Simon Hausmann
  • 2 edits in trunk

[Qt] Fix compilation of app code against QtWebKit master header file

Unreviewed trivial build fix.

  • Source/sync.profile: Exclude util.h and testwindow.h from the master header

file, because it cannot be used outside of the WebKit source tree.

6:48 AM Changeset in webkit [104290] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

REGRESSION (r104060): fast/forms/textarea-metrics.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=75644

Reviewed by Alexey Proskuryakov.

We need to clear the style selector on doc type change as the doc type
may affect interpretation of the stylesheets. r104060 extended the life
of the style selector in some cases, exposing this problem.

  • dom/Document.cpp:

(WebCore::Document::setDocType):

6:25 AM Changeset in webkit [104289] by kov@webkit.org
  • 4 edits
    2 adds in trunk

Make the new WTF module build on Gtk
​https://bugs.webkit.org/show_bug.cgi?id=75669

Patch by Eric Seidel <​eric@webkit.org> and Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2012-01-06

Source/JavaScriptCore:

  • GNUmakefile.am:

Source/WTF:

  • GNUmakefile.am: Added.
  • GNUmakefile.list.am: Added.
6:21 AM Changeset in webkit [104288] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebKit

[BlackBerry] Upstream BlackBerry WebCoreSupport cache client
​https://bugs.webkit.org/show_bug.cgi?id=75649

Patch by Jacky Jiang <​zhajiang@rim.com> on 2012-01-06
Reviewed by Antonio Gomes.

Initial upstream, no new tests.

  • blackberry/WebCoreSupport/CacheClientBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/CacheClientBlackBerry.h: Added.
5:34 AM Changeset in webkit [104287] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/WebKit2

[Qt][WK2] QQuickWebView breaks when an empty url is loaded
​https://bugs.webkit.org/show_bug.cgi?id=75445

Patch by Rafael Brandao <​rafael.lobo@openbossa.org> on 2012-01-06
Reviewed by Tor Arne Vestbø.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::load):

  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml: Check if a request to load

an empty url is ignored. 'about:blank' should be used instead to load an empty page.

  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
5:18 AM Changeset in webkit [104286] by vestbo@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[Qt] Remove un-needed VPATHs from project includes

Reviewed by Simon Hausmann.

4:53 AM Changeset in webkit [104285] by vestbo@webkit.org
  • 11 edits
    4 moves
    4 adds in trunk

[Qt] Move listing of include paths and libs to pri files in sources

Includepaths are sometimes modified by non-Qt contributors so keeping
them in files inside Sources makes it more likely that they are updated
along with project files for the other ports.

Using pri files instead of prf files for this also has the benefit that
the include() from the main target file can be parsed and followed by
Qt Creator -- something that does not work with load().

Dependency from a target to a library through the WEBKIT variable are
handled through forwarding-files in Tools/qmake/mkspecs/modules, which
set the source root of the module and include the right pri file.

Ideally we'd use the variant of include() that takes an optional
namespace to read the variables into, or the fromfile() function,
but both of these add an overhead of about 40% on the total qmake
runtime, due to making a deep copy of all the variables in the
project or re-reading all the prf files from scratch.

Reviewed by Simon Hausmann.
Reviewed by Ossy.

4:44 AM Changeset in webkit [104284] by vestbo@webkit.org
  • 2 edits in trunk

[Qt] Add a few more files ot OTHER_FILES

Rubber-stamped by Simon Hausmann.

4:27 AM Changeset in webkit [104283] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip a new failing test.

  • platform/qt/Skipped:
3:25 AM Changeset in webkit [104282] by commit-queue@webkit.org
  • 9 edits in trunk

Source/WebKit/efl: [EFL] Add new pre-rendering code.
​https://bugs.webkit.org/show_bug.cgi?id=73430

Patch by JungJik Lee <​jungjik.lee@samsung.com> on 2012-01-06
Reviewed by Zoltan Herczeg.

Add new pre-rendering code to pre-render the view area more efficiently.
At first find centered view position where backing store starts to queuing the render request from.
And append the request into the tiled backing store in spiral order.

  • ewk/ewk_private.h:
  • ewk/ewk_tiled_backing_store.cpp:

(ewk_tiled_backing_store_pre_render_tile_add):
(ewk_tiled_backing_store_pre_render_spiral_queue):

  • ewk/ewk_tiled_backing_store.h:
  • ewk/ewk_view.cpp:

(_ewk_view_smart_pre_render_start):
(ewk_view_base_smart_set):
(ewk_view_pre_render_start):

  • ewk/ewk_view.h:
  • ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_rect_collision_check):
(_ewk_view_tiled_rect_collision_resolve):
(_ewk_view_tiled_smart_pre_render_start):
(ewk_view_tiled_smart_set):

Tools: [EFL] Add pre-render handling code in EWebLauncher.
​https://bugs.webkit.org/show_bug.cgi?id=73430

Patch by JungJik Lee <​jungjik.lee@samsung.com> on 2012-01-06
Reviewed by Zoltan Herczeg.

Add pre-render handling code by pressing Insert key.

  • EWebLauncher/main.c:

(on_key_down):

2:55 AM Changeset in webkit [104281] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.
​https://bugs.webkit.org/show_bug.cgi?id=75698

Unreviewed.

  • platform/chromium/test_expectations.txt:
2:31 AM Changeset in webkit [104280] by zeno.albisser@nokia.com
  • 2 edits
    1 add in trunk/Source/WebKit2

[Qt][WK2] Add test for application URL schemes.
​https://bugs.webkit.org/show_bug.cgi?id=74933

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
2:28 AM Changeset in webkit [104279] by abarth@webkit.org
  • 7 edits in trunk/Source/WebCore

FrameDestructionObserver should be more full-service
​https://bugs.webkit.org/show_bug.cgi?id=75690

Reviewed by Eric Seidel.

This patch moves code common to both subclasses of
FrameDestructionObserver into FrameDestructionObserver itself. As we
add more subclasses, we don't want to keep copy/pasting this code.

  • page/Frame.cpp:

(WebCore::FrameDestructionObserver::FrameDestructionObserver):
(WebCore::FrameDestructionObserver::~FrameDestructionObserver):
(WebCore::FrameDestructionObserver::frameDestroyed):

  • page/Frame.h:

(WebCore::FrameDestructionObserver::frame):

  • plugins/DOMMimeType.cpp:

(WebCore::DOMMimeType::DOMMimeType):
(WebCore::DOMMimeType::~DOMMimeType):

  • plugins/DOMMimeType.h:
  • plugins/DOMPlugin.cpp:

(WebCore::DOMPlugin::DOMPlugin):
(WebCore::DOMPlugin::~DOMPlugin):

  • plugins/DOMPlugin.h:
1:43 AM Changeset in webkit [104278] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

Move MediaDocument styles into CSS. Set black background for chromium.
​https://bugs.webkit.org/show_bug.cgi?id=74123

Source/WebCore:

Patch by Dale Curtis <​dalecurtis@chromium.org> on 2012-01-06
Reviewed by Eric Seidel.

Test: platform/chromium/media/video-black-bg-in-media-document.html

  • css/mediaControls.css:

(body:-webkit-full-page-media):
(video:-webkit-full-page-media):

  • css/mediaControlsChromium.css:

(body:-webkit-full-page-media):

  • html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

LayoutTests:

Adds a new chromium specific test for ensuring the background is set
properly.

Rebaselines the text portions of media-document-audio-repaint.

Patch by Dale Curtis <​dalecurtis@chromium.org> on 2012-01-06
Reviewed by Eric Seidel.

  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-gpu/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium/media/media-document-audio-repaint-expected.txt:
  • platform/chromium/media/video-black-bg-in-media-document-expected.txt: Added.
  • platform/chromium/media/video-black-bg-in-media-document.html: Added.
  • platform/chromium/test_expectations.txt:
1:03 AM Changeset in webkit [104277] by Csaba Osztrogonác
  • 5 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Update Qt specific expected results after r104208.

  • platform/qt/fast/table/032-expected.png:
  • platform/qt/fast/table/032-expected.txt:
  • platform/qt/fast/writing-mode/table-percent-width-quirk-expected.png: Added.
  • platform/qt/fast/writing-mode/table-percent-width-quirk-expected.txt: Added.
  • platform/qt/tables/mozilla/bugs/bug55694-expected.png:
  • platform/qt/tables/mozilla/bugs/bug55694-expected.txt:
12:53 AM Changeset in webkit [104276] by aboxhall@chromium.org
  • 13 edits
    2 adds in trunk

Report correct line number for non-native editable text elements.
​https://bugs.webkit.org/show_bug.cgi?id=71263

Reviewed by Ryosuke Niwa.

Source/WebCore:

A non-native editable text element is an element with an ARIA role of "textbox", which is
set on an element which behaves like an editable text element (such as a textarea, text
input field or contenteditable text), but whose behaviour is controlled by the author rather
than the browser.

This change makes certain methods on Node, and related methods in htmlediting and
visible_units, aware of the notion that an element may be editable only from the point of
view of assistive technology (via the ARIA textbox role), via the EditableType enum added to
EditingBoundary.h.

This is so that AccessibilityObject::lineForPosition() can use previousLinePosition(), and
AccessibilityRenderObject::indexForVisiblePosition() can use highestEditableRoot(), in a way
that respects non-native editability.

Test: accessibility/textbox-role-reports-line-number.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::rootAXEditableElement): Returns the root element which is
editable from the point of view of assistive technology, whether natively or otherwise.
(WebCore::AXObjectCache::nodeIsTextControl): Whether the given node is considered an
editable text element by assistive technology, natively or otherwise.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::lineForPosition): Modified to request the previous line
position in an element which is editable to Accessibility.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::indexForVisiblePosition): Modified to request the
highest root element which is editable to Accessibility.

  • dom/Node.cpp:

(WebCore::Node::rendererIsEditableToAccessibility): Whether this node is editable to
Accessibility for the given EditableLevel.
(WebCore::Node::rootEditableElement): Overloaded version of this method which takes an
EditableType enum value indicating whether non-native editability is to be respected.

  • dom/Node.h:

(WebCore::Node::rendererIsEditable): Overloaded version of this method which takes an
EditableType enum value indicating whether non-native editability is to be respected.
(WebCore::Node::rendererIsRichlyEditable): Overloaded version of this method which takes
an EditableType enum value indicating whether non-native editability is to be respected.

  • editing/EditingBoundary.h:
  • editing/htmlediting.cpp:

(WebCore::highestEditableRoot): Added optional EditableType parameter.
(WebCore::isEditablePosition): Added optional EditableType parameter.
(WebCore::isRichlyEditablePosition): Added optional EditableType parameter.
(WebCore::editableRootForPosition): Added optional EditableType parameter.

  • editing/htmlediting.h:
  • editing/visible_units.cpp:

(WebCore::previousLeafWithSameEditability): Added optional EditableType parameter.
(WebCore::previousLinePosition): Added optional EditableType parameter.
(WebCore::nextLeafWithSameEditability): Added optional EditableType parameter.
(WebCore::nextLinePosition): Added optional EditableType parameter.

  • editing/visible_units.h:

LayoutTests:

  • accessibility/textbox-role-reports-line-number-expected.txt: Added.
  • accessibility/textbox-role-reports-line-number.html: Added.
12:47 AM Changeset in webkit [104275] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

Fix a crash by importing an element of which local name ends with ":input".
​https://bugs.webkit.org/show_bug.cgi?id=75103

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/dom/importNode-confusing-localName.html

  • dom/Document.cpp:

(WebCore::Document::importNode): Pass QualifiedName of the source elemnt
to createElement() in order to avoid unnecessary serialization and
parsing of the qualified name

LayoutTests:

  • fast/dom/importNode-confusing-localName-expected.txt: Added.
  • fast/dom/importNode-confusing-localName.html: Added.
12:33 AM Changeset in webkit [104274] by tkent@chromium.org
  • 13 edits
    1 copy
    1 add in trunk/Source/WebCore

Move HTMLFormControlElementWithState class in its own header file.
​https://bugs.webkit.org/show_bug.cgi?id=75482

Patch by Alexis Menard <​alexis.menard@openbossa.org> on 2012-01-06
Reviewed by Kent Tamura.

Move HTMLFormControlElementWithState class which was mixed in HTMLFormControlElement
files into its own header file and its own implementation file.

No new tests : the existing ones should cover the refactoring.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLFormControlElement.cpp:
  • html/HTMLFormControlElement.h:
  • html/HTMLKeygenElement.h:
  • html/HTMLSelectElement.h:
  • html/HTMLTextFormControlElement.h:
12:14 AM Changeset in webkit [104273] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

NRWT should use test_expectation.txt on wk2 platforms
​https://bugs.webkit.org/show_bug.cgi?id=75417

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(path_to_test_expectations_file):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(test_path_to_test_expectations_file):

12:09 AM Changeset in webkit [104272] by Csaba Osztrogonác
  • 13 edits
    2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r104268.
​http://trac.webkit.org/changeset/104268
​https://bugs.webkit.org/show_bug.cgi?id=75689

It broke the mac build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-01-06

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::didMoveToNewDocument):
(WebCore::HTMLFormControlElementWithState::shouldAutocomplete):
(WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState):
(WebCore::HTMLFormControlElementWithState::finishParsingChildren):

  • html/HTMLFormControlElement.h:

(WebCore::HTMLFormControlElementWithState::canContainRangeEndPoint):
(WebCore::HTMLFormControlElementWithState::saveFormControlState):
(WebCore::HTMLFormControlElementWithState::restoreFormControlState):

  • html/HTMLFormControlElementWithState.cpp: Removed.
  • html/HTMLFormControlElementWithState.h: Removed.
  • html/HTMLKeygenElement.h:
  • html/HTMLSelectElement.h:
  • html/HTMLTextFormControlElement.h:
12:07 AM Changeset in webkit [104271] by commit-queue@webkit.org
  • 15 edits
    2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r104259 and r104261.
​http://trac.webkit.org/changeset/104259
​http://trac.webkit.org/changeset/104261
​https://bugs.webkit.org/show_bug.cgi?id=75688

Caused assertion failures (Requested by rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-01-06

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):

  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp:

(WebCore::Document::setDocType):
(WebCore::Document::adoptNode):

  • dom/Element.cpp:

(WebCore::Element::removeShadowRoot):

  • dom/Node.cpp:

(WebCore::Node::setDocument):
(WebCore::Node::setTreeScopeRecursively):
(WebCore::Node::setDocumentRecursively):
(WebCore::Node::didMoveToNewDocument):

  • dom/Node.h:
  • dom/TreeScope.cpp:
  • dom/TreeScope.h:
  • dom/TreeScopeAdopter.cpp: Removed.
  • dom/TreeScopeAdopter.h: Removed.
12:04 AM Changeset in webkit [104270] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

WTF::String: Inline method shouldn't have WTF_EXPORT_PRIVATE
​https://bugs.webkit.org/show_bug.cgi?id=75612

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-01-06
Reviewed by Kevin Ollivier.

  • wtf/text/WTFString.h:

(WTF::String::findIgnoringCase):
(WTF::String::append):
(WTF::String::fromUTF8):
(WTF::String::fromUTF8WithLatin1Fallback):
(WTF::String::isHashTableDeletedValue):

Note: See TracTimeline for information about the timeline view.