⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 8, 2012:

11:18 PM Changeset in webkit [104436] by wangxianzhu@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix compilation error about ListHashSetReverseIterator
​https://bugs.webkit.org/show_bug.cgi?id=75372

Reviewed by Darin Adler.

There is a typo in class ListHashSetReverseIterator:
typedef ListHashSetConstIterator<ValueArg, inlineCapacity, HashArg> const_reverse_iterator;
Should be
typedef ListHashSetConstReverseIterator<ValueArg, inlineCapacity, HashArg> const_reverse_iterator;

  • wtf/ListHashSet.h:
11:15 PM Changeset in webkit [104435] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix: ScrollAnimatorMac has missing initializer in systemUptime()
​https://bugs.webkit.org/show_bug.cgi?id=75827

Reviewed by Darin Adler.

Explicitly initialize the struct timeval to avoid compiler warnings.

  • platform/mac/ScrollAnimatorMac.mm:

(systemUptime):

11:09 PM Changeset in webkit [104434] by Lucas Forschler
  • 5 edits in branches/safari-534.54-branch/Source

Versioning.

11:01 PM Changeset in webkit [104433] by Lucas Forschler
  • 1 copy in tags/Safari-534.54.3

New tag.

10:56 PM Changeset in webkit [104432] by mikelawther@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

color tests for CSS3 calc
​https://bugs.webkit.org/show_bug.cgi?id=75819

Reviewed by Eric Seidel.

Tests for future implementation of CSS3 calc() (see ​http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/color-hsl-expected.txt: Added.
  • css3/calc/color-hsl.html: Added.
  • css3/calc/color-rgb-expected.txt: Added.
  • css3/calc/color-rgb.html: Added.
10:14 PM Changeset in webkit [104431] by mikelawther@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

font tests for CSS3 calc
​https://bugs.webkit.org/show_bug.cgi?id=75818

Reviewed by Eric Seidel.

Tests for future implementation of CSS3 calc() (see ​http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/font-expected.txt: Added.
  • css3/calc/font-monospace-expected.txt: Added.
  • css3/calc/font-monospace.html: Added.
  • css3/calc/font-size-expected.txt: Added.
  • css3/calc/font-size-fractional-expected.txt: Added.
  • css3/calc/font-size-fractional.html: Added.
  • css3/calc/font-size.html: Added.
  • css3/calc/font.html: Added.
10:01 PM Changeset in webkit [104430] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Memory allocation mismatch by using adoptArrayPtr in GraphicsContext3DOpenGL.cpp
​https://bugs.webkit.org/show_bug.cgi?id=75820

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-01-08
Reviewed by Darin Adler.

Dbates submitted a patch to release fastMalloc allocation
in GraphicsContext3DOpenGL.cpp properly.
See ​http://trac.webkit.org/browser/trunk/Source/WebCore/ChangeLog?rev=104395
But one thing similar to the above still remains mismatched.

No new tests required.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::getShaderInfoLog):

8:27 PM Changeset in webkit [104429] by rniwa@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

WinCE build fix after r104415.

  • jit/JITExceptions.cpp:
  • jit/JITExceptions.h:
6:57 PM Changeset in webkit [104428] by mikelawther@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

border tests for CSS3 calc
​https://bugs.webkit.org/show_bug.cgi?id=75815

Tests for future implementation of CSS3 calc() (see ​http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

Reviewed by Adam Barth.

  • css3/calc/border-expected.txt: Added.
  • css3/calc/border-radius-expected-mismatch.html: Added.
  • css3/calc/border-radius.html: Added.
  • css3/calc/border.html: Added.
6:50 PM Changeset in webkit [104427] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Use the concrete FrameNetworkingContextBlackBerry to access Frame
​https://bugs.webkit.org/show_bug.cgi?id=75611

Reviewed by Antonio Gomes.

In platform/network/blackberry/ResourceHandleBlackBerry.cpp, we were using
NetworkingContext::wrappedFrame() to access the frame associated with the
networking context. NetworkingContext::wrappedFrame() was added as a virtual
function by the BlackBerry porting internally. It's unnecessary because
FrameNetworkingContextBlackBerry inherits from FrameNetworkingContext which
has a protected frame() member which is exported as public in
FrameNetworkingContextBlackBerry. We don't want to upstream wrappedFrame()
as a specific change of the BlackBerry porting in
platform/network/NetworkingContext.h, so use the concrete networking context
FrameNetworkingContextBlackBerry to access the associated frame.

No functionalities changed, no new tests.

  • platform/network/blackberry/ResourceHandleBlackBerry.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

6:41 PM Changeset in webkit [104426] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add intermittent timeout expectations to media/track/track-cues-cuechange.html and
media/track/track-cues-enter-exit.html. The failure is tracked by the bug 75817.

  • platform/chromium/test_expectations.txt:
6:33 PM Changeset in webkit [104425] by commit-queue@webkit.org
  • 8 edits
    54 deletes in trunk

Unreviewed, rolling out r104421.
​http://trac.webkit.org/changeset/104421
​https://bugs.webkit.org/show_bug.cgi?id=75816

Need to rebaseline some tests on Linux (Requested by noamr on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-01-08

Source/WebCore:

  • Target.pri:

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::allowedCompositingTriggers):

Tools:

  • qmake/mkspecs/features/features.prf:

LayoutTests:

  • platform/qt/Skipped:
  • platform/qt/css3/filters/add-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/add-filter-rendering-expected.txt: Removed.
  • platform/qt/css3/filters/crash-filter-change-expected.png: Removed.
  • platform/qt/css3/filters/crash-filter-change-expected.txt: Removed.
  • platform/qt/css3/filters/crash-hw-sw-switch-expected.png: Removed.
  • platform/qt/css3/filters/custom-filter-property-parsing-expected.txt: Removed.
  • platform/qt/css3/filters/custom-filter-property-parsing-invalid-expected.txt: Removed.
  • platform/qt/css3/filters/effect-blur-expected.png: Removed.
  • platform/qt/css3/filters/effect-blur-expected.txt: Removed.
  • platform/qt/css3/filters/effect-brightness-expected.png: Removed.
  • platform/qt/css3/filters/effect-brightness-expected.txt: Removed.
  • platform/qt/css3/filters/effect-contrast-expected.png: Removed.
  • platform/qt/css3/filters/effect-contrast-expected.txt: Removed.
  • platform/qt/css3/filters/effect-drop-shadow-expected.png: Removed.
  • platform/qt/css3/filters/effect-drop-shadow-expected.txt: Removed.
  • platform/qt/css3/filters/effect-grayscale-expected.png: Removed.
  • platform/qt/css3/filters/effect-grayscale-expected.txt: Removed.
  • platform/qt/css3/filters/effect-hue-rotate-expected.png: Removed.
  • platform/qt/css3/filters/effect-hue-rotate-expected.txt: Removed.
  • platform/qt/css3/filters/effect-invert-expected.png: Removed.
  • platform/qt/css3/filters/effect-invert-expected.txt: Removed.
  • platform/qt/css3/filters/effect-opacity-expected.png: Removed.
  • platform/qt/css3/filters/effect-opacity-expected.txt: Removed.
  • platform/qt/css3/filters/effect-saturate-expected.png: Removed.
  • platform/qt/css3/filters/effect-saturate-expected.txt: Removed.
  • platform/qt/css3/filters/effect-sepia-expected.png: Removed.
  • platform/qt/css3/filters/effect-sepia-expected.txt: Removed.
  • platform/qt/css3/filters/filter-animation-expected.png: Removed.
  • platform/qt/css3/filters/filter-animation-expected.txt: Removed.
  • platform/qt/css3/filters/filter-animation-from-none-expected.png: Removed.
  • platform/qt/css3/filters/filter-animation-from-none-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-computed-style-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-expected.png: Removed.
  • platform/qt/css3/filters/filter-property-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-parsing-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-parsing-invalid-expected.txt: Removed.
  • platform/qt/css3/filters/filter-region-expected.png: Removed.
  • platform/qt/css3/filters/filter-region-expected.txt: Removed.
  • platform/qt/css3/filters/filter-repaint-expected.png: Removed.
  • platform/qt/css3/filters/filter-repaint-expected.txt: Removed.
  • platform/qt/css3/filters/filter-with-transform-expected.png: Removed.
  • platform/qt/css3/filters/filter-with-transform-expected.txt: Removed.
  • platform/qt/css3/filters/filtered-inline-expected.png: Removed.
  • platform/qt/css3/filters/filtered-inline-expected.txt: Removed.
  • platform/qt/css3/filters/nested-filter-expected.png: Removed.
  • platform/qt/css3/filters/nested-filter-expected.txt: Removed.
  • platform/qt/css3/filters/nested-filters-expected.png: Removed.
  • platform/qt/css3/filters/nested-filters-expected.txt: Removed.
  • platform/qt/css3/filters/regions-expanding-expected.png: Removed.
  • platform/qt/css3/filters/regions-expanding-expected.txt: Removed.
  • platform/qt/css3/filters/remove-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/remove-filter-rendering-expected.txt: Removed.
  • platform/qt/css3/filters/simple-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/simple-filter-rendering-expected.txt: Removed.
6:14 PM Changeset in webkit [104424] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk/LayoutTests

Another Chromium Windows and Chromium Linux rebaseline after r104240.
The expected result committed in r104361 was clearly wrong.

  • platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-win-vista/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.png:
5:01 PM Changeset in webkit [104423] by abarth@webkit.org
  • 6 edits in trunk/Tools

Remove support for Chromium Mac CG from garden-o-matic
​https://bugs.webkit.org/show_bug.cgi?id=75814

Reviewed by Eric Seidel.

This configuration no longer exists. This patch is mostly a matter of
updating config.js and removing the examples from the unit tests.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
4:49 PM Changeset in webkit [104422] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Remove Mac CG specific expectations in test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=75813

Unreviewed.

This configuration no longer exists and this change is needed to stop
the bots from erroring out.

  • platform/chromium/test_expectations.txt:
4:46 PM Changeset in webkit [104421] by noam.rosenthal@nokia.com
  • 8 edits
    54 adds in trunk

[Qt] Enable CSS_FILTERS in Qt build
​https://bugs.webkit.org/show_bug.cgi?id=75777

Source/WebCore:

Enable CSS_FILTERS and unskip the tests.

Reviewed by Kenneth Rohde Christiansen.

Filter tests are now unskipped for Qt.

  • Target.pri: add missing files to build.

Source/WebKit/qt:

For now, disallow compositing for filters. We will change that trigger when
​https://bugs.webkit.org/show_bug.cgi?id=75778 is implemented.

Reviewed by Kenneth Rohde Christiansen.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::allowedCompositingTriggers):

Tools:

Add the CSS_FILTERS feature flag to Qt.

Reviewed by Kenneth Rohde Christiansen.

  • qmake/mkspecs/features/features.prf:

LayoutTests:

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/Skipped: Unskip filter tests that work.
  • platform/qt/css3/filters/*: Added Qt specific results.
4:32 PM Changeset in webkit [104420] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Categorize bots by ports instead of core/non-core separation
​https://bugs.webkit.org/show_bug.cgi?id=75766

Reviewed by Eric Seidel.

Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
(Chromium still comes before GTK and Qt).

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
4:29 PM Changeset in webkit [104419] by levin@chromium.org
  • 4 edits
    5 adds in trunk

[chromium] iframes in an autoresized window get sized incorrectly.
​https://bugs.webkit.org/show_bug.cgi?id=75806

Reviewed by Adam Barth.

Source/WebKit/chromium:

TEST: fast/autoresize/autoresize-with-iframe.html

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView): Only do autoresizing
for the main frame not child frames.

LayoutTests:

  • fast/autoresize/autoresize-with-iframe-expected.txt: Added.
  • fast/autoresize/autoresize-with-iframe.html: Added.
  • fast/autoresize/basic.html: Pulled out autoresize-util.js
  • fast/autoresize/resources/autoresize-util.js: Added.

(log):
(shouldBe):

  • fast/autoresize/resources/iframe.html: Added.
4:27 PM Changeset in webkit [104418] by abarth@webkit.org
  • 5 edits in trunk/Source

[Chromium] Remove use_skia option from GYP
​https://bugs.webkit.org/show_bug.cgi?id=75811

Reviewed by Ryosuke Niwa.

The CG configuration of Chromium Mac is no longer supported.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • WebKit.gyp:
  • WebKit.gypi:
4:12 PM Changeset in webkit [104417] by rniwa@webkit.org
  • 4 edits in trunk/Tools

Remove the concept of core builders from webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=75809

Reviewed by Ryosuke Niwa.

Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
and remove the relevant code.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot.init):
(BuildBot._matches_regexps):
(BuildBot._builder_statuses_with_names_matching_regexps):
(BuildBot.builder_statuses):
(BuildBot.failure_map):
(BuildBot._latest_builds_from_builders):
(BuildBot.last_green_revision):

  • Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:

(MockBuildBot.builder_statuses):

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(test_status_parsing):
(test_last_green_revision):
(test_last_green_revision.mock_builds_from_builders):

4:04 PM Changeset in webkit [104416] by abarth@webkit.org
  • 19 edits in trunk/Tools

Remove Chromium Mac CG concept from webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=75810

Reviewed by Ryosuke Niwa.

This configuration no longer exists. We can remove all the supporting
code from webkitpy.

  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

(BaselineOptimizerTest.test_move_baselines):
(BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
(BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
(BaselineOptimizerTest.test_common_directory_includes_root):
(BaselineOptimizerTest.test_complex_shadowing):

  • Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build):

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest):

  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):
(ChromiumPort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

(_default_tests_paths):
(ChromiumGpuLinuxPort.tests):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

(ChromiumGpuTest.integration_test_chromium_gpu_mac):
(ChromiumGpuTest.assert_port_works):
(ChromiumGpuTest.test_baseline_paths):
(ChromiumGpuTest.test_graphics_type):
(ChromiumGpuTest.test_default_tests_paths):
(ChromiumGpuTest.test_test_files):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort):
(ChromiumMacPort.init):
(ChromiumMacPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_graphics_type):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory._port_name_from_arguments_and_options):
(PortFactory.get):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest.test_chromium_gpu_mac):
(FactoryTest.test_chromium_mac):

  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

(GetGoogleChromePortTest._verify_expectations_overrides):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockChromiumDRTTest.test_chromium_parse_options):

  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:

(test_url_fetcher):
(test_zip_factory):
(test_archive):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline_expectations):

3:46 PM Changeset in webkit [104415] by fpizlo@apple.com
  • 8 edits
    2 adds in trunk/Source/JavaScriptCore

The JIT's protocol for exception handling should be available to other parts of the system
​https://bugs.webkit.org/show_bug.cgi?id=75808
<rdar://problem/10661025>

Reviewed by Oliver Hunt.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • jit/JITExceptions.cpp: Added.

(JSC::genericThrow):
(JSC::jitThrow):

  • jit/JITExceptions.h: Added.
  • jit/JITStubs.cpp:
  • runtime/JSGlobalData.h:
3:44 PM Changeset in webkit [104414] by benjamin@webkit.org
  • 10 edits
    6 adds in trunk

Valid canonical URLs should have a lowercase hostname
​https://bugs.webkit.org/show_bug.cgi?id=75771

Reviewed by Adam Barth.

Source/WebCore:

According to the RFC 3986 (and other browsers implementation), the hostname
of valid canonical URLs should be lowercase.

This patch lowercase the hostname in KURL::parse() similarily to what we
do for the scheme.

Tests: fast/url/host-lowercase-per-scheme.html

fast/url/safari-extension.html

  • platform/KURL.cpp:

(WebCore::isCanonicalHostnameLowercaseForScheme):
(WebCore::KURL::parse):

LayoutTests:

Update the test results for existing tests validating the hostname.

Added the test safari-extension.html for checking regressions of
the safari-extension:// protocol.

Added host-lowercase-per-scheme.html for testing the hostname is
set to lowercase for regognized Internet protocols.

  • fast/url/host-expected.txt:
  • fast/url/host-lowercase-per-scheme-expected.txt: Added.
  • fast/url/host-lowercase-per-scheme.html: Added.
  • fast/url/idna2008-expected.txt:
  • fast/url/ipv4-expected.txt:
  • fast/url/ipv6-expected.txt:
  • fast/url/relative-expected.txt:
  • fast/url/relative-unix-expected.txt:
  • fast/url/safari-extension-expected.txt: Added.
  • fast/url/safari-extension.html: Added.
  • fast/url/standard-url-expected.txt:
  • platform/chromium/fast/url/host-lowercase-per-scheme-expected.txt: Added.
  • platform/chromium/fast/url/safari-extension-expected.txt: Added.
3:28 PM Changeset in webkit [104413] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Categorize bots by ports instead of core/non-core separation
​https://bugs.webkit.org/show_bug.cgi?id=75766

Reviewed by Adam Barth.

Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3:15 PM Changeset in webkit [104412] by abarth@webkit.org
  • 10 edits in trunk/Source/WebCore

Rename checkNodeSecurity and allowsAccessFromFrame to have sensible names
​https://bugs.webkit.org/show_bug.cgi?id=75796

Reviewed by Sam Weinig.

This patch contains only renames and FIXME comments. No behavior change.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::allowAccessToNode):
(WebCore::allowAccessToFrame):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSHTMLFrameElementCustom.cpp:

(WebCore::allowSettingJavascriptURL):

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::getOwnPropertySlotDelegate):
(WebCore::JSHistory::getOwnPropertyDescriptorDelegate):
(WebCore::JSHistory::putDelegate):
(WebCore::JSHistory::deleteProperty):
(WebCore::JSHistory::getOwnPropertyNames):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::getOwnPropertySlotDelegate):
(WebCore::JSLocation::getOwnPropertyDescriptorDelegate):
(WebCore::JSLocation::putDelegate):
(WebCore::JSLocation::deleteProperty):
(WebCore::JSLocation::getOwnPropertyNames):
(WebCore::JSLocation::toStringFunction):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::canAccessFromCurrentOrigin):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateFunctionCallback):

2:48 PM Changeset in webkit [104411] by abarth@webkit.org
  • 15 edits in trunk/Source/WebCore

Remove deprecated toDynamicFrame and unused [CallWith=DynamicFrame]
​https://bugs.webkit.org/show_bug.cgi?id=75795

Reviewed by Eric Seidel.

We've succeeded in removing all the callers fo this function, including
all the uses of CallWith=DynamicFrame in IDL files.

  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallString):

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:
1:59 PM Changeset in webkit [104410] by abarth@webkit.org
  • 14 edits in trunk/Source/WebCore

NeedsUserGestureCheck IDL attribute is no longer used
​https://bugs.webkit.org/show_bug.cgi?id=75794

Reviewed by Eric Seidel.

This IDL attribute is no longer used because we use static state to
keep track of the user gesture state. We can delete the code that
supports it.

  • bindings/scripts/CodeGeneratorCPP.pm:
  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/TestObj.idl:
1:44 PM Changeset in webkit [104409] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r103859): WKViews leak
​https://bugs.webkit.org/show_bug.cgi?id=75805

The flags changed event monitor added in r103859 was retaining the WKView (as it references
self in the handler block), causing it to leak.

  • UIProcess/API/mac/WKView.mm:

(-[WKView dealloc]): Moved call to remove the flags changed event monitor from here...
(-[WKView viewDidMoveToWindow]): ...to here. Moved call to add the flags changed event
monitor to here from...
(-[WKView initWithFrame:contextRef:pageGroupRef:]): ...here.

1:33 PM Changeset in webkit [104408] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove unused security functions from V8 bindings
​https://bugs.webkit.org/show_bug.cgi?id=75797

Reviewed by Eric Seidel.

This functions have no callers. They can be removed.

  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:
  • bindings/v8/specialization/V8BindingState.cpp:
  • bindings/v8/specialization/V8BindingState.h:
1:31 PM Changeset in webkit [104407] by psolanki@apple.com
  • 4 edits in trunk/Source/WebCore

Assertion failure under SharedBuffer::append() when NETWORK_CFDATA_ARRAY_CALLBACK is enabled
​https://bugs.webkit.org/show_bug.cgi?id=75656

Reviewed by Darin Adler.

Update the implementation of SubresourceLoader::didReceiveDataArray() to conform to the
refactoring done as part of bug 71149 in r100311.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveData):
(WebCore::SubresourceLoader::errorLoadingResource):

  • loader/SubresourceLoader.h:
  • loader/cf/SubresourceLoaderCF.cpp:

(WebCore::SubresourceLoader::didReceiveDataArray):

1:03 PM Changeset in webkit [104406] by steveblock@google.com
  • 6 edits
    9 deletes in trunk/Source/WebCore

Remove V8-specific Java Bridge code
​https://bugs.webkit.org/show_bug.cgi?id=75801

Reviewed by Darin Adler.

Also remove superfluous JSC and V8 guards, as the code is now used only
with JSC.

No new tests, removing dead code only.

  • WebCore.gypi:
  • bridge/jni/JNIUtility.cpp:

(JSC::Bindings::javaTypeFromClassName):
(JSC::Bindings::signatureFromJavaType):
(JSC::Bindings::getJNIField):
(JSC::Bindings::callJNIMethod):

  • bridge/jni/JavaType.h:
  • bridge/jni/jsc/JavaMethodJSC.cpp:

(appendClassName):
(JavaMethod::signature):

  • bridge/jni/v8/JNIUtilityPrivate.cpp: Removed.
  • bridge/jni/v8/JNIUtilityPrivate.h: Removed.
  • bridge/jni/v8/JavaClassV8.h: Removed.
  • bridge/jni/v8/JavaFieldV8.h: Removed.
  • bridge/jni/v8/JavaInstanceV8.h: Removed.
  • bridge/jni/v8/JavaMethodV8.h: Removed.
  • bridge/jni/v8/JavaNPObjectV8.cpp: Removed.
  • bridge/jni/v8/JavaNPObjectV8.h: Removed.
  • bridge/jni/v8/JavaValueV8.h: Removed.
  • bridge/jsc/BridgeJSC.h:
11:35 AM Changeset in webkit [104405] by Csaba Osztrogonác
  • 8 edits
    54 deletes in trunk

Unreviewed, rolling out r104403.
​http://trac.webkit.org/changeset/104403
​https://bugs.webkit.org/show_bug.cgi?id=75803

It broke all tests on Qt5 (Requested by Ossy_weekend on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-01-08

Source/WebCore:

  • Target.pri:

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::allowedCompositingTriggers):

Tools:

  • qmake/mkspecs/features/features.prf:

LayoutTests:

  • platform/qt/Skipped:
  • platform/qt/css3/filters/add-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/add-filter-rendering-expected.txt: Removed.
  • platform/qt/css3/filters/crash-filter-change-expected.png: Removed.
  • platform/qt/css3/filters/crash-filter-change-expected.txt: Removed.
  • platform/qt/css3/filters/crash-hw-sw-switch-expected.png: Removed.
  • platform/qt/css3/filters/custom-filter-property-parsing-expected.txt: Removed.
  • platform/qt/css3/filters/custom-filter-property-parsing-invalid-expected.txt: Removed.
  • platform/qt/css3/filters/effect-blur-expected.png: Removed.
  • platform/qt/css3/filters/effect-blur-expected.txt: Removed.
  • platform/qt/css3/filters/effect-brightness-expected.png: Removed.
  • platform/qt/css3/filters/effect-brightness-expected.txt: Removed.
  • platform/qt/css3/filters/effect-contrast-expected.png: Removed.
  • platform/qt/css3/filters/effect-contrast-expected.txt: Removed.
  • platform/qt/css3/filters/effect-drop-shadow-expected.png: Removed.
  • platform/qt/css3/filters/effect-drop-shadow-expected.txt: Removed.
  • platform/qt/css3/filters/effect-grayscale-expected.png: Removed.
  • platform/qt/css3/filters/effect-grayscale-expected.txt: Removed.
  • platform/qt/css3/filters/effect-hue-rotate-expected.png: Removed.
  • platform/qt/css3/filters/effect-hue-rotate-expected.txt: Removed.
  • platform/qt/css3/filters/effect-invert-expected.png: Removed.
  • platform/qt/css3/filters/effect-invert-expected.txt: Removed.
  • platform/qt/css3/filters/effect-opacity-expected.png: Removed.
  • platform/qt/css3/filters/effect-opacity-expected.txt: Removed.
  • platform/qt/css3/filters/effect-saturate-expected.png: Removed.
  • platform/qt/css3/filters/effect-saturate-expected.txt: Removed.
  • platform/qt/css3/filters/effect-sepia-expected.png: Removed.
  • platform/qt/css3/filters/effect-sepia-expected.txt: Removed.
  • platform/qt/css3/filters/filter-animation-expected.png: Removed.
  • platform/qt/css3/filters/filter-animation-expected.txt: Removed.
  • platform/qt/css3/filters/filter-animation-from-none-expected.png: Removed.
  • platform/qt/css3/filters/filter-animation-from-none-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-computed-style-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-expected.png: Removed.
  • platform/qt/css3/filters/filter-property-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-parsing-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-parsing-invalid-expected.txt: Removed.
  • platform/qt/css3/filters/filter-region-expected.png: Removed.
  • platform/qt/css3/filters/filter-region-expected.txt: Removed.
  • platform/qt/css3/filters/filter-repaint-expected.png: Removed.
  • platform/qt/css3/filters/filter-repaint-expected.txt: Removed.
  • platform/qt/css3/filters/filter-with-transform-expected.png: Removed.
  • platform/qt/css3/filters/filter-with-transform-expected.txt: Removed.
  • platform/qt/css3/filters/filtered-inline-expected.png: Removed.
  • platform/qt/css3/filters/filtered-inline-expected.txt: Removed.
  • platform/qt/css3/filters/nested-filter-expected.png: Removed.
  • platform/qt/css3/filters/nested-filter-expected.txt: Removed.
  • platform/qt/css3/filters/nested-filters-expected.png: Removed.
  • platform/qt/css3/filters/nested-filters-expected.txt: Removed.
  • platform/qt/css3/filters/regions-expanding-expected.png: Removed.
  • platform/qt/css3/filters/regions-expanding-expected.txt: Removed.
  • platform/qt/css3/filters/remove-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/remove-filter-rendering-expected.txt: Removed.
  • platform/qt/css3/filters/simple-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/simple-filter-rendering-expected.txt: Removed.
11:22 AM Changeset in webkit [104404] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Don't create style selector in Element::recalcStyleIfNeededAfterAttributeChanged if it doesn't exist
​https://bugs.webkit.org/show_bug.cgi?id=75802

Rubber-stamped by Andreas Kling.

Element::recalcStyleIfNeededAfterAttributeChanged shouldn't create style selector for attribute
check if it doesn't already exist. We are going to need a full style recalc anyway in that case
and the constructed style selector may get throw out again.

  • dom/Element.cpp:

(WebCore::Element::recalcStyleIfNeededAfterAttributeChanged):

10:05 AM Changeset in webkit [104403] by noam.rosenthal@nokia.com
  • 8 edits
    55 adds in trunk

[Qt] Enable CSS_FILTERS in Qt build
​https://bugs.webkit.org/show_bug.cgi?id=75777

Source/WebCore:

Enable CSS_FILTERS and unskip the tests.

Reviewed by Kenneth Rohde Christiansen.

Filter tests are now unskipped for Qt.

  • Target.pri: add missing files to build.

Source/WebKit/qt:

For now, disallow compositing for filters. We will change that trigger when
​https://bugs.webkit.org/show_bug.cgi?id=75778 is implemented.

Reviewed by Kenneth Rohde Christiansen.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::allowedCompositingTriggers):

Tools:

Add the CSS_FILTERS feature flag to Qt.

Reviewed by Kenneth Rohde Christiansen.

  • qmake/mkspecs/features/features.prf:

LayoutTests:

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/Skipped: Unskip filter tests that work.
  • platform/qt/css3/filters/*: Added Qt specific results.
8:46 AM Changeset in webkit [104402] by haraken@chromium.org
  • 3 edits
    2 adds in trunk/Tools

Rewrite the CSS parser of prepare-ChangeLog with unittests.
​https://bugs.webkit.org/show_bug.cgi?id=75202

Reviewed by David Kilzer.

The current CSS parser can just parse simple CSSes like

foo bar baz {

property1: value;
property2: value;

}

, and cannot parse comments nor a CSS in which a selector and {
appears in different lines. This patch rewrites the CSS parser
(i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
shown in css_unittests.css.

Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css

  • Scripts/prepare-ChangeLog:

(get_selector_line_ranges_for_css):

  • Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.

(element1):
(element2):
(element3):
(element4.p):
(element5.p.q.r.s):
(element6#p):
(element7 element8):
(element9.p element10.q):
(element11#p element12#q):
(element13, element14):
(.p):
(#p):
(.p element15 #q element16.r element17#s):
(element18:target):
(element19):
(element20):
(element21):
(element22):

8:21 AM Changeset in webkit [104401] by haraken@chromium.org
  • 4 edits in trunk/Tools

The Perl parser of prepare-ChangeLog can parse here-documents
​https://bugs.webkit.org/show_bug.cgi?id=73208

Reviewed by David Kilzer.

Currently prepare-ChangeLog cannot recognize here-documents in Perl,
which results in wrong subroutine names in ChangeLogs.
With this patch, prepare-ChangeLog can judge whether the line of "}"
is the end of a subroutine or a line inside a here-document.

Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_perl):

  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:

Added test cases for here-documents.
(func7):
(func8):
(func9):
(func10):
(func11):
(func12):
(func13):
(func14):
(func15):
(func16):

8:15 AM Changeset in webkit [104400] by haraken@chromium.org
  • 3 edits
    2 adds in trunk/Tools

Add unittests for the JavaScript parser of prepare-ChangeLog
​https://bugs.webkit.org/show_bug.cgi?id=75201

Reviewed by David Kilzer.

javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
of prepare-ChangeLog.

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_javascript): Before this patch, a string found was just
omitted from parsing. Thus,

str = "foo"
function func() {
}

was recognized as equivalent to

str = function func() {
}

This patch replaces a string with a dummy identifier 'string_appeared_here'
to tell the parser that a string appeared there.

  • Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.

(func1):
(func2):
(func3):
(func4):
(func5):
(func6):
(func7):
(func8):
(func9):
(func10):
(func11):
(func12):
(funcOverloaded):
(Func1.prototype.get x1):
(Func1.prototype.get x2):
(Func1.prototype.set x1):
(Func1.prototype.set x3):
(Func2.prototype.func13):
(Func2.prototype.func14):
(Func2.prototype.func15):
(func16.func17):
(func16.func18):
(func16.func19):
(func16):

3:45 AM Changeset in webkit [104399] by Antti Koivisto
  • 5 edits
    2 adds in trunk

Source/WebCore: REGRESSION (r104060): Layout Test fast/media/viewport-media-query.html is occasionally failing
​https://bugs.webkit.org/show_bug.cgi?id=75633

Reviewed by Andreas Kling.

If something triggers CSSStyleSelector construction very early, before documentElement is known,
it won't be able to resolve viewport-related media queries. In the included test case
the attribute on <html> element triggers the style selector creation. I can't repro
the fast/media/viewport-media-query.html failure but I suspect it is the same issue with
a different mechanism for early CSSStyleSelector construction.

  • Reset style selector on documentElement change.
  • Remove the code for lazy documentElement initialization. It is not an useful optimization, the children of Document rarely change.

Test: fast/media/viewport-media-query-synchronous.html

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::childrenChanged):

  • dom/Document.h:

(WebCore::Document::documentElement):

LayoutTests: Layout Test fast/media/viewport-media-query.html is occasionally failing
​https://bugs.webkit.org/show_bug.cgi?id=75633

Reviewed by Andreas Kling.

  • fast/media/viewport-media-query-synchronous-expected.txt: Added.
  • fast/media/viewport-media-query-synchronous.html: Added.
12:06 AM Changeset in webkit [104398] by levin@chromium.org
  • 12 edits
    3 adds in trunk

[chromium] Add layout test support for autosize code in FrameView.
​https://bugs.webkit.org/show_bug.cgi?id=73631

Reviewed by Dmitry Titov.

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): Expose the new autoresize method.
(LayoutTestController::reset): Set the autoresize mode back to false.
(LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.

  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.

  • DumpRenderTree/chromium/WebViewHost.h:

LayoutTests:

  • fast/autoresize/basic-expected.txt: Added.
  • fast/autoresize/basic.html: Added. Simple test to verify that autoresizing happens.
  • platform/efl/Skipped: Skipped the new directory since the layout test controller on this platform, doesn't support enableAutoResizeMode.
  • platform/gtk/Skipped: Ditto.
  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
  • platform/wincairo/Skipped: Ditto.

Jan 7, 2012:

7:59 PM Changeset in webkit [104397] by kling@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Windows build fix.

  • DOMHTMLClasses.cpp:

(DOMHTMLDocument::forms):
(DOMHTMLSelectElement::options):

7:47 PM Changeset in webkit [104396] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to regenerate bindings on the Windows bot.

  • html/HTMLCollection.h:
7:41 PM Changeset in webkit [104395] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Memory allocator mismatch; Use operator new[] with OwnArrayPtr instead of fastMalloc()

Rubber-stamped by Adam Barth.

Currently getProgramInfoLog() in GraphicsContext3DOpenGL.cpp assumes that operator new[]
and fastMalloc() are equivalent when it adopts a fastMalloc() allocated buffer. Notice,
OwnArrayPtr ultimately calls delete[] on destruction. When GLOBAL_FASTMALLOC_NEW is disabled,
it isn't true that operator new[], operator delete[] are equivalent to fastMalloc(), fastFree(),
respectively. Hence, there may be a mismatch between the allocation and deallocation
routines. Therefore, we should allocate the array to be adopted by OwnArrayPtr using
operator new[].

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::getProgramInfoLog):

4:45 PM Changeset in webkit [104394] by dslomov@google.com
  • 11 edits
    2 moves
    4 adds
    4 deletes in trunk/LayoutTests

Unreviewed; chromium tests rebaselined after r104240.

  • platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open2-expected.png.
  • platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open4-expected.png.
  • platform/chromium-mac/fast/forms/input-text-double-click-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-text-drag-down-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-text-option-delete-expected.png: Removed.
  • platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png: Removed.
4:09 PM Changeset in webkit [104393] by dslomov@google.com
  • 4 edits
    2 adds
    2 deletes in trunk/LayoutTests

Unreviewed: updating expectations and rebaselining.
svg/custom/inline-svg-in-xhtml rebaselined due to ​http://trac.webkit.org/changeset/104240/.

  • platform/chromium-cg-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Added.
  • platform/chromium-cg-mac/svg/custom/inline-svg-in-xhtml-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Added.
  • platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
3:51 PM Changeset in webkit [104392] by dslomov@google.com
  • 2 edits
    5 adds in trunk/LayoutTests

Unreviewed: updating expectations and rebaslining.
svg/custom/pattern-userSpaceOnUse-userToBaseTransform rebaselined due to ​http://trac.webkit.org/changeset/104356/.

  • platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
  • platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
  • platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added.
  • platform/chromium/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
  • platform/chromium/test_expectations.txt:
2:39 PM Changeset in webkit [104391] by Philippe Normand
  • 6 edits
    1 add in trunk/LayoutTests

Unreviewed, GTK rebaseline after r104386 and r104208.

  • platform/gtk/Skipped: Skip failing accessibility/textbox-role-reports-line-number.html
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/table/032-expected.txt:
  • platform/gtk/fast/writing-mode/table-percent-width-quirk-expected.txt: Added.
  • platform/gtk/tables/mozilla/bugs/bug55694-expected.txt:
2:12 PM Changeset in webkit [104390] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: test expectations and filed WK75784.

  • platform/chromium/test_expectations.txt:
1:50 PM Changeset in webkit [104389] by dslomov@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed: disabled CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers
and filed ​https://bugs.webkit.org/show_bug.cgi?id=75783.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

10:43 AM Changeset in webkit [104388] by cmarrin@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

2012-01-07 Chris Marrin <​cmarrin@apple.com>

Fixed a warning in GTK build of ANGLE

Unreviewed.

  • src/compiler/DetectRecursion.cpp: (DetectRecursion::~DetectRecursion):
9:46 AM Changeset in webkit [104387] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WK2][GTK] Each test takes roughly half a second to load
​https://bugs.webkit.org/show_bug.cgi?id=70699

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2012-01-07
Reviewed by Martin Robinson.

Set the XDG_CACHE_HOME environment variable when testing with
WebKitTestRunner. This way the testing is started with a non-existing
application cache. If the cache exists and is not empty, the emptying
and vacuuming that is performed before every test can consume a lot of
time.

This is just a temporary workaround until it becomes possible to set
a desired directory to be used as the application cache location through
WebKitWebContext.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.setup_environ_for_server):

9:18 AM Changeset in webkit [104386] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] Enable requestAnimationFrame in build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=75773

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2012-01-07
Reviewed by Martin Robinson.

Tools:

Enable requestAnimationFrame for the Gtk port.

  • Scripts/build-webkit:

LayoutTests:

Skip the passing requestAnimationFrame-related tests and put
the remaining failing one under the tests that require modal
dialog implementation.

  • platform/gtk/Skipped:
7:22 AM Changeset in webkit [104385] by cmarrin@apple.com
  • 3 edits in trunk/Source/WebCore

2012-01-07 Chris Marrin <​cmarrin@apple.com>

Fixed ANGLE build for GNU and QT broken in ​https://trac.webkit.org/changeset/104363

Unreviewed.

  • GNUmakefile.list.am:
  • Target.pri:
2:08 AM Changeset in webkit [104384] by kling@webkit.org
  • 9 edits in trunk/Source/WebCore

Unreviewed C++ bindings build fix after r104383.

Use WTF::getPtr() to grab at impl pointer since they could be either RefPtr or raw.

  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation):

  • bindings/scripts/test/CPP/WebDOMTestCallback.cpp:

(WebDOMTestCallback::impl):

  • bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp:

(WebDOMTestEventConstructor::impl):

  • bindings/scripts/test/CPP/WebDOMTestInterface.cpp:

(WebDOMTestInterface::impl):

  • bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp:

(WebDOMTestMediaQueryListListener::impl):

  • bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp:

(WebDOMTestNamedConstructor::impl):

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::impl):

  • bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:

(WebDOMTestSerializedScriptValueInterface::impl):

1:35 AM Changeset in webkit [104383] by kling@webkit.org
  • 43 edits
    2 adds
    2 deletes in trunk

Simplify HTMLCollection ownership model.
<​http://webkit.org/b/75437>

Reviewed by Sam Weinig.

Source/WebCore:

Remove HTMLCollection's inheritance from RefCounted and use OwnPtr to store it.
Added ref()/deref() methods that forward to the collection's base node, these
are only ever used by DOM wrappers.

This is a behavior change, HTMLCollection wrappers now keep the base node alive.

Test: fast/dom/htmlcollection-protects-base.html

  • html/HTMLCollection.h:

(WebCore::HTMLCollection::ref):
(WebCore::HTMLCollection::deref):

Removed inheritance from RefCounted. Added ref/deref that forward the refs
to the collection's base Node.

  • dom/Element.cpp:

(WebCore::Element::~Element):

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::Document::~Document):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::~HTMLFormElement):

  • html/HTMLSelectElement.h:
  • html/HTMLSelectElement.cpp:

Remove HTMLCollection::detachFromNode() and call sites.

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::namedItemWithIndex):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::invalidateCacheIfNeeded):
(WebCore::HTMLCollection::itemAfter):
(WebCore::HTMLCollection::calcLength):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::nextItem):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
(WebCore::HTMLCollection::hasNamedItem):
(WebCore::HTMLCollection::namedItems):
(WebCore::HTMLCollection::tags):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::calcLength):
(WebCore::HTMLFormCollection::item):
(WebCore::HTMLFormCollection::getNamedItem):
(WebCore::HTMLFormCollection::namedItem):
(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):
(WebCore::HTMLOptionsCollection::remove):
(WebCore::HTMLOptionsCollection::selectedIndex):
(WebCore::HTMLOptionsCollection::setSelectedIndex):
(WebCore::HTMLOptionsCollection::setLength):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::length):
(WebCore::HTMLPropertiesCollection::item):
(WebCore::HTMLPropertiesCollection::names):

Removed base node null-checks and assertions. Added one assertion to
the HTMLCollection constructor (that m_base is non-null.)

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::Document::openSearchDescriptionURL):
(WebCore::Document::cachedCollection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):
(WebCore::JSHTMLDocument::all):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::GetNamedProperty):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::ensureCachedHTMLCollection):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::properties):

  • html/HTMLAllCollection.h:
  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::create):

  • html/HTMLCollection.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::HTMLCollection):

  • html/HTMLDataListElement.cpp:

(WebCore::HTMLDataListElement::options):

  • html/HTMLDataListElement.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::children):

  • html/HTMLElement.h:
  • html/HTMLSelectElement.h:

(WebCore::HTMLSelectElement::options):

  • html/HTMLFormCollection.h:
  • html/HTMLFormElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::elements):

  • html/HTMLNameCollection.h:

(WebCore::HTMLNameCollection::create):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::create):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::areas):

  • html/HTMLMapElement.h:
  • html/HTMLPropertiesCollection.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::rows):
(WebCore::HTMLTableElement::tBodies):

  • html/HTMLTableElement.h:
  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::insertCell):
(WebCore::HTMLTableRowElement::deleteCell):
(WebCore::HTMLTableRowElement::cells):

  • html/HTMLTableRowElement.h:
  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::create):
(WebCore::HTMLTableRowsCollection::itemAfter):

  • html/HTMLTableRowsCollection.h:
  • html/HTMLTableSectionElement.h:
  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::insertRow):
(WebCore::HTMLTableSectionElement::deleteRow):
(WebCore::HTMLTableSectionElement::rows):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::selectedOption):

  • html/HTMLOptionsCollection.h:
  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::create):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::create):

  • Source/WebCore/accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::getDocumentLinks):

Store cached HTMLCollections in OwnPtrs. Methods that used to return
PassRefPtr<HTMLCollection> now simply return HTMLCollection*.
Updated call sites as appropriate.

LayoutTests:

  • Removed fast/dom/htmlcollection-zombies.html since it was testing bogus behavior.
  • Added a test to verify that HTMLCollection protects its base node from GC.
  • fast/dom/htmlcollection-protects-base-expected.txt: Added.
  • fast/dom/htmlcollection-protects-base.html: Added.
  • fast/dom/htmlcollection-zombies-expected.txt: Removed.
  • fast/dom/htmlcollection-zombies.html: Removed.
1:14 AM Changeset in webkit [104382] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to fix Qt build.

  • page/Geolocation.cpp:

(WebCore::Geolocation::Geolocation):

1:12 AM Changeset in webkit [104381] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

REGRESSION(r104210): Crash inside DynamicSubtreeNodeList::length
​https://bugs.webkit.org/show_bug.cgi?id=75731

Reviewed by Andreas Kling.

Source/WebCore:

The crash was caused by DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent
using m_cachedItem as a way to access the document. Changed SubtreeCaches to use
DynamicSubtreeNodeList's m_node instead.

Test: fast/dom/node-list-length-after-removing-node.html

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setItemCache):
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::item):

  • dom/DynamicNodeList.h:

(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isLengthCacheValid):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isItemCacheValid):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedItem):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent):

LayoutTests:

Add a regression test. It reproduces the crash with a very high probability.

  • fast/dom/node-list-length-after-removing-node-expected.txt: Added.
  • fast/dom/node-list-length-after-removing-node.html: Added.
12:46 AM Changeset in webkit [104380] by abarth@webkit.org
  • 41 edits
    2 copies in trunk/Source/WebCore

Disconnecting DOMWindow properties is fragile and overly complicated
​https://bugs.webkit.org/show_bug.cgi?id=75699

Reviewed by Alexey Proskuryakov.

Previously, we had to carefully check every object tree hanging off of
DOMWindow to make sure that every property correctly disconnected
itself and all its subobjects from the Frame when the DOMWindow
disconnected from the Frame.

This patch introduces DOMWindowProperty, which is a base class that
handles this work automagically, ensuring that we won't have any
dangling Frame pointers and removing a bunch of boilerplate code.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • css/StyleMedia.cpp:

(WebCore::StyleMedia::StyleMedia):

  • css/StyleMedia.h:

(WebCore::StyleMedia::create):

  • loader/appcache/DOMApplicationCache.cpp:

(WebCore::DOMApplicationCache::DOMApplicationCache):
(WebCore::DOMApplicationCache::disconnectFrame):

  • loader/appcache/DOMApplicationCache.h:
  • page/BarInfo.cpp:

(WebCore::BarInfo::BarInfo):

  • page/BarInfo.h:
  • page/Console.cpp:

(WebCore::Console::Console):
(WebCore::Console::memory):

  • page/Console.h:
  • page/DOMSelection.cpp:

(WebCore::DOMSelection::DOMSelection):

  • page/DOMSelection.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::registerProperty):
(WebCore::DOMWindow::unregisterProperty):
(WebCore::DOMWindow::clear):

  • page/DOMWindow.h:
  • page/Geolocation.cpp:

(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::disconnectFrame):

  • page/Geolocation.h:
  • page/History.cpp:

(WebCore::History::History):

  • page/History.h:
  • page/Location.cpp:

(WebCore::Location::Location):

  • page/Location.h:
  • page/Navigator.cpp:

(WebCore::Navigator::Navigator):
(WebCore::Navigator::~Navigator):

  • page/Navigator.h:
  • page/Performance.cpp:

(WebCore::Performance::Performance):
(WebCore::Performance::memory):

  • page/Performance.h:
  • page/PerformanceNavigation.cpp:

(WebCore::PerformanceNavigation::PerformanceNavigation):

  • page/PerformanceNavigation.h:
  • page/PerformanceTiming.cpp:

(WebCore::PerformanceTiming::PerformanceTiming):

  • page/PerformanceTiming.h:
  • page/Screen.cpp:

(WebCore::Screen::Screen):

  • page/Screen.h:
  • plugins/DOMMimeTypeArray.cpp:

(WebCore::DOMMimeTypeArray::DOMMimeTypeArray):

  • plugins/DOMMimeTypeArray.h:
  • plugins/DOMPluginArray.cpp:

(WebCore::DOMPluginArray::DOMPluginArray):

  • plugins/DOMPluginArray.h:
  • storage/Storage.cpp:

(WebCore::Storage::Storage):

  • storage/Storage.h:
Note: See TracTimeline for information about the timeline view.