Timeline



Jan 9, 2012:

11:04 PM EFLWebKit edited by sh4.seo@samsung.com
(diff)
9:42 PM Changeset in webkit [104538] by commit-queue@webkit.org
  • 8 edits
    4 deletes in trunk/Source

Unreviewed, rolling out r104507.
http://trac.webkit.org/changeset/104507
https://bugs.webkit.org/show_bug.cgi?id=75936

Broke webkit_unit_tests (Requested by dimich on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-09

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/cc/CCLayerIterator.cpp: Removed.
  • platform/graphics/chromium/cc/CCLayerIterator.h: Removed.
  • platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Removed.
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::walkLayersAndCalculateVisibleLayerRects):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerIteratorTest.cpp: Removed.
9:39 PM Changeset in webkit [104537] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Touch WebView.h in an attempt to clobber Chromium bots on build.webkit.org.

  • public/WebView.h:
8:44 PM Changeset in webkit [104536] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed rebaseline, fixing incorrect rebaseline from r104489.

  • platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png:
8:12 PM Changeset in webkit [104535] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed update for test_expectations.txt.

  • platform/chromium/test_expectations.txt:
8:10 PM Changeset in webkit [104534] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from 116459 to 116979.

  • DEPS:
7:00 PM Changeset in webkit [104533] by dimich@chromium.org
  • 216 edits
    3 copies
    11 moves
    3 adds
    9 deletes in trunk/LayoutTests

[Chromium] Rebaseline a lot of tests with input controls after r104494
https://bugs.webkit.org/show_bug.cgi?id=75924

Unreviewed.

  • platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-leopard/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-leopard/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-leopard/editing/selection/4975120-expected.png:
  • platform/chromium-mac-leopard/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-leopard/fast/css/line-height-expected.png:
  • platform/chromium-mac-leopard/fast/dom/isindex-001-expected.png:
  • platform/chromium-mac-leopard/fast/dom/isindex-002-expected.png:
  • platform/chromium-mac-leopard/fast/events/autoscroll-expected.png:
  • platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.png:
  • platform/chromium-mac-leopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac-leopard/fast/forms/encoding-test-expected.png:
  • platform/chromium-mac-leopard/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac-leopard/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-align-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-baseline-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-spaces-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-table-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-mac-leopard/fast/forms/minWidthPercent-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-leopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac-leopard/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-leopard/fast/table/003-expected.png:
  • platform/chromium-mac-leopard/fast/table/text-field-baseline-expected.png:
  • platform/chromium-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/45621-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug55545-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4975120-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/032-expected.png: Renamed from LayoutTests/platform/chromium/fast/block/float/032-expected.png.
  • platform/chromium-mac-snowleopard/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/isindex-001-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/isindex-002-expected.png:
  • platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.png:
  • platform/chromium-mac-snowleopard/fast/events/context-no-deselect-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/basic-inputs-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/input-appearance-disabled-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/input-appearance-height-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-table-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-width-expected.png: Copied from LayoutTests/platform/chromium/fast/forms/input-width-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/minWidthPercent-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/tables/mozilla/bugs/bug55545-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/placeholder-pseudo-style-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/validation-message-appearance-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.txt: Renamed from LayoutTests/platform/chromium/fast/speech/input-appearance-numberandspeech-expected.txt.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.txt: Renamed from LayoutTests/platform/chromium/fast/speech/input-appearance-speechbutton-expected.txt.
  • platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/003-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-expected.png: Renamed from LayoutTests/platform/chromium/fast/table/colspanMinWidth-expected.png.
  • platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-vertical-expected.png: Renamed from LayoutTests/platform/chromium/fast/forms/input-width-expected.png.
  • platform/chromium-mac-snowleopard/fast/table/spanOverlapRepaint-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-snowleopard/plugins/mouse-click-plugin-clears-selection-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png.
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/45621-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png: Removed.
  • platform/chromium-win-vista/tables/mozilla/bugs/bug4527-expected.png: Removed.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug4527-expected.png: Removed.
  • platform/chromium/fast/forms/minWidthPercent-expected.png: Removed.
  • platform/chromium/fast/replaced/width100percent-textfield-expected.png: Removed.
  • platform/chromium/fast/table/colspanMinWidth-vertical-expected.png: Removed.
  • platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.png: Removed.
  • platform/chromium/tables/mozilla/bugs/bug24200-expected.png: Removed.
6:40 PM Changeset in webkit [104532] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

2012-01-09 Rob Buis <rbuis@rim.com>

Upstream change to disable input[color] css rules for BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=75719

Reviewed by Antonio Gomes.

Do not enable default css color rules for inputcolor for BlackBerry port.

  • CMakeLists.txt:
6:29 PM Changeset in webkit [104531] by commit-queue@webkit.org
  • 7 edits
    7 adds in trunk

Source/WebCore: Implement navigator.startActivity; add IntentRequest object for managing web intents callbacks.
Web content will invoke navigator.startActivity to launch a new Web
Intents call. Each such call will map to an IntentRequest broker
object which is used by client code to correlate any return data to
the (optional) callbacks supplied by web content calls.
https://bugs.webkit.org/show_bug.cgi?id=75756

Patch by Greg Billock <gbillock@google.com> on 2012-01-09
Reviewed by Adam Barth.

Test: webintents/web-intents-api.html

  • Modules/intents/Intent.cpp: Added.

(WebCore::Intent::identifier):
(WebCore::Intent::setIdentifier):

  • Modules/intents/Intent.h: Added.
  • Modules/intents/Intent.idl: Added.
  • Modules/intents/IntentResultCallback.h: Added.

(WebCore::IntentResultCallback::~IntentResultCallback):

  • Modules/intents/IntentResultCallback.idl: Added.
  • Modules/intents/IntentsRequest.cpp: Added.
  • Modules/intents/IntentsRequest.h: Added.
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:

(GetNativeTypeForCallbacks):

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::dispatchIntent):

LayoutTests: Implement navigator.startActivity; add IntentsController for managing web intents callbacks.
https://bugs.webkit.org/show_bug.cgi?id=75756

Patch by Greg Billock <gbillock@google.com> on 2012-01-09
Reviewed by Adam Barth.

  • webintents/web-intents-api-expected.txt: Added.
  • webintents/web-intents-api.html: Added.
6:14 PM Changeset in webkit [104530] by mitz@apple.com
  • 4 edits in trunk

-[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
https://bugs.webkit.org/show_bug.cgi?id=75920

Reviewed by Darin Adler.

Source/WebCore:

Test: added to TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm

  • page/mac/FrameMac.mm:

(WebCore::Frame::rangeImage): Removed the requirement that the start and end positions used
for setting the selection in the render tree be candidates.

Tools:

  • TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:

(TestWebKitAPI::TEST): Added a test for a range in a
-webkit-user-select: none; block.

6:12 PM Changeset in webkit [104529] by eae@chromium.org
  • 2 edits in branches/subpixellayout/Source

Get chromium/linux building again.

6:11 PM Changeset in webkit [104528] by morrita@google.com
  • 15 edits
    2 adds in trunk/Source/WebCore

[Refactoring] Moving between TreeScopes should be done by its own class.
https://bugs.webkit.org/show_bug.cgi?id=75290

Reviewed by Ryosuke Niwa.

This change extracted Node::setTreeScopeRecursively(),
setDocumentRecursively() and a part of setDocument() into a new
class called TreeScopeAdopter. By doing this, the idea of
moving a node from scope to scope, that was originally hidden
behind the forest of Node APIs, has become clearer.

Note that this change is a preparation for Bug 59816.

No new tests. No behavioral change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp: Followed the renaming.

(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):

  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp: Followed te renaming.

(WebCore::Document::setDocType):
(WebCore::Document::adoptNode):

  • dom/Element.cpp: Followed te renaming.

(WebCore::Element::removeShadowRoot):

  • dom/Node.cpp:

(WebCore::Node::setDocument):
(WebCore::Node::setTreeScope):
(WebCore::Node::didMoveToNewDocument):

  • dom/Node.h:
  • dom/TreeScope.h:
  • dom/TreeScope.cpp:

(WebCore::TreeScope::adoptIfNeeded): moved from setTreeScopeRecursively()

  • dom/TreeScopeAdopter.cpp: Added.

(WebCore::TreeScopeAdopter::TreeScopeAdopter):
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):
(WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):

  • dom/TreeScopeAdopter.h: Added.

(WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled):
(WebCore::TreeScopeAdopter::execute):
(WebCore::TreeScopeAdopter::needsScopeChange()):
(WebCore::TreeScopeAdopter::shadowRootFor):

6:03 PM Changeset in webkit [104527] by barraclough@apple.com
  • 5 edits in trunk

Error handling : in ISO8601 timezone
https://bugs.webkit.org/show_bug.cgi?id=75919

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • wtf/DateMath.cpp:

(WTF::parseDateFromNullTerminatedCharacters):

  • need to increment the string position.

LayoutTests:

  • fast/js/date-parse-test-expected.txt:
  • fast/js/script-tests/date-parse-test.js:
    • added test cases.
5:56 PM Changeset in webkit [104526] by abarth@webkit.org
  • 18 edits
    9 copies
    30 adds in trunk/Source/WebCore

run-bindings-tests should exercise all the IDL attributes we use
https://bugs.webkit.org/show_bug.cgi?id=75900

Reviewed by Eric Seidel.

I just grepped through the code generator script for IDL attributes and
wrote tests for them.

  • bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.cpp: Added.
  • bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.h: Added.
  • bindings/scripts/test/CPP/WebDOMTestEventTarget.cpp: Added.
  • bindings/scripts/test/CPP/WebDOMTestEventTarget.h: Added.
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/CPP/WebDOMTestOverridingNameGetter.cpp: Added.
  • bindings/scripts/test/CPP/WebDOMTestOverridingNameGetter.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestEventTargetPrivate.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.cpp: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetterPrivate.h: Added.
  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Added.
  • bindings/scripts/test/JS/JSTestActiveDOMObject.h: Added.
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:
  • bindings/scripts/test/JS/JSTestEventTarget.cpp: Added.
  • bindings/scripts/test/JS/JSTestEventTarget.h: Added.
  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestOverridingNameGetter.cpp: Added.
  • bindings/scripts/test/JS/JSTestOverridingNameGetter.h: Added.
  • bindings/scripts/test/ObjC/DOMTestActiveDOMObjectInternal.h: Added.
  • bindings/scripts/test/ObjC/DOMTestEventTarget.h: Added.
  • bindings/scripts/test/ObjC/DOMTestEventTarget.mm: Added.
  • bindings/scripts/test/ObjC/DOMTestEventTargetInternal.h: Added.
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/ObjC/DOMTestOverridingNameGetter.h: Added.
  • bindings/scripts/test/ObjC/DOMTestOverridingNameGetter.mm: Added.
  • bindings/scripts/test/ObjC/DOMTestOverridingNameGetterInternal.h: Added.
  • bindings/scripts/test/TestDomainSecurity.idl: Added.
  • bindings/scripts/test/TestEventConstructor.idl:
  • bindings/scripts/test/TestEventTarget.idl: Added.
  • bindings/scripts/test/TestInterface.idl:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestOverridingNameGetter.idl: Added.
  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp: Added.
  • bindings/scripts/test/V8/V8TestActiveDOMObject.h: Added.
  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:
  • bindings/scripts/test/V8/V8TestEventTarget.cpp: Added.
  • bindings/scripts/test/V8/V8TestEventTarget.h: Added.
  • bindings/scripts/test/V8/V8TestInterface.h:
  • bindings/scripts/test/V8/V8TestObj.cpp:
  • bindings/scripts/test/V8/V8TestOverridingNameGetter.cpp: Added.
  • bindings/scripts/test/V8/V8TestOverridingNameGetter.h: Added.
5:54 PM Changeset in webkit [104525] by mikelawther@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

background position parsing test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75823

Reviewed by Daniel Bates.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/background-position-parsing-expected-mismatch.html: Added.
  • css3/calc/background-position-parsing.html: Added.
  • css3/calc/resources/diamond.png: Added.
  • css3/calc/resources/ring.png: Added.
5:32 PM Changeset in webkit [104524] by dpranke@chromium.org
  • 6 edits in trunk/Tools

webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
https://bugs.webkit.org/show_bug.cgi?id=75884

Reviewed by Ryosuke Niwa.

Fix regression introduced (revealed?) in r104340. Chromium file
url syntax is different on win32 and the test results weren't
expecting that.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations._report_errors):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_parse_error_nonfatal):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTTest.input_line):
(MockChromiumDRTTest.test_pixeltestfails):

  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:

(TestRebaseliner.make_rebaseliner):
(TestRebaseliner.test_one_platform):
(TestRebaseliner.test_all_platforms):
(TestRebaseliner.test_png_file_with_comment):
(TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
(TestRebaseliner.test_png_file_with_comment_as_duplicate):
(TestRealMain.test_all_platforms):

5:24 PM Changeset in webkit [104523] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

http/tests/inspector-enabled/dedicated-workers-list.html flakey on linux
https://bugs.webkit.org/show_bug.cgi?id=75186

Reviewed by Adam Barth.

  • platform/chromium/test_expectations.txt:
5:21 PM Changeset in webkit [104522] by nduca@chromium.org
  • 6 edits in trunk/Source/WebCore

[chromium] Add documentation to updater classes
https://bugs.webkit.org/show_bug.cgi?id=75866

Reviewed by James Robinson.

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/CanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:
5:14 PM Changeset in webkit [104521] by jonlee@apple.com
  • 5 edits
    1 copy
    3 adds in trunk/LayoutTests

New pixel test results with r104351.

Unreviewed.

Moved from mac to mac-snowleopard:

  • platform/mac-snowleopard/fast/block/margin-collapse/103

New pixel test results:

  • platform/mac/fast/block/margin-collapse/103-expected.png:
  • platform/mac/fast/table/003-expected.png:
  • platform/mac/tables/mozilla/bugs/bug194024-expected.png:
  • platform/mac/tables/mozilla/bugs/bug30692-expected.png:
5:12 PM Changeset in webkit [104520] by mikelawther@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

img size test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75893

Reviewed by Daniel Bates.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/img-size-expected-mismatch.html: Added.
  • css3/calc/img-size.html: Added.
  • css3/calc/resources/colorsquare.png: Added.
5:08 PM Changeset in webkit [104519] by mrowe@apple.com
  • 2 edits in tags/Safari-535.15.1/Source/JavaScriptCore

Merge r104510.

5:07 PM Changeset in webkit [104518] by mrowe@apple.com
  • 5 edits in tags/Safari-535.15.1/Source

Versioning.

5:07 PM Changeset in webkit [104517] by Lucas Forschler
  • 2 edits
    3 copies in branches/safari-534.54-branch

Merged r102509.

5:05 PM Changeset in webkit [104516] by mrowe@apple.com
  • 1 copy in tags/Safari-535.15.1

New tag.

5:02 PM Changeset in webkit [104515] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r102377.

5:00 PM Changeset in webkit [104514] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r102263.

4:55 PM Changeset in webkit [104513] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r102016.

4:50 PM Changeset in webkit [104512] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r101584.

4:42 PM Changeset in webkit [104511] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unused variable from CodeGeneratorV8
https://bugs.webkit.org/show_bug.cgi?id=75895

Reviewed by Eric Seidel.

Unused variables aren't worth keeping around.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateImplementation):

4:41 PM Changeset in webkit [104510] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JavaScriptCore executable targets shouldn't explicitly depend on the JavaScriptCore framework target <http://webkit.org/b/75907> / <rdar://problem/10659862>

We'd like for it to be possible to build jsc without building JavaScriptCore.framework and the explicit
dependencies prevent this.

Reviewed by Dan Bernstein.

4:39 PM Changeset in webkit [104509] by jonlee@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Temporary fix for pixel result diffs from focus ring (darker color on WK2).
These results should be removed once the cause is found-- filed as bug:
https://bugs.webkit.org/show_bug.cgi?id=75909

Unreviewed.

  • platform/mac-wk2/fast/forms/plaintext-mode-2-expected.png: Added.
  • platform/mac-wk2/fast/forms/plaintext-mode-2-expected.txt: Added.
4:33 PM Changeset in webkit [104508] by jonlee@apple.com
  • 72 edits
    21 copies
    21 adds in trunk/LayoutTests

Some gardening with fix for r104351.

Moving pixel test results from mac to mac-snowleopard (because of theme changes):

  • platform/mac-snowleopard/fast/forms/HTMLOptionElement_label01
  • platform/mac-snowleopard/fast/forms/button-cannot-be-nested
  • platform/mac-snowleopard/fast/forms/button-inner-block-reuse
  • platform/mac-snowleopard/fast/forms/control-clip-overflow
  • platform/mac-snowleopard/fast/forms/file/input-file-re-render
  • platform/mac-snowleopard/fast/forms/formmove
  • platform/mac-snowleopard/fast/forms/input-text-scroll-left-on-blur
  • platform/mac-snowleopard/fast/forms/listbox-hit-test-zoomed
  • platform/mac-snowleopard/fast/forms/listbox-scrollbar-incremental-load
  • platform/mac-snowleopard/fast/forms/menulist-width-change
  • platform/mac-snowleopard/fast/forms/option-text-clip
  • platform/mac-snowleopard/fast/forms/plaintext-mode-2
  • platform/mac-snowleopard/fast/forms/range/slider-thumb-shared-style
  • platform/mac-snowleopard/fast/forms/search-vertical-alignment
  • platform/mac-snowleopard/fast/forms/select-change-listbox-to-popup
  • platform/mac-snowleopard/fast/forms/select-item-background-clip
  • platform/mac-snowleopard/fast/forms/select-selected
  • platform/mac-snowleopard/fast/forms/select-size
  • platform/mac-snowleopard/fast/forms/select-visual-hebrew
  • platform/mac-snowleopard/fast/forms/textarea-scrollbar
  • platform/mac-snowleopard/fast/forms/textarea-scrolled

New pixel test results:

  • platform/mac/fast/forms/001-expected.png:
  • platform/mac/fast/forms/006-expected.png:
  • platform/mac/fast/forms/HTMLOptionElement_label01-expected.png:
  • platform/mac/fast/forms/basic-buttons-expected.png:
  • platform/mac/fast/forms/basic-inputs-expected.png:
  • platform/mac/fast/forms/basic-selects-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.png:
  • platform/mac/fast/forms/box-shadow-override-expected.png:
  • platform/mac/fast/forms/button-align-expected.png:
  • platform/mac/fast/forms/button-cannot-be-nested-expected.png:
  • platform/mac/fast/forms/button-default-title-expected.png:
  • platform/mac/fast/forms/button-generated-content-expected.png:
  • platform/mac/fast/forms/button-inner-block-reuse-expected.png:
  • platform/mac/fast/forms/button-sizes-expected.png:
  • platform/mac/fast/forms/button-style-color-expected.png:
  • platform/mac/fast/forms/button-table-styles-expected.png:
  • platform/mac/fast/forms/button-text-transform-expected.png:
  • platform/mac/fast/forms/button-white-space-expected.png:
  • platform/mac/fast/forms/control-clip-overflow-expected.png:
  • platform/mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/mac/fast/forms/disabled-select-change-index-expected.png:
  • platform/mac/fast/forms/fieldset-align-expected.png:
  • platform/mac/fast/forms/file/file-input-direction-expected.png:
  • platform/mac/fast/forms/file/input-file-re-render-expected.png:
  • platform/mac/fast/forms/floating-textfield-relayout-expected.png:
  • platform/mac/fast/forms/form-element-geometry-expected.png:
  • platform/mac/fast/forms/form-hides-table-expected.png:
  • platform/mac/fast/forms/formmove-expected.png:
  • platform/mac/fast/forms/input-align-expected.png:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/mac/fast/forms/input-appearance-height-expected.png:
  • platform/mac/fast/forms/input-appearance-width-expected.png:
  • platform/mac/fast/forms/input-baseline-expected.png:
  • platform/mac/fast/forms/input-button-sizes-expected.png:
  • platform/mac/fast/forms/input-table-expected.png:
  • platform/mac/fast/forms/input-text-click-outside-expected.png:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/mac/fast/forms/input-value-expected.png:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
  • platform/mac/fast/forms/listbox-bidi-align-expected.png:
  • platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:
  • platform/mac/fast/forms/listbox-scrollbar-incremental-load-expected.png:
  • platform/mac/fast/forms/menulist-width-change-expected.png:
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/mac/fast/forms/option-strip-whitespace-expected.png:
  • platform/mac/fast/forms/option-text-clip-expected.png:
  • platform/mac/fast/forms/placeholder-position-expected.png:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/mac/fast/forms/plaintext-mode-2-expected.png:
  • platform/mac/fast/forms/radio_checked_dynamic-expected.png:
  • platform/mac/fast/forms/range/input-appearance-range-expected.png:
  • platform/mac/fast/forms/range/slider-padding-expected.png:
  • platform/mac/fast/forms/range/slider-thumb-shared-style-expected.png:
  • platform/mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/mac/fast/forms/select-align-expected.png:
  • platform/mac/fast/forms/select-change-listbox-size-expected.png:
  • platform/mac/fast/forms/select-change-listbox-to-popup-expected.png:
  • platform/mac/fast/forms/select-initial-position-expected.png:
  • platform/mac/fast/forms/select-item-background-clip-expected.png:
  • platform/mac/fast/forms/select-selected-expected.png:
  • platform/mac/fast/forms/select-size-expected.png:
  • platform/mac/fast/forms/select-style-expected.png:
  • platform/mac/fast/forms/select-visual-hebrew-expected.png:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.png:
  • platform/mac/fast/forms/textAreaLineHeight-expected.png:
  • platform/mac/fast/forms/textarea-align-expected.png:
  • platform/mac/fast/forms/textarea-scrollbar-expected.png:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.png:
  • platform/mac/fast/forms/textarea-width-expected.png:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
4:31 PM Changeset in webkit [104507] by commit-queue@webkit.org
  • 8 edits
    4 adds in trunk/Source

[chromium] Create iterators for the RenderSurface-Layer tree
https://bugs.webkit.org/show_bug.cgi?id=74203

Patch by Dana Jansens <danakj@chromium.org> on 2012-01-09
Reviewed by James Robinson.

Source/WebCore:

New unit tests: CCLayerIteratorTest.cpp

  • WebCore.gypi:
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/cc/CCLayerIterator.cpp: Added.

(WebCore::CCLayerIteratorActions::BackToFront::begin):
(WebCore::CCLayerIteratorActions::BackToFront::end):
(WebCore::CCLayerIteratorActions::BackToFront::next):
(WebCore::CCLayerIteratorActions::FrontToBack::begin):
(WebCore::CCLayerIteratorActions::FrontToBack::end):
(WebCore::CCLayerIteratorActions::FrontToBack::next):
(WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):

  • platform/graphics/chromium/cc/CCLayerIterator.h: Added.

(WebCore::CCLayerIterator::CCLayerIterator):
(WebCore::CCLayerIterator::begin):
(WebCore::CCLayerIterator::end):
(WebCore::CCLayerIterator::operator++):
(WebCore::CCLayerIterator::operator==):
(WebCore::CCLayerIterator::operator!=):
(WebCore::CCLayerIterator::operator->):
(WebCore::CCLayerIterator::operator*):
(WebCore::CCLayerIterator::representsTargetRenderSurface):
(WebCore::CCLayerIterator::representsContributingRenderSurface):
(WebCore::CCLayerIterator::representsItself):
(WebCore::CCLayerIterator::targetRenderSurfaceLayer):

  • platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Added.

(WebCore::CCLayerIteratorPosition::CCLayerIteratorPosition):
(WebCore::CCLayerIteratorPosition::currentLayer):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsContributingRenderSurface):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsTargetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceLayer):
(WebCore::CCLayerIteratorPosition::targetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceChildren):
(WebCore::CCLayerIteratorPosition::operator==):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::walkLayersAndCalculateVisibleLayerRects):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerIteratorTest.cpp: Added.
4:13 PM Changeset in webkit [104506] by commit-queue@webkit.org
  • 5 edits in trunk

IndexedDB: Throw exception if IDBCursor.continue() called with lower key than current
https://bugs.webkit.org/show_bug.cgi?id=74213

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-09
Reviewed by Tony Chang.

Source/WebCore:

  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::continueFunction):

LayoutTests:

  • storage/indexeddb/cursor-continue-expected.txt:
  • storage/indexeddb/cursor-continue.html:
4:12 PM Changeset in webkit [104505] by wjmaclean@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] REGRESSION(r104368): Broke CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers
https://bugs.webkit.org/show_bug.cgi?id=75783

Updated unit test to reflect desired behaviour now that tile/quad culling
is implemented.

Reviewed by James Robinson.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

4:03 PM Changeset in webkit [104504] by ojan@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Tests for nested flexboxes
https://bugs.webkit.org/show_bug.cgi?id=70776

Reviewed by Tony Chang.

  • css3/flexbox/orthogonal-flex-directions-expected.txt: Added.
  • css3/flexbox/orthogonal-flex-directions.html: Added.
4:01 PM Changeset in webkit [104503] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Windows Build Fix

3:56 PM Changeset in webkit [104502] by crogers@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Fix potential issue in WebMediaPlayerClientImpl
https://bugs.webkit.org/show_bug.cgi?id=75899

Reviewed by Kenneth Russell.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::load):
(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::wrap):

3:53 PM Changeset in webkit [104501] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[chromium win] Creating lots of temporary canvas contexts will crash.
https://bugs.webkit.org/show_bug.cgi?id=68420

When using the skia port, the allocation of 2d canvas backing stores
no longer needs to be done through a platform API (GDI/CG) because
canvases now use skia for drawing text. Removing the allocation through
GDI on windows prevents resource exhaustion due to unreferenced canvases
that are awaiting garbage collection.

Patch by Justin Novosad <junov@chromium.org> on 2012-01-09
Reviewed by Stephen White.

No new tests: Relying on existing canvas layout tests.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer):

  • platform/graphics/ImageBuffer.h:
  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createNonPlatformCanvas):
(WebCore::ImageBuffer::ImageBuffer):

3:43 PM Changeset in webkit [104500] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r101091.

3:32 PM Changeset in webkit [104499] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merge 100809.

3:23 PM Changeset in webkit [104498] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r100677.

3:16 PM Changeset in webkit [104497] by Lucas Forschler
  • 9 edits
    5 copies in branches/safari-534.54-branch

Merged r100630.

3:14 PM Changeset in webkit [104496] by leviw@chromium.org
  • 37 edits in branches/subpixellayout/LayoutTests/platform

Updated svg expectations

3:14 PM Changeset in webkit [104495] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.

Unreviewed, build fix.

test-webkitpy had a built-in self-test routine to verify that
deleting the .pyc files worked correctly. When I removed the
python24 directory in r104482, I broke the self-test.

I have deleted the self-test for now. Since I am reworking
test-webkitpy I will make sure the new version is adequately
tested.

  • Scripts/test-webkitpy:

(configure_logging):
(_clean_pyc_files):
(_clean_packages):
(init):

3:13 PM Changeset in webkit [104494] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=75860
[Chromium Mac] no background is drawn for input elements

Patch by Avi Drissman <avi@chromium.org> on 2012-01-09
Reviewed by Dimitri Glazkov.

Reverts r104240 for Chromium. Unfortunately the code that uses Cocoa
API misbehaves when built with the 10.5 SDK, so we use SPI. For now.

  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::paintTextField):

3:05 PM Changeset in webkit [104493] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGText.cpp

Fix rounding problem in RenderSVGText::nodeAtFloatPoint

2:43 PM Changeset in webkit [104492] by barraclough@apple.com
  • 3 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=75692
Roll out possibly bad new test case.

Rubber stamped by Sam Weinig.

  • fast/js/date-constructor-expected.txt:
  • fast/js/script-tests/date-constructor.js:
2:06 PM Changeset in webkit [104491] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Log is a little to verbose for blackberry port
https://bugs.webkit.org/show_bug.cgi?id=75728

The BlackBerry::Platform::Log* functions take care of the call to vfprintf
which is resulting in unintentional noise in our logs. Add a conditional
directive to fix.

Change to using BlackBerry::Platform::logStreamV which does not insert
threading info and newlines unlike BlackBerry::Platform::log.

Finally, add log locking and unlocking which the BlackBerry platform
uses to ensure that N threads do not trample on each other's logs.

Patch by Adam Treat <atreat@rim.com> on 2012-01-09
Reviewed by Rob Buis.

  • wtf/Assertions.cpp:

(WTFLogLocker::WTFReportAssertionFailure):
(WTFLogLocker::WTFReportAssertionFailureWithMessage):
(WTFLogLocker::WTFReportArgumentAssertionFailure):
(WTFLogLocker::WTFReportFatalError):
(WTFLogLocker::WTFReportError):
(WTFLogLocker::WTFLog):
(WTFLogLocker::WTFLogVerbose):

2:02 PM Changeset in webkit [104490] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Compilation error on build-webkit --debug --no-3d-canvas on mac.
https://bugs.webkit.org/show_bug.cgi?id=75878

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-09
Reviewed by Alexey Proskuryakov.

  • html/canvas/WebGLContextEvent.cpp:
2:00 PM Changeset in webkit [104489] by dimich@chromium.org
  • 1 edit
    1 move
    1 add
    4 deletes in trunk/LayoutTests

[Chromium] Rebaseline media/media-document-audio-repaint.html for gpu tests.
https://bugs.webkit.org/show_bug.cgi?id=75888

Unreviewed.

  • platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-gpu-mac/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt: Removed.
  • platform/chromium-gpu/media/media-document-audio-repaint-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.txt: Renamed from LayoutTests/platform/chromium/media/media-document-audio-repaint-expected.txt.
1:56 PM Changeset in webkit [104488] by barraclough@apple.com
  • 14 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=75789
defineOwnProperty not implemented for Array objects

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Implements support for getter/setter & non-default attribute properties on arrays,
by forcing them into a dictionary-like 'SparseMode'. This fixes ~300 test-262
test failures.

  • JavaScriptCore.exp:
    • Updated exports.
  • dfg/DFGOperations.cpp:
    • JSArray::pop now requires an exec state.
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncPop):

  • JSArray::pop now requires an exec state.
  • runtime/JSArray.cpp:

(JSC::SparseArrayValueMap::add):

  • Add a potentially empty entry into the map.

(JSC::SparseArrayValueMap::put):

  • Changed to call setter.

(JSC::SparseArrayEntry::get):

  • calls getters.

(JSC::SparseArrayEntry::getNonSparseMode):

  • does not call getters.

(JSC::JSArray::enterSparseMode):

  • Convert into 'SparseMode' - removes the vectors, don't allow it to be recreated.

(JSC::JSArray::putDescriptor):

  • Create a numeric property based on a descriptor.

(JSC::sameValue):

  • See ES5.1 9.12.

(JSC::reject):

(JSC::JSArray::defineOwnNumericProperty):

  • Define an indexed property on an array object.

(JSC::JSArray::setLengthWritable):

  • Marks the length read-only, enters SparseMode as necessary.

(JSC::JSArray::defineOwnProperty):

  • Defines either an indexed property or 'length' on an array object.

(JSC::JSArray::getOwnPropertySlotByIndex):

  • Updated to correctly handle accessor descriptors & attributes.

(JSC::JSArray::getOwnPropertyDescriptor):

  • Updated to correctly handle accessor descriptors & attributes.

(JSC::JSArray::put):

  • Pass strict mode flag to setLength.

(JSC::JSArray::putByIndex):

  • putByIndexBeyondVectorLength requires an ExecState* rather than a JSGloablData&.

(JSC::JSArray::putByIndexBeyondVectorLength):

  • Pass exec to SparseArrayValueMap::put.

(JSC::JSArray::deletePropertyByIndex):

  • Do not allow deletion of non-configurable properties.

(JSC::compareKeysForQSort):

  • used in implementation of getOwnPropertyNames.

(JSC::JSArray::getOwnPropertyNames):

  • Properties in the sparse map should be iterated in order.

(JSC::JSArray::setLength):

  • Updated to take a 'shouldThrow' flag, return a result indicating error.

(JSC::JSArray::pop):

  • pop should throw an error if length is not writable, even if the array is empty.

(JSC::JSArray::push):

  • putByIndexBeyondVectorLength requires an ExecState* rather than a JSGloablData&.

(JSC::JSArray::sort):

  • Changed 'get' to 'getNonSparseMode' (can't be getters to call).

(JSC::JSArray::compactForSorting):

  • Changed 'get' to 'getNonSparseMode' (can't be getters to call).
  • runtime/JSArray.h:

(JSC::SparseArrayValueMap::lengthIsReadOnly):

  • Check if the length is read only.

(JSC::SparseArrayValueMap::setLengthIsReadOnly):

  • Mark the length as read only.

(JSC::SparseArrayValueMap::find):

  • Moved into header.

(JSC::JSArray::isLengthWritable):

  • Wraps SparseArrayValueMap::lengthIsReadOnly.
  • runtime/JSObject.cpp:

(JSC::JSObject::defineOwnProperty):

  • Should be returning the result of putDescriptor.
  • runtime/PropertyDescriptor.cpp:

(JSC::PropertyDescriptor::attributesOverridingCurrent):

  • Added attributesOverridingCurrent - this should probably be merged with attributesWithOverride.
  • runtime/PropertyDescriptor.h:
    • Added attributesOverridingCurrent.

LayoutTests:

  • fast/js/array-defineOwnProperty-expected.txt: Added.
  • fast/js/array-defineOwnProperty.html: Added.
  • fast/js/script-tests/array-defineOwnProperty.js: Added.
    • Added tests for array properties with accessors & non-defulat attributes.
  • fast/js/mozilla/strict/15.4.4.6-expected.txt:
  • fast/js/mozilla/strict/8.12.5-expected.txt:
  • ietestcenter/Javascript/15.4.4.14-9-a-12-expected.txt:
  • ietestcenter/Javascript/15.4.4.15-8-a-12-expected.txt:
    • Check in passing results.
1:50 PM Changeset in webkit [104487] by levin@chromium.org
  • 1 edit in branches/chromium/963/Source/WebKit/chromium/src/WebFrameImpl.cpp

Fix M17 build.

1:32 PM Changeset in webkit [104486] by tsepez@chromium.org
  • 3 edits
    4 adds in trunk

Treat code="" attribute in embed tags similarly to applet tags.
https://bugs.webkit.org/show_bug.cgi?id=75871

Reviewed by Daniel Bates.

Source/WebCore:

Tests: http/tests/security/xssAuditor/embed-tag-code-attribute-2.html

http/tests/security/xssAuditor/embed-tag-code-attribute.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterEmbedToken):

LayoutTests:

  • http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt: Added.
  • http/tests/security/xssAuditor/embed-tag-code-attribute-2.html: Added.
  • http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt: Added.
  • http/tests/security/xssAuditor/embed-tag-code-attribute.html: Added.
1:25 PM Changeset in webkit [104485] by commit-queue@webkit.org
  • 13 edits in trunk

[Chromium] remove all references to the legacy accelerated 2d Canvas
implementation
https://bugs.webkit.org/show_bug.cgi?id=75108

Purging an old settings flag that is no longer referenced

Patch by Justin Novosad <junov@chromium.org> on 2012-01-09
Reviewed by Darin Fisher.

Source/WebCore:

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:

Tools:

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::setAccelerated2dCanvasEnabled):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:
1:16 PM Changeset in webkit [104484] by leviw@chromium.org
  • 5 edits in branches/subpixellayout/Source/WebCore

Fixing SVG's initial transform to local coordinates to pixel snap. Also fixing widget alignment corner cases.

1:16 PM Changeset in webkit [104483] by Adam Roben
  • 2 edits in trunk/Tools

Convert Cygwin paths to Windows paths before passing them to DRT

Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
NRWT

I couldn't find a way to test this because I couldn't figure out how to override the
cygpath function as it is used by WebKitDriver.

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
Windows-style path before passing it to DRT.

1:10 PM Changeset in webkit [104482] by dpranke@chromium.org
  • 9 edits
    1 copy
    3 deletes in trunk/Tools

webkitpy: revamp version checking
https://bugs.webkit.org/show_bug.cgi?id=75765

Reviewed by Adam Barth.

The version-checking code in webkitpy/python24/versioning seems really
awkward and overdesigned, especially since we don't support python 2.4
any more.

In addition, I am tired of getting warnings about Python 2.6 being "a
newer release than what is supported" :).

I'm taking a page from the depot_tools python code and just creating a
new webkitpy.common.version_check module that will print a message on
stderr and call sys.exit() if we're running an unsupported version.

  • Scripts/check-webkit-style:
  • Scripts/new-run-webkit-httpd:
  • Scripts/new-run-webkit-tests:
  • Scripts/rebaseline-chromium-webkit-tests:
  • Scripts/test-webkitpy:

(configure_logging):
(init):

  • Scripts/webkit-patch:

(main):

  • Scripts/webkitpy/common/system/executive.py:

(Executive._child_process_encoding):
(Executive._should_encode_child_process_arguments):

  • Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • Scripts/webkitpy/python24/init.py: Removed.
  • Scripts/webkitpy/python24/versioning.py: Removed.
  • Scripts/webkitpy/python24/versioning_unittest.py: Removed.
1:08 PM Changeset in webkit [104481] by commit-queue@webkit.org
  • 5 edits in trunk

IndexedDB: Make WebIDBDatabase::close() idempotent
https://bugs.webkit.org/show_bug.cgi?id=75751

Source/WebKit/chromium:

Allow Chromium's back-end to safely trigger the cleanup that occurs
when a database connection is closed, without tracking whether or not
the connection was previous closed by script.

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-09
Reviewed by Tony Chang.

  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::close):

LayoutTests:

Verify that calling IDBDatabase.close() twice from script is harmless.
Note that the tests pass without the related code change in the bug,
which is just for non-script use by the chromium port.

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-09
Reviewed by Tony Chang.

  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
12:58 PM Changeset in webkit [104480] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

remove reference to cg-specific test
https://bugs.webkit.org/show_bug.cgi?id=75881

Patch by Elliot Poger <epoger@google.com> on 2012-01-09
Reviewed by Ojan Vafai.

  • platform/chromium/test_expectations.txt:
12:53 PM Changeset in webkit [104479] by eric.carlson@apple.com
  • 4 edits in trunk

Source/WebCore: REGRESSION(r104327?): media/track/track-cues-cuechange.html and track-cues-enter-exit.html
intermittently time out, media/track/track-cues-seeking and fails
https://bugs.webkit.org/show_bug.cgi?id=75817

Unreviewed, fix a problem introduced in r104327.

No new tests, covered by existing tests.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_ignoreTrackDisplayUpdate.

LayoutTests: REGRESSION(r104327?): media/track/track-cues-cuechange.html and track-cues-enter-exit.html intermittently time out, media/track/track-cues-seeking and fails
https://bugs.webkit.org/show_bug.cgi?id=75817

Unreviewed, fix a problem introduced in r104327.

Re-enable <track> tests disabled after r104327.

  • platform/chromium/test_expectations.txt:
12:47 PM Changeset in webkit [104478] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r100343.

12:38 PM Changeset in webkit [104477] by abarth@webkit.org
  • 4 edits in trunk/Tools

Remove Chromium Mac CG from the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=75873

Reviewed by Ojan Vafai.

This configuration no longer exists.

  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testOverrideJustBuildType):
(testPlatformAndBuildType):

12:22 PM Changeset in webkit [104476] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk

Add normalize attribute to ConvolverNode to disable normalization.
https://bugs.webkit.org/show_bug.cgi?id=75126

Patch by Raymond Toy <Raymond Toy> on 2012-01-09
Reviewed by Kenneth Russell.

Tests added in convolution-mono-mono.html.

  • platform/audio/Reverb.cpp:

(WebCore::Reverb::Reverb): Add extra arg to indicate whether
normalization is enabled or not, and do it.

  • platform/audio/Reverb.h: Update declaration.
  • webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::ConvolverNode): Initialize attribute (to
true).
(WebCore::ConvolverNode::setBuffer): Call Reverb with
normalization argument.

  • webaudio/ConvolverNode.h:

(WebCore::ConvolverNode::normalize): New method to return
normalization.
(WebCore::ConvolverNode::setNormalize): New method to set
normalization.

  • webaudio/ConvolverNode.idl: Add normalize attribute.
  • LayoutTests/webaudio/convolution-mono-mono.html:
  • LayoutTests/webaudio/convolution-mono-mono-expected.txt:
  • LayoutTests/webaudio/resources/convolution-testing.js:

Test for convolution. Tests only work when normalization is
disabled.

12:17 PM Changeset in webkit [104475] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GStreamer] webkitwebsrc: pad template is leaked
https://bugs.webkit.org/show_bug.cgi?id=74224

Patch by Judy Hao <judy.liqiong-hao@nokia.com> on 2012-01-09
Reviewed by Philippe Normand.

Use a GstPadTemplate smart pointer in webkit_web_src_init to
avoid a memory leak.

Fixing memory leaks. So, no new test case is introduced.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webkit_web_src_init):

12:15 PM Changeset in webkit [104474] by wangxianzhu@chromium.org
  • 14 edits
    1 add in trunk/Source

Avoid unnecessary TextureManager::reduceMemoryToLimit().
https://bugs.webkit.org/show_bug.cgi?id=75632

Source/WebCore:

Unnecessary TextureManager::reduceMemoryToLimit() will cause some tile
textures that are required soon to be unnecessarily removed/replaced,
and degrade performance, sometimes significantly.

For example, CCLayerTreeHost::setViewport will be called during
scrolling. The original code would call TextureManager::reduceMemoryToLimit(),
causing some textures unnecessarily discarded and then recreated
repeatedly during scrolling.

It's also unnecessary to call TextureManager::reduceMemoryToLimit()
from TextureManager::setPreferredMemoryLimitBytes() because the limit
is not a hard limit. The callers should call reduceMemoryToLimit()
explicitly if it wants it when setting the preferred memory limit.

Reviewed by James Robinson.

Tests: webkit_unit_tests --gtest_filter=TextureManagerTest.*:CCLayerTreeHostTestSetViewportSize.*

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::finishDrawingFrame): Call reduceMemoryToLimit() explicitly

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::setPreferredMemoryLimitBytes): Removed call to reduceMemoryToLimit().

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setViewportSize): Changed name from setViewport(). Check change of viewportSize.

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setViewportSize): Changed name from setViewport()

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Source/WebKit/chromium:

Main part of the change is in Source/WebCore.

Reviewed by James Robinson.

Tests: webkit_unit_tests --gtest_filter=TextureManagerTest.*:CCLayerTreeHostTestSetViewportSize.*

  • WebKit.gypi:
  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::setViewportSize):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateLayerTreeViewport):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::create):
(WTF::CCLayerTreeHostTestOpacityChange::beginTest):
(WTF::CCLayerTreeHostTestSetViewportSize::CCLayerTreeHostTestSetViewportSize):
(WTF::CCLayerTreeHostTestSetViewportSize::beginTest):
(WTF::CCLayerTreeHostTestSetViewportSize::afterTest):
(WTF::TEST_F):

  • tests/TextureManagerTest.cpp: Added.

(WTF::FakeTextureAllocator::createTexture):
(WTF::FakeTextureAllocator::deleteTexture):
(WTF::texturesMemorySize):
(WTF::createTextureManager):
(WTF::requestTexture):
(WTF::TEST):

12:02 PM Changeset in webkit [104473] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

There is no support for fastcall in Solaris Studio.
Fixes build on Solaris.
https://bugs.webkit.org/show_bug.cgi?id=75736

Patch by Pavel Heimlich <tropikhajma@gmail.com> on 2012-01-09
Reviewed by Gavin Barraclough.

  • jit/JITStubs.h:
11:46 AM Changeset in webkit [104472] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] JPEG RGB swizzling order should match platform pixel format
https://bugs.webkit.org/show_bug.cgi?id=75861

Choose between JCS_EXT_BGRX and JCS_EXT_RGBX channel swizzling
based on the configured Skia 32-bit pixel format.

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-01-09
Reviewed by Kenneth Russell.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(rgbOutputColorSpace):

11:44 AM Changeset in webkit [104471] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix build failure on Solaris
https://bugs.webkit.org/show_bug.cgi?id=75733

Patch by Pavel Heimlich <tropikhajma@gmail.com> on 2012-01-09
Reviewed by Gavin Barraclough.

  • wtf/ByteArray.h:
11:41 AM Changeset in webkit [104470] by levin@chromium.org
  • 1 edit in branches/chromium/963/Source/WebKit/chromium/src/WebFrameImpl.cpp

Merge 104419 - [chromium] iframes in an autoresized window get sized incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=75806

Reviewed by Adam Barth.

Source/WebKit/chromium:

TEST: fast/autoresize/autoresize-with-iframe.html

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView): Only do autoresizing
for the main frame not child frames.

LayoutTests:

  • fast/autoresize/autoresize-with-iframe-expected.txt: Added.
  • fast/autoresize/autoresize-with-iframe.html: Added.
  • fast/autoresize/basic.html: Pulled out autoresize-util.js
  • fast/autoresize/resources/autoresize-util.js: Added.

(log):
(shouldBe):

  • fast/autoresize/resources/iframe.html: Added.

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/9151009

11:26 AM Changeset in webkit [104469] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

getComputedStyle for border-radius is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75630

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for border-radius shorthand property.

Test: fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):
(WebCore::getBorderRadiusShorthandValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add new tests to make sure we return the correct values.

  • fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand.html: Added.
11:17 AM Changeset in webkit [104468] by kubo@profusion.mobi
  • 2 edits in trunk/Source/JavaScriptCore

[CMake] Clean up some cruft from WTF's CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=75420

Reviewed by Daniel Bates.

  • wtf/CMakeLists.txt: Remove the unused WTF_PORT_FLAGS variable; add

all needed paths to WTF_INCLUDE_DIRECTORIES in a single place.

11:16 AM Changeset in webkit [104467] by abarth@webkit.org
  • 1 delete in trunk/LayoutTests/platform/chromium-gpu-cg-mac

Remove expected results for Chromium Mac CG. This configuration is no longer supported.

11:15 AM Changeset in webkit [104466] by abarth@webkit.org
  • 1 delete in trunk/LayoutTests/platform/chromium-cg-mac-snowleopard

Remove expected results for Chromium Mac CG. This configuration is no longer supported.

11:15 AM Changeset in webkit [104465] by abarth@webkit.org
  • 1 delete in trunk/LayoutTests/platform/chromium-cg-mac-leopard

Remove expected results for Chromium Mac CG. This configuration is no longer supported.

11:15 AM Changeset in webkit [104464] by abarth@webkit.org
  • 1 delete in trunk/LayoutTests/platform/chromium-cg-mac

Remove expected results for Chromium Mac CG. This configuration is no longer supported.

10:38 AM Changeset in webkit [104463] by Adam Roben
  • 3 edits in trunk/Tools

Print an error message when NRWT can't run Apache

Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.check_httpd): Print an error message when Apache returns an error code instead of
failing silently.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
run Apache.
(PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
fails.

7:34 AM Changeset in webkit [104462] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75856

media/track/track-webvtt-tc026-voice.html is crashing on Chromium
Debug Mac after http://trac.webkit.org/changeset/104327/

Tracking in bug 75817.

Unreviewed.

  • platform/chromium/test_expectations.txt:
7:32 AM Changeset in webkit [104461] by rgabor@webkit.org
  • 2 edits in trunk/Tools

[Gtk][ARM] Cross compiler buildbot is failing after r103040
https://bugs.webkit.org/show_bug.cgi?id=75846

Reviewed by Philippe Normand.

  • Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary):

7:19 AM Changeset in webkit [104460] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r104418.
http://trac.webkit.org/changeset/104418
https://bugs.webkit.org/show_bug.cgi?id=75855

we still need to build against CG on Mac sometimes (Requested
by epoger on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-09

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • WebKit.gyp:
  • WebKit.gypi:
7:08 AM Changeset in webkit [104459] by commit-queue@webkit.org
  • 6 edits in trunk

[GTK] [AC] Simplify accelerated compositing build options
https://bugs.webkit.org/show_bug.cgi?id=75518

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-01-09
Reviewed by Gustavo Noronha Silva.

.:

  • configure.ac: Remove the --enable-3d-rendering option. It's enabled by

default now when accelerated compositing is enabled.

  • GNUmakefile.am: Automatically enable 3D rendering when accelerated compositing

is turned on.

Source/WebCore:

  • GNUmakefile.am: Automatically enable 3D rendering when AC is available.
  • GNUmakefile.list.am: Clean up a comment.
6:59 AM Changeset in webkit [104458] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

possible regression: r104060 maybe causing crashes
https://bugs.webkit.org/show_bug.cgi?id=75676

Reviewed by Andreas Kling.

Based on the stacks, CSSStyleSelector may be getting deleted from under the
CSSStyleSelector::appendAuthorStylesheets call. Protect by temporarily detaching
from the document. Also add assertions to catch the case.

No test, there is no known repro and the fix is speculative.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::setDocType):
(WebCore::Document::childrenChanged):
(WebCore::Document::clearStyleSelector):
(WebCore::Document::updateActiveStylesheets):

  • dom/Document.h:
6:30 AM Changeset in webkit [104457] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebCore

Use Vector<OwnPtr> for m_viewportDependentMediaQueryResults in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=75723

Reviewed by Andreas Kling.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::~CSSStyleSelector):
(WebCore::CSSStyleSelector::addViewportDependentMediaQueryResult):

  • css/CSSStyleSelector.h:
6:28 AM Changeset in webkit [104456] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75852

http/tests/inspector/network/download.html is timing out on mac, and
occasionally on other platforms too.

Unreviewed.

  • platform/chromium/test_expectations.txt:
6:14 AM Changeset in webkit [104455] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Tools

[Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=75807

This patch adds a new icon to navigationbar of the Qt MiniBrowser
which allows you to dynamically toggle whether touch mocking is
enabled or disabled.

Patch by Alexander Færøy <ahf@0x90.dk> on 2012-01-09
Reviewed by Tor Arne Vestbø.

  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::notify):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::WindowOptions):
(WindowOptions::touchMockingEnabled):
(WindowOptions::setTouchMockingEnabled):

  • MiniBrowser/qt/icons/touch.png: Added.
  • MiniBrowser/qt/qml/BrowserWindow.qml:
6:05 AM Changeset in webkit [104454] by Csaba Osztrogonác
  • 2 edits
    1 copy in trunk/LayoutTests

Fix expected files for new test: fast/dom/insertAdjacentHTML-DocumentFragment-crash.html
https://bugs.webkit.org/show_bug.cgi?id=75847

Reviewed by Philippe Normand.

  • fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt: Add JSC specifix expected file as generic expected file.
  • platform/chromium/fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt: Add V8 specifix expected file.
6:00 AM Changeset in webkit [104453] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75849

We need to prevent TextTrack and TextTrackCue from being
garbage collected when the parent/owner is still reachable.
This is tracked in bug 73865.

Unreviewed.

  • platform/chromium/test_expectations.txt:
5:48 AM Changeset in webkit [104452] by alexis.menard@openbossa.org
  • 8 edits in trunk/Source/WebCore

Extend CSSValueList to allow slash separated lists.
https://bugs.webkit.org/show_bug.cgi?id=75841

Reviewed by Andreas Kling.

Multiple CSS properties are using slash to separate
various parts (e.g. border-radius) so having this
feature available in CSSValueList will make it easier
in the future to support these properties.

No new tests : existing ones should cover the refactor.

  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::isImplicit):
(WebCore::CSSInitialValue::CSSInitialValue):

  • css/CSSValue.cpp:

(WebCore::CSSValue::isImplicitInitialValue):

  • css/CSSValue.h:

In order for CSSValue to not grow I moved m_isImplicitInitialValue
back to CSSInitialValue as this object is used only in CSSValuePool
and is allocated only twice.
(WebCore::CSSValue::CSSValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::CSSValueList):
(WebCore::CSSValueList::copy):
Fix also usage of PassRefPtr.
(WebCore::CSSValueList::customCssText):
Refactor to use StringBuilder.

  • css/CSSValueList.h:

(WebCore::CSSValueList::createCommaSeparated):
(WebCore::CSSValueList::createSpaceSeparated):
(WebCore::CSSValueList::createSlashSeparated):

  • css/WebKitCSSFilterValue.cpp:

(WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):

  • css/WebKitCSSTransformValue.cpp:

(WebCore::WebKitCSSTransformValue::WebKitCSSTransformValue):

5:22 AM Changeset in webkit [104451] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75844

media/track/track-cues-cuechange.html is failing after
http://trac.webkit.org/changeset/104327/

Tracking in bug 75817.

Unreviewed.

  • platform/chromium/test_expectations.txt:
4:35 AM Changeset in webkit [104450] by abecsi@webkit.org
  • 23 edits in trunk

[Qt][WK2] Pinch zoom should affect the page size
https://bugs.webkit.org/show_bug.cgi?id=74601

Reviewed by Kenneth Rohde Christiansen.

The current implementation uses the scale property of the QQuickWebPage
to scale the page in response to pinch gestures.
However for layout and anchoring to work correctly in QML, pinching needs
to change the page size.
This patch applies the pinch scale to the page size and to the transformation
matrix of the drawing area.
Thus the page item's coordinate system is no longer a direct representation
of the WebCore::Page coordinate system and it is no longer suitable as
an inertial frame of reference for input events. The event propagation had
to be moved to the QQuickWebView and the positions translated to content
coordinates when NativeWebEvents are created.
Re-landing with fixed event delivery for the test infrastructure.

  • Shared/NativeWebMouseEvent.h:
  • Shared/NativeWebTouchEvent.h:
  • Shared/NativeWebWheelEvent.h:
  • Shared/qt/NativeWebMouseEventQt.cpp:

(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):

  • Shared/qt/NativeWebTouchEventQt.cpp:

(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):

  • Shared/qt/NativeWebWheelEventQt.cpp:

(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):

  • Shared/qt/WebEventFactoryQt.cpp:

(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebTouchEvent):

  • Shared/qt/WebEventFactoryQt.h:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::geometryChanged):
(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::paintToCurrentGLContext):
(QQuickWebPage::usesTraditionalDesktopBehaviour):
(QQuickWebPage::setUsesTraditionalDesktopBehaviour):
(QQuickWebPage::eventHandler):
(QQuickWebPage::setContentSize):
(QQuickWebPage::contentSize):
(QQuickWebPage::setContentScale):
(QQuickWebPage::contentScale):
(QQuickWebPage::transformFromItem):
(QQuickWebPage::transformToItem):
(QQuickWebPagePrivate::updateSize):

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebpage_p_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::enableMouseEvents):
(QQuickWebViewPrivate::disableMouseEvents):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::didFinishFirstNonEmptyLayout):
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::pageDidRequestScroll):
(QQuickWebViewPrivate::updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::PostTransitionState::apply):
(QQuickWebViewPrivate::setUseTraditionalDesktopBehaviour):
(QQuickWebViewExperimental::setUseTraditionalDesktopBehaviour):
(QQuickWebViewExperimental::useTraditionalDesktopBehaviour):
(QQuickWebView::mapToWebContent):
(QQuickWebView::mapRectToWebContent):
(QQuickWebView::mapFromWebContent):
(QQuickWebView::mapRectFromWebContent):
(QQuickWebView::geometryChanged):
(QQuickWebView::keyPressEvent):
(QQuickWebView::keyReleaseEvent):
(QQuickWebView::inputMethodEvent):
(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):
(QQuickWebView::touchEvent):
(QQuickWebView::mousePressEvent):
(QQuickWebView::mouseMoveEvent):
(QQuickWebView::mouseReleaseEvent):
(QQuickWebView::mouseDoubleClickEvent):
(QQuickWebView::wheelEvent):
(QQuickWebView::hoverEnterEvent):
(QQuickWebView::hoverMoveEvent):
(QQuickWebView::hoverLeaveEvent):
(QQuickWebView::dragMoveEvent):
(QQuickWebView::dragEnterEvent):
(QQuickWebView::dragLeaveEvent):
(QQuickWebView::dropEvent):
(QQuickWebView::event):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::contentsSize):

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::scrollRequest):

  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::recognize):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemAtScale):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::applyConstraints):
(WebKit::QtViewportInteractionEngine::currentCSSScale):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::panGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::scaleContent):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleEvent):
(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleSingleTapEvent):
(QtWebPageEventHandler::handleDoubleTapEvent):
(QtWebPageEventHandler::touchEvent):

  • UIProcess/qt/QtWebPageEventHandler.h:
4:13 AM Changeset in webkit [104449] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Set color_set function to the clipped smart class.
https://bugs.webkit.org/show_bug.cgi?id=75286

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-01-09
Reviewed by Andreas Kling.

Set _ewk_view_smart_color_set() function to the clipped smart class's color_set,
so application can set webpage's background color using evas_object_color_set() API.

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_color_set):
(ewk_view_smart_class_init):

4:06 AM Changeset in webkit [104448] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75840

Unreviewed.

fast/filesystem/file-writer-abort.html is occasionally crashing
also on Windows.

  • platform/chromium/test_expectations.txt:
3:54 AM Changeset in webkit [104447] by noam.rosenthal@nokia.com
  • 7 edits
    1 add in trunk/Source/WebCore

[Texmap] Move surface management from TextureMapperNode to TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=75779

Instead of a TextureMapperSurfaceManager class inside of TextureMapperNode.cpp, we now
maintain that surface pool inside of the TextureMapper class. This will later allow us to
allocate intermediate surface from within TextureMapperGL, a functionality we need for
filters.

Also, surfaces are not automatically created with the viewport size, but rather with the
size passed as a parameter. The surface from the pool is the smallest texture that is
larger than the required size, or any texture if such texture is not yet allocated.

Reviewed by Kenneth Rohde Christiansen.

Tests in LayoutTests/compositing already cover this.

  • GNUmakefile.list.am: Added TextureMapper.cpp to the build.
  • Target.pri: Added TextureMapper.cpp to the build.
  • WebCore.gypi: Added TextureMapper.cpp to the build.
  • platform/graphics/texmap/TextureMapper.cpp: Added.
  • platform/graphics/texmap/TextureMapper.h:
  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::paint):
(WebCore::TextureMapperNode::paintReflection):
(WebCore::TextureMapperNode::paintRecursive):

  • platform/graphics/texmap/TextureMapperNode.h:

(WebCore::TextureMapperNode::TextureMapperNode):

2:16 AM Changeset in webkit [104446] by mario@webkit.org
  • 6 edits in trunk/Source

[Gtk] Regression: text-inserted events lack text inserted and current line
https://bugs.webkit.org/show_bug.cgi?id=72830

Reviewed by Martin Robinson.

Source/WebCore:

Fix issue getting the exposed text for an accessibility object at,
before of after a given offset, after changing it at least once.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(webkit_accessible_class_init): Don't initialize
gailTextUtilQuark, it won't be used anymore.
(getGailTextUtilForAtk): Don't cache the GailTextUtil as object
data, but create a new one each time this function is called.
(webkit_accessible_text_get_caret_offset): Simplified code by
using the new focusedObjectAndCaretOffsetUnignored function,
instead of the old objectAndOffsetUnignored function.
(focusedObjectAndCaretOffsetUnignored): Rewrite of the old
objectAndOffsetUnignored function so it now needs less
parameters than before and takes care of carefully selecting the
start and end visible positions to calculate the position of the
caret from the point of view of the accessibility object of
reference passed as the only input parameter now. Updated callers.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.h:
  • editing/gtk/FrameSelectionGtk.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
Simplified code by calling to focusedObjectAndCaretOffsetUnignored
function, instead of the old objectAndOffsetUnignored function.

Source/WebKit/gtk:

Updated unit tests to check that both getting the current position
for the caret and the exposed text at, before or after a given
offset for an accessible object works as expected.

  • tests/testatk.c:

(runGetTextTests): For objects implementing AtkEditableText, try
to change the exposed text and retrieve it again as a full line.
(testWebkitAtkCaretOffsets): For a text control (a text entry),
set the caret offset to a value greater than 1 and retrieve it.

2:00 AM Changeset in webkit [104445] by Antti Koivisto
  • 4 edits
    2 adds in trunk

Subtree invalidation on stylesheet change
https://bugs.webkit.org/show_bug.cgi?id=75834

Source/WebCore:

Reviewed by Andreas Kling.

Currently if we add a stylesheet with scoped selectors and matching scope elements exist,
we recalculate the entire document style. It is sufficient to invalidate the subtrees
matching the scope only.

This allows us to do less full style recalcs on many popular web sites (nytimes.com for example).
Subtree recalcs are typically much cheaper.

Test: fast/css/id-or-class-before-stylesheet.html

  • dom/Document.cpp:

(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):
(WebCore::Document::analyzeStylesheetChange):
(WebCore::Document::updateActiveStylesheets):

  • dom/Document.h:

LayoutTests:

Reviewed by Andreas Kling.

  • fast/css/id-or-class-before-stylesheet-expected.txt: Added.
  • fast/css/id-or-class-before-stylesheet.html: Added.
1:53 AM Changeset in webkit [104444] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Fix make distcheck issues.

Source/WebCore:

  • GNUmakefile.list.am: Add missing header.

Tools:

  • MiniBrowser/gtk/GNUmakefile.am:
1:38 AM Changeset in webkit [104443] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[Refactoring] Use join(", ", @arguments) to build a method argument string
in CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=75830

Reviewed by Adam Barth.

The code in CodeGeneratorJS.pm to build a method argument string is dirty
and error-prone. It is concatenating arguments one by one judging whether
", " is necessary or not. This patch refactors the code so that it pushes
all arguments into @arguments and then builds a method string by
join(", ", @arguments).

Test: bindings/scripts/test/*

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GenerateParametersCheck):
(GenerateImplementationFunctionCall):

1:09 AM Changeset in webkit [104442] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

CSSMutableStyleDeclaration: Remove propertiesEqual().
<http://webkit.org/b/75829>

Reviewed by Antti Koivisto.

Remove propertiesEqual() since it was wrong (it only compared CSSValue pointers,
not the actual values.)

Skip comparing the style declarations in NamedNodeMap::mappedMapsEquivalent()
and just compare pointers instead. This is possible because the declarations
all come from the mapped attribute/declaration table.

  • css/CSSMutableStyleDeclaration.h:
  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::mappedMapsEquivalent):

12:53 AM Changeset in webkit [104441] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

insertAdjacentHTML doesn't play nice with DocumentFragment
https://bugs.webkit.org/show_bug.cgi?id=75826

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/dom/insertAdjacentHTML-DocumentFragment-crash.html

Document nodes aren't the only non-Element ContainerNodes.

  • html/HTMLElement.cpp:

(WebCore::contextElementForInsertion):

LayoutTests:

  • fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt: Added.
  • fast/dom/insertAdjacentHTML-DocumentFragment-crash.html: Added.
12:42 AM Changeset in webkit [104440] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSStyleSelector: Any attribute with a decl() can be assumed to be mapped.
<http://webkit.org/b/75832>

Reviewed by Antti Koivisto.

Replace isMappedAttribute() check with an assertion. Only a mapped attribute
will have an associated style declaration.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):

12:32 AM Changeset in webkit [104439] by Philippe Normand
  • 3 edits
    1 add in trunk/LayoutTests

Unreviewed, GTK rebaseline after r104412.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/http/tests/security/cross-frame-access-put-expected.txt: Added.
  • platform/gtk/Skipped: Skip fast/text/international/spaces-combined-in-vertical-text.html
12:26 AM Changeset in webkit [104438] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[Refactoring] Use join(", ", @arguments) to build a method argument
string in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=75828

Reviewed by Darin Adler.

The code in CodeGeneratorV8.pm to build a method argument string is dirty
and error-prone. It is concatenating arguments one by one judging whether
", " is necessary or not. This patch refactors the code so that it pushes
all arguments into @arguments and then builds a method string by
join(", ", @arguments).

Test: bindings/scripts/test/*

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallString):

12:06 AM Changeset in webkit [104437] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r104412.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/http/tests/security/cross-frame-access-put-expected.txt:

Jan 8, 2012:

11:18 PM Changeset in webkit [104436] by wangxianzhu@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix compilation error about ListHashSetReverseIterator
https://bugs.webkit.org/show_bug.cgi?id=75372

Reviewed by Darin Adler.

There is a typo in class ListHashSetReverseIterator:
typedef ListHashSetConstIterator<ValueArg, inlineCapacity, HashArg> const_reverse_iterator;
Should be
typedef ListHashSetConstReverseIterator<ValueArg, inlineCapacity, HashArg> const_reverse_iterator;

  • wtf/ListHashSet.h:
11:15 PM Changeset in webkit [104435] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix: ScrollAnimatorMac has missing initializer in systemUptime()
https://bugs.webkit.org/show_bug.cgi?id=75827

Reviewed by Darin Adler.

Explicitly initialize the struct timeval to avoid compiler warnings.

  • platform/mac/ScrollAnimatorMac.mm:

(systemUptime):

11:09 PM Changeset in webkit [104434] by Lucas Forschler
  • 5 edits in branches/safari-534.54-branch/Source

Versioning.

11:01 PM Changeset in webkit [104433] by Lucas Forschler
  • 1 copy in tags/Safari-534.54.3

New tag.

10:56 PM Changeset in webkit [104432] by mikelawther@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

color tests for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75819

Reviewed by Eric Seidel.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/color-hsl-expected.txt: Added.
  • css3/calc/color-hsl.html: Added.
  • css3/calc/color-rgb-expected.txt: Added.
  • css3/calc/color-rgb.html: Added.
10:14 PM Changeset in webkit [104431] by mikelawther@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

font tests for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75818

Reviewed by Eric Seidel.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/font-expected.txt: Added.
  • css3/calc/font-monospace-expected.txt: Added.
  • css3/calc/font-monospace.html: Added.
  • css3/calc/font-size-expected.txt: Added.
  • css3/calc/font-size-fractional-expected.txt: Added.
  • css3/calc/font-size-fractional.html: Added.
  • css3/calc/font-size.html: Added.
  • css3/calc/font.html: Added.
10:01 PM Changeset in webkit [104430] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Memory allocation mismatch by using adoptArrayPtr in GraphicsContext3DOpenGL.cpp
https://bugs.webkit.org/show_bug.cgi?id=75820

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-01-08
Reviewed by Darin Adler.

Dbates submitted a patch to release fastMalloc allocation
in GraphicsContext3DOpenGL.cpp properly.
See http://trac.webkit.org/browser/trunk/Source/WebCore/ChangeLog?rev=104395
But one thing similar to the above still remains mismatched.

No new tests required.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::getShaderInfoLog):

8:27 PM Changeset in webkit [104429] by rniwa@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

WinCE build fix after r104415.

  • jit/JITExceptions.cpp:
  • jit/JITExceptions.h:
6:57 PM Changeset in webkit [104428] by mikelawther@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

border tests for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75815

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

Reviewed by Adam Barth.

  • css3/calc/border-expected.txt: Added.
  • css3/calc/border-radius-expected-mismatch.html: Added.
  • css3/calc/border-radius.html: Added.
  • css3/calc/border.html: Added.
6:50 PM Changeset in webkit [104427] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Use the concrete FrameNetworkingContextBlackBerry to access Frame
https://bugs.webkit.org/show_bug.cgi?id=75611

Reviewed by Antonio Gomes.

In platform/network/blackberry/ResourceHandleBlackBerry.cpp, we were using
NetworkingContext::wrappedFrame() to access the frame associated with the
networking context. NetworkingContext::wrappedFrame() was added as a virtual
function by the BlackBerry porting internally. It's unnecessary because
FrameNetworkingContextBlackBerry inherits from FrameNetworkingContext which
has a protected frame() member which is exported as public in
FrameNetworkingContextBlackBerry. We don't want to upstream wrappedFrame()
as a specific change of the BlackBerry porting in
platform/network/NetworkingContext.h, so use the concrete networking context
FrameNetworkingContextBlackBerry to access the associated frame.

No functionalities changed, no new tests.

  • platform/network/blackberry/ResourceHandleBlackBerry.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

6:41 PM Changeset in webkit [104426] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add intermittent timeout expectations to media/track/track-cues-cuechange.html and
media/track/track-cues-enter-exit.html. The failure is tracked by the bug 75817.

  • platform/chromium/test_expectations.txt:
6:33 PM Changeset in webkit [104425] by commit-queue@webkit.org
  • 8 edits
    54 deletes in trunk

Unreviewed, rolling out r104421.
http://trac.webkit.org/changeset/104421
https://bugs.webkit.org/show_bug.cgi?id=75816

Need to rebaseline some tests on Linux (Requested by noamr on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-08

Source/WebCore:

  • Target.pri:

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::allowedCompositingTriggers):

Tools:

  • qmake/mkspecs/features/features.prf:

LayoutTests:

  • platform/qt/Skipped:
  • platform/qt/css3/filters/add-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/add-filter-rendering-expected.txt: Removed.
  • platform/qt/css3/filters/crash-filter-change-expected.png: Removed.
  • platform/qt/css3/filters/crash-filter-change-expected.txt: Removed.
  • platform/qt/css3/filters/crash-hw-sw-switch-expected.png: Removed.
  • platform/qt/css3/filters/custom-filter-property-parsing-expected.txt: Removed.
  • platform/qt/css3/filters/custom-filter-property-parsing-invalid-expected.txt: Removed.
  • platform/qt/css3/filters/effect-blur-expected.png: Removed.
  • platform/qt/css3/filters/effect-blur-expected.txt: Removed.
  • platform/qt/css3/filters/effect-brightness-expected.png: Removed.
  • platform/qt/css3/filters/effect-brightness-expected.txt: Removed.
  • platform/qt/css3/filters/effect-contrast-expected.png: Removed.
  • platform/qt/css3/filters/effect-contrast-expected.txt: Removed.
  • platform/qt/css3/filters/effect-drop-shadow-expected.png: Removed.
  • platform/qt/css3/filters/effect-drop-shadow-expected.txt: Removed.
  • platform/qt/css3/filters/effect-grayscale-expected.png: Removed.
  • platform/qt/css3/filters/effect-grayscale-expected.txt: Removed.
  • platform/qt/css3/filters/effect-hue-rotate-expected.png: Removed.
  • platform/qt/css3/filters/effect-hue-rotate-expected.txt: Removed.
  • platform/qt/css3/filters/effect-invert-expected.png: Removed.
  • platform/qt/css3/filters/effect-invert-expected.txt: Removed.
  • platform/qt/css3/filters/effect-opacity-expected.png: Removed.
  • platform/qt/css3/filters/effect-opacity-expected.txt: Removed.
  • platform/qt/css3/filters/effect-saturate-expected.png: Removed.
  • platform/qt/css3/filters/effect-saturate-expected.txt: Removed.
  • platform/qt/css3/filters/effect-sepia-expected.png: Removed.
  • platform/qt/css3/filters/effect-sepia-expected.txt: Removed.
  • platform/qt/css3/filters/filter-animation-expected.png: Removed.
  • platform/qt/css3/filters/filter-animation-expected.txt: Removed.
  • platform/qt/css3/filters/filter-animation-from-none-expected.png: Removed.
  • platform/qt/css3/filters/filter-animation-from-none-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-computed-style-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-expected.png: Removed.
  • platform/qt/css3/filters/filter-property-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-parsing-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-parsing-invalid-expected.txt: Removed.
  • platform/qt/css3/filters/filter-region-expected.png: Removed.
  • platform/qt/css3/filters/filter-region-expected.txt: Removed.
  • platform/qt/css3/filters/filter-repaint-expected.png: Removed.
  • platform/qt/css3/filters/filter-repaint-expected.txt: Removed.
  • platform/qt/css3/filters/filter-with-transform-expected.png: Removed.
  • platform/qt/css3/filters/filter-with-transform-expected.txt: Removed.
  • platform/qt/css3/filters/filtered-inline-expected.png: Removed.
  • platform/qt/css3/filters/filtered-inline-expected.txt: Removed.
  • platform/qt/css3/filters/nested-filter-expected.png: Removed.
  • platform/qt/css3/filters/nested-filter-expected.txt: Removed.
  • platform/qt/css3/filters/nested-filters-expected.png: Removed.
  • platform/qt/css3/filters/nested-filters-expected.txt: Removed.
  • platform/qt/css3/filters/regions-expanding-expected.png: Removed.
  • platform/qt/css3/filters/regions-expanding-expected.txt: Removed.
  • platform/qt/css3/filters/remove-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/remove-filter-rendering-expected.txt: Removed.
  • platform/qt/css3/filters/simple-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/simple-filter-rendering-expected.txt: Removed.
6:14 PM Changeset in webkit [104424] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk/LayoutTests

Another Chromium Windows and Chromium Linux rebaseline after r104240.
The expected result committed in r104361 was clearly wrong.

  • platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-win-vista/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.png:
5:01 PM Changeset in webkit [104423] by abarth@webkit.org
  • 6 edits in trunk/Tools

Remove support for Chromium Mac CG from garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=75814

Reviewed by Eric Seidel.

This configuration no longer exists. This patch is mostly a matter of
updating config.js and removing the examples from the unit tests.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
4:49 PM Changeset in webkit [104422] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Remove Mac CG specific expectations in test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=75813

Unreviewed.

This configuration no longer exists and this change is needed to stop
the bots from erroring out.

  • platform/chromium/test_expectations.txt:
4:46 PM Changeset in webkit [104421] by noam.rosenthal@nokia.com
  • 8 edits
    54 adds in trunk

[Qt] Enable CSS_FILTERS in Qt build
https://bugs.webkit.org/show_bug.cgi?id=75777

Source/WebCore:

Enable CSS_FILTERS and unskip the tests.

Reviewed by Kenneth Rohde Christiansen.

Filter tests are now unskipped for Qt.

  • Target.pri: add missing files to build.

Source/WebKit/qt:

For now, disallow compositing for filters. We will change that trigger when
https://bugs.webkit.org/show_bug.cgi?id=75778 is implemented.

Reviewed by Kenneth Rohde Christiansen.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::allowedCompositingTriggers):

Tools:

Add the CSS_FILTERS feature flag to Qt.

Reviewed by Kenneth Rohde Christiansen.

  • qmake/mkspecs/features/features.prf:

LayoutTests:

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/Skipped: Unskip filter tests that work.
  • platform/qt/css3/filters/*: Added Qt specific results.
4:32 PM Changeset in webkit [104420] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Categorize bots by ports instead of core/non-core separation
https://bugs.webkit.org/show_bug.cgi?id=75766

Reviewed by Eric Seidel.

Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
(Chromium still comes before GTK and Qt).

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
4:29 PM Changeset in webkit [104419] by levin@chromium.org
  • 4 edits
    5 adds in trunk

[chromium] iframes in an autoresized window get sized incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=75806

Reviewed by Adam Barth.

Source/WebKit/chromium:

TEST: fast/autoresize/autoresize-with-iframe.html

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView): Only do autoresizing
for the main frame not child frames.

LayoutTests:

  • fast/autoresize/autoresize-with-iframe-expected.txt: Added.
  • fast/autoresize/autoresize-with-iframe.html: Added.
  • fast/autoresize/basic.html: Pulled out autoresize-util.js
  • fast/autoresize/resources/autoresize-util.js: Added.

(log):
(shouldBe):

  • fast/autoresize/resources/iframe.html: Added.
4:27 PM Changeset in webkit [104418] by abarth@webkit.org
  • 5 edits in trunk/Source

[Chromium] Remove use_skia option from GYP
https://bugs.webkit.org/show_bug.cgi?id=75811

Reviewed by Ryosuke Niwa.

The CG configuration of Chromium Mac is no longer supported.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • WebKit.gyp:
  • WebKit.gypi:
4:12 PM Changeset in webkit [104417] by rniwa@webkit.org
  • 4 edits in trunk/Tools

Remove the concept of core builders from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=75809

Reviewed by Ryosuke Niwa.

Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
and remove the relevant code.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot.init):
(BuildBot._matches_regexps):
(BuildBot._builder_statuses_with_names_matching_regexps):
(BuildBot.builder_statuses):
(BuildBot.failure_map):
(BuildBot._latest_builds_from_builders):
(BuildBot.last_green_revision):

  • Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:

(MockBuildBot.builder_statuses):

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(test_status_parsing):
(test_last_green_revision):
(test_last_green_revision.mock_builds_from_builders):

4:04 PM Changeset in webkit [104416] by abarth@webkit.org
  • 19 edits in trunk/Tools

Remove Chromium Mac CG concept from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=75810

Reviewed by Ryosuke Niwa.

This configuration no longer exists. We can remove all the supporting
code from webkitpy.

  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

(BaselineOptimizerTest.test_move_baselines):
(BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
(BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
(BaselineOptimizerTest.test_common_directory_includes_root):
(BaselineOptimizerTest.test_complex_shadowing):

  • Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build):

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest):

  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):
(ChromiumPort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

(_default_tests_paths):
(ChromiumGpuLinuxPort.tests):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

(ChromiumGpuTest.integration_test_chromium_gpu_mac):
(ChromiumGpuTest.assert_port_works):
(ChromiumGpuTest.test_baseline_paths):
(ChromiumGpuTest.test_graphics_type):
(ChromiumGpuTest.test_default_tests_paths):
(ChromiumGpuTest.test_test_files):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort):
(ChromiumMacPort.init):
(ChromiumMacPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_graphics_type):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory._port_name_from_arguments_and_options):
(PortFactory.get):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest.test_chromium_gpu_mac):
(FactoryTest.test_chromium_mac):

  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

(GetGoogleChromePortTest._verify_expectations_overrides):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockChromiumDRTTest.test_chromium_parse_options):

  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:

(test_url_fetcher):
(test_zip_factory):
(test_archive):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline_expectations):

3:46 PM Changeset in webkit [104415] by fpizlo@apple.com
  • 8 edits
    2 adds in trunk/Source/JavaScriptCore

The JIT's protocol for exception handling should be available to other parts of the system
https://bugs.webkit.org/show_bug.cgi?id=75808
<rdar://problem/10661025>

Reviewed by Oliver Hunt.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • jit/JITExceptions.cpp: Added.

(JSC::genericThrow):
(JSC::jitThrow):

  • jit/JITExceptions.h: Added.
  • jit/JITStubs.cpp:
  • runtime/JSGlobalData.h:
3:44 PM Changeset in webkit [104414] by benjamin@webkit.org
  • 10 edits
    6 adds in trunk

Valid canonical URLs should have a lowercase hostname
https://bugs.webkit.org/show_bug.cgi?id=75771

Reviewed by Adam Barth.

Source/WebCore:

According to the RFC 3986 (and other browsers implementation), the hostname
of valid canonical URLs should be lowercase.

This patch lowercase the hostname in KURL::parse() similarily to what we
do for the scheme.

Tests: fast/url/host-lowercase-per-scheme.html

fast/url/safari-extension.html

  • platform/KURL.cpp:

(WebCore::isCanonicalHostnameLowercaseForScheme):
(WebCore::KURL::parse):

LayoutTests:

Update the test results for existing tests validating the hostname.

Added the test safari-extension.html for checking regressions of
the safari-extension:// protocol.

Added host-lowercase-per-scheme.html for testing the hostname is
set to lowercase for regognized Internet protocols.

  • fast/url/host-expected.txt:
  • fast/url/host-lowercase-per-scheme-expected.txt: Added.
  • fast/url/host-lowercase-per-scheme.html: Added.
  • fast/url/idna2008-expected.txt:
  • fast/url/ipv4-expected.txt:
  • fast/url/ipv6-expected.txt:
  • fast/url/relative-expected.txt:
  • fast/url/relative-unix-expected.txt:
  • fast/url/safari-extension-expected.txt: Added.
  • fast/url/safari-extension.html: Added.
  • fast/url/standard-url-expected.txt:
  • platform/chromium/fast/url/host-lowercase-per-scheme-expected.txt: Added.
  • platform/chromium/fast/url/safari-extension-expected.txt: Added.
3:28 PM Changeset in webkit [104413] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Categorize bots by ports instead of core/non-core separation
https://bugs.webkit.org/show_bug.cgi?id=75766

Reviewed by Adam Barth.

Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3:15 PM Changeset in webkit [104412] by abarth@webkit.org
  • 10 edits in trunk/Source/WebCore

Rename checkNodeSecurity and allowsAccessFromFrame to have sensible names
https://bugs.webkit.org/show_bug.cgi?id=75796

Reviewed by Sam Weinig.

This patch contains only renames and FIXME comments. No behavior change.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::allowAccessToNode):
(WebCore::allowAccessToFrame):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSHTMLFrameElementCustom.cpp:

(WebCore::allowSettingJavascriptURL):

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::getOwnPropertySlotDelegate):
(WebCore::JSHistory::getOwnPropertyDescriptorDelegate):
(WebCore::JSHistory::putDelegate):
(WebCore::JSHistory::deleteProperty):
(WebCore::JSHistory::getOwnPropertyNames):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::getOwnPropertySlotDelegate):
(WebCore::JSLocation::getOwnPropertyDescriptorDelegate):
(WebCore::JSLocation::putDelegate):
(WebCore::JSLocation::deleteProperty):
(WebCore::JSLocation::getOwnPropertyNames):
(WebCore::JSLocation::toStringFunction):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::canAccessFromCurrentOrigin):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateFunctionCallback):

2:48 PM Changeset in webkit [104411] by abarth@webkit.org
  • 15 edits in trunk/Source/WebCore

Remove deprecated toDynamicFrame and unused [CallWith=DynamicFrame]
https://bugs.webkit.org/show_bug.cgi?id=75795

Reviewed by Eric Seidel.

We've succeeded in removing all the callers fo this function, including
all the uses of CallWith=DynamicFrame in IDL files.

  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallString):

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:
1:59 PM Changeset in webkit [104410] by abarth@webkit.org
  • 14 edits in trunk/Source/WebCore

NeedsUserGestureCheck IDL attribute is no longer used
https://bugs.webkit.org/show_bug.cgi?id=75794

Reviewed by Eric Seidel.

This IDL attribute is no longer used because we use static state to
keep track of the user gesture state. We can delete the code that
supports it.

  • bindings/scripts/CodeGeneratorCPP.pm:
  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/TestObj.idl:
1:44 PM Changeset in webkit [104409] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r103859): WKViews leak
https://bugs.webkit.org/show_bug.cgi?id=75805

The flags changed event monitor added in r103859 was retaining the WKView (as it references
self in the handler block), causing it to leak.

  • UIProcess/API/mac/WKView.mm:

(-[WKView dealloc]): Moved call to remove the flags changed event monitor from here...
(-[WKView viewDidMoveToWindow]): ...to here. Moved call to add the flags changed event
monitor to here from...
(-[WKView initWithFrame:contextRef:pageGroupRef:]): ...here.

1:33 PM Changeset in webkit [104408] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove unused security functions from V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=75797

Reviewed by Eric Seidel.

This functions have no callers. They can be removed.

  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:
  • bindings/v8/specialization/V8BindingState.cpp:
  • bindings/v8/specialization/V8BindingState.h:
1:31 PM Changeset in webkit [104407] by psolanki@apple.com
  • 4 edits in trunk/Source/WebCore

Assertion failure under SharedBuffer::append() when NETWORK_CFDATA_ARRAY_CALLBACK is enabled
https://bugs.webkit.org/show_bug.cgi?id=75656

Reviewed by Darin Adler.

Update the implementation of SubresourceLoader::didReceiveDataArray() to conform to the
refactoring done as part of bug 71149 in r100311.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveData):
(WebCore::SubresourceLoader::errorLoadingResource):

  • loader/SubresourceLoader.h:
  • loader/cf/SubresourceLoaderCF.cpp:

(WebCore::SubresourceLoader::didReceiveDataArray):

1:03 PM Changeset in webkit [104406] by steveblock@google.com
  • 6 edits
    9 deletes in trunk/Source/WebCore

Remove V8-specific Java Bridge code
https://bugs.webkit.org/show_bug.cgi?id=75801

Reviewed by Darin Adler.

Also remove superfluous JSC and V8 guards, as the code is now used only
with JSC.

No new tests, removing dead code only.

  • WebCore.gypi:
  • bridge/jni/JNIUtility.cpp:

(JSC::Bindings::javaTypeFromClassName):
(JSC::Bindings::signatureFromJavaType):
(JSC::Bindings::getJNIField):
(JSC::Bindings::callJNIMethod):

  • bridge/jni/JavaType.h:
  • bridge/jni/jsc/JavaMethodJSC.cpp:

(appendClassName):
(JavaMethod::signature):

  • bridge/jni/v8/JNIUtilityPrivate.cpp: Removed.
  • bridge/jni/v8/JNIUtilityPrivate.h: Removed.
  • bridge/jni/v8/JavaClassV8.h: Removed.
  • bridge/jni/v8/JavaFieldV8.h: Removed.
  • bridge/jni/v8/JavaInstanceV8.h: Removed.
  • bridge/jni/v8/JavaMethodV8.h: Removed.
  • bridge/jni/v8/JavaNPObjectV8.cpp: Removed.
  • bridge/jni/v8/JavaNPObjectV8.h: Removed.
  • bridge/jni/v8/JavaValueV8.h: Removed.
  • bridge/jsc/BridgeJSC.h:
11:35 AM Changeset in webkit [104405] by Csaba Osztrogonác
  • 8 edits
    54 deletes in trunk

Unreviewed, rolling out r104403.
http://trac.webkit.org/changeset/104403
https://bugs.webkit.org/show_bug.cgi?id=75803

It broke all tests on Qt5 (Requested by Ossy_weekend on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-08

Source/WebCore:

  • Target.pri:

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::allowedCompositingTriggers):

Tools:

  • qmake/mkspecs/features/features.prf:

LayoutTests:

  • platform/qt/Skipped:
  • platform/qt/css3/filters/add-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/add-filter-rendering-expected.txt: Removed.
  • platform/qt/css3/filters/crash-filter-change-expected.png: Removed.
  • platform/qt/css3/filters/crash-filter-change-expected.txt: Removed.
  • platform/qt/css3/filters/crash-hw-sw-switch-expected.png: Removed.
  • platform/qt/css3/filters/custom-filter-property-parsing-expected.txt: Removed.
  • platform/qt/css3/filters/custom-filter-property-parsing-invalid-expected.txt: Removed.
  • platform/qt/css3/filters/effect-blur-expected.png: Removed.
  • platform/qt/css3/filters/effect-blur-expected.txt: Removed.
  • platform/qt/css3/filters/effect-brightness-expected.png: Removed.
  • platform/qt/css3/filters/effect-brightness-expected.txt: Removed.
  • platform/qt/css3/filters/effect-contrast-expected.png: Removed.
  • platform/qt/css3/filters/effect-contrast-expected.txt: Removed.
  • platform/qt/css3/filters/effect-drop-shadow-expected.png: Removed.
  • platform/qt/css3/filters/effect-drop-shadow-expected.txt: Removed.
  • platform/qt/css3/filters/effect-grayscale-expected.png: Removed.
  • platform/qt/css3/filters/effect-grayscale-expected.txt: Removed.
  • platform/qt/css3/filters/effect-hue-rotate-expected.png: Removed.
  • platform/qt/css3/filters/effect-hue-rotate-expected.txt: Removed.
  • platform/qt/css3/filters/effect-invert-expected.png: Removed.
  • platform/qt/css3/filters/effect-invert-expected.txt: Removed.
  • platform/qt/css3/filters/effect-opacity-expected.png: Removed.
  • platform/qt/css3/filters/effect-opacity-expected.txt: Removed.
  • platform/qt/css3/filters/effect-saturate-expected.png: Removed.
  • platform/qt/css3/filters/effect-saturate-expected.txt: Removed.
  • platform/qt/css3/filters/effect-sepia-expected.png: Removed.
  • platform/qt/css3/filters/effect-sepia-expected.txt: Removed.
  • platform/qt/css3/filters/filter-animation-expected.png: Removed.
  • platform/qt/css3/filters/filter-animation-expected.txt: Removed.
  • platform/qt/css3/filters/filter-animation-from-none-expected.png: Removed.
  • platform/qt/css3/filters/filter-animation-from-none-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-computed-style-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-expected.png: Removed.
  • platform/qt/css3/filters/filter-property-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-parsing-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-parsing-invalid-expected.txt: Removed.
  • platform/qt/css3/filters/filter-region-expected.png: Removed.
  • platform/qt/css3/filters/filter-region-expected.txt: Removed.
  • platform/qt/css3/filters/filter-repaint-expected.png: Removed.
  • platform/qt/css3/filters/filter-repaint-expected.txt: Removed.
  • platform/qt/css3/filters/filter-with-transform-expected.png: Removed.
  • platform/qt/css3/filters/filter-with-transform-expected.txt: Removed.
  • platform/qt/css3/filters/filtered-inline-expected.png: Removed.
  • platform/qt/css3/filters/filtered-inline-expected.txt: Removed.
  • platform/qt/css3/filters/nested-filter-expected.png: Removed.
  • platform/qt/css3/filters/nested-filter-expected.txt: Removed.
  • platform/qt/css3/filters/nested-filters-expected.png: Removed.
  • platform/qt/css3/filters/nested-filters-expected.txt: Removed.
  • platform/qt/css3/filters/regions-expanding-expected.png: Removed.
  • platform/qt/css3/filters/regions-expanding-expected.txt: Removed.
  • platform/qt/css3/filters/remove-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/remove-filter-rendering-expected.txt: Removed.
  • platform/qt/css3/filters/simple-filter-rendering-expected.png: Removed.
  • platform/qt/css3/filters/simple-filter-rendering-expected.txt: Removed.
11:22 AM Changeset in webkit [104404] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Don't create style selector in Element::recalcStyleIfNeededAfterAttributeChanged if it doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=75802

Rubber-stamped by Andreas Kling.

Element::recalcStyleIfNeededAfterAttributeChanged shouldn't create style selector for attribute
check if it doesn't already exist. We are going to need a full style recalc anyway in that case
and the constructed style selector may get throw out again.

  • dom/Element.cpp:

(WebCore::Element::recalcStyleIfNeededAfterAttributeChanged):

10:05 AM Changeset in webkit [104403] by noam.rosenthal@nokia.com
  • 8 edits
    55 adds in trunk

[Qt] Enable CSS_FILTERS in Qt build
https://bugs.webkit.org/show_bug.cgi?id=75777

Source/WebCore:

Enable CSS_FILTERS and unskip the tests.

Reviewed by Kenneth Rohde Christiansen.

Filter tests are now unskipped for Qt.

  • Target.pri: add missing files to build.

Source/WebKit/qt:

For now, disallow compositing for filters. We will change that trigger when
https://bugs.webkit.org/show_bug.cgi?id=75778 is implemented.

Reviewed by Kenneth Rohde Christiansen.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::allowedCompositingTriggers):

Tools:

Add the CSS_FILTERS feature flag to Qt.

Reviewed by Kenneth Rohde Christiansen.

  • qmake/mkspecs/features/features.prf:

LayoutTests:

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/Skipped: Unskip filter tests that work.
  • platform/qt/css3/filters/*: Added Qt specific results.
8:46 AM Changeset in webkit [104402] by haraken@chromium.org
  • 3 edits
    2 adds in trunk/Tools

Rewrite the CSS parser of prepare-ChangeLog with unittests.
https://bugs.webkit.org/show_bug.cgi?id=75202

Reviewed by David Kilzer.

The current CSS parser can just parse simple CSSes like

foo bar baz {

property1: value;
property2: value;

}

, and cannot parse comments nor a CSS in which a selector and {
appears in different lines. This patch rewrites the CSS parser
(i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
shown in css_unittests.css.

Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css

  • Scripts/prepare-ChangeLog:

(get_selector_line_ranges_for_css):

  • Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.

(element1):
(element2):
(element3):
(element4.p):
(element5.p.q.r.s):
(element6#p):
(element7 element8):
(element9.p element10.q):
(element11#p element12#q):
(element13, element14):
(.p):
(#p):
(.p element15 #q element16.r element17#s):
(element18:target):
(element19):
(element20):
(element21):
(element22):

8:21 AM Changeset in webkit [104401] by haraken@chromium.org
  • 4 edits in trunk/Tools

The Perl parser of prepare-ChangeLog can parse here-documents
https://bugs.webkit.org/show_bug.cgi?id=73208

Reviewed by David Kilzer.

Currently prepare-ChangeLog cannot recognize here-documents in Perl,
which results in wrong subroutine names in ChangeLogs.
With this patch, prepare-ChangeLog can judge whether the line of "}"
is the end of a subroutine or a line inside a here-document.

Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_perl):

  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:

Added test cases for here-documents.
(func7):
(func8):
(func9):
(func10):
(func11):
(func12):
(func13):
(func14):
(func15):
(func16):

8:15 AM Changeset in webkit [104400] by haraken@chromium.org
  • 3 edits
    2 adds in trunk/Tools

Add unittests for the JavaScript parser of prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=75201

Reviewed by David Kilzer.

javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
of prepare-ChangeLog.

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_javascript): Before this patch, a string found was just
omitted from parsing. Thus,

str = "foo"
function func() {
}

was recognized as equivalent to

str = function func() {
}

This patch replaces a string with a dummy identifier 'string_appeared_here'
to tell the parser that a string appeared there.

  • Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.

(func1):
(func2):
(func3):
(func4):
(func5):
(func6):
(func7):
(func8):
(func9):
(func10):
(func11):
(func12):
(funcOverloaded):
(Func1.prototype.get x1):
(Func1.prototype.get x2):
(Func1.prototype.set x1):
(Func1.prototype.set x3):
(Func2.prototype.func13):
(Func2.prototype.func14):
(Func2.prototype.func15):
(func16.func17):
(func16.func18):
(func16.func19):
(func16):

3:45 AM Changeset in webkit [104399] by Antti Koivisto
  • 5 edits
    2 adds in trunk

Source/WebCore: REGRESSION (r104060): Layout Test fast/media/viewport-media-query.html is occasionally failing
https://bugs.webkit.org/show_bug.cgi?id=75633

Reviewed by Andreas Kling.

If something triggers CSSStyleSelector construction very early, before documentElement is known,
it won't be able to resolve viewport-related media queries. In the included test case
the attribute on <html> element triggers the style selector creation. I can't repro
the fast/media/viewport-media-query.html failure but I suspect it is the same issue with
a different mechanism for early CSSStyleSelector construction.

  • Reset style selector on documentElement change.
  • Remove the code for lazy documentElement initialization. It is not an useful optimization, the children of Document rarely change.

Test: fast/media/viewport-media-query-synchronous.html

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::childrenChanged):

  • dom/Document.h:

(WebCore::Document::documentElement):

LayoutTests: Layout Test fast/media/viewport-media-query.html is occasionally failing
https://bugs.webkit.org/show_bug.cgi?id=75633

Reviewed by Andreas Kling.

  • fast/media/viewport-media-query-synchronous-expected.txt: Added.
  • fast/media/viewport-media-query-synchronous.html: Added.
12:06 AM Changeset in webkit [104398] by levin@chromium.org
  • 12 edits
    3 adds in trunk

[chromium] Add layout test support for autosize code in FrameView.
https://bugs.webkit.org/show_bug.cgi?id=73631

Reviewed by Dmitry Titov.

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): Expose the new autoresize method.
(LayoutTestController::reset): Set the autoresize mode back to false.
(LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.

  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.

  • DumpRenderTree/chromium/WebViewHost.h:

LayoutTests:

  • fast/autoresize/basic-expected.txt: Added.
  • fast/autoresize/basic.html: Added. Simple test to verify that autoresizing happens.
  • platform/efl/Skipped: Skipped the new directory since the layout test controller on this platform, doesn't support enableAutoResizeMode.
  • platform/gtk/Skipped: Ditto.
  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
  • platform/wincairo/Skipped: Ditto.
Note: See TracTimeline for information about the timeline view.