Timeline
Jan 14, 2012:
- 7:14 PM Changeset in webkit [105028] by
-
- 8 edits1 move in trunk/Source
HWndDC should be in platform/win instead of wtf.
https://bugs.webkit.org/show_bug.cgi?id=76314
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- JavaScriptCore.gypi:
Source/WebCore:
No new functionality, so no new tests.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- platform/win/HWndDC.h: Renamed from Source/JavaScriptCore/wtf/win/HWndDCWin.h.
I also made the class non-copyable.
(WebCore::HWndDC::HWndDC):
(WebCore::HWndDC::~HWndDC):
(WebCore::HWndDC::operator HDC):
Source/WebKit/chromium:
- src/win/WebScreenInfoFactory.cpp:
(WebKit::WebScreenInfoFactory::screenInfo):
- 5:24 PM Changeset in webkit [105027] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=76339
Take a page from the Gtk and Qt ports and quiet these logs unless they
are explicitly enabled via environment variable.
Patch by Adam Treat <atreat@rim.com> on 2012-01-14
Reviewed by George Staikos.
- platform/blackberry/LoggingBlackBerry.cpp:
(WebCore::initializeLoggingChannelsIfNecessary):
- 4:31 PM Changeset in webkit [105026] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/10696295> Crash in WebProcess at com.apple.CFNetwork: URLCredentialStorage::CreateCurrentPersistentCredentials + 298
Reviewed by Anders Carlsson.
- WebProcess/mac/SecItemShimMethods.mm:
(WebKit::initializeSecItemShim): Removed an early return that was accidentally added in r105008.
- 3:53 PM Changeset in webkit [105025] by
-
- 1 edit6 adds in trunk/LayoutTests
Chromium results for test added by r105021
Unreviewed gardening.
- platform/chromium-linux/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added.
- platform/chromium-win/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
- platform/chromium-win/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added.
- 12:46 PM Changeset in webkit [105024] by
-
- 2 edits in trunk/LayoutTests
Change expected failures from IMAGE+TEXT to TEXT on Mac.
The Mac bots do not check pixel results so displays results suppressed
as IMAGE+TEXT as unexpected failures. Change the suppressions to TEXT.
These results require rebaseline since the changes landed in r103251.
Unreviewed gardening.
- platform/mac/test_expectations.txt:
- 12:31 PM Changeset in webkit [105023] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove reference result added in r105021.
This reference result only works in chromium-linux and qt it seems,
so remove it and allow ports to add port-specific png results.
Unreviewed.
- css2.1/20110323/outline-color-applies-to-008-expected.html: Removed.
- 11:28 AM Changeset in webkit [105022] by
-
- 2 edits in trunk/Tools
[chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
https://bugs.webkit.org/show_bug.cgi?id=76313
Patch by James Robinson <jamesr@chromium.org> on 2012-01-14
Reviewed by Adam Barth.
The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.
- Scripts/run-chromium-webkit-unit-tests:
- 11:13 AM Changeset in webkit [105021] by
-
- 5 edits30 adds in trunk
CSS 2.1 failure: outline-color-applies-to* tests fail
https://bugs.webkit.org/show_bug.cgi?id=71944
Reviewed by Julien Chaffraix.
Source/WebCore:
Paint the outline color for row, row-group, header-group and footer-group
elements.
Tests: css2.1/20110323/outline-color-applies-to-001.htm
css2.1/20110323/outline-color-applies-to-002.htm
css2.1/20110323/outline-color-applies-to-003.htm
css2.1/20110323/outline-color-applies-to-004.htm
css2.1/20110323/outline-color-applies-to-005.htm
css2.1/20110323/outline-color-applies-to-006.htm
css2.1/20110323/outline-color-applies-to-007.htm
css2.1/20110323/outline-color-applies-to-008.htm
css2.1/20110323/outline-color-applies-to-009.htm
css2.1/20110323/outline-color-applies-to-010.htm
(There is no outline-color-applies-to-011.htm in the test suite.)
css2.1/20110323/outline-color-applies-to-012.htm
css2.1/20110323/outline-color-applies-to-013.htm
css2.1/20110323/outline-color-applies-to-014.htm
css2.1/20110323/outline-color-applies-to-015.htm
fast/css/outline-color-self-painting-row.htm
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::paintOutlineForRowIfNeeded): Wrapper function for painting the outline for the row.
This is used by RenderTableSection::paintObject and RenderTableRow::paint
(WebCore::RenderTableRow::paint): For rows with a self-painting layer, paint the outline. Tested by
fast/css/outline-color-self-painting-row.htm.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paint): Paint the outline for header-group, row-group and footer-groups.
(WebCore::RenderTableSection::paintObject): When iterating through the cells paint the outline of rows as required.
Doing it here avoids the need to walk the RenderTableSection's tree separately elsewhere.
LayoutTests:
- css2.1/20110323/outline-color-applies-to-001-expected.html: Added.
- css2.1/20110323/outline-color-applies-to-001.htm: Added.
- css2.1/20110323/outline-color-applies-to-002-expected.html: Added.
- css2.1/20110323/outline-color-applies-to-002.htm: Added.
- css2.1/20110323/outline-color-applies-to-003-expected.html: Added.
- css2.1/20110323/outline-color-applies-to-003.htm: Added.
- css2.1/20110323/outline-color-applies-to-004-expected.html: Added.
- css2.1/20110323/outline-color-applies-to-004.htm: Added.
- css2.1/20110323/outline-color-applies-to-005-expected.html: Added.
- css2.1/20110323/outline-color-applies-to-005.htm: Added.
- css2.1/20110323/outline-color-applies-to-006-expected.html: Added.
- css2.1/20110323/outline-color-applies-to-006.htm: Added.
- css2.1/20110323/outline-color-applies-to-007-expected.html: Added.
- css2.1/20110323/outline-color-applies-to-007.htm: Added.
- css2.1/20110323/outline-color-applies-to-008-expected.html: Added.
- css2.1/20110323/outline-color-applies-to-008.htm: Added.
- css2.1/20110323/outline-color-applies-to-009-expected.html: Added.
- css2.1/20110323/outline-color-applies-to-009.htm: Added.
- css2.1/20110323/outline-color-applies-to-010-expected.html: Added.
- css2.1/20110323/outline-color-applies-to-010.htm: Added.
- css2.1/20110323/outline-color-applies-to-012-expected.html: Added.
- css2.1/20110323/outline-color-applies-to-012.htm: Added.
- css2.1/20110323/outline-color-applies-to-013-expected.html: Added.
- css2.1/20110323/outline-color-applies-to-013.htm: Added.
- css2.1/20110323/outline-color-applies-to-014-expected.html: Added.
- css2.1/20110323/outline-color-applies-to-014.htm: Added.
- css2.1/20110323/outline-color-applies-to-015-expected.html: Added.
- css2.1/20110323/outline-color-applies-to-015.htm: Added.
- fast/css/outline-color-self-painting-row-expected.html: Added.
- fast/css/outline-color-self-painting-row.htm: Added.
- 11:11 AM Changeset in webkit [105020] by
-
- 2 edits1 delete in trunk/Source/WebKit/chromium
[Chromium] Remove WebKit::WebWorker class.
https://bugs.webkit.org/show_bug.cgi?id=76327
Reviewed by Darin Fisher.
- public/WebWorker.h: Removed.
- src/WebWorkerClientImpl.cpp:
- 7:51 AM Changeset in webkit [105019] by
-
- 3 edits2 adds in trunk
Unmatched transparency layer begin/end on a filtered element with an opacity ancestor
https://bugs.webkit.org/show_bug.cgi?id=76329
Source/WebCore:
Reviewed by Dan Bernstein.
When doing a paint with painting disabled on the GraphicsContext, as we do
for updating control tints, or computing text rectangles on Find, do not
apply filter effects. This is both a performance gain, and fixes an issue
with mismatched begin/end transparency layers.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
Reviewed by Dan Bernstein.
Manual test with a filtered element as a descendant of an element with
opacity. Doing a Find is necessary to exercise the test.
- ManualTests/filters/opacity-above-filter.html: Added.
- 5:43 AM Changeset in webkit [105018] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r105017.
http://trac.webkit.org/changeset/105017
https://bugs.webkit.org/show_bug.cgi?id=76333
broke the build (Requested by philn-tp on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-14
- gtk/jhbuild.modules:
- 5:23 AM Changeset in webkit [105017] by
-
- 2 edits in trunk/Tools
[GTK] Include gtk+3 in the jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=76284
Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-01-14
Reviewed by Philippe Normand.
- gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
Jan 13, 2012:
- 8:41 PM Changeset in webkit [105016] by
-
- 2 edits in trunk/LayoutTests
Skip test that started failing after r105015.
- platform/qt/Skipped:
- 7:03 PM Changeset in webkit [105015] by
-
- 26 edits in trunk
Implement flex-align
https://bugs.webkit.org/show_bug.cgi?id=75782
Reviewed by Tony Chang.
Source/WebCore:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Intentially gets computed style for flex-item-align:auto wrong.
Will fix this in a followup patch.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
- rendering/RenderFlexibleBox.cpp:
(WebCore::flexAlignForChild):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::flexAlign):
(WebCore::RenderStyleBitfields::setFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexItemAlign):
- rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
- rendering/style/StyleFlexibleBoxData.h:
LayoutTests:
- css3/flexbox/css-properties-expected.txt:
- css3/flexbox/flex-align-expected.txt:
- css3/flexbox/flex-align.html:
- css3/flexbox/script-tests/css-properties.js:
- fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 6:47 PM Changeset in webkit [105014] by
-
- 2 edits in trunk
GCC compiler version is not detected properly for QNX qcc variant
https://bugs.webkit.org/show_bug.cgi?id=76288
Reviewed by Rob Buis.
Provide an alternative way of getting the compiler version for GCC variants
that don't support -dumpversion (such as qcc).
- Source/cmake/WebKitHelpers.cmake:
- 5:13 PM Changeset in webkit [105013] by
-
- 2 edits in trunk/Source/WebCore
[Windows, WinCairo] Build correction after r104919.
- WebCore.vcproj/WebCore.vcproj: Exclude ShadowContentSelectorQuery.cpp from the build, since it is built as part of DOMAllInOne.cpp.
- 4:42 PM Changeset in webkit [105012] by
-
- 5 edits in branches/safari-534.54-branch/Source
Versioning.
- 4:28 PM Changeset in webkit [105011] by
-
- 5 edits in trunk
Pointer Lock: Change isLocked() from operator to attribute isLocked
https://bugs.webkit.org/show_bug.cgi?id=76311
Reviewed by Adam Barth.
Source/WebCore:
This patch implements the recent Mouse Lock Specification update
changing navigator.pointer.isLocked() to .isLocked.
Test pointer-lock/pointer-lock-api.html updated to new spec.
- page/PointerLock.idl:
LayoutTests:
- pointer-lock/pointer-lock-api-expected.txt:
- pointer-lock/pointer-lock-api.html:
- 4:25 PM Changeset in webkit [105010] by
-
- 1 copy in tags/Safari-534.54.5
New tag.
- 4:13 PM Changeset in webkit [105009] by
-
- 1 edit4 adds in trunk/LayoutTests
Add a test for cross-origin XMLHttpRequest and CORS (which doesn't work currently)
https://bugs.webkit.org/show_bug.cgi?id=57600
Reviewed by Adam Barth.
- http/tests/security/resources/cors-redirect.php: Added.
- http/tests/security/resources/empty.html: Added.
- http/tests/security/xhr-cors-redirect-expected.txt: Added.
- http/tests/security/xhr-cors-redirect.html: Added.
- 4:08 PM Changeset in webkit [105008] by
-
- 4 edits in trunk/Source/WebKit2
Delay updating the root compositing layer if the layer tree state is frozen
https://bugs.webkit.org/show_bug.cgi?id=76316
Reviewed by Dan Bernstein.
When the layer tree is frozen, stash the root layer in m_pendingRootCompositingLayer and set it in flushLayers.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
- 4:01 PM Changeset in webkit [105007] by
-
- 5 edits in trunk
noteOn, noteGrainOn and noteOff idl should take doubles
https://bugs.webkit.org/show_bug.cgi?id=76073
Patch by Raymond Toy <Raymond Toy> on 2012-01-13
Reviewed by Adam Barth.
Source/WebCore:
Existing audiobuffersource-playbackrate and gain tests cover the
noteOn and noteOff changes.
- webaudio/AudioBufferSourceNode.idl: noteOn, noteGrainOn, and
noteOff take doubles.
LayoutTests:
- webaudio/audiobuffersource-playbackrate-expected.wav: Updated
- webaudio/gain-expected.wav: Updated
- 3:58 PM Changeset in webkit [105006] by
-
- 10 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=71230
Clicking where the overlay scroll track would be should not scroll the page
-and corresponding-
<rdar://problem/9585424>
Reviewed by Alexey Proskuryakov.
These new functions indicate whether the scrollbar should participate in hit
testing. Non-overlay scrollbars always should, so they return true. Overlay
scrollbars consult the animator, which checks the current alpha.
- platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::shouldScrollbarParticipateInHitTesting):
- platform/Scrollbar.cpp:
(WebCore::Scrollbar:: shouldParticipateInHitTesting):
- platform/Scrollbar.h:
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac:: shouldScrollbarParticipateInHitTesting):
In these hit-testing functions, only hit-test when the scrollbar should
participate.
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollbarAtPoint):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::nodeAtPoint):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestOverflowControls):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::isPointInOverflowControl):
- 3:56 PM Changeset in webkit [105005] by
-
- 5 edits in trunk
REGRESSION: svg/custom/use-instanceRoot-event-listeners.xhtml & svg/custom/pointer-events-invalid-fill.svg broken on the Bots
https://bugs.webkit.org/show_bug.cgi?id=76254
Reviewed by Anders Carlsson.
Source/WebCore:
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::beginLoadTimerFired): Added a call to
CachedResourceLoader::loadDone() after decrementing the request count. This allows the
frame loader to see that the request count is zero and dispatch didFinishLoad.
LayoutTests:
- svg/custom/pointer-events-invalid-fill.svg: Force layout before sending a mouse event.
Otherwise, the WebHTMLView may have zero size, causing the hit test in
-[EventSendingController mouseMoveToX:Y:] to yield the clip view and the event to go nowhere.
- svg/custom/resources/use-instanceRoot-event-listeners.js: Ditto.
- 3:52 PM Changeset in webkit [105004] by
-
- 4 edits in trunk/Source/WebCore
WebAudio: Optimize calculateNormalizationScale().
https://bugs.webkit.org/show_bug.cgi?id=74372
Reviewed by Eric Carlson.
No new tests; optimization of existing code, so covered by existing test cases.
- platform/audio/Reverb.cpp:
(WebCore::calculateNormalizationScale): Replace implementation with optimized vector
math operation.
(WebCore::Reverb::Reverb):
- platform/audio/VectorMath.cpp:
(WebCore::VectorMath::vsvesq): Vector math operation for squared sum of elements.
- platform/audio/VectorMath.h:
- 3:40 PM Changeset in webkit [105003] by
-
- 2 edits in trunk/Source/WebCore
Remove a unused variable.
https://bugs.webkit.org/show_bug.cgi?id=76307
Reviewed by James Robinson.
- platform/mac/ScrollElasticityController.mm:
(WebCore::ScrollElasticityController::snapRubberBandTimerFired):
- 3:39 PM Changeset in webkit [105002] by
-
- 3 edits2 copies in branches/safari-534.54-branch
Merged r104352.
- 3:35 PM Changeset in webkit [105001] by
-
- 2 edits in trunk/Tools
Remove --dry-run support from webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=76300
Reviewed by Dirk Pranke.
This is the rest of the patch from Bug 76300. I landed it separtely
because main.py had some stray conflict markers that I needed to clean
up first.
- Scripts/webkitpy/test/main.py:
(Tester.parse_args):
(Tester._run_tests):
- 3:32 PM Changeset in webkit [105000] by
-
- 4 edits in trunk
Source/WebCore: Revert most of the multipart changes in
http://trac.webkit.org/changeset/104756.
https://bugs.webkit.org/show_bug.cgi?id=76297
Reviewed by Alexey Proskuryakov.
http/tests/multipart/invalid-image-data.html
should stop asserting on chromium win dbg.
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didReceiveData):
(WebCore::SubresourceLoader::sendDataToResource):
LayoutTests: http/tests/multipart/invalid-image-data.html should no longer
be crashing on chromium win dbg.
https://bugs.webkit.org/show_bug.cgi?id=76297
Reviewed by Alexey Proskuryakov.
- platform/chromium/test_expectations.txt:
- 3:31 PM Changeset in webkit [104999] by
-
- 2 edits in trunk/Tools
test-webkitpy does not run
https://bugs.webkit.org/show_bug.cgi?id=76318
Unreviewed.
Looks like some conflict markers got left in the file.
- Scripts/webkitpy/test/main.py:
(Tester.run):
- 3:28 PM Changeset in webkit [104998] by
-
- 7 edits in trunk/Tools
Remove --dry-run support from webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=76300
Reviewed by Dirk Pranke.
We don't use this functionality for anything, and it doesn't really
work. Someone in #webkit tried using it and and got sad/confused. We
should just remove it.
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.push_local_commits_to_server):
- Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.init):
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(_shared_test_commit_with_message):
(GitSVNTest.test_commit_text_parsing):
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.commit_with_message):
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.init):
(Bugzilla.quips):
(Bugzilla.authenticate):
(Bugzilla.add_attachment_to_bug):
(Bugzilla.add_patch_to_bug):
(Bugzilla.create_bug):
(Bugzilla.clear_attachment_flags):
(Bugzilla.set_flag_on_attachment):
(Bugzilla.obsolete_attachment):
(Bugzilla.add_cc_to_bug):
(Bugzilla.post_comment_to_bug):
(Bugzilla.close_bug_as_fixed):
(Bugzilla.reassign_bug):
(reopen_bug):
- Scripts/webkitpy/test/main.py:
(Tester.parse_args):
(Tester.run_tests):
- 3:16 PM Changeset in webkit [104997] by
-
- 14 edits in branches/safari-534.54-branch
Merged r104269.
- 3:13 PM Changeset in webkit [104996] by
-
- 4 edits2 copies in branches/safari-534.54-branch
Merged r104239.
- 2:58 PM Changeset in webkit [104995] by
-
- 5 edits in trunk
check-webkit-style: should encourage the use of Own* classes for Windows DC.
https://bugs.webkit.org/show_bug.cgi?id=76227
Reviewed by Dirk Pranke.
Source/JavaScriptCore:
- wtf/win/HWndDCWin.h:
(WTF::HwndDC::HwndDC): Add a way to do GetDCEx.
There are no users, but I want to catch this in check-webkit-style
and tell any users to use HwndDC to avoid leaks.
Tools:
- Scripts/webkitpy/style/checkers/cpp.py:
(check_for_leaky_patterns): The new check.
(process_line): Added a call to the new check.
(CppChecker): Added the new error type.
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTestBase):
(CppStyleTestBase.perform_leaky_pattern_check):
The check for only leaky pattern errors.
(LeakyPatternTest): Test cases.
- 2:52 PM Changeset in webkit [104994] by
-
- 5 edits in trunk/Source
Versioning.
- 2:42 PM Changeset in webkit [104993] by
-
- 9 edits in trunk/Source/WebCore
WebAudio: Use float instead of double values for gain operations.
https://bugs.webkit.org/show_bug.cgi?id=74345
Reviewed by Sam Weinig.
No new tests; optimization of existing code, so covered by existing test cases.
The following functions now take or operate on floats instead of doubles:
(WebCore::AudioBus::scale):
(WebCore::AudioBus::processWithGainFrom):
(WebCore::AudioBus::copyWithGainFrom):
(WebCore::AudioBus::sumWithGainFrom):
- platform/audio/AudioBus.h:
(WebCore::AudioBus::setGain):
(WebCore::AudioBus::gain):
- platform/audio/AudioChannel.cpp:
(WebCore::AudioChannel::scale):
- platform/audio/AudioChannel.h:
- webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::process):
- webaudio/AudioBufferSourceNode.h:
- webaudio/AudioGainNode.h:
- webaudio/AudioPannerNode.h:
- 2:42 PM Changeset in webkit [104992] by
-
- 3 edits in branches/safari-534.54-branch/Source/JavaScriptCore
Merged r104119.
- 2:38 PM Changeset in webkit [104991] by
-
- 2 edits in trunk/Source/WebCore
Don't use pending activity notification in IntentRequest
https://bugs.webkit.org/show_bug.cgi?id=76302
Patch by Greg Billock <gbillock@google.com> on 2012-01-13
Reviewed by Adam Barth.
- Modules/intents/IntentRequest.cpp:
(WebCore::IntentRequest::IntentRequest):
(WebCore::IntentRequest::postResult):
(WebCore::IntentRequest::postFailure):
- 2:34 PM Changeset in webkit [104990] by
-
- 2 edits in branches/safari-534.54-branch/Source/JavaScriptCore
Merged r104094.
- 2:29 PM Changeset in webkit [104989] by
-
- 6 edits3 copies in branches/safari-534.54-branch
Merged r104086.
- 2:20 PM Changeset in webkit [104988] by
-
- 3 edits12 copies in branches/safari-534.54-branch
Merged r103981.
- 2:18 PM Changeset in webkit [104987] by
-
- 4 edits3 adds in trunk
EQUALPOWER panner incorrectly computes gain
https://bugs.webkit.org/show_bug.cgi?id=75767
Source/WebCore:
Patch by Raymond Toy <Raymond Toy> on 2012-01-13
Reviewed by Kenneth Russell.
Layout test added.
- platform/audio/EqualPowerPanner.cpp:
(WebCore::EqualPowerPanner::pan): Correct the formula.
LayoutTests:
Patch by Raymond Toy <rtoy@chromium.org> on 2012-01-13
Reviewed by Kenneth Russell.
- webaudio/panner-equalpower.html: Added.
- webaudio/panner-equalpower-expected.txt: Added.
- webaudio/resources/panner-model-testing.js: Added.
- webaudio/resources/audio-testing.js:
(createImpulseBuffer): New common utility function.
- 2:15 PM Changeset in webkit [104986] by
-
- 3 edits in trunk/Source/WebKit2
Implement TiledCoreAnimationDrawingArea::setLayerTreeStateIsFrozen
https://bugs.webkit.org/show_bug.cgi?id=76308
Reviewed by Sam Weinig.
Keep track of whether the layer tree state is frozen and suspend/resume the layer flush scheduler accordingly.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::setLayerTreeStateIsFrozen):
(WebKit::TiledCoreAnimationDrawingArea::layerTreeStateIsFrozen):
(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerSync):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
- 2:00 PM Changeset in webkit [104985] by
-
- 26 edits in trunk
Unreviewed, rolling out r104972.
http://trac.webkit.org/changeset/104972
https://bugs.webkit.org/show_bug.cgi?id=75782
Broke some tests
Source/WebCore:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::initialFlexItemAlign):
- rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
- rendering/style/StyleFlexibleBoxData.h:
LayoutTests:
- css3/flexbox/css-properties-expected.txt:
- css3/flexbox/flex-align-expected.txt:
- css3/flexbox/flex-align.html:
- css3/flexbox/script-tests/css-properties.js:
- fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 1:39 PM Changeset in webkit [104984] by
-
- 2 edits in branches/safari-534.54-branch/Source/WebCore
Rollout 99999 (104249).
- 1:38 PM Changeset in webkit [104983] by
-
- 2 edits in trunk/Source/WebKit2
Disable implicit animations when setting the root compositing layer
https://bugs.webkit.org/show_bug.cgi?id=76304
Reviewed by Sam Weinig.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
- 1:31 PM Changeset in webkit [104982] by
-
- 1 edit in trunk/Tools/ChangeLog
fix changelog
- 1:24 PM Changeset in webkit [104981] by
-
- 2 edits in trunk/Source
Unreviewed build fix for Qt SnowLeopard build bot.
This is a workaround for the moment.
- wtf/Platform.h:
- 1:23 PM Changeset in webkit [104980] by
-
- 4 edits in trunk/Tools
test-webkitpy: should support classes and individual test names as well as modules
https://bugs.webkit.org/show_bug.cgi?id=76233
Reviewed by Adam Barth.
The default unittest.main() supports a list of individual
TestCase classes or individual tests as well as modules. This
change adds support for the same to test-webkitpy, so now you
can say
% test-wekbitpy webkitpy.test.cat_unittest.CatTest
and
% test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic
in addition to
% test-wekbitpy webkitpy.test.cat_unittest
- Scripts/test-webkitpy:
- Scripts/webkitpy/test/cat_unittest.py:
- Scripts/webkitpy/test/main.py:
(Tester.parse_args):
(Tester.run):
(Tester):
(Tester._find_modules):
(Tester._exclude):
(Tester._run_tests):
(Tester._is_module):
(Tester._log_exception):
- 1:23 PM Changeset in webkit [104979] by
-
- 9 edits in branches/subpixellayout/Source/WebCore
Windows build fixes for WebCore.
- 1:20 PM Changeset in webkit [104978] by
-
- 4 edits in trunk/Source/WebCore
-[WebTileCacheLayer setNeedsDisplay] doesn't trigger invalidation
https://bugs.webkit.org/show_bug.cgi?id=76299
Reviewed by Simon Fraser.
Override -[WebTileCacheLayer setNeedsDisplay] and call TileCache::setNeedsDisplay from there,
instead of ending up with a huge rectangle in TileCache::setNeedsDisplayInRect which causes our
tile computation logic to fail due to integer overflow when converting from CGFloats to ints.
- platform/graphics/ca/mac/TileCache.h:
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setNeedsDisplay):
- platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer setNeedsDisplay]):
- 1:16 PM Changeset in webkit [104977] by
-
- 3 edits in trunk/Tools
test-webkitpy: should support classes and individual test names as well as modules
https://bugs.webkit.org/show_bug.cgi?id=76233
Reviewed by Adam Barth.
The default unittest.main() supports a list of individual
TestCase classes or individual tests as well as modules. This
change adds support for the same to test-webkitpy, so now you
can say
% test-wekbitpy webkitpy.test.cat_unittest.CatTest
and
% test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic
in addition to
% test-wekbitpy webkitpy.test.cat_unittest
- Scripts/test-webkitpy:
- Scripts/webkitpy/test/cat_unittest.py:
- Scripts/webkitpy/test/main.py:
(Tester.parse_args):
(Tester.run):
(Tester):
(Tester._find_modules):
(Tester._exclude):
(Tester._run_tests):
(Tester._is_module):
(Tester._log_exception):
- 1:16 PM Changeset in webkit [104976] by
-
- 2 edits in trunk/Source/JavaScriptCore
Header file is missing header guard.
Reviewed by Dirk Pranke.
- wtf/win/HWndDCWin.h: Added the guards.
- 12:59 PM Changeset in webkit [104975] by
-
- 2 edits in trunk/Tools
test-webkitpy: add basic code coverage support
https://bugs.webkit.org/show_bug.cgi?id=76201
Reviewed by Adam Barth.
This test adds basic code coverage support to test-webkitpy; if
you pass the -c flag, we will generate a new coverage file. We
can start simply with this and add more features as necessary.
This patch requires coverage to be already installed on the
machine. I am not auto-installing this for now.
- Scripts/webkitpy/test/main.py:
(Tester.parse_args):
(Tester.run_tests):
- 12:54 PM Changeset in webkit [104974] by
-
- 2 edits in trunk/Tools
StatusBubbleTest.test_build_bubble is failing
https://bugs.webkit.org/show_bug.cgi?id=76222
Reviewed by Adam Barth.
- QueueStatusServer/handlers/statusbubble_unittest.py:
(StatusBubbleTest.test_build_bubble):
- 12:53 PM Changeset in webkit [104973] by
-
- 1 edit21 adds in trunk/LayoutTests
Add new baselines for various compositing tests which didn't have Mac results.
- platform/mac/compositing/animation/busy-indicator-expected.png: Added.
- platform/mac/compositing/animation/busy-indicator-expected.txt: Added.
- platform/mac/compositing/flat-with-transformed-child-expected.png: Added.
- platform/mac/compositing/flat-with-transformed-child-expected.txt: Added.
- platform/mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
- platform/mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.txt: Added.
- platform/mac/compositing/geometry/fixed-position-composited-page-scale-expected.png: Added.
- platform/mac/compositing/geometry/fixed-position-composited-page-scale-expected.txt: Added.
- platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
- platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.txt: Added.
- platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
- platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.txt: Added.
- platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
- platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.txt: Added.
- platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
- platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.txt: Added.
- platform/mac/compositing/repaint/same-size-invalidation-expected.png: Added.
- platform/mac/compositing/repaint/same-size-invalidation-expected.txt: Added.
- platform/mac/compositing/scaling/tiled-layer-recursion-expected.png: Added.
- platform/mac/compositing/scaling/tiled-layer-recursion-expected.txt: Added.
- 12:43 PM Changeset in webkit [104972] by
-
- 26 edits in trunk
Implement flex-align
https://bugs.webkit.org/show_bug.cgi?id=75782
Reviewed by Tony Chang.
Source/WebCore:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Not 100% sure about this, but I think the computed value of
flex-item-align needs to take the parent's flex-align into
account for computed auto values.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
- rendering/RenderFlexibleBox.cpp:
(WebCore::flexAlign):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::flexAlign):
(WebCore::RenderStyleBitfields::setFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexItemAlign):
- rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
- rendering/style/StyleFlexibleBoxData.h:
LayoutTests:
- css3/flexbox/css-properties-expected.txt:
- css3/flexbox/flex-align-expected.txt:
- css3/flexbox/flex-align.html:
- css3/flexbox/script-tests/css-properties.js:
- fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 12:34 PM Changeset in webkit [104971] by
-
- 1 edit3 adds in trunk/LayoutTests
[chromium] Update chromium image baselines for cross-fade-invalidation
- platform/chromium-linux/css3/images/cross-fade-invalidation-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/images/cross-fade-invalidation-expected.png: Added.
- platform/chromium-win/css3/images/cross-fade-invalidation-expected.png: Added.
- 12:31 PM Changeset in webkit [104970] by
-
- 2 edits in trunk/Source/JavaScriptCore
Eval in strict mode does not need dynamic checks
https://bugs.webkit.org/show_bug.cgi?id=76286
Patch by Andy Wingo <wingo@igalia.com> on 2012-01-13
Reviewed by Oliver Hunt.
- runtime/JSActivation.cpp (JSC::JSActivation::JSActivation):
Eval in strict mode cannot introduce variables, so it not impose
the need for dynamic checks.
- 12:13 PM Changeset in webkit [104969] by
-
- 2 edits in trunk/LayoutTests
Fix an obviously incorrect expected result image.
Patch by Simon Fraser <Simon Fraser> on 2012-01-13
- platform/mac/css3/images/cross-fade-invalidation-expected.png:
- 11:59 AM Changeset in webkit [104968] by
-
- 2 edits in trunk/LayoutTests
Fix an obviously incorrect expected result image.
- platform/mac/css3/images/cross-fade-invalidation-expected.png:
- 11:55 AM Changeset in webkit [104967] by
-
- 4 edits in trunk/Tools
nrwt should use multiple http shards
https://bugs.webkit.org/show_bug.cgi?id=75958
Add --max-locked-shards option to the nrwt for manual set
the maximum number of the locked shards
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._max_locked_shards):
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ShardingTests.get_shards):
(ShardingTests.test_multiple_locked_shards):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 11:45 AM Changeset in webkit [104966] by
-
- 2 edits in trunk/Source/WebCore
Rename GraphicsContext* argument in various RenderLayer methods
https://bugs.webkit.org/show_bug.cgi?id=76283
Reviewed by James Robinson/Anders Carlsson.
Rename the GraphicsContext* parameter "p" in various RenderLayer
methods to "context". "p" was a historical name from when it was
called Painter.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::beginTransparencyLayers):
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::paintOverlayScrollbars):
(WebCore::RenderLayer::restoreClip):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContentsAndReflection):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintList):
- 11:42 AM Changeset in webkit [104965] by
-
- 14 edits in trunk/Source/WebCore
[CSSRegions]Add back region style code removed in r104036
https://bugs.webkit.org/show_bug.cgi?id=76064
Reviewed by David Hyatt.
No new tests. The region style tests are still skipped. A follow up patch will enable
both region style for background-color and region style tests.
- WebCore.exp.in:
- css/CSSStyleSelector.cpp:
(WebCore::RuleData::useInRegionStyle):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::initForRegionStyling):
(WebCore::CSSStyleSelector::initRegionRules):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::addToRuleSet):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::isValidRegionStyleProperty):
(WebCore::CSSStyleSelector::applyProperty):
- css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::setRegionForStyling):
(WebCore::CSSStyleSelector::regionForStyling):
(WebCore::CSSStyleSelector::applyPropertyToRegionStyle):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::clearRenderObjectCustomStyle):
(WebCore::RenderFlowThread::setRegionRangeForBox):
- rendering/RenderFlowThread.h:
- rendering/RenderLayer.cpp:
(WebCore::CurrentRenderRegionMaintainer::CurrentRenderRegionMaintainer):
(WebCore::CurrentRenderRegionMaintainer::~CurrentRenderRegionMaintainer):
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::hitTest):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleInRegion):
- rendering/RenderObject.h:
(WebCore::RenderObject::canHaveRegionStyle):
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::renderObjectRegionStyle):
(WebCore::RenderRegion::computeStyleInRegion):
(WebCore::RenderRegion::clearObjectStyleInRegion):
- rendering/RenderRegion.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
- rendering/RenderView.h:
(WebCore::RenderView::currentRenderRegion):
(WebCore::RenderView::setCurrentRenderRegion):
- 11:42 AM Changeset in webkit [104964] by
-
- 5 edits in branches/safari-534.54-branch
Merged r103728.
- 11:41 AM Changeset in webkit [104963] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix; added project.pbxproj changes lost in r104954.
https://bugs.webkit.org/show_bug.cgi?id=75906
- WebCore.xcodeproj/project.pbxproj:
- 11:40 AM Changeset in webkit [104962] by
-
- 7 edits6 copies in branches/safari-534.54-branch
Merge 103637.
- 11:26 AM Changeset in webkit [104961] by
-
- 8 edits2 adds in trunk/Source
TextureMapper: Extract layer transform logic to a LayerTransform class.
https://bugs.webkit.org/show_bug.cgi?id=76291
Reviewed by Noam Rosenthal.
Source/WebCore:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- platform/graphics/texmap/LayerTransform.cpp: Added.
(WebCore::LayerTransform::LayerTransform):
(WebCore::LayerTransform::setPosition):
(WebCore::LayerTransform::setSize):
(WebCore::LayerTransform::setAnchorPoint):
(WebCore::LayerTransform::setFlattening):
(WebCore::LayerTransform::setLocalTransform):
(WebCore::LayerTransform::setChildrenTransform):
(WebCore::LayerTransform::combined):
(WebCore::LayerTransform::combinedForChildren):
(WebCore::LayerTransform::combineTransforms):
(WebCore::LayerTransform::combineTransformsForChildren):
- platform/graphics/texmap/LayerTransform.h: Added.
- platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::setTransform):
(WebCore::TextureMapperNode::computeTransformsRecursive):
(WebCore::TextureMapperNode::collectVisibleContentsRects):
(WebCore::TextureMapperNode::paintSelf):
(WebCore::TextureMapperNode::compareGraphicsLayersZValue):
(WebCore::TextureMapperNode::paintSelfAndChildren):
(WebCore::TextureMapperNode::paintReflection):
(WebCore::TextureMapperNode::syncCompositingStateSelf):
- platform/graphics/texmap/TextureMapperNode.h:
(WebCore::TextureMapperNode::TextureMapperNode):
Source/WebKit2:
Move the paint call before the visible rect collection to make sure that
transforms are computed. This will increase the delay for the visible rects
to get to the WebProcess until we move this calculation out of the UI Process.
This fixes an assert triggering in LayerTransform::combineTransforms.
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
- 11:24 AM Changeset in webkit [104960] by
-
- 3 edits2 adds in trunk/Source/WebKit/efl
[EFL] SecurityPolicy whitelist interface should be exposed to EWebKit
https://bugs.webkit.org/show_bug.cgi?id=76082
Patch by Leandro Pereira <leandro@profusion.mobi> on 2012-01-13
Reviewed by Andreas Kling.
- CMakeListsEfl.txt: Added reference to ewk_security_policy.{cpp,h}.
- ewk/EWebKit.h: Include ewk_security_policy.h.
- ewk/ewk_security_policy.cpp: Added.
(ewk_security_policy_whitelist_origin_add): Implemented thin layer around SecurityPolicy::addOriginAccessWhitelistEntry().
(ewk_security_policy_whitelist_origin_del): Implemented thin layer around SecurityPolicy::removeOriginAccessWhitelistEntry().
(ewk_security_policy_whitelist_origin_reset): Implemented thin layer around SecurityPolicy::resetOriginAccessWhitelists().
- ewk/ewk_security_policy.h: Added.
- 11:19 AM Changeset in webkit [104959] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, build fix for unused argument warning after r104954.
https://bugs.webkit.org/show_bug.cgi?id=75906
Also fixed up somebody's bad merge in Source/WebCore/ChangeLog.
- html/canvas/WebGLObject.cpp:
(WebCore::WebGLObject::WebGLObject):
- 11:19 AM Changeset in webkit [104958] by
-
- 2 edits in trunk/Source/WebKit2
[WinCairo] Build correction.
- Shared/WebGraphicsContext.h: Use proper include path for RefPtrCairo.h.
- 11:15 AM Changeset in webkit [104957] by
-
- 2 edits2 adds in trunk/LayoutTests
[chromium] Update expectations
- platform/chromium-linux/compositing/visibility/visibility-simple-video-layer-expected.png: Added.
- platform/chromium-win/compositing/visibility/visibility-simple-video-layer-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 11:06 AM Changeset in webkit [104956] by
-
- 2 edits in trunk/LayoutTests
[chromium] Update a few expectations
- platform/chromium/test_expectations.txt:
- 11:05 AM Changeset in webkit [104955] by
-
- 2 edits in trunk/Tools
prepare-ChangeLog: Look for a text editor in a few more variables.
https://bugs.webkit.org/show_bug.cgi?id=76289
Reviewed by Ryosuke Niwa.
A text editor was looked for only in the CHANGE_LOG_EDITOR and
CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
to the OS X-specific open(1) command.
As there does not seem to be a common way of looking for a text editor
among the scripts in Tools/Scripts right now, just look at $VISUAL and
$EDITOR (set much more often than the other variables in Unix systems)
before falling back to open(1).
- Scripts/prepare-ChangeLog:
(openChangeLogs):
- 11:02 AM Changeset in webkit [104954] by
-
- 24 edits5 copies1 add in trunk
Add WebGLContextGroup as step toward sharing WebGL resources
https://bugs.webkit.org/show_bug.cgi?id=75906
The WebGL Working Group will soon add the ability to share
WebGL resources among WebGL contexts. This is the necessary
prep work. NO API changes.
Added WebGLSharedObject for objects that are shared vs
WebGLContextObject for objects that are not.
Patch by Gregg Tavares <gman@google.com> on 2012-01-13
Reviewed by Kenneth Russell.
No new tests. No change in behavior.
- GNUmakefile.list.am:
- WebCore.gypi:
- html/canvas/OESVertexArrayObject.cpp:
(WebCore::OESVertexArrayObject::createVertexArrayOES):
(WebCore::OESVertexArrayObject::deleteVertexArrayOES):
(WebCore::OESVertexArrayObject::isVertexArrayOES):
(WebCore::OESVertexArrayObject::bindVertexArrayOES):
- html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::WebGLBuffer):
(WebCore::WebGLBuffer::~WebGLBuffer):
(WebCore::WebGLBuffer::deleteObjectImpl):
- html/canvas/WebGLBuffer.h:
- html/canvas/WebGLContextGroup.cpp: Added.
(WebCore::WebGLContextGroup::create):
(WebCore::WebGLContextGroup::WebGLContextGroup):
(WebCore::WebGLContextGroup::~WebGLContextGroup):
(WebCore::WebGLContextGroup::getAGraphicsContext3D):
(WebCore::WebGLContextGroup::addContext):
(WebCore::WebGLContextGroup::removeContext):
(WebCore::WebGLContextGroup::removeObject):
(WebCore::WebGLContextGroup::addObject):
(WebCore::WebGLContextGroup::detachAndRemoveAllObjects):
(WebCore::WebGLContextGroup::loseContextGroup):
- html/canvas/WebGLContextGroup.h: Copied from Source/WebCore/html/canvas/WebGLShader.h.
- html/canvas/WebGLContextObject.cpp: Copied from Source/WebCore/html/canvas/WebGLShader.cpp.
(WebCore::WebGLContextObject::WebGLContextObject):
(WebCore::WebGLContextObject::~WebGLContextObject):
(WebCore::WebGLContextObject::detachContext):
(WebCore::WebGLContextObject::getAGraphicsContext3D):
- html/canvas/WebGLContextObject.h: Copied from Source/WebCore/html/canvas/WebGLShader.h.
(WebCore::WebGLContextObject::context):
(WebCore::WebGLContextObject::validate):
(WebCore::WebGLContextObject::hasGroupOrContext):
- html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::WebGLFramebuffer):
(WebCore::WebGLFramebuffer::~WebGLFramebuffer):
(WebCore::WebGLFramebuffer::setAttachmentForBoundFramebuffer):
(WebCore::WebGLFramebuffer::getAttachment):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
(WebCore::WebGLFramebuffer::checkStatus):
(WebCore::WebGLFramebuffer::onAccess):
(WebCore::WebGLFramebuffer::deleteObjectImpl):
(WebCore::WebGLFramebuffer::initializeRenderbuffers):
- html/canvas/WebGLFramebuffer.h:
- html/canvas/WebGLObject.cpp:
(WebCore::WebGLObject::WebGLObject):
(WebCore::WebGLObject::~WebGLObject):
(WebCore::WebGLObject::deleteObject):
(WebCore::WebGLObject::detach):
(WebCore::WebGLObject::onDetached):
- html/canvas/WebGLObject.h:
- html/canvas/WebGLProgram.cpp:
(WebCore::WebGLProgram::WebGLProgram):
(WebCore::WebGLProgram::~WebGLProgram):
(WebCore::WebGLProgram::deleteObjectImpl):
(WebCore::WebGLProgram::cacheActiveAttribLocations):
- html/canvas/WebGLProgram.h:
- html/canvas/WebGLRenderbuffer.cpp:
(WebCore::WebGLRenderbuffer::~WebGLRenderbuffer):
(WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
(WebCore::WebGLRenderbuffer::deleteObjectImpl):
- html/canvas/WebGLRenderbuffer.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::~WebGLRenderingContext):
(WebCore::WebGLRenderingContext::clearIfComposited):
(WebCore::WebGLRenderingContext::checkObjectToBeBound):
(WebCore::WebGLRenderingContext::clear):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::createBuffer):
(WebCore::WebGLRenderingContext::createFramebuffer):
(WebCore::WebGLRenderingContext::createTexture):
(WebCore::WebGLRenderingContext::createProgram):
(WebCore::WebGLRenderingContext::createRenderbuffer):
(WebCore::WebGLRenderingContext::createShader):
(WebCore::WebGLRenderingContext::deleteObject):
(WebCore::WebGLRenderingContext::deleteRenderbuffer):
(WebCore::WebGLRenderingContext::deleteTexture):
(WebCore::WebGLRenderingContext::detachShader):
(WebCore::WebGLRenderingContext::validateElementArraySize):
(WebCore::WebGLRenderingContext::validateIndexArrayConservative):
(WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
(WebCore::WebGLRenderingContext::validateWebGLObject):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::framebufferRenderbuffer):
(WebCore::WebGLRenderingContext::framebufferTexture2D):
(WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
(WebCore::WebGLRenderingContext::linkProgram):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::useProgram):
(WebCore::WebGLRenderingContext::removeSharedObject):
(WebCore::WebGLRenderingContext::addSharedObject):
(WebCore::WebGLRenderingContext::removeContextObject):
(WebCore::WebGLRenderingContext::addContextObject):
(WebCore::WebGLRenderingContext::detachAndRemoveAllObjects):
(WebCore::WebGLRenderingContext::initVertexAttrib0):
(WebCore::WebGLRenderingContext::loseContext):
(WebCore::WebGLRenderingContext::loseContextImpl):
- html/canvas/WebGLRenderingContext.h:
(WebCore::WebGLRenderingContext::contextGroup):
- html/canvas/WebGLShader.cpp:
(WebCore::WebGLShader::WebGLShader):
(WebCore::WebGLShader::~WebGLShader):
(WebCore::WebGLShader::deleteObjectImpl):
- html/canvas/WebGLShader.h:
- html/canvas/WebGLSharedObject.cpp: Copied from Source/WebCore/html/canvas/WebGLRenderbuffer.cpp.
(WebCore::WebGLSharedObject::WebGLSharedObject):
(WebCore::WebGLSharedObject::~WebGLSharedObject):
(WebCore::WebGLSharedObject::detachContextGroup):
(WebCore::WebGLSharedObject::getAGraphicsContext3D):
- html/canvas/WebGLSharedObject.h: Copied from Source/WebCore/html/canvas/WebGLShader.h.
(WebCore::WebGLSharedObject::contextGroup):
(WebCore::WebGLSharedObject::isBuffer):
(WebCore::WebGLSharedObject::isFramebuffer):
(WebCore::WebGLSharedObject::isProgram):
(WebCore::WebGLSharedObject::isRenderbuffer):
(WebCore::WebGLSharedObject::isShader):
(WebCore::WebGLSharedObject::isTexture):
(WebCore::WebGLSharedObject::validate):
(WebCore::WebGLSharedObject::hasGroupOrContext):
- html/canvas/WebGLTexture.cpp:
(WebCore::WebGLTexture::WebGLTexture):
(WebCore::WebGLTexture::~WebGLTexture):
(WebCore::WebGLTexture::deleteObjectImpl):
- html/canvas/WebGLTexture.h:
- html/canvas/WebGLVertexArrayObjectOES.cpp:
(WebCore::WebGLVertexArrayObjectOES::WebGLVertexArrayObjectOES):
(WebCore::WebGLVertexArrayObjectOES::~WebGLVertexArrayObjectOES):
(WebCore::WebGLVertexArrayObjectOES::deleteObjectImpl):
- html/canvas/WebGLVertexArrayObjectOES.h:
- 10:43 AM Changeset in webkit [104953] by
-
- 5 edits6 copies in branches/safari-534.54-branch
Merged r103636.
- 10:40 AM Changeset in webkit [104952] by
-
- 3 edits6 copies in branches/safari-534.54-branch
Merged r103594.
- 10:37 AM Changeset in webkit [104951] by
-
- 4 edits3 copies in branches/safari-534.54-branch
Merged r103587.
- 10:35 AM Changeset in webkit [104950] by
-
- 6 edits3 copies in branches/safari-534.54-branch
Merged r103482.
- 10:26 AM Changeset in webkit [104949] by
-
- 3 edits in branches/safari-534.54-branch/Source/JavaScriptCore
Merged r103286.
- 10:05 AM Changeset in webkit [104948] by
-
- 2 edits in trunk/Source/WebCore
[soup] Initialize m_soupFlags in all ResourceResponse constructors.
Rubber-stamped by Gustavo Noronha Silva.
m_soupFlags was being initialized in two of the three ResourceResponse
constructors, causing some trouble in
FrameLoaderClient::dispatchDidReceiveResponse (ports which use
ResourceRequest::setSoupMessageFlags with the response's unitialized
flags).
- platform/network/soup/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
- 9:58 AM Changeset in webkit [104947] by
-
- 2 edits in trunk/Source/WebCore
CFURLRef to KURL conversion shouldn't turn raw paths into file URLs
https://bugs.webkit.org/show_bug.cgi?id=76251
Reviewed by Dan Bernstein.
- platform/cf/KURLCFNet.cpp: (WebCore::KURL::KURL): Removed the offending code.
- 9:51 AM Changeset in webkit [104946] by
-
- 5 edits1 move in trunk/Source
HWndDC is a better name than HwndDC.
https://bugs.webkit.org/show_bug.cgi?id=76281
Reviewed by Darin Adler.
Source/JavaScriptCore:
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- JavaScriptCore.gypi:
- wtf/win/HWndDCWin.h: Renamed from Source/JavaScriptCore/wtf/win/HwndDCWin.h.
(WTF::HWndDC::HWndDC):
(WTF::HWndDC::~HWndDC):
(WTF::HWndDC::operator HDC):
Source/WebKit/chromium:
- src/win/WebScreenInfoFactory.cpp:
(WebKit::WebScreenInfoFactory::screenInfo):
- 9:43 AM Changeset in webkit [104945] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Disconnecting the front-end does not disable profiling.
https://bugs.webkit.org/show_bug.cgi?id=76213
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-01-13
Reviewed by Pavel Feldman.
Not testable.
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::clearFrontend):
- 9:41 AM Changeset in webkit [104944] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark a flaky test as flaky
- platform/chromium/test_expectations.txt:
- 9:41 AM Changeset in webkit [104943] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix missing signal in qwebframe API test for Qt5
https://bugs.webkit.org/show_bug.cgi?id=76195
Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-01-13
Reviewed by Noam Rosenthal.
In Qt5 QObject has a new signal with this signature: "objectNameChanged(QString)".
- tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::enumerate_data):
- 9:04 AM Changeset in webkit [104942] by
-
- 2 edits in trunk/Tools
[GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
https://bugs.webkit.org/show_bug.cgi?id=76269
Reviewed by Martin Robinson.
- gtk/gtkdoc.py:
(GTKDoc._run_gtkdoc_scangobj):
- 8:35 AM Changeset in webkit [104941] by
-
- 2 edits in trunk/Source/WebCore
JSC/DOM bindings: Reduce HandleHeap churn in cacheWrapper().
<http://webkit.org/b/76271>
Reviewed by Darin Adler.
Use JSC::Weak::swap() to move JSDOMWrappers into the DOMWrapperWorld's wrapper map.
This avoids invoking the JSC::Weak copy constructor and associated HandleHeap churn.
- bindings/js/JSDOMBinding.h:
(WebCore::cacheWrapper):
- 8:28 AM Changeset in webkit [104940] by
-
- 13 edits3 adds in trunk/Source/WebCore
Web Inspector: [InspectorIndexedDB] Add InspectorIndexedDBAgent and IndexedDBModel, pass database names to inspector.
https://bugs.webkit.org/show_bug.cgi?id=76264
Reviewed by Pavel Feldman.
- CMakeLists.txt:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/CodeGeneratorInspector.py:
- inspector/Inspector.json:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorIndexedDBAgent.cpp: Added.
(WebCore::InspectorIndexedDBAgent::FrontendProvider::create):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::~FrontendProvider):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::frontend):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::clearFrontend):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::FrontendProvider):
(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::~InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::setFrontend):
(WebCore::InspectorIndexedDBAgent::clearFrontend):
(WebCore::InspectorIndexedDBAgent::restore):
(WebCore::InspectorIndexedDBAgent::enable):
(WebCore::InspectorIndexedDBAgent::disable):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
- inspector/InspectorIndexedDBAgent.h: Added.
(WebCore::InspectorIndexedDBAgent::create):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::buildObjectForFrame):
- inspector/compile-front-end.sh:
- inspector/front-end/IndexedDBModel.js: Added.
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype.get securityOrigin):
(WebInspector.ResourceTreeFrame.prototype._navigate):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 8:20 AM Changeset in webkit [104939] by
-
- 1 edit3 adds in trunk/LayoutTests
Test that cloneNode() doesn't cause crashes when used directly after stylesheet mutation.
<http://webkit.org/b/75987>
Reviewed by Antti Koivisto.
- fast/css/cloneNode-after-deleteRule-crash-expected.txt: Added.
- fast/css/cloneNode-after-deleteRule-crash.html: Added.
- fast/css/resources/cloneNode-after-deleteRule-subdocument.html: Added.
- 8:03 AM Changeset in webkit [104938] by
-
- 12 edits3 deletes in trunk/Source/WebCore
Unreviewed, rolling out r104935.
http://trac.webkit.org/changeset/104935
https://bugs.webkit.org/show_bug.cgi?id=76277
Breaks AppleWin compilation (Requested by vsevik on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-13
- CMakeLists.txt:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/CodeGeneratorInspector.py:
- inspector/Inspector.json:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorIndexedDBAgent.cpp: Removed.
- inspector/InspectorIndexedDBAgent.h: Removed.
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::buildObjectForFrame):
- inspector/compile-front-end.sh:
- inspector/front-end/IndexedDBModel.js: Removed.
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype._navigate):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 7:49 AM Changeset in webkit [104937] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Remove extern "C" from ewk_private.h
https://bugs.webkit.org/show_bug.cgi?id=76250
Reviewed by Andreas Kling.
ewk_private.h defines internal functions used by WebKit itself. There is no chance to be used by C application.
So, extern "C" keyword is unneeded in ewk_private.h.
- ewk/ewk_private.h:
- 7:44 AM Changeset in webkit [104936] by
-
- 3 edits in trunk/Source/JavaScriptCore
[EFL] Add OwnPtr specialization for Eina_Module.
https://bugs.webkit.org/show_bug.cgi?id=76255
Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-01-13
Reviewed by Andreas Kling.
Add an overload for deleteOwnedPtr(Eina_Module*) on EFL port.
- wtf/OwnPtrCommon.h:
- wtf/efl/OwnPtrEfl.cpp:
(WTF::deleteOwnedPtr):
- 7:08 AM Changeset in webkit [104935] by
-
- 12 edits3 adds in trunk/Source/WebCore
Web Inspector: [InspectorIndexedDB] Add InspectorIndexedDBAgent and IndexedDBModel, pass database names to inspector.
https://bugs.webkit.org/show_bug.cgi?id=76264
Reviewed by Pavel Feldman.
- CMakeLists.txt:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/CodeGeneratorInspector.py:
- inspector/Inspector.json:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorIndexedDBAgent.cpp: Added.
(WebCore::InspectorIndexedDBAgent::FrontendProvider::create):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::~FrontendProvider):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::frontend):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::clearFrontend):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::FrontendProvider):
(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::~InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::setFrontend):
(WebCore::InspectorIndexedDBAgent::clearFrontend):
(WebCore::InspectorIndexedDBAgent::restore):
(WebCore::InspectorIndexedDBAgent::enable):
(WebCore::InspectorIndexedDBAgent::disable):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
- inspector/InspectorIndexedDBAgent.h: Added.
(WebCore::InspectorIndexedDBAgent::create):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::buildObjectForFrame):
- inspector/compile-front-end.sh:
- inspector/front-end/IndexedDBModel.js: Added.
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype.get securityOrigin):
(WebInspector.ResourceTreeFrame.prototype._navigate):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 7:04 AM Changeset in webkit [104934] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fix build when using TextureMapper with OpenGL/ES
https://bugs.webkit.org/show_bug.cgi?id=76268
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-01-13
Reviewed by Tor Arne Vestbø.
- WebCore.pri: When the texture mapper uses OpenGL/ES, then it also relies on the
availability of libEGL by using eglGetCurrentContext(). In that case we need to link against
libEGL.
- 6:58 AM Changeset in webkit [104933] by
-
- 4 edits2 adds in trunk
Source/WebCore: Don't artifically keep IDBDatabase objects alive if there are no references to it.
https://bugs.webkit.org/show_bug.cgi?id=75859
Originally, this code was added to keep the IDBDatabase object alive
even if no reference from JavaScript to the object existed, because
running transactions could still send events for this database
connection. Meanwhile, transactions are marked as active DOM objects
during their lifetime, and they keep a RefPtr to the IDBDatabase
object, so this hack is no longer required.
Reviewed by Tony Gentilcore.
Test: storage/indexeddb/delete-closed-database-object.html
- storage/IDBDatabase.cpp:
- storage/IDBDatabase.h:
LayoutTests: Test that an IDBDatabase object is garbage collected once no further references to it exist.
https://bugs.webkit.org/show_bug.cgi?id=75859
Reviewed by Tony Gentilcore.
- storage/indexeddb/delete-closed-database-object-expected.txt: Added.
- storage/indexeddb/delete-closed-database-object.html: Added.
- 6:41 AM Changeset in webkit [104932] by
-
- 3 edits in trunk/Source/WebCore
TextureMapper: Do the node transform computation when painting.
https://bugs.webkit.org/show_bug.cgi?id=74721
Reviewed by Noam Rosenthal.
The transform of the node tree was built during the syncCompositingState
step. This would cause an ASSERT with QWebView, trying to use a dirty transform
state since the rootTextureMapperNode in QWebFramePrivate::renderCompositedLayers
doesn't run the sync step after getting the world transform set.
This moves the transform computation from the sync to the paint step to
prevent making sure that the sync step has been run on all nodes before painting.
- platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::computeTransformsRecursive):
(WebCore::TextureMapperNode::computeTiles):
Remove an unused variable.
(WebCore::TextureMapperNode::paint):
(WebCore::TextureMapperNode::syncAnimationsRecursively):
(WebCore::TextureMapperNode::syncCompositingState):
- platform/graphics/texmap/TextureMapperNode.h:
- 6:39 AM Changeset in webkit [104931] by
-
- 3 edits in trunk/Source/WebCore
TextureMapper: Simplify transform manipulations.
https://bugs.webkit.org/show_bug.cgi?id=74719
Reviewed by Noam Rosenthal.
- Make sure that the replica node has a complete transform and use it directly instead of keeping a copy in the source.
- Apply the origin and position translation only once, on the target and descendants transforms.
- Use to2dTransform() on !preserves3D layers instead of doing the flattening manually.
- Remove mentions of perspective as this is handled by WebCore through the children transform.
- Apply the inverse target transform on the replica only where it is needed in paintReflection since it uses the full transform in paintSelf.
- Merge the base and local transforms.
- platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::setTransform):
(WebCore::TextureMapperNode::computeTransformsSelf):
(WebCore::TextureMapperNode::computeAllTransforms):
(WebCore::TextureMapperNode::paintSelf):
(WebCore::TextureMapperNode::paintReflection):
- platform/graphics/texmap/TextureMapperNode.h:
- 6:38 AM Changeset in webkit [104930] by
-
- 2 edits in trunk/Source/WebCore
TextureMapper: Fix the fillsForward transform adjustment in syncAnimations.
https://bugs.webkit.org/show_bug.cgi?id=76184
Reviewed by Noam Rosenthal.
Also make the intention clearer by using setTransform and setOpacity.
- platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::syncAnimations):
- 6:32 AM Changeset in webkit [104929] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, update expectation for svg/dom/SVGPathSegList-segment-modification.svg on LEOPARD DEBUG.
- platform/chromium/test_expectations.txt:
- 6:25 AM Changeset in webkit [104928] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed inspector scripts navigator style fixes.
- inspector/front-end/scriptsPanel.css:
(#scripts-editor-container-tabbed-pane .tabbed-pane-header-tab):
- 6:20 AM Changeset in webkit [104927] by
-
- 9 edits5 adds in trunk
Source/WebCore: Once we prepared a script element for execution, execute it, even if the script element was meanwhile removed from the dom tree.
https://bugs.webkit.org/show_bug.cgi?id=76083
Reviewed by Adam Barth.
This bug was caught by the following IE Test Center test:
http://samples.msdn.microsoft.com/ietestcenter/HTML5/show_async_test.htm?11_RemovingAsyncScript
Test: http/tests/misc/async-script-removed.html
http/tests/misc/async-script.html
- dom/ScriptElement.cpp:
- dom/ScriptElement.h:
- dom/ScriptRunner.cpp:
(WebCore::ScriptRunner::queueScriptForExecution):
- html/HTMLScriptElement.cpp:
- html/HTMLScriptElement.h:
- svg/SVGScriptElement.cpp:
- svg/SVGScriptElement.h:
LayoutTests: Once we've prepared script element for execution, execute it, even if the script element was meanwhile removed from the dom tree.
https://bugs.webkit.org/show_bug.cgi?id=76083
Reviewed by Adam Barth.
- http/tests/misc/async-script-expected.txt: Added.
- http/tests/misc/async-script-removed-expected.txt: Added.
- http/tests/misc/async-script-removed.html: Added.
- http/tests/misc/async-script.html: Added.
- http/tests/misc/resources/delayed-log.php: Added.
- 6:18 AM Changeset in webkit [104926] by
-
- 4 edits in trunk/Source/WebCore
Large SVG text layout performance regression in r81168
https://bugs.webkit.org/show_bug.cgi?id=65711
Reviewed by Antti Koivisto.
Finish SVGTextMetricsBuilder introduction, tested in my local svg-text-performance branch.
SVGTextMetricsBuilder has two public methods:
a) SVGTextMetricsBuilder::measureTextRenderer(RenderSVGInlineText*)
It will be used exclusively for non-initial, incremental layout changes. Once the inital
text layout ran, any mutation of eg. a child text node of a <tspan>, will only trigger
a rebuild of the layout attributes associated with the passed in renderer.
b) SVGTextMetricsBuilder::buildMetricsAndLayoutAttributes(RenderSVGText*, RenderSVGInlineText* stopAtLeaf, SVGCharacterDataMap& allCharactersMap)
stopAtLeaf=0:
This carries out the initial layout phase. It measures all characters of the whole <text> subtree, and stores the SVGTextMetrics for each character
in the SVGTextLayoutAttributes, stored in the RenderSVGInlineText object. It requires a SVGCharacterDataMap allCharactersMap as input argument,
which contains a HashMap<unsigned, {float x, y, dx, dy, rotate}>, which maps each character position to a set of x/y/dx/dy/rotate values.
The SVGCharacterDataMap living in SVGTextLayoutAttributes will be filled, from the global "allCharactersMap", so that each RenderSVGInlineText only
stores the positioning information for its children, if any.
Note: SVGTextMetricsBuilder is not yet deployed, so this talks about the design, once everything is landed.
stopAtLeaf!=0:
This is never used for the initial layout phase. If the initial layout is done, and eg. a <tspan> is added to the <text> subtree, we no longer
need to rebuild the metrics map & layout attributes for the whole tree, but only for the desired <tspan>, and its previous/next sibling, if present
(which may be affected by the inclusion of another node inbetween them).
SVGTextMetricsBuilder is now finished, and will be used in the next patch chunk.
Doesn't affect any tests yet.
- rendering/svg/SVGTextLayoutAttributes.h:
(WebCore::SVGTextLayoutAttributes::clear):
(WebCore::SVGCharacterData::SVGCharacterData):
- rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::SVGTextMetricsBuilder):
(WebCore::SVGTextMetricsBuilder::currentCharacterStartsSurrogatePair):
(WebCore::SVGTextMetricsBuilder::advance):
(WebCore::SVGTextMetricsBuilder::advanceSimpleText):
(WebCore::SVGTextMetricsBuilder::advanceComplexText):
(WebCore::SVGTextMetricsBuilder::initializeMeasurementWithTextRenderer):
(WebCore::MeasureTextData::MeasureTextData):
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):
(WebCore::SVGTextMetricsBuilder::walkTree):
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):
(WebCore::SVGTextMetricsBuilder::buildMetricsAndLayoutAttributes):
- rendering/svg/SVGTextMetricsBuilder.h:
- 6:10 AM Changeset in webkit [104925] by
-
- 2 edits in trunk/Source/WebCore
Not reviewed: Fixing Win builders.
- inspector/DOMEditor.cpp:
(WebCore::DOMEditor::diff):
- 6:01 AM Changeset in webkit [104924] by
-
- 9 edits in trunk/Source
[EFL] Add 'Copy Image Address' to context menu.
https://bugs.webkit.org/show_bug.cgi?id=76153
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-01-13
Reviewed by Andreas Kling.
Source/WebCore:
Enables 'Copy Image Address' option to context menu in WebKit-EFL as it is enabled in GTK and QT ports.
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):
- platform/ContextMenuItem.h:
- platform/LocalizationStrategy.h:
- platform/LocalizedStrings.cpp:
- platform/LocalizedStrings.h:
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore::contextMenuItemTagCopyImageUrlToClipboard):
Source/WebKit/efl:
Adds EWK_CONTEXT_MENU_ITEM_TAG_COPY_IMAGE_URL_TO_CLIPBOARD to Ewk_Context_Menu_Action to synchronize it with ContextMenuItem.h
- ewk/ewk_contextmenu.h:
- 5:48 AM Changeset in webkit [104923] by
-
- 3 edits in trunk/Source/WebCore
Not reviewed: 32bit build fix.
- inspector/DOMEditor.cpp:
- inspector/DOMEditor.h:
- 5:41 AM Changeset in webkit [104922] by
-
- 4 edits in trunk/Source
Unreviewed, rollout r104905.
https://bugs.webkit.org/show_bug.cgi?id=76267
This patch broke tests in the GTK 64bit Debug bot.
Source/WebCore:
- editing/gtk/FrameSelectionGtk.cpp:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
Source/WebKit/gtk:
- tests/testatk.c:
(textCaretMovedCallback):
(testWebkitAtkCaretOffsets):
(textSelectionChangedCallback):
(testWebkitAtkTextSelections):
- 5:29 AM Changeset in webkit [104921] by
-
- 1 edit4 moves7 adds4 deletes in trunk/LayoutTests
Unreviewed, rebaseline Chromium and optimize Qt/GTK baselines after r104917 using garden-o-matic.
- platform/chromium-mac-snowleopard/svg/custom/text-xy-updates-SVGList-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Removed.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Removed.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Removed.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Removed.
- svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Renamed from LayoutTests/platform/gtk/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt.
- svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Renamed from LayoutTests/platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt.
- svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Renamed from LayoutTests/platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt.
- svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Renamed from LayoutTests/platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt.
- 5:24 AM Changeset in webkit [104920] by
-
- 7 edits3 adds in trunk
Web Inspector: make HTML editing preserve node identity when node nesting level changes.
https://bugs.webkit.org/show_bug.cgi?id=76183
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/elements/set-outer-html-2.html
- inspector/DOMEditor.cpp:
(WebCore::DOMEditor::patchDocument):
(WebCore::DOMEditor::patchNode):
(WebCore::DOMEditor::innerPatchHTMLElement):
(WebCore::DOMEditor::innerPatchNode):
(WebCore::DOMEditor::diff):
(WebCore::DOMEditor::innerPatchChildren):
(WebCore::DOMEditor::createDigest):
(WebCore::DOMEditor::insertBefore):
(WebCore::DOMEditor::removeChild):
(WebCore::DOMEditor::markNodeAsUsed):
(WebCore::DOMEditor::dumpMap):
- inspector/DOMEditor.h:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setOuterHTML):
LayoutTests:
- inspector/elements/set-outer-html-2-expected.txt: Added.
- inspector/elements/set-outer-html-2.html: Added.
- inspector/elements/set-outer-html-expected.txt:
- inspector/elements/set-outer-html-test.js: Added.
(initialize_SetOuterHTMLTest.InspectorTest.setUpTestSuite.step1):
(initialize_SetOuterHTMLTest.InspectorTest.setUpTestSuite.step2):
(initialize_SetOuterHTMLTest.InspectorTest.setUpTestSuite.step3):
(initialize_SetOuterHTMLTest.InspectorTest.setUpTestSuite):
(initialize_SetOuterHTMLTest.InspectorTest.recordEvent):
(initialize_SetOuterHTMLTest.InspectorTest.patchOuterHTML):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTML.bringBack):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTML):
(initialize_SetOuterHTMLTest.InspectorTest.innerSetOuterHTML.dumpOuterHTML.dumpIdentity):
(initialize_SetOuterHTMLTest.InspectorTest.innerSetOuterHTML.dumpOuterHTML.callback):
(initialize_SetOuterHTMLTest.InspectorTest.innerSetOuterHTML.dumpOuterHTML):
(initialize_SetOuterHTMLTest.InspectorTest.innerSetOuterHTML):
(initialize_SetOuterHTMLTest):
- inspector/elements/set-outer-html.html:
- 5:04 AM Changeset in webkit [104919] by
-
- 17 edits1 copy3 adds in trunk
ShadowContentElement should be able to use query.
https://bugs.webkit.org/show_bug.cgi?id=75302
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-13
Reviewed by Hajime Morita.
Source/WebCore:
This patch introduces a selector to query elements in ShadowContentElement.
This can be used instead of ShadowContentElement::shouldInclude in more sophisticated ways.
Tests: fast/dom/shadow/shadow-contents-select-expected.html
fast/dom/shadow/shadow-contents-select.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/DOMAllInOne.cpp:
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::SelectorDataList):
Extracted from SelectorQueryto share codes with ShadowContentSelectorQuery.
(WebCore::SelectorDataList::initialize):
(WebCore::SelectorDataList::matches):
(WebCore::SelectorDataList::queryAll):
(WebCore::SelectorDataList::queryFirst):
(WebCore::SelectorDataList::canUseIdLookup):
(WebCore::SelectorDataList::execute):
(WebCore::SelectorQuery::SelectorQuery):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):
- dom/SelectorQuery.h:
(WebCore::SelectorDataList::size):
- dom/ShadowContentElement.cpp:
(WebCore::ShadowContentElement::select):
(WebCore::ShadowContentElement::setSelect):
- dom/ShadowContentElement.h:
- dom/ShadowContentSelectorQuery.cpp: Added.
(WebCore::ShadowContentSelectorQuery::ShadowContentSelectorQuery):
(WebCore::ShadowContentSelectorQuery::matches):
Returns true if Node is matched by the query.
- dom/ShadowContentSelectorQuery.h: Copied from Source/WebCore/dom/ShadowContentElement.h.
- dom/ShadowInclusionSelector.cpp:
(WebCore::ShadowInclusionSelector::select):
- dom/ShadowInclusionSelector.h:
- html/HTMLAttributeNames.in:
- html/HTMLDetailsElement.cpp:
(WebCore::summaryQuerySelector):
(WebCore::DetailsContentElement::DetailsContentElement): Re-implemented using query.
(WebCore::DetailsSummaryElement::DetailsSummaryElement): ditto.
LayoutTests:
Tests for ShadowContentElement query.
- fast/dom/shadow/shadow-contents-select-expected.html: Added.
- fast/dom/shadow/shadow-contents-select.html: Added.
- 4:39 AM Changeset in webkit [104918] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-13
- DEPS:
- 3:54 AM Changeset in webkit [104917] by
-
- 74 edits in trunk/LayoutTests
Update Snow-Leopard SVG pixel test baseline after r104881.
Unreviewed gardening.
- platform/mac-snowleopard/svg/css/composite-shadow-example-expected.png:
- platform/mac-snowleopard/svg/css/composite-shadow-with-opacity-expected.png:
- platform/mac-snowleopard/svg/css/stars-with-shadow-expected.png:
- platform/mac-snowleopard/svg/custom/altglyph-expected.png:
- platform/mac-snowleopard/svg/custom/external-paintserver-reference-expected.png:
- platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
- platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
- platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
- platform/mac-snowleopard/svg/custom/invisible-text-after-scrolling-expected.png:
- platform/mac-snowleopard/svg/custom/junk-data-expected.png:
- platform/mac-snowleopard/svg/custom/linking-base-external-reference-expected.png:
- platform/mac-snowleopard/svg/custom/missing-xlink-expected.png:
- platform/mac-snowleopard/svg/custom/object-sizing-no-width-height-expected.png:
- platform/mac-snowleopard/svg/custom/path-bad-data-expected.png:
- platform/mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/mac-snowleopard/svg/custom/text-xy-updates-SVGList-expected.png:
- platform/mac-snowleopard/svg/custom/use-font-face-crash-expected.png:
- platform/mac-snowleopard/svg/dom/SVGLengthList-appendItem-expected.png:
- platform/mac-snowleopard/svg/dom/SVGLengthList-basics-expected.png:
- platform/mac-snowleopard/svg/dom/SVGLengthList-initialize-expected.png:
- platform/mac-snowleopard/svg/dom/SVGLengthList-insertItemBefore-expected.png:
- platform/mac-snowleopard/svg/dom/SVGLengthList-removeItem-expected.png:
- platform/mac-snowleopard/svg/dom/SVGLengthList-replaceItem-expected.png:
- platform/mac-snowleopard/svg/dom/SVGLengthList-xml-dom-modifications-expected.png:
- platform/mac-snowleopard/svg/dom/SVGNumberList-basics-expected.png:
- platform/mac-snowleopard/svg/dom/SVGPathSegList-appendItem-expected.png:
- platform/mac-snowleopard/svg/dom/SVGPathSegList-clear-and-initialize-expected.png:
- platform/mac-snowleopard/svg/dom/SVGPathSegList-insertItemBefore-expected.png:
- platform/mac-snowleopard/svg/dom/SVGPathSegList-removeItem-expected.png:
- platform/mac-snowleopard/svg/dom/SVGPathSegList-replaceItem-expected.png:
- platform/mac-snowleopard/svg/dom/SVGPointList-basics-expected.png:
- platform/mac-snowleopard/svg/dom/SVGStringList-basics-expected.png:
- platform/mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png:
- platform/mac-snowleopard/svg/dom/css-transforms-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/hixie/error/012-expected.png:
- platform/mac-snowleopard/svg/in-html/circle-expected.png:
- platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png:
- platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png:
- platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png:
- platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png:
- platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png:
- platform/mac-snowleopard/svg/text/kerning-expected.png:
- platform/mac-snowleopard/svg/text/multichar-glyph-expected.png:
- platform/mac-snowleopard/svg/wicd/rightsizing-grid-expected.png:
- platform/mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png:
- platform/mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png:
- platform/mac-snowleopard/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
- platform/mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
- platform/mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
- platform/mac-snowleopard/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
- platform/mac-snowleopard/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
- 3:36 AM Changeset in webkit [104916] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Detailed heap snapshot. _calculateFlags is too slow on a large heap snapshot.
https://bugs.webkit.org/show_bug.cgi?id=76252
_calculateFlags speed is about 10k edges per second.
It requires 150sec for the snapshot with 1.5m edges.
The root of problem is var node = list.shift();
shift() is not effective in term of memory and cpu.
In our case it can be replaced with pop().
Now the function works 40 times faster.
Drive by change: if statement was reformatted a bit for better readability.
Reviewed by Yury Semikhatsky.
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._calculateFlags):
- 3:25 AM Changeset in webkit [104915] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Add visible field into ewk_tiled_backing_store's data.
https://bugs.webkit.org/show_bug.cgi?id=76165
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2012-01-13
Reviewed by Nikolas Zimmermann.
Using of evas_object_visible_get() API can't gurantee the correctness of
evas_object's visible status if it's called inside of evas_object's
smart_show() method.
So, a visible flag for the ewk_tiled_backing_store is added.
In addition, as tiles are not visible, ewk_tiled_backing_store will push
its own tiles into the cache when it disapear.
- ewk/ewk_tiled_backing_store.cpp:
(_ewk_tiled_backing_store_updates_process):
(_ewk_tiled_backing_store_item_process_idler_start):
(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_smart_member_add):
(_ewk_tiled_backing_store_smart_show):
(_ewk_tiled_backing_store_smart_hide):
- 3:02 AM Changeset in webkit [104914] by
-
- 3 edits1 add1 delete in trunk/LayoutTests
Unreviewed; chromium tests rebaselined after r104907.
- platform/chromium-mac-leopard/fast/repaint/focus-layers-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/focus-layers-expected.png: Added.
- platform/chromium-mac/fast/repaint/focus-layers-expected.png: Removed.
- platform/chromium-win/fast/repaint/focus-layers-expected.png:
- 2:52 AM Changeset in webkit [104913] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Chromium] JavaScriptOutlineDialog fails to open
https://bugs.webkit.org/show_bug.cgi?id=76259
Reviewed by Yury Semikhatsky.
- WebCore.gypi:
- 2:07 AM Changeset in webkit [104912] by
-
- 24 edits in trunk/LayoutTests
Unreviewed tests rebaseline after r104803.
- fast/profiler/throw-exception-from-eval-expected.txt:
- platform/chromium-mac/http/tests/history/cross-origin-replace-history-object-child-expected.txt:
- platform/chromium-win/http/tests/security/javascriptURL/xss-DENIED-javascript-execution-expected.txt:
- platform/chromium-win/http/tests/security/xss-DENIED-history-properties-expected.txt:
- platform/chromium/http/tests/security/xss-eval-expected.txt:
- platform/mac-leopard/plugins/plugin-initiate-popup-window-expected.txt:
- platform/mac-wk2/plugins/mouse-events-scaled-expected.txt:
- platform/mac/fast/AppleScript/001-expected.txt:
- platform/mac/plugins/npp-set-window-called-during-destruction-expected.txt:
- platform/mac/plugins/plugin-initiate-popup-window-expected.txt:
- platform/qt-wk2/plugins/document-open-expected.txt:
- platform/win-wk2/platform/win/plugins/windowless-paint-rect-coordinates-expected.txt:
- platform/win/plugins/call-javascript-that-destroys-plugin-expected.txt:
- platform/win/plugins/get-value-netscape-window-expected.txt:
- platform/win/plugins/iframe-inside-overflow-expected.txt:
- platform/win/plugins/keyboard-events-expected.txt:
- platform/win/plugins/mouse-events-expected.txt:
- platform/win/plugins/mouse-events-fixedpos-expected.txt:
- platform/win/plugins/npn-invalidate-rect-invalidates-window-expected.txt:
- platform/win/plugins/npp-set-window-called-during-destruction-expected.txt:
- platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt:
- platform/win/plugins/window-region-is-set-to-clip-rect-expected.txt:
- platform/win/plugins/windowless-paint-rect-coordinates-expected.txt:
- 2:05 AM Changeset in webkit [104911] by
-
- 2 edits in trunk/LayoutTests
[Qt][Mac] Unreviewed garedening. Skip new failing tests to paint the bot green.
- platform/qt-mac/Skipped:
- 1:41 AM Changeset in webkit [104910] by
-
- 2 edits in trunk/Tools
[Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
https://bugs.webkit.org/show_bug.cgi?id=76247
Reviewed by Kenneth Rohde Christiansen.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
- 1:31 AM Changeset in webkit [104909] by
-
- 77 edits in trunk/LayoutTests
2012-01-13 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Update Lion SVG pixel test baseline after r104881.
Also update SVGFETurbulenceElement-*-stitchTiles-*, filter-child-repaint.svg results, which pass again.
- platform/mac/svg/css/composite-shadow-example-expected.png:
- platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
- platform/mac/svg/css/stars-with-shadow-expected.png:
- platform/mac/svg/custom/altglyph-expected.png:
- platform/mac/svg/custom/external-paintserver-reference-expected.png:
- platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
- platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
- platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
- platform/mac/svg/custom/invisible-text-after-scrolling-expected.png:
- platform/mac/svg/custom/junk-data-expected.png:
- platform/mac/svg/custom/linking-base-external-reference-expected.png:
- platform/mac/svg/custom/missing-xlink-expected.png:
- platform/mac/svg/custom/object-sizing-no-width-height-expected.png:
- platform/mac/svg/custom/path-bad-data-expected.png:
- platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/mac/svg/custom/text-xy-updates-SVGList-expected.png:
- platform/mac/svg/custom/use-font-face-crash-expected.png:
- platform/mac/svg/dom/SVGLengthList-appendItem-expected.png:
- platform/mac/svg/dom/SVGLengthList-basics-expected.png:
- platform/mac/svg/dom/SVGLengthList-initialize-expected.png:
- platform/mac/svg/dom/SVGLengthList-insertItemBefore-expected.png:
- platform/mac/svg/dom/SVGLengthList-removeItem-expected.png:
- platform/mac/svg/dom/SVGLengthList-replaceItem-expected.png:
- platform/mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.png:
- platform/mac/svg/dom/SVGNumberList-basics-expected.png:
- platform/mac/svg/dom/SVGPathSegList-appendItem-expected.png:
- platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png:
- platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png:
- platform/mac/svg/dom/SVGPathSegList-removeItem-expected.png:
- platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.png:
- platform/mac/svg/dom/SVGPointList-basics-expected.png:
- platform/mac/svg/dom/SVGStringList-basics-expected.png:
- platform/mac/svg/dom/SVGTransformList-basics-expected.png:
- platform/mac/svg/dom/css-transforms-expected.png:
- platform/mac/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
- platform/mac/svg/hixie/error/012-expected.png:
- platform/mac/svg/in-html/circle-expected.png:
- platform/mac/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png:
- platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png:
- platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png:
- platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png:
- platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png:
- platform/mac/svg/repaint/filter-child-repaint-expected.png:
- platform/mac/svg/text/kerning-expected.png:
- platform/mac/svg/text/multichar-glyph-expected.png:
- platform/mac/svg/wicd/rightsizing-grid-expected.png:
- platform/mac/svg/wicd/test-rightsizing-b-expected.png:
- platform/mac/svg/wicd/test-scalable-background-image1-expected.png:
- platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
- platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
- platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
- platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
- 1:23 AM Changeset in webkit [104908] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Unused code cleanup on ewk_tiled_model.cpp.
https://bugs.webkit.org/show_bug.cgi?id=76031
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2012-01-13
Reviewed by Ryosuke Niwa.
Remove unused code from ewk_tiled_model.cpp.
- ewk/ewk_tiled_model.cpp:
- 1:17 AM Changeset in webkit [104907] by
-
- 5 edits2 adds in trunk
text-decorations should not be propagated to floating, absolutely or fixed
positioned decendants
https://bugs.webkit.org/show_bug.cgi?id=18611
Reviewed by Darin Adler.
Source/WebCore:
Previously text-decorations were propagated to all child elements,
but they should not be propagated to out-of-flow descendants,
i.e. floating, absolutely or fixed positioned elements.
The spec says "text decorations are not propagated to any out-of-flow descendants":
http://www.w3.org/TR/2011/WD-css3-text-20110901/#decoration
Test: fast/css/text-decoration-in-descendants.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::getTextDecorationColors):
LayoutTests:
The added test checks that text-decorations are not propagated to out-of-flow
descendants, i.e. floating, absolutely or fixed positioned elements.
The spec says "text decorations are not propagated to any out-of-flow descendants":
http://www.w3.org/TR/2011/WD-css3-text-20110901/#decoration
- fast/css/text-decoration-in-descendants-expected.html: Added.
- fast/css/text-decoration-in-descendants.html: Added.
- platform/chromium-linux/fast/repaint/focus-layers-expected.png: Updated the test result.
- platform/mac/fast/repaint/focus-layers-expected.png: Ditto.
- 1:14 AM Changeset in webkit [104906] by
-
- 3 edits2 adds in trunk
REGRESSION (r104668): Crash in HTMLFormElement destructor if the
document contains radio groups with the identical name.
https://bugs.webkit.org/show_bug.cgi?id=76206
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/forms/radio/radio-group-document-destruction.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::~HTMLInputElement):
setForm(0) may register this to a document-level radio button group.
We need to unregister this from the group because
Document::checkedRadioButtons() is still accessible from other objects.
LayoutTests:
- fast/forms/radio/radio-group-document-destruction-expected.txt: Added.
- fast/forms/radio/radio-group-document-destruction.html: Added.
- 1:12 AM Changeset in webkit [104905] by
-
- 4 edits in trunk/Source
[GTK] ATK text-caret-moved and text-selection-changed events not being emitted
https://bugs.webkit.org/show_bug.cgi?id=76069
Reviewed by Martin Robinson.
Source/WebCore:
Fix bug introduced with patch for Bug 72830.
- editing/gtk/FrameSelectionGtk.cpp:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
Pass the right accessibility object associated with the current
selection to objectFocusedAndCaretOffsetUnignored.
Source/WebKit/gtk:
Update caret browsing related unit tests to check emissions of
'text-caret-moved' and 'text-selection-changed' signals.
- tests/testatk.c:
(textCaretMovedCallback): New callback for 'text-caret-moved'.
(testWebkitAtkCaretOffsets): Check emissions of 'text-caret-moved'.
(textSelectionChangedCallback): New callback for 'text-selection-changed'.
(testWebkitAtkTextSelections): Check emissions of 'text-selection-changed'.
- 1:10 AM Changeset in webkit [104904] by
-
- 2 edits in trunk/Source/WebKit/gtk
[Gtk] Removed duplicated unit test.
The unit test testWebkitAtkGetTextAtOffsetForms is exactly the
same test case than testWebkitAtkGetTextAtOffset, so it makes no
sense to have it duplicated.
Rubber-stamped by Martin Robinson.
- tests/testatk.c:
(main): Removed testWebkitAtkGetTextAtOffsetForms.
- 1:05 AM Changeset in webkit [104903] by
-
- 4 edits in trunk/Source/WebCore
Refactor RenderLayerBacking::paintIntoLayer and RenderLayer::paintLayer()/paintLayerContents() to avoid duplicate code
https://bugs.webkit.org/show_bug.cgi?id=75983
Reviewed by Simon Fraser.
No new tests, just merging two duplicate methods.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):
This method is used only in non-composited mode, so I've moved the check for composited mode much earlier.
(WebCore::RenderLayer::paintLayerContentsAndReflection):
Also used just in non-composited mode, it will draw the reflection and then just call paintLayerContents.
(WebCore::RenderLayer::paintLayerContents):
Old method, that is now used by both composited and non-composited mode. I've added 3 more flags used to render the
Graphics layers: Background, Foreground and Mask.
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
Removed all the code and delegated the work to RenderLayer::paintLayerContents.
- 12:47 AM Changeset in webkit [104902] by
-
- 4 edits in trunk/Tools
[Mac][DRT] Should support --no-timeout
https://bugs.webkit.org/show_bug.cgi?id=76242
Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-13
Reviewed by Darin Adler.
- DumpRenderTree/mac/DumpRenderTree.mm:
(initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
(setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
(shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
- DumpRenderTree/mac/DumpRenderTreeMac.h:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
- 12:46 AM Changeset in webkit [104901] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix after r104787 if JIT_VERBOSE_OSR is defined
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
