Context Navigation

← Previous Period
Next Period →

Timeline

Jan 21, 2012:

7:45 PM Changeset in webkit [105584] by commit-queue@webkit.org

2 edits in trunk

[GTK][PATCH] Enable MathML support by default
https://bugs.webkit.org/show_bug.cgi?id=76790

Patch by Priit Laes <plaes@plaes.org> on 2012-01-21
Reviewed by Martin Robinson.

configure.ac: Enable MathML by default.

7:30 PM Changeset in webkit [105583] by commit-queue@webkit.org

13 edits in trunk/Source

[Chromium] Incremental texture updates are not atomic.
https://bugs.webkit.org/show_bug.cgi?id=72672

Patch by David Reveman <reveman@chromium.org> on 2012-01-21
Reviewed by Adam Barth.

Source/WebCore:

Use a new set of textures for each commit when incremental
texture updates are enabled.

This patch is tested by the following unit test:

CCLayerTreeHostTestAtomicCommit.runMultiThread

platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::ManagedTexture):
(WebCore::ManagedTexture::steal):

platform/graphics/chromium/ManagedTexture.h:
platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::deleteTextureAfterCommit):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

platform/graphics/chromium/cc/CCProxy.h:
platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(WebCore::CCSingleThreadProxy::partialTextureUpdateCapability):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::partialTextureUpdateCapability):

platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

Add CCLayerTreeHostTestAtomicCommit test that verifies atomicity
of commits.

tests/CCLayerTreeHostTest.cpp:

(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::create):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::createTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::deleteTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::bindTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::texture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::usedTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::CompositorFakeWebGraphicsContext3DWithTextureTracking):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::MockContentLayerDelegate::drawsContent):
(WTF::MockContentLayerDelegate::paintContents):
(WTF::MockContentLayerDelegate::notifySyncRequired):
(WTF::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit):
(WTF::CCLayerTreeHostTestAtomicCommit::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::layout):
(WTF::CCLayerTreeHostTestAtomicCommit::afterTest):
(WTF::TEST_F):

tests/CompositorFakeWebGraphicsContext3D.h:

5:43 PM Changeset in webkit [105582] by abarth@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add baselines for test after http://trac.webkit.org/changeset/105575.
This baseline looks very similar to the existing non-Chromium baseline.

platform/chromium-mac-snowleopard/svg/filters/feImage-preserveAspectratio-expected.png: Added.
platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png: Added.

5:36 PM Changeset in webkit [105581] by fpizlo@apple.com

8 edits
9 adds
1 delete in trunk/Source/JavaScriptCore

DFG should not have code that directly decodes the states of old JIT inline
cache data structures
https://bugs.webkit.org/show_bug.cgi?id=76768

Reviewed by Sam Weinig.

Introduced new classes (like GetByIdStatus) that encapsulate the set of things
that the DFG would like to know about property accesses and calls. Whereas it
previously got this information by directly decoding the data structures used
by the old JIT for inline caching, it now uses these classes, which do the work
for it. This should make it somewhat more straight forward to introduce new
ways of profiling the same information.

Also hoisted StructureSet into bytecode/ from dfg/, because it's now used by
code in bytecode/.

Making this work right involved carefully ensuring that the heuristics for
choosing how to handle property accesses was at least as good as what we had
before, since I completely restructured that code. Currently the performance
looks neutral. Since I rewrote the code I did change some things that I never
liked before, like previously if a put_bu_id had executed exactly once then
we'd compile it as if it had taken slow-path. Executing once is special because
then the inline cache is not baked in, so there is no information about how the
DFG should optimize the code. Now this is rationalized: if the put_by_id does
not offer enough information to be optimized (i.e. had executed 0 or 1 times)
then we turn it into a forced OSR exit (i.e. a patch point). However, get_by_id
still has the old behavior; I left it that way because I didn't want to make
too many changes at once.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
bytecode/CallLinkStatus.cpp: Added.

(JSC::CallLinkStatus::computeFor):

bytecode/CallLinkStatus.h: Added.

(JSC::CallLinkStatus::CallLinkStatus):
(JSC::CallLinkStatus::isSet):
(JSC::CallLinkStatus::operator!):
(JSC::CallLinkStatus::couldTakeSlowPath):
(JSC::CallLinkStatus::callTarget):

bytecode/GetByIdStatus.cpp: Added.

(JSC::GetByIdStatus::computeFor):

bytecode/GetByIdStatus.h: Added.

(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::state):
(JSC::GetByIdStatus::isSet):
(JSC::GetByIdStatus::operator!):
(JSC::GetByIdStatus::isSimpleDirect):
(JSC::GetByIdStatus::takesSlowPath):
(JSC::GetByIdStatus::makesCalls):
(JSC::GetByIdStatus::structureSet):
(JSC::GetByIdStatus::offset):

bytecode/MethodCallLinkStatus.cpp: Added.

(JSC::MethodCallLinkStatus::computeFor):

bytecode/MethodCallLinkStatus.h: Added.

(JSC::MethodCallLinkStatus::MethodCallLinkStatus):
(JSC::MethodCallLinkStatus::isSet):
(JSC::MethodCallLinkStatus::operator!):
(JSC::MethodCallLinkStatus::needsPrototypeCheck):
(JSC::MethodCallLinkStatus::structure):
(JSC::MethodCallLinkStatus::prototypeStructure):
(JSC::MethodCallLinkStatus::function):
(JSC::MethodCallLinkStatus::prototype):

bytecode/PutByIdStatus.cpp: Added.

(JSC::PutByIdStatus::computeFor):

bytecode/PutByIdStatus.h: Added.

(JSC::PutByIdStatus::PutByIdStatus):
(JSC::PutByIdStatus::state):
(JSC::PutByIdStatus::isSet):
(JSC::PutByIdStatus::operator!):
(JSC::PutByIdStatus::isSimpleReplace):
(JSC::PutByIdStatus::isSimpleTransition):
(JSC::PutByIdStatus::takesSlowPath):
(JSC::PutByIdStatus::oldStructure):
(JSC::PutByIdStatus::newStructure):
(JSC::PutByIdStatus::structureChain):
(JSC::PutByIdStatus::offset):

bytecode/StructureSet.h: Added.

(JSC::StructureSet::StructureSet):
(JSC::StructureSet::clear):
(JSC::StructureSet::add):
(JSC::StructureSet::addAll):
(JSC::StructureSet::remove):
(JSC::StructureSet::contains):
(JSC::StructureSet::isSubsetOf):
(JSC::StructureSet::isSupersetOf):
(JSC::StructureSet::size):
(JSC::StructureSet::at):
(JSC::StructureSet::operator[]):
(JSC::StructureSet::last):
(JSC::StructureSet::predictionFromStructures):
(JSC::StructureSet::operator==):
(JSC::StructureSet::dump):

dfg/DFGAbstractValue.h:
dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGStructureSet.h: Removed.

5:09 PM Changeset in webkit [105580] by commit-queue@webkit.org

4 edits
6 adds in trunk

Add .url attribute alongside .URL in EventSource and WebSocket to comply with the specs but not break existing usage.
https://bugs.webkit.org/show_bug.cgi?id=40899

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-21
Reviewed by Adam Barth.

Source/WebCore:

Tests: fast/eventsource/eventsource-url-attribute.html

http/tests/websocket/tests/hixie76/url-attribute.html
http/tests/websocket/tests/hybi/url-attribute.html

page/EventSource.idl:
websockets/WebSocket.idl:

LayoutTests:

fast/eventsource/eventsource-url-attribute-expected.txt: Added.
fast/eventsource/eventsource-url-attribute.html: Added.
http/tests/websocket/tests/hixie76/url-attribute-expected.txt: Added.
http/tests/websocket/tests/hixie76/url-attribute.html: Added.
http/tests/websocket/tests/hybi/url-attribute-expected.txt: Added.
http/tests/websocket/tests/hybi/url-attribute.html: Added.

4:48 PM Changeset in webkit [105579] by fpizlo@apple.com

5 edits in trunk/Source/JavaScriptCore

JIT compilation should not require ExecState
https://bugs.webkit.org/show_bug.cgi?id=76729
<rdar://problem/10731545>

Reviewed by Gavin Barraclough.

Changed the relevant JIT driver functions to take JSGlobalData& instead of
ExecState*, since really they just needed the global data.

dfg/DFGDriver.cpp:

(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):

dfg/DFGDriver.h:

(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):

jit/JITDriver.h:

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

3:56 PM Changeset in webkit [105578] by commit-queue@webkit.org

13 edits in trunk/Source

Unreviewed, rolling out r105564.
http://trac.webkit.org/changeset/105564
https://bugs.webkit.org/show_bug.cgi?id=76792

Does not compile on Chromium Mac (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-21

Source/WebCore:

platform/graphics/chromium/ManagedTexture.cpp:
platform/graphics/chromium/ManagedTexture.h:
platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::commitComplete):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

platform/graphics/chromium/cc/CCProxy.h:
platform/graphics/chromium/cc/CCSingleThreadProxy.h:
platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):

platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):

tests/CompositorFakeWebGraphicsContext3D.h:

9:19 AM Changeset in webkit [105577] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

[Qt] Unreviewed weekend gardening. Skip the new failing tests to paint the bots green.

platform/qt-wk2/Skipped:
platform/qt/Skipped:

7:40 AM Changeset in webkit [105576] by cmarrin@apple.com

19 edits
6 adds in trunk

Implement hardware accelerated Brightness and contrast filters
https://bugs.webkit.org/show_bug.cgi?id=75521
https://bugs.webkit.org/show_bug.cgi?id=76719

Reviewed by Simon Fraser.

Source/WebCore:

Implemented hardware accelerated brightness and contrast filters. This also fixes
the bug where grayscale filter was accidentally never getting hardware accelerated.
It also complies with proposed spec changes for the brightness filter to be additive
rather than multiplicative, according to https://bugs.webkit.org/show_bug.cgi?id=76719.
Had to make both fixes in the same patch because I had to change the allowed brightness
values for the hardware version, so I had to change the software version as well.

Tests: css3/filters/effect-brightness-hw.html

css3/filters/effect-contrast-hw.html

css/CSSParser.cpp:

(WebCore::CSSParser::parseBuiltinFilterArguments):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::createFilterOperations):

platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::setFilters):
(PlatformCALayer::filtersCanBeComposited):

rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::build):

LayoutTests:

New tests for hardware accelerated brightness and contrast filters. Also
added brightness and contrast values to effect-combined-hw test. And changed
brightness values in effect-brightness.html to reflect new spec.
Also fixed parsing and computed style tests to reflect new brightness spec.

css3/filters/effect-brightness-expected.png:
css3/filters/effect-brightness-hw-expected.png: Added.
css3/filters/effect-brightness-hw-expected.txt: Added.
css3/filters/effect-brightness-hw.html: Added.
css3/filters/effect-brightness.html:
css3/filters/effect-combined-expected.png:
css3/filters/effect-combined-hw-expected.png:
css3/filters/effect-combined-hw-expected.txt:
css3/filters/effect-combined-hw.html:
css3/filters/effect-combined.html:
css3/filters/effect-contrast-hw-expected.png: Added.
css3/filters/effect-contrast-hw-expected.txt: Added.
css3/filters/effect-contrast-hw.html: Added.
css3/filters/filter-property-computed-style-expected.txt:
css3/filters/filter-property-parsing-expected.txt:
css3/filters/filter-property-parsing-invalid-expected.txt:
css3/filters/script-tests/filter-property-computed-style.js:
css3/filters/script-tests/filter-property-parsing-invalid.js:
css3/filters/script-tests/filter-property-parsing.js:

4:28 AM Changeset in webkit [105575] by Nikolas Zimmermann

5 edits
3 adds in trunk

2012-01-21 Nikolas Zimmermann <nzimmermann@rim.com>

<feImage> ignores preserveAspectRatio="none"
https://bugs.webkit.org/show_bug.cgi?id=76780

Reviewed by Antti Koivisto.

Add new testcase covering preserveAspectRatio="none" + <feImage>, which is now fixed.

platform/chromium/test_expectations.txt: Add new test, that needs a rebaseline.
platform/mac/svg/filters/feImage-preserveAspectratio-expected.png: Added.
platform/mac/svg/filters/feImage-preserveAspectratio-expected.txt: Added.
svg/filters/feImage-preserveAspectratio.svg: Added.

2012-01-21 Nikolas Zimmermann <nzimmermann@rim.com>

<feImage> ignores preserveAspectRatio="none"
https://bugs.webkit.org/show_bug.cgi?id=76780

Reviewed by Antti Koivisto.

preserveAspectRatio="none" was ignored in SVGFEImage. It always called transformRect() w/o checking
whether it was supposed to transform the rect or not - move code from RenderSVGImage right into
transformRect(), to do nothing if preserveAspectRatio="none" was given.

Test: svg/filters/feImage-preserveAspectratio.svg

rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::transformRect):

2:18 AM Changeset in webkit [105574] by jochen@chromium.org

3 edits
6 adds in trunk

history.replaceState should update the HistoryItem to use a GET method if previously non-GET (POST)
https://bugs.webkit.org/show_bug.cgi?id=76721

Reviewed by Mihai Parparita.

Source/WebCore:

Tests: http/tests/history/replacestate-post-to-get-2.html

http/tests/history/replacestate-post-to-get.html

loader/HistoryController.cpp:

(WebCore::HistoryController::replaceState):

LayoutTests:

http/tests/history/replacestate-post-to-get-2-expected.txt: Added.
http/tests/history/replacestate-post-to-get-2.html: Added.
http/tests/history/replacestate-post-to-get-expected.txt: Added.
http/tests/history/replacestate-post-to-get.html: Added.
http/tests/history/resources/replacestate-current.php: Added.
http/tests/history/resources/replacestate-forward-back.php: Added.

2:00 AM Changeset in webkit [105573] by commit-queue@webkit.org

7 edits
2 adds in trunk

Null dereference in SVGDocumentExtensions::removePendingResource when updating <use>'s href
https://bugs.webkit.org/show_bug.cgi?id=69284

Patch by Florin Malita <fmalita@google.com> on 2012-01-21
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/custom/use-crash-pending-resource.svg

The crash is caused by assumptions in SVGUseElement that xlink:href is the only
pending resource. This patch adds support for dealing with multiple pending resources.

rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::registerResource):

svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::hasPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::isElementPendingResource):
(WebCore::SVGDocumentExtensions::removePendingResourceForElement):

svg/SVGDocumentExtensions.h:
svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
(WebCore::SVGStyledElement::clearHasPendingResourcesIfPossible):
Renamed SVGDocumentExtensions::hasPendingResources -> Renamed SVGDocumentExtensions::hasPendingResource.
Renamed SVGDocumentExtensions::isElementInPendingResources -> SVGDocumentExtensions::isElementPendingResources.
Added support for querying and removing pending resources for a specific element.

svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::buildPendingResource):
Refactored to support multiple pending resources.

LayoutTests:

svg/custom/use-crash-pending-resource-expected.txt: Added.
svg/custom/use-crash-pending-resource.svg: Added.

12:51 AM Changeset in webkit [105572] by commit-queue@webkit.org

4 edits in trunk

REGRESSION (Safari 5.0.5 - ToT): crash in SVG test http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectApproved/animate-elem-39-t.html
https://bugs.webkit.org/show_bug.cgi?id=64671

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-21
Reviewed by Nikolas Zimmermann.

Source/WebCore:

No new tests. This change is to fix crashes in existing tests.

svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::beginListChanged): If the new begin time is
later than the current end time, and the event time is also after then
end time (but we have not yet updated to that time) and the animation
is active, we need to make the animation inactive explicitly.

LayoutTests:

platform/chromium/test_expectations.txt: Marking all svg/W3C-SVG-1.1/animate-elem* tests

as flakey pending this change being committed and new results.

12:42 AM Changeset in webkit [105571] by timothy@apple.com

4 edits in trunk/Source/WebKit2

Make WebKit2 remember the height of the Web Inspector when it is docked.

https://webkit.org/b/76769

Reviewed by Dan Bernstein.

Shared/WebPreferencesStore.h: Added InspectorAttachedHeight.
UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::setAttachedWindowHeight): Call WebPreferencesStore::setInspectorAttachedHeight.

UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformAttach): Set the height of the inspector's WKView to inspectorAttachedHeight.
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight): Remove unneeded setNeedsDisplay: calls.

12:17 AM Changeset in webkit [105570] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

PopupMenuClient::multiple() should be const
https://bugs.webkit.org/show_bug.cgi?id=76771

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-21
Reviewed by Kent Tamura.

platform/PopupMenuClient.h:

(WebCore::PopupMenuClient::multiple):

rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::multiple):

rendering/RenderMenuList.h:

Jan 20, 2012:

10:06 PM Changeset in webkit [105569] by commit-queue@webkit.org

6 edits
4 adds in trunk/Source/WebCore

Switch indexeddb to use supplemental IDL for DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=76723

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-01-20
Reviewed by Adam Barth.

No new tests required, all existing tests pass.

Modules/indexeddb: Added.
Modules/indexeddb/DOMWindowIndexedDatabase.cpp: Added. webkitIndexedDB() method previously in DOMWindow.cpp

(WebCore::DOMWindowIndexedDatabase::DOMWindowIndexedDatabase):
(WebCore::DOMWindowIndexedDatabase::~DOMWindowIndexedDatabase):
(WebCore::DOMWindowIndexedDatabase::webkitIndexedDB):

Modules/indexeddb/DOMWindowIndexedDatabase.h: Added.
Modules/indexeddb/DOMWindowIndexedDatabase.idl: Added. attributes previously in DOMWindow.idl
WebCore.gyp/WebCore.gyp: add Modules/indexeddb/ directory
WebCore.gypi: add Modules/indexeddb/*
page/DOMWindow.cpp: remove webkitIndexedDB() method, add accessor methods for m_idbFactory

(WebCore::DOMWindow::getIDBFactory):
(WebCore::DOMWindow::setIDBFactory):

page/DOMWindow.h:
page/DOMWindow.idl:

8:11 PM Changeset in webkit [105568] by levin@chromium.org

2 edits in trunk/Source/WebCore

Allow isContextThread to be called while in ~ScriptExecutionContext.
https://bugs.webkit.org/show_bug.cgi?id=76756

Reviewed by Adam Barth.

It is possible for objects to get torn down or get called from ~ScriptExecutionContext
and in turn call isContextThread. The resulting behavior is undefined. This change defines
the behavior. I don't know of any places that do this but I have a test that is rarely
failing due to isContextThread being false. This is my best guess as to why, and I
don't see a reason to try to avoid calling isContextThread at this point.

No new functionality exposed so no new tests.

dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::isContextThread):

7:32 PM Changeset in webkit [105567] by levin@chromium.org

3 edits in trunk/Tools

The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
https://bugs.webkit.org/show_bug.cgi?id=76752

Reviewed by Eric Seidel.

Scripts/webkitpy/style/checkers/cpp.py:

(check_for_leaky_patterns):

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(LeakyPatternTest.test_create_dc):
(LeakyPatternTest.test_create_compatible_dc):

7:19 PM Changeset in webkit [105566] by commit-queue@webkit.org

6 edits in trunk/Source

[chromium] Write unit tests for compositor-thread zooming
https://bugs.webkit.org/show_bug.cgi?id=71529

Patch by Alexandre Elias <aelias@google.com> on 2012-01-20
Reviewed by James Robinson.

Add unit tests for pinch zoom and page scale animation. Includes
small cleanups in CCLayerTreeHostImpl for testability.

Source/WebCore:

platform/graphics/chromium/cc/CCInputHandler.h:
platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::setViewportSize):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Source/WebKit/chromium:

tests/CCLayerTreeHostImplTest.cpp:

(WebKit::CCLayerTreeHostImplTest::setupScrollAndContentsLayers):
(WebKit::TEST_F):

7:03 PM Changeset in webkit [105565] by ostapenko.viatcheslav@nokia.com

2 edits in trunk/Source/WebKit2

[Qt] [WK2] Division by zero error in QtViewportInteractionEngine::setItemRectVisible
https://bugs.webkit.org/show_bug.cgi?id=76674

Reviewed by Kenneth Rohde Christiansen.

Make sure that itemRect is not empty.

UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::setItemRectVisible):

6:49 PM Changeset in webkit [105564] by commit-queue@webkit.org

13 edits in trunk/Source

[Chromium] Incremental texture updates are not atomic.
https://bugs.webkit.org/show_bug.cgi?id=72672

Patch by David Reveman <reveman@chromium.org> on 2012-01-20
Reviewed by James Robinson.

Source/WebCore:

Use a new set of textures for each commit when incremental
texture updates are enabled.

This patch is tested by the following unit test:

CCLayerTreeHostTestAtomicCommit.runMultiThread

platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::ManagedTexture):
(WebCore::ManagedTexture::steal):

platform/graphics/chromium/ManagedTexture.h:
platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::deleteTextureAfterCommit):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

platform/graphics/chromium/cc/CCProxy.h:
platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(WebCore::CCSingleThreadProxy::partialTextureUpdateCapability):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::partialTextureUpdateCapability):

platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

Add CCLayerTreeHostTestAtomicCommit test that verifies atomicity
of commits.

tests/CCLayerTreeHostTest.cpp:

tests/CompositorFakeWebGraphicsContext3D.h:

6:35 PM Changeset in webkit [105563] by eae@chromium.org

720 edits in branches/subpixellayout/Source

Merge missing trunk changes (up until 105194) into branch.

6:34 PM Changeset in webkit [105562] by crogers@google.com

2 edits in trunk/Source/WebCore

De-zippering incorrectly snaps to target gain
https://bugs.webkit.org/show_bug.cgi?id=76741

Reviewed by Kenneth Russell.

platform/audio/AudioBus.cpp:

6:21 PM Changeset in webkit [105561] by commit-queue@webkit.org

3 edits
4 adds in trunk

[chromium] Partially filled pixels do not occlude pixels below them.
https://bugs.webkit.org/show_bug.cgi?id=76658

Patch by Dana Jansens <danakj@chromium.org> on 2012-01-20
Reviewed by James Robinson.

Source/WebCore:

Test: compositing/culling/tile-occlusion-boundaries.html

platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::enclosedIntRect):
(WebCore::CCQuadCuller::cullOccludedQuads):

LayoutTests:

compositing/culling/tile-occlusion-boundaries-expected.png: Added.
compositing/culling/tile-occlusion-boundaries-expected.txt: Added.
compositing/culling/tile-occlusion-boundaries.html: Added.
compositing/resources/green.jpg: Added.

6:06 PM Changeset in webkit [105560] by shawnsingh@chromium.org

2 edits in trunk/Tools

Changed my status in commiters.py

Unreviewed.

Scripts/webkitpy/common/config/committers.py:

5:34 PM Changeset in webkit [105559] by commit-queue@webkit.org

4 edits in trunk/Source

Small cleanup of {get,put}CurrentFrame for WebMediaPlayerClientImpl/CCVideoLayerImpl.
https://bugs.webkit.org/show_bug.cgi?id=76332

Patch by Ami Fischman <fischman@chromium.org> on 2012-01-20
Reviewed by James Robinson.

Source/WebCore:

platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::draw):

Source/WebKit/chromium:

src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):

5:16 PM Changeset in webkit [105558] by sfalken@apple.com

2 edits in trunk/Source/WebKit2

Drag/drop of a file into a WebView on Windows needs to allow access to that file
https://bugs.webkit.org/show_bug.cgi?id=76753
<rdar://problem/10731719>

Reviewed by Alexey Proskuryakov.

The Windows drag/drop code path was missing the code to open a file read exception.

Added code to match the Mac version, while allowing directories and multiple files to
also be dragged (matching our previous behavior).

UIProcess/win/WebView.cpp:

(WebKit::maybeCreateSandboxExtensionFromDragData): Added.
(WebKit::WebView::Drop): Add a universal read exception if we're dragging a file into a WebView to open it.

5:11 PM Changeset in webkit [105557] by abarth@webkit.org

1 edit
1 add in trunk/LayoutTests

Add a Chromium-specific baselines for
fast/dom/Window/open-invalid-url.html. Although this expected result
says "FAIL", the behavior seems to be reasonable.

platform/chromium/fast/dom/Window/open-invalid-url-expected.txt: Added.

4:45 PM Changeset in webkit [105556] by beidson@apple.com

2 edits in trunk/Source/WebCore

<rdar://problem/9328684> and https://bugs.webkit.org/show_bug.cgi?id=62764 Frequent crashes due to null frame below ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache

Reviewed by Sam Weinig.

No way to reproduce without special malloc debugging and that doesn't even reproduce on all platforms. So still no test.

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::detachFromFrame): Protect m_frame for the duration of this method.

4:36 PM Changeset in webkit [105555] by levin@chromium.org

3 edits in trunk/Source/JavaScriptCore

Make OwnPtr<HDC> work for the Chromium Windows port.
https://bugs.webkit.org/show_bug.cgi?id=76738

Reviewed by Jian Li.

JavaScriptCore.gyp/JavaScriptCore.gyp: Added OwnPtrWin.cpp to the

Chromium Windows build.

wtf/OwnPtrCommon.h: Changed from platform WIN to OS WIN for

OwnPtr<HDC> and similar constructs.

4:09 PM Changeset in webkit [105554] by ap@apple.com

2 edits in trunk/Source/WebCore

WebCore should not send invalid URLs to client createWindow methods.
https://bugs.webkit.org/show_bug.cgi?id=39017

Unreviewed test fix.

page/DOMWindow.cpp: (WebCore::DOMWindow::createWindow): Let empty URLs through.

4:05 PM Changeset in webkit [105553] by rniwa@webkit.org

2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from 118291 to 118493.

DEPS:

4:03 PM Changeset in webkit [105552] by weinig@apple.com

23 edits in trunk/Source

Make WebCore RunLoop work for WebKit1
https://bugs.webkit.org/show_bug.cgi?id=76739

Reviewed by Anders Carlsson.

Source/WebCore:

platform/RunLoop.cpp:

Specialize RunLoop initialization for Mac, where it can happen on any thread.

platform/RunLoop.h:

Add RunLoop constructor that takes a CFRunLoopRef on the mac for initializing
the main thread.

platform/mac/RunLoopMac.mm:

(WebCore::RunLoop::initializeMainRunLoop):
Add new implementation that can work from any thread (and multiple threads at the
same time if necessary).

(WebCore::RunLoop::current):
Treat the main thread specially, not storing it in thread specific data.

(WebCore::RunLoop::main):
Copy main accessor since it needs access to the file static.

(WebCore::RunLoop::RunLoop):
Add constructor which takes a CFRunLoopRef.

Source/WebKit/mac:

Carbon/CarbonWindowAdapter.mm:

(+[CarbonWindowAdapter initialize]):

History/WebBackForwardList.mm:

(+[WebBackForwardList initialize]):

History/WebHistoryItem.mm:

(+[WebHistoryItem initialize]):

Misc/WebElementDictionary.mm:

(+[WebElementDictionary initialize]):

Misc/WebIconDatabase.mm:

(+[WebIconDatabase initialize]):

Plugins/Hosted/WebHostedNetscapePluginView.mm:

(+[WebHostedNetscapePluginView initialize]):

Plugins/WebBaseNetscapePluginView.mm:
Plugins/WebBasePluginPackage.mm:
Plugins/WebNetscapePluginView.mm:

(+[WebNetscapePluginView initialize]):

WebCoreSupport/WebEditorClient.mm:

(+[WebUndoStep initialize]):

WebCoreSupport/WebFrameLoaderClient.mm:
WebView/WebArchive.mm:

(+[WebArchivePrivate initialize]):

WebView/WebDataSource.mm:

(+[WebDataSourcePrivate initialize]):

WebView/WebHTMLView.mm:

(+[WebHTMLViewPrivate initialize]):
(+[WebHTMLView initialize]):

WebView/WebResource.mm:

(+[WebResourcePrivate initialize]):

WebView/WebTextIterator.mm:

(+[WebTextIteratorPrivate initialize]):

WebView/WebView.mm:

(+[WebView initialize]):

WebView/WebViewData.mm:

(+[WebViewPrivate initialize]):
Initialized the main run loop in addition to other initialization.

3:47 PM Changeset in webkit [105551] by ojan@chromium.org

2 edits in trunk/Tools

run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
https://bugs.webkit.org/show_bug.cgi?id=76748

Reviewed by Ryosuke Niwa.

It crawls the whole subtree and then doesn't use the data. Cutting this out
saves 4 seconds warm and 17 seconds cold on my Mac Pro.

Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(run):

3:36 PM Changeset in webkit [105550] by abarth@webkit.org

2 edits in trunk/Tools

Another tiny tweak to the garden-o-matic CSS. This makes things line
up slightly nicer when there aren't any failures.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:

(#summary):

3:23 PM Changeset in webkit [105549] by timothy_horton@apple.com

4 edits
2 adds in trunk

Crash in RenderSVGResourceContainer::markAllClientsForInvalidation
https://bugs.webkit.org/show_bug.cgi?id=76606
<rdar://problem/10720970>

Reviewed by Dirk Schulze.

Notify SVGResourcesCache and superclass when RenderSVGInline is about
to be destroyed, preventing a crash.

Test: svg/custom/crash-inline-container-client.html

rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::willBeDestroyed):

rendering/svg/RenderSVGInline.h:

svg/custom/crash-inline-container-client-expected.txt: Added.
svg/custom/crash-inline-container-client.html: Added.

3:22 PM Changeset in webkit [105548] by ap@apple.com

3 edits
2 adds in trunk

WebCore should not send invalid URLs to client createWindow methods.
https://bugs.webkit.org/show_bug.cgi?id=39017

Reviewed by Sam Weinig.

Test: fast/dom/window/open-invalid-url.html

page/DOMWindow.cpp: (WebCore::DOMWindow::createWindow): Bail out early for invalid URLs.

3:21 PM Changeset in webkit [105547] by rniwa@webkit.org

2 edits in trunk/Source/WebKit/chromium

Revert r105545. Something got broken about gclient/gyp but I can't figure out what.

DEPS:

3:00 PM Changeset in webkit [105546] by caio.oliveira@openbossa.org

2 edits in trunk/Source/WebCore

Remove unused variable in RenderReplaced after r105513
https://bugs.webkit.org/show_bug.cgi?id=76742

Reviewed by Daniel Bates.

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):

2:59 PM Changeset in webkit [105545] by rniwa@webkit.org

2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from 118291 to 118530.

DEPS:

2:49 PM Changeset in webkit [105544] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[chromium] Plumb damage from accelerated canvas 2D.
https://bugs.webkit.org/show_bug.cgi?id=76728

Patch by Jonathan Backer <backer@chromium.org> on 2012-01-20
Reviewed by Kenneth Russell.

platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::contentChanged):

2:17 PM Changeset in webkit [105543] by rniwa@webkit.org

5 edits in trunk/Tools

run-perf-tests should support --test-results-server option
https://bugs.webkit.org/show_bug.cgi?id=76680

Reviewed by Adam Barth.

Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
to be used by perf bots. Also refactor file_uploader as needed.

Scripts/webkitpy/common/net/file_uploader.py:

(FileUploader.init):
(FileUploader.upload_single_file):
(FileUploader.upload_as_multipart_form_data):
(FileUploader):
(FileUploader._upload_data):
(FileUploader._upload_data.callback):

Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase.upload_json_files):

Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):
(PerfTestsRunner._parse_args):
(PerfTestsRunner.run):
(PerfTestsRunner._generate_json):
(PerfTestsRunner._upload_json):
(PerfTestsRunner._run_tests_set):

Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(create_runner):
(test_run_with_upload_json):
(test_run_with_upload_json.mock_upload_json):
(test_upload_json):
(test_upload_json.MockFileUploader):
(test_upload_json.MockFileUploader.init):
(test_upload_json.MockFileUploader.upload_single_file):
(test_parse_args):

2:16 PM Changeset in webkit [105542] by jchaffraix@webkit.org

4 edits
2 adds in trunk

Crash in RenderTable::borderBefore
https://bugs.webkit.org/show_bug.cgi?id=75215

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/table/crash-beforeBorder-dirty-section.html

This is a regression from r97661 that added some calls to get the object's borders but tables are a
special case and they may need to recompute some sections' pointers.

The whole sections' pointers lazy recomputation logic is unfortunately far from being bullet proof and
this change is only a mitigation for the current crash.

rendering/RenderTable.cpp:

(WebCore::RenderTable::borderBefore):
(WebCore::RenderTable::borderAfter):
Make sure we recompute our sections. The change was made here to avoid hitting the
path used inside the table code (ie outerBorder{Before|After}) that shouldn't be
affected.

rendering/RenderTable.h:

(WebCore::RenderTable::topSection):
Added an ASSERT to catch more bad use in the future.

LayoutTests:

fast/table/crash-beforeBorder-dirty-section-expected.txt: Added.
fast/table/crash-beforeBorder-dirty-section.html: Added.

2:10 PM Changeset in webkit [105541] by leviw@chromium.org

14 edits in branches/subpixellayout/Source

Fixing widget painting on all platforms, and fixing an issue where nested NSViews were handed a subpixel value for the visible area. Correcting an enclosingIntRect usage in PaintInfo. Cleaning up some unnecessary changes to shrink patch noise.

1:19 PM Changeset in webkit [105540] by Simon Fraser

3 edits in trunk/Source/WebKit/mac

https://bugs.webkit.org/show_bug.cgi?id=76444

This breaks builds.

WebView/WebPreferences.mm:
WebView/WebPreferencesPrivate.h:

1:05 PM Changeset in webkit [105539] by ggaren@apple.com

7 edits in trunk/Source/JavaScriptCore

Removed some regexp entry boilerplate code
https://bugs.webkit.org/show_bug.cgi?id=76687

Reviewed by Darin Adler.

1% - 2% speedup on regexp tests, no change overall.

runtime/RegExp.cpp:

(JSC::RegExp::match):

ASSERT that our startIndex is non-negative, because anything less would be uncivilized.

ASSERT that our input is not the null string for the same reason.

No need to test for startOffset being past the end of the string, since the regular expression engine will do this test for us.

No need to initialize the output vector, since the regular expression engine will fill it in for us.

yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::interpret):

yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::compile):

RegExp used to do these jobs for us, but now we do them for ourselves
because it's a better separation of concerns, and the JIT can do them
more efficiently than C++ code:

Test for "past the end" before doing any matching -- otherwise a* will match with zero length past the end of the string, which is wrong.

Initialize the output vector before doing any matching.

1:05 PM Changeset in webkit [105538] by commit-queue@webkit.org

3 edits
1 add in trunk

Add proper offset to position right click to simulate a context menu invocation.
https://bugs.webkit.org/show_bug.cgi?id=76421

Patch by Marc-Andre Decoste <mad@chromium.org> on 2012-01-20
Reviewed by Ojan Vafai.

ManualTests/win/contextmenu-key3.html: Added.

Source/WebCore:

Manual tests only because DRT doesn't support context menu key.

page/EventHandler.cpp:

(WebCore::EventHandler::sendContextMenuEventForKey):

1:01 PM Changeset in webkit [105537] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

Build fix for no-DFG configuration.
Needed for <rdar://problem/10727689>.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitProfiledOpcode):

jit/JIT.h:

(JSC::JIT::emitValueProfilingSite):

12:55 PM Changeset in webkit [105536] by abarth@webkit.org

2 edits in trunk/Tools

The party time image overlaps real content! This patch makes the
image centered vertically.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:

(#onebar.partytime #summary):

12:40 PM Changeset in webkit [105535] by ojan@chromium.org

6 edits in trunk/Tools

Refactor TestExpectationsParser in preparation for caching the results
https://bugs.webkit.org/show_bug.cgi?id=76669

Reviewed by Dimitri Glazkov.

Make everything private expect for the parse method.
Eventually, we'll need the expectations lines to not be modified
outside of TestExpectationsParser so we can cache the results.
This makes check-webkit-style of the chromium test_expectations.txt file
go from ~17 seconds to ~12 seconds on my Mac Pro.

This patch is just a refactor in preparation, so no new tests.

Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:

(TestExpectationEditorTests.make_parsed_expectation_lines):

Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser.parse):
(TestExpectationParser):
(TestExpectationParser._parse_line):
(TestExpectationParser._tokenize):
(TestExpectationParser._tokenize_list):
(TestExpectationsModel._clear_expectations_for_test):
(TestExpectations.init):
(TestExpectations._add_expectations):
(TestExpectations._add_skipped_tests):

Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(TestExpectationParserTests.test_tokenize_blank):
(TestExpectationParserTests.test_tokenize_missing_colon):
(TestExpectationParserTests.test_tokenize_extra_colon):
(TestExpectationParserTests.test_tokenize_empty_comment):
(TestExpectationParserTests.test_tokenize_comment):
(TestExpectationParserTests.test_tokenize_missing_equal):
(TestExpectationParserTests.test_tokenize_extra_equal):
(TestExpectationParserTests.test_tokenize_valid):
(TestExpectationParserTests.test_tokenize_valid_with_comment):
(TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
(TestExpectationParserTests.test_parse_empty_string):
(TestExpectationSerializerTests.assert_round_trip):
(TestExpectationSerializerTests.assert_list_round_trip):

Scripts/webkitpy/tool/commands/expectations.py:

(OptimizeExpectations.execute):

Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningExpectationsUpdater.update_expectations):

12:22 PM Changeset in webkit [105534] by abarth@webkit.org

3 edits in trunk/Tools

Follow-up to previous patch: don't produce NaN when the revision number
is missing.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:

12:22 PM Changeset in webkit [105533] by fpizlo@apple.com

20 edits in trunk/Source/JavaScriptCore

Bytecode instructions that may have value profiling should have a direct inline
link to the ValueProfile instance
https://bugs.webkit.org/show_bug.cgi?id=76682
<rdar://problem/10727689>

Reviewed by Sam Weinig.

Each opcode that gets value profiled now has a link to its ValueProfile. This
required rationalizing the emission of value profiles for opcode combos, like
op_method_check/op_get_by_id and op_call/op_call_put_result. It only makes
sense for one of them to have a value profile link, and it makes most sense
for it to be the one that actually sets the result. The previous behavior was
to have op_method_check profile for op_get_by_id when they were used together,
but otherwise for op_get_by_id to have its own profiles. op_call already did
the right thing; all profiling was done by op_call_put_result.

But rationalizing this code required breaking some of the natural boundaries
that the code had; for instance the code in DFG that emits a GetById in place
of both op_method_check and op_get_by_id must now know that it's the latter of
those that has the value profile, while the first of those constitutes the OSR
target. Hence each CodeOrigin must now have two bytecode indices - one for
OSR exit and one for profiling.

Finally this change required some refiddling of our optimization heuristics,
because now all code blocks have "more instructions" due to the value profile
slots.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::dump):

bytecode/CodeBlock.h:

(JSC::CodeBlock::valueProfileForBytecodeOffset):

bytecode/CodeOrigin.h:

(JSC::CodeOrigin::CodeOrigin):
(JSC::CodeOrigin::bytecodeIndexForValueProfile):

bytecode/Instruction.h:

(JSC::Instruction::Instruction):

bytecode/Opcode.h:
bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitProfiledOpcode):
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitGetScopedVar):
(JSC::BytecodeGenerator::emitResolveBase):
(JSC::BytecodeGenerator::emitResolveBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitResolveWithThis):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitConstruct):

bytecompiler/BytecodeGenerator.h:
dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):

dfg/DFGGraph.h:

(JSC::DFG::Graph::valueProfileFor):

jit/JIT.h:

(JSC::JIT::emitValueProfilingSite):

jit/JITCall.cpp:

(JSC::JIT::emit_op_call_put_result):

jit/JITCall32_64.cpp:

(JSC::JIT::emit_op_call_put_result):

jit/JITInlineMethods.h:

(JSC::JIT::emitValueProfilingSite):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
(JSC::JIT::emitSlow_op_resolve_global_dynamic):

jit/JITOpcodes32_64.cpp:

jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emitSlow_op_method_check):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_get_global_var):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_method_check):
(JSC::JIT::emitSlow_op_method_check):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_get_global_var):

jit/JITStubCall.h:

(JSC::JITStubCall::callWithValueProfiling):

runtime/Options.cpp:

(JSC::Options::initializeOptions):

12:21 PM Changeset in webkit [105532] by commit-queue@webkit.org

4 edits in trunk

Unreviewed, rolling out r105426.
http://trac.webkit.org/changeset/105426
https://bugs.webkit.org/show_bug.cgi?id=76726

Might have caused a 20% regression in the PLT (Requested by
abarth|gardener on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-20

Source/WebCore:

rendering/RenderObject.h:

(WebCore::RenderObject::style):

LayoutTests:

platform/mac-snowleopard/Skipped:

12:08 PM Changeset in webkit [105531] by commit-queue@webkit.org

17 edits in trunk/Source

[chromium] Revert a couple of changes in fileapi/ that break tests in chromeos.
https://bugs.webkit.org/show_bug.cgi?id=76718

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-01-20
Reviewed by Darin Fisher.

Source/WebCore:

fileapi/BlobURL.cpp:

(WebCore::BlobURL::getIdentifier):
(WebCore::BlobURL::createBlobURL):

fileapi/BlobURL.h:

(WebCore::BlobURL::blobProtocol):

fileapi/DOMFileSystemBase.cpp:

(WebCore::DOMFileSystemBase::crackFileSystemURL):

fileapi/DOMFileSystemBase.h:
fileapi/EntryBase.cpp:

(WebCore::EntryBase::toURL):

fileapi/FileWriter.cpp:

(WebCore::FileWriter::write):
(WebCore::FileWriter::truncate):

page/DOMWindow.cpp:

(WebCore::DOMWindow::webkitRequestFileSystem):

page/DOMWindow.h:
platform/AsyncFileSystem.cpp:
platform/AsyncFileSystem.h:
workers/WorkerContext.cpp:

(WebCore::WorkerContext::webkitRequestFileSystem):
(WebCore::WorkerContext::webkitRequestFileSystemSync):

Source/WebKit/chromium:

public/platform/WebFileSystem.h:
src/AssertMatchingEnums.cpp:
src/AsyncFileSystemChromium.cpp:
src/AsyncFileSystemChromium.h:

11:44 AM Changeset in webkit [105530] by abarth@webkit.org

4 edits in trunk/Tools

Garden-o-matic should tell me which revisions have been checked by all the bots
https://bugs.webkit.org/show_bug.cgi?id=76722

Reviewed by Dimitri Glazkov.

This information helps me know when it's safe for me to roll a
candidate revision.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:

11:23 AM Changeset in webkit [105529] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Refactor canvas drawing to be more data driven
https://bugs.webkit.org/show_bug.cgi?id=76635

CCCanvasLayerImpl no longer handles drawing itself, but produces a list of CCCanvasDrawQuads.
These quads are then drawn by LayerRendererChromium.

This is a refactor, so no new tests were added.

Patch by Tim Dresser <tdresser@chromium.org> on 2012-01-20
Reviewed by James Robinson.

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawCanvasQuad):

platform/graphics/chromium/cc/CCCanvasDrawQuad.cpp:

(WebCore::CCCanvasDrawQuad::create):
(WebCore::CCCanvasDrawQuad::CCCanvasDrawQuad):

platform/graphics/chromium/cc/CCCanvasDrawQuad.h:

(WebCore::CCCanvasDrawQuad::textureId):
(WebCore::CCCanvasDrawQuad::hasAlpha):
(WebCore::CCCanvasDrawQuad::premultipliedAlpha):

platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:

(WebCore::CCCanvasLayerImpl::appendQuads):

platform/graphics/chromium/cc/CCCanvasLayerImpl.h:

11:08 AM Changeset in webkit [105528] by fsamuel@chromium.org

4 edits in trunk/Source/WebKit/chromium

[Chromium] Do not recompute viewport on same page navigation
https://bugs.webkit.org/show_bug.cgi?id=75576

Reviewed by Darin Fisher.

Added parameter isNavigationWithinPage to WebViewImpl::didCommitLoad
that indicates whether a same-page navigation has just occurred.

The page scale factor flag is reset only on navigation to a new page.
If the flag is not set, viewport and page scale will be recomputed on
layoutUpdated.

src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
(WebKit::FrameLoaderClientImpl::dispatchDidCommitLoad):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::didCommitLoad):
(WebKit::WebViewImpl::observeNewNavigation):

src/WebViewImpl.h:

11:06 AM Changeset in webkit [105527] by abarth@webkit.org

1 edit
5 adds in trunk/LayoutTests

Add new baselines for a test introduced in
http://trac.webkit.org/changeset/105515. These all appear to be
correct.

platform/chromium-linux/fast/borders/scaled-border-image-expected.png: Added.
platform/chromium-mac-leopard/fast/borders/scaled-border-image-expected.png: Added.
platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png: Added.
platform/chromium-win/fast/borders/scaled-border-image-expected.png: Added.
platform/chromium-win/fast/borders/scaled-border-image-expected.txt: Added.

11:03 AM Changeset in webkit [105526] by abarth@webkit.org

10 edits
9 adds
23 deletes in trunk/LayoutTests

Update baselines after http://trac.webkit.org/changeset/105513. Even
though these results look different on different platforms, the tests
seem to be aiming for the two boxes to look the same, which they do.

Also, removed some redundant results.

platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
platform/chromium-mac-leopard/tables/mozilla/bugs/bug101674-expected.png:
platform/chromium-mac-leopard/tables/mozilla/bugs/bug86708-expected.png:
platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/97619-expected.png:
platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png:
platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png:
platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png:
platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug101674-expected.png: Added.
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug86708-expected.png: Added.
platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/97619-expected.png: Added.
platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png: Removed.
platform/chromium-mac/tables/mozilla/bugs/bug86708-expected.png: Removed.
platform/chromium-mac/tables/mozilla_expected_failures/bugs/97619-expected.png: Removed.
platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.

10:52 AM Changeset in webkit [105525] by abarth@webkit.org

2 edits in trunk/LayoutTests

This test fails.

platform/chromium/test_expectations.txt:

10:17 AM Changeset in webkit [105524] by inferno@chromium.org

3 edits
2 adds in trunk

Crash in xsltParseGlobalVariable.
https://bugs.webkit.org/show_bug.cgi?id=75978

Reviewed by Andreas Kling.

Source/WebCore:

The code missed to reset the stylesheet pointer after we fail
to compile the XSLT stylesheet. As a result, the stylesheet gets
reused with a removed document in the next transformToFragment call.

Test: fast/xsl/xslt-transform-to-fragment-crash.html

xml/XSLTProcessorLibxslt.cpp:

(WebCore::XSLTProcessor::transformToString):

LayoutTests:

fast/xsl/xslt-transform-to-fragment-crash-expected.txt: Added.
fast/xsl/xslt-transform-to-fragment-crash.html: Added.

9:36 AM Changeset in webkit [105523] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][WK2] REGRESSION(r105517): It made 49 tests timeout
https://bugs.webkit.org/show_bug.cgi?id=76708

platform/qt-wk2/Skipped: Typo fix after last change.

9:35 AM Changeset in webkit [105522] by vestbo@webkit.org

2 edits in trunk/Tools

build-webkit: Don't spit out congratulations message on Ctrl+C

Reviewed by Andreas Kling.

9:07 AM Changeset in webkit [105521] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][WK2] REGRESSION(r105517): It made 49 tests timeout
https://bugs.webkit.org/show_bug.cgi?id=76708

platform/qt-wk2/Skipped: Skip failing tests to paint the bot green.

9:06 AM Changeset in webkit [105520] by Philippe Normand

4 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r105486.

fast/dom/constructed-objects-prototypes-expected.txt:
platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
platform/gtk/fast/js/global-constructors-expected.txt:

8:49 AM Changeset in webkit [105519] by Philippe Normand

2 edits in trunk/Tools

[GTK] Allow extra jhbuild modulesets
https://bugs.webkit.org/show_bug.cgi?id=76691

Reviewed by Gustavo Noronha Silva.

gtk/jhbuildrc: Extra modulesets and modules can be added in

JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
env variables respectively. Use comma-separated values. Example:
WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.

8:32 AM Changeset in webkit [105518] by Csaba Osztrogonác

22 edits in trunk/LayoutTests

Differentiate between SVG/CSS width/height attributes/properties
https://bugs.webkit.org/show_bug.cgi?id=76447

Unreviewed gardening after r105513, update Qt specific results.

platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png:
platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt:
platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png:
platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt:
platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png:
platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt:
platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png:
platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
platform/qt/svg/wicd/rightsizing-grid-expected.png:
platform/qt/svg/wicd/rightsizing-grid-expected.txt:
platform/qt/tables/mozilla/bugs/bug101674-expected.png:
platform/qt/tables/mozilla/bugs/bug101674-expected.txt:
platform/qt/tables/mozilla/bugs/bug86708-expected.png:
platform/qt/tables/mozilla/bugs/bug86708-expected.txt:
platform/qt/tables/mozilla_expected_failures/bugs/97619-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/97619-expected.txt:

8:24 AM Changeset in webkit [105517] by jocelyn.turcotte@nokia.com

9 edits in trunk/Source/WebKit2

[Qt] Trigger forcing accelerated compositing from the UI process side.
https://bugs.webkit.org/show_bug.cgi?id=76296

Reviewed by Noam Rosenthal.

Some messages can be sent from the web view to the LayerTreeHost before
accelerated compositing is entered on the web process and signaled back.
By letting the UI process decide if AC has to be forced, we can create
the LayerTreeHostProxy earlier to send messages to the web process while
AC is being entered there.

This patch also fixes the flow of DidRenderFrame and RenderNextFrame messages
by setting the m_waitingForUIProcess flag properly and only send the
RenderNextFrame once the painting thread on the UI process is ready to paint.

This fixes the first visible content rect message not being received when
loading pages from the disk.

Shared/WebPreferencesStore.h:
UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):

UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):

UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::flushLayerChanges):
(WebKit::LayerTreeHostProxy::didRenderFrame):

WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::performScheduledLayerFlush):

WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::platformInitialize):

7:56 AM Changeset in webkit [105516] by Nikolas Zimmermann

13 edits in trunk/LayoutTests

2012-01-20 Nikolas Zimmermann <nzimmermann@rim.com>

Differentiate between SVG/CSS width/height attributes/properties
https://bugs.webkit.org/show_bug.cgi?id=76447

Not reviewed. Rebaseline gtk results.

platform/gtk/fast/block/float/015-expected.txt:
platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt:
platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt:
platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt:
platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
platform/gtk/svg/custom/use-font-face-crash-expected.txt:
platform/gtk/svg/wicd/rightsizing-grid-expected.txt:
platform/gtk/tables/mozilla/bugs/bug101674-expected.txt:
platform/gtk/tables/mozilla/bugs/bug86708-expected.txt:
platform/gtk/tables/mozilla_expected_failures/bugs/97619-expected.txt:

7:51 AM Changeset in webkit [105515] by Nikolas Zimmermann

3 edits
3 adds in trunk

REGRESSION (r98852): apple.com navigation bar is broken under full-page zoom
https://bugs.webkit.org/show_bug.cgi?id=76249

Reviewed by Andreas Kling.

Source/WebCore:

Fix regression with full-page zoom & border-image. paintNinePieceImage() expects local, unzoomed coordinates.
Restore the behaviour as it was before r98852, fixing the regression.

Test: fast/borders/scaled-border-image.html

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintNinePieceImage):

LayoutTests:

Add new test covering zooming + border-image, which regressed.

fast/borders/scaled-border-image.html: Added.
platform/mac/fast/borders/scaled-border-image-expected.png: Added.
platform/mac/fast/borders/scaled-border-image-expected.txt: Added.

7:33 AM Changeset in webkit [105514] by mihnea@adobe.com

39 edits
3 adds in trunk

[CSSRegion]Expose DOM interface for WebKitCSSRegionRule
https://bugs.webkit.org/show_bug.cgi?id=73985

Reviewed by Antti Koivisto.

Source/WebCore:

Start by exposing the interface and the cssRules attribute of type CSSRuleList.
Test: fast/regions/webkit-region-rule.html

CMakeLists.txt:
DerivedSources.cpp:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSCSSRuleCustom.cpp:

(WebCore::toJS):

bindings/objc/DOMCSS.mm:

(kitClass):

bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::toV8):

css/WebKitCSSRegionRule.cpp:
css/WebKitCSSRegionRule.h:
css/WebKitCSSRegionRule.idl:
page/DOMWindow.idl:

LayoutTests:

Start by exposing the interface and the cssRules attribute of type CSSRuleList.

fast/dom/Window/window-properties-expected.txt:
fast/dom/Window/window-property-descriptors-expected.txt:
fast/dom/prototype-inheritance-2-expected.txt:
fast/regions/webkit-region-rule-expected.txt: Added.
fast/regions/webkit-region-rule.html: Added.
platform/gtk/fast/dom/Window/window-properties-expected.txt:
platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
platform/gtk/fast/js/global-constructors-expected.txt:
platform/mac/fast/dom/Window/window-properties-expected.txt:
platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
platform/mac/fast/js/global-constructors-expected.txt:
platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt:
platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
platform/qt-wk2/fast/dom/prototype-inheritance-2-expected.txt:
platform/qt/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
platform/qt/fast/js/global-constructors-expected.txt:
platform/win/fast/dom/Window/window-properties-expected.txt:
platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
platform/win/fast/dom/prototype-inheritance-2-expected.txt:
platform/win/fast/js/global-constructors-expected.txt:

7:30 AM Changeset in webkit [105513] by Nikolas Zimmermann

58 edits in trunk

Differentiate between SVG/CSS width/height attributes/properties
https://bugs.webkit.org/show_bug.cgi?id=76447

Reviewed by Antti Koivisto.

Source/WebCore:

Remove a gazillion of hacks out of our SVG implementation, by correctly differentiating between the
SVG width/height attributes and the CSS width/height properties. They need to be treated independently
when handling the intrinsic size negotiation, according to both CSS 2.1 & SVG 1.1 2nd Edition specs.

Fixes several bugs in the LayoutTests/svg/custom/*object*sizing tests, we now match Opera perfectly. FF still has some bugs, and IE9 as well.

css/svg.css: Remove hardcoded, width/height: 100% on <svg>.
rendering/RenderBox.h:

(WebCore::RenderBox::computeIntrinsicRatioInformation): Make 'intrinsicRatio' a float, and add 'intrinsicSize' as seperated FloatSize, to avoid confusion.

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): Add forgotton case for percentage intrinsic sizes, that lead to workarounds in other places, that can now be removed.

rendering/RenderImage.cpp:

(WebCore::RenderImage::computeReplacedLogicalWidth): Directly use imageHasRelativeWidth/Height(), it does differentiate between SVG/CSS width/height attributes/properties now.
(WebCore::RenderImage::computeIntrinsicRatioInformation): Adapt to 'intrinsicRatio' argument change.

rendering/RenderImage.h: Ditto.
rendering/RenderReplaced.cpp: Refactor existing code, break out firstContainingBlockWithLogicalWidth/hasReplacedLogicalWidth/hasReplacedLogicalHeight/hasAutoHeightOrContainingBlockWithAutoHeight.

(WebCore::firstContainingBlockWithLogicalWidth): Refactored.
(WebCore::RenderReplaced::hasReplacedLogicalWidth): Refactored, and exported, so SVGSVGElement::widthAttributeEstablishesViewport() can use it.
(WebCore::hasAutoHeightOrContainingBlockWithAutoHeight): Refactored.
(WebCore::RenderReplaced::hasReplacedLogicalHeight): Refactored, and exported, so SVGSVGElement::heightAttributeEstablishesViewport() can use it.
(WebCore::RenderReplaced::computeReplacedLogicalWidth): Adapt to 'intrinsicRatio' changes ('intrinsicSize' is now decoupled from it). Refactor so that RenderSVGRoot can directly use it as well!
(WebCore::RenderReplaced::computeReplacedLogicalHeight): Ditto.

rendering/RenderReplaced.h:
rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeIntrinsicRatioInformation): Only determine the intrinsic size & ratio using the SVG width/height attributes, not the CSS width/height properties, as it's specified.
(WebCore::resolveLengthAttributeForSVG): Helper function for computeReplacedLogicalWidth/Height, that scales Length values that come from SVG width/height attributes.
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth): Finally remove home-brewn size computation logic - it can be fully shared with RenderReplaced now that we inherit from it.
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto.

rendering/svg/RenderSVGRoot.h:
rendering/svg/RenderSVGViewportContainer.h:

(WebCore::RenderSVGViewportContainer::viewport): Export viewport() for easier length resolution.

svg/SVGLengthContext.cpp:

(WebCore::SVGLengthContext::determineViewport): Finally clean up this hell, and make it easy to understand. Only need to resolve lengths against either RenderSVGRoot or RenderSVGViewportContainer now.

svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::viewport): Remove wrong code and disable this. Its not used, and we have no test coverage for it. Its current implementation didn't make any sense.
(WebCore::SVGSVGElement::parseMappedAttribute): Remove hacks mapping SVG width/height attributes to CSS properties.
(WebCore::SVGSVGElement::svgAttributeChanged): Ditto.
(WebCore::SVGSVGElement::localCoordinateSpaceTransform): Refactored.
(WebCore::SVGSVGElement::currentViewBoxRect): Ditto.
(WebCore::SVGSVGElement::currentViewportSize): Ditto.
(WebCore::SVGSVGElement::widthAttributeEstablishesViewport): Main logic determining if the SVG or CSS properties establish the viewport - a direct transliteration from the spec.
(WebCore::SVGSVGElement::heightAttributeEstablishesViewport): Ditto.
(WebCore::SVGSVGElement::intrinsicWidth): Helper.
(WebCore::SVGSVGElement::intrinsicHeight): Ditto.

svg/SVGSVGElement.h:
svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::size): Cleanup code.
(WebCore::SVGImage::hasRelativeWidth): Added, avoids hacks in RenderBoxModelObject.
(WebCore::SVGImage::hasRelativeHeight): Ditto.
(WebCore::SVGImage::computeIntrinsicDimensions): Make use of new SVGSVGElement::computeIntrinsicDimensions.

svg/graphics/SVGImage.h:

LayoutTests:

Update SVG pixel test baseline.

platform/mac/svg/custom/dynamic-empty-path-expected.png: Marginal changes.
platform/mac/svg/custom/fractional-rects-expected.png: Ditto.
platform/mac/svg/custom/js-update-container-expected.png: Ditto.
platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Align with Opera, gives same result now. All *object*sizing* tests are passing now.
platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Ditto.
platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Ditto.
platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Ditto.
platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Ditto.
platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Ditto.
platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Ditto.
platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Ditto.
platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Ditto.
platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Ditto.
platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Ditto.
platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Ditto.
platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.png: Marginal changes.
platform/mac/svg/custom/viewBox-hit-expected.png: Ditto.
platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Ditto.
platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.png: Ditto.
platform/mac/svg/zoom/page/zoom-background-images-expected.png: Ditto.
platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Ditto.
platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Ditto.
platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Ditto.
platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Ditto.
platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Ditto.
platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Ditto.
platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Ditto.
platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Ditto.
platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Ditto.
platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Ditto.
platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Ditto.
platform/mac/tables/mozilla/bugs/bug101674-expected.png: Ditto.
platform/mac/tables/mozilla/bugs/bug101674-expected.txt: Ditto.
platform/mac/tables/mozilla/bugs/bug86708-expected.png: Ditto.
platform/mac/tables/mozilla/bugs/bug86708-expected.txt: Ditto.
platform/mac/tables/mozilla_expected_failures/bugs/97619-expected.png: Ditto.
platform/mac/tables/mozilla_expected_failures/bugs/97619-expected.txt: Ditto.
svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute.xhtml: Fix test, now that our bug is fixed.
svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml: Ditto.
svg/custom/object-sizing-width-50p-on-target-svg-absolute.xhtml: Ditto.
svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute.xhtml: Ditto.
svg/foreignObject/text-tref-02-b-expected.txt: Size is not reported anymore.

7:03 AM Changeset in webkit [105512] by commit-queue@webkit.org

5 edits
4 adds in trunk

window.innerWidth/Height should not include page scale
https://bugs.webkit.org/show_bug.cgi?id=76555

Source/WebCore:

The DOM attributes window.innerWidth and window.innerHeight should be in
CSS pixels instead of device pixels. Currently the text zoom factor is
cancelled out when calculating these values, but the same also needs to
be done for the page scale.

There is an additional subtlety concerning frames/iframes since their
visible content rectangle is already in (unscaled) CSS pixels. By using
Frame::frameScaleFactor() we avoid unnecessarily cancelling out the page
scale factor in this case.

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-01-20
Reviewed by Kenneth Rohde Christiansen.

Tests: fast/dom/iframe-inner-size-scaling.html

fast/dom/window-inner-size-scaling.html

page/DOMWindow.cpp:

(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):

LayoutTests:

Add two tests for window.innerWidth and window.innerHeight interaction
with page scaling.

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-01-20
Reviewed by Kenneth Rohde Christiansen.

fast/dom/iframe-inner-size-scaling-expected.txt: Added.
fast/dom/iframe-inner-size-scaling.html: Added.
fast/dom/window-inner-size-scaling-expected.txt: Added.
fast/dom/window-inner-size-scaling.html: Added.
fast/frames/frame-set-rotation-hit.html: Calculate the panel height before changing the page scale, because the visual viewport changes with the page scale.
fast/frames/frame-set-scaling-hit.html: Ditto.

6:53 AM Changeset in webkit [105511] by Csaba Osztrogonác

2 edits
1 add in trunk/LayoutTests

[Qt] animations tests fails which uses suspend/resume
https://bugs.webkit.org/show_bug.cgi?id=43905

Patch by Alexis Menard <alexis.menard@openbossa.org> on 2012-01-20
Reviewed by Csaba Osztrogonác.

They seem to pass correctly on my machine.

platform/qt/Skipped:
platform/qt/animations/additive-transform-animations-expected.txt: Added.

6:49 AM Changeset in webkit [105510] by commit-queue@webkit.org

9 edits
2 adds in trunk/LayoutTests

new baselines for crbug 110493
https://bugs.webkit.org/show_bug.cgi?id=76629

Patch by Elliot Poger <epoger@google.com> on 2012-01-20
Reviewed by Dirk Pranke.

platform/chromium-linux/fast/borders/border-image-rotate-transform-expected.png:
platform/chromium-linux/svg/custom/focus-ring-expected.png:
platform/chromium-mac-leopard/svg/custom/focus-ring-expected.png:
platform/chromium-mac-leopard/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
platform/chromium-mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png:
platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png:
platform/chromium-mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
platform/chromium-win/fast/borders/border-image-rotate-transform-expected.png:
platform/chromium-win/svg/custom/focus-ring-expected.png:
platform/chromium/test_expectations.txt:

6:29 AM Changeset in webkit [105509] by kinuko@chromium.org

2 edits
1 delete in trunk

Unreviewed; Windows buildbot update failure fix.

../ManualTests/data-transfer-items-file-dragout.html: Removed the notion of test:lorem-text.html.
../ManualTests/resources/test:lorem-text.html: Removed as this doesn't work on Windows.

4:36 AM Changeset in webkit [105508] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

Unreviewed gardening. Skip failing tests.

platform/qt-wk2/Skipped: Skip tests because of https://bugs.webkit.org/show_bug.cgi?id=76699
platform/wk2/Skipped: Skip a test because of missing layoutTestController.setEditingBehavior

4:31 AM Changeset in webkit [105507] by pfeldman@chromium.org

2 edits in trunk/Source/WebKit/chromium

Web Inspector: [chromium] add WebDevToolsFrontendClient::openInNewTab for upcoming WebCore change.
https://bugs.webkit.org/show_bug.cgi?id=76698

Reviewed by Yury Semikhatsky.

public/WebDevToolsFrontendClient.h:

(WebKit::WebDevToolsFrontendClient::openInNewTab):

4:21 AM BuildingGtk edited by kov@webkit.org

Added libxtst-dev - needed for jhbuilding the at-spi bits required for … (diff)

4:08 AM Changeset in webkit [105506] by kinuko@chromium.org

30 edits
8 adds in trunk

Add DataTransferItems support for drag-and-drop'ed files and texts
https://bugs.webkit.org/show_bug.cgi?id=76367

Reviewed by Tony Chang.

WebKit-svn:

ManualTests/data-transfer-items-file-dragout.html: Added.
ManualTests/resources/test:lorem-text.html: Added.

WebKit-svn/LayoutTests:

editing/pasteboard/data-transfer-items-drag-drop-file-expected.txt: Added.
editing/pasteboard/data-transfer-items-drag-drop-file.html: Added.
editing/pasteboard/data-transfer-items-drag-drop-string-expected.txt: Added.
editing/pasteboard/data-transfer-items-drag-drop-string.html: Added.
platform/gtk/Skipped: Added the new tests as the platform does not support dataTransferItems yet.
platform/mac/Skipped: Ditto.
platform/qt/Skipped: Ditto.
platform/win/Skipped: Ditto.

WebKit-svn/Source/WebCore:

Per http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the-datatransfer-interface
the new interface should also support drag-and-dropped files and texts in
addition to pasted texts/images. The user apps should also be able to add
texts/files to the drag store by calling event.dataTransfer.items.add().

This patch adds drag-and-drop'ed items support in DataTransferItem and
DataTransferItemList so that they work for dropped files and texts (as well as
the copy-pasted texts/images).

This patch also adds customized toJS()/toV8() code to Blob/File javascript
binding so that the JS code can get either Blob or File underlying object
where the API returns Blob. This change is necessary since we return Blob
from DataTransferItem.getAsFile() for pasted images but want to return File
for dropped files.

Tests: editing/pasteboard/data-transfer-items-drag-drop-file.html

editing/pasteboard/data-transfer-items-drag-drop-string.html

GNUmakefile.list.am: Added entries for the new {JS,V8}BlobCustom.
Target.pri: Ditto.
UseJSC.cmake: Ditto.
WebCore.gypi: Ditto.
bindings/js/JSBindingsAllInOne.cpp: Ditto.
bindings/js/JSBlobCustom.cpp: Added toJS custom code that returns File or

Blob depending on the return value of isFile().
(WebCore::toJS):

bindings/v8/custom/V8BlobCustom.cpp: Added toV8 custom code.

(WebCore::toV8):

dom/DataTransferItem.h: Added a new create() method which takes File.
dom/DataTransferItemList.cpp: Added add(File) method.

(WebCore::DataTransferItemList::add):

dom/DataTransferItemList.h: Ditto.
dom/DataTransferItemList.idl: Ditto.
fileapi/Blob.idl: Added CustomToJS for toJS/toV8.
platform/chromium/ClipboardChromium.cpp: Added code for drag-and-drop'ed items.

(WebCore::ClipboardChromium::items): Revised.
(WebCore::ClipboardChromium::mayUpdateItems): Added.
(WebCore::ClipboardChromium::isStorageUpdated): Added.

platform/chromium/ClipboardChromium.h:
platform/chromium/DataTransferItemChromium.cpp: Added a new constructor that

takes File and updated getAsFile() to make it support dropped files.
(WebCore::DataTransferItem::create):
(WebCore::DataTransferItemChromium::DataTransferItemChromium):
(WebCore::DataTransferItemChromium::getAsFile):

platform/chromium/DataTransferItemChromium.h:
platform/chromium/DataTransferItemListChromium.cpp:

(WebCore::DataTransferItemListChromium::addInternalItem):

platform/chromium/DataTransferItemListChromium.cpp: Added overrides implementation for m_item accessors to make them reflect the changes in the owner clipboard.

(WebCore::DataTransferItemListChromium::length):
(WebCore::DataTransferItemListChromium::item):
(WebCore::DataTransferItemListChromium::deleteItem):
(WebCore::DataTransferItemListChromium::clear):
(WebCore::DataTransferItemListChromium::add):
(WebCore::DataTransferItemListChromium::mayUpdateItems): Added.

platform/qt/DataTransferItemQt.cpp: Added a new constructor that takes File and updated

getAsFile() to make it support dropped files.
(WebCore::DataTransferItem::create):
(WebCore::DataTransferItemQt::DataTransferItemQt):
(WebCore::DataTransferItemQt::getAsFile):

platform/qt/DataTransferItemQt.h:

3:43 AM Changeset in webkit [105505] by mario@webkit.org

2 edits in trunk/LayoutTests

[Gtk] Unreviewed, unskipping test passing after r105286.

platform/gtk/Skipped: Unskip test.

3:39 AM Changeset in webkit [105504] by commit-queue@webkit.org

7 edits in trunk/Source/WebKit2

Unreviewed, rolling out r105497.
http://trac.webkit.org/changeset/105497
https://bugs.webkit.org/show_bug.cgi?id=76696

Leaking in Qt layout tests and timing out in GTK API tests.
(Requested by jturcotte on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-20

Shared/WebPreferencesStore.h:
UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):

UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):

WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::platformInitialize):

3:29 AM Changeset in webkit [105503] by mario@webkit.org

17 edits
6 adds in trunk

[GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
https://bugs.webkit.org/show_bug.cgi?id=72589

Reviewed by Martin Robinson.

New optional dependency for WK2's accessibility unit test: AT-SPI2.

configure.ac: Check for AT-SPI2 when building with WK2 support.

Source/WebKit2:

Expose the accessibility hierarchy in the multi-process
architecture of WK2 through AtkSocket and AtkPlug.

Make the WebView widget return an AtkSocket when calling to
gtk_widget_get_accessible().

GNUmakefile.am: Add new files.
UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkit_web_view_base_init):
(webkitWebViewBaseGetAccessible):
(webkit_web_view_base_class_init):

UIProcess/API/gtk/WebKitWebViewBaseAccessible.cpp: Added.

(webkitWebViewBaseAccessibleWidgetFinalize):
(webkitWebViewBaseAccessibleWidgetDestroyed):
(webkitWebViewBaseAccessibleInitialize):
(webkitWebViewBaseAccessibleRefStateSet):
(webkitWebViewBaseAccessibleGetIndexInParent):
(webkit_web_view_base_accessible_init):
(webkit_web_view_base_accessible_class_init):
(webkitWebViewBaseAccessibleNew):

UIProcess/API/gtk/WebKitWebViewBaseAccessible.h: Added.

Make the WebPage create an AtkPlug on its initialization and
sending the ID of that plug to the UI process, so it can embed the
plug in the socket.

Also, take care of all the needed wrapping around the WebCore's
accessibility objects, exposing them in the UI process's
accessibility hierarchy thanks to the socket-plug connection.

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::accessibilityPlugID):

UIProcess/WebPageProxy.messages.in:
UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::bindAccessibilityTree):

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

WebProcess/WebPage/gtk/WebPageAccessibilityObject.cpp: Added.

(accessibilityRootObjectWrapper):
(webPageAccessibilityObjectInitialize):
(webPageAccessibilityObjectGetIndexInParent):
(webPageAccessibilityObjectGetNChildren):
(webPageAccessibilityObjectRefChild):
(web_page_accessibility_object_init):
(web_page_accessibility_object_class_init):
(webPageAccessibilityObjectNew):
(webPageAccessibilityObjectRefresh):

WebProcess/WebPage/gtk/WebPageAccessibilityObject.h: Added.
WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::updateAccessibilityTree):

New unit test for checking accessibility support in WK2GTK.

UIProcess/API/gtk/tests/AccessibilityTestServer.cpp: Added.

(loadChangedCallback): Notify the parent process (the test)
when ready.
(main):

UIProcess/API/gtk/tests/GNUmakefile.am:
UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp: Added.

(stopTestServer):
(sigAbortHandler):
(testServerMonitorThreadFunc):
(startTestServerMonitor):
(startTestServer):
(checkAtspiAccessible):
(findTestServerApplication):
(testAtspiBasicHierarchy):
(beforeAll):
(afterAll):

Tools:

Ensure the accessibility infrastructure is available when running
the unit tests, otherwise WK2's accessibility tests won't work.

Scripts/run-gtk-tests:

(TestRunner):
(TestRunner._lookup_atspi2_binary): New. Looks for the directory
where at-spi2's stuff is located (like at-spi-bus-launcher and
at-spi2-registryd).
(TestRunner.run): Initialize the accessibility infrastructure.

gtk/generate-gtkdoc:

(get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.

gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.

3:10 AM Changeset in webkit [105502] by alexis.menard@openbossa.org

16 edits
2 adds
2 deletes in trunk

remove CSSBorderImageValue
https://bugs.webkit.org/show_bug.cgi?id=75563

Reviewed by Tony Chang.

Source/WebCore:

Remove CSSBorderImageValue as border-image is a shorthand therefore we don't
need a dedicated CSS class type for it. CSSBorderImageValue was here for
-webkit-border-image which is not a shorthand. This is the first step to move border-image
close to a correct shorthand implementation while keeping -webkit-border-image being a regular
CSS property.

No new tests : It's a refactor, existing tests should cover it.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.order:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSAllInOne.cpp:
css/CSSBorderImage.cpp: Added.

(WebCore::createBorderImageValue):

css/CSSBorderImage.h: Added.
css/CSSBorderImageValue.cpp: Removed.
css/CSSBorderImageValue.h: Removed.
css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForNinePieceImage):

css/CSSParser.cpp:

(WebCore::BorderImageParseContext::commitBorderImage):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::mapNinePieceImage):

css/CSSValue.cpp:

(WebCore::CSSValue::addSubresourceStyleURLs):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

css/CSSValue.h:

LayoutTests:

Modify the expected output as now border-image is a CSSValueList.

fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt:

2:51 AM Changeset in webkit [105501] by apavlov@chromium.org

2 edits in branches/chromium/963/Source/WebCore/inspector/front-end

Merge 105140 (re-land) - Web Inspector: [TextPrompt] Autocomplete adds unwanted text that's hard to remove
https://bugs.webkit.org/show_bug.cgi?id=76058

Reviewed by Pavel Feldman.

As per the results of a war room:

Auto-suggest only after user typing (avoid showing suggestions when navigating through the user input.)
Do not select the first item if the suggest box is shown at the end of prompt (to allow Enter to commit the input.)
Only show grayed autocompletion at the end of prompt (otherwise show a suggest box with the first item selected.)
Grayed autocompletion can only be accepted with the End or Right keys.
Enter can accept a selected suggestion item from the list, without committing the input.
Retain the CSS model editing behavior as close to the existing one as possible.
Enable PageUp/PageDown to navigate the suggest box items.

inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype):
():

inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.set text):
(WebInspector.TextPrompt.prototype._removeSuggestionAids):
(WebInspector.TextPrompt.prototype._selectStart.moveBackIfOutside):
(WebInspector.TextPrompt.prototype._selectStart):
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.prototype.acceptAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.isCaretAtEndOfPrompt):
(WebInspector.TextPrompt.prototype.tabKeyPressed):
(WebInspector.TextPrompt.prototype.downKeyPressed):
(WebInspector.TextPrompt.prototype.pageUpKeyPressed):
(WebInspector.TextPrompt.prototype.pageDownKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype._onNextItem):
(WebInspector.TextPrompt.SuggestBox.prototype._onPreviousItem):
(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestions):
(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
(WebInspector.TextPrompt.SuggestBox.prototype._canShowBox):
(WebInspector.TextPrompt.SuggestBox.prototype._rememberRowCountPerViewport):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
(WebInspector.TextPrompt.SuggestBox.prototype.pageUpKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.pageDownKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):

TBR=apavlov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9271002

2:29 AM Changeset in webkit [105500] by hayato@chromium.org

21 edits
3 adds in trunk

Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
https://bugs.webkit.org/show_bug.cgi?id=76353

Reviewed by Hajime Morita.

Add ShadowRoot.idl, which is enabled only on chromium port since this is
under development feature.
ShadowRoot.idl contains minimum API so that we can test it.
Other APIs should be added on other changes so that we can isolate issues.

Source/WebCore:

Test: fast/dom/shadow/shadow-root-js-api.html

WebCore.gypi:
bindings/generic/RuntimeEnabledFeatures.cpp:
bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::shadowDOMEnabled):
(WebCore::RuntimeEnabledFeatures::setShadowDOMEnabled):

dom/ShadowRoot.h:

(WebCore::ShadowRoot::host):

dom/ShadowRoot.idl: Added.
testing/Internals.cpp:

(WebCore::Internals::ensureShadowRoot):
(WebCore::Internals::shadowRoot):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit/chromium:

features.gypi:
public/WebRuntimeFeatures.h:
src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableShadowDOM):
(WebKit::WebRuntimeFeatures::isShadowDOMEnabled):

Tools:

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

LayoutTests:

fast/dom/shadow/shadow-root-js-api-expected.txt: Added.
fast/dom/shadow/shadow-root-js-api.html: Added.
platform/efl/Skipped:
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:
platform/wincairo/Skipped:

2:17 AM Changeset in webkit [105499] by apavlov@chromium.org

2 edits in branches/chromium/963/Source/WebCore/inspector/front-end

Revert 105252 - Merge 105140 - Web Inspector: [TextPrompt] Autocomplete adds unwanted text that's hard to remove
https://bugs.webkit.org/show_bug.cgi?id=76058

Reviewed by Pavel Feldman.

As per the results of a war room:

Auto-suggest only after user typing (avoid showing suggestions when navigating through the user input.)
Do not select the first item if the suggest box is shown at the end of prompt (to allow Enter to commit the input.)
Only show grayed autocompletion at the end of prompt (otherwise show a suggest box with the first item selected.)
Grayed autocompletion can only be accepted with the End or Right keys.
Enter can accept a selected suggestion item from the list, without committing the input.
Retain the CSS model editing behavior as close to the existing one as possible.
Enable PageUp/PageDown to navigate the suggest box items.

inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype):
():

inspector/front-end/TextPrompt.js:

TBR=apavlov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9252006

TBR=apavlov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9131006

2:04 AM Changeset in webkit [105498] by jocelyn.turcotte@nokia.com

3 edits
3 adds in trunk

[Qt] Public API watch dog auto test.
https://bugs.webkit.org/show_bug.cgi?id=73922

Reviewed by Simon Hausmann.

This test aims to prevent unintended/unapproved
modifications to the public QML API.

Source/tests.pri:

Source/WebKit2:

UIProcess/API/qt/tests/publicapi/publicapi.pro: Added.
UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp: Added.

(isCheckedEnum):
(isCheckedClass):
(checkKnownType):
(gatherAPI):
(tst_publicapi::publicAPI):

2:02 AM Changeset in webkit [105497] by jocelyn.turcotte@nokia.com

7 edits in trunk/Source/WebKit2

[Qt] Trigger forcing accelerated compositing from the UI process side.
https://bugs.webkit.org/show_bug.cgi?id=76296

Reviewed by Noam Rosenthal.

This fixes the first visible content rect message not being received when
loading pages from the disk.

Shared/WebPreferencesStore.h:
UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):

UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):

WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::platformInitialize):

1:57 AM Changeset in webkit [105496] by mario@webkit.org

2 edits in trunk/Tools

[GTK] GTK's DRT not to log events for already defunct objects
https://bugs.webkit.org/show_bug.cgi?id=76620

Reviewed by Martin Robinson.

Do not log 'state-change:defunct' events.

DumpRenderTree/gtk/AccessibilityCallbacks.cpp:

(printAccessibilityEvent): Early return if a
'state-change:defunct' signal is passed.
(axObjectEventListener): Pass the signal name and value in
separate parameters to printAccessibilityEvent.

1:39 AM Changeset in webkit [105495] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

undefined reference to symbol eina_module_free
https://bugs.webkit.org/show_bug.cgi?id=76681

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-01-20
Reviewed by Martin Robinson.

eina_module_free has been used without including eina libraries after r104936.

wtf/PlatformEfl.cmake: Add EINA_LIBRARIES.

1:23 AM Changeset in webkit [105494] by tkent@chromium.org

2 edits in trunk/Websites/webkit.org

Each style rule should have its own ID.
https://bugs.webkit.org/show_bug.cgi?id=76428

Reviewed by David Levin.

coding/coding-style.html: Add an id attribute to each of li elements,

and add code to set title="#id-name" and to make li elements clickable.

1:12 AM Changeset in webkit [105493] by Csaba Osztrogonác

4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r105486.

platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
platform/qt/fast/js/global-constructors-expected.txt:

1:05 AM Changeset in webkit [105492] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip a new failing test.

platform/qt/Skipped:

12:59 AM Changeset in webkit [105491] by commit-queue@webkit.org

7 edits
2 copies in trunk/Source/WebKit/chromium

[chromium] Chromium should have EditorClientImpl::checkTextOfParagraph.
https://bugs.webkit.org/show_bug.cgi?id=74071

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-20
Reviewed by Darin Fisher.

Spellchecker on Mac has more sophisticated interface for spellchecking (checkTextOfParagraph).
If the other ports have the same interface, code can be clearer and easy to extend.
This patch introduces such an interface. The implementation will be done not in WebKit but in Chromium.

Also, currently WebKit::WebTextCheckingResult and WebCore::TextCheckingResult have different forms.
They should be corresponding apparently. This patch introduces such correspondence.

WebKit.gyp:
public/WebSpellCheckClient.h:

(WebKit::WebSpellCheckClient::checkTextOfParagraph):

A new interface for spellchecking.

public/WebTextCheckingResult.h:

(WebKit::WebTextCheckingResult::WebTextCheckingResult):

Changed so that WebTextCheckingResult corresponds to WebCore::TextCheckingResult.

public/WebTextCheckingType.h: Copied from Source/WebKit/chromium/public/WebTextCheckingResult.h.
src/AssertMatchingEnums.cpp:
src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::checkTextOfParagraph):

src/EditorClientImpl.h:
src/WebTextCheckingResult.cpp: Copied from Source/WebKit/chromium/public/WebTextCheckingResult.h.

(WebKit::WebTextCheckingResult::operator TextCheckingResult):

12:47 AM Changeset in webkit [105490] by tkent@chromium.org

6 edits in trunk/Source/WebCore

Change LocalizedNumber interface
https://bugs.webkit.org/show_bug.cgi?id=76613

Reviewed by Hajime Morita.

Change the functions of LocalizedNumber from:

double parseLocalizedNumber(const String&);
String formatLocalizedNumber(double, unsigned fractionDigits);

To:

String convertToLocalizedNumber(const String&, usnigned fractionDigits);
String convertFromLocalizedNumber(const String&);

in order that we can avoid conversion from/to a double value.

The fractionDigits argumetn of convertToLocalizedNumber() will be
removed in the future. We need it because we'd like to recycle the old
functions to implement new functions for now and functions in
LocalizedNumber can't call functions in HTMLParserIdioms.cpp.

No new tests because the change doesn't make any behavior change.

html/NumberInputType.cpp:

(WebCore::NumberInputType::visibleValue):
Use convertToLocalizedNumber.
(WebCore::NumberInputType::convertFromVisibleValue):
Use convertFromLocalizedNumber.
(WebCore::NumberInputType::isAcceptableValue): ditto.

platform/text/LocalizedNumber.h:

Remove parseLocalizedNumber and formatLocalizedNumber, and
introduce convertToLocalizedNumber and convertFromLocalizedNumber.

platform/text/LocalizedNumberICU.cpp:

(WebCore::parseLocalizedNumber): Make this static.
(WebCore::formatLocalizedNumber): Make this static.
(WebCore::convertToLocalizedNumber): Implement this with formatLocalizedNumber.
(WebCore::convertFromLocalizedNumber): Implement this with parseLocalizedNumber.

platform/text/LocalizedNumberNone.cpp:

(WebCore::convertToLocalizedNumber):
Implement this as a function returning the input string.
(WebCore::convertFromLocalizedNumber): ditto.

platform/text/mac/LocalizedNumberMac.mm:

12:42 AM Changeset in webkit [105489] by commit-queue@webkit.org

6 edits in trunk/Source/WebKit/chromium

[chromium] WebFrame should have an interface to invoke spellchecking in arbitrarily.
https://bugs.webkit.org/show_bug.cgi?id=73971

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-20
Reviewed by Darin Fisher.

This interface is necessary to recheck spelling of an arbitrary element.

public/WebFrame.h:
public/WebNode.h:
src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::requestTextChecking):

Requests spellchecking for the element having current selection.

src/WebFrameImpl.h:
src/WebNode.cpp:

(WebKit::WebNode::rootEditableElement):

Takes a root editable element from Node.

12:26 AM Changeset in webkit [105488] by pfeldman@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: problem with Ctrl - <arrows> shortcuts in Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=76622

Reviewed by Yury Semikhatsky.

inspector/front-end/InspectorView.js:

(WebInspector.InspectorView.prototype._keyDown):

inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype.set readOnly):
(WebInspector.TextViewer.prototype._cancelEditing):
(WebInspector.TextViewer.prototype.wasShown):
(WebInspector.TextViewer.prototype.willHide):

inspector/front-end/UIUtils.js:

(WebInspector.isInEditMode):

inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):

12:04 AM Changeset in webkit [105487] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, test results rebaseline after r105457.

fast/canvas/canvas-webkitLineDash-expected.txt:

12:00 AM Changeset in webkit [105486] by arv@chromium.org

11 edits
3 adds in trunk

Source/WebCore: Migrate createObjectURL & revokeObjectURL to static (Class) methods.
https://bugs.webkit.org/show_bug.cgi?id=74386

Reviewed by Adam Barth.

Test: fast/dom/DOMURL/check-instanceof-domurl-functions.html
Already Existing -

fast/files/revoke-blob-url.html
fast/dom/window-domurl-crash.html
fast/files/apply-blob-url-to-img.html
fast/files/create-blob-url-crash.html
fast/files/workers/inline-worker-via-blob-url.html

html/DOMURL.cpp: Added HashMap for local static objects.

(WebCore::PublicURLManager::PublicURLManager):
(WebCore::PublicURLManager::contextDestroyed):
(WebCore::PublicURLManager::blobURLs):
(WebCore::PublicURLManager::streamURLs):
(WebCore::publicURLManagerMap):
(WebCore::publicURLManager):
(WebCore::publicBlobURLs):
(WebCore::publicStreamURLs):
(WebCore::DOMURL::createObjectURL): Changed to static.
(WebCore::DOMURL::revokeObjectURL): ditto.

html/DOMURL.h:

(WebCore::DOMURL::create):
(WebCore::DOMURL::~DOMURL):
(WebCore::DOMURL::DOMURL):

html/DOMURL.idl:
page/DOMWindow.cpp: Removed object initialization for DOMURL.
page/DOMWindow.h: ditto.
page/DOMWindow.idl: ditto.
workers/WorkerContext.cpp: ditto.
workers/WorkerContext.h: ditto.
workers/WorkerContext.idl: ditto.

LayoutTests: Migrate createObjectURL & revokeObjectURL to static (Class) methods
https://bugs.webkit.org/show_bug.cgi?id=74386

Reviewed by Adam Barth.

Added test to check if createObjectURL & revokeObjectURL are static functions.

fast/dom/DOMURL: Added.
fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Added.
fast/dom/DOMURL/check-instanceof-domurl-functions.html: Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed