Timeline
Jan 22, 2012:
- 11:08 PM Changeset in webkit [105594] by
-
- 1 edit in branches/chromium/963/Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js
Merge 105261 - Web Inspector: Popover does not disappear, causes debugger failure.
https://bugs.webkit.org/show_bug.cgi?id=71363
Reviewed by Pavel Feldman.
This is a work-around simple enough for a merge. The real fix would
be to get TextViewer to manage the highlight on its own, so it's not
accidently removed while re-building DOM for the text chunk.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):
TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9279002
- 9:36 PM Changeset in webkit [105593] by
-
- 1 edit in branches/chromium/963/Source/WebCore/platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp
Merge 105393 - [Chromium] Random characters got rendered as empty boxes or with incorrect glyphs even when a font is present
https://bugs.webkit.org/show_bug.cgi?id=76508
Patch by Kazuhiro Inaba <kinaba@chromium.org> on 2012-01-19
Reviewed by Kent Tamura.
Wrapped GetGlyphIndices() API calls so that when they failed we trigger font
loading outside the sandbox and retry the call.
No new auto tests since the bug involves the system's occasional cache behavior
and thus there's no reliable way to reproduce and test the situation.
- platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::getGlyphIndices):
GDI call wrapper ensuring fonts to be loaded.
(WebCore::initSpaceGlyph):
Changed to use the wrapper function.
(WebCore::fillBMPGlyphs):
Changed to use the wrapper function.
Introduced scoped HDC management by HWndDC.
(WebCore::GlyphPage::fill):
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9280004
- 6:13 PM Changeset in webkit [105592] by
-
- 2 edits in trunk/Tools
Windows python test build fix.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.init):
- 11:51 AM Changeset in webkit [105591] by
-
- 2 edits in trunk/LayoutTests
2012-01-22 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix typo, which makes the style bot warn on every patch.
- platform/chromium/test_expectations.txt:
- 11:29 AM Changeset in webkit [105590] by
-
- 7 edits in trunk/Source
[GTK] ATK text-caret-moved and text-selection-changed events not being emitted
https://bugs.webkit.org/show_bug.cgi?id=76069
Reviewed by Martin Robinson.
Source/WebCore:
Fix bug introduced with patch for Bug 72830.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isDescendantOfObject): New function,
to check if an accessibility object is a descendant of other object.
(WebCore::AccessibilityObject::isAncestorOfObject): New function,
to check if an accessibility object is an ancestor of other object.
- accessibility/AccessibilityObject.h:
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_text_get_caret_offset): Make sure to pass the
right reference object to objectFocusedAndCaretOffsetUnignored.
(objectFocusedAndCaretOffsetUnignored): Use positionBeforeNode
instead of firstPositionInNode for calculating the begining of the
range used to calculate the offsets. Ensure that the reference
object is never a descendant of the actual object being returned.
- editing/gtk/FrameSelectionGtk.cpp:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
Pass the right accessibility object associated with the current
selection to objectFocusedAndCaretOffsetUnignored.
Source/WebKit/gtk:
Update caret browsing related unit tests to check emissions of
'text-caret-moved' and 'text-selection-changed' signals.
- tests/testatk.c:
(textCaretMovedCallback): New callback for 'text-caret-moved'.
(testWebkitAtkCaretOffsets): Check emissions of 'text-caret-moved'.
(textSelectionChangedCallback): New callback for 'text-selection-changed'.
(testWebkitAtkTextSelections): Check emissions of 'text-selection-changed'.
- 4:50 AM Changeset in webkit [105589] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed, unskipping passing test.
- platform/gtk/Skipped: unskipped
http/tests/security/mixedContent/empty-url-plugin-in-frame.html
- 3:52 AM Changeset in webkit [105588] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed, unskipping test passing after r79655.
- platform/gtk/Skipped: unskipped http/tests/incremental/slow-utf8-html.pl
- 2:12 AM Changeset in webkit [105587] by
-
- 4 edits in trunk
[GTK] DumpRenderTree converts "file:///" to a path differently
https://bugs.webkit.org/show_bug.cgi?id=76631
Reviewed by Martin Robinson.
Tools:
DumpRenderTree should print "/" as the last path component if the
path is a lone slash instead of empty output.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(webViewConsoleMessage):
LayoutTests:
Unskipped a couple of tests after fix.
- platform/gtk/Skipped:
- 1:11 AM Changeset in webkit [105586] by
-
- 5 edits in trunk/Source/JavaScriptCore
Build fix for non-DFG platforms that error out on warn-unused-parameter.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/MethodCallLinkStatus.cpp:
(JSC::MethodCallLinkStatus::computeFor):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- 12:47 AM Changeset in webkit [105585] by
-
- 5 edits in trunk/Source/JavaScriptCore
Build fix for non-DFG platforms.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/MethodCallLinkStatus.cpp:
(JSC::MethodCallLinkStatus::computeFor):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
Jan 21, 2012:
- 7:45 PM Changeset in webkit [105584] by
-
- 2 edits in trunk
[GTK][PATCH] Enable MathML support by default
https://bugs.webkit.org/show_bug.cgi?id=76790
Patch by Priit Laes <plaes@plaes.org> on 2012-01-21
Reviewed by Martin Robinson.
- configure.ac: Enable MathML by default.
- 7:30 PM Changeset in webkit [105583] by
-
- 13 edits in trunk/Source
[Chromium] Incremental texture updates are not atomic.
https://bugs.webkit.org/show_bug.cgi?id=72672
Patch by David Reveman <reveman@chromium.org> on 2012-01-21
Reviewed by Adam Barth.
Source/WebCore:
Use a new set of textures for each commit when incremental
texture updates are enabled.
This patch is tested by the following unit test:
- CCLayerTreeHostTestAtomicCommit.runMultiThread
- platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::ManagedTexture):
(WebCore::ManagedTexture::steal):
- platform/graphics/chromium/ManagedTexture.h:
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::deleteTextureAfterCommit):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
- platform/graphics/chromium/cc/CCProxy.h:
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore::CCSingleThreadProxy::partialTextureUpdateCapability):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::partialTextureUpdateCapability):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
Add CCLayerTreeHostTestAtomicCommit test that verifies atomicity
of commits.
- tests/CCLayerTreeHostTest.cpp:
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::create):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::createTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::deleteTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::bindTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::texture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::usedTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::CompositorFakeWebGraphicsContext3DWithTextureTracking):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::MockContentLayerDelegate::drawsContent):
(WTF::MockContentLayerDelegate::paintContents):
(WTF::MockContentLayerDelegate::notifySyncRequired):
(WTF::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit):
(WTF::CCLayerTreeHostTestAtomicCommit::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::layout):
(WTF::CCLayerTreeHostTestAtomicCommit::afterTest):
(WTF::TEST_F):
- tests/CompositorFakeWebGraphicsContext3D.h:
- 5:43 PM Changeset in webkit [105582] by
-
- 1 edit2 adds in trunk/LayoutTests
Add baselines for test after http://trac.webkit.org/changeset/105575.
This baseline looks very similar to the existing non-Chromium baseline.
- platform/chromium-mac-snowleopard/svg/filters/feImage-preserveAspectratio-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png: Added.
- 5:36 PM Changeset in webkit [105581] by
-
- 8 edits9 adds1 delete in trunk/Source/JavaScriptCore
DFG should not have code that directly decodes the states of old JIT inline
cache data structures
https://bugs.webkit.org/show_bug.cgi?id=76768
Reviewed by Sam Weinig.
Introduced new classes (like GetByIdStatus) that encapsulate the set of things
that the DFG would like to know about property accesses and calls. Whereas it
previously got this information by directly decoding the data structures used
by the old JIT for inline caching, it now uses these classes, which do the work
for it. This should make it somewhat more straight forward to introduce new
ways of profiling the same information.
Also hoisted StructureSet into bytecode/ from dfg/, because it's now used by
code in bytecode/.
Making this work right involved carefully ensuring that the heuristics for
choosing how to handle property accesses was at least as good as what we had
before, since I completely restructured that code. Currently the performance
looks neutral. Since I rewrote the code I did change some things that I never
liked before, like previously if a put_bu_id had executed exactly once then
we'd compile it as if it had taken slow-path. Executing once is special because
then the inline cache is not baked in, so there is no information about how the
DFG should optimize the code. Now this is rationalized: if the put_by_id does
not offer enough information to be optimized (i.e. had executed 0 or 1 times)
then we turn it into a forced OSR exit (i.e. a patch point). However, get_by_id
still has the old behavior; I left it that way because I didn't want to make
too many changes at once.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CallLinkStatus.cpp: Added.
(JSC::CallLinkStatus::computeFor):
- bytecode/CallLinkStatus.h: Added.
(JSC::CallLinkStatus::CallLinkStatus):
(JSC::CallLinkStatus::isSet):
(JSC::CallLinkStatus::operator!):
(JSC::CallLinkStatus::couldTakeSlowPath):
(JSC::CallLinkStatus::callTarget):
- bytecode/GetByIdStatus.cpp: Added.
(JSC::GetByIdStatus::computeFor):
- bytecode/GetByIdStatus.h: Added.
(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::state):
(JSC::GetByIdStatus::isSet):
(JSC::GetByIdStatus::operator!):
(JSC::GetByIdStatus::isSimpleDirect):
(JSC::GetByIdStatus::takesSlowPath):
(JSC::GetByIdStatus::makesCalls):
(JSC::GetByIdStatus::structureSet):
(JSC::GetByIdStatus::offset):
- bytecode/MethodCallLinkStatus.cpp: Added.
(JSC::MethodCallLinkStatus::computeFor):
- bytecode/MethodCallLinkStatus.h: Added.
(JSC::MethodCallLinkStatus::MethodCallLinkStatus):
(JSC::MethodCallLinkStatus::isSet):
(JSC::MethodCallLinkStatus::operator!):
(JSC::MethodCallLinkStatus::needsPrototypeCheck):
(JSC::MethodCallLinkStatus::structure):
(JSC::MethodCallLinkStatus::prototypeStructure):
(JSC::MethodCallLinkStatus::function):
(JSC::MethodCallLinkStatus::prototype):
- bytecode/PutByIdStatus.cpp: Added.
(JSC::PutByIdStatus::computeFor):
- bytecode/PutByIdStatus.h: Added.
(JSC::PutByIdStatus::PutByIdStatus):
(JSC::PutByIdStatus::state):
(JSC::PutByIdStatus::isSet):
(JSC::PutByIdStatus::operator!):
(JSC::PutByIdStatus::isSimpleReplace):
(JSC::PutByIdStatus::isSimpleTransition):
(JSC::PutByIdStatus::takesSlowPath):
(JSC::PutByIdStatus::oldStructure):
(JSC::PutByIdStatus::newStructure):
(JSC::PutByIdStatus::structureChain):
(JSC::PutByIdStatus::offset):
- bytecode/StructureSet.h: Added.
(JSC::StructureSet::StructureSet):
(JSC::StructureSet::clear):
(JSC::StructureSet::add):
(JSC::StructureSet::addAll):
(JSC::StructureSet::remove):
(JSC::StructureSet::contains):
(JSC::StructureSet::isSubsetOf):
(JSC::StructureSet::isSupersetOf):
(JSC::StructureSet::size):
(JSC::StructureSet::at):
(JSC::StructureSet::operator[]):
(JSC::StructureSet::last):
(JSC::StructureSet::predictionFromStructures):
(JSC::StructureSet::operator==):
(JSC::StructureSet::dump):
- dfg/DFGAbstractValue.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGStructureSet.h: Removed.
- 5:09 PM Changeset in webkit [105580] by
-
- 4 edits6 adds in trunk
Add .url attribute alongside .URL in EventSource and WebSocket to comply with the specs but not break existing usage.
https://bugs.webkit.org/show_bug.cgi?id=40899
Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-21
Reviewed by Adam Barth.
Source/WebCore:
Tests: fast/eventsource/eventsource-url-attribute.html
http/tests/websocket/tests/hixie76/url-attribute.html
http/tests/websocket/tests/hybi/url-attribute.html
- page/EventSource.idl:
- websockets/WebSocket.idl:
LayoutTests:
- fast/eventsource/eventsource-url-attribute-expected.txt: Added.
- fast/eventsource/eventsource-url-attribute.html: Added.
- http/tests/websocket/tests/hixie76/url-attribute-expected.txt: Added.
- http/tests/websocket/tests/hixie76/url-attribute.html: Added.
- http/tests/websocket/tests/hybi/url-attribute-expected.txt: Added.
- http/tests/websocket/tests/hybi/url-attribute.html: Added.
- 4:48 PM Changeset in webkit [105579] by
-
- 5 edits in trunk/Source/JavaScriptCore
JIT compilation should not require ExecState
https://bugs.webkit.org/show_bug.cgi?id=76729
<rdar://problem/10731545>
Reviewed by Gavin Barraclough.
Changed the relevant JIT driver functions to take JSGlobalData& instead of
ExecState*, since really they just needed the global data.
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
- dfg/DFGDriver.h:
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
- jit/JITDriver.h:
(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):
- runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
- 3:56 PM Changeset in webkit [105578] by
-
- 13 edits in trunk/Source
Unreviewed, rolling out r105564.
http://trac.webkit.org/changeset/105564
https://bugs.webkit.org/show_bug.cgi?id=76792
Does not compile on Chromium Mac (Requested by abarth on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-21
Source/WebCore:
- platform/graphics/chromium/ManagedTexture.cpp:
- platform/graphics/chromium/ManagedTexture.h:
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::commitComplete):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
- platform/graphics/chromium/cc/CCProxy.h:
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
- tests/CompositorFakeWebGraphicsContext3D.h:
- 9:19 AM Changeset in webkit [105577] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening. Skip the new failing tests to paint the bots green.
- platform/qt-wk2/Skipped:
- platform/qt/Skipped:
- 7:40 AM Changeset in webkit [105576] by
-
- 19 edits6 adds in trunk
Implement hardware accelerated Brightness and contrast filters
https://bugs.webkit.org/show_bug.cgi?id=75521
https://bugs.webkit.org/show_bug.cgi?id=76719
Reviewed by Simon Fraser.
Source/WebCore:
Implemented hardware accelerated brightness and contrast filters. This also fixes
the bug where grayscale filter was accidentally never getting hardware accelerated.
It also complies with proposed spec changes for the brightness filter to be additive
rather than multiplicative, according to https://bugs.webkit.org/show_bug.cgi?id=76719.
Had to make both fixes in the same patch because I had to change the allowed brightness
values for the hardware version, so I had to change the software version as well.
Tests: css3/filters/effect-brightness-hw.html
css3/filters/effect-contrast-hw.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseBuiltinFilterArguments):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::createFilterOperations):
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::setFilters):
(PlatformCALayer::filtersCanBeComposited):
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):
LayoutTests:
New tests for hardware accelerated brightness and contrast filters. Also
added brightness and contrast values to effect-combined-hw test. And changed
brightness values in effect-brightness.html to reflect new spec.
Also fixed parsing and computed style tests to reflect new brightness spec.
- css3/filters/effect-brightness-expected.png:
- css3/filters/effect-brightness-hw-expected.png: Added.
- css3/filters/effect-brightness-hw-expected.txt: Added.
- css3/filters/effect-brightness-hw.html: Added.
- css3/filters/effect-brightness.html:
- css3/filters/effect-combined-expected.png:
- css3/filters/effect-combined-hw-expected.png:
- css3/filters/effect-combined-hw-expected.txt:
- css3/filters/effect-combined-hw.html:
- css3/filters/effect-combined.html:
- css3/filters/effect-contrast-hw-expected.png: Added.
- css3/filters/effect-contrast-hw-expected.txt: Added.
- css3/filters/effect-contrast-hw.html: Added.
- css3/filters/filter-property-computed-style-expected.txt:
- css3/filters/filter-property-parsing-expected.txt:
- css3/filters/filter-property-parsing-invalid-expected.txt:
- css3/filters/script-tests/filter-property-computed-style.js:
- css3/filters/script-tests/filter-property-parsing-invalid.js:
- css3/filters/script-tests/filter-property-parsing.js:
- 4:28 AM Changeset in webkit [105575] by
-
- 5 edits3 adds in trunk
2012-01-21 Nikolas Zimmermann <nzimmermann@rim.com>
<feImage> ignores preserveAspectRatio="none"
https://bugs.webkit.org/show_bug.cgi?id=76780
Reviewed by Antti Koivisto.
Add new testcase covering preserveAspectRatio="none" + <feImage>, which is now fixed.
- platform/chromium/test_expectations.txt: Add new test, that needs a rebaseline.
- platform/mac/svg/filters/feImage-preserveAspectratio-expected.png: Added.
- platform/mac/svg/filters/feImage-preserveAspectratio-expected.txt: Added.
- svg/filters/feImage-preserveAspectratio.svg: Added.
2012-01-21 Nikolas Zimmermann <nzimmermann@rim.com>
<feImage> ignores preserveAspectRatio="none"
https://bugs.webkit.org/show_bug.cgi?id=76780
Reviewed by Antti Koivisto.
preserveAspectRatio="none" was ignored in SVGFEImage. It always called transformRect() w/o checking
whether it was supposed to transform the rect or not - move code from RenderSVGImage right into
transformRect(), to do nothing if preserveAspectRatio="none" was given.
Test: svg/filters/feImage-preserveAspectratio.svg
- rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
- svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::transformRect):
- 2:18 AM Changeset in webkit [105574] by
-
- 3 edits6 adds in trunk
history.replaceState should update the HistoryItem to use a GET method if previously non-GET (POST)
https://bugs.webkit.org/show_bug.cgi?id=76721
Reviewed by Mihai Parparita.
Source/WebCore:
Tests: http/tests/history/replacestate-post-to-get-2.html
http/tests/history/replacestate-post-to-get.html
- loader/HistoryController.cpp:
(WebCore::HistoryController::replaceState):
LayoutTests:
- http/tests/history/replacestate-post-to-get-2-expected.txt: Added.
- http/tests/history/replacestate-post-to-get-2.html: Added.
- http/tests/history/replacestate-post-to-get-expected.txt: Added.
- http/tests/history/replacestate-post-to-get.html: Added.
- http/tests/history/resources/replacestate-current.php: Added.
- http/tests/history/resources/replacestate-forward-back.php: Added.
- 2:00 AM Changeset in webkit [105573] by
-
- 7 edits2 adds in trunk
Null dereference in SVGDocumentExtensions::removePendingResource when updating <use>'s href
https://bugs.webkit.org/show_bug.cgi?id=69284
Patch by Florin Malita <fmalita@google.com> on 2012-01-21
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Test: svg/custom/use-crash-pending-resource.svg
The crash is caused by assumptions in SVGUseElement that xlink:href is the only
pending resource. This patch adds support for dealing with multiple pending resources.
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::registerResource):
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::hasPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::isElementPendingResource):
(WebCore::SVGDocumentExtensions::removePendingResourceForElement):
- svg/SVGDocumentExtensions.h:
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
(WebCore::SVGStyledElement::clearHasPendingResourcesIfPossible):
Renamed SVGDocumentExtensions::hasPendingResources -> Renamed SVGDocumentExtensions::hasPendingResource.
Renamed SVGDocumentExtensions::isElementInPendingResources -> SVGDocumentExtensions::isElementPendingResources.
Added support for querying and removing pending resources for a specific element.
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::buildPendingResource):
Refactored to support multiple pending resources.
LayoutTests:
- svg/custom/use-crash-pending-resource-expected.txt: Added.
- svg/custom/use-crash-pending-resource.svg: Added.
- 12:51 AM Changeset in webkit [105572] by
-
- 4 edits in trunk
REGRESSION (Safari 5.0.5 - ToT): crash in SVG test http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectApproved/animate-elem-39-t.html
https://bugs.webkit.org/show_bug.cgi?id=64671
Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-21
Reviewed by Nikolas Zimmermann.
Source/WebCore:
No new tests. This change is to fix crashes in existing tests.
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::beginListChanged): If the new begin time is
later than the current end time, and the event time is also after then
end time (but we have not yet updated to that time) and the animation
is active, we need to make the animation inactive explicitly.
LayoutTests:
- platform/chromium/test_expectations.txt: Marking all svg/W3C-SVG-1.1/animate-elem* tests
as flakey pending this change being committed and new results.
- 12:42 AM Changeset in webkit [105571] by
-
- 4 edits in trunk/Source/WebKit2
Make WebKit2 remember the height of the Web Inspector when it is docked.
Reviewed by Dan Bernstein.
- Shared/WebPreferencesStore.h: Added InspectorAttachedHeight.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::setAttachedWindowHeight): Call WebPreferencesStore::setInspectorAttachedHeight.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformAttach): Set the height of the inspector's WKView to inspectorAttachedHeight.
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight): Remove unneeded setNeedsDisplay: calls.
- 12:17 AM Changeset in webkit [105570] by
-
- 4 edits in trunk/Source/WebCore
PopupMenuClient::multiple() should be const
https://bugs.webkit.org/show_bug.cgi?id=76771
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-21
Reviewed by Kent Tamura.
- platform/PopupMenuClient.h:
(WebCore::PopupMenuClient::multiple):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::multiple):
- rendering/RenderMenuList.h:
