Timeline
Jan 23, 2012:
- 11:47 PM Changeset in webkit [105701] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] http/tests/navigation/anchor-frames-gbk.html fails
https://bugs.webkit.org/show_bug.cgi?id=76896
- platform/qt-wk2/Skipped: Skip the failing test.
- 11:38 PM Changeset in webkit [105700] by
-
- 2 edits in trunk/Source/WebCore
Avoid spurious rebuilds on vs2010 due to DerivedSources not existing
https://bugs.webkit.org/show_bug.cgi?id=76873
Patch by Scott Graham <scottmg@chromium.org> on 2012-01-23
Reviewed by Adam Barth.
- WebCore.gyp/WebCore.gyp:
- 11:37 PM Changeset in webkit [105699] by
-
- 1 edit3 adds in trunk/LayoutTests
[Qt] Unreviewed gardening after r105647.
- platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.png: Added.
- platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.txt: Added.
- 11:34 PM Changeset in webkit [105698] by
-
- 93 edits in trunk/Source
JSValue::toString() should return a JSString* instead of a UString
https://bugs.webkit.org/show_bug.cgi?id=76861
Reviewed by Gavin Barraclough.
This makes the common case -- toString() on a string -- faster and
inline-able. (Not a measureable speedup, but we can now remove a bunch
of duplicate hand-rolled code for this optimization.)
This also clarifies the boundary between "C++ strings" and "JS strings".
In all cases other than true, false, null, undefined, and multi-digit
numbers, the JS runtime was just retrieving a UString from a JSString,
so returning a JSString* is strictly better. In the other cases, we can
optimize to avoid creating a new JSString if we care to, but it doesn't
seem to be a big deal.
- JavaScriptCore.exp: Export!
- jsc.cpp:
(functionPrint):
(functionDebug):
(functionRun):
(functionLoad):
(functionCheckSyntax):
(runWithScripts):
(runInteractive):
- API/JSValueRef.cpp:
(JSValueToStringCopy):
- bytecode/CodeBlock.cpp:
(JSC::valueToSourceString): Call value() after calling toString(), to
convert from "JS string" (JSString*) to "C++ string" (UString), since
toString() no longer returns a "C++ string".
- dfg/DFGOperations.cpp:
(JSC::DFG::operationValueAddNotNumber):
- jit/JITStubs.cpp:
(op_add): Updated for removal of toPrimitiveString():
all '+' operands can use toString(), except for object operands, which
need to take a slow path to call toPrimitive().
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncPush):
- runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::opIn):
- runtime/DateConstructor.cpp:
(JSC::dateParse):
- runtime/DatePrototype.cpp:
(JSC::formatLocaleDate): Call value() after calling toString(), as above.
- runtime/ErrorInstance.h:
(JSC::ErrorInstance::create): Simplified down to one canonical create()
function, to make string handling easier.
- runtime/ErrorPrototype.cpp:
(JSC::errorProtoFuncToString):
- runtime/ExceptionHelpers.cpp:
(JSC::createInvalidParamError):
(JSC::createNotAConstructorError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):
- runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
- runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncBind):
- runtime/JSArray.cpp:
(JSC::JSArray::sort): Call value() after calling toString(), as above.
- runtime/JSCell.cpp:
- runtime/JSCell.h: Removed JSCell::toString() because JSValue does this
job now. Doing it in JSCell is slower (requires extra type checking), and
creates the misimpression that language-defined toString() behavior is
an implementation detail of JSCell.
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
(JSC::globalFuncEval):
(JSC::globalFuncParseInt):
(JSC::globalFuncParseFloat):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape): Call value() after calling toString(), as above.
- runtime/JSONObject.cpp:
(JSC::unwrapBoxedPrimitive):
(JSC::Stringifier::Stringifier):
(JSC::JSONProtoFuncParse): Removed some manual optimization that toString()
takes care of.
- runtime/JSObject.cpp:
(JSC::JSObject::toString):
- runtime/JSObject.h: Updated to return JSString*.
- runtime/JSString.cpp:
- runtime/JSString.h:
(JSC::JSValue::toString): Removed, since I removed JSCell::toString().
- runtime/JSValue.cpp:
(JSC::JSValue::toStringSlowCase): Removed toPrimitiveString(), and re-
spawned toStringSlowCase() from its zombie corpse, since toPrimitiveString()
basically did what we want all the time. (Note that the toPrimitive()
preference changes from NoPreference to PreferString, because that's
how ToString is defined in the language. op_add does not want this behavior.)
- runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToString):
(JSC::numberProtoFuncToLocaleString): A little simpler, now that toString()
returns a JSString*.
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorDefineProperty):
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncHasOwnProperty):
(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):
(JSC::objectProtoFuncPropertyIsEnumerable): More calls to value(), as above.
- runtime/Operations.cpp:
(JSC::jsAddSlowCase): Need to check for object before taking the toString()
fast path becuase adding an object to a string requires calling toPrimitive()
on the object, not toString(). (They differ in their preferred conversion
type.)
- runtime/Operations.h:
(JSC::jsString):
(JSC::jsStringFromArguments): This code gets simpler, now that toString()
does the right thing.
(JSC::jsAdd): Now checks for object, just like jsAddSlowCase().
- runtime/RegExpConstructor.cpp:
(JSC::setRegExpConstructorInput):
(JSC::constructRegExp):
- runtime/RegExpObject.cpp:
(JSC::RegExpObject::match):
- runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoFuncToString): More calls to value(), as above.
- runtime/StringConstructor.cpp:
(JSC::constructWithStringConstructor):
(JSC::callStringConstructor): This code gets simpler, now that toString()
does the right thing.
- runtime/StringPrototype.cpp:
(JSC::replaceUsingRegExpSearch):
(JSC::replaceUsingStringSearch):
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncConcat):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncLastIndexOf):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
(JSC::stringProtoFuncSlice):
(JSC::stringProtoFuncSplit):
(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncSubstring):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncLocaleCompare):
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
(JSC::stringProtoFuncLink):
(JSC::trimString): Some of this code gets simpler, now that toString()
does the right thing. More calls to value(), as above.
../JavaScriptGlue:
Reviewed by Gavin Barraclough.
- JSUtils.cpp:
(KJSValueToCFTypeInternal):
../WebCore:
Reviewed by Gavin Barraclough.
Mechanical changes to call value() after calling toString(), to
convert from "JS string" (JSString*) to "C++ string" (UString), since
toString() no longer returns a "C++ string".
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromValue):
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
- bindings/js/JSClipboardCustom.cpp:
(WebCore::JSClipboard::clearData):
(WebCore::JSClipboard::getData):
- bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- bindings/js/JSDOMBinding.cpp:
(WebCore::valueToStringWithNullCheck):
(WebCore::valueToStringWithUndefinedOrNullCheck):
(WebCore::reportException):
- bindings/js/JSDOMFormDataCustom.cpp:
(WebCore::JSDOMFormData::append):
- bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::putDelegate):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setLocation):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):
- bindings/js/JSDeviceMotionEventCustom.cpp:
(WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):
- bindings/js/JSDeviceOrientationEventCustom.cpp:
(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
- bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::setLocation):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):
- bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
- bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::documentWrite):
- bindings/js/JSHTMLInputElementCustom.cpp:
(WebCore::JSHTMLInputElement::setSelectionDirection):
(WebCore::JSHTMLInputElement::setSelectionRange):
- bindings/js/JSInspectorFrontendHostCustom.cpp:
(WebCore::JSInspectorFrontendHost::showContextMenu):
- bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::evaluate):
- bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::setHref):
(WebCore::JSLocation::setProtocol):
(WebCore::JSLocation::setHost):
(WebCore::JSLocation::setHostname):
(WebCore::JSLocation::setPort):
(WebCore::JSLocation::setPathname):
(WebCore::JSLocation::setSearch):
(WebCore::JSLocation::setHash):
(WebCore::JSLocation::replace):
(WebCore::JSLocation::assign):
- bindings/js/JSMessageEventCustom.cpp:
(WebCore::handleInitMessageEvent):
- bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
- bindings/js/JSSQLTransactionSyncCustom.cpp:
(WebCore::JSSQLTransactionSync::executeSql):
- bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker):
- bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::putDelegate):
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::getExtension):
- bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocketConstructor::constructJSWebSocket):
(WebCore::JSWebSocket::send):
(WebCore::JSWebSocket::close):
- bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::importScripts):
- bindings/js/JSWorkerCustom.cpp:
(WebCore::JSWorkerConstructor::constructJSWorker):
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::open):
(WebCore::JSXMLHttpRequest::send):
- bindings/js/JSXSLTProcessorCustom.cpp:
(WebCore::JSXSLTProcessor::setParameter):
(WebCore::JSXSLTProcessor::getParameter):
(WebCore::JSXSLTProcessor::removeParameter):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
- bindings/js/ScriptEventListener.cpp:
(WebCore::eventListenerHandlerBody):
- bindings/js/ScriptValue.cpp:
(WebCore::ScriptValue::toString):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateEventListenerCall):
(JSValueToNative):
(GenerateConstructorDefinition):
- bridge/c/c_utility.cpp:
(JSC::Bindings::convertValueToNPVariant):
- bridge/jni/jni_jsobject.mm:
(JavaJSObject::convertValueToJObject):
- bridge/jni/jsc/JNIUtilityPrivate.cpp:
(JSC::Bindings::convertArrayInstanceToJavaArray):
(JSC::Bindings::convertValueToJValue):
- bridge/jni/jsc/JavaFieldJSC.cpp:
(JavaField::dispatchValueFromInstance):
(JavaField::valueFromInstance):
(JavaField::dispatchSetValueToInstance):
(JavaField::setValueToInstance):
- bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
- testing/js/JSInternalsCustom.cpp:
(WebCore::JSInternals::setUserPreferredLanguages):
../WebKit/mac:
Reviewed by Gavin Barraclough.
Mechanical changes to call value() after calling toString(), to
convert from "JS string" (JSString*) to "C++ string" (UString), since
toString() no longer returns a "C++ string".
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::addValueToArray):
- WebView/WebFrame.mm:
(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
../WebKit2:
Reviewed by Gavin Barraclough.
Mechanical changes to call value() after calling toString(), to
convert from "JS string" (JSString*) to "C++ string" (UString), since
toString() no longer returns a "C++ string".
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):
- 11:09 PM Changeset in webkit [105697] by
-
- 3 edits in trunk/Source/WebCore
In CodeGeneratorObjC.pm, overwrite the output .h/.mm
only if the bytes differ
https://bugs.webkit.org/show_bug.cgi?id=76874
Reviewed by Adam Barth.
This is one of steps to stop rebuilding .h/.cpp/.mm files
generated by unchanged IDLs (bug 76836).
This patch makes a change on CodeGeneratorObjC.pm so that
it overwrites the output .h/.mm only if the bytes differ.
No tests. No change in behavior.
I manually confirmed that when I add a new attribute to Element.idl,
the time-stamps of unrelated DOM*.h and DOM*.mm do not change.
- bindings/scripts/CodeGenerator.pm:
(UpdateFileIfChanged): Added. This method writes data to a file
only if the data is different from the data in the current file.
- bindings/scripts/CodeGeneratorObjC.pm:
(WriteData): Used UpdateFileIfChanged().
- 10:46 PM Changeset in webkit [105696] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-23
- DEPS:
- 10:43 PM Changeset in webkit [105695] by
-
- 7 edits10 adds in trunk
REGRESSION: Downloaded file name fallback encodings are not set correctly
https://bugs.webkit.org/show_bug.cgi?id=76862
Reviewed by Adam Barth.
Source/WebCore:
Tests: http/tests/download/default-encoding.html
http/tests/download/form-submission-result.html
http/tests/download/inherited-encoding.html
http/tests/download/literal-utf-8.html
- loader/DocumentWriter.cpp:
- loader/DocumentWriter.h:
Removed deprecatedFrameEncoding. Due to changes in Document::encoding behavior, it can now
be used in its place.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest): Instead of hunting
down a correct loader (and active one is not always correct any more), just use opening document's
encoding.
LayoutTests:
- http/tests/download/default-encoding-expected.txt: Added.
- http/tests/download/default-encoding.html: Added.
- http/tests/download/inherited-encoding-expected.txt: Added.
- http/tests/download/inherited-encoding.html: Added.
- http/tests/download/literal-utf-8-expected.txt: Added.
- http/tests/download/literal-utf-8.html: Added.
- http/tests/download/resources/literal-koi8-r.php: Added.
- http/tests/download/resources/literal-utf-8.php: Added.
- http/tests/download/inherited-encoding-form-submission-result-expected.txt: Added.
- http/tests/download/inherited-encoding-form-submission-result.html: Added.
- 10:26 PM Changeset in webkit [105694] by
-
- 10 edits in trunk
Implement flex-pack:distribute
https://bugs.webkit.org/show_bug.cgi?id=76864
Reviewed by Tony Chang.
Source/WebCore:
See http://dev.w3.org/csswg/css3-flexbox/#flex-pack.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexPack):
- css/CSSValueKeywords.in:
- rendering/RenderFlexibleBox.cpp:
(WebCore::initialPackingOffset):
(WebCore::packingSpaceBetweenChildren):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse):
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleFlexibleBoxData.h:
LayoutTests:
- css3/flexbox/004-expected.txt:
- css3/flexbox/004.html:
- 9:44 PM Changeset in webkit [105693] by
-
- 5 edits in trunk/Source/WebCore
Implement CSS clip property in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=74913
Reviewed by Andreas Kling.
No new tests / refactoring only.
- css/CSSPrimitiveValue.h:
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength):
This new function aims to provide a single call for converting many CSSPrimitiveValue
values to Lengths. It is templated to allow the caller to specify which conversions
are appropriate depending on the context in which the value is used.
- css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyClip::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- 9:19 PM Changeset in webkit [105692] by
-
- 2 edits2 copies in branches/chromium/963
Merge 105386 - REGRESSION(r100111): A 'change' event does not fire when a mouse drag
occurs to switch elements in a listbox <select>
https://bugs.webkit.org/show_bug.cgi?id=76244
Reviewed by Hajime Morita.
Source/WebCore:
Test: fast/forms/select/listbox-drag-in-non-multiple.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::updateSelectedState):
Do not update m_activeSelectionState for non-multiple <select>.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
Use setActiveSelection*Index() and updateListBoxSelection(true) instead
of updateSelectedState() because updateSelectedState() updates
m_lastOnChangeSelection and will prevent the mouseup handler from
dispatching 'change' event.
We should not call listBoxOnChange() in the mousemove handler in order
to align the behavior of IE and Firefox.
LayoutTests:
- fast/forms/resources/common.js:
(mouseMoveToIndexInListbox): Added.
- fast/forms/select/listbox-drag-in-non-multiple-expected.txt: Added.
- fast/forms/select/listbox-drag-in-non-multiple.html: Added.
TBR=tkent@chromium.org
BUG=crbug.com/110068
Review URL: https://chromiumcodereview.appspot.com/9285007
- 9:08 PM Changeset in webkit [105691] by
-
- 5 edits15 adds in trunk
decodeEscapeSequences() not correct for some encodings (GBK, Big5, ...).
https://bugs.webkit.org/show_bug.cgi?id=71316
Reviewed by Daniel Bates.
Source/WebCore:
Pass trailing unescaped bytes into the character set decoder to get correct
results in the presence of encodings which re-use ASCII values in sequences.
Tests: http/tests/navigation/anchor-frames-gbk.html
http/tests/security/xssAuditor/iframe-onload-GBK-char.html
http/tests/security/xssAuditor/img-onerror-GBK-char.html
http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode.html
http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode.html
http/tests/security/xssAuditor/script-tag-Big5-char.html
http/tests/security/xssAuditor/script-tag-Big5-char2.html
- platform/text/DecodeEscapeSequences.h:
(WebCore::Unicode16BitEscapeSequence::findInString):
(WebCore::Unicode16BitEscapeSequence::findEndOfRun):
(WebCore::Unicode16BitEscapeSequence::decodeRun):
(WebCore::URLEscapeSequence::findInString):
(WebCore::URLEscapeSequence::findEndOfRun):
(WebCore::URLEscapeSequence::decodeRun):
(WebCore::decodeEscapeSequences):
LayoutTests:
- http/tests/navigation/anchor-frames-gbk-expected.txt: Added.
- http/tests/navigation/anchor-frames-gbk.html: Added.
- http/tests/navigation/resources/frame-with-anchor-gbk.html: Added.
- http/tests/security/xssAuditor/iframe-onload-GBK-char-expected.txt: Added.
- http/tests/security/xssAuditor/iframe-onload-GBK-char.html: Added.
- http/tests/security/xssAuditor/img-onerror-GBK-char-expected.txt: Added.
- http/tests/security/xssAuditor/img-onerror-GBK-char.html: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-decode-16bit-unicode.pl:
- http/tests/security/xssAuditor/script-tag-Big5-char-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode.html: Added.
- http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode.html: Added.
- http/tests/security/xssAuditor/script-tag-Big5-char.html: Added.
- http/tests/security/xssAuditor/script-tag-Big5-char2-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-Big5-char2.html: Added.
- platform/chromium/test_expectations.txt:
- 9:04 PM Changeset in webkit [105690] by
-
- 2 edits in trunk/Source/WebCore
Fix a build break in a clean compile of the Chromium port (at least
reported by tbreisacher).
- css/CSSStyleDeclaration.cpp:
- 8:53 PM Changeset in webkit [105689] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] QQuickWebView is initializing touch mode twice while being constructed
https://bugs.webkit.org/show_bug.cgi?id=76859
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-01-23
Reviewed by Kenneth Rohde Christiansen.
Removing d->initializeTouch() from QQuickWebView::QQuickWebView()
since in QQuickWebViewPrivate::initialize() there is a call for
setUseTraditionalDesktopBehaviour(false), which will call initializeTouch.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::QQuickWebView):
- 8:40 PM Changeset in webkit [105688] by
-
- 6 edits in trunk/Source/WebKit2
[GTK][WK2] Make the LoadTracking and WebView test fixtures more flexible
https://bugs.webkit.org/show_bug.cgi?id=76755
Reviewed by Alejandro G. Castro.
Always clear the loading events when loading new content in the load tracking
test. In the WebView test correctly handle loading HTML with a URL that isn't
"about:blank."
- UIProcess/API/gtk/tests/LoadTrackingTest.cpp:
(LoadTrackingTest::loadURI): Reset the class state when starting a new load.
(LoadTrackingTest::loadHtml): Ditto.
(LoadTrackingTest::loadPlainText): Ditto.
(LoadTrackingTest::loadRequest): Ditto.
- UIProcess/API/gtk/tests/LoadTrackingTest.h: Added new method definitions.
- UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:
(assertNormalLoadHappened): No longer clear loading events. The fixture handles that now.
(testLoadHtml): Update to reflect new method name.
(testLoadPlainText): Ditto.
(testLoadRequest): Ditto.
(testWebViewReload): Ditto.
- UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::loadHtml): Properly interpret the baseURL parameter.
- UIProcess/API/gtk/tests/WebViewTest.h: Make loading methods virtual.
- 8:38 PM Changeset in webkit [105687] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Clean up old WebSharedWorker::startWorkerContext() method.
https://bugs.webkit.org/show_bug.cgi?id=76853
Reviewed by Darin Fisher.
- public/WebSharedWorker.h:
- src/WebSharedWorkerImpl.cpp:
- src/WebSharedWorkerImpl.h:
- 8:23 PM Changeset in webkit [105686] by
-
- 10 edits in trunk
[GTK] editing/deleting/5408255.html results are incorrect
https://bugs.webkit.org/show_bug.cgi?id=53644
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-01-23
Reviewed by Martin Robinson.
Source/WebCore:
When the WEBKIT_TOP_LEVEL environment variable is set, resources
should be loaded from the source tree to which the variable is
pointing. This approach is used when performing testing on the
Gtk port.
No new tests, changes cause one test to pass.
- platform/graphics/gtk/ImageGtk.cpp:
(getPathToImageResource): Also make changes to the resource path
construction code on Windows.
(WebCore::Image::loadPlatformResource):
Tools:
WEBKIT_TOP_LEVEL environment variable is now set directly in either
WebKitTestRunner or DumpRenderTree through usage of a compilation-time
macro. This way both tools can be run outside the test harness without
the need to manually set the environment variable.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(getTopLevelPath):
- GNUmakefile.am:
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.setup_environ_for_server):
- WebKitTestRunner/GNUmakefile.am:
- WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
(WTR::InjectedBundle::platformInitialize):
LayoutTests:
Unskip newly-passing editing test.
- platform/gtk/Skipped:
- 8:15 PM Changeset in webkit [105685] by
-
- 3 edits2 adds in trunk
Crash in WebCore::RenderTableSection::rowLogicalHeightChanged
https://webkit.org/b/76842
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/table/crash-section-logical-height-changed-needsCellRecalc.html
The issue was that we would access our section's structure when it was dirty.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::rowLogicalHeightChanged):
Bail out if we need cells recalculation as our internal structure is not up-to-date
and we will recompute all the rows' heights as part of the recomputation anyway.
LayoutTests:
- fast/table/crash-section-logical-height-changed-needsCellRecalc-expected.txt: Added.
- fast/table/crash-section-logical-height-changed-needsCellRecalc.html: Added.
- 8:07 PM Changeset in webkit [105684] by
-
- 7 edits2 adds in trunk
Source/WebKit/chromium: [Chromium] Implement layoutTestController.workerThreadCount in DRT
https://bugs.webkit.org/show_bug.cgi?id=74653.
Expose WebCore::WorkerThread::workerThreadCount() in API layer
for DumpRenderTree.
Reviewed by Darin Fisher.
- WebKit.gyp:
- public/WebWorkerInfo.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.
- src/WebWorkerInfo.cpp: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.
(WebKit::WebWorkerInfo::dedicatedWorkerCount):
Tools: [Chromium] Implement layoutTestController.workerThreadCount in DRT
https://bugs.webkit.org/show_bug.cgi?id=74653.
Reviewed by Darin Fisher.
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::workerThreadCount):
- DumpRenderTree/chromium/LayoutTestController.h:
LayoutTests: [Chromium] Implement layoutTestController.workerThreadCount in DRT
https://bugs.webkit.org/show_bug.cgi?id=74653.
Reviewed by Darin Fisher.
- platform/chromium/test_expectations.txt:
- 7:59 PM Changeset in webkit [105683] by
-
- 2 edits in trunk/Source/WebCore
[Refactoring] Make finish() of CodeGeneratorJS.pm empty
https://bugs.webkit.org/show_bug.cgi?id=76846
Reviewed by Adam Barth.
This is one of steps to stop rebuilding .h/.cpp files generated
by unchanged IDLs (bug 76836).
As a refactoring, we are planning to remove finish() from all
CodeGenerators. In this bug, we make finish() of CodeGeneratorJS.pm
empty.
No new tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(finish): Made it empty. We will remove finish() after
making finish() of all CodeGenerators empty.
(GenerateInterface): Modified to call WriteData().
(WriteData): Simple code refactoring.
Removed if(defined $IMPL).
Removed if(defined $HEADER).
Removed if(defined $DEPS).
$IMPL -> IMPL.
$HEADER -> HEADER.
$DEPS -> DEPS.
- 7:55 PM Changeset in webkit [105682] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r105676.
http://trac.webkit.org/changeset/105676
https://bugs.webkit.org/show_bug.cgi?id=76665
Breaks build on max due to compile warnings.
- runtime/JSObject.cpp:
(JSC::JSObject::finalize):
(JSC::JSObject::visitChildren):
(JSC::JSObject::allocatePropertyStorage):
- runtime/JSObject.h:
- 7:20 PM Changeset in webkit [105681] by
-
- 5 edits in trunk/Source/WebKit/chromium
Fine tune Web Intents Chromium API
https://bugs.webkit.org/show_bug.cgi?id=76754
Patch by Greg Billock <gbillock@google.com> on 2012-01-23
Reviewed by Darin Fisher.
- public/WebIntent.h:
- public/WebIntentServiceInfo.h:
- src/WebIntent.cpp:
- src/WebIntentServiceInfo.cpp:
(WebKit::WebIntentServiceInfo::WebIntentServiceInfo):
- 6:45 PM Changeset in webkit [105680] by
-
- 5 edits in trunk/Source
[chromium] updateRect is incorrect when contentBounds != bounds
https://bugs.webkit.org/show_bug.cgi?id=72919
Reviewed by James Robinson.
Source/WebCore:
Unit test added to TiledLayerChromiumTest.cpp
The m_updateRect member in LayerChromium types is used to track
what was painted for that layer. For tiled layers (especially
image layers), the updateRect was being given with respect to the
size of the content, rather than the size of the layer. This patch
adds a conversion so that updateRect is always with respect to the
layer size, so that damage tracking will work correctly in those
cases.
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):
Source/WebKit/chromium:
- tests/TiledLayerChromiumTest.cpp:
(WTF::FakeTiledLayerWithScaledBounds::FakeTiledLayerWithScaledBounds):
(WTF::FakeTiledLayerWithScaledBounds::setContentBounds):
(WTF::FakeTiledLayerWithScaledBounds::contentBounds):
(WTF::FakeTiledLayerWithScaledBounds::updateRect):
(WTF::TEST):
- 6:39 PM Changeset in webkit [105679] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Make "Copy as HTML" use the same copy functions as other copy methods.
https://bugs.webkit.org/show_bug.cgi?id=76706
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-01-23
Reviewed by Pavel Feldman.
Changed DOMAgent.copyNode to call getOuterHTML and use the callback function to
return the text to InspectorFrontendHost.copyText. This will make all copy
functions use the same code path.
Not testable.
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorDOMAgent.h:
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.copyNode.copy):
(WebInspector.DOMNode.prototype.copyNode):
- 6:36 PM Changeset in webkit [105678] by
-
- 3 edits in trunk/Source/WebCore
Make zoom multiplier float instead of double to match RenderStyle::effectiveZoom etc. and thus avoid unnecessary precision conversions.
https://bugs.webkit.org/show_bug.cgi?id=69490
Reviewed by Andreas Kling.
Covered by existing tests.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLength):
Use float multiplier instead of double.
(WebCore::CSSPrimitiveValue::computeLengthDouble):
Use float multiplier instead of double.
- css/CSSPrimitiveValue.h:
Change type signatures of computeLength template prototype.
- 6:33 PM Changeset in webkit [105677] by
-
- 66 adds in branches/subpixellayout/Source
Add missing files
- 6:29 PM Changeset in webkit [105676] by
-
- 3 edits in trunk/Source/JavaScriptCore
Use copying collector for out-of-line JSObject property storage
https://bugs.webkit.org/show_bug.cgi?id=76665
Reviewed by Geoffrey Garen.
- runtime/JSObject.cpp:
(JSC::JSObject::visitChildren): Changed to use copyAndAppend whenever the property storage is out-of-line.
(JSC::JSObject::allocatePropertyStorage): Changed to use tryAllocateStorage/tryReallocateStorage as opposed to
operator new.
- runtime/JSObject.h:
- 6:18 PM Changeset in webkit [105675] by
-
- 5 edits in trunk/Source/WebKit/chromium
[Chromium][WebSocket] Remove binary communication using WebData in WebKit API
https://bugs.webkit.org/show_bug.cgi?id=76608
Reviewed by Darin Fisher.
- public/WebSocket.h: Remove BinaryTypeData definition and sendBinary(const WebData&).
- public/WebSocketClient.h: Remove didReceiveBinaryData(const WebData&).
- src/WebSocketImpl.cpp: Remove WebData related code and set default binary type as BinaryTypeBlob.
(WebKit::WebSocketImpl::WebSocketImpl): Remove sendBinary(const WebData&).
(WebKit::WebSocketImpl::didReceiveBinaryData): Remove WebData supporting code.
- src/WebSocketImpl.h: Remove sendBinary(const WebData&).
- 6:09 PM Changeset in webkit [105674] by
-
- 4 edits in trunk/Tools
nrwt: make --chromium work like --qt
https://bugs.webkit.org/show_bug.cgi?id=76875
Reviewed by Adam Barth.
--chromium used to have to be handled differently from --qt
due to the way the PortFactory was implemented; there's not
really a good reason for that any more so this patch makes
things slightly more consistent and eliminates the
options.chromium flag (--chromium is now truly a synonym for
--platform chromium).
- Scripts/webkitpy/layout_tests/port/factory.py:
(PortFactory._default_port):
(PortFactory.get):
- Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.setUp):
(FactoryTest.test_chromium_mac):
(FactoryTest.test_chromium_linux):
(FactoryTest.test_chromium_win):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 6:05 PM Changeset in webkit [105673] by
-
- 2 edits in trunk/Tools
run-webkit-tests needs to propagate --chromium
https://bugs.webkit.org/show_bug.cgi?id=76870
Reviewed by Eric Seidel.
run-webkit-tests removes '--chromium' argument from @ARGV when
determining which port to run, which means that that doesn't
propagate to new-run-webkit-tests. That's bad (and is handled
for the other ports by re-adding the flag, but apparently we're
just now noticing for Chromium).
- Scripts/run-webkit-tests:
- 6:00 PM Changeset in webkit [105672] by
-
- 4 edits in trunk/LayoutTests
Unreviewed test expectations fixes for a couple of window/frame tests.
- http/tests/security/cross-frame-access-put-expected.txt:
Updated expectations to reflect that window.frameElement now has the type
HTMLIFrameElement. The test itself has already been updated.
- platform/mac/fast/dom/Window/window-properties-expected.txt:
Added window.applicationCache.abort method.
- platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
Added DOMURL class.
- 5:59 PM Changeset in webkit [105671] by
-
- 2 edits in trunk/Source/WebCore
[GTK][PATCH] More build silencing with (AM_V_...)
https://bugs.webkit.org/show_bug.cgi?id=76791
Patch by Priit Laes <plaes@plaes.org> on 2012-01-23
Reviewed by Gustavo Noronha Silva.
- GNUmakefile.am: Silence is golden...
- 5:54 PM Changeset in webkit [105670] by
-
- 14 edits in trunk/Source/WebKit2
[Qt] Implement SSL error handling QML API.
https://bugs.webkit.org/show_bug.cgi?id=76793
Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-23
Reviewed by Simon Hausmann.
This patch implements support for accepting or rejecting invalid SSL
certificates from the QML API.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::handleCertificateVerificationRequest):
(QQuickWebViewExperimental::certificateVerificationDialog):
(QQuickWebViewExperimental::setCertificateVerificationDialog):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::certificateVerificationRequest):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/qt/QtDialogRunner.cpp:
(CertificateVerificationDialogContextObject::CertificateVerificationDialogContextObject):
(CertificateVerificationDialogContextObject::hostname):
(CertificateVerificationDialogContextObject::accept):
(CertificateVerificationDialogContextObject::reject):
(QtDialogRunner::initForCertificateVerification):
- UIProcess/qt/QtDialogRunner.h:
- UIProcess/qt/QtPageClient.cpp:
(QtPageClient::handleCertificateVerificationRequest):
- UIProcess/qt/QtPageClient.h:
- WebProcess/qt/QtNetworkAccessManager.cpp:
(WebKit::QtNetworkAccessManager::QtNetworkAccessManager):
(WebKit::QtNetworkAccessManager::onSslErrors):
- WebProcess/qt/QtNetworkAccessManager.h:
- 5:47 PM Changeset in webkit [105669] by
-
- 4 edits in trunk
More build fixing after r105646.
Source/JavaScriptCore:
- JavaScriptCore.exp:
Tools:
- TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
(TestWebKitAPI::TestNode::key):
- 5:36 PM Changeset in webkit [105668] by
-
- 12 edits in trunk/Source/WebCore
MicroData: Remove ExceptionCode& from setAttribute() call.
https://bugs.webkit.org/show_bug.cgi?id=76695
Patch by Arko Saha <nghq36@motorola.com> on 2012-01-23
Reviewed by Hajime Morita.
Changeset http://trac.webkit.org/changeset/103296 removed unused
ExceptionCode& argument from Element::setAttribute(QualifiedName).
Hence updating all calls to setAttribute() method in MicroData code.
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::setItemValueText):
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::setItemValueText):
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::setItemValueText):
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::setItemValueText):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::setItemValueText):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setItemValueText):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setItemValueText):
- html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::setItemValueText):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::setItemValueText):
- html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::setItemValueText):
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::setItemValueText):
- 5:31 PM Changeset in webkit [105667] by
-
- 6 edits in trunk/Source
[windows] Convert usages of GetDC to HWndDC Part 2.
https://bugs.webkit.org/show_bug.cgi?id=76750
Reviewed by Adam Roben.
Source/WebKit/win:
- FullscreenVideoController.cpp:
(createCompatibleDCForWindow): Moved out the code which creates a DC for a window
to keep the same scope for the DC lifetime.
(FullscreenVideoController::draw): Switch to using OwnPtr<HDC>
since createCompatibleDCForWindow returns a PassOwnPtr.
- WebNodeHighlight.cpp:
(WebNodeHighlight::update):
Cleaned up leaks from calling GetDC without release.
Note that there is a potential leak of hdc that previously existed
and still does in an early exit scenario. (This could be easily fixed
by using OwnPtr<HDC> but I was trying to keep this patch focused.)
- WebView.cpp:
(WebView::scrollBackingStore): Typical conversion.
(WebView::updateBackingStore): Reduced the scope of windowDC to be
right where it is being used.
(WebView::performLayeredWindowUpdate): Typical conversion.
(WebView::paintIntoBackingStore): Ditto.
Source/WebKit2:
- Shared/win/ShareableBitmapWin.cpp:
(WebKit::ShareableBitmap::windowsContext): Fix incorrect usage of OwnPtr<HDC> which
would do a DeleteDC instead of a ReleaseDC.
- 5:21 PM Changeset in webkit [105666] by
-
- 2 edits in trunk/Tools
Unreviewed build fix - r105646 broke this.
- TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
(TestWebKitAPI::TestNode::TestNode):
(TestWebKitAPI::TestNode::key):
(TestWebKitAPI::RedBlackTreeTest::assertEqual):
(TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
(TestWebKitAPI::RedBlackTreeTest::testDriver):
- 5:21 PM Changeset in webkit [105665] by
-
- 3 edits2 adds in trunk
Fix crash when a focused node is removed while in processing focusin event.
https://bugs.webkit.org/show_bug.cgi?id=76656
Reviewed by Dimitri Glazkov.
Source/WebCore:
Test: fast/events/focus-remove-focuesed-node.html
- dom/Document.cpp:
(WebCore::Document::setFocusedNode):
LayoutTests:
- fast/events/focus-remove-focuesed-node-expected.txt: Added.
- fast/events/focus-remove-focuesed-node.html: Added.
- 5:16 PM Changeset in webkit [105664] by
-
- 4 edits in trunk/LayoutTests
Switch media/audio-data-url.html layout test to base64-encoded WAV data.
https://bugs.webkit.org/show_bug.cgi?id=76759
Reviewed by Eric Carlson.
- media/audio-data-url-expected.txt:
- media/audio-data-url.html:
- platform/chromium/test_expectations.txt:
- 5:10 PM Changeset in webkit [105663] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r105658.
http://trac.webkit.org/changeset/105658
https://bugs.webkit.org/show_bug.cgi?id=76883
We want this eventually, but not right at this moment
(Requested by abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-23
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- 5:09 PM Changeset in webkit [105662] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Add <(SHARED_INTERMEDIATE_DIR)/webkit to include path of targets that depend on WebKit API so they pick up the copied headers in an onion build
https://bugs.webkit.org/show_bug.cgi?id=76879
Reviewed by Dirk Pranke.
- WebKit.gyp:
- 5:07 PM Changeset in webkit [105661] by
-
- 13 edits in trunk/Source
[windows] Convert usages of GetDC to HWndDC Part 1.
https://bugs.webkit.org/show_bug.cgi?id=76744
Reviewed by Adam Roben.
Source/WebCore:
No new functionality so no new tests.
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::getFontDataForCharacters): Changed GetDC to HWndDC
and removed ReleaseDC.
(WebCore::createGDIFont): Ditto.
(WebCore::FontCache::getTraitsInFamily): Ditto.
- platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Ditto.
- platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformInit): Ditto.
- platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::initGDIFont): Ditto.
(WebCore::SimpleFontData::containsCharacters): Ditto.
(WebCore::SimpleFontData::determinePitch): Ditto.
(WebCore::SimpleFontData::boundsForGDIGlyph): Ditto.
(WebCore::SimpleFontData::widthForGDIGlyph): Ditto.
(WebCore::SimpleFontData::scriptFontProperties): Ditto.
- platform/win/CursorWin.cpp:
(WebCore::createSharedCursor): Ditto.
- platform/win/DragImageCGWin.cpp:
(WebCore::scaleDragImage): Ditto.
(WebCore::createDragImageFromImage): Ditto.
- platform/win/DragImageWin.cpp:
(WebCore::createDragImageForLink): Ditto.
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeImage): Ditto.
Source/WebKit/win:
- WebIconDatabase.cpp:
(createDIB): Changed GetDC to HWndDC and removed ReleaseDC.
Source/WebKit2:
- UIProcess/win/WebView.cpp:
(WebKit::WebView::flashBackingStoreUpdates): Typical conversion.
- 4:54 PM Changeset in webkit [105660] by
-
- 5 edits in trunk/Source/WebCore
[GTK] Scrollbars do not respect the has-backward-stepper and has-forward-stepper properties
https://bugs.webkit.org/show_bug.cgi?id=76747
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-01-23
Reviewed by Gustavo Noronha Silva.
No new tests. Regressions are covered by existing tests, but testing
different GTK+ theme configurations is not possible yet.
- platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::backButtonRect): If there is no back stepper, return an empty rect.
(WebCore::ScrollbarThemeGtk::forwardButtonRect): If there is no forward stepper, return an empty rect.
(WebCore::ScrollbarThemeGtk::trackRect): Adjust track rect calculation to account for when there is
no steppers.
- platform/gtk/ScrollbarThemeGtk.h: New members describing whether there are primary steppers.
- platform/gtk/ScrollbarThemeGtk2.cpp:
(WebCore::ScrollbarThemeGtk::updateThemeProperties): Look at the theme to determine if there
are primary foward and back steppers.
- platform/gtk/ScrollbarThemeGtk3.cpp:
(WebCore::ScrollbarThemeGtk::updateThemeProperties): Ditto.
- 4:47 PM Changeset in webkit [105659] by
-
- 3 edits4 adds in trunk
REGRESSION(r105396): drag state is not cleared after each drag
https://bugs.webkit.org/show_bug.cgi?id=76878
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Revert a part of r105396 that made performDragAndDrop not call clearDragState
when the default action was not prevented since it caused a regression.
I'm pretty certain always calling clearDragState in performDragAndDrop is wrong
but I can't think of a test case where this becomes a problem at the moment.
Since this area is not well tested, revert the change instead of making further
changes to the code base.
Tests: fast/events/clear-drag-state.html
fast/events/clear-edit-drag-state.html
- page/EventHandler.cpp:
(WebCore::EventHandler::performDragAndDrop):
LayoutTests:
Add a regression test to ensure we don't fire extra dragenter event
on the second drag at an element that contains the dragged content.
- fast/events/clear-drag-state-expected.txt: Added.
- fast/events/clear-drag-state.html: Added.
- fast/events/clear-edit-drag-state-expected.txt: Added.
- fast/events/clear-edit-drag-state.html: Added.
- 4:41 PM Changeset in webkit [105658] by
-
- 2 edits in trunk/Tools
garden-o-matic should support Chromium Mac Lion
https://bugs.webkit.org/show_bug.cgi?id=76880
Reviewed by Eric Seidel.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- 4:40 PM Changeset in webkit [105657] by
-
- 5 edits in trunk/Source/WebCore
Fixed typo in exception messages
https://bugs.webkit.org/show_bug.cgi?id=76710
Patch by Thiago Marcos P. Santos <tmpsantos@gmail.com> on 2012-01-23
Reviewed by Alexey Proskuryakov.
- dom/DOMCoreException.cpp:
- fileapi/FileException.cpp:
- storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::postflightAndCommit):
- xml/XMLHttpRequestException.cpp:
- 4:35 PM Changeset in webkit [105656] by
-
- 2 edits in trunk/Source/WebCore
Allow delayed DC allocation in HWndDC.
https://bugs.webkit.org/show_bug.cgi?id=76737
Reviewed by Adam Roben.
No new functionality exposed so no new tests.
- platform/win/HWndDC.h: Changed this slightly to allow
for allocating a window DC after the initial creation since
this pattern occurrs in several places so this makes it easy to
replace them in an upcoming change.
(WebCore::HWndDC::HWndDC):
(WebCore::HWndDC::~HWndDC):
(WebCore::HWndDC::setHWnd):
(WebCore::HWndDC::clear):
- 4:26 PM Changeset in webkit [105655] by
-
- 6 edits in trunk/Source/WebCore
MicroData: Compilation error while building Webkit with --microdata.
https://bugs.webkit.org/show_bug.cgi?id=76703
Patch by Arko Saha <nghq36@motorola.com> on 2012-01-23
Reviewed by Hajime Morita.
- dom/MicroDataItemList.cpp:
(WebCore::MicroDataItemList::MicroDataItemList):
(WebCore::MicroDataItemList::~MicroDataItemList):
- dom/MicroDataItemList.h:
- dom/NodeRareData.h:
(WebCore::NodeRareData::properties):
- html/HTMLPropertiesCollection.cpp:
(WebCore::HTMLPropertiesCollection::create):
(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
- html/HTMLPropertiesCollection.h:
- 4:22 PM Changeset in webkit [105654] by
-
- 8 edits in trunk/Source/WebCore
[chromium] Convert uses of GetDC to HWndDC.
https://bugs.webkit.org/show_bug.cgi?id=76290
Reviewed by Dmitry Titov.
- platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::createFontIndirectAndGetWinName):
(WebCore::fontContainsCharacter):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::getTraitsInFamily):
- platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
(WebCore::FontPlatformData::scriptFontProperties):
- platform/graphics/chromium/FontUtilsChromiumWin.cpp:
(WebCore::FontMap::getAscent):
(WebCore::FontMap::getSpaceGlyph):
- platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::fillBMPGlyphs):
- platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformWidthForGlyph):
- platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::EnsureCachedDCCreated):
- rendering/RenderThemeChromiumWin.cpp:
(WebCore::systemFontSize):
(WebCore::pointsToPixels):
- 4:13 PM Changeset in webkit [105653] by
-
- 2 edits in trunk/Websites/webkit.org
website: Reword WEBKITOUTPUTDIR documentation on Building WebKit page
https://bugs.webkit.org/show_bug.cgi?id=76544
Patch by Seo Sanghyeon <sh4.seo@samsung.com> on 2012-01-23
Reviewed by Darin Adler.
WEBKITOUTPUTDIR is not only for Windows.
- building/build.html:
- 4:01 PM Changeset in webkit [105652] by
-
- 3 edits in trunk/Tools
check-webkit-style whitespace/operators triggers on overloaded division operator
https://bugs.webkit.org/show_bug.cgi?id=76650
Reviewed by Darin Adler.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_operator_methods):
- 4:00 PM Changeset in webkit [105651] by
-
- 4 edits1 add3 deletes in trunk/LayoutTests
Reduce throttling on video-buffering-repaints-controls test to prevent timeout.
https://bugs.webkit.org/show_bug.cgi?id=76113
Also reduces flakiness by checking for a repaint between progress and
suspend events versus just between progress events.
Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-23
Reviewed by Adam Barth.
- http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
- http/tests/media/video-buffering-repaints-controls.html:
- platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png:
- platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
- platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/gtk/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
- 3:49 PM Changeset in webkit [105650] by
-
- 4 edits in trunk/Tools
run-perf-tests should report server-side errors
https://bugs.webkit.org/show_bug.cgi?id=76802
Reviewed by Tony Chang.
Report errors whenever server's response doesn't match "OK".
- Scripts/webkitpy/common/net/file_uploader.py:
(FileUploader.upload_single_text_file):
(FileUploader.upload_as_multipart_form_data):
(FileUploader._upload_data.callback):
(FileUploader):
(FileUploader._upload_data):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._upload_json):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_upload_json):
(test_upload_json.MockFileUploader.upload_single_text_file):
- 3:46 PM Changeset in webkit [105649] by
-
- 5 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=75799
Calling intersectsNode on a detached range should throw.
Source/WebCore:
INVALID_STATE_ERR exception should be thrown if intersectsNode is called on a detached Range.
Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-23
Reviewed by Darin Adler.
Test: fast/dom/Range/range-intersectsNode-exception.html
- dom/Range.cpp:
(WebCore::Range::intersectsNode): Throwing INVALID_STATE_ERR exception if the range is detached.
LayoutTests:
Added test case to verify the exception thrown while calling intersectsNode on a detached range.
Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-23
Reviewed by Darin Adler.
- fast/dom/Range/range-intersectsNode-exception-expected.txt: Added.
- fast/dom/Range/range-intersectsNode-exception.html: Added.
- fast/dom/Range/range-intersectsNode-expected.txt:
- fast/dom/Range/resources/intersectsNode.js: Modified the test case to catch the exception.
- 3:35 PM Changeset in webkit [105648] by
-
- 19 edits1 delete in trunk/Source/WebCore
Convert DataTransferItem/DataTransferItemList back into an interface class
https://bugs.webkit.org/show_bug.cgi?id=76856
When Qt implemented the DataTransferItemList, a lot of logic was moved into the shared
classes since Chromium/Qt happened to implement it the same way. Now that I want to do some
refactoring/cleanup work to better implement DataTransferItemList in Chromium, we won't
share the same data anymore so it doesn't make sense to keep that code in a common location.
Reviewed by David Levin.
Covered by existing tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/DataTransferItem.cpp:
- dom/DataTransferItem.h:
- dom/DataTransferItemList.cpp: Removed.
- dom/DataTransferItemList.h:
- platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::mayUpdateItems):
- platform/chromium/DataTransferItemChromium.cpp:
(WebCore::DataTransferItemChromium::create):
(WebCore::DataTransferItemChromium::DataTransferItemChromium):
(WebCore::DataTransferItemChromium::getAsString):
(WebCore::DataTransferItemChromium::getAsFile):
(WebCore::DataTransferItemChromium::clipboardChromium):
- platform/chromium/DataTransferItemChromium.h:
(WebCore::DataTransferItemChromium::kind):
(WebCore::DataTransferItemChromium::type):
- platform/chromium/DataTransferItemListChromium.cpp:
(WebCore::DataTransferItemListChromium::DataTransferItemListChromium):
- platform/chromium/DataTransferItemListChromium.h:
- platform/qt/DataTransferItemListQt.cpp:
(WebCore::DataTransferItemListQt::DataTransferItemListQt):
(WebCore::DataTransferItemListQt::length):
(WebCore::DataTransferItemListQt::item):
(WebCore::DataTransferItemListQt::deleteItem):
(WebCore::DataTransferItemListQt::clear):
(WebCore::DataTransferItemListQt::add):
- platform/qt/DataTransferItemListQt.h:
- platform/qt/DataTransferItemQt.cpp:
(WebCore::DataTransferItemQt::create):
(WebCore::DataTransferItemQt::DataTransferItemQt):
(WebCore::DataTransferItemQt::getAsString):
(WebCore::DataTransferItemQt::getAsFile):
- platform/qt/DataTransferItemQt.h:
(WebCore::DataTransferItemQt::kind):
(WebCore::DataTransferItemQt::type):
- 3:32 PM Changeset in webkit [105647] by
-
- 1 edit2 adds in trunk/LayoutTests
getComputedStyle margin percentage test for CSS calc
https://bugs.webkit.org/show_bug.cgi?id=76130
Reviewed by Darin Adler.
Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.
- css3/calc/getComputedStyle-margin-percentage-expected.txt: Added.
- css3/calc/getComputedStyle-margin-percentage.html: Added.
- 3:30 PM Changeset in webkit [105646] by
-
- 5 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=76855
Implement a JIT-code aware sampling profiler for JSC
Reviewed by Geoff Garen.
Step 2: generalize RedBlackTree. The profiler is going to want tio use
a RedBlackTree, allow this class to work with subclasses of
RedBlackTree::Node, Node should not need to know the names of the m_key
and m_value fields (the subclass can provide a key() accessor), and
RedBlackTree does not need to know anything about ValueType.
- JavaScriptCore.exp:
- wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::findAndRemoveFreeSpace):
(WTF::MetaAllocator::debugFreeSpaceSize):
(WTF::MetaAllocator::addFreeSpace):
- wtf/MetaAllocator.h:
(WTF::MetaAllocator::FreeSpaceNode::FreeSpaceNode):
(WTF::MetaAllocator::FreeSpaceNode::key):
- wtf/MetaAllocatorHandle.h:
(WTF::MetaAllocatorHandle::key):
- wtf/RedBlackTree.h:
(WTF::RedBlackTree::Node::successor):
(WTF::RedBlackTree::Node::predecessor):
(WTF::RedBlackTree::Node::parent):
(WTF::RedBlackTree::Node::setParent):
(WTF::RedBlackTree::Node::left):
(WTF::RedBlackTree::Node::setLeft):
(WTF::RedBlackTree::Node::right):
(WTF::RedBlackTree::Node::setRight):
(WTF::RedBlackTree::insert):
(WTF::RedBlackTree::remove):
(WTF::RedBlackTree::findExact):
(WTF::RedBlackTree::findLeastGreaterThanOrEqual):
(WTF::RedBlackTree::findGreatestLessThanOrEqual):
(WTF::RedBlackTree::first):
(WTF::RedBlackTree::last):
(WTF::RedBlackTree::size):
(WTF::RedBlackTree::treeMinimum):
(WTF::RedBlackTree::treeMaximum):
(WTF::RedBlackTree::treeInsert):
(WTF::RedBlackTree::leftRotate):
(WTF::RedBlackTree::rightRotate):
(WTF::RedBlackTree::removeFixup):
- 3:01 PM Changeset in webkit [105645] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed buildfix for ENABLE(MUTATION_OBSERVERS) following r105642.
- css/CSSMutableStyleDeclaration.cpp:
- 2:42 PM Changeset in webkit [105644] by
-
- 4 edits in trunk/Tools
run-perf-tests ignore Skipped list on chromium
https://bugs.webkit.org/show_bug.cgi?id=76764
Reviewed by Dirk Pranke.
Move skipped_perf_tests from WebKit port to Base port so that Chromium port
can also find skipped list. Chromium port only uses test_expectations.txt for
layout tests but performacne tests don't use test_expectations.txt so Chromium port
also needs to use Skipped list.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port._tests_from_skipped_file_contents):
(Port):
(Port._expectations_from_skipped_files):
(Port.skipped_perf_tests):
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_skipped_perf_tests):
(PortTest.test_skipped_perf_tests.add_text_file):
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._skipped_tests_for_unsupported_features):
(WebKitPort._skipped_file_search_paths):
(WebKitPort.skipped_layout_tests):
- 2:37 PM Changeset in webkit [105643] by
-
- 3 edits in trunk/Source/WebCore
Update uniteIfNonZero to use isZero.
https://bugs.webkit.org/show_bug.cgi?id=76637
Patch by Philip Rogers <pdr@google.com> on 2012-01-23
Reviewed by Darin Adler.
No new tests. (I found no existing codepath that would be affected by
this change but I think this change is still valuable in preventing
future bugs.)
- platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::uniteIfNonZero):
The following change is a minor followup to
https://bugs.webkit.org/show_bug.cgi?id=76177#c12 and is not directly
related to the rest of this patch.
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::computeContainerBoundingBoxes):
- 2:26 PM Changeset in webkit [105642] by
-
- 24 edits2 deletes in trunk/Source/WebCore
Eliminate CSSElementStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=76848
Reviewed by Andreas Kling.
CSSElementStyleDeclaration has little functionality. It can merge with CSSMutableStyleDeclaration simplifying the code.
Having an element parent is mutually exclusive with having a css rule parent. We can keep them in a union. This also
shrinks all inline style declarations by one pointer.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMBinding.h:
(WebCore::root):
- css/CSSAllInOne.cpp:
- css/CSSElementStyleDeclaration.cpp: Removed.
- css/CSSElementStyleDeclaration.h: Removed.
- css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
- css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::createInline):
(WebCore::CSSMutableStyleDeclaration::createForSVGFontFaceElement):
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
- css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
(WebCore::CSSStyleDeclaration::parentStyleSheet):
Merge the CSSElementStyleDeclaration::styleSheet() logic here.
- css/CSSStyleDeclaration.h:
(WebCore::CSSStyleDeclaration::parentRule):
(WebCore::CSSStyleDeclaration::clearParentRule):
(WebCore::CSSStyleDeclaration::parentElement):
(WebCore::CSSStyleDeclaration::clearParentElement):
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
CSSStyleRule's style declaration can't have isElementStyleDeclaration set, the dead code can be removed.
This is asserted in setDeclaration() and again implicitly in the destructor (by clearParentRule()).
- dom/StyledElement.cpp:
(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::copyNonAttributeProperties):
- dom/StyledElement.h:
(WebCore::StyledElement::inlineStyleDecl):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
- editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
- html/ValidationMessage.cpp:
(WebCore::adjustBubblePosition):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):
- html/shadow/SliderThumbElement.cpp:
(WebCore::TrackLimiterElement::create):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):
- 2:07 PM Changeset in webkit [105641] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r105640.
http://trac.webkit.org/changeset/105640
https://bugs.webkit.org/show_bug.cgi?id=76849
Broke the chromium build.
- DEPS:
- 1:41 PM Changeset in webkit [105640] by
-
- 2 edits in trunk/Source/WebKit/chromium
rolling chromium DEPS to r118713
https://bugs.webkit.org/show_bug.cgi?id=76849
Patch by Justin Novosad <junov@chromium.org> on 2012-01-23
Reviewed by Stephen White.
This is to pick up a change to skia build configuration
- DEPS:
- 1:39 PM Changeset in webkit [105639] by
-
- 4 edits in trunk
Fix the build after r105635.
Source/JavaScriptCore:
- JavaScriptCore.exp:
Tools:
- TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
(TestWebKitAPI::TEST):
- 1:36 PM Changeset in webkit [105638] by
-
- 6 edits in trunk/Source/JavaScriptCore
Remove StackBounds from JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=76310
Reviewed by Sam Weinig.
Removed StackBounds and the stack() function from JSGlobalData since it no
longer accessed any members of JSGlobalData.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- heap/MachineStackMarker.cpp:
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::gatherFromCurrentThread):
- parser/Parser.cpp:
(JSC::::Parser):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
- 1:35 PM Changeset in webkit [105637] by
-
- 3 edits in trunk/Source/WebCore
Use OVERRIDE for PopupMenuClient's implementations
https://bugs.webkit.org/show_bug.cgi?id=76774
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-23
Reviewed by Darin Adler.
- rendering/RenderMenuList.h: Also sort the methods to the same
order as PopupMenuClient.
- rendering/RenderTextControlSingleLine.h:
- 1:08 PM Changeset in webkit [105636] by
-
- 24 edits in trunk/Source/JavaScriptCore
Implement a JIT-code aware sampling profiler for JSC
https://bugs.webkit.org/show_bug.cgi?id=76855
Rubber stanmped by Geoff Garen.
Mechanical change - pass CodeBlock through to the executable allocator,
such that we will be able to map ranges of JIT code back to their owner.
- assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
- assembler/ARMAssembler.h:
- assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::executableCopy):
- assembler/AssemblerBufferWithConstantPool.h:
(JSC::AssemblerBufferWithConstantPool::executableCopy):
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::linkCode):
- assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::executableCopy):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::executableCopy):
- assembler/X86Assembler.h:
(JSC::X86Assembler::executableCopy):
(JSC::X86Assembler::X86InstructionFormatter::executableCopy):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryCachePutByID):
- dfg/DFGThunks.cpp:
(JSC::DFG::osrExitGenerationThunkGenerator):
- jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::allocate):
- jit/ExecutableAllocator.h:
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::ExecutableAllocator::allocate):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubs.cpp:
- jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::compile):
- 12:42 PM Changeset in webkit [105635] by
-
- 16 edits in trunk
Basic enhancements to StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=67081
Source/JavaScriptCore:
This change contains the following enhancements to StringBuilder,
for convenience, performance, testability, etc.:
- Change toStringPreserveCapacity() to const
- new public methods: capacity(), swap(), toAtomicString(), canShrink() and append(const StringBuilder&)
- == and != opearators to compare StringBuilders and a StringBuilder/String
Unit tests: Tools/TestWebKitAPI/Tests/WTF/StringBuilder.cpp
Reviewed by Darin Adler.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- wtf/text/AtomicString.cpp:
(WTF::SubstringTranslator::hash):
(WTF::SubstringTranslator::equal):
(WTF::SubstringTranslator::translate):
(WTF::AtomicString::add):
(WTF::AtomicString::addSlowCase):
- wtf/text/AtomicString.h:
(WTF::AtomicString::AtomicString):
(WTF::AtomicString::add):
- wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::reifyString):
(WTF::StringBuilder::resize):
(WTF::StringBuilder::canShrink):
(WTF::StringBuilder::shrinkToFit):
- wtf/text/StringBuilder.h:
(WTF::StringBuilder::append):
(WTF::StringBuilder::toString):
(WTF::StringBuilder::toStringPreserveCapacity):
(WTF::StringBuilder::toAtomicString):
(WTF::StringBuilder::isEmpty):
(WTF::StringBuilder::capacity):
(WTF::StringBuilder::is8Bit):
(WTF::StringBuilder::swap):
(WTF::equal):
(WTF::operator==):
(WTF::operator!=):
- wtf/text/StringImpl.h:
Source/WebCore:
These changes are because we explicitly disallowed StringBuilder's
copy constructor and assignment operator, and the change of return
type of StringBuilder::toString().
Reviewed by Darin Adler.
No new tests. All layout tests and unit tests should run as before.
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpCookiesForQuickTime):
- svg/SVGPathStringBuilder.h:
(WebCore::SVGPathStringBuilder::cleanup):
Source/WebKit/chromium:
This change is because we explicitly disallowed StringBuilder's
copy constructor and assignment operator.
Reviewed by Darin Adler.
No new tests. All layout tests and unit tests should run as before.
- src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::encodeAndFlushBuffer):
Tools:
Reviewed by Darin Adler.
- TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
(TestWebKitAPI::TEST):
- 12:00 PM Changeset in webkit [105634] by
-
- 6 edits11 adds in trunk/Source
[chromium] Add WebSolidColorLayer interface to draw non-textured color layers from Aura.
https://bugs.webkit.org/show_bug.cgi?id=75732
Reviewed by James Robinson.
Source/WebCore:
Add WebSolidColorLayer to paint solid-color layers without a backing texture.
Test: unit test for CCSolidColorLayerImpl.
- WebCore.gypi:
- platform/graphics/chromium/SolidColorLayerChromium.cpp: Added.
(WebCore::SolidColorLayerChromium::createCCLayerImpl):
(WebCore::SolidColorLayerChromium::create):
(WebCore::SolidColorLayerChromium::SolidColorLayerChromium):
(WebCore::SolidColorLayerChromium::~SolidColorLayerChromium):
- platform/graphics/chromium/SolidColorLayerChromium.h: Added.
- platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp: Added.
(WebCore::CCSolidColorLayerImpl::CCSolidColorLayerImpl):
(WebCore::CCSolidColorLayerImpl::~CCSolidColorLayerImpl):
(WebCore::CCSolidColorLayerImpl::quadTransform):
(WebCore::CCSolidColorLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCSolidColorLayerImpl.h: Added.
(WebCore::CCSolidColorLayerImpl::create):
(WebCore::CCSolidColorLayerImpl::layerTypeAsString):
Source/WebKit/chromium:
- WebKit.gyp:
- WebKit.gypi:
- public/platform/WebSolidColorLayer.h: Added.
- src/WebSolidColorLayer.cpp: Added.
(WebKit::WebSolidColorLayer::create):
(WebKit::WebSolidColorLayer::WebSolidColorLayer):
(WebKit::WebSolidColorLayer::setBackgroundColor):
- src/WebSolidColorLayerImpl.cpp: Added.
(WebKit::WebSolidColorLayerImpl::create):
(WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
(WebKit::WebSolidColorLayerImpl::~WebSolidColorLayerImpl):
- src/WebSolidColorLayerImpl.h: Added.
- tests/CCLayerTestCommon.cpp: Added.
(CCLayerTestCommon::completelyContains):
(CCLayerTestCommon::verifyQuadsExactlyCoverRect):
- tests/CCLayerTestCommon.h: Added.
- tests/CCSolidColorLayerImplTest.cpp: Added.
(CCLayerTestCommon::TEST):
- tests/CCTiledLayerImplTest.cpp:
- 11:39 AM Changeset in webkit [105633] by
-
- 32 edits15 adds24 deletes in trunk/LayoutTests
Update the baselines for a number of tests that use gradients. The new
results are just slightly different than the old results.
- fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
- fast/gradients/border-image-gradient-expected.txt: Added.
- fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Added.
- platform/chromium-linux-x86/fast/gradients: Removed.
- platform/chromium-linux/fast/canvas/fillrect_gradient-expected.png:
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.png:
- platform/chromium-linux/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Removed.
- platform/chromium-linux/fast/gradients/css3-color-stops-expected.png: Removed.
- platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.png:
- platform/chromium-linux/fast/gradients/generated-gradients-expected.png:
- platform/chromium-linux/fast/gradients/simple-gradients-expected.png:
- platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png: Removed.
- platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png:
- platform/chromium-mac-leopard/fast/canvas/fillrect_gradient-expected.png:
- platform/chromium-mac-leopard/fast/gradients/generated-gradients-expected.png:
- platform/chromium-mac-leopard/fast/reflections/reflection-masks-expected.png:
- platform/chromium-mac-snowleopard/fast/canvas/fillrect_gradient-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement: Added.
- platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/gradients/border-image-gradient-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/gradients/css3-color-stops-expected.png:
- platform/chromium-mac-snowleopard/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/gradients/generated-gradients-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/gradients/simple-gradients-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/reflections/reflection-masks-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-2-expected.png:
- platform/chromium-mac-snowleopard/svg/filters/big-sized-filter-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png:
- platform/chromium-mac/fast/canvas/fillrect_gradient-expected.png: Removed.
- platform/chromium-mac/fast/canvas/gradient-add-second-start-end-stop-expected.png: Removed.
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Removed.
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
- platform/chromium-mac/fast/gradients/border-image-gradient-expected.png: Removed.
- platform/chromium-mac/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Removed.
- platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients-expected.png: Removed.
- platform/chromium-mac/fast/gradients/generated-gradients-expected.png: Removed.
- platform/chromium-mac/fast/gradients/simple-gradients-expected.png: Removed.
- platform/chromium-mac/fast/reflections/reflection-masks-expected.png: Removed.
- platform/chromium-mac/svg/filters/big-sized-filter-expected.png: Removed.
- platform/chromium-win-vista/fast/gradients: Removed.
- platform/chromium-win-xp/svg/as-background-image: Removed.
- platform/chromium-win/fast/canvas/fillrect_gradient-expected.png:
- platform/chromium-win/fast/canvas/gradient-add-second-start-end-stop-expected.png:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.png:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.png:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png:
- platform/chromium-win/fast/gradients/border-image-gradient-expected.png:
- platform/chromium-win/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
- platform/chromium-win/fast/gradients/css3-color-stops-expected.png:
- platform/chromium-win/fast/gradients/css3-repeating-linear-gradients-expected.png:
- platform/chromium-win/fast/gradients/generated-gradients-expected.png:
- platform/chromium-win/fast/gradients/simple-gradients-expected.png:
- platform/chromium-win/fast/reflections/reflection-masks-expected.png:
- platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
- platform/chromium-win/svg/filters/big-sized-filter-expected.png:
- platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
- platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed.
- platform/gtk/fast/gradients/border-image-gradient-expected.txt: Removed.
- platform/gtk/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
- platform/mac/fast/gradients/border-image-gradient-expected.txt: Removed.
- platform/mac/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
- platform/qt/fast/gradients/border-image-gradient-expected.txt: Removed.
- platform/qt/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
- 9:20 AM Changeset in webkit [105632] by
-
- 3 edits in trunk/Source/WebCore
Attempt to fix Qt build.
Not reviewed.
- css/CSSElementStyleDeclaration.cpp:
- css/CSSElementStyleDeclaration.h:
(WebCore::CSSElementStyleDeclaration::createForSVGFontFaceElement):
- 9:00 AM Changeset in webkit [105631] by
-
- 3 edits in trunk/Source/WebCore
Move m_rootEditableElementForSelectionOnMouseDown off of HTMLAnchorElement.
<http://webkit.org/b/76833>
Reviewed by Antti Koivisto.
Move HTMLAnchorElement::m_rootEditableElementForSelectionOnMouseDown to a rare
data-style hashmap, effectively shrinking HTMLAnchorElement by one CPU word.
The pointer is only used during interactive event handling, so it shouldn't have
any noticeable effects on web performance.
This reduces memory consumption by 256 kB (on 64-bit) when viewing the full
HTML5 spec at <http://whatwg.org/c>.
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::HTMLAnchorElement):
(WebCore::HTMLAnchorElement::~HTMLAnchorElement):
(WebCore::HTMLAnchorElement::defaultEventHandler):
(WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType):
(WebCore::rootEditableElementMap):
(WebCore::HTMLAnchorElement::rootEditableElementForSelectionOnMouseDown):
(WebCore::HTMLAnchorElement::setRootEditableElementForSelectionOnMouseDown):
- html/HTMLAnchorElement.h:
- 8:49 AM Changeset in webkit [105630] by
-
- 17 edits1 delete in trunk/Source/WebCore
Eliminate CSSElementStyleDeclaration subclasses
https://bugs.webkit.org/show_bug.cgi?id=76827
Reviewed by Andreas Kling.
CSSInlineStyleDeclaration and FontFaceStyleDeclaration serve no real purpose.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSElementStyleDeclaration.cpp:
(WebCore::CSSElementStyleDeclaration::createForSVGFontFaceElement):
(WebCore::CSSElementStyleDeclaration::styleSheet):
- css/CSSElementStyleDeclaration.h:
(WebCore::CSSElementStyleDeclaration::createInline):
(WebCore::toCSSElementStyleDeclaration):
- css/CSSInlineStyleDeclaration.h: Removed.
- css/CSSMutableStyleDeclaration.cpp:
- dom/StyledElement.cpp:
(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::copyNonAttributeProperties):
- dom/StyledElement.h:
(WebCore::StyledElement::inlineStyleDecl):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
- editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
- html/ValidationMessage.cpp:
(WebCore::adjustBubblePosition):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):
- html/shadow/SliderThumbElement.cpp:
(WebCore::TrackLimiterElement::create):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):
- 8:45 AM Changeset in webkit [105629] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, unskip now passing tests on GTK. Spotted by Zan Dobersek.
- platform/gtk/Skipped: Unskip tests 5 tests using ArrayBuffer
which is no longer tied to 3D_CANVAS.
- 8:37 AM Changeset in webkit [105628] by
-
- 3 edits in trunk/Source/WebCore
Not reviewed: annotate inspector's js so that it compiled.
- inspector/front-end/ElementsTreeOutline.js:
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.SuggestBox.prototype.upKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.downKeyPressed):
- 8:32 AM Changeset in webkit [105627] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, mark another test as flaky crash.
- platform/gtk/test_expectations.txt:
editing/execCommand/19455.html is flaky, sometimes hitting an ASSERT.
- 8:24 AM Changeset in webkit [105626] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] fix WebAudio build after r105431
https://bugs.webkit.org/show_bug.cgi?id=76819
Reviewed by Martin Robinson.
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::copyGstreamerBuffersToAudioChannel): Use mutableData()
when copying.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcLoop): Drop constness when setting the buffer
data pointer.
- 8:20 AM Changeset in webkit [105625] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: add touch events to the event listeners list.
https://bugs.webkit.org/show_bug.cgi?id=76830
Reviewed by Yury Semikhatsky.
- English.lproj/localizedStrings.js:
- inspector/InjectedScriptSource.js:
(.):
- inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.EventListenerBreakpointsSidebarPane):
- 7:52 AM Changeset in webkit [105624] by
-
- 3 edits16 adds in trunk/LayoutTests
Unreviewed, GTK gardening. Rebaseline after r105613, marked 3 svg
flaky tests and added baselines for 15 tests.
- platform/gtk/css3/images/cross-fade-background-size-expected.txt: Added.
- platform/gtk/fast/backgrounds/mask-box-image-expected.txt: Added.
- platform/gtk/fast/borders/scaled-border-image-expected.txt: Added.
- platform/gtk/fast/css/text-overflow-input-expected.txt: Added.
- platform/gtk/fast/line-grid/line-grid-floating-expected.txt: Added.
- platform/gtk/fast/line-grid/line-grid-inside-columns-expected.txt: Added.
- platform/gtk/fast/line-grid/line-grid-into-floats-expected.txt: Added.
- platform/gtk/fast/line-grid/line-grid-positioned-expected.txt: Added.
- platform/gtk/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
- platform/gtk/svg/custom/relative-sized-image-expected.txt: Added.
- platform/gtk/svg/custom/transform-with-shadow-and-gradient-expected.txt: Added.
- platform/gtk/svg/filters/feImage-preserveAspectratio-expected.txt: Added.
- platform/gtk/svg/text/append-text-node-to-tspan-expected.txt: Added.
- platform/gtk/svg/text/modify-text-node-in-tspan-expected.txt: Added.
- platform/gtk/svg/text/remove-text-node-from-tspan-expected.txt: Added.
- platform/gtk/svg/text/remove-tspan-from-text-expected.txt: Added.
- platform/gtk/test_expectations.txt:
- 7:47 AM Changeset in webkit [105623] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: inspector close button is missing in the dock-to-right mode.
https://bugs.webkit.org/show_bug.cgi?id=76829
Reviewed by Timothy Hatcher.
- inspector/front-end/inspector.js:
(WebInspector.set attached):
(WebInspector.get _setCompactMode):
- 7:25 AM BuildingGtk edited by
- added gst modules in example moduleset (diff)
- 7:24 AM Changeset in webkit [105622] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r105613.
- platform/qt/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Updated.
- platform/qt/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Updated.
- 7:17 AM Changeset in webkit [105621] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: IndexedDBModel should keep track of requests sent to the backend.
https://bugs.webkit.org/show_bug.cgi?id=76705
Reviewed by Pavel Feldman.
- inspector/Inspector.json:
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
- inspector/InspectorIndexedDBAgent.h:
- inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel):
(WebInspector.IndexedDBModel.prototype._frameDetached):
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNamesForFrame):
(WebInspector.IndexedDBRequestManager):
(WebInspector.IndexedDBRequestManager.prototype.requestDatabaseNamesForFrame.innerCallback):
(WebInspector.IndexedDBRequestManager.prototype.requestDatabaseNamesForFrame):
(WebInspector.IndexedDBRequestManager.prototype._databaseNamesLoaded):
(WebInspector.IndexedDBRequestManager.prototype._requestId):
(WebInspector.IndexedDBRequestManager.prototype._frameDetached):
(WebInspector.IndexedDBRequestManager.prototype._reset):
(WebInspector.IndexedDBRequestManager.DatabasesForFrameRequest):
(WebInspector.IndexedDBDispatcher):
(WebInspector.IndexedDBDispatcher.prototype.databaseNamesLoaded):
- 7:10 AM Changeset in webkit [105620] by
-
- 5 edits3 adds in trunk
Web Inspector: Inspecting an element inside an iframe no longer works
https://bugs.webkit.org/show_bug.cgi?id=76808
Reviewed by Timothy Hatcher.
Source/WebCore:
Test: http/tests/inspector/inspect-element.html
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::innerParentNode):
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.getChildNodes.mycallback):
(WebInspector.DOMNode.prototype.getChildNodes):
(WebInspector.DOMNode.prototype._setChildrenPayload):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._selectedNodeChanged):
LayoutTests:
- http/tests/inspector/inspect-element-expected.txt: Added.
- http/tests/inspector/inspect-element.html: Added.
- http/tests/inspector/resources/inspect-element-iframe.html: Added.
- 6:52 AM Changeset in webkit [105619] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: response.bodySize in HAR is invalid (negative) for cached resources
https://bugs.webkit.org/show_bug.cgi?id=76823
Reviewed by Yury Semikhatsky.
- fix response.bodySize for cached resources;
Also some drive-by fixes:
- pretty-print HAR when exported
- proper annotation for JSON.stringify()
- de-obfuscate a piece of code in TimelinePanel
- inspector/front-end/HAREntry.js:
(WebInspector.HAREntry.prototype.get responseBodySize):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._exportAll):
(WebInspector.NetworkLogView.prototype._exportResource):
- 6:45 AM Changeset in webkit [105618] by
-
- 4 edits2 adds in trunk/Source/WebCore
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
New files for the implementation of the AtkAction interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.
- accessibility/gtk/WebKitAccessibleInterfaceAction.cpp: Added.
(core):
(webkitAccessibleActionInterfaceInit):
(webkitAccessibleActionDoAction):
(webkitAccessibleActionGetNActions):
(webkitAccessibleActionGetDescription):
(webkitAccessibleActionGetKeybinding):
(webkitAccessibleActionGetName):
- accessibility/gtk/WebKitAccessibleInterfaceAction.h: Added.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
related to the implementation of the AtkAction interface.
Add new files to build files.
- GNUmakefile.list.am: Add WebKitAccessibleInterfaceAction.[h|cpp].
- WebCore.gypi: Ditto.
- 6:36 AM Changeset in webkit [105617] by
-
- 2 edits in trunk/Tools
[GTK] run-gtk-tests randomly fails while running the xprop comand
https://bugs.webkit.org/show_bug.cgi?id=76817
Reviewed by Gustavo Noronha Silva.
No need to use xprop to remove the AT_SPI_BUS property since
run-gtk-tests will always run new instances of Xvfb.
- Scripts/run-gtk-tests:
(TestRunner): Unskip TestWebKitAccessibility.
(TestRunner.run): Uncomment lines for launching the accessibility
bus and registry daemon, and remove lines for running xprop.
- 6:32 AM Changeset in webkit [105616] by
-
- 2 edits in trunk/Tools
[Qt] Don't warn about override and final being C++11 extensions
Clang will emit a warning when these extensions are used without passing
--std=c++11, but we use feature checking to decide if we have the right
extensions, so we can safely ignore these warnings. The XCode and Windows
project files have the same workaround.
The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
we only have one extra compiler for Objective-C, which is also used for
Objective-C++ sources, so we have to pass the flag, even if it doesn't
make sense for Objective-C.
Reviewed by Simon Hausmann.
- 6:12 AM Changeset in webkit [105615] by
-
- 2 edits in trunk/LayoutTests
Unreviewed tweaking of test expectations: it should be IMAGE instead of IMAGE+TEXT.
- platform/chromium/test_expectations.txt:
- 6:03 AM Changeset in webkit [105614] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed rebaseline after r105613 (SVG animation repaint issue...).
- platform/chromium-mac-leopard/svg/custom/relative-sized-image-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/relative-sized-image-expected.png: Added.
- 5:05 AM BuildingGtk edited by
- (diff)
- 5:01 AM BuildingGtk edited by
- (diff)
- 5:00 AM BuildingGtk edited by
- (diff)
- 4:59 AM BuildingGtk edited by
- Add info on WEBKIT_EXTRA_MODULE{S,SETS} (diff)
- 4:48 AM Changeset in webkit [105613] by
-
- 9 edits6 adds in trunk
SVG animation repaint issue with image and dynamic clipPath
https://bugs.webkit.org/show_bug.cgi?id=76559
Reviewed by Zoltan Herczeg.
Source/WebCore:
Based on patch by Kelly Norton <knorton@google.com>. I extended the patch
to correctly handle relative length resolution as well.
RenderSVGImage doesn't react on setNeedsBoundariesUpdate() calls
and thus fails to update its boundaries in some cases.
The logic is also inconsistent, compared to the other renderers.
Fix that properly, by reusing the method used in RenderSVGViewportContainer.
Call calculateImageViewport() immediately, after initializing the LayoutRepainter.
Previously we resolved the image viewport in RenderSVGImage::updateFromElement. This is
wrong, as it queries the frameRect() of the RenderSVGRoot in a state, where the renderer
still needs layout, leading to wrong results.
I turned Kellys manual testcase into a predictable test, see svg/repaint/image-with-clip-path.svg
Relative sized image handling is tested in svg/custom/relative-sized-image.xhtml now.
Tests: svg/custom/relative-sized-image.xhtml
svg/repaint/image-with-clip-path.svg
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::RenderSVGImage):
(WebCore::RenderSVGImage::updateImageViewport):
(WebCore::RenderSVGImage::layout):
- rendering/svg/RenderSVGImage.h:
(WebCore::RenderSVGImage::setNeedsBoundariesUpdate):
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::svgAttributeChanged):
LayoutTests:
Update results after fixing RenderSVGImage repainting.
- platform/chromium-win/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
- platform/mac/svg/custom/relative-sized-image-expected.png: Added.
- platform/mac/svg/custom/relative-sized-image-expected.txt: Added.
- platform/mac/svg/repaint/image-with-clip-path-expected.png: Added.
- svg/custom/relative-sized-image.xhtml: Added.
- svg/repaint/image-with-clip-path-expected.txt: Added.
- svg/repaint/image-with-clip-path.svg: Added.
- 4:42 AM Changeset in webkit [105612] by
-
- 11 edits in trunk
<feImage> has problems referencing local elements
https://bugs.webkit.org/show_bug.cgi?id=76800
Reviewed by Zoltan Herczeg.
Source/WebCore:
<feImage> referencing local elements are currently rendered into an ImageBuffer
by SVGFEImageElement, using the local coordinates of the referenced renderer.
This approach is buggy and should be avoided, by moving the rendering fully
into SVGFEImage, which takes care of respecting the correct transformations.
This fixes <feImage> + local references, which currently breaks two tests in trunk.
Covered by existing tests.
- rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::build):
- svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::FEImage):
(WebCore::FEImage::createWithImage):
(WebCore::FEImage::createWithIRIReference):
(WebCore::FEImage::determineAbsolutePaintRect):
(WebCore::FEImage::referencedRenderer):
(WebCore::FEImage::platformApplySoftware):
(WebCore::FEImage::externalRepresentation):
- svg/graphics/filters/SVGFEImage.h:
(WebCore::FEImage::~FEImage):
- svg/graphics/filters/SVGFilter.h:
(WebCore::SVGFilter::absoluteTransform):
LayoutTests:
Update svg/filters/feImage-reference-* results, which are fixed now.
- platform/chromium/test_expectations.txt : Updated.
- platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Update for marginal change.
- svg/filters/feImage-reference-invalidation-expected.png:
- svg/filters/feImage-reference-svg-primitive-expected.png:
- 4:39 AM Changeset in webkit [105611] by
-
- 2 edits in trunk/Source/WebCore
2012-01-23 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix Mac build, by exporting a new symbol.
- WebCore.exp.in:
- 3:55 AM Changeset in webkit [105610] by
-
- 5 edits2 adds in trunk/Source/WebCore
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
Move common function returnString() from the wrapper and
hyperlink implementations to a new utility file.
- accessibility/gtk/WebKitAccessibleUtil.cpp: Added.
(returnString): Taken from WebKitAccessibleWrapperAtk.cpp and
WebKitAccessibleHyperlink.cpp
- accessibility/gtk/WebKitAccessibleUtil.h: Added.
- accessibility/gtk/WebKitAccessibleHyperlink.cpp: Remove local
implementation of returnString.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Ditto.
Add new files to build files.
- GNUmakefile.list.am: Add WebKitAccessibleUtil.[h|cpp].
- WebCore.gypi: Ditto.
- 3:51 AM Changeset in webkit [105609] by
-
- 2 edits in trunk/LayoutTests
WebKit fails IETC composition event types
https://bugs.webkit.org/show_bug.cgi?id=76690
Unreviewed gardening after r105605.
- fast/events/ime-composition-events-001-expected.txt: Updated.
- 3:46 AM Changeset in webkit [105608] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
Fix typo in class struct (parent class field had the wrong type),
fix coding style issues and update date in headers.
- accessibility/gtk/WebKitAccessibleHyperlink.cpp:
- accessibility/gtk/WebKitAccessibleHyperlink.h:
- 3:43 AM Changeset in webkit [105607] by
-
- 7 edits in trunk/Source
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
Source/WebCore:
Rename WebKitAccessible's public functions to follow WebKit's
coding style and update callers.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleNew): Renamed from webkit_accessible_new.
(webkitAccessibleGetAccessibilityObject): Likewise.
(webkitAccessibleDetach):Likewise.
(webkitAccessibleGetFocusedElement): Likewise.
- accessibility/gtk/WebKitAccessibleWrapperAtk.h:
Update calls to WebKitAccessible's public functions.
- accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::detachWrapper): Update call.
(WebCore::AXObjectCache::attachWrapper): Ditto.
- accessibility/gtk/WebKitAccessibleHyperlink.cpp:
(core): Update call.
Source/WebKit/gtk:
Update callers to WebKitAccessible's public functions.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
(modifyAccessibilityValue):
(DumpRenderTreeSupportGtk::accessibilityHelpText):
- 3:17 AM Changeset in webkit [105606] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Fix make distcheck.
- GNUmakefile.list.am: Add missing files, remove deleted files and
fix indentation.
- 2:41 AM Changeset in webkit [105605] by
-
- 4 edits in trunk
WebKit fails IETC composition event types
https://bugs.webkit.org/show_bug.cgi?id=76690
- 2:21 AM Changeset in webkit [105604] by
-
- 10 edits2 moves in trunk/Source
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
Source/WebCore:
Rename the file for the ATK AccessibilityObject wrapper to be more
coherent with the rest of the files in the same directory.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Renamed from
Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp.
(fallbackObject):
(returnString):
(core):
(webkit_accessible_get_name):
(webkit_accessible_get_description):
(setAtkRelationSetFromCoreObject):
(isRootObject):
(atkParentOfRootObject):
(webkit_accessible_get_parent):
(getNChildrenForTable):
(webkit_accessible_get_n_children):
(getChildForTable):
(webkit_accessible_ref_child):
(getIndexInParentForCellInRow):
(webkit_accessible_get_index_in_parent):
(addAttributeToSet):
(webkit_accessible_get_attributes):
(atkRole):
(webkit_accessible_get_role):
(selectionBelongsToObject):
(isTextWithCaret):
(setAtkStateSetFromCoreObject):
(webkit_accessible_ref_state_set):
(webkit_accessible_ref_relation_set):
(webkit_accessible_init):
(webkit_accessible_finalize):
(webkit_accessible_class_init):
(webkit_accessible_get_type):
(webkit_accessible_action_do_action):
(webkit_accessible_action_get_n_actions):
(webkit_accessible_action_get_description):
(webkit_accessible_action_get_keybinding):
(webkit_accessible_action_get_name):
(atk_action_interface_init):
(listObjectForSelection):
(optionFromList):
(optionFromSelection):
(webkit_accessible_selection_add_selection):
(webkit_accessible_selection_clear_selection):
(webkit_accessible_selection_ref_selection):
(webkit_accessible_selection_get_selection_count):
(webkit_accessible_selection_is_child_selected):
(webkit_accessible_selection_remove_selection):
(webkit_accessible_selection_select_all_selection):
(atk_selection_interface_init):
(utf8Substr):
(convertUniCharToUTF8):
(textForRenderer):
(textForObject):
(webkit_accessible_text_get_text):
(getGailTextUtilForAtk):
(getPangoLayoutForAtk):
(webkit_accessible_text_get_text_after_offset):
(webkit_accessible_text_get_text_at_offset):
(webkit_accessible_text_get_text_before_offset):
(webkit_accessible_text_get_character_at_offset):
(webkit_accessible_text_get_caret_offset):
(baselinePositionForRenderObject):
(getAttributeSetForAccessibilityObject):
(compareAttribute):
(attributeSetDifference):
(accessibilityObjectLength):
(getAccessibilityObjectForOffset):
(getRunAttributesFromAccesibilityObject):
(webkit_accessible_text_get_run_attributes):
(webkit_accessible_text_get_default_attributes):
(textExtents):
(webkit_accessible_text_get_character_extents):
(webkit_accessible_text_get_range_extents):
(webkit_accessible_text_get_character_count):
(webkit_accessible_text_get_offset_at_point):
(getSelectionOffsetsForObject):
(webkit_accessible_text_get_n_selections):
(webkit_accessible_text_get_selection):
(webkit_accessible_text_add_selection):
(webkit_accessible_text_set_selection):
(webkit_accessible_text_remove_selection):
(webkit_accessible_text_set_caret_offset):
(atk_text_interface_init):
(webkit_accessible_editable_text_set_run_attributes):
(webkit_accessible_editable_text_set_text_contents):
(webkit_accessible_editable_text_insert_text):
(webkit_accessible_editable_text_copy_text):
(webkit_accessible_editable_text_cut_text):
(webkit_accessible_editable_text_delete_text):
(webkit_accessible_editable_text_paste_text):
(atk_editable_text_interface_init):
(contentsToAtk):
(atkToContents):
(webkit_accessible_component_ref_accessible_at_point):
(webkit_accessible_component_get_extents):
(webkit_accessible_component_grab_focus):
(atk_component_interface_init):
(webkit_accessible_image_get_image_position):
(webkit_accessible_image_get_image_description):
(webkit_accessible_image_get_image_size):
(atk_image_interface_init):
(cell):
(cellIndex):
(cellAtIndex):
(webkit_accessible_table_ref_at):
(webkit_accessible_table_get_index_at):
(webkit_accessible_table_get_column_at_index):
(webkit_accessible_table_get_row_at_index):
(webkit_accessible_table_get_n_columns):
(webkit_accessible_table_get_n_rows):
(webkit_accessible_table_get_column_extent_at):
(webkit_accessible_table_get_row_extent_at):
(webkit_accessible_table_get_column_header):
(webkit_accessible_table_get_row_header):
(webkit_accessible_table_get_caption):
(webkit_accessible_table_get_column_description):
(webkit_accessible_table_get_row_description):
(atk_table_interface_init):
(webkitAccessibleHypertextGetLink):
(webkitAccessibleHypertextGetNLinks):
(webkitAccessibleHypertextGetLinkIndex):
(atkHypertextInterfaceInit):
(webkitAccessibleHyperlinkImplGetHyperlink):
(atkHyperlinkImplInterfaceInit):
(documentAttributeValue):
(webkit_accessible_document_get_attribute_value):
(webkit_accessible_document_get_attributes):
(webkit_accessible_document_get_locale):
(atk_document_interface_init):
(webkitAccessibleValueGetCurrentValue):
(webkitAccessibleValueGetMaximumValue):
(webkitAccessibleValueGetMinimumValue):
(webkitAccessibleValueSetCurrentValue):
(webkitAccessibleValueGetMinimumIncrement):
(atkValueInterfaceInit):
(GetAtkInterfaceTypeFromWAIType):
(getInterfaceMaskFromObject):
(getUniqueAccessibilityTypeName):
(getAccessibilityTypeFromObject):
(webkit_accessible_new):
(webkit_accessible_get_accessibility_object):
(webkit_accessible_detach):
(webkit_accessible_get_focused_element):
(objectFocusedAndCaretOffsetUnignored):
- accessibility/gtk/WebKitAccessibleWrapperAtk.h: Renamed from
Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.h.
Update the include for the AccessibilityObject wrapper header.
- accessibility/gtk/AXObjectCacheAtk.cpp: Update include.
- accessibility/gtk/WebKitAccessibleHyperlink.cpp: Ditto.
- accessibility/gtk/WebKitAccessibleHyperlink.h: Ditto.
- editing/gtk/FrameSelectionGtk.cpp:
Update filename for the ATK wrapper in build files.
- GNUmakefile.list.am: Updated.
- WebCore.gypi: Updated.
Source/WebKit/gtk:
Update the include for the AccessibilityObject wrapper header.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Update include.
- webkit/webkitwebframe.cpp: Ditto.
- 2:14 AM Changeset in webkit [105603] by
-
- 3 edits in trunk/Tools
[Qt] Change how build-webkit decides when to do full incremental builds
Instead of relying on update-webkit (which isn't run on the bots) to
decide when to do a full incremental build (make qmake), we let the
build-webkit script itself check the current SVN revision against the
previous build (by storing it in .webkit.config).
If the two differ we assume a full incremental build is needed, since
the new revisions might have introduced problematic things like new
Q_OBJECT macros. If not, we assume the developer is doing changes
locally, and revert to doing a plain 'make'.
In addition, when the build fails in the latter case, we inform the
developer of possible pitfalls and how to manually run 'make qmake'.
Reviewed by Ossy.
- 2:09 AM Changeset in webkit [105602] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed follow-up to r105596, added missing test resources.
- http/tests/inspector/resources/har-pages-iframe.html: Added.
- http/tests/inspector/resources/har-pages-navigation-target.html: Added.
- 2:05 AM Changeset in webkit [105601] by
-
- 2 edits in trunk/Tools
[GTK] run-gtk-tests randomly fails while running the xprop comand
https://bugs.webkit.org/show_bug.cgi?id=76817
Reviewed by Philippe Normand.
Temporarily comment the lines related to launching the ATSPI bus
and registry daemon, which are making the bots to fail randomly.
- Scripts/run-gtk-tests:
(TestRunner): Skip TestWebKitAccessibility, as it won't run
properly if the ATSPI infrastructure is not properly initialized.
(TestRunner.run): Comment lines related to initialization of ATSPI.
- 2:04 AM Changeset in webkit [105600] by
-
- 18 edits in trunk/Source
Web Inspector: PageAgent.open() dosen't belong to the protocol.
https://bugs.webkit.org/show_bug.cgi?id=74790
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/Inspector.json:
- inspector/InspectorFrontendClient.h:
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::openInNewTab):
- inspector/InspectorFrontendClientLocal.h:
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::openInNewTab):
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::navigate):
- inspector/InspectorPageAgent.h:
- inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype._openInNewTab):
- inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.openInNewTab):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._openInNewTab):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype.ondblclick):
- inspector/front-end/inspector.js:
(WebInspector.openResource):
Source/WebKit/chromium:
- public/WebDevToolsFrontendClient.h:
(WebKit::WebDevToolsFrontendClient::openInNewTab):
- src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::openInNewTab):
(WebKit::InspectorFrontendClientImpl::saveAs):
- src/InspectorFrontendClientImpl.h:
- 1:59 AM Changeset in webkit [105599] by
-
- 9 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r101742.
- platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/gtk/fast/forms/placeholder-position-expected.txt:
- platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/gtk/fast/forms/search-styled-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- 1:23 AM Changeset in webkit [105598] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: DetailedHeapSnapshot: Replace the list of retainers with the expandable tree (to get rid of cycles)
https://bugs.webkit.org/show_bug.cgi?id=76813
Reviewed by Pavel Feldman.
- English.lproj/localizedStrings.js:
- inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotObjectNode):
- inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotRetainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.reset):
(WebInspector.DetailedHeapshotView.prototype._startRetainersHeaderDragging):
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype.createRetainingEdgesProvider):
(WebInspector.HeapSnapshotEdgesProvider):
- inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider):
(WebInspector.HeapSnapshotProxy.prototype.createRetainingEdgesProvider):
- 1:13 AM Changeset in webkit [105597] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK gardening, marked 2 tests as flaky on Debug and
unskipped another needing new baselines.
- platform/gtk/test_expectations.txt:
- 1:02 AM Changeset in webkit [105596] by
-
- 9 edits2 adds in trunk
Web Inspector: HAR pageref attributes are wrong and inconsistent with pages array
https://bugs.webkit.org/show_bug.cgi?id=76398
Reviewed by Pavel Feldman.
Source/WebCore:
- introduce a notion of LoadPage;
- move page load times to LoadPage;
- associate network resources with LoadPage;
- export pages for all available resoruces to HAR, not just the last page;
- use page ids, not document URLs in HAR entries to refer to pages;
- use page URL as a title field of a HAR page;
- inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel):
- inspector/front-end/HAREntry.js:
(WebInspector.HAREntry.prototype.build):
(WebInspector.HAREntry.prototype.get responseCompression):
(WebInspector.HARLog.prototype._buildPages):
(WebInspector.HARLog.prototype._convertPage):
(WebInspector.HARLog.prototype._pageEventTime):
- inspector/front-end/NetworkLog.js:
(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype._mainFrameNavigated):
(WebInspector.NetworkLog.prototype._onResourceStarted):
(WebInspector.Page):
(WebInspector.Page.prototype.get id):
(WebInspector.Page.prototype.get url):
(WebInspector.Page.prototype.get contentLoadTime):
(WebInspector.Page.prototype.set contentLoadTime):
(WebInspector.Page.prototype.get loadTime):
(WebInspector.Page.prototype.set loadTime):
(WebInspector.Page.prototype.get startTime):
(WebInspector.Page.prototype._bindResource):
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):
- inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.get page):
(WebInspector.Resource.prototype.set page):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype.get page):
(WebInspector.PageDispatcher.prototype.domContentEventFired):
(WebInspector.PageDispatcher.prototype.loadEventFired):
LayoutTests:
- http/tests/inspector/resource-har-headers-expected.txt:
- http/tests/inspector/resource-parameters-expected.txt:
- platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt:
- 12:58 AM Changeset in webkit [105595] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK gardening, marked a test as flaky and unskipped
several needing new baselines.
- platform/gtk/test_expectations.txt:
Jan 22, 2012:
- 11:08 PM Changeset in webkit [105594] by
-
- 1 edit in branches/chromium/963/Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js
Merge 105261 - Web Inspector: Popover does not disappear, causes debugger failure.
https://bugs.webkit.org/show_bug.cgi?id=71363
Reviewed by Pavel Feldman.
This is a work-around simple enough for a merge. The real fix would
be to get TextViewer to manage the highlight on its own, so it's not
accidently removed while re-building DOM for the text chunk.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):
TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9279002
- 9:36 PM Changeset in webkit [105593] by
-
- 1 edit in branches/chromium/963/Source/WebCore/platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp
Merge 105393 - [Chromium] Random characters got rendered as empty boxes or with incorrect glyphs even when a font is present
https://bugs.webkit.org/show_bug.cgi?id=76508
Patch by Kazuhiro Inaba <kinaba@chromium.org> on 2012-01-19
Reviewed by Kent Tamura.
Wrapped GetGlyphIndices() API calls so that when they failed we trigger font
loading outside the sandbox and retry the call.
No new auto tests since the bug involves the system's occasional cache behavior
and thus there's no reliable way to reproduce and test the situation.
- platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::getGlyphIndices):
GDI call wrapper ensuring fonts to be loaded.
(WebCore::initSpaceGlyph):
Changed to use the wrapper function.
(WebCore::fillBMPGlyphs):
Changed to use the wrapper function.
Introduced scoped HDC management by HWndDC.
(WebCore::GlyphPage::fill):
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9280004
- 6:13 PM Changeset in webkit [105592] by
-
- 2 edits in trunk/Tools
Windows python test build fix.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.init):
- 11:51 AM Changeset in webkit [105591] by
-
- 2 edits in trunk/LayoutTests
2012-01-22 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix typo, which makes the style bot warn on every patch.
- platform/chromium/test_expectations.txt:
- 11:29 AM Changeset in webkit [105590] by
-
- 7 edits in trunk/Source
[GTK] ATK text-caret-moved and text-selection-changed events not being emitted
https://bugs.webkit.org/show_bug.cgi?id=76069
Reviewed by Martin Robinson.
Source/WebCore:
Fix bug introduced with patch for Bug 72830.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isDescendantOfObject): New function,
to check if an accessibility object is a descendant of other object.
(WebCore::AccessibilityObject::isAncestorOfObject): New function,
to check if an accessibility object is an ancestor of other object.
- accessibility/AccessibilityObject.h:
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_text_get_caret_offset): Make sure to pass the
right reference object to objectFocusedAndCaretOffsetUnignored.
(objectFocusedAndCaretOffsetUnignored): Use positionBeforeNode
instead of firstPositionInNode for calculating the begining of the
range used to calculate the offsets. Ensure that the reference
object is never a descendant of the actual object being returned.
- editing/gtk/FrameSelectionGtk.cpp:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
Pass the right accessibility object associated with the current
selection to objectFocusedAndCaretOffsetUnignored.
Source/WebKit/gtk:
Update caret browsing related unit tests to check emissions of
'text-caret-moved' and 'text-selection-changed' signals.
- tests/testatk.c:
(textCaretMovedCallback): New callback for 'text-caret-moved'.
(testWebkitAtkCaretOffsets): Check emissions of 'text-caret-moved'.
(textSelectionChangedCallback): New callback for 'text-selection-changed'.
(testWebkitAtkTextSelections): Check emissions of 'text-selection-changed'.
- 4:50 AM Changeset in webkit [105589] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed, unskipping passing test.
- platform/gtk/Skipped: unskipped
http/tests/security/mixedContent/empty-url-plugin-in-frame.html
- 3:52 AM Changeset in webkit [105588] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed, unskipping test passing after r79655.
- platform/gtk/Skipped: unskipped http/tests/incremental/slow-utf8-html.pl
- 2:12 AM Changeset in webkit [105587] by
-
- 4 edits in trunk
[GTK] DumpRenderTree converts "file:///" to a path differently
https://bugs.webkit.org/show_bug.cgi?id=76631
Reviewed by Martin Robinson.
Tools:
DumpRenderTree should print "/" as the last path component if the
path is a lone slash instead of empty output.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(webViewConsoleMessage):
LayoutTests:
Unskipped a couple of tests after fix.
- platform/gtk/Skipped:
- 1:11 AM Changeset in webkit [105586] by
-
- 5 edits in trunk/Source/JavaScriptCore
Build fix for non-DFG platforms that error out on warn-unused-parameter.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/MethodCallLinkStatus.cpp:
(JSC::MethodCallLinkStatus::computeFor):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- 12:47 AM Changeset in webkit [105585] by
-
- 5 edits in trunk/Source/JavaScriptCore
Build fix for non-DFG platforms.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/MethodCallLinkStatus.cpp:
(JSC::MethodCallLinkStatus::computeFor):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
