⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 26, 2012:

11:52 PM Changeset in webkit [106097] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

Remove FIXME: ColorProfile encapsulation as a Vector<char> works well
https://bugs.webkit.org/show_bug.cgi?id=77176

Reviewed by Adam Barth.

No new tests. No change in behavior.

  • platform/image-decoders/ImageDecoder.h:
11:33 PM Changeset in webkit [106096] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectation change.
fast/canvas/gradient-add-second-start-end-stop.html fails on MAC GPU.

  • platform/chromium/test_expectations.txt:
11:23 PM Changeset in webkit [106095] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebCore

ImageBuffer::draw should deep copy if drawing to an accelerated context
https://bugs.webkit.org/show_bug.cgi?id=77185

Reviewed by Simon Fraser.

No new tests since any test for this issue would be flaky at best.

  • platform/graphics/cg/ImageBufferCG.cpp: Deep copy when drawing ourself into

an accelerated context for both draw and drawPattern.

(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):

11:19 PM Changeset in webkit [106094] by kevino@webkit.org
  • 2 edits in trunk

[wx] Unreviewed. Build fix, don't build some sources
which appear to no longer be needed.

11:13 PM Changeset in webkit [106093] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed. Build fix, add WebCore/testing/js
to the list of source directories we build.

11:10 PM Changeset in webkit [106092] by kevino@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[wx] Unreviewed. Build fix, wx uses the Mac ICU headers so we must match Mac behavior.

11:05 PM Changeset in webkit [106091] by kevino@webkit.org
  • 7 edits
    2 adds in trunk/Source/WebCore

[wx] Unreviewed. Build fixes.

  • Remove some constructors not generated by CPP bindings from being added to CPP binding headers
  • Keyboard event fixes after modifier changes
  • Add stubs for Language and RunLoop platform methods
11:02 PM Changeset in webkit [106090] by kevino@webkit.org
  • 7 edits in trunk/Source/WebKit/wx

[wx] Unreviewed. Build fixes after UndoStep and ChromeClient changes.

10:28 PM Changeset in webkit [106089] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectation change.
fast/canvas/quadraticCurveTo.xml fails for WIN GPU

  • platform/chromium/test_expectations.txt:
9:17 PM Changeset in webkit [106088] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectation change.
fast/js/dfg-double-vote-fuzz.html is slow on Mac 10.6 (dbg).

  • platform/chromium/test_expectations.txt:
9:07 PM Changeset in webkit [106087] by commit-queue@webkit.org
  • 11 edits
    2 deletes in trunk

Unreviewed, rolling out r105486.
http://trac.webkit.org/changeset/105486
https://bugs.webkit.org/show_bug.cgi?id=77182

This patch doesn't take web workers into account. (Requested
by dave_levin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-26

Source/WebCore:

  • html/DOMURL.cpp:

(WebCore::DOMURL::DOMURL):
(WebCore::DOMURL::~DOMURL):
(WebCore::DOMURL::contextDestroyed):
(WebCore):
(WebCore::DOMURL::createObjectURL):
(WebCore::DOMURL::revokeObjectURL):

  • html/DOMURL.h:

(WebCore::DOMURL::create):
(DOMURL):

  • html/DOMURL.idl:
  • page/DOMWindow.cpp:

(WebCore):
(WebCore::DOMWindow::webkitURL):

  • page/DOMWindow.h:

(DOMWindow):
():

  • page/DOMWindow.idl:
  • workers/WorkerContext.cpp:

(WebCore):
(WebCore::WorkerContext::webkitURL):
(WebCore::WorkerContext::webkitRequestFileSystem):

  • workers/WorkerContext.h:

(WorkerContext):
():

  • workers/WorkerContext.idl:

LayoutTests:

  • fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Removed.
  • fast/dom/DOMURL/check-instanceof-domurl-functions.html: Removed.
9:03 PM Changeset in webkit [106086] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

Cleanup JPEGImageDecoder includes
https://bugs.webkit.org/show_bug.cgi?id=77171

Reviewed by Adam Barth.

No new tests. Refactoring cleanup only.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
9:02 PM Changeset in webkit [106085] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed test expectation change.
svg/as-object/nested-embedded-svg-size-changes.html times out or passes.

  • platform/chromium/test_expectations.txt:
8:48 PM Changeset in webkit [106084] by tkent@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Cleanup of WebPopupMenuImpl
https://bugs.webkit.org/show_bug.cgi?id=76441

Reviewed by Kentaro Hara.

Removed WebPopupMenuImpl::invalidateContents() and scrollRectIntoView()
because they were removed from HostWindow in r58445 and r55864. They
were found by OVERRIDE.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::popupOpened): Rename WebPopupMenuImpl::Init().

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::WebPopupMenuImpl): Update a comment.
(WebKit::WebPopupMenuImpl::init): Renamed from Init(). Update a comment.
(WebKit::WebPopupMenuImpl::handleMouseMove): Prepend "handle" to the name.
(WebKit::WebPopupMenuImpl::handleMouseLeave): ditto.
(WebKit::WebPopupMenuImpl::handleMouseDown): ditto.
(WebKit::WebPopupMenuImpl::handleMouseUp): ditto.
(WebKit::WebPopupMenuImpl::handleMouseWheel): ditto.
(WebKit::WebPopupMenuImpl::handleGestureEvent): ditto.
(WebKit::WebPopupMenuImpl::handleTouchEvent): ditto.
(WebKit::WebPopupMenuImpl::handleKeyEvent): ditto.
(WebKit::WebPopupMenuImpl::close): Update a comment.
(WebKit::WebPopupMenuImpl::composite): Remove a unused argument name.
(WebKit::WebPopupMenuImpl::handleInputEvent): Update a comment. Update callsites for handle*().
(WebKit::WebPopupMenuImpl::setFocus): Remove a unused argument name.
(WebKit::WebPopupMenuImpl::setComposition): ditto.
(WebKit::WebPopupMenuImpl::confirmComposition): ditto.
(WebKit::WebPopupMenuImpl::setTextDirection): ditto.
(WebKit::WebPopupMenuImpl::scroll): Unfold folded lines.

  • src/WebPopupMenuImpl.h:
    • Remove useless argument names.
    • Add OVERRIDE.
8:43 PM Changeset in webkit [106083] by timothy_horton@apple.com
  • 8 edits in trunk/Source

3D transformed elements hide when showing the print dialog
https://bugs.webkit.org/show_bug.cgi?id=45894
<rdar://problem/7441593>

Reviewed by Andy Estes.

Suspend updates of the compositing layer tree while printing is taking place,
preventing on-screen layers from moving to their print-mode positions.

No new tests, as WebKitTestRunner doesn't support putting the document
into printing mode.

  • page/FrameView.cpp:

(WebCore::FrameView::syncCompositingStateForThisFrame):
(WebCore::FrameView::paintContents):

  • platform/graphics/ca/LayerFlushScheduler.h:

(WebCore::LayerFlushScheduler::isSuspended): Added.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::beginPrinting):
(WebKit::WebPage::endPrinting):

  • WebProcess/WebPage/ca/LayerTreeHostCA.h:
  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:
  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::forceRepaint):
(WebKit::LayerTreeHostCAMac::flushPendingLayerChanges):

8:10 PM Changeset in webkit [106082] by fpizlo@apple.com
  • 2 edits in trunk/Tools

Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered
https://bugs.webkit.org/show_bug.cgi?id=77177

Reviewed by Jon Honeycutt.

  • Scripts/commit-log-editor:
7:45 PM Changeset in webkit [106081] by fpizlo@apple.com
  • 3 edits in trunk/LayoutTests

fast/js/dfg-byte-array-put.html should assert the array size
https://bugs.webkit.org/show_bug.cgi?id=77173

Reviewed by Andy Estes.

  • fast/js/dfg-byte-array-put-expected.txt:
  • fast/js/script-tests/dfg-byte-array-put.js:
7:34 PM Changeset in webkit [106080] by yuzo@google.com
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Unreviewed test expectation change.

  • platform/chromium/fast/js/dfg-inline-arguments-use-from-all-the-places-broken-expected.txt: Added.
6:48 PM Changeset in webkit [106079] by ojan@chromium.org
  • 2 edits in trunk/Tools

Decrease sleep time when killing server_process on Mac.
https://bugs.webkit.org/show_bug.cgi?id=77169

Reviewed by Eric Seidel.

This shaves another ~70ms off single test runtime.

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess.stop):

6:30 PM Changeset in webkit [106078] by mhahnenberg@apple.com
  • 14 edits
    2 deletes in trunk/Source/JavaScriptCore

Merge AllocationSpace into MarkedSpace
https://bugs.webkit.org/show_bug.cgi?id=77116

Reviewed by Geoffrey Garen.

Merging AllocationSpace and MarkedSpace in preparation for future refactoring/enhancement to
MarkedSpace allocation.

(BumpSpace):

  • heap/Heap.h:

(JSC::Heap::objectSpace):
(Heap):
():

  • heap/HeapBlock.h:

():

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::tryAllocateHelper):
(JSC):
(JSC::MarkedSpace::tryAllocate):
(JSC::MarkedSpace::allocateSlowCase):
(JSC::MarkedSpace::allocateBlock):
(JSC::MarkedSpace::freeBlocks):
(TakeIfUnmarked):
(JSC::TakeIfUnmarked::TakeIfUnmarked):
(JSC::TakeIfUnmarked::operator()):
(JSC::TakeIfUnmarked::returnValue):
(JSC::MarkedSpace::shrink):
(GatherDirtyCells):
(JSC::GatherDirtyCells::returnValue):
(JSC::GatherDirtyCells::GatherDirtyCells):
(JSC::GatherDirtyCells::operator()):
(JSC::MarkedSpace::gatherDirtyCells):

  • heap/MarkedSpace.h:

(MarkedSpace):
(JSC::MarkedSpace::blocks):
(JSC::MarkedSpace::forEachCell):
(JSC):
(JSC::MarkedSpace::allocate):

6:25 PM Changeset in webkit [106077] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Fix bad code generated by the JSC idl code generator for [CachedAttribute] attributes
https://bugs.webkit.org/show_bug.cgi?id=77165

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-26
Reviewed by Oliver Hunt.

Missing parameter in a call to deserialize() and using 'this' in the
attribute accessor functions (which are static).

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(NativeToJSValue):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjCachedAttribute1):
(WebCore::jsTestObjCachedAttribute2):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::jsTestSerializedScriptValueInterfaceValue):

6:11 PM Changeset in webkit [106076] by wjmaclean@chromium.org
  • 7 edits in trunk/Source

Source/WebCore: [chromium] Allow modification of size of partially occluded quads during culling to reduce pixel overdraw.
https://bugs.webkit.org/show_bug.cgi?id=76349

Reviewed by James Robinson.

Prior to this patch, draw culling either rejects a DrawQuad because it is completely
occluded, or draws the entire quad (even if it is largely occluded). This patch
attempts to reduce the number of pixels drawn by determining if a partially
occluded DrawQuad can be resized to a smaller quad, based on what portion of the
DrawQuad is actually visible, and performing that resizing where possible.

Added cases to existing unit tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawTileQuad):

  • platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::CCDrawQuad):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore::CCDrawQuad::setQuadVisibleRect):
(WebCore::CCDrawQuad::quadVisibleRect):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::rectSubtractRegion):
(WebCore::CCQuadCuller::cullOccludedQuads):

Source/WebKit/chromium: [chromium] Allow modification of size of partially occluded quads.
https://bugs.webkit.org/show_bug.cgi?id=76349

Reviewed by James Robinson.

  • tests/CCQuadCullerTest.cpp:

(WebCore::makeTileQuads)
(WebCore::setQuads):
(WebCore::TEST):

6:10 PM Changeset in webkit [106075] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2012-01-26 Oliver Hunt <oliver@apple.com>

MSVC bug fix.
<rdar://problem/10703671> MSVC generates bad code for enum compare.

RS=Geoff

Make bitfield large enough to work around MSVC's desire to make enums
signed types.

  • bytecode/CallLinkInfo.h: (CallLinkInfo):
6:09 PM Changeset in webkit [106074] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Revert changes which added setResourceUsageCHROMIUM gl extension since feature changed directions
https://bugs.webkit.org/show_bug.cgi?id=77120

Patch by Michal Mocny <mmocny@google.com> on 2012-01-26
Reviewed by Kenneth Russell.

  • public/platform/WebGraphicsContext3D.h:

(WebGraphicsContext3D):

  • src/GraphicsContext3DChromium.cpp:

(WebCore):

  • tests/FakeWebGraphicsContext3D.h:

(WebKit::FakeWebGraphicsContext3D::setVisibilityCHROMIUM):

6:01 PM Changeset in webkit [106073] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Scrollbars disappear when switching from legacy to overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=77166

Reviewed by Dan Bernstein.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollbarStyleChanged):
Call positionScrollbarLayers to make sure that the new scrollbar layers are positioned correctly.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::updateScrollerStyle):
Call ScrollbarThemeMac::setNewPainterForScrollbar after making the call to the scrollbar painter controller
to set the horizontal or vertical imp, since setting the imp will reset the knob style.

5:55 PM Changeset in webkit [106072] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

NULL ptr in WebCore::ContainerNode::parserAddChild
https://bugs.webkit.org/show_bug.cgi?id=76258

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/parser/nested-fragment-parser-crash.html

We always need a parent element to attach to. In crazy cases, we can
have elements in the stack of open elements that are already detached
from the DOM. In those cases, they don't have a parent, so we aren't
able to enforce the maximum DOM depth. (Fortunately, they're not
attached to the DOM anymore so we don't need to enforce the maximum DOM
depth!)

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::attachLater):
(WebCore::HTMLConstructionSite::fosterParent):

LayoutTests:

This crazy test case causes the parser to do all manner of crazy
things, which is good times for testing.

  • fast/parser/nested-fragment-parser-crash-expected.txt: Added.
  • fast/parser/nested-fragment-parser-crash.html: Added.
5:35 PM Changeset in webkit [106071] by mhahnenberg@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/JavaScriptCore

2012-01-26 Mark Hahnenberg <mhahnenberg@apple.com>

Hang in parallel GC caused by incorrect GCC asm codegen
Reviewed by Filip Pizlo.

<rdar://problem/10742649>

  • wtf/Atomics.h: (WTF::weakCompareAndSwap): Mark the argument volatile to force GCC to do the right thing.
5:30 PM Changeset in webkit [106070] by mrowe@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merge r102507.

5:30 PM Changeset in webkit [106069] by mrowe@apple.com
  • 4 edits in branches/safari-534.54-branch/Source/WebKit2

Merge r102504.

5:30 PM Changeset in webkit [106068] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-534.54-branch/Source/WebKit2

Merge r102497.

5:15 PM Changeset in webkit [106067] by fpizlo@apple.com
  • 24 edits
    14 adds in trunk

All DFG helpers that may call out to arbitrary JS code must know where they
were called from due to inlining and call stack walking
https://bugs.webkit.org/show_bug.cgi?id=77070
<rdar://problem/10750834>

Source/JavaScriptCore:

Reviewed by Geoff Garen.

Changed the DFG to always record a code origin index in the tag of the argument
count (which we previously left blank for the benefit of LLInt, but is still
otherwise unused by the DFG), so that if we ever need to walk the stack accurately
we know where to start. In particular, if the current ExecState* points several
semantic call frames away from the true semantic call frame because we had
performed inlining, having the code origin index recorded means that we can reify
those call frames as necessary to give runtime/library code an accurate view of
the current JS state.

This required several large but mechanical changes:

  • Calling a function from the DFG now plants a store32 instruction to store the code origin index. But the indices of code origins were previously picked by the DFG::JITCompiler after code generation completed. I changed this somewhat; even though the code origins are put into the CodeBlock after code gen, the code gen now knows a priori what their indices will be. Extensive assertions are in place to ensure that the two don't get out of sync, in the form of the DFG::CallBeginToken. Note that this mechanism has almost no effect on JS calls; those don't need the code origin index set in the call frame because we can get it by doing a binary search on the return PC.
  • Stack walking now always calls trueCallFrame() first before beginning the walk, since even the top call frame may be wrong. It still calls trueCallerFrame() as before to get to the next frame, though trueCallerFrame() is now mostly a wrapper around callerFrame()->trueCallFrame().


  • Because the mechanism for getting the code origin of a call frame is bimodal (either the call frame knows its code origin because the code origin index was set, or it's necessary to use the callee frame's return PC), I put in extra mechanisms to determine whether your caller, or your callee, corresponds to a call out of C++ code. Previously we just had the host call flag, but this is insufficient as it does not cover the case of someone calling JSC::call(). But luckily we can determine this just by looking at the return PC: if the return PC is in range of the ctiTrampiline, then two things are true: this call frame's PC will tell you nothing about where you came from in your caller, and the caller already knows where it's at because it must have set the code origin index (unless it's not DFG code, in which case we don't care because there is no inlining to worry about).


  • During testing this revealed a simple off-by-one goof in DFG::ByteCodeParser's inlining code, so I fixed it.
  • Finally because I was tired of doing random #if's for checking if I should be passing around an Instruction* or a ReturnAddressPtr, I created a class called AbstractPC that holds whatever notion of a PC is appropriate for the current execution environment. It's designed to work gracefully even if both the interpreter and the JIT are compiled in, and should integrate nicely with the LLInt.


This is neutral on all benchmarks and fixes some nasty corner-case regressions of
evil code that uses combinations of getters/setters and function.arguments.

(JSC::CodeBlock::codeOrigin):
(CodeBlock):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(CallBeginToken):
(JSC::DFG::CallBeginToken::CallBeginToken):
(JSC::DFG::CallBeginToken::assertCodeOriginIndex):
(JSC::DFG::CallBeginToken::assertNoCodeOriginIndex):
(DFG):
(JSC::DFG::CallExceptionRecord::CallExceptionRecord):
(CallExceptionRecord):
(JSC::DFG::JITCompiler::JITCompiler):
(JITCompiler):
(JSC::DFG::JITCompiler::nextCallBeginToken):
(JSC::DFG::JITCompiler::beginCall):
(JSC::DFG::JITCompiler::notifyCall):
(JSC::DFG::JITCompiler::addExceptionCheck):
(JSC::DFG::JITCompiler::addFastExceptionCheck):

  • dfg/DFGOperations.cpp:

():

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryBuildGetByIDList):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • interpreter/AbstractPC.cpp: Added.

(JSC):
(JSC::AbstractPC::AbstractPC):

  • interpreter/AbstractPC.h: Added.

(JSC):
(AbstractPC):
(JSC::AbstractPC::AbstractPC):
(JSC::AbstractPC::hasJITReturnAddress):
(JSC::AbstractPC::jitReturnAddress):
(JSC::AbstractPC::hasInterpreterReturnAddress):
(JSC::AbstractPC::interpreterReturnAddress):
(JSC::AbstractPC::isSet):
(JSC::AbstractPC::operator!):
():

  • interpreter/CallFrame.cpp:

(JSC):
(JSC::CallFrame::trueCallFrame):
(JSC::CallFrame::trueCallerFrame):

  • interpreter/CallFrame.h:

(JSC::ExecState::abstractReturnPC):
(JSC::ExecState::codeOriginIndexForDFGWithInlining):
(ExecState):
(JSC::ExecState::trueCallFrame):
(JSC::ExecState::trueCallFrameFromVMCode):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::retrieveArgumentsFromVMCode):
(JSC::Interpreter::retrieveCallerFromVMCode):
(JSC::Interpreter::findFunctionCallFrameFromVMCode):

  • interpreter/Interpreter.h:

(Interpreter):
():

  • jit/JITStubs.cpp:

(JSC):
():

  • jit/JITStubs.h:

(JSC):
(JSC::returnAddressIsInCtiTrampoline):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::argumentsGetter):
(JSC::JSFunction::callerGetter):
(JSC::JSFunction::getOwnPropertyDescriptor):

LayoutTests:

Reviewed by Geoff Garen.

  • fast/js/dfg-inline-arguments-use-directly-from-inlined-code-expected.txt: Added.
  • fast/js/dfg-inline-arguments-use-directly-from-inlined-code.html: Added.
  • fast/js/dfg-inline-arguments-use-from-all-the-places-broken-expected.txt: Added.
  • fast/js/dfg-inline-arguments-use-from-all-the-places-broken.html: Added.
  • fast/js/dfg-inline-arguments-use-from-all-the-places-expected.txt: Added.
  • fast/js/dfg-inline-arguments-use-from-all-the-places.html: Added.
  • fast/js/dfg-inline-arguments-use-from-getter-expected.txt: Added.
  • fast/js/dfg-inline-arguments-use-from-getter.html: Added.
  • fast/js/script-tests/dfg-inline-arguments-use-directly-from-inlined-code.js: Added.

(foo):
(bar):
(argsToStr):

  • fast/js/script-tests/dfg-inline-arguments-use-from-all-the-places-broken.js: Added.

(foo):
(fuzz):
(getter):
(bar):
(argsToStr):

  • fast/js/script-tests/dfg-inline-arguments-use-from-all-the-places.js: Added.

(foo):
(fuzz):
(getter):
(bar):
(argsToStr):

  • fast/js/script-tests/dfg-inline-arguments-use-from-getter.js: Added.

(foo):
(bar):
(argsToStr):

5:14 PM Changeset in webkit [106066] by ojan@chromium.org
  • 2 edits in trunk/Tools

Remove builder name so http://trac.webkit.org/changeset/106035 actually works.
https://bugs.webkit.org/show_bug.cgi?id=77164

Reviewed by Dirk Pranke.

http://trac.webkit.org/changeset/106035 depends on builder_name being
falsey by default. There's other code that requires it to be iterable
by default. So, make it be the empty string.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

5:08 PM Changeset in webkit [106065] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium]: svg/W3C-SVG-1.1/text-text-03-b.svg is marked as flakey, when it isn't
https://bugs.webkit.org/show_bug.cgi?id=77157

Unreviewed Chromium expectations update to remove a no-longer-flakey test.

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-26

  • platform/chromium/test_expectations.txt: Removed svg/W3C-SVG-1.1/text-text-03-b.svg
4:54 PM Changeset in webkit [106064] by cdn@chromium.org
  • 2 edits in trunk/Source/WebCore

The registration of schemes is currently racey as they are not registered from the main thread.
Getting rid of the assert that ensures that we are registering from the main thread until we can fix this.

Thank you ap@webkit for helping us identify this.

https://bugs.webkit.org/show_bug.cgi?id=77160

Reviewed by Adam Barth.

  • platform/SchemeRegistry.cpp:

(WebCore::CORSEnabledSchemes):

4:42 PM Changeset in webkit [106063] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

Add GestureTapDown and GestureDoubleTap gesture types to WebGestureEvent.
https://bugs.webkit.org/show_bug.cgi?id=77140

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-01-26
Reviewed by Darin Fisher.

  • public/WebInputEvent.h:

():

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent):

4:37 PM Changeset in webkit [106062] by rniwa@webkit.org
  • 3 edits in trunk/Tools

run-perf-test should include relative file paths in test names
https://bugs.webkit.org/show_bug.cgi?id=77144

Reviewed by Adam Birth.

Include all directory names in the test name separated by "/".
e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):
(PerfTestsRunner._process_parser_test_result):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):

4:31 PM Changeset in webkit [106061] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

We don't need to always repaint overlay scrollbars if they're in layers
https://bugs.webkit.org/show_bug.cgi?id=77159

Reviewed by Beth Dakin.

If a scrollable area has overlay scrollbars we'll always invalidate both scrollbars, regardless of
whether both scroll offsets actually change since they're translucent and we want to draw the new page
contents underneath.

However, if the scrollbars are painted into GraphicsLayers they'll be composited by the GPU, and so we don't
need to repaint them unless the corresponding scroll offset actually changes (which is handled in Scrollbar::updateThumb).

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::setScrollOffsetFromAnimation):

4:16 PM Changeset in webkit [106060] by dpranke@chromium.org
  • 3 edits
    5 deletes in trunk/Tools

webkitpy: re-land cleanup of test scaffolding
https://bugs.webkit.org/show_bug.cgi?id=77153

Reviewed by Eric Seidel.

This is an attempt to reland the change in bug 76973 /
r105935. My earlier attempt to manipulate PYTHONPATH
seems to only work some of the time, for reasons that
elude me. Directly adding Tools/Scripts to sys.path from
inside the test script appears to work (more?) reliably.

Also, it seemed like the files didn't actually get deleted
the last time; I don't know why.

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/common/system/executive_unittest.py:

(command_line):
(ExecutiveTest):
(ExecutiveTest.test_run_command_args_type):
(ExecutiveTest.test_run_command_with_unicode):
(ExecutiveTest.test_running_pids):
(main):

  • Scripts/webkitpy/common/system/fileutils.py: Removed.
  • Scripts/webkitpy/test/cat.py: Removed.
  • Scripts/webkitpy/test/cat_unittest.py: Removed.
  • Scripts/webkitpy/test/echo.py: Removed.
  • Scripts/webkitpy/test/echo_unittest.py: Removed.
4:07 PM Changeset in webkit [106059] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: WebCore::IDBKey objects are leaked
https://bugs.webkit.org/show_bug.cgi?id=77114

Reviewed by Tony Chang.

Fixing memory leaks, no new tests.

  • storage/IDBKey.h:

(WebCore::IDBKey::createInvalid):
(WebCore::IDBKey::createNumber):
(WebCore::IDBKey::createString):
(WebCore::IDBKey::createDate):
(WebCore::IDBKey::createArray):

4:03 PM Changeset in webkit [106058] by ojan@chromium.org
  • 5 edits in trunk/Tools

run-webkit-tests calls "nm" when it doesn't need to
https://bugs.webkit.org/show_bug.cgi?id=77143

Reviewed by Dirk Pranke.

If we are not running any test that can be skipped by checking
the DRT feature list or looking at the list of symbols, avoid calling
out to DRT or calling "nm".

This saves ~700ms on my Mac Pro. In cases where you still have to call out
to "nm" it's only a couple ms slower.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.init):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.skipped_tests):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._should_check_for_missing_features):
(WebKitPort):
(WebKitPort._should_check_for_missing_symbols):
(WebKitPort._skipped_tests_for_unsupported_features):
(WebKitPort.skipped_layout_tests):
(WebKitPort.skipped_tests):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(WebKitPortTest.test_skipped_directories_for_symbols):
(test_skipped_directories_for_features):
(test_skipped_directories_for_features_no_matching_tests_in_test_list):
(test_skipped_layout_tests):

3:50 PM Changeset in webkit [106057] by cdn@chromium.org
  • 7 edits in trunk/Source

Source/WebCore: Add a scheme registry for CORS requests. Allow simple CORS requests to be made to registered schemes.
https://bugs.webkit.org/show_bug.cgi?id=77041

Reviewed by Alexey Proskuryakov.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):

  • platform/SchemeRegistry.cpp:

(WebCore::CORSEnabledSchemes):
(WebCore):
(WebCore::SchemeRegistry::registerCORSEnabledScheme):
(WebCore::SchemeRegistry::isCORSEnabledScheme):

  • platform/SchemeRegistry.h:

(SchemeRegistry):

Source/WebKit/chromium: Add API to register schemes which can be sent simple CORS requests.
https://bugs.webkit.org/show_bug.cgi?id=77041

Reviewed by Alexey Proskuryakov.

  • public/WebSecurityPolicy.h:

(WebSecurityPolicy):

  • src/WebSecurityPolicy.cpp:

(WebKit::WebSecurityPolicy::registerCORSEnabledScheme):
(WebKit):

3:48 PM Changeset in webkit [106056] by leviw@chromium.org
  • 4 edits
    5 adds
    1 delete in trunk/LayoutTests

compositing/shadows/shadow-drawing.html and svg/css/group-with-shadow.svg are failing on Chromium Win
https://bugs.webkit.org/show_bug.cgi?id=77151

Unreviewed gardening. Rebaselining expectations for the above tests on Chromium-Windows and re-enabling them.

  • platform/chromium-win-vista/compositing/shadows: Added.
  • platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-win-vista/svg/css/group-with-shadow-expected.png: Added.
  • platform/chromium-win-xp/compositing/shadows: Added.
  • platform/chromium-win-xp/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-win-xp/svg/css: Removed.
  • platform/chromium-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium/test_expectations.txt:
3:44 PM Changeset in webkit [106055] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

File extension for webp files is .webp
https://bugs.webkit.org/show_bug.cgi?id=76982

Reviewed by Adam Barth.

No new tests. No change in behavior.

  • platform/image-decoders/webp/WEBPImageDecoder.h:

(WebCore::WEBPImageDecoder::filenameExtension):

3:29 PM Changeset in webkit [106054] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

Support a suffix on ChangeLog filenames based on a configuration file
https://bugs.webkit.org/show_bug.cgi?id=76956

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-26
Reviewed by Kentaro Hara.

Modify the tools used to generate, edit and resolve ChangeLogs to support
the addition of a suffix to the ChangeLog filename.

This patch makes it easier to support alternate ChangeLog files in branches.

  • Scripts/VCSUtils.pm:

(changeLogSuffix):
(changeLogFileName):

  • Scripts/commit-log-editor:
  • Scripts/prepare-ChangeLog:

(getLatestChangeLogs):
(generateNewChangeLogs):
(generateFileList):

  • Scripts/resolve-ChangeLogs:

(findChangeLog):

3:25 PM Changeset in webkit [106053] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

compositing/shadows/shadow-drawing.html and svg/css/group-with-shadow.svg are failing on Chromium Win
https://bugs.webkit.org/show_bug.cgi?id=77151

Unreviewed gardening. Marking the above 2 tests as flaky on Chromium Windows until
I can root cause the change.

  • platform/chromium/test_expectations.txt:
3:13 PM Changeset in webkit [106052] by alokp@chromium.org
  • 4 edits in trunk/Source/WebCore

[chromium] Remove dead and unnecessary code related to LayerChromium::cleanupResources
https://bugs.webkit.org/show_bug.cgi?id=77137

Reviewed by James Robinson.

No new test needed. Only removing dead code.

  • platform/graphics/chromium/LayerChromium.cpp:
  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::layerTreeHost):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setLayerTreeHost):

3:06 PM Changeset in webkit [106051] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Move horizontal rubber-band checks to ScrollElasticityController::handleWheelEvent
https://bugs.webkit.org/show_bug.cgi?id=77147

Reviewed by Adam Roben.

  • platform/mac/ScrollAnimatorMac.h:

(ScrollAnimatorMac):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):
Always call ScrollElasticityController::handleWheelEvent, and only call didBeginScrollGesture and
didEndScrollGesture if the event was actually handled.

(WebCore::ScrollAnimatorMac::shouldRubberBandInDirection):
Implement this.

  • platform/mac/ScrollElasticityController.h:
  • platform/mac/ScrollElasticityController.mm:

(WebCore::ScrollElasticityController::handleWheelEvent):
Check if we should rubber-band and return false if we shouldn't.

(WebCore::ScrollElasticityController::shouldRubberBandInHorizontalDirection):
Ask the client if we should rubber-band.

2:58 PM Changeset in webkit [106050] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r106038.
http://trac.webkit.org/changeset/106038
https://bugs.webkit.org/show_bug.cgi?id=77142

Caused a bunch of skipped tests to not be skipped. (Requested
by ojan on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-26

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser):
(TestExpectationParser.parse):
(TestExpectationParser._parse_line):
(TestExpectationParser._collect_matching_tests):
(TestExpectations.init):
(TestExpectations._add_skipped_tests):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.test_dirs):
(Port.normalize_test_name):
(Port.update_baseline):
(Port.layout_tests_dir):
(Port.relative_perf_test_filename):
(Port.abspath_for_test):

2:55 PM Changeset in webkit [106049] by pvarga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix build when VERBOSE_SPECULATION_FAILURE is enabled in DFG
https://bugs.webkit.org/show_bug.cgi?id=77104

Reviewed by Filip Pizlo.

  • dfg/DFGOperations.cpp:

():

2:46 PM Changeset in webkit [106048] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Remove setLayerTreeHost nonsense on lost context
https://bugs.webkit.org/show_bug.cgi?id=76675

Reviewed by Kenneth Russell.

This code isn't needed any more. On a lost context event, we drop all TextureManager-managed textures through
the proxy and no layer types need special lost context handling.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):

2:33 PM Changeset in webkit [106047] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/workers/storage/interrupt-database.html is a flaky crasher on Debug Chromium Bots
https://bugs.webkit.org/show_bug.cgi?id=77136

Unreviewed gardening. Marking fast/workers/storage/interrupt-database.html as a flaky
crasher on debug Chromium bots.

  • platform/chromium/test_expectations.txt:
2:33 PM Changeset in webkit [106046] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Simplify checking of whether we should rubberband horizontally
https://bugs.webkit.org/show_bug.cgi?id=77141

Reviewed by Adam Roben.

Have a single check for horizontal rubber-banding in both directions. This is in preparation
for moving this code into ScrollElasticityController.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::shouldRubberBandInHorizontalDirection):
(WebCore::ScrollAnimatorMac::handleWheelEvent):

2:26 PM Changeset in webkit [106045] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix include path in gyp file for V8InternalSettings.h
https://bugs.webkit.org/show_bug.cgi?id=77128

Patch by Scott Graham <scottmg@chomium.org> on 2012-01-26
Reviewed by Kent Tamura.

  • WebCore.gyp/WebCore.gyp:
2:26 PM Changeset in webkit [106044] by jamesr@google.com
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Add enter/exitRunLoop to WebThread API
https://bugs.webkit.org/show_bug.cgi?id=76012

Reviewed by Darin Fisher.

This adds those two APIs to WebKit::WebThread and converts CCLayerTreeHostTest over to use these APIs instead
of webkit_support. The immediate motivation is that we can't use webkit_support in webkit_unit_tests in the
component build.

  • WebKit.gyp:
  • public/platform/WebThread.h:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::TimeoutTask::run):
(WTF::CCLayerTreeHostTest::BeginTask::BeginTask):
(WTF::CCLayerTreeHostTest::BeginTask::~BeginTask):
(WTF::CCLayerTreeHostTest::BeginTask::run):
(WTF::CCLayerTreeHostTest::runTest):

2:24 PM Changeset in webkit [106043] by jamesr@google.com
  • 34 edits
    1 delete in trunk

We shouldn't synchronously update styles on all documents after running script
https://bugs.webkit.org/show_bug.cgi?id=46761

Reviewed by Simon Fraser.

Currently we call Document::updateStyleForAllDocuments() after invoking any event or timeout handler. This is
slow since it iterates over the entire document tree and defeats our recalcStyle timer batching. It is
unnecessary as any code that depends on styles or the render tree being up to date must call
updateStyleIfNeeded() on the document it is accessing.

The first reference I can find to this code is in r798 in the file WebCore/khtml/xml/domnode_impl.cpp. It's been
cargo culted forward ever since.

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeScript):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::executeScriptInWorld):

  • bindings/js/ScriptController.h:
  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::ScriptController):

  • bindings/v8/ScriptController.h:
  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::executeScript):

  • inspector/InspectorClient.cpp:

(WebCore::InspectorClient::doDispatchMessageOnFrontendPage):

2:21 PM Changeset in webkit [106042] by inferno@chromium.org
  • 1 edit in branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResource.cpp

Merge 105985 - 2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>
BUG=99615
Review URL: https://chromiumcodereview.appspot.com/9288080

2:18 PM Changeset in webkit [106041] by inferno@chromium.org
  • 4 edits in branches/chromium/963/Source/WebCore/rendering/svg

Merge 105986 - 2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>
Needed to fix windows builds.
BUG=99615
Review URL: https://chromiumcodereview.appspot.com/9235073

2:10 PM Changeset in webkit [106040] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

Unreviewed, rolling out r106027.
http://trac.webkit.org/changeset/106027
https://bugs.webkit.org/show_bug.cgi?id=77139

"It messed up Qt5 buildbots." (Requested by jeez_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-26

  • platform/qt-4.8/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
2:10 PM Changeset in webkit [106039] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Get rid of ScrollElasticityController::beginScrollGesture()
https://bugs.webkit.org/show_bug.cgi?id=77138

Reviewed by Adam Roben.

ScrollElasticityController::handleWheelEvent now checks if the wheel event phase is
PlatformWheelEventPhaseBegan and sets up the gesture state if it is.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):

  • platform/mac/ScrollElasticityController.h:

(ScrollElasticityController):

  • platform/mac/ScrollElasticityController.mm:

(WebCore::ScrollElasticityController::handleWheelEvent):

1:46 PM Changeset in webkit [106038] by ojan@chromium.org
  • 3 edits in trunk/Tools

Parsing test_expecations.txt + Skipped lists takes too long
https://bugs.webkit.org/show_bug.cgi?id=77059

Reviewed by Dirk Pranke.

This saves ~100ms on the Apple Mac port.
-memoize a bunch of path methods.
-Avoid doing multiple disk accesses per line.
-Parse the skipped list directly instead of turning it into a test_expecations.txt
formatting string and parsing that.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser):
(TestExpectationParser.parse_skipped_tests):
(TestExpectationParser._parse_line):
(TestExpectationParser._collect_matching_tests):
(TestExpectations.init):
(TestExpectations._add_skipped_tests):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port):
(Port.test_isfile):
(Port.normalize_test_name):
(Port.layout_tests_dir):
(Port.abspath_for_test):

1:38 PM Changeset in webkit [106037] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Get rid of ScrollElasticityController::endScrollGesture()
https://bugs.webkit.org/show_bug.cgi?id=77134

Reviewed by Adam Roben.

Just make ScrollElasticityController::handleWheelEvent call snapRubberBand if the wheel
event phase is PlatformWheelEventPhaseEnded.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):

  • platform/mac/ScrollElasticityController.h:

(ScrollElasticityController):

  • platform/mac/ScrollElasticityController.mm:

(WebCore::ScrollElasticityController::handleWheelEvent):

1:35 PM Changeset in webkit [106036] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in SVGSVGElement::currentViewBoxRect.
https://bugs.webkit.org/show_bug.cgi?id=77121

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Symbols shouldn't be rendered. Revert the ASSERT
from r105513 into a hard check.

Test: svg/custom/symbol-viewport-element-crash.svg

  • svg/SVGLengthContext.cpp:

(WebCore::SVGLengthContext::determineViewport):

LayoutTests:

  • svg/custom/symbol-viewport-element-crash-expected.txt: Added.
  • svg/custom/symbol-viewport-element-crash.svg: Added.
1:26 PM Changeset in webkit [106035] by ojan@chromium.org
  • 3 edits in trunk/Tools

Only store the SVN revision in the summarized results if we're on a builder
https://bugs.webkit.org/show_bug.cgi?id=76976

Reviewed by Dirk Pranke.

This shaves another ~130ms off the single test run-webkit-tests runtime.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(summarize_results):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ResultSummaryTest.get_result):
(ResultSummaryTest):
(ResultSummaryTest.get_result_summary):
(ResultSummaryTest.get_unexpected_results):
(ResultSummaryTest.test_no_svn_revision):
(ResultSummaryTest.test_svn_revision):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.use_trac_links_in_results_html):

1:17 PM Changeset in webkit [106034] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll chromium_rev to 119248
https://bugs.webkit.org/show_bug.cgi?id=77124

Patch by John Bates <jbates@google.com> on 2012-01-26
Reviewed by James Robinson.

  • DEPS:
1:08 PM Changeset in webkit [106033] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Inline beginScrollGesture/endScrollGesture in handleWheelEvent
https://bugs.webkit.org/show_bug.cgi?id=77133

Reviewed by Andreas Kling.

  • platform/mac/ScrollAnimatorMac.h:

(ScrollAnimatorMac):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):

12:56 PM Changeset in webkit [106032] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

No need to set m_haveScrolledSincePageLoad in beginScrollGesture
https://bugs.webkit.org/show_bug.cgi?id=77132

Reviewed by Andreas Kling.

m_haveScrolledSincePageLoad is already set to true in handleWheelEvent so we don't need
to set it to true again.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::beginScrollGesture):

12:46 PM Changeset in webkit [106031] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Simplify checking for whether we should rubberband or not when at the edge
https://bugs.webkit.org/show_bug.cgi?id=77131

Reviewed by Beth Dakin.

We only need to check once if we're pinned at either edge whether we should rubber-band
or not. Do this when the wheel event phase is PlatformWheelEventPhaseBegan. This lets us
remove a bunch of code that would keep track of the current horizontal scroll direction.

  • platform/mac/ScrollAnimatorMac.h:

(ScrollAnimatorMac):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):

12:39 PM Changeset in webkit [106030] by efidler@rim.com
  • 8 edits
    2 deletes in trunk

[JSC] Inspector instrumentation for JavaScript calls.
https://bugs.webkit.org/show_bug.cgi?id=40119

Reviewed by Geoffrey Garen.

Source/WebCore:

Covered by existing Chromium inspector tests

  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::instrumentedCall):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willCallFunctionImpl):

LayoutTests:

  • inspector/timeline/timeline-injected-script-eval-expected.txt: expectation is now valid cross-platform
  • inspector/timeline/timeline-receive-response-event-expected.txt: ditto
  • platform/chromium/inspector/timeline/timeline-injected-script-eval-expected.txt: Removed.
  • platform/chromium/inspector/timeline/timeline-receive-response-event-expected.txt: Removed.
12:30 PM Changeset in webkit [106029] by vangelis@chromium.org
  • 2 edits in trunk/Source/WebCore

Signal to skia to force A8 text from LCD output, but only when we have to disable LCD because we're in a layer
https://bugs.webkit.org/show_bug.cgi?id=76547

Patch by Mike Reed <reed@google.com> on 2012-01-26
Reviewed by Stephen White.

Existing tests should confirm nothing is broken. Antialiased text
is disabled in layouttests, so they should be unaffected by the
difference in antialiasing quality.

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::setupPaintForFont):

12:19 PM Changeset in webkit [106028] by commit-queue@webkit.org
  • 4 edits in trunk

[Qt][WK2] fast/loader tests failed after r94178
https://bugs.webkit.org/show_bug.cgi?id=67388

Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-01-26
Reviewed by Simon Hausmann.

Tools:

Applying the same fix used for Qt-WebKit1 from bug #67254 -
[Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
https://bugs.webkit.org/show_bug.cgi?id=67254
Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
derived from the running location of DumpRenderTree binary.

  • WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:

(WTR::LayoutTestController::pathToLocalResource):

LayoutTests:

Removing the following tests from skipped list:
fast/loader/local-CSS-from-local.html
fast/loader/local-JavaScript-from-local.html
fast/loader/local-image-from-local.html

  • platform/qt-wk2/Skipped:
12:15 PM Changeset in webkit [106027] by jesus@webkit.org
  • 5 edits in trunk/LayoutTests

Updating skipped tests after r105997.

Unreviewed gardening.

  • platform/qt-4.8/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
12:13 PM Changeset in webkit [106026] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Use PlatformWheelEvent::phase() to determine if a scroll gesture begins or ends
https://bugs.webkit.org/show_bug.cgi?id=77127

Reviewed by Beth Dakin.

  • platform/mac/ScrollAnimatorMac.h:

(ScrollAnimatorMac):
Remove handleGestureEvent.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):
Look at the event phase to determine when to call didBeginGesture and didEndGesture.

12:09 PM Changeset in webkit [106025] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Using strncmp() for comparing scheme and port numbers is inefficient
https://bugs.webkit.org/show_bug.cgi?id=75821

Reviewed by Darin Adler.

Replace the equal() function comparing 2 arbitrary strings by a template
comparing the string to an array, character by character.

This is only used for small strings: the schemes and the ports.

  • platform/KURL.cpp:

(WebCore::equal):
(WebCore::isDefaultPortForScheme):
(WebCore::isNonFileHierarchicalScheme):
(WebCore::isCanonicalHostnameLowercaseForScheme):

12:02 PM Changeset in webkit [106024] by knorton@google.com
  • 2 edits
    6 adds in trunk/LayoutTests

[chromium] Unreviewed, rebaseline after http://trac.webkit.org/changeset/105613.

  • platform/chromium-linux/svg/custom/relative-sized-image-expected.png: Added.
  • platform/chromium-linux/svg/repaint/image-with-clip-path-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/repaint/image-with-clip-path-expected.png: Added.
  • platform/chromium-win/svg/custom/relative-sized-image-expected.png: Added.
  • platform/chromium-win/svg/custom/relative-sized-image-expected.txt: Added.
  • platform/chromium-win/svg/repaint/image-with-clip-path-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:56 AM Changeset in webkit [106023] by caio.oliveira@openbossa.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] REGRESSION(102228): lot of test failures after enabled page cache
https://bugs.webkit.org/show_bug.cgi?id=73999

Reviewed by Kenneth Rohde Christiansen.

Those tests were failing because PageCache was enabled for WTR and they depend on
it being disable: they rely on onload being called after navigating back to a page.

WTR should run without PageCache enabled. This was fixed in r106005, so we can
unskip these now.

  • platform/qt-wk2/Skipped:
11:47 AM Changeset in webkit [106022] by abecsi@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] Add the componentComplete method to WebView
https://bugs.webkit.org/show_bug.cgi?id=77111

Reviewed by Kenneth Rohde Christiansen.

Move the touch/desktop initialization to componentComplete.
Also return valid default values in the viewport info functions
if the interaction engine is not yet initialized because the
viewport info component could finish initialization earlier
than the WebView, which results in QML warnings during MiniBrowser
startup.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::setUseTraditionalDesktopBehaviour):
(QQuickWebView::geometryChanged):
(QQuickWebView::componentComplete):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::currentScale):
(QWebViewportInfo::devicePixelRatio):
(QWebViewportInfo::initialScale):
(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):
(QWebViewportInfo::isScalable):
(QWebViewportInfo::layoutSize):

11:28 AM Changeset in webkit [106021] by andersca@apple.com
  • 6 edits in trunk/Source

WebWheelEvent::Phase and PlatformWheelEvent::Phase declarations should match AppKit
https://bugs.webkit.org/show_bug.cgi?id=77123

Reviewed by Beth Dakin.

Source/WebCore:

  • platform/PlatformWheelEvent.h:

():

  • platform/mac/PlatformEventFactoryMac.mm:

(WebCore::phaseForEvent):

Source/WebKit2:

  • Shared/WebEvent.h:

():

  • Shared/mac/WebEventFactory.mm:

(WebKit::phaseForEvent):

11:26 AM Changeset in webkit [106020] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

String::latin1() should take advantage of 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=76646

Reviewed by Geoffrey Garen.

  • wtf/text/WTFString.cpp:

(WTF::String::latin1): For 8 bit strings, use existing buffer
without conversion.

11:23 AM Changeset in webkit [106019] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Dromaeo tests usage of StringImpl find routines cause 8->16 bit conversions
https://bugs.webkit.org/show_bug.cgi?id=76645

Reviewed by Geoffrey Garen.

  • wtf/text/StringImpl.cpp:

(WTF::equalIgnoringCase): New LChar version.
(WTF::findInner): New helper function.
(WTF::StringImpl::find): Added 8 bit path.
(WTF::reverseFindInner): New helper funciton.
(WTF::StringImpl::reverseFind): Added 8 bit path.
(WTF::StringImpl::reverseFindIgnoringCase): Added 8 bit path.

  • wtf/text/StringImpl.h:

(WTF):

11:23 AM Changeset in webkit [106018] by dcheng@chromium.org
  • 2 edits in trunk/Source/WebCore

Revert code changes from r105800
https://bugs.webkit.org/show_bug.cgi?id=77071

The strings are already lowercased in EventHandler.cpp:findDropZone() so there's
no need to call lower() again.

Reviewed by Tony Chang.

Covered by existing tests.

  • dom/Clipboard.cpp:

(WebCore::Clipboard::hasDropZoneType):

11:20 AM Changeset in webkit [106017] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Chromium]: rebaseline after r105878
https://bugs.webkit.org/show_bug.cgi?id=77017

Unreviewed Chromium expectations update.

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-26

  • platform/chromium/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
  • platform/chromium/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:18 AM Changeset in webkit [106016] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION (r91125): Polyline tool in google docs is broken
https://bugs.webkit.org/show_bug.cgi?id=65796

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-26
Reviewed by Nikolas Zimmermann.

It turns out that the CG problem is a design decision. The bounding code
returns CGRectNull for cases where a bound is ill-defined, rather than the
empty bound as expected.

I'm also removing the workaround for isEmpty to get correct zero length paths.
It is no longer necessary.

Tested by existing layout tests.

  • platform/graphics/cg/PathCG.cpp: Removed path empty and path bound testing classes.

(WebCore::Path::boundingRect): Added check for CGRectNull
(WebCore::Path::fastBoundingRect): Added check for CGRectNull
(WebCore::Path::strokeBoundingRect): Added check for CGRectNull
(WebCore::Path::isEmpty): Reverted to former behavior, just using CGPathIsEmpty.
(WebCore::Path::hasCurrentPoint): Reverted to former behavior, using isEmpty.
(WebCore::Path::transform): Reverted to former behavior, using isEmpty.

11:02 AM Changeset in webkit [106015] by kling@webkit.org
  • 13 edits in trunk/Source/WebCore

Refactor application of additional style attributes for table elements.
<http://webkit.org/b/77095>

Reviewed by Darin Adler.

The primary purpose of this change is to reduce usage of CSSMappedAttributeDeclaration.
Instead of using the mapped attribute decl table for additional table style, just use
regular CSSMutableStyleDeclarations. We cache them all globally, except for the style
that's shared between a table's cells. That one is cached per-table since it depends
on the table's border and padding.

  • dom/CSSMappedAttributeDeclaration.cpp:

(WebCore::CSSMappedAttributeDeclaration::~CSSMappedAttributeDeclaration):

  • dom/MappedAttributeEntry.h:

Remove the concept of persistent CSSMappedAttributeDeclarations. The hunk in
~CSSMappedAttributeDeclaration was wildly wrong since it would leave stale pointers
in the decl table, but unreachable since we always leaked one ref to those decls.

  • dom/StyledElement.h:

(WebCore::StyledElement::additionalAttributeStyle):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::additionalAttributeStyle):

  • html/HTMLTableCellElement.h:

(HTMLTableCellElement):

  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::additionalAttributeStyle):

  • html/HTMLTableColElement.h:

(HTMLTableColElement):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::parseMappedAttribute):
(WebCore::leakBorderStyle):
(WebCore::HTMLTableElement::additionalAttributeStyle):
(WebCore::HTMLTableElement::createSharedCellStyle):
(WebCore::HTMLTableElement::additionalCellStyle):
(WebCore::leakGroupBorderStyle):
(WebCore::HTMLTableElement::additionalGroupStyle):

  • html/HTMLTableElement.h:

(HTMLTableElement):

  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::additionalAttributeStyle):

  • html/HTMLTableSectionElement.h:

(HTMLTableSectionElement):

Instead of collecting additional style decls into a vector, switch over to a
"PassRefPtr<CSSMutableStyleDeclaration> additionalAttributeStyle()".
All style declarations that can be reused for all elements are cached at the return
sites, leaving only the shared table cell style which we cache on HTMLTableElement.
Also removed the canHaveAdditionalAttributeStyleDecls() virtual since the default
additionalAttributeStyle() will just return 0.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):

Updated for the new additional style conventions.

10:52 AM Changeset in webkit [106014] by mrowe@apple.com
  • 5 edits in branches/safari-534.54-branch/Source

Versioning.

10:51 AM Changeset in webkit [106013] by mrowe@apple.com
  • 1 copy in tags/Safari-534.54.10

New tag.

10:46 AM Changeset in webkit [106012] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

ASSERT(!m_overlay) reached in TapHighlightController.cpp:73
https://bugs.webkit.org/show_bug.cgi?id=77117

Reviewed by Tor Arne Vestbø.

The PageOverlay does only get uninstalled after the fade-out animation finishes,
so do not assert on !m_overlay after the uninstallPageOverlay call.

  • WebProcess/WebPage/TapHighlightController.cpp:

(WebKit::TapHighlightController::hideHighlight):

10:45 AM Changeset in webkit [106011] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Scripts panel editor container should be based on UISourceCode objects, not SourceFrames.
https://bugs.webkit.org/show_bug.cgi?id=77098

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsNavigator.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.setScriptSourceIsBeingEdited):
(WebInspector.ScriptsPanel.prototype.get visibleView):
(WebInspector.ScriptsPanel.prototype.viewForFile):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
(WebInspector.EditorContainer):
(WebInspector.EditorContainer.prototype.get visibleView):
(WebInspector.EditorContainer.prototype.showFile):
(WebInspector.EditorContainer.prototype.setFileIsDirty):
(WebInspector.EditorContainer.prototype.replaceFiles):
(WebInspector.EditorContainer.prototype.reset):
(WebInspector.EditorContainerDelegate):
(WebInspector.EditorContainerDelegate.prototype.viewForFile):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.replaceUISourceCodes):
(WebInspector.ScriptsPanel.SingleFileEditorContainer):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.get visibleView):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.showFile):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.setFileIsDirty):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.replaceFiles):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.reset):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype.get visibleView):
(WebInspector.TabbedEditorContainer.prototype._titleForFile):
(WebInspector.TabbedEditorContainer.prototype._tooltipForFile):
(WebInspector.TabbedEditorContainer.prototype._appendFileTab):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._tabSelected):
(WebInspector.TabbedEditorContainer.prototype.replaceFiles.get if):
(WebInspector.TabbedEditorContainer.prototype.replaceFiles):
(WebInspector.TabbedEditorContainer.prototype.setFileIsDirty.get if):
(WebInspector.TabbedEditorContainer.prototype.setFileIsDirty):
(WebInspector.TabbedEditorContainer.prototype.reset):

10:42 AM Changeset in webkit [106010] by inferno@chromium.org
  • 1 edit in branches/chromium/963/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp

Merge 105983 - 2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>
BUG=99615
Review URL: https://chromiumcodereview.appspot.com/9288069

10:41 AM Changeset in webkit [106009] by inferno@chromium.org
  • 12 edits
    5 copies in branches/chromium/963

Merge 105978 - crash in WebCore::RenderSVGContainer::paint
BUG=99615
Review URL: https://chromiumcodereview.appspot.com/9235065

9:54 AM Changeset in webkit [106008] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit2

WebPreferencesStore: use DEFINE_STATIC_LOCAL for overrides HashMap
https://bugs.webkit.org/show_bug.cgi?id=77109

Reviewed by Andreas Kling.

Fix build for Clang.

  • Shared/WebPreferencesStore.cpp:

(WebKit):
(WebKit::boolTestRunnerOverridesMap):
(WebKit::WebPreferencesStore::overrideBoolValueForKey):
(WebKit::WebPreferencesStore::removeTestRunnerOverrides):
(WebKit::WebPreferencesStore::getBoolValueForKey):

9:52 AM Changeset in webkit [106007] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test accessibility/loading-iframe-sends-notification.html occasionally exceeds the Chromium Windows callstack
https://bugs.webkit.org/show_bug.cgi?id=77110

Unreviewed gardening. Marking accessibility/loading-iframe-sends-notification.html as flaky on the Chromium
Windows Debug bot.

  • platform/chromium/test_expectations.txt:
9:42 AM Changeset in webkit [106006] by leviw@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Adding platform expectations after r105978.

Unreviewed gardening.

  • platform/chromium-linux/svg/wicd/sizing-flakiness-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/wicd/sizing-flakiness-expected.png: Added.
  • platform/chromium-win/svg/wicd/sizing-flakiness-expected.png: Added.
9:10 AM Changeset in webkit [106005] by caio.oliveira@openbossa.org
  • 17 edits in trunk

Implement overridePreference for boolean preferences in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=77033

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

Implement a way to WebKitTestRunner override preferences for the pages
loaded. Follows the same approach taken by
overrideXSSAuditorEnabledForTestRunner() from r66551, but generalizing to many
preferences.

Preferences are stored in the UI process using WebPreferencesStore, and when
there's a change, this data is sent to Web process, triggering
WebPage::preferencesDidChange(), which take a WebPreferencesStore and apply it's
data to the WebCore::Settings object.

The overridePreference() is executed on the Web process, and set the preferences
without communicating to the UI process. The overriden preferences are stored in
a static map and WebPreferencesStore query this map before returning the values
of each preference. This static map is used only on the Web process.

To clear the overrides we need to clear the map. Since WTR only sets preferences
when resetting the page, we hook the clearing at WebPage::preferencesDidChange().
A WKPreferences private function was exposed to WTR force the update, in case
there's no effective change at UI process (all the properties remains the same).

This clearing could be improved by creating a proper message instead of hooking
at WebPage::preferencesDidChange().

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::decode):
(WebKit::WebPreferencesStore::overrideBoolValueForKey):
(WebKit::WebPreferencesStore::removeTestRunnerOverrides):
(WebKit::WebPreferencesStore::getBoolValueForKey):

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesResetTestRunnerOverrides):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • UIProcess/WebPreferences.h:

(WebKit::WebPreferences::forceUpdate):

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleOverrideBoolPreferenceForTestRunner):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
(WebKit::InjectedBundle::overrideXSSAuditorEnabledForTestRunner):

  • WebProcess/InjectedBundle/InjectedBundle.h:

Tools:

For now overridePreference supports boolean values.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setXSSAuditorEnabled):
(WTR::LayoutTestController::overridePreference):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues): Reset the overrides
explicitly and properly disable the use of PageCache when resetting the
state. Tests that use PageCache can now enable it via overridePreference.

LayoutTests:

  • platform/wk2/Skipped:
8:07 AM Changeset in webkit [106004] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Support opening multiple URL's from the command line in the Qt MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=77100

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-26
Reviewed by Simon Hausmann.

This patch makes the MiniBrowser read multiple URL's from the command
line such that there will be one browser window opened for each URL.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::handleUserOptions):

7:44 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
7:28 AM Changeset in webkit [106003] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[Qt] The Qt MiniBrowser crashes when given multiple URL's
https://bugs.webkit.org/show_bug.cgi?id=77009

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-26
Reviewed by Simon Hausmann.

This patch fixes a crash in BrowserWindow::newWindow() where a
BrowserWindow-object is constructed with a 0 pointer as the
WindowOptions parameter which leads to a crash.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::newWindow):

  • MiniBrowser/qt/BrowserWindow.h:
7:22 AM SettingUpDevelopmentEnvironmentForN9 created by zarvai@inf.u-szeged.hu
7:20 AM Changeset in webkit [106002] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Still failing tests after moving to ICU
https://bugs.webkit.org/show_bug.cgi?id=77102

Unreviewed gardening.

  • platform/qt-wk2/Skipped: Skip failing tests for now.
7:04 AM Changeset in webkit [106001] by Nikolas Zimmermann
  • 6 edits
    3 adds in trunk

SVG + <object> tests are flakey
https://bugs.webkit.org/show_bug.cgi?id=77099

Reviewed by Andreas Kling.

Source/WebCore:

Bug 76447 changed the way RenderSVGRoot figures out its size. Previously RenderSVGRoot directly called out to the
ownerRenderer (RenderEmbeddedObject) to compute its replaced size when embedded through eg. <object> element,
which was quite hacky. It now relies on the ownerRenderers availableLogicalWidth/Height to be correctly set,
which requires that the ownerRenderer is always laid out before the RenderSVGRoot and not the other way round.

This is the source of current flakiness bugs.

In trunk FrameView contains several special hacks, to layout the ownerRenderers view, after the RenderSVGRoots view
finished layout. This worked without flakiness as RenderSVGRoot used to directly call computeReplacedLogicalWidth/Height
on the ownerRenderer, which is now gone. Fortunately we can keep the new design, and can remove all hacks out of
RenderSVGRoot/FrameView, if we can guarantee that the ownerRenderer FrameView is laid out before the RenderSVGRoot FrameView.

This is a much less error-prone approach as the previous one. This lets us run nrwt --tolerance 0 -p svg -g again,
without 100% reproducable failing svg/wicd tests. (There's still one unrelated error, before guard malloc mode passes fully).

Test: svg/wicd/sizing-flakiness.html (Adjusted version of the rightsizing test, made to fail with trunk w/o this patch.)

  • page/FrameView.cpp: Remove m_inLayoutParentView.

(WebCore::FrameView::FrameView): Remove no longer needed m_inLayoutParentView.
(WebCore::FrameView::forceLayoutParentViewIfNeeded): Simplify, no need to call updateWidgetPositions anymore, nor to clear/query flags in RenderSVGRoot.
(WebCore::FrameView::layout): Call forceLayoutParentViewIfNeeded() before laying out the embedded document, to guarantee the correct order.

  • page/FrameView.h:

(FrameView): Remove m_inLayoutParentView.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::RenderSVGRoot): Remove m_needsSizeNegotiationWithHostDocument.
(WebCore::resolveLengthAttributeForSVG): Remove outcommented code, that went in by accident.
(WebCore::RenderSVGRoot::layout): Remove m_needsSizeNegotiationWithHostDocument handling which is now incorrect and no longer needed.

  • rendering/svg/RenderSVGRoot.h:

(RenderSVGRoot): Remove m_needsSizeNegotiationWithHostDocument + accessors.

LayoutTests:

Introduce a testcase that fails reproducibly w/o needed guard malloc, if we ever regress <object> sizing again.

  • platform/mac/svg/wicd/sizing-flakiness-expected.png:
  • platform/mac/svg/wicd/sizing-flakiness-expected.txt:
  • svg/wicd/sizing-flakiness.html: Adjusted version of the rightsizing test, made to fail with trunk w/o this patch.
7:03 AM Changeset in webkit [106000] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK][WK2] Primary clipboard should be updated with the current selection in X11 platforms
https://bugs.webkit.org/show_bug.cgi?id=77097

Reviewed by Martin Robinson.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::respondToChangedSelection): Call
setSelectionPrimaryClipboardIfNeeded() to update primary clipboard
in X11 platforms.

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::collapseSelection): Callback called when clearing
clipboard contents.
(WebKit::WebEditorClient::setSelectionPrimaryClipboardIfNeeded):
Updaye primary clipboard with the current selection.

6:56 AM Changeset in webkit [105999] by kling@webkit.org
  • 5 edits in trunk/Source/WebCore

Make elements that don't have attributes smaller.
<http://webkit.org/b/76876>

Reviewed by Antti Koivisto.

Move the inline style declaration from StyledElement to NamedNodeMap, since having
an inline style declaration also implies having a style attribute on the element.
This saves one CPU word per element that has no attributes.

This reduces memory consumption by 412 kB (on 64-bit) when viewing the full
HTML5 spec at <http://whatwg.org/c>.

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::ensureInlineStyleDecl):
(WebCore::NamedNodeMap::destroyInlineStyleDecl):
(WebCore::NamedNodeMap::createInlineStyleDecl):

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::inlineStyleDecl):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::addSubresourceAttributeURLs):

  • dom/StyledElement.h:

(WebCore::StyledElement::inlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):

6:14 AM Changeset in webkit [105998] by antonm@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Another unreviewed rebaseline.

  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Added.
6:07 AM Changeset in webkit [105997] by commit-queue@webkit.org
  • 11 edits in trunk

[Qt] Use ICU if available
https://bugs.webkit.org/show_bug.cgi?id=76821

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-01-26
Reviewed by Simon Hausmann.

Source/WebCore:

Adding correct sources to a Qt 5 based build.

No new tests, it's just a build dependency change.

  • Target.pri:

Source/WTF:

Adding libicu dependencies for a Qt5 based build.

  • WTF.pri:

Tools:

Adding unicode defines for a Qt 5 based build.

  • qmake/mkspecs/features/features.prf:

LayoutTests:

Unskipping ICU related tests for Qt 5 and skipping for
Qt 4.

  • platform/qt-4.8/Skipped:
  • platform/qt-arm/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
5:53 AM Changeset in webkit [105996] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Added missing NETSCAPE_PLUGIN_API macro.
https://bugs.webkit.org/show_bug.cgi?id=77093

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2012-01-26
Reviewed by Andreas Kling.

The ewk_view_js_window_object_clear function should be inside ENABLE(NETSCAPE_PLUGIN_API) macro.

  • ewk/ewk_view.cpp:
5:43 AM Changeset in webkit [105995] by Csaba Osztrogonác
  • 4 edits in trunk/Source

[Qt][Win] One more speculative buildfix after r105970.

Source/JavaScriptCore:

Source/WTF:

  • WTF.pri:
4:58 AM Changeset in webkit [105994] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix mac build after r105988.

  • WebCore.exp.in:
4:46 AM Changeset in webkit [105993] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

[Qt][Win] Speculative buildfix after r105970.

4:42 AM Changeset in webkit [105992] by Nikolas Zimmermann
  • 5 edits in trunk/LayoutTests

svg/webarchive tests are flakey under guard malloc
https://bugs.webkit.org/show_bug.cgi?id=77092

Reviewed by Zoltan Herczeg.

Fix flakey tests, by moving the <script> that dumps the test as webarchive, after the actual content.

  • svg/webarchive/svg-cursor-subresources-expected.webarchive:
  • svg/webarchive/svg-cursor-subresources.svg:
  • svg/webarchive/svg-feimage-subresources-expected.webarchive:
  • svg/webarchive/svg-feimage-subresources.svg:
4:28 AM Changeset in webkit [105991] by zeno.albisser@nokia.com
  • 10 edits
    2 adds in trunk/Source/WebKit2

[Qt][WK2] Use QVariant for payload data in application URL schemes.
https://bugs.webkit.org/show_bug.cgi?id=77007

Make application schemes use QVariant for payload data.
This allows passing QByteArrays as well as simple String data.

Remove unneeded http header parts that were exposed in
QQuickNetworkReply.

Add ByteArrayTestData class to allow injecting QByteArray
data into an application scheme handler for testing.

Reviewed by Simon Hausmann.

  • Shared/qt/QtNetworkReplyData.cpp:

(WebKit::QtNetworkReplyData::QtNetworkReplyData):
(WebKit::QtNetworkReplyData::encode):
(WebKit::QtNetworkReplyData::decode):

  • Shared/qt/QtNetworkReplyData.h:
  • UIProcess/API/qt/qquicknetworkreply.cpp:

(QQuickNetworkReply::QQuickNetworkReply):
(QQuickNetworkReply::data):
(QQuickNetworkReply::setData):
(QQuickNetworkReply::send):

  • UIProcess/API/qt/qquicknetworkreply_p.h:
  • UIProcess/API/qt/tests/bytearraytestdata.cpp: Added.

(ByteArrayTestData::ByteArrayTestData):
(ByteArrayTestData::latin1Data):
(ByteArrayTestData::utf8Data):

  • UIProcess/API/qt/tests/bytearraytestdata.h: Added.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:
  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(main):

  • UIProcess/API/qt/tests/tests.pri:
  • WebProcess/qt/QtNetworkReply.cpp:

(WebKit::QtNetworkReply::setReplyData):

  • WebProcess/qt/QtNetworkReply.h:
4:18 AM Changeset in webkit [105990] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Fixed build when using force_static_libs_as_shared
https://bugs.webkit.org/attachment.cgi?bugid=77082

Patch by Thiago Marcos P. Santos <tmpsantos@gmail.com> on 2012-01-26
Reviewed by Simon Hausmann.

  • Target.pri:
4:17 AM Changeset in webkit [105989] by antonm@chromium.org
  • 1 edit
    9 adds
    5 deletes in trunk/LayoutTests

Unreviewed rebaseline after http://trac.webkit.org/changeset/105977.

  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Removed.
  • platform/chromium/svg/W3C-SVG-1.1-SE: Added.
  • platform/chromium/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
  • platform/chromium/svg/stroke: Added.
  • platform/chromium/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Removed.
  • platform/gtk/svg/stroke: Removed.
  • platform/gtk/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Removed.
  • platform/qt/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Removed.
  • svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
  • svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Added.
4:16 AM Changeset in webkit [105988] by commit-queue@webkit.org
  • 13 edits in trunk

[WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission
https://bugs.webkit.org/show_bug.cgi?id=42545

Patch by Nándor Huszka <huszka.nandor@stud.u-szeged.hu> on 2012-01-26
Reviewed by Zoltan Herczeg.

Source/WebCore:

No need for new tests, there is no behavior change.

Added a line to file which copies the forwarding headers.

  • WebCore.vcproj/copyForwardingHeaders.cmd:

Source/WebKit2:

Implement the setGeolocationPermission method.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetGeolocationPermission):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setGeoLocationPermission):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Implement the setGeolocationPermission method.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setGeolocationPermission):
(WTR):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

LayoutTests:

Unskip a test which does not fail now and move tests to the appropriate label.

  • platform/wk2/Skipped:
3:58 AM Changeset in webkit [105987] by Nikolas Zimmermann
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r105982.
http://trac.webkit.org/changeset/105982
https://bugs.webkit.org/show_bug.cgi?id=77090

breaks the world (Requested by WildFox on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-26

  • wtf/MainThread.cpp:

(WTF):

  • wtf/Platform.h:
  • wtf/mac/MainThreadMac.mm:

(WTF):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):

3:08 AM Changeset in webkit [105986] by Nikolas Zimmermann
  • 5 edits in trunk/Source/WebCore

2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix Qt build after r105978.

  • rendering/svg/RenderSVGResourceClipper.cpp: Add missing Frame/FrameView includes.
  • rendering/svg/RenderSVGResourceSolidColor.cpp: Ditto.
  • rendering/svg/SVGInlineTextBox.cpp: Ditto.
  • rendering/svg/SVGRenderSupport.cpp: Ditto.
2:41 AM Changeset in webkit [105985] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix non-AllInOne builds after r105978.

  • rendering/svg/RenderSVGResource.cpp:
2:29 AM Changeset in webkit [105984] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed inspector closure compilation fix.

  • inspector/front-end/externs.js:

(WebInspector.closeDrawerView):

2:26 AM Changeset in webkit [105983] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix release builds after r105978.

  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paintSelectionBackground): Remove unused variable.
2:22 AM Changeset in webkit [105982] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

[Qt] GC should be parallel on Qt platform
https://bugs.webkit.org/show_bug.cgi?id=73309

Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-01-26
Reviewed by Zoltan Herczeg.

These changes made the parallel gc feature available for Qt port.
The implementation of "registerGCThread" and "isMainThreadOrGCThread"
is moved from MainThreadMac.mm to the common MainThread.cpp to make
them available for other platforms.

Measurement results:
V8 speed-up: 1.071x as fast [From: 746.1ms To: 696.4ms ]
WindScorpion speed-up: 1.082x as fast [From: 3490.4ms To: 3226.7ms]
V8 Splay speed-up: 1.158x as fast [From: 145.8ms To: 125.9ms ]

Tested on Intel(R) Core(TM) i5-2320 CPU @ 3.00GHz with 4-core.

  • wtf/MainThread.cpp:

(WTF):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):

  • wtf/Platform.h:
  • wtf/mac/MainThreadMac.mm:
2:10 AM Changeset in webkit [105981] by kbalazs@webkit.org
  • 5 edits in trunk/Tools

[NRWT] Support --ignore-metrics
https://bugs.webkit.org/show_bug.cgi?id=76278

Reviewed by Tony Chang.

Port the feature from ORWT.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._run_compare_test):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(DriverOutput):
(DriverOutput.strip_metrics):

  • Scripts/webkitpy/layout_tests/port/driver_unittest.py:

(DriverOutputTest):
(DriverOutputTest.test_strip_metrics):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):
(parse_args):

2:07 AM Changeset in webkit [105980] by tkent@chromium.org
  • 5 edits in trunk

Unreviewed, rolling out r105968.
http://trac.webkit.org/changeset/105968
https://bugs.webkit.org/show_bug.cgi?id=76995

Incorrect behavior change

Source/WebCore:

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setIndeterminate):

LayoutTests:

  • fast/forms/indeterminate-radio.html:
  • fast/forms/radio-checkbox-restore-indeterminate.html:
1:51 AM Changeset in webkit [105979] by commit-queue@webkit.org
  • 8 edits in trunk/Tools

Unreviewed, rolling out r105935 and r105954.
http://trac.webkit.org/changeset/105935
http://trac.webkit.org/changeset/105954
https://bugs.webkit.org/show_bug.cgi?id=77080

test-webkitpy is still broken (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-26

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/common/system/executive_unittest.py:

(never_ending_command):
(ExecutiveTest.test_run_command_args_type):
(ExecutiveTest.test_run_command_with_unicode):
(ExecutiveTest.test_running_pids):

  • Scripts/webkitpy/common/system/fileutils.py:

(make_stdout_binary):

  • Scripts/webkitpy/test/cat.py:

(command_arguments):
(main):

  • Scripts/webkitpy/test/cat_unittest.py:

(CatTest):
(CatTest.assert_cat):
(CatTest.test_basic):
(CatTest.test_no_newline):
(CatTest.test_unicode):
(CatTest.test_as_command):

  • Scripts/webkitpy/test/echo.py:

(command_arguments):
(main):

  • Scripts/webkitpy/test/echo_unittest.py:

(EchoTest):
(EchoTest.test_basic):
(EchoTest.test_no_newline):
(EchoTest.test_unicode):
(EchoTest.test_argument_order):
(EchoTest.test_empty_arguments):
(EchoTest.test_no_arguments):
(EchoTest.test_as_command):

1:50 AM Changeset in webkit [105978] by Nikolas Zimmermann
  • 14 edits
    5 adds in trunk

crash in WebCore::RenderSVGContainer::paint
https://bugs.webkit.org/show_bug.cgi?id=69714

Reviewed by Dirk Schulze.

Source/WebCore:

When RenderSVGResourceClipper draws its children to a mask, it requires some special constraints:

  • fill-opacity/stroke-opacity/opacity forced to 1
  • masker/filter resources shouldn't be applied to the children
  • fill must be set to the initial fill paint server for all children (solid black)
  • stroke must be set to the initial stroke paint server for all children (none)

This was achieved before by mutating the style of the children, which made them need a relayout.
SVGImageBufferTools:renderSubtreeToImageBuffer thus needed to layout the children, if needed, before painting.

This can be completly avoided, when changing RenderSVGResourceClipper to avoid style mutations.
Introduce a new "PaintBehaviorRenderingSVGMask", and set the current FrameViews paintBehaviour to this
state, before painting the subtree. This way we can detect that we're rendering a clip mask, without
having to mutate the style of the children and without having to relayout.

We can now ASSERT(!item->needsLayout()) in renderSubtreeToImageBuffer.

Tests: svg/clip-path/clip-path-tspan-and-stroke.svg

svg/custom/layout-loop.svg

  • rendering/PaintPhase.h:
  • rendering/svg/RenderSVGResource.cpp:

(WebCore::requestPaintingResource):

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::RenderSVGResourceClipper):
(WebCore::RenderSVGResourceClipper::removeAllClientsFromCache):
(WebCore::RenderSVGResourceClipper::removeClientFromCache):
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):

  • rendering/svg/RenderSVGResourceClipper.h:
  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):
(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):

  • rendering/svg/RenderSVGResourceMasker.h:
  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::createTileImage):

  • rendering/svg/RenderSVGResourceSolidColor.cpp:

(WebCore::RenderSVGResourceSolidColor::applyResource):

  • rendering/svg/SVGImageBufferTools.cpp:

(WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintSelectionBackground):
(WebCore::SVGInlineTextBox::paint):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::prepareToRenderSVGContent):

LayoutTests:

Added a new test covering the clipper specific demands when rendering its children to a mask.
(fill/stroke-opacity=1, opacity=1, don't apply masker/filter to children)

All cases are covered by existing tests, I'm adding a new combination of <tspan> within a <text>,
that tries to apply a stroke paint server, which is supposed to be ignored.

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Added.
  • svg/clip-path/clip-path-tspan-and-stroke.svg: Added.
  • svg/custom/layout-loop-expected.txt: Added.
  • svg/custom/layout-loop.svg: Added.
1:40 AM Changeset in webkit [105977] by Nikolas Zimmermann
  • 13 edits in trunk/LayoutTests

2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Regenerated some new SVG results using a Lion machine, to make the baseline pass with --tolerance 0 -p on a vanilla iMac again.

  • platform/mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
  • platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.png:
  • platform/mac/svg/stroke/zero-length-arc-linecaps-rendering-expected.png:
  • platform/mac/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt:
  • platform/mac/svg/stroke/zero-length-path-linecap-rendering-expected.png:
  • platform/mac/svg/stroke/zero-length-path-linecap-rendering-expected.txt:
  • platform/mac/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png:
  • platform/mac/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt:
  • platform/mac/test_expectations.txt
1:28 AM Changeset in webkit [105976] by Nikolas Zimmermann
  • 3 edits in trunk/WebKitLibraries

2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix win build, by disabling ENABLE_SHADOW_DOM by default.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
1:09 AM Changeset in webkit [105975] by Nikolas Zimmermann
  • 4 edits in trunk/Source

2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Try to fix Qt/Win build by building OwnPtrWin.cpp into the WTF library.

  • WTF.pro:

2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Try to fix Gtk build - JSShadowRoot.cpp can't be found, fix by looking for it in the derived sources.

  • GNUmakefile.list.am:
1:01 AM Changeset in webkit [105974] by rgabor@webkit.org
  • 2 edits in trunk/Tools

[GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=76138

Reviewed by Martin Robinson.

  • Scripts/webkitdirs.pm:

(isCrossCompilation):
(buildAutotoolsProject):

12:56 AM Changeset in webkit [105973] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r105917.

  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
12:55 AM Changeset in webkit [105972] by mrowe@apple.com
  • 12 edits in branches/safari-534.54-branch/Source

Merge r105942.

12:28 AM Changeset in webkit [105971] by rniwa@webkit.org
  • 1 edit
    15 adds in trunk

Port Mozilla's Graph Server
https://bugs.webkit.org/show_bug.cgi?id=76312

Reviewed by Adam Barth.

Add the app engine backend for the Mozilla's graph server used on perf-webkit.appspot.com.

To deploy webkit-perf.appspot.com, you also need to pull index.html, embed.html, graph.html, jq,
js (except config.js), and css (except title.png) from https://github.com/mozilla/graphs.

  • Websites/perf-webkit.appspot.com: Added.
  • Websites/perf-webkit.appspot.com/app.yaml: Added.
  • Websites/perf-webkit.appspot.com/create_handler.py: Added.

(CreateHandler):
(CreateHandler.post):
(CreateHandler._createBuilder):
(CreateHandler._createBuilder.execute):
(CreateHandler._createBranch):
(CreateHandler._createBranch.execute):
(CreateHandler._createPlatform):
(CreateHandler._createPlatform.execute):

  • Websites/perf-webkit.appspot.com/dashboard_handler.py: Added.

(DashboardHandler):
(DashboardHandler.get):

  • Websites/perf-webkit.appspot.com/index.yaml: Added.
  • Websites/perf-webkit.appspot.com/main.py: Added.

(main):

  • Websites/perf-webkit.appspot.com/manifest_handler.py: Added.

(ManifestHandler):
(ManifestHandler.get):

  • Websites/perf-webkit.appspot.com/models.py: Added.

(NumericIdHolder):
(NumericIdHolder.whose):
(createInTransactionWithNumericIdHolder):
(modelFromNumericId):
(Branch):
(Platform):
(Builder):
(Builder.authenticate):
(Builder.hashedPassword):
(Build):
(Test):
(TestResult):
(ReportLog):

  • Websites/perf-webkit.appspot.com/report_handler.py: Added.

(ReportHandler):
(ReportHandler.post):
(ReportHandler._modelByKeyNameInBodyOrError):
(ReportHandler._integerInBody):
(ReportHandler._timestampInBody):
(ReportHandler._output):
(ReportHandler._resultsAreValid):
(ReportHandler._createBuildIfPossible):
(ReportHandler._createBuildIfPossible.execute):
(ReportHandler._addTestIfNeeded):
(ReportHandler._addTestIfNeeded.execute):

  • Websites/perf-webkit.appspot.com/runs_handler.py: Added.

(RunsHandler):
(RunsHandler.get):

  • Websites/perf-webkit.appspot.com/static: Added.
  • Websites/perf-webkit.appspot.com/static/create-models.html: Added.
  • Websites/perf-webkit.appspot.com/static/manual-submit.html: Added.
12:17 AM Changeset in webkit [105970] by aestes@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION (r105555): Incorrect use of OS() macro breaks OwnPtr when used with Win32 data types
https://bugs.webkit.org/show_bug.cgi?id=77073

Reviewed by Ryosuke Niwa.

r105555 changed PLATFORM(WIN) to OS(WIN), but WTF_OS_WIN isn't defined.
This should have been changed to OS(WINDOWS). This causes the
preprocessor to strip out Win32 data type overrides for deleteOwnedPtr,
causing allocations made by Win32 to be deleted by fastmalloc.

  • wtf/OwnPtrCommon.h:

(WTF): Use OS(WINDOWS) instead of OS(WIN).

12:16 AM Changeset in webkit [105969] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Improve user experience of advanced search panel closing.
https://bugs.webkit.org/show_bug.cgi?id=76983

Reviewed by Pavel Feldman.

Added close button to search panel.
Esc now closes the panel even when search filed has focus.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.AdvancedSearchController.prototype.close):
(WebInspector.SearchView):
(WebInspector.SearchView.prototype._onKeyDown):
(WebInspector.SearchView.prototype._closeButtonPressed):

  • inspector/front-end/inspector.css:

(.search-view .search-panel):
(.search-view .search-panel button.search-close-button):

  • inspector/front-end/inspector.js:

(WebInspector._escPressed):
(WebInspector.closeDrawerView):

12:06 AM Changeset in webkit [105968] by commit-queue@webkit.org
  • 5 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=76995.
WebKit fails IETC :indeterminate and input type=radio test.

As per the HTML spec http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#dom-input-indeterminate,
only checkbox input type should respect the indeterminate state.
Removed the support for indeterminate state for radio input types.

Source/WebCore:

Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-26
Reviewed by Eric Seidel.

Modified the existing test cases.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setIndeterminate): Indeterminate state is supported only for checkbox input type.

LayoutTests:

Modified the existing test cases.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-26
Reviewed by Eric Seidel.

  • fast/forms/indeterminate-radio.html:
  • fast/forms/radio-checkbox-restore-indeterminate.html:

Jan 25, 2012:

11:50 PM Changeset in webkit [105967] by abarth@webkit.org
  • 2 edits in trunk/Tools

Kentaro is a reviewer now. Yay!

  • Scripts/webkitpy/common/config/committers.py:
10:15 PM Changeset in webkit [105966] by Lucas Forschler
  • 5 edits in branches/safari-534.54-branch/Source

Versioning.

10:12 PM Changeset in webkit [105965] by Lucas Forschler
  • 1 copy in tags/Safari-534.54.9

New tag.

9:56 PM Changeset in webkit [105964] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Add IntentRequest include for FrameLoaderClientImpl.
https://bugs.webkit.org/show_bug.cgi?id=77039

Patch by Greg Billock <gbillock@google.com> on 2012-01-25
Reviewed by Darin Fisher.

  • src/FrameLoaderClientImpl.cpp:
9:12 PM Changeset in webkit [105963] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/js/dfg-uint32array-overflow-values.html is slow on Chromium Debug bots
https://bugs.webkit.org/show_bug.cgi?id=77069

Marking fast/js/dfg-uint32array-overflow-values.html slow for Debug Chromium bots.

  • platform/chromium/test_expectations.txt:
9:02 PM Changeset in webkit [105962] by dcheng@chromium.org
  • 7 edits
    1 move
    1 add
    1 delete in trunk/Source

[chromium] Fix ClipboardChromium::validateFilename to actually operate on extensions
https://bugs.webkit.org/show_bug.cgi?id=76996

Source/WebCore:

As it turns out, we were always calling validateFilename on a data object with an empty
extension. Now we call it on an actual extension so that it's sanitized.

Reviewed by Tony Chang.

Unit test: webkit_unit_tests --gtest_filter=ClipboardChromium.*

  • WebCore.gypi:
  • platform/chromium/ClipboardChromium.cpp:

(WebCore::writeImageToDataObject):

  • platform/chromium/ClipboardChromium.h:

(ClipboardChromium):

  • platform/chromium/ClipboardChromiumLinux.cpp: Removed.
  • platform/chromium/ClipboardChromiumPosix.cpp: Renamed from Source/WebCore/platform/chromium/ClipboardChromiumMac.cpp.

(WebCore):
(WebCore::isInvalidFileCharacter):
(WebCore::ClipboardChromium::validateFilename):

  • platform/chromium/ClipboardChromiumWin.cpp:

(WebCore):
(WebCore::ClipboardChromium::validateFilename):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • WebKit.gypi:
  • tests/ClipboardChromiumTest.cpp: Added.

(WebCore):
(WebCore::TEST):

7:08 PM Changeset in webkit [105961] by commit-queue@webkit.org
  • 10 edits in trunk/Source

[chromium] Rollout r100751, this mechanism does not work and is very slow
https://bugs.webkit.org/show_bug.cgi?id=77055

Unreviewed rollout of http://trac.webkit.org/changeset/100751. The refresh rate mechanism is not implemented,
but it still triggers a very slow codepath and triggers races on some platforms.

Patch by James Robinson <jamesr@chromium.org> on 2012-01-25

Source/WebCore:

  • platform/PlatformScreen.h:

(WebCore):

  • platform/chromium/PlatformScreenChromium.cpp:
  • platform/chromium/PlatformSupport.h:

(PlatformSupport):
():

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(CCSettings):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeImplOnImplThread):

Source/WebKit/chromium:

  • public/WebScreenInfo.h:

(WebScreenInfo):
(WebKit::WebScreenInfo::WebScreenInfo):

  • src/PlatformSupport.cpp:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::runTest):

6:27 PM Changeset in webkit [105960] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Reverting the addition of storage/indexeddb/prefetch-bugfix-108071.html
to Chromium's test_expectations. The proper place for this test to be disabled was
in Chromium, since it failed in test_shell.

  • platform/chromium/test_expectations.txt:
6:10 PM Changeset in webkit [105959] by Lucas Forschler
  • 4 edits
    3 copies in branches/safari-534.54-branch

Merged r105894.

6:01 PM Changeset in webkit [105958] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r102819.

5:59 PM Changeset in webkit [105957] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt: running w/ no arguments fails
https://bugs.webkit.org/show_bug.cgi?id=77064

Unreviewed, build fix.

This change fixes a regression introduced in r105944
where running without --platform <foo> or one of the other
platform switches would cause a null deref :(.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(main):

5:56 PM Changeset in webkit [105956] by eric@webkit.org
  • 2 edits in trunk/Tools

Automatically CC someone from Apple on any changes to Obj-C public API
https://bugs.webkit.org/show_bug.cgi?id=77053

Reviewed by Timothy Hatcher.

This has long been de-facto practice, seems now that we have
fancy watchlist support, we should just make the tools
do this automatically.

  • Scripts/webkitpy/common/config/watchlist:
5:53 PM Changeset in webkit [105955] by piman@chromium.org
  • 2 edits in trunk/Tools

Updating status in committers.py.

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
5:47 PM Changeset in webkit [105954] by dpranke@chromium.org
  • 3 edits in trunk/Tools

test-webkitpy: executive_unittest fails if PYTHONPATH isn't set
https://bugs.webkit.org/show_bug.cgi?id=77058

Reviewed by Eric Seidel.

r105935 broke executive_unittest by changing which script we
were running and not ensuring that the PYTHONPATH was set up
properly.

This change also fixes a regression introduced recently where
test-webkitpy wasn't figuring out the path to Tools/Scripts
right, either (so running ./test-webkitpy would fail).

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/common/system/executive_unittest.py:

(script_dir):
(ExecutiveTest.setUp):
(ExecutiveTest):
(ExecutiveTest.tearDown):

5:34 PM Changeset in webkit [105953] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/LayoutTests/platform/mac-snowleopard/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png

Fixing one incorrect test expectation.

5:30 PM Changeset in webkit [105952] by abarth@webkit.org
  • 2 edits in trunk/Tools

Disable tests on the mac-ews while we sort out hte stability issues.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(MacEWS):

5:29 PM Changeset in webkit [105951] by dpranke@chromium.org
  • 8 edits in trunk/Tools

investigate use of 'mac' and 'win' as fully-specified port names for the apple ports
https://bugs.webkit.org/show_bug.cgi?id=76475

Reviewed by Eric Seidel.

This patch cleans up the internal usage of port names for the
Apple mac and Apple win ports so that 'mac' and 'win are never
considered "fully specified" port names: they are still legal
input to the PortFactory.get() routine, but only if run on the given
platform (i.e. trying to PortFactory.get('mac') on windows or
linux will return an error, since we don't know which version of
the port is desired.

This also cleans up handling of the webkit2 variants, so that
the full port names consistently follow the
<operating_system>-<version>[-<wk2>] convention.

Lastly this patch adds some assertions and removes some
try/catch logic to catch more programming and usage errors;
previously mac-tiger might've been allowed -- and it would've
translated into using just the baselines in platform/mac -- but
now it should fail.

  • Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort.determine_full_port_name):
(ApplePort.init):
(ApplePort):
(ApplePort._port_name_with_version):

  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest.test_mac):
(FactoryTest.test_win):

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(MacTest.test_versions):

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/win_unittest.py:

(WinTest.test_versions):

5:24 PM Changeset in webkit [105950] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Reapply Daniel Bates's build fix from r105847 after the exact same issue was reintroduced in r105930.

Attempt to fix Mac build after changeset <http://trac.webkit.org/changeset/105930>.
(https://bugs.webkit.org/show_bug.cgi?id=75049)

Don't include NotImplemented.h in KURL.h since NotImplemented.h includes Logging.h, which defines
LOG_CHANNEL_PREFIX to be "Log". And this conflicts with the inclusion of WebKitLogging.h in
WebHTMLView.mm (which would have defined LOG_CHANNEL_PREFIX to be "WebKitLog").

  • platform/KURL.h:

(WebCore::KURL::innerURL):

5:15 PM Changeset in webkit [105949] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Marking svg/custom/object-sizing-explicit-width.xhtml and
storage/indexeddb/prefetch-bugfix-108071.html as flaky on Chromium.

  • platform/chromium/test_expectations.txt:
5:11 PM Changeset in webkit [105948] by dpranke@chromium.org
  • 5 edits in trunk/Tools

webkitpy: print nicer errors while linting expectations files, remove redundant tests
https://bugs.webkit.org/show_bug.cgi?id=76955

Reviewed by Adam Barth.

This change cleans up the errors that are printed so that the
are more "quickfix" compatible (path:lineno).

Also, there were a bunch of redundant tests between
layout_tests.models.test_expectations_unittest and
style.checkers.test_expectations_unittest. The latter should
just expect the former to do most of the testing.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser._parse_modifiers):
(TestExpectations._report_errors):
(TestExpectations._add_skipped_tests):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_parse_error_nonfatal):
(SemanticTests.test_bad_bugid):

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker.init):

  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase.assert_lines_lint):
(TestExpectationsTestCase.test_valid_expectations):
(TestExpectationsTestCase.test_invalid_expectations):
(TestExpectationsTestCase.test_tab):

5:09 PM Changeset in webkit [105947] by eric@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r105940.
http://trac.webkit.org/changeset/105940
https://bugs.webkit.org/show_bug.cgi?id=76095

Only half this change landed

  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
5:00 PM Changeset in webkit [105946] by leviw@chromium.org
  • 273 edits
    7 adds in branches/subpixellayout/LayoutTests

Updating test expectations.

4:54 PM Changeset in webkit [105945] by eric@webkit.org
  • 7 edits in trunk/Tools

webkit-patch apply-* should always continue after failures
https://bugs.webkit.org/show_bug.cgi?id=77057

Reviewed by Adam Barth.

As far as I can tell there is only one potential drawback to always
forcing: that if you're somehow in the wrong directory it will create new
directories for new files. Since webkit-patch always cd's to the root
it seems that's not a drawback. The drawback of not using --force for
svn-apply, is that it will stop after the first failure, which is rarely
(if ever) the desired behavior. This just removes the force option
(which was strangely hidden behind --non-interactive). This should
make for a better user experiance.

  • Scripts/webkitpy/common/checkout/checkout.py:

(Checkout.apply_patch):

  • Scripts/webkitpy/common/checkout/checkout_mock.py:

(MockCheckout.apply_patch):

  • Scripts/webkitpy/common/checkout/checkout_unittest.py:

(CheckoutTest.test_chromium_deps):
(CheckoutTest):
(CheckoutTest.test_apply_patch):

  • Scripts/webkitpy/tool/commands/download_unittest.py:

(DownloadCommandsTest._default_options):

  • Scripts/webkitpy/tool/steps/applypatch.py:

(ApplyPatch.options):
(ApplyPatch.run):

  • Scripts/webkitpy/tool/steps/options.py:

(Options):

4:52 PM Changeset in webkit [105944] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt: should be able to run --platform test interactively
https://bugs.webkit.org/show_bug.cgi?id=76959

Reviewed by Adam Barth.

As part of refactoring the Port interfaces, in r103254 I made
passing a Host object to the Port mandatory; previously TestPort
objects would create their own (mock) hosts. However,
new-run-webkit-tests always passed a real Host, not a MockHost,
and so you couldn't run new-run-webkit-tests --platform test
interactively to debug test failures.

This change fixes that by creating a MockHost instead of a real
host if you say --platform test*.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(main):

4:48 PM Changeset in webkit [105943] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Attempted Mac build fix after r105939.

  • runtime/DatePrototype.cpp: Don't #include unicode/udat.h on Mac or iOS.

It isn't used on these platforms and isn't available in the ICU headers
for Mac.

4:34 PM Changeset in webkit [105942] by mrowe@apple.com
  • 14 edits in trunk/Source

Build in to an alternate location when USE_STAGING_INSTALL_PATH is set.

<rdar://problem/10609417> Adopt USE_STAGING_INSTALL_PATH

Reviewed by David Kilzer.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig: Define NORMAL_JAVASCRIPTCORE_FRAMEWORKS_DIR, which contains

the path where JavaScriptCore is normally installed. Update JAVASCRIPTCORE_FRAMEWORKS_DIR
to point to the staged frameworks directory when USE_STAGING_INSTALL_PATH is set.

  • Configurations/JavaScriptCore.xcconfig: Always set the framework's install name based on

the normal framework location. This prevents an incorrect install name from being used when
installing in to the staged frameworks directory.

Source/ThirdParty:

  • gtest/xcode/Config/ProductionProject.xcconfig: Ensure that the staged frameworks path

is in the framework search path when USE_STAGING_INSTALL_PATH is set. Look for the WebCore
framework in the staged frameworks directory when USE_STAGING_INSTALL_PATH is set.

Source/WebCore:

  • Configurations/WebCore.xcconfig: Define NORMAL_WEBCORE_FRAMEWORKS_DIR, which contains

the path where WebCore is normally installed. Update WEBCORE_FRAMEWORKS_DIR to point to
the staged frameworks directory when USE_STAGING_INSTALL_PATH is set. Define
NORMAL_PRODUCTION_FRAMEWORKS_DIR, which contains the path where our public frameworks
are normally installed. Update PRODUCTION_FRAMEWORKS_DIR to point to the staged frameworks
directory when USE_STAGING_INSTALL_PATH is set. Always set the framework's install name
based on the normal framework location. This prevents an incorrect install name from being
used when installing in to the staged frameworks directory. Look for our other frameworks
in the staged frameworks directory when USE_STAGING_INSTALL_PATH is set.

Source/WebKit/mac:

  • Configurations/WebKit.xcconfig: Define NORMAL_WEBKIT_FRAMEWORKS_DIR, which contains

the path where WebKit is normally installed. Update WEBKIT_FRAMEWORKS_DIR to point to
the staged frameworks directory when USE_STAGING_INSTALL_PATH is set. Define
NORMAL_PRODUCTION_FRAMEWORKS_DIR, which contains the path where our public frameworks
are normally installed. Update PRODUCTION_FRAMEWORKS_DIR to point to the staged frameworks
directory when USE_STAGING_INSTALL_PATH is set. Always set the framework's install name
based on the normal framework location. This prevents an incorrect install name from being
used when installing in to the staged frameworks directory. Look for our other frameworks
in the staged frameworks directory when USE_STAGING_INSTALL_PATH is set. Update
WEBCORE_PRIVATE_HEADERS_DIR to find WebCore at the top level of the staged frameworks
directory when USE_STAGING_INSTALL_PATH is set, rather than finding it embedded inside of
WebKit.framework.

Source/WebKit2:

  • Configurations/BaseTarget.xcconfig: Define NORMAL_WEBKIT2_FRAMEWORKS_DIR, which contains

the path where WebKit is normally installed. Update WEBKIT2_FRAMEWORKS_DIR to point to
the staged frameworks directory when USE_STAGING_INSTALL_PATH is set. Update
UMBRELLA_FRAMEWORKS_DIR so we can find WebCore at the top level of the staged frameworks
directory when USE_STAGING_INSTALL_PATH is set, rather than finding it embedded inside of
WebKit.framework.

  • Configurations/PluginProcess.xcconfig: Set our install path based on WEBKIT2_FRAMEWORKS_DIR.
  • Configurations/WebKit2.xcconfig: Set our install path based on WEBKIT2_FRAMEWORKS_DIR.

Always set the framework's install name based on the normal framework location. This prevents
an incorrect install name from being used when installing in to the staged frameworks directory.

  • Configurations/WebProcess.xcconfig: Set our install path based on WEBKIT2_FRAMEWORKS_DIR.
4:27 PM Changeset in webkit [105941] by eric@webkit.org
  • 5 edits
    1 copy in trunk

"text" and "URL" legacy clipboard types should not be case sensitive
https://bugs.webkit.org/show_bug.cgi?id=76947

Reviewed by Adam Barth.

Source/WebCore:

This matches the HTML5 spec which says the first thing to do is to lowercase
the type before comparing.
I also removed the stripping of whitespace since that is not part of the modern spec (and no tests failed as a result of removal).
Turns out we already had a test for case sensitivity, but it was disabled on Mac
so I just re-enabled it and have added failing expectations for the parts
of the test we still fail.

  • platform/mac/ClipboardMac.mm:

(WebCore::cocoaTypeFromHTMLClipboardType):
(WebCore::ClipboardMac::getData):

LayoutTests:

This test has been disabled on Mac since it was added 2 years ago.
But we actually need to fix at least one of the bugs covered by this
test, so I'm unskipping it and adding failing expectations for the
parts Mac doens't yet pass.

  • platform/mac/Skipped:
  • platform/mac/editing/pasteboard/dataTransfer-setData-getData-expected.txt: Added.
4:17 PM Changeset in webkit [105940] by eric@webkit.org
  • 5 edits in trunk/Source

HTMLIsIndexElement should not expose HTMLInputElement properties
https://bugs.webkit.org/show_bug.cgi?id=76095

Reviewed by Adam Barth.

Source/WebCore:

document.createElement("isindex") should produce an HTMLUnknownElement
per the HTML5 spec. The parser automagically translates <isindex> into
a whole dom tree roughly representing what <isindex> used to do 15 years ago. :)

This patch just removes our support for HTMLIsIndexElement. The parser
support was already in. Having support for HTMLIsIndexElement was causing
one of the IE TestCenter tests to fail.

Test: fast/dom/HTMLIsIndexElement/prototype-chain.html

  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:
  • bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:

(WebKit::createHTMLElementWrapper):

  • bindings/objc/DOM.mm:

(WebCore::createElementClassMap):

  • bindings/objc/DOMHTML.h:
  • bindings/objc/PublicDOMInterfaces.h:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLIsIndexElement.cpp: Removed.
  • html/HTMLIsIndexElement.h: Removed.
  • html/HTMLIsIndexElement.idl: Removed.
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:

Source/WebKit/mac:

  • MigrateHeaders.make:
4:11 PM Changeset in webkit [105939] by efidler@rim.com
  • 2 edits in trunk/Source/JavaScriptCore

Implement Date.toLocaleString() using ICU
https://bugs.webkit.org/show_bug.cgi?id=76714

Reviewed by Darin Adler.

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):

4:00 PM Changeset in webkit [105938] by eric@webkit.org
  • 5 edits in trunk

HTMLEmbedObject should match HTMLObjectElement by stopping any load when it is removed from beforeload
https://bugs.webkit.org/show_bug.cgi?id=74360

Reviewed by Adam Barth.

Source/WebCore:

Neither of these !renderer() checks is strictly necessary since requestObject()
makes the same check. However requestObject() asserts before it makes that
check, so it makes sense to add the check to HTMLEmebedObject instead of
removing the check from HTMLObjectElement.
I also moved the protect RefPtr to before the beforeload dispatch since
beforeload can remove the whole DOM element (as this test does) and
thus I beleive the renderer() check could be checking free'd memory.

Updated fast/dom/beforeload/remove-flash-in-beforeload-listener.html to test
<embed> as well as <object>.

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget):

LayoutTests:

Test <embed> as well as <object> in this test.

  • fast/dom/beforeload/remove-flash-in-beforeload-listener.html:
3:56 PM Changeset in webkit [105937] by tkent@chromium.org
  • 8 edits in trunk/Source/WebCore

Move focus/blur handling code of HTMLInputElement to InputType
https://bugs.webkit.org/show_bug.cgi?id=76984

Reviewed by Dimitri Glazkov.

No new tests. Just a refactoring.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::handleFocusEvent):
Move the code to PasswordInputType::handleFocusEvent().
(WebCore::HTMLInputElement::handleBlurEvent):
Move the code to TextFieldInputType::handleBlurEvent() and
PasswordInputType::handleBlurEvent().

  • html/InputType.cpp:

(WebCore::InputType::handleFocusEvent):

  • html/InputType.h:

(InputType): Add handleFocusEvent().

  • html/PasswordInputType.cpp:

(WebCore::PasswordInputType::handleFocusEvent):
Move the code for type=password from HTMLInputElement::handleFocusEvent().
(WebCore::PasswordInputType::handleBlurEvent):
Move the code for tyep=password from HTMLInputElement::handleBlurEvent().

  • html/PasswordInputType.h:

(PasswordInputType): Add handleFocusEvent() and handleBlurEvent().

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::handleBlurEvent):
Move the code for text field types from HTMLInputElement::handleBlurEvent().

  • html/TextFieldInputType.h:

(TextFieldInputType): Add handleBlurEvent().

3:52 PM Changeset in webkit [105936] by dpranke@chromium.org
  • 4 edits in trunk/Tools

run-webkit-tests --lint-test-files should lint all the ports by default
https://bugs.webkit.org/show_bug.cgi?id=76749

Reviewed by Ojan Vafai.

Currently run-webkit-tests --lint-test-files will only lint the
test_expectations for the single port determined by the command
line options. This is not obvious and can produce unintended results
if you want to lint the chromium port (probably the normal case
for using --lint-test-files) but don't specify a port name or
--chromium.

I think we should probably lint *all* of the ports if no port
name is supplied. This change implements that, and also moves
the linting logic out of the Manager class, since this really
has nothing to do with Managers. It has little to do with
run-webkit-tests, but splitting it into a different script would
introduce compatibility issues. It might make sense to do that
anyway, in a separate patch and combining that with cleaning up
the style checker to share more code.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._strip_test_dir_prefix):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(lint):
(run):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(LintTest.test_all_configurations): added.
(LintTest.test_lint_test_files): added.
(LintTest.test_lint_test_fileserrors): added.
(MainTest.test_lint_test_files): removed.
(MainTest.test_lint_test_files
errors): removed.

3:46 PM Changeset in webkit [105935] by dpranke@chromium.org
  • 7 edits in trunk/Tools

webkitpy: clean up a bunch of test scaffolding
https://bugs.webkit.org/show_bug.cgi?id=76973

Reviewed by Eric Seidel.

There were several helper modules in the webkitpy.test package
that appear to only be used by executive_unittest.py. I am
rolling them all into that file to make that clearer.

  • Scripts/webkitpy/common/system/executive_unittest.py:

(ExecutiveTest.test_run_command_args_type):
(ExecutiveTest.test_run_command_with_unicode):
(ExecutiveTest.test_running_pids):
(command_line):
(main):

  • Scripts/webkitpy/common/system/fileutils.py: Removed.
  • Scripts/webkitpy/test/cat.py: Removed.
  • Scripts/webkitpy/test/cat_unittest.py: Removed.
  • Scripts/webkitpy/test/echo.py: Removed.
  • Scripts/webkitpy/test/echo_unittest.py: Removed.
3:40 PM Changeset in webkit [105934] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebKit2

[WK2][Qt] REGRESSION: Pages with transform animations sometimes omit some of the layers since r105413
https://bugs.webkit.org/show_bug.cgi?id=76886

Reviewed by Kenneth Rohde Christiansen.

We now render the whole layer if it or one if its ancestors has an active transform
animations. It's possible to optimize further in the future, but not currently necessary.
Also, we make sure that when a WebGraphicsLayer's property that affects transformation is
changed, all its descandants layers are marked as modified so that we re-adjust their
visible rect in the next pass.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::notifyChangeRecursively):
(WebCore):
(WebCore::WebGraphicsLayer::setPosition):
(WebCore::WebGraphicsLayer::setAnchorPoint):
(WebCore::WebGraphicsLayer::setSize):
(WebCore::WebGraphicsLayer::setTransform):
(WebCore::WebGraphicsLayer::setChildrenTransform):
(WebCore::WebGraphicsLayer::setPreserves3D):
(WebCore::WebGraphicsLayer::setMasksToBounds):
(WebCore::WebGraphicsLayer::addAnimation):
(WebCore::WebGraphicsLayer::removeAnimation):
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::WebGraphicsLayer::selfOrAncestorHasActiveTransformAnimations):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayer):

3:31 PM Changeset in webkit [105933] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Node.cpp shouldn't duplicate QualifiedName parsing logic
https://bugs.webkit.org/show_bug.cgi?id=76672

Reviewed by Eric Seidel.

I added this code out of ignorance that this logic already existed in
Document.cpp. In a future patch, we should consider moving it to
QualifiedName.cpp.

  • dom/Node.cpp:

(WebCore):
(WebCore::Node::checkSetPrefix):

3:29 PM Changeset in webkit [105932] by eric@webkit.org
  • 5 edits in trunk/Source/WebCore

Share more code between updateWidget implementations in HTMLEmbedElement and HTMLObjectElement
https://bugs.webkit.org/show_bug.cgi?id=74340

Reviewed by Adam Barth.

I'm preparing to unify these two methods, and starting by sharing more code between them.

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget):

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::guardedDispatchBeforeLoadEvent):

  • html/HTMLPlugInElement.h:
3:11 PM Changeset in webkit [105931] by eric@webkit.org
  • 2 edits in trunk/Tools

Remove Python 2.5 support from WebKit
https://bugs.webkit.org/show_bug.cgi?id=71593

Reviewed by Adam Barth.

Just removing support from this one core file.
I'll commit the rest of the (large) change once we've
gone 24 hours and seen that no bots have exploded.
We can roll out this one change if we break bots
and then roll in the rest once those bots are fixed.

  • Scripts/webkitpy/common/system/executive.py:

(Executive.cpu_count):

2:43 PM Changeset in webkit [105930] by ericu@chromium.org
  • 8 edits in trunk/Source

Add full support for filesystem URLs.
https://bugs.webkit.org/show_bug.cgi?id=75049

Reviewed by Adam Barth.

No new tests; existing layout tests cover the basic functionality, and
the new functionality won't be there until Chromium adds it. This patch
merely enables that, without changing behavior.

Source/WebCore:

  • fileapi/EntryBase.cpp:

(WebCore::EntryBase::toURL): Add missing escaping of URL path.

  • page/SecurityOrigin.cpp:

(WebCore::extractInnerURL): Use innerURL member, if it's populated.

  • platform/KURL.h:

(WebCore::KURL::innerURL): Add innerURL member.

  • platform/KURLGoogle.cpp:

(WebCore::KURLGooglePrivate::KURLGooglePrivate):
(WebCore::KURLGooglePrivate::operator=):
Add copy constructor and operator=, which are now needed since
m_innerURL needs special handling.
(WebCore::KURLGooglePrivate::setUtf8):
(WebCore::KURLGooglePrivate::setAscii):
Add calls to initInnerURL.
(WebCore::KURLGooglePrivate::initInnerURL):
Add method to init/copy m_innerURL.
(WebCore::KURLGooglePrivate::copyTo):
Handle m_innerURL during copies.
(WebCore::encodeWithURLEscapeSequences):
Unescape %2F / in paths; it's much more readable, and it's safe.

  • platform/KURLGooglePrivate.h:

(WebCore::KURLGooglePrivate::innerURL): Add accessor for new m_innerURL.

Source/WebKit/chromium:

  • tests/KURLTest.cpp:

TEST(KURLTest, Encode): Update expectation that '/' sails through unescaped.

2:40 PM Changeset in webkit [105929] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test fast/canvas/webgl/invalid-passed-params.html is failing
https://bugs.webkit.org/show_bug.cgi?id=75784

Reviewed by Kenneth Russell.

Passing on ToT chromium.org, webkit.org (GPU and non-GPU), rebaseline this test.

  • platform/chromium/test_expectations.txt:
2:33 PM Changeset in webkit [105928] by dcheng@chromium.org
  • 4 edits in trunk/Source/WebCore

[chromium] Refactor Clipboard invalidate for DataTransferItem/DataTransferItemList into a wrapper
https://bugs.webkit.org/show_bug.cgi?id=76993

We want to unify the backing data store for ClipboardChromium and DataTransferItems. For
that, we want use a similar representation to DataTransferItem list inside
ChromiumDataObject. However, since ChromiumDataObject should be valid in scopes where
Clipboard is not (e.g. default drag processing), we need to separate the clipboard
invalidation logic into a wrapper class.

Reviewed by Tony Chang.

Covered by existing tests.

  • platform/chromium/ClipboardChromium.cpp:

():
(WebCore::ClipboardChromium::items):

  • platform/chromium/DataTransferItemChromium.cpp:

(WebCore::DataTransferItemChromium::getAsString):

  • platform/chromium/DataTransferItemListChromium.cpp:

(WebCore::DataTransferItemListChromium::length):
(WebCore::DataTransferItemListChromium::item):
(WebCore::DataTransferItemListChromium::deleteItem):
(WebCore::DataTransferItemListChromium::clear):
(WebCore::DataTransferItemListChromium::add):

2:29 PM Changeset in webkit [105927] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

Build fix for qt

2:25 PM Changeset in webkit [105926] by rniwa@webkit.org
  • 3 edits in trunk/PerformanceTests

html5-full-render.html fails due to a log
https://bugs.webkit.org/show_bug.cgi?id=77046

Reviewed by Adam Barth.

Replace the call to log() in html5-full-render.html by a call to newly added logInfo(),
which doesn't print anything inside DRT.

  • Parser/html5-full-render.html:
  • resources/runner.js:

(logInfo):

2:13 PM Changeset in webkit [105925] by noam.rosenthal@nokia.com
  • 8 edits
    2 adds in trunk/Source/WebCore

[Texmap] Divide TextureMapperNode.cpp to 3 files.
https://bugs.webkit.org/show_bug.cgi?id=76660

Reviewed by Kenneth Rohde Christiansen.

Split the animation part of TextureMapperNode out to a separate file, called
TextureMapperAnimation.
Provide a clean interface for that class, that allows separating the internals of the scene
painting from the internals of the animation interpolation.

No new tests. Existing animation tests cover this.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::addAnimation):
(WebCore::GraphicsLayerTextureMapper::pauseAnimation):
(WebCore::GraphicsLayerTextureMapper::removeAnimation):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncCompositingStateSelf):
(WebCore::TextureMapperNode::descendantsOrSelfHaveRunningAnimations):
(WebCore::TextureMapperNode::syncAnimations):
(WebCore::TextureMapperNode::syncAnimationsRecursively):
(WebCore::TextureMapperNode::syncCompositingState):

  • platform/graphics/texmap/TextureMapperNode.h:

(TextureMapperNode):

2:11 PM Changeset in webkit [105924] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test http/tests/workers/terminate-during-sync-operation.html times out frequently on Win DBG
https://bugs.webkit.org/show_bug.cgi?id=77047

Unreviewed. Marking http/tests/workers/terminate-during-sync-operation.html as flaky (timeout) on Chromium Win DBG

  • platform/chromium/test_expectations.txt:
2:00 PM Changeset in webkit [105923] by knorton@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed expectation update after r105613.

  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
1:46 PM Changeset in webkit [105922] by commit-queue@webkit.org
  • 27 edits in trunk

ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
https://bugs.webkit.org/show_bug.cgi?id=76863

.:

Patch by Hajime Morita <morrita@google.com>> on 2012-01-25
Reviewed by Dimitri Glazkov.

Added a feature flag.

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • configure.ac:

Source/JavaScriptCore:

Patch by Hajime Morita <morrita@google.com> on 2012-01-25
Reviewed by Dimitri Glazkov.

Added a feature flag.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Patch by Hajime Morita <morrita@google.com> on 2012-01-25
Reviewed by Dimitri Glazkov.

Added a feature flag.

No tests, it's a behid flag configuration change.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Patch by Hajime Morita <morrita@google.com> on 2012-01-25
Reviewed by Dimitri Glazkov.

Added a feature flag.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Patch by Hajime Morita <morrita@google.com> on 2012-01-25
Reviewed by Dimitri Glazkov.

Added a feature flag.

  • Configurations/FeatureDefines.xcconfig:

Tools:

Patch by Hajime Morita <morrita@google.com> on 2012-01-25
Reviewed by Dimitri Glazkov.

Added a feature flag.

  • Scripts/build-webkit:
  • qmake/mkspecs/features/features.prf:

WebKitLibraries:

Patch by Hajime Morita <morrita@google.com>> on 2012-01-25
Reviewed by Dimitri Glazkov.

Added a feature flag.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
1:09 PM Changeset in webkit [105921] by leviw@chromium.org
  • 1 edit
    7 adds
    2 deletes in trunk/LayoutTests

[Chromium]: rebaseline after r105878
https://bugs.webkit.org/show_bug.cgi?id=77017

Unreviewed Chromium image expectations update.

Not updating test_expectations because I am not sure that the rebaselining tool did
the right thing.

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-25

  • platform/chromium-linux-x86/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
  • platform/chromium-linux/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
  • platform/chromium-linux/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
  • platform/chromium-linux/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/custom/zero-path-square-cap-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
  • platform/chromium-mac/svg/custom/zero-path-square-cap-rendering-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering-expected.png: Added.
  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
  • platform/chromium-win/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
  • platform/chromium-win/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
  • platform/chromium/svg/custom/subpaths-moveto-only-rendering-expected.txt: Added.
1:06 PM Changeset in webkit [105920] by leviw@chromium.org
  • 6 edits in trunk

Unreviewed, rolling out r105906.
http://trac.webkit.org/changeset/105906
https://bugs.webkit.org/show_bug.cgi?id=77038

Breaks compositing/visibility/layer-visible-content.html and
compositing/visibility/visibility-image-layers-dynamic.html
(Requested by leviw|gardening on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-25

Source/WebCore:

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

LayoutTests:

  • compositing/visibility/layer-visible-content-expected.txt:
  • compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • platform/chromium/test_expectations.txt:
12:57 PM Changeset in webkit [105919] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Page Up and Page Down mappings are backwards on BlackBerry port.
https://bugs.webkit.org/show_bug.cgi?id=77021

Fix Page Up and Page Down mappings as they are reversed.

Patch by Mike Fenton <mifenton@rim.com> on 2012-01-25
Reviewed by Antonio Gomes.

  • platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:

(WebCore::keyIdentifierForBlackBerryCharacter):
(WebCore::windowsKeyCodeForBlackBerryCharacter):

12:52 PM Changeset in webkit [105918] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[BlackBerry] Implement OSAllocator::commit/decommit.
BlackBerry port should support virtual memory decommiting.
https://bugs.webkit.org/show_bug.cgi?id=77013

Patch by Yong Li <yoli@rim.com> on 2012-01-25
Reviewed by Rob Buis.

  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):

  • wtf/Platform.h:
12:47 PM Changeset in webkit [105917] by morrita@google.com
  • 19 edits
    5 adds in trunk

<content> should create HTMLContentElement object
https://bugs.webkit.org/show_bug.cgi?id=76439

Reviewed by Dimitri Glazkov.

Source/WebCore:

  • Added HTMLContentElement.idl which has @select attribute.
  • Added "content" element.

Both are behind ENABLE_SHADOW_DOM.

Tests: fast/dom/shadow/content-element-api.html

fast/dom/shadow/content-element-outside-shadow.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLTagNames.in:
  • html/shadow/HTMLContentElement.cpp:

(WebCore::contentTagName):
(WebCore):
(WebCore::HTMLContentElement::create):

  • html/shadow/HTMLContentElement.h:

(HTMLContentElement):

  • html/shadow/HTMLContentElement.idl: Added.

LayoutTests:

Ensure that contnet elements are renderered not only inside the shadow tree
but also the outside that.

  • fast/dom/shadow/content-element-api-expected.txt: Added.
  • fast/dom/shadow/content-element-api.html: Added.
  • fast/dom/shadow/content-element-outside-shadow-expected.txt: Added.
  • fast/dom/shadow/content-element-outside-shadow.html: Added.
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/Skipped:
12:37 PM Changeset in webkit [105916] by Martin Robinson
  • 4 edits in trunk

[WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions
https://bugs.webkit.org/show_bug.cgi?id=76344

Reviewed by Sam Weinig.

Source/WebKit2:

When creating InjectedBundleNavigationActions, initialize the mouse button to NoButton.
This ensures that when there is no mouse event associated with the action, when the event
hits the client-API layer, the button is still NoButton.

  • WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:

(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction): Initialize m_mouseButton
to WebMouseEvent::NoButton.

Tools:

Add a test verifying that the mouse button during policy decisions for
events not triggered by mouse events is NoButton.

  • TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:

(TestWebKitAPI::decidePolicyForNavigationAction): Added test.
(TestWebKitAPI::decidePolicyForNewWindowAction): Added test.

12:29 PM Changeset in webkit [105915] by rniwa@webkit.org
  • 3 edits in trunk/Tools

run-perf-tests should timeout sooner
https://bugs.webkit.org/show_bug.cgi?id=77026

Reviewed by Adam Barth.

Bump off the timeout from 10 minutes to 4 minutes.

Also use float instead of str in test result values to compress the size of json files bots upload.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):
(PerfTestsRunner._process_chromium_style_test_result):
(PerfTestsRunner._process_parser_test_result):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_run_test_set_for_parser_tests):
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):

12:28 PM Changeset in webkit [105914] by eae@chromium.org
  • 20 edits
    1 delete in branches/subpixellayout/Source

Revert unwanted changes against trunk caused by incorrect merge conflict resolution.

12:27 PM Changeset in webkit [105913] by kareng@chromium.org
  • 1 add in branches/chromium/1018/codereview.settings

adding codereview.settings

12:22 PM Changeset in webkit [105912] by kareng@chromium.org
  • 1 copy in branches/chromium/1018

testing branching for chrome.

12:21 PM Changeset in webkit [105911] by rniwa@webkit.org
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r105828.
http://trac.webkit.org/changeset/105828
https://bugs.webkit.org/show_bug.cgi?id=77036

Caused many crashes in ClusterFuzz and PerformanceTests
(Requested by inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-25

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):

  • rendering/RenderBlock.h:

(RenderBlock):

LayoutTests:

  • fast/css-generated-content/float-first-letter-siblings-convert-to-inline-expected.txt: Removed.
  • fast/css-generated-content/float-first-letter-siblings-convert-to-inline.html: Removed.
12:21 PM Changeset in webkit [105910] by kareng@chromium.org
  • 1 copy in branches/1018

testing ability to branch for chrome

12:13 PM Changeset in webkit [105909] by kerz@chromium.org
  • 376 edits
    454 copies in branches/chromium/963/LayoutTests/platform

Merge 103884 - [Chromium] Unreviewed test expectations update after r103875.
https://bugs.webkit.org/show_bug.cgi?id=74888

  • platform/chromium-cg-mac-leopard/fast/dom/HTMLTableElement/colSpan-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/dom/HTMLTableElement/createCaption-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug1163-1-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug119786-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug1302-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug222846-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug29058-3-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug48028-1-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug48028-2-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug5838-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug6304-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug8381-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/core/captions-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_position-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_simple-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/table_frame_border-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/table_frame_box-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/table_rules_all-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/tables_caption_align_bot-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/tables_caption_align_top-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/x_caption_align_bottom-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/x_caption_align_top-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/x_caption_class-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/x_caption_id-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/x_caption_style-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug10140-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug10216-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug104898-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug106966-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug91057-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/core/captions3-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/caption-width-absolute-position-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/caption-width-absolute-position-offset-top-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/caption-width-fixed-position-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/caption-width-fixed-position-offset-top-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/caption-width-relative-position-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/caption-width-relative-position-offset-top-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/dom/HTMLTableElement/colSpan-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/dom/HTMLTableElement/colSpan-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/dom/HTMLTableElement/createCaption-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/dom/HTMLTableElement/createCaption-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/frame-and-rules-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug1163-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug1163-1-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug119786-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug119786-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug1302-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug1302-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug222846-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug222846-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug29058-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug29058-3-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug29157-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug48028-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug48028-1-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug48028-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug48028-2-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug5838-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug5838-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug6304-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug6304-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug8381-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug8381-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/core/captions-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/core/captions-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_layers-opacity-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_position-table-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_position-table-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_frame_border-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_frame_border-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_frame_box-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_frame_box-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_bot-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_bot-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_top-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_top-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_align_bottom-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_align_bottom-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_align_top-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_align_top-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_class-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_class-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_id-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_id-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_style-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_style-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10140-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10140-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10216-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10216-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug104898-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug104898-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug106966-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug106966-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-3-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-4-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug91057-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug91057-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/core/captions3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/core/captions3-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.txt: Added.
  • platform/chromium-linux/fast/dom/HTMLTableElement/colSpan-expected.png:
  • platform/chromium-linux/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1163-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug119786-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1302-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug222846-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug29058-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug48028-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug48028-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug5838-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug6304-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug8381-expected.png:
  • platform/chromium-linux/tables/mozilla/core/captions-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_frame_border-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_frame_box-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_caption_align_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_align_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_style-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-leopard/fast/dom/HTMLTableElement/colSpan-expected.png:
  • platform/chromium-mac-leopard/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1163-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug119786-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1302-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug222846-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug29058-3-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug48028-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug48028-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug5838-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug6304-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug8381-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/core/captions-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/table_frame_border-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/table_frame_box-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tables_caption_align_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_caption_align_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_caption_class-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_caption_id-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_caption_style-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/caption-width-absolute-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/caption-width-absolute-position-offset-top-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/caption-width-fixed-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/caption-width-fixed-position-offset-top-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/caption-width-relative-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/caption-width-relative-position-offset-top-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTableElement/colSpan-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTableElement/colSpan-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTableElement/createCaption-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTableElement/createCaption-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/table/frame-and-rules-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1163-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1163-1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug119786-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug119786-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1302-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1302-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug222846-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug222846-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug29058-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug29058-3-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug29157-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug48028-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug48028-1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug48028-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug48028-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug5838-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug5838-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug6304-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug6304-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug8381-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug8381-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/captions-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/captions-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_layers-opacity-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_position-table-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_position-table-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_frame_border-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_frame_border-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_frame_box-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_frame_box-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_bot-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_bot-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_top-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_top-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_align_bottom-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_align_bottom-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_align_top-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_align_top-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_class-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_class-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_id-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_id-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_style-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_style-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10140-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10140-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10216-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10216-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug104898-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug104898-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug106966-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug106966-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-3-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-4-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug91057-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug91057-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/core/captions3-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/core/captions3-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.txt: Added.
  • platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/chromium-win/fast/css/caption-width-absolute-position-expected.png: Added.
  • platform/chromium-win/fast/css/caption-width-absolute-position-offset-top-expected.png: Added.
  • platform/chromium-win/fast/css/caption-width-fixed-position-expected.png: Added.
  • platform/chromium-win/fast/css/caption-width-fixed-position-offset-top-expected.png: Added.
  • platform/chromium-win/fast/css/caption-width-relative-position-expected.png: Added.
  • platform/chromium-win/fast/css/caption-width-relative-position-offset-top-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLTableElement/colSpan-expected.png:
  • platform/chromium-win/fast/dom/HTMLTableElement/colSpan-expected.txt:
  • platform/chromium-win/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/chromium-win/fast/dom/HTMLTableElement/createCaption-expected.txt:
  • platform/chromium-win/fast/repaint/table-section-repaint-expected.txt: Added.
  • platform/chromium-win/fast/table/frame-and-rules-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1163-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1163-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug119786-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug119786-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1302-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1302-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug222846-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug222846-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug29058-3-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug29058-3-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug29157-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug48028-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug48028-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug48028-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug48028-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug5838-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug5838-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug6304-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug6304-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug8381-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug8381-expected.txt:
  • platform/chromium-win/tables/mozilla/core/captions-expected.png:
  • platform/chromium-win/tables/mozilla/core/captions-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_position-table-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/table_frame_border-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_frame_border-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/table_frame_box-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_frame_box-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_all-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_none-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_caption_align_bot-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/tables_caption_align_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_caption_align_top-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_top-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_class-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_id-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_style-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_style-expected.txt:
  • platform/chromium-win/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • platform/chromium-win/tables/mozilla/other/wa_table_tr_align-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-3-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-4-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions3-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.txt:
  • platform/chromium/test_expectations.txt:

TBR=mnaganov@chromium.org

12:07 PM Changeset in webkit [105908] by enrica@apple.com
  • 5 edits in trunk

WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
https://bugs.webkit.org/show_bug.cgi?id=76951
<rdar://problem/9325158>

Reviewed by Alexey Proskuryakov.

Source/WebKit/mac:

  • WebView/WebHTMLView.mm: Removed typingAttributes implementation.
  • WebView/WebView.mm:

(-[WebView typingAttributes]): Added.

Tools:

  • TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView

and WebHTMLView.
(TestWebKitAPI::TEST):

12:03 PM Changeset in webkit [105907] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

This test is actually flaky by timing out, not by failing.

  • platform/chromium/test_expectations.txt:
11:53 AM Changeset in webkit [105906] by shawnsingh@chromium.org
  • 6 edits in trunk

Fix the semantics of passing contentsVisible flag to GraphicsLayers
https://bugs.webkit.org/show_bug.cgi?id=76975

Reviewed by Simon Fraser.

Source/WebCore:

This patch is covered by existing tests, in particular
compositing/visibility/layer-visible-content.html; its
expectations are rebaselined.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

LayoutTests:

  • compositing/visibility/layer-visible-content-expected.txt: rebaselined expectations.
  • compositing/visibility/visibility-image-layers-dynamic-expected.txt: rebaselined expectations.
  • platform/chromium/test_expectations.txt: removed the expectation that the test fails on chromium, it should pass now.
11:43 AM Changeset in webkit [105905] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Make DFG update topCallFrame
https://bugs.webkit.org/show_bug.cgi?id=76969

Reviewed by Filip Pizlo.

Add NativeCallFrameTracer to manage topCallFrame assignment
in the DFG operations, and make use of it.

  • dfg/DFGOperations.cpp:

(JSC::DFG::operationPutByValInternal):
():

  • interpreter/Interpreter.h:

(JSC):
(NativeCallFrameTracer):
(JSC::NativeCallFrameTracer::NativeCallFrameTracer):

11:42 AM Changeset in webkit [105904] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed test fix to followup r105900.

  • compositing/overflow/overflow-scaled-descendant-overlapping.html:
11:27 AM Changeset in webkit [105903] by tony@chromium.org
  • 6 edits
    2 adds in trunk

support overflow:auto and overflow:scroll in new flexbox
https://bugs.webkit.org/show_bug.cgi?id=76953

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/flexbox-overflow-auto-expected.html

css3/flexbox/flexbox-overflow-auto.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::addLayoutOverflow): In the case of reverse flexboxen, we can overflow up or to the left (like horizontal-bt or rtl content).

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock): Call updateScrollInfoAfterLayout() to add overflow scrollbars.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): In row-reverse, offset the start of the content by the scrollbar.
(WebCore::RenderFlexibleBox::layoutColumnReverse): In column-reverse, offset the start of the content by the scrollbar.

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox): Make isHorizontalFlow public.

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::isReverseFlexDirection): Convenience method.

LayoutTests:

  • css3/flexbox/flexbox-overflow-auto-expected.html: Added.
  • css3/flexbox/flexbox-overflow-auto.html: Added.
11:13 AM Changeset in webkit [105902] by leviw@chromium.org
  • 6 edits
    2 deletes in trunk

Unreviewed, rolling out r105885.
http://trac.webkit.org/changeset/105885
https://bugs.webkit.org/show_bug.cgi?id=77027

Causes assertions in Position. (Requested by leviw|gardening
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-25

Source/WebCore:

  • dom/Position.cpp:

(WebCore::Position::upstream):
(WebCore::Position::downstream):

  • dom/PositionIterator.cpp:
  • dom/PositionIterator.h:

(PositionIterator):

  • editing/htmlediting.cpp:

(WebCore::nextCandidate):
(WebCore::nextVisuallyDistinctCandidate):
(WebCore::previousCandidate):
(WebCore::previousVisuallyDistinctCandidate):

LayoutTests:

  • perf/selection-skip-hidden-node-expected.txt: Removed.
  • perf/selection-skip-hidden-node.html: Removed.
11:11 AM Changeset in webkit [105901] by alexis.menard@openbossa.org
  • 9 edits
    2 adds in trunk

border-image should be implemented like a shorthand.
https://bugs.webkit.org/show_bug.cgi?id=76697

Reviewed by Tony Chang.

Source/WebCore:

Make sure that border-image is implemented like a shorthand : when we parse
it we set the correct value to its longhands. The code was not doing it
previously as we inherited the old implementation of -webkit-border-image which
is not a shorthand but a regular property. It will then increase
style.length for a given element as we now expand the longhands.
The behavior stays the same for -webkit-border-image.

Test: fast/css/border-image-style-length.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::commitWebKitBorderImage):
(WebCore::BorderImageParseContext::commitBorderImage):
(BorderImageParseContext):
(WebCore::BorderImageParseContext::commitBorderImageProperty):
(WebCore::CSSParser::parseBorderImage):

  • css/CSSParser.h:

():

  • css/CSSPropertyLonghand.cpp:

(WebCore::initShorthandMap):

  • css/CSSStyleApplyProperty.cpp:

():
(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::mapNinePieceImage):

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::ensurePropertyMap):
(WebCore::addShorthandProperties):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::borderImageSlices):
(WebCore::RenderStyleBitfields::borderImageWidth):
(WebCore::RenderStyleBitfields::borderImageOutset):
(RenderStyleBitfields):
(WebCore::RenderStyleBitfields::setBorderImageSlices):
(WebCore::RenderStyleBitfields::setBorderImageWidth):
(WebCore::RenderStyleBitfields::setBorderImageOutset):

LayoutTests:

Make sure we cover that border-image correctly expands its longhands.

  • fast/css/border-image-style-length-expected.txt: Added.
  • fast/css/border-image-style-length.html: Added.
11:04 AM Changeset in webkit [105900] by morrita@google.com
  • 66 edits
    3 adds in trunk

[Refactoring][Internals] Should have InternalSettings
https://bugs.webkit.org/show_bug.cgi?id=76424

Source/WebCore:

Reviewed by Kent Tamura.

This change extracted setting related method from window.internals
to window.internals.settings object.

  • Invoked Internals::reset() in the constructor to employ Document object.
  • Moved setting and configuration related Internals methods to newly introduced InternalSettings object.

No new tests, covered by existing tests.

  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCoreTestSupport.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • testing/InternalSettings.cpp: Added.

(WebCore::InternalSettings::create):
(WebCore::InternalSettings::~InternalSettings):
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::settings):
(WebCore::InternalSettings::document):
(WebCore::InternalSettings::page):
(WebCore::InternalSettings::setInspectorResourcesDataSizeLimits):
(WebCore::InternalSettings::setForceCompositingMode):
(WebCore::InternalSettings::setAcceleratedFiltersEnabled):
(WebCore::InternalSettings::setEnableCompositingForFixedPosition):
(WebCore::InternalSettings::setEnableCompositingForScrollableFrames):
(WebCore::InternalSettings::setAcceleratedDrawingEnabled):
(WebCore::InternalSettings::setEnableScrollAnimator):
(WebCore::InternalSettings::setZoomAnimatorTransform):
(WebCore::InternalSettings::setZoomParameters):
(WebCore::InternalSettings::setMockScrollbarsEnabled):
(WebCore::InternalSettings::setPasswordEchoEnabled):
(WebCore::InternalSettings::setPasswordEchoDurationInSeconds):
(WebCore::InternalSettings::setShouldLayoutFixedElementsRelativeToFrame):
(WebCore::InternalSettings::setUnifiedTextCheckingEnabled):
(WebCore::InternalSettings::unifiedTextCheckingEnabled):
(WebCore::InternalSettings::pageScaleFactor):
(WebCore::InternalSettings::setPageScaleFactor):
(WebCore::InternalSettings::setPerTileDrawingEnabled):

  • testing/InternalSettings.h: Added.
  • testing/InternalSettings.idl: Added.
  • testing/Internals.cpp:

(WebCore::Internals::create):
(WebCore::Internals::Internals):
(WebCore::Internals::reset):

  • testing/Internals.h:

(WebCore::Internals::settings):

  • testing/Internals.idl:
  • testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::injectInternalsObject):

  • testing/v8/WebCoreTestSupport.cpp:

(WebCoreTestSupport::injectInternalsObject):

Tools:

Reviewed by Kent Tamura.

  • GNUmakefile.am: Added so new files.

LayoutTests:

Updated to follow API receiver change.

Reviewed by Kent Tamura.

  • compositing/geometry/fixed-position-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-composited-page-scale.html:
  • compositing/geometry/fixed-position-composited-switch.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale.html:
  • compositing/iframes/resources/scrollgrandchild-inner.html:
  • compositing/resources/mock_scrollbars.js:
  • compositing/scaling/tiled-layer-recursion.html:
  • editing/input/resources/password-echo.js:

(init):

  • editing/spelling/spellcheck-async-mutation.html:
  • editing/spelling/spellcheck-async.html:
  • editing/spelling/spelling-unified-emulation.html:
  • fast/dom/Element/scale-page-bounding-client-rect.html:
  • fast/dom/Element/scale-page-client-rects.html:
  • fast/dom/Range/scale-page-bounding-client-rect.html:
  • fast/dom/Range/scale-page-client-rects.html:
  • fast/dom/iframe-inner-size-scaling.html:
  • fast/dom/window-inner-size-scaling.html:
  • fast/events/scale-and-scroll-body.html:
  • fast/events/scale-and-scroll-iframe-body.html:
  • fast/events/scale-and-scroll-iframe-window.html:
  • fast/events/scale-and-scroll-window.html:
  • fast/events/script-tests/page-scaled-mouse-click-iframe.js:

(iframeLoaded):

  • fast/events/script-tests/page-scaled-mouse-click.js:
  • fast/events/scroll-in-scaled-page-with-overflow-hidden.html:
  • fast/events/touch/page-scaled-touch-gesture-click.html:
  • fast/frames/frame-set-rotation-hit.html:
  • fast/frames/frame-set-scaling-hit.html:
  • fast/frames/iframe-double-scale-contents.html:
  • fast/repaint/background-scaling.html:
  • fast/repaint/fixed-in-page-scale.html:
  • fast/repaint/fixed-right-bottom-in-page-scale.html:
  • fast/repaint/fixed-right-in-page-scale.html:
  • fast/repaint/scale-page-shrink.html:
  • fast/transforms/selection-bounds-in-transformed-view.html:
  • http/tests/inspector/network-test.js:

(resetInspectorResourcesData):

  • http/tests/inspector/network/network-content-replacement-embed.html:
  • http/tests/inspector/network/network-content-replacement-xhr.html:
  • platform/chromium/compositing/accelerated-drawing/alpha.html:
  • platform/chromium/compositing/accelerated-drawing/svg-filters.html:
  • platform/chromium/compositing/force-compositing-mode/force-composite-empty.html:
  • platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html:
10:55 AM Changeset in webkit [105899] by toyoshim@chromium.org
  • 2 edits in trunk/Tools

webkitpy: new-run-webkit-websocket is broken
https://bugs.webkit.org/show_bug.cgi?id=76999

Reviewed by Dirk Pranke.

r105674 broke new-run-webkit-websocket, since options.chromium
doesn't exist any more. new-run-webkit-httpd was also broken
and already fixed at r105835.

  • Scripts/new-run-webkit-websocketserver:

(main):

10:54 AM Changeset in webkit [105898] by alexis.menard@openbossa.org
  • 4 edits
    2 adds in trunk

border-image should not crash when the source is not specified.
https://bugs.webkit.org/show_bug.cgi?id=77001

Reviewed by Andreas Kling.

Source/WebCore:

This bug was introduced by r105502 but was exposed by r105738.
The image-source of a border-image is not mandatory therefore it
may happen that you have no value set for it. WebCore::createBorderImageValue
was wrongly assuming that the image is always set. This problem also required a bit
of refactoring in CSSStyleSelector::mapNinePieceImage to take into account that
the image could be optional (just like other properties).

Test: fast/css/border-image-null-image-crash.html

  • css/CSSBorderImage.cpp:

(WebCore::createBorderImageValue):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::mapNinePieceImage):

LayoutTests:

Add a new test to cover this crash specifically.

  • fast/css/border-image-null-image-crash-expected.txt: Added.
  • fast/css/border-image-null-image-crash.html: Added.
10:38 AM Changeset in webkit [105897] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt] public.pri is missing dependency to quick module.
https://bugs.webkit.org/show_bug.cgi?id=77016

Patch by Zeno Albisser <zeno@webkit.org> on 2012-01-25
Reviewed by Tor Arne Vestbø.

  • declarative/public.pri:
10:34 AM Changeset in webkit [105896] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, only skip scrollbars/scroll-rtl-or-bt-layer.html on qt-wk2.
eventSender.mouseScrollBy is implemented on GTK+ and Mac.

  • platform/qt-wk2/Skipped:
  • platform/wk2/Skipped:
10:31 AM Changeset in webkit [105895] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium]: rebaseline after r105878
https://bugs.webkit.org/show_bug.cgi?id=77017

Unreviewed Chromium test expectations update to allow more failure modes.

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-25

  • platform/chromium/test_expectations.txt:
10:27 AM Changeset in webkit [105894] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

Inlining breaks call frame walking when the walking is done from outside the inlinee,
but inside a code block that had inlining
https://bugs.webkit.org/show_bug.cgi?id=76978
<rdar://problem/10720904>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::codeOriginForReturn):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::trueCallerFrame):

LayoutTests:

  • fast/js/dfg-inline-arguments-use-from-uninlined-code-expected.txt: Added.
  • fast/js/dfg-inline-arguments-use-from-uninlined-code.html: Added.
  • fast/js/script-tests/dfg-inline-arguments-use-from-uninlined-code.js: Added.

(foo):
(fuzz):
(bar):
(baz):

10:18 AM Changeset in webkit [105893] by kenneth@webkit.org
  • 13 edits
    5 adds in trunk

[Qt] Implement tap feedback respecting -webkit-tap-highlight-color
https://bugs.webkit.org/show_bug.cgi?id=76914

Reviewed by Simon Hausmann.

.:

Add a manual test.

  • ManualTests/qt/tap-highlighting.html: Added.

Source/WebCore:

Implement highlighting of dom nodes with a rounded rect, respecting
the color of -webkit-tap-highlight-color and any transform applied
to the element.

Tested with manual test.

  • Target.pri:
  • page/GestureTapHighlighter.cpp: Added.

(WebCore::GestureTapHighlighter::pathForNodeHighlight):

  • page/GestureTapHighlighter.h: Added.

Source/WebKit2:

Implement tap highlighting for Qt. When a touch press is issued,
which is not handled by the web page, then we highlight any
activatable node below. In all otehr cases, we hide any highlights.

The highlighting itself is painted on an accelerated PageOverlay,
on the web process side.

  • Target.pri:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handlePotentialActivation):

  • UIProcess/WebPageProxy.h:
  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::recognize):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handlePotentialSingleTapEvent):

  • UIProcess/qt/QtWebPageEventHandler.h:
  • WebProcess/WebPage/TapHighlightController.cpp: Added.

(WebKit::TapHighlightController::TapHighlightController):
(WebKit::TapHighlightController::~TapHighlightController):
(WebKit::TapHighlightController::highlight):
(WebKit::TapHighlightController::hideHighlight):
(WebKit::TapHighlightController::pageOverlayDestroyed):
(WebKit::TapHighlightController::willMoveToWebPage):
(WebKit::TapHighlightController::didMoveToWebPage):
(WebKit::highlightColor):
(WebKit::TapHighlightController::drawRect):
(WebKit::TapHighlightController::mouseEvent):

  • WebProcess/WebPage/TapHighlightController.h: Added.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::highlightPotentialActivation):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::tapHighlightController):

  • WebProcess/WebPage/WebPage.messages.in:
10:12 AM Changeset in webkit [105892] by leviw@chromium.org
  • 1 edit
    7 deletes in trunk/LayoutTests

Unreviewed, rolling out r105887.
http://trac.webkit.org/changeset/105887
https://bugs.webkit.org/show_bug.cgi?id=77023

Rolling out incorrect chromium expectations for zero length
svg stroke. (Requested by leviw on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-25

  • platform/chromium-mac-leopard/svg/stroke/zero-length-path-linecap-rendering-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/stroke/zero-length-path-linecap-rendering-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Removed.
  • platform/chromium-win-vista/svg/stroke/zero-length-path-linecap-rendering-expected.png: Removed.
  • platform/chromium-win-vista/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Removed.
  • platform/chromium-win-xp/svg/stroke/zero-length-path-linecap-rendering-expected.png: Removed.
  • platform/chromium-win-xp/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Removed.
  • platform/chromium-win/svg/stroke/zero-length-path-linecap-rendering-expected.png: Removed.
  • platform/chromium-win/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Removed.
10:01 AM Changeset in webkit [105891] by jsbell@chromium.org
  • 8 edits
    2 adds in trunk

IndexedDB: Need to distinguish key paths that don't yield value vs. yield invalid key
https://bugs.webkit.org/show_bug.cgi?id=76487

Source/WebCore:

Implement the precondition checks for IDBObjectStore.add/put operations: raise an error
if there is a key generator (autoIncrement) and the path yields a value and the value
is not a valid key; raise an error if any of the index key paths yield a value which
is not a valid key.

Reviewed by Tony Chang.

Tests: storage/indexeddb/keypath-edges.html

storage/indexeddb/objectstore-basics.html

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):

Source/WebKit/chromium:

Added a NullType to represent a null IDBKey pointer. This is needed to distinguish the
cases in the spec where the key resolution algorithm returns no value (null) versus
returns a value but that value is not a valid key (invalid).

Reviewed by Tony Chang.

  • public/WebIDBKey.h:
  • src/WebIDBKey.cpp:

(WebKit::WebIDBKey::createNull): Added.
(WebKit::WebIDBKey::createFromValueAndKeyPath): Now returns null if value is null.
(WebKit::convertFromWebIDBKeyArray): Null keys should never exist within arrays.
(WebKit::WebIDBKey::assignInvalid):
(WebKit::WebIDBKey::assignNull):
(WebKit::WebIDBKey::type):

LayoutTests:

Reviewed by Tony Chang.

  • storage/indexeddb/keypath-edges-expected.txt: Added.
  • storage/indexeddb/keypath-edges.html: Added.
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
9:59 AM Changeset in webkit [105890] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip scrollbars/scroll-rtl-or-bt-layer.html on WebKit2
because eventSender.mouseScrollBy isn't implemented.

  • platform/wk2/Skipped:
9:56 AM Changeset in webkit [105889] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed Qt gardening.

Temporally skip failing tests after r105878.

Patch by Balazs Kelemen <kbalazs@webkit.org> on 2012-01-25

  • platform/qt/Skipped:
9:51 AM Changeset in webkit [105888] by leviw@chromium.org
  • 1 edit
    16 adds in trunk/LayoutTests

Unreviewed. Adding platform expectations after 105879

  • platform/chromium-linux-x86/compositing: Added.
  • platform/chromium-linux-x86/compositing/overflow: Added.
  • platform/chromium-linux-x86/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
  • platform/chromium-linux/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
  • platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
  • platform/chromium-win-vista/compositing: Added.
  • platform/chromium-win-vista/compositing/overflow: Added.
  • platform/chromium-win-vista/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
  • platform/chromium-win-vista/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
  • platform/chromium-win-xp/compositing: Added.
  • platform/chromium-win-xp/compositing/overflow: Added.
  • platform/chromium-win-xp/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
  • platform/chromium-win-xp/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
  • platform/chromium-win/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
  • platform/chromium-win/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
9:48 AM Changeset in webkit [105887] by leviw@chromium.org
  • 1 edit
    13 adds in trunk/LayoutTests

Unreviewed. Adding platform test expectations after r105878.

  • platform/chromium-mac-leopard/svg/stroke: Added.
  • platform/chromium-mac-leopard/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
  • platform/chromium-mac-leopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
  • platform/chromium-win-vista/svg/stroke: Added.
  • platform/chromium-win-vista/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
  • platform/chromium-win-vista/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
  • platform/chromium-win-xp/svg/stroke: Added.
  • platform/chromium-win-xp/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
  • platform/chromium-win-xp/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
  • platform/chromium-win/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
  • platform/chromium-win/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
9:45 AM Changeset in webkit [105886] by Philippe Normand
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline and skip new timing-out media test.

  • platform/gtk/Skipped:
  • platform/gtk/css3/calc/getComputedStyle-margin-percentage-expected.txt: Added.
  • platform/gtk/fast/multicol/span/generated-child-split-flow-crash-expected.txt: Added.
9:23 AM Changeset in webkit [105885] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=65377
Skip the entire node when it is right to do so, instead of stepping
through every character, so we save CPU time on checking every position
unnecessarily.

Patch by Yong Li <yoli@rim.com> on 2012-01-25
Reviewed by Darin Adler.

Source/WebCore:

Test: perf/selection-skip-hidden-node.html

  • dom/Position.cpp:

(WebCore::Position::upstream):
(WebCore::Position::downstream):

  • dom/PositionIterator.cpp:

(WebCore::PositionIterator::moveToLeafNodeStart):
(WebCore::PositionIterator::moveToLeafNodeEnd):

  • dom/PositionIterator.h:
  • editing/htmlediting.cpp:

(WebCore::nextCandidate):
(WebCore::nextVisuallyDistinctCandidate):
(WebCore::previousCandidate):
(WebCore::previousVisuallyDistinctCandidate):

LayoutTests:

  • perf/selection-skip-hidden-node-expected.txt: Added.
  • perf/selection-skip-hidden-node.html: Added.
9:21 AM Changeset in webkit [105884] by commit-queue@webkit.org
  • 11 edits in trunk

[WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
https://bugs.webkit.org/show_bug.cgi?id=63458

Patch by Nándor Huszka <huszka.nandor@stud.u-szeged.hu> on 2012-01-25
Reviewed by Adam Roben.

Source/WebKit2:

Implement the setPopupBlockingEnabled method.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetPrivateBrowsingEnabled):
(WKBundleSetPopupBlockingEnabled):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPopupBlockingEnabled):

  • WebProcess/InjectedBundle/InjectedBundle.h:

Tools:

Implement the setPopupBlockingEnabled method.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setPopupBlockingEnabled):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

LayoutTests:

Unskip tests which do not fail now.

  • platform/wk2/Skipped:
9:18 AM Changeset in webkit [105883] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove unnecessary member variable from PluginView.
https://bugs.webkit.org/show_bug.cgi?id=76909

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2012-01-25
Reviewed by Adam Roben.

No new tests needed.

  • plugins/PluginView.cpp:

(WebCore::PluginView::getURLNotify):
(WebCore::PluginView::getURL):
(WebCore::PluginView::PluginView):
(WebCore::PluginView::handlePost):
(WebCore::PluginView::getValueForURL):
(WebCore::PluginView::setValueForURL):

  • plugins/PluginView.h:
9:17 AM Changeset in webkit [105882] by Philippe Normand
  • 5 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline and skipping 2 new test failures.

  • platform/gtk/Skipped:
  • platform/gtk/svg/custom/path-moveto-only-rendering-expected.txt:
  • platform/gtk/svg/custom/subpaths-moveto-only-rendering-expected.txt:
  • platform/gtk/svg/custom/zero-path-square-cap-rendering-expected.txt:
9:09 AM Changeset in webkit [105881] by yael.aharon@nokia.com
  • 4 edits in trunk/Source

[Qt] Build fix when using force_static_libs_as_shared
https://bugs.webkit.org/show_bug.cgi?id=76832

Reviewed by Simon Hausmann.

Source/WebCore:

Add a dependency on QtWidgets, when compiling against Qt5.

No new tests. This is a build fix.

  • Target.pri:

Source/WebKit2:

Add a dependency on QtWidgets.

  • Target.pri:
8:19 AM Changeset in webkit [105880] by Philippe Normand
  • 13 edits in trunk/LayoutTests

[Gtk] Update expected layout test results after r105686
https://bugs.webkit.org/show_bug.cgi?id=77008

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-01-25
Reviewed by Philippe Normand.

After r105686, missing image icons are properly loaded and
shown, causing failures because of incorrect expected results.
These changes properly fix the expectations and subsequently
remove failures.

  • platform/gtk/editing/execCommand/insertImage-expected.txt:
  • platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
  • platform/gtk/fast/block/float/015-expected.txt:
  • platform/gtk/fast/borders/rtl-border-05-expected.txt:
  • platform/gtk/fast/dom/34176-expected.txt:
  • platform/gtk/fast/dom/inner-text-expected.txt:
  • platform/gtk/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/gtk/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/gtk/fast/hidpi/broken-image-icon-hidpi-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2962-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug56201-expected.txt:
  • platform/gtk/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
7:50 AM Changeset in webkit [105879] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Clipping of render layer boundaries does not take page scale into account
https://bugs.webkit.org/show_bug.cgi?id=76850

Source/WebCore:

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-01-25
Reviewed by Simon Fraser.

When inserting render layers into the compositor's overlap map, the
layer boundaries are clipped against any potential parent clip rects.
The clip rects are given in CSS coordinates, while the render layer
boundaries are in scaled CSS coordinates, so the result is incorrect.
This patch scales the clip rects before calculating the intersection.

Test: compositing/overflow/overflow-scaled-descendant-overlapping.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap):

LayoutTests:

Added new test to make sure render layers inside clipped containers
are correctly tested for overlap with other layers.

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-01-25
Reviewed by Simon Fraser.

  • compositing/overflow/overflow-scaled-descendant-overlapping.html: Added.
  • platform/chromium-linux/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
7:31 AM Changeset in webkit [105878] by commit-queue@webkit.org
  • 10 edits
    7 adds in trunk

Linecaps wrong for zero length lines
https://bugs.webkit.org/show_bug.cgi?id=71820

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-25
Reviewed by Nikolas Zimmermann.

Total reworking of the method used to draw zero-length linecaps for
SVG. This patch works for all zero length sub-paths.

Source/WebCore:

Tests: svg/stroke/zero-length-path-linecap-rendering.svg

svg/stroke/zero-length-subpaths-linecap-rendering.svg

  • rendering/svg/RenderSVGShape.cpp: Significant refactoring to enable new implementation and clarify code.

(WebCore::RenderSVGShape::createShape):
(WebCore::RenderSVGShape::strokeContains):
(WebCore::RenderSVGShape::shouldStrokeZeroLengthSubpath):
(WebCore::RenderSVGShape::zeroLengthSubpathRect):
(WebCore::RenderSVGShape::zeroLengthLinecapPath):
(WebCore::RenderSVGShape::nonScalingStrokePath):
(WebCore::RenderSVGShape::setupNonScalingStrokeTransform):
(WebCore::RenderSVGShape::fillShape):
(WebCore::RenderSVGShape::strokePath):
(WebCore::RenderSVGShape::fillAndStrokePath):
(WebCore::RenderSVGShape::updateCachedBoundaries):
(WebCore::RenderSVGShape::processZeroLengthSubpaths):

  • rendering/svg/RenderSVGShape.h: Declarations for new methods.
  • rendering/svg/SVGSubpathData.h: Class for finding zero length subpaths.
  • svg/SVGPathBuilder.h: Fix typos
  • svg/SVGPathConsumer.h: Fix typos
  • svg/SVGPathSegListBuilder.h: Fix typos
  • svg/SVGPathTraversalStateBuilder.h: Fix typos

LayoutTests:

  • platform/chromium/test_expectations.txt: Chromium test expectations

pending new expected images and text.

  • platform/mac/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
  • platform/mac/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
  • platform/mac/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
  • platform/mac/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
  • platform/mac/test_expectations.txt: Chromium test expectations

pending new expected images and text.

  • svg/stroke/zero-length-path-linecap-rendering.svg: Added.
  • svg/stroke/zero-length-subpaths-linecap-rendering.svg: Added.
7:10 AM Changeset in webkit [105877] by yurys@chromium.org
  • 14 edits
    1 add in trunk/Source/WebCore

Web Inspector: show memory counter graphs in timeline panel
https://bugs.webkit.org/show_bug.cgi?id=76843

Timeline panel is extended with several graphs depicting total node count,
number of DOM groups and event listeners. This feature is hidden behind
experimental setting.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::setDomCountersEnabled):
(WebCore::InspectorTimelineAgent::didCallFunction):
(WebCore::InspectorTimelineAgent::didDispatchEvent):
(WebCore::InspectorTimelineAgent::didWriteHTML):
(WebCore::InspectorTimelineAgent::didFireTimer):
(WebCore::InspectorTimelineAgent::didEvaluateScript):
(WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
(WebCore::InspectorTimelineAgent::collectDomCounters):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):

  • inspector/InspectorTimelineAgent.h:

(WebCore::InspectorTimelineAgent::create):

  • inspector/TimelineRecordFactory.cpp:
  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.MemoryStatistics):
(WebInspector.MemoryStatistics.prototype.setTopPosition):
(WebInspector.MemoryStatistics.prototype.setSidebarWidth):
(WebInspector.MemoryStatistics.prototype._sidebarResized):
(WebInspector.MemoryStatistics.prototype._updateSize):
(WebInspector.MemoryStatistics.prototype._updateSidebarSize):
(WebInspector.MemoryStatistics.prototype._createCounterSidebarElement):
(WebInspector.MemoryStatistics.prototype.addTimlineEvent):
(WebInspector.MemoryStatistics.prototype._draw.getGroupCount):
(WebInspector.MemoryStatistics.prototype._draw.getNodeCount):
(WebInspector.MemoryStatistics.prototype._draw.getListenerCount):
(WebInspector.MemoryStatistics.prototype._draw):
(WebInspector.MemoryStatistics.prototype._calculateVisibleIndexes):
(WebInspector.MemoryStatistics.prototype._onMouseOver):
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):
(WebInspector.MemoryStatistics.prototype.visible):
(WebInspector.MemoryStatistics.prototype.show):
(WebInspector.MemoryStatistics.prototype.refresh):
(WebInspector.MemoryStatistics.prototype.hide):
(WebInspector.MemoryStatistics.prototype._setVerticalClip):
(WebInspector.MemoryStatistics.prototype._calculateXValues):
(WebInspector.MemoryStatistics.prototype._drawPolyline):
(WebInspector.MemoryStatistics.prototype._drawBottomBound):
(WebInspector.MemoryStatistics.prototype._clear):
(WebInspector.TimelinePanel.prototype._startSplitterDragging):
(WebInspector.TimelinePanel.prototype._splitterDragging):
(WebInspector.TimelinePanel.prototype._endSplitterDragging):
(WebInspector.TimelinePanel.prototype._setSplitterPosition):
(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._toggleMemoryStatistics):
(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
(WebInspector.TimelinePanel.prototype.sidebarResized):
(WebInspector.TimelinePanel.prototype._refresh):

  • inspector/front-end/timelinePanel.css:

(#timeline-memory-splitter):
(#memory-counters-graph):
(#memory-graphs-container):
(#memory-graphs-container .split-view-contents):
(.timeline-marker):
(.memory-counter-sidebar-info):
(.memory-counter-sidebar-info.bottom-border-visible):

7:03 AM Changeset in webkit [105876] by kbalazs@webkit.org
  • 10 edits
    1 copy
    1 add
    1 delete in trunk/Tools

[Qt] Cleanup testfonts handling
https://bugs.webkit.org/show_bug.cgi?id=76068

Reviewed by Simon Hausmann.

Factor test font initialization into it's own file so test
font users can share the implementation by adding the file
to their build.
Use fonts.conf from the test font directory to not require the
current directory to be the WebKit root.
Fix the -use-test-fonts option of QtTestBrowser by initializing
the fonts earlier, before it is too late (namely before calling
show on the main window).

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::open):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.

(WebKit::initializeTestFonts):

  • DumpRenderTree/qt/QtInitializeTestFonts.h: Added.
  • DumpRenderTree/qt/fonts.conf: Removed. No need for this since

we will use the one from the test fonts directory.

  • DumpRenderTree/qt/main.cpp:

(main): Fix the ifdefs to make it clear that the code to
set up the Dpi has not been ported to Qt5 yet.

  • QtTestBrowser/QtTestBrowser.pro:
  • QtTestBrowser/launcherwindow.h:

(WindowOptions::WindowOptions):

  • QtTestBrowser/main.cpp:

(launcherMain):
(LauncherApplication::handleUserOptions):

  • WebKitTestRunner/InjectedBundle/Target.pri:
  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts): Remove the code to set up the Dpi
because it does not work with Qt5.

6:32 AM Changeset in webkit [105875] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] build-webkit --qt requires a git-svn or SVN checkout.

Reviewed by Tor Arne Vestø.

Don't require it by making svnRevisionForDirectory return "unknown"
instead of bailing out with an error.

  • Scripts/VCSUtils.pm:

(svnRevisionForDirectory):

6:30 AM Changeset in webkit [105874] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed single line test fix after r105865.

  • inspector/profiler/detailed-heapshots-test.js:

(initialize_DetailedHeapshotTest.):
(initialize_DetailedHeapshotTest):

6:13 AM Changeset in webkit [105873] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

<http://webkit.org/b/76941> Web Inspector: Remove Unused InspectorFrontendHost.search Stub

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2012-01-25
Reviewed by Pavel Feldman.

  • inspector/front-end/InspectorFrontendHostStub.js:
5:27 AM Changeset in webkit [105872] by Csaba Osztrogonác
  • 3 edits
    7 adds in trunk/LayoutTests

[Qt][ARM] Unreviewed gardening.

Skip failing tests, update/add platform specific expected files for passing tests.

  • platform/qt-arm/Skipped:
  • platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt-arm/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Added.
  • platform/qt-arm/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Added.
  • platform/qt-arm/svg/batik/text/textOnPath3-expected.txt: Added.
5:20 AM Changeset in webkit [105871] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed inspector style fix.

  • inspector/front-end/tabbedPane.css:

(.tabbed-pane-header-tab-close-button):
(select.tabbed-pane-header-tabs-drop-down-select):

5:04 AM Changeset in webkit [105870] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Fix incorrect behavior in HTMLCollection.prototype.item().
https://bugs.webkit.org/show_bug.cgi?id=74468

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-25
Reviewed by Adam Barth.

HTMLCollection.prototype.item("someString") was falling back to
.namedItem("someString"), which is wrong per spec. Also align the
handling of various other types of objects passed as the argument with
the spec and the rest of the browsers.

Source/WebCore:

Test: fast/dom/collection-item.html

  • bindings/js/JSHTMLCollectionCustom.cpp: Remove custom implementation of item().
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp: Ditto.
  • html/HTMLCollection.idl: Remove [Custom] in item(), it's not needed.

LayoutTests:

  • fast/dom/collection-item-expected.txt: Added.
  • fast/dom/collection-item.html: Added.
4:39 AM Changeset in webkit [105869] by mikelawther@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

table border spacing test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=76226

Reviewed by Julien Chaffraix.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/table-border-spacing-expected.txt: Added.
  • css3/calc/table-border-spacing.html: Added.
4:36 AM Changeset in webkit [105868] by commit-queue@webkit.org
  • 8 edits
    2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r105858.
http://trac.webkit.org/changeset/105858
https://bugs.webkit.org/show_bug.cgi?id=77004

It made many tests crash on Qt (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-25

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::addAnimation):
(WebCore::GraphicsLayerTextureMapper::pauseAnimation):
(WebCore::GraphicsLayerTextureMapper::removeAnimation):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):

  • platform/graphics/texmap/TextureMapperAnimation.cpp: Removed.
  • platform/graphics/texmap/TextureMapperAnimation.h: Removed.
  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncCompositingStateSelf):
(WebCore::TextureMapperNode::descendantsOrSelfHaveRunningAnimations):
(WebCore::normalizedAnimationValue):
(WebCore):
(WebCore::TextureMapperNode::applyOpacityAnimation):
(WebCore::solveEpsilon):
(WebCore::solveCubicBezierFunction):
(WebCore::solveStepsFunction):
(WebCore::applyTimingFunction):
(WebCore::TextureMapperNode::applyTransformAnimation):
(WebCore::TextureMapperNode::applyAnimationFrame):
(WebCore::TextureMapperNode::applyAnimation):
(WebCore::TextureMapperNode::hasOpacityAnimation):
(WebCore::TextureMapperNode::hasTransformAnimation):
(WebCore::TextureMapperNode::syncAnimations):
(WebCore::TextureMapperNode::syncAnimationsRecursively):
(WebCore::TextureMapperNode::syncCompositingState):
(WebCore::TextureMapperAnimation::TextureMapperAnimation):

  • platform/graphics/texmap/TextureMapperNode.h:

(TextureMapperAnimation):
(WebCore::TextureMapperAnimation::create):
(WebCore):
(TextureMapperNode):

4:35 AM Changeset in webkit [105867] by Csaba Osztrogonác
  • 21 edits
    2 adds
    2 deletes in trunk/LayoutTests

Unreviewed gardening, Skipped list cleanup.

  • platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
  • platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.
  • platform/mac/Skipped: Remove non-existent files.
  • platform/qt/Skipped: Group new skipped tests.
  • platform/qt/editing/deleting/delete-line-011-expected.png:
  • platform/qt/editing/deleting/delete-line-011-expected.txt:
  • platform/qt/editing/pasteboard/paste-4039777-fix-expected.png: Added.
  • platform/qt/editing/pasteboard/paste-4039777-fix-expected.txt: Added.
  • platform/qt/fast/block/float/floats-and-text-indent-expected.png:
  • platform/qt/fast/block/float/floats-and-text-indent-expected.txt:
  • platform/qt/fast/block/float/floats-and-text-indent-rl-expected.png:
  • platform/qt/fast/block/float/floats-and-text-indent-rl-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
4:32 AM Changeset in webkit [105866] by bashi@chromium.org
  • 4 edits in trunk

fast/text/unicode-variation-selector.html doesn't pass on Lion
https://bugs.webkit.org/show_bug.cgi?id=76041

Source/WebCore:

Reviewed by Dan Bernstein.

Consumes non-BMP marks in advanceByCombiningCharacterSequence() to take into
account Ideographic variation selectors (these are non-BMP marks).

No new tests. fast/text/unicode-variation-selector.html should pass on Lion.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::advanceByCombiningCharacterSequence): Use Unicode code point
to iterate the loop which consumes marks.

LayoutTests:

Update the UVS test font to be CoreText-friendly. This updated font is provided by Apple.

Reviewed by Dan Bernstein.

  • fast/text/resources/gw432047.ttf:
4:25 AM Changeset in webkit [105865] by loislo@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: DetailedHeapSnapshot: adjust node name cell format for the retainers tree.
https://bugs.webkit.org/show_bug.cgi?id=76989

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
(WebInspector.HeapSnapshotObjectNode.prototype._postfixObjectCell):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotEdgesProvider.prototype._serialize):

4:01 AM Changeset in webkit [105864] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: [InspectorIndexedDB] Pass Database, object stores and indexes meta information to frontend.
https://bugs.webkit.org/show_bug.cgi?id=76711

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):
(WebCore::assertDocument):
(WebCore::assertIDBFactory):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
(WebCore::InspectorIndexedDBAgent::requestDatabase):

  • inspector/InspectorIndexedDBAgent.h:

(InspectorIndexedDBAgent):

  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel):
(WebInspector.IndexedDBModel.prototype._frameDetached):
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype._originAddedToFrame):
(WebInspector.IndexedDBModel.prototype._originRemovedFromFrame):
(WebInspector.IndexedDBModel.prototype._originRemoved):
(WebInspector.IndexedDBModel.prototype._updateOriginDatabaseNames):
(WebInspector.IndexedDBModel.prototype._databaseRemoved):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNamesForFrame):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.Frame):
(WebInspector.IndexedDBModel.Database):
(WebInspector.IndexedDBModel.ObjectStore):
(WebInspector.IndexedDBModel.ObjectStoreIndex):
(WebInspector.IndexedDBRequestManager.prototype._databaseNamesLoaded):
(WebInspector.IndexedDBRequestManager.prototype.requestDatabase.innerCallback):
(WebInspector.IndexedDBRequestManager.prototype.requestDatabase):
(WebInspector.IndexedDBRequestManager.prototype._databaseLoaded):
(WebInspector.IndexedDBRequestManager.prototype._frameDetached):
(WebInspector.IndexedDBRequestManager.prototype._databaseRemoved):
(WebInspector.IndexedDBRequestManager.prototype._reset):
(WebInspector.IndexedDBRequestManager.DatabaseRequest):
(WebInspector.IndexedDBDispatcher.prototype.databaseNamesLoaded):
(WebInspector.IndexedDBDispatcher.prototype.databaseLoaded):

3:54 AM Changeset in webkit [105863] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: add optional runtime validator
https://bugs.webkit.org/show_bug.cgi?id=76676

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-25
Reviewed by Yury Semikhatsky.

Generator algorithm is redone significantly.

  • inspector/CodeGeneratorInspector.py:

(RawTypes.BaseType):
(RawTypes.BaseType.request_raw_internal_runtime_cast):
(RawTypes.BaseType.generate_validate_method_impl):
(RawTypes):
(RawTypes.generate_validate_methods):
(RawTypes.String):
(RawTypes.String.generate_validate_method):
(RawTypes.String.get_raw_validator_call_text):
(RawTypes.Int):
(RawTypes.Int.generate_validate_method):
(RawTypes.Int.get_raw_validator_call_text):
(RawTypes.Number):
(RawTypes.Number.generate_validate_method):
(RawTypes.Number.get_raw_validator_call_text):
(RawTypes.Bool):
(RawTypes.Bool.generate_validate_method):
(RawTypes.Bool.get_raw_validator_call_text):
(RawTypes.Object):
(RawTypes.Object.generate_validate_method):
(RawTypes.Object.get_raw_validator_call_text):
(RawTypes.Any):
(RawTypes.Any.generate_validate_method):
(RawTypes.Any.get_raw_validator_call_text):
(RawTypes.Array):
(RawTypes.Array.generate_validate_method):
(RawTypes.Array.get_raw_validator_call_text):
(TypeBindings.create_named_type_declaration.Helper):
(TypeBindings.create_ad_hoc_type_declaration.Helper):
(TypeBindings.create_type_declaration_.EnumBinding):
(TypeBindings.create_type_declaration_.EnumBinding.resolve_inner):
(TypeBindings.create_type_declaration_.EnumBinding.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.EnumBinding.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.EnumBinding.get_validator_call_text):
(TypeBindings.create_type_declaration_.EnumBinding.get_in_c_type_text):
(TypeBindings.create_type_declaration_.PlainString):
(TypeBindings.create_type_declaration_.PlainString.resolve_inner):
(TypeBindings.create_type_declaration_.PlainString.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.PlainString.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.PlainString.get_validator_call_text):
(TypeBindings.create_type_declaration_.TypedefString):
(TypeBindings.create_type_declaration_.TypedefString.resolve_inner):
(TypeBindings.create_type_declaration_.TypedefString.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.TypedefString.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.TypedefString.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.TypedefString.get_validator_call_text):
(TypeBindings.create_type_declaration_.TypedefString.get_in_c_type_text):
(TypeBindings.create_type_declaration_.ClassBinding):
(TypeBindings.create_type_declaration_.ClassBinding.resolve_inner):
(TypeBindings.create_type_declaration_.ClassBinding.resolve_inner.PropertyData):
(TypeBindings.create_type_declaration_.ClassBinding.resolve_inner.ResolveData):
(TypeBindings.create_type_declaration_.ClassBinding.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.ClassBinding.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.ClassBinding.get_code_generator):
(TypeBindings.create_type_declaration_.ClassBinding.get_code_generator.CodeGenerator.generate_type_builder):
(get_validator_call_text):
(get_in_c_type_text):
(AdHocTypeContextImpl):
(AdHocTypeContextImpl.init):
(AdHocTypeContextImpl.get_type_name_fix):
(AdHocTypeContextImpl.get_type_name_fix.NameFix):
(AdHocTypeContextImpl.get_type_name_fix.NameFix.output_comment):
(AdHocTypeContextImpl.add_type):
(PlainObjectBinding):
(PlainObjectBinding.resolve_inner):
(PlainObjectBinding.request_user_runtime_cast):
(PlainObjectBinding.request_internal_runtime_cast):
(PlainObjectBinding.get_validator_call_text):
(ArrayBinding):
(ArrayBinding.resolve_inner):
(ArrayBinding.resolve_inner.AdHocTypeContext):
(ArrayBinding.resolve_inner.AdHocTypeContext.get_type_name_fix):
(ArrayBinding.resolve_inner.AdHocTypeContext.get_type_name_fix.NameFix):
(ArrayBinding.resolve_inner.AdHocTypeContext.get_type_name_fix.NameFix.output_comment):
(ArrayBinding.resolve_inner.AdHocTypeContext.add_type):
(ArrayBinding.resolve_inner.ResolveData):
(ArrayBinding.request_user_runtime_cast):
(ArrayBinding.request_internal_runtime_cast):
(ArrayBinding.get_code_generator):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder):
(ArrayBinding.get_validator_call_text):
(ArrayBinding.get_in_c_type_text):
(RawTypeBinding.resolve_inner):
(RawTypeBinding):
(RawTypeBinding.request_user_runtime_cast):
(RawTypeBinding.request_internal_runtime_cast):
(RawTypeBinding.get_validator_call_text):
(TypeData.get_name):
(TypeData):
(TypeData.get_domain_name):
(resolve_param_type):
(NeedRuntimeCastRequest):
(NeedRuntimeCastRequest.init):
(NeedRuntimeCastRequest.acknowledge):
(NeedRuntimeCastRequest.is_acknowledged):
(resolve_all_types):
(resolve_all_types.ForwardListener):
(resolve_all_types.ForwardListener.add_type_data):
(resolve_all_types.ResolveContext):
(Generator):
(Generator.go):
(Generator.process_event):
(Generator.process_event.AdHocTypeContext):
(Generator.process_event.AdHocTypeContext.add_type):
(Generator.process_event.EventForwardListener):
(Generator.process_event.EventForwardListener.add_type_data):
(Generator.process_event.EventResolveContext):
(Generator.process_event.EventGenerateContext):
(Generator.process_types.GenerateContext):
(Generator.process_types.create_type_builder_caller.call_type_builder):
(Generator.process_types.generate_forward_callback):

  • inspector/InspectorValues.h:

(WebCore::InspectorObject::size):

3:44 AM Changeset in webkit [105862] by antonm@chromium.org
  • 6 edits in trunk/Source/WebCore

Unreview manual revert of r105843.

  • fileapi/EntryBase.cpp:

(WebCore::EntryBase::toURL):

  • page/SecurityOrigin.cpp:

(WebCore::extractInnerURL):

  • platform/KURL.h:

(KURL):

  • platform/KURLGoogle.cpp:

(WebCore):
(WebCore::KURLGooglePrivate::setUtf8):
(WebCore::KURLGooglePrivate::setAscii):
(WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily):
(WebCore::KURLGooglePrivate::copyTo):
(WebCore::encodeWithURLEscapeSequences):

  • platform/KURLGooglePrivate.h:

(KURLGooglePrivate):

3:44 AM Changeset in webkit [105861] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] fast/css/text-overflow-input.html rebaseline
https://bugs.webkit.org/show_bug.cgi?id=76981

Reviewed by Kent Tamura.

Fixed in r105451

  • platform/chromium/test_expectations.txt:
3:37 AM Changeset in webkit [105860] by noel.gordon@gmail.com
  • 3 edits in trunk/Source/WebCore

Use maximum image dimension definition from libwebp
https://bugs.webkit.org/show_bug.cgi?id=76980

Reviewed by Kent Tamura.

No new tests, no change in behavior.

  • platform/image-encoders/skia/WEBPImageEncoder.cpp:

(WebCore::encodePixels): s/WEBP_MAX_DIMENSION/WEBPImageEncoder::MaximumImageDimension/

  • platform/image-encoders/skia/WEBPImageEncoder.h:

(): Remove local definition of the maximum webp image dimension

3:24 AM Changeset in webkit [105859] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

JPEGDecoder should use imageDecoder colorProfile helpers
https://bugs.webkit.org/show_bug.cgi?id=76968

Reviewed by Adam Barth.

No new tests. Cover by existing tests, in particular:

fast/images/ycbcr-with-cmyk-color-profile.html
fast/images/gray-scale-jpeg-with-color-profile.html
fast/images/cmyk-jpeg-with-color-profile.html
fast/images/color-jpeg-with-color-profile.html

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: white-space removals via Xcode.

(WebCore::readColorProfile): Use ImageDecoder.h color profile helper routines.
(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::decode):

3:09 AM Changeset in webkit [105858] by noam.rosenthal@nokia.com
  • 8 edits
    2 adds in trunk/Source/WebCore

[Texmap] Divide TextureMapperNode.cpp to 3 files.
https://bugs.webkit.org/show_bug.cgi?id=76660

Reviewed by Kenneth Rohde Christiansen.

Split the animation part of TextureMapperNode out to a separate file, called
TextureMapperAnimation.
Provide a clean interface for that class, that allows separating the internals of the scene
painting from the internals of the animation interpolation.

No new tests. Existing animation tests cover this.

  • GNUmakefile.list.am: Added new TextureMapper-related files.
  • Target.pri: Added new TextureMapper-related files.
  • WebCore.gypi: Added new TextureMapper-related files.
  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::addAnimation):
(WebCore::GraphicsLayerTextureMapper::pauseAnimation):
(WebCore::GraphicsLayerTextureMapper::removeAnimation):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  • platform/graphics/texmap/TextureMapperAnimation.cpp: Added.
  • platform/graphics/texmap/TextureMapperAnimation.h: Added.
  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncCompositingStateSelf):
(WebCore::TextureMapperNode::descendantsOrSelfHaveRunningAnimations):
(WebCore::TextureMapperNode::syncAnimations):
(WebCore::TextureMapperNode::syncAnimationsRecursively):
(WebCore::TextureMapperNode::syncCompositingState):

  • platform/graphics/texmap/TextureMapperNode.h:
2:18 AM Changeset in webkit [105857] by abarth@webkit.org
  • 2 edits in trunk/Tools

Temporarily disable running the unit tests on the Chromium EWS. These
tests don't work properly (see
https://bugs.webkit.org/show_bug.cgi?id=76979) and are currently
blocking the EWS.

  • Scripts/webkitpy/common/config/ports.py:

(ChromiumPort):

1:57 AM Changeset in webkit [105856] by abarth@webkit.org
  • 4 edits in trunk

Update results.html version of PixelZoomer
https://bugs.webkit.org/show_bug.cgi?id=76965

Reviewed by Ojan Vafai.

Tools:

Improve readability as suggested by Ojan.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:

LayoutTests:

Update result.html with changes from PixelZoomer.js.

  • fast/harness/results.html:
12:54 AM Changeset in webkit [105855] by sergio@webkit.org
  • 5 edits in trunk/Source/WebKit2

[WK2] FindController should not assume that ports do not want to highlight text matches
https://bugs.webkit.org/show_bug.cgi?id=76921

Reviewed by Darin Adler.

FindController must obey the FindOptionsShowHighlight flag instead
of assuming that ports do not want to highlight search matches.

  • Shared/API/c/WKFindOptions.h: added kWKFindOptionsShowHighlight.
  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toFindOptions): Ditto.

  • Shared/WebFindOptions.h: added FindOptionsShowHighlight.
  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findString):

12:37 AM Changeset in webkit [105854] by Carlos Garcia Campos
  • 8 edits
    2 moves
    1 add
    1 delete in trunk

[GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=76899

Reviewed by Martin Robinson.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitLoaderClient.cpp: Renamed from

Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp.
(didStartProvisionalLoadForFrame): Use clientInfo instead fo
getting the view from the page.
(didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
(didFailProvisionalLoadWithErrorForFrame): Ditto.
(didCommitLoadForFrame): Ditto.
(didFinishLoadForFrame): Ditto.
(didFailLoadWithErrorForFrame): Ditto.
(didSameDocumentNavigationForFrame): Ditto.
(didReceiveTitleForFrame): Ditto.
(didChangeProgress): Ditto.
(didChangeBackForwardList): Ditto.
(attachLoaderClientToView): Pass WebKitWebView as clientInfo to
callbacks.

  • UIProcess/API/gtk/WebKitLoaderClient.h: Added.
  • UIProcess/API/gtk/WebKitUIClient.cpp:

(createNewPage): Use clientInfo instead fo getting the view from
the page.
(showPage): Ditto.
(closePage): Ditto.
(runJavaScriptAlert): Ditto.
(runJavaScriptConfirm): Ditto.
(runJavaScriptPrompt): Ditto.
(toolbarsAreVisible): Ditto.
(setToolbarsAreVisible): Ditto.
(menuBarIsVisible): Ditto.
(setMenuBarIsVisible): Ditto.
(statusBarIsVisible): Ditto.
(setStatusBarIsVisible): Ditto.
(isResizable): Ditto.
(setIsResizable): Ditto.
(getWindowFrame): Ditto.
(setWindowFrame): Ditto.
(attachUIClientToView): Pass WebKitWebView as clientInfo to
callbacks.

  • UIProcess/API/gtk/WebKitUIClient.h: Remove GObject boilerplate.
  • UIProcess/API/gtk/WebKitWebLoaderClient.h: Removed.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Remove UIClient and LoaderClient
objects and call attachUIClientToView() and attachLoaderClientToView().

  • UIProcess/API/gtk/tests/GNUmakefile.am: Rename

WebKitWebLoaderClient to WebKitLoaderClient.

  • UIProcess/API/gtk/tests/TestLoaderClient.cpp: Renamed from

Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp.

Tools:

  • gtk/generate-gtkdoc:

(get_webkit2_options): WebKitWebLoaderClient has been renamed to
WebKitLoaderClient.

12:04 AM Changeset in webkit [105853] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unskip now passing tests after r105813.

  • platform/qt/Skipped:
Note: See TracTimeline for information about the timeline view.