⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 1, 2012:

11:48 PM Changeset in webkit [106535] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Rename [V8DisallowShadowing] to [V8Unforgeable]
​https://bugs.webkit.org/show_bug.cgi?id=77599

Reviewed by Adam Barth.

This patch renames [V8DisallowShadowing] to [V8Unforgeable], following the Web IDL
spec (​http://dev.w3.org/2006/webapi/WebIDL/#Unforgeable).

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

  • page/DOMWindow.idl:
  • page/Location.idl:
11:07 PM Changeset in webkit [106534] by haraken@chromium.org
  • 41 edits in trunk/Source/WebCore

Rename [ConvertNullToNullString] to [TreatNullAs=EmptyString]
​https://bugs.webkit.org/show_bug.cgi?id=77602

Reviewed by Adam Barth.

This patch renames [ConvertNullToNullString] to [TreatNullAs=EmptyString],
according to the spec (​http://dev.w3.org/2006/webapi/WebIDL/#TreatNullAs).

No tests. No changes in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(JSValueToNative):

  • bindings/scripts/CodeGeneratorV8.pm:

(GetNativeTypeFromSignature):

  • css/CSSCharsetRule.idl:
  • css/CSSPageRule.idl:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleRule.idl:
  • css/CSSValue.idl:
  • css/MediaList.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • dom/Attr.idl:
  • dom/CharacterData.idl:
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/ProcessingInstruction.idl:
  • dom/ShadowRoot.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLOutputElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLTitleElement.idl:
  • html/canvas/CanvasRenderingContext2D.idl:
  • page/DOMWindow.idl:
  • storage/StorageEvent.idl:
  • svg/SVGAngle.idl:
  • svg/SVGElement.idl:
  • svg/SVGLength.idl:
  • svg/SVGScriptElement.idl:
  • bindings/scripts/test/TestObj.idl: No change in the run-bindings-tests results.
10:31 PM Changeset in webkit [106533] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Webkit generate-coverage-data script needs update to use new test script
​https://bugs.webkit.org/show_bug.cgi?id=77597

Patch by Jacob Goldstein <​jacobg@adobe.com> on 2012-02-01
Reviewed by Dirk Schulze.

  • Scripts/generate-coverage-data:
10:24 PM Changeset in webkit [106532] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

Remove [GenerateConstructor] from IDL files
​https://bugs.webkit.org/show_bug.cgi?id=77598

Reviewed by Adam Barth.

[GenerateConstructor] is used in some IDL files but it is not implemented
in code generators. I could not find any history about [GenerateConstructor]
in code generators. This patch removes them from IDL files.

Maybe we want to replace [GenerateConstructor] with [Constructor] eventually,
but currently no tests are written for their constructors (e.g. "new DOMTokenList()").
So simply removing them would make sense.

No new tests. No change in behavior.

  • dom/DOMStringList.idl:
  • html/DOMSettableTokenList.idl:
  • html/DOMTokenList.idl:
  • svg/SVGFEConvolveMatrixElement.idl:
  • webaudio/AudioPannerNode.idl:
9:10 PM Changeset in webkit [106531] by eric.carlson@apple.com
  • 9 edits
    4 adds in trunk

Consider user's preferred language when choosing text tracks
​https://bugs.webkit.org/show_bug.cgi?id=74121

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Tests: media/track/track-language-preference.html

media/track/track-prefer-captions.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadTimerFired): configureTextTracks -> configureNewTextTracks.
(WebCore::HTMLMediaElement::textTracksAreReady): Add more comments.
(WebCore::HTMLMediaElement::textTrackModeChanged): Ditto.
(WebCore::HTMLMediaElement::showingTrackWithSameKind): Minor restructuring.
(WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind): Renamed from userIsInterestedInThisTrack,

don't consider user's language preference.

(WebCore::HTMLMediaElement::configureTextTrackGroup): New, configure all tracks in a group,

considering user's kind and language preferences.

(WebCore::HTMLMediaElement::configureNewTextTracks): New, configure all newly added tracks.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::TrackGroup::TrackGroup):
(TrackGroup):

  • platform/Language.cpp:

(WebCore::canonicalLanguageIdentifier): New, create a canonicalized version of a language string.
(WebCore::bestMatchingLanguage): New, return the language from the list that best matches the

specified language.

(WebCore::preferredLanguageFromList): New, return the language in the specified list that best

matches the user's language preference.

  • platform/Language.h:
  • testing/Internals.cpp:

(WebCore::Internals::setShouldDisplayTrackType): New, allow DRT to set the track type preference.
(WebCore::Internals::shouldDisplayTrackType): New, allow DRT to read the track type preference.

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • media/track/track-language-preference-expected.txt: Added.
  • media/track/track-language-preference.html: Added.
  • media/track/track-prefer-captions-expected.txt: Added.
  • media/track/track-prefer-captions.html: Added.
  • platform/mac/Skipped:
8:21 PM Changeset in webkit [106530] by hayato@chromium.org
  • 13 edits in trunk/Source/WebCore

Change class hierarycy so that ShadowRoot can inherit DocumentFragment.
​https://bugs.webkit.org/show_bug.cgi?id=76693

Reviewed by Darin Adler.

Make ShadowRoot inherit DocumentFragment so that it matches the class hierarchy of IDL in the spec.
TreeScope becomes a separated class, which is now inherited by Document and ShadowRoot using multiple-inheritance.
This patch is pre-requirement for coming IDL change.

No tests. No change in behavior.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::buildAccessKeyMap):
(WebCore::Document::childrenChanged):
(WebCore::Document::attach):
(WebCore::Document::detach):

  • dom/Document.h:

(Document):

  • dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::DocumentFragment):

  • dom/DocumentFragment.h:

(DocumentFragment):

  • dom/DocumentOrderedMap.cpp:

(WebCore::DocumentOrderedMap::get):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::~ShadowRoot):
(WebCore::ShadowRoot::attach):

  • dom/ShadowRoot.h:
  • dom/TreeScope.cpp:

(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::~TreeScope):
(WebCore::TreeScope::setParentTreeScope):
(WebCore::TreeScope::getImageMap):
(WebCore::TreeScope::findAnchor):

  • dom/TreeScope.h:

(WebCore):
(WebCore::TreeScope::rootNode):
(TreeScope):

  • dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope):

  • page/DragController.cpp:

(WebCore::asFileInput):

  • page/FocusController.cpp:

(WebCore::ownerOfTreeScope):
(WebCore::FocusController::nextFocusableNode):
(WebCore::FocusController::previousFocusableNode):

8:11 PM Changeset in webkit [106529] by benjamin@webkit.org
  • 5 edits in trunk/Source/WebCore

WorkerScriptController::evaluate() should not return anything
​https://bugs.webkit.org/show_bug.cgi?id=77587

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-02-01
Reviewed by Adam Barth.

Remove the return value from WorkerScriptController as it is
(and should be) unused.

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

  • bindings/js/WorkerScriptController.h:

(WorkerScriptController):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

  • bindings/v8/WorkerScriptController.h:

(WorkerScriptController):

7:25 PM Changeset in webkit [106528] by haraken@chromium.org
  • 13 edits in trunk/Source/WebCore

Remove [DelegatingPrototypeGetOwnPropertySlot], [HasCustomIndexGetter],
[HasIndexSetter], [JSConstructorTemplate] and [NonEmpty] from code generators
​https://bugs.webkit.org/show_bug.cgi?id=77585

Reviewed by Adam Barth.

This patch removes [DelegatingPrototypeGetOwnPropertySlot], [HasCustomIndexGetter],
[HasIndexSetter], [JSConstructorTemplate] and [NonEmpty] from code generators,
since they are not used by no IDL files.

No tests. No change in behavior.

  • bindings/scripts/CodeGenerator.pm:

(GetterExpression):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
(IsConstructable):
(IsConstructorTemplate):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated the run-bindings-tests results.
  • bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.

(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.

(WebCore):

  • bindings/scripts/test/JS/JSTestObj.h: Ditto.

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

(WebCore):

7:22 PM Changeset in webkit [106527] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Select attribute of HTMLContentElement should be able be changed dynamically.
​https://bugs.webkit.org/show_bug.cgi?id=76261

Patch by Shinya Kawanaka <​shinyak@google.com> on 2012-02-01
Reviewed by Hajime Morita.

Source/WebCore:

When select attribute is changed, the flag to recalc style is set.

Test: fast/dom/shadow/content-element-select-dynamic.html

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::parseMappedAttribute):

Sets recalc style when select is changed.

  • html/shadow/HTMLContentElement.h:

(HTMLContentElement):

LayoutTests:

Test cases for changing select attribute dynamically.

  • fast/dom/shadow/content-element-select-dynamic-expected.txt: Added.
  • fast/dom/shadow/content-element-select-dynamic.html: Added.
6:47 PM Changeset in webkit [106526] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

Remove [ImplementationUUID] and [InterfaceUUID] from html/canvas/*.idl
​https://bugs.webkit.org/show_bug.cgi?id=77589

Reviewed by Adam Barth.

[ImplementationUUID] and [InterfaceUUID] are used in html/canvas/*.idl,
but they are not implemented in code generators and thus have no meaning.
This patch removes them.

No tests. No change in behavior.

  • html/canvas/CanvasGradient.idl:
  • html/canvas/CanvasPattern.idl: The file is now empty though.
  • html/canvas/CanvasRenderingContext.idl:
  • html/canvas/CanvasRenderingContext2D.idl:
  • html/canvas/WebGLRenderingContext.idl:
6:46 PM Changeset in webkit [106525] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r106408.
​http://trac.webkit.org/changeset/106408
​https://bugs.webkit.org/show_bug.cgi?id=77592

crashes in chromium mac release tests (Requested by japhet on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-01

  • platform/graphics/Region.cpp:
  • platform/graphics/Region.h:

(Region):
(Shape):

6:42 PM Changeset in webkit [106524] by noam.rosenthal@nokia.com
  • 10 edits in trunk/Source

[Texmap] Use glScissors for clipping in TextureMapperGL when possible
​https://bugs.webkit.org/show_bug.cgi?id=77575

Reviewed by Martin Robinson.

Source/WebCore:

Maintain a clipping stack, that helps us use stencils in conjunction with scissors.
We apply scissors when the clip region is rectalinear, and stencil when it's not.

No behavior changes so no new tests.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(SharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::SharedGLData):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::bindSurface):
(WebCore):
(WebCore::scissorClip):
(WebCore::TextureMapperGL::beginScissorClip):
(WebCore::TextureMapperGL::endScissorClip):
(WebCore::TextureMapperGL::beginClip):
(WebCore::TextureMapperGL::endClip):

  • platform/graphics/opengl/TextureMapperGL.h:

(TextureMapperGL):

Source/WebKit2:

Instead of applying the scissor clip in QQuickWebPage, we trickle it down to
TextureMapperGL, and apply it there as part of beginClip(). All direct GL operations are
now cleaned out of QQuickWebPage.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::paintToCurrentGLContext):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::paintToCurrentGLContext):

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::paintToCurrentGLContext):

  • UIProcess/DrawingAreaProxyImpl.h:

(DrawingAreaProxyImpl):

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):

6:34 PM Changeset in webkit [106523] by andersca@apple.com
  • 2 edits
    3 moves
    2 adds in trunk/Source/WebCore

Move the scrolling coordinator to page/scrolling
​https://bugs.webkit.org/show_bug.cgi?id=77590

Reviewed by Dan Bernstein.

Put scrolling related files in page/scrolling to avoid cluttering the page directory.

  • WebCore.xcodeproj/project.pbxproj:
  • page/scrolling/ScrollingCoordinator.cpp: Renamed from Source/WebCore/page/ScrollingCoordinator.cpp.
  • page/scrolling/ScrollingCoordinator.h: Renamed from Source/WebCore/page/ScrollingCoordinator.h.
  • page/scrolling/mac/ScrollingCoordinatorMac.mm: Renamed from Source/WebCore/page/mac/ScrollingCoordinatorMac.mm.
6:27 PM Changeset in webkit [106522] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Remove [ObjCPrefix], [V8ConstructorTemplate], [allowAccessToNode],
[v8implname] and [v8referenceattr] from code generators
​https://bugs.webkit.org/show_bug.cgi?id=77588

Reviewed by Adam Barth.

This patch removes [ObjCPrefix], [V8ConstructorTemplate], [allowAccessToNode],
[v8implname] and [v8referenceattr] from code generators, since they are not used
by any IDL files.

No tests. No changes in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(IsConstructable):
(IsConstructorTemplate):
(GenerateNormalAttrGetter):
(GenerateFunctionCallString):

6:19 PM Changeset in webkit [106521] by msaboff@apple.com
  • 5 edits in trunk

Yarr crash with regexp replace
​https://bugs.webkit.org/show_bug.cgi?id=67454

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Properly handle the case of a back reference to an unmatched
subpattern by always matching without consuming any characters.

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::matchBackReference):
(JSC::Yarr::Interpreter::backtrackBackReference):

LayoutTests:

New tests to check for proper handling of back references to
unmatched subpatterns.

  • fast/js/regexp-backreferences-expected.txt:
  • fast/js/script-tests/regexp-backreferences.js:
6:11 PM Changeset in webkit [106520] by abarth@webkit.org
  • 2 edits in trunk/Tools

Update the tests to show that the mac-ews processes patches from
non-committers.

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(EarlyWarningSytemTest.test_committer_only_ewses):
(EarlyWarningSytemTest.test_builder_ewses):

6:08 PM Changeset in webkit [106519] by abarth@webkit.org
  • 2 edits in branches/chromium/1025/Source/WebCore/platform/network

Merge 106514 - contentDispositionType misparses the Content-Disposition header in some obscure corner cases
​https://bugs.webkit.org/show_bug.cgi?id=77577

Reviewed by Eric Seidel.

The contentDispositionType extracts the disposition-type from the
Content-Disposition header. According to RFC 6266 (and previous RFCs),
the disposition-type must be an RFC 2616 token. Rather than enforce
this general rule, we had special-cased some examples (including
name=foo and filename=bar). This patch generalizes our check to
properly validate that the disposition-type is an RFC 2616 token.

In conjunction with some other work in the Chromium network stack, this
causes Chromium to pass the following tests:

​http://greenbytes.de/tech/tc2231/#inlonlyquoted
​http://greenbytes.de/tech/tc2231/#attonlyquoted

Without this patch, these test cases neither trigger a navigation nor a
download in Chromium. This patch does not appear to cause any visible
change in Safari. (Safari passes these tests both before and after
this patch.)

  • platform/network/HTTPParsers.cpp:

(WebCore::isRFC2616Token):
(WebCore::contentDispositionType):

  • This patch also adds a comment to filenameFromHTTPContentDisposition, which explains some of the was this function incorrectly implements the requirements in RFC 6266. Resolving these issues is a subject for a future patch.
  • platform/network/HTTPParsers.h:

TBR=​abarth@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/9309049

5:56 PM Changeset in webkit [106518] by abarth@webkit.org
  • 9 edits in trunk/Tools

Mac-ews logs are huge
​https://bugs.webkit.org/show_bug.cgi?id=77045

Reviewed by Eric Seidel.

In order to get the cr-linux-ews bot to run tests on EC2, we created
the chromium-xvfb port, which contained a number of tweaks to the
Chromium port's behavior. This patch refactors those tweaks so they
can be shared with the mac-ews, mostly by moving them into the
non-interactive mode of RunTests.

  • Scripts/webkitpy/common/config/ports.py:

(WebKitPort):
(WebKitPort.layout_tests_results_path):
(ChromiumPort.run_javascriptcore_tests_command):
(ChromiumXVFBPort):
(ChromiumXVFBPort.run_webkit_tests_command):

  • Scripts/webkitpy/common/config/ports_mock.py:

(MockPort):
(MockPort.layout_tests_results_path):

  • Scripts/webkitpy/common/config/ports_unittest.py:

(WebKitPortTest.test_chromium_xvfb_port):

  • Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:

(LayoutTestResultsReaderTest.test_missing_layout_test_results):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

(CommitQueueTest.test_commit_queue):
(test_rollout):
(test_manual_reject_during_processing):

  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

  • Scripts/webkitpy/tool/steps/runtests_unittest.py:

(RunTestsTest.test_no_unit_tests):

  • Scripts/webkitpy/tool/steps/steps_unittest.py:

(StepsTest.test_runtests_args):

5:40 PM Changeset in webkit [106517] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Roll out r106442. It made some tests more stable but others less stable.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(create_runner):
(test_run_passing_test):
(test_run_silent_test):
(test_run_failed_test):
(test_run_tonguey_test):
(test_run_timeout_test):
(test_run_crash_test):
(test_run_test_set):

5:39 PM Changeset in webkit [106516] by commit-queue@webkit.org
  • 5 edits in trunk

Support targetOrigin = "/" in postMessage for sending messages to same origin as source document.
​https://bugs.webkit.org/show_bug.cgi?id=77580

Patch by Pablo Flouret <​pablof@motorola.com> on 2012-02-01
Reviewed by Adam Barth.

Source/WebCore:

No new tests. Modified http/tests/security/postMessage/target-origin.html
to test this case as well.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):

LayoutTests:

  • http/tests/security/postMessage/target-origin-expected.txt:
  • http/tests/security/postMessage/target-origin.html:
4:20 PM Changeset in webkit [106515] by caio.oliveira@openbossa.org
  • 32 edits in trunk/Source

Avoid creating NamedNodeMap unnecessarily
​https://bugs.webkit.org/show_bug.cgi?id=77574

Reviewed by Ryosuke Niwa.

Source/WebCore:

The method Element::attributes() was being used for multiple things in our
codebase: (1) as the getter for NamedNodeMap exposed to DOM, (2) as a way to other WebCore
code get the "attribute storage" (currently inside NamedNodeMap), and (3) as a way to
get the attribute storage creating one if necessary.

This commit separate the jobs in different functions:

1) attributes() keeps being the DOM getter, and loses its boolean parameter.

2) updatedAttributes() updates the invalid attributes and returns the attribute
storage. If we don't have one, return 0.

3) ensureUpdatedAttributes() updates the invalid attributes and forces the
creation of attribute storage to return.

There is also another way to get to the attribute storage currently, via
attributeMap(), which doesn't update the attributes for possible changes in Style
or SVG attributes.

Note that the new functions are not available in Node class, so C++ code manipulating
attributes should cast to Element.

This separation also made easier to spot and fix some places where we do not
need to create the attribute storage if it doesn't exist.

No new tests, this commit shouldn't change the behavior of existing code.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector):

  • dom/DatasetDOMStringMap.cpp:

(WebCore::DatasetDOMStringMap::getNames):
(WebCore::DatasetDOMStringMap::item):
(WebCore::DatasetDOMStringMap::contains):

  • dom/Document.cpp:

(WebCore::Document::importNode):

  • dom/Element.cpp:

(WebCore::Element::setAttribute):
(WebCore::Element::hasAttributes):
(WebCore::Element::setAttributeNode):
(WebCore::Element::setAttributeNodeNS):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::normalizeAttributes):

  • dom/Element.h:

(Element):
(WebCore::Element::attributes):
(WebCore::Element::ensureAttributeData):
(WebCore::Element::ensureUpdatedAttributes):
(WebCore::Element::updatedAttributes):
(WebCore::Element::setAttributesFromElement):
(WebCore::Element::ensureAttributeMap): Made const to be reused by ensureUpdatedAttributes().
(WebCore::Element::updateInvalidAttributes):
(WebCore):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::mapsEquivalent): Having no attributes is equivalent to
not having an attribute storage because the attribute storage is lazily created.

  • dom/Node.cpp:

(WebCore::Node::isEqualNode): Do not force the creation of attribute storage to
compare two nodes.
(WebCore::Node::isDefaultNamespace): Use updatedAttributes(). Since we iterate
using length, it's OK if the attribute storage is empty.
(WebCore::Node::lookupNamespaceURI): Ditto.
(WebCore::Node::lookupNamespacePrefix): Ditto.
(WebCore::Node::compareDocumentPosition): Ditto.

  • editing/ApplyStyleCommand.cpp:

(WebCore::hasNoAttributeOrOnlyStyleAttribute):
(WebCore::isEmptyFontTag):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::isRemovableBlock): Use isElementNode() explicitly
to identify non-Element nodes, then use hasAttributes() if is Element.

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::highestVisuallyEquivalentDivBelowRoot):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendElement): Do not create the attribute storage
unnecessarily.

  • editing/htmlediting.cpp:

(WebCore::areIdenticalElements): Do not create the attribute storage
unnecessarily. Use mapsEquivalent() for comparing the attributes.

  • editing/markup.cpp:

(WebCore::completeURLs): Do not create the attribute storage unnecessarily.
(WebCore::StyledMarkupAccumulator::appendElement): Ditto.
(WebCore::isPlainTextMarkup): hasAttributes() will avoid creating the attribute
storage unnecessarily.

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::parametersForPlugin):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parametersForPlugin):

  • html/HTMLParamElement.cpp:

(WebCore::HTMLParamElement::isURLAttribute): Do not create the attribute storage
unnecessarily.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement): Use
ensureUpdatedAttributes() since we will add new attributes.
(WebCore):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::buildArrayForElementAttributes):

  • page/PageSerializer.cpp:

(WebCore::isCharsetSpecifyingNode): Do not assume attributeMap will exist.

  • svg/properties/SVGAnimatedPropertySynchronizer.h: Use ensureUpdatedAttributes()

since we will add new attributes.

  • xml/XPathFunctions.cpp:

(WebCore::XPath::FunLang::evaluate): Do not create the attribute storage
unnecessarily.

  • xml/XPathNodeSet.cpp:

(WebCore::XPath::NodeSet::traversalSort):

  • xml/XPathStep.cpp:

(WebCore::XPath::Step::nodesInAxis): Use isElementNode() instead of comparing
nodeType() manually. Do not create the attribute storage unnecessarily.

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser): Do not create the attribute
storage unnecessarily.

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser): Ditto.

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::XMLTreeBuilder): Ditto.

Source/WebKit/chromium:

  • src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::openTagToString): use updatedAttributes().

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(QWebElement::attributeNames): use updateAttributes().

4:14 PM Changeset in webkit [106514] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

contentDispositionType misparses the Content-Disposition header in some obscure corner cases
​https://bugs.webkit.org/show_bug.cgi?id=77577

Reviewed by Eric Seidel.

The contentDispositionType extracts the disposition-type from the
Content-Disposition header. According to RFC 6266 (and previous RFCs),
the disposition-type must be an RFC 2616 token. Rather than enforce
this general rule, we had special-cased some examples (including
name=foo and filename=bar). This patch generalizes our check to
properly validate that the disposition-type is an RFC 2616 token.

In conjunction with some other work in the Chromium network stack, this
causes Chromium to pass the following tests:

​http://greenbytes.de/tech/tc2231/#inlonlyquoted
​http://greenbytes.de/tech/tc2231/#attonlyquoted

Without this patch, these test cases neither trigger a navigation nor a
download in Chromium. This patch does not appear to cause any visible
change in Safari. (Safari passes these tests both before and after
this patch.)

  • platform/network/HTTPParsers.cpp:

(WebCore::isRFC2616Token):
(WebCore::contentDispositionType):

  • This patch also adds a comment to filenameFromHTTPContentDisposition, which explains some of the was this function incorrectly implements the requirements in RFC 6266. Resolving these issues is a subject for a future patch.
  • platform/network/HTTPParsers.h:
4:09 PM Changeset in webkit [106513] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/win

Another attempt to fix the Windows build.

  • FullscreenVideoController.cpp:

(FullscreenVideoController::LayerClient::platformCALayerDidCreateTiles):

4:08 PM Changeset in webkit [106512] by barraclough@apple.com
  • 12 edits in trunk

calling function on catch block scope containing an eval result in wrong this value being passed
​https://bugs.webkit.org/show_bug.cgi?id=77581

Reviewed by Oliver Hunt.

javascript:function F(){ return 'F' in this; }; try { throw F; } catch (e) { eval(""); alert(e()); }

Source/JavaScriptCore:

  • bytecompiler/NodesCodegen.cpp:

(JSC::TryNode::emitBytecode):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createTryStatement):

  • parser/NodeConstructors.h:

(JSC::TryNode::TryNode):

  • parser/Nodes.h:

(TryNode):

  • parser/Parser.cpp:

(JSC::::parseTryStatement):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createTryStatement):

  • runtime/JSObject.h:

(JSObject):
(JSC::JSObject::isStaticScopeObject):
(JSC):

LayoutTests:

  • fast/js/eval-var-decl-expected.txt:
  • fast/js/script-tests/eval-var-decl.js:

(checkThis):
(testEvalInCatch):

4:01 PM Changeset in webkit [106511] by mitz@apple.com
  • 23 edits in trunk/Source

Source/WebCore: WebCore part of <rdar://problem/10442663> Paginated display does not respect page-break-{before,after}
​https://bugs.webkit.org/show_bug.cgi?id=77505

Reviewed by Darin Adler.

  • page/Page.h:

(WebCore::Page::Pagination::Pagination): Added initializer for the behavesLikeColumns member
variable.
(WebCore::Page::Pagination::operator==): Added comparison of behavesLikeColumns values.
(Pagination): Added behavesLikeColumns member variable. When set to false (the default),
paginated display respects the page-break-{before,after} properties rather than the
column-break-{before,after} ones.

  • rendering/ColumnInfo.h:

(WebCore::ColumnInfo::ColumnInfo): Added initializer for the m_paginationUnit member.
(WebCore::ColumnInfo::paginationUnit): Added this getter.
(WebCore::ColumnInfo::setPaginationUnit): Added this setter.
(ColumnInfo): Added m_paginationUnit member. It defaults to Column.

  • rendering/LayoutState.h:

(WebCore::LayoutState::isPaginatingColumns): Changed to check the pagination unit.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock): Added code to set the pagination unit in the ColumnInfo.
(WebCore::RenderBlock::paginationUnit): Added. The base class implementation returns Column.

  • rendering/RenderBlock.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::paginationUnit): Added this override that returns Page, unless
this is the RenderView for the main frame and pagination is set to behave like columns.

  • rendering/RenderView.h:

Source/WebKit/mac: WebKit/mac part of <rdar://problem/10442663> Paginated display does not respect page-break-{before,after}
​https://bugs.webkit.org/show_bug.cgi?id=77505

Reviewed by Darin Adler.

  • WebView/WebView.mm:

(-[WebView _setPaginationBehavesLikeColumns:]): Added this setter.
(-[WebView _paginationBehavesLikeColumns]): Added this getter.

  • WebView/WebViewPrivate.h:

Source/WebKit2: WebKit2 part of <rdar://problem/10442663> Paginated display does not respect page-break-{before,after}
​https://bugs.webkit.org/show_bug.cgi?id=77505

Reviewed by Darin Adler.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode): Encode paginationBehavesLikeColumns.
(WebKit::WebPageCreationParameters::decode): Decode paginationBehavesLikeColumns.

  • Shared/WebPageCreationParameters.h:

(WebPageCreationParameters): Added paginationBehavesLikeColumns boolean.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPaginationBehavesLikeColumns): Added this setter.
(WKPageGetPaginationBehavesLikeColumns): Added this getter.

  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]): Added this Objective-C
wrapper around WKPageSetPaginationBehavesLikeColumns.
(-[WKBrowsingContextController paginationBehavesLikeColumns]): Added this Objective-C wrapper
around WKPageGetPaginationBehavesLikeColumns.

  • UIProcess/API/mac/WKBrowsingContextControllerPrivate.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy): Added call to setPaginationBehavesLikeColumns() with
the value from the creation parameters.
(WebKit::WebPageProxy::setPaginationBehavesLikeColumns): Added this setter.
(WebKit::WebPageProxy::creationParameters): Populate paginationBehavesLikeColumns.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::paginationBehavesLikeColumns): Added this getter.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setPaginationBehavesLikeColumns): Added this setter.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Added SetPaginationBehavesLikeColumns message.
3:59 PM Changeset in webkit [106510] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Backgrounds in HTML inside foreignObject don't draw
​https://bugs.webkit.org/show_bug.cgi?id=23111

Patch by Florin Malita <​fmalita@google.com> on 2012-02-01
Reviewed by Eric Seidel.

Source/WebCore:

Test: svg/foreignObject/body-background.svg

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBackground):
Tweak the <body> background inhibiting logic to allow drawing when the element is embedded in FOs.

LayoutTests:

  • svg/foreignObject/body-background-expected.png: Added.
  • svg/foreignObject/body-background-expected.txt: Added.
  • svg/foreignObject/body-background.svg: Added.
3:58 PM Changeset in webkit [106509] by Lucas Forschler
  • 2 edits in trunk/Tools

Enable EWS for non-contributers.
​https://bugs.webkit.org/show_bug.cgi?id=77576

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(MacEWS):

3:54 PM Changeset in webkit [106508] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r104727): Strange graphics corruption opening a new tab in Safari
​https://bugs.webkit.org/show_bug.cgi?id=77578
<rdar://problem/10767174>

Reviewed by Dan Bernstein.

Resizing a window will always invalidate the window backing store, so make sure to set
_data->_windowHasValidBackingStore to NO whenever that happens.

  • UIProcess/API/mac/WKView.mm:

(-[WKView addWindowObserversForWindow:]):
Use separate methods for the NSWindowDidMoveNotification and NSWindowDidResizeNotification notifications.

(-[WKView _windowDidMove:]):
Call -[WKView _updateWindowAndViewFrames].

(-[WKView _windowDidResize:]):
Call -[WKView _updateWindowAndViewFrames] and mark the window backing store as invalid.

3:36 PM Changeset in webkit [106507] by Lucas Forschler
  • 5 edits in branches/safari-534.54-branch/Source

Versioning.

3:32 PM Changeset in webkit [106506] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Make one able to set the local storage (tracker) database dir's path
​https://bugs.webkit.org/show_bug.cgi?id=77006

Patch by Gustavo Lima Chaves <​glima@profusion.mobi> on 2012-02-01
Reviewed by Darin Adler.

There are no behavior changes with the diff, so no need for new tests.

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::setDatabaseDirectoryPath):
(WebCore):
(WebCore::StorageTracker::databaseDirectoryPath):

  • storage/StorageTracker.h:

(StorageTracker):

3:29 PM Changeset in webkit [106505] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Fix Window build.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::LayerClient::platformCALayerDidCreateTiles):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerDidCreateTiles):

3:23 PM Changeset in webkit [106504] by oliver@apple.com
  • 24 edits in trunk

Add support for inferred function names
​https://bugs.webkit.org/show_bug.cgi?id=77579

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Add new "inferred" names to function expressions, getters, and setters.
This property is not exposed to JS, so is only visible in the debugger
and profiler.

(JSC::BytecodeGenerator::makeFunction):

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::calculatedFunctionName):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createProperty):
(JSC::ASTBuilder::makeAssignNode):

  • parser/Nodes.h:

(JSC::FunctionBodyNode::setInferredName):
(JSC::FunctionBodyNode::inferredName):
(FunctionBodyNode):

  • profiler/Profiler.cpp:

(JSC):
(JSC::Profiler::createCallIdentifier):
(JSC::createCallIdentifierFromFunctionImp):

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::fromGlobalCode):

  • runtime/Executable.h:

(JSC::FunctionExecutable::create):
(JSC::FunctionExecutable::inferredName):
(FunctionExecutable):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::calculatedDisplayName):
(JSC):
(JSC::getCalculatedDisplayName):

  • runtime/JSFunction.h:

(JSC):

LayoutTests:

Update test case results.

  • fast/profiler/anonymous-event-handler-expected.txt:
  • fast/profiler/anonymous-function-called-from-different-contexts-expected.txt:
  • fast/profiler/anonymous-function-calls-built-in-functions-expected.txt:
  • fast/profiler/anonymous-function-calls-eval-expected.txt:
  • fast/profiler/built-in-function-calls-anonymous-expected.txt:
  • fast/profiler/inline-event-handler-expected.txt:
  • fast/profiler/many-calls-in-the-same-scope-expected.txt:
  • fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt:
  • fast/profiler/multiple-and-different-scoped-function-calls-expected.txt:
  • fast/profiler/multiple-anonymous-functions-called-from-the-same-function-expected.txt:
  • fast/profiler/nested-anonymous-functon-expected.txt:
  • fast/profiler/start-and-stop-profiler-multiple-times-expected.txt:
3:11 PM Changeset in webkit [106503] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

GetMIMEDescription should return const char *
​https://bugs.webkit.org/show_bug.cgi?id=77297

Patch by John Yani <​vanuan@gmail.com> on 2012-02-01
Reviewed by Alexey Proskuryakov.

No new tests. No change in behaviour.

  • plugins/blackberry/PluginPackageBlackBerry.cpp:

(WebCore::PluginPackage::fetchInfo):

  • plugins/efl/PluginPackageEfl.cpp:

(WebCore):
(WebCore::PluginPackage::fetchInfo):

  • plugins/npapi.h:
  • plugins/npfunctions.h:
  • plugins/qt/PluginPackageQt.cpp:

(WebCore::PluginPackage::fetchInfo):

3:08 PM Changeset in webkit [106502] by fpizlo@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

DFG should fold double-to-int conversions
​https://bugs.webkit.org/show_bug.cgi?id=77532

Reviewed by Oliver Hunt.

Performance neutral on major benchmarks. But it makes calling V8's
Math.random() 4x faster.

  • bytecode/CodeBlock.cpp:

(JSC):
(JSC::CodeBlock::addOrFindConstant):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addConstant):
(CodeBlock):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::toInt32):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::getJSConstantForValue):
(JSC::DFG::ByteCodeParser::isInt32Constant):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::addShouldSpeculateInteger):
(Graph):
(JSC::DFG::Graph::addImmediateShouldSpeculateInteger):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::doRoundOfDoubleVoting):
(JSC::DFG::Propagator::fixupNode):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileAdd):
(DFG):
(JSC::DFG::SpeculativeJIT::compileArithSub):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::valueOfNumberConstantAsInt32):
(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/JSValueInlineMethods.h:

(JSC::JSValue::asDouble):

3:08 PM Changeset in webkit [106501] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Consolidate duplicate "willHide" functions in DetailedHeapshotView.js to fix
a syntax error in JSC and make the Inspector open again in Release builds.

​https://webkit.org/b/77424

Reviewed by Brian Weinstein.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype.willHide): Consolidated.
(WebInspector.DetailedHeapshotView.prototype.willHide): Removed.

3:05 PM Changeset in webkit [106500] by commit-queue@webkit.org
  • 18 edits in trunk/Source

[Chromium] Enable deferred canvas rendering in the skia port
​https://bugs.webkit.org/show_bug.cgi?id=76732

Patch by Justin Novosad <​junov@chromium.org> on 2012-02-01
Reviewed by Stephen White.

Source/WebCore:

No new tests: covered by existing canvas layout tests

Adding a new setting to enable deferred 2d canvas rendering.
Added support for deferred 2d canvas rendering in ImageBufferSkia
and Canvas2DLayerChromium, mostly plumbing. Deffered rendering
implementation is provided by skia (class SkDeferredCanvas).

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::shouldDefer):
(WebCore):
(WebCore::HTMLCanvasElement::createImageBuffer):

  • html/HTMLCanvasElement.h:

(HTMLCanvasElement):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setAccelerated2dCanvasEnabled):
(WebCore):
(WebCore::Settings::setDeferred2dCanvasEnabled):

  • page/Settings.h:

(Settings):
(WebCore::Settings::deferred2dCanvasEnabled):

  • platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::create):
(ImageBuffer):

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::ImageBuffer):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::ImageBuffer):

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore):
(WebCore::Canvas2DLayerChromium::setCanvas):
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::ImageBuffer):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::prepareForDraw):
(WebCore::AcceleratedDeviceContext::flush):
(WebCore):
(WebCore::createAcceleratedCanvas):
(WebCore::ImageBuffer::ImageBuffer):

  • platform/graphics/wince/ImageBufferWinCE.cpp:

(WebCore::ImageBuffer::ImageBuffer):

  • platform/graphics/wx/ImageBufferWx.cpp:

(WebCore::ImageBuffer::ImageBuffer):

Source/WebKit/chromium:

Adding a new setting for enabling deferred 2d canvas rendering

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setDeferred2dCanvasEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

2:58 PM Changeset in webkit [106499] by Lucas Forschler
  • 1 copy in tags/Safari-534.54.13

New tag.

2:55 PM Changeset in webkit [106498] by Lucas Forschler
  • 5 edits in branches/safari-534.54-branch/Source

Versioning.

2:27 PM Changeset in webkit [106497] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG graph dump for GetScopedVar should show the correct prediction
​https://bugs.webkit.org/show_bug.cgi?id=77530

Reviewed by Geoff Garen.

GetScopedVar has a heap prediction, not a variable prediction. But it does
have a variable. Hence we need to check for heap predictions before checking
for variable predictions.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

2:15 PM Changeset in webkit [106496] by mhahnenberg@apple.com
  • 7 edits in trunk

Replace JSArray destructor with finalizer
​https://bugs.webkit.org/show_bug.cgi?id=77488

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

(JSC::JSArray::finalize): Added finalizer.
(JSC::JSArray::allocateSparseMap): Factored out code for allocating new sparse maps.
(JSC):
(JSC::JSArray::deallocateSparseMap): Factored out code for deallocating sparse maps.
(JSC::JSArray::enterDictionaryMode): Renamed enterSparseMode to enterDictionaryMode
because the old name was confusing because we could have a sparse array that never
called enterSparseMode.
(JSC::JSArray::defineOwnNumericProperty):
(JSC::JSArray::setLengthWritable):
(JSC::JSArray::putByIndexBeyondVectorLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::sort):
(JSC::JSArray::compactForSorting):

  • runtime/JSArray.h:

(JSArray):

LayoutTests:

  • fast/js/script-tests/sparse-array.js: Added code to test oscillation between

sparse and dense arrays.

  • fast/js/sparse-array-expected.txt:
2:12 PM Changeset in webkit [106495] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merged r106207.

2:05 PM Changeset in webkit [106494] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Gcc build fix after r106482.

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

2:02 PM Changeset in webkit [106493] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

rebaseline box-shadow-clipped-slices
​https://bugs.webkit.org/show_bug.cgi?id=77565

Patch by Elliot Poger <​epoger@google.com> on 2012-02-01
Reviewed by Stephen White.

  • platform/chromium-linux/fast/box-shadow/box-shadow-clipped-slices-expected.png:
  • platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
1:52 PM Changeset in webkit [106492] by Beth Dakin
  • 34 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=77383
Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
-and corresponding-
<rdar://problem/10709560>

Reviewed by Sam Weinig.

Source/WebCore:

The goal is to re-vamp didFirstVisuallyNonEmptyLayout to be more accurate.
This patch adds a new heuristic called didNewFirstVisuallNonEmptyLayout and
leaves the old one for the time being. That is temporary.

The heuristic for didNewFirstVisuallNonEmptyLayout is to count relevant
painted RenderObjects on Page.

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::setPaintedObjectsCounterThreshold):
(WebCore::Page::addRelevantRepaintedObject):

  • page/Page.h:

(WebCore):
(Page):
(WebCore::Page::startCountingRepaintedObjects):

  • WebCore.exp.in:

Start counting relevant painted RenderObjects on the page once the first
layout is complete.

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

Machinery for firing didNewFirstVisuallNonEmptyLayout.

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::dispatchDidNewFirstVisuallyNonEmptyLayout):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didNewFirstVisuallyNonEmptyLayout):
(WebCore):

  • loader/FrameLoader.h:

(FrameLoader):

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::dispatchDidNewFirstVisuallyNonEmptyLayout):

These RenderObjects are the ones that this api currently consider to be
relevant. If their repaint rects intersect with the viewRect, then they are
added to the relevant objects set on the Page.

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::paint):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintReplaced):

  • rendering/RenderHTMLCanvas.cpp:

(WebCore::RenderHTMLCanvas::paintReplaced):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::paintReplaced):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::paint):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::paintReplaced):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced):

Source/WebKit2:

Machinery for didNewFirstVisuallNonEmptyLayout.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didNewFirstVisuallyNonEmptyLayout):
(WebKit):

  • UIProcess/WebLoaderClient.h:

(WebLoaderClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didNewFirstVisuallyNonEmptyLayout):
(WebKit):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidNewFirstVisuallyNonEmptyLayout):
(WebKit):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

This temporary API allows the client to specify the threshold for the painted
objects counter on Page. This is temporary.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetPaintedObjectsCounterThreshold):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setPaintedObjectsCounterThreshold):
(WebKit):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

Tools:

WebKit2's WebLoaderClient has a temporary new function that must be accounted
for.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

1:49 PM Changeset in webkit [106491] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r106286.

1:48 PM Changeset in webkit [106490] by alexis.menard@openbossa.org
  • 8 edits
    2 adds in trunk

CSSStyleDeclaration.getPropertyPriority() fails for CSS shorthand properties with 'important' priority
​https://bugs.webkit.org/show_bug.cgi?id=49058

Reviewed by Andreas Kling.

Source/WebCore:

CSSMutableStyleDeclaration::getPropertyPriority was not handling shorthands properly. Shorthands are
not part of the property list of the style so we need to query the longhands which are the one added
in the list. Only if the longhands have equal priority the shorthand priority is known. I also renamed
getPropertyPriority (not the CSSOM exposed method) to something more consistent with WebKit naming guidelines.

Test: fast/css/shorthand-priority.html

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::propertyIsImportant):
(WebCore::CSSMutableStyleDeclaration::addParsedProperty):
(WebCore::CSSMutableStyleDeclaration::getPropertyPriority):

  • css/CSSMutableStyleDeclaration.h:

(CSSMutableStyleDeclaration):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::extractAndRemoveTextDirection):
(WebCore::EditingStyle::collapseTextDecorationProperties):
(WebCore::EditingStyle::conflictsWithInlineStyleOfElement):
(WebCore::setTextDecorationProperty):

  • editing/RemoveCSSPropertyCommand.cpp:

(WebCore::RemoveCSSPropertyCommand::doApply):

Source/WebKit/qt:

Update the code as getPropertyPriority has been renamed to propertyIsImportant.

  • Api/qwebelement.cpp:

(QWebElement::styleProperty):

LayoutTests:

  • fast/css/shorthand-priority-expected.txt: Added.
  • fast/css/shorthand-priority.html: Added.
1:46 PM Changeset in webkit [106489] by Lucas Forschler
  • 10 edits in branches/safari-534.54-branch/Source

Merged r106271.

1:34 PM Changeset in webkit [106488] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Crash in EventHandler::updateDragAndDrop
​https://bugs.webkit.org/show_bug.cgi?id=77569

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: fast/events/remove-target-with-shadow-in-drag.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateDragAndDrop):

LayoutTests:

  • fast/events/remove-target-with-shadow-in-drag-expected.txt: Added.
  • fast/events/remove-target-with-shadow-in-drag.html: Added.
1:18 PM Changeset in webkit [106487] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Unreviewed, rolling out r106382.
​http://trac.webkit.org/changeset/106382
​https://bugs.webkit.org/show_bug.cgi?id=77571

Causing chromium crashes in PNGImageDecoder (Requested by
japhet on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-01

Source/WebCore:

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::evaluate):

  • page/Console.cpp:

(WebCore::Console::time):
(WebCore::Console::timeEnd):

  • platform/chromium/PlatformSupport.h:
  • platform/chromium/TraceEvent.h:

(internal):
(ScopeTracer):
(WebCore::internal::ScopeTracer::ScopeTracer):
(WebCore::internal::ScopeTracer::~ScopeTracer):

Source/WebKit/chromium:

  • public/platform/WebKitPlatformSupport.h:

(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::isTraceEventEnabled):
(WebKit::WebKitPlatformSupport::traceEventBegin):
(WebKit::WebKitPlatformSupport::traceEventEnd):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::isTraceEventEnabled):
(WebCore):
(WebCore::PlatformSupport::traceEventBegin):
(WebCore::PlatformSupport::traceEventEnd):

12:48 PM Changeset in webkit [106486] by Martin Robinson
  • 4 edits in releases/WebKitGTK/webkit-1.6

.: Update the version number in preparation for the 1.6.3 release.

Reviewed by Xan Lopez.

  • configure.ac: Update the library version.

Source/WebKit/gtk: Update the NEWS file in preparation for the 1.6.3 release.

Reviewed by Xan Lopez.

  • NEWS: Update this file.
12:39 PM Changeset in webkit [106485] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.6

Manually pull in the gthread library, as it seems that
with gold it doesn't happen automatically.

Reviewed by Xan Lopez.

  • Source/autotools/webkit.m4:
12:10 PM Changeset in webkit [106484] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.6

Restore Source/WebKit/gtk/webkit/webkitversion.h to the list of files
processed by autoconfig.

  • configure.ac: Re-add the file.
12:02 PM Changeset in webkit [106483] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Reviewed by Darin Adler.

Simplify the code that creates a new tile layer by getting a reference to the RetainPtr<WebTileLayer>&
slot in the hash map and assign directly into it.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::revalidateTiles):

11:59 AM Changeset in webkit [106482] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

Tile cache doesn't have an upper limit
​https://bugs.webkit.org/show_bug.cgi?id=77564
<rdar://problem/10710744>

Reviewed by Darin Adler.

Cache enough tiles to cover 3x the visible height and 2x the visible width of the page,
and drop tiles that are outside that area.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::platformCALayerDidCreateTiles):
Call GraphicsLayerClient::notifySyncRequired here, which will schedule a layer flush and ensure that
the page layout is up to date before the new tiles are painted.

  • platform/graphics/ca/PlatformCALayerClient.h:

Add platformCALayerDidCreateTiles member function.

  • platform/graphics/ca/mac/TileCache.h:

Update for new/removed member functions and member variables.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::TileCache):
Initialize the tile revalidation timer.

(WebCore::TileCache::tileCacheLayerBoundsChanged):
If we don't have any tiles at all right now, revalidate the tiles immediately. Otherwise,
schedule the revalidation timer.

(WebCore::TileCache::setNeedsDisplayInRect):
Return early if we have no tiles.

(WebCore::TileCache::visibleRectChanged):
Schedule tile revalidation.

(WebCore::TileCache::rectForTileIndex):
New helper function that returns the bounds rect of a tile given its tile index.

(WebCore::TileCache::getTileIndexRangeForRect):
Clamp the rect to the bounds of the tile cache layer.

(WebCore::TileCache::scheduleTileRevalidation):
Schedule the revalidation timer if it hasn't already been scheduled.

(WebCore::TileCache::tileRevalidationTimerFired):
Call revalidateTiles.

(WebCore::TileCache::revalidateTiles):
Compute the tile coverage rect and remove all tiles that are outside. Create new tiles for any
parts of the tile coverage rect that don't have tiles already.

(WebCore::TileCache::tileLayerAtIndex):
Remove invalid assertions.

11:52 AM Changeset in webkit [106481] by dpranke@chromium.org
  • 4 edits
    3 adds in trunk

TestWebKitAPI isn't being built on chromium bots any more
​https://bugs.webkit.org/show_bug.cgi?id=77563

Reviewed by Dimitri Glazkov.

I accidentally dropped it in the refactoring in r105449.

Source/WebKit/chromium:

  • All.gyp:

Tools:

  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
11:41 AM Changeset in webkit [106480] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Fixed some lines in the date-constructor.js test.
​https://bugs.webkit.org/show_bug.cgi?id=75892

Patch by Szilard Ledan <​Ledan-Muntean.Szilard@stud.u-szeged.hu> on 2012-02-01
Reviewed by Gavin Barraclough.

  • fast/js/date-constructor-expected.txt:
  • fast/js/script-tests/date-constructor.js:
11:38 AM Changeset in webkit [106479] by commit-queue@webkit.org
  • 5 edits
    14 adds in trunk

Source/WebCore: Add support for fixed and percent min-width on the table element for table-layout: auto to
match Firefox and Opera's behavior.

In FixedTableLayout.cpp, the computePreferredLogicalWidths method looks like it has
issues based on the comment: "FIXME: This entire calculation is incorrect for both
minwidth and maxwidth." (minwidth and maxwidth refer to the preferred widths, not the
min-width and max-width styles). I have not implemented min-width for FixedTableLayout
in this patch since it requires some more research around that comment.

min-width and max-width on the table element was discussed on the www-style list:
​http://lists.w3.org/Archives/Public/www-style/2012Jan/0684.html

min-width is not implemented on <table> for table-layout: auto
​https://bugs.webkit.org/show_bug.cgi?id=76553

Patch by Max Vujovic <​mvujovic@adobe.com> on 2012-02-01
Reviewed by Julien Chaffraix.

Test: fast/table/min-width.html

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::computePreferredLogicalWidths):

If the min or max preferred logical width is less than a fixed min width style, it is
set to the fixed min width style. Like a percent width style, a percent min-width style
does not affect the min or max preferred logical widths computed by the table layout
algorithm. RenderTable's computeLogicalWidth method handles percent min-width styles.

min-width for the table-layout: fixed case has been split out into this bug:
​https://bugs.webkit.org/show_bug.cgi?id=76948

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):

If the RenderStyle's logical min width is defined and greater than the logical width
calculation, this method sets the logical width to the logical min width.

(WebCore::RenderTable::convertStyleWidthToComputedWidth):

This new method generalizes and factors out logic from RenderTable::computeLogicalWidth
that converted the width style to a computed value in the fixed and percent case.
RenderTable::computeLogicalWidth now calls this method to determine the computed values
for both the width style and the min-width style. In the future, it can also be used for
the max-width style.

Note that this method handles the special CSS table case, which requires borders and
paddings to be included in the computed width calculation. This applies to all width
styles, including width, min-width, and max-width. Before, this special case was handled
in RenderTable::computeLogicalWidth.

  • rendering/RenderTable.h:

LayoutTests: Add support for min-width on the table element.

min-width is not implemented on <table> for table-layout: auto
​https://bugs.webkit.org/show_bug.cgi?id=76553

Patch by Max Vujovic <​mvujovic@adobe.com> on 2012-02-01
Reviewed by Julien Chaffraix.

  • fast/table/min-width-css-block-table.html: Added.
  • fast/table/min-width-css-block-table-expected.txt: Added.
  • fast/table/min-width-css-inline-table.html: Added.
  • fast/table/min-width-css-inline-table-expected.txt: Added.
  • fast/table/min-width-html-block-table.html: Added.
  • fast/table/min-width-html-block-table-expected.txt: Added.
  • fast/table/min-width-html-inline-table.html: Added.
  • fast/table/min-width-html-inline-table-expected.txt: Added.
  • fast/table/script-tests/min-width-css-block-table.js: Added.

(computeLogicalWidth):

  • fast/table/script-tests/min-width-css-inline-table.js: Added.

(computeLogicalWidth):

  • fast/table/script-tests/min-width-helpers.js: Added.

(runTests):
(createTableStyle):
(computeLogicalWidthHelper):
(createSpan):

  • fast/table/script-tests/min-width-html-block-table.js: Added.

(computeLogicalWidth):

  • fast/table/script-tests/min-width-html-inline-table.js: Added.

(computeLogicalWidth):

11:37 AM Changeset in webkit [106478] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Refactor identifier resolution in BytecodeGenerator
​https://bugs.webkit.org/show_bug.cgi?id=76285

Patch by Andy Wingo <​wingo@igalia.com> on 2012-02-01
Reviewed by Geoffrey Garen.

  • bytecompiler/BytecodeGenerator.h:

(JSC::ResolveResult): New class, to describe the storage
location corresponding to an identifier in a program.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::resolve): New function, replacing
findScopedProperty.
(JSC::BytecodeGenerator::resolveConstDecl): New function,
encapsulating what ConstDeclNode::emitBytecode used to do.
(JSC::BytecodeGenerator::emitGetStaticVar):
(JSC::BytecodeGenerator::emitPutStaticVar): New functions,
corresponding to the old emitGetScopedVar and emitPutScopedVar.
(JSC::BytecodeGenerator::registerFor): Remove version that took an
Identifier&; replaced by ResolveResult::local().
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveBase):
(JSC::BytecodeGenerator::emitResolveBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitResolveWithThis): Change to accept a
"resolveResult" argument. This is more clear, and reduces the
amount of double analysis happening at compile-time.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ResolveNode::emitBytecode):
(JSC::EvalFunctionCallNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::PostfixResolveNode::emitBytecode):
(JSC::DeleteResolveNode::emitBytecode):
(JSC::TypeOfResolveNode::emitBytecode):
(JSC::PrefixResolveNode::emitBytecode):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):
(JSC::ForInNode::emitBytecode): Refactor to use the new
ResolveResult structure.

11:21 AM Changeset in webkit [106477] by commit-queue@webkit.org
  • 4 edits in trunk

[SKIA/CHROMIUM] Perform getImageData format conversions using Skia
​https://bugs.webkit.org/show_bug.cgi?id=77553

Patch by Brian Salomon <​bsalomon@google.com> on 2012-02-01
Reviewed by Stephen White.

Source/WebCore:

Many existing canvas tests exercise this functionality.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::getImageData):

LayoutTests:

  • platform/chromium/test_expectations.txt:
10:45 AM Changeset in webkit [106476] by Nate Chapin
  • 3 edits
    3 adds in trunk

Source/WebCore: preventDefault() in a mousedown in a subframe should not
prevent the scrollbar from handling mouse movements if the
cursor leaves the subframe.
​https://bugs.webkit.org/show_bug.cgi?id=73097

Reviewed by Darin Adler.

Test: fast/events/scroll-div-with-prevent-default-in-subframe.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):

LayoutTests: Test for ​https://bugs.webkit.org/show_bug.cgi?id=73097.
Test adapted from repro case provided by ​zacklloyd@google.com.

Reviewed by Darin Adler.

  • fast/events/resources/subframe-with-scrollable-div.html: Added.
  • fast/events/scroll-div-with-prevent-default-in-subframe-expected.txt: Added.
  • fast/events/scroll-div-with-prevent-default-in-subframe.html: Added.
10:29 AM Changeset in webkit [106475] by hans@chromium.org
  • 5 edits in trunk

Rename WebSpeechInputResult::set() to assign()
​https://bugs.webkit.org/show_bug.cgi?id=77540

Reviewed by Darin Fisher.

Source/WebKit/chromium:

It was suggested in a previous code review
(​https://bugs.webkit.org/show_bug.cgi?id=77083#c5)
that this function should be called assign().

  • public/WebSpeechInputResult.h:

(WebSpeechInputResult):
(WebKit::WebSpeechInputResult::set):

  • src/WebSpeechInputResult.cpp:

(WebKit::WebSpeechInputResult::assign):

Tools:

  • DumpRenderTree/chromium/MockWebSpeechInputController.cpp:

(MockWebSpeechInputController::addMockRecognitionResult):
(MockWebSpeechInputController::speechTaskFired):

10:04 AM Changeset in webkit [106474] by Carlos Garcia Campos
  • 3 edits in trunk/Tools

[GTK] WebKit1 API documentation is not generated when building with gtk-2.0
​https://bugs.webkit.org/show_bug.cgi?id=77542

Reviewed by Martin Robinson.

  • gtk/generate-gtkdoc: Check first whether there's

webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
instead.
(get_webkit2_options): Return just the options since the
pkg_config_path doesn't depend on options
(get_webkit1_options): Ditto.
(generate_doc): Helper function to create a generator and generate
documentation for the given pkg-config file with the given options.

  • gtk/gtkdoc.py:

(GTKDoc.init): Don't use for args parameter, since it's
used as a dict and never expanded.
(PkgConfigGTKDoc.init): Ditto.

10:01 AM Changeset in webkit [106473] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] API documentation is not installed even when building with --enable-gtk-doc
​https://bugs.webkit.org/show_bug.cgi?id=77094

Reviewed by Martin Robinson.

  • GNUmakefile.am: Add install-data-local and uninstall-local rules

to install/uninstall WebKit1 and WebKit2 API documentation.

9:58 AM Changeset in webkit [106472] by mario@webkit.org
  • 4 edits in trunk

[GTK] editing/inserting/4960120-2.html flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=76815

Reviewed by Martin Robinson.

Source/WebCore:

Check if the node for the first parent object not ignoring
accessibility is null before using it. This might happen with
certain kind of accessibility objects, such as the root one (the
scroller containing the webArea object as its only child).

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(objectFocusedAndCaretOffsetUnignored): Add missing null check.

LayoutTests:

  • platform/gtk/test_expectations.txt: Unskipping tests that

shouldn't be crashing from now on.

9:41 AM Changeset in webkit [106471] by Antti Koivisto
  • 10 edits in trunk/Source/WebCore

Make CSSMappedAttributeDeclaration have CSSMutableStyleDeclaration instead of being one
​https://bugs.webkit.org/show_bug.cgi?id=77545

Reviewed by Andreas Kling.

This is the easiest path for eliminating the last remaining subclass of CSSMutableStyleDeclaration.

On negative side this increases memory use of CSSMappedAttributeDeclaration by one ptr and refcount
(it loses the vptr) in total.

This is not meant to be the end state, just an intermediate refactoring step. CSSMappedAttributeDeclaration
should clearly be renamed too but this patch doesn't do that. It might not exist in its current form
much longer.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::setProperty):
(WebCore::CSSMutableStyleDeclaration::merge):

  • css/CSSMutableStyleDeclaration.h:

Remove protected section. No subclasses remain.
Rename setPropertyInternal() to setProperty(). All public methods here are internal.


(CSSMutableStyleDeclaration):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseMappedAttributeValue):

  • dom/Attribute.cpp:

(WebCore::Attribute::clone):

  • dom/Attribute.h:

(Attribute):
(WebCore::Attribute::decl):
(WebCore::Attribute::mappedAttributeDeclaration):
(WebCore::Attribute::setMappedAttributeDeclaration):
(WebCore::Attribute::Attribute):

  • dom/CSSMappedAttributeDeclaration.cpp:

(WebCore::CSSMappedAttributeDeclaration::setMappedImageProperty):
(WebCore::CSSMappedAttributeDeclaration::setMappedProperty):
(WebCore::CSSMappedAttributeDeclaration::removeMappedProperty):

  • dom/CSSMappedAttributeDeclaration.h:

(CSSMappedAttributeDeclaration):
(WebCore::CSSMappedAttributeDeclaration::declaration):
(WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):

Make CSSMutableStyleDeclaration a member instead of the base class.


  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::removeCSSProperty):
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):
(WebCore::StyledElement::addCSSLength):
(WebCore::StyledElement::addCSSColor):
(WebCore::StyledElement::createMappedDecl):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::getPresentationAttribute):

9:38 AM Changeset in webkit [106470] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Set all PlatformTouchPoint values possible from a QTouch event.
​https://bugs.webkit.org/show_bug.cgi?id=77442

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-02-01
Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/PlatformTouchPointQt.cpp:

(WebCore::PlatformTouchPoint::PlatformTouchPoint):

9:22 AM Changeset in webkit [106469] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: move type builder code to dedicated InspectorTypeBuilder .h/.cpp
​https://bugs.webkit.org/show_bug.cgi?id=77471

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-02-01
Reviewed by Yury Semikhatsky.

Code is moved physically to other file -- generator is changed accrodingly.

  • inspector/CodeGeneratorInspector.py:

(String):
(provides):
(typename):
(Array):

9:03 AM Changeset in webkit [106468] by yurys@chromium.org
  • 6 edits
    2 adds in trunk

Web Inspector: debugger reports wrong sources when paused in inline script on page reload
​https://bugs.webkit.org/show_bug.cgi?id=77548

Source/WebCore:

V8 returns treats each script source as ending with \n, now we take
this into account when reporting script line count to the inspector
front-end.

Reviewed by Vsevolod Vlasov.

Test: inspector/debugger/pause-in-inline-script.html

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::dispatchDidParseSource):

  • bindings/v8/DebuggerScript.js:

LayoutTests:

Reviewed by Vsevolod Vlasov.

  • inspector/debugger/debugger-scripts-expected.txt:
  • inspector/debugger/pause-in-inline-script-expected.txt: Added.
  • inspector/debugger/pause-in-inline-script.html: Added.
  • platform/chromium/inspector/debugger/debugger-scripts-expected.txt:
8:50 AM Changeset in webkit [106467] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] unittests/testloading crashes
​https://bugs.webkit.org/show_bug.cgi?id=77544

Patch by Philippe Normand <​pnormand@igalia.com> on 2012-02-01
Reviewed by Xan Lopez.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidFailLoading): Bail out
early from dispatchDidFailLoading if the error is the result of an
interrupted load.

6:54 AM Changeset in webkit [106466] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed, rolling out r106460.
​http://trac.webkit.org/changeset/106460
​https://bugs.webkit.org/show_bug.cgi?id=77552

It break unit tests if WEBKIT_TESTFONTS isn't defined.
(Requested by Ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-01

  • Scripts/webkitpy/layout_tests/port/qt.py:
5:53 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
5:50 AM Changeset in webkit [106465] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Content element should be able to be dynamically added/removed/replaced in a shadow tree.
​https://bugs.webkit.org/show_bug.cgi?id=76611

Patch by Shinya Kawanaka <​shinyak@google.com> on 2012-02-01
Reviewed by Hajime Morita

Source/WebCore:

When a content element is added/removed/replaced in a shadow tree, we have to recreate
the shadow tree to recalculate inclusions of content elements. Currently we didn't recalculate it
when content element is removed. (When added, it is recalculated.)
This patch enables us to recalcurate the shadow tree when content element is removed.

Test: fast/dom/shadow/content-element-move.html

  • dom/Element.cpp:

(WebCore::Element::attach):

If a shadow root exists, attaches shadow tree before attaching child elements.

  • dom/ShadowRoot.cpp: Added a flag to recalculate shadow tree.

(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::recalcShadowTreeStyle):

Recalculates light children and shadow tree.

(WebCore::ShadowRoot::setNeedsReattachHostChildrenAndShadow):
(WebCore::ShadowRoot::reattachHostChildrenAndShadow):

Detaches shadow tree and host light children, and attaches them again.

  • dom/ShadowRoot.h:

(WebCore::ShadowRoot::clearNeedsReattachHostChildrenAndShadow):
(WebCore::ShadowRoot::needsReattachHostChildrenAndShadow):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::attach):

Does not need to detach included elements, because they are not attached in ContainerNode anymore.

(WebCore::HTMLContentElement::detach):

When a content element detached, reattaches a shadow tree.

LayoutTests:

Test cases for appending/removing/replacing content element in a shadow tree.

  • fast/dom/shadow/content-element-move-expected.txt: Added.
  • fast/dom/shadow/content-element-move.html: Added.
5:31 AM Changeset in webkit [106464] by peter@chromium.org
  • 3 edits
    3 adds in trunk

getIntersectionList causes transforms to be recalculated in SVG
​https://bugs.webkit.org/show_bug.cgi?id=77179

Reviewed by Nikolas Zimmermann.

Introduce a local variable to store the element's local-to-parent
transformation matrix in, removing the need for the const_cast and
stopping us from modifying any matrices elsewhere.

Source/WebCore:

Test: svg/custom/intersection-list-transforms.svg

  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::getElementCTM):

LayoutTests:

  • svg/custom/intersection-list-transforms-expected.png: Added.
  • svg/custom/intersection-list-transforms-expected.txt: Added.
  • svg/custom/intersection-list-transforms.svg: Added.
4:02 AM Changeset in webkit [106463] by vsevik@chromium.org
  • 9 edits
    6 adds in trunk

Web Inspector: [InspectorIndexedDB] Add tests for database names and database structure requests.
​https://bugs.webkit.org/show_bug.cgi?id=77439

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: http/tests/inspector/indexeddb/database-names.html

http/tests/inspector/indexeddb/database-structure.html

  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel.prototype.refreshDatabase):

LayoutTests:

  • http/tests/inspector/indexeddb/database-names-expected.txt: Added.
  • http/tests/inspector/indexeddb/database-names.html: Added.
  • http/tests/inspector/indexeddb/database-structure-expected.txt: Added.
  • http/tests/inspector/indexeddb/database-structure.html: Added.
  • http/tests/inspector/indexeddb/indexeddb-test.js: Added.
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
3:37 AM Changeset in webkit [106462] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Scripts navigator becomes empty after "show folders" settings change.
​https://bugs.webkit.org/show_bug.cgi?id=77441

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype._reset):

  • inspector/front-end/utilities.js:
2:55 AM Changeset in webkit [106461] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Automatic clean build feature always do clean build with --no-webkit2
​https://bugs.webkit.org/show_bug.cgi?id=74519

Patch by Nándor Huszka <​huszka.nandor@stud.u-szeged.hu> on 2012-02-01
Reviewed by Tor Arne Vestbø.

Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.

  • qmake/mkspecs/features/features.prf:
2:37 AM Changeset in webkit [106460] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2] run-webkit-tests --qt crashes if WEBKIT_TESTFONTS is not set
​https://bugs.webkit.org/show_bug.cgi?id=77466

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2012-02-01
Reviewed by Kenneth Rohde Christiansen.

Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
is set or if we should raise an error.

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.setup_environ_for_server):

2:31 AM Changeset in webkit [106459] by shawnsingh@chromium.org
  • 6 edits in trunk

Fix the semantics of passing contentsVisible flag to GraphicsLayers
​https://bugs.webkit.org/show_bug.cgi?id=76975

Reviewed by Simon Fraser.

Source/WebCore:

This patch is covered by existing tests, in particular
compositing/visibility/layer-visible-content.html; its
expectations are rebaselined.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

LayoutTests:

  • compositing/visibility/layer-visible-content-expected.txt: rebaselined expected result
  • compositing/visibility/layer-visible-content.html: fixed height so that result is platform-independent
  • platform/chromium/test_expectations.txt: removed fail expectation, it should pass now.
2:25 AM Changeset in webkit [106458] by Philippe Normand
  • 4 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r106445

  • platform/gtk/security/block-test-expected.txt:
  • platform/gtk/security/block-test-no-port-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt:
2:20 AM Changeset in webkit [106457] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[WK2] Unreviewed gardening after r106426.
Skip new failing tests because of missing layoutTestController.dumpResourceResponseMIMETypes().
​https://bugs.webkit.org/show_bug.cgi?id=42543

  • platform/qt-wk2/Skipped: Remove a test also skipped in wk2/Skipped.
  • platform/wk2/Skipped:
2:08 AM Changeset in webkit [106456] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

Unreviewed, another GTK build fix after r106446.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

Restore webKitWebSrcGetProtocols as it was before r106446.

2:05 AM Changeset in webkit [106455] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectaion change.
plugins/createScriptableObject-before-start.html is flaky on LINUX.

  • platform/chromium/test_expectations.txt:
2:00 AM Changeset in webkit [106454] by Csaba Osztrogonác
  • 15 edits
    3 deletes in trunk

Implement Error.stack
​https://bugs.webkit.org/show_bug.cgi?id=66994

Unreviewed, rolling out r106407.

Source/JavaScriptCore:

(JSC::AbstractPC::AbstractPC):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::throwException):

  • interpreter/Interpreter.h:

(JSC):
(Interpreter):

  • jsc.cpp:

(GlobalObject::finishCreation):

  • parser/Parser.h:

(JSC::::parse):

  • runtime/CommonIdentifiers.h:
  • runtime/Error.cpp:

(JSC::addErrorInfo):

  • runtime/Error.h:

(JSC):

LayoutTests:

  • fast/js/exception-properties-expected.txt:
  • fast/js/script-tests/exception-properties.js:
  • fast/js/script-tests/stack-trace.js: Removed.
  • fast/js/stack-trace-expected.txt: Removed.
  • fast/js/stack-trace.html: Removed.
  • platform/chromium/test_expectations.txt:
1:54 AM Changeset in webkit [106453] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectaion change.
media/controls-drag-timebar.html passes or times out on WIN and LINUX.

  • platform/chromium/test_expectations.txt:
1:50 AM Changeset in webkit [106452] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

Unreviewed, GTK build fix after r106446.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
1:49 AM Changeset in webkit [106451] by commit-queue@webkit.org
  • 6 edits
    2 deletes in trunk

Unreviewed, rolling out r106432.
​http://trac.webkit.org/changeset/106432
​https://bugs.webkit.org/show_bug.cgi?id=77529

it breaks tests (Requested by shinyak on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-01

Source/WebCore:

  • dom/Element.cpp:

(WebCore::Element::attach):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::recalcShadowTreeStyle):

  • dom/ShadowRoot.h:

(ShadowRoot):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):

LayoutTests:

  • fast/dom/shadow/content-element-move-expected.txt: Removed.
  • fast/dom/shadow/content-element-move.html: Removed.
1:47 AM Changeset in webkit [106450] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Fix after r106386. The empty anchor element was generating an erroneous whitespace.

  • Bindings/event-target-wrapper.html:
1:44 AM Changeset in webkit [106449] by hayato@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary [OldStyleObjC] from ShadowRoot.idl.
​https://bugs.webkit.org/show_bug.cgi?id=77516

Reviewed by Kentaro Hara.

No new tests. No change in behavior.

  • dom/ShadowRoot.idl:
1:39 AM Changeset in webkit [106448] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Another fix after r106379.

  • Parser/html5-full-render.html:
1:38 AM Changeset in webkit [106447] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectaion change.
svg/text/text-align-04-b.svg is flaky on WIN and LINUX.

  • platform/chromium/test_expectations.txt:
1:36 AM Changeset in webkit [106446] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer] 0.11 webkitwebsrc
​https://bugs.webkit.org/show_bug.cgi?id=77086

Port the webkitwebsrc element to GStreamer 0.11 APIs.

Reviewed by Gustavo Noronha Silva.

No new tests, existing http media layout tests should cover this.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webkit_web_src_class_init):

1:29 AM Changeset in webkit [106445] by Philippe Normand
  • 11 edits
    1 add in trunk

Source/WebKit/gtk: Patch by Philippe Normand <​pnormand@igalia.com> and Sergio Villar Senin <​svillar@igalia.com> on 2012-02-01
Reviewed by Martin Robinson.

[GTK] Improve FrameLoader signals. Resource loading
​https://bugs.webkit.org/show_bug.cgi?id=49543

New signals:
WebKitWebFrame::resource-request-starting
WebKitWebFrame::resource-response-received
WebKitWebFrame::resource-load-finished
WebKitWebFrame::resource-content-length-received
WebKitWebFrame::resource-load-failed
WebKitWebResource::response-received
WebKitWebResource::load-failed
WebKitWebResource::load-finished
WebKitWebResource::content-length-received
WebKitWebView::resource-response-received
WebKitWebView::resource-load-finished
WebKitWebView::resource-content-length-received
WebKitWebView::resource-load-failed

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchWillSendRequest):
(WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
(WebKit::FrameLoaderClient::dispatchDidReceiveContentLength):
(WebKit::FrameLoaderClient::dispatchDidFinishLoading):
(WebKit::FrameLoaderClient::dispatchDidFailLoading):

  • webkit/webkitwebframe.cpp:

(webkit_web_frame_class_init):

  • webkit/webkitwebresource.cpp:

(webkit_web_resource_class_init):

  • webkit/webkitwebview.cpp:

(webkit_web_view_class_init):

  • webkitmarshal.list:

Tools: Patch by Philippe Normand <​pnormand@igalia.com> and Sergio Villar Senin <​svillar@igalia.com> on 2012-02-01
Reviewed by Martin Robinson.

[GTK] Improve FrameLoader signals. Resource loading
​https://bugs.webkit.org/show_bug.cgi?id=49543

Support for the new loader signals in DRT.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(urlPath):
(willSendRequestCallback):
(urlSuitableForTestResult):
(descriptionSuitableForTestResult):
(didReceiveResponse):
(didFinishLoading):
(didFailLoadingWithError):
(createWebView):

LayoutTests: Reviewed by Martin Robinson.

[GTK] Improve FrameLoader signals. Resource loading
​https://bugs.webkit.org/show_bug.cgi?id=49543

Unskip tests now passing.

  • platform/gtk/Skipped:
  • platform/gtk/fast/loader/file-protocol-fragment-expected.txt: Added.
  • platform/gtk/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
1:22 AM Changeset in webkit [106444] by kkristof@inf.u-szeged.hu
  • 7 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r106373.

  • fast/forms/implicit-submission-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/qt/http/tests/security/cross-frame-access-put-expected.txt:
1:19 AM Changeset in webkit [106443] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectation change.
​https://bugs.webkit.org/show_bug.cgi?id=77521
fast/repaint/search-field-cancel.html is failing on LINUX.

  • platform/chromium/test_expectations.txt:
1:15 AM Changeset in webkit [106442] by rniwa@webkit.org
  • 4 edits in trunk/Tools

run-perf-tests should restart DRT for each test
​https://bugs.webkit.org/show_bug.cgi?id=77506

Reviewed by Adam Barth.

Always restart DRT when running performance tests in order to minimize the dependency between tests.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver.stop):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(create_runner):
(test_run_passing_test):
(test_run_silent_test):
(test_run_failed_test):
(test_run_tonguey_test):
(test_run_timeout_test):
(test_run_crash_test):
(test_run_test_set_kills_drt_per_run):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.init):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):

1:13 AM Changeset in webkit [106441] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectation change.
fast/repaint/textarea-set-disabled.html is failing.
​https://bugs.webkit.org/show_bug.cgi?id=77521

  • platform/chromium/test_expectations.txt:
1:06 AM Changeset in webkit [106440] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectation change.
Layout Test fast/forms/textfield-overflow.html is failing on WIN and LINUX.

  • platform/chromium/test_expectations.txt:
1:01 AM Changeset in webkit [106439] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Disable WebFrameTest.FindInPage
​https://bugs.webkit.org/show_bug.cgi?id=77186

Disable it because PlatformContextSkiaTest.trackOpaqueOvalTest has
been failing since FindInPage test was committed.

  • tests/WebFrameTest.cpp:

(WebKit::TEST_F):

12:52 AM Changeset in webkit [106438] by hans@chromium.org
  • 17 edits
    2 adds in trunk

Speech Input: Report speech element rect relative to window rather than frame
​https://bugs.webkit.org/show_bug.cgi?id=76443

Reviewed by Darin Fisher.

Source/WebCore:

When requesting speech input, report the speech element rect relative
to the window rather than the frame. The embedder will typically use
this position to show a bubble indicating that speech recognition is
in progress.

Test: fast/speech/bubble-position.html

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

Tools:

Update LayoutTestController to allow for retrieving the speech
element's position used in a request.

In Chromium this is handled by the MockWebSpeechInputController;
adding stubs for the other implementations.

  • DumpRenderTree/LayoutTestController.cpp:

(setMockSpeechInputDumpRectCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::setMockSpeechInputDumpRect):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/chromium/MockWebSpeechInputController.cpp:

(MockWebSpeechInputController::setDumpRect):
(MockWebSpeechInputController::clearResults):
(MockWebSpeechInputController::startRecognition):
(MockWebSpeechInputController::MockWebSpeechInputController):
(makeRectResult):
(MockWebSpeechInputController::speechTaskFired):

  • DumpRenderTree/chromium/MockWebSpeechInputController.h:

(MockWebSpeechInputController):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setMockSpeechInputDumpRect):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setMockSpeechInputDumpRect):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setMockSpeechInputDumpRect):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setMockSpeechInputDumpRect):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setMockSpeechInputDumpRect):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::setMockSpeechInputDumpRect):

LayoutTests:

Add layout test to check that the element position used when
requesting speech input is relative to the window, not the frame.

  • fast/speech/bubble-position-expected.txt: Added.
  • fast/speech/bubble-position.html: Added.
12:09 AM Changeset in webkit [106437] by Philippe Normand
  • 6 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r106373 and r106361.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:

Jan 31, 2012:

11:47 PM Changeset in webkit [106436] by rniwa@webkit.org
  • 2 edits in trunk

webkit-perf.appspot.com should accept test results without medians
​https://bugs.webkit.org/show_bug.cgi?id=77513

Reviewed by Hajime Morita.

Don't store 0s when values are not in JSON.

  • Websites/webkit-perf.appspot.com/report_handler.py:

(ReportHandler.post._float_or_none):
(ReportHandler.post):

11:36 PM Changeset in webkit [106435] by kling@webkit.org
  • 7 edits in trunk/Source/WebCore

Make elements that don't have attributes smaller.
<​http://webkit.org/b/76876>

Reviewed by Sam Weinig and Antti Koivisto.

Move the inline style declaration from StyledElement to ElementAttributeData, since having
an inline style declaration also implies having a style attribute on the element.
This saves one CPU word per element that has no attributes.

This reduces memory consumption by 412 kB (on 64-bit) when viewing the full
HTML5 spec at <​http://whatwg.org/c>.

This was rolled out once because of a performance regression which has been averted this
time around by adding an Element::ensureAttributeMap() so we can force creation of the
NamedNodeMap without also serializing the inline style for the "style" attribute.

  • dom/Element.h:

(Element):
(WebCore::Element::ensureAttributeMap):
(WebCore):

  • dom/ElementAttributeData.h:

(ElementAttributeData):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::ensureInlineStyleDecl):
(WebCore):
(WebCore::NamedNodeMap::destroyInlineStyleDecl):

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::inlineStyleDecl):
(NamedNodeMap):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::addSubresourceAttributeURLs):

  • dom/StyledElement.h:

(WebCore::StyledElement::inlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(StyledElement):
(WebCore::StyledElement::destroyInlineStyleDecl):

10:55 PM Changeset in webkit [106434] by hayato@chromium.org
  • 5 edits in trunk

Add APIs, getElementsByXXX family, to ShadowRoot IDL.
​https://bugs.webkit.org/show_bug.cgi?id=77323

Reviewed by Dimitri Glazkov.

Add APIs (getElementById, getElemesntByTagName, getElementsByClassName and getElementsByTagNameNS)
to ShadowRoot IDL.

Source/WebCore:

  • dom/ShadowRoot.idl:

LayoutTests:

  • fast/dom/shadow/shadow-root-js-api-expected.txt:
  • fast/dom/shadow/shadow-root-js-api.html:
10:49 PM Changeset in webkit [106433] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

Add missing JS_PRIVATE_EXPORTs
​https://bugs.webkit.org/show_bug.cgi?id=77507

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-01-31
Reviewed by Kevin Ollivier.

  • heap/MarkedSpace.h:

(MarkedSpace):

  • interpreter/Interpreter.h:

(Interpreter):

  • runtime/JSValue.h:

(JSValue):

  • wtf/text/AtomicString.h:

(WTF::AtomicString::add):

  • wtf/text/WTFString.h:

(WTF):

10:39 PM Changeset in webkit [106432] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Content element should be able to be dynamically added/removed/replaced in a shadow tree.
​https://bugs.webkit.org/show_bug.cgi?id=76611

Patch by Shinya Kawanaka <​shinyak@google.com> on 2012-01-31
Reviewed by Hajime Morita.

Source/WebCore:

When a content element is added/removed/replaced in a shadow tree, we have to recreate
the shadow tree to recalculate inclusions of content elements. Currently we didn't recalculate it
when content element is removed. (When added, it is recalculated.)
This patch enables us to recalcurate the shadow tree when content element is removed.

Test: fast/dom/shadow/content-element-move.html

  • dom/Element.cpp:

(WebCore::Element::attach):

If a shadow root exists, attaches shadow tree before attaching child elements.

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::recalcShadowTreeStyle):

Recalculates light children and shadow tree.

(WebCore::ShadowRoot::reattachHostChildrenAndShadow):

Detaches shadow tree and host light children, and attaches them again.

  • dom/ShadowRoot.h: Added a flag to recalculate shadow tree.

(WebCore::ShadowRoot::setNeedsShadowTreeStyleRecalc):
(WebCore::ShadowRoot::clearNeedsShadowTreeStyleRecalc):
(WebCore::ShadowRoot::needsShadowTreeStyleRecalc):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::attach):

Does not need to detach included elements, because they are not attached in ContainerNode anymore.

(WebCore::HTMLContentElement::detach):

When a content element detached, reattaches a shadow tree.

LayoutTests:

Test cases for appending/removing/replacing content element in a shadow tree.

  • fast/dom/shadow/content-element-move-expected.txt: Added.
  • fast/dom/shadow/content-element-move.html: Added.
9:46 PM Changeset in webkit [106431] by ryuan.choi@samsung.com
  • 7 edits in trunk

[EFL] Add basic DRT/Efl implementation to support viewport test.
​https://bugs.webkit.org/show_bug.cgi?id=77320

Reviewed by Andreas Kling.

Source/WebKit/efl:

Add dumpConfigurationForViewport.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::dumpConfigurationForViewport):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport().

LayoutTests:

Remove fast/viewport from Skipped and add some tests which aren't passed.
These skipped tests are also in qt/Skipped and gtk/Skipped.

  • platform/efl/Skipped:
9:37 PM Changeset in webkit [106430] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=76801
Listboxes incorrectly display contents when cleared and then re-populated.

Whenever the number of items in the listbox is less than the size of listbox (number of visible items the listbox can accomodate),
we set the listbox scroll-offset to zero. The scroll-offset of the Scrollbar should also be set to 0 so that when the listbox is re-populated,
scrollbar position and the content inside the listbox are in sync.

Source/WebCore:

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-01-31
Reviewed by Andreas Kling.

Tests: fast/forms/listbox-clear-restore.html

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::computeLogicalHeight): Setting the scroll-offset of the Scrollbar to 0 when scrollbar is not needed.

LayoutTests:

Added test case.

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-01-31
Reviewed by Andreas Kling.

  • fast/forms/listbox-clear-restore-expected.html: Added.
  • fast/forms/listbox-clear-restore.html: Added.
9:25 PM Changeset in webkit [106429] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Stop using -fomit-frame-pointer
​https://bugs.webkit.org/show_bug.cgi?id=77403

Reviewed by Filip Pizlo.

JavaScriptCore is too fast. I'm just the man to fix it.

  • Configurations/JavaScriptCore.xcconfig:
9:19 PM Changeset in webkit [106428] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectation change.
LayoutTest platform/mac/fast/events/non-roman-key-code.html crashes at r106422.

  • platform/chromium/test_expectations.txt:
8:31 PM Changeset in webkit [106427] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix build break after r106373.

  • CMakeLists.txt:
8:07 PM Changeset in webkit [106426] by abarth@webkit.org
  • 6 edits
    9 adds in trunk

HTMLPreloadScanner should understand the <base> element
​https://bugs.webkit.org/show_bug.cgi?id=77231

Reviewed by Eric Seidel.

Source/WebCore:

Previously, the HTMLPreloadScanner would ignore the <base> element when
preloading resources. If there was a <base> tag, this could cause the
preload scanner to make a bunch of useless requests.

This patch teaches the preload scanner to use <base> tags to better
predict which URLs will be used by the document.

Tests: fast/preloader/first-base-tag-scanned-wins.html

fast/preloader/first-base-tag-wins.html
fast/preloader/understands-base-tag.html

  • dom/Document.cpp:

(WebCore::Document::completeURL):
(WebCore):

  • dom/Document.h:

(Document):
(WebCore::Document::baseElementURL):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::HTMLNames::PreloadTask::PreloadTask):
(WebCore::HTMLNames::PreloadTask::processAttributes):
(WebCore::HTMLNames::PreloadTask::preload):
(WebCore::HTMLNames::PreloadTask::baseElementHref):
(PreloadTask):
(WebCore::HTMLPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::processToken):
(WebCore::HTMLPreloadScanner::updatePredictedBaseElementURL):
(WebCore):

  • html/parser/HTMLPreloadScanner.h:

(HTMLPreloadScanner):

LayoutTests:

These tests ensure that we understand the <base> element and that we
understand that the first <base> element is the one that maters.

  • fast/preloader/first-base-tag-scanned-wins-expected.txt: Added.
  • fast/preloader/first-base-tag-scanned-wins.html: Added.
  • fast/preloader/first-base-tag-wins-expected.txt: Added.
  • fast/preloader/first-base-tag-wins.html: Added.
  • fast/preloader/resources/base-image1.png: Copied from LayoutTests/fast/preloader/resources/image1.png.
  • fast/preloader/resources/base-image2.png: Copied from LayoutTests/fast/preloader/resources/image1.png.
  • fast/preloader/resources/base-image3.png: Copied from LayoutTests/fast/preloader/resources/image1.png.
  • fast/preloader/understands-base-tag-expected.txt: Added.
  • fast/preloader/understands-base-tag.html: Added.
7:51 PM Changeset in webkit [106425] by morrita@google.com
  • 2 edits
    96 adds in trunk/PerformanceTests

Import Dromaeo to WebKit repository.
​https://bugs.webkit.org/show_bug.cgi?id=77328

Reviewed by Ryosuke Niwa.

Imported a modified version of Dromaeo which is able to
run on the DRT.

The imported version originally came from:
​https://github.com/omo/dromaeo/commit/c942a1452109cdd5f759b3c4aee8d68d490d44a2

  • Dromaeo/resources/dromaeo/web/application.css: Added.
  • Dromaeo/resources/dromaeo/web/favicon.ico: Added.
  • Dromaeo/resources/dromaeo/web/favicon.png: Added.
  • Dromaeo/resources/dromaeo/web/htmlrunner.js: Added.
  • Dromaeo/resources/dromaeo/web/ie.css: Added.
  • Dromaeo/resources/dromaeo/web/images/bg.png: Added.
  • Dromaeo/resources/dromaeo/web/images/clouds.png: Added.
  • Dromaeo/resources/dromaeo/web/images/clouds2.png: Added.
  • Dromaeo/resources/dromaeo/web/images/comets.png: Added.
  • Dromaeo/resources/dromaeo/web/images/dino1.png: Added.
  • Dromaeo/resources/dromaeo/web/images/dino2.png: Added.
  • Dromaeo/resources/dromaeo/web/images/dino3.png: Added.
  • Dromaeo/resources/dromaeo/web/images/dino4.png: Added.
  • Dromaeo/resources/dromaeo/web/images/dino5.png: Added.
  • Dromaeo/resources/dromaeo/web/images/dino6.png: Added.
  • Dromaeo/resources/dromaeo/web/images/dino7.png: Added.
  • Dromaeo/resources/dromaeo/web/images/dino8.png: Added.
  • Dromaeo/resources/dromaeo/web/images/left.png: Added.
  • Dromaeo/resources/dromaeo/web/images/logo.png: Added.
  • Dromaeo/resources/dromaeo/web/images/logo2.png: Added.
  • Dromaeo/resources/dromaeo/web/images/logo3.png: Added.
  • Dromaeo/resources/dromaeo/web/images/right.png: Added.
  • Dromaeo/resources/dromaeo/web/images/top.png: Added.
  • Dromaeo/resources/dromaeo/web/images/water.png: Added.
  • Dromaeo/resources/dromaeo/web/index.html: Added.
  • Dromaeo/resources/dromaeo/web/jquery.js: Added.
  • Dromaeo/resources/dromaeo/web/lib/dojo.js: Added.
  • Dromaeo/resources/dromaeo/web/lib/jquery.js: Added.
  • Dromaeo/resources/dromaeo/web/lib/mootools.js: Added.
  • Dromaeo/resources/dromaeo/web/lib/prototype.js: Added.
  • Dromaeo/resources/dromaeo/web/pngfix.js: Added.
  • Dromaeo/resources/dromaeo/web/reset.css: Added.
  • Dromaeo/resources/dromaeo/web/test-head.html: Added.
  • Dromaeo/resources/dromaeo/web/test-head.js: Added.
  • Dromaeo/resources/dromaeo/web/test-tail.html: Added.
  • Dromaeo/resources/dromaeo/web/test-tail.js: Added.
  • Dromaeo/resources/dromaeo/web/tests/MANIFEST.json: Added.
  • Dromaeo/resources/dromaeo/web/tests/cssquery-dojo.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/cssquery-jquery.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/cssquery-mootools.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/cssquery-prototype.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/cssquery-yui.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/dom-attr.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/dom-modify.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/dom-query.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/dom-traverse.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/dromaeo-3d-cube.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/dromaeo-core-eval.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/dromaeo-object-array.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/dromaeo-object-regexp.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/dromaeo-object-string.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/dromaeo-string-base64.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/jslib-attr-jquery.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/jslib-attr-prototype.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/jslib-event-jquery.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/jslib-event-prototype.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/jslib-modify-jquery.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/jslib-modify-prototype.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/jslib-style-jquery.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/jslib-style-prototype.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/jslib-traverse-jquery.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/jslib-traverse-prototype.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-3d-morph.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-3d-raytrace.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-access-binary-trees.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-access-fannkuch.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-access-nbody.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-access-nsieve.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-bitops-3bit-bits-in-byte.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-bitops-bits-in-byte.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-bitops-bitwise-and.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-bitops-nsieve-bits.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-controlflow-recursive.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-crypto-aes.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-crypto-md5.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-crypto-sha1.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-date-format-tofte.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-date-format-xparb.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-math-cordic.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-math-partial-sums.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-math-spectral-norm.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-regexp-dna.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-string-fasta.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-string-tagcloud.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-string-unpack-code.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-string-validate-input.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/v8-crypto.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/v8-deltablue.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/v8-earley-boyer.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/v8-raytrace.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/v8-richards.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/72px.png: Added.
  • Dromaeo/resources/dromaeo/web/web-style.css: Added.
  • Dromaeo/resources/dromaeo/web/webrunner.js: Added.
  • Skipped: Unskip the dromaeo driver.
7:38 PM Changeset in webkit [106424] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Set content hint information for ewk_view_single.
​https://bugs.webkit.org/show_bug.cgi?id=77319

Patch by KwangHyuk Kim <​hyuki.kim@samsung.com> on 2012-01-31
Reviewed by Ryosuke Niwa.

The content hint information corresponding to opengl_x11 engine is set
for the image object which ewk_view_single owns when evas is based on
opengl_x11 engine.

  • ewk/ewk_view_single.cpp:

(_ewk_view_single_smart_backing_store_add):

7:23 PM Changeset in webkit [106423] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Dynamic allocate AudioBus with required number of channels for AudioNodeInput
​https://bugs.webkit.org/show_bug.cgi?id=76516

Patch by Raymond Liu <​raymond.liu@intel.com> on 2012-01-31
Reviewed by Kenneth Russell.

No new tests required.

  • webaudio/AudioBasicProcessorNode.cpp:

(WebCore::AudioBasicProcessorNode::checkNumberOfChannelsForInput):

  • webaudio/AudioChannelMerger.cpp:

(WebCore::AudioChannelMerger::checkNumberOfChannelsForInput):

  • webaudio/AudioGainNode.cpp:

(WebCore::AudioGainNode::checkNumberOfChannelsForInput):

  • webaudio/AudioNode.cpp:

(WebCore::AudioNode::checkNumberOfChannelsForInput):

  • webaudio/AudioNode.h:
  • webaudio/AudioNodeInput.cpp:

(WebCore::AudioNodeInput::AudioNodeInput):
(WebCore::AudioNodeInput::updateInternalBus):
(WebCore::AudioNodeInput::internalSummingBus):

  • webaudio/AudioNodeInput.h:
7:21 PM Changeset in webkit [106422] by ap@apple.com
  • 9 edits
    2 adds in trunk

REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
​https://bugs.webkit.org/show_bug.cgi?id=77473
<rdar://problem/10751357>

Reviewed by Darin Adler.

Source/WebCore:

Test: platform/mac/fast/events/non-roman-key-code.html

  • WebCore.exp.in:
  • platform/mac/PlatformEventFactoryMac.h:
  • platform/mac/PlatformEventFactoryMac.mm:

(WebCore::keyIdentifierForKeyEvent):
(WebCore::windowsKeyCodeForKeyEvent):
Export functions for reuse in WebKit2. I did not attempt any larger refactoring at this time.

Source/WebKit2:

  • Shared/mac/WebEventFactory.mm: Removed broken copy/pasted implementation in favor of

WebCore ones.

Tools:

  • DumpRenderTree/mac/EventSendingController.mm:

(-[EventSendingController keyDown:withModifiers:withLocation:]):

  • WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::keyDown):
Added a new special keyDown value to test this.

7:17 PM Changeset in webkit [106421] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Make WebGL put synthesized errors in the JS console
​https://bugs.webkit.org/show_bug.cgi?id=77267

Patch by Gregg Tavares <​gman@google.com> on 2012-01-31
Reviewed by Kenneth Russell.

No new functionality so no new tests.

  • html/canvas/WebGLCompressedTextures.cpp:

(WebCore::WebGLCompressedTextures::validateCompressedTexFuncData):
(WebCore::WebGLCompressedTextures::compressedTexImage2D):
(WebCore::WebGLCompressedTextures::compressedTexSubImage2D):

  • html/canvas/WebGLCompressedTextures.h:

(WebGLCompressedTextures):

  • html/canvas/WebGLDebugShaders.cpp:

(WebCore::WebGLDebugShaders::getTranslatedShaderSource):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::activeTexture):
(WebCore::WebGLRenderingContext::attachShader):
(WebCore::WebGLRenderingContext::bindAttribLocation):
(WebCore::WebGLRenderingContext::checkObjectToBeBound):
(WebCore::WebGLRenderingContext::bindBuffer):
(WebCore::WebGLRenderingContext::bindFramebuffer):
(WebCore::WebGLRenderingContext::bindRenderbuffer):
(WebCore::WebGLRenderingContext::bindTexture):
(WebCore::WebGLRenderingContext::blendEquation):
(WebCore::WebGLRenderingContext::blendEquationSeparate):
(WebCore::WebGLRenderingContext::blendFunc):
(WebCore::WebGLRenderingContext::blendFuncSeparate):
(WebCore::WebGLRenderingContext::bufferData):
(WebCore::WebGLRenderingContext::bufferSubData):
(WebCore::WebGLRenderingContext::checkFramebufferStatus):
(WebCore::WebGLRenderingContext::clear):
(WebCore::WebGLRenderingContext::compileShader):
(WebCore::WebGLRenderingContext::compressedTexImage2D):
(WebCore::WebGLRenderingContext::compressedTexSubImage2D):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::createShader):
(WebCore::WebGLRenderingContext::deleteObject):
(WebCore::WebGLRenderingContext::depthRange):
(WebCore::WebGLRenderingContext::detachShader):
(WebCore::WebGLRenderingContext::disable):
(WebCore::WebGLRenderingContext::disableVertexAttribArray):
(WebCore::WebGLRenderingContext::validateWebGLObject):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::enable):
(WebCore::WebGLRenderingContext::enableVertexAttribArray):
(WebCore::WebGLRenderingContext::framebufferRenderbuffer):
(WebCore::WebGLRenderingContext::framebufferTexture2D):
(WebCore::WebGLRenderingContext::generateMipmap):
(WebCore::WebGLRenderingContext::getActiveAttrib):
(WebCore::WebGLRenderingContext::getActiveUniform):
(WebCore::WebGLRenderingContext::getAttachedShaders):
(WebCore::WebGLRenderingContext::getAttribLocation):
(WebCore::WebGLRenderingContext::getBufferParameter):
(WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getProgramParameter):
(WebCore::WebGLRenderingContext::getProgramInfoLog):
(WebCore::WebGLRenderingContext::getRenderbufferParameter):
(WebCore::WebGLRenderingContext::getShaderParameter):
(WebCore::WebGLRenderingContext::getShaderInfoLog):
(WebCore::WebGLRenderingContext::getShaderSource):
(WebCore::WebGLRenderingContext::getTexParameter):
(WebCore::WebGLRenderingContext::getUniform):
(WebCore::WebGLRenderingContext::getUniformLocation):
(WebCore::WebGLRenderingContext::getVertexAttrib):
(WebCore::WebGLRenderingContext::hint):
(WebCore::WebGLRenderingContext::isEnabled):
(WebCore::WebGLRenderingContext::linkProgram):
(WebCore::WebGLRenderingContext::pixelStorei):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::renderbufferStorage):
(WebCore::WebGLRenderingContext::scissor):
(WebCore::WebGLRenderingContext::shaderSource):
(WebCore::WebGLRenderingContext::stencilFunc):
(WebCore::WebGLRenderingContext::stencilFuncSeparate):
(WebCore::WebGLRenderingContext::stencilMaskSeparate):
(WebCore::WebGLRenderingContext::texImage2DBase):
(WebCore::WebGLRenderingContext::texImage2DImpl):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::videoFrameToImage):
(WebCore::WebGLRenderingContext::texParameter):
(WebCore::WebGLRenderingContext::texSubImage2DBase):
(WebCore::WebGLRenderingContext::texSubImage2DImpl):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::uniform1f):
(WebCore::WebGLRenderingContext::uniform1fv):
(WebCore::WebGLRenderingContext::uniform1i):
(WebCore::WebGLRenderingContext::uniform1iv):
(WebCore::WebGLRenderingContext::uniform2f):
(WebCore::WebGLRenderingContext::uniform2fv):
(WebCore::WebGLRenderingContext::uniform2i):
(WebCore::WebGLRenderingContext::uniform2iv):
(WebCore::WebGLRenderingContext::uniform3f):
(WebCore::WebGLRenderingContext::uniform3fv):
(WebCore::WebGLRenderingContext::uniform3i):
(WebCore::WebGLRenderingContext::uniform3iv):
(WebCore::WebGLRenderingContext::uniform4f):
(WebCore::WebGLRenderingContext::uniform4fv):
(WebCore::WebGLRenderingContext::uniform4i):
(WebCore::WebGLRenderingContext::uniform4iv):
(WebCore::WebGLRenderingContext::uniformMatrix2fv):
(WebCore::WebGLRenderingContext::uniformMatrix3fv):
(WebCore::WebGLRenderingContext::uniformMatrix4fv):
(WebCore::WebGLRenderingContext::useProgram):
(WebCore::WebGLRenderingContext::validateProgram):
(WebCore::WebGLRenderingContext::vertexAttrib1f):
(WebCore::WebGLRenderingContext::vertexAttrib1fv):
(WebCore::WebGLRenderingContext::vertexAttrib2f):
(WebCore::WebGLRenderingContext::vertexAttrib2fv):
(WebCore::WebGLRenderingContext::vertexAttrib3f):
(WebCore::WebGLRenderingContext::vertexAttrib3fv):
(WebCore::WebGLRenderingContext::vertexAttrib4f):
(WebCore::WebGLRenderingContext::vertexAttrib4fv):
(WebCore::WebGLRenderingContext::vertexAttribPointer):
(WebCore::WebGLRenderingContext::viewport):
(WebCore::WebGLRenderingContext::forceLostContext):
(WebCore::WebGLRenderingContext::loseContextImpl):
(WebCore::WebGLRenderingContext::forceRestoreContext):
(WebCore::WebGLRenderingContext::validateTextureBinding):
(WebCore::WebGLRenderingContext::validateLocationLength):
(WebCore::WebGLRenderingContext::validateSize):
(WebCore::WebGLRenderingContext::validateString):
(WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
(WebCore::WebGLRenderingContext::validateTexFuncLevel):
(WebCore::WebGLRenderingContext::validateTexFuncParameters):
(WebCore::WebGLRenderingContext::validateTexFuncData):
(WebCore::WebGLRenderingContext::validateDrawMode):
(WebCore::WebGLRenderingContext::validateStencilSettings):
(WebCore::WebGLRenderingContext::validateStencilFunc):
(WebCore::WebGLRenderingContext::validateFramebufferFuncParameters):
(WebCore::WebGLRenderingContext::validateBlendEquation):
(WebCore::WebGLRenderingContext::validateBlendFuncFactors):
(WebCore::WebGLRenderingContext::validateCapability):
(WebCore::WebGLRenderingContext::validateUniformParameters):
(WebCore::WebGLRenderingContext::validateUniformMatrixParameters):
(WebCore::WebGLRenderingContext::validateBufferDataParameters):
(WebCore::WebGLRenderingContext::validateHTMLImageElement):
(WebCore::WebGLRenderingContext::vertexAttribfImpl):
(WebCore::WebGLRenderingContext::vertexAttribfvImpl):
(WebCore::WebGLRenderingContext::maybeRestoreContext):
(WebCore):
(WebCore::WebGLRenderingContext::synthesizeGLError):

  • html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

7:04 PM Changeset in webkit [106420] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Clean up m_processLock logic in AudioBasicProcessorNode and AudioGainNode
​https://bugs.webkit.org/show_bug.cgi?id=76772

Patch by Raymond Liu <​raymond.liu@intel.com> on 2012-01-31
Reviewed by Kenneth Russell.

No new tests required.

  • webaudio/AudioBasicProcessorNode.cpp:

(WebCore::AudioBasicProcessorNode::process):
(WebCore::AudioBasicProcessorNode::checkNumberOfChannelsForInput):

  • webaudio/AudioBasicProcessorNode.h:
  • webaudio/AudioGainNode.cpp:

(WebCore::AudioGainNode::process):
(WebCore::AudioGainNode::checkNumberOfChannelsForInput):

  • webaudio/AudioGainNode.h:

(AudioGainNode):

6:41 PM WikiStart edited by gman@google.com
(diff)
5:55 PM Changeset in webkit [106419] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Fix Parser/html5-full-render.html after r106379.

  • Parser/html5-full-render.html:
5:54 PM Changeset in webkit [106418] by adamk@chromium.org
  • 8 edits
    2 adds in trunk

ProcessingInstruction should not be a ContainerNode
​https://bugs.webkit.org/show_bug.cgi?id=75141

Reviewed by Darin Adler.

Source/WebCore:

Per the DOM spec, ProcessingInstruction can't have any children.
And the WebCore behavior already matches the spec by always returning
false for childTypeAllowed(). This change simplifies
ProcessingInstruction's implementation by making it subclass Node
instead of ContainerNode.

Test: fast/dom/processing-instruction-appendChild-exceptions.xhtml

  • dom/ContainerNode.cpp: Moved dispatchBeforeLoadEvent up to Node.
  • dom/ContainerNode.h:
  • dom/Node.cpp:

(WebCore::Node::dispatchBeforeLoadEvent): Moved up from ContainerNode
since it's used both by ProcessingInstruction and various Element
subclasses.

  • dom/Node.h:
  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::ProcessingInstruction): Call Node constructor.
(WebCore::ProcessingInstruction::insertedIntoDocument): Call Node impl.
(WebCore::ProcessingInstruction::removedFromDocument): ditto.
(WebCore::ProcessingInstruction::finishParsingChildren): ditto.

  • dom/ProcessingInstruction.h:

LayoutTests:

  • fast/dom/processing-instruction-appendChild-exceptions-expected.txt: Added.
  • fast/dom/processing-instruction-appendChild-exceptions.xhtml: Added.
5:49 PM Changeset in webkit [106417] by msaboff@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

StringProtoFuncToUpperCase should call StringImpl::upper similar to StringProtoToLowerCase
​https://bugs.webkit.org/show_bug.cgi?id=76647

Reviewed by Darin Adler.

Changed stringProtoFuncToUpperCase to call StringImpl::upper() in a manor similar
to stringProtoFuncToLowerCase(). Fixed StringImpl::upper() to handle to special
cases. One case is s-sharp (0xdf) which converts to "SS". The other case is
for characters which become 16 bit values when converted to upper case. For
those, we up convert the the source string and use the 16 bit path.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncToUpperCase):

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::upper):

  • wtf/unicode/CharacterNames.h:

(smallLetterSharpS): New constant

5:41 PM Changeset in webkit [106416] by dpranke@chromium.org
  • 6 edits
    1 delete in trunk/Tools

nrwt: fix the mock port to work with DriverProxy, reftests
​https://bugs.webkit.org/show_bug.cgi?id=77170

Reviewed by Eric Seidel.

The DryrunPort used for benchmarking and testing NRWT has been
broken since we added the DriverProxy code. It isn't really
needed any more, so I've removed it.

The MockDRT port was also broken by DriverProxy, and moreover,
never worked w/ reftests. Since we don't exercise this module in
the unit tests, the code had also bitrotted some. I have cleaned
it up and made it use DriverInput and DriverOutput for
consistency.

  • Scripts/webkitpy/layout_tests/port/dryrun.py:

(DryRunPort.init):
(DryRunPort):
(DryRunPort.real_name):
(DryRunPort.create_driver):
(DryRunPort.driver_cmd_line):
(DryRunPort._driver_class):
(DryrunDriver):
(DryrunDriver.run_test):

  • Scripts/webkitpy/layout_tests/port/mock_drt.py:

(MockDRTPort.create_driver):
(MockChromiumDRT.run_one_test):

5:21 PM Changeset in webkit [106415] by mdelaney@apple.com
  • 5 edits in trunk

Failing 2d.shadow.enable.off.2.html on Lion
​https://bugs.webkit.org/show_bug.cgi?id=77489

Reviewed by Dan Bernstein.

Source/WebCore:

The canvas spec requires that shadows not be drawn under certain
circumstances outlined here: ​http://www.whatwg.org/specs/web-apps/current-work/#shadows
This patch adds in those checks which allows us to pass now (on Lion)
the philip canvas test that was checking that constraint.

No new tests. Unskipping the test on Lion that this patch fixes.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setAllAttributesToDefault):
(WebCore::CanvasRenderingContext2D::setShadow):
(WebCore::CanvasRenderingContext2D::applyShadow):
(WebCore::CanvasRenderingContext2D::shouldDrawShadows):

  • html/canvas/CanvasRenderingContext2D.h:

(CanvasRenderingContext2D):

LayoutTests:

  • platform/mac-lion/Skipped: We can unskip this test now that this patch has us passing this test.
5:18 PM Changeset in webkit [106414] by oliver@apple.com
  • 5 edits in trunk

Remove unneeded sourceId property
​https://bugs.webkit.org/show_bug.cgi?id=77495

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

sourceId isn't used anymore, so we'll just remove it.

  • runtime/Error.cpp:

(JSC):
(JSC::addErrorInfo):
(JSC::hasErrorInfo):

LayoutTests:

Update the test for the removal of sourceId

  • fast/js/exception-properties-expected.txt:
  • fast/js/script-tests/exception-properties.js:
5:09 PM Changeset in webkit [106413] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectation change.
fast/replaced/width100percent-searchfield.html is failing on MAC.

  • platform/chromium/test_expectations.txt:
4:32 PM Changeset in webkit [106412] by ojan@chromium.org
  • 6 edits in trunk/Tools

run-webkit-tests calls out to webkit-build-directory twice
​https://bugs.webkit.org/show_bug.cgi?id=77248

Reviewed by Dirk Pranke.

  • Scripts/webkit-build-directory:

If called with no arguments, print out both the top-level directory and the
configuration directory

  • Scripts/webkitpy/layout_tests/port/config.py:

(Config.build_directory):
When called with no arguments, get and cache both the top-level and configuration directories.

  • Scripts/webkitpy/layout_tests/port/config_standalone.py:

(main):

  • Scripts/webkitpy/layout_tests/port/config_unittest.py:

(ConfigTest.assert_configuration):
(ConfigTest.test_build_directory.mock_webkit_build_directory):
(ConfigTest.test_build_directory):
(ConfigTest.test_default_configurationnotfound):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._build_path):
Cache the build directory in the options object so that other users
of the options object don't need to call out to webkit-build-directory.
Also, properly support the existing --build-directory argument.

3:58 PM Changeset in webkit [106411] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

TileCache::setNeedsDisplayInRect cleanup
​https://bugs.webkit.org/show_bug.cgi?id=77486

Reviewed by Andreas Kling.

  • platform/graphics/ca/mac/TileCache.h:
  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::setNeedsDisplayInRect):
TileCache::tileLayerAtIndex can in the future return nil, so cope with that. Also, replace
nested if statements with continue statements.

(WebCore::TileCache::getTileIndexRangeForRect):
Rename this to better indicate that it returns a range of indices.

3:55 PM Changeset in webkit [106410] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] enable -Wexit-time-destructors for webkit unit tests
​https://bugs.webkit.org/show_bug.cgi?id=77300
Fix the only extant violation (verified by building webkit_unit_tests in static build).

Patch by Ami Fischman <​fischman@chromium.org> on 2012-01-31
Reviewed by Tony Chang.

  • WebKitUnitTests.gyp:
  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::defaultWebFrameClient):
(WebKit::FrameTestHelpers::defaultWebViewClient):

3:49 PM Changeset in webkit [106409] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Bump up the timeout for performance tests since DOM/DOMTable.html
and Parser/html5-full-render.html are timing out on the bot.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):

3:36 PM Changeset in webkit [106408] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Add contains() test to Region
​https://bugs.webkit.org/show_bug.cgi?id=72294

Patch by Dana Jansens <​danakj@chromium.org> on 2012-01-31
Reviewed by Anders Carlsson.

  • platform/graphics/Region.cpp:

(WebCore::Region::contains):
(WebCore):

  • platform/graphics/Region.h:

(Region):
(Shape):
(WebCore::operator==):
(WebCore):

3:24 PM Changeset in webkit [106407] by oliver@apple.com
  • 15 edits
    3 adds in trunk

Implement Error.stack
​https://bugs.webkit.org/show_bug.cgi?id=66994

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Original patch by Juan Carlos Montemayor Elosua:

This patch utilizes topCallFrame to create a stack trace when
an error is thrown. Users will also be able to use the stack()
command in jsc to get arrays with stack trace information.

Modified to be correct on ToT, with a variety of correctness,
performance, and security improvements.

(JSC::getCallerLine):
(JSC::getSourceURLFromCallFrame):
(JSC::getStackFrameCodeType):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):

  • interpreter/Interpreter.h:

(JSC::StackFrame::toString):

  • jsc.cpp:

(GlobalObject::finishCreation):
(functionJSCStack):

  • parser/Parser.h:

(JSC::Parser::parse):

  • runtime/CommonIdentifiers.h:
  • runtime/Error.cpp:

(JSC::addErrorInfo):

  • runtime/Error.h:

LayoutTests:

Reviewed by Gavin Barraclough

Original patch by Juan Carlos Montemayor Elosua.

Unit tests that contain both normal and special cases for stack trace
generation.

  • fast/js/exception-properties-expected.txt:
  • fast/js/script-tests/exception-properties.js:
  • fast/js/script-tests/stack-trace.js: Added.

(printStack):
(hostThrower):
(callbacker):
(outer):
(inner):
(evaler):
(normalOuter):
(normalInner):
(scripterInner):
(scripterOuter):

  • fast/js/stack-trace-expected.txt: Added.
  • fast/js/stack-trace.html: Added.
  • platform/chromium/test_expectations.txt:
3:20 PM Changeset in webkit [106406] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Compositor debug borders are not scaled correctly
​https://bugs.webkit.org/show_bug.cgi?id=77468

Use CCLayerImpl::contentBounds() instead of CCLayerImpl::bounds() to calculate debug
border geometry so that the borders are properly scaled.

Patch by Sami Kyostila <​skyostil@chromium.org> on 2012-01-31
Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::appendDebugBorderQuad):

3:17 PM Changeset in webkit [106405] by jsbell@chromium.org
  • 4 edits in trunk/LayoutTests

IndexedDB: Re-enable structured-clone test
​https://bugs.webkit.org/show_bug.cgi?id=77239

This test was landed disabled, since it was failing. Turns out Date serialization
differs ("PST" vs. "Pacific Standard Time") across machines, so debug statements
in the test were removed.

Reviewed by Tony Chang.

  • platform/chromium/test_expectations.txt:
  • storage/indexeddb/structured-clone-expected.txt:
  • storage/indexeddb/structured-clone.html:
3:11 PM Changeset in webkit [106404] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Fix the update_webgl_conformance_tests.py script in order to enable it
to detect the SCM being used correctly.
​https://bugs.webkit.org/show_bug.cgi?id=77462

Patch by Ehsan Akhgari <​ehsan.akhgari@gmail.com> on 2012-01-31
Reviewed by Kenneth Russell.

  • Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:

(default_out_dir):

3:09 PM Changeset in webkit [106403] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] bot lacks mobility
​https://bugs.webkit.org/show_bug.cgi?id=68243

Unreviewed gardening.
Removing tests from skipped list. These tests are no
longer failing since the Qt5 tree we use includes
the required modules that used to live in mobility.

  • platform/qt-wk2/Skipped:
3:07 PM Changeset in webkit [106402] by Antti Koivisto
  • 2 edits in trunk/Source/WebKit/qt

Try to fix Qt build.

Not reviewed.

  • Api/qwebelement.cpp:

(QWebElement::styleProperty):

3:02 PM Changeset in webkit [106401] by thakis@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Expose windowResizerRectChanged() on WebWidget.
​https://bugs.webkit.org/show_bug.cgi?id=77453

Needed for ​http://crbug.com/111266

Reviewed by Darin Fisher.

  • public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::didChangeWindowResizerRect):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::didChangeWindowResizerRect):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

2:58 PM Changeset in webkit [106400] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed, rolling out r106376.
​http://trac.webkit.org/changeset/106376
​https://bugs.webkit.org/show_bug.cgi?id=77481

Broke WebGLLayerChromiumTest in webkit_unit_tests (Requested
by kbr_google on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-01-31

Source/WebCore:

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore):
(WebCore::DrawingBuffer::reset):

LayoutTests:

  • platform/chromium/test_expectations.txt:
2:57 PM Changeset in webkit [106399] by nduca@chromium.org
  • 3 edits
    3 adds in trunk/Source/WebKit/chromium

[chromium] Import PaintAggregator
​https://bugs.webkit.org/show_bug.cgi?id=53715

Reviewed by Darin Fisher.

  • WebKit.gyp:
  • WebKit.gypi:
  • src/painting/PaintAggregator.cpp: Added.

(WebKit::calculateArea):
(WebKit::subtractIntersection):
(WebKit::sharesEdge):
(WebKit::PaintAggregator::PendingUpdate::PendingUpdate):
(WebKit::PaintAggregator::PendingUpdate::~PendingUpdate):
(WebKit::PaintAggregator::PendingUpdate::calculateScrollDamage):
(WebKit::PaintAggregator::PendingUpdate::calculatePaintBounds):
(WebKit::PaintAggregator::hasPendingUpdate):
(WebKit::PaintAggregator::clearPendingUpdate):
(WebKit::PaintAggregator::popPendingUpdate):
(WebKit::PaintAggregator::invalidateRect):
(WebKit::PaintAggregator::scrollRect):
(WebKit::PaintAggregator::scrollPaintRect):
(WebKit::PaintAggregator::shouldInvalidateScrollRect):
(WebKit::PaintAggregator::invalidateScrollRect):
(WebKit::PaintAggregator::combinePaintRects):

  • src/painting/PaintAggregator.h: Added.
  • tests/PaintAggregatorTest.cpp: Added.

(WebKit::TEST):

2:55 PM Changeset in webkit [106398] by mihnea@adobe.com
  • 2 edits in trunk/Source/WebCore

[CSSRegions]Reduce the cases when the box style in region is computed
​https://bugs.webkit.org/show_bug.cgi?id=77446

Reviewed by David Hyatt.

Covered by existing region style tests.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::setRegionBoxesRegionStyle):
(WebCore::RenderRegion::restoreRegionBoxesOriginalStyle):

2:46 PM Changeset in webkit [106397] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Put tiles in a HashMap
​https://bugs.webkit.org/show_bug.cgi?id=77480

Reviewed by Antti Koivisto.

Put tiles in a hash map keyed off the tile index.

  • platform/graphics/ca/mac/TileCache.h:

Shuffle member variables around so the order makes more sense.
Add the tile map.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::TileCache):
Update member initializers.

(WebCore::TileCache::setNeedsDisplayInRect):
Call tileLayerAtIndex instead of tileLayerAtPosition.

(WebCore::TileCache::setAcceleratesDrawing):
(WebCore::TileCache::setTileDebugBorderWidth):
(WebCore::TileCache::setTileDebugBorderColor):
Iterate over the hash map instead of the sublayers.

(WebCore::TileCache::resizeTileGrid):
Add the created layers to the map.

(WebCore::TileCache::tileLayerAtIndex):
Rename from tileLayerAtPoint to better reflect that this member function
returns a tile layer at the given index and not the given point.

2:45 PM Changeset in webkit [106396] by eric@webkit.org
  • 3 edits in trunk/Tools

webkit-patch apply-from-bug should work regardless of your CWD
​https://bugs.webkit.org/show_bug.cgi?id=77482

Reviewed by Adam Barth.

webkit-patch only ever works with patches made from the root
directory. We should pass the CWD to svn-apply in the case
where we're running not from the webkit root. I believe
this used to work in the past and regressed.

  • Scripts/webkitpy/common/checkout/checkout.py:

(Checkout.apply_patch):

  • Scripts/webkitpy/common/checkout/checkout_unittest.py:

(CheckoutTest.test_apply_patch):

2:42 PM Changeset in webkit [106395] by fsamuel@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] ChromeClientImpl::dispatchViewportPropertiesDidChange is repeatedly called in Google News
​https://bugs.webkit.org/show_bug.cgi?id=77429

Reviewed by Darin Fisher.

m_webView->isPageScaleFactorSet() is tested in ChromeClientImpl::layoutUpdated, and it is never true,
because WebViewImpl::setPageScaleFactorPreservingScrollOffset is called repeatedly and exits early
and thus never calls WebViewImpl::setPageScaleFactor which sets the flag.

The simplest solution is to simply get rid of the early return in
WebViewImpl::setPageScaleFactorPreservingScrollOffset.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset):

2:40 PM Changeset in webkit [106394] by fsamuel@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Expose setLayoutFallbackWidth as a WebSetting
​https://bugs.webkit.org/show_bug.cgi?id=77431

Reviewed by Darin Fisher.

The layout fallback width is the default fixed layout width
set for desktop web pages that lack a viewport tag. This width
can vary from platform to platform and can depend on other factors,
and so it should be a setting exposed to Chromium.

  • public/WebSettings.h:

():

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setLayoutFallbackWidth):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

2:30 PM Changeset in webkit [106393] by Antti Koivisto
  • 10 edits in trunk/Source/WebCore

Make CSSOM style() return CSSStyleDeclaration*
​https://bugs.webkit.org/show_bug.cgi?id=77475

Reviewed by Anders Carlsson

CSSStyleRule::style() and some other places return CSSMutableStyleDeclaration.
They should return the plain CSSOM type instead.

CSSMutableStyleDeclaration* should be available through non-CSSOM function.

  • css/CSSFontFaceRule.h:

(WebCore::CSSFontFaceRule::style):
(WebCore::CSSFontFaceRule::declaration):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSStyleRule.h:

(WebCore::CSSStyleRule::style):
(WebCore::CSSStyleRule::declaration):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForKeyframe):

  • css/WebKitCSSKeyframeRule.h:

(WebCore):
(WebCore::WebKitCSSKeyframeRule::style):
(WebCore::WebKitCSSKeyframeRule::declaration):
(WebKitCSSKeyframeRule):

  • editing/EditingStyle.cpp:

(WebCore::styleFromMatchedRulesForElement):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::revalidateStyle):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::retrieveResourcesForCSSRule):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::parseMappedAttribute):
(WebCore::SVGFontFaceElement::fontFamily):
(WebCore::SVGFontFaceElement::rebuildFontFace):

2:05 PM Changeset in webkit [106392] by dgrogan@chromium.org
  • 4 edits
    1 copy
    3 adds in trunk/LayoutTests

IndexedDB: refactor basics layout test so that it can be run on workers.
​https://bugs.webkit.org/show_bug.cgi?id=76683

Reviewed by Tony Chang.

  • storage/indexeddb/basics-workers-expected.txt: Added.
  • storage/indexeddb/basics-workers.html: Added.
  • storage/indexeddb/basics.html:
  • storage/indexeddb/resources/basics.js: Copied from LayoutTests/storage/indexeddb/basics.html.

(test):
(openCallback):

  • storage/indexeddb/resources/idb-worker-common.js: Added.

(debug):
(finishJSTest):
(description):
(testPassed):
(testFailed):

2:03 PM WikiStart edited by rniwa@webkit.org
Add a link to Writing Performance Tests (diff)
2:00 PM Changeset in webkit [106391] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[Chromium] Remove references to gyp cygwin build target
​https://bugs.webkit.org/show_bug.cgi?id=77253

Patch by Scott Graham <​scottmg@chromium.org> on 2012-01-31
Reviewed by Julien Chaffraix.

Target dependency is no longer required, it's done earlier in the
build process.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:
1:57 PM Changeset in webkit [106390] by eric@webkit.org
  • 6 edits
    1 copy
    3 deletes in trunk/LayoutTests

Rebaseline results after ​http://trac.webkit.org/changeset/106373

Unreviewed.

  • fast/forms/implicit-submission-expected.txt:
  • platform/chromium-mac/fast/dom/Window/window-lookup-precedence-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/wrapper-classes-expected.txt: Removed.
  • platform/chromium-win/fast/forms/implicit-submission-expected.txt:
  • platform/chromium/fast/dom/Window/element-constructors-on-window-expected.txt:
  • platform/chromium/fast/dom/Window/window-lookup-precedence-expected.txt:
  • platform/chromium/fast/dom/wrapper-classes-expected.txt:
  • platform/mac/fast/forms/implicit-submission-expected.txt: Copied from LayoutTests/fast/forms/implicit-submission-expected.txt.
  • platform/qt/fast/forms/implicit-submission-expected.txt: Removed.
1:46 PM Changeset in webkit [106389] by ojan@chromium.org
  • 6 edits in trunk/Tools

Unreviewed, rolling out r106302.
​http://trac.webkit.org/changeset/106302
​https://bugs.webkit.org/show_bug.cgi?id=77472

Broke building DRT before running the tests (Requested by ojan
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-01-31

  • Scripts/webkit-build-directory:
  • Scripts/webkitpy/layout_tests/port/config.py:

(Config.build_directory):

  • Scripts/webkitpy/layout_tests/port/config_standalone.py:

(main):

  • Scripts/webkitpy/layout_tests/port/config_unittest.py:

(ConfigTest.assert_configuration):
(ConfigTest.test_build_directory.mock_webkit_build_directory):
(ConfigTest.test_build_directory):
(ConfigTest.test_default_configurationnotfound):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._build_path):

1:43 PM Changeset in webkit [106388] by jonlee@apple.com
  • 4 edits
    2 adds in trunk

Hidden form elements do not save their state prior to form submission
​https://bugs.webkit.org/show_bug.cgi?id=77391
<rdar://problem/10563108>

Reviewed by Brady Eidson.

Source/WebCore:

Test: fast/forms/state-restore-hidden.html

  • html/HiddenInputType.cpp: Teach hidden inputs to save and restore their state.

(WebCore::HiddenInputType::saveFormControlState):
(WebCore::HiddenInputType::restoreFormControlState):

  • html/HiddenInputType.h:

(HiddenInputType):

LayoutTests:

The test changes the value of the hidden input element via Javascript prior to
submitting the form. The form action goes back one page, and we check to see
that the hidden input value is what it was set to by Javascript, rather than what
it was originally assigned.

  • fast/forms/state-restore-hidden-expected.txt: Added.
  • fast/forms/state-restore-hidden.html: Added.
1:39 PM Changeset in webkit [106387] by jsbell@chromium.org
  • 6 edits in trunk

IndexedDB: IDBCursor.update() should raise exception if key changed
​https://bugs.webkit.org/show_bug.cgi?id=76952

Source/WebCore:

Move the test from the async task to the synchronous call, per spec. Also re-ordered the tests
done during the synchronous call and the asynchronous task to follow the spec order.

Reviewed by Tony Chang.

Tests: storage/indexeddb/cursor-update.html

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put): Added check during update() call, order checks per spec.
(WebCore::IDBObjectStoreBackendImpl::putInternal): Move effective key calculation inline.

  • storage/IDBObjectStoreBackendImpl.h: Removed selectKeyForPut method.

LayoutTests:

Reviewed by Tony Chang.

  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/cursor-update.html:
1:35 PM Changeset in webkit [106386] by rniwa@webkit.org
  • 21 edits in trunk/PerformanceTests

PerfTestRunner should automatically create pre#log
​https://bugs.webkit.org/show_bug.cgi?id=77469

Reviewed by Tony Chang.

Automatically generate <pre id="log"></pre> if there isn't one.

  • Bindings/event-target-wrapper.html:
  • DOM/Accessors.html:
  • DOM/CloneNodes.html:
  • DOM/CreateNodes.html:
  • DOM/DOMDivWalk.html:
  • DOM/DOMTable.html:
  • DOM/DOMWalk.html:
  • DOM/Events.html:
  • DOM/GetElement.html:
  • DOM/GridSort.html:
  • DOM/Template.html:
  • Dromaeo/dom-query.html:
  • Dromaeo/resources/dromaeorunner.js:
  • Parser/html-parser.html:
  • Parser/html5-full-render.html:
  • Parser/simple-url.html:
  • Parser/tiny-innerHTML.html:
  • Parser/url-parser.html:
  • Parser/xml-parser.html:
  • resources/runner.js:

(PerfTestRunner.log):
(PerfTestRunner.printStatistics):

1:31 PM Changeset in webkit [106385] by andersca@apple.com
  • 12 edits in trunk/Source/WebCore

Inform the tile cache whenever the visible rect changes
​https://bugs.webkit.org/show_bug.cgi?id=77470

Reviewed by Andreas Kling.

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::visibleRectChanged):
Add empty function.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::visibleRectChanged):
Call through to the PlatformCALayer.

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::visibleRectChanged):
Call through to the underlying WebTileCacheLayer.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::visibleRectChanged):
Add empty stub.

(WebCore::TileCache::visibleRect):
Add new (currently unused) helper function that returns the visible rect of the
tile cache layer.

  • platform/graphics/ca/mac/WebTileCacheLayer.h:
  • platform/graphics/ca/mac/WebTileCacheLayer.mm:

(-[WebTileCacheLayer visibleRectChanged]):
Call through to the TielCache object.

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::visibleRectChanged):
Add stub.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidScroll):
Call GraphicsLayer::visibleRectChanged.

1:24 PM Changeset in webkit [106384] by Antti Koivisto
  • 6 edits in trunk/Source/WebCore

Remove CSSStyleDeclaration isElementStyleDeclaration bit
​https://bugs.webkit.org/show_bug.cgi?id=77460

Reviewed by Andreas Kling.

Inline style declaration is now the only type of style declaration with element parent.
We can remove the bit and the associated logic.

  • bindings/js/JSDOMBinding.h:

(WebCore::root):

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):

  • css/CSSMutableStyleDeclaration.h:

(WebCore::CSSMutableStyleDeclaration::createInline):
(CSSMutableStyleDeclaration):

  • css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
(WebCore):
(WebCore::CSSStyleDeclaration::parentStyleSheet):

  • css/CSSStyleDeclaration.h:

(WebCore::CSSStyleDeclaration::parentRule):
(WebCore::CSSStyleDeclaration::clearParentRule):
(WebCore::CSSStyleDeclaration::parentElement):
(WebCore::CSSStyleDeclaration::clearParentElement):
(CSSStyleDeclaration):

1:15 PM Changeset in webkit [106383] by commit-queue@webkit.org
  • 22 edits in trunk/Source

[chromium] Compute occlusion during paint loop
​https://bugs.webkit.org/show_bug.cgi?id=76858

Patch by Dana Jansens <​danakj@chromium.org> on 2012-01-31
Reviewed by James Robinson.

Source/WebCore:

New unit tests in TiledLayerChromiumTest.cpp, CCLayerTreeHostCommonTest.cpp, CCLayerTreeHostTest.cpp

  • platform/graphics/FloatRect.cpp:

(WebCore::enclosedIntRect):
(WebCore):

  • platform/graphics/FloatRect.h:

(WebCore):

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerChromium):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/ImageLayerChromium.h:

(ImageLayerChromium):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::contentToScreenSpaceTransform):
(WebCore):
(WebCore::LayerChromium::addSelfToOccludedScreenSpace):
(WebCore::LayerChromium::isPaintedAxisAlignedInScreen):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(WebCore::LayerChromium::paintContentsIfDirty):
(LayerChromium):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::addSelfToOccludedScreenSpace):

  • platform/graphics/chromium/TiledLayerChromium.h:

(WebCore):
():

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(RenderSurfaceRegion):
(WebCore):
(WebCore::pushTargetRenderSurfaceRegion):
(WebCore::popAndPushTargetRenderSurfaceRegion):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):
():

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):
(WebCore):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::ContentLayerChromiumWithUpdateTracking::paintContentsIfDirty):
(WTF):
(TestLayerChromium):
(WTF::TestLayerChromium::create):
(WTF::TestLayerChromium::paintContentsIfDirty):
(WTF::TestLayerChromium::drawsContent):
(WTF::TestLayerChromium::occludedScreenSpace):
(WTF::TestLayerChromium::clearOccludedScreenSpace):
(WTF::TestLayerChromium::TestLayerChromium):
(WTF::setLayerPropertiesForTesting):
(CCLayerTreeHostTestLayerOcclusion):
(WTF::CCLayerTreeHostTestLayerOcclusion::CCLayerTreeHostTestLayerOcclusion):
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusion::afterTest):

  • tests/Canvas2DLayerChromiumTest.cpp:

(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):

  • tests/TiledLayerChromiumTest.cpp:

(WTF::FakeLayerTextureUpdater::setOpaquePaintRect):
(FakeLayerTextureUpdater):
(WTF::FakeTiledLayerChromium::paintContentsIfDirty):
(WTF::FakeLayerTextureUpdater::prepareToUpdate):
(WTF::TEST):
(WTF):

1:02 PM Changeset in webkit [106382] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[Chromium] Add chromium-style tracing support
​https://bugs.webkit.org/show_bug.cgi?id=76885

Patch by John Bates <​jbates@google.com> on 2012-01-31
Reviewed by Darin Fisher.

This code enables WebKit trace events to pass through more data to the
chromium platform tracing API and generally to use the full tracing
API provided by chromium.

Source/WebCore:

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::evaluate): Replace old tracing API.

  • page/Console.cpp:

(WebCore::Console::time): Replace old tracing API.
(WebCore::Console::timeEnd): Replace old tracing API.

  • platform/chromium/PlatformSupport.h:
  • platform/chromium/TraceEvent.h:

(WebCore::TraceEvent::TraceID::TraceID):
(WebCore::TraceEvent::TraceID::data):
(WebCore::TraceEvent::TraceStringWithCopy::TraceStringWithCopy):
(WebCore::TraceEvent::TraceStringWithCopy::operator const char* ):
(WebCore::TraceEvent::setTraceValue):
(WebCore::TraceEvent::addTraceEvent):
(WebCore::TraceEvent::TraceEndOnScopeClose::TraceEndOnScopeClose):
(WebCore::TraceEvent::TraceEndOnScopeClose::~TraceEndOnScopeClose):
(WebCore::TraceEvent::TraceEndOnScopeClose::initialize):
(WebCore::TraceEvent::TraceEndOnScopeClose::addEventIfEnabled):
(WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::TraceEndOnScopeCloseThreshold):
(WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::~TraceEndOnScopeCloseThreshold):
(WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::initialize):
(WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::addEventIfEnabled):

Source/WebKit/chromium:

  • public/platform/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::getTraceCategoryEnabledFlag):
(WebKit::WebKitPlatformSupport::addTraceEvent):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::getTraceCategoryEnabledFlag):
(WebCore::PlatformSupport::addTraceEvent):

12:49 PM Changeset in webkit [106381] by piman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Add back temporarily WebKitPlatformSupport::createGraphicsContext3D() to fix build
​https://bugs.webkit.org/show_bug.cgi?id=77467

Rubber-stamped by Nate Chapin <Nate Chapin>.

  • public/platform/WebKitPlatformSupport.h:

(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::createGraphicsContext3D):

12:41 PM Changeset in webkit [106380] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Source/WebCore: Crash in DeleteSelectionCommand::handleGeneralDelete when attempting to delete the start block
​https://bugs.webkit.org/show_bug.cgi?id=77077

Reviewed by Enrica Casucci.

The crash was caused by a missing null check after removing the position out of the start block.
Fixed the bug by adding an early return.

Tests: editing/deleting/delete-start-block.html

editing/selection/move-into-empty-root-inline-box.html

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::handleGeneralDelete):

LayoutTests: Crash in previousLinePosition when moving into a root inline box without leaves
​https://bugs.webkit.org/show_bug.cgi?id=76812

Reviewed by Enrica Casucci.

Add a regression test for the crash. Unfortunately, we can only test previousLinePosition.

  • editing/selection/move-into-empty-root-inline-box-expected.txt: Added.
  • editing/selection/move-into-empty-root-inline-box.html: Added.
12:05 PM Changeset in webkit [106379] by rniwa@webkit.org
  • 17 edits in trunk/PerformanceTests

runner.js in performance tests should define a class
​https://bugs.webkit.org/show_bug.cgi?id=77074

Reviewed by Eric Seidel.

Wrap all functions in runner.js by PerfTestRunner and update tests that runner.js accordingly.
Also replace compute* functions in runner.js by more robust code from dom-perf.js.

  • Bindings/event-target-wrapper.html:
  • DOM/DOMTable.html:
  • DOM/resources/dom-perf.js:

(BenchmarkSuite.prototype.RunSingle):
(runBenchmarkSuite):

  • Mutation/append-child-deep.html:
  • Mutation/append-child.html:
  • Mutation/inner-html.html:
  • Mutation/remove-child-deep.html:
  • Mutation/remove-child.html:
  • Parser/html-parser.html:
  • Parser/html5-full-render.html:
  • Parser/simple-url.html:
  • Parser/tiny-innerHTML.html:
  • Parser/url-parser.html:
  • Parser/xml-parser.html:
  • resources/runner.js:

(PerfTestRunner.log):
(PerfTestRunner.logInfo):
(PerfTestRunner.loadFile):
(PerfTestRunner.computeStatistics):
(PerfTestRunner.logStatistics):
(PerfTestRunner._runLoop.else):
(PerfTestRunner._runLoop):
(PerfTestRunner._runner):

12:05 PM Changeset in webkit [106378] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

[chromium] Fix css3/flexbox/cross-axis-scrollbar-expected to work on
chromium win.

The scrollbars overflow the bounds of the scrollbar rect (see bug 77368).
Work around this by using positioned elements and setting the z-index as
negative. It didn't work previously because when the scrollbar was
positioned, it clipped the extra pixels. Tested to verify that this works
on Chromium Win and Chromium Linux.

Unreviewed, test fix.

  • css3/flexbox/cross-axis-scrollbar-expected.html:
  • platform/chromium/test_expectations.txt:
12:00 PM Changeset in webkit [106377] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLIsIndexElement should not expose HTMLInputElement properties
​https://bugs.webkit.org/show_bug.cgi?id=76095

Patch by Rafael Brandao <​rafael.lobo@openbossa.org> on 2012-01-31
Reviewed by Eric Seidel.

This is a buildfix for r106373.

  • DerivedSources.pri: Removed reference to HTMLIsIndexElement.idl
12:00 PM Changeset in webkit [106376] by commit-queue@webkit.org
  • 3 edits in trunk

WebGL must allocate smaller drawing buffer when the allocation fails.
​https://bugs.webkit.org/show_bug.cgi?id=76654

Patch by Yongsheng Zhu <​yongsheng.zhu@intel.com> on 2012-01-31
Reviewed by Kenneth Russell.

Test: fast/canvas/webgl/drawingbuffer-test.html

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore):
(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::reset):

11:58 AM Changeset in webkit [106375] by ap@apple.com
  • 2 edits
    2 adds in trunk/Source/WebKit2

PluginProcess should be able to use remote open and save panels
​https://bugs.webkit.org/show_bug.cgi?id=77461
<rdar://problem/10783615>

Reviewed by Mark Rowe.

  • PluginProcess/mac/PluginProcess.entitlements: Added.
  • PluginProcess/mac/add-entitlements.sh: Added.
  • WebKit2.xcodeproj/project.pbxproj: Add appropriate entitlement, plus ad hoc binary signing for it to work.
11:50 AM Changeset in webkit [106374] by eae@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/platform/qt

Fix scrollbar painting on qt (again).

11:33 AM Changeset in webkit [106373] by eric@webkit.org
  • 43 edits
    5 adds
    3 deletes in trunk

HTMLIsIndexElement should not expose HTMLInputElement properties
​https://bugs.webkit.org/show_bug.cgi?id=76095

Reviewed by Adam Barth.

Source/WebCore:

document.createElement("isindex") should produce an HTMLUnknownElement
per the HTML5 spec. The parser automagically translates <isindex> into
a whole dom tree roughly representing what <isindex> used to do 15 years ago. :)

This patch just removes our support for HTMLIsIndexElement. The parser
support was already in. Having support for HTMLIsIndexElement was causing
one of the IE TestCenter tests to fail.

Test: fast/dom/HTMLIsIndexElement/prototype-chain.html

  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:
  • bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:

(WebKit::createHTMLElementWrapper):

  • bindings/objc/DOM.mm:

(WebCore::createElementClassMap):

  • bindings/objc/DOMHTML.h:
  • bindings/objc/PublicDOMInterfaces.h:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLIsIndexElement.cpp: Removed.
  • html/HTMLIsIndexElement.h: Removed.
  • html/HTMLIsIndexElement.idl: Removed.
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:

Source/WebKit/mac:

  • MigrateHeaders.make:

LayoutTests:

  • fast/dom/HTMLIsIndexElement/prototype-chain-expected.txt: Added.
  • fast/dom/HTMLIsIndexElement/prototype-chain.html: Added.
  • fast/dom/HTMLIsIndexElement/script-tests/prototype-chain.js: Added.
11:13 AM Changeset in webkit [106372] by commit-queue@webkit.org
  • 5 edits
    1 copy
    5 moves
    3 adds in trunk/LayoutTests

[Qt] Use ICU if available
​https://bugs.webkit.org/show_bug.cgi?id=76821

Patch by Rafael Brandao <​rafael.lobo@openbossa.org> on 2012-01-31
Reviewed by Csaba Osztrogonác.

After r105997, some tests had different expected results but they were passing
like /fast/text/find-{kana|russian|soft-hyphen}.html and editing/execCommand/findString-diacriticals.html.
The test editing/selection/regional-indicators.html had a false expected file,
and the rest was moved to a more specific folder (i.e. some bugs skipped on qt5 and qt-wk2
didn't need to be on qt-wk2 as well, etc.) and/or created specific bugs for further investigation.

  • platform/qt-4.8/Skipped:
  • platform/qt-4.8/css1/text_properties/text_transform-expected.txt: Copied from LayoutTests/platform/qt/css1/text_properties/text_transform-expected.txt.
  • platform/qt-4.8/editing/selection/regional-indicators-expected.txt: Renamed from LayoutTests/platform/qt/editing/selection/regional-indicators-expected.txt.
  • platform/qt-4.8/fast/text/find-kana-expected.txt: Renamed from LayoutTests/platform/qt/fast/text/find-kana-expected.txt.
  • platform/qt-4.8/fast/text/find-russian-expected.txt: Renamed from LayoutTests/platform/qt/fast/text/find-russian-expected.txt.
  • platform/qt-4.8/fast/text/find-soft-hyphen-expected.txt: Renamed from LayoutTests/platform/qt/fast/text/find-soft-hyphen-expected.txt.
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/css1/text_properties/text_transform-expected.txt: Renamed from LayoutTests/platform/qt/css1/text_properties/text_transform-expected.txt.
  • platform/qt-5.0/editing/execCommand/findString-diacriticals-expected.txt: Added.
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
11:11 AM Changeset in webkit [106371] by piman@chromium.org
  • 10 edits in trunk

Merge WebGraphicsContext3D creation and initialization, and move it to
WebViewClient.
​https://bugs.webkit.org/show_bug.cgi?id=76593

Reviewed by Darin Fisher.

Source/WebKit/chromium:

  • public/WebViewClient.h:

(WebKit::WebViewClient::createGraphicsContext3D):

  • public/platform/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::initialize):

  • public/platform/WebKitPlatformSupport.h:
  • src/GraphicsContext3DChromium.cpp:

Tools:

  • DumpRenderTree/chromium/TestWebPlugin.cpp:

(TestWebPlugin::TestWebPlugin):
(TestWebPlugin::initialize):

  • DumpRenderTree/chromium/TestWebPlugin.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createGraphicsContext3D):
(WebViewHost::createPlugin):

  • DumpRenderTree/chromium/WebViewHost.h:
11:07 AM Changeset in webkit [106370] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ASSERT(m_jumpsToLink.isEmpty()) failing in ARMv7Assembler dtor
​https://bugs.webkit.org/show_bug.cgi?id=77443

Reviewed by Gavin Barraclough.

Removed failing ASSERT() and thus destructor. The ASSERT isn't needed.
We are hitting it in the YARR JIT case where we bail out and go to the
interpreter with a partially JIT'ed function. Since we haven't linked
the JIT'ed code, there is likely to be some unresolved jumps in the vector
when the ARMv7Assembler destructor is called. For the case where we
complete the JIT process, we clear the vector at the end of
LinkBuffer::linkCode (LinkBuffer.h:292).

  • assembler/ARMv7Assembler.h:

(ARMv7Assembler):

11:00 AM Changeset in webkit [106369] by rgabor@webkit.org
  • 2 edits in trunk/Tools

[GTK] build-webkit warning.
​https://bugs.webkit.org/show_bug.cgi?id=77411

Reviewed by Philippe Normand.

  • Scripts/webkitdirs.pm:

(isCrossCompilation):

10:06 AM Changeset in webkit [106368] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Vector<T>::operator== shouldn't require T to have operator!=
​https://bugs.webkit.org/show_bug.cgi?id=77448

Reviewed by Andreas Kling.

Change VectorComparer::compare to use !(a == b) instead of a != b since
it makes more sense for Vector::operator== to use the element's operator==.

  • wtf/Vector.h:
9:40 AM Changeset in webkit [106367] by kareng@chromium.org
  • 1 add in branches/chromium/1025/codereview.settings

adding codereview.settings

9:39 AM Changeset in webkit [106366] by mitz@apple.com
  • 2 edits in trunk/Tools

When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.

Reviewed by Anders Carlsson.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
9:39 AM Changeset in webkit [106365] by kareng@chromium.org
  • 1 copy in branches/chromium/1025

branching for chrome m18

9:29 AM Changeset in webkit [106364] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

Unreviewed include cleanup.

Tested locally on Qt and Chromium port.

  • dom/Node.cpp:
9:11 AM Changeset in webkit [106363] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

If the QTDIR environment variable is set, the build system fails to compile WinCairo
​https://bugs.webkit.org/show_bug.cgi?id=77112

Reviewed by Daniel Bates.

  • Scripts/webkitdirs.pm:

(determineIsQt):

9:09 AM Changeset in webkit [106362] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

Ensure tiles are repainted when scrolling using mouse wheel.
​https://bugs.webkit.org/show_bug.cgi?id=77339

A new slot visibleContentRectAndScaleChanged has been added
that is emited by non-animated scrolling code in the
QtViewportInteractionEngine.

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-01-31
Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initializeDesktop):
(QQuickWebViewPrivate::initializeTouch):
(QQuickWebViewPrivate::_q_resume):
(QQuickWebViewPrivate::_q_updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::updateTouchViewportSize):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::wheelEvent):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

8:44 AM Changeset in webkit [106361] by commit-queue@webkit.org
  • 14 edits in trunk

The spec renamed addTrack() to addTextTrack().
​https://bugs.webkit.org/show_bug.cgi?id=77381

Patch by Arko Saha <​arko@motorola.com> on 2012-01-31
Reviewed by Eric Carlson.

Renamed addTrack() to addTextTrack().
Spec: ​http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#media-elements

Source/WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::addTextTrack):

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::addTextTrack):

  • html/HTMLMediaElement.idl:

LayoutTests:

  • media/track/track-add-track-expected.txt:
  • media/track/track-add-track.html:
  • media/track/track-addtrack-kind-expected.txt:
  • media/track/track-addtrack-kind.html:
  • media/track/track-text-track-destructor-crash.html:
  • media/track/track-texttracks-expected.txt:
  • media/track/track-texttracks.html:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
7:56 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
7:35 AM Changeset in webkit [106360] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: reimplement generated array types
​https://bugs.webkit.org/show_bug.cgi?id=77289

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-01-31
Reviewed by Vsevolod Vlasov.

Arrays are now rendered as a single template class. Its type-specific
details are provided by an additional ArrayItemHelper class that is
defined using C++ specialization technique.

  • inspector/CodeGeneratorInspector.py:

(RawTypes.String):
(RawTypes.String.get_array_item_raw_c_type_text):
(RawTypes.Int):
(RawTypes.Int.get_array_item_raw_c_type_text):
(RawTypes.Number):
(RawTypes.Number.get_array_item_raw_c_type_text):
(RawTypes.Bool):
(RawTypes.Bool.get_array_item_raw_c_type_text):
(RawTypes.Object):
(RawTypes.Object.get_array_item_raw_c_type_text):
(RawTypes.Any):
(RawTypes.Any.get_array_item_raw_c_type_text):
(RawTypes.Array):
(RawTypes.Array.get_array_item_raw_c_type_text):
(RawTypes):
(TypeBindings.create_type_declaration_.EnumBinding):
(TypeBindings.create_type_declaration_.EnumBinding.get_array_item_c_type_text):
(TypeBindings.create_type_declaration_.PlainString):
(TypeBindings.create_type_declaration_.PlainString.get_array_item_c_type_text):
(TypeBindings.create_type_declaration_.TypedefString):
(TypeBindings.create_type_declaration_.TypedefString.get_array_item_c_type_text):
(StructItemTraits):
(get_array_item_c_type_text):
(PlainObjectBinding):
(PlainObjectBinding.get_array_item_c_type_text):
(AdHocTypeContext):
(AdHocTypeContext.get_type_name_fix):
(AdHocTypeContext.add_type):
(ArrayBinding):
(ArrayBinding.resolve_inner):
(ArrayBinding.resolve_inner.ResolveData):
(ArrayBinding.request_user_runtime_cast):
(ArrayBinding.request_internal_runtime_cast):
(ArrayBinding.get_code_generator):
(ArrayBinding.get_code_generator.CodeGenerator):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder):
(ArrayBinding.get_code_generator.CodeGenerator.generate_forward_declaration):
(ArrayBinding.get_code_generator.CodeGenerator.register_use):
(ArrayBinding.get_code_generator.CodeGenerator.get_generate_pass_id):
(ArrayBinding.get_validator_call_text):
(ArrayBinding.get_in_c_type_text):
(ArrayBinding.get_array_item_c_type_text):
(ArrayBinding.get_setter_value_expression_pattern):
(ArrayBinding.reduce_to_raw_type):
(RawTypeBinding.get_array_item_c_type_text):
(ArrayItemHelper):
(typename):
(ArrayOf):
(Traits):

7:09 AM Changeset in webkit [106359] by Adam Roben
  • 2 edits in trunk/Tools

Only call -typingAttributes on WebViews, not WebHTMLViews

Looks like this case was just missed in r105908.

Fixes <​http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing

Reviewed by Antti Koivisto.

  • TestWebKitAPI/Tests/mac/InspectorBar.mm:

(TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
earlier.

6:58 AM Changeset in webkit [106358] by Antti Koivisto
  • 5 edits in trunk/Source/WebCore

Parent SVGFontFaceElements style declaration to the rule
​https://bugs.webkit.org/show_bug.cgi?id=77421

Reviewed by Adam Roben.

For some reason the declaration is parented to the element which adds a bunch of unnecessary special case code.
The invalidation on mutation is done explicitly by SVGFontFaceElement so that is not affected. The declaration
is not exposed so the change is not observable with a test.

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::~CSSFontFaceRule):

  • css/CSSMutableStyleDeclaration.h:

(WebCore::CSSMutableStyleDeclaration::createInline):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::SVGFontFaceElement):
(WebCore::SVGFontFaceElement::parseMappedAttribute):
(WebCore::SVGFontFaceElement::fontFamily):
(WebCore::SVGFontFaceElement::rebuildFontFace):

  • svg/SVGFontFaceElement.h:


Remove the unnecessary m_styleDeclaration field, access through m_fontFaceRule instead.

6:28 AM Changeset in webkit [106357] by kenneth@webkit.org
  • 5 edits in trunk

Tap highlighting: Support better outlines for multiline inlines ​https://bugs.webkit.org/show_bug.cgi?id=77428

Reviewed by Simon Hausmann.

.:

Update the test to use a transform.

  • ManualTests/qt/tap-highlighting-inlines.html:

Source/WebCore:

Covered by manual tests.

Do not use the linesBoundingBox anymore but draw a custom path
with rounded corners. Inlines are drawn as max 3 rects, first
line rect, joined middle rect and the rect for the last line.

  • page/GestureTapHighlighter.cpp:
  • platform/graphics/Path.h: Make addBeziersForRoundedRect public.
6:03 AM Changeset in webkit [106356] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Tools

[Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
​https://bugs.webkit.org/show_bug.cgi?id=77221

Reviewed by Kenneth Rohde Christiansen.

This makes sure that the indicator isn't in the way when doing clicks or dealing with the rest of the UI.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::sendTouchEvent):

5:47 AM Changeset in webkit [106355] by zeno.albisser@nokia.com
  • 5 edits in trunk/Source/WebKit2

[Qt][WK2] Make UIProcess decide about encoding of input data for application URL schemes.
​https://bugs.webkit.org/show_bug.cgi?id=77417

Make the UIProcess decide about the encoding and display
a warning in case no encoding was defined.
Make the QQuickNetworkReply store a QWeakPointer to the
QQuickWebViewExperimental to get rid of hackish chain of parental queries.

Reviewed by Simon Hausmann.

  • UIProcess/API/qt/qquicknetworkreply.cpp:

(QQuickNetworkReply::send):
(QQuickNetworkReply::setWebViewExperimental):

  • UIProcess/API/qt/qquicknetworkreply_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewExperimental::schemeDelegates_Append):

  • WebProcess/qt/QtNetworkReply.cpp:

(WebKit::QtNetworkReply::QtNetworkReply):
(WebKit::QtNetworkReply::setReplyData):

4:11 AM Changeset in webkit [106354] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: show sizes in bytes instead of KB, MB in heap profiler.
​https://bugs.webkit.org/show_bug.cgi?id=77199

Patch by Alexei Filippov <​alexeif@chromium.org> on 2012-01-31
Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotInstanceNode.prototype._enhanceData):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):
(WebInspector.HeapSnapshotDiffNode.prototype.get data):

  • inspector/front-end/UIUtils.js:

(Number.withThousandsSeparator):

3:59 AM Changeset in webkit [106353] by hans@chromium.org
  • 17 edits
    2 adds
    5 deletes in trunk

Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
​https://bugs.webkit.org/show_bug.cgi?id=77083

Reviewed by Darin Fisher.

Source/WebCore:

Remove SpeechInputClientMock. The mock is moving to the DumpRenderTree
implementation.

No new tests, just refactoring.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mock/SpeechInputClientMock.cpp: Removed.
  • platform/mock/SpeechInputClientMock.h: Removed.

Source/WebKit/chromium:

Remove the WebSpeechInputControllerMock interface and proxy
implementation. The mock is moving to the DumpRenderTree
implementation instead, which removes the need to expose this
interface in the WebKit API.

Also add a proper copy constructor for WebSpeechInputResult.
The default one doesn't do a proper copy.

  • WebKit.gyp:
  • public/WebSpeechInputControllerMock.h: Removed.
  • public/WebSpeechInputResult.h:

(WebKit::WebSpeechInputResult::WebSpeechInputResult):
(WebSpeechInputResult):

  • src/WebSpeechInputControllerMockImpl.cpp: Removed.
  • src/WebSpeechInputControllerMockImpl.h: Removed.
  • src/WebSpeechInputResult.cpp:

(WebKit::WebSpeechInputResult::set):
(WebKit):

Tools:

Add MockWebSpeechInputController which provides a mock implementation
of the WebSpeechInputController interface, and use that in
DumpRenderTree.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::addMockSpeechInputResult):

  • DumpRenderTree/chromium/LayoutTestController.h:

():

  • DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.

(MockWebSpeechInputController::create):
(MockWebSpeechInputController::addMockRecognitionResult):
(MockWebSpeechInputController::clearResults):
(MockWebSpeechInputController::startRecognition):
(MockWebSpeechInputController::cancelRecognition):
(MockWebSpeechInputController::stopRecording):
(MockWebSpeechInputController::MockWebSpeechInputController):
(MockWebSpeechInputController::speechTaskFired):
(MockWebSpeechInputController::SpeechTask::SpeechTask):
(MockWebSpeechInputController::SpeechTask::stop):
(MockWebSpeechInputController::SpeechTask::runIfValid):

  • DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.

(WebKit):
(MockWebSpeechInputController):
(MockWebSpeechInputController::taskList):
(SpeechTask):

  • DumpRenderTree/chromium/TestShell.cpp:
  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::speechInputController):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebKit):
(WebViewHost::speechInputControllerMock):
(WebViewHost):
():

3:49 AM Changeset in webkit [106352] by pfeldman@chromium.org
  • 2 edits
    1 copy in trunk/Source/WebCore

Web Inspector: boost protocol version to 1.0
​https://bugs.webkit.org/show_bug.cgi?id=77408

Reviewed by Yury Semikhatsky.

  • inspector/Inspector-1.0.json: Copied from Source/WebCore/inspector/Inspector.json.
  • inspector/Inspector.json:
3:04 AM Changeset in webkit [106351] by rolandsteiner@chromium.org
  • 3 edits in trunk/Source/WebCore

<style scoped>: Improve shortcut code for cases where <style scoped> isn't used
​https://bugs.webkit.org/show_bug.cgi?id=77410

Move shortcut from setupScopingElementStack(), do it at the calling sites instead
(where a larger chunk of work can be skipped).

Reviewed by Antti Koivisto.

No new tests. (refactoring)

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::setupScopingElementStack): remove shortcut code
(WebCore::CSSStyleSelector::pushParent): add shortcut code
(WebCore::CSSStyleSelector::matchScopedAuthorRules): factor matching scoped rules out from matchAuthorRules
(WebCore::CSSStyleSelector::matchAuthorRules): add shortcut code

  • css/CSSStyleSelector.h:

(CSSStyleSelector): add matchScopedAuthorRules

2:45 AM Changeset in webkit [106350] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-01-31

  • DEPS:
2:39 AM Changeset in webkit [106349] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectation change.
inspector/timeline/timeline-receive-response-event.html is flaky on LINUX

  • platform/chromium/test_expectations.txt:
2:13 AM Changeset in webkit [106348] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

[PerformanceTests] Add landing html for Dromaeo dom-query test
​https://bugs.webkit.org/show_bug.cgi?id=77329

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-01-31
Reviewed by Ryosuke Niwa.

PerformanceTests:

Added a "landing html" which includes actual dromaemo page and
send messages to interact with it. The landing html also dumps the
score in run-perf-tests friendly format.

This test isn't enabled until Dromaemo itself is available for run-perf-tests.
It will happen in a separate change.

  • Dromaeo/dom-query.html: Added.
  • Dromaeo/resources/dromaeorunner.js: Added.
  • Skipped: Skipping this for now.

Tools:

Added some more ignorable output patterns to allow warnings
from a third party test suite.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):
(PerfTestsRunner._should_ignore_line_in_parser_test_result):

2:05 AM Changeset in webkit [106347] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: DOMDebugger.setEventListenerBreakpoint should accept regular DOM event names.
​https://bugs.webkit.org/show_bug.cgi?id=77409

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint):
(WebCore):
(WebCore::InspectorDOMDebuggerAgent::setInstrumentationBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeInstrumentationBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):

  • inspector/InspectorDOMDebuggerAgent.h:

(InspectorDOMDebuggerAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didInstallTimerImpl):
(WebCore::InspectorInstrumentation::didRemoveTimerImpl):
(WebCore::InspectorInstrumentation::willHandleEventImpl):
(WebCore::InspectorInstrumentation::willFireTimerImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):

2:01 AM Changeset in webkit [106346] by nayankk@motorola.com
  • 3 edits in trunk

[GTK] Remove V8 compilation option.
​https://bugs.webkit.org/show_bug.cgi?id=77405

Reviewed by Philippe Normand.

Revert the changes introduced as part of bug 69469
to provide an option to compile V8 as JavaScript engine.

  • GNUmakefile.am: Remove defining USE_JSC macro.
  • configure.ac: Remove --with-jsengine option.
1:36 AM Changeset in webkit [106345] by Philippe Normand
  • 5 edits
    1 add in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/Skipped: Skipping some new failures.
  • platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Added.
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/gtk/test_expectations.txt: Marked one more svg test as flaky.
1:19 AM Changeset in webkit [106344] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectation change.
77412 - [Chromium] Layout Test media/media-blocked-by-beforeload.html fails for LEOPARD

  • platform/chromium/test_expectations.txt:
12:37 AM Changeset in webkit [106343] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

On more (last) typo fix after r106339.

  • platform/qt/Skipped:
12:22 AM Changeset in webkit [106342] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Fix compilation errors on build-webkit --debug --no-workers on mac.
​https://bugs.webkit.org/show_bug.cgi?id=75869

Patch by Pablo Flouret <​pablof@motorola.com> on 2012-01-31
Reviewed by Adam Barth.

Source/WebCore:

  • WebCore.exp.in:

Source/WebKit/mac:

  • Workers/WebWorkersPrivate.mm:

(+[WebWorkersPrivate workerThreadCount]):

12:04 AM Changeset in webkit [106341] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Typo fix after r106339.

  • platform/qt/Skipped:
12:02 AM Changeset in webkit [106340] by Philippe Normand
  • 2 edits in trunk

[GStreamer] 0.11 build support
​https://bugs.webkit.org/show_bug.cgi?id=77085

Reviewed by Martin Robinson.

  • configure.ac: New --with-gstreamer option, defaulting to 0.10.
Note: See TracTimeline for information about the timeline view.